{"action":"created","issue":{"url":"https://api.github.com/repos/DWilliames/paddy2-beta/issues/60","repository_url":"https://api.github.com/repos/DWilliames/paddy2-beta","labels_url":"https://api.github.com/repos/DWilliames/paddy2-beta/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/DWilliames/paddy2-beta/issues/60/comments","events_url":"https://api.github.com/repos/DWilliames/paddy2-beta/issues/60/events","html_url":"https://github.com/DWilliames/paddy2-beta/issues/60","id":344884312,"node_id":"MDU6SXNzdWUzNDQ4ODQzMTI=","number":60,"title":"Feature request: Allow padding on groups, not require extra layer with padding","user":{"login":"dlewand691","id":1159913,"node_id":"MDQ6VXNlcjExNTk5MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1159913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlewand691","html_url":"https://github.com/dlewand691","followers_url":"https://api.github.com/users/dlewand691/followers","following_url":"https://api.github.com/users/dlewand691/following{/other_user}","gists_url":"https://api.github.com/users/dlewand691/gists{/gist_id}","starred_url":"https://api.github.com/users/dlewand691/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlewand691/subscriptions","organizations_url":"https://api.github.com/users/dlewand691/orgs","repos_url":"https://api.github.com/users/dlewand691/repos","events_url":"https://api.github.com/users/dlewand691/events{/privacy}","received_events_url":"https://api.github.com/users/dlewand691/received_events","type":"User","site_admin":false},"labels":[{"id":999550233,"node_id":"MDU6TGFiZWw5OTk1NTAyMzM=","url":"https://api.github.com/repos/DWilliames/paddy2-beta/labels/waiting%20for%20follow%20up","name":"waiting for follow up","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-07-26T15:05:44Z","updated_at":"2018-08-09T00:08:02Z","closed_at":null,"author_association":"NONE","body":"I'm working through some issues with our design system and thought I'd share an idea/request...\r\n\r\nCurrently, to use padding, it requires an extra layer inside of a group that has the padding applied to it. Fine, works great for buttons and such. \r\n\r\nBut...if you have something more complicated like a card design with an image, a headline, some body copy, etc. it would be great to be able to add padding directly to the group of layers instead of requiring the extra \"padding layer\". \r\n\r\nThe benefits would be less layer complexity and easier to maintain. Thoughts? Hope I'm explaining this clearly, was confusing myself earlier with which layers needed padding/stacking/etc.\r\n\r\n![cleanshot 2018-07-26 at 10 58 01](https://user-images.githubusercontent.com/1159913/43270647-98296568-90c3-11e8-852f-32b9fc8ed44c.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/DWilliames/paddy2-beta/issues/comments/411593896","html_url":"https://github.com/DWilliames/paddy2-beta/issues/60#issuecomment-411593896","issue_url":"https://api.github.com/repos/DWilliames/paddy2-beta/issues/60","id":411593896,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTU5Mzg5Ng==","user":{"login":"richardsison","id":587608,"node_id":"MDQ6VXNlcjU4NzYwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/587608?v=4","gravatar_id":"","url":"https://api.github.com/users/richardsison","html_url":"https://github.com/richardsison","followers_url":"https://api.github.com/users/richardsison/followers","following_url":"https://api.github.com/users/richardsison/following{/other_user}","gists_url":"https://api.github.com/users/richardsison/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsison/subscriptions","organizations_url":"https://api.github.com/users/richardsison/orgs","repos_url":"https://api.github.com/users/richardsison/repos","events_url":"https://api.github.com/users/richardsison/events{/privacy}","received_events_url":"https://api.github.com/users/richardsison/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T00:08:02Z","updated_at":"2018-08-09T00:08:02Z","author_association":"NONE","body":"@dlewand691 Just saw this now mate! I have two recommendations:\r\n\r\nIn both cases you need an invisible frame to prevent touching the bottom of the group. Currently Paddy can't have padding and \"align to bottom\" at the same time. I thought it could. I've also grouped all of the \"container\" elements into a symbol — not necessary, but felt it was cleaner.\r\n\r\nAnyway… In the file you'll see an object called \"Frame [20 0]\". That provides the same functionality as padding a div in CSS with the benefit of using positive numbers (fully appreciate your desire to pad groups directly though…).\r\n\r\nThe difference between two options is the approach to the text box for the title. I assume what you're trying to do is have the \"content\" fixed to the bottom, while respecting the desired padding (so it's not touching the edges).\r\n\r\nA bit of Sketch Text box behaviour…\r\n\r\nA default behaviour with Sketch textboxes is if you resize the WIDTH ONLY, the height will **automatically resize** itself based off the content — that's what you want. **BUT** if you resize the **height**, it tells Sketch that you don't want it to resize the height automatically anymore. (which is fine sometimes too).\r\n\r\nThe weird thing is you if you _change_ the height (so the height is fixed), you cannot convert the textbox into a \"flexible height textbox\" anymore via Sketch. You _need_ a plugin (I use Automate Sketch > Resize to Fix Text Height).\r\n\r\nAlright. Here are the options:\r\n\r\n1. As long as you just resize the text box width, this will technically work fine. Paddy distributes the objects properly, and the text box will resize based off its content automatically. Just don't change the height.\r\n\r\nThe problem with this one is that because everything is pushed from the top-left, Paddy will the resize everything based off that anchor (pushing the entire component down (except the objects that are ignored). I'd actually recommend the following option.\r\n\r\n2. The simple workaround is to define a textbox height that is safely going to cater for the maximum character count. And then set the textbox alignment to bottom (https://d.pr/i/9p3Ja7)\r\n\r\nDownload file: https://d.pr/f/oFkoRQ\r\n\r\n… Hope that made sense and helped!"}}
{"actor":{"display_login":"richardsison"}}