{"action":"created","issue":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/177","repository_url":"https://api.github.com/repos/aws/sagemaker-python-sdk","labels_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/177/labels{/name}","comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/177/comments","events_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/177/events","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/177","id":321749878,"number":177,"title":"Save training output files in local mode","user":{"login":"yangaws","id":31293788,"avatar_url":"https://avatars3.githubusercontent.com/u/31293788?v=4","gravatar_id":"","url":"https://api.github.com/users/yangaws","html_url":"https://github.com/yangaws","followers_url":"https://api.github.com/users/yangaws/followers","following_url":"https://api.github.com/users/yangaws/following{/other_user}","gists_url":"https://api.github.com/users/yangaws/gists{/gist_id}","starred_url":"https://api.github.com/users/yangaws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangaws/subscriptions","organizations_url":"https://api.github.com/users/yangaws/orgs","repos_url":"https://api.github.com/users/yangaws/repos","events_url":"https://api.github.com/users/yangaws/events{/privacy}","received_events_url":"https://api.github.com/users/yangaws/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-09T22:37:42Z","updated_at":"2018-05-09T22:42:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/177","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/177","diff_url":"https://github.com/aws/sagemaker-python-sdk/pull/177.diff","patch_url":"https://github.com/aws/sagemaker-python-sdk/pull/177.patch"},"body":"*Issue #, if available:*\r\n\r\n*Description of changes:*\r\nSave training output files in local mode. The files will be copied out of Algo-* folder as well as model file. \r\n\r\nNow the training artifacts are all in folder S3_Artifacts. The structure looks like:\r\n\r\nS3_Artifacts/\r\n  model/\r\n    files and subdirectories related to model\r\n  output/\r\n    files and subdirectories related to output\r\n\r\nUnit tests are also updated.\r\n\r\n\r\n## Merge Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request._\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md) doc\r\n- [x] I have added tests that prove my fix is effective or that my feature works (if appropriate)\r\n- [x] I have updated the [changelog](https://github.com/aws/sagemaker-python-sdk/blob/master/CHANGELOG.rst) with a description of my changes (if appropriate)\r\n- [ ] I have updated any necessary [documentation](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) (if appropriate)\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n"},"comment":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/comments/387896973","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/177#issuecomment-387896973","issue_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/177","id":387896973,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-05-09T22:42:00Z","updated_at":"2018-05-09T22:42:00Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/177?src=pr&el=h1) Report\n> Merging [#177](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/177?src=pr&el=desc) into [master](https://codecov.io/gh/aws/sagemaker-python-sdk/commit/d2f018e1868420db5c0a451cd58af7c2936c70d5?src=pr&el=desc) will **increase** coverage by `0.02%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/177/graphs/tree.svg?token=2snJKHzl2x&src=pr&height=150&width=650)](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/177?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #177      +/-   ##\n==========================================\n+ Coverage   90.63%   90.66%   +0.02%     \n==========================================\n  Files          37       37              \n  Lines        2478     2484       +6     \n==========================================\n+ Hits         2246     2252       +6     \n  Misses        232      232\n```\n\n\n| [Impacted Files](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/177?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/sagemaker/local/image.py](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/177/diff?src=pr&el=tree#diff-c3JjL3NhZ2VtYWtlci9sb2NhbC9pbWFnZS5weQ==) | `87.68% <100%> (+0.27%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/177?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/177?src=pr&el=footer). Last update [d2f018e...713d5b2](https://codecov.io/gh/aws/sagemaker-python-sdk/pull/177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}