{"push_id":3128154677,"size":11,"distinct_size":1,"ref":"refs/heads/clean_code_lowpriority","head":"947a1c128980af427d52c218383bbf453fc06453","before":"f0117853c82e2e833172197c40d9335e7b8b5bb2","commits":[{"sha":"48596dd453ff521255fc25d1083a6009e972ef8b","author":{"name":"Kyle Palmquist","email":"447c4841df3cfe5ca2a28681a72163736dfb8dc4@yahoo.com"},"message":"Addressing part of issue #28\n\n- added checks so p_W_W values are not divided by 0, resulting in NaN (undefined). Instead they are set to 0.\n- removed unnecessary duplicate code\n- added additional comments","distinct":false,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/48596dd453ff521255fc25d1083a6009e972ef8b"},{"sha":"e0a29b5ad734f53759ebaa27c30c33a27f1cbf1e","author":{"name":"kpalmqui","email":"8fe940a4f6e6f2d7ee678844224017987a29fcd6"},"message":"Merge branch 'master' into markov_weatherbugs","distinct":false,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/e0a29b5ad734f53759ebaa27c30c33a27f1cbf1e"},{"sha":"71f01b4e0645f8d3dc3f0307d83bf38b0e3022c8","author":{"name":"Kyle Palmquist","email":"447c4841df3cfe5ca2a28681a72163736dfb8dc4@yahoo.com"},"message":"Merge branch 'master' into markov_weatherbugs","distinct":false,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/71f01b4e0645f8d3dc3f0307d83bf38b0e3022c8"},{"sha":"8d7f7bae48051a5f4a972b57816575ce1562bd3f","author":{"name":"Chandler Haukap","email":"f8aca26b7558d29b12f3db3165ed5f2500519367@uwyo.edu"},"message":"Corrected pWW > 1 (issue #31)\n\nsee issue #31 for extensive documentation.","distinct":false,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/8d7f7bae48051a5f4a972b57816575ce1562bd3f"},{"sha":"bdb118a2c9dbc2cc90861140aeb349974a89d63a","author":{"name":"Chandler Haukap","email":"f8aca26b7558d29b12f3db3165ed5f2500519367@uwyo.edu"},"message":"Changed implementation of PPT_avg to prevent NaN. (issue #28)\n\nThe mean(vector) function cannot be used to calculate the average since there is no guarantee that the vector will contain at least on element. Instead I use two sum() functions for PPT_cm and DOY. The bottom sum,\n```\nsum(DGF$DOY==i)\n```\nis guaranteed to be > 0 because every DOY is represented at least once.\n\nI also removed the check for NaN values since the issue is resolved.","distinct":false,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/bdb118a2c9dbc2cc90861140aeb349974a89d63a"},{"sha":"efd76d3bc9c11dbfdd231e3158bec4bf6131dec6","author":{"name":"kpalmqui","email":"8fe940a4f6e6f2d7ee678844224017987a29fcd6"},"message":"Merge branch 'master' into markov_weatherbugs","distinct":false,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/efd76d3bc9c11dbfdd231e3158bec4bf6131dec6"},{"sha":"5ff05761e528ec7c9532c5039b01f272c47dbcd6","author":{"name":"Chandler Haukap","email":"f8aca26b7558d29b12f3db3165ed5f2500519367@uwyo.edu"},"message":"Correcting calculation of ppt_avg (issue #28)\n\nIn the last commit related to issue #28 I changed how PPT_avg was calculated to avoid NaN values. However, the new implementation divided by the total number of years for that day, instead of the total number of WET days for that year. This error has been corrected with this commit.","distinct":false,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/5ff05761e528ec7c9532c5039b01f272c47dbcd6"},{"sha":"022621b80bb39a39f5b52e673f3bcb7649f9b83f","author":{"name":"Chandler Haukap","email":"f8aca26b7558d29b12f3db3165ed5f2500519367@uwyo.edu"},"message":"Preventing NaN value for PPT_avg (issue #28)\n\nA check has been added when calculating PPT_avg to avoid division by 0. Division by 0 occurs in the case where there has never been rainfall for the given DOY. This results in 0/0 which equals NaN. This check enures that the denominator is greater than 0. If it is not, PPT_avg defaults to 0.","distinct":false,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/022621b80bb39a39f5b52e673f3bcb7649f9b83f"},{"sha":"afe72c219a2bc867df7c00ed164fcbb6982112c7","author":{"name":"Chandler Haukap","email":"f8aca26b7558d29b12f3db3165ed5f2500519367@uwyo.edu"},"message":"Addressing issues in pull request #77\n\nFixed formatting issues and added comments.","distinct":false,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/afe72c219a2bc867df7c00ed164fcbb6982112c7"},{"sha":"4b6ee12743aca664f1e5ea68b9e61c2772fb8945","author":{"name":"Chandler Haukap","email":"d144033d9cc8f0048d7066faec1f26ae8a9538b5@users.noreply.github.com"},"message":"Merge pull request #77 from DrylandEcology/markov_weatherbugs\n\nMerge Markov weatherbugs into master","distinct":false,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/4b6ee12743aca664f1e5ea68b9e61c2772fb8945"},{"sha":"947a1c128980af427d52c218383bbf453fc06453","author":{"name":"Chandler Haukap","email":"f8aca26b7558d29b12f3db3165ed5f2500519367@uwyo.edu"},"message":"Merge branch 'clean_code_lowpriority'","distinct":true,"url":"https://api.github.com/repos/DrylandEcology/rSFSTEP2/commits/947a1c128980af427d52c218383bbf453fc06453"}]}
{"actor":{"display_login":"chaukap"}}