{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/12412","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/12412/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/12412/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/12412/events","html_url":"https://github.com/highfidelity/hifi/pull/12412","id":297567246,"number":12412,"title":"Introduce task abort feature for early exit of task branch","user":{"login":"samcake","id":2230265,"avatar_url":"https://avatars2.githubusercontent.com/u/2230265?v=4","gravatar_id":"","url":"https://api.github.com/users/samcake","html_url":"https://github.com/samcake","followers_url":"https://api.github.com/users/samcake/followers","following_url":"https://api.github.com/users/samcake/following{/other_user}","gists_url":"https://api.github.com/users/samcake/gists{/gist_id}","starred_url":"https://api.github.com/users/samcake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samcake/subscriptions","organizations_url":"https://api.github.com/users/samcake/orgs","repos_url":"https://api.github.com/users/samcake/repos","events_url":"https://api.github.com/users/samcake/events{/privacy}","received_events_url":"https://api.github.com/users/samcake/received_events","type":"User","site_admin":false},"labels":[{"id":675876856,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Engine","name":"Engine","color":"A2277C","default":false},{"id":313595519,"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-15T19:26:26Z","updated_at":"2018-02-15T19:34:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/12412","html_url":"https://github.com/highfidelity/hifi/pull/12412","diff_url":"https://github.com/highfidelity/hifi/pull/12412.diff","patch_url":"https://github.com/highfidelity/hifi/pull/12412.patch"},"body":"Introducing a way to abort a task from one of its job, using it to skip highlight tasks if nothing to highlight\r\n\r\nIn the JobCOnfig base calass we are adding a TaskFlow object which can be used to issue commands from within a job::run to control the flow of the calling task (of the job).\r\n\r\nTHe first command we expose is \"abortTask\"\r\nIt allows a Job to tell the task to abort the rest of the job remaining that it owns.\r\n\r\nWe use this new feature to remove any Highlight effect processing early on if there is nothing to highlight. This shaves a few hundreds of nano seconds that where spend on that before all teh time.\r\n\r\n## TEST PLAN ##\r\nEnd result should be similar to master \r\nthe render thread / engine time should be equal or lower in this PR than in master (With stats, the top of the 4th column)\r\n- run the test plan described  here\r\nhttps://github.com/highfidelity/hifi_tests/blob/master/tests/engine/render/effect/highlight/coverage/test.md\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/366037157","html_url":"https://github.com/highfidelity/hifi/pull/12412#issuecomment-366037157","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/12412","id":366037157,"user":{"login":"hifi-gustavo","id":4554450,"avatar_url":"https://avatars0.githubusercontent.com/u/4554450?v=4","gravatar_id":"","url":"https://api.github.com/users/hifi-gustavo","html_url":"https://github.com/hifi-gustavo","followers_url":"https://api.github.com/users/hifi-gustavo/followers","following_url":"https://api.github.com/users/hifi-gustavo/following{/other_user}","gists_url":"https://api.github.com/users/hifi-gustavo/gists{/gist_id}","starred_url":"https://api.github.com/users/hifi-gustavo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hifi-gustavo/subscriptions","organizations_url":"https://api.github.com/users/hifi-gustavo/orgs","repos_url":"https://api.github.com/users/hifi-gustavo/repos","events_url":"https://api.github.com/users/hifi-gustavo/events{/privacy}","received_events_url":"https://api.github.com/users/hifi-gustavo/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T19:34:28Z","updated_at":"2018-02-15T19:34:28Z","author_association":"NONE","body":"Android build is available at: https://deployment.highfidelity.com/jobs/pr-build/label%3Dandroid/7230/app_12412_PR.apk"}}
{"actor":{"display_login":"hifi-gustavo"}}