{"action":"created","issue":{"url":"https://api.github.com/repos/understrap/understrap/issues/866","repository_url":"https://api.github.com/repos/understrap/understrap","labels_url":"https://api.github.com/repos/understrap/understrap/issues/866/labels{/name}","comments_url":"https://api.github.com/repos/understrap/understrap/issues/866/comments","events_url":"https://api.github.com/repos/understrap/understrap/issues/866/events","html_url":"https://github.com/understrap/understrap/issues/866","id":388918158,"node_id":"MDU6SXNzdWUzODg5MTgxNTg=","number":866,"title":"Unable to minify JavaScript when Template Literals are added to custom-javascript.js","user":{"login":"blachawk","id":3985279,"node_id":"MDQ6VXNlcjM5ODUyNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/3985279?v=4","gravatar_id":"","url":"https://api.github.com/users/blachawk","html_url":"https://github.com/blachawk","followers_url":"https://api.github.com/users/blachawk/followers","following_url":"https://api.github.com/users/blachawk/following{/other_user}","gists_url":"https://api.github.com/users/blachawk/gists{/gist_id}","starred_url":"https://api.github.com/users/blachawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blachawk/subscriptions","organizations_url":"https://api.github.com/users/blachawk/orgs","repos_url":"https://api.github.com/users/blachawk/repos","events_url":"https://api.github.com/users/blachawk/events{/privacy}","received_events_url":"https://api.github.com/users/blachawk/received_events","type":"User","site_admin":false},"labels":[{"id":855956072,"node_id":"MDU6TGFiZWw4NTU5NTYwNzI=","url":"https://api.github.com/repos/understrap/understrap/labels/Assigned","name":"Assigned","color":"0052cc","default":false},{"id":156119429,"node_id":"MDU6TGFiZWwxNTYxMTk0Mjk=","url":"https://api.github.com/repos/understrap/understrap/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false},{"id":853355599,"node_id":"MDU6TGFiZWw4NTMzNTU1OTk=","url":"https://api.github.com/repos/understrap/understrap/labels/Feature%20request","name":"Feature request","color":"e1fca6","default":false},{"id":156119430,"node_id":"MDU6TGFiZWwxNTYxMTk0MzA=","url":"https://api.github.com/repos/understrap/understrap/labels/Help%20wanted!","name":"Help wanted!","color":"159818","default":false},{"id":854301538,"node_id":"MDU6TGFiZWw4NTQzMDE1Mzg=","url":"https://api.github.com/repos/understrap/understrap/labels/ToDo","name":"ToDo","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"0dp","id":3642367,"node_id":"MDQ6VXNlcjM2NDIzNjc=","avatar_url":"https://avatars0.githubusercontent.com/u/3642367?v=4","gravatar_id":"","url":"https://api.github.com/users/0dp","html_url":"https://github.com/0dp","followers_url":"https://api.github.com/users/0dp/followers","following_url":"https://api.github.com/users/0dp/following{/other_user}","gists_url":"https://api.github.com/users/0dp/gists{/gist_id}","starred_url":"https://api.github.com/users/0dp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dp/subscriptions","organizations_url":"https://api.github.com/users/0dp/orgs","repos_url":"https://api.github.com/users/0dp/repos","events_url":"https://api.github.com/users/0dp/events{/privacy}","received_events_url":"https://api.github.com/users/0dp/received_events","type":"User","site_admin":false},"assignees":[{"login":"0dp","id":3642367,"node_id":"MDQ6VXNlcjM2NDIzNjc=","avatar_url":"https://avatars0.githubusercontent.com/u/3642367?v=4","gravatar_id":"","url":"https://api.github.com/users/0dp","html_url":"https://github.com/0dp","followers_url":"https://api.github.com/users/0dp/followers","following_url":"https://api.github.com/users/0dp/following{/other_user}","gists_url":"https://api.github.com/users/0dp/gists{/gist_id}","starred_url":"https://api.github.com/users/0dp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dp/subscriptions","organizations_url":"https://api.github.com/users/0dp/orgs","repos_url":"https://api.github.com/users/0dp/repos","events_url":"https://api.github.com/users/0dp/events{/privacy}","received_events_url":"https://api.github.com/users/0dp/received_events","type":"User","site_admin":false},{"login":"Thomas-A-Reinert","id":5886977,"node_id":"MDQ6VXNlcjU4ODY5Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5886977?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomas-A-Reinert","html_url":"https://github.com/Thomas-A-Reinert","followers_url":"https://api.github.com/users/Thomas-A-Reinert/followers","following_url":"https://api.github.com/users/Thomas-A-Reinert/following{/other_user}","gists_url":"https://api.github.com/users/Thomas-A-Reinert/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomas-A-Reinert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomas-A-Reinert/subscriptions","organizations_url":"https://api.github.com/users/Thomas-A-Reinert/orgs","repos_url":"https://api.github.com/users/Thomas-A-Reinert/repos","events_url":"https://api.github.com/users/Thomas-A-Reinert/events{/privacy}","received_events_url":"https://api.github.com/users/Thomas-A-Reinert/received_events","type":"User","site_admin":false},{"login":"axlright","id":25565292,"node_id":"MDQ6VXNlcjI1NTY1Mjky","avatar_url":"https://avatars2.githubusercontent.com/u/25565292?v=4","gravatar_id":"","url":"https://api.github.com/users/axlright","html_url":"https://github.com/axlright","followers_url":"https://api.github.com/users/axlright/followers","following_url":"https://api.github.com/users/axlright/following{/other_user}","gists_url":"https://api.github.com/users/axlright/gists{/gist_id}","starred_url":"https://api.github.com/users/axlright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axlright/subscriptions","organizations_url":"https://api.github.com/users/axlright/orgs","repos_url":"https://api.github.com/users/axlright/repos","events_url":"https://api.github.com/users/axlright/events{/privacy}","received_events_url":"https://api.github.com/users/axlright/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-12-08T12:34:56Z","updated_at":"2018-12-10T15:49:30Z","closed_at":null,"author_association":"NONE","body":"  - [ ] a Bug Report\r\n\r\n## Please tell us about your environment:\r\n  - **WordPress Version:** 5.0\r\n  - **OS Version:** [Windows 10]\r\n  - **Browser:** [ all ]\r\n  - **Language:** [ Javascript]\r\n---\r\n\r\n# Issue Overview for Bugreports\r\nIn the event we want to add our own custom JavaScript to UnderStrap, instructions are given in the package to create a file called custom-javascript.js.  This process works.  But if we add JavaScript **[template literals](https://developers.google.com/web/updates/2015/01/ES6-Template-Strings)** to the code in that file, UnderStrap fails to minify, and the developer is kicked out of **gulp watch-bs**.  \r\n\r\n* Example of what to add:\r\n> var mTempLit = `` ` ``compile`` ` ``;   \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/understrap/understrap/issues/comments/445863544","html_url":"https://github.com/understrap/understrap/issues/866#issuecomment-445863544","issue_url":"https://api.github.com/repos/understrap/understrap/issues/866","id":445863544,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTg2MzU0NA==","user":{"login":"blachawk","id":3985279,"node_id":"MDQ6VXNlcjM5ODUyNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/3985279?v=4","gravatar_id":"","url":"https://api.github.com/users/blachawk","html_url":"https://github.com/blachawk","followers_url":"https://api.github.com/users/blachawk/followers","following_url":"https://api.github.com/users/blachawk/following{/other_user}","gists_url":"https://api.github.com/users/blachawk/gists{/gist_id}","starred_url":"https://api.github.com/users/blachawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blachawk/subscriptions","organizations_url":"https://api.github.com/users/blachawk/orgs","repos_url":"https://api.github.com/users/blachawk/repos","events_url":"https://api.github.com/users/blachawk/events{/privacy}","received_events_url":"https://api.github.com/users/blachawk/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T15:49:30Z","updated_at":"2018-12-10T15:49:30Z","author_association":"NONE","body":"I just want you guys to know I really appriciate your care and effort in making a solid product with the very little time you have.  Just for clarity purposes,  the main issue I see in this is allowing the use of back ticks for strings.  [More on that here](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals).  This really has nothing to do with ES6 or ts (TypeScript). Its been a core part of the language in forming JavaScript strings.  \r\n\r\nI'll be diving into some creative workarounds this week (thanks to you guys) and see what I come up with. Appreciate any through or planning in considering this for any future releases of UnderStrap.\r\n  "}}
{"actor":{"display_login":"blachawk"}}