{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/235102157","pull_request_review_id":176891382,"id":235102157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTEwMjE1Nw==","diff_hunk":"@@ -0,0 +1,57 @@\n+-- This file is run from not only pg_regress, but also during the standalone\n+-- pg_upgrade cluster test. It contains corner cases specific to pg_upgrade\n+-- where the state that needs to be tested would otherwise be destroyed during\n+-- a dump and restore (such as dropped columns).\n+\n+DROP SCHEMA IF EXISTS upgrade_cornercases CASCADE;\n+CREATE SCHEMA upgrade_cornercases;\n+SET search_path TO upgrade_cornercases, public;\n+\n+-- dropping columns on tables with inheritance\n+CREATE TABLE root1 (a int, b int, c int) DISTRIBUTED RANDOMLY;\n+\n+CREATE TABLE child1 (d int) INHERITS (root1);\n+\n+INSERT INTO root1 VALUES (1, 2, 3), (4, 5, 6), (7, 8, 9);\n+INSERT INTO child1\n+VALUES (10, 100, 1000, 10000),\n+       (11, 111, 1111, 11111),\n+       (12, 123, 1234, 12345);\n+\n+ALTER TABLE root1 DROP COLUMN b;\n+ALTER TABLE ONLY root1 DROP COLUMN c;\n+","path":"src/test/regress/sql/gp_upgrade_cornercases.sql","position":23,"original_position":23,"commit_id":"f546914fe8380c86b682b665264cdf1ad49976fe","original_commit_id":"f546914fe8380c86b682b665264cdf1ad49976fe","user":{"login":"l-wang","id":2261807,"node_id":"MDQ6VXNlcjIyNjE4MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/2261807?v=4","gravatar_id":"","url":"https://api.github.com/users/l-wang","html_url":"https://github.com/l-wang","followers_url":"https://api.github.com/users/l-wang/followers","following_url":"https://api.github.com/users/l-wang/following{/other_user}","gists_url":"https://api.github.com/users/l-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/l-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l-wang/subscriptions","organizations_url":"https://api.github.com/users/l-wang/orgs","repos_url":"https://api.github.com/users/l-wang/repos","events_url":"https://api.github.com/users/l-wang/events{/privacy}","received_events_url":"https://api.github.com/users/l-wang/received_events","type":"User","site_admin":false},"body":"ah that's fair.","created_at":"2018-11-20T17:38:05Z","updated_at":"2018-11-20T17:38:06Z","html_url":"https://github.com/greenplum-db/gpdb/pull/6250#discussion_r235102157","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6250","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/235102157"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/6250#discussion_r235102157"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6250"}},"in_reply_to_id":234305065},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6250","id":231312769,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzEyNzY5","html_url":"https://github.com/greenplum-db/gpdb/pull/6250","diff_url":"https://github.com/greenplum-db/gpdb/pull/6250.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/6250.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/6250","number":6250,"state":"open","locked":false,"title":"pg_dump: address DROP COLUMN FIXME and add regression tests","user":{"login":"doty-pivotal","id":26942209,"node_id":"MDQ6VXNlcjI2OTQyMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/26942209?v=4","gravatar_id":"","url":"https://api.github.com/users/doty-pivotal","html_url":"https://github.com/doty-pivotal","followers_url":"https://api.github.com/users/doty-pivotal/followers","following_url":"https://api.github.com/users/doty-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/doty-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/doty-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doty-pivotal/subscriptions","organizations_url":"https://api.github.com/users/doty-pivotal/orgs","repos_url":"https://api.github.com/users/doty-pivotal/repos","events_url":"https://api.github.com/users/doty-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/doty-pivotal/received_events","type":"User","site_admin":false},"body":"After reviewing the use of `ALTER TABLE DROP COLUMN` in the `pg_dump` code, we feel that the ordering of DDL statements in the dump do not raise any concerns with respect to vanilla table inheritance hierarchies.\r\n\r\nIn the current implementation, we need to cascade the `DROP COLUMN` to partitions, but we do not want to cascade to \"normal\" inherited child tables. Because the child tables are not hooked into the inheritance hierarchy until after the `DROP COLUMN` is performed, it looks like `ALTER TABLE` and `ALTER TABLE ONLY` are equivalent for vanilla inheritance.\r\n\r\nWe've added some regression tests that will hopefully catch any changes to the above assumptions. The added sql test file is run from not only `pg_regress`, but also during the standalone `pg_upgrade` cluster test. It is intended to contain corner cases specific to `pg_upgrade` where the state that needs to be tested would otherwise be destroyed during a dump and restore (such as dropped columns).\r\n\r\nThere is also a `.gitignore` touch up commit included.","created_at":"2018-11-15T19:46:10Z","updated_at":"2018-11-20T17:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4bfc5e28db2d200b84afa6845da3f89d28a6f1f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ashwinstar","id":11396815,"node_id":"MDQ6VXNlcjExMzk2ODE1","avatar_url":"https://avatars2.githubusercontent.com/u/11396815?v=4","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},{"login":"khannaekta","id":15749573,"node_id":"MDQ6VXNlcjE1NzQ5NTcz","avatar_url":"https://avatars0.githubusercontent.com/u/15749573?v=4","gravatar_id":"","url":"https://api.github.com/users/khannaekta","html_url":"https://github.com/khannaekta","followers_url":"https://api.github.com/users/khannaekta/followers","following_url":"https://api.github.com/users/khannaekta/following{/other_user}","gists_url":"https://api.github.com/users/khannaekta/gists{/gist_id}","starred_url":"https://api.github.com/users/khannaekta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khannaekta/subscriptions","organizations_url":"https://api.github.com/users/khannaekta/orgs","repos_url":"https://api.github.com/users/khannaekta/repos","events_url":"https://api.github.com/users/khannaekta/events{/privacy}","received_events_url":"https://api.github.com/users/khannaekta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":865288500,"node_id":"MDU6TGFiZWw4NjUyODg1MDA=","url":"https://api.github.com/repos/greenplum-db/gpdb/labels/Upgrade","name":"Upgrade","color":"a51e1c","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6250/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6250/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/6250/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/f546914fe8380c86b682b665264cdf1ad49976fe","head":{"label":"doty-pivotal:dev/alter_table_fixme","ref":"dev/alter_table_fixme","sha":"f546914fe8380c86b682b665264cdf1ad49976fe","user":{"login":"doty-pivotal","id":26942209,"node_id":"MDQ6VXNlcjI2OTQyMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/26942209?v=4","gravatar_id":"","url":"https://api.github.com/users/doty-pivotal","html_url":"https://github.com/doty-pivotal","followers_url":"https://api.github.com/users/doty-pivotal/followers","following_url":"https://api.github.com/users/doty-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/doty-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/doty-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doty-pivotal/subscriptions","organizations_url":"https://api.github.com/users/doty-pivotal/orgs","repos_url":"https://api.github.com/users/doty-pivotal/repos","events_url":"https://api.github.com/users/doty-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/doty-pivotal/received_events","type":"User","site_admin":false},"repo":{"id":116710926,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY3MTA5MjY=","name":"gpdb","full_name":"doty-pivotal/gpdb","private":false,"owner":{"login":"doty-pivotal","id":26942209,"node_id":"MDQ6VXNlcjI2OTQyMjA5","avatar_url":"https://avatars3.githubusercontent.com/u/26942209?v=4","gravatar_id":"","url":"https://api.github.com/users/doty-pivotal","html_url":"https://github.com/doty-pivotal","followers_url":"https://api.github.com/users/doty-pivotal/followers","following_url":"https://api.github.com/users/doty-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/doty-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/doty-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doty-pivotal/subscriptions","organizations_url":"https://api.github.com/users/doty-pivotal/orgs","repos_url":"https://api.github.com/users/doty-pivotal/repos","events_url":"https://api.github.com/users/doty-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/doty-pivotal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/doty-pivotal/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/doty-pivotal/gpdb","forks_url":"https://api.github.com/repos/doty-pivotal/gpdb/forks","keys_url":"https://api.github.com/repos/doty-pivotal/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doty-pivotal/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doty-pivotal/gpdb/teams","hooks_url":"https://api.github.com/repos/doty-pivotal/gpdb/hooks","issue_events_url":"https://api.github.com/repos/doty-pivotal/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/doty-pivotal/gpdb/events","assignees_url":"https://api.github.com/repos/doty-pivotal/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/doty-pivotal/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/doty-pivotal/gpdb/tags","blobs_url":"https://api.github.com/repos/doty-pivotal/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doty-pivotal/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doty-pivotal/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/doty-pivotal/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doty-pivotal/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/doty-pivotal/gpdb/languages","stargazers_url":"https://api.github.com/repos/doty-pivotal/gpdb/stargazers","contributors_url":"https://api.github.com/repos/doty-pivotal/gpdb/contributors","subscribers_url":"https://api.github.com/repos/doty-pivotal/gpdb/subscribers","subscription_url":"https://api.github.com/repos/doty-pivotal/gpdb/subscription","commits_url":"https://api.github.com/repos/doty-pivotal/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/doty-pivotal/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/doty-pivotal/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/doty-pivotal/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/doty-pivotal/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/doty-pivotal/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doty-pivotal/gpdb/merges","archive_url":"https://api.github.com/repos/doty-pivotal/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doty-pivotal/gpdb/downloads","issues_url":"https://api.github.com/repos/doty-pivotal/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/doty-pivotal/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/doty-pivotal/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/doty-pivotal/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doty-pivotal/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/doty-pivotal/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/doty-pivotal/gpdb/deployments","created_at":"2018-01-08T18:08:55Z","updated_at":"2018-11-07T00:52:39Z","pushed_at":"2018-11-15T21:38:56Z","git_url":"git://github.com/doty-pivotal/gpdb.git","ssh_url":"git@github.com:doty-pivotal/gpdb.git","clone_url":"https://github.com/doty-pivotal/gpdb.git","svn_url":"https://github.com/doty-pivotal/gpdb","homepage":"http://greenplum.org","size":327436,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"012476fd5099d8ad78c096def6d83599493c4961","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc4MTE0MA==","name":"gpdb","full_name":"greenplum-db/gpdb","private":false,"owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2018-11-20T13:06:08Z","pushed_at":"2018-11-20T17:35:36Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":331961,"stargazers_count":2797,"watchers_count":2797,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":850,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":850,"open_issues":248,"watchers":2797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6250"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/6250"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/6250"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/6250/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6250/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/6250/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/f546914fe8380c86b682b665264cdf1ad49976fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"l-wang"}}