{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/helmclient/pulls/comments/237395505","pull_request_review_id":179680270,"id":237395505,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzM5NTUwNQ==","diff_hunk":"@@ -13,6 +13,14 @@ import (\n \t\"k8s.io/client-go/kubernetes\"\n )\n \n+/*\n+\tNOTE: This code is copied from e2esetup/k8s package to avoid circular\n+\tdependencies. All changes made there should be reflected in e2esetup.\n+\n+\t\tSee https://github.com/giantswarm/e2esetup/pull/13\n+\n+*/","path":"integration/setup/k8s/setup.go","position":10,"original_position":10,"commit_id":"4974443abe870a4bb88afa80146141e2ae9309a5","original_commit_id":"4974443abe870a4bb88afa80146141e2ae9309a5","user":{"login":"kopiczko","id":4608994,"node_id":"MDQ6VXNlcjQ2MDg5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"body":"The diff is small because git thinks the file was moved from vendor directory. This is a full copy.","created_at":"2018-11-29T08:49:17Z","updated_at":"2018-11-29T08:49:17Z","html_url":"https://github.com/giantswarm/helmclient/pull/65#discussion_r237395505","pull_request_url":"https://api.github.com/repos/giantswarm/helmclient/pulls/65","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/helmclient/pulls/comments/237395505"},"html":{"href":"https://github.com/giantswarm/helmclient/pull/65#discussion_r237395505"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/helmclient/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/giantswarm/helmclient/pulls/65","id":234549472,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTQ5NDcy","html_url":"https://github.com/giantswarm/helmclient/pull/65","diff_url":"https://github.com/giantswarm/helmclient/pull/65.diff","patch_url":"https://github.com/giantswarm/helmclient/pull/65.patch","issue_url":"https://api.github.com/repos/giantswarm/helmclient/issues/65","number":65,"state":"open","locked":false,"title":"integration, vendor: remove e2esetup dependency from code (#63)","user":{"login":"kopiczko","id":4608994,"node_id":"MDQ6VXNlcjQ2MDg5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"body":"Towards https://github.com/giantswarm/giantswarm/issues/4709.\r\n\r\nWe were using e2esetup to create/delete tiller namespace in tests. We\r\ndon't want the dependency in the code though because e2esetup depends on\r\nhelmclient. This creates potential circular dependency problem and makes\r\nvendoring hard.","created_at":"2018-11-29T08:36:16Z","updated_at":"2018-11-29T08:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a814c5d47e630a69e8560298120dd2203a12627c","assignee":{"login":"kopiczko","id":4608994,"node_id":"MDQ6VXNlcjQ2MDg5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"assignees":[{"login":"kopiczko","id":4608994,"node_id":"MDQ6VXNlcjQ2MDg5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/helmclient/pulls/65/commits","review_comments_url":"https://api.github.com/repos/giantswarm/helmclient/pulls/65/comments","review_comment_url":"https://api.github.com/repos/giantswarm/helmclient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/helmclient/issues/65/comments","statuses_url":"https://api.github.com/repos/giantswarm/helmclient/statuses/4974443abe870a4bb88afa80146141e2ae9309a5","head":{"label":"giantswarm:int","ref":"int","sha":"4974443abe870a4bb88afa80146141e2ae9309a5","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":128738723,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg3Mzg3MjM=","name":"helmclient","full_name":"giantswarm/helmclient","private":false,"owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/giantswarm/helmclient","description":"Package helmclient implements Helm related primitives to work against Tiller. ","fork":false,"url":"https://api.github.com/repos/giantswarm/helmclient","forks_url":"https://api.github.com/repos/giantswarm/helmclient/forks","keys_url":"https://api.github.com/repos/giantswarm/helmclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/helmclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/helmclient/teams","hooks_url":"https://api.github.com/repos/giantswarm/helmclient/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/helmclient/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/helmclient/events","assignees_url":"https://api.github.com/repos/giantswarm/helmclient/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/helmclient/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/helmclient/tags","blobs_url":"https://api.github.com/repos/giantswarm/helmclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/helmclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/helmclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/helmclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/helmclient/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/helmclient/languages","stargazers_url":"https://api.github.com/repos/giantswarm/helmclient/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/helmclient/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/helmclient/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/helmclient/subscription","commits_url":"https://api.github.com/repos/giantswarm/helmclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/helmclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/helmclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/helmclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/helmclient/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/helmclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/helmclient/merges","archive_url":"https://api.github.com/repos/giantswarm/helmclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/helmclient/downloads","issues_url":"https://api.github.com/repos/giantswarm/helmclient/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/helmclient/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/helmclient/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/helmclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/helmclient/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/helmclient/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/helmclient/deployments","created_at":"2018-04-09T08:23:26Z","updated_at":"2018-11-29T08:06:02Z","pushed_at":"2018-11-29T08:46:03Z","git_url":"git://github.com/giantswarm/helmclient.git","ssh_url":"git@github.com:giantswarm/helmclient.git","clone_url":"https://github.com/giantswarm/helmclient.git","svn_url":"https://github.com/giantswarm/helmclient","homepage":null,"size":9881,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"7c3a9fa9bc88d0489ee41caa18b08289541f6104","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":128738723,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg3Mzg3MjM=","name":"helmclient","full_name":"giantswarm/helmclient","private":false,"owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/giantswarm/helmclient","description":"Package helmclient implements Helm related primitives to work against Tiller. ","fork":false,"url":"https://api.github.com/repos/giantswarm/helmclient","forks_url":"https://api.github.com/repos/giantswarm/helmclient/forks","keys_url":"https://api.github.com/repos/giantswarm/helmclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/helmclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/helmclient/teams","hooks_url":"https://api.github.com/repos/giantswarm/helmclient/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/helmclient/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/helmclient/events","assignees_url":"https://api.github.com/repos/giantswarm/helmclient/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/helmclient/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/helmclient/tags","blobs_url":"https://api.github.com/repos/giantswarm/helmclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/helmclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/helmclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/helmclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/helmclient/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/helmclient/languages","stargazers_url":"https://api.github.com/repos/giantswarm/helmclient/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/helmclient/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/helmclient/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/helmclient/subscription","commits_url":"https://api.github.com/repos/giantswarm/helmclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/helmclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/helmclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/helmclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/helmclient/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/helmclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/helmclient/merges","archive_url":"https://api.github.com/repos/giantswarm/helmclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/helmclient/downloads","issues_url":"https://api.github.com/repos/giantswarm/helmclient/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/helmclient/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/helmclient/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/helmclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/helmclient/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/helmclient/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/helmclient/deployments","created_at":"2018-04-09T08:23:26Z","updated_at":"2018-11-29T08:06:02Z","pushed_at":"2018-11-29T08:46:03Z","git_url":"git://github.com/giantswarm/helmclient.git","ssh_url":"git@github.com:giantswarm/helmclient.git","clone_url":"https://github.com/giantswarm/helmclient.git","svn_url":"https://github.com/giantswarm/helmclient","homepage":null,"size":9881,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/helmclient/pulls/65"},"html":{"href":"https://github.com/giantswarm/helmclient/pull/65"},"issue":{"href":"https://api.github.com/repos/giantswarm/helmclient/issues/65"},"comments":{"href":"https://api.github.com/repos/giantswarm/helmclient/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/helmclient/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/helmclient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/helmclient/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/helmclient/statuses/4974443abe870a4bb88afa80146141e2ae9309a5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kopiczko"}}