{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/emission/pulls/comments/198271378","pull_request_review_id":132172965,"id":198271378,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODI3MTM3OA==","diff_hunk":"@@ -267,6 +272,21 @@ export class ConfirmBid extends React.Component<ConfirmBidProps, ConfirmBidState\n     this.props.navigator.pop()\n   }\n \n+  presentErrorResult(error) {\n+    console.error(error)","path":"src/lib/Components/Bidding/Screens/ConfirmBid.tsx","position":35,"original_position":35,"commit_id":"1eb630dcdafd33d6950606fad690be97ab56af73","original_commit_id":"1eb630dcdafd33d6950606fad690be97ab56af73","user":{"login":"yuki24","id":386234,"node_id":"MDQ6VXNlcjM4NjIzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/386234?v=4","gravatar_id":"","url":"https://api.github.com/users/yuki24","html_url":"https://github.com/yuki24","followers_url":"https://api.github.com/users/yuki24/followers","following_url":"https://api.github.com/users/yuki24/following{/other_user}","gists_url":"https://api.github.com/users/yuki24/gists{/gist_id}","starred_url":"https://api.github.com/users/yuki24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuki24/subscriptions","organizations_url":"https://api.github.com/users/yuki24/orgs","repos_url":"https://api.github.com/users/yuki24/repos","events_url":"https://api.github.com/users/yuki24/events{/privacy}","received_events_url":"https://api.github.com/users/yuki24/received_events","type":"User","site_admin":false},"body":"I left this `console.error` to send the error to Sentry. In development this will show a red screen that may be surprising, but that's intentional. ","created_at":"2018-06-26T19:34:59Z","updated_at":"2018-06-26T19:34:59Z","html_url":"https://github.com/artsy/emission/pull/1125#discussion_r198271378","pull_request_url":"https://api.github.com/repos/artsy/emission/pulls/1125","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/artsy/emission/pulls/comments/198271378"},"html":{"href":"https://github.com/artsy/emission/pull/1125#discussion_r198271378"},"pull_request":{"href":"https://api.github.com/repos/artsy/emission/pulls/1125"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/emission/pulls/1125","id":197528398,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTI4Mzk4","html_url":"https://github.com/artsy/emission/pull/1125","diff_url":"https://github.com/artsy/emission/pull/1125.diff","patch_url":"https://github.com/artsy/emission/pull/1125.patch","issue_url":"https://api.github.com/repos/artsy/emission/issues/1125","number":1125,"state":"open","locked":false,"title":"User should see an error message when a request to MP did not go through","user":{"login":"yuki24","id":386234,"node_id":"MDQ6VXNlcjM4NjIzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/386234?v=4","gravatar_id":"","url":"https://api.github.com/users/yuki24","html_url":"https://github.com/yuki24","followers_url":"https://api.github.com/users/yuki24/followers","following_url":"https://api.github.com/users/yuki24/following{/other_user}","gists_url":"https://api.github.com/users/yuki24/gists{/gist_id}","starred_url":"https://api.github.com/users/yuki24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuki24/subscriptions","organizations_url":"https://api.github.com/users/yuki24/orgs","repos_url":"https://api.github.com/users/yuki24/repos","events_url":"https://api.github.com/users/yuki24/events{/privacy}","received_events_url":"https://api.github.com/users/yuki24/received_events","type":"User","site_admin":false},"body":"finishes https://artsyproduct.atlassian.net/browse/PURCHASE-188\r\n\r\nThis is a simple change for displaying an error message when an network error occurs. I'm not sure what the app should take the user to when the CONTINUE button is pressed, but that could be addressed as a separate task.\r\n\r\nI tested this by disabling WiFi and hitting the PLACE BID button. The actual device may behave differently depending on the network condition.\r\n\r\n## Screenshot:\r\n\r\n![network-error](https://user-images.githubusercontent.com/386234/41934821-a87afa6a-7955-11e8-9ca6-4cc7a827b0ff.gif)\r\n\r\n","created_at":"2018-06-26T19:33:59Z","updated_at":"2018-06-26T19:34:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f44f85ad385693d359031197ae9249d1a6f3cb7f","assignee":{"login":"sweir27","id":2081340,"node_id":"MDQ6VXNlcjIwODEzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2081340?v=4","gravatar_id":"","url":"https://api.github.com/users/sweir27","html_url":"https://github.com/sweir27","followers_url":"https://api.github.com/users/sweir27/followers","following_url":"https://api.github.com/users/sweir27/following{/other_user}","gists_url":"https://api.github.com/users/sweir27/gists{/gist_id}","starred_url":"https://api.github.com/users/sweir27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweir27/subscriptions","organizations_url":"https://api.github.com/users/sweir27/orgs","repos_url":"https://api.github.com/users/sweir27/repos","events_url":"https://api.github.com/users/sweir27/events{/privacy}","received_events_url":"https://api.github.com/users/sweir27/received_events","type":"User","site_admin":false},"assignees":[{"login":"sweir27","id":2081340,"node_id":"MDQ6VXNlcjIwODEzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2081340?v=4","gravatar_id":"","url":"https://api.github.com/users/sweir27","html_url":"https://github.com/sweir27","followers_url":"https://api.github.com/users/sweir27/followers","following_url":"https://api.github.com/users/sweir27/following{/other_user}","gists_url":"https://api.github.com/users/sweir27/gists{/gist_id}","starred_url":"https://api.github.com/users/sweir27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweir27/subscriptions","organizations_url":"https://api.github.com/users/sweir27/orgs","repos_url":"https://api.github.com/users/sweir27/repos","events_url":"https://api.github.com/users/sweir27/events{/privacy}","received_events_url":"https://api.github.com/users/sweir27/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"orta","id":49038,"node_id":"MDQ6VXNlcjQ5MDM4","avatar_url":"https://avatars2.githubusercontent.com/u/49038?v=4","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},{"login":"sepans","id":687513,"node_id":"MDQ6VXNlcjY4NzUxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/687513?v=4","gravatar_id":"","url":"https://api.github.com/users/sepans","html_url":"https://github.com/sepans","followers_url":"https://api.github.com/users/sepans/followers","following_url":"https://api.github.com/users/sepans/following{/other_user}","gists_url":"https://api.github.com/users/sepans/gists{/gist_id}","starred_url":"https://api.github.com/users/sepans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepans/subscriptions","organizations_url":"https://api.github.com/users/sepans/orgs","repos_url":"https://api.github.com/users/sepans/repos","events_url":"https://api.github.com/users/sepans/events{/privacy}","received_events_url":"https://api.github.com/users/sepans/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/emission/pulls/1125/commits","review_comments_url":"https://api.github.com/repos/artsy/emission/pulls/1125/comments","review_comment_url":"https://api.github.com/repos/artsy/emission/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/emission/issues/1125/comments","statuses_url":"https://api.github.com/repos/artsy/emission/statuses/1eb630dcdafd33d6950606fad690be97ab56af73","head":{"label":"artsy:PURCHASE-188","ref":"PURCHASE-188","sha":"1eb630dcdafd33d6950606fad690be97ab56af73","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":52437732,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQzNzczMg==","name":"emission","full_name":"artsy/emission","owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/emission","description":"React Native Components","fork":false,"url":"https://api.github.com/repos/artsy/emission","forks_url":"https://api.github.com/repos/artsy/emission/forks","keys_url":"https://api.github.com/repos/artsy/emission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/emission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/emission/teams","hooks_url":"https://api.github.com/repos/artsy/emission/hooks","issue_events_url":"https://api.github.com/repos/artsy/emission/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/emission/events","assignees_url":"https://api.github.com/repos/artsy/emission/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/emission/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/emission/tags","blobs_url":"https://api.github.com/repos/artsy/emission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/emission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/emission/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/emission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/emission/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/emission/languages","stargazers_url":"https://api.github.com/repos/artsy/emission/stargazers","contributors_url":"https://api.github.com/repos/artsy/emission/contributors","subscribers_url":"https://api.github.com/repos/artsy/emission/subscribers","subscription_url":"https://api.github.com/repos/artsy/emission/subscription","commits_url":"https://api.github.com/repos/artsy/emission/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/emission/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/emission/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/emission/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/emission/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/emission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/emission/merges","archive_url":"https://api.github.com/repos/artsy/emission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/emission/downloads","issues_url":"https://api.github.com/repos/artsy/emission/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/emission/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/emission/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/emission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/emission/labels{/name}","releases_url":"https://api.github.com/repos/artsy/emission/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/emission/deployments","created_at":"2016-02-24T11:36:24Z","updated_at":"2018-06-26T14:50:50Z","pushed_at":"2018-06-26T19:34:00Z","git_url":"git://github.com/artsy/emission.git","ssh_url":"git@github.com:artsy/emission.git","clone_url":"https://github.com/artsy/emission.git","svn_url":"https://github.com/artsy/emission","homepage":"http://artsy.github.io/blog/2018/04/17/making-a-components-pod/","size":25142,"stargazers_count":473,"watchers_count":473,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":52,"open_issues":65,"watchers":473,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"800dfa236b66412ac51e7f132a84fe92395bab0c","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":52437732,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQzNzczMg==","name":"emission","full_name":"artsy/emission","owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/emission","description":"React Native Components","fork":false,"url":"https://api.github.com/repos/artsy/emission","forks_url":"https://api.github.com/repos/artsy/emission/forks","keys_url":"https://api.github.com/repos/artsy/emission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/emission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/emission/teams","hooks_url":"https://api.github.com/repos/artsy/emission/hooks","issue_events_url":"https://api.github.com/repos/artsy/emission/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/emission/events","assignees_url":"https://api.github.com/repos/artsy/emission/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/emission/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/emission/tags","blobs_url":"https://api.github.com/repos/artsy/emission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/emission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/emission/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/emission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/emission/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/emission/languages","stargazers_url":"https://api.github.com/repos/artsy/emission/stargazers","contributors_url":"https://api.github.com/repos/artsy/emission/contributors","subscribers_url":"https://api.github.com/repos/artsy/emission/subscribers","subscription_url":"https://api.github.com/repos/artsy/emission/subscription","commits_url":"https://api.github.com/repos/artsy/emission/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/emission/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/emission/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/emission/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/emission/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/emission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/emission/merges","archive_url":"https://api.github.com/repos/artsy/emission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/emission/downloads","issues_url":"https://api.github.com/repos/artsy/emission/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/emission/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/emission/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/emission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/emission/labels{/name}","releases_url":"https://api.github.com/repos/artsy/emission/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/emission/deployments","created_at":"2016-02-24T11:36:24Z","updated_at":"2018-06-26T14:50:50Z","pushed_at":"2018-06-26T19:34:00Z","git_url":"git://github.com/artsy/emission.git","ssh_url":"git@github.com:artsy/emission.git","clone_url":"https://github.com/artsy/emission.git","svn_url":"https://github.com/artsy/emission","homepage":"http://artsy.github.io/blog/2018/04/17/making-a-components-pod/","size":25142,"stargazers_count":473,"watchers_count":473,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":52,"open_issues":65,"watchers":473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/emission/pulls/1125"},"html":{"href":"https://github.com/artsy/emission/pull/1125"},"issue":{"href":"https://api.github.com/repos/artsy/emission/issues/1125"},"comments":{"href":"https://api.github.com/repos/artsy/emission/issues/1125/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/emission/pulls/1125/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/emission/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/emission/pulls/1125/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/emission/statuses/1eb630dcdafd33d6950606fad690be97ab56af73"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"yuki24"}}