{"action":"closed","number":1687,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1687","id":185057643,"html_url":"https://github.com/apache/incubator-pulsar/pull/1687","diff_url":"https://github.com/apache/incubator-pulsar/pull/1687.diff","patch_url":"https://github.com/apache/incubator-pulsar/pull/1687.patch","issue_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/1687","number":1687,"state":"closed","locked":false,"title":"Don't offload empty ledgers","user":{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false},"body":"It shouldn't be possible for a ledger in a managed ledger to be\r\nempty (it should be cleaned up on recovery), but this patch adds\r\ndefensive code so that if they do exist for some reason, they won't be\r\noffloaded.\r\n\r\nMaster Issue: #1511\r\n","created_at":"2018-04-30T20:35:25Z","updated_at":"2018-05-02T17:10:26Z","closed_at":"2018-05-02T17:10:26Z","merged_at":"2018-05-02T17:10:26Z","merge_commit_sha":"b982943c77972211c937270d305d14f9d12d5f84","assignee":{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false},"assignees":[{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":898065851,"url":"https://api.github.com/repos/apache/incubator-pulsar/labels/component/tieredstorage","name":"component/tieredstorage","color":"0e8a16","default":false},{"id":493495385,"url":"https://api.github.com/repos/apache/incubator-pulsar/labels/type/feature","name":"type/feature","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/13","html_url":"https://github.com/apache/incubator-pulsar/milestone/13","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/13/labels","id":3118453,"number":13,"title":"2.1.0-incubating","description":"","creator":{"login":"merlimat","id":62500,"avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":4,"state":"open","created_at":"2018-02-15T04:20:44Z","updated_at":"2018-05-02T17:10:26Z","due_on":"2018-05-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1687/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1687/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/1687/comments","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/d31f0d0fe748774bb5886f249d1a0944b5ffbc07","head":{"label":"ivankelly:no-offload-empty","ref":"no-offload-empty","sha":"d31f0d0fe748774bb5886f249d1a0944b5ffbc07","user":{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false},"repo":{"id":110581105,"name":"incubator-pulsar","full_name":"ivankelly/incubator-pulsar","owner":{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivankelly/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":true,"url":"https://api.github.com/repos/ivankelly/incubator-pulsar","forks_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/deployments","created_at":"2017-11-13T17:46:25Z","updated_at":"2018-03-27T16:43:23Z","pushed_at":"2018-05-01T10:21:14Z","git_url":"git://github.com/ivankelly/incubator-pulsar.git","ssh_url":"git@github.com:ivankelly/incubator-pulsar.git","clone_url":"https://github.com/ivankelly/incubator-pulsar.git","svn_url":"https://github.com/ivankelly/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":23947,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1cac0bae469bcb2cadc4ef6cad61d3dbf9b83ca8","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117812,"name":"incubator-pulsar","full_name":"apache/incubator-pulsar","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":false,"url":"https://api.github.com/repos/apache/incubator-pulsar","forks_url":"https://api.github.com/repos/apache/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/apache/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/apache/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/apache/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/apache/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/apache/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/apache/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-pulsar/deployments","created_at":"2016-06-28T07:00:03Z","updated_at":"2018-05-02T17:03:10Z","pushed_at":"2018-05-02T17:10:26Z","git_url":"git://github.com/apache/incubator-pulsar.git","ssh_url":"git@github.com:apache/incubator-pulsar.git","clone_url":"https://github.com/apache/incubator-pulsar.git","svn_url":"https://github.com/apache/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":28771,"stargazers_count":1662,"watchers_count":1662,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":355,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":355,"open_issues":153,"watchers":1662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1687"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/1687"},"issue":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/1687"},"comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/1687/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1687/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1687/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-pulsar/statuses/d31f0d0fe748774bb5886f249d1a0944b5ffbc07"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":45,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"sijie"}}