{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/comments/245455325","pull_request_review_id":189569283,"id":245455325,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ1NTMyNQ==","diff_hunk":"@@ -217,13 +217,20 @@ func ValidateURL(urlStr *string) error {\n \n // InitializeClusterWatcher initializes a file watcher for the cluster config file\n // When the file is updated the configuration synchronously reload the cluster configuration\n-func (c clusterService) InitializeClusterWatcher() (func() error, error) {\n+func (c clusterService) InitializeClusterWatcher() (func() error, chan bool, error) {","path":"cluster/service/cluster_service.go","position":30,"original_position":30,"commit_id":"30028ee2dc07f7b42fa3b88405337efe6a98a4bc","original_commit_id":"30028ee2dc07f7b42fa3b88405337efe6a98a4bc","user":{"login":"alexeykazakov","id":620087,"node_id":"MDQ6VXNlcjYyMDA4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/620087?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeykazakov","html_url":"https://github.com/alexeykazakov","followers_url":"https://api.github.com/users/alexeykazakov/followers","following_url":"https://api.github.com/users/alexeykazakov/following{/other_user}","gists_url":"https://api.github.com/users/alexeykazakov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeykazakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeykazakov/subscriptions","organizations_url":"https://api.github.com/users/alexeykazakov/orgs","repos_url":"https://api.github.com/users/alexeykazakov/repos","events_url":"https://api.github.com/users/alexeykazakov/events{/privacy}","received_events_url":"https://api.github.com/users/alexeykazakov/received_events","type":"User","site_admin":false},"body":"Do you really still need that done channel in the tests after fixing the parallel test execution?","created_at":"2019-01-05T00:24:13Z","updated_at":"2019-01-05T00:48:11Z","html_url":"https://github.com/fabric8-services/fabric8-cluster/pull/56#discussion_r245455325","pull_request_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/56","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/comments/245455325"},"html":{"href":"https://github.com/fabric8-services/fabric8-cluster/pull/56#discussion_r245455325"},"pull_request":{"href":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/56","id":242220959,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMjIwOTU5","html_url":"https://github.com/fabric8-services/fabric8-cluster/pull/56","diff_url":"https://github.com/fabric8-services/fabric8-cluster/pull/56.diff","patch_url":"https://github.com/fabric8-services/fabric8-cluster/pull/56.patch","issue_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/issues/56","number":56,"state":"open","locked":false,"title":"feat: read clusters from database","user":{"login":"xcoulon","id":178502,"node_id":"MDQ6VXNlcjE3ODUwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/178502?v=4","gravatar_id":"","url":"https://api.github.com/users/xcoulon","html_url":"https://github.com/xcoulon","followers_url":"https://api.github.com/users/xcoulon/followers","following_url":"https://api.github.com/users/xcoulon/following{/other_user}","gists_url":"https://api.github.com/users/xcoulon/gists{/gist_id}","starred_url":"https://api.github.com/users/xcoulon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcoulon/subscriptions","organizations_url":"https://api.github.com/users/xcoulon/orgs","repos_url":"https://api.github.com/users/xcoulon/repos","events_url":"https://api.github.com/users/xcoulon/events{/privacy}","received_events_url":"https://api.github.com/users/xcoulon/received_events","type":"User","site_admin":false},"body":"also:\r\n- update to latest `fabric8-common` to remove an annoying error\r\n    message after each test\r\n- run integration tests on a single processor to avoid concurrent\r\n    writes in the database, which result in assertion errors\r\n\r\nFixes #54\r\n\r\nSigned-off-by: Xavier Coulon <xcoulon@redhat.com>","created_at":"2019-01-04T10:11:46Z","updated_at":"2019-01-05T00:48:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"731448676ed954b01b33e74daccff30711ed39d4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dipak-pawar","id":7941617,"node_id":"MDQ6VXNlcjc5NDE2MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7941617?v=4","gravatar_id":"","url":"https://api.github.com/users/dipak-pawar","html_url":"https://github.com/dipak-pawar","followers_url":"https://api.github.com/users/dipak-pawar/followers","following_url":"https://api.github.com/users/dipak-pawar/following{/other_user}","gists_url":"https://api.github.com/users/dipak-pawar/gists{/gist_id}","starred_url":"https://api.github.com/users/dipak-pawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dipak-pawar/subscriptions","organizations_url":"https://api.github.com/users/dipak-pawar/orgs","repos_url":"https://api.github.com/users/dipak-pawar/repos","events_url":"https://api.github.com/users/dipak-pawar/events{/privacy}","received_events_url":"https://api.github.com/users/dipak-pawar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/56/commits","review_comments_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/56/comments","review_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/issues/56/comments","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/statuses/30028ee2dc07f7b42fa3b88405337efe6a98a4bc","head":{"label":"xcoulon:Issue54_list_cluster_from_repository","ref":"Issue54_list_cluster_from_repository","sha":"30028ee2dc07f7b42fa3b88405337efe6a98a4bc","user":{"login":"xcoulon","id":178502,"node_id":"MDQ6VXNlcjE3ODUwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/178502?v=4","gravatar_id":"","url":"https://api.github.com/users/xcoulon","html_url":"https://github.com/xcoulon","followers_url":"https://api.github.com/users/xcoulon/followers","following_url":"https://api.github.com/users/xcoulon/following{/other_user}","gists_url":"https://api.github.com/users/xcoulon/gists{/gist_id}","starred_url":"https://api.github.com/users/xcoulon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcoulon/subscriptions","organizations_url":"https://api.github.com/users/xcoulon/orgs","repos_url":"https://api.github.com/users/xcoulon/repos","events_url":"https://api.github.com/users/xcoulon/events{/privacy}","received_events_url":"https://api.github.com/users/xcoulon/received_events","type":"User","site_admin":false},"repo":{"id":153425380,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0MjUzODA=","name":"fabric8-cluster","full_name":"xcoulon/fabric8-cluster","private":false,"owner":{"login":"xcoulon","id":178502,"node_id":"MDQ6VXNlcjE3ODUwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/178502?v=4","gravatar_id":"","url":"https://api.github.com/users/xcoulon","html_url":"https://github.com/xcoulon","followers_url":"https://api.github.com/users/xcoulon/followers","following_url":"https://api.github.com/users/xcoulon/following{/other_user}","gists_url":"https://api.github.com/users/xcoulon/gists{/gist_id}","starred_url":"https://api.github.com/users/xcoulon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcoulon/subscriptions","organizations_url":"https://api.github.com/users/xcoulon/orgs","repos_url":"https://api.github.com/users/xcoulon/repos","events_url":"https://api.github.com/users/xcoulon/events{/privacy}","received_events_url":"https://api.github.com/users/xcoulon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xcoulon/fabric8-cluster","description":"Cluster management service","fork":true,"url":"https://api.github.com/repos/xcoulon/fabric8-cluster","forks_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/forks","keys_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/teams","hooks_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/hooks","issue_events_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/events","assignees_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/tags","blobs_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/languages","stargazers_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/stargazers","contributors_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/contributors","subscribers_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/subscribers","subscription_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/subscription","commits_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/merges","archive_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/downloads","issues_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/labels{/name}","releases_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/xcoulon/fabric8-cluster/deployments","created_at":"2018-10-17T08:49:06Z","updated_at":"2018-10-17T08:49:09Z","pushed_at":"2019-01-04T18:21:33Z","git_url":"git://github.com/xcoulon/fabric8-cluster.git","ssh_url":"git@github.com:xcoulon/fabric8-cluster.git","clone_url":"https://github.com/xcoulon/fabric8-cluster.git","svn_url":"https://github.com/xcoulon/fabric8-cluster","homepage":"","size":6366,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-services:master","ref":"master","sha":"f285f98653e6cd8ff7994377efd2032e72cae769","user":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"repo":{"id":144640567,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2NDA1Njc=","name":"fabric8-cluster","full_name":"fabric8-services/fabric8-cluster","private":false,"owner":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fabric8-services/fabric8-cluster","description":"Cluster management service","fork":false,"url":"https://api.github.com/repos/fabric8-services/fabric8-cluster","forks_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/forks","keys_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/teams","hooks_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/hooks","issue_events_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/events","assignees_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/tags","blobs_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/languages","stargazers_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/stargazers","contributors_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/contributors","subscribers_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/subscribers","subscription_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/subscription","commits_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/merges","archive_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/downloads","issues_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-services/fabric8-cluster/deployments","created_at":"2018-08-13T22:34:56Z","updated_at":"2019-01-04T22:30:47Z","pushed_at":"2019-01-04T22:30:45Z","git_url":"git://github.com/fabric8-services/fabric8-cluster.git","ssh_url":"git@github.com:fabric8-services/fabric8-cluster.git","clone_url":"https://github.com/fabric8-services/fabric8-cluster.git","svn_url":"https://github.com/fabric8-services/fabric8-cluster","homepage":"","size":6336,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/56"},"html":{"href":"https://github.com/fabric8-services/fabric8-cluster/pull/56"},"issue":{"href":"https://api.github.com/repos/fabric8-services/fabric8-cluster/issues/56"},"comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-cluster/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-services/fabric8-cluster/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-services/fabric8-cluster/statuses/30028ee2dc07f7b42fa3b88405337efe6a98a4bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alexeykazakov"}}