{"action":"created","comment":{"url":"https://api.github.com/repos/pmd/pmd/pulls/comments/231995569","pull_request_review_id":173086984,"id":231995569,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTk5NTU2OQ==","diff_hunk":"@@ -1353,6 +1353,55 @@ public class ClassInDefaultPackage {\n         </example>\n     </rule>\n \n+    <rule name=\"UseUnderscoresInNumericLiterals\"\n+          language=\"java\"\n+          since=\"6.10.0\"\n+          minimumLanguageVersion=\"1.7\"\n+          message=\"Numeric literals with more than 3 digits must use '_' as a separator\"","path":"pmd-java/src/main/resources/category/java/codestyle.xml","position":8,"original_position":8,"commit_id":"fd145e30b222dd9463e44d3f93620f78b524af44","original_commit_id":"fd145e30b222dd9463e44d3f93620f78b524af44","user":{"login":"oowekyala","id":24524930,"node_id":"MDQ6VXNlcjI0NTI0OTMw","avatar_url":"https://avatars0.githubusercontent.com/u/24524930?v=4","gravatar_id":"","url":"https://api.github.com/users/oowekyala","html_url":"https://github.com/oowekyala","followers_url":"https://api.github.com/users/oowekyala/followers","following_url":"https://api.github.com/users/oowekyala/following{/other_user}","gists_url":"https://api.github.com/users/oowekyala/gists{/gist_id}","starred_url":"https://api.github.com/users/oowekyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oowekyala/subscriptions","organizations_url":"https://api.github.com/users/oowekyala/orgs","repos_url":"https://api.github.com/users/oowekyala/repos","events_url":"https://api.github.com/users/oowekyala/events{/privacy}","received_events_url":"https://api.github.com/users/oowekyala/received_events","type":"User","site_admin":false},"body":"Maybe the rule message can be improved by using the placeholder `{0}`, which will be replaced by the image of the matched node, i.e. by the number. E.g. `Number {0} should separate every third digit with an underscore`. This message also passes when the violation is because of misplaced underscores","created_at":"2018-11-08T17:43:27Z","updated_at":"2018-11-08T17:46:52Z","html_url":"https://github.com/pmd/pmd/pull/1384#discussion_r231995569","pull_request_url":"https://api.github.com/repos/pmd/pmd/pulls/1384","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pmd/pmd/pulls/comments/231995569"},"html":{"href":"https://github.com/pmd/pmd/pull/1384#discussion_r231995569"},"pull_request":{"href":"https://api.github.com/repos/pmd/pmd/pulls/1384"}}},"pull_request":{"url":"https://api.github.com/repos/pmd/pmd/pulls/1384","id":222733778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzMzNzc4","html_url":"https://github.com/pmd/pmd/pull/1384","diff_url":"https://github.com/pmd/pmd/pull/1384.diff","patch_url":"https://github.com/pmd/pmd/pull/1384.patch","issue_url":"https://api.github.com/repos/pmd/pmd/issues/1384","number":1384,"state":"open","locked":false,"title":"[java] New Rule - NumericLiteralConvention","user":{"login":"rajeshggwp","id":8025160,"node_id":"MDQ6VXNlcjgwMjUxNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/8025160?v=4","gravatar_id":"","url":"https://api.github.com/users/rajeshggwp","html_url":"https://github.com/rajeshggwp","followers_url":"https://api.github.com/users/rajeshggwp/followers","following_url":"https://api.github.com/users/rajeshggwp/following{/other_user}","gists_url":"https://api.github.com/users/rajeshggwp/gists{/gist_id}","starred_url":"https://api.github.com/users/rajeshggwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajeshggwp/subscriptions","organizations_url":"https://api.github.com/users/rajeshggwp/orgs","repos_url":"https://api.github.com/users/rajeshggwp/repos","events_url":"https://api.github.com/users/rajeshggwp/events{/privacy}","received_events_url":"https://api.github.com/users/rajeshggwp/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease, prefix the PR title with the language it applies to within brackets, such as *[java]* or *[apex]*. If not specific to a language, you can use *[core]*\r\n-->\r\n\r\nBefore submitting a PR, please check that:\r\n - [x] The PR is submitted against `master`. The PMD team will merge back to support branches as needed.\r\n - [x] `./mvnw clean verify` passes. This will [build](https://github.com/pmd/pmd/blob/master/BUILDING.md) and test PMD, execute PMD and checkstyle rules. [Check this for more info](https://github.com/pmd/pmd/blob/master/CONTRIBUTING.md#code-style)\r\n\r\n**PR Description:**\r\nResolves #1232\r\n","created_at":"2018-10-14T18:27:43Z","updated_at":"2018-11-08T17:46:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abf800e32c4ba2bda6ae612a36379d0e14f9aaeb","assignee":{"login":"jsotuyod","id":802626,"node_id":"MDQ6VXNlcjgwMjYyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/802626?v=4","gravatar_id":"","url":"https://api.github.com/users/jsotuyod","html_url":"https://github.com/jsotuyod","followers_url":"https://api.github.com/users/jsotuyod/followers","following_url":"https://api.github.com/users/jsotuyod/following{/other_user}","gists_url":"https://api.github.com/users/jsotuyod/gists{/gist_id}","starred_url":"https://api.github.com/users/jsotuyod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsotuyod/subscriptions","organizations_url":"https://api.github.com/users/jsotuyod/orgs","repos_url":"https://api.github.com/users/jsotuyod/repos","events_url":"https://api.github.com/users/jsotuyod/events{/privacy}","received_events_url":"https://api.github.com/users/jsotuyod/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsotuyod","id":802626,"node_id":"MDQ6VXNlcjgwMjYyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/802626?v=4","gravatar_id":"","url":"https://api.github.com/users/jsotuyod","html_url":"https://github.com/jsotuyod","followers_url":"https://api.github.com/users/jsotuyod/followers","following_url":"https://api.github.com/users/jsotuyod/following{/other_user}","gists_url":"https://api.github.com/users/jsotuyod/gists{/gist_id}","starred_url":"https://api.github.com/users/jsotuyod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsotuyod/subscriptions","organizations_url":"https://api.github.com/users/jsotuyod/orgs","repos_url":"https://api.github.com/users/jsotuyod/repos","events_url":"https://api.github.com/users/jsotuyod/events{/privacy}","received_events_url":"https://api.github.com/users/jsotuyod/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484475155,"node_id":"MDU6TGFiZWw0ODQ0NzUxNTU=","url":"https://api.github.com/repos/pmd/pmd/labels/a:new-rule","name":"a:new-rule","color":"c2e0c6","default":false},{"id":493190983,"node_id":"MDU6TGFiZWw0OTMxOTA5ODM=","url":"https://api.github.com/repos/pmd/pmd/labels/is:WIP","name":"is:WIP","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/pmd/pmd/milestones/27","html_url":"https://github.com/pmd/pmd/milestone/27","labels_url":"https://api.github.com/repos/pmd/pmd/milestones/27/labels","id":3774002,"node_id":"MDk6TWlsZXN0b25lMzc3NDAwMg==","number":27,"title":"6.10.0","description":"","creator":{"login":"adangel","id":1573684,"node_id":"MDQ6VXNlcjE1NzM2ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1573684?v=4","gravatar_id":"","url":"https://api.github.com/users/adangel","html_url":"https://github.com/adangel","followers_url":"https://api.github.com/users/adangel/followers","following_url":"https://api.github.com/users/adangel/following{/other_user}","gists_url":"https://api.github.com/users/adangel/gists{/gist_id}","starred_url":"https://api.github.com/users/adangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adangel/subscriptions","organizations_url":"https://api.github.com/users/adangel/orgs","repos_url":"https://api.github.com/users/adangel/repos","events_url":"https://api.github.com/users/adangel/events{/privacy}","received_events_url":"https://api.github.com/users/adangel/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":9,"state":"open","created_at":"2018-10-27T18:00:13Z","updated_at":"2018-11-06T08:15:15Z","due_on":"2018-11-25T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pmd/pmd/pulls/1384/commits","review_comments_url":"https://api.github.com/repos/pmd/pmd/pulls/1384/comments","review_comment_url":"https://api.github.com/repos/pmd/pmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmd/pmd/issues/1384/comments","statuses_url":"https://api.github.com/repos/pmd/pmd/statuses/fd145e30b222dd9463e44d3f93620f78b524af44","head":{"label":"rajeshggwp:master","ref":"master","sha":"fd145e30b222dd9463e44d3f93620f78b524af44","user":{"login":"rajeshggwp","id":8025160,"node_id":"MDQ6VXNlcjgwMjUxNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/8025160?v=4","gravatar_id":"","url":"https://api.github.com/users/rajeshggwp","html_url":"https://github.com/rajeshggwp","followers_url":"https://api.github.com/users/rajeshggwp/followers","following_url":"https://api.github.com/users/rajeshggwp/following{/other_user}","gists_url":"https://api.github.com/users/rajeshggwp/gists{/gist_id}","starred_url":"https://api.github.com/users/rajeshggwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajeshggwp/subscriptions","organizations_url":"https://api.github.com/users/rajeshggwp/orgs","repos_url":"https://api.github.com/users/rajeshggwp/repos","events_url":"https://api.github.com/users/rajeshggwp/events{/privacy}","received_events_url":"https://api.github.com/users/rajeshggwp/received_events","type":"User","site_admin":false},"repo":{"id":151837936,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE4Mzc5MzY=","name":"pmd","full_name":"rajeshggwp/pmd","private":false,"owner":{"login":"rajeshggwp","id":8025160,"node_id":"MDQ6VXNlcjgwMjUxNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/8025160?v=4","gravatar_id":"","url":"https://api.github.com/users/rajeshggwp","html_url":"https://github.com/rajeshggwp","followers_url":"https://api.github.com/users/rajeshggwp/followers","following_url":"https://api.github.com/users/rajeshggwp/following{/other_user}","gists_url":"https://api.github.com/users/rajeshggwp/gists{/gist_id}","starred_url":"https://api.github.com/users/rajeshggwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajeshggwp/subscriptions","organizations_url":"https://api.github.com/users/rajeshggwp/orgs","repos_url":"https://api.github.com/users/rajeshggwp/repos","events_url":"https://api.github.com/users/rajeshggwp/events{/privacy}","received_events_url":"https://api.github.com/users/rajeshggwp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rajeshggwp/pmd","description":"An extensible multilanguage static code analyzer.","fork":true,"url":"https://api.github.com/repos/rajeshggwp/pmd","forks_url":"https://api.github.com/repos/rajeshggwp/pmd/forks","keys_url":"https://api.github.com/repos/rajeshggwp/pmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajeshggwp/pmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajeshggwp/pmd/teams","hooks_url":"https://api.github.com/repos/rajeshggwp/pmd/hooks","issue_events_url":"https://api.github.com/repos/rajeshggwp/pmd/issues/events{/number}","events_url":"https://api.github.com/repos/rajeshggwp/pmd/events","assignees_url":"https://api.github.com/repos/rajeshggwp/pmd/assignees{/user}","branches_url":"https://api.github.com/repos/rajeshggwp/pmd/branches{/branch}","tags_url":"https://api.github.com/repos/rajeshggwp/pmd/tags","blobs_url":"https://api.github.com/repos/rajeshggwp/pmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajeshggwp/pmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajeshggwp/pmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajeshggwp/pmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajeshggwp/pmd/statuses/{sha}","languages_url":"https://api.github.com/repos/rajeshggwp/pmd/languages","stargazers_url":"https://api.github.com/repos/rajeshggwp/pmd/stargazers","contributors_url":"https://api.github.com/repos/rajeshggwp/pmd/contributors","subscribers_url":"https://api.github.com/repos/rajeshggwp/pmd/subscribers","subscription_url":"https://api.github.com/repos/rajeshggwp/pmd/subscription","commits_url":"https://api.github.com/repos/rajeshggwp/pmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajeshggwp/pmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajeshggwp/pmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajeshggwp/pmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajeshggwp/pmd/contents/{+path}","compare_url":"https://api.github.com/repos/rajeshggwp/pmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajeshggwp/pmd/merges","archive_url":"https://api.github.com/repos/rajeshggwp/pmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajeshggwp/pmd/downloads","issues_url":"https://api.github.com/repos/rajeshggwp/pmd/issues{/number}","pulls_url":"https://api.github.com/repos/rajeshggwp/pmd/pulls{/number}","milestones_url":"https://api.github.com/repos/rajeshggwp/pmd/milestones{/number}","notifications_url":"https://api.github.com/repos/rajeshggwp/pmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajeshggwp/pmd/labels{/name}","releases_url":"https://api.github.com/repos/rajeshggwp/pmd/releases{/id}","deployments_url":"https://api.github.com/repos/rajeshggwp/pmd/deployments","created_at":"2018-10-06T12:30:13Z","updated_at":"2018-11-08T17:23:11Z","pushed_at":"2018-11-08T17:23:08Z","git_url":"git://github.com/rajeshggwp/pmd.git","ssh_url":"git@github.com:rajeshggwp/pmd.git","clone_url":"https://github.com/rajeshggwp/pmd.git","svn_url":"https://github.com/rajeshggwp/pmd","homepage":"https://pmd.github.io","size":249965,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pmd:master","ref":"master","sha":"0c1afc426debff979b25219dbc8f4e07c76645b5","user":{"login":"pmd","id":1958157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTgxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1958157?v=4","gravatar_id":"","url":"https://api.github.com/users/pmd","html_url":"https://github.com/pmd","followers_url":"https://api.github.com/users/pmd/followers","following_url":"https://api.github.com/users/pmd/following{/other_user}","gists_url":"https://api.github.com/users/pmd/gists{/gist_id}","starred_url":"https://api.github.com/users/pmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmd/subscriptions","organizations_url":"https://api.github.com/users/pmd/orgs","repos_url":"https://api.github.com/users/pmd/repos","events_url":"https://api.github.com/users/pmd/events{/privacy}","received_events_url":"https://api.github.com/users/pmd/received_events","type":"Organization","site_admin":false},"repo":{"id":4992906,"node_id":"MDEwOlJlcG9zaXRvcnk0OTkyOTA2","name":"pmd","full_name":"pmd/pmd","private":false,"owner":{"login":"pmd","id":1958157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTgxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1958157?v=4","gravatar_id":"","url":"https://api.github.com/users/pmd","html_url":"https://github.com/pmd","followers_url":"https://api.github.com/users/pmd/followers","following_url":"https://api.github.com/users/pmd/following{/other_user}","gists_url":"https://api.github.com/users/pmd/gists{/gist_id}","starred_url":"https://api.github.com/users/pmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmd/subscriptions","organizations_url":"https://api.github.com/users/pmd/orgs","repos_url":"https://api.github.com/users/pmd/repos","events_url":"https://api.github.com/users/pmd/events{/privacy}","received_events_url":"https://api.github.com/users/pmd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pmd/pmd","description":"An extensible multilanguage static code analyzer.","fork":false,"url":"https://api.github.com/repos/pmd/pmd","forks_url":"https://api.github.com/repos/pmd/pmd/forks","keys_url":"https://api.github.com/repos/pmd/pmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmd/pmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmd/pmd/teams","hooks_url":"https://api.github.com/repos/pmd/pmd/hooks","issue_events_url":"https://api.github.com/repos/pmd/pmd/issues/events{/number}","events_url":"https://api.github.com/repos/pmd/pmd/events","assignees_url":"https://api.github.com/repos/pmd/pmd/assignees{/user}","branches_url":"https://api.github.com/repos/pmd/pmd/branches{/branch}","tags_url":"https://api.github.com/repos/pmd/pmd/tags","blobs_url":"https://api.github.com/repos/pmd/pmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmd/pmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmd/pmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmd/pmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmd/pmd/statuses/{sha}","languages_url":"https://api.github.com/repos/pmd/pmd/languages","stargazers_url":"https://api.github.com/repos/pmd/pmd/stargazers","contributors_url":"https://api.github.com/repos/pmd/pmd/contributors","subscribers_url":"https://api.github.com/repos/pmd/pmd/subscribers","subscription_url":"https://api.github.com/repos/pmd/pmd/subscription","commits_url":"https://api.github.com/repos/pmd/pmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmd/pmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmd/pmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmd/pmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmd/pmd/contents/{+path}","compare_url":"https://api.github.com/repos/pmd/pmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmd/pmd/merges","archive_url":"https://api.github.com/repos/pmd/pmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmd/pmd/downloads","issues_url":"https://api.github.com/repos/pmd/pmd/issues{/number}","pulls_url":"https://api.github.com/repos/pmd/pmd/pulls{/number}","milestones_url":"https://api.github.com/repos/pmd/pmd/milestones{/number}","notifications_url":"https://api.github.com/repos/pmd/pmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmd/pmd/labels{/name}","releases_url":"https://api.github.com/repos/pmd/pmd/releases{/id}","deployments_url":"https://api.github.com/repos/pmd/pmd/deployments","created_at":"2012-07-11T18:03:00Z","updated_at":"2018-11-08T10:57:55Z","pushed_at":"2018-11-08T17:23:11Z","git_url":"git://github.com/pmd/pmd.git","ssh_url":"git@github.com:pmd/pmd.git","clone_url":"https://github.com/pmd/pmd.git","svn_url":"https://github.com/pmd/pmd","homepage":"https://pmd.github.io","size":251542,"stargazers_count":1896,"watchers_count":1896,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":663,"mirror_url":null,"archived":false,"open_issues_count":201,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":663,"open_issues":201,"watchers":1896,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmd/pmd/pulls/1384"},"html":{"href":"https://github.com/pmd/pmd/pull/1384"},"issue":{"href":"https://api.github.com/repos/pmd/pmd/issues/1384"},"comments":{"href":"https://api.github.com/repos/pmd/pmd/issues/1384/comments"},"review_comments":{"href":"https://api.github.com/repos/pmd/pmd/pulls/1384/comments"},"review_comment":{"href":"https://api.github.com/repos/pmd/pmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmd/pmd/pulls/1384/commits"},"statuses":{"href":"https://api.github.com/repos/pmd/pmd/statuses/fd145e30b222dd9463e44d3f93620f78b524af44"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"oowekyala"}}