{"action":"closed","number":23883,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/23883","id":187685864,"html_url":"https://github.com/angular/angular/pull/23883","diff_url":"https://github.com/angular/angular/pull/23883.diff","patch_url":"https://github.com/angular/angular/pull/23883.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/23883","number":23883,"state":"closed","locked":false,"title":"refactor(ivy): rename `PipeDef.n` to `PipeDef.factory`","user":{"login":"JoostK","id":123679,"avatar_url":"https://avatars3.githubusercontent.com/u/123679?v=4","gravatar_id":"","url":"https://api.github.com/users/JoostK","html_url":"https://github.com/JoostK","followers_url":"https://api.github.com/users/JoostK/followers","following_url":"https://api.github.com/users/JoostK/following{/other_user}","gists_url":"https://api.github.com/users/JoostK/gists{/gist_id}","starred_url":"https://api.github.com/users/JoostK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoostK/subscriptions","organizations_url":"https://api.github.com/users/JoostK/orgs","repos_url":"https://api.github.com/users/JoostK/repos","events_url":"https://api.github.com/users/JoostK/events{/privacy}","received_events_url":"https://api.github.com/users/JoostK/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[ ] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[x] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n\r\nA vague property name for a pipe's factory function was used.\r\n\r\n## What is the new behavior?\r\n\r\nA descriptive property name is used, equal to `DirectiveDef`.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n## Other information\r\n\r\nThe original reason for this property to be short no longer holds true, as pipes always need to be defined using `definePipe`.","created_at":"2018-05-13T19:21:43Z","updated_at":"2018-05-30T16:57:32Z","closed_at":"2018-05-30T16:57:32Z","merged_at":null,"merge_commit_sha":"c351b799c150afbe9f8a13419ce4259ba6ee2848","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":133556520,"url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge","name":"PR action: merge","color":"99ff66","default":false},{"id":660621334,"url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master-only","name":"PR target: master-only","color":"5319e7","default":false},{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":799860804,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20ivy","name":"comp: ivy","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/23883/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/23883/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/23883/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/03f1dd4058ad37cb74ffba51f482dce729ab1c9b","head":{"label":"JoostK:ivy-pipedef-refactoring","ref":"ivy-pipedef-refactoring","sha":"03f1dd4058ad37cb74ffba51f482dce729ab1c9b","user":{"login":"JoostK","id":123679,"avatar_url":"https://avatars3.githubusercontent.com/u/123679?v=4","gravatar_id":"","url":"https://api.github.com/users/JoostK","html_url":"https://github.com/JoostK","followers_url":"https://api.github.com/users/JoostK/followers","following_url":"https://api.github.com/users/JoostK/following{/other_user}","gists_url":"https://api.github.com/users/JoostK/gists{/gist_id}","starred_url":"https://api.github.com/users/JoostK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoostK/subscriptions","organizations_url":"https://api.github.com/users/JoostK/orgs","repos_url":"https://api.github.com/users/JoostK/repos","events_url":"https://api.github.com/users/JoostK/events{/privacy}","received_events_url":"https://api.github.com/users/JoostK/received_events","type":"User","site_admin":false},"repo":{"id":107854570,"name":"angular","full_name":"JoostK/angular","owner":{"login":"JoostK","id":123679,"avatar_url":"https://avatars3.githubusercontent.com/u/123679?v=4","gravatar_id":"","url":"https://api.github.com/users/JoostK","html_url":"https://github.com/JoostK","followers_url":"https://api.github.com/users/JoostK/followers","following_url":"https://api.github.com/users/JoostK/following{/other_user}","gists_url":"https://api.github.com/users/JoostK/gists{/gist_id}","starred_url":"https://api.github.com/users/JoostK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoostK/subscriptions","organizations_url":"https://api.github.com/users/JoostK/orgs","repos_url":"https://api.github.com/users/JoostK/repos","events_url":"https://api.github.com/users/JoostK/events{/privacy}","received_events_url":"https://api.github.com/users/JoostK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JoostK/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/JoostK/angular","forks_url":"https://api.github.com/repos/JoostK/angular/forks","keys_url":"https://api.github.com/repos/JoostK/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoostK/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoostK/angular/teams","hooks_url":"https://api.github.com/repos/JoostK/angular/hooks","issue_events_url":"https://api.github.com/repos/JoostK/angular/issues/events{/number}","events_url":"https://api.github.com/repos/JoostK/angular/events","assignees_url":"https://api.github.com/repos/JoostK/angular/assignees{/user}","branches_url":"https://api.github.com/repos/JoostK/angular/branches{/branch}","tags_url":"https://api.github.com/repos/JoostK/angular/tags","blobs_url":"https://api.github.com/repos/JoostK/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoostK/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoostK/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoostK/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoostK/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/JoostK/angular/languages","stargazers_url":"https://api.github.com/repos/JoostK/angular/stargazers","contributors_url":"https://api.github.com/repos/JoostK/angular/contributors","subscribers_url":"https://api.github.com/repos/JoostK/angular/subscribers","subscription_url":"https://api.github.com/repos/JoostK/angular/subscription","commits_url":"https://api.github.com/repos/JoostK/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoostK/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoostK/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoostK/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoostK/angular/contents/{+path}","compare_url":"https://api.github.com/repos/JoostK/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoostK/angular/merges","archive_url":"https://api.github.com/repos/JoostK/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoostK/angular/downloads","issues_url":"https://api.github.com/repos/JoostK/angular/issues{/number}","pulls_url":"https://api.github.com/repos/JoostK/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/JoostK/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/JoostK/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoostK/angular/labels{/name}","releases_url":"https://api.github.com/repos/JoostK/angular/releases{/id}","deployments_url":"https://api.github.com/repos/JoostK/angular/deployments","created_at":"2017-10-22T09:58:30Z","updated_at":"2018-05-22T20:27:31Z","pushed_at":"2018-05-27T13:26:59Z","git_url":"git://github.com/JoostK/angular.git","ssh_url":"git@github.com:JoostK/angular.git","clone_url":"https://github.com/JoostK/angular.git","svn_url":"https://github.com/JoostK/angular","homepage":"https://angular.io","size":78890,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"d4b8b2440673049c58d51b0ae4afceb028d62cc0","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-05-30T16:56:03Z","pushed_at":"2018-05-30T16:57:15Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":79973,"stargazers_count":36695,"watchers_count":36695,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8888,"mirror_url":null,"archived":false,"open_issues_count":2411,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8888,"open_issues":2411,"watchers":36695,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/23883"},"html":{"href":"https://github.com/angular/angular/pull/23883"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/23883"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/23883/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/23883/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/23883/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/03f1dd4058ad37cb74ffba51f482dce729ab1c9b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"vicb"}}