{"action":"closed","issue":{"url":"https://api.github.com/repos/googleapis/google-cloud-node/issues/2869","repository_url":"https://api.github.com/repos/googleapis/google-cloud-node","labels_url":"https://api.github.com/repos/googleapis/google-cloud-node/issues/2869/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-node/issues/2869/comments","events_url":"https://api.github.com/repos/googleapis/google-cloud-node/issues/2869/events","html_url":"https://github.com/googleapis/google-cloud-node/issues/2869","id":366900148,"node_id":"MDU6SXNzdWUzNjY5MDAxNDg=","number":2869,"title":"Update all samples to use async/await","user":{"login":"JustinBeckwith","id":534619,"node_id":"MDQ6VXNlcjUzNDYxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"labels":[{"id":1066916508,"node_id":"MDU6TGFiZWwxMDY2OTE2NTA4","url":"https://api.github.com/repos/googleapis/google-cloud-node/labels/help%20wanted","name":"help wanted","color":"0ed11e","default":true},{"id":944195317,"node_id":"MDU6TGFiZWw5NDQxOTUzMTc=","url":"https://api.github.com/repos/googleapis/google-cloud-node/labels/type:%20process","name":"type: process","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-04T17:47:41Z","updated_at":"2018-11-15T18:50:46Z","closed_at":"2018-11-15T18:50:46Z","author_association":"CONTRIBUTOR","body":"Most of our samples are using promises for async programming, which is great.  Now that Node 8 is the latest LTS, and 10 is about to go out - we should start converting all the samples to async/await.  Lets use this as a high level tracking bug.  \r\n\r\n- [x] [googleapis/google-api-nodejs-client](https://github.com/googleapis/google-api-nodejs-client)\r\n- [x] [googleapis/google-auth-library-nodejs](https://github.com/googleapis/google-auth-library-nodejs)\r\n- [ ] [googleapis/nodejs-spanner](https://github.com/googleapis/nodejs-spanner)\r\n- [ ] [googleapis/nodejs-firestore](https://github.com/googleapis/nodejs-firestore)\r\n- [ ] [googleapis/nodejs-compute](https://github.com/googleapis/nodejs-compute)\r\n- [ ] [googleapis/nodejs-bigtable](https://github.com/googleapis/nodejs-bigtable)\r\n- [x] [googleapis/nodejs-common-grpc](https://github.com/googleapis/nodejs-common-grpc)\r\n- [x] [googleapis/nodejs-common](https://github.com/googleapis/nodejs-common)\r\n- [ ] [googleapis/nodejs-kms](https://github.com/googleapis/nodejs-kms)\r\n- [ ] [googleapis/nodejs-iot](https://github.com/googleapis/nodejs-iot)\r\n- [ ] [googleapis/nodejs-error-reporting](https://github.com/googleapis/nodejs-error-reporting)\r\n- [ ] [googleapis/nodejs-redis](https://github.com/googleapis/nodejs-redis)\r\n- [ ] [googleapis/nodejs-vision](https://github.com/googleapis/nodejs-vision)\r\n- [x] [googleapis/gax-nodejs](https://github.com/googleapis/gax-nodejs)\r\n- [x] [googleapis/nodejs-translate](https://github.com/googleapis/nodejs-translate)\r\n- [ ] [googleapis/nodejs-text-to-speech](https://github.com/googleapis/nodejs-text-to-speech)\r\n- [ ] [googleapis/nodejs-os-login](https://github.com/googleapis/nodejs-os-login)\r\n- [ ] [googleapis/nodejs-dataproc](https://github.com/googleapis/nodejs-dataproc)\r\n- [ ] [googleapis/nodejs-bigquery-data-transfer](https://github.com/googleapis/nodejs-bigquery-data-transfer)\r\n- [ ] [googleapis/nodejs-video-intelligence](https://github.com/googleapis/nodejs-video-intelligence)\r\n- [ ] [googleapis/nodejs-speech](https://github.com/googleapis/nodejs-speech)\r\n- [ ] [googleapis/nodejs-resource](https://github.com/googleapis/nodejs-resource)\r\n- [ ] [googleapis/nodejs-pubsub](https://github.com/googleapis/nodejs-pubsub)\r\n- [ ] [googleapis/nodejs-monitoring](https://github.com/googleapis/nodejs-monitoring)\r\n- [ ] [googleapis/nodejs-logging-winston](https://github.com/googleapis/nodejs-logging-winston)\r\n- [ ] [googleapis/nodejs-logging](https://github.com/googleapis/nodejs-logging)\r\n- [ ] [googleapis/nodejs-logging-bunyan](https://github.com/googleapis/nodejs-logging-bunyan)\r\n- [ ] [googleapis/nodejs-language](https://github.com/googleapis/nodejs-language)\r\n- [ ] [googleapis/nodejs-dns](https://github.com/googleapis/nodejs-dns)\r\n- [ ] [googleapis/nodejs-dlp](https://github.com/googleapis/nodejs-dlp)\r\n- [ ] [googleapis/nodejs-datastore](https://github.com/googleapis/nodejs-datastore)\r\n- [ ] [googleapis/nodejs-bigquery](https://github.com/googleapis/nodejs-bigquery)\r\n- [ ] [googleapis/nodejs-cloud-container](https://github.com/googleapis/nodejs-cloud-container)\r\n- [x] [googleapis/nodejs-proto-files](https://github.com/googleapis/nodejs-proto-files)\r\n- [ ] [googleapis/nodejs-storage](https://github.com/googleapis/nodejs-storage)\r\n- [ ] [googleapis/nodejs-automl](https://github.com/googleapis/nodejs-automl)\r\n- [x] [googleapis/nodejs-promisify](https://github.com/googleapis/nodejs-promisify)\r\n- [x] [googleapis/nodejs-projectify](https://github.com/googleapis/nodejs-projectify)\r\n- [x] [googleapis/nodejs-paginator](https://github.com/googleapis/nodejs-paginator)\r\n- [x] [googleapis/google-p12-pem](https://github.com/googleapis/google-p12-pem)\r\n- [x] [googleapis/node-gtoken](https://github.com/googleapis/node-gtoken)\r\n- [ ] [googleapis/nodejs-tasks](https://github.com/googleapis/nodejs-tasks)\r\n- [ ] [googleapis/google-cloud-node](https://github.com/googleapis/google-cloud-node)\r\n- [ ] [googleapis/cloud-trace-nodejs](https://github.com/googleapis/cloud-trace-nodejs)\r\n- [ ] [googleapis/cloud-debug-nodejs](https://github.com/googleapis/cloud-debug-nodejs)\r\n- [ ] [googleapis/github-repo-automation](https://github.com/googleapis/github-repo-automation)\r\n- [ ] [GoogleCloudPlatform/cloud-profiler-nodejs](https://github.com/GoogleCloudPlatform/cloud-profiler-nodejs)\r\n- [x] [googleapis/gcs-resumable-upload](https://github.com/googleapis/gcs-resumable-upload)\r\n- [x] [googleapis/gcp-metadata](https://github.com/googleapis/gcp-metadata)\r\n- [x] [googleapis/google-cloud-kvstore](https://github.com/googleapis/google-cloud-kvstore)\r\n- [x] [googleapis/gce-images](https://github.com/googleapis/gce-images)\r\n- [x] [googleapis/nodejs-googleapis-common](https://github.com/googleapis/nodejs-googleapis-common)\r\n- [ ] [googleapis/nodejs-asset](https://github.com/googleapis/nodejs-asset)\r\n- [x] [googleapis/sloth](https://github.com/googleapis/sloth)\r\n- [ ] [googleapis/nodejs-dialogflow](https://github.com/googleapis/nodejs-dialogflow)\r\n\r\n@sduskis this is something that we should have our new friends help with :)\r\n\r\nTo call out the specific work:\r\n- All samples should use `async` or `await` instead of promises or callbacks\r\n- We can remove all of the catch clauses that just print the output to console.error (a throw will do that anyway)"}}
{"actor":{"display_login":"JustinBeckwith"}}