{"action":"created","issue":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5461","repository_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore","labels_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5461/labels{/name}","comments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5461/comments","events_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5461/events","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5461","id":382452194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTU4MDE0","number":5461,"title":"WIP: Feature - #3663 - Add importing OT projects","user":{"login":"richmahn","id":2839925,"node_id":"MDQ6VXNlcjI4Mzk5MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2839925?v=4","gravatar_id":"","url":"https://api.github.com/users/richmahn","html_url":"https://github.com/richmahn","followers_url":"https://api.github.com/users/richmahn/followers","following_url":"https://api.github.com/users/richmahn/following{/other_user}","gists_url":"https://api.github.com/users/richmahn/gists{/gist_id}","starred_url":"https://api.github.com/users/richmahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richmahn/subscriptions","organizations_url":"https://api.github.com/users/richmahn/orgs","repos_url":"https://api.github.com/users/richmahn/repos","events_url":"https://api.github.com/users/richmahn/events{/privacy}","received_events_url":"https://api.github.com/users/richmahn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-20T00:46:11Z","updated_at":"2018-11-20T00:56:48Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/5461","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5461","diff_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5461.diff","patch_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5461.patch"},"body":"#### Describe what your pull request addresses (Please include relevant issue numbers):\r\n- Makes it so all restriction of New Testament Only is removed, especially for Online Import from Door43, per #3663 \r\n\r\n#### Please include detailed Test instructions for your pull request:\r\n- Check out this branch in tC and make sure all packages and apps are up to date\r\n- Load tC, on the project page do an Online Import. Make sure you can get any OT book from Door43 using the search by book in the interface\r\n- Make sure even OT book names are localized\r\n\r\n#### Standard Test Instructions for PR Review Process:\r\n\r\n- [ ] Double check unit tests that have been written\r\n- [ ] Check for documentation for code changes\r\n- [ ] Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR\r\n- [ ] Checkout the branch locally and ensure that app runs as expected\r\n  - [ ] Ensure tests pass\r\n  - [ ] Open and watch the console for errors\r\n  - [ ] Make sure all actions perform as expected\r\n  - [ ] Import and Load a new Project\r\n  - [ ] Load a tool and perform basic actions\r\n  - [ ] Switch tools and perform basic actions\r\n  - [ ] Switch project to an existing project\r\n  - [ ] Load a tool and perform basic actions\r\n  - [ ] Switch tools and perform basic actions\r\n  - [ ] Next time reverse the order of importing after loading an existing project\r\n- [ ] Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story\r\n- [ ] Ask Ben or Koz if you have any concerns about implementation (especially UI related)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/unfoldingword-dev/translationcore/5461)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/comments/440096981","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5461#issuecomment-440096981","issue_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5461","id":440096981,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDA5Njk4MQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-11-20T00:56:48Z","updated_at":"2018-11-20T00:56:48Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461?src=pr&el=h1) Report\n> Merging [#5461](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461?src=pr&el=desc) into [develop](https://codecov.io/gh/unfoldingWord-dev/translationCore/commit/ecd6dc51fb9f5a39c7e04ad57c0144ccce7090db?src=pr&el=desc) will **increase** coverage by `0.07%`.\n> The diff coverage is `62.5%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461/graphs/tree.svg?width=650&token=JX8FJXc5PX&height=150&src=pr)](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff             @@\n##           develop    #5461      +/-   ##\n===========================================\n+ Coverage    59.24%   59.31%   +0.07%     \n===========================================\n  Files          263      263              \n  Lines         8416     8419       +3     \n  Branches      1381     1381              \n===========================================\n+ Hits          4986     4994       +8     \n+ Misses        3000     2998       -2     \n+ Partials       430      427       -3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...dation/ProjectInformationCheck/BookDropdownMenu.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461/diff?src=pr&el=tree#diff-c3JjL2pzL2NvbXBvbmVudHMvcHJvamVjdFZhbGlkYXRpb24vUHJvamVjdEluZm9ybWF0aW9uQ2hlY2svQm9va0Ryb3Bkb3duTWVudS5qcw==) | `85.71% <ø> (ø)` | :arrow_up: |\n| [...tsManagement/OnlineImportModal/BookDropDownMenu.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461/diff?src=pr&el=tree#diff-c3JjL2pzL2NvbXBvbmVudHMvaG9tZS9wcm9qZWN0c01hbmFnZW1lbnQvT25saW5lSW1wb3J0TW9kYWwvQm9va0Ryb3BEb3duTWVudS5qcw==) | `87.5% <100%> (+1.78%)` | :arrow_up: |\n| [src/js/helpers/ProjectDetailsHelpers.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461/diff?src=pr&el=tree#diff-c3JjL2pzL2hlbHBlcnMvUHJvamVjdERldGFpbHNIZWxwZXJzLmpz) | `88.59% <100%> (+0.05%)` | :arrow_up: |\n| [src/js/helpers/localizationHelpers.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461/diff?src=pr&el=tree#diff-c3JjL2pzL2hlbHBlcnMvbG9jYWxpemF0aW9uSGVscGVycy5qcw==) | `82% <25%> (+10.57%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461?src=pr&el=footer). Last update [ecd6dc5...2c88c9e](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5461?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}