{"action":"created","comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments/189127790","pull_request_review_id":121248231,"id":189127790,"diff_hunk":"@@ -105,9 +105,14 @@\n     <inspection_tool class=\"AssignmentUsedAsCondition\" enabled=\"true\" level=\"ERROR\" enabled_by_default=\"true\" />\n     <!-- we are ok to use auto-boxing as we use modern java -->\n     <inspection_tool class=\"AutoBoxing\" enabled=\"false\" level=\"ERROR\" enabled_by_default=\"false\" />\n-    <!-- we can not use try-with-resource till we switch to jacoco for code coverage -->\n-    <inspection_tool class=\"AutoCloseableResource\" enabled=\"false\" level=\"ERROR\" enabled_by_default=\"false\" />\n-    <!-- we are ok to use auto-unboxing as we use modern java -->\n+    <inspection_tool class=\"AutoCloseableResource\" enabled=\"true\" level=\"ERROR\" enabled_by_default=\"true\">\n+        <!-- These classes do not contain any resources that need to be closed. -->\n+        <option name=\"ignoredTypes\" value=\"java.io.ByteArrayOutputStream,java.util.stream.Stream,java.util.stream.IntStream,java.util.stream.LongStream,java.util.stream.DoubleStream,com.puppycrawl.tools.checkstyle.internal.utils.CloseAndFlushTestByteArrayOutputStream\" />","path":"config/intellij-idea-inspections.xml","position":9,"original_position":9,"commit_id":"f91daec88847774cb3f7e85699b1ec06bad27dd4","original_commit_id":"f91daec88847774cb3f7e85699b1ec06bad27dd4","user":{"login":"pbludov","id":900805,"avatar_url":"https://avatars2.githubusercontent.com/u/900805?v=4","gravatar_id":"","url":"https://api.github.com/users/pbludov","html_url":"https://github.com/pbludov","followers_url":"https://api.github.com/users/pbludov/followers","following_url":"https://api.github.com/users/pbludov/following{/other_user}","gists_url":"https://api.github.com/users/pbludov/gists{/gist_id}","starred_url":"https://api.github.com/users/pbludov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbludov/subscriptions","organizations_url":"https://api.github.com/users/pbludov/orgs","repos_url":"https://api.github.com/users/pbludov/repos","events_url":"https://api.github.com/users/pbludov/events{/privacy}","received_events_url":"https://api.github.com/users/pbludov/received_events","type":"User","site_admin":false},"body":"done. If the CI fails, i'll revert this.","created_at":"2018-05-17T23:17:24Z","updated_at":"2018-05-17T23:17:25Z","html_url":"https://github.com/checkstyle/checkstyle/pull/5753#discussion_r189127790","pull_request_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5753","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments/189127790"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/5753#discussion_r189127790"},"pull_request":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5753"}},"in_reply_to_id":188250012},"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5753","id":183252312,"html_url":"https://github.com/checkstyle/checkstyle/pull/5753","diff_url":"https://github.com/checkstyle/checkstyle/pull/5753.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/5753.patch","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/5753","number":5753,"state":"open","locked":false,"title":"issue #5752: Activate checks related to java.io.Closeable","user":{"login":"pbludov","id":900805,"avatar_url":"https://avatars2.githubusercontent.com/u/900805?v=4","gravatar_id":"","url":"https://api.github.com/users/pbludov","html_url":"https://github.com/pbludov","followers_url":"https://api.github.com/users/pbludov/followers","following_url":"https://api.github.com/users/pbludov/following{/other_user}","gists_url":"https://api.github.com/users/pbludov/gists{/gist_id}","starred_url":"https://api.github.com/users/pbludov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbludov/subscriptions","organizations_url":"https://api.github.com/users/pbludov/orgs","repos_url":"https://api.github.com/users/pbludov/repos","events_url":"https://api.github.com/users/pbludov/events{/privacy}","received_events_url":"https://api.github.com/users/pbludov/received_events","type":"User","site_admin":false},"body":"Issue #5752 \r\n\r\nForce use of `try-with-resources`","created_at":"2018-04-22T02:44:28Z","updated_at":"2018-05-17T23:17:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe79075b992c3ccc155bc1711105fafe5cc8777a","assignee":{"login":"rnveach","id":5427943,"avatar_url":"https://avatars1.githubusercontent.com/u/5427943?v=4","gravatar_id":"","url":"https://api.github.com/users/rnveach","html_url":"https://github.com/rnveach","followers_url":"https://api.github.com/users/rnveach/followers","following_url":"https://api.github.com/users/rnveach/following{/other_user}","gists_url":"https://api.github.com/users/rnveach/gists{/gist_id}","starred_url":"https://api.github.com/users/rnveach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnveach/subscriptions","organizations_url":"https://api.github.com/users/rnveach/orgs","repos_url":"https://api.github.com/users/rnveach/repos","events_url":"https://api.github.com/users/rnveach/events{/privacy}","received_events_url":"https://api.github.com/users/rnveach/received_events","type":"User","site_admin":false},"assignees":[{"login":"rnveach","id":5427943,"avatar_url":"https://avatars1.githubusercontent.com/u/5427943?v=4","gravatar_id":"","url":"https://api.github.com/users/rnveach","html_url":"https://github.com/rnveach","followers_url":"https://api.github.com/users/rnveach/followers","following_url":"https://api.github.com/users/rnveach/following{/other_user}","gists_url":"https://api.github.com/users/rnveach/gists{/gist_id}","starred_url":"https://api.github.com/users/rnveach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnveach/subscriptions","organizations_url":"https://api.github.com/users/rnveach/orgs","repos_url":"https://api.github.com/users/rnveach/repos","events_url":"https://api.github.com/users/rnveach/events{/privacy}","received_events_url":"https://api.github.com/users/rnveach/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5753/commits","review_comments_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5753/comments","review_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/5753/comments","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/f91daec88847774cb3f7e85699b1ec06bad27dd4","head":{"label":"Softus:issue-5752","ref":"issue-5752","sha":"f91daec88847774cb3f7e85699b1ec06bad27dd4","user":{"login":"Softus","id":20538760,"avatar_url":"https://avatars0.githubusercontent.com/u/20538760?v=4","gravatar_id":"","url":"https://api.github.com/users/Softus","html_url":"https://github.com/Softus","followers_url":"https://api.github.com/users/Softus/followers","following_url":"https://api.github.com/users/Softus/following{/other_user}","gists_url":"https://api.github.com/users/Softus/gists{/gist_id}","starred_url":"https://api.github.com/users/Softus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Softus/subscriptions","organizations_url":"https://api.github.com/users/Softus/orgs","repos_url":"https://api.github.com/users/Softus/repos","events_url":"https://api.github.com/users/Softus/events{/privacy}","received_events_url":"https://api.github.com/users/Softus/received_events","type":"Organization","site_admin":false},"repo":{"id":107936114,"name":"checkstyle","full_name":"Softus/checkstyle","owner":{"login":"Softus","id":20538760,"avatar_url":"https://avatars0.githubusercontent.com/u/20538760?v=4","gravatar_id":"","url":"https://api.github.com/users/Softus","html_url":"https://github.com/Softus","followers_url":"https://api.github.com/users/Softus/followers","following_url":"https://api.github.com/users/Softus/following{/other_user}","gists_url":"https://api.github.com/users/Softus/gists{/gist_id}","starred_url":"https://api.github.com/users/Softus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Softus/subscriptions","organizations_url":"https://api.github.com/users/Softus/orgs","repos_url":"https://api.github.com/users/Softus/repos","events_url":"https://api.github.com/users/Softus/events{/privacy}","received_events_url":"https://api.github.com/users/Softus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Softus/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":true,"url":"https://api.github.com/repos/Softus/checkstyle","forks_url":"https://api.github.com/repos/Softus/checkstyle/forks","keys_url":"https://api.github.com/repos/Softus/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Softus/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Softus/checkstyle/teams","hooks_url":"https://api.github.com/repos/Softus/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/Softus/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/Softus/checkstyle/events","assignees_url":"https://api.github.com/repos/Softus/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/Softus/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/Softus/checkstyle/tags","blobs_url":"https://api.github.com/repos/Softus/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Softus/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Softus/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Softus/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Softus/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/Softus/checkstyle/languages","stargazers_url":"https://api.github.com/repos/Softus/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/Softus/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/Softus/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/Softus/checkstyle/subscription","commits_url":"https://api.github.com/repos/Softus/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Softus/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Softus/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Softus/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Softus/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/Softus/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Softus/checkstyle/merges","archive_url":"https://api.github.com/repos/Softus/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Softus/checkstyle/downloads","issues_url":"https://api.github.com/repos/Softus/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/Softus/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/Softus/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/Softus/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Softus/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/Softus/checkstyle/releases{/id}","deployments_url":"https://api.github.com/repos/Softus/checkstyle/deployments","created_at":"2017-10-23T05:31:34Z","updated_at":"2018-05-12T06:10:50Z","pushed_at":"2018-05-15T02:44:20Z","git_url":"git://github.com/Softus/checkstyle.git","ssh_url":"git@github.com:Softus/checkstyle.git","clone_url":"https://github.com/Softus/checkstyle.git","svn_url":"https://github.com/Softus/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":57890,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"checkstyle:master","ref":"master","sha":"f2275e0b77c787064d8fc671dafde4452f4c8662","user":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars0.githubusercontent.com/u/5179750?v=4","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"repo":{"id":12499251,"name":"checkstyle","full_name":"checkstyle/checkstyle","owner":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars0.githubusercontent.com/u/5179750?v=4","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/checkstyle/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":false,"url":"https://api.github.com/repos/checkstyle/checkstyle","forks_url":"https://api.github.com/repos/checkstyle/checkstyle/forks","keys_url":"https://api.github.com/repos/checkstyle/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/checkstyle/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/checkstyle/checkstyle/teams","hooks_url":"https://api.github.com/repos/checkstyle/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/checkstyle/checkstyle/events","assignees_url":"https://api.github.com/repos/checkstyle/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/checkstyle/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/checkstyle/checkstyle/tags","blobs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/checkstyle/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/checkstyle/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/checkstyle/checkstyle/languages","stargazers_url":"https://api.github.com/repos/checkstyle/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/checkstyle/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/checkstyle/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/checkstyle/checkstyle/subscription","commits_url":"https://api.github.com/repos/checkstyle/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/checkstyle/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/checkstyle/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/checkstyle/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/checkstyle/checkstyle/merges","archive_url":"https://api.github.com/repos/checkstyle/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/checkstyle/checkstyle/downloads","issues_url":"https://api.github.com/repos/checkstyle/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/checkstyle/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/checkstyle/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/checkstyle/checkstyle/releases{/id}","deployments_url":"https://api.github.com/repos/checkstyle/checkstyle/deployments","created_at":"2013-08-31T02:05:05Z","updated_at":"2018-05-17T20:58:50Z","pushed_at":"2018-05-17T23:01:29Z","git_url":"git://github.com/checkstyle/checkstyle.git","ssh_url":"git@github.com:checkstyle/checkstyle.git","clone_url":"https://github.com/checkstyle/checkstyle.git","svn_url":"https://github.com/checkstyle/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":58047,"stargazers_count":3672,"watchers_count":3672,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6441,"mirror_url":null,"archived":false,"open_issues_count":465,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6441,"open_issues":465,"watchers":3672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5753"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/5753"},"issue":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/5753"},"comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/5753/comments"},"review_comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5753/comments"},"review_comment":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5753/commits"},"statuses":{"href":"https://api.github.com/repos/checkstyle/checkstyle/statuses/f91daec88847774cb3f7e85699b1ec06bad27dd4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pbludov"}}