{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/223628108","pull_request_review_id":162781735,"id":223628108,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzYyODEwOA==","diff_hunk":"@@ -0,0 +1,273 @@\n+/* SPDX-License-Identifier: LGPL-2.1+ */\n+\n+#pragma once\n+\n+#include <stdbool.h>\n+#include <stddef.h>\n+#include <stdint.h>\n+\n+#include \"macro.h\"\n+#include \"string-util.h\"\n+#include \"util.h\"\n+\n+/*\n+  In case you wonder why we have our own JSON implementation, here are a couple of reasons why this implementation has\n+  benefits over various other implementatins:\n+\n+  - We need support for 64bit signed and unsigned integers, i.e. the full 64,5bit range of -9223372036854775808…18446744073709551615\n+  - All our variants are immutable after creation\n+  - Special values such as true, false, zero, null, empty strings, empty array, empty objects require zero memory","path":"src/basic/json.h","position":19,"original_position":19,"commit_id":"4482c20ede009707ad23f3c1bd4556f78012a33d","original_commit_id":"2593f078249c27e055c2dcaa7371b9b92fb025c0","user":{"login":"keszybz","id":349618,"node_id":"MDQ6VXNlcjM0OTYxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/349618?v=4","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"body":"\"zero\" is probably wrong...","created_at":"2018-10-09T09:43:03Z","updated_at":"2018-10-09T09:49:58Z","html_url":"https://github.com/systemd/systemd/pull/10316#discussion_r223628108","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/10316","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/223628108"},"html":{"href":"https://github.com/systemd/systemd/pull/10316#discussion_r223628108"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/10316"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/10316","id":221216751,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjE2NzUx","html_url":"https://github.com/systemd/systemd/pull/10316","diff_url":"https://github.com/systemd/systemd/pull/10316.diff","patch_url":"https://github.com/systemd/systemd/pull/10316.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/10316","number":10316,"state":"open","locked":false,"title":"just the json stuff from #9762","user":{"login":"poettering","id":2130732,"node_id":"MDQ6VXNlcjIxMzA3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"body":"Split out, on request of @keszybz ","created_at":"2018-10-08T19:15:36Z","updated_at":"2018-10-09T09:49:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e700c4001aff10a20781ba665714caada75b7995","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":224437857,"node_id":"MDU6TGFiZWwyMjQ0Mzc4NTc=","url":"https://api.github.com/repos/systemd/systemd/labels/tests","name":"tests","color":"c7def8","default":false},{"id":222868150,"node_id":"MDU6TGFiZWwyMjI4NjgxNTA=","url":"https://api.github.com/repos/systemd/systemd/labels/util-lib","name":"util-lib","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/10316/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/10316/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/10316/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/4482c20ede009707ad23f3c1bd4556f78012a33d","head":{"label":"poettering:json-api","ref":"json-api","sha":"4482c20ede009707ad23f3c1bd4556f78012a33d","user":{"login":"poettering","id":2130732,"node_id":"MDQ6VXNlcjIxMzA3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"repo":{"id":37097921,"node_id":"MDEwOlJlcG9zaXRvcnkzNzA5NzkyMQ==","name":"systemd","full_name":"poettering/systemd","private":false,"owner":{"login":"poettering","id":2130732,"node_id":"MDQ6VXNlcjIxMzA3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"html_url":"https://github.com/poettering/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/poettering/systemd","forks_url":"https://api.github.com/repos/poettering/systemd/forks","keys_url":"https://api.github.com/repos/poettering/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poettering/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poettering/systemd/teams","hooks_url":"https://api.github.com/repos/poettering/systemd/hooks","issue_events_url":"https://api.github.com/repos/poettering/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/poettering/systemd/events","assignees_url":"https://api.github.com/repos/poettering/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/poettering/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/poettering/systemd/tags","blobs_url":"https://api.github.com/repos/poettering/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poettering/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poettering/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/poettering/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poettering/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/poettering/systemd/languages","stargazers_url":"https://api.github.com/repos/poettering/systemd/stargazers","contributors_url":"https://api.github.com/repos/poettering/systemd/contributors","subscribers_url":"https://api.github.com/repos/poettering/systemd/subscribers","subscription_url":"https://api.github.com/repos/poettering/systemd/subscription","commits_url":"https://api.github.com/repos/poettering/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/poettering/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/poettering/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/poettering/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/poettering/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/poettering/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poettering/systemd/merges","archive_url":"https://api.github.com/repos/poettering/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poettering/systemd/downloads","issues_url":"https://api.github.com/repos/poettering/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/poettering/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/poettering/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/poettering/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poettering/systemd/labels{/name}","releases_url":"https://api.github.com/repos/poettering/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/poettering/systemd/deployments","created_at":"2015-06-08T23:07:59Z","updated_at":"2018-07-17T23:48:19Z","pushed_at":"2018-10-09T08:12:10Z","git_url":"git://github.com/poettering/systemd.git","ssh_url":"git@github.com:poettering/systemd.git","clone_url":"https://github.com/poettering/systemd.git","svn_url":"https://github.com/poettering/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":98922,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2,"open_issues":0,"watchers":13,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"3ccf61268fc500ec0fbc28c432f279c4b4aa8642","user":{"login":"systemd","id":1918868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTg4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"node_id":"MDEwOlJlcG9zaXRvcnkzMjg3MzMxMw==","name":"systemd","full_name":"systemd/systemd","private":false,"owner":{"login":"systemd","id":1918868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTg4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/systemd/systemd","description":"⚙️ 🐧 systemd System and Service Manager ","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2018-10-09T08:52:35Z","pushed_at":"2018-10-09T09:31:15Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"https://www.freedesktop.org/wiki/Software/systemd/","size":98593,"stargazers_count":3761,"watchers_count":3761,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1402,"mirror_url":null,"archived":false,"open_issues_count":1082,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1402,"open_issues":1082,"watchers":3761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/10316"},"html":{"href":"https://github.com/systemd/systemd/pull/10316"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/10316"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/10316/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/10316/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/10316/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/4482c20ede009707ad23f3c1bd4556f78012a33d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"keszybz"}}