{"action":"closed","number":145,"pull_request":{"url":"https://api.github.com/repos/superfly/fly/pulls/145","id":209946699,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTQ2Njk5","html_url":"https://github.com/superfly/fly/pull/145","diff_url":"https://github.com/superfly/fly/pull/145.diff","patch_url":"https://github.com/superfly/fly/pull/145.patch","issue_url":"https://api.github.com/repos/superfly/fly/issues/145","number":145,"state":"closed","locked":false,"title":"feat: global cache del/purgeTags","user":{"login":"mrkurt","id":7724,"node_id":"MDQ6VXNlcjc3MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7724?v=4","gravatar_id":"","url":"https://api.github.com/users/mrkurt","html_url":"https://github.com/mrkurt","followers_url":"https://api.github.com/users/mrkurt/followers","following_url":"https://api.github.com/users/mrkurt/following{/other_user}","gists_url":"https://api.github.com/users/mrkurt/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkurt/subscriptions","organizations_url":"https://api.github.com/users/mrkurt/orgs","repos_url":"https://api.github.com/users/mrkurt/repos","events_url":"https://api.github.com/users/mrkurt/events{/privacy}","received_events_url":"https://api.github.com/users/mrkurt/received_events","type":"User","site_admin":false},"body":"This introduces `cache.global.del`, which propagates deletes through new `CacheNotifier` plumbing.\r\n\r\nSome things to look at, opine on:\r\n\r\n1. `CacheNotifierAdapter`: should we call these something else\r\n2. We don't have a good way to detect adapters/configs. We're using a pattern like this in two places: https://github.com/superfly/fly/blob/cache-notifications/src/cache_notifier.ts#L68-L75\r\n3. This implementation of the Redis notifier will double issue deletes. I may try and fix this, or just let it be for now.\r\n\r\nUsage looks like this:\r\n\r\n```javascript\r\ndescribe(\"@fly/cache/global\", () => {\r\n  it(\"sends del notification\", async () => {\r\n    const key = \"notifier_test_key_\" + Math.random()\r\n    await cache.set(key, \"asdf\")\r\n    await cache.global.del(key)\r\n\r\n    // TODO: this can be race-y, global del is not guaranteed to happen before the next read\r\n    await sleep(20)\r\n    const res = await cache.getString(key)\r\n    expect(res).to.eq(null)\r\n\r\n  })\r\n})\r\n```","created_at":"2018-08-21T20:29:45Z","updated_at":"2018-08-28T20:02:51Z","closed_at":"2018-08-28T20:02:51Z","merged_at":"2018-08-28T20:02:51Z","merge_commit_sha":"24508cd89a4a52763dbe64f3d2595b0e4a70977d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/superfly/fly/pulls/145/commits","review_comments_url":"https://api.github.com/repos/superfly/fly/pulls/145/comments","review_comment_url":"https://api.github.com/repos/superfly/fly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superfly/fly/issues/145/comments","statuses_url":"https://api.github.com/repos/superfly/fly/statuses/f3c294f47b24cb97644f7677d4c86a7b57b2cd62","head":{"label":"superfly:cache-notifications","ref":"cache-notifications","sha":"f3c294f47b24cb97644f7677d4c86a7b57b2cd62","user":{"login":"superfly","id":22525303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTI1MzAz","avatar_url":"https://avatars1.githubusercontent.com/u/22525303?v=4","gravatar_id":"","url":"https://api.github.com/users/superfly","html_url":"https://github.com/superfly","followers_url":"https://api.github.com/users/superfly/followers","following_url":"https://api.github.com/users/superfly/following{/other_user}","gists_url":"https://api.github.com/users/superfly/gists{/gist_id}","starred_url":"https://api.github.com/users/superfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superfly/subscriptions","organizations_url":"https://api.github.com/users/superfly/orgs","repos_url":"https://api.github.com/users/superfly/repos","events_url":"https://api.github.com/users/superfly/events{/privacy}","received_events_url":"https://api.github.com/users/superfly/received_events","type":"Organization","site_admin":false},"repo":{"id":116983326,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY5ODMzMjY=","name":"fly","full_name":"superfly/fly","owner":{"login":"superfly","id":22525303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTI1MzAz","avatar_url":"https://avatars1.githubusercontent.com/u/22525303?v=4","gravatar_id":"","url":"https://api.github.com/users/superfly","html_url":"https://github.com/superfly","followers_url":"https://api.github.com/users/superfly/followers","following_url":"https://api.github.com/users/superfly/following{/other_user}","gists_url":"https://api.github.com/users/superfly/gists{/gist_id}","starred_url":"https://api.github.com/users/superfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superfly/subscriptions","organizations_url":"https://api.github.com/users/superfly/orgs","repos_url":"https://api.github.com/users/superfly/repos","events_url":"https://api.github.com/users/superfly/events{/privacy}","received_events_url":"https://api.github.com/users/superfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/superfly/fly","description":"Open source Edge Application runtime","fork":false,"url":"https://api.github.com/repos/superfly/fly","forks_url":"https://api.github.com/repos/superfly/fly/forks","keys_url":"https://api.github.com/repos/superfly/fly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superfly/fly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superfly/fly/teams","hooks_url":"https://api.github.com/repos/superfly/fly/hooks","issue_events_url":"https://api.github.com/repos/superfly/fly/issues/events{/number}","events_url":"https://api.github.com/repos/superfly/fly/events","assignees_url":"https://api.github.com/repos/superfly/fly/assignees{/user}","branches_url":"https://api.github.com/repos/superfly/fly/branches{/branch}","tags_url":"https://api.github.com/repos/superfly/fly/tags","blobs_url":"https://api.github.com/repos/superfly/fly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superfly/fly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superfly/fly/git/refs{/sha}","trees_url":"https://api.github.com/repos/superfly/fly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superfly/fly/statuses/{sha}","languages_url":"https://api.github.com/repos/superfly/fly/languages","stargazers_url":"https://api.github.com/repos/superfly/fly/stargazers","contributors_url":"https://api.github.com/repos/superfly/fly/contributors","subscribers_url":"https://api.github.com/repos/superfly/fly/subscribers","subscription_url":"https://api.github.com/repos/superfly/fly/subscription","commits_url":"https://api.github.com/repos/superfly/fly/commits{/sha}","git_commits_url":"https://api.github.com/repos/superfly/fly/git/commits{/sha}","comments_url":"https://api.github.com/repos/superfly/fly/comments{/number}","issue_comment_url":"https://api.github.com/repos/superfly/fly/issues/comments{/number}","contents_url":"https://api.github.com/repos/superfly/fly/contents/{+path}","compare_url":"https://api.github.com/repos/superfly/fly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superfly/fly/merges","archive_url":"https://api.github.com/repos/superfly/fly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superfly/fly/downloads","issues_url":"https://api.github.com/repos/superfly/fly/issues{/number}","pulls_url":"https://api.github.com/repos/superfly/fly/pulls{/number}","milestones_url":"https://api.github.com/repos/superfly/fly/milestones{/number}","notifications_url":"https://api.github.com/repos/superfly/fly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superfly/fly/labels{/name}","releases_url":"https://api.github.com/repos/superfly/fly/releases{/id}","deployments_url":"https://api.github.com/repos/superfly/fly/deployments","created_at":"2018-01-10T16:37:08Z","updated_at":"2018-08-27T14:56:30Z","pushed_at":"2018-08-28T20:02:51Z","git_url":"git://github.com/superfly/fly.git","ssh_url":"git@github.com:superfly/fly.git","clone_url":"https://github.com/superfly/fly.git","svn_url":"https://github.com/superfly/fly","homepage":"https://fly.io","size":40987,"stargazers_count":165,"watchers_count":165,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":25,"watchers":165,"default_branch":"master"}},"base":{"label":"superfly:master","ref":"master","sha":"75613204b33108dd6da1be5d00b4bed8700a94d4","user":{"login":"superfly","id":22525303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTI1MzAz","avatar_url":"https://avatars1.githubusercontent.com/u/22525303?v=4","gravatar_id":"","url":"https://api.github.com/users/superfly","html_url":"https://github.com/superfly","followers_url":"https://api.github.com/users/superfly/followers","following_url":"https://api.github.com/users/superfly/following{/other_user}","gists_url":"https://api.github.com/users/superfly/gists{/gist_id}","starred_url":"https://api.github.com/users/superfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superfly/subscriptions","organizations_url":"https://api.github.com/users/superfly/orgs","repos_url":"https://api.github.com/users/superfly/repos","events_url":"https://api.github.com/users/superfly/events{/privacy}","received_events_url":"https://api.github.com/users/superfly/received_events","type":"Organization","site_admin":false},"repo":{"id":116983326,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY5ODMzMjY=","name":"fly","full_name":"superfly/fly","owner":{"login":"superfly","id":22525303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTI1MzAz","avatar_url":"https://avatars1.githubusercontent.com/u/22525303?v=4","gravatar_id":"","url":"https://api.github.com/users/superfly","html_url":"https://github.com/superfly","followers_url":"https://api.github.com/users/superfly/followers","following_url":"https://api.github.com/users/superfly/following{/other_user}","gists_url":"https://api.github.com/users/superfly/gists{/gist_id}","starred_url":"https://api.github.com/users/superfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superfly/subscriptions","organizations_url":"https://api.github.com/users/superfly/orgs","repos_url":"https://api.github.com/users/superfly/repos","events_url":"https://api.github.com/users/superfly/events{/privacy}","received_events_url":"https://api.github.com/users/superfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/superfly/fly","description":"Open source Edge Application runtime","fork":false,"url":"https://api.github.com/repos/superfly/fly","forks_url":"https://api.github.com/repos/superfly/fly/forks","keys_url":"https://api.github.com/repos/superfly/fly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superfly/fly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superfly/fly/teams","hooks_url":"https://api.github.com/repos/superfly/fly/hooks","issue_events_url":"https://api.github.com/repos/superfly/fly/issues/events{/number}","events_url":"https://api.github.com/repos/superfly/fly/events","assignees_url":"https://api.github.com/repos/superfly/fly/assignees{/user}","branches_url":"https://api.github.com/repos/superfly/fly/branches{/branch}","tags_url":"https://api.github.com/repos/superfly/fly/tags","blobs_url":"https://api.github.com/repos/superfly/fly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superfly/fly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superfly/fly/git/refs{/sha}","trees_url":"https://api.github.com/repos/superfly/fly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superfly/fly/statuses/{sha}","languages_url":"https://api.github.com/repos/superfly/fly/languages","stargazers_url":"https://api.github.com/repos/superfly/fly/stargazers","contributors_url":"https://api.github.com/repos/superfly/fly/contributors","subscribers_url":"https://api.github.com/repos/superfly/fly/subscribers","subscription_url":"https://api.github.com/repos/superfly/fly/subscription","commits_url":"https://api.github.com/repos/superfly/fly/commits{/sha}","git_commits_url":"https://api.github.com/repos/superfly/fly/git/commits{/sha}","comments_url":"https://api.github.com/repos/superfly/fly/comments{/number}","issue_comment_url":"https://api.github.com/repos/superfly/fly/issues/comments{/number}","contents_url":"https://api.github.com/repos/superfly/fly/contents/{+path}","compare_url":"https://api.github.com/repos/superfly/fly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superfly/fly/merges","archive_url":"https://api.github.com/repos/superfly/fly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superfly/fly/downloads","issues_url":"https://api.github.com/repos/superfly/fly/issues{/number}","pulls_url":"https://api.github.com/repos/superfly/fly/pulls{/number}","milestones_url":"https://api.github.com/repos/superfly/fly/milestones{/number}","notifications_url":"https://api.github.com/repos/superfly/fly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superfly/fly/labels{/name}","releases_url":"https://api.github.com/repos/superfly/fly/releases{/id}","deployments_url":"https://api.github.com/repos/superfly/fly/deployments","created_at":"2018-01-10T16:37:08Z","updated_at":"2018-08-27T14:56:30Z","pushed_at":"2018-08-28T20:02:51Z","git_url":"git://github.com/superfly/fly.git","ssh_url":"git@github.com:superfly/fly.git","clone_url":"https://github.com/superfly/fly.git","svn_url":"https://github.com/superfly/fly","homepage":"https://fly.io","size":40987,"stargazers_count":165,"watchers_count":165,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":25,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superfly/fly/pulls/145"},"html":{"href":"https://github.com/superfly/fly/pull/145"},"issue":{"href":"https://api.github.com/repos/superfly/fly/issues/145"},"comments":{"href":"https://api.github.com/repos/superfly/fly/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/superfly/fly/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/superfly/fly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superfly/fly/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/superfly/fly/statuses/f3c294f47b24cb97644f7677d4c86a7b57b2cd62"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mrkurt","id":7724,"node_id":"MDQ6VXNlcjc3MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7724?v=4","gravatar_id":"","url":"https://api.github.com/users/mrkurt","html_url":"https://github.com/mrkurt","followers_url":"https://api.github.com/users/mrkurt/followers","following_url":"https://api.github.com/users/mrkurt/following{/other_user}","gists_url":"https://api.github.com/users/mrkurt/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkurt/subscriptions","organizations_url":"https://api.github.com/users/mrkurt/orgs","repos_url":"https://api.github.com/users/mrkurt/repos","events_url":"https://api.github.com/users/mrkurt/events{/privacy}","received_events_url":"https://api.github.com/users/mrkurt/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":8,"additions":531,"deletions":91,"changed_files":18}}
{"actor":{"display_login":"mrkurt"}}