{"action":"closed","number":30304,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/30304","id":216064377,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDY0Mzc3","html_url":"https://github.com/cockroachdb/cockroach/pull/30304","diff_url":"https://github.com/cockroachdb/cockroach/pull/30304.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/30304.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30304","number":30304,"state":"closed","locked":false,"title":"release-2.1: kv: check transaction status before recording refresh spans","user":{"login":"nvanbenschoten","id":5438456,"node_id":"MDQ6VXNlcjU0Mzg0NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"body":"Backport 2/2 commits from #29685.\r\n\r\n/cc @cockroachdb/release\r\n\r\n---\r\n\r\nFixes #29253.\r\n\r\nWe previously accounted for refresh spans before checking the\r\ntransaction's status. This meant that we would attempt to add new\r\nrefresh spans even if the txn had already been committed. If this\r\nattempt failed because the `max_refresh_spans_bytes` threshold was\r\nexceeded, we would erroneously return an error to the client even\r\nthough their transaction had already been committed. The simple\r\nfix for this is to only record refresh spans for transactions that\r\nare still PENDING. The new test case would have failed with the\r\nerror observed in #29253 without this fix.\r\n\r\nThis raises an auxiliary question about whether we should be asserting\r\nthat a transaction's status is not COMMITTED if we ever return an\r\nerror to the client. cc. @andreimatei.\r\n\r\nOn the positive side, this should be a minor perf win, as we'll\r\navoid recording refresh spans on the final batch of every txn.\r\n\r\nA similar fix will need to be backported to 2.0. The backport\r\nwon't be clean though because of the new txnInterceptor structure.\r\nHowever, the test shouldn't need to change.\r\n\r\nRelease note (bug fix): Don't return transaction size limit errors\r\nfor transactions that have already committed.\r\n","created_at":"2018-09-17T17:55:41Z","updated_at":"2018-09-17T20:46:15Z","closed_at":"2018-09-17T20:46:15Z","merged_at":"2018-09-17T20:46:14Z","merge_commit_sha":"324980e51b2d56c208533d916002abb4dbc11dec","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andreimatei","id":377201,"node_id":"MDQ6VXNlcjM3NzIwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/377201?v=4","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"core-prs","id":2437977,"node_id":"MDQ6VGVhbTI0Mzc5Nzc=","slug":"core-prs","description":"Join this team for notifications about core PRs","privacy":"closed","url":"https://api.github.com/teams/2437977","members_url":"https://api.github.com/teams/2437977/members{/member}","repositories_url":"https://api.github.com/teams/2437977/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/30304/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/30304/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30304/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/f85eb95407abbc93bc62035157e68979f4e0398d","head":{"label":"nvanbenschoten:backport2.1-29685","ref":"backport2.1-29685","sha":"f85eb95407abbc93bc62035157e68979f4e0398d","user":{"login":"nvanbenschoten","id":5438456,"node_id":"MDQ6VXNlcjU0Mzg0NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"repo":{"id":42610470,"node_id":"MDEwOlJlcG9zaXRvcnk0MjYxMDQ3MA==","name":"cockroach","full_name":"nvanbenschoten/cockroach","private":false,"owner":{"login":"nvanbenschoten","id":5438456,"node_id":"MDQ6VXNlcjU0Mzg0NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nvanbenschoten/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach","forks_url":"https://api.github.com/repos/nvanbenschoten/cockroach/forks","keys_url":"https://api.github.com/repos/nvanbenschoten/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvanbenschoten/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvanbenschoten/cockroach/teams","hooks_url":"https://api.github.com/repos/nvanbenschoten/cockroach/hooks","issue_events_url":"https://api.github.com/repos/nvanbenschoten/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/nvanbenschoten/cockroach/events","assignees_url":"https://api.github.com/repos/nvanbenschoten/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/nvanbenschoten/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/nvanbenschoten/cockroach/tags","blobs_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvanbenschoten/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/nvanbenschoten/cockroach/languages","stargazers_url":"https://api.github.com/repos/nvanbenschoten/cockroach/stargazers","contributors_url":"https://api.github.com/repos/nvanbenschoten/cockroach/contributors","subscribers_url":"https://api.github.com/repos/nvanbenschoten/cockroach/subscribers","subscription_url":"https://api.github.com/repos/nvanbenschoten/cockroach/subscription","commits_url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvanbenschoten/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvanbenschoten/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvanbenschoten/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/nvanbenschoten/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvanbenschoten/cockroach/merges","archive_url":"https://api.github.com/repos/nvanbenschoten/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvanbenschoten/cockroach/downloads","issues_url":"https://api.github.com/repos/nvanbenschoten/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/nvanbenschoten/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/nvanbenschoten/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/nvanbenschoten/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvanbenschoten/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/nvanbenschoten/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/nvanbenschoten/cockroach/deployments","created_at":"2015-09-16T20:04:21Z","updated_at":"2018-09-05T17:38:35Z","pushed_at":"2018-09-17T20:42:40Z","git_url":"git://github.com/nvanbenschoten/cockroach.git","ssh_url":"git@github.com:nvanbenschoten/cockroach.git","clone_url":"https://github.com/nvanbenschoten/cockroach.git","svn_url":"https://github.com/nvanbenschoten/cockroach","homepage":null,"size":524410,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:release-2.1","ref":"release-2.1","sha":"d803f9e170e1896d7e0b2fbf8680f11d8f91e553","user":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU2MzU4Nw==","name":"cockroach","full_name":"cockroachdb/cockroach","private":false,"owner":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-09-17T20:45:28Z","pushed_at":"2018-09-17T20:46:14Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":1036948,"stargazers_count":14289,"watchers_count":14289,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1508,"mirror_url":null,"archived":false,"open_issues_count":1984,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1508,"open_issues":1984,"watchers":14289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/30304"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/30304"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/30304"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/30304/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/30304/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/30304/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/f85eb95407abbc93bc62035157e68979f4e0398d"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nvanbenschoten","id":5438456,"node_id":"MDQ6VXNlcjU0Mzg0NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":84,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"nvanbenschoten"}}