{"action":"created","comment":{"url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/comments/202759298","pull_request_review_id":137519359,"id":202759298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjc1OTI5OA==","diff_hunk":"@@ -26,25 +26,46 @@ import \"./OpsManaged.sol\";\n import \"./OpenSTValueInterface.sol\";\n import \"./OpenSTUtilityInterface.sol\";\n \n-/// @title Registrar - registers for utility tokens\n+/**\n+ *  @title Registrar contract which implements OpsManaged.\n+ *\n+ *  @notice Contains functions that register for utility tokens.\n+ */\n contract Registrar is OpsManaged {\n+\t\n+\t/** Storage */\n \n-    /*\n-     *  Storage\n-     */\n-    // mapping(uint256 /* chainId */ => CoreInterface) cores;\n+\t// mapping(uint256 /* chainId */ => CoreInterface) cores;\n \n-    /*\n-     *  Public functions\n-     */\n-    constructor() public\n-        OpsManaged()\n-    {\n-    }\n+\t/**  Public functions */\n+\n+\t/**\n+\t *  @notice Contract Constructor.\n+\t */\n+\n+\t constructor() public\n+\t \tOpsManaged()\n+\t \t{ }\n \n-    /*\n-     *  OpenSTValue\n-     */\n+\n+\t/**\n+\t *  @notice External function confirmRedemptionIntent.\n+\t *\n+\t *  @dev Only callable by Ops.\n+\t *\n+\t *  @param _uuid Uuid of the token.\n+\t *  @param _redeemer Address of the redeemer.\n+\t *  @param _redeemerNonce Nonce of the redeemer.\n+\t *  @param _beneficiary Address of beneficiary on the value chain.\n+\t *  @param _amountUT Amount of utility tokens to redeem.\n+\t *  @param _redemptionUnlockHeight Block height upto which redemption is locked.\n+\t *  @param _hashLock Hash lock for the redeem request.\n+\t *  @param _blockHeight Current block height.","path":"contracts/Registrar.sol","position":53,"original_position":53,"commit_id":"9326fc2061965bdbdabd30de83ca801966fc910c","original_commit_id":"9326fc2061965bdbdabd30de83ca801966fc910c","user":{"login":"jasonklein","id":6839162,"node_id":"MDQ6VXNlcjY4MzkxNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6839162?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonklein","html_url":"https://github.com/jasonklein","followers_url":"https://api.github.com/users/jasonklein/followers","following_url":"https://api.github.com/users/jasonklein/following{/other_user}","gists_url":"https://api.github.com/users/jasonklein/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonklein/subscriptions","organizations_url":"https://api.github.com/users/jasonklein/orgs","repos_url":"https://api.github.com/users/jasonklein/repos","events_url":"https://api.github.com/users/jasonklein/events{/privacy}","received_events_url":"https://api.github.com/users/jasonklein/received_events","type":"User","site_admin":false},"body":"I don't believe \"current\" is correct (because this block height is the value included in the redemption intent hash which comes from the utility chain).","created_at":"2018-07-16T17:11:10Z","updated_at":"2018-07-16T17:15:47Z","html_url":"https://github.com/OpenSTFoundation/openst-protocol/pull/193#discussion_r202759298","pull_request_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/193","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/comments/202759298"},"html":{"href":"https://github.com/OpenSTFoundation/openst-protocol/pull/193#discussion_r202759298"},"pull_request":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/193","id":201131637,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTMxNjM3","html_url":"https://github.com/OpenSTFoundation/openst-protocol/pull/193","diff_url":"https://github.com/OpenSTFoundation/openst-protocol/pull/193.diff","patch_url":"https://github.com/OpenSTFoundation/openst-protocol/pull/193.patch","issue_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/193","number":193,"state":"open","locked":false,"title":"Updates comments in the openst-protocol repo [mosa-98]-III","user":{"login":"noslav","id":26611201,"node_id":"MDQ6VXNlcjI2NjExMjAx","avatar_url":"https://avatars3.githubusercontent.com/u/26611201?v=4","gravatar_id":"","url":"https://api.github.com/users/noslav","html_url":"https://github.com/noslav","followers_url":"https://api.github.com/users/noslav/followers","following_url":"https://api.github.com/users/noslav/following{/other_user}","gists_url":"https://api.github.com/users/noslav/gists{/gist_id}","starred_url":"https://api.github.com/users/noslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noslav/subscriptions","organizations_url":"https://api.github.com/users/noslav/orgs","repos_url":"https://api.github.com/users/noslav/repos","events_url":"https://api.github.com/users/noslav/events{/privacy}","received_events_url":"https://api.github.com/users/noslav/received_events","type":"User","site_admin":false},"body":"Files touched - \r\nProtocolVersioned.sol\r\nProtocolVersionedMock.sol\r\nRLP.sol\r\nRegistrar.sol\r\nSTPrime.sol\r\nSTPrimeConfig.sol\r\nSafeMathMock.sol\r\nSimpleStake.sol\r\nTestUtils.sol\r\nUtilityTokenAbstract.sol\r\nUtilityTokenAbstractMock.sol\r\nUtilityTokenInterface.sol\r\nWorkers.sol\r\nWorkersInterface.sol\r\n\r\nGuidelines - \r\n* Replaces `///` document comment style with `/** */` one.\r\n* One-liner doc comments follow the same guideline: /** */ -  for struct, enum and member vars.\r\n* For multiline doc comments, it should be\r\n`/**`\r\n   `*  @title A title that should describe the contract or interface.`\r\n   `*`\r\n   `*  @notice Explain to a user what a contract, interface or function does.`\r\n   `*`\r\n   `*  @dev Explain to a developer any extra details for a contract, interface or function.`\r\n   `*`\r\n   `*  @param _firstParameterName Documents a parameter of a function`\r\n   `*`              `just like in doxygen.`\r\n   `*  @param _secondParamName Followed by second param details.`\r\n   `*`\r\n   `*  @return type Documents the return type of a contract's function.`\r\n   `*/`\r\n* All comment lines start with caps and end with a period, using proper grammar. ","created_at":"2018-07-12T21:31:25Z","updated_at":"2018-07-16T17:15:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47b22b691b6b5b91730d3884e41d071991d22d9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/193/commits","review_comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/193/comments","review_comment_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/193/comments","statuses_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/statuses/9326fc2061965bdbdabd30de83ca801966fc910c","head":{"label":"OpenSTFoundation:pranay/mosa-98CommentsStyling-III","ref":"pranay/mosa-98CommentsStyling-III","sha":"9326fc2061965bdbdabd30de83ca801966fc910c","user":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":108171643,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxNzE2NDM=","name":"openst-protocol","full_name":"OpenSTFoundation/openst-protocol","owner":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSTFoundation/openst-protocol","description":"OpenST Protocol allows to stake Simple Token on Ethereum to mint branded utility tokens","fork":false,"url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol","forks_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/forks","keys_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/teams","hooks_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/hooks","issue_events_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/events","assignees_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/tags","blobs_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/languages","stargazers_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/stargazers","contributors_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/contributors","subscribers_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/subscribers","subscription_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/subscription","commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/merges","archive_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/downloads","issues_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/labels{/name}","releases_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/deployments","created_at":"2017-10-24T19:09:30Z","updated_at":"2018-07-13T12:08:16Z","pushed_at":"2018-07-16T17:03:11Z","git_url":"git://github.com/OpenSTFoundation/openst-protocol.git","ssh_url":"git@github.com:OpenSTFoundation/openst-protocol.git","clone_url":"https://github.com/OpenSTFoundation/openst-protocol.git","svn_url":"https://github.com/OpenSTFoundation/openst-protocol","homepage":"https://simpletoken.org","size":3785,"stargazers_count":65,"watchers_count":65,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":32,"watchers":65,"default_branch":"master"}},"base":{"label":"OpenSTFoundation:develop","ref":"develop","sha":"53bb7b417af0eff4a837315ffe9fd9803b911db7","user":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":108171643,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxNzE2NDM=","name":"openst-protocol","full_name":"OpenSTFoundation/openst-protocol","owner":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSTFoundation/openst-protocol","description":"OpenST Protocol allows to stake Simple Token on Ethereum to mint branded utility tokens","fork":false,"url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol","forks_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/forks","keys_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/teams","hooks_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/hooks","issue_events_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/events","assignees_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/tags","blobs_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/languages","stargazers_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/stargazers","contributors_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/contributors","subscribers_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/subscribers","subscription_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/subscription","commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/merges","archive_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/downloads","issues_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/labels{/name}","releases_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/deployments","created_at":"2017-10-24T19:09:30Z","updated_at":"2018-07-13T12:08:16Z","pushed_at":"2018-07-16T17:03:11Z","git_url":"git://github.com/OpenSTFoundation/openst-protocol.git","ssh_url":"git@github.com:OpenSTFoundation/openst-protocol.git","clone_url":"https://github.com/OpenSTFoundation/openst-protocol.git","svn_url":"https://github.com/OpenSTFoundation/openst-protocol","homepage":"https://simpletoken.org","size":3785,"stargazers_count":65,"watchers_count":65,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":32,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/193"},"html":{"href":"https://github.com/OpenSTFoundation/openst-protocol/pull/193"},"issue":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/193"},"comments":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-protocol/statuses/9326fc2061965bdbdabd30de83ca801966fc910c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jasonklein"}}