{"action":"created","issue":{"url":"https://api.github.com/repos/r-lib/usethis/issues/542","repository_url":"https://api.github.com/repos/r-lib/usethis","labels_url":"https://api.github.com/repos/r-lib/usethis/issues/542/labels{/name}","comments_url":"https://api.github.com/repos/r-lib/usethis/issues/542/comments","events_url":"https://api.github.com/repos/r-lib/usethis/issues/542/events","html_url":"https://github.com/r-lib/usethis/issues/542","id":388773015,"node_id":"MDU6SXNzdWUzODg3NzMwMTU=","number":542,"title":"use_spell_check() does not find typos","user":{"login":"JBGruber","id":23524101,"node_id":"MDQ6VXNlcjIzNTI0MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/23524101?v=4","gravatar_id":"","url":"https://api.github.com/users/JBGruber","html_url":"https://github.com/JBGruber","followers_url":"https://api.github.com/users/JBGruber/followers","following_url":"https://api.github.com/users/JBGruber/following{/other_user}","gists_url":"https://api.github.com/users/JBGruber/gists{/gist_id}","starred_url":"https://api.github.com/users/JBGruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JBGruber/subscriptions","organizations_url":"https://api.github.com/users/JBGruber/orgs","repos_url":"https://api.github.com/users/JBGruber/repos","events_url":"https://api.github.com/users/JBGruber/events{/privacy}","received_events_url":"https://api.github.com/users/JBGruber/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-07T18:53:09Z","updated_at":"2018-12-11T18:51:22Z","closed_at":"2018-12-11T18:51:22Z","author_association":"NONE","body":"**First of all: Thanks for this awsome package. It made developing packages so incredibly easy!**\r\n\r\nNow the issue I have: I used `usethis::use_spell_check()` to add an automatic spell check to a little fun package I wrote: www.github.com/JBGruber/rwhatsapp\r\n\r\nNow I found a typo in the documentation which was not picked up before. The typo is reported by `spelling::spell_check_package()` though. Not sure if I understand something wrong but I though `usethis::use_spell_check()` would cause a warning when running `devtools::check()`.\r\n\r\n# reprex\r\n\r\nI use the said package as reprex. You could also try it by adding a typo to one of your own.\r\n\r\n```r\r\nsystem(\"git clone https://github.com/JBGruber/rwhatsapp.git\")\r\nsetwd(\"./rwhatsapp\")\r\nlines <- readLines(\"./R/rwhatsapp.R\")\r\nlines[grepl(\"#'   problems you can provide a\", lines)] <- gsub(\r\n  x = lines[grepl(\"#'   problems you can provide a\", lines)],\r\n  pattern = \"custom\",\r\n  replacement = \"cudtom\"\r\n)\r\nwriteLines(lines, \"./R/rwhatsapp.R\")\r\nroxygen2::roxygenise(clean = TRUE)\r\ndevtools::check()\r\nspelling::spell_check_package()\r\nsession_info()\r\n```\r\n# some output\r\n\r\nThese are the last lines of output for me when running `devtools::check()` and the output of `spelling::spell_check_package()`\r\n\r\n```\r\n✔  Running ‘spelling.R’\r\n✔  Running ‘testthat.R’\r\n   \r\n   \r\n── R CMD check results ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────── rwhatsapp 0.1.3.9000 ────\r\nDuration: 28.7s\r\n\r\n0 errors ✔ | 0 warnings ✔ | 0 notes ✔\r\n> spelling::spell_check_package()\r\n  WORD     FOUND IN\r\ncudtom   rwa_read.Rd:18\r\n```\r\nAnd here comes my `session_info()` in case you need it.\r\n```\r\n> session_info()\r\n─ Session info ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────\r\n setting  value                       \r\n version  R version 3.5.1 (2018-07-02)\r\n os       Ubuntu 18.04.1 LTS          \r\n system   x86_64, linux-gnu           \r\n ui       RStudio                     \r\n language en_GB:en                    \r\n collate  en_GB.UTF-8                 \r\n ctype    en_GB.UTF-8                 \r\n tz       Europe/London               \r\n date     2018-12-07                  \r\n\r\n─ Packages ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────\r\n !  package     * version    date       lib source                            \r\n    assertthat    0.2.0      2017-04-11 [1] CRAN (R 3.5.0)                    \r\n    backports     1.1.2      2017-12-13 [1] CRAN (R 3.5.0)                    \r\n    base64enc     0.1-3      2015-07-28 [1] CRAN (R 3.5.0)                    \r\n    bindr         0.1.1      2018-03-13 [1] CRAN (R 3.5.0)                    \r\n    bindrcpp      0.2.2      2018-03-29 [1] CRAN (R 3.5.0)                    \r\n    broom         0.5.1      2018-12-05 [1] CRAN (R 3.5.1)                    \r\n    callr         3.0.0      2018-08-24 [1] CRAN (R 3.5.1)                    \r\n    cli           1.0.1      2018-09-25 [1] CRAN (R 3.5.1)                    \r\n    commonmark    1.7        2018-12-01 [1] CRAN (R 3.5.1)                    \r\n    covr          3.2.1      2018-10-18 [1] CRAN (R 3.5.1)                    \r\n    crayon        1.3.4      2017-09-16 [1] CRAN (R 3.5.0)                    \r\n    desc          1.2.0      2018-05-01 [1] CRAN (R 3.5.0)                    \r\n    devtools    * 2.0.1      2018-10-26 [1] CRAN (R 3.5.1)                    \r\n    digest        0.6.18     2018-10-10 [1] CRAN (R 3.5.1)                    \r\n    dplyr         0.7.8      2018-11-10 [1] CRAN (R 3.5.1)                    \r\n    fs            1.2.6      2018-08-23 [1] CRAN (R 3.5.1)                    \r\n    generics      0.0.2      2018-11-29 [1] CRAN (R 3.5.1)                    \r\n    glue          1.3.0      2018-11-09 [1] Github (tidyverse/glue@35c61e9)   \r\n    hunspell      2.9        2017-12-16 [1] CRAN (R 3.5.0)                    \r\n    janeaustenr   0.1.5      2017-06-10 [1] CRAN (R 3.5.1)                    \r\n    lattice       0.20-38    2018-11-04 [4] CRAN (R 3.5.1)                    \r\n    lazyeval      0.2.1      2017-10-29 [1] CRAN (R 3.5.0)                    \r\n    magrittr      1.5        2014-11-22 [1] CRAN (R 3.5.0)                    \r\n    Matrix        1.2-15     2018-11-01 [4] CRAN (R 3.5.1)                    \r\n    memoise       1.1.0      2017-04-21 [1] CRAN (R 3.5.0)                    \r\n    nlme          3.1-137    2018-04-07 [4] CRAN (R 3.5.0)                    \r\n    pillar        1.3.0      2018-07-14 [1] CRAN (R 3.5.1)                    \r\n    pkgbuild      1.0.2      2018-10-16 [1] CRAN (R 3.5.1)                    \r\n    pkgconfig     2.0.2      2018-08-16 [1] CRAN (R 3.5.1)                    \r\n    pkgload       1.0.2      2018-10-29 [1] CRAN (R 3.5.1)                    \r\n    prettyunits   1.0.2      2015-07-13 [1] CRAN (R 3.5.0)                    \r\n    processx      3.2.1      2018-12-05 [1] CRAN (R 3.5.1)                    \r\n    ps            1.2.1      2018-11-06 [1] CRAN (R 3.5.1)                    \r\n    purrr         0.2.5      2018-05-29 [1] CRAN (R 3.5.0)                    \r\n    R6            2.3.0      2018-10-04 [1] CRAN (R 3.5.1)                    \r\n    rcmdcheck     1.3.2      2018-11-10 [1] CRAN (R 3.5.1)                    \r\n    Rcpp          1.0.0      2018-11-07 [1] CRAN (R 3.5.1)                    \r\n    remotes       2.0.2      2018-10-30 [1] CRAN (R 3.5.1)                    \r\n    rex           1.1.2      2017-10-19 [1] CRAN (R 3.5.0)                    \r\n    rlang         0.3.0.1    2018-10-25 [1] CRAN (R 3.5.1)                    \r\n    roxygen2    * 6.1.1      2018-11-07 [1] CRAN (R 3.5.1)                    \r\n    rprojroot     1.3-2      2018-01-03 [1] CRAN (R 3.5.0)                    \r\n    rstudioapi    0.8        2018-10-02 [1] CRAN (R 3.5.1)                    \r\n VP rwhatsapp   * 0.1.3.9000 2018-12-07 [?] local                             \r\n    sessioninfo   1.1.1      2018-11-05 [1] CRAN (R 3.5.1)                    \r\n    SnowballC     0.5.1      2014-08-09 [1] CRAN (R 3.5.0)                    \r\n    spelling      1.2        2018-12-07 [1] Github (ropensci/spelling@5c6d160)\r\n    stringi       1.2.4      2018-07-20 [1] CRAN (R 3.5.1)                    \r\n    stringr       1.3.1      2018-05-10 [1] CRAN (R 3.5.0)                    \r\n    testthat      2.0.1      2018-10-13 [1] CRAN (R 3.5.1)                    \r\n    tibble        1.4.2      2018-01-22 [1] CRAN (R 3.5.0)                    \r\n    tidyr         0.8.2      2018-10-28 [1] CRAN (R 3.5.1)                    \r\n    tidyselect    0.2.5      2018-10-11 [1] CRAN (R 3.5.1)                    \r\n    tidytext      0.2.0      2018-10-17 [1] CRAN (R 3.5.1)                    \r\n    tokenizers    0.2.1      2018-03-29 [1] CRAN (R 3.5.1)                    \r\n    usethis     * 1.4.0      2018-08-14 [1] CRAN (R 3.5.1)                    \r\n    withr         2.1.2      2018-03-15 [1] CRAN (R 3.5.0)                    \r\n    xml2          1.2.0      2018-01-24 [1] CRAN (R 3.5.0)                    \r\n    xopen         1.0.0      2018-09-17 [1] CRAN (R 3.5.1)                    \r\n    yaml          2.2.0      2018-07-25 [1] CRAN (R 3.5.1)      \r\n```\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/r-lib/usethis/issues/comments/446317144","html_url":"https://github.com/r-lib/usethis/issues/542#issuecomment-446317144","issue_url":"https://api.github.com/repos/r-lib/usethis/issues/542","id":446317144,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjMxNzE0NA==","user":{"login":"JBGruber","id":23524101,"node_id":"MDQ6VXNlcjIzNTI0MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/23524101?v=4","gravatar_id":"","url":"https://api.github.com/users/JBGruber","html_url":"https://github.com/JBGruber","followers_url":"https://api.github.com/users/JBGruber/followers","following_url":"https://api.github.com/users/JBGruber/following{/other_user}","gists_url":"https://api.github.com/users/JBGruber/gists{/gist_id}","starred_url":"https://api.github.com/users/JBGruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JBGruber/subscriptions","organizations_url":"https://api.github.com/users/JBGruber/orgs","repos_url":"https://api.github.com/users/JBGruber/repos","events_url":"https://api.github.com/users/JBGruber/events{/privacy}","received_events_url":"https://api.github.com/users/JBGruber/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T18:51:22Z","updated_at":"2018-12-11T18:51:22Z","author_association":"NONE","body":"Thanks @jennybc for looking into this. \r\n\r\nI just realised that everything works fine when I use `Build -> Check Package` in RStudio instead of typing `devtools::check()`.\r\n\r\n```\r\n> checking tests ...\r\n  See below...\r\n\r\n-- Test failures ------------------------------------------------- spelling ----\r\n\r\n> if(requireNamespace('spelling', quietly=TRUE))\r\n+   spelling::spell_check_test(vignettes = TRUE, error = TRUE, skip_on_cran = TRUE)\r\nError: Potential spelling errors: cudtom\r\nExecution halted\r\n\r\n1 error x | 0 warnings v | 0 notes v\r\nError: R CMD check found ERRORs\r\nExecution halted\r\n\r\nExited with status 1.\r\n```\r\nI'm still a bit confused why this happens (so it would be great if someone wants to elaborate) but at least I know how to get around it.\r\n\r\nAnyway, it seems `usethis` and `spelling` are fine!"}}
{"actor":{"display_login":"JBGruber"}}