{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/198906115","pull_request_review_id":132923229,"id":198906115,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODkwNjExNQ==","diff_hunk":"@@ -59,7 +59,7 @@ function TableVisTypeProvider(Private) {\n       defaults: {\n         perPage: 10,\n         showPartialRows: false,\n-        showMeticsAtAllLevels: false,","path":"src/core_plugins/table_vis/public/table_vis.js","position":4,"original_position":4,"commit_id":"e2f5cdf75319313e6162e6afdb2cc1b3a34abd43","original_commit_id":"e2f5cdf75319313e6162e6afdb2cc1b3a34abd43","user":{"login":"cjcenizal","id":1238659,"node_id":"MDQ6VXNlcjEyMzg2NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1238659?v=4","gravatar_id":"","url":"https://api.github.com/users/cjcenizal","html_url":"https://github.com/cjcenizal","followers_url":"https://api.github.com/users/cjcenizal/followers","following_url":"https://api.github.com/users/cjcenizal/following{/other_user}","gists_url":"https://api.github.com/users/cjcenizal/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcenizal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcenizal/subscriptions","organizations_url":"https://api.github.com/users/cjcenizal/orgs","repos_url":"https://api.github.com/users/cjcenizal/repos","events_url":"https://api.github.com/users/cjcenizal/events{/privacy}","received_events_url":"https://api.github.com/users/cjcenizal/received_events","type":"User","site_admin":false},"body":"@ppisljar Thanks, I've set up a meeting to discuss this.","created_at":"2018-06-28T16:31:01Z","updated_at":"2018-06-28T16:31:01Z","html_url":"https://github.com/elastic/kibana/pull/19981#discussion_r198906115","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/19981","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/198906115"},"html":{"href":"https://github.com/elastic/kibana/pull/19981#discussion_r198906115"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19981"}},"in_reply_to_id":198839480},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/19981","id":195420036,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDIwMDM2","html_url":"https://github.com/elastic/kibana/pull/19981","diff_url":"https://github.com/elastic/kibana/pull/19981.diff","patch_url":"https://github.com/elastic/kibana/pull/19981.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/19981","number":19981,"state":"closed","locked":false,"title":"Spelling","user":{"login":"jsoref","id":2119212,"node_id":"MDQ6VXNlcjIxMTkyMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2119212?v=4","gravatar_id":"","url":"https://api.github.com/users/jsoref","html_url":"https://github.com/jsoref","followers_url":"https://api.github.com/users/jsoref/followers","following_url":"https://api.github.com/users/jsoref/following{/other_user}","gists_url":"https://api.github.com/users/jsoref/gists{/gist_id}","starred_url":"https://api.github.com/users/jsoref/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsoref/subscriptions","organizations_url":"https://api.github.com/users/jsoref/orgs","repos_url":"https://api.github.com/users/jsoref/repos","events_url":"https://api.github.com/users/jsoref/events{/privacy}","received_events_url":"https://api.github.com/users/jsoref/received_events","type":"User","site_admin":false},"body":"- If submitting code, have you tested and built your code locally prior to submission with `yarn test && yarn build`?\r\nno (but the build system is happy now...)\r\n\r\nI've tried to exclude things where kibana isn't the upstream, if I've missed things, please let me know (I've published my exclusions on a branch called `ignore`). I'll happily drop changes from here and try to send them upstream. If you know where upstream is, please let me know.\r\n\r\nI'm happy to split this into multiple PRs, e.g. comments / strings / docs / local variables / private functions / public functions. I just need some direction.\r\n\r\nNotes:\r\n* there are some bug fixes in here (e.g., `UNKNOWN`).\r\n* I left a couple of commit messages with things that are more or less comments indicating I'm less certain about the appropriate correction -- I'll try to include comments on the PR to call attention.\r\n* My tooling isn't perfect, and I make mistakes.\r\n--\r\nGenerated by https://github.com/jsoref/spelling `f`; to maintain your repo, please consider `fchurn`","created_at":"2018-06-18T04:33:07Z","updated_at":"2018-06-28T16:31:01Z","closed_at":"2018-06-27T03:17:42Z","merged_at":"2018-06-27T03:17:42Z","merge_commit_sha":"2b27fb1c5f43660e9f723594ae1489e68577530a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":222889424,"node_id":"MDU6TGFiZWwyMjI4ODk0MjQ=","url":"https://api.github.com/repos/elastic/kibana/labels/chore","name":"chore","color":"f9d0c4","default":false},{"id":883958396,"node_id":"MDU6TGFiZWw4ODM5NTgzOTY=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.4.0","name":"v6.4.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/19981/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/19981/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/19981/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/e2f5cdf75319313e6162e6afdb2cc1b3a34abd43","head":{"label":"jsoref:spelling","ref":"spelling","sha":"e2f5cdf75319313e6162e6afdb2cc1b3a34abd43","user":{"login":"jsoref","id":2119212,"node_id":"MDQ6VXNlcjIxMTkyMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2119212?v=4","gravatar_id":"","url":"https://api.github.com/users/jsoref","html_url":"https://github.com/jsoref","followers_url":"https://api.github.com/users/jsoref/followers","following_url":"https://api.github.com/users/jsoref/following{/other_user}","gists_url":"https://api.github.com/users/jsoref/gists{/gist_id}","starred_url":"https://api.github.com/users/jsoref/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsoref/subscriptions","organizations_url":"https://api.github.com/users/jsoref/orgs","repos_url":"https://api.github.com/users/jsoref/repos","events_url":"https://api.github.com/users/jsoref/events{/privacy}","received_events_url":"https://api.github.com/users/jsoref/received_events","type":"User","site_admin":false},"repo":{"id":137421743,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0MjE3NDM=","name":"kibana","full_name":"jsoref/kibana","owner":{"login":"jsoref","id":2119212,"node_id":"MDQ6VXNlcjIxMTkyMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2119212?v=4","gravatar_id":"","url":"https://api.github.com/users/jsoref","html_url":"https://github.com/jsoref","followers_url":"https://api.github.com/users/jsoref/followers","following_url":"https://api.github.com/users/jsoref/following{/other_user}","gists_url":"https://api.github.com/users/jsoref/gists{/gist_id}","starred_url":"https://api.github.com/users/jsoref/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsoref/subscriptions","organizations_url":"https://api.github.com/users/jsoref/orgs","repos_url":"https://api.github.com/users/jsoref/repos","events_url":"https://api.github.com/users/jsoref/events{/privacy}","received_events_url":"https://api.github.com/users/jsoref/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsoref/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/jsoref/kibana","forks_url":"https://api.github.com/repos/jsoref/kibana/forks","keys_url":"https://api.github.com/repos/jsoref/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsoref/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsoref/kibana/teams","hooks_url":"https://api.github.com/repos/jsoref/kibana/hooks","issue_events_url":"https://api.github.com/repos/jsoref/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/jsoref/kibana/events","assignees_url":"https://api.github.com/repos/jsoref/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/jsoref/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/jsoref/kibana/tags","blobs_url":"https://api.github.com/repos/jsoref/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsoref/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsoref/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsoref/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsoref/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/jsoref/kibana/languages","stargazers_url":"https://api.github.com/repos/jsoref/kibana/stargazers","contributors_url":"https://api.github.com/repos/jsoref/kibana/contributors","subscribers_url":"https://api.github.com/repos/jsoref/kibana/subscribers","subscription_url":"https://api.github.com/repos/jsoref/kibana/subscription","commits_url":"https://api.github.com/repos/jsoref/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsoref/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsoref/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsoref/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsoref/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/jsoref/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsoref/kibana/merges","archive_url":"https://api.github.com/repos/jsoref/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsoref/kibana/downloads","issues_url":"https://api.github.com/repos/jsoref/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/jsoref/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/jsoref/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/jsoref/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsoref/kibana/labels{/name}","releases_url":"https://api.github.com/repos/jsoref/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/jsoref/kibana/deployments","created_at":"2018-06-15T00:15:16Z","updated_at":"2018-06-19T03:32:07Z","pushed_at":"2018-06-27T03:17:49Z","git_url":"git://github.com/jsoref/kibana.git","ssh_url":"git@github.com:jsoref/kibana.git","clone_url":"https://github.com/jsoref/kibana.git","svn_url":"https://github.com/jsoref/kibana","homepage":"https://www.elastic.co/products/kibana","size":418176,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"28402d3dfc42b94799c8db11006435996be6e7f3","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-06-28T14:19:34Z","pushed_at":"2018-06-28T15:39:11Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":419529,"stargazers_count":9587,"watchers_count":9587,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3731,"mirror_url":null,"archived":false,"open_issues_count":3238,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3731,"open_issues":3238,"watchers":9587,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19981"},"html":{"href":"https://github.com/elastic/kibana/pull/19981"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/19981"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/19981/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19981/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19981/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/e2f5cdf75319313e6162e6afdb2cc1b3a34abd43"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cjcenizal"}}