{"action":"created","comment":{"url":"https://api.github.com/repos/RustPython/RustPython/pulls/comments/214465477","pull_request_review_id":151536886,"id":214465477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQ2NTQ3Nw==","diff_hunk":"@@ -512,21 +512,30 @@ impl fmt::Debug for PyObject {\n #[derive(Debug, Default, Clone)]\n pub struct PyFuncArgs {\n     pub args: Vec<PyObjectRef>,\n-    // TODO: add kwargs here\n+    pub kwargs: Option<Vec<(String, PyObjectRef)>>,","path":"vm/src/pyobject.rs","position":5,"original_position":5,"commit_id":"67b7cc2e45bb6d97dcceea108ba4a7a5989d57da","original_commit_id":"67b7cc2e45bb6d97dcceea108ba4a7a5989d57da","user":{"login":"windelbouwman","id":1816500,"node_id":"MDQ6VXNlcjE4MTY1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1816500?v=4","gravatar_id":"","url":"https://api.github.com/users/windelbouwman","html_url":"https://github.com/windelbouwman","followers_url":"https://api.github.com/users/windelbouwman/followers","following_url":"https://api.github.com/users/windelbouwman/following{/other_user}","gists_url":"https://api.github.com/users/windelbouwman/gists{/gist_id}","starred_url":"https://api.github.com/users/windelbouwman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windelbouwman/subscriptions","organizations_url":"https://api.github.com/users/windelbouwman/orgs","repos_url":"https://api.github.com/users/windelbouwman/repos","events_url":"https://api.github.com/users/windelbouwman/events{/privacy}","received_events_url":"https://api.github.com/users/windelbouwman/received_events","type":"User","site_admin":false},"body":"Btw, is option required? An empty vector means no kwargs?","created_at":"2018-08-31T20:18:41Z","updated_at":"2018-08-31T20:18:41Z","html_url":"https://github.com/RustPython/RustPython/pull/115#discussion_r214465477","pull_request_url":"https://api.github.com/repos/RustPython/RustPython/pulls/115","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RustPython/RustPython/pulls/comments/214465477"},"html":{"href":"https://github.com/RustPython/RustPython/pull/115#discussion_r214465477"},"pull_request":{"href":"https://api.github.com/repos/RustPython/RustPython/pulls/115"}},"in_reply_to_id":214465357},"pull_request":{"url":"https://api.github.com/repos/RustPython/RustPython/pulls/115","id":212481610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDgxNjEw","html_url":"https://github.com/RustPython/RustPython/pull/115","diff_url":"https://github.com/RustPython/RustPython/pull/115.diff","patch_url":"https://github.com/RustPython/RustPython/pull/115.patch","issue_url":"https://api.github.com/repos/RustPython/RustPython/issues/115","number":115,"state":"open","locked":false,"title":"Implement kwargs in function calls","user":{"login":"OddBloke","id":62736,"node_id":"MDQ6VXNlcjYyNzM2","avatar_url":"https://avatars1.githubusercontent.com/u/62736?v=4","gravatar_id":"","url":"https://api.github.com/users/OddBloke","html_url":"https://github.com/OddBloke","followers_url":"https://api.github.com/users/OddBloke/followers","following_url":"https://api.github.com/users/OddBloke/following{/other_user}","gists_url":"https://api.github.com/users/OddBloke/gists{/gist_id}","starred_url":"https://api.github.com/users/OddBloke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OddBloke/subscriptions","organizations_url":"https://api.github.com/users/OddBloke/orgs","repos_url":"https://api.github.com/users/OddBloke/repos","events_url":"https://api.github.com/users/OddBloke/events{/privacy}","received_events_url":"https://api.github.com/users/OddBloke/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-31T20:01:19Z","updated_at":"2018-08-31T20:18:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f46c518704ad699d2719864959d9808660c6492a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RustPython/RustPython/pulls/115/commits","review_comments_url":"https://api.github.com/repos/RustPython/RustPython/pulls/115/comments","review_comment_url":"https://api.github.com/repos/RustPython/RustPython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RustPython/RustPython/issues/115/comments","statuses_url":"https://api.github.com/repos/RustPython/RustPython/statuses/67b7cc2e45bb6d97dcceea108ba4a7a5989d57da","head":{"label":"OddBloke:kwargs","ref":"kwargs","sha":"67b7cc2e45bb6d97dcceea108ba4a7a5989d57da","user":{"login":"OddBloke","id":62736,"node_id":"MDQ6VXNlcjYyNzM2","avatar_url":"https://avatars1.githubusercontent.com/u/62736?v=4","gravatar_id":"","url":"https://api.github.com/users/OddBloke","html_url":"https://github.com/OddBloke","followers_url":"https://api.github.com/users/OddBloke/followers","following_url":"https://api.github.com/users/OddBloke/following{/other_user}","gists_url":"https://api.github.com/users/OddBloke/gists{/gist_id}","starred_url":"https://api.github.com/users/OddBloke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OddBloke/subscriptions","organizations_url":"https://api.github.com/users/OddBloke/orgs","repos_url":"https://api.github.com/users/OddBloke/repos","events_url":"https://api.github.com/users/OddBloke/events{/privacy}","received_events_url":"https://api.github.com/users/OddBloke/received_events","type":"User","site_admin":false},"repo":{"id":143053292,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNTMyOTI=","name":"RustPython","full_name":"OddBloke/RustPython","owner":{"login":"OddBloke","id":62736,"node_id":"MDQ6VXNlcjYyNzM2","avatar_url":"https://avatars1.githubusercontent.com/u/62736?v=4","gravatar_id":"","url":"https://api.github.com/users/OddBloke","html_url":"https://github.com/OddBloke","followers_url":"https://api.github.com/users/OddBloke/followers","following_url":"https://api.github.com/users/OddBloke/following{/other_user}","gists_url":"https://api.github.com/users/OddBloke/gists{/gist_id}","starred_url":"https://api.github.com/users/OddBloke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OddBloke/subscriptions","organizations_url":"https://api.github.com/users/OddBloke/orgs","repos_url":"https://api.github.com/users/OddBloke/repos","events_url":"https://api.github.com/users/OddBloke/events{/privacy}","received_events_url":"https://api.github.com/users/OddBloke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OddBloke/RustPython","description":"A Python Interpreter written in Rust","fork":true,"url":"https://api.github.com/repos/OddBloke/RustPython","forks_url":"https://api.github.com/repos/OddBloke/RustPython/forks","keys_url":"https://api.github.com/repos/OddBloke/RustPython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OddBloke/RustPython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OddBloke/RustPython/teams","hooks_url":"https://api.github.com/repos/OddBloke/RustPython/hooks","issue_events_url":"https://api.github.com/repos/OddBloke/RustPython/issues/events{/number}","events_url":"https://api.github.com/repos/OddBloke/RustPython/events","assignees_url":"https://api.github.com/repos/OddBloke/RustPython/assignees{/user}","branches_url":"https://api.github.com/repos/OddBloke/RustPython/branches{/branch}","tags_url":"https://api.github.com/repos/OddBloke/RustPython/tags","blobs_url":"https://api.github.com/repos/OddBloke/RustPython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OddBloke/RustPython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OddBloke/RustPython/git/refs{/sha}","trees_url":"https://api.github.com/repos/OddBloke/RustPython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OddBloke/RustPython/statuses/{sha}","languages_url":"https://api.github.com/repos/OddBloke/RustPython/languages","stargazers_url":"https://api.github.com/repos/OddBloke/RustPython/stargazers","contributors_url":"https://api.github.com/repos/OddBloke/RustPython/contributors","subscribers_url":"https://api.github.com/repos/OddBloke/RustPython/subscribers","subscription_url":"https://api.github.com/repos/OddBloke/RustPython/subscription","commits_url":"https://api.github.com/repos/OddBloke/RustPython/commits{/sha}","git_commits_url":"https://api.github.com/repos/OddBloke/RustPython/git/commits{/sha}","comments_url":"https://api.github.com/repos/OddBloke/RustPython/comments{/number}","issue_comment_url":"https://api.github.com/repos/OddBloke/RustPython/issues/comments{/number}","contents_url":"https://api.github.com/repos/OddBloke/RustPython/contents/{+path}","compare_url":"https://api.github.com/repos/OddBloke/RustPython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OddBloke/RustPython/merges","archive_url":"https://api.github.com/repos/OddBloke/RustPython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OddBloke/RustPython/downloads","issues_url":"https://api.github.com/repos/OddBloke/RustPython/issues{/number}","pulls_url":"https://api.github.com/repos/OddBloke/RustPython/pulls{/number}","milestones_url":"https://api.github.com/repos/OddBloke/RustPython/milestones{/number}","notifications_url":"https://api.github.com/repos/OddBloke/RustPython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OddBloke/RustPython/labels{/name}","releases_url":"https://api.github.com/repos/OddBloke/RustPython/releases{/id}","deployments_url":"https://api.github.com/repos/OddBloke/RustPython/deployments","created_at":"2018-07-31T18:38:26Z","updated_at":"2018-08-06T14:59:41Z","pushed_at":"2018-08-31T20:00:25Z","git_url":"git://github.com/OddBloke/RustPython.git","ssh_url":"git@github.com:OddBloke/RustPython.git","clone_url":"https://github.com/OddBloke/RustPython.git","svn_url":"https://github.com/OddBloke/RustPython","homepage":null,"size":21366,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RustPython:master","ref":"master","sha":"5f0c8a343f7a788f0f915703bb8f33a6d567105f","user":{"login":"RustPython","id":39710557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzEwNTU3","avatar_url":"https://avatars3.githubusercontent.com/u/39710557?v=4","gravatar_id":"","url":"https://api.github.com/users/RustPython","html_url":"https://github.com/RustPython","followers_url":"https://api.github.com/users/RustPython/followers","following_url":"https://api.github.com/users/RustPython/following{/other_user}","gists_url":"https://api.github.com/users/RustPython/gists{/gist_id}","starred_url":"https://api.github.com/users/RustPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RustPython/subscriptions","organizations_url":"https://api.github.com/users/RustPython/orgs","repos_url":"https://api.github.com/users/RustPython/repos","events_url":"https://api.github.com/users/RustPython/events{/privacy}","received_events_url":"https://api.github.com/users/RustPython/received_events","type":"Organization","site_admin":false},"repo":{"id":135201145,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyMDExNDU=","name":"RustPython","full_name":"RustPython/RustPython","owner":{"login":"RustPython","id":39710557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzEwNTU3","avatar_url":"https://avatars3.githubusercontent.com/u/39710557?v=4","gravatar_id":"","url":"https://api.github.com/users/RustPython","html_url":"https://github.com/RustPython","followers_url":"https://api.github.com/users/RustPython/followers","following_url":"https://api.github.com/users/RustPython/following{/other_user}","gists_url":"https://api.github.com/users/RustPython/gists{/gist_id}","starred_url":"https://api.github.com/users/RustPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RustPython/subscriptions","organizations_url":"https://api.github.com/users/RustPython/orgs","repos_url":"https://api.github.com/users/RustPython/repos","events_url":"https://api.github.com/users/RustPython/events{/privacy}","received_events_url":"https://api.github.com/users/RustPython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RustPython/RustPython","description":"A Python Interpreter written in Rust","fork":false,"url":"https://api.github.com/repos/RustPython/RustPython","forks_url":"https://api.github.com/repos/RustPython/RustPython/forks","keys_url":"https://api.github.com/repos/RustPython/RustPython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RustPython/RustPython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RustPython/RustPython/teams","hooks_url":"https://api.github.com/repos/RustPython/RustPython/hooks","issue_events_url":"https://api.github.com/repos/RustPython/RustPython/issues/events{/number}","events_url":"https://api.github.com/repos/RustPython/RustPython/events","assignees_url":"https://api.github.com/repos/RustPython/RustPython/assignees{/user}","branches_url":"https://api.github.com/repos/RustPython/RustPython/branches{/branch}","tags_url":"https://api.github.com/repos/RustPython/RustPython/tags","blobs_url":"https://api.github.com/repos/RustPython/RustPython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RustPython/RustPython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RustPython/RustPython/git/refs{/sha}","trees_url":"https://api.github.com/repos/RustPython/RustPython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RustPython/RustPython/statuses/{sha}","languages_url":"https://api.github.com/repos/RustPython/RustPython/languages","stargazers_url":"https://api.github.com/repos/RustPython/RustPython/stargazers","contributors_url":"https://api.github.com/repos/RustPython/RustPython/contributors","subscribers_url":"https://api.github.com/repos/RustPython/RustPython/subscribers","subscription_url":"https://api.github.com/repos/RustPython/RustPython/subscription","commits_url":"https://api.github.com/repos/RustPython/RustPython/commits{/sha}","git_commits_url":"https://api.github.com/repos/RustPython/RustPython/git/commits{/sha}","comments_url":"https://api.github.com/repos/RustPython/RustPython/comments{/number}","issue_comment_url":"https://api.github.com/repos/RustPython/RustPython/issues/comments{/number}","contents_url":"https://api.github.com/repos/RustPython/RustPython/contents/{+path}","compare_url":"https://api.github.com/repos/RustPython/RustPython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RustPython/RustPython/merges","archive_url":"https://api.github.com/repos/RustPython/RustPython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RustPython/RustPython/downloads","issues_url":"https://api.github.com/repos/RustPython/RustPython/issues{/number}","pulls_url":"https://api.github.com/repos/RustPython/RustPython/pulls{/number}","milestones_url":"https://api.github.com/repos/RustPython/RustPython/milestones{/number}","notifications_url":"https://api.github.com/repos/RustPython/RustPython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RustPython/RustPython/labels{/name}","releases_url":"https://api.github.com/repos/RustPython/RustPython/releases{/id}","deployments_url":"https://api.github.com/repos/RustPython/RustPython/deployments","created_at":"2018-05-28T19:27:01Z","updated_at":"2018-08-31T19:37:40Z","pushed_at":"2018-08-31T20:10:31Z","git_url":"git://github.com/RustPython/RustPython.git","ssh_url":"git@github.com:RustPython/RustPython.git","clone_url":"https://github.com/RustPython/RustPython.git","svn_url":"https://github.com/RustPython/RustPython","homepage":null,"size":21420,"stargazers_count":117,"watchers_count":117,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":18,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RustPython/RustPython/pulls/115"},"html":{"href":"https://github.com/RustPython/RustPython/pull/115"},"issue":{"href":"https://api.github.com/repos/RustPython/RustPython/issues/115"},"comments":{"href":"https://api.github.com/repos/RustPython/RustPython/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/RustPython/RustPython/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/RustPython/RustPython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RustPython/RustPython/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/RustPython/RustPython/statuses/67b7cc2e45bb6d97dcceea108ba4a7a5989d57da"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"windelbouwman"}}