{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/175228262","pull_request_review_id":104734294,"id":175228262,"diff_hunk":"@@ -0,0 +1,162 @@\n+/*\n+Copyright 2018 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package main\n+\n+import (\n+\t\"fmt\"\n+\t\"os\"\n+\t\"os/exec\"\n+\t\"path/filepath\"\n+\t\"strings\"\n+\t\"time\"\n+\n+\tclientv2 \"github.com/coreos/etcd/client\"\n+\t\"github.com/coreos/etcd/clientv3\"\n+\t\"github.com/golang/glog\"\n+\t\"golang.org/x/net/context\"\n+)\n+\n+// CombinedEtcdClient provides an implementation of EtcdMigrateClient using a combination of the etcd v2 client, v3 client\n+// and etcdctl commands called via the shell.\n+type CombinedEtcdClient struct {\n+\tcfg      *EtcdMigrateCfg\n+\tv2client clientv2.Client","path":"cluster/images/etcd/migrate/migrate_client.go","position":37,"original_position":37,"commit_id":"81816767b25ee9002156db09ce0f80397c28ef47","original_commit_id":"81816767b25ee9002156db09ce0f80397c28ef47","user":{"login":"wenjiaswe","id":33743058,"avatar_url":"https://avatars1.githubusercontent.com/u/33743058?v=4","gravatar_id":"","url":"https://api.github.com/users/wenjiaswe","html_url":"https://github.com/wenjiaswe","followers_url":"https://api.github.com/users/wenjiaswe/followers","following_url":"https://api.github.com/users/wenjiaswe/following{/other_user}","gists_url":"https://api.github.com/users/wenjiaswe/gists{/gist_id}","starred_url":"https://api.github.com/users/wenjiaswe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenjiaswe/subscriptions","organizations_url":"https://api.github.com/users/wenjiaswe/orgs","repos_url":"https://api.github.com/users/wenjiaswe/repos","events_url":"https://api.github.com/users/wenjiaswe/events{/privacy}","received_events_url":"https://api.github.com/users/wenjiaswe/received_events","type":"User","site_admin":false},"body":"Is v2client supposed to be a pointer as well?","created_at":"2018-03-16T22:25:54Z","updated_at":"2018-03-16T22:25:54Z","html_url":"https://github.com/kubernetes/kubernetes/pull/61241#discussion_r175228262","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61241","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/175228262"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61241#discussion_r175228262"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61241"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61241","id":175388241,"html_url":"https://github.com/kubernetes/kubernetes/pull/61241","diff_url":"https://github.com/kubernetes/kubernetes/pull/61241.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61241.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61241","number":61241,"state":"open","locked":false,"title":"Reimplement migrate-if-needed.sh in go","user":{"login":"jpbetz","id":523590,"avatar_url":"https://avatars1.githubusercontent.com/u/523590?v=4","gravatar_id":"","url":"https://api.github.com/users/jpbetz","html_url":"https://github.com/jpbetz","followers_url":"https://api.github.com/users/jpbetz/followers","following_url":"https://api.github.com/users/jpbetz/following{/other_user}","gists_url":"https://api.github.com/users/jpbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpbetz/subscriptions","organizations_url":"https://api.github.com/users/jpbetz/orgs","repos_url":"https://api.github.com/users/jpbetz/repos","events_url":"https://api.github.com/users/jpbetz/events{/privacy}","received_events_url":"https://api.github.com/users/jpbetz/received_events","type":"User","site_admin":false},"body":"The `migrate-if-needed.sh` script was already partially implemented in go (see the attachlease and rollback sub-dirs), but was still unnecessarily difficult to understand and test.  This closely reimplements the original logic but with improved code structure, error handling and testing.\r\n\r\nWhere possible, go code that was previously executed as separate binaries is now statically linked into a single 'migrate' go cobra CLI app, which is then thinly wrapped by`migrate-if-needed.sh`.\r\n\r\nThere are numerous additional improvements that need to be made, but will be submitted in future PRs.  This PR is focused on achieving parity with the pre-existing functionality and introducing some much needed unit test coverage.\r\n\r\nThe integration tests in the Makefile ensure the main upgrade / rollback flows continue to work as intended with the go impl.\r\n\r\nIt appears that the `attachlease` and `rollback` go binaries are no longer needed as standalones and so I have consolidated them into the new `migrate` go binary. Other than that, this change aims to be 100% backward compatible.\r\n\r\n```release-note\r\nNONE\r\n```","created_at":"2018-03-15T21:49:19Z","updated_at":"2018-03-16T22:25:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bd51801e10c119659114addd681e748c51d4b62","assignee":{"login":"mml","id":3115,"avatar_url":"https://avatars3.githubusercontent.com/u/3115?v=4","gravatar_id":"","url":"https://api.github.com/users/mml","html_url":"https://github.com/mml","followers_url":"https://api.github.com/users/mml/followers","following_url":"https://api.github.com/users/mml/following{/other_user}","gists_url":"https://api.github.com/users/mml/gists{/gist_id}","starred_url":"https://api.github.com/users/mml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mml/subscriptions","organizations_url":"https://api.github.com/users/mml/orgs","repos_url":"https://api.github.com/users/mml/repos","events_url":"https://api.github.com/users/mml/events{/privacy}","received_events_url":"https://api.github.com/users/mml/received_events","type":"User","site_admin":false},"assignees":[{"login":"mml","id":3115,"avatar_url":"https://avatars3.githubusercontent.com/u/3115?v=4","gravatar_id":"","url":"https://api.github.com/users/mml","html_url":"https://github.com/mml","followers_url":"https://api.github.com/users/mml/followers","following_url":"https://api.github.com/users/mml/following{/other_user}","gists_url":"https://api.github.com/users/mml/gists{/gist_id}","starred_url":"https://api.github.com/users/mml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mml/subscriptions","organizations_url":"https://api.github.com/users/mml/orgs","repos_url":"https://api.github.com/users/mml/repos","events_url":"https://api.github.com/users/mml/events{/privacy}","received_events_url":"https://api.github.com/users/mml/received_events","type":"User","site_admin":false},{"login":"lavalamp","id":647318,"avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},{"login":"cheftako","id":947971,"avatar_url":"https://avatars3.githubusercontent.com/u/947971?v=4","gravatar_id":"","url":"https://api.github.com/users/cheftako","html_url":"https://github.com/cheftako","followers_url":"https://api.github.com/users/cheftako/followers","following_url":"https://api.github.com/users/cheftako/following{/other_user}","gists_url":"https://api.github.com/users/cheftako/gists{/gist_id}","starred_url":"https://api.github.com/users/cheftako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheftako/subscriptions","organizations_url":"https://api.github.com/users/cheftako/orgs","repos_url":"https://api.github.com/users/cheftako/repos","events_url":"https://api.github.com/users/cheftako/events{/privacy}","received_events_url":"https://api.github.com/users/cheftako/received_events","type":"User","site_admin":false},{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars1.githubusercontent.com/u/7751204?v=4","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},{"login":"eparis","id":8093535,"avatar_url":"https://avatars3.githubusercontent.com/u/8093535?v=4","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":127257343,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/etcd","name":"area/etcd","color":"0052cc","default":false},{"id":134646230,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/platform/gce","name":"area/platform/gce","color":"d4c5f9","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":267761362,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":679979244,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/gcp","name":"sig/gcp","color":"d2b48c","default":false},{"id":253451093,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38","html_url":"https://github.com/kubernetes/kubernetes/milestone/38","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38/labels","id":2848396,"number":38,"title":"v1.11","description":null,"creator":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":77,"closed_issues":0,"state":"open","created_at":"2017-10-18T17:24:38Z","updated_at":"2018-03-16T17:13:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61241/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61241/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61241/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/81816767b25ee9002156db09ce0f80397c28ef47","head":{"label":"jpbetz:go-migrate-if-needed","ref":"go-migrate-if-needed","sha":"81816767b25ee9002156db09ce0f80397c28ef47","user":{"login":"jpbetz","id":523590,"avatar_url":"https://avatars1.githubusercontent.com/u/523590?v=4","gravatar_id":"","url":"https://api.github.com/users/jpbetz","html_url":"https://github.com/jpbetz","followers_url":"https://api.github.com/users/jpbetz/followers","following_url":"https://api.github.com/users/jpbetz/following{/other_user}","gists_url":"https://api.github.com/users/jpbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpbetz/subscriptions","organizations_url":"https://api.github.com/users/jpbetz/orgs","repos_url":"https://api.github.com/users/jpbetz/repos","events_url":"https://api.github.com/users/jpbetz/events{/privacy}","received_events_url":"https://api.github.com/users/jpbetz/received_events","type":"User","site_admin":false},"repo":{"id":103191852,"name":"kubernetes","full_name":"jpbetz/kubernetes","owner":{"login":"jpbetz","id":523590,"avatar_url":"https://avatars1.githubusercontent.com/u/523590?v=4","gravatar_id":"","url":"https://api.github.com/users/jpbetz","html_url":"https://github.com/jpbetz","followers_url":"https://api.github.com/users/jpbetz/followers","following_url":"https://api.github.com/users/jpbetz/following{/other_user}","gists_url":"https://api.github.com/users/jpbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpbetz/subscriptions","organizations_url":"https://api.github.com/users/jpbetz/orgs","repos_url":"https://api.github.com/users/jpbetz/repos","events_url":"https://api.github.com/users/jpbetz/events{/privacy}","received_events_url":"https://api.github.com/users/jpbetz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpbetz/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/jpbetz/kubernetes","forks_url":"https://api.github.com/repos/jpbetz/kubernetes/forks","keys_url":"https://api.github.com/repos/jpbetz/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpbetz/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpbetz/kubernetes/teams","hooks_url":"https://api.github.com/repos/jpbetz/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jpbetz/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jpbetz/kubernetes/events","assignees_url":"https://api.github.com/repos/jpbetz/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jpbetz/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jpbetz/kubernetes/tags","blobs_url":"https://api.github.com/repos/jpbetz/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpbetz/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpbetz/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpbetz/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpbetz/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jpbetz/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jpbetz/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jpbetz/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jpbetz/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jpbetz/kubernetes/subscription","commits_url":"https://api.github.com/repos/jpbetz/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpbetz/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpbetz/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpbetz/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpbetz/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jpbetz/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpbetz/kubernetes/merges","archive_url":"https://api.github.com/repos/jpbetz/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpbetz/kubernetes/downloads","issues_url":"https://api.github.com/repos/jpbetz/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jpbetz/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jpbetz/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jpbetz/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpbetz/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jpbetz/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/jpbetz/kubernetes/deployments","created_at":"2017-09-11T21:50:52Z","updated_at":"2017-09-11T21:51:35Z","pushed_at":"2018-03-16T18:29:37Z","git_url":"git://github.com/jpbetz/kubernetes.git","ssh_url":"git@github.com:jpbetz/kubernetes.git","clone_url":"https://github.com/jpbetz/kubernetes.git","svn_url":"https://github.com/jpbetz/kubernetes","homepage":"http://kubernetes.io","size":545519,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ca02c11887c65431af85f809606527be7f08062d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-03-16T22:17:21Z","pushed_at":"2018-03-16T22:24:46Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":764885,"stargazers_count":33813,"watchers_count":33813,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12005,"mirror_url":null,"archived":false,"open_issues_count":3559,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12005,"open_issues":3559,"watchers":33813,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61241"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61241"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61241"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61241/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61241/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61241/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/81816767b25ee9002156db09ce0f80397c28ef47"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wenjiaswe"}}