{"action":"created","issue":{"url":"https://api.github.com/repos/ohler55/agoo/issues/32","repository_url":"https://api.github.com/repos/ohler55/agoo","labels_url":"https://api.github.com/repos/ohler55/agoo/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/ohler55/agoo/issues/32/comments","events_url":"https://api.github.com/repos/ohler55/agoo/issues/32/events","html_url":"https://github.com/ohler55/agoo/issues/32","id":379526772,"node_id":"MDU6SXNzdWUzNzk1MjY3NzI=","number":32,"title":"reserved identifier violation","user":{"login":"elfring","id":660477,"node_id":"MDQ6VXNlcjY2MDQ3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/660477?v=4","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-11T14:15:35Z","updated_at":"2018-11-13T12:22:17Z","closed_at":null,"author_association":"NONE","body":"I would like to point out that identifiers like “[`__AGOO_TEXT_H__`](https://github.com/ohler55/agoo/blob/43df6048ea69395c03770871cef88a988557ca0b/ext/agoo/text.h#L3 \"Update candidate\")” and “[`_Hook`](https://github.com/ohler55/agoo/blob/b455db6a8caa15d870ff6b033f820ff1e07dc0f6/ext/agoo/hook.h#L24 \"Another update candidate\")” [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier \"Do not use identifiers which are reserved for the compiler implementation.\") to the expected naming convention of the C language standard.\r\nWould you like to adjust your selection for unique names?"},"comment":{"url":"https://api.github.com/repos/ohler55/agoo/issues/comments/438247298","html_url":"https://github.com/ohler55/agoo/issues/32#issuecomment-438247298","issue_url":"https://api.github.com/repos/ohler55/agoo/issues/32","id":438247298,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODI0NzI5OA==","user":{"login":"ohler55","id":118856,"node_id":"MDQ6VXNlcjExODg1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/118856?v=4","gravatar_id":"","url":"https://api.github.com/users/ohler55","html_url":"https://github.com/ohler55","followers_url":"https://api.github.com/users/ohler55/followers","following_url":"https://api.github.com/users/ohler55/following{/other_user}","gists_url":"https://api.github.com/users/ohler55/gists{/gist_id}","starred_url":"https://api.github.com/users/ohler55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohler55/subscriptions","organizations_url":"https://api.github.com/users/ohler55/orgs","repos_url":"https://api.github.com/users/ohler55/repos","events_url":"https://api.github.com/users/ohler55/events{/privacy}","received_events_url":"https://api.github.com/users/ohler55/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T12:22:17Z","updated_at":"2018-11-13T12:22:17Z","author_association":"OWNER","body":"If you point out the offending variables I'll change them on a case by case basis. I can imagine that the words like `total` or `street` would be considered reserved but I don't see a need to change words such as those."}}
{"actor":{"display_login":"ohler55"}}