{"action":"created","comment":{"url":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/comments/238100477","pull_request_review_id":180563439,"id":238100477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODEwMDQ3Nw==","diff_hunk":"@@ -66,10 +88,24 @@ class DeleteMembershipRequest(metaclass=ResourceMeta):\n     __params__ = {\n         'type': 'object',\n         'additionalProperties': False,\n-        'required': ['user_id'],\n+        'required': ['user_id', 'member_role', 'editor_id', 'editor_role'],\n         'properties': {\n             'user_id': {\n-                'type': 'string',\n+                'type': 'integer',\n+            },\n+        }\n+    }\n+\n+    __body__ = {","path":"bounce/server/resource/membership.py","position":84,"original_position":83,"commit_id":"94ffe8315d59e51cb2ab784568f78fa2a9a95e5b","original_commit_id":"8cf87873b168233f705869dc538bdb6e86fbc0b8","user":{"login":"ginsstaahh","id":7409729,"node_id":"MDQ6VXNlcjc0MDk3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/7409729?v=4","gravatar_id":"","url":"https://api.github.com/users/ginsstaahh","html_url":"https://github.com/ginsstaahh","followers_url":"https://api.github.com/users/ginsstaahh/followers","following_url":"https://api.github.com/users/ginsstaahh/following{/other_user}","gists_url":"https://api.github.com/users/ginsstaahh/gists{/gist_id}","starred_url":"https://api.github.com/users/ginsstaahh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginsstaahh/subscriptions","organizations_url":"https://api.github.com/users/ginsstaahh/orgs","repos_url":"https://api.github.com/users/ginsstaahh/repos","events_url":"https://api.github.com/users/ginsstaahh/events{/privacy}","received_events_url":"https://api.github.com/users/ginsstaahh/received_events","type":"User","site_admin":false},"body":"That's true.  We'll need to delete the user knowing his role.  I think what we should do in order to find his role is use the id of the user we want to delete, query the memberships table using his id, and get his role from there instead of getting it from the body.  It should look very similar to how we do it for checking the editor's role.  Can you think of how you can do that?","created_at":"2018-12-02T14:17:07Z","updated_at":"2018-12-02T14:17:07Z","html_url":"https://github.com/ubclaunchpad/bounce/pull/100#discussion_r238100477","pull_request_url":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/comments/238100477"},"html":{"href":"https://github.com/ubclaunchpad/bounce/pull/100#discussion_r238100477"},"pull_request":{"href":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/100"}},"in_reply_to_id":236799918},"pull_request":{"url":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/100","id":230989032,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTg5MDMy","html_url":"https://github.com/ubclaunchpad/bounce/pull/100","diff_url":"https://github.com/ubclaunchpad/bounce/pull/100.diff","patch_url":"https://github.com/ubclaunchpad/bounce/pull/100.patch","issue_url":"https://api.github.com/repos/ubclaunchpad/bounce/issues/100","number":100,"state":"open","locked":false,"title":"Roles and Positions","user":{"login":"ginsstaahh","id":7409729,"node_id":"MDQ6VXNlcjc0MDk3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/7409729?v=4","gravatar_id":"","url":"https://api.github.com/users/ginsstaahh","html_url":"https://github.com/ginsstaahh","followers_url":"https://api.github.com/users/ginsstaahh/followers","following_url":"https://api.github.com/users/ginsstaahh/following{/other_user}","gists_url":"https://api.github.com/users/ginsstaahh/gists{/gist_id}","starred_url":"https://api.github.com/users/ginsstaahh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginsstaahh/subscriptions","organizations_url":"https://api.github.com/users/ginsstaahh/orgs","repos_url":"https://api.github.com/users/ginsstaahh/repos","events_url":"https://api.github.com/users/ginsstaahh/events{/privacy}","received_events_url":"https://api.github.com/users/ginsstaahh/received_events","type":"User","site_admin":false},"body":":tickets: **Ticket(s)**: Closes #90,91,62,56,78\r\n\r\n---\r\n\r\n## :construction_worker: Changes\r\n\r\n_Briefly describe the changes you made and why you made them in bulleted form._\r\n\r\n## :traffic_light: Concerns\r\n\r\n_If there is anything you want reviewers to pay special attention to, put it here._\r\n\r\n## :mag: Testing Instructions\r\n\r\n_Explain how to test your changes, if applicable._\r\n","created_at":"2018-11-14T21:33:23Z","updated_at":"2018-12-02T14:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/100/commits","review_comments_url":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/100/comments","review_comment_url":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubclaunchpad/bounce/issues/100/comments","statuses_url":"https://api.github.com/repos/ubclaunchpad/bounce/statuses/94ffe8315d59e51cb2ab784568f78fa2a9a95e5b","head":{"label":"ubclaunchpad:positions","ref":"positions","sha":"94ffe8315d59e51cb2ab784568f78fa2a9a95e5b","user":{"login":"ubclaunchpad","id":12406312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDA2MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12406312?v=4","gravatar_id":"","url":"https://api.github.com/users/ubclaunchpad","html_url":"https://github.com/ubclaunchpad","followers_url":"https://api.github.com/users/ubclaunchpad/followers","following_url":"https://api.github.com/users/ubclaunchpad/following{/other_user}","gists_url":"https://api.github.com/users/ubclaunchpad/gists{/gist_id}","starred_url":"https://api.github.com/users/ubclaunchpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubclaunchpad/subscriptions","organizations_url":"https://api.github.com/users/ubclaunchpad/orgs","repos_url":"https://api.github.com/users/ubclaunchpad/repos","events_url":"https://api.github.com/users/ubclaunchpad/events{/privacy}","received_events_url":"https://api.github.com/users/ubclaunchpad/received_events","type":"Organization","site_admin":false},"repo":{"id":134099219,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQwOTkyMTk=","name":"bounce","full_name":"ubclaunchpad/bounce","private":false,"owner":{"login":"ubclaunchpad","id":12406312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDA2MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12406312?v=4","gravatar_id":"","url":"https://api.github.com/users/ubclaunchpad","html_url":"https://github.com/ubclaunchpad","followers_url":"https://api.github.com/users/ubclaunchpad/followers","following_url":"https://api.github.com/users/ubclaunchpad/following{/other_user}","gists_url":"https://api.github.com/users/ubclaunchpad/gists{/gist_id}","starred_url":"https://api.github.com/users/ubclaunchpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubclaunchpad/subscriptions","organizations_url":"https://api.github.com/users/ubclaunchpad/orgs","repos_url":"https://api.github.com/users/ubclaunchpad/repos","events_url":"https://api.github.com/users/ubclaunchpad/events{/privacy}","received_events_url":"https://api.github.com/users/ubclaunchpad/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ubclaunchpad/bounce","description":"🏀 Bringing people with common interests together","fork":false,"url":"https://api.github.com/repos/ubclaunchpad/bounce","forks_url":"https://api.github.com/repos/ubclaunchpad/bounce/forks","keys_url":"https://api.github.com/repos/ubclaunchpad/bounce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubclaunchpad/bounce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubclaunchpad/bounce/teams","hooks_url":"https://api.github.com/repos/ubclaunchpad/bounce/hooks","issue_events_url":"https://api.github.com/repos/ubclaunchpad/bounce/issues/events{/number}","events_url":"https://api.github.com/repos/ubclaunchpad/bounce/events","assignees_url":"https://api.github.com/repos/ubclaunchpad/bounce/assignees{/user}","branches_url":"https://api.github.com/repos/ubclaunchpad/bounce/branches{/branch}","tags_url":"https://api.github.com/repos/ubclaunchpad/bounce/tags","blobs_url":"https://api.github.com/repos/ubclaunchpad/bounce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubclaunchpad/bounce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubclaunchpad/bounce/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubclaunchpad/bounce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubclaunchpad/bounce/statuses/{sha}","languages_url":"https://api.github.com/repos/ubclaunchpad/bounce/languages","stargazers_url":"https://api.github.com/repos/ubclaunchpad/bounce/stargazers","contributors_url":"https://api.github.com/repos/ubclaunchpad/bounce/contributors","subscribers_url":"https://api.github.com/repos/ubclaunchpad/bounce/subscribers","subscription_url":"https://api.github.com/repos/ubclaunchpad/bounce/subscription","commits_url":"https://api.github.com/repos/ubclaunchpad/bounce/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubclaunchpad/bounce/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubclaunchpad/bounce/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubclaunchpad/bounce/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubclaunchpad/bounce/contents/{+path}","compare_url":"https://api.github.com/repos/ubclaunchpad/bounce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubclaunchpad/bounce/merges","archive_url":"https://api.github.com/repos/ubclaunchpad/bounce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubclaunchpad/bounce/downloads","issues_url":"https://api.github.com/repos/ubclaunchpad/bounce/issues{/number}","pulls_url":"https://api.github.com/repos/ubclaunchpad/bounce/pulls{/number}","milestones_url":"https://api.github.com/repos/ubclaunchpad/bounce/milestones{/number}","notifications_url":"https://api.github.com/repos/ubclaunchpad/bounce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubclaunchpad/bounce/labels{/name}","releases_url":"https://api.github.com/repos/ubclaunchpad/bounce/releases{/id}","deployments_url":"https://api.github.com/repos/ubclaunchpad/bounce/deployments","created_at":"2018-05-19T21:28:38Z","updated_at":"2018-12-02T07:12:08Z","pushed_at":"2018-12-02T07:12:07Z","git_url":"git://github.com/ubclaunchpad/bounce.git","ssh_url":"git@github.com:ubclaunchpad/bounce.git","clone_url":"https://github.com/ubclaunchpad/bounce.git","svn_url":"https://github.com/ubclaunchpad/bounce","homepage":"","size":3294,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":22,"watchers":0,"default_branch":"master"}},"base":{"label":"ubclaunchpad:master","ref":"master","sha":"ce1dd66dc7fb10583600a48e48ef343f7cc5fb1d","user":{"login":"ubclaunchpad","id":12406312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDA2MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12406312?v=4","gravatar_id":"","url":"https://api.github.com/users/ubclaunchpad","html_url":"https://github.com/ubclaunchpad","followers_url":"https://api.github.com/users/ubclaunchpad/followers","following_url":"https://api.github.com/users/ubclaunchpad/following{/other_user}","gists_url":"https://api.github.com/users/ubclaunchpad/gists{/gist_id}","starred_url":"https://api.github.com/users/ubclaunchpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubclaunchpad/subscriptions","organizations_url":"https://api.github.com/users/ubclaunchpad/orgs","repos_url":"https://api.github.com/users/ubclaunchpad/repos","events_url":"https://api.github.com/users/ubclaunchpad/events{/privacy}","received_events_url":"https://api.github.com/users/ubclaunchpad/received_events","type":"Organization","site_admin":false},"repo":{"id":134099219,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQwOTkyMTk=","name":"bounce","full_name":"ubclaunchpad/bounce","private":false,"owner":{"login":"ubclaunchpad","id":12406312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDA2MzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12406312?v=4","gravatar_id":"","url":"https://api.github.com/users/ubclaunchpad","html_url":"https://github.com/ubclaunchpad","followers_url":"https://api.github.com/users/ubclaunchpad/followers","following_url":"https://api.github.com/users/ubclaunchpad/following{/other_user}","gists_url":"https://api.github.com/users/ubclaunchpad/gists{/gist_id}","starred_url":"https://api.github.com/users/ubclaunchpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubclaunchpad/subscriptions","organizations_url":"https://api.github.com/users/ubclaunchpad/orgs","repos_url":"https://api.github.com/users/ubclaunchpad/repos","events_url":"https://api.github.com/users/ubclaunchpad/events{/privacy}","received_events_url":"https://api.github.com/users/ubclaunchpad/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ubclaunchpad/bounce","description":"🏀 Bringing people with common interests together","fork":false,"url":"https://api.github.com/repos/ubclaunchpad/bounce","forks_url":"https://api.github.com/repos/ubclaunchpad/bounce/forks","keys_url":"https://api.github.com/repos/ubclaunchpad/bounce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubclaunchpad/bounce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubclaunchpad/bounce/teams","hooks_url":"https://api.github.com/repos/ubclaunchpad/bounce/hooks","issue_events_url":"https://api.github.com/repos/ubclaunchpad/bounce/issues/events{/number}","events_url":"https://api.github.com/repos/ubclaunchpad/bounce/events","assignees_url":"https://api.github.com/repos/ubclaunchpad/bounce/assignees{/user}","branches_url":"https://api.github.com/repos/ubclaunchpad/bounce/branches{/branch}","tags_url":"https://api.github.com/repos/ubclaunchpad/bounce/tags","blobs_url":"https://api.github.com/repos/ubclaunchpad/bounce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubclaunchpad/bounce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubclaunchpad/bounce/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubclaunchpad/bounce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubclaunchpad/bounce/statuses/{sha}","languages_url":"https://api.github.com/repos/ubclaunchpad/bounce/languages","stargazers_url":"https://api.github.com/repos/ubclaunchpad/bounce/stargazers","contributors_url":"https://api.github.com/repos/ubclaunchpad/bounce/contributors","subscribers_url":"https://api.github.com/repos/ubclaunchpad/bounce/subscribers","subscription_url":"https://api.github.com/repos/ubclaunchpad/bounce/subscription","commits_url":"https://api.github.com/repos/ubclaunchpad/bounce/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubclaunchpad/bounce/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubclaunchpad/bounce/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubclaunchpad/bounce/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubclaunchpad/bounce/contents/{+path}","compare_url":"https://api.github.com/repos/ubclaunchpad/bounce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubclaunchpad/bounce/merges","archive_url":"https://api.github.com/repos/ubclaunchpad/bounce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubclaunchpad/bounce/downloads","issues_url":"https://api.github.com/repos/ubclaunchpad/bounce/issues{/number}","pulls_url":"https://api.github.com/repos/ubclaunchpad/bounce/pulls{/number}","milestones_url":"https://api.github.com/repos/ubclaunchpad/bounce/milestones{/number}","notifications_url":"https://api.github.com/repos/ubclaunchpad/bounce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubclaunchpad/bounce/labels{/name}","releases_url":"https://api.github.com/repos/ubclaunchpad/bounce/releases{/id}","deployments_url":"https://api.github.com/repos/ubclaunchpad/bounce/deployments","created_at":"2018-05-19T21:28:38Z","updated_at":"2018-12-02T07:12:08Z","pushed_at":"2018-12-02T07:12:07Z","git_url":"git://github.com/ubclaunchpad/bounce.git","ssh_url":"git@github.com:ubclaunchpad/bounce.git","clone_url":"https://github.com/ubclaunchpad/bounce.git","svn_url":"https://github.com/ubclaunchpad/bounce","homepage":"","size":3294,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":22,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/100"},"html":{"href":"https://github.com/ubclaunchpad/bounce/pull/100"},"issue":{"href":"https://api.github.com/repos/ubclaunchpad/bounce/issues/100"},"comments":{"href":"https://api.github.com/repos/ubclaunchpad/bounce/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubclaunchpad/bounce/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/ubclaunchpad/bounce/statuses/94ffe8315d59e51cb2ab784568f78fa2a9a95e5b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ginsstaahh"}}