{"action":"created","comment":{"url":"https://api.github.com/repos/grommet/grommet/pulls/comments/238893362","pull_request_review_id":181546589,"id":238893362,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODg5MzM2Mg==","diff_hunk":"@@ -327,6 +327,19 @@ xlarge\n string\n ```\n \n+**height**","path":"src/js/components/Select/README.md","position":4,"original_position":4,"commit_id":"5f311922308b0958577de8b99bd050a86640efe3","original_commit_id":"5f311922308b0958577de8b99bd050a86640efe3","user":{"login":"alansouzati","id":1207250,"node_id":"MDQ6VXNlcjEyMDcyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1207250?v=4","gravatar_id":"","url":"https://api.github.com/users/alansouzati","html_url":"https://github.com/alansouzati","followers_url":"https://api.github.com/users/alansouzati/followers","following_url":"https://api.github.com/users/alansouzati/following{/other_user}","gists_url":"https://api.github.com/users/alansouzati/gists{/gist_id}","starred_url":"https://api.github.com/users/alansouzati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alansouzati/subscriptions","organizations_url":"https://api.github.com/users/alansouzati/orgs","repos_url":"https://api.github.com/users/alansouzati/repos","events_url":"https://api.github.com/users/alansouzati/events{/privacy}","received_events_url":"https://api.github.com/users/alansouzati/received_events","type":"User","site_admin":false},"body":"show we say dropHeight just to be more explicit ? @ericsoderberghp thoughts?","created_at":"2018-12-05T00:34:42Z","updated_at":"2018-12-05T00:34:42Z","html_url":"https://github.com/grommet/grommet/pull/2532#discussion_r238893362","pull_request_url":"https://api.github.com/repos/grommet/grommet/pulls/2532","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/grommet/grommet/pulls/comments/238893362"},"html":{"href":"https://github.com/grommet/grommet/pull/2532#discussion_r238893362"},"pull_request":{"href":"https://api.github.com/repos/grommet/grommet/pulls/2532"}}},"pull_request":{"url":"https://api.github.com/repos/grommet/grommet/pulls/2532","id":235996605,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTk2NjA1","html_url":"https://github.com/grommet/grommet/pull/2532","diff_url":"https://github.com/grommet/grommet/pull/2532.diff","patch_url":"https://github.com/grommet/grommet/pull/2532.patch","issue_url":"https://api.github.com/repos/grommet/grommet/issues/2532","number":2532,"state":"open","locked":false,"title":"[Select] Add option to limit height of the drop container","user":{"login":"oorestisime","id":3874836,"node_id":"MDQ6VXNlcjM4NzQ4MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3874836?v=4","gravatar_id":"","url":"https://api.github.com/users/oorestisime","html_url":"https://github.com/oorestisime","followers_url":"https://api.github.com/users/oorestisime/followers","following_url":"https://api.github.com/users/oorestisime/following{/other_user}","gists_url":"https://api.github.com/users/oorestisime/gists{/gist_id}","starred_url":"https://api.github.com/users/oorestisime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oorestisime/subscriptions","organizations_url":"https://api.github.com/users/oorestisime/orgs","repos_url":"https://api.github.com/users/oorestisime/repos","events_url":"https://api.github.com/users/oorestisime/events{/privacy}","received_events_url":"https://api.github.com/users/oorestisime/received_events","type":"User","site_admin":false},"body":"Closes: #2426\r\n\r\nSigned-off-by: Orestis Ioannou <oorestisime@gmail.com>\r\n\r\n<!--- Provide a general summary of the PR in the Title above -->\r\n\r\n#### What does this PR do?\r\n\r\nAdd height option to the select component which is forwarded to the drop container\r\n\r\n#### Where should the reviewer start?\r\n\r\n#### What testing has been done on this PR?\r\n\r\nModified the lots options of the storybook to include a height\r\n\r\n#### How should this be manually tested?\r\nstorybook\r\n#### Any background context you want to provide?\r\n\r\n#### What are the relevant issues?\r\n#2426\r\n#### Screenshots (if appropriate)\r\n\r\n#### Do the grommet docs need to be updated?\r\ndid it\r\n#### Should this PR be mentioned in the release notes?\r\n\r\n#### Is this change backwards compatible or is it a breaking change?\r\ncompatible","created_at":"2018-12-04T23:33:29Z","updated_at":"2018-12-05T00:34:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f783e9b8db5140a3be730c77cc2cbd8fa919fe3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":482916132,"node_id":"MDU6TGFiZWw0ODI5MTYxMzI=","url":"https://api.github.com/repos/grommet/grommet/labels/in%20progress","name":"in progress","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grommet/grommet/pulls/2532/commits","review_comments_url":"https://api.github.com/repos/grommet/grommet/pulls/2532/comments","review_comment_url":"https://api.github.com/repos/grommet/grommet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grommet/grommet/issues/2532/comments","statuses_url":"https://api.github.com/repos/grommet/grommet/statuses/5f311922308b0958577de8b99bd050a86640efe3","head":{"label":"oorestisime:select_drop_container","ref":"select_drop_container","sha":"5f311922308b0958577de8b99bd050a86640efe3","user":{"login":"oorestisime","id":3874836,"node_id":"MDQ6VXNlcjM4NzQ4MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3874836?v=4","gravatar_id":"","url":"https://api.github.com/users/oorestisime","html_url":"https://github.com/oorestisime","followers_url":"https://api.github.com/users/oorestisime/followers","following_url":"https://api.github.com/users/oorestisime/following{/other_user}","gists_url":"https://api.github.com/users/oorestisime/gists{/gist_id}","starred_url":"https://api.github.com/users/oorestisime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oorestisime/subscriptions","organizations_url":"https://api.github.com/users/oorestisime/orgs","repos_url":"https://api.github.com/users/oorestisime/repos","events_url":"https://api.github.com/users/oorestisime/events{/privacy}","received_events_url":"https://api.github.com/users/oorestisime/received_events","type":"User","site_admin":false},"repo":{"id":159043467,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkwNDM0Njc=","name":"grommet","full_name":"oorestisime/grommet","private":false,"owner":{"login":"oorestisime","id":3874836,"node_id":"MDQ6VXNlcjM4NzQ4MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3874836?v=4","gravatar_id":"","url":"https://api.github.com/users/oorestisime","html_url":"https://github.com/oorestisime","followers_url":"https://api.github.com/users/oorestisime/followers","following_url":"https://api.github.com/users/oorestisime/following{/other_user}","gists_url":"https://api.github.com/users/oorestisime/gists{/gist_id}","starred_url":"https://api.github.com/users/oorestisime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oorestisime/subscriptions","organizations_url":"https://api.github.com/users/oorestisime/orgs","repos_url":"https://api.github.com/users/oorestisime/repos","events_url":"https://api.github.com/users/oorestisime/events{/privacy}","received_events_url":"https://api.github.com/users/oorestisime/received_events","type":"User","site_admin":false},"html_url":"https://github.com/oorestisime/grommet","description":"a react-based framework that provides accessibility, modularity, responsiveness, and theming in a tidy package","fork":true,"url":"https://api.github.com/repos/oorestisime/grommet","forks_url":"https://api.github.com/repos/oorestisime/grommet/forks","keys_url":"https://api.github.com/repos/oorestisime/grommet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oorestisime/grommet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oorestisime/grommet/teams","hooks_url":"https://api.github.com/repos/oorestisime/grommet/hooks","issue_events_url":"https://api.github.com/repos/oorestisime/grommet/issues/events{/number}","events_url":"https://api.github.com/repos/oorestisime/grommet/events","assignees_url":"https://api.github.com/repos/oorestisime/grommet/assignees{/user}","branches_url":"https://api.github.com/repos/oorestisime/grommet/branches{/branch}","tags_url":"https://api.github.com/repos/oorestisime/grommet/tags","blobs_url":"https://api.github.com/repos/oorestisime/grommet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oorestisime/grommet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oorestisime/grommet/git/refs{/sha}","trees_url":"https://api.github.com/repos/oorestisime/grommet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oorestisime/grommet/statuses/{sha}","languages_url":"https://api.github.com/repos/oorestisime/grommet/languages","stargazers_url":"https://api.github.com/repos/oorestisime/grommet/stargazers","contributors_url":"https://api.github.com/repos/oorestisime/grommet/contributors","subscribers_url":"https://api.github.com/repos/oorestisime/grommet/subscribers","subscription_url":"https://api.github.com/repos/oorestisime/grommet/subscription","commits_url":"https://api.github.com/repos/oorestisime/grommet/commits{/sha}","git_commits_url":"https://api.github.com/repos/oorestisime/grommet/git/commits{/sha}","comments_url":"https://api.github.com/repos/oorestisime/grommet/comments{/number}","issue_comment_url":"https://api.github.com/repos/oorestisime/grommet/issues/comments{/number}","contents_url":"https://api.github.com/repos/oorestisime/grommet/contents/{+path}","compare_url":"https://api.github.com/repos/oorestisime/grommet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oorestisime/grommet/merges","archive_url":"https://api.github.com/repos/oorestisime/grommet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oorestisime/grommet/downloads","issues_url":"https://api.github.com/repos/oorestisime/grommet/issues{/number}","pulls_url":"https://api.github.com/repos/oorestisime/grommet/pulls{/number}","milestones_url":"https://api.github.com/repos/oorestisime/grommet/milestones{/number}","notifications_url":"https://api.github.com/repos/oorestisime/grommet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oorestisime/grommet/labels{/name}","releases_url":"https://api.github.com/repos/oorestisime/grommet/releases{/id}","deployments_url":"https://api.github.com/repos/oorestisime/grommet/deployments","created_at":"2018-11-25T15:01:15Z","updated_at":"2018-12-04T22:32:08Z","pushed_at":"2018-12-04T23:32:09Z","git_url":"git://github.com/oorestisime/grommet.git","ssh_url":"git@github.com:oorestisime/grommet.git","clone_url":"https://github.com/oorestisime/grommet.git","svn_url":"https://github.com/oorestisime/grommet","homepage":"https://grommet.io","size":129447,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grommet:master","ref":"master","sha":"76cb3e605c0e733f916395639d22bbd3506d8f5d","user":{"login":"grommet","id":14203820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjAzODIw","avatar_url":"https://avatars3.githubusercontent.com/u/14203820?v=4","gravatar_id":"","url":"https://api.github.com/users/grommet","html_url":"https://github.com/grommet","followers_url":"https://api.github.com/users/grommet/followers","following_url":"https://api.github.com/users/grommet/following{/other_user}","gists_url":"https://api.github.com/users/grommet/gists{/gist_id}","starred_url":"https://api.github.com/users/grommet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grommet/subscriptions","organizations_url":"https://api.github.com/users/grommet/orgs","repos_url":"https://api.github.com/users/grommet/repos","events_url":"https://api.github.com/users/grommet/events{/privacy}","received_events_url":"https://api.github.com/users/grommet/received_events","type":"Organization","site_admin":false},"repo":{"id":32787174,"node_id":"MDEwOlJlcG9zaXRvcnkzMjc4NzE3NA==","name":"grommet","full_name":"grommet/grommet","private":false,"owner":{"login":"grommet","id":14203820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjAzODIw","avatar_url":"https://avatars3.githubusercontent.com/u/14203820?v=4","gravatar_id":"","url":"https://api.github.com/users/grommet","html_url":"https://github.com/grommet","followers_url":"https://api.github.com/users/grommet/followers","following_url":"https://api.github.com/users/grommet/following{/other_user}","gists_url":"https://api.github.com/users/grommet/gists{/gist_id}","starred_url":"https://api.github.com/users/grommet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grommet/subscriptions","organizations_url":"https://api.github.com/users/grommet/orgs","repos_url":"https://api.github.com/users/grommet/repos","events_url":"https://api.github.com/users/grommet/events{/privacy}","received_events_url":"https://api.github.com/users/grommet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grommet/grommet","description":"a react-based framework that provides accessibility, modularity, responsiveness, and theming in a tidy package","fork":false,"url":"https://api.github.com/repos/grommet/grommet","forks_url":"https://api.github.com/repos/grommet/grommet/forks","keys_url":"https://api.github.com/repos/grommet/grommet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grommet/grommet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grommet/grommet/teams","hooks_url":"https://api.github.com/repos/grommet/grommet/hooks","issue_events_url":"https://api.github.com/repos/grommet/grommet/issues/events{/number}","events_url":"https://api.github.com/repos/grommet/grommet/events","assignees_url":"https://api.github.com/repos/grommet/grommet/assignees{/user}","branches_url":"https://api.github.com/repos/grommet/grommet/branches{/branch}","tags_url":"https://api.github.com/repos/grommet/grommet/tags","blobs_url":"https://api.github.com/repos/grommet/grommet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grommet/grommet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grommet/grommet/git/refs{/sha}","trees_url":"https://api.github.com/repos/grommet/grommet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grommet/grommet/statuses/{sha}","languages_url":"https://api.github.com/repos/grommet/grommet/languages","stargazers_url":"https://api.github.com/repos/grommet/grommet/stargazers","contributors_url":"https://api.github.com/repos/grommet/grommet/contributors","subscribers_url":"https://api.github.com/repos/grommet/grommet/subscribers","subscription_url":"https://api.github.com/repos/grommet/grommet/subscription","commits_url":"https://api.github.com/repos/grommet/grommet/commits{/sha}","git_commits_url":"https://api.github.com/repos/grommet/grommet/git/commits{/sha}","comments_url":"https://api.github.com/repos/grommet/grommet/comments{/number}","issue_comment_url":"https://api.github.com/repos/grommet/grommet/issues/comments{/number}","contents_url":"https://api.github.com/repos/grommet/grommet/contents/{+path}","compare_url":"https://api.github.com/repos/grommet/grommet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grommet/grommet/merges","archive_url":"https://api.github.com/repos/grommet/grommet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grommet/grommet/downloads","issues_url":"https://api.github.com/repos/grommet/grommet/issues{/number}","pulls_url":"https://api.github.com/repos/grommet/grommet/pulls{/number}","milestones_url":"https://api.github.com/repos/grommet/grommet/milestones{/number}","notifications_url":"https://api.github.com/repos/grommet/grommet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grommet/grommet/labels{/name}","releases_url":"https://api.github.com/repos/grommet/grommet/releases{/id}","deployments_url":"https://api.github.com/repos/grommet/grommet/deployments","created_at":"2015-03-24T08:54:10Z","updated_at":"2018-12-05T00:34:21Z","pushed_at":"2018-12-05T00:26:50Z","git_url":"git://github.com/grommet/grommet.git","ssh_url":"git@github.com:grommet/grommet.git","clone_url":"https://github.com/grommet/grommet.git","svn_url":"https://github.com/grommet/grommet","homepage":"https://grommet.io","size":134261,"stargazers_count":3986,"watchers_count":3986,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":462,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":462,"open_issues":50,"watchers":3986,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grommet/grommet/pulls/2532"},"html":{"href":"https://github.com/grommet/grommet/pull/2532"},"issue":{"href":"https://api.github.com/repos/grommet/grommet/issues/2532"},"comments":{"href":"https://api.github.com/repos/grommet/grommet/issues/2532/comments"},"review_comments":{"href":"https://api.github.com/repos/grommet/grommet/pulls/2532/comments"},"review_comment":{"href":"https://api.github.com/repos/grommet/grommet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grommet/grommet/pulls/2532/commits"},"statuses":{"href":"https://api.github.com/repos/grommet/grommet/statuses/5f311922308b0958577de8b99bd050a86640efe3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alansouzati"}}