{"action":"created","issue":{"url":"https://api.github.com/repos/micnews/react-jw-player/issues/54","repository_url":"https://api.github.com/repos/micnews/react-jw-player","labels_url":"https://api.github.com/repos/micnews/react-jw-player/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/micnews/react-jw-player/issues/54/comments","events_url":"https://api.github.com/repos/micnews/react-jw-player/issues/54/events","html_url":"https://github.com/micnews/react-jw-player/issues/54","id":258321391,"node_id":"MDU6SXNzdWUyNTgzMjEzOTE=","number":54,"title":"Version 2 Proposal","user":{"login":"danmakenoise","id":12228305,"node_id":"MDQ6VXNlcjEyMjI4MzA1","avatar_url":"https://avatars1.githubusercontent.com/u/12228305?v=4","gravatar_id":"","url":"https://api.github.com/users/danmakenoise","html_url":"https://github.com/danmakenoise","followers_url":"https://api.github.com/users/danmakenoise/followers","following_url":"https://api.github.com/users/danmakenoise/following{/other_user}","gists_url":"https://api.github.com/users/danmakenoise/gists{/gist_id}","starred_url":"https://api.github.com/users/danmakenoise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmakenoise/subscriptions","organizations_url":"https://api.github.com/users/danmakenoise/orgs","repos_url":"https://api.github.com/users/danmakenoise/repos","events_url":"https://api.github.com/users/danmakenoise/events{/privacy}","received_events_url":"https://api.github.com/users/danmakenoise/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-09-17T18:10:16Z","updated_at":"2018-11-06T10:35:01Z","closed_at":null,"author_association":"COLLABORATOR","body":"Hey gang!\r\n\r\nWe are about to get started building version 2 of this and I wanted to get some discussion going about a few things:\r\n\r\n1. A personal goal of mine is to decouple this component from JW Player's API much as possible. One way we've coupled the component pretty tightly is by making a lot of defaults in the configuration options. I think in version 2, it will be better to not override any defaults from player scripts and just let users add in their out config vis `customProps`. This will prevent us from having to add in a new component property for every single config option, over time.\r\n\r\n1. I also want to break out a base component from a wrapper component. My thought is that the base component `ReactJWPlayerBase` would ONLY map props to JW Player Event hooks. This component will be a great option for anyone looking to really customize the component. The second component could be just `ReactJWPlayer`, and we would move all of the \"nice to have\" functionality, like `onFiftyPercent`, having preroll automatically generated, etc.\r\n\r\nThis set up would allow us to decouple the base component from JW Player as much as possible, and allow us to have the container component more or less completely decoupled.\r\n\r\nSo here is what I would like some feedback on, including some other utility things.\r\n\r\n1. Should we break out `ReactJWPlayer` and `ReactJWPlayerBase`. How do we feel about those titles? How do we feel about the separation of logic between them.\r\n1. I'm considering changing up the linter from `miclint` to using eslint with an `.eslintrc` file directly. This should make contributing a little easier for those that have IDE's set up to automatically read and lint based upon `.eslintrc`\r\n1. I would like to add Flow typing to the component.\r\n1. I'm considering switching the testing library to Jest, after finding some pretty great productivity enhancements in my personal time. I don't have an issue with keeping `tape` if people feel strongly one way or the other.\r\n1. Since this will be a major version, is there anything else we should change?"},"comment":{"url":"https://api.github.com/repos/micnews/react-jw-player/issues/comments/436206980","html_url":"https://github.com/micnews/react-jw-player/issues/54#issuecomment-436206980","issue_url":"https://api.github.com/repos/micnews/react-jw-player/issues/54","id":436206980,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjIwNjk4MA==","user":{"login":"ellell","id":1212640,"node_id":"MDQ6VXNlcjEyMTI2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1212640?v=4","gravatar_id":"","url":"https://api.github.com/users/ellell","html_url":"https://github.com/ellell","followers_url":"https://api.github.com/users/ellell/followers","following_url":"https://api.github.com/users/ellell/following{/other_user}","gists_url":"https://api.github.com/users/ellell/gists{/gist_id}","starred_url":"https://api.github.com/users/ellell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellell/subscriptions","organizations_url":"https://api.github.com/users/ellell/orgs","repos_url":"https://api.github.com/users/ellell/repos","events_url":"https://api.github.com/users/ellell/events{/privacy}","received_events_url":"https://api.github.com/users/ellell/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T10:35:01Z","updated_at":"2018-11-06T10:35:01Z","author_association":"MEMBER","body":"@danmakenoise Yea, I'm good with putting this on ice!"}}
{"actor":{"display_login":"ellell"}}