{"action":"created","issue":{"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/148","repository_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility","labels_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/148/comments","events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/148/events","html_url":"https://github.com/OutpostUniverse/OP2Utility/pull/148","id":351910691,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzY0OTkw","number":148,"title":"Add tests","user":{"login":"DanRStevens","id":16793474,"node_id":"MDQ6VXNlcjE2NzkzNDc0","avatar_url":"https://avatars2.githubusercontent.com/u/16793474?v=4","gravatar_id":"","url":"https://api.github.com/users/DanRStevens","html_url":"https://github.com/DanRStevens","followers_url":"https://api.github.com/users/DanRStevens/followers","following_url":"https://api.github.com/users/DanRStevens/following{/other_user}","gists_url":"https://api.github.com/users/DanRStevens/gists{/gist_id}","starred_url":"https://api.github.com/users/DanRStevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanRStevens/subscriptions","organizations_url":"https://api.github.com/users/DanRStevens/orgs","repos_url":"https://api.github.com/users/DanRStevens/repos","events_url":"https://api.github.com/users/DanRStevens/events{/privacy}","received_events_url":"https://api.github.com/users/DanRStevens/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-19T15:17:47Z","updated_at":"2018-08-19T20:25:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/148","html_url":"https://github.com/OutpostUniverse/OP2Utility/pull/148","diff_url":"https://github.com/OutpostUniverse/OP2Utility/pull/148.diff","patch_url":"https://github.com/OutpostUniverse/OP2Utility/pull/148.patch"},"body":"Add `makefile` support for compiling and running unit tests (`make check`).\r\n\r\nAdd example Google Test test cases for MemoryStreamReader. Currently there is some duplication, to provide examples of writing tests with and without fixtures. One block of code can be removed in a future edit.\r\n"},"comment":{"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/comments/414153421","html_url":"https://github.com/OutpostUniverse/OP2Utility/pull/148#issuecomment-414153421","issue_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/148","id":414153421,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDE1MzQyMQ==","user":{"login":"Brett208","id":15183337,"node_id":"MDQ6VXNlcjE1MTgzMzM3","avatar_url":"https://avatars3.githubusercontent.com/u/15183337?v=4","gravatar_id":"","url":"https://api.github.com/users/Brett208","html_url":"https://github.com/Brett208","followers_url":"https://api.github.com/users/Brett208/followers","following_url":"https://api.github.com/users/Brett208/following{/other_user}","gists_url":"https://api.github.com/users/Brett208/gists{/gist_id}","starred_url":"https://api.github.com/users/Brett208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brett208/subscriptions","organizations_url":"https://api.github.com/users/Brett208/orgs","repos_url":"https://api.github.com/users/Brett208/repos","events_url":"https://api.github.com/users/Brett208/events{/privacy}","received_events_url":"https://api.github.com/users/Brett208/received_events","type":"User","site_admin":false},"created_at":"2018-08-19T20:25:36Z","updated_at":"2018-08-19T20:25:36Z","author_association":"MEMBER","body":"@DanRStevens it looks like you are planning on using Google Test without including its sourcecode or some sort of .lib/.obj/.dll file. I just checked and Visual Studio offers built in support for adding a Google Test project to a solution. I have to download the module first though as I don't have it installed. I'll download it and try to add the tests you wrote and compile on MSVC without issues.\r\n\r\nYou will likely need to update the MemoryStreamReader examples to use the new Stream namespace and filenames.\r\n\r\n-Brett"}}
{"actor":{"display_login":"Brett208"}}