{"action":"created","comment":{"url":"https://api.github.com/repos/jadu/pulsar/pulls/comments/182699007","pull_request_review_id":113545357,"id":182699007,"diff_hunk":"@@ -127,7 +127,7 @@\n     <div class=\"modal__dialog\">\n         <div class=\"modal__content\">\n             <div class=\"modal__header\">\n-                <button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">&times;</button>\n+                <button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">×</button>\n                 <h4 class=\"modal__title\">Connect CXM User</h4>","path":"views/playground/admin-mappings/index.html.twig","position":6,"original_position":24,"commit_id":"bb9bdef34a7058142d789328a21a15a637507978","original_commit_id":"bb9bdef34a7058142d789328a21a15a637507978","user":{"login":"jamesjacobs","id":756393,"avatar_url":"https://avatars3.githubusercontent.com/u/756393?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesjacobs","html_url":"https://github.com/jamesjacobs","followers_url":"https://api.github.com/users/jamesjacobs/followers","following_url":"https://api.github.com/users/jamesjacobs/following{/other_user}","gists_url":"https://api.github.com/users/jamesjacobs/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesjacobs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesjacobs/subscriptions","organizations_url":"https://api.github.com/users/jamesjacobs/orgs","repos_url":"https://api.github.com/users/jamesjacobs/repos","events_url":"https://api.github.com/users/jamesjacobs/events{/privacy}","received_events_url":"https://api.github.com/users/jamesjacobs/received_events","type":"User","site_admin":false},"body":"Should be an `h1` now for consistency with the other examples.","created_at":"2018-04-19T10:16:31Z","updated_at":"2018-04-19T10:18:00Z","html_url":"https://github.com/jadu/pulsar/pull/802#discussion_r182699007","pull_request_url":"https://api.github.com/repos/jadu/pulsar/pulls/802","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jadu/pulsar/pulls/comments/182699007"},"html":{"href":"https://github.com/jadu/pulsar/pull/802#discussion_r182699007"},"pull_request":{"href":"https://api.github.com/repos/jadu/pulsar/pulls/802"}}},"pull_request":{"url":"https://api.github.com/repos/jadu/pulsar/pulls/802","id":181802235,"html_url":"https://github.com/jadu/pulsar/pull/802","diff_url":"https://github.com/jadu/pulsar/pull/802.diff","patch_url":"https://github.com/jadu/pulsar/pull/802.patch","issue_url":"https://api.github.com/repos/jadu/pulsar/issues/802","number":802,"state":"open","locked":false,"title":"Improve Modal Accessibility Structure","user":{"login":"nvasileiadis","id":1425876,"avatar_url":"https://avatars0.githubusercontent.com/u/1425876?v=4","gravatar_id":"","url":"https://api.github.com/users/nvasileiadis","html_url":"https://github.com/nvasileiadis","followers_url":"https://api.github.com/users/nvasileiadis/followers","following_url":"https://api.github.com/users/nvasileiadis/following{/other_user}","gists_url":"https://api.github.com/users/nvasileiadis/gists{/gist_id}","starred_url":"https://api.github.com/users/nvasileiadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvasileiadis/subscriptions","organizations_url":"https://api.github.com/users/nvasileiadis/orgs","repos_url":"https://api.github.com/users/nvasileiadis/repos","events_url":"https://api.github.com/users/nvasileiadis/events{/privacy}","received_events_url":"https://api.github.com/users/nvasileiadis/received_events","type":"User","site_admin":false},"body":"Changes based on this example:\r\n\r\n```\r\n<div class=\"modal\" role=\"dialog\" aria-labelledby=\"myModal-title\" aria-modal=\"true\" aria-describedby=\"myModal-description\" id=\"myModal\">\r\n    <div class=\"modal__dialog\">\r\n        <div class=\"modal__content\">\r\n            <div class=\"modal__header\">\r\n                <button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-label=\"Close dialog\">×</button>\r\n                <h1 id=\"myModal-title\" class=\"modal__title\">Site Navigation</h1>\r\n            </div>\r\n            <div class=\"modal__body\">\r\n                <p id=\"myModal-description\" class=\"hide\">SR description goes here</p>\r\n                .... additional modal mark up ......\r\n            </div>\r\n            <div class=\"modal__footer\">\r\n                <button type=\"button\" class=\"btn btn--primary\">Save Changes</button>\r\n                <button type=\"button\" class=\"btn btn--naked\" data-dismiss=\"modal\">Cancel</button>\r\n            </div>\r\n        </div>\r\n    </div>\r\n</div>\r\n```\r\n\r\nTested in:\r\n\r\n| OS | Browser | Software | Status |\r\n| --- | --- | --- | --- |\r\n| MacOS | Chrome | VoiceOver | <g-emoji class=\"g-emoji\" alias=\"white_check_mark\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/2705.png\">✅</g-emoji> |\r\n MacOS | Chrome | ChromeVox | <g-emoji class=\"g-emoji\" alias=\"white_check_mark\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/2705.png\">✅</g-emoji> |\r\n| Win10 | IE | JAWS | <g-emoji class=\"g-emoji\" alias=\"white_check_mark\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/2705.png\">✅</g-emoji> |\r\n| Win10 | IE | NDA | <g-emoji class=\"g-emoji\" alias=\"white_check_mark\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/2705.png\">✅</g-emoji> |","created_at":"2018-04-16T09:32:51Z","updated_at":"2018-04-19T10:18:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0a281eab582e8a3300a50b932acfd7cf582a99c","assignee":{"login":"nvasileiadis","id":1425876,"avatar_url":"https://avatars0.githubusercontent.com/u/1425876?v=4","gravatar_id":"","url":"https://api.github.com/users/nvasileiadis","html_url":"https://github.com/nvasileiadis","followers_url":"https://api.github.com/users/nvasileiadis/followers","following_url":"https://api.github.com/users/nvasileiadis/following{/other_user}","gists_url":"https://api.github.com/users/nvasileiadis/gists{/gist_id}","starred_url":"https://api.github.com/users/nvasileiadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvasileiadis/subscriptions","organizations_url":"https://api.github.com/users/nvasileiadis/orgs","repos_url":"https://api.github.com/users/nvasileiadis/repos","events_url":"https://api.github.com/users/nvasileiadis/events{/privacy}","received_events_url":"https://api.github.com/users/nvasileiadis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nvasileiadis","id":1425876,"avatar_url":"https://avatars0.githubusercontent.com/u/1425876?v=4","gravatar_id":"","url":"https://api.github.com/users/nvasileiadis","html_url":"https://github.com/nvasileiadis","followers_url":"https://api.github.com/users/nvasileiadis/followers","following_url":"https://api.github.com/users/nvasileiadis/following{/other_user}","gists_url":"https://api.github.com/users/nvasileiadis/gists{/gist_id}","starred_url":"https://api.github.com/users/nvasileiadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvasileiadis/subscriptions","organizations_url":"https://api.github.com/users/nvasileiadis/orgs","repos_url":"https://api.github.com/users/nvasileiadis/repos","events_url":"https://api.github.com/users/nvasileiadis/events{/privacy}","received_events_url":"https://api.github.com/users/nvasileiadis/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mikedevelops","id":9677023,"avatar_url":"https://avatars2.githubusercontent.com/u/9677023?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedevelops","html_url":"https://github.com/mikedevelops","followers_url":"https://api.github.com/users/mikedevelops/followers","following_url":"https://api.github.com/users/mikedevelops/following{/other_user}","gists_url":"https://api.github.com/users/mikedevelops/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedevelops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedevelops/subscriptions","organizations_url":"https://api.github.com/users/mikedevelops/orgs","repos_url":"https://api.github.com/users/mikedevelops/repos","events_url":"https://api.github.com/users/mikedevelops/events{/privacy}","received_events_url":"https://api.github.com/users/mikedevelops/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":771163932,"url":"https://api.github.com/repos/jadu/pulsar/labels/a11y","name":"a11y","color":"82ea38","default":false},{"id":659498737,"url":"https://api.github.com/repos/jadu/pulsar/labels/minor","name":"minor","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jadu/pulsar/pulls/802/commits","review_comments_url":"https://api.github.com/repos/jadu/pulsar/pulls/802/comments","review_comment_url":"https://api.github.com/repos/jadu/pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jadu/pulsar/issues/802/comments","statuses_url":"https://api.github.com/repos/jadu/pulsar/statuses/bb9bdef34a7058142d789328a21a15a637507978","head":{"label":"jadu:modal-accessibility","ref":"modal-accessibility","sha":"bb9bdef34a7058142d789328a21a15a637507978","user":{"login":"jadu","id":2369677,"avatar_url":"https://avatars2.githubusercontent.com/u/2369677?v=4","gravatar_id":"","url":"https://api.github.com/users/jadu","html_url":"https://github.com/jadu","followers_url":"https://api.github.com/users/jadu/followers","following_url":"https://api.github.com/users/jadu/following{/other_user}","gists_url":"https://api.github.com/users/jadu/gists{/gist_id}","starred_url":"https://api.github.com/users/jadu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadu/subscriptions","organizations_url":"https://api.github.com/users/jadu/orgs","repos_url":"https://api.github.com/users/jadu/repos","events_url":"https://api.github.com/users/jadu/events{/privacy}","received_events_url":"https://api.github.com/users/jadu/received_events","type":"Organization","site_admin":false},"repo":{"id":49197651,"name":"pulsar","full_name":"jadu/pulsar","owner":{"login":"jadu","id":2369677,"avatar_url":"https://avatars2.githubusercontent.com/u/2369677?v=4","gravatar_id":"","url":"https://api.github.com/users/jadu","html_url":"https://github.com/jadu","followers_url":"https://api.github.com/users/jadu/followers","following_url":"https://api.github.com/users/jadu/following{/other_user}","gists_url":"https://api.github.com/users/jadu/gists{/gist_id}","starred_url":"https://api.github.com/users/jadu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadu/subscriptions","organizations_url":"https://api.github.com/users/jadu/orgs","repos_url":"https://api.github.com/users/jadu/repos","events_url":"https://api.github.com/users/jadu/events{/privacy}","received_events_url":"https://api.github.com/users/jadu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jadu/pulsar","description":"The User Experience and Interface framework for the Jadu Continuum Platform","fork":false,"url":"https://api.github.com/repos/jadu/pulsar","forks_url":"https://api.github.com/repos/jadu/pulsar/forks","keys_url":"https://api.github.com/repos/jadu/pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jadu/pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jadu/pulsar/teams","hooks_url":"https://api.github.com/repos/jadu/pulsar/hooks","issue_events_url":"https://api.github.com/repos/jadu/pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/jadu/pulsar/events","assignees_url":"https://api.github.com/repos/jadu/pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/jadu/pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/jadu/pulsar/tags","blobs_url":"https://api.github.com/repos/jadu/pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jadu/pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jadu/pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/jadu/pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jadu/pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/jadu/pulsar/languages","stargazers_url":"https://api.github.com/repos/jadu/pulsar/stargazers","contributors_url":"https://api.github.com/repos/jadu/pulsar/contributors","subscribers_url":"https://api.github.com/repos/jadu/pulsar/subscribers","subscription_url":"https://api.github.com/repos/jadu/pulsar/subscription","commits_url":"https://api.github.com/repos/jadu/pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/jadu/pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/jadu/pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/jadu/pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/jadu/pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/jadu/pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jadu/pulsar/merges","archive_url":"https://api.github.com/repos/jadu/pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jadu/pulsar/downloads","issues_url":"https://api.github.com/repos/jadu/pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/jadu/pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/jadu/pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/jadu/pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jadu/pulsar/labels{/name}","releases_url":"https://api.github.com/repos/jadu/pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/jadu/pulsar/deployments","created_at":"2016-01-07T10:20:34Z","updated_at":"2018-04-17T13:12:06Z","pushed_at":"2018-04-19T10:12:42Z","git_url":"git://github.com/jadu/pulsar.git","ssh_url":"git@github.com:jadu/pulsar.git","clone_url":"https://github.com/jadu/pulsar.git","svn_url":"https://github.com/jadu/pulsar","homepage":"https://jadu.github.io/pulsar/","size":163295,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":36,"watchers":17,"default_branch":"develop"}},"base":{"label":"jadu:develop","ref":"develop","sha":"fc7c86b283c37ef772a7a9b50f5d4c3d6ed7c99a","user":{"login":"jadu","id":2369677,"avatar_url":"https://avatars2.githubusercontent.com/u/2369677?v=4","gravatar_id":"","url":"https://api.github.com/users/jadu","html_url":"https://github.com/jadu","followers_url":"https://api.github.com/users/jadu/followers","following_url":"https://api.github.com/users/jadu/following{/other_user}","gists_url":"https://api.github.com/users/jadu/gists{/gist_id}","starred_url":"https://api.github.com/users/jadu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadu/subscriptions","organizations_url":"https://api.github.com/users/jadu/orgs","repos_url":"https://api.github.com/users/jadu/repos","events_url":"https://api.github.com/users/jadu/events{/privacy}","received_events_url":"https://api.github.com/users/jadu/received_events","type":"Organization","site_admin":false},"repo":{"id":49197651,"name":"pulsar","full_name":"jadu/pulsar","owner":{"login":"jadu","id":2369677,"avatar_url":"https://avatars2.githubusercontent.com/u/2369677?v=4","gravatar_id":"","url":"https://api.github.com/users/jadu","html_url":"https://github.com/jadu","followers_url":"https://api.github.com/users/jadu/followers","following_url":"https://api.github.com/users/jadu/following{/other_user}","gists_url":"https://api.github.com/users/jadu/gists{/gist_id}","starred_url":"https://api.github.com/users/jadu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadu/subscriptions","organizations_url":"https://api.github.com/users/jadu/orgs","repos_url":"https://api.github.com/users/jadu/repos","events_url":"https://api.github.com/users/jadu/events{/privacy}","received_events_url":"https://api.github.com/users/jadu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jadu/pulsar","description":"The User Experience and Interface framework for the Jadu Continuum Platform","fork":false,"url":"https://api.github.com/repos/jadu/pulsar","forks_url":"https://api.github.com/repos/jadu/pulsar/forks","keys_url":"https://api.github.com/repos/jadu/pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jadu/pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jadu/pulsar/teams","hooks_url":"https://api.github.com/repos/jadu/pulsar/hooks","issue_events_url":"https://api.github.com/repos/jadu/pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/jadu/pulsar/events","assignees_url":"https://api.github.com/repos/jadu/pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/jadu/pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/jadu/pulsar/tags","blobs_url":"https://api.github.com/repos/jadu/pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jadu/pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jadu/pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/jadu/pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jadu/pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/jadu/pulsar/languages","stargazers_url":"https://api.github.com/repos/jadu/pulsar/stargazers","contributors_url":"https://api.github.com/repos/jadu/pulsar/contributors","subscribers_url":"https://api.github.com/repos/jadu/pulsar/subscribers","subscription_url":"https://api.github.com/repos/jadu/pulsar/subscription","commits_url":"https://api.github.com/repos/jadu/pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/jadu/pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/jadu/pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/jadu/pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/jadu/pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/jadu/pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jadu/pulsar/merges","archive_url":"https://api.github.com/repos/jadu/pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jadu/pulsar/downloads","issues_url":"https://api.github.com/repos/jadu/pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/jadu/pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/jadu/pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/jadu/pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jadu/pulsar/labels{/name}","releases_url":"https://api.github.com/repos/jadu/pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/jadu/pulsar/deployments","created_at":"2016-01-07T10:20:34Z","updated_at":"2018-04-17T13:12:06Z","pushed_at":"2018-04-19T10:12:42Z","git_url":"git://github.com/jadu/pulsar.git","ssh_url":"git@github.com:jadu/pulsar.git","clone_url":"https://github.com/jadu/pulsar.git","svn_url":"https://github.com/jadu/pulsar","homepage":"https://jadu.github.io/pulsar/","size":163295,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":36,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jadu/pulsar/pulls/802"},"html":{"href":"https://github.com/jadu/pulsar/pull/802"},"issue":{"href":"https://api.github.com/repos/jadu/pulsar/issues/802"},"comments":{"href":"https://api.github.com/repos/jadu/pulsar/issues/802/comments"},"review_comments":{"href":"https://api.github.com/repos/jadu/pulsar/pulls/802/comments"},"review_comment":{"href":"https://api.github.com/repos/jadu/pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jadu/pulsar/pulls/802/commits"},"statuses":{"href":"https://api.github.com/repos/jadu/pulsar/statuses/bb9bdef34a7058142d789328a21a15a637507978"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jamesjacobs"}}