{"action":"created","issue":{"url":"https://api.github.com/repos/apache/trafodion/issues/1637","repository_url":"https://api.github.com/repos/apache/trafodion","labels_url":"https://api.github.com/repos/apache/trafodion/issues/1637/labels{/name}","comments_url":"https://api.github.com/repos/apache/trafodion/issues/1637/comments","events_url":"https://api.github.com/repos/apache/trafodion/issues/1637/events","html_url":"https://github.com/apache/trafodion/pull/1637","id":340021421,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTM0OTYy","number":1637,"title":"[TRAFODION-3131] Fix some reserved and non-reserved word issues","user":{"login":"DaveBirdsall","id":5659628,"node_id":"MDQ6VXNlcjU2NTk2Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5659628?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveBirdsall","html_url":"https://github.com/DaveBirdsall","followers_url":"https://api.github.com/users/DaveBirdsall/followers","following_url":"https://api.github.com/users/DaveBirdsall/following{/other_user}","gists_url":"https://api.github.com/users/DaveBirdsall/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveBirdsall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveBirdsall/subscriptions","organizations_url":"https://api.github.com/users/DaveBirdsall/orgs","repos_url":"https://api.github.com/users/DaveBirdsall/repos","events_url":"https://api.github.com/users/DaveBirdsall/events{/privacy}","received_events_url":"https://api.github.com/users/DaveBirdsall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-10T21:57:06Z","updated_at":"2018-07-11T00:38:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/trafodion/pulls/1637","html_url":"https://github.com/apache/trafodion/pull/1637","diff_url":"https://github.com/apache/trafodion/pull/1637.diff","patch_url":"https://github.com/apache/trafodion/pull/1637.patch"},"body":"This set of changes does the following:\r\n\r\n1. Fixes some issues with reserved words not being recognized as reserved words.\r\n2. Updates core/TEST037 to include test cases for some recently added functions (CRC32, MD5, SHA, SHA1 and SHA2)\r\n3. Updates the expected results for core/TEST037.\r\n\r\nNote: I'm aware that the comments in core/TEST037 are not perfectly aligned with the expected results. (But they are much more aligned than they were.) Will leave further improvements to follow-up work.\r\n\r\nNote: I considered refactoring common/ComResWords.cpp and the \"prettify SQL text\" functions in common/NAString.cpp, moving them to the parser and changing them to use the ParKeyWords table in parser/ParKeyWords.cpp. I wanted to do this to simplify development, consolidating three keyword tables into one. I started down this path and discovered that this was far from easy; moreover I concluded that it wouldn't actually simplify development much. So I fell back to the position of merely adding thorough documentation to parser/ParKeyWords.cpp, giving instructions on how to keep these tables in sync."},"comment":{"url":"https://api.github.com/repos/apache/trafodion/issues/comments/404008444","html_url":"https://github.com/apache/trafodion/pull/1637#issuecomment-404008444","issue_url":"https://api.github.com/repos/apache/trafodion/issues/1637","id":404008444,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDAwODQ0NA==","user":{"login":"Traf-Jenkins","id":12548626,"node_id":"MDQ6VXNlcjEyNTQ4NjI2","avatar_url":"https://avatars2.githubusercontent.com/u/12548626?v=4","gravatar_id":"","url":"https://api.github.com/users/Traf-Jenkins","html_url":"https://github.com/Traf-Jenkins","followers_url":"https://api.github.com/users/Traf-Jenkins/followers","following_url":"https://api.github.com/users/Traf-Jenkins/following{/other_user}","gists_url":"https://api.github.com/users/Traf-Jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/Traf-Jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Traf-Jenkins/subscriptions","organizations_url":"https://api.github.com/users/Traf-Jenkins/orgs","repos_url":"https://api.github.com/users/Traf-Jenkins/repos","events_url":"https://api.github.com/users/Traf-Jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/Traf-Jenkins/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T00:38:05Z","updated_at":"2018-07-11T00:38:05Z","author_association":"NONE","body":"Test Passed.  https://jenkins.esgyn.com/job/Check-PR-master/2807/\n"}}
{"actor":{"display_login":"Traf-Jenkins"}}