{"action":"created","comment":{"url":"https://api.github.com/repos/opendatakit/collect/pulls/comments/202785848","pull_request_review_id":137549887,"id":202785848,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjc4NTg0OA==","diff_hunk":"@@ -613,6 +613,6 @@\n     <string name=\"hide_old_form_versions_setting_title\">Hide old form versions</string>\n     <string name=\"hide_old_form_versions_setting_summary\">Only the newest version will appear in Fill Blank Form</string>\n     <string name=\"seconds\">Seconds</string>\n-    <string name=\"start_ranking\">Start ranking</string>\n+    <string name=\"sort_out_items\">Sort out items</string>","path":"collect_app/src/main/res/values/strings.xml","position":5,"original_position":5,"commit_id":"9f6cd900682152206d4187a62a6f043aec534d20","original_commit_id":"9f6cd900682152206d4187a62a6f043aec534d20","user":{"login":"lognaturel","id":967540,"node_id":"MDQ6VXNlcjk2NzU0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/967540?v=4","gravatar_id":"","url":"https://api.github.com/users/lognaturel","html_url":"https://github.com/lognaturel","followers_url":"https://api.github.com/users/lognaturel/followers","following_url":"https://api.github.com/users/lognaturel/following{/other_user}","gists_url":"https://api.github.com/users/lognaturel/gists{/gist_id}","starred_url":"https://api.github.com/users/lognaturel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lognaturel/subscriptions","organizations_url":"https://api.github.com/users/lognaturel/orgs","repos_url":"https://api.github.com/users/lognaturel/repos","events_url":"https://api.github.com/users/lognaturel/events{/privacy}","received_events_url":"https://api.github.com/users/lognaturel/received_events","type":"User","site_admin":false},"body":"This text doesn't make sense to me. @grzesiek2010 what did you not like about \"Start ranking\"? Perhaps \"Rank items\"? @yanokwa?","created_at":"2018-07-16T18:51:54Z","updated_at":"2018-07-16T18:51:54Z","html_url":"https://github.com/opendatakit/collect/pull/2363#discussion_r202785848","pull_request_url":"https://api.github.com/repos/opendatakit/collect/pulls/2363","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/comments/202785848"},"html":{"href":"https://github.com/opendatakit/collect/pull/2363#discussion_r202785848"},"pull_request":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/2363"}}},"pull_request":{"url":"https://api.github.com/repos/opendatakit/collect/pulls/2363","id":200648348,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjQ4MzQ4","html_url":"https://github.com/opendatakit/collect/pull/2363","diff_url":"https://github.com/opendatakit/collect/pull/2363.diff","patch_url":"https://github.com/opendatakit/collect/pull/2363.patch","issue_url":"https://api.github.com/repos/opendatakit/collect/issues/2363","number":2363,"state":"open","locked":false,"title":"RankWidget in a dialog","user":{"login":"grzesiek2010","id":3276264,"node_id":"MDQ6VXNlcjMyNzYyNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3276264?v=4","gravatar_id":"","url":"https://api.github.com/users/grzesiek2010","html_url":"https://github.com/grzesiek2010","followers_url":"https://api.github.com/users/grzesiek2010/followers","following_url":"https://api.github.com/users/grzesiek2010/following{/other_user}","gists_url":"https://api.github.com/users/grzesiek2010/gists{/gist_id}","starred_url":"https://api.github.com/users/grzesiek2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzesiek2010/subscriptions","organizations_url":"https://api.github.com/users/grzesiek2010/orgs","repos_url":"https://api.github.com/users/grzesiek2010/repos","events_url":"https://api.github.com/users/grzesiek2010/events{/privacy}","received_events_url":"https://api.github.com/users/grzesiek2010/received_events","type":"User","site_admin":false},"body":"#### What has been done to verify that this works as intended?\r\nI've tested this change using the attached form.\r\n\r\n#### Why is this the best possible solution? Were any other approaches considered?\r\nIt's an improvement required by users on the forum to make this widget consistent with others that have buttons like DateWidget.\r\n\r\n#### Are there any risks to merging this code? If so, what are they?\r\nCan't see any risk here.\r\n\r\n#### Do we need any specific form for testing your changes? If so, please attach one.\r\nI used:\r\n[rank.xml.txt](https://github.com/opendatakit/collect/files/2197575/rank.xml.txt)\r\n\r\n#### Does this change require updates to documentation? If so, please file an issue [here]( https://github.com/opendatakit/docs/issues/new) and include the link below.\r\nNo.\r\n\r\n#### Before submitting this PR, please make sure you have:\r\n- [x] run `./gradlew pmd checkstyle lintDebug spotbugsDebug` and confirmed all checks still pass.\r\n- [ ] verified that any new UI elements use theme colors. [UI Components Style guidelines](https://github.com/opendatakit/collect/blob/master/CONTRIBUTING.md#ui-components-style-guidelines)","created_at":"2018-07-11T10:03:44Z","updated_at":"2018-07-16T18:51:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90de7f31e7f2bd9e43b6eb5f552eea11e37598c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opendatakit/collect/pulls/2363/commits","review_comments_url":"https://api.github.com/repos/opendatakit/collect/pulls/2363/comments","review_comment_url":"https://api.github.com/repos/opendatakit/collect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opendatakit/collect/issues/2363/comments","statuses_url":"https://api.github.com/repos/opendatakit/collect/statuses/9f6cd900682152206d4187a62a6f043aec534d20","head":{"label":"grzesiek2010:rank_in_dialog","ref":"rank_in_dialog","sha":"9f6cd900682152206d4187a62a6f043aec534d20","user":{"login":"grzesiek2010","id":3276264,"node_id":"MDQ6VXNlcjMyNzYyNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3276264?v=4","gravatar_id":"","url":"https://api.github.com/users/grzesiek2010","html_url":"https://github.com/grzesiek2010","followers_url":"https://api.github.com/users/grzesiek2010/followers","following_url":"https://api.github.com/users/grzesiek2010/following{/other_user}","gists_url":"https://api.github.com/users/grzesiek2010/gists{/gist_id}","starred_url":"https://api.github.com/users/grzesiek2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzesiek2010/subscriptions","organizations_url":"https://api.github.com/users/grzesiek2010/orgs","repos_url":"https://api.github.com/users/grzesiek2010/repos","events_url":"https://api.github.com/users/grzesiek2010/events{/privacy}","received_events_url":"https://api.github.com/users/grzesiek2010/received_events","type":"User","site_admin":false},"repo":{"id":75389799,"node_id":"MDEwOlJlcG9zaXRvcnk3NTM4OTc5OQ==","name":"collect","full_name":"grzesiek2010/collect","owner":{"login":"grzesiek2010","id":3276264,"node_id":"MDQ6VXNlcjMyNzYyNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3276264?v=4","gravatar_id":"","url":"https://api.github.com/users/grzesiek2010","html_url":"https://github.com/grzesiek2010","followers_url":"https://api.github.com/users/grzesiek2010/followers","following_url":"https://api.github.com/users/grzesiek2010/following{/other_user}","gists_url":"https://api.github.com/users/grzesiek2010/gists{/gist_id}","starred_url":"https://api.github.com/users/grzesiek2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzesiek2010/subscriptions","organizations_url":"https://api.github.com/users/grzesiek2010/orgs","repos_url":"https://api.github.com/users/grzesiek2010/repos","events_url":"https://api.github.com/users/grzesiek2010/events{/privacy}","received_events_url":"https://api.github.com/users/grzesiek2010/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grzesiek2010/collect","description":"ODK Collect is an Android app for filling out forms. It's been used to collect millions of data points in challenging environments around the world. Contribute and make the world a better place! ✨🌍✨","fork":true,"url":"https://api.github.com/repos/grzesiek2010/collect","forks_url":"https://api.github.com/repos/grzesiek2010/collect/forks","keys_url":"https://api.github.com/repos/grzesiek2010/collect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grzesiek2010/collect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grzesiek2010/collect/teams","hooks_url":"https://api.github.com/repos/grzesiek2010/collect/hooks","issue_events_url":"https://api.github.com/repos/grzesiek2010/collect/issues/events{/number}","events_url":"https://api.github.com/repos/grzesiek2010/collect/events","assignees_url":"https://api.github.com/repos/grzesiek2010/collect/assignees{/user}","branches_url":"https://api.github.com/repos/grzesiek2010/collect/branches{/branch}","tags_url":"https://api.github.com/repos/grzesiek2010/collect/tags","blobs_url":"https://api.github.com/repos/grzesiek2010/collect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grzesiek2010/collect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grzesiek2010/collect/git/refs{/sha}","trees_url":"https://api.github.com/repos/grzesiek2010/collect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grzesiek2010/collect/statuses/{sha}","languages_url":"https://api.github.com/repos/grzesiek2010/collect/languages","stargazers_url":"https://api.github.com/repos/grzesiek2010/collect/stargazers","contributors_url":"https://api.github.com/repos/grzesiek2010/collect/contributors","subscribers_url":"https://api.github.com/repos/grzesiek2010/collect/subscribers","subscription_url":"https://api.github.com/repos/grzesiek2010/collect/subscription","commits_url":"https://api.github.com/repos/grzesiek2010/collect/commits{/sha}","git_commits_url":"https://api.github.com/repos/grzesiek2010/collect/git/commits{/sha}","comments_url":"https://api.github.com/repos/grzesiek2010/collect/comments{/number}","issue_comment_url":"https://api.github.com/repos/grzesiek2010/collect/issues/comments{/number}","contents_url":"https://api.github.com/repos/grzesiek2010/collect/contents/{+path}","compare_url":"https://api.github.com/repos/grzesiek2010/collect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grzesiek2010/collect/merges","archive_url":"https://api.github.com/repos/grzesiek2010/collect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grzesiek2010/collect/downloads","issues_url":"https://api.github.com/repos/grzesiek2010/collect/issues{/number}","pulls_url":"https://api.github.com/repos/grzesiek2010/collect/pulls{/number}","milestones_url":"https://api.github.com/repos/grzesiek2010/collect/milestones{/number}","notifications_url":"https://api.github.com/repos/grzesiek2010/collect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grzesiek2010/collect/labels{/name}","releases_url":"https://api.github.com/repos/grzesiek2010/collect/releases{/id}","deployments_url":"https://api.github.com/repos/grzesiek2010/collect/deployments","created_at":"2016-12-02T11:26:41Z","updated_at":"2018-05-24T19:10:02Z","pushed_at":"2018-07-16T12:46:16Z","git_url":"git://github.com/grzesiek2010/collect.git","ssh_url":"git@github.com:grzesiek2010/collect.git","clone_url":"https://github.com/grzesiek2010/collect.git","svn_url":"https://github.com/grzesiek2010/collect","homepage":"https://github.com/opendatakit/collect","size":42041,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opendatakit:master","ref":"master","sha":"0d1eff387d5828cfd7ec2a30d652813e306e182a","user":{"login":"opendatakit","id":6222985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjI5ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/6222985?v=4","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"repo":{"id":40213809,"node_id":"MDEwOlJlcG9zaXRvcnk0MDIxMzgwOQ==","name":"collect","full_name":"opendatakit/collect","owner":{"login":"opendatakit","id":6222985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjI5ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/6222985?v=4","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opendatakit/collect","description":"ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨","fork":false,"url":"https://api.github.com/repos/opendatakit/collect","forks_url":"https://api.github.com/repos/opendatakit/collect/forks","keys_url":"https://api.github.com/repos/opendatakit/collect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opendatakit/collect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opendatakit/collect/teams","hooks_url":"https://api.github.com/repos/opendatakit/collect/hooks","issue_events_url":"https://api.github.com/repos/opendatakit/collect/issues/events{/number}","events_url":"https://api.github.com/repos/opendatakit/collect/events","assignees_url":"https://api.github.com/repos/opendatakit/collect/assignees{/user}","branches_url":"https://api.github.com/repos/opendatakit/collect/branches{/branch}","tags_url":"https://api.github.com/repos/opendatakit/collect/tags","blobs_url":"https://api.github.com/repos/opendatakit/collect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opendatakit/collect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opendatakit/collect/git/refs{/sha}","trees_url":"https://api.github.com/repos/opendatakit/collect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opendatakit/collect/statuses/{sha}","languages_url":"https://api.github.com/repos/opendatakit/collect/languages","stargazers_url":"https://api.github.com/repos/opendatakit/collect/stargazers","contributors_url":"https://api.github.com/repos/opendatakit/collect/contributors","subscribers_url":"https://api.github.com/repos/opendatakit/collect/subscribers","subscription_url":"https://api.github.com/repos/opendatakit/collect/subscription","commits_url":"https://api.github.com/repos/opendatakit/collect/commits{/sha}","git_commits_url":"https://api.github.com/repos/opendatakit/collect/git/commits{/sha}","comments_url":"https://api.github.com/repos/opendatakit/collect/comments{/number}","issue_comment_url":"https://api.github.com/repos/opendatakit/collect/issues/comments{/number}","contents_url":"https://api.github.com/repos/opendatakit/collect/contents/{+path}","compare_url":"https://api.github.com/repos/opendatakit/collect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opendatakit/collect/merges","archive_url":"https://api.github.com/repos/opendatakit/collect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opendatakit/collect/downloads","issues_url":"https://api.github.com/repos/opendatakit/collect/issues{/number}","pulls_url":"https://api.github.com/repos/opendatakit/collect/pulls{/number}","milestones_url":"https://api.github.com/repos/opendatakit/collect/milestones{/number}","notifications_url":"https://api.github.com/repos/opendatakit/collect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opendatakit/collect/labels{/name}","releases_url":"https://api.github.com/repos/opendatakit/collect/releases{/id}","deployments_url":"https://api.github.com/repos/opendatakit/collect/deployments","created_at":"2015-08-04T23:21:33Z","updated_at":"2018-07-16T16:47:43Z","pushed_at":"2018-07-16T16:47:37Z","git_url":"git://github.com/opendatakit/collect.git","ssh_url":"git@github.com:opendatakit/collect.git","clone_url":"https://github.com/opendatakit/collect.git","svn_url":"https://github.com/opendatakit/collect","homepage":"https://docs.opendatakit.org/collect-intro","size":41086,"stargazers_count":307,"watchers_count":307,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":661,"mirror_url":null,"archived":false,"open_issues_count":205,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":661,"open_issues":205,"watchers":307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/2363"},"html":{"href":"https://github.com/opendatakit/collect/pull/2363"},"issue":{"href":"https://api.github.com/repos/opendatakit/collect/issues/2363"},"comments":{"href":"https://api.github.com/repos/opendatakit/collect/issues/2363/comments"},"review_comments":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/2363/comments"},"review_comment":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/2363/commits"},"statuses":{"href":"https://api.github.com/repos/opendatakit/collect/statuses/9f6cd900682152206d4187a62a6f043aec534d20"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lognaturel"}}