{"action":"created","comment":{"url":"https://api.github.com/repos/istio-releases/daily-release/pulls/comments/166128772","pull_request_review_id":94161782,"id":166128772,"diff_hunk":"@@ -63,5 +63,18 @@ cp -R ${DAILY_BUILD}/install/* install/\n ARTIFACTS_DIR=\"${GOPATH}/src/github.com/istio-releases/daily-release/_artifacts\"\n \n echo 'Running E2E Tests'\n-ARGS=\"--test_logs_path=\"${ARTIFACTS_DIR}\" --istioctl_url \"${ISTIOCTL_STAGE_URL}\" \"$@\"\"\n-make e2e_all E2E_ARGS=\"${ARGS}\"\n+ARGS=( --test_logs_path=\"${ARTIFACTS_DIR}\" --istioctl_url \"${ISTIOCTL_STAGE_URL}\" \"$@\" )\n+\n+EXTRA_E2E_ARGS=()\n+EXTRA_E2E_ARGS+=( --mixer_tag=\"${TAG}\" )\n+EXTRA_E2E_ARGS+=( --pilot_tag=\"${TAG}\" )\n+EXTRA_E2E_ARGS+=( --proxy_tag=\"${TAG}\")","path":"prow/daily-release-qualification.sh","position":11,"original_position":11,"commit_id":"d0e234c96969a9b8de2967d043da1f4dac471378","original_commit_id":"d0e234c96969a9b8de2967d043da1f4dac471378","user":{"login":"chxchx","id":11745975,"avatar_url":"https://avatars1.githubusercontent.com/u/11745975?v=4","gravatar_id":"","url":"https://api.github.com/users/chxchx","html_url":"https://github.com/chxchx","followers_url":"https://api.github.com/users/chxchx/followers","following_url":"https://api.github.com/users/chxchx/following{/other_user}","gists_url":"https://api.github.com/users/chxchx/gists{/gist_id}","starred_url":"https://api.github.com/users/chxchx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chxchx/subscriptions","organizations_url":"https://api.github.com/users/chxchx/orgs","repos_url":"https://api.github.com/users/chxchx/repos","events_url":"https://api.github.com/users/chxchx/events{/privacy}","received_events_url":"https://api.github.com/users/chxchx/received_events","type":"User","site_admin":false},"body":"nit: add a white space before closing parenthesis to be consistent in style","created_at":"2018-02-05T22:12:36Z","updated_at":"2018-02-05T22:12:36Z","html_url":"https://github.com/istio-releases/daily-release/pull/377#discussion_r166128772","pull_request_url":"https://api.github.com/repos/istio-releases/daily-release/pulls/377","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio-releases/daily-release/pulls/comments/166128772"},"html":{"href":"https://github.com/istio-releases/daily-release/pull/377#discussion_r166128772"},"pull_request":{"href":"https://api.github.com/repos/istio-releases/daily-release/pulls/377"}}},"pull_request":{"url":"https://api.github.com/repos/istio-releases/daily-release/pulls/377","id":167244571,"html_url":"https://github.com/istio-releases/daily-release/pull/377","diff_url":"https://github.com/istio-releases/daily-release/pull/377.diff","patch_url":"https://github.com/istio-releases/daily-release/pull/377.patch","issue_url":"https://api.github.com/repos/istio-releases/daily-release/issues/377","number":377,"state":"open","locked":false,"title":"Use go test directly with flags instead of make e2e","user":{"login":"yutongz","id":25786429,"avatar_url":"https://avatars2.githubusercontent.com/u/25786429?v=4","gravatar_id":"","url":"https://api.github.com/users/yutongz","html_url":"https://github.com/yutongz","followers_url":"https://api.github.com/users/yutongz/followers","following_url":"https://api.github.com/users/yutongz/following{/other_user}","gists_url":"https://api.github.com/users/yutongz/gists{/gist_id}","starred_url":"https://api.github.com/users/yutongz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yutongz/subscriptions","organizations_url":"https://api.github.com/users/yutongz/orgs","repos_url":"https://api.github.com/users/yutongz/repos","events_url":"https://api.github.com/users/yutongz/events{/privacy}","received_events_url":"https://api.github.com/users/yutongz/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-05T20:18:50Z","updated_at":"2018-02-05T22:12:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbb40873b3ba11ddf20e7b1b8b74f230b474d228","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio-releases/daily-release/pulls/377/commits","review_comments_url":"https://api.github.com/repos/istio-releases/daily-release/pulls/377/comments","review_comment_url":"https://api.github.com/repos/istio-releases/daily-release/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio-releases/daily-release/issues/377/comments","statuses_url":"https://api.github.com/repos/istio-releases/daily-release/statuses/d0e234c96969a9b8de2967d043da1f4dac471378","head":{"label":"istio-releases:yutongz-patch-1","ref":"yutongz-patch-1","sha":"d0e234c96969a9b8de2967d043da1f4dac471378","user":{"login":"istio-releases","id":29259397,"avatar_url":"https://avatars2.githubusercontent.com/u/29259397?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-releases","html_url":"https://github.com/istio-releases","followers_url":"https://api.github.com/users/istio-releases/followers","following_url":"https://api.github.com/users/istio-releases/following{/other_user}","gists_url":"https://api.github.com/users/istio-releases/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-releases/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-releases/subscriptions","organizations_url":"https://api.github.com/users/istio-releases/orgs","repos_url":"https://api.github.com/users/istio-releases/repos","events_url":"https://api.github.com/users/istio-releases/events{/privacy}","received_events_url":"https://api.github.com/users/istio-releases/received_events","type":"Organization","site_admin":false},"repo":{"id":110592722,"name":"daily-release","full_name":"istio-releases/daily-release","owner":{"login":"istio-releases","id":29259397,"avatar_url":"https://avatars2.githubusercontent.com/u/29259397?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-releases","html_url":"https://github.com/istio-releases","followers_url":"https://api.github.com/users/istio-releases/followers","following_url":"https://api.github.com/users/istio-releases/following{/other_user}","gists_url":"https://api.github.com/users/istio-releases/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-releases/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-releases/subscriptions","organizations_url":"https://api.github.com/users/istio-releases/orgs","repos_url":"https://api.github.com/users/istio-releases/repos","events_url":"https://api.github.com/users/istio-releases/events{/privacy}","received_events_url":"https://api.github.com/users/istio-releases/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio-releases/daily-release","description":null,"fork":false,"url":"https://api.github.com/repos/istio-releases/daily-release","forks_url":"https://api.github.com/repos/istio-releases/daily-release/forks","keys_url":"https://api.github.com/repos/istio-releases/daily-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio-releases/daily-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio-releases/daily-release/teams","hooks_url":"https://api.github.com/repos/istio-releases/daily-release/hooks","issue_events_url":"https://api.github.com/repos/istio-releases/daily-release/issues/events{/number}","events_url":"https://api.github.com/repos/istio-releases/daily-release/events","assignees_url":"https://api.github.com/repos/istio-releases/daily-release/assignees{/user}","branches_url":"https://api.github.com/repos/istio-releases/daily-release/branches{/branch}","tags_url":"https://api.github.com/repos/istio-releases/daily-release/tags","blobs_url":"https://api.github.com/repos/istio-releases/daily-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio-releases/daily-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio-releases/daily-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio-releases/daily-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio-releases/daily-release/statuses/{sha}","languages_url":"https://api.github.com/repos/istio-releases/daily-release/languages","stargazers_url":"https://api.github.com/repos/istio-releases/daily-release/stargazers","contributors_url":"https://api.github.com/repos/istio-releases/daily-release/contributors","subscribers_url":"https://api.github.com/repos/istio-releases/daily-release/subscribers","subscription_url":"https://api.github.com/repos/istio-releases/daily-release/subscription","commits_url":"https://api.github.com/repos/istio-releases/daily-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio-releases/daily-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio-releases/daily-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio-releases/daily-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio-releases/daily-release/contents/{+path}","compare_url":"https://api.github.com/repos/istio-releases/daily-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio-releases/daily-release/merges","archive_url":"https://api.github.com/repos/istio-releases/daily-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio-releases/daily-release/downloads","issues_url":"https://api.github.com/repos/istio-releases/daily-release/issues{/number}","pulls_url":"https://api.github.com/repos/istio-releases/daily-release/pulls{/number}","milestones_url":"https://api.github.com/repos/istio-releases/daily-release/milestones{/number}","notifications_url":"https://api.github.com/repos/istio-releases/daily-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio-releases/daily-release/labels{/name}","releases_url":"https://api.github.com/repos/istio-releases/daily-release/releases{/id}","deployments_url":"https://api.github.com/repos/istio-releases/daily-release/deployments","created_at":"2017-11-13T19:34:55Z","updated_at":"2017-11-14T01:50:14Z","pushed_at":"2018-02-05T22:04:45Z","git_url":"git://github.com/istio-releases/daily-release.git","ssh_url":"git@github.com:istio-releases/daily-release.git","clone_url":"https://github.com/istio-releases/daily-release.git","svn_url":"https://github.com/istio-releases/daily-release","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"istio-releases:master","ref":"master","sha":"651344a536d487090630133260705639b0012991","user":{"login":"istio-releases","id":29259397,"avatar_url":"https://avatars2.githubusercontent.com/u/29259397?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-releases","html_url":"https://github.com/istio-releases","followers_url":"https://api.github.com/users/istio-releases/followers","following_url":"https://api.github.com/users/istio-releases/following{/other_user}","gists_url":"https://api.github.com/users/istio-releases/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-releases/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-releases/subscriptions","organizations_url":"https://api.github.com/users/istio-releases/orgs","repos_url":"https://api.github.com/users/istio-releases/repos","events_url":"https://api.github.com/users/istio-releases/events{/privacy}","received_events_url":"https://api.github.com/users/istio-releases/received_events","type":"Organization","site_admin":false},"repo":{"id":110592722,"name":"daily-release","full_name":"istio-releases/daily-release","owner":{"login":"istio-releases","id":29259397,"avatar_url":"https://avatars2.githubusercontent.com/u/29259397?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-releases","html_url":"https://github.com/istio-releases","followers_url":"https://api.github.com/users/istio-releases/followers","following_url":"https://api.github.com/users/istio-releases/following{/other_user}","gists_url":"https://api.github.com/users/istio-releases/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-releases/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-releases/subscriptions","organizations_url":"https://api.github.com/users/istio-releases/orgs","repos_url":"https://api.github.com/users/istio-releases/repos","events_url":"https://api.github.com/users/istio-releases/events{/privacy}","received_events_url":"https://api.github.com/users/istio-releases/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio-releases/daily-release","description":null,"fork":false,"url":"https://api.github.com/repos/istio-releases/daily-release","forks_url":"https://api.github.com/repos/istio-releases/daily-release/forks","keys_url":"https://api.github.com/repos/istio-releases/daily-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio-releases/daily-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio-releases/daily-release/teams","hooks_url":"https://api.github.com/repos/istio-releases/daily-release/hooks","issue_events_url":"https://api.github.com/repos/istio-releases/daily-release/issues/events{/number}","events_url":"https://api.github.com/repos/istio-releases/daily-release/events","assignees_url":"https://api.github.com/repos/istio-releases/daily-release/assignees{/user}","branches_url":"https://api.github.com/repos/istio-releases/daily-release/branches{/branch}","tags_url":"https://api.github.com/repos/istio-releases/daily-release/tags","blobs_url":"https://api.github.com/repos/istio-releases/daily-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio-releases/daily-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio-releases/daily-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio-releases/daily-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio-releases/daily-release/statuses/{sha}","languages_url":"https://api.github.com/repos/istio-releases/daily-release/languages","stargazers_url":"https://api.github.com/repos/istio-releases/daily-release/stargazers","contributors_url":"https://api.github.com/repos/istio-releases/daily-release/contributors","subscribers_url":"https://api.github.com/repos/istio-releases/daily-release/subscribers","subscription_url":"https://api.github.com/repos/istio-releases/daily-release/subscription","commits_url":"https://api.github.com/repos/istio-releases/daily-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio-releases/daily-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio-releases/daily-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio-releases/daily-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio-releases/daily-release/contents/{+path}","compare_url":"https://api.github.com/repos/istio-releases/daily-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio-releases/daily-release/merges","archive_url":"https://api.github.com/repos/istio-releases/daily-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio-releases/daily-release/downloads","issues_url":"https://api.github.com/repos/istio-releases/daily-release/issues{/number}","pulls_url":"https://api.github.com/repos/istio-releases/daily-release/pulls{/number}","milestones_url":"https://api.github.com/repos/istio-releases/daily-release/milestones{/number}","notifications_url":"https://api.github.com/repos/istio-releases/daily-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio-releases/daily-release/labels{/name}","releases_url":"https://api.github.com/repos/istio-releases/daily-release/releases{/id}","deployments_url":"https://api.github.com/repos/istio-releases/daily-release/deployments","created_at":"2017-11-13T19:34:55Z","updated_at":"2017-11-14T01:50:14Z","pushed_at":"2018-02-05T22:04:45Z","git_url":"git://github.com/istio-releases/daily-release.git","ssh_url":"git@github.com:istio-releases/daily-release.git","clone_url":"https://github.com/istio-releases/daily-release.git","svn_url":"https://github.com/istio-releases/daily-release","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio-releases/daily-release/pulls/377"},"html":{"href":"https://github.com/istio-releases/daily-release/pull/377"},"issue":{"href":"https://api.github.com/repos/istio-releases/daily-release/issues/377"},"comments":{"href":"https://api.github.com/repos/istio-releases/daily-release/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/istio-releases/daily-release/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/istio-releases/daily-release/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio-releases/daily-release/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/istio-releases/daily-release/statuses/d0e234c96969a9b8de2967d043da1f4dac471378"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chxchx"}}