{"action":"created","comment":{"url":"https://api.github.com/repos/azkaban/azkaban/pulls/comments/176831352","pull_request_review_id":106609016,"id":176831352,"diff_hunk":"@@ -109,13 +109,13 @@\n     // Designates one of the external link topics to correspond to a job log viewer\n     public static final String AZKABAN_SERVER_EXTERNAL_LOGVIEWER_TOPIC = \"azkaban.server.external.logviewer.topic\";\n     public static final String AZKABAN_SERVER_EXTERNAL_LOGVIEWER_LABEL = \"azkaban.server.external.logviewer.label\";\n-    \n+\n     /*\n      * Hadoop/Spark user job link.\n      * Example:\n-     * a) azkaban.server.external.resource_manager_job_url=http://***rm***:8088/cluster/app/application_${application.id}\n-     * b) azkaban.server.external.history_server_job_url=http://***jh***:19888/jobhistory/job/job_${application.id}\n-     * c) azkaban.server.external.spark_history_server_job_url=http://***sh***:18080/history/application_${application.id}/1/jobs\n+     * a) azkaban.server.external.resource_manager_job_url=http://resource-manager-http-address:port/cluster/app/application_${application.id}\n+     * b) azkaban.server.external.history_server_job_url=http://history-server-http-address:port/jobhistory/job/job_${application.id}","path":"az-core/src/main/java/azkaban/Constants.java","position":13,"original_position":13,"commit_id":"f12b547bd5af55435dacbb7289d5bc8acba43f45","original_commit_id":"f12b547bd5af55435dacbb7289d5bc8acba43f45","user":{"login":"jamiesjc","id":23324945,"avatar_url":"https://avatars0.githubusercontent.com/u/23324945?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiesjc","html_url":"https://github.com/jamiesjc","followers_url":"https://api.github.com/users/jamiesjc/followers","following_url":"https://api.github.com/users/jamiesjc/following{/other_user}","gists_url":"https://api.github.com/users/jamiesjc/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiesjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiesjc/subscriptions","organizations_url":"https://api.github.com/users/jamiesjc/orgs","repos_url":"https://api.github.com/users/jamiesjc/repos","events_url":"https://api.github.com/users/jamiesjc/events{/privacy}","received_events_url":"https://api.github.com/users/jamiesjc/received_events","type":"User","site_admin":false},"body":"It is not guaranteed that the rest of the URL patterns will be the same for external users.","created_at":"2018-03-23T18:42:38Z","updated_at":"2018-03-23T18:42:38Z","html_url":"https://github.com/azkaban/azkaban/pull/1708#discussion_r176831352","pull_request_url":"https://api.github.com/repos/azkaban/azkaban/pulls/1708","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/comments/176831352"},"html":{"href":"https://github.com/azkaban/azkaban/pull/1708#discussion_r176831352"},"pull_request":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/1708"}},"in_reply_to_id":176827566},"pull_request":{"url":"https://api.github.com/repos/azkaban/azkaban/pulls/1708","id":177144969,"html_url":"https://github.com/azkaban/azkaban/pull/1708","diff_url":"https://github.com/azkaban/azkaban/pull/1708.diff","patch_url":"https://github.com/azkaban/azkaban/pull/1708.patch","issue_url":"https://api.github.com/repos/azkaban/azkaban/issues/1708","number":1708,"state":"open","locked":false,"title":"Edit the comments for job URL examples.","user":{"login":"jamiesjc","id":23324945,"avatar_url":"https://avatars0.githubusercontent.com/u/23324945?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiesjc","html_url":"https://github.com/jamiesjc","followers_url":"https://api.github.com/users/jamiesjc/followers","following_url":"https://api.github.com/users/jamiesjc/following{/other_user}","gists_url":"https://api.github.com/users/jamiesjc/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiesjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiesjc/subscriptions","organizations_url":"https://api.github.com/users/jamiesjc/orgs","repos_url":"https://api.github.com/users/jamiesjc/repos","events_url":"https://api.github.com/users/jamiesjc/events{/privacy}","received_events_url":"https://api.github.com/users/jamiesjc/received_events","type":"User","site_admin":false},"body":"Followed the example in below document to clarify the job URL examples in comments.\r\nhttps://hadoop.apache.org/docs/current/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/HistoryServerRest.html","created_at":"2018-03-23T18:01:18Z","updated_at":"2018-03-23T18:42:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0656d84c61bf5fe585fb584e01d68177b16eea11","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kunkun-tang","id":2895882,"avatar_url":"https://avatars3.githubusercontent.com/u/2895882?v=4","gravatar_id":"","url":"https://api.github.com/users/kunkun-tang","html_url":"https://github.com/kunkun-tang","followers_url":"https://api.github.com/users/kunkun-tang/followers","following_url":"https://api.github.com/users/kunkun-tang/following{/other_user}","gists_url":"https://api.github.com/users/kunkun-tang/gists{/gist_id}","starred_url":"https://api.github.com/users/kunkun-tang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunkun-tang/subscriptions","organizations_url":"https://api.github.com/users/kunkun-tang/orgs","repos_url":"https://api.github.com/users/kunkun-tang/repos","events_url":"https://api.github.com/users/kunkun-tang/events{/privacy}","received_events_url":"https://api.github.com/users/kunkun-tang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/azkaban/azkaban/pulls/1708/commits","review_comments_url":"https://api.github.com/repos/azkaban/azkaban/pulls/1708/comments","review_comment_url":"https://api.github.com/repos/azkaban/azkaban/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azkaban/azkaban/issues/1708/comments","statuses_url":"https://api.github.com/repos/azkaban/azkaban/statuses/f12b547bd5af55435dacbb7289d5bc8acba43f45","head":{"label":"jamiesjc:addressCommentsIn#1695","ref":"addressCommentsIn#1695","sha":"f12b547bd5af55435dacbb7289d5bc8acba43f45","user":{"login":"jamiesjc","id":23324945,"avatar_url":"https://avatars0.githubusercontent.com/u/23324945?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiesjc","html_url":"https://github.com/jamiesjc","followers_url":"https://api.github.com/users/jamiesjc/followers","following_url":"https://api.github.com/users/jamiesjc/following{/other_user}","gists_url":"https://api.github.com/users/jamiesjc/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiesjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiesjc/subscriptions","organizations_url":"https://api.github.com/users/jamiesjc/orgs","repos_url":"https://api.github.com/users/jamiesjc/repos","events_url":"https://api.github.com/users/jamiesjc/events{/privacy}","received_events_url":"https://api.github.com/users/jamiesjc/received_events","type":"User","site_admin":false},"repo":{"id":73132656,"name":"azkaban","full_name":"jamiesjc/azkaban","owner":{"login":"jamiesjc","id":23324945,"avatar_url":"https://avatars0.githubusercontent.com/u/23324945?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiesjc","html_url":"https://github.com/jamiesjc","followers_url":"https://api.github.com/users/jamiesjc/followers","following_url":"https://api.github.com/users/jamiesjc/following{/other_user}","gists_url":"https://api.github.com/users/jamiesjc/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiesjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiesjc/subscriptions","organizations_url":"https://api.github.com/users/jamiesjc/orgs","repos_url":"https://api.github.com/users/jamiesjc/repos","events_url":"https://api.github.com/users/jamiesjc/events{/privacy}","received_events_url":"https://api.github.com/users/jamiesjc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamiesjc/azkaban","description":"Azkaban workflow manager.","fork":true,"url":"https://api.github.com/repos/jamiesjc/azkaban","forks_url":"https://api.github.com/repos/jamiesjc/azkaban/forks","keys_url":"https://api.github.com/repos/jamiesjc/azkaban/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamiesjc/azkaban/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamiesjc/azkaban/teams","hooks_url":"https://api.github.com/repos/jamiesjc/azkaban/hooks","issue_events_url":"https://api.github.com/repos/jamiesjc/azkaban/issues/events{/number}","events_url":"https://api.github.com/repos/jamiesjc/azkaban/events","assignees_url":"https://api.github.com/repos/jamiesjc/azkaban/assignees{/user}","branches_url":"https://api.github.com/repos/jamiesjc/azkaban/branches{/branch}","tags_url":"https://api.github.com/repos/jamiesjc/azkaban/tags","blobs_url":"https://api.github.com/repos/jamiesjc/azkaban/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamiesjc/azkaban/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamiesjc/azkaban/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamiesjc/azkaban/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamiesjc/azkaban/statuses/{sha}","languages_url":"https://api.github.com/repos/jamiesjc/azkaban/languages","stargazers_url":"https://api.github.com/repos/jamiesjc/azkaban/stargazers","contributors_url":"https://api.github.com/repos/jamiesjc/azkaban/contributors","subscribers_url":"https://api.github.com/repos/jamiesjc/azkaban/subscribers","subscription_url":"https://api.github.com/repos/jamiesjc/azkaban/subscription","commits_url":"https://api.github.com/repos/jamiesjc/azkaban/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamiesjc/azkaban/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamiesjc/azkaban/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamiesjc/azkaban/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamiesjc/azkaban/contents/{+path}","compare_url":"https://api.github.com/repos/jamiesjc/azkaban/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamiesjc/azkaban/merges","archive_url":"https://api.github.com/repos/jamiesjc/azkaban/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamiesjc/azkaban/downloads","issues_url":"https://api.github.com/repos/jamiesjc/azkaban/issues{/number}","pulls_url":"https://api.github.com/repos/jamiesjc/azkaban/pulls{/number}","milestones_url":"https://api.github.com/repos/jamiesjc/azkaban/milestones{/number}","notifications_url":"https://api.github.com/repos/jamiesjc/azkaban/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamiesjc/azkaban/labels{/name}","releases_url":"https://api.github.com/repos/jamiesjc/azkaban/releases{/id}","deployments_url":"https://api.github.com/repos/jamiesjc/azkaban/deployments","created_at":"2016-11-08T00:13:14Z","updated_at":"2016-11-08T00:13:20Z","pushed_at":"2018-03-23T17:59:50Z","git_url":"git://github.com/jamiesjc/azkaban.git","ssh_url":"git@github.com:jamiesjc/azkaban.git","clone_url":"https://github.com/jamiesjc/azkaban.git","svn_url":"https://github.com/jamiesjc/azkaban","homepage":"https://azkaban.github.io","size":47606,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"azkaban:master","ref":"master","sha":"5e30b7ed0ede1006ba1c5595956d07ac25dcc189","user":{"login":"azkaban","id":213618,"avatar_url":"https://avatars0.githubusercontent.com/u/213618?v=4","gravatar_id":"","url":"https://api.github.com/users/azkaban","html_url":"https://github.com/azkaban","followers_url":"https://api.github.com/users/azkaban/followers","following_url":"https://api.github.com/users/azkaban/following{/other_user}","gists_url":"https://api.github.com/users/azkaban/gists{/gist_id}","starred_url":"https://api.github.com/users/azkaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azkaban/subscriptions","organizations_url":"https://api.github.com/users/azkaban/orgs","repos_url":"https://api.github.com/users/azkaban/repos","events_url":"https://api.github.com/users/azkaban/events{/privacy}","received_events_url":"https://api.github.com/users/azkaban/received_events","type":"Organization","site_admin":false},"repo":{"id":6271421,"name":"azkaban","full_name":"azkaban/azkaban","owner":{"login":"azkaban","id":213618,"avatar_url":"https://avatars0.githubusercontent.com/u/213618?v=4","gravatar_id":"","url":"https://api.github.com/users/azkaban","html_url":"https://github.com/azkaban","followers_url":"https://api.github.com/users/azkaban/followers","following_url":"https://api.github.com/users/azkaban/following{/other_user}","gists_url":"https://api.github.com/users/azkaban/gists{/gist_id}","starred_url":"https://api.github.com/users/azkaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azkaban/subscriptions","organizations_url":"https://api.github.com/users/azkaban/orgs","repos_url":"https://api.github.com/users/azkaban/repos","events_url":"https://api.github.com/users/azkaban/events{/privacy}","received_events_url":"https://api.github.com/users/azkaban/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azkaban/azkaban","description":"Azkaban workflow manager.","fork":false,"url":"https://api.github.com/repos/azkaban/azkaban","forks_url":"https://api.github.com/repos/azkaban/azkaban/forks","keys_url":"https://api.github.com/repos/azkaban/azkaban/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azkaban/azkaban/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azkaban/azkaban/teams","hooks_url":"https://api.github.com/repos/azkaban/azkaban/hooks","issue_events_url":"https://api.github.com/repos/azkaban/azkaban/issues/events{/number}","events_url":"https://api.github.com/repos/azkaban/azkaban/events","assignees_url":"https://api.github.com/repos/azkaban/azkaban/assignees{/user}","branches_url":"https://api.github.com/repos/azkaban/azkaban/branches{/branch}","tags_url":"https://api.github.com/repos/azkaban/azkaban/tags","blobs_url":"https://api.github.com/repos/azkaban/azkaban/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azkaban/azkaban/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azkaban/azkaban/git/refs{/sha}","trees_url":"https://api.github.com/repos/azkaban/azkaban/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azkaban/azkaban/statuses/{sha}","languages_url":"https://api.github.com/repos/azkaban/azkaban/languages","stargazers_url":"https://api.github.com/repos/azkaban/azkaban/stargazers","contributors_url":"https://api.github.com/repos/azkaban/azkaban/contributors","subscribers_url":"https://api.github.com/repos/azkaban/azkaban/subscribers","subscription_url":"https://api.github.com/repos/azkaban/azkaban/subscription","commits_url":"https://api.github.com/repos/azkaban/azkaban/commits{/sha}","git_commits_url":"https://api.github.com/repos/azkaban/azkaban/git/commits{/sha}","comments_url":"https://api.github.com/repos/azkaban/azkaban/comments{/number}","issue_comment_url":"https://api.github.com/repos/azkaban/azkaban/issues/comments{/number}","contents_url":"https://api.github.com/repos/azkaban/azkaban/contents/{+path}","compare_url":"https://api.github.com/repos/azkaban/azkaban/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azkaban/azkaban/merges","archive_url":"https://api.github.com/repos/azkaban/azkaban/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azkaban/azkaban/downloads","issues_url":"https://api.github.com/repos/azkaban/azkaban/issues{/number}","pulls_url":"https://api.github.com/repos/azkaban/azkaban/pulls{/number}","milestones_url":"https://api.github.com/repos/azkaban/azkaban/milestones{/number}","notifications_url":"https://api.github.com/repos/azkaban/azkaban/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azkaban/azkaban/labels{/name}","releases_url":"https://api.github.com/repos/azkaban/azkaban/releases{/id}","deployments_url":"https://api.github.com/repos/azkaban/azkaban/deployments","created_at":"2012-10-18T01:34:53Z","updated_at":"2018-03-23T00:24:59Z","pushed_at":"2018-03-23T18:01:19Z","git_url":"git://github.com/azkaban/azkaban.git","ssh_url":"git@github.com:azkaban/azkaban.git","clone_url":"https://github.com/azkaban/azkaban.git","svn_url":"https://github.com/azkaban/azkaban","homepage":"https://azkaban.github.io","size":47482,"stargazers_count":1667,"watchers_count":1667,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":802,"mirror_url":null,"archived":false,"open_issues_count":412,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":802,"open_issues":412,"watchers":1667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/1708"},"html":{"href":"https://github.com/azkaban/azkaban/pull/1708"},"issue":{"href":"https://api.github.com/repos/azkaban/azkaban/issues/1708"},"comments":{"href":"https://api.github.com/repos/azkaban/azkaban/issues/1708/comments"},"review_comments":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/1708/comments"},"review_comment":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/1708/commits"},"statuses":{"href":"https://api.github.com/repos/azkaban/azkaban/statuses/f12b547bd5af55435dacbb7289d5bc8acba43f45"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jamiesjc"}}