{"action":"created","issue":{"url":"https://api.github.com/repos/deliveroo/routemaster-client-ex/issues/71","repository_url":"https://api.github.com/repos/deliveroo/routemaster-client-ex","labels_url":"https://api.github.com/repos/deliveroo/routemaster-client-ex/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/deliveroo/routemaster-client-ex/issues/71/comments","events_url":"https://api.github.com/repos/deliveroo/routemaster-client-ex/issues/71/events","html_url":"https://github.com/deliveroo/routemaster-client-ex/pull/71","id":299955285,"number":71,"title":"The JSON parser should work reliably when the body was already parsed","user":{"login":"tompave-roo","id":17473426,"avatar_url":"https://avatars0.githubusercontent.com/u/17473426?v=4","gravatar_id":"","url":"https://api.github.com/users/tompave-roo","html_url":"https://github.com/tompave-roo","followers_url":"https://api.github.com/users/tompave-roo/followers","following_url":"https://api.github.com/users/tompave-roo/following{/other_user}","gists_url":"https://api.github.com/users/tompave-roo/gists{/gist_id}","starred_url":"https://api.github.com/users/tompave-roo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tompave-roo/subscriptions","organizations_url":"https://api.github.com/users/tompave-roo/orgs","repos_url":"https://api.github.com/users/tompave-roo/repos","events_url":"https://api.github.com/users/tompave-roo/events{/privacy}","received_events_url":"https://api.github.com/users/tompave-roo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-24T17:00:54Z","updated_at":"2018-02-24T17:01:19Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/deliveroo/routemaster-client-ex/pulls/71","html_url":"https://github.com/deliveroo/routemaster-client-ex/pull/71","diff_url":"https://github.com/deliveroo/routemaster-client-ex/pull/71.diff","patch_url":"https://github.com/deliveroo/routemaster-client-ex/pull/71.patch"},"body":"When used in phoenix, without some extra configuration, the default JSON parser will parse the body before the Drain's parser can run. This results in the event list containing simple maps rather than structs.\r\n\r\nThis PR updates the parser to work reliably both when the body needs to be parsed (e.g. a custom plug app or in phoenix apps that have already been re-configured), and when the body is already parsed (default phoenix behaviour).\r\n\r\nAlso, it removed the custom JSON decoder that uses Poison to automatically cast the JSON into structs. This is future proof since Poison is going to be replaced with Jason in a future Phoenix release, and Jason doesn't have that feature."},"comment":{"url":"https://api.github.com/repos/deliveroo/routemaster-client-ex/issues/comments/368242505","html_url":"https://github.com/deliveroo/routemaster-client-ex/pull/71#issuecomment-368242505","issue_url":"https://api.github.com/repos/deliveroo/routemaster-client-ex/issues/71","id":368242505,"user":{"login":"tompave-roo","id":17473426,"avatar_url":"https://avatars0.githubusercontent.com/u/17473426?v=4","gravatar_id":"","url":"https://api.github.com/users/tompave-roo","html_url":"https://github.com/tompave-roo","followers_url":"https://api.github.com/users/tompave-roo/followers","following_url":"https://api.github.com/users/tompave-roo/following{/other_user}","gists_url":"https://api.github.com/users/tompave-roo/gists{/gist_id}","starred_url":"https://api.github.com/users/tompave-roo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tompave-roo/subscriptions","organizations_url":"https://api.github.com/users/tompave-roo/orgs","repos_url":"https://api.github.com/users/tompave-roo/repos","events_url":"https://api.github.com/users/tompave-roo/events{/privacy}","received_events_url":"https://api.github.com/users/tompave-roo/received_events","type":"User","site_admin":false},"created_at":"2018-02-24T17:01:19Z","updated_at":"2018-02-24T17:01:19Z","author_association":"OWNER","body":"Fixes https://github.com/deliveroo/routemaster-client-ex/issues/68\r\n\r\nAnd replaces https://github.com/deliveroo/routemaster-client-ex/pull/70"}}
{"actor":{"display_login":"tompave-roo"}}