{"action":"created","comment":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments/189685658","pull_request_review_id":121913262,"id":189685658,"diff_hunk":"@@ -874,7 +874,10 @@ function placement.no_overlap(c, args)\n     local curlay = layout.get()\n     local areas = { screen.workarea }\n     for _, cl in pairs(cls) do\n-        if cl ~= c and cl.type ~= \"desktop\" and (cl.floating or curlay == layout.suit.floating) then\n+        if cl ~= c\n+           and cl.type ~= \"desktop\"\n+           and (cl.floating or curlay == layout.suit.floating)\n+           and not (cl.maximized or cl.fullscreen) then","path":"lib/awful/placement.lua","position":8,"original_position":8,"commit_id":"cbfe8274be63a7b5e8a0b1a60da6a333b1d8eac1","original_commit_id":"cbfe8274be63a7b5e8a0b1a60da6a333b1d8eac1","user":{"login":"ZipFile","id":3847904,"avatar_url":"https://avatars0.githubusercontent.com/u/3847904?v=4","gravatar_id":"","url":"https://api.github.com/users/ZipFile","html_url":"https://github.com/ZipFile","followers_url":"https://api.github.com/users/ZipFile/followers","following_url":"https://api.github.com/users/ZipFile/following{/other_user}","gists_url":"https://api.github.com/users/ZipFile/gists{/gist_id}","starred_url":"https://api.github.com/users/ZipFile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZipFile/subscriptions","organizations_url":"https://api.github.com/users/ZipFile/orgs","repos_url":"https://api.github.com/users/ZipFile/repos","events_url":"https://api.github.com/users/ZipFile/events{/privacy}","received_events_url":"https://api.github.com/users/ZipFile/received_events","type":"User","site_admin":false},"body":"Hm. Feels like this should be configurable then. From my experience, partially maximized clients rarely fill more than half of the screen, so there is plenty of free space to fit new clients to. What do you think?\r\n\r\nAlso, should I add `immobilized` property too or is it okay to just check `cl.immobilized_horizontal or cl.immobilized_vertical`?","created_at":"2018-05-21T19:12:00Z","updated_at":"2018-05-21T19:12:00Z","html_url":"https://github.com/awesomeWM/awesome/pull/2266#discussion_r189685658","pull_request_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/2266","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments/189685658"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/2266#discussion_r189685658"},"pull_request":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/2266"}},"in_reply_to_id":189507611},"pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/2266","id":189146940,"html_url":"https://github.com/awesomeWM/awesome/pull/2266","diff_url":"https://github.com/awesomeWM/awesome/pull/2266.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/2266.patch","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/2266","number":2266,"state":"open","locked":false,"title":"Improve no_overlap placement","user":{"login":"ZipFile","id":3847904,"avatar_url":"https://avatars0.githubusercontent.com/u/3847904?v=4","gravatar_id":"","url":"https://api.github.com/users/ZipFile","html_url":"https://github.com/ZipFile","followers_url":"https://api.github.com/users/ZipFile/followers","following_url":"https://api.github.com/users/ZipFile/following{/other_user}","gists_url":"https://api.github.com/users/ZipFile/gists{/gist_id}","starred_url":"https://api.github.com/users/ZipFile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZipFile/subscriptions","organizations_url":"https://api.github.com/users/ZipFile/orgs","repos_url":"https://api.github.com/users/ZipFile/repos","events_url":"https://api.github.com/users/ZipFile/events{/privacy}","received_events_url":"https://api.github.com/users/ZipFile/received_events","type":"User","site_admin":false},"body":"1) Improve placement heuristic by ignoring fullscreen/maximized clients. On tile layouts such clients are ignored, but not on the `awful.layout.suit.floating`.\r\n2) Fix  #2139. If there is no free space and client located on the same screen - keep position unchanged. In case of offscreen client - fall back to old logic (move top left).","created_at":"2018-05-18T22:17:03Z","updated_at":"2018-05-21T19:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fce9957151a4388413d26ce2d77f0d184c46a72d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/2266/commits","review_comments_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/2266/comments","review_comment_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/2266/comments","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/cbfe8274be63a7b5e8a0b1a60da6a333b1d8eac1","head":{"label":"ZipFile:fix-no_overlap","ref":"fix-no_overlap","sha":"cbfe8274be63a7b5e8a0b1a60da6a333b1d8eac1","user":{"login":"ZipFile","id":3847904,"avatar_url":"https://avatars0.githubusercontent.com/u/3847904?v=4","gravatar_id":"","url":"https://api.github.com/users/ZipFile","html_url":"https://github.com/ZipFile","followers_url":"https://api.github.com/users/ZipFile/followers","following_url":"https://api.github.com/users/ZipFile/following{/other_user}","gists_url":"https://api.github.com/users/ZipFile/gists{/gist_id}","starred_url":"https://api.github.com/users/ZipFile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZipFile/subscriptions","organizations_url":"https://api.github.com/users/ZipFile/orgs","repos_url":"https://api.github.com/users/ZipFile/repos","events_url":"https://api.github.com/users/ZipFile/events{/privacy}","received_events_url":"https://api.github.com/users/ZipFile/received_events","type":"User","site_admin":false},"repo":{"id":133719869,"name":"awesome","full_name":"ZipFile/awesome","owner":{"login":"ZipFile","id":3847904,"avatar_url":"https://avatars0.githubusercontent.com/u/3847904?v=4","gravatar_id":"","url":"https://api.github.com/users/ZipFile","html_url":"https://github.com/ZipFile","followers_url":"https://api.github.com/users/ZipFile/followers","following_url":"https://api.github.com/users/ZipFile/following{/other_user}","gists_url":"https://api.github.com/users/ZipFile/gists{/gist_id}","starred_url":"https://api.github.com/users/ZipFile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZipFile/subscriptions","organizations_url":"https://api.github.com/users/ZipFile/orgs","repos_url":"https://api.github.com/users/ZipFile/repos","events_url":"https://api.github.com/users/ZipFile/events{/privacy}","received_events_url":"https://api.github.com/users/ZipFile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZipFile/awesome","description":"awesome window manager","fork":true,"url":"https://api.github.com/repos/ZipFile/awesome","forks_url":"https://api.github.com/repos/ZipFile/awesome/forks","keys_url":"https://api.github.com/repos/ZipFile/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZipFile/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZipFile/awesome/teams","hooks_url":"https://api.github.com/repos/ZipFile/awesome/hooks","issue_events_url":"https://api.github.com/repos/ZipFile/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/ZipFile/awesome/events","assignees_url":"https://api.github.com/repos/ZipFile/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/ZipFile/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/ZipFile/awesome/tags","blobs_url":"https://api.github.com/repos/ZipFile/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZipFile/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZipFile/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZipFile/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZipFile/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/ZipFile/awesome/languages","stargazers_url":"https://api.github.com/repos/ZipFile/awesome/stargazers","contributors_url":"https://api.github.com/repos/ZipFile/awesome/contributors","subscribers_url":"https://api.github.com/repos/ZipFile/awesome/subscribers","subscription_url":"https://api.github.com/repos/ZipFile/awesome/subscription","commits_url":"https://api.github.com/repos/ZipFile/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZipFile/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZipFile/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZipFile/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZipFile/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/ZipFile/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZipFile/awesome/merges","archive_url":"https://api.github.com/repos/ZipFile/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZipFile/awesome/downloads","issues_url":"https://api.github.com/repos/ZipFile/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/ZipFile/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/ZipFile/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/ZipFile/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZipFile/awesome/labels{/name}","releases_url":"https://api.github.com/repos/ZipFile/awesome/releases{/id}","deployments_url":"https://api.github.com/repos/ZipFile/awesome/deployments","created_at":"2018-05-16T20:31:29Z","updated_at":"2018-05-16T20:31:33Z","pushed_at":"2018-05-20T15:50:28Z","git_url":"git://github.com/ZipFile/awesome.git","ssh_url":"git@github.com:ZipFile/awesome.git","clone_url":"https://github.com/ZipFile/awesome.git","svn_url":"https://github.com/ZipFile/awesome","homepage":"https://awesomewm.org/","size":12844,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awesomeWM:master","ref":"master","sha":"347238b57af6a39d5575cd00497ed7b9b032a853","user":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars3.githubusercontent.com/u/6843364?v=4","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"repo":{"id":17378009,"name":"awesome","full_name":"awesomeWM/awesome","owner":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars3.githubusercontent.com/u/6843364?v=4","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awesomeWM/awesome","description":"awesome window manager","fork":false,"url":"https://api.github.com/repos/awesomeWM/awesome","forks_url":"https://api.github.com/repos/awesomeWM/awesome/forks","keys_url":"https://api.github.com/repos/awesomeWM/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesomeWM/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesomeWM/awesome/teams","hooks_url":"https://api.github.com/repos/awesomeWM/awesome/hooks","issue_events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/awesomeWM/awesome/events","assignees_url":"https://api.github.com/repos/awesomeWM/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/awesomeWM/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/awesomeWM/awesome/tags","blobs_url":"https://api.github.com/repos/awesomeWM/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesomeWM/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesomeWM/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesomeWM/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/awesomeWM/awesome/languages","stargazers_url":"https://api.github.com/repos/awesomeWM/awesome/stargazers","contributors_url":"https://api.github.com/repos/awesomeWM/awesome/contributors","subscribers_url":"https://api.github.com/repos/awesomeWM/awesome/subscribers","subscription_url":"https://api.github.com/repos/awesomeWM/awesome/subscription","commits_url":"https://api.github.com/repos/awesomeWM/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesomeWM/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/awesomeWM/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/awesomeWM/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesomeWM/awesome/merges","archive_url":"https://api.github.com/repos/awesomeWM/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesomeWM/awesome/downloads","issues_url":"https://api.github.com/repos/awesomeWM/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/awesomeWM/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/awesomeWM/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/awesomeWM/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesomeWM/awesome/labels{/name}","releases_url":"https://api.github.com/repos/awesomeWM/awesome/releases{/id}","deployments_url":"https://api.github.com/repos/awesomeWM/awesome/deployments","created_at":"2014-03-03T19:56:16Z","updated_at":"2018-05-21T18:14:08Z","pushed_at":"2018-05-21T07:01:10Z","git_url":"git://github.com/awesomeWM/awesome.git","ssh_url":"git@github.com:awesomeWM/awesome.git","clone_url":"https://github.com/awesomeWM/awesome.git","svn_url":"https://github.com/awesomeWM/awesome","homepage":"https://awesomewm.org/","size":12845,"stargazers_count":1925,"watchers_count":1925,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":274,"mirror_url":null,"archived":false,"open_issues_count":238,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":274,"open_issues":238,"watchers":1925,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/2266"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/2266"},"issue":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/2266"},"comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/2266/comments"},"review_comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/2266/comments"},"review_comment":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/2266/commits"},"statuses":{"href":"https://api.github.com/repos/awesomeWM/awesome/statuses/cbfe8274be63a7b5e8a0b1a60da6a333b1d8eac1"}},"author_association":"NONE"}}
{"actor":{"display_login":"ZipFile"}}