{"action":"closed","issue":{"url":"https://api.github.com/repos/philnash/pwned/issues/7","repository_url":"https://api.github.com/repos/philnash/pwned","labels_url":"https://api.github.com/repos/philnash/pwned/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/philnash/pwned/issues/7/comments","events_url":"https://api.github.com/repos/philnash/pwned/issues/7/events","html_url":"https://github.com/philnash/pwned/issues/7","id":304851591,"number":7,"title":"ActiveRecord Validator may be confusing","user":{"login":"K1N5L4Y3R","id":2091837,"avatar_url":"https://avatars2.githubusercontent.com/u/2091837?v=4","gravatar_id":"","url":"https://api.github.com/users/K1N5L4Y3R","html_url":"https://github.com/K1N5L4Y3R","followers_url":"https://api.github.com/users/K1N5L4Y3R/followers","following_url":"https://api.github.com/users/K1N5L4Y3R/following{/other_user}","gists_url":"https://api.github.com/users/K1N5L4Y3R/gists{/gist_id}","starred_url":"https://api.github.com/users/K1N5L4Y3R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/K1N5L4Y3R/subscriptions","organizations_url":"https://api.github.com/users/K1N5L4Y3R/orgs","repos_url":"https://api.github.com/users/K1N5L4Y3R/repos","events_url":"https://api.github.com/users/K1N5L4Y3R/events{/privacy}","received_events_url":"https://api.github.com/users/K1N5L4Y3R/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-13T16:59:16Z","updated_at":"2018-03-15T22:22:00Z","closed_at":"2018-03-15T22:22:00Z","author_association":"NONE","body":"Note: I haven't actually played with the gem. I just checked the README.\r\n\r\nIn my personal opinion, the ActiveRecord Validator may be confusing as it is, because it implies that the attribute needs to be \"pwned\" (i.e. it needs to exist on the Pwned Passwords database because it was included in a breach). I think that the opposite is meant, but correct me if I'm wrong.\r\n\r\n```ruby\r\n# Current validator\r\nvalidates :password, pwned: true\r\n\r\n# Suggested validator\r\nvalidates :password, not_pwned: true\r\n```\r\n\r\nIf this is something that makes sense to you, let me know and I can probably take a look at it when I have some time and submit a PR."}}
{"actor":{"display_login":"philnash"}}