{"action":"closed","number":154,"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/pulls/154","id":202886603,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODg2NjAz","html_url":"https://github.com/alphagov/digitalmarketplace-search-api/pull/154","diff_url":"https://github.com/alphagov/digitalmarketplace-search-api/pull/154.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-search-api/pull/154.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/issues/154","number":154,"state":"closed","locked":false,"title":"Find elasticsearch URI in VCAP_SERVICES by tag","user":{"login":"lfdebrux","id":503614,"node_id":"MDQ6VXNlcjUwMzYxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/503614?v=4","gravatar_id":"","url":"https://api.github.com/users/lfdebrux","html_url":"https://github.com/lfdebrux","followers_url":"https://api.github.com/users/lfdebrux/followers","following_url":"https://api.github.com/users/lfdebrux/following{/other_user}","gists_url":"https://api.github.com/users/lfdebrux/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdebrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdebrux/subscriptions","organizations_url":"https://api.github.com/users/lfdebrux/orgs","repos_url":"https://api.github.com/users/lfdebrux/repos","events_url":"https://api.github.com/users/lfdebrux/events{/privacy}","received_events_url":"https://api.github.com/users/lfdebrux/received_events","type":"User","site_admin":false},"body":"[Ticket](https://trello.com/c/C0FISeKl)\r\n\r\nGOV.UK PaaS are planning to migrate from using Docker compose with elasticsearch. In preparation for this they changed the VCAP_SERVICE label from 'elasticsearch' to 'elasticsearch-compose' see (#153). In future, they will be changing the label back from 'elasticsearch-compose' to 'elasticsearch'.\r\n\r\nThis commit changes the way that we find the elasticsearch entry in VCAP_SERVICES to be robust to these changes; assuming that the service always contains the tag 'elasticsearch', `get_service_by_tag_from_vcap_services` should be able to find it.","created_at":"2018-07-20T15:41:51Z","updated_at":"2018-07-26T10:37:12Z","closed_at":"2018-07-26T10:37:12Z","merged_at":null,"merge_commit_sha":"87d5c7932c236c08bc443f624900f3a36b7b2908","assignee":null,"assignees":[],"requested_reviewers":[{"login":"risicle","id":807447,"node_id":"MDQ6VXNlcjgwNzQ0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},{"login":"benvand","id":3469840,"node_id":"MDQ6VXNlcjM0Njk4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3469840?v=4","gravatar_id":"","url":"https://api.github.com/users/benvand","html_url":"https://github.com/benvand","followers_url":"https://api.github.com/users/benvand/followers","following_url":"https://api.github.com/users/benvand/following{/other_user}","gists_url":"https://api.github.com/users/benvand/gists{/gist_id}","starred_url":"https://api.github.com/users/benvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvand/subscriptions","organizations_url":"https://api.github.com/users/benvand/orgs","repos_url":"https://api.github.com/users/benvand/repos","events_url":"https://api.github.com/users/benvand/events{/privacy}","received_events_url":"https://api.github.com/users/benvand/received_events","type":"User","site_admin":false},{"login":"Wynndow","id":13836290,"node_id":"MDQ6VXNlcjEzODM2Mjkw","avatar_url":"https://avatars1.githubusercontent.com/u/13836290?v=4","gravatar_id":"","url":"https://api.github.com/users/Wynndow","html_url":"https://github.com/Wynndow","followers_url":"https://api.github.com/users/Wynndow/followers","following_url":"https://api.github.com/users/Wynndow/following{/other_user}","gists_url":"https://api.github.com/users/Wynndow/gists{/gist_id}","starred_url":"https://api.github.com/users/Wynndow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wynndow/subscriptions","organizations_url":"https://api.github.com/users/Wynndow/orgs","repos_url":"https://api.github.com/users/Wynndow/repos","events_url":"https://api.github.com/users/Wynndow/events{/privacy}","received_events_url":"https://api.github.com/users/Wynndow/received_events","type":"User","site_admin":false},{"login":"louzoid-gds","id":31240444,"node_id":"MDQ6VXNlcjMxMjQwNDQ0","avatar_url":"https://avatars0.githubusercontent.com/u/31240444?v=4","gravatar_id":"","url":"https://api.github.com/users/louzoid-gds","html_url":"https://github.com/louzoid-gds","followers_url":"https://api.github.com/users/louzoid-gds/followers","following_url":"https://api.github.com/users/louzoid-gds/following{/other_user}","gists_url":"https://api.github.com/users/louzoid-gds/gists{/gist_id}","starred_url":"https://api.github.com/users/louzoid-gds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louzoid-gds/subscriptions","organizations_url":"https://api.github.com/users/louzoid-gds/orgs","repos_url":"https://api.github.com/users/louzoid-gds/repos","events_url":"https://api.github.com/users/louzoid-gds/events{/privacy}","received_events_url":"https://api.github.com/users/louzoid-gds/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/pulls/154/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/pulls/154/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/issues/154/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/statuses/311dc3ce4407a4f068549ad3334152d6486da034","head":{"label":"alphagov:ldeb-fix-search-api-elasticsearch-uri","ref":"ldeb-fix-search-api-elasticsearch-uri","sha":"311dc3ce4407a4f068549ad3334152d6486da034","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":30530410,"node_id":"MDEwOlJlcG9zaXRvcnkzMDUzMDQxMA==","name":"digitalmarketplace-search-api","full_name":"alphagov/digitalmarketplace-search-api","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-search-api","description":"API to handle interactions between the digitalmarketplace applications and search applications.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/deployments","created_at":"2015-02-09T10:24:46Z","updated_at":"2018-07-23T10:42:20Z","pushed_at":"2018-07-23T11:21:03Z","git_url":"git://github.com/alphagov/digitalmarketplace-search-api.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-search-api.git","clone_url":"https://github.com/alphagov/digitalmarketplace-search-api.git","svn_url":"https://github.com/alphagov/digitalmarketplace-search-api","homepage":null,"size":4444,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"0f1264a2921c7e402e3d6a7defaf4b5fa06a7bed","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":30530410,"node_id":"MDEwOlJlcG9zaXRvcnkzMDUzMDQxMA==","name":"digitalmarketplace-search-api","full_name":"alphagov/digitalmarketplace-search-api","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-search-api","description":"API to handle interactions between the digitalmarketplace applications and search applications.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/deployments","created_at":"2015-02-09T10:24:46Z","updated_at":"2018-07-23T10:42:20Z","pushed_at":"2018-07-23T11:21:03Z","git_url":"git://github.com/alphagov/digitalmarketplace-search-api.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-search-api.git","clone_url":"https://github.com/alphagov/digitalmarketplace-search-api.git","svn_url":"https://github.com/alphagov/digitalmarketplace-search-api","homepage":null,"size":4444,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":0,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/pulls/154"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-search-api/pull/154"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/issues/154"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-search-api/statuses/311dc3ce4407a4f068549ad3334152d6486da034"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":67,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"lfdebrux"}}