{"action":"closed","number":83,"pull_request":{"url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/83","id":173548320,"html_url":"https://github.com/Expensify/Bedrock-PHP/pull/83","diff_url":"https://github.com/Expensify/Bedrock-PHP/pull/83.diff","patch_url":"https://github.com/Expensify/Bedrock-PHP/pull/83.patch","issue_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/83","number":83,"state":"closed","locked":false,"title":"Protect against sql injecting ourselves","user":{"login":"mattabullock","id":3344667,"avatar_url":"https://avatars0.githubusercontent.com/u/3344667?v=4","gravatar_id":"","url":"https://api.github.com/users/mattabullock","html_url":"https://github.com/mattabullock","followers_url":"https://api.github.com/users/mattabullock/followers","following_url":"https://api.github.com/users/mattabullock/following{/other_user}","gists_url":"https://api.github.com/users/mattabullock/gists{/gist_id}","starred_url":"https://api.github.com/users/mattabullock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattabullock/subscriptions","organizations_url":"https://api.github.com/users/mattabullock/orgs","repos_url":"https://api.github.com/users/mattabullock/repos","events_url":"https://api.github.com/users/mattabullock/events{/privacy}","received_events_url":"https://api.github.com/users/mattabullock/received_events","type":"User","site_admin":false},"body":"Emails have special characters in them, and it was allowing us to sql inject ourselves in the BWM db.\r\n\r\nRelated to: https://github.com/Expensify/Expensify/issues/66022\r\n\r\nHOLD for updating version\r\n\r\n# Tests\r\n1. Queue job with special characters in the params (i.e. `www-prod/TestJob?asdf=''''`)\r\n2. Run BWM\r\n3. Confirm that it doesn't crash and is inserted into the db effectively.\r\n```\r\n3|66|www-prod/TestJob?asdf=''''f'|1520450955.5|1520450955.62\r\n```","created_at":"2018-03-07T19:19:46Z","updated_at":"2018-03-08T13:45:48Z","closed_at":"2018-03-08T13:45:48Z","merged_at":"2018-03-08T13:45:48Z","merge_commit_sha":"c66bc94791b83a34612415443a7068d1b153b6f8","assignee":{"login":"mattabullock","id":3344667,"avatar_url":"https://avatars0.githubusercontent.com/u/3344667?v=4","gravatar_id":"","url":"https://api.github.com/users/mattabullock","html_url":"https://github.com/mattabullock","followers_url":"https://api.github.com/users/mattabullock/followers","following_url":"https://api.github.com/users/mattabullock/following{/other_user}","gists_url":"https://api.github.com/users/mattabullock/gists{/gist_id}","starred_url":"https://api.github.com/users/mattabullock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattabullock/subscriptions","organizations_url":"https://api.github.com/users/mattabullock/orgs","repos_url":"https://api.github.com/users/mattabullock/repos","events_url":"https://api.github.com/users/mattabullock/events{/privacy}","received_events_url":"https://api.github.com/users/mattabullock/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattabullock","id":3344667,"avatar_url":"https://avatars0.githubusercontent.com/u/3344667?v=4","gravatar_id":"","url":"https://api.github.com/users/mattabullock","html_url":"https://github.com/mattabullock","followers_url":"https://api.github.com/users/mattabullock/followers","following_url":"https://api.github.com/users/mattabullock/following{/other_user}","gists_url":"https://api.github.com/users/mattabullock/gists{/gist_id}","starred_url":"https://api.github.com/users/mattabullock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattabullock/subscriptions","organizations_url":"https://api.github.com/users/mattabullock/orgs","repos_url":"https://api.github.com/users/mattabullock/repos","events_url":"https://api.github.com/users/mattabullock/events{/privacy}","received_events_url":"https://api.github.com/users/mattabullock/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/83/commits","review_comments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/83/comments","review_comment_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/83/comments","statuses_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/statuses/c68b538077dd27749976f3f0cfc0a0d2723f423e","head":{"label":"Expensify:mb-sql-injection","ref":"mb-sql-injection","sha":"c68b538077dd27749976f3f0cfc0a0d2723f423e","user":{"login":"Expensify","id":476779,"avatar_url":"https://avatars0.githubusercontent.com/u/476779?v=4","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"repo":{"id":68838259,"name":"Bedrock-PHP","full_name":"Expensify/Bedrock-PHP","owner":{"login":"Expensify","id":476779,"avatar_url":"https://avatars0.githubusercontent.com/u/476779?v=4","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Expensify/Bedrock-PHP","description":null,"fork":false,"url":"https://api.github.com/repos/Expensify/Bedrock-PHP","forks_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/forks","keys_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/teams","hooks_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/hooks","issue_events_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/events{/number}","events_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/events","assignees_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/assignees{/user}","branches_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/branches{/branch}","tags_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/tags","blobs_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/statuses/{sha}","languages_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/languages","stargazers_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/stargazers","contributors_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/contributors","subscribers_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/subscribers","subscription_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/subscription","commits_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/contents/{+path}","compare_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/merges","archive_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/downloads","issues_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues{/number}","pulls_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls{/number}","milestones_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/milestones{/number}","notifications_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/labels{/name}","releases_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/releases{/id}","deployments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/deployments","created_at":"2016-09-21T16:52:46Z","updated_at":"2018-02-13T11:27:05Z","pushed_at":"2018-03-08T13:45:48Z","git_url":"git://github.com/Expensify/Bedrock-PHP.git","ssh_url":"git@github.com:Expensify/Bedrock-PHP.git","clone_url":"https://github.com/Expensify/Bedrock-PHP.git","svn_url":"https://github.com/Expensify/Bedrock-PHP","homepage":null,"size":297,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":2,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"Expensify:master","ref":"master","sha":"ae5d9688496c46a406e353d989822c6ee68bdeef","user":{"login":"Expensify","id":476779,"avatar_url":"https://avatars0.githubusercontent.com/u/476779?v=4","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"repo":{"id":68838259,"name":"Bedrock-PHP","full_name":"Expensify/Bedrock-PHP","owner":{"login":"Expensify","id":476779,"avatar_url":"https://avatars0.githubusercontent.com/u/476779?v=4","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Expensify/Bedrock-PHP","description":null,"fork":false,"url":"https://api.github.com/repos/Expensify/Bedrock-PHP","forks_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/forks","keys_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/teams","hooks_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/hooks","issue_events_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/events{/number}","events_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/events","assignees_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/assignees{/user}","branches_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/branches{/branch}","tags_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/tags","blobs_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/statuses/{sha}","languages_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/languages","stargazers_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/stargazers","contributors_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/contributors","subscribers_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/subscribers","subscription_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/subscription","commits_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/contents/{+path}","compare_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/merges","archive_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/downloads","issues_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues{/number}","pulls_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls{/number}","milestones_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/milestones{/number}","notifications_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/labels{/name}","releases_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/releases{/id}","deployments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/deployments","created_at":"2016-09-21T16:52:46Z","updated_at":"2018-02-13T11:27:05Z","pushed_at":"2018-03-08T13:45:48Z","git_url":"git://github.com/Expensify/Bedrock-PHP.git","ssh_url":"git@github.com:Expensify/Bedrock-PHP.git","clone_url":"https://github.com/Expensify/Bedrock-PHP.git","svn_url":"https://github.com/Expensify/Bedrock-PHP","homepage":null,"size":297,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":2,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/83"},"html":{"href":"https://github.com/Expensify/Bedrock-PHP/pull/83"},"issue":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/83"},"comments":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/statuses/c68b538077dd27749976f3f0cfc0a0d2723f423e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"iwiznia","id":521248,"avatar_url":"https://avatars1.githubusercontent.com/u/521248?v=4","gravatar_id":"","url":"https://api.github.com/users/iwiznia","html_url":"https://github.com/iwiznia","followers_url":"https://api.github.com/users/iwiznia/followers","following_url":"https://api.github.com/users/iwiznia/following{/other_user}","gists_url":"https://api.github.com/users/iwiznia/gists{/gist_id}","starred_url":"https://api.github.com/users/iwiznia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwiznia/subscriptions","organizations_url":"https://api.github.com/users/iwiznia/orgs","repos_url":"https://api.github.com/users/iwiznia/repos","events_url":"https://api.github.com/users/iwiznia/events{/privacy}","received_events_url":"https://api.github.com/users/iwiznia/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":5,"additions":5,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"iwiznia"}}