{"action":"created","comment":{"url":"https://api.github.com/repos/mui-org/material-ui/pulls/comments/244578066","pull_request_review_id":188488468,"id":244578066,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU3ODA2Ng==","diff_hunk":"@@ -43,6 +43,7 @@ export const styles = theme => ({\n     width: '100%',\n     animation: 'buffer 3s infinite linear',\n     animationName: '$buffer',\n+    willChange: 'opacity, background-position',","path":"packages/material-ui/src/LinearProgress/LinearProgress.js","position":4,"original_position":4,"commit_id":"06a02d3ada20f82eac2814ac8412d56bfc71fb06","original_commit_id":"06a02d3ada20f82eac2814ac8412d56bfc71fb06","user":{"login":"Pajn","id":817422,"node_id":"MDQ6VXNlcjgxNzQyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/817422?v=4","gravatar_id":"","url":"https://api.github.com/users/Pajn","html_url":"https://github.com/Pajn","followers_url":"https://api.github.com/users/Pajn/followers","following_url":"https://api.github.com/users/Pajn/following{/other_user}","gists_url":"https://api.github.com/users/Pajn/gists{/gist_id}","starred_url":"https://api.github.com/users/Pajn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pajn/subscriptions","organizations_url":"https://api.github.com/users/Pajn/orgs","repos_url":"https://api.github.com/users/Pajn/repos","events_url":"https://api.github.com/users/Pajn/events{/privacy}","received_events_url":"https://api.github.com/users/Pajn/received_events","type":"User","site_admin":false},"body":"Running animations are promoted to a layer automatically and thus does not need will-change. Will-change is, as it's name implies for things that are not currently changing but is about to so that the animation doesn't have to start with a costly layer promotion.","created_at":"2018-12-31T11:50:01Z","updated_at":"2018-12-31T11:50:01Z","html_url":"https://github.com/mui-org/material-ui/pull/14036#discussion_r244578066","pull_request_url":"https://api.github.com/repos/mui-org/material-ui/pulls/14036","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/comments/244578066"},"html":{"href":"https://github.com/mui-org/material-ui/pull/14036#discussion_r244578066"},"pull_request":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/14036"}},"in_reply_to_id":244543839},"pull_request":{"url":"https://api.github.com/repos/mui-org/material-ui/pulls/14036","id":241493739,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDkzNzM5","html_url":"https://github.com/mui-org/material-ui/pull/14036","diff_url":"https://github.com/mui-org/material-ui/pull/14036.diff","patch_url":"https://github.com/mui-org/material-ui/pull/14036.patch","issue_url":"https://api.github.com/repos/mui-org/material-ui/issues/14036","number":14036,"state":"open","locked":false,"title":"[core] Remove opinionated will-change usage","user":{"login":"joshwooding","id":12938082,"node_id":"MDQ6VXNlcjEyOTM4MDgy","avatar_url":"https://avatars1.githubusercontent.com/u/12938082?v=4","gravatar_id":"","url":"https://api.github.com/users/joshwooding","html_url":"https://github.com/joshwooding","followers_url":"https://api.github.com/users/joshwooding/followers","following_url":"https://api.github.com/users/joshwooding/following{/other_user}","gists_url":"https://api.github.com/users/joshwooding/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwooding/subscriptions","organizations_url":"https://api.github.com/users/joshwooding/orgs","repos_url":"https://api.github.com/users/joshwooding/repos","events_url":"https://api.github.com/users/joshwooding/events{/privacy}","received_events_url":"https://api.github.com/users/joshwooding/received_events","type":"User","site_admin":false},"body":"<!-- Thanks so much for your PR, your contribution is appreciated! ❤️ -->\r\n\r\n- [x] I have followed (at least) the [PR section of the contributing guide](https://github.com/mui-org/material-ui/blob/master/CONTRIBUTING.md#submitting-a-pull-request).\r\n\r\nCloses #10831\r\n\r\nAffects the following components:\r\n- Slider\r\n- ToggleButton \r\n- CircularProgress \r\n- Fade \r\n- LinearProgress\r\n- TabIndicator\r\n- Zoom \r\n\r\nI'm not sure what component prefix should be added to the title but, I didn't list all the components to improve the readability","created_at":"2018-12-30T14:27:39Z","updated_at":"2018-12-31T11:50:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8a5dc42dcffac8e7a0adfc8df48d59c14ee48f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":278518662,"node_id":"MDU6TGFiZWwyNzg1MTg2NjI=","url":"https://api.github.com/repos/mui-org/material-ui/labels/PR:%20good%20for%20merge","name":"PR: good for merge","color":"0e8a16","default":false},{"id":297148466,"node_id":"MDU6TGFiZWwyOTcxNDg0NjY=","url":"https://api.github.com/repos/mui-org/material-ui/labels/core","name":"core","color":"5c72c9","default":false},{"id":297114765,"node_id":"MDU6TGFiZWwyOTcxMTQ3NjU=","url":"https://api.github.com/repos/mui-org/material-ui/labels/performance","name":"performance","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mui-org/material-ui/pulls/14036/commits","review_comments_url":"https://api.github.com/repos/mui-org/material-ui/pulls/14036/comments","review_comment_url":"https://api.github.com/repos/mui-org/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mui-org/material-ui/issues/14036/comments","statuses_url":"https://api.github.com/repos/mui-org/material-ui/statuses/06a02d3ada20f82eac2814ac8412d56bfc71fb06","head":{"label":"joshwooding:will-change-change","ref":"will-change-change","sha":"06a02d3ada20f82eac2814ac8412d56bfc71fb06","user":{"login":"joshwooding","id":12938082,"node_id":"MDQ6VXNlcjEyOTM4MDgy","avatar_url":"https://avatars1.githubusercontent.com/u/12938082?v=4","gravatar_id":"","url":"https://api.github.com/users/joshwooding","html_url":"https://github.com/joshwooding","followers_url":"https://api.github.com/users/joshwooding/followers","following_url":"https://api.github.com/users/joshwooding/following{/other_user}","gists_url":"https://api.github.com/users/joshwooding/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwooding/subscriptions","organizations_url":"https://api.github.com/users/joshwooding/orgs","repos_url":"https://api.github.com/users/joshwooding/repos","events_url":"https://api.github.com/users/joshwooding/events{/privacy}","received_events_url":"https://api.github.com/users/joshwooding/received_events","type":"User","site_admin":false},"repo":{"id":155016676,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUwMTY2NzY=","name":"material-ui","full_name":"joshwooding/material-ui","private":false,"owner":{"login":"joshwooding","id":12938082,"node_id":"MDQ6VXNlcjEyOTM4MDgy","avatar_url":"https://avatars1.githubusercontent.com/u/12938082?v=4","gravatar_id":"","url":"https://api.github.com/users/joshwooding","html_url":"https://github.com/joshwooding","followers_url":"https://api.github.com/users/joshwooding/followers","following_url":"https://api.github.com/users/joshwooding/following{/other_user}","gists_url":"https://api.github.com/users/joshwooding/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwooding/subscriptions","organizations_url":"https://api.github.com/users/joshwooding/orgs","repos_url":"https://api.github.com/users/joshwooding/repos","events_url":"https://api.github.com/users/joshwooding/events{/privacy}","received_events_url":"https://api.github.com/users/joshwooding/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joshwooding/material-ui","description":"React components that implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/joshwooding/material-ui","forks_url":"https://api.github.com/repos/joshwooding/material-ui/forks","keys_url":"https://api.github.com/repos/joshwooding/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshwooding/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshwooding/material-ui/teams","hooks_url":"https://api.github.com/repos/joshwooding/material-ui/hooks","issue_events_url":"https://api.github.com/repos/joshwooding/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/joshwooding/material-ui/events","assignees_url":"https://api.github.com/repos/joshwooding/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/joshwooding/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/joshwooding/material-ui/tags","blobs_url":"https://api.github.com/repos/joshwooding/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshwooding/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshwooding/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshwooding/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshwooding/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/joshwooding/material-ui/languages","stargazers_url":"https://api.github.com/repos/joshwooding/material-ui/stargazers","contributors_url":"https://api.github.com/repos/joshwooding/material-ui/contributors","subscribers_url":"https://api.github.com/repos/joshwooding/material-ui/subscribers","subscription_url":"https://api.github.com/repos/joshwooding/material-ui/subscription","commits_url":"https://api.github.com/repos/joshwooding/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshwooding/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshwooding/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshwooding/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshwooding/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/joshwooding/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshwooding/material-ui/merges","archive_url":"https://api.github.com/repos/joshwooding/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshwooding/material-ui/downloads","issues_url":"https://api.github.com/repos/joshwooding/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/joshwooding/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/joshwooding/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/joshwooding/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshwooding/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/joshwooding/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/joshwooding/material-ui/deployments","created_at":"2018-10-27T22:51:00Z","updated_at":"2018-12-30T16:37:09Z","pushed_at":"2018-12-30T16:39:32Z","git_url":"git://github.com/joshwooding/material-ui.git","ssh_url":"git@github.com:joshwooding/material-ui.git","clone_url":"https://github.com/joshwooding/material-ui.git","svn_url":"https://github.com/joshwooding/material-ui","homepage":"https://material-ui.com/","size":54516,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mui-org:master","ref":"master","sha":"f946f19a5c8a6b38759e02bd86c9b77e89232caa","user":{"login":"mui-org","id":33663932,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjYzOTMy","avatar_url":"https://avatars2.githubusercontent.com/u/33663932?v=4","gravatar_id":"","url":"https://api.github.com/users/mui-org","html_url":"https://github.com/mui-org","followers_url":"https://api.github.com/users/mui-org/followers","following_url":"https://api.github.com/users/mui-org/following{/other_user}","gists_url":"https://api.github.com/users/mui-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mui-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mui-org/subscriptions","organizations_url":"https://api.github.com/users/mui-org/orgs","repos_url":"https://api.github.com/users/mui-org/repos","events_url":"https://api.github.com/users/mui-org/events{/privacy}","received_events_url":"https://api.github.com/users/mui-org/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA4MzE1Ng==","name":"material-ui","full_name":"mui-org/material-ui","private":false,"owner":{"login":"mui-org","id":33663932,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjYzOTMy","avatar_url":"https://avatars2.githubusercontent.com/u/33663932?v=4","gravatar_id":"","url":"https://api.github.com/users/mui-org","html_url":"https://github.com/mui-org","followers_url":"https://api.github.com/users/mui-org/followers","following_url":"https://api.github.com/users/mui-org/following{/other_user}","gists_url":"https://api.github.com/users/mui-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mui-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mui-org/subscriptions","organizations_url":"https://api.github.com/users/mui-org/orgs","repos_url":"https://api.github.com/users/mui-org/repos","events_url":"https://api.github.com/users/mui-org/events{/privacy}","received_events_url":"https://api.github.com/users/mui-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mui-org/material-ui","description":"React components that implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/mui-org/material-ui","forks_url":"https://api.github.com/repos/mui-org/material-ui/forks","keys_url":"https://api.github.com/repos/mui-org/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mui-org/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mui-org/material-ui/teams","hooks_url":"https://api.github.com/repos/mui-org/material-ui/hooks","issue_events_url":"https://api.github.com/repos/mui-org/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mui-org/material-ui/events","assignees_url":"https://api.github.com/repos/mui-org/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mui-org/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mui-org/material-ui/tags","blobs_url":"https://api.github.com/repos/mui-org/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mui-org/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mui-org/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mui-org/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mui-org/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mui-org/material-ui/languages","stargazers_url":"https://api.github.com/repos/mui-org/material-ui/stargazers","contributors_url":"https://api.github.com/repos/mui-org/material-ui/contributors","subscribers_url":"https://api.github.com/repos/mui-org/material-ui/subscribers","subscription_url":"https://api.github.com/repos/mui-org/material-ui/subscription","commits_url":"https://api.github.com/repos/mui-org/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mui-org/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mui-org/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mui-org/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mui-org/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mui-org/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mui-org/material-ui/merges","archive_url":"https://api.github.com/repos/mui-org/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mui-org/material-ui/downloads","issues_url":"https://api.github.com/repos/mui-org/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mui-org/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mui-org/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mui-org/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mui-org/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/mui-org/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/mui-org/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2018-12-31T10:06:28Z","pushed_at":"2018-12-31T10:39:46Z","git_url":"git://github.com/mui-org/material-ui.git","ssh_url":"git@github.com:mui-org/material-ui.git","clone_url":"https://github.com/mui-org/material-ui.git","svn_url":"https://github.com/mui-org/material-ui","homepage":"https://material-ui.com/","size":54646,"stargazers_count":43136,"watchers_count":43136,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8641,"mirror_url":null,"archived":false,"open_issues_count":279,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8641,"open_issues":279,"watchers":43136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/14036"},"html":{"href":"https://github.com/mui-org/material-ui/pull/14036"},"issue":{"href":"https://api.github.com/repos/mui-org/material-ui/issues/14036"},"comments":{"href":"https://api.github.com/repos/mui-org/material-ui/issues/14036/comments"},"review_comments":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/14036/comments"},"review_comment":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/14036/commits"},"statuses":{"href":"https://api.github.com/repos/mui-org/material-ui/statuses/06a02d3ada20f82eac2814ac8412d56bfc71fb06"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Pajn"}}