{"action":"created","comment":{"url":"https://api.github.com/repos/lanl/Draco/pulls/comments/223217177","pull_request_review_id":162293806,"id":223217177,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIxNzE3Nw==","diff_hunk":"@@ -9,11 +9,11 @@\n \n macro( set_ccs2_software_version PROJNAME )\n \n-  if( NOT ${${PROJNAME}_VERSION_MAJOR} )\n+  if( \"${${PROJNAME}_VERSION_MAJOR}x\" STREQUAL \"x\" )","path":"config/dracoVersion.cmake","position":null,"original_position":5,"commit_id":"fe31d3148fa2f5a8773cf1e64c843c0aed1f0416","original_commit_id":"efee1dc17df0a69551d44b6d7c53f11b2a8d2921","user":{"login":"KineticTheory","id":17579601,"node_id":"MDQ6VXNlcjE3NTc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/17579601?v=4","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false},"body":"Fixed in fe31d31","created_at":"2018-10-07T15:15:35Z","updated_at":"2018-10-07T15:15:35Z","html_url":"https://github.com/lanl/Draco/pull/496#discussion_r223217177","pull_request_url":"https://api.github.com/repos/lanl/Draco/pulls/496","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lanl/Draco/pulls/comments/223217177"},"html":{"href":"https://github.com/lanl/Draco/pull/496#discussion_r223217177"},"pull_request":{"href":"https://api.github.com/repos/lanl/Draco/pulls/496"}},"in_reply_to_id":223191410},"pull_request":{"url":"https://api.github.com/repos/lanl/Draco/pulls/496","id":220237306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMjM3MzA2","html_url":"https://github.com/lanl/Draco/pull/496","diff_url":"https://github.com/lanl/Draco/pull/496.diff","patch_url":"https://github.com/lanl/Draco/pull/496.patch","issue_url":"https://api.github.com/repos/lanl/Draco/issues/496","number":496,"state":"open","locked":false,"title":"Enable warning level 4 for Visual Studio","user":{"login":"KineticTheory","id":17579601,"node_id":"MDQ6VXNlcjE3NTc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/17579601?v=4","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false},"body":"### Background\r\n\r\n* Warning level 4 for Visual Studio adds static analysis warnings for potential design flaws like data and function hiding.  SQA sites recommend running VS with `/W4` because these warnings are quite useful.\r\n\r\n### Description of changes\r\n\r\nImplement minor changes to eliminate newly created warnings.\r\n\r\n+ **Data hiding**: Rename some variables so they do not hide variables with the same name declared at a higher scope.\r\n+ **Function hiding**: Use `override` to be explicit about what functions should be used in inheritance hierarchies.\r\n+ Change some signed/unsigned integers to eliminate unequal comparisons.\r\n+ Add a `LASTENTRY` to the `Meshes` enum in `TestRTT_Format_Reader.hh` that can be used to initialize variables at declaration in the tests.\r\n+ Eliminate `using namespace` commands found outside of function or class definitions. Also remove `using namespace` commands that appear inside of the same namespace.\r\n+ Use `static_cast` in a few places to be explicit about data type conversion.\r\n+ Use `constexpr` in a few places to eliminate warnings about conditionals that are known at compile time.\r\n+ Add extra pragmas to suppress warnings that eminate from TPL code.\r\n+ Eliminate `rng/Subrandom_Generator.cc` by moving the constructor definition to the header file.\r\n\r\nAlso:\r\n\r\n+ Split lines that declared multiple variables on a single line.\r\n+ Add two new functions to `DracoStrings` and use these instead of locally defined functions.  The new functions are constructed in a way that avoids warnings about type conversion.\r\n  - `string_tolower`\r\n  - `string_toupper`\r\n+ Comment out some unused variable names found in function signatures.\r\n+ Comment out some unreachable code.\r\n+ Fix some include directives.\r\n+ Remove `DLL_PUBLIC` macros where they are no longer needed.\r\n+ Remove some dead code.\r\n+ Fix comments (indentation, limit to 80 cols)\r\n\r\n### Status\r\n\r\n* Reference:\r\n  * [Pre-Merge Code Review](https://github.com/lanl/Draco/wiki/Style-Guide)\r\n  * [CDash Status](https://rtt.lanl.gov/cdash/index.php?project=Draco&filtercount=1&showfilters=1&field1=buildname&compare1=63&value1=-pr)\r\n* Checks\r\n  * [x] Travis CI checks pass\r\n  * [x] Code coverage does not decrease\r\n  * [x] [Valgrind test passes](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [x] [Toss3 checks pass](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [x] [Trinitite checks pass](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [ ] Code reviewed/approved, sufficient DbC checks, testing, documentation\r\n","created_at":"2018-10-04T03:10:40Z","updated_at":"2018-10-07T15:15:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"510a2b23f37ef1c9d5609a25d335b16354392ded","assignee":{"login":"KineticTheory","id":17579601,"node_id":"MDQ6VXNlcjE3NTc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/17579601?v=4","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false},"assignees":[{"login":"KineticTheory","id":17579601,"node_id":"MDQ6VXNlcjE3NTc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/17579601?v=4","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":335081557,"node_id":"MDU6TGFiZWwzMzUwODE1NTc=","url":"https://api.github.com/repos/lanl/Draco/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/lanl/Draco/pulls/496/commits","review_comments_url":"https://api.github.com/repos/lanl/Draco/pulls/496/comments","review_comment_url":"https://api.github.com/repos/lanl/Draco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lanl/Draco/issues/496/comments","statuses_url":"https://api.github.com/repos/lanl/Draco/statuses/fe31d3148fa2f5a8773cf1e64c843c0aed1f0416","head":{"label":"KineticTheory:vs_w4","ref":"vs_w4","sha":"fe31d3148fa2f5a8773cf1e64c843c0aed1f0416","user":{"login":"KineticTheory","id":17579601,"node_id":"MDQ6VXNlcjE3NTc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/17579601?v=4","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false},"repo":{"id":62067205,"node_id":"MDEwOlJlcG9zaXRvcnk2MjA2NzIwNQ==","name":"Draco","full_name":"KineticTheory/Draco","private":false,"owner":{"login":"KineticTheory","id":17579601,"node_id":"MDQ6VXNlcjE3NTc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/17579601?v=4","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KineticTheory/Draco","description":"An object-oriented component library supporting radiation transport applications.","fork":true,"url":"https://api.github.com/repos/KineticTheory/Draco","forks_url":"https://api.github.com/repos/KineticTheory/Draco/forks","keys_url":"https://api.github.com/repos/KineticTheory/Draco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KineticTheory/Draco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KineticTheory/Draco/teams","hooks_url":"https://api.github.com/repos/KineticTheory/Draco/hooks","issue_events_url":"https://api.github.com/repos/KineticTheory/Draco/issues/events{/number}","events_url":"https://api.github.com/repos/KineticTheory/Draco/events","assignees_url":"https://api.github.com/repos/KineticTheory/Draco/assignees{/user}","branches_url":"https://api.github.com/repos/KineticTheory/Draco/branches{/branch}","tags_url":"https://api.github.com/repos/KineticTheory/Draco/tags","blobs_url":"https://api.github.com/repos/KineticTheory/Draco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KineticTheory/Draco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KineticTheory/Draco/git/refs{/sha}","trees_url":"https://api.github.com/repos/KineticTheory/Draco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KineticTheory/Draco/statuses/{sha}","languages_url":"https://api.github.com/repos/KineticTheory/Draco/languages","stargazers_url":"https://api.github.com/repos/KineticTheory/Draco/stargazers","contributors_url":"https://api.github.com/repos/KineticTheory/Draco/contributors","subscribers_url":"https://api.github.com/repos/KineticTheory/Draco/subscribers","subscription_url":"https://api.github.com/repos/KineticTheory/Draco/subscription","commits_url":"https://api.github.com/repos/KineticTheory/Draco/commits{/sha}","git_commits_url":"https://api.github.com/repos/KineticTheory/Draco/git/commits{/sha}","comments_url":"https://api.github.com/repos/KineticTheory/Draco/comments{/number}","issue_comment_url":"https://api.github.com/repos/KineticTheory/Draco/issues/comments{/number}","contents_url":"https://api.github.com/repos/KineticTheory/Draco/contents/{+path}","compare_url":"https://api.github.com/repos/KineticTheory/Draco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KineticTheory/Draco/merges","archive_url":"https://api.github.com/repos/KineticTheory/Draco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KineticTheory/Draco/downloads","issues_url":"https://api.github.com/repos/KineticTheory/Draco/issues{/number}","pulls_url":"https://api.github.com/repos/KineticTheory/Draco/pulls{/number}","milestones_url":"https://api.github.com/repos/KineticTheory/Draco/milestones{/number}","notifications_url":"https://api.github.com/repos/KineticTheory/Draco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KineticTheory/Draco/labels{/name}","releases_url":"https://api.github.com/repos/KineticTheory/Draco/releases{/id}","deployments_url":"https://api.github.com/repos/KineticTheory/Draco/deployments","created_at":"2016-06-27T15:36:16Z","updated_at":"2016-06-27T15:36:24Z","pushed_at":"2018-10-07T15:14:43Z","git_url":"git://github.com/KineticTheory/Draco.git","ssh_url":"git@github.com:KineticTheory/Draco.git","clone_url":"https://github.com/KineticTheory/Draco.git","svn_url":"https://github.com/KineticTheory/Draco","homepage":null,"size":19008,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"lanl:develop","ref":"develop","sha":"45211f31fd13347127b9f6a36c06ff03d512adc3","user":{"login":"lanl","id":585305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NTMwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/585305?v=4","gravatar_id":"","url":"https://api.github.com/users/lanl","html_url":"https://github.com/lanl","followers_url":"https://api.github.com/users/lanl/followers","following_url":"https://api.github.com/users/lanl/following{/other_user}","gists_url":"https://api.github.com/users/lanl/gists{/gist_id}","starred_url":"https://api.github.com/users/lanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanl/subscriptions","organizations_url":"https://api.github.com/users/lanl/orgs","repos_url":"https://api.github.com/users/lanl/repos","events_url":"https://api.github.com/users/lanl/events{/privacy}","received_events_url":"https://api.github.com/users/lanl/received_events","type":"Organization","site_admin":false},"repo":{"id":52980394,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjk4MDM5NA==","name":"Draco","full_name":"lanl/Draco","private":false,"owner":{"login":"lanl","id":585305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NTMwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/585305?v=4","gravatar_id":"","url":"https://api.github.com/users/lanl","html_url":"https://github.com/lanl","followers_url":"https://api.github.com/users/lanl/followers","following_url":"https://api.github.com/users/lanl/following{/other_user}","gists_url":"https://api.github.com/users/lanl/gists{/gist_id}","starred_url":"https://api.github.com/users/lanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanl/subscriptions","organizations_url":"https://api.github.com/users/lanl/orgs","repos_url":"https://api.github.com/users/lanl/repos","events_url":"https://api.github.com/users/lanl/events{/privacy}","received_events_url":"https://api.github.com/users/lanl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lanl/Draco","description":"An object-oriented component library supporting radiation transport applications.","fork":false,"url":"https://api.github.com/repos/lanl/Draco","forks_url":"https://api.github.com/repos/lanl/Draco/forks","keys_url":"https://api.github.com/repos/lanl/Draco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lanl/Draco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lanl/Draco/teams","hooks_url":"https://api.github.com/repos/lanl/Draco/hooks","issue_events_url":"https://api.github.com/repos/lanl/Draco/issues/events{/number}","events_url":"https://api.github.com/repos/lanl/Draco/events","assignees_url":"https://api.github.com/repos/lanl/Draco/assignees{/user}","branches_url":"https://api.github.com/repos/lanl/Draco/branches{/branch}","tags_url":"https://api.github.com/repos/lanl/Draco/tags","blobs_url":"https://api.github.com/repos/lanl/Draco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lanl/Draco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lanl/Draco/git/refs{/sha}","trees_url":"https://api.github.com/repos/lanl/Draco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lanl/Draco/statuses/{sha}","languages_url":"https://api.github.com/repos/lanl/Draco/languages","stargazers_url":"https://api.github.com/repos/lanl/Draco/stargazers","contributors_url":"https://api.github.com/repos/lanl/Draco/contributors","subscribers_url":"https://api.github.com/repos/lanl/Draco/subscribers","subscription_url":"https://api.github.com/repos/lanl/Draco/subscription","commits_url":"https://api.github.com/repos/lanl/Draco/commits{/sha}","git_commits_url":"https://api.github.com/repos/lanl/Draco/git/commits{/sha}","comments_url":"https://api.github.com/repos/lanl/Draco/comments{/number}","issue_comment_url":"https://api.github.com/repos/lanl/Draco/issues/comments{/number}","contents_url":"https://api.github.com/repos/lanl/Draco/contents/{+path}","compare_url":"https://api.github.com/repos/lanl/Draco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lanl/Draco/merges","archive_url":"https://api.github.com/repos/lanl/Draco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lanl/Draco/downloads","issues_url":"https://api.github.com/repos/lanl/Draco/issues{/number}","pulls_url":"https://api.github.com/repos/lanl/Draco/pulls{/number}","milestones_url":"https://api.github.com/repos/lanl/Draco/milestones{/number}","notifications_url":"https://api.github.com/repos/lanl/Draco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lanl/Draco/labels{/name}","releases_url":"https://api.github.com/repos/lanl/Draco/releases{/id}","deployments_url":"https://api.github.com/repos/lanl/Draco/deployments","created_at":"2016-03-02T17:00:24Z","updated_at":"2018-10-06T17:31:57Z","pushed_at":"2018-10-07T15:14:44Z","git_url":"git://github.com/lanl/Draco.git","ssh_url":"git@github.com:lanl/Draco.git","clone_url":"https://github.com/lanl/Draco.git","svn_url":"https://github.com/lanl/Draco","homepage":null,"size":18939,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":23,"open_issues":19,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/lanl/Draco/pulls/496"},"html":{"href":"https://github.com/lanl/Draco/pull/496"},"issue":{"href":"https://api.github.com/repos/lanl/Draco/issues/496"},"comments":{"href":"https://api.github.com/repos/lanl/Draco/issues/496/comments"},"review_comments":{"href":"https://api.github.com/repos/lanl/Draco/pulls/496/comments"},"review_comment":{"href":"https://api.github.com/repos/lanl/Draco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lanl/Draco/pulls/496/commits"},"statuses":{"href":"https://api.github.com/repos/lanl/Draco/statuses/fe31d3148fa2f5a8773cf1e64c843c0aed1f0416"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"KineticTheory"}}