{"action":"created","comment":{"url":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/comments/212118575","pull_request_review_id":148677887,"id":212118575,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjExODU3NQ==","diff_hunk":"@@ -0,0 +1,78 @@\n+'use strict';\n+\n+var EventTarget = require('../util/eventtarget');\n+var inherits = require('util').inherits;\n+var util = require('../util');\n+\n+var match = navigator.userAgent.match(/Edge\\/(\\d+).(\\d+)$/);\n+var PeerConnection = require('rtcpeerconnection-shim')(window, match[2]);\n+\n+function EdgeRTCPeerConnection(configuration) {\n+  if (!(this instanceof EdgeRTCPeerConnection)) {\n+    return new EdgeRTCPeerConnection(configuration);\n+  }\n+\n+  EventTarget.call(this);\n+\n+  var peerConnection = new PeerConnection(configuration);\n+\n+  Object.defineProperties(this, {\n+    _peerConnection: {\n+      value: peerConnection\n+    },\n+    iceConnectionState: {\n+      enumerable: true,\n+      get: function() {\n+        return this._peerConnection.iceConnectionState;\n+      }\n+    },\n+    iceGatheringState: {\n+      enumerable: true,\n+      get: function() {\n+        return this._peerConnection.iceGatheringState;\n+      }\n+    },\n+    signalingState: {\n+      enumerable: true,\n+      get: function() {\n+        return this._peerConnection.signalingState;\n+      }\n+    }\n+  });\n+\n+  util.proxyProperties(PeerConnection.prototype, this, peerConnection);\n+}\n+\n+inherits(EdgeRTCPeerConnection, EventTarget);\n+\n+// otalk/RTCPeerConnection shim throws InvalidAccessError\n+// when sender is not part of getSenders or has been previously removed\n+EdgeRTCPeerConnection.prototype.removeTrack = function removeTrack(sender) {\n+  if (!this._peerConnection._isClosed && (sender instanceof window.RTCRtpSender)) {\n+    var s = this._peerConnection.getSenders().find(function(s) {","path":"lib/rtcpeerconnection/edge.js","position":52,"original_position":52,"commit_id":"32978714e330cb0d6adbf96fc1a9715e1f04655f","original_commit_id":"32978714e330cb0d6adbf96fc1a9715e1f04655f","user":{"login":"markandrus","id":359154,"node_id":"MDQ6VXNlcjM1OTE1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/359154?v=4","gravatar_id":"","url":"https://api.github.com/users/markandrus","html_url":"https://github.com/markandrus","followers_url":"https://api.github.com/users/markandrus/followers","following_url":"https://api.github.com/users/markandrus/following{/other_user}","gists_url":"https://api.github.com/users/markandrus/gists{/gist_id}","starred_url":"https://api.github.com/users/markandrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markandrus/subscriptions","organizations_url":"https://api.github.com/users/markandrus/orgs","repos_url":"https://api.github.com/users/markandrus/repos","events_url":"https://api.github.com/users/markandrus/events{/privacy}","received_events_url":"https://api.github.com/users/markandrus/received_events","type":"User","site_admin":false},"body":"Nitpick: prefer more descriptive variable names, like `sender`.","created_at":"2018-08-22T21:37:37Z","updated_at":"2018-08-22T21:53:00Z","html_url":"https://github.com/twilio/twilio-webrtc.js/pull/45#discussion_r212118575","pull_request_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/45","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/comments/212118575"},"html":{"href":"https://github.com/twilio/twilio-webrtc.js/pull/45#discussion_r212118575"},"pull_request":{"href":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/45","id":209915570,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTE1NTcw","html_url":"https://github.com/twilio/twilio-webrtc.js/pull/45","diff_url":"https://github.com/twilio/twilio-webrtc.js/pull/45.diff","patch_url":"https://github.com/twilio/twilio-webrtc.js/pull/45.patch","issue_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/issues/45","number":45,"state":"open","locked":false,"title":"Introduce RTCPeerConnection Shim for Edge ","user":{"login":"syerrapragada","id":20006575,"node_id":"MDQ6VXNlcjIwMDA2NTc1","avatar_url":"https://avatars3.githubusercontent.com/u/20006575?v=4","gravatar_id":"","url":"https://api.github.com/users/syerrapragada","html_url":"https://github.com/syerrapragada","followers_url":"https://api.github.com/users/syerrapragada/followers","following_url":"https://api.github.com/users/syerrapragada/following{/other_user}","gists_url":"https://api.github.com/users/syerrapragada/gists{/gist_id}","starred_url":"https://api.github.com/users/syerrapragada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syerrapragada/subscriptions","organizations_url":"https://api.github.com/users/syerrapragada/orgs","repos_url":"https://api.github.com/users/syerrapragada/repos","events_url":"https://api.github.com/users/syerrapragada/events{/privacy}","received_events_url":"https://api.github.com/users/syerrapragada/received_events","type":"User","site_admin":false},"body":"I fixed most of the integration tests on Edge. @markandrus @manjeshbhargav There are still couple of integration test failures that need fix.\r\n 1. `#TrackEvent`  failing with InvalidState Error\r\n 2. All `rollback` sdp type tests.","created_at":"2018-08-21T18:27:27Z","updated_at":"2018-08-22T21:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"329db53731ef5f88cbd03d3342b74de56e062019","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/45/commits","review_comments_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/45/comments","review_comment_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/issues/45/comments","statuses_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/statuses/32978714e330cb0d6adbf96fc1a9715e1f04655f","head":{"label":"twilio:edge_pcshim","ref":"edge_pcshim","sha":"32978714e330cb0d6adbf96fc1a9715e1f04655f","user":{"login":"twilio","id":109142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/109142?v=4","gravatar_id":"","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"repo":{"id":99382952,"node_id":"MDEwOlJlcG9zaXRvcnk5OTM4Mjk1Mg==","name":"twilio-webrtc.js","full_name":"twilio/twilio-webrtc.js","owner":{"login":"twilio","id":109142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/109142?v=4","gravatar_id":"","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twilio/twilio-webrtc.js","description":"WebRTC-related APIs and shims used by twilio-video.js","fork":false,"url":"https://api.github.com/repos/twilio/twilio-webrtc.js","forks_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/forks","keys_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/teams","hooks_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/hooks","issue_events_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/issues/events{/number}","events_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/events","assignees_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/assignees{/user}","branches_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/branches{/branch}","tags_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/tags","blobs_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/statuses/{sha}","languages_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/languages","stargazers_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/stargazers","contributors_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/contributors","subscribers_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/subscribers","subscription_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/subscription","commits_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/contents/{+path}","compare_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/merges","archive_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/downloads","issues_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/issues{/number}","pulls_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls{/number}","milestones_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/milestones{/number}","notifications_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/labels{/name}","releases_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/releases{/id}","deployments_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/deployments","created_at":"2017-08-04T22:09:10Z","updated_at":"2018-08-17T11:40:55Z","pushed_at":"2018-08-22T20:05:32Z","git_url":"git://github.com/twilio/twilio-webrtc.js.git","ssh_url":"git@github.com:twilio/twilio-webrtc.js.git","clone_url":"https://github.com/twilio/twilio-webrtc.js.git","svn_url":"https://github.com/twilio/twilio-webrtc.js","homepage":null,"size":6980,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"twilio:edge-support","ref":"edge-support","sha":"68e0e5942a1c171c22832f34b7f40b28d3c66e2b","user":{"login":"twilio","id":109142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/109142?v=4","gravatar_id":"","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"repo":{"id":99382952,"node_id":"MDEwOlJlcG9zaXRvcnk5OTM4Mjk1Mg==","name":"twilio-webrtc.js","full_name":"twilio/twilio-webrtc.js","owner":{"login":"twilio","id":109142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/109142?v=4","gravatar_id":"","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twilio/twilio-webrtc.js","description":"WebRTC-related APIs and shims used by twilio-video.js","fork":false,"url":"https://api.github.com/repos/twilio/twilio-webrtc.js","forks_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/forks","keys_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/teams","hooks_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/hooks","issue_events_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/issues/events{/number}","events_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/events","assignees_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/assignees{/user}","branches_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/branches{/branch}","tags_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/tags","blobs_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/statuses/{sha}","languages_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/languages","stargazers_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/stargazers","contributors_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/contributors","subscribers_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/subscribers","subscription_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/subscription","commits_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/contents/{+path}","compare_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/merges","archive_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/downloads","issues_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/issues{/number}","pulls_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls{/number}","milestones_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/milestones{/number}","notifications_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/labels{/name}","releases_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/releases{/id}","deployments_url":"https://api.github.com/repos/twilio/twilio-webrtc.js/deployments","created_at":"2017-08-04T22:09:10Z","updated_at":"2018-08-17T11:40:55Z","pushed_at":"2018-08-22T20:05:32Z","git_url":"git://github.com/twilio/twilio-webrtc.js.git","ssh_url":"git@github.com:twilio/twilio-webrtc.js.git","clone_url":"https://github.com/twilio/twilio-webrtc.js.git","svn_url":"https://github.com/twilio/twilio-webrtc.js","homepage":null,"size":6980,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/45"},"html":{"href":"https://github.com/twilio/twilio-webrtc.js/pull/45"},"issue":{"href":"https://api.github.com/repos/twilio/twilio-webrtc.js/issues/45"},"comments":{"href":"https://api.github.com/repos/twilio/twilio-webrtc.js/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twilio/twilio-webrtc.js/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/twilio/twilio-webrtc.js/statuses/32978714e330cb0d6adbf96fc1a9715e1f04655f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"markandrus"}}