{"action":"created","issue":{"url":"https://api.github.com/repos/juju-solutions/bundle-canonical-kubernetes/issues/549","repository_url":"https://api.github.com/repos/juju-solutions/bundle-canonical-kubernetes","labels_url":"https://api.github.com/repos/juju-solutions/bundle-canonical-kubernetes/issues/549/labels{/name}","comments_url":"https://api.github.com/repos/juju-solutions/bundle-canonical-kubernetes/issues/549/comments","events_url":"https://api.github.com/repos/juju-solutions/bundle-canonical-kubernetes/issues/549/events","html_url":"https://github.com/juju-solutions/bundle-canonical-kubernetes/pull/549","id":313420993,"number":549,"title":"Modifications for converged services, ceph (legacy storage mechanism, not CSI plugins)","user":{"login":"CalvinHartwell","id":1898323,"avatar_url":"https://avatars3.githubusercontent.com/u/1898323?v=4","gravatar_id":"","url":"https://api.github.com/users/CalvinHartwell","html_url":"https://github.com/CalvinHartwell","followers_url":"https://api.github.com/users/CalvinHartwell/followers","following_url":"https://api.github.com/users/CalvinHartwell/following{/other_user}","gists_url":"https://api.github.com/users/CalvinHartwell/gists{/gist_id}","starred_url":"https://api.github.com/users/CalvinHartwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CalvinHartwell/subscriptions","organizations_url":"https://api.github.com/users/CalvinHartwell/orgs","repos_url":"https://api.github.com/users/CalvinHartwell/repos","events_url":"https://api.github.com/users/CalvinHartwell/events{/privacy}","received_events_url":"https://api.github.com/users/CalvinHartwell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-04-11T17:37:06Z","updated_at":"2018-04-24T18:32:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/juju-solutions/bundle-canonical-kubernetes/pulls/549","html_url":"https://github.com/juju-solutions/bundle-canonical-kubernetes/pull/549","diff_url":"https://github.com/juju-solutions/bundle-canonical-kubernetes/pull/549.diff","patch_url":"https://github.com/juju-solutions/bundle-canonical-kubernetes/pull/549.patch"},"body":"Hi all,\r\n\r\nI've added changes to the bundle builder to add the following:\r\n- Ability to generate a converged bundle with services bundled on the same machines to save space\r\n- Added Ceph using legacy storage mechanisms, not ceph [https://github.com/ceph/ceph-csi](https://github.com/ceph/ceph-csi)\r\n\r\nHere is an example: \r\n\r\n`./bundle --converged -o ./bundles/cdk-canal-converged -c stable k8s/cdk cni/canal legacy-storage/ceph`\r\n\r\nWill produce a bundle for converged CDK with Ceph and Canal, but no Ceph CSI plugin. "},"comment":{"url":"https://api.github.com/repos/juju-solutions/bundle-canonical-kubernetes/issues/comments/384035172","html_url":"https://github.com/juju-solutions/bundle-canonical-kubernetes/pull/549#issuecomment-384035172","issue_url":"https://api.github.com/repos/juju-solutions/bundle-canonical-kubernetes/issues/549","id":384035172,"user":{"login":"CalvinHartwell","id":1898323,"avatar_url":"https://avatars3.githubusercontent.com/u/1898323?v=4","gravatar_id":"","url":"https://api.github.com/users/CalvinHartwell","html_url":"https://github.com/CalvinHartwell","followers_url":"https://api.github.com/users/CalvinHartwell/followers","following_url":"https://api.github.com/users/CalvinHartwell/following{/other_user}","gists_url":"https://api.github.com/users/CalvinHartwell/gists{/gist_id}","starred_url":"https://api.github.com/users/CalvinHartwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CalvinHartwell/subscriptions","organizations_url":"https://api.github.com/users/CalvinHartwell/orgs","repos_url":"https://api.github.com/users/CalvinHartwell/repos","events_url":"https://api.github.com/users/CalvinHartwell/events{/privacy}","received_events_url":"https://api.github.com/users/CalvinHartwell/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T18:32:51Z","updated_at":"2018-04-24T18:32:51Z","author_association":"NONE","body":"> I'm a bit concerned that this repo is going to become more and more conflicted. The charm team uses this repo to build our generic cdk bundles to place in the store, while the field is dealing with specialized situations that are probably unique per-customer. The field shouldn't have to wait on us to use a tool to build their special bundles, and we shouldn't be spending time worrying about a new PR from the field breaking our build/CI. Is a fork in order? @tvansteenburgh \r\n\r\nActually the bundles we ship to customers are very similar to what is shipped hence the PR. We actually show this tool to customers and suggest they use it to generate their own bundles. What we ship in the field is only very slightly modified, usually we do the following: \r\n\r\n1) Add more workers or masters.\r\n2) Integrate with other storage mechanisms (I.E Ceph) and other third party products (Helm could be used for this)\r\n3) Converge some of these services based on deployment substrate, this isn't always required. \r\n4) Change the CNI plugin, I.E use Canal, Flannel or Calico. \r\n\r\nIMO I think it is very important to align both the field and the dev team on tooling and automated tests, we're supposed to be delivering the same product and giving customers what they want together, I don't think this will work if we're not unified. If we in the field have to create our own test-suite and tools for bundle generation we will really struggle. \r\n\r\nAnyway this PR addresses a few issues we've picked up from the field (ignoring the CSI stuff): \r\n\r\n1) Ceph support has been added as this is a common request from customers, especially when running on bare metal. \r\n2) easyrsa in CDK should be an LXD container and not a VM as its overkill\r\n3) Ability to converge services, for example Ceph-mon and Ceph-osd can be run on the same machines (kubernetes-workers). \r\n\r\nCheers,\r\n\r\n- Calvin "}}
{"actor":{"display_login":"CalvinHartwell"}}