{"action":"created","issue":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2320","repository_url":"https://api.github.com/repos/cosmos/cosmos-sdk","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2320/labels{/name}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2320/comments","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2320/events","html_url":"https://github.com/cosmos/cosmos-sdk/issues/2320","id":359740256,"node_id":"MDU6SXNzdWUzNTk3NDAyNTY=","number":2320,"title":"Clear Transient Store in EndBlock instead of Commit","user":{"login":"rigelrozanski","id":20132176,"node_id":"MDQ6VXNlcjIwMTMyMTc2","avatar_url":"https://avatars1.githubusercontent.com/u/20132176?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelrozanski","html_url":"https://github.com/rigelrozanski","followers_url":"https://api.github.com/users/rigelrozanski/followers","following_url":"https://api.github.com/users/rigelrozanski/following{/other_user}","gists_url":"https://api.github.com/users/rigelrozanski/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelrozanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelrozanski/subscriptions","organizations_url":"https://api.github.com/users/rigelrozanski/orgs","repos_url":"https://api.github.com/users/rigelrozanski/repos","events_url":"https://api.github.com/users/rigelrozanski/events{/privacy}","received_events_url":"https://api.github.com/users/rigelrozanski/received_events","type":"User","site_admin":false},"labels":[{"id":969553658,"node_id":"MDU6TGFiZWw5Njk1NTM2NTg=","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/core","name":"core","color":"fafad2","default":false},{"id":1069170359,"node_id":"MDU6TGFiZWwxMDY5MTcwMzU5","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/prelaunch-2.0","name":"prelaunch-2.0","color":"fff4b2","default":false},{"id":855388211,"node_id":"MDU6TGFiZWw4NTUzODgyMTE=","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/tests","name":"tests","color":"d2fafa","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-13T04:40:33Z","updated_at":"2018-09-26T00:12:32Z","closed_at":null,"author_association":"MEMBER","body":"Simultaneous to this we should also turn off commit's during simulation, which really slows things down and needed to be turned on in https://github.com/cosmos/cosmos-sdk/pull/2310\r\n\r\nCC @mossid \r\n\r\nSome convo's around this:\r\n\r\n>@rigelrozanski\r\nI think organizationally speaking it makes more sense to exist in `Commit` as that’s the point for the store operations (this is the current implementation of Transient Store). `EndBlock` I see more for application logic closing operations. It would be feasible for it to exist in either I believe though\r\n@ValarDragon:\r\nI kind of feel like it would make sense to clear the Transient Store in EndBlock, as its really just there to provide a performance increase for things the app may want to query at various times intra-block. Commit is for persisting what must needs to be written disk. (Though I do see your point, as its still very much in the realm of things Commit handles)\r\nGiven that theres a motivation for clearing the transient store in EndBlock though (faster simulations, which I think is valuable), I think it we should move it there.\r\n(This shouldn't block your PR being merged post-review though!)"},"comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments/424542695","html_url":"https://github.com/cosmos/cosmos-sdk/issues/2320#issuecomment-424542695","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2320","id":424542695,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDU0MjY5NQ==","user":{"login":"rigelrozanski","id":20132176,"node_id":"MDQ6VXNlcjIwMTMyMTc2","avatar_url":"https://avatars1.githubusercontent.com/u/20132176?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelrozanski","html_url":"https://github.com/rigelrozanski","followers_url":"https://api.github.com/users/rigelrozanski/followers","following_url":"https://api.github.com/users/rigelrozanski/following{/other_user}","gists_url":"https://api.github.com/users/rigelrozanski/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelrozanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelrozanski/subscriptions","organizations_url":"https://api.github.com/users/rigelrozanski/orgs","repos_url":"https://api.github.com/users/rigelrozanski/repos","events_url":"https://api.github.com/users/rigelrozanski/events{/privacy}","received_events_url":"https://api.github.com/users/rigelrozanski/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T00:12:32Z","updated_at":"2018-09-26T00:12:32Z","author_association":"MEMBER","body":"ah maybe"}}
{"actor":{"display_login":"rigelrozanski"}}