{"action":"created","comment":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments/227460738","pull_request_review_id":167506690,"id":227460738,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzQ2MDczOA==","diff_hunk":"@@ -0,0 +1,39 @@\n+import React from \"react\"\n+import PropTypes from \"prop-types\"\n+import { css } from \"react-emotion\"\n+\n+import presets from \"../../utils/presets\"\n+\n+import { rhythm, options } from \"../../utils/typography\"\n+\n+const contentContainer = css`\n+  background: red;\n+  position: relative;\n+`\n+\n+const ContentContainer = ({ children, hasSideBar = false }) => (\n+  <div\n+    className={contentContainer}\n+    css={{\n+      maxWidth: hasSideBar\n+        ? rhythm(presets.maxWidthWithSidebar)\n+        : rhythm(presets.maxWidth),\n+      margin: `0 auto`,\n+      padding: `${rhythm(1.5)} ${rhythm(options.blockMarginBottom)}`,\n+      paddingBottom: rhythm(3.5),\n+\n+      [presets.Tablet]: {\n+        paddingBottom: rhythm(1.5),\n+      },\n+    }}","path":"www/src/components/layout/content-container.js","position":28,"original_position":28,"commit_id":"707feda8531fe2c720b14fef78b876b6736d6bdd","original_commit_id":"707feda8531fe2c720b14fef78b876b6736d6bdd","user":{"login":"greglobinski","id":32480082,"node_id":"MDQ6VXNlcjMyNDgwMDgy","avatar_url":"https://avatars2.githubusercontent.com/u/32480082?v=4","gravatar_id":"","url":"https://api.github.com/users/greglobinski","html_url":"https://github.com/greglobinski","followers_url":"https://api.github.com/users/greglobinski/followers","following_url":"https://api.github.com/users/greglobinski/following{/other_user}","gists_url":"https://api.github.com/users/greglobinski/gists{/gist_id}","starred_url":"https://api.github.com/users/greglobinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglobinski/subscriptions","organizations_url":"https://api.github.com/users/greglobinski/orgs","repos_url":"https://api.github.com/users/greglobinski/repos","events_url":"https://api.github.com/users/greglobinski/events{/privacy}","received_events_url":"https://api.github.com/users/greglobinski/received_events","type":"User","site_admin":false},"body":"Actually, the content-container.js is unused now, it's job does now the `Content` component in `layout-default.js` I will remove the  file altogether. Sorry for the mistake.","created_at":"2018-10-23T16:02:55Z","updated_at":"2018-10-23T16:02:55Z","html_url":"https://github.com/gatsbyjs/gatsby/pull/9312#discussion_r227460738","pull_request_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/9312","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments/227460738"},"html":{"href":"https://github.com/gatsbyjs/gatsby/pull/9312#discussion_r227460738"},"pull_request":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/9312"}},"in_reply_to_id":227445568},"pull_request":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/9312","id":224946018,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTQ2MDE4","html_url":"https://github.com/gatsbyjs/gatsby/pull/9312","diff_url":"https://github.com/gatsbyjs/gatsby/pull/9312.diff","patch_url":"https://github.com/gatsbyjs/gatsby/pull/9312.patch","issue_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/9312","number":9312,"state":"open","locked":false,"title":"feat(www): Ecosystem page starting point & style lint setup [WIP]","user":{"login":"greglobinski","id":32480082,"node_id":"MDQ6VXNlcjMyNDgwMDgy","avatar_url":"https://avatars2.githubusercontent.com/u/32480082?v=4","gravatar_id":"","url":"https://api.github.com/users/greglobinski","html_url":"https://github.com/greglobinski","followers_url":"https://api.github.com/users/greglobinski/followers","following_url":"https://api.github.com/users/greglobinski/following{/other_user}","gists_url":"https://api.github.com/users/greglobinski/gists{/gist_id}","starred_url":"https://api.github.com/users/greglobinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglobinski/subscriptions","organizations_url":"https://api.github.com/users/greglobinski/orgs","repos_url":"https://api.github.com/users/greglobinski/repos","events_url":"https://api.github.com/users/greglobinski/events{/privacy}","received_events_url":"https://api.github.com/users/greglobinski/received_events","type":"User","site_admin":false},"body":"* upgrade `gatsby-transformer-screenshot` to use `GATSBY_SCREENSHOT_PLACEHOLDER=true`\r\n* install and setup `stylelint`\r\n* mute stylelint errors in non Ecosystem's components\r\n* add ecosystem icon\r\n* add ecosystem page\r\n* refactor layout.js -> layout/layout-defaul.js\r\n* refactor banneer.js -> layout/top-bannner.js\r\n* create layout/page-heading.js\r\n\r\nAfter the discussion on Slack I changed styles in styled component way. With that we get Contextual class names in development and linting for CSS code. But still if the decision is that `css` prop is the only way we do styling I can revert the changes. \r\n\r\nI moved the layout component and its sub components (however not all yet) into a subfolder `components/layout`. The new layout does not implement all features the current layout has, only these which are necessary for now [WIP], but I believe it's a good idea to create layout-default.js which can be use in most pages and also other layouts for special cases like for example for Showcase page with modal feature.\r\n\r\nThe refactored components (layout, top-bar) are for now applied only to Ecosystem page, I will apply them to the rest of the pages gradually together with other changes.  \r\n\r\n![screenshot from 2018-10-23 10-45-15](https://user-images.githubusercontent.com/32480082/47348049-e3d86d00-d6b0-11e8-90e9-b0962f5cb0be.png)\r\n![screenshot from 2018-10-23 10-45-37](https://user-images.githubusercontent.com/32480082/47348056-e6d35d80-d6b0-11e8-9a16-2040255c711f.png)\r\n\r\n\r\n\r\n\r\n","created_at":"2018-10-23T08:39:19Z","updated_at":"2018-10-23T16:02:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8ab8cd52524ddf1bf38cf8b90e9c2b66f9ff141","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fk","id":21834,"node_id":"MDQ6VXNlcjIxODM0","avatar_url":"https://avatars3.githubusercontent.com/u/21834?v=4","gravatar_id":"","url":"https://api.github.com/users/fk","html_url":"https://github.com/fk","followers_url":"https://api.github.com/users/fk/followers","following_url":"https://api.github.com/users/fk/following{/other_user}","gists_url":"https://api.github.com/users/fk/gists{/gist_id}","starred_url":"https://api.github.com/users/fk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fk/subscriptions","organizations_url":"https://api.github.com/users/fk/orgs","repos_url":"https://api.github.com/users/fk/repos","events_url":"https://api.github.com/users/fk/events{/privacy}","received_events_url":"https://api.github.com/users/fk/received_events","type":"User","site_admin":false},{"login":"amberleyromo","id":3461087,"node_id":"MDQ6VXNlcjM0NjEwODc=","avatar_url":"https://avatars1.githubusercontent.com/u/3461087?v=4","gravatar_id":"","url":"https://api.github.com/users/amberleyromo","html_url":"https://github.com/amberleyromo","followers_url":"https://api.github.com/users/amberleyromo/followers","following_url":"https://api.github.com/users/amberleyromo/following{/other_user}","gists_url":"https://api.github.com/users/amberleyromo/gists{/gist_id}","starred_url":"https://api.github.com/users/amberleyromo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amberleyromo/subscriptions","organizations_url":"https://api.github.com/users/amberleyromo/orgs","repos_url":"https://api.github.com/users/amberleyromo/repos","events_url":"https://api.github.com/users/amberleyromo/events{/privacy}","received_events_url":"https://api.github.com/users/amberleyromo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/9312/commits","review_comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/9312/comments","review_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/9312/comments","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/707feda8531fe2c720b14fef78b876b6736d6bdd","head":{"label":"greglobinski:gl/ecosystem/start","ref":"gl/ecosystem/start","sha":"707feda8531fe2c720b14fef78b876b6736d6bdd","user":{"login":"greglobinski","id":32480082,"node_id":"MDQ6VXNlcjMyNDgwMDgy","avatar_url":"https://avatars2.githubusercontent.com/u/32480082?v=4","gravatar_id":"","url":"https://api.github.com/users/greglobinski","html_url":"https://github.com/greglobinski","followers_url":"https://api.github.com/users/greglobinski/followers","following_url":"https://api.github.com/users/greglobinski/following{/other_user}","gists_url":"https://api.github.com/users/greglobinski/gists{/gist_id}","starred_url":"https://api.github.com/users/greglobinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglobinski/subscriptions","organizations_url":"https://api.github.com/users/greglobinski/orgs","repos_url":"https://api.github.com/users/greglobinski/repos","events_url":"https://api.github.com/users/greglobinski/events{/privacy}","received_events_url":"https://api.github.com/users/greglobinski/received_events","type":"User","site_admin":false},"repo":{"id":153398225,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzOTgyMjU=","name":"gatsby","full_name":"greglobinski/gatsby","private":false,"owner":{"login":"greglobinski","id":32480082,"node_id":"MDQ6VXNlcjMyNDgwMDgy","avatar_url":"https://avatars2.githubusercontent.com/u/32480082?v=4","gravatar_id":"","url":"https://api.github.com/users/greglobinski","html_url":"https://github.com/greglobinski","followers_url":"https://api.github.com/users/greglobinski/followers","following_url":"https://api.github.com/users/greglobinski/following{/other_user}","gists_url":"https://api.github.com/users/greglobinski/gists{/gist_id}","starred_url":"https://api.github.com/users/greglobinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglobinski/subscriptions","organizations_url":"https://api.github.com/users/greglobinski/orgs","repos_url":"https://api.github.com/users/greglobinski/repos","events_url":"https://api.github.com/users/greglobinski/events{/privacy}","received_events_url":"https://api.github.com/users/greglobinski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/greglobinski/gatsby","description":"Build blazing fast, modern apps and websites with React","fork":true,"url":"https://api.github.com/repos/greglobinski/gatsby","forks_url":"https://api.github.com/repos/greglobinski/gatsby/forks","keys_url":"https://api.github.com/repos/greglobinski/gatsby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greglobinski/gatsby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greglobinski/gatsby/teams","hooks_url":"https://api.github.com/repos/greglobinski/gatsby/hooks","issue_events_url":"https://api.github.com/repos/greglobinski/gatsby/issues/events{/number}","events_url":"https://api.github.com/repos/greglobinski/gatsby/events","assignees_url":"https://api.github.com/repos/greglobinski/gatsby/assignees{/user}","branches_url":"https://api.github.com/repos/greglobinski/gatsby/branches{/branch}","tags_url":"https://api.github.com/repos/greglobinski/gatsby/tags","blobs_url":"https://api.github.com/repos/greglobinski/gatsby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greglobinski/gatsby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greglobinski/gatsby/git/refs{/sha}","trees_url":"https://api.github.com/repos/greglobinski/gatsby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greglobinski/gatsby/statuses/{sha}","languages_url":"https://api.github.com/repos/greglobinski/gatsby/languages","stargazers_url":"https://api.github.com/repos/greglobinski/gatsby/stargazers","contributors_url":"https://api.github.com/repos/greglobinski/gatsby/contributors","subscribers_url":"https://api.github.com/repos/greglobinski/gatsby/subscribers","subscription_url":"https://api.github.com/repos/greglobinski/gatsby/subscription","commits_url":"https://api.github.com/repos/greglobinski/gatsby/commits{/sha}","git_commits_url":"https://api.github.com/repos/greglobinski/gatsby/git/commits{/sha}","comments_url":"https://api.github.com/repos/greglobinski/gatsby/comments{/number}","issue_comment_url":"https://api.github.com/repos/greglobinski/gatsby/issues/comments{/number}","contents_url":"https://api.github.com/repos/greglobinski/gatsby/contents/{+path}","compare_url":"https://api.github.com/repos/greglobinski/gatsby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greglobinski/gatsby/merges","archive_url":"https://api.github.com/repos/greglobinski/gatsby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greglobinski/gatsby/downloads","issues_url":"https://api.github.com/repos/greglobinski/gatsby/issues{/number}","pulls_url":"https://api.github.com/repos/greglobinski/gatsby/pulls{/number}","milestones_url":"https://api.github.com/repos/greglobinski/gatsby/milestones{/number}","notifications_url":"https://api.github.com/repos/greglobinski/gatsby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greglobinski/gatsby/labels{/name}","releases_url":"https://api.github.com/repos/greglobinski/gatsby/releases{/id}","deployments_url":"https://api.github.com/repos/greglobinski/gatsby/deployments","created_at":"2018-10-17T05:04:43Z","updated_at":"2018-10-22T08:38:33Z","pushed_at":"2018-10-23T07:57:00Z","git_url":"git://github.com/greglobinski/gatsby.git","ssh_url":"git@github.com:greglobinski/gatsby.git","clone_url":"https://github.com/greglobinski/gatsby.git","svn_url":"https://github.com/greglobinski/gatsby","homepage":"https://www.gatsbyjs.org","size":434450,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gatsbyjs:master","ref":"master","sha":"ba82bc4a2bfa449c2cb87ea608756ac1fd4106a6","user":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":36040894,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA0MDg5NA==","name":"gatsby","full_name":"gatsbyjs/gatsby","private":false,"owner":{"login":"gatsbyjs","id":12551863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTUxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/12551863?v=4","gravatar_id":"","url":"https://api.github.com/users/gatsbyjs","html_url":"https://github.com/gatsbyjs","followers_url":"https://api.github.com/users/gatsbyjs/followers","following_url":"https://api.github.com/users/gatsbyjs/following{/other_user}","gists_url":"https://api.github.com/users/gatsbyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gatsbyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatsbyjs/subscriptions","organizations_url":"https://api.github.com/users/gatsbyjs/orgs","repos_url":"https://api.github.com/users/gatsbyjs/repos","events_url":"https://api.github.com/users/gatsbyjs/events{/privacy}","received_events_url":"https://api.github.com/users/gatsbyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gatsbyjs/gatsby","description":"Build blazing fast, modern apps and websites with React","fork":false,"url":"https://api.github.com/repos/gatsbyjs/gatsby","forks_url":"https://api.github.com/repos/gatsbyjs/gatsby/forks","keys_url":"https://api.github.com/repos/gatsbyjs/gatsby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gatsbyjs/gatsby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gatsbyjs/gatsby/teams","hooks_url":"https://api.github.com/repos/gatsbyjs/gatsby/hooks","issue_events_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/events{/number}","events_url":"https://api.github.com/repos/gatsbyjs/gatsby/events","assignees_url":"https://api.github.com/repos/gatsbyjs/gatsby/assignees{/user}","branches_url":"https://api.github.com/repos/gatsbyjs/gatsby/branches{/branch}","tags_url":"https://api.github.com/repos/gatsbyjs/gatsby/tags","blobs_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/refs{/sha}","trees_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/{sha}","languages_url":"https://api.github.com/repos/gatsbyjs/gatsby/languages","stargazers_url":"https://api.github.com/repos/gatsbyjs/gatsby/stargazers","contributors_url":"https://api.github.com/repos/gatsbyjs/gatsby/contributors","subscribers_url":"https://api.github.com/repos/gatsbyjs/gatsby/subscribers","subscription_url":"https://api.github.com/repos/gatsbyjs/gatsby/subscription","commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/commits{/sha}","git_commits_url":"https://api.github.com/repos/gatsbyjs/gatsby/git/commits{/sha}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/comments{/number}","issue_comment_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/comments{/number}","contents_url":"https://api.github.com/repos/gatsbyjs/gatsby/contents/{+path}","compare_url":"https://api.github.com/repos/gatsbyjs/gatsby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gatsbyjs/gatsby/merges","archive_url":"https://api.github.com/repos/gatsbyjs/gatsby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gatsbyjs/gatsby/downloads","issues_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues{/number}","pulls_url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls{/number}","milestones_url":"https://api.github.com/repos/gatsbyjs/gatsby/milestones{/number}","notifications_url":"https://api.github.com/repos/gatsbyjs/gatsby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gatsbyjs/gatsby/labels{/name}","releases_url":"https://api.github.com/repos/gatsbyjs/gatsby/releases{/id}","deployments_url":"https://api.github.com/repos/gatsbyjs/gatsby/deployments","created_at":"2015-05-21T22:43:05Z","updated_at":"2018-10-23T14:17:56Z","pushed_at":"2018-10-23T14:18:08Z","git_url":"git://github.com/gatsbyjs/gatsby.git","ssh_url":"git@github.com:gatsbyjs/gatsby.git","clone_url":"https://github.com/gatsbyjs/gatsby.git","svn_url":"https://github.com/gatsbyjs/gatsby","homepage":"https://www.gatsbyjs.org","size":435122,"stargazers_count":27035,"watchers_count":27035,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3233,"mirror_url":null,"archived":false,"open_issues_count":758,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3233,"open_issues":758,"watchers":27035,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/9312"},"html":{"href":"https://github.com/gatsbyjs/gatsby/pull/9312"},"issue":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/issues/9312"},"comments":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/issues/9312/comments"},"review_comments":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/9312/comments"},"review_comment":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/9312/commits"},"statuses":{"href":"https://api.github.com/repos/gatsbyjs/gatsby/statuses/707feda8531fe2c720b14fef78b876b6736d6bdd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"greglobinski"}}