{"action":"closed","number":22716,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/22716","id":166539869,"html_url":"https://github.com/odoo/odoo/pull/22716","diff_url":"https://github.com/odoo/odoo/pull/22716.diff","patch_url":"https://github.com/odoo/odoo/pull/22716.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/22716","number":22716,"state":"closed","locked":false,"title":"[11.0] - Foreign currency payments - wrong reconciliation test case","user":{"login":"jbeficent","id":7683926,"avatar_url":"https://avatars0.githubusercontent.com/u/7683926?v=4","gravatar_id":"","url":"https://api.github.com/users/jbeficent","html_url":"https://github.com/jbeficent","followers_url":"https://api.github.com/users/jbeficent/followers","following_url":"https://api.github.com/users/jbeficent/following{/other_user}","gists_url":"https://api.github.com/users/jbeficent/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeficent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeficent/subscriptions","organizations_url":"https://api.github.com/users/jbeficent/orgs","repos_url":"https://api.github.com/users/jbeficent/repos","events_url":"https://api.github.com/users/jbeficent/events{/privacy}","received_events_url":"https://api.github.com/users/jbeficent/received_events","type":"User","site_admin":false},"body":"Description of the issue/feature this PR addresses:\r\nIf you issue and get paid for an invoice in a different currency than the company, the full reconciliation should only occur when the invoice has been paid in full from the invoice currency perspective. Now, if the amounts in invoice and payment match from a company currency perspective, the invoice is incorrectly flagged as paid.\r\n\r\nCurrent behavior before PR:\r\n\r\nDesired behavior after PR is merged:\r\nDoes not implement any fix. Just adds a successful and a failing test scenarios.\r\n\r\nSteps to reproduce:\r\nFAILING SCENARIO:\r\nDay 1: Invoice Cust/001 to customer (expressed in CC)\r\nMarket value of CC (day 1): 1 CC = $0.5\r\n* Dr. 100 CC / $50 - Accounts receivable\r\n* Cr. 100 CC / $50 - Revenue\r\n\r\n Day 2: Receive payment for half invoice Cust/001 (in CC)\r\nMarket value of CC (day 2): 1 CC = $1\r\nPayment transaction:\r\n* Dr. 50 CC / $50 - CC Bank\r\n* Cr. 50 CC / $50 - Accounts Receivable\r\n\r\nAt this point the invoice Invoice Cust/001  is flagged as 'paid'.\r\n\r\nIt is expected that the invoice should keep open, and after the second payment has been received, it should be flagged as paid, and an exchange rate journal entry should be created with the gain/loss.\r\n\r\n\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2018-02-01T13:41:15Z","updated_at":"2018-03-16T14:35:47Z","closed_at":"2018-03-16T14:35:47Z","merged_at":null,"merge_commit_sha":"b6867f22be9803c04284ef37b753cf88a5af2f90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":712046675,"url":"https://api.github.com/repos/odoo/odoo/labels/11.0","name":"11.0","color":"80f438","default":false},{"id":620800387,"url":"https://api.github.com/repos/odoo/odoo/labels/Accounting","name":"Accounting","color":"ac0000","default":false},{"id":99269636,"url":"https://api.github.com/repos/odoo/odoo/labels/Confirmed","name":"Confirmed","color":"DF013A","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/22716/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/22716/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/22716/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/b1da244b305195b1762f388d444aae9c2bf71e35","head":{"label":"Eficent:11.0-eficent-fix_reconciliation","ref":"11.0-eficent-fix_reconciliation","sha":"b1da244b305195b1762f388d444aae9c2bf71e35","user":{"login":"Eficent","id":7718403,"avatar_url":"https://avatars0.githubusercontent.com/u/7718403?v=4","gravatar_id":"","url":"https://api.github.com/users/Eficent","html_url":"https://github.com/Eficent","followers_url":"https://api.github.com/users/Eficent/followers","following_url":"https://api.github.com/users/Eficent/following{/other_user}","gists_url":"https://api.github.com/users/Eficent/gists{/gist_id}","starred_url":"https://api.github.com/users/Eficent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eficent/subscriptions","organizations_url":"https://api.github.com/users/Eficent/orgs","repos_url":"https://api.github.com/users/Eficent/repos","events_url":"https://api.github.com/users/Eficent/events{/privacy}","received_events_url":"https://api.github.com/users/Eficent/received_events","type":"Organization","site_admin":false},"repo":{"id":30303054,"name":"odoo","full_name":"Eficent/odoo","owner":{"login":"Eficent","id":7718403,"avatar_url":"https://avatars0.githubusercontent.com/u/7718403?v=4","gravatar_id":"","url":"https://api.github.com/users/Eficent","html_url":"https://github.com/Eficent","followers_url":"https://api.github.com/users/Eficent/followers","following_url":"https://api.github.com/users/Eficent/following{/other_user}","gists_url":"https://api.github.com/users/Eficent/gists{/gist_id}","starred_url":"https://api.github.com/users/Eficent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eficent/subscriptions","organizations_url":"https://api.github.com/users/Eficent/orgs","repos_url":"https://api.github.com/users/Eficent/repos","events_url":"https://api.github.com/users/Eficent/events{/privacy}","received_events_url":"https://api.github.com/users/Eficent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Eficent/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":true,"url":"https://api.github.com/repos/Eficent/odoo","forks_url":"https://api.github.com/repos/Eficent/odoo/forks","keys_url":"https://api.github.com/repos/Eficent/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eficent/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eficent/odoo/teams","hooks_url":"https://api.github.com/repos/Eficent/odoo/hooks","issue_events_url":"https://api.github.com/repos/Eficent/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/Eficent/odoo/events","assignees_url":"https://api.github.com/repos/Eficent/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/Eficent/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/Eficent/odoo/tags","blobs_url":"https://api.github.com/repos/Eficent/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eficent/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eficent/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eficent/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eficent/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/Eficent/odoo/languages","stargazers_url":"https://api.github.com/repos/Eficent/odoo/stargazers","contributors_url":"https://api.github.com/repos/Eficent/odoo/contributors","subscribers_url":"https://api.github.com/repos/Eficent/odoo/subscribers","subscription_url":"https://api.github.com/repos/Eficent/odoo/subscription","commits_url":"https://api.github.com/repos/Eficent/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eficent/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eficent/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eficent/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eficent/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/Eficent/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eficent/odoo/merges","archive_url":"https://api.github.com/repos/Eficent/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eficent/odoo/downloads","issues_url":"https://api.github.com/repos/Eficent/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/Eficent/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/Eficent/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/Eficent/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eficent/odoo/labels{/name}","releases_url":"https://api.github.com/repos/Eficent/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/Eficent/odoo/deployments","created_at":"2015-02-04T14:37:42Z","updated_at":"2016-05-02T12:36:09Z","pushed_at":"2018-03-16T10:46:25Z","git_url":"git://github.com/Eficent/odoo.git","ssh_url":"git@github.com:Eficent/odoo.git","clone_url":"https://github.com/Eficent/odoo.git","svn_url":"https://github.com/Eficent/odoo","homepage":"https://www.odoo.com","size":1990178,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"11.0"}},"base":{"label":"odoo:11.0","ref":"11.0","sha":"5af12238781a147b56572d5b576f64a4e1473083","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2018-03-16T14:25:00Z","pushed_at":"2018-03-16T14:33:28Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1995660,"stargazers_count":9058,"watchers_count":9058,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7784,"mirror_url":null,"archived":false,"open_issues_count":2212,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7784,"open_issues":2212,"watchers":9058,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/22716"},"html":{"href":"https://github.com/odoo/odoo/pull/22716"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/22716"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/22716/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/22716/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/22716/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/b1da244b305195b1762f388d444aae9c2bf71e35"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":6,"review_comments":5,"maintainer_can_modify":false,"commits":3,"additions":85,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"qdp-odoo"}}