{"action":"created","comment":{"url":"https://api.github.com/repos/linode/manager/pulls/comments/237257536","pull_request_review_id":179513105,"id":237257536,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzI1NzUzNg==","diff_hunk":"@@ -141,7 +142,7 @@ export const resizeVolume = (volumeId: number, data: { size: number }) => Reques\n  * @param data { { label: string } } The updated label for this Volume.\n  *\n  */\n-export const updateVolume = (volumeId: number, data: { label: string }) => Request<Volume>(\n+export const updateVolume = (volumeId: number, data: { label: string, tags?: string[] }) => Request<Volume>(","path":"src/services/volumes/volumes.ts","position":13,"original_position":13,"commit_id":"ee2220c7aa3132e8a0091b82a92c00ced2c23b72","original_commit_id":"8baa44b487738606750fe88b89f8ba7911d84d0a","user":{"login":"rjstires","id":12218651,"node_id":"MDQ6VXNlcjEyMjE4NjUx","avatar_url":"https://avatars0.githubusercontent.com/u/12218651?v=4","gravatar_id":"","url":"https://api.github.com/users/rjstires","html_url":"https://github.com/rjstires","followers_url":"https://api.github.com/users/rjstires/followers","following_url":"https://api.github.com/users/rjstires/following{/other_user}","gists_url":"https://api.github.com/users/rjstires/gists{/gist_id}","starred_url":"https://api.github.com/users/rjstires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjstires/subscriptions","organizations_url":"https://api.github.com/users/rjstires/orgs","repos_url":"https://api.github.com/users/rjstires/repos","events_url":"https://api.github.com/users/rjstires/events{/privacy}","received_events_url":"https://api.github.com/users/rjstires/received_events","type":"User","site_admin":false},"body":"Label is required and tags are options, per API docs.\r\n\r\nMy understanding, WRT tags, is that if we supply an empty array it will update the volume to have no tags. That seems like a super easy way of deleting someones tags inadvertently. ","created_at":"2018-11-28T20:57:23Z","updated_at":"2018-11-28T20:57:23Z","html_url":"https://github.com/linode/manager/pull/4148#discussion_r237257536","pull_request_url":"https://api.github.com/repos/linode/manager/pulls/4148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/linode/manager/pulls/comments/237257536"},"html":{"href":"https://github.com/linode/manager/pull/4148#discussion_r237257536"},"pull_request":{"href":"https://api.github.com/repos/linode/manager/pulls/4148"}},"in_reply_to_id":237248987},"pull_request":{"url":"https://api.github.com/repos/linode/manager/pulls/4148","id":234309170,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzA5MTcw","html_url":"https://github.com/linode/manager/pull/4148","diff_url":"https://github.com/linode/manager/pull/4148.diff","patch_url":"https://github.com/linode/manager/pull/4148.patch","issue_url":"https://api.github.com/repos/linode/manager/issues/4148","number":4148,"state":"open","locked":false,"title":"M3-1438 M3-1459 Add/edit tags for volumes.","user":{"login":"rjstires","id":12218651,"node_id":"MDQ6VXNlcjEyMjE4NjUx","avatar_url":"https://avatars0.githubusercontent.com/u/12218651?v=4","gravatar_id":"","url":"https://api.github.com/users/rjstires","html_url":"https://github.com/rjstires","followers_url":"https://api.github.com/users/rjstires/followers","following_url":"https://api.github.com/users/rjstires/following{/other_user}","gists_url":"https://api.github.com/users/rjstires/gists{/gist_id}","starred_url":"https://api.github.com/users/rjstires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjstires/subscriptions","organizations_url":"https://api.github.com/users/rjstires/orgs","repos_url":"https://api.github.com/users/rjstires/repos","events_url":"https://api.github.com/users/rjstires/events{/privacy}","received_events_url":"https://api.github.com/users/rjstires/received_events","type":"User","site_admin":false},"body":"_In progress_\r\n#### TagsInput\r\nchange: Added optional/defaulted name property.\r\nchange: Added optional/defaulted label property.\r\nchange: Added optional onBlur handler.","created_at":"2018-11-28T15:02:53Z","updated_at":"2018-11-28T20:57:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a876c1ff2d96029ae626c1d1f4411e86697ad4bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":872353835,"node_id":"MDU6TGFiZWw4NzIzNTM4MzU=","url":"https://api.github.com/repos/linode/manager/labels/Work%20in%20Progress","name":"Work in Progress","color":"ffbd8d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/linode/manager/pulls/4148/commits","review_comments_url":"https://api.github.com/repos/linode/manager/pulls/4148/comments","review_comment_url":"https://api.github.com/repos/linode/manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linode/manager/issues/4148/comments","statuses_url":"https://api.github.com/repos/linode/manager/statuses/ee2220c7aa3132e8a0091b82a92c00ced2c23b72","head":{"label":"rjstires:M3-1459-add-edit-volume-tags","ref":"M3-1459-add-edit-volume-tags","sha":"ee2220c7aa3132e8a0091b82a92c00ced2c23b72","user":{"login":"rjstires","id":12218651,"node_id":"MDQ6VXNlcjEyMjE4NjUx","avatar_url":"https://avatars0.githubusercontent.com/u/12218651?v=4","gravatar_id":"","url":"https://api.github.com/users/rjstires","html_url":"https://github.com/rjstires","followers_url":"https://api.github.com/users/rjstires/followers","following_url":"https://api.github.com/users/rjstires/following{/other_user}","gists_url":"https://api.github.com/users/rjstires/gists{/gist_id}","starred_url":"https://api.github.com/users/rjstires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjstires/subscriptions","organizations_url":"https://api.github.com/users/rjstires/orgs","repos_url":"https://api.github.com/users/rjstires/repos","events_url":"https://api.github.com/users/rjstires/events{/privacy}","received_events_url":"https://api.github.com/users/rjstires/received_events","type":"User","site_admin":false},"repo":{"id":111036147,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEwMzYxNDc=","name":"manager","full_name":"rjstires/manager","private":false,"owner":{"login":"rjstires","id":12218651,"node_id":"MDQ6VXNlcjEyMjE4NjUx","avatar_url":"https://avatars0.githubusercontent.com/u/12218651?v=4","gravatar_id":"","url":"https://api.github.com/users/rjstires","html_url":"https://github.com/rjstires","followers_url":"https://api.github.com/users/rjstires/followers","following_url":"https://api.github.com/users/rjstires/following{/other_user}","gists_url":"https://api.github.com/users/rjstires/gists{/gist_id}","starred_url":"https://api.github.com/users/rjstires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjstires/subscriptions","organizations_url":"https://api.github.com/users/rjstires/orgs","repos_url":"https://api.github.com/users/rjstires/repos","events_url":"https://api.github.com/users/rjstires/events{/privacy}","received_events_url":"https://api.github.com/users/rjstires/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rjstires/manager","description":"The Linode Manager (Beta)","fork":true,"url":"https://api.github.com/repos/rjstires/manager","forks_url":"https://api.github.com/repos/rjstires/manager/forks","keys_url":"https://api.github.com/repos/rjstires/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjstires/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjstires/manager/teams","hooks_url":"https://api.github.com/repos/rjstires/manager/hooks","issue_events_url":"https://api.github.com/repos/rjstires/manager/issues/events{/number}","events_url":"https://api.github.com/repos/rjstires/manager/events","assignees_url":"https://api.github.com/repos/rjstires/manager/assignees{/user}","branches_url":"https://api.github.com/repos/rjstires/manager/branches{/branch}","tags_url":"https://api.github.com/repos/rjstires/manager/tags","blobs_url":"https://api.github.com/repos/rjstires/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjstires/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjstires/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjstires/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjstires/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/rjstires/manager/languages","stargazers_url":"https://api.github.com/repos/rjstires/manager/stargazers","contributors_url":"https://api.github.com/repos/rjstires/manager/contributors","subscribers_url":"https://api.github.com/repos/rjstires/manager/subscribers","subscription_url":"https://api.github.com/repos/rjstires/manager/subscription","commits_url":"https://api.github.com/repos/rjstires/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjstires/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjstires/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjstires/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjstires/manager/contents/{+path}","compare_url":"https://api.github.com/repos/rjstires/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjstires/manager/merges","archive_url":"https://api.github.com/repos/rjstires/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjstires/manager/downloads","issues_url":"https://api.github.com/repos/rjstires/manager/issues{/number}","pulls_url":"https://api.github.com/repos/rjstires/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/rjstires/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/rjstires/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjstires/manager/labels{/name}","releases_url":"https://api.github.com/repos/rjstires/manager/releases{/id}","deployments_url":"https://api.github.com/repos/rjstires/manager/deployments","created_at":"2017-11-17T00:03:52Z","updated_at":"2017-11-17T00:03:55Z","pushed_at":"2018-11-28T20:51:34Z","git_url":"git://github.com/rjstires/manager.git","ssh_url":"git@github.com:rjstires/manager.git","clone_url":"https://github.com/rjstires/manager.git","svn_url":"https://github.com/rjstires/manager","homepage":"https://cloud.linode.com","size":26325,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"linode:feature/M3-1405-volume-tags","ref":"feature/M3-1405-volume-tags","sha":"e187a81a667a3c89e9562a3edb03ef62fa0946e9","user":{"login":"linode","id":5184305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxODQzMDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5184305?v=4","gravatar_id":"","url":"https://api.github.com/users/linode","html_url":"https://github.com/linode","followers_url":"https://api.github.com/users/linode/followers","following_url":"https://api.github.com/users/linode/following{/other_user}","gists_url":"https://api.github.com/users/linode/gists{/gist_id}","starred_url":"https://api.github.com/users/linode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linode/subscriptions","organizations_url":"https://api.github.com/users/linode/orgs","repos_url":"https://api.github.com/users/linode/repos","events_url":"https://api.github.com/users/linode/events{/privacy}","received_events_url":"https://api.github.com/users/linode/received_events","type":"Organization","site_admin":false},"repo":{"id":58934207,"node_id":"MDEwOlJlcG9zaXRvcnk1ODkzNDIwNw==","name":"manager","full_name":"linode/manager","private":false,"owner":{"login":"linode","id":5184305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxODQzMDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5184305?v=4","gravatar_id":"","url":"https://api.github.com/users/linode","html_url":"https://github.com/linode","followers_url":"https://api.github.com/users/linode/followers","following_url":"https://api.github.com/users/linode/following{/other_user}","gists_url":"https://api.github.com/users/linode/gists{/gist_id}","starred_url":"https://api.github.com/users/linode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linode/subscriptions","organizations_url":"https://api.github.com/users/linode/orgs","repos_url":"https://api.github.com/users/linode/repos","events_url":"https://api.github.com/users/linode/events{/privacy}","received_events_url":"https://api.github.com/users/linode/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linode/manager","description":"The Linode Manager (Early Access)","fork":false,"url":"https://api.github.com/repos/linode/manager","forks_url":"https://api.github.com/repos/linode/manager/forks","keys_url":"https://api.github.com/repos/linode/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linode/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linode/manager/teams","hooks_url":"https://api.github.com/repos/linode/manager/hooks","issue_events_url":"https://api.github.com/repos/linode/manager/issues/events{/number}","events_url":"https://api.github.com/repos/linode/manager/events","assignees_url":"https://api.github.com/repos/linode/manager/assignees{/user}","branches_url":"https://api.github.com/repos/linode/manager/branches{/branch}","tags_url":"https://api.github.com/repos/linode/manager/tags","blobs_url":"https://api.github.com/repos/linode/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linode/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linode/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/linode/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linode/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/linode/manager/languages","stargazers_url":"https://api.github.com/repos/linode/manager/stargazers","contributors_url":"https://api.github.com/repos/linode/manager/contributors","subscribers_url":"https://api.github.com/repos/linode/manager/subscribers","subscription_url":"https://api.github.com/repos/linode/manager/subscription","commits_url":"https://api.github.com/repos/linode/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/linode/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/linode/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/linode/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/linode/manager/contents/{+path}","compare_url":"https://api.github.com/repos/linode/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linode/manager/merges","archive_url":"https://api.github.com/repos/linode/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linode/manager/downloads","issues_url":"https://api.github.com/repos/linode/manager/issues{/number}","pulls_url":"https://api.github.com/repos/linode/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/linode/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/linode/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linode/manager/labels{/name}","releases_url":"https://api.github.com/repos/linode/manager/releases{/id}","deployments_url":"https://api.github.com/repos/linode/manager/deployments","created_at":"2016-05-16T13:24:49Z","updated_at":"2018-11-28T20:38:13Z","pushed_at":"2018-11-28T20:56:39Z","git_url":"git://github.com/linode/manager.git","ssh_url":"git@github.com:linode/manager.git","clone_url":"https://github.com/linode/manager.git","svn_url":"https://github.com/linode/manager","homepage":"https://cloud.linode.com","size":24794,"stargazers_count":387,"watchers_count":387,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":95,"open_issues":14,"watchers":387,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/linode/manager/pulls/4148"},"html":{"href":"https://github.com/linode/manager/pull/4148"},"issue":{"href":"https://api.github.com/repos/linode/manager/issues/4148"},"comments":{"href":"https://api.github.com/repos/linode/manager/issues/4148/comments"},"review_comments":{"href":"https://api.github.com/repos/linode/manager/pulls/4148/comments"},"review_comment":{"href":"https://api.github.com/repos/linode/manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linode/manager/pulls/4148/commits"},"statuses":{"href":"https://api.github.com/repos/linode/manager/statuses/ee2220c7aa3132e8a0091b82a92c00ced2c23b72"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rjstires"}}