{"action":"opened","number":1162,"pull_request":{"url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1162","id":229035143,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDM1MTQz","html_url":"https://github.com/input-output-hk/daedalus/pull/1162","diff_url":"https://github.com/input-output-hk/daedalus/pull/1162.diff","patch_url":"https://github.com/input-output-hk/daedalus/pull/1162.patch","issue_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1162","number":1162,"state":"open","locked":false,"title":"[DDW-462] use taskkill to kill processes with pid on windows","user":{"login":"DominikGuzei","id":172414,"node_id":"MDQ6VXNlcjE3MjQxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/172414?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikGuzei","html_url":"https://github.com/DominikGuzei","followers_url":"https://api.github.com/users/DominikGuzei/followers","following_url":"https://api.github.com/users/DominikGuzei/following{/other_user}","gists_url":"https://api.github.com/users/DominikGuzei/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikGuzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikGuzei/subscriptions","organizations_url":"https://api.github.com/users/DominikGuzei/orgs","repos_url":"https://api.github.com/users/DominikGuzei/repos","events_url":"https://api.github.com/users/DominikGuzei/events{/privacy}","received_events_url":"https://api.github.com/users/DominikGuzei/received_events","type":"User","site_admin":false},"body":"This PR tries to solve an issue on Windows where an existing cardano-node sometimes cannot be killed by using normal `process.kill(pid)` because of a [known issue in node.js](https://github.com/nodejs/node/issues/3617).\r\n\r\n---\r\n\r\n## Review Checklist:\r\n\r\n### Basics\r\n\r\n- [ ] PR is updated to the most recent version of target branch (and there are no conflicts)\r\n- [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes\r\n- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub\r\n- [ ] Automated tests: All acceptance tests are passing (`yarn run test`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)\r\n- [ ] There are no *flow* errors or warnings (`yarn run flow:test`)\r\n- [ ] There are no *lint* errors or warnings (`yarn run lint`)\r\n- [ ] Text changes are proofread and approved (Jane Wild)\r\n- [ ] There are no missing translations (running `yarn run manage:translations` produces no changes)\r\n- [ ] UI changes look good in all themes (Alexander Rukin)\r\n- [ ] Storybook works and no stories are broken (`yarn run storybook`)\r\n- [ ] In case of dependency changes `yarn.lock` file is updated\r\n\r\n### Code Quality\r\n- [ ] Important parts of the code are properly documented and commented\r\n- [ ] Code is properly typed with flow\r\n- [ ] React components are split-up enough to avoid unnecessary re-rendering\r\n- [ ] Any code that only works in Electron is neatly separated from components\r\n\r\n### Testing\r\n- [ ] New feature / change is covered by acceptance tests\r\n- [ ] All existing acceptance tests are still up-to-date\r\n- [ ] New feature / change is covered by Daedalus Testing scenario\r\n- [ ] All existing Daedalus Testing scenarios are still up-to-date\r\n\r\n### After Review:\r\n- [ ] Merge PR\r\n- [ ] Delete source branch\r\n- [ ] Move ticket to `done` on the Youtrack board\r\n","created_at":"2018-11-07T13:55:47Z","updated_at":"2018-11-07T13:55:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"DominikGuzei","id":172414,"node_id":"MDQ6VXNlcjE3MjQxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/172414?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikGuzei","html_url":"https://github.com/DominikGuzei","followers_url":"https://api.github.com/users/DominikGuzei/followers","following_url":"https://api.github.com/users/DominikGuzei/following{/other_user}","gists_url":"https://api.github.com/users/DominikGuzei/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikGuzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikGuzei/subscriptions","organizations_url":"https://api.github.com/users/DominikGuzei/orgs","repos_url":"https://api.github.com/users/DominikGuzei/repos","events_url":"https://api.github.com/users/DominikGuzei/events{/privacy}","received_events_url":"https://api.github.com/users/DominikGuzei/received_events","type":"User","site_admin":false},"assignees":[{"login":"DominikGuzei","id":172414,"node_id":"MDQ6VXNlcjE3MjQxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/172414?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikGuzei","html_url":"https://github.com/DominikGuzei","followers_url":"https://api.github.com/users/DominikGuzei/followers","following_url":"https://api.github.com/users/DominikGuzei/following{/other_user}","gists_url":"https://api.github.com/users/DominikGuzei/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikGuzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikGuzei/subscriptions","organizations_url":"https://api.github.com/users/DominikGuzei/orgs","repos_url":"https://api.github.com/users/DominikGuzei/repos","events_url":"https://api.github.com/users/DominikGuzei/events{/privacy}","received_events_url":"https://api.github.com/users/DominikGuzei/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":679315587,"node_id":"MDU6TGFiZWw2NzkzMTU1ODc=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/DO%20NOT%20MERGE","name":"DO NOT MERGE","color":"000000","default":false},{"id":465480669,"node_id":"MDU6TGFiZWw0NjU0ODA2Njk=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/WIP","name":"WIP","color":"fbca04","default":false},{"id":455603671,"node_id":"MDU6TGFiZWw0NTU2MDM2NzE=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1162/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1162/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1162/comments","statuses_url":"https://api.github.com/repos/input-output-hk/daedalus/statuses/3c4577577674675a8b7f3569ea1d0397c3398744","head":{"label":"input-output-hk:fix/ddw-462-node-restarting-not-working-on-windows","ref":"fix/ddw-462-node-restarting-not-working-on-windows","sha":"3c4577577674675a8b7f3569ea1d0397c3398744","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70064828,"node_id":"MDEwOlJlcG9zaXRvcnk3MDA2NDgyOA==","name":"daedalus","full_name":"input-output-hk/daedalus","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/daedalus","description":"Daedalus - cryptocurrency wallet","fork":false,"url":"https://api.github.com/repos/input-output-hk/daedalus","forks_url":"https://api.github.com/repos/input-output-hk/daedalus/forks","keys_url":"https://api.github.com/repos/input-output-hk/daedalus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/daedalus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/daedalus/teams","hooks_url":"https://api.github.com/repos/input-output-hk/daedalus/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/daedalus/events","assignees_url":"https://api.github.com/repos/input-output-hk/daedalus/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/daedalus/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/daedalus/tags","blobs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/daedalus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/daedalus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/daedalus/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/daedalus/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/daedalus/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/daedalus/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/daedalus/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/daedalus/subscription","commits_url":"https://api.github.com/repos/input-output-hk/daedalus/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/daedalus/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/daedalus/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/daedalus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/daedalus/merges","archive_url":"https://api.github.com/repos/input-output-hk/daedalus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/daedalus/downloads","issues_url":"https://api.github.com/repos/input-output-hk/daedalus/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/daedalus/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/daedalus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/daedalus/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/daedalus/deployments","created_at":"2016-10-05T13:48:54Z","updated_at":"2018-11-06T11:48:31Z","pushed_at":"2018-11-07T13:53:55Z","git_url":"git://github.com/input-output-hk/daedalus.git","ssh_url":"git@github.com:input-output-hk/daedalus.git","clone_url":"https://github.com/input-output-hk/daedalus.git","svn_url":"https://github.com/input-output-hk/daedalus","homepage":null,"size":131975,"stargazers_count":492,"watchers_count":492,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":159,"open_issues":108,"watchers":492,"default_branch":"develop"}},"base":{"label":"input-output-hk:release/0.12.0","ref":"release/0.12.0","sha":"8e59bfdf0d013bfa9acab4d9aa695275c86504b2","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70064828,"node_id":"MDEwOlJlcG9zaXRvcnk3MDA2NDgyOA==","name":"daedalus","full_name":"input-output-hk/daedalus","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/daedalus","description":"Daedalus - cryptocurrency wallet","fork":false,"url":"https://api.github.com/repos/input-output-hk/daedalus","forks_url":"https://api.github.com/repos/input-output-hk/daedalus/forks","keys_url":"https://api.github.com/repos/input-output-hk/daedalus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/daedalus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/daedalus/teams","hooks_url":"https://api.github.com/repos/input-output-hk/daedalus/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/daedalus/events","assignees_url":"https://api.github.com/repos/input-output-hk/daedalus/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/daedalus/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/daedalus/tags","blobs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/daedalus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/daedalus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/daedalus/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/daedalus/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/daedalus/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/daedalus/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/daedalus/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/daedalus/subscription","commits_url":"https://api.github.com/repos/input-output-hk/daedalus/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/daedalus/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/daedalus/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/daedalus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/daedalus/merges","archive_url":"https://api.github.com/repos/input-output-hk/daedalus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/daedalus/downloads","issues_url":"https://api.github.com/repos/input-output-hk/daedalus/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/daedalus/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/daedalus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/daedalus/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/daedalus/deployments","created_at":"2016-10-05T13:48:54Z","updated_at":"2018-11-06T11:48:31Z","pushed_at":"2018-11-07T13:53:55Z","git_url":"git://github.com/input-output-hk/daedalus.git","ssh_url":"git@github.com:input-output-hk/daedalus.git","clone_url":"https://github.com/input-output-hk/daedalus.git","svn_url":"https://github.com/input-output-hk/daedalus","homepage":null,"size":131975,"stargazers_count":492,"watchers_count":492,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":159,"open_issues":108,"watchers":492,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1162"},"html":{"href":"https://github.com/input-output-hk/daedalus/pull/1162"},"issue":{"href":"https://api.github.com/repos/input-output-hk/daedalus/issues/1162"},"comments":{"href":"https://api.github.com/repos/input-output-hk/daedalus/issues/1162/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1162/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1162/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/daedalus/statuses/3c4577577674675a8b7f3569ea1d0397c3398744"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"DominikGuzei"}}