{"action":"created","issue":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/14298","repository_url":"https://api.github.com/repos/mrdoob/three.js","labels_url":"https://api.github.com/repos/mrdoob/three.js/issues/14298/labels{/name}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/14298/comments","events_url":"https://api.github.com/repos/mrdoob/three.js/issues/14298/events","html_url":"https://github.com/mrdoob/three.js/pull/14298","id":332953089,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzEyNzM3","number":14298,"title":"Added video support to loading manager","user":{"login":"osiriswrecks","id":24221107,"node_id":"MDQ6VXNlcjI0MjIxMTA3","avatar_url":"https://avatars0.githubusercontent.com/u/24221107?v=4","gravatar_id":"","url":"https://api.github.com/users/osiriswrecks","html_url":"https://github.com/osiriswrecks","followers_url":"https://api.github.com/users/osiriswrecks/followers","following_url":"https://api.github.com/users/osiriswrecks/following{/other_user}","gists_url":"https://api.github.com/users/osiriswrecks/gists{/gist_id}","starred_url":"https://api.github.com/users/osiriswrecks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osiriswrecks/subscriptions","organizations_url":"https://api.github.com/users/osiriswrecks/orgs","repos_url":"https://api.github.com/users/osiriswrecks/repos","events_url":"https://api.github.com/users/osiriswrecks/events{/privacy}","received_events_url":"https://api.github.com/users/osiriswrecks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mrdoob/three.js/milestones/4","html_url":"https://github.com/mrdoob/three.js/milestone/4","labels_url":"https://api.github.com/repos/mrdoob/three.js/milestones/4/labels","id":3044279,"node_id":"MDk6TWlsZXN0b25lMzA0NDI3OQ==","number":4,"title":"rXX","description":"","creator":{"login":"mrdoob","id":97088,"node_id":"MDQ6VXNlcjk3MDg4","avatar_url":"https://avatars0.githubusercontent.com/u/97088?v=4","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":11,"state":"open","created_at":"2018-01-17T23:51:52Z","updated_at":"2018-06-16T16:26:27Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-06-16T02:14:00Z","updated_at":"2018-06-16T17:10:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/14298","html_url":"https://github.com/mrdoob/three.js/pull/14298","diff_url":"https://github.com/mrdoob/three.js/pull/14298.diff","patch_url":"https://github.com/mrdoob/three.js/pull/14298.patch"},"body":"We needed a basic way to track loading progress for video textures on a project at work, so I added VideoLoader and VideoTextureLoader objects based on existing code.\r\n\r\nThis is my first pull request...well, ever, so I'm happy to clean up and reduce duplicated code (and right now, there's a good chunk of that because I copied the ImageLoader and TextureLoader files and tweaked things to work for video). I'd love to see this functionality added to the mainstream build if others find it useful."},"comment":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/397826442","html_url":"https://github.com/mrdoob/three.js/pull/14298#issuecomment-397826442","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/14298","id":397826442,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzgyNjQ0Mg==","user":{"login":"Mugen87","id":12612165,"node_id":"MDQ6VXNlcjEyNjEyMTY1","avatar_url":"https://avatars2.githubusercontent.com/u/12612165?v=4","gravatar_id":"","url":"https://api.github.com/users/Mugen87","html_url":"https://github.com/Mugen87","followers_url":"https://api.github.com/users/Mugen87/followers","following_url":"https://api.github.com/users/Mugen87/following{/other_user}","gists_url":"https://api.github.com/users/Mugen87/gists{/gist_id}","starred_url":"https://api.github.com/users/Mugen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mugen87/subscriptions","organizations_url":"https://api.github.com/users/Mugen87/orgs","repos_url":"https://api.github.com/users/Mugen87/repos","events_url":"https://api.github.com/users/Mugen87/events{/privacy}","received_events_url":"https://api.github.com/users/Mugen87/received_events","type":"User","site_admin":false},"created_at":"2018-06-16T17:10:17Z","updated_at":"2018-06-16T17:10:17Z","author_association":"COLLABORATOR","body":"Yeah, the video element is something special since we don't want to wait until the entire resource is downloaded. Since it's a stream, it's necessary to work with different events like `loadeddata`, `canplay` or `canplaythrough`. The problem is that it seems inconsistent if these events trigger an `onLoad()` callback. `onLoad()` in three.js is always used when the given resource is entirely loaded. So maybe we need a different nomenclature for such a loader."}}
{"actor":{"display_login":"Mugen87"}}