{"action":"created","comment":{"url":"https://api.github.com/repos/espressomd/espresso/pulls/comments/204903927","pull_request_review_id":140067603,"id":204903927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDkwMzkyNw==","diff_hunk":"@@ -78,13 +76,15 @@ def test_mass_momentum_thermostat(self):\n             self.system.part[i].v = [0.0, 0.0, 0.0]\n         self.system.thermostat.turn_off()\n \n-        self.lbf = lb.LBFluid(\n+        self.lbf = self.lb_class(\n             visc=self.params['viscosity'],\n             dens=self.params['dens'],\n             agrid=self.params['agrid'],\n             tau=self.system.time_step,\n             fric=self.params['friction'], ext_force_density=[0, 0, 0])\n+        print(\"0\",self.system.analysis.analyze_linear_momentum())","path":"testsuite/lb_common.py","position":50,"original_position":50,"commit_id":"2018a0d7ca556f5f90ea7eae04a2295d1238218c","original_commit_id":"2018a0d7ca556f5f90ea7eae04a2295d1238218c","user":{"login":"KaiSzuttor","id":2150555,"node_id":"MDQ6VXNlcjIxNTA1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/2150555?v=4","gravatar_id":"","url":"https://api.github.com/users/KaiSzuttor","html_url":"https://github.com/KaiSzuttor","followers_url":"https://api.github.com/users/KaiSzuttor/followers","following_url":"https://api.github.com/users/KaiSzuttor/following{/other_user}","gists_url":"https://api.github.com/users/KaiSzuttor/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiSzuttor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiSzuttor/subscriptions","organizations_url":"https://api.github.com/users/KaiSzuttor/orgs","repos_url":"https://api.github.com/users/KaiSzuttor/repos","events_url":"https://api.github.com/users/KaiSzuttor/events{/privacy}","received_events_url":"https://api.github.com/users/KaiSzuttor/received_events","type":"User","site_admin":false},"body":"please remove print statements","created_at":"2018-07-24T20:42:21Z","updated_at":"2018-07-24T20:45:37Z","html_url":"https://github.com/espressomd/espresso/pull/2074#discussion_r204903927","pull_request_url":"https://api.github.com/repos/espressomd/espresso/pulls/2074","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/comments/204903927"},"html":{"href":"https://github.com/espressomd/espresso/pull/2074#discussion_r204903927"},"pull_request":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/2074"}}},"pull_request":{"url":"https://api.github.com/repos/espressomd/espresso/pulls/2074","id":203579504,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTc5NTA0","html_url":"https://github.com/espressomd/espresso/pull/2074","diff_url":"https://github.com/espressomd/espresso/pull/2074.diff","patch_url":"https://github.com/espressomd/espresso/pull/2074.patch","issue_url":"https://api.github.com/repos/espressomd/espresso/issues/2074","number":2074,"state":"open","locked":false,"title":"Lb test merge and fixes","user":{"login":"RudolfWeeber","id":440745,"node_id":"MDQ6VXNlcjQ0MDc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/440745?v=4","gravatar_id":"","url":"https://api.github.com/users/RudolfWeeber","html_url":"https://github.com/RudolfWeeber","followers_url":"https://api.github.com/users/RudolfWeeber/followers","following_url":"https://api.github.com/users/RudolfWeeber/following{/other_user}","gists_url":"https://api.github.com/users/RudolfWeeber/gists{/gist_id}","starred_url":"https://api.github.com/users/RudolfWeeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RudolfWeeber/subscriptions","organizations_url":"https://api.github.com/users/RudolfWeeber/orgs","repos_url":"https://api.github.com/users/RudolfWeeber/repos","events_url":"https://api.github.com/users/RudolfWeeber/events{/privacy}","received_events_url":"https://api.github.com/users/RudolfWeeber/received_events","type":"User","site_admin":false},"body":"This merges the lb.py and lb_gpu.py test cases into lb_comon.py.\r\nlb_cpu and lb_gpu tests only specify the lb class to use and the precision.\r\n\r\ncore fixes:\r\n* cuda_common: Prevent double frees\r\n* lb fields resetting: Changing lb parameters or initializing now results in a reset lb fluid. Before that, something halfway happened.\r\n\r\n* Fix double ext_force_density application in 1st time step\r\n\r\n@KaiSzuttor, could you take a look at this?","created_at":"2018-07-24T16:07:06Z","updated_at":"2018-07-24T20:45:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dca6ad90bb07e6f1a892bd72d1893575274a0a7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/espressomd/espresso/pulls/2074/commits","review_comments_url":"https://api.github.com/repos/espressomd/espresso/pulls/2074/comments","review_comment_url":"https://api.github.com/repos/espressomd/espresso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espressomd/espresso/issues/2074/comments","statuses_url":"https://api.github.com/repos/espressomd/espresso/statuses/2018a0d7ca556f5f90ea7eae04a2295d1238218c","head":{"label":"RudolfWeeber:lb_test_merge_and_fix","ref":"lb_test_merge_and_fix","sha":"2018a0d7ca556f5f90ea7eae04a2295d1238218c","user":{"login":"RudolfWeeber","id":440745,"node_id":"MDQ6VXNlcjQ0MDc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/440745?v=4","gravatar_id":"","url":"https://api.github.com/users/RudolfWeeber","html_url":"https://github.com/RudolfWeeber","followers_url":"https://api.github.com/users/RudolfWeeber/followers","following_url":"https://api.github.com/users/RudolfWeeber/following{/other_user}","gists_url":"https://api.github.com/users/RudolfWeeber/gists{/gist_id}","starred_url":"https://api.github.com/users/RudolfWeeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RudolfWeeber/subscriptions","organizations_url":"https://api.github.com/users/RudolfWeeber/orgs","repos_url":"https://api.github.com/users/RudolfWeeber/repos","events_url":"https://api.github.com/users/RudolfWeeber/events{/privacy}","received_events_url":"https://api.github.com/users/RudolfWeeber/received_events","type":"User","site_admin":false},"repo":{"id":36076985,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA3Njk4NQ==","name":"espresso","full_name":"RudolfWeeber/espresso","owner":{"login":"RudolfWeeber","id":440745,"node_id":"MDQ6VXNlcjQ0MDc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/440745?v=4","gravatar_id":"","url":"https://api.github.com/users/RudolfWeeber","html_url":"https://github.com/RudolfWeeber","followers_url":"https://api.github.com/users/RudolfWeeber/followers","following_url":"https://api.github.com/users/RudolfWeeber/following{/other_user}","gists_url":"https://api.github.com/users/RudolfWeeber/gists{/gist_id}","starred_url":"https://api.github.com/users/RudolfWeeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RudolfWeeber/subscriptions","organizations_url":"https://api.github.com/users/RudolfWeeber/orgs","repos_url":"https://api.github.com/users/RudolfWeeber/repos","events_url":"https://api.github.com/users/RudolfWeeber/events{/privacy}","received_events_url":"https://api.github.com/users/RudolfWeeber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RudolfWeeber/espresso","description":"The ESPResSo package","fork":true,"url":"https://api.github.com/repos/RudolfWeeber/espresso","forks_url":"https://api.github.com/repos/RudolfWeeber/espresso/forks","keys_url":"https://api.github.com/repos/RudolfWeeber/espresso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RudolfWeeber/espresso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RudolfWeeber/espresso/teams","hooks_url":"https://api.github.com/repos/RudolfWeeber/espresso/hooks","issue_events_url":"https://api.github.com/repos/RudolfWeeber/espresso/issues/events{/number}","events_url":"https://api.github.com/repos/RudolfWeeber/espresso/events","assignees_url":"https://api.github.com/repos/RudolfWeeber/espresso/assignees{/user}","branches_url":"https://api.github.com/repos/RudolfWeeber/espresso/branches{/branch}","tags_url":"https://api.github.com/repos/RudolfWeeber/espresso/tags","blobs_url":"https://api.github.com/repos/RudolfWeeber/espresso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RudolfWeeber/espresso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RudolfWeeber/espresso/git/refs{/sha}","trees_url":"https://api.github.com/repos/RudolfWeeber/espresso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RudolfWeeber/espresso/statuses/{sha}","languages_url":"https://api.github.com/repos/RudolfWeeber/espresso/languages","stargazers_url":"https://api.github.com/repos/RudolfWeeber/espresso/stargazers","contributors_url":"https://api.github.com/repos/RudolfWeeber/espresso/contributors","subscribers_url":"https://api.github.com/repos/RudolfWeeber/espresso/subscribers","subscription_url":"https://api.github.com/repos/RudolfWeeber/espresso/subscription","commits_url":"https://api.github.com/repos/RudolfWeeber/espresso/commits{/sha}","git_commits_url":"https://api.github.com/repos/RudolfWeeber/espresso/git/commits{/sha}","comments_url":"https://api.github.com/repos/RudolfWeeber/espresso/comments{/number}","issue_comment_url":"https://api.github.com/repos/RudolfWeeber/espresso/issues/comments{/number}","contents_url":"https://api.github.com/repos/RudolfWeeber/espresso/contents/{+path}","compare_url":"https://api.github.com/repos/RudolfWeeber/espresso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RudolfWeeber/espresso/merges","archive_url":"https://api.github.com/repos/RudolfWeeber/espresso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RudolfWeeber/espresso/downloads","issues_url":"https://api.github.com/repos/RudolfWeeber/espresso/issues{/number}","pulls_url":"https://api.github.com/repos/RudolfWeeber/espresso/pulls{/number}","milestones_url":"https://api.github.com/repos/RudolfWeeber/espresso/milestones{/number}","notifications_url":"https://api.github.com/repos/RudolfWeeber/espresso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RudolfWeeber/espresso/labels{/name}","releases_url":"https://api.github.com/repos/RudolfWeeber/espresso/releases{/id}","deployments_url":"https://api.github.com/repos/RudolfWeeber/espresso/deployments","created_at":"2015-05-22T14:37:33Z","updated_at":"2017-08-07T07:47:34Z","pushed_at":"2018-07-24T19:42:23Z","git_url":"git://github.com/RudolfWeeber/espresso.git","ssh_url":"git@github.com:RudolfWeeber/espresso.git","clone_url":"https://github.com/RudolfWeeber/espresso.git","svn_url":"https://github.com/RudolfWeeber/espresso","homepage":"http://espressomd.org","size":103794,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"espressomd:python","ref":"python","sha":"24e5ee56e4891e4cd8fd2f45f03d05a91a69006b","user":{"login":"espressomd","id":689837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4OTgzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/689837?v=4","gravatar_id":"","url":"https://api.github.com/users/espressomd","html_url":"https://github.com/espressomd","followers_url":"https://api.github.com/users/espressomd/followers","following_url":"https://api.github.com/users/espressomd/following{/other_user}","gists_url":"https://api.github.com/users/espressomd/gists{/gist_id}","starred_url":"https://api.github.com/users/espressomd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressomd/subscriptions","organizations_url":"https://api.github.com/users/espressomd/orgs","repos_url":"https://api.github.com/users/espressomd/repos","events_url":"https://api.github.com/users/espressomd/events{/privacy}","received_events_url":"https://api.github.com/users/espressomd/received_events","type":"Organization","site_admin":false},"repo":{"id":1524644,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0NjQ0","name":"espresso","full_name":"espressomd/espresso","owner":{"login":"espressomd","id":689837,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4OTgzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/689837?v=4","gravatar_id":"","url":"https://api.github.com/users/espressomd","html_url":"https://github.com/espressomd","followers_url":"https://api.github.com/users/espressomd/followers","following_url":"https://api.github.com/users/espressomd/following{/other_user}","gists_url":"https://api.github.com/users/espressomd/gists{/gist_id}","starred_url":"https://api.github.com/users/espressomd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressomd/subscriptions","organizations_url":"https://api.github.com/users/espressomd/orgs","repos_url":"https://api.github.com/users/espressomd/repos","events_url":"https://api.github.com/users/espressomd/events{/privacy}","received_events_url":"https://api.github.com/users/espressomd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/espressomd/espresso","description":"The ESPResSo package","fork":false,"url":"https://api.github.com/repos/espressomd/espresso","forks_url":"https://api.github.com/repos/espressomd/espresso/forks","keys_url":"https://api.github.com/repos/espressomd/espresso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espressomd/espresso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espressomd/espresso/teams","hooks_url":"https://api.github.com/repos/espressomd/espresso/hooks","issue_events_url":"https://api.github.com/repos/espressomd/espresso/issues/events{/number}","events_url":"https://api.github.com/repos/espressomd/espresso/events","assignees_url":"https://api.github.com/repos/espressomd/espresso/assignees{/user}","branches_url":"https://api.github.com/repos/espressomd/espresso/branches{/branch}","tags_url":"https://api.github.com/repos/espressomd/espresso/tags","blobs_url":"https://api.github.com/repos/espressomd/espresso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espressomd/espresso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espressomd/espresso/git/refs{/sha}","trees_url":"https://api.github.com/repos/espressomd/espresso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espressomd/espresso/statuses/{sha}","languages_url":"https://api.github.com/repos/espressomd/espresso/languages","stargazers_url":"https://api.github.com/repos/espressomd/espresso/stargazers","contributors_url":"https://api.github.com/repos/espressomd/espresso/contributors","subscribers_url":"https://api.github.com/repos/espressomd/espresso/subscribers","subscription_url":"https://api.github.com/repos/espressomd/espresso/subscription","commits_url":"https://api.github.com/repos/espressomd/espresso/commits{/sha}","git_commits_url":"https://api.github.com/repos/espressomd/espresso/git/commits{/sha}","comments_url":"https://api.github.com/repos/espressomd/espresso/comments{/number}","issue_comment_url":"https://api.github.com/repos/espressomd/espresso/issues/comments{/number}","contents_url":"https://api.github.com/repos/espressomd/espresso/contents/{+path}","compare_url":"https://api.github.com/repos/espressomd/espresso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espressomd/espresso/merges","archive_url":"https://api.github.com/repos/espressomd/espresso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espressomd/espresso/downloads","issues_url":"https://api.github.com/repos/espressomd/espresso/issues{/number}","pulls_url":"https://api.github.com/repos/espressomd/espresso/pulls{/number}","milestones_url":"https://api.github.com/repos/espressomd/espresso/milestones{/number}","notifications_url":"https://api.github.com/repos/espressomd/espresso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espressomd/espresso/labels{/name}","releases_url":"https://api.github.com/repos/espressomd/espresso/releases{/id}","deployments_url":"https://api.github.com/repos/espressomd/espresso/deployments","created_at":"2011-03-25T07:43:15Z","updated_at":"2018-07-24T16:03:08Z","pushed_at":"2018-07-24T20:00:55Z","git_url":"git://github.com/espressomd/espresso.git","ssh_url":"git@github.com:espressomd/espresso.git","clone_url":"https://github.com/espressomd/espresso.git","svn_url":"https://github.com/espressomd/espresso","homepage":"http://espressomd.org","size":103516,"stargazers_count":74,"watchers_count":74,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":115,"open_issues":137,"watchers":74,"default_branch":"python"}},"_links":{"self":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/2074"},"html":{"href":"https://github.com/espressomd/espresso/pull/2074"},"issue":{"href":"https://api.github.com/repos/espressomd/espresso/issues/2074"},"comments":{"href":"https://api.github.com/repos/espressomd/espresso/issues/2074/comments"},"review_comments":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/2074/comments"},"review_comment":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espressomd/espresso/pulls/2074/commits"},"statuses":{"href":"https://api.github.com/repos/espressomd/espresso/statuses/2018a0d7ca556f5f90ea7eae04a2295d1238218c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KaiSzuttor"}}