{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/7521","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/7521/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/7521/comments","events_url":"https://api.github.com/repos/coq/coq/issues/7521/events","html_url":"https://github.com/coq/coq/pull/7521","id":323408592,"number":7521,"title":"Fix soundness bug with VM/native and cofixpoints","user":{"login":"maximedenes","id":647105,"avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"labels":[{"id":485985650,"url":"https://api.github.com/repos/coq/coq/labels/kind:%20fix","name":"kind: fix","color":"d93f0b","default":false},{"id":723364268,"url":"https://api.github.com/repos/coq/coq/labels/part:%20kernel","name":"part: kernel","color":"dddddd","default":false}],"state":"closed","locked":false,"assignee":{"login":"ppedrot","id":1202327,"avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false},"assignees":[{"login":"ppedrot","id":1202327,"avatar_url":"https://avatars1.githubusercontent.com/u/1202327?v=4","gravatar_id":"","url":"https://api.github.com/users/ppedrot","html_url":"https://github.com/ppedrot","followers_url":"https://api.github.com/users/ppedrot/followers","following_url":"https://api.github.com/users/ppedrot/following{/other_user}","gists_url":"https://api.github.com/users/ppedrot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppedrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppedrot/subscriptions","organizations_url":"https://api.github.com/users/ppedrot/orgs","repos_url":"https://api.github.com/users/ppedrot/repos","events_url":"https://api.github.com/users/ppedrot/events{/privacy}","received_events_url":"https://api.github.com/users/ppedrot/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/7","html_url":"https://github.com/coq/coq/milestone/7","labels_url":"https://api.github.com/repos/coq/coq/milestones/7/labels","id":2647743,"number":7,"title":"8.9+beta1","description":"The date of the feature freeze has not been announced yet.","creator":{"login":"Zimmi48","id":1108325,"avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"open_issues":124,"closed_issues":154,"state":"open","created_at":"2017-07-18T15:03:25Z","updated_at":"2018-05-28T18:12:46Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2018-05-15T22:41:05Z","updated_at":"2018-05-29T06:31:21Z","closed_at":"2018-05-28T18:12:46Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/7521","html_url":"https://github.com/coq/coq/pull/7521","diff_url":"https://github.com/coq/coq/pull/7521.diff","patch_url":"https://github.com/coq/coq/pull/7521.patch"},"body":"This fix includes a nice cleanup in the kernel, removing a hook and unifying `pre_env` and `env`. The cleanup makes the fix convenient because the bytecode and native compilers can then access standard reduction functions. In particular, we eta-expand cofixpoints when required, to fix the soundness bug.\r\n\r\nI'm not sure if this qualifies for backporting, though. Let's see what CI says.\r\n\r\nThis is still work in progress, it is missing a `CHANGES` entry and some test cases.\r\n\r\n<!-- If this is a bug fix, make sure the bug was reported beforehand. -->\r\nFixes / closes #7333\r\n\r\n\r\n<!-- If this is a feature pull request / breaks compatibility: -->\r\n<!-- (Otherwise, remove these lines.) -->\r\n- [ ] Corresponding documentation was added / updated.\r\n- [x] Entry added in CHANGES.\r\n"},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/392666940","html_url":"https://github.com/coq/coq/pull/7521#issuecomment-392666940","issue_url":"https://api.github.com/repos/coq/coq/issues/7521","id":392666940,"user":{"login":"Zimmi48","id":1108325,"avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T06:31:21Z","updated_at":"2018-05-29T06:31:21Z","author_association":"CONTRIBUTOR","body":"How come this PR did not add any tests? Sorry for not noticing earlier."}}
{"actor":{"display_login":"Zimmi48"}}