{"action":"created","comment":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments/243774680","pull_request_review_id":187631582,"id":243774680,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc3NDY4MA==","diff_hunk":"@@ -68,31 +74,75 @@ class WXDLLIMPEXP_CORE wxTextValidator: public wxValidator\n \n     wxTextEntry *GetTextEntry();\n \n+    // strings & chars inclusions:\n+    // ---------------------------\n+\n     void SetCharIncludes(const wxString& chars);\n+    void AddCharIncludes(const wxString& chars);\n+\n     void SetIncludes(const wxArrayString& includes) { m_includes = includes; }\n-    inline wxArrayString& GetIncludes() { return m_includes; }\n+    void AddInclude(const wxString& include)\n+    {\n+        if ( !include.empty() )\n+            m_includes.Add(include);","path":"include/wx/valtext.h","position":32,"original_position":32,"commit_id":"300c49bac71108f670e75bd8eda5b13883faade9","original_commit_id":"300c49bac71108f670e75bd8eda5b13883faade9","user":{"login":"vadz","id":146917,"node_id":"MDQ6VXNlcjE0NjkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/146917?v=4","gravatar_id":"","url":"https://api.github.com/users/vadz","html_url":"https://github.com/vadz","followers_url":"https://api.github.com/users/vadz/followers","following_url":"https://api.github.com/users/vadz/following{/other_user}","gists_url":"https://api.github.com/users/vadz/gists{/gist_id}","starred_url":"https://api.github.com/users/vadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadz/subscriptions","organizations_url":"https://api.github.com/users/vadz/orgs","repos_url":"https://api.github.com/users/vadz/repos","events_url":"https://api.github.com/users/vadz/events{/privacy}","received_events_url":"https://api.github.com/users/vadz/received_events","type":"User","site_admin":false},"body":"Please prefer using std-like methods in the new code, i.e. `push_back()` instead of `Add()`.","created_at":"2018-12-23T20:14:05Z","updated_at":"2018-12-23T20:37:25Z","html_url":"https://github.com/wxWidgets/wxWidgets/pull/1093#discussion_r243774680","pull_request_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1093","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments/243774680"},"html":{"href":"https://github.com/wxWidgets/wxWidgets/pull/1093#discussion_r243774680"},"pull_request":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1093"}}},"pull_request":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1093","id":240140466,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMTQwNDY2","html_url":"https://github.com/wxWidgets/wxWidgets/pull/1093","diff_url":"https://github.com/wxWidgets/wxWidgets/pull/1093.diff","patch_url":"https://github.com/wxWidgets/wxWidgets/pull/1093.patch","issue_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1093","number":1093,"state":"open","locked":false,"title":"wxTextValidator improvements","user":{"login":"AliKet","id":7704771,"node_id":"MDQ6VXNlcjc3MDQ3NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7704771?v=4","gravatar_id":"","url":"https://api.github.com/users/AliKet","html_url":"https://github.com/AliKet","followers_url":"https://api.github.com/users/AliKet/followers","following_url":"https://api.github.com/users/AliKet/following{/other_user}","gists_url":"https://api.github.com/users/AliKet/gists{/gist_id}","starred_url":"https://api.github.com/users/AliKet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliKet/subscriptions","organizations_url":"https://api.github.com/users/AliKet/orgs","repos_url":"https://api.github.com/users/AliKet/repos","events_url":"https://api.github.com/users/AliKet/events{/privacy}","received_events_url":"https://api.github.com/users/AliKet/received_events","type":"User","site_admin":false},"body":"To ease the process of review, i created this PR from [this](https://github.com/wxWidgets/wxWidgets/pull/749) without `wxRegexTextValidator` (which will be added later).\r\n\r\nHere is the global picture...\r\n\r\n### Incompatible changes:\r\n\r\n- `GetIncludes()` and `GetExcludes()` need to preserve invariants so now they return **immutable** `wxArrayString`.\r\n(please use the public interface instead: `SetIncludes()`/`SetExcludes()`/`AddInclude()`/`AddExclude()`)\r\n\r\n- Add `m_charIncludes` and `m_charExcludes` as using the same data member for two different things (chars and strings) was a bad idea (i.e. complicates the design without much benefit. but worst, it prevented us from creating some useful validators!)\r\n\r\n### Other changes:\r\n\r\n- Add `wxFILTER_XDIGITS` and `wxFILTER_SPACE` styles\r\n\r\n### Good news:\r\n\r\nNow you can freely combine between different `wxFILTER_XXX` when creating this type of validator","created_at":"2018-12-20T11:36:50Z","updated_at":"2018-12-23T20:37:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee7d93f742a2004718b32abb18ddc8169491b33b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":198449061,"node_id":"MDU6TGFiZWwxOTg0NDkwNjE=","url":"https://api.github.com/repos/wxWidgets/wxWidgets/labels/work%20needed","name":"work needed","color":"f7c6c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1093/commits","review_comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1093/comments","review_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1093/comments","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/300c49bac71108f670e75bd8eda5b13883faade9","head":{"label":"AliKet:txt_val","ref":"txt_val","sha":"300c49bac71108f670e75bd8eda5b13883faade9","user":{"login":"AliKet","id":7704771,"node_id":"MDQ6VXNlcjc3MDQ3NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7704771?v=4","gravatar_id":"","url":"https://api.github.com/users/AliKet","html_url":"https://github.com/AliKet","followers_url":"https://api.github.com/users/AliKet/followers","following_url":"https://api.github.com/users/AliKet/following{/other_user}","gists_url":"https://api.github.com/users/AliKet/gists{/gist_id}","starred_url":"https://api.github.com/users/AliKet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliKet/subscriptions","organizations_url":"https://api.github.com/users/AliKet/orgs","repos_url":"https://api.github.com/users/AliKet/repos","events_url":"https://api.github.com/users/AliKet/events{/privacy}","received_events_url":"https://api.github.com/users/AliKet/received_events","type":"User","site_admin":false},"repo":{"id":121492653,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0OTI2NTM=","name":"wxWidgets","full_name":"AliKet/wxWidgets","private":false,"owner":{"login":"AliKet","id":7704771,"node_id":"MDQ6VXNlcjc3MDQ3NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7704771?v=4","gravatar_id":"","url":"https://api.github.com/users/AliKet","html_url":"https://github.com/AliKet","followers_url":"https://api.github.com/users/AliKet/followers","following_url":"https://api.github.com/users/AliKet/following{/other_user}","gists_url":"https://api.github.com/users/AliKet/gists{/gist_id}","starred_url":"https://api.github.com/users/AliKet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliKet/subscriptions","organizations_url":"https://api.github.com/users/AliKet/orgs","repos_url":"https://api.github.com/users/AliKet/repos","events_url":"https://api.github.com/users/AliKet/events{/privacy}","received_events_url":"https://api.github.com/users/AliKet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AliKet/wxWidgets","description":"Cross-Platform GUI Library - Report issues here: https://trac.wxwidgets.org/","fork":true,"url":"https://api.github.com/repos/AliKet/wxWidgets","forks_url":"https://api.github.com/repos/AliKet/wxWidgets/forks","keys_url":"https://api.github.com/repos/AliKet/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AliKet/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AliKet/wxWidgets/teams","hooks_url":"https://api.github.com/repos/AliKet/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/AliKet/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/AliKet/wxWidgets/events","assignees_url":"https://api.github.com/repos/AliKet/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/AliKet/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/AliKet/wxWidgets/tags","blobs_url":"https://api.github.com/repos/AliKet/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AliKet/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AliKet/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/AliKet/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AliKet/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/AliKet/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/AliKet/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/AliKet/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/AliKet/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/AliKet/wxWidgets/subscription","commits_url":"https://api.github.com/repos/AliKet/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/AliKet/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/AliKet/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/AliKet/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/AliKet/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/AliKet/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AliKet/wxWidgets/merges","archive_url":"https://api.github.com/repos/AliKet/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AliKet/wxWidgets/downloads","issues_url":"https://api.github.com/repos/AliKet/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/AliKet/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/AliKet/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/AliKet/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AliKet/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/AliKet/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/AliKet/wxWidgets/deployments","created_at":"2018-02-14T09:29:41Z","updated_at":"2018-06-08T01:38:58Z","pushed_at":"2018-12-22T21:09:48Z","git_url":"git://github.com/AliKet/wxWidgets.git","ssh_url":"git@github.com:AliKet/wxWidgets.git","clone_url":"https://github.com/AliKet/wxWidgets.git","svn_url":"https://github.com/AliKet/wxWidgets","homepage":"https://www.wxwidgets.org/","size":312467,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wxWidgets:master","ref":"master","sha":"c6d3b9c0b9d7f4837c675e1c0c6135d937f06b32","user":{"login":"wxWidgets","id":791023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/791023?v=4","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"repo":{"id":1764646,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY0NjQ2","name":"wxWidgets","full_name":"wxWidgets/wxWidgets","private":false,"owner":{"login":"wxWidgets","id":791023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/791023?v=4","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wxWidgets/wxWidgets","description":"Cross-Platform GUI Library - Report issues here: https://trac.wxwidgets.org/","fork":false,"url":"https://api.github.com/repos/wxWidgets/wxWidgets","forks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/forks","keys_url":"https://api.github.com/repos/wxWidgets/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wxWidgets/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wxWidgets/wxWidgets/teams","hooks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/events","assignees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/wxWidgets/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/tags","blobs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/wxWidgets/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscription","commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/wxWidgets/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wxWidgets/wxWidgets/merges","archive_url":"https://api.github.com/repos/wxWidgets/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wxWidgets/wxWidgets/downloads","issues_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/wxWidgets/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/wxWidgets/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wxWidgets/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/wxWidgets/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/deployments","created_at":"2011-05-18T05:54:03Z","updated_at":"2018-12-23T16:34:03Z","pushed_at":"2018-12-23T16:33:55Z","git_url":"git://github.com/wxWidgets/wxWidgets.git","ssh_url":"git@github.com:wxWidgets/wxWidgets.git","clone_url":"https://github.com/wxWidgets/wxWidgets.git","svn_url":"https://github.com/wxWidgets/wxWidgets","homepage":"https://www.wxwidgets.org/","size":313136,"stargazers_count":2235,"watchers_count":2235,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":841,"mirror_url":null,"archived":false,"open_issues_count":36,"license":null,"forks":841,"open_issues":36,"watchers":2235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1093"},"html":{"href":"https://github.com/wxWidgets/wxWidgets/pull/1093"},"issue":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1093"},"comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1093/comments"},"review_comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1093/comments"},"review_comment":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1093/commits"},"statuses":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/300c49bac71108f670e75bd8eda5b13883faade9"}},"author_association":"NONE"}}
{"actor":{"display_login":"vadz"}}