{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/194567817","pull_request_review_id":127718434,"id":194567817,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDU2NzgxNw==","diff_hunk":"@@ -75,6 +75,11 @@ func NewPublicFilterAPI(backend Backend, lightMode bool) *PublicFilterAPI {\n \treturn api\n }\n \n+// EventSystem returns\n+func (filter *PublicFilterAPI) EventSystem() *EventSystem {","path":"eth/filters/api.go","position":5,"original_position":5,"commit_id":"6cc26d7b1dee8e711e596740fd96ecb72be1c9b4","original_commit_id":"6cc26d7b1dee8e711e596740fd96ecb72be1c9b4","user":{"login":"zsfelfoldi","id":9884311,"node_id":"MDQ6VXNlcjk4ODQzMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9884311?v=4","gravatar_id":"","url":"https://api.github.com/users/zsfelfoldi","html_url":"https://github.com/zsfelfoldi","followers_url":"https://api.github.com/users/zsfelfoldi/followers","following_url":"https://api.github.com/users/zsfelfoldi/following{/other_user}","gists_url":"https://api.github.com/users/zsfelfoldi/gists{/gist_id}","starred_url":"https://api.github.com/users/zsfelfoldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsfelfoldi/subscriptions","organizations_url":"https://api.github.com/users/zsfelfoldi/orgs","repos_url":"https://api.github.com/users/zsfelfoldi/repos","events_url":"https://api.github.com/users/zsfelfoldi/events{/privacy}","received_events_url":"https://api.github.com/users/zsfelfoldi/received_events","type":"User","site_admin":false},"body":"This is unnecessary and also definitely wrong; you cannot expose internal structures like the event system through the API.","created_at":"2018-06-11T22:31:37Z","updated_at":"2018-06-11T22:35:14Z","html_url":"https://github.com/ethereum/go-ethereum/pull/16842#discussion_r194567817","pull_request_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16842","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/194567817"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/16842#discussion_r194567817"},"pull_request":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16842"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16842","id":191349731,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMzQ5NzMx","html_url":"https://github.com/ethereum/go-ethereum/pull/16842","diff_url":"https://github.com/ethereum/go-ethereum/pull/16842.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/16842.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/16842","number":16842,"state":"open","locked":false,"title":"contracts: add checkpoint registrar smart contract","user":{"login":"rjl493456442","id":5959481,"node_id":"MDQ6VXNlcjU5NTk0ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/5959481?v=4","gravatar_id":"","url":"https://api.github.com/users/rjl493456442","html_url":"https://github.com/rjl493456442","followers_url":"https://api.github.com/users/rjl493456442/followers","following_url":"https://api.github.com/users/rjl493456442/following{/other_user}","gists_url":"https://api.github.com/users/rjl493456442/gists{/gist_id}","starred_url":"https://api.github.com/users/rjl493456442/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjl493456442/subscriptions","organizations_url":"https://api.github.com/users/rjl493456442/orgs","repos_url":"https://api.github.com/users/rjl493456442/repos","events_url":"https://api.github.com/users/rjl493456442/events{/privacy}","received_events_url":"https://api.github.com/users/rjl493456442/received_events","type":"User","site_admin":false},"body":"In this PR, i introduce a new system contract `Checkpoint registrar` to get rid of hard coding checkpoint information.\r\n\r\nThe idea is that the people be trusted(maybe from the foundation) can register latest checkpoint information into the contract. And in the mean time, the les server can watch the `NewCheckpoint` event. If the checkpoint generated in local is `hashEqual` with the hash included in the event, and the checkpoint is stable enough(8192 blocks has been built top on this), so the les server can regard this as a `stable checkpoint`.\r\n\r\nThe stable checkpoint can be used in the `trust less syncing` we will implement in the future.\r\n\r\nNow i have deployed a test contract on the rinkeby, all tests are based on the rinkeby testnet.\r\n\r\n---\r\n\r\nBesides, this PR introduces two relative API exposed by les server:\r\n\r\n- LatestCheckpoint\r\n- GetCheckpoint\r\nSo that we can obtain the checkpoint from the les server easily.\r\n","created_at":"2018-05-30T06:51:34Z","updated_at":"2018-06-11T22:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45c44c28cd1bc7acf79d1199dba64c2cb76dfac8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"karalabe","id":129561,"node_id":"MDQ6VXNlcjEyOTU2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/129561?v=4","gravatar_id":"","url":"https://api.github.com/users/karalabe","html_url":"https://github.com/karalabe","followers_url":"https://api.github.com/users/karalabe/followers","following_url":"https://api.github.com/users/karalabe/following{/other_user}","gists_url":"https://api.github.com/users/karalabe/gists{/gist_id}","starred_url":"https://api.github.com/users/karalabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karalabe/subscriptions","organizations_url":"https://api.github.com/users/karalabe/orgs","repos_url":"https://api.github.com/users/karalabe/repos","events_url":"https://api.github.com/users/karalabe/events{/privacy}","received_events_url":"https://api.github.com/users/karalabe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16842/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16842/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/16842/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/6cc26d7b1dee8e711e596740fd96ecb72be1c9b4","head":{"label":"rjl493456442:checkpoint_contract","ref":"checkpoint_contract","sha":"6cc26d7b1dee8e711e596740fd96ecb72be1c9b4","user":{"login":"rjl493456442","id":5959481,"node_id":"MDQ6VXNlcjU5NTk0ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/5959481?v=4","gravatar_id":"","url":"https://api.github.com/users/rjl493456442","html_url":"https://github.com/rjl493456442","followers_url":"https://api.github.com/users/rjl493456442/followers","following_url":"https://api.github.com/users/rjl493456442/following{/other_user}","gists_url":"https://api.github.com/users/rjl493456442/gists{/gist_id}","starred_url":"https://api.github.com/users/rjl493456442/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjl493456442/subscriptions","organizations_url":"https://api.github.com/users/rjl493456442/orgs","repos_url":"https://api.github.com/users/rjl493456442/repos","events_url":"https://api.github.com/users/rjl493456442/events{/privacy}","received_events_url":"https://api.github.com/users/rjl493456442/received_events","type":"User","site_admin":false},"repo":{"id":94566539,"node_id":"MDEwOlJlcG9zaXRvcnk5NDU2NjUzOQ==","name":"go-ethereum","full_name":"rjl493456442/go-ethereum","owner":{"login":"rjl493456442","id":5959481,"node_id":"MDQ6VXNlcjU5NTk0ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/5959481?v=4","gravatar_id":"","url":"https://api.github.com/users/rjl493456442","html_url":"https://github.com/rjl493456442","followers_url":"https://api.github.com/users/rjl493456442/followers","following_url":"https://api.github.com/users/rjl493456442/following{/other_user}","gists_url":"https://api.github.com/users/rjl493456442/gists{/gist_id}","starred_url":"https://api.github.com/users/rjl493456442/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjl493456442/subscriptions","organizations_url":"https://api.github.com/users/rjl493456442/orgs","repos_url":"https://api.github.com/users/rjl493456442/repos","events_url":"https://api.github.com/users/rjl493456442/events{/privacy}","received_events_url":"https://api.github.com/users/rjl493456442/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjl493456442/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":true,"url":"https://api.github.com/repos/rjl493456442/go-ethereum","forks_url":"https://api.github.com/repos/rjl493456442/go-ethereum/forks","keys_url":"https://api.github.com/repos/rjl493456442/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjl493456442/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjl493456442/go-ethereum/teams","hooks_url":"https://api.github.com/repos/rjl493456442/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/rjl493456442/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/rjl493456442/go-ethereum/events","assignees_url":"https://api.github.com/repos/rjl493456442/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/rjl493456442/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/rjl493456442/go-ethereum/tags","blobs_url":"https://api.github.com/repos/rjl493456442/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjl493456442/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjl493456442/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjl493456442/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjl493456442/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/rjl493456442/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/rjl493456442/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/rjl493456442/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/rjl493456442/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/rjl493456442/go-ethereum/subscription","commits_url":"https://api.github.com/repos/rjl493456442/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjl493456442/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjl493456442/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjl493456442/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjl493456442/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/rjl493456442/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjl493456442/go-ethereum/merges","archive_url":"https://api.github.com/repos/rjl493456442/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjl493456442/go-ethereum/downloads","issues_url":"https://api.github.com/repos/rjl493456442/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/rjl493456442/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/rjl493456442/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/rjl493456442/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjl493456442/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/rjl493456442/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/rjl493456442/go-ethereum/deployments","created_at":"2017-06-16T17:25:11Z","updated_at":"2017-06-16T17:25:20Z","pushed_at":"2018-06-11T13:08:41Z","git_url":"git://github.com/rjl493456442/go-ethereum.git","ssh_url":"git@github.com:rjl493456442/go-ethereum.git","clone_url":"https://github.com/rjl493456442/go-ethereum.git","svn_url":"https://github.com/rjl493456442/go-ethereum","homepage":"https://geth.ethereum.org","size":98859,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"13af27641829f61d1e6b383e37aab6caae22f2c1","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MjkxOQ==","name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2018-06-11T18:31:40Z","pushed_at":"2018-06-11T22:10:13Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"https://geth.ethereum.org","size":98543,"stargazers_count":18473,"watchers_count":18473,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5969,"mirror_url":null,"archived":false,"open_issues_count":826,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":5969,"open_issues":826,"watchers":18473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16842"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/16842"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/16842"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/16842/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16842/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/16842/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/6cc26d7b1dee8e711e596740fd96ecb72be1c9b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zsfelfoldi"}}