{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments/198622145","pull_request_review_id":132585757,"id":198622145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODYyMjE0NQ==","diff_hunk":"@@ -193,15 +193,13 @@ void D3D12RaytracingHelloWorld::CreateLocalRootSignatureSubobjects(CD3D12_STATE_\n         rootSignatureAssociation->AddExport(c_raygenShaderName);\n     }\n #if USE_NON_NULL_LOCAL_ROOT_SIG \n-    // Empty local root signature to be used in a miss shader and a hit group.\n+    // Empty local root signature is set as the default shader association.","path":"Samples/Desktop/D3D12Raytracing/src/D3D12RaytracingHelloWorld/D3D12RaytracingHelloWorld.cpp","position":5,"original_position":5,"commit_id":"620cfa55f7bc6b132489cdf19525f4754f403229","original_commit_id":"80a68e62c44cd24e190224d499e529c71b396466","user":{"login":"pkristof","id":25936161,"node_id":"MDQ6VXNlcjI1OTM2MTYx","avatar_url":"https://avatars0.githubusercontent.com/u/25936161?v=4","gravatar_id":"","url":"https://api.github.com/users/pkristof","html_url":"https://github.com/pkristof","followers_url":"https://api.github.com/users/pkristof/followers","following_url":"https://api.github.com/users/pkristof/following{/other_user}","gists_url":"https://api.github.com/users/pkristof/gists{/gist_id}","starred_url":"https://api.github.com/users/pkristof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkristof/subscriptions","organizations_url":"https://api.github.com/users/pkristof/orgs","repos_url":"https://api.github.com/users/pkristof/repos","events_url":"https://api.github.com/users/pkristof/events{/privacy}","received_events_url":"https://api.github.com/users/pkristof/received_events","type":"User","site_admin":false},"body":"And please add: \r\n    // In this sample, this could be omitted for convenience and use the default shader association instead, since <why>.","created_at":"2018-06-27T19:59:59Z","updated_at":"2018-06-27T19:59:59Z","html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/410#discussion_r198622145","pull_request_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/410","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments/198622145"},"html":{"href":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/410#discussion_r198622145"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/410"}},"in_reply_to_id":198618717},"pull_request":{"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/410","id":197813738,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODEzNzM4","html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/410","diff_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/410.diff","patch_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/410.patch","issue_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/410","number":410,"state":"open","locked":false,"title":"Porting the rest of the samples to use the RS5 style fallback layer interface and removing explicit exports/shader associations in some samples","user":{"login":"wallisc","id":2508805,"node_id":"MDQ6VXNlcjI1MDg4MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2508805?v=4","gravatar_id":"","url":"https://api.github.com/users/wallisc","html_url":"https://github.com/wallisc","followers_url":"https://api.github.com/users/wallisc/followers","following_url":"https://api.github.com/users/wallisc/following{/other_user}","gists_url":"https://api.github.com/users/wallisc/gists{/gist_id}","starred_url":"https://api.github.com/users/wallisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallisc/subscriptions","organizations_url":"https://api.github.com/users/wallisc/orgs","repos_url":"https://api.github.com/users/wallisc/repos","events_url":"https://api.github.com/users/wallisc/events{/privacy}","received_events_url":"https://api.github.com/users/wallisc/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-27T18:18:48Z","updated_at":"2018-06-27T19:59:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59370db1a51e4457d3ffe73a4930b14bacd5dbf0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/410/commits","review_comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/410/comments","review_comment_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/410/comments","statuses_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/620cfa55f7bc6b132489cdf19525f4754f403229","head":{"label":"Microsoft:develop-dxr-rs5-port","ref":"develop-dxr-rs5-port","sha":"620cfa55f7bc6b132489cdf19525f4754f403229","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36831874,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgzMTg3NA==","name":"DirectX-Graphics-Samples","full_name":"Microsoft/DirectX-Graphics-Samples","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","description":"This repo contains the DirectX Graphics samples that demonstrate how to build graphics intensive applications on Windows.","fork":false,"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples","forks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/forks","keys_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/teams","hooks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/events","assignees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/tags","blobs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/languages","stargazers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscription","commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/merges","archive_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/downloads","issues_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/deployments","created_at":"2015-06-03T21:34:47Z","updated_at":"2018-06-27T16:52:24Z","pushed_at":"2018-06-27T19:25:43Z","git_url":"git://github.com/Microsoft/DirectX-Graphics-Samples.git","ssh_url":"git@github.com:Microsoft/DirectX-Graphics-Samples.git","clone_url":"https://github.com/Microsoft/DirectX-Graphics-Samples.git","svn_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","homepage":null,"size":106136,"stargazers_count":1641,"watchers_count":1641,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":626,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":626,"open_issues":47,"watchers":1641,"default_branch":"master"}},"base":{"label":"Microsoft:develop-dxr-rs5","ref":"develop-dxr-rs5","sha":"5353c9797ceccbf9b1496e55793e88ee3153794f","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36831874,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgzMTg3NA==","name":"DirectX-Graphics-Samples","full_name":"Microsoft/DirectX-Graphics-Samples","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","description":"This repo contains the DirectX Graphics samples that demonstrate how to build graphics intensive applications on Windows.","fork":false,"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples","forks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/forks","keys_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/teams","hooks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/events","assignees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/tags","blobs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/languages","stargazers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscription","commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/merges","archive_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/downloads","issues_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/deployments","created_at":"2015-06-03T21:34:47Z","updated_at":"2018-06-27T16:52:24Z","pushed_at":"2018-06-27T19:25:43Z","git_url":"git://github.com/Microsoft/DirectX-Graphics-Samples.git","ssh_url":"git@github.com:Microsoft/DirectX-Graphics-Samples.git","clone_url":"https://github.com/Microsoft/DirectX-Graphics-Samples.git","svn_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","homepage":null,"size":106136,"stargazers_count":1641,"watchers_count":1641,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":626,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":626,"open_issues":47,"watchers":1641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/410"},"html":{"href":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/410"},"issue":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/410"},"comments":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/410/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/410/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/410/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/620cfa55f7bc6b132489cdf19525f4754f403229"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pkristof"}}