{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments/229137188","pull_request_review_id":169565237,"id":229137188,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTEzNzE4OA==","diff_hunk":"@@ -0,0 +1,121 @@\n+#!/bin/bash\n+\n+CONFIGURATION=$1\n+if [ -z $CONFIGURATION ]; then\n+  CONFIGURATION=Debug\n+fi\n+\n+PACKAGEVERSION=$2\n+if [ -z $PACKAGEVERSION ]; then\n+  PACKAGEVERSION=\"1.0.0.1\"\n+fi\n+\n+SCRIPTDIR=\"$(dirname ${BASH_SOURCE[0]})\"\n+\n+# convert to an absolute path because it is required by `dotnet publish`\n+pushd $SCRIPTDIR\n+SCRIPTDIR=\"$(pwd)\"\n+popd\n+\n+SRCDIR=$SCRIPTDIR/../..\n+ROOTDIR=$SRCDIR/..\n+BUILDOUTPUT=$ROOTDIR/BuildOutput\n+PUBLISHDIR=$ROOTDIR/Publish\n+INSTALLROOT=$ROOTDIR/InstallRoot\n+VFSFORGITDESTINATION=\"usr/local/vfsforgit\"\n+INSTALLERPACKAGENAME=\"VFSForGit.$PACKAGEVERSION\"\n+\n+echo \"SRCDIR: ${SRCDIR}\"\n+echo \"ROOTDIR: ${ROOTDIR}\"\n+echo \"BUILDOUTPUT: ${BUILDOUTPUT}\"\n+echo \"PUBLISHDIR: ${PUBLISHDIR}\"\n+\n+function CheckBuildIsAvailable()\n+{\n+\tif [ ! -d $BUILDOUTPUT ] || [ ! -d $PUBLISHDIR ]; then\n+  \t\techo \"Could not find VFSForGit Build to package.\"\n+  \t\texit 1\n+\tfi\n+}\n+\n+function SetPermissions()\n+{\n+\tchmodCommand=\"chmod -R 755 \\\"${INSTALLROOT}\\\"\"\n+\techo $chmodCommand\n+\teval $chmodCommand || exit 1\n+}\n+\n+function CreateInstallerRoot()","path":"Scripts/Mac/BuildInstaller.sh","position":48,"original_position":48,"commit_id":"69122987cc383bdd8869f2e016bab0942ab3108c","original_commit_id":"69122987cc383bdd8869f2e016bab0942ab3108c","user":{"login":"nickgra","id":40180167,"node_id":"MDQ6VXNlcjQwMTgwMTY3","avatar_url":"https://avatars0.githubusercontent.com/u/40180167?v=4","gravatar_id":"","url":"https://api.github.com/users/nickgra","html_url":"https://github.com/nickgra","followers_url":"https://api.github.com/users/nickgra/followers","following_url":"https://api.github.com/users/nickgra/following{/other_user}","gists_url":"https://api.github.com/users/nickgra/gists{/gist_id}","starred_url":"https://api.github.com/users/nickgra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickgra/subscriptions","organizations_url":"https://api.github.com/users/nickgra/orgs","repos_url":"https://api.github.com/users/nickgra/repos","events_url":"https://api.github.com/users/nickgra/events{/privacy}","received_events_url":"https://api.github.com/users/nickgra/received_events","type":"User","site_admin":false},"body":"We need to run this code as part of the installation of the package, not as part of the script that creates the package. You can pass pre/postinstall scripts to pkgbuild and they'll be added to the package and ran at the correct times.","created_at":"2018-10-29T23:49:51Z","updated_at":"2018-10-29T23:55:19Z","html_url":"https://github.com/Microsoft/VFSForGit/pull/438#discussion_r229137188","pull_request_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/438","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments/229137188"},"html":{"href":"https://github.com/Microsoft/VFSForGit/pull/438#discussion_r229137188"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/438","id":226724429,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzI0NDI5","html_url":"https://github.com/Microsoft/VFSForGit/pull/438","diff_url":"https://github.com/Microsoft/VFSForGit/pull/438.diff","patch_url":"https://github.com/Microsoft/VFSForGit/pull/438.patch","issue_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/438","number":438,"state":"open","locked":false,"title":"[WIP] Mac installer prototype","user":{"login":"alameenshah","id":378580,"node_id":"MDQ6VXNlcjM3ODU4MA==","avatar_url":"https://avatars2.githubusercontent.com/u/378580?v=4","gravatar_id":"","url":"https://api.github.com/users/alameenshah","html_url":"https://github.com/alameenshah","followers_url":"https://api.github.com/users/alameenshah/followers","following_url":"https://api.github.com/users/alameenshah/following{/other_user}","gists_url":"https://api.github.com/users/alameenshah/gists{/gist_id}","starred_url":"https://api.github.com/users/alameenshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alameenshah/subscriptions","organizations_url":"https://api.github.com/users/alameenshah/orgs","repos_url":"https://api.github.com/users/alameenshah/repos","events_url":"https://api.github.com/users/alameenshah/events{/privacy}","received_events_url":"https://api.github.com/users/alameenshah/received_events","type":"User","site_admin":false},"body":"### How to build installer\r\n1. Run Mac Build ```Scripts/Mac/BuildGVFSForMac.sh```\r\n2. Run Installer build ```Scripts/Mac/BuildInstaller.sh```\r\n\r\n### How to install\r\n1. ```BuildInstaller.sh``` would create a DMG (Disk Image) file at the Root directory. \r\n\r\n<img width=\"473\" alt=\"screen shot 2018-10-29 at 5 33 04 pm\" src=\"https://user-images.githubusercontent.com/378580/47681821-dcc5c900-dba0-11e8-83c4-85eb781184e6.png\">\r\n\r\n2. Double click on the DMG file to mount it.\r\n3. Open Terminal and run the following command to install. ```sudo installer -pkg /Volumes/VFSForGit.1.0.0.1/VFSForGit.1.0.0.1.pkg -target /```\r\n4. Double clicking on the installer package ```.pkg``` file would launch the GUI installer wizard.\r\n\r\n### Running GVFS\r\nInstaller copies all GVFS assemblies (both .Net Core and Native) to the directory ```/usr/local/vfsforgit```. It also installs ```/usr/local/bin/gvfs``` which is a link to ```/usr/local/vfsforgit/gvfs```. ```gvfs``` command should be visible in the Terminal. The ```ProjFS.kext``` has to be manually loaded before cloning a gvfs repository.\r\n\r\n### TODO\r\n1. Read installer version properly from the command line.\r\n2. Add License, Readme text.\r\n3. The script ```Scripts/Mac/BuildInstaller.sh``` prints all the commands and variables. I will remove after bug fixing.","created_at":"2018-10-29T21:46:59Z","updated_at":"2018-10-29T23:55:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fec58b17487648ddb6603d785913136d5e00d9c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/438/commits","review_comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/438/comments","review_comment_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/438/comments","statuses_url":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/69122987cc383bdd8869f2e016bab0942ab3108c","head":{"label":"alameenshah:mac_installer_prototype","ref":"mac_installer_prototype","sha":"69122987cc383bdd8869f2e016bab0942ab3108c","user":{"login":"alameenshah","id":378580,"node_id":"MDQ6VXNlcjM3ODU4MA==","avatar_url":"https://avatars2.githubusercontent.com/u/378580?v=4","gravatar_id":"","url":"https://api.github.com/users/alameenshah","html_url":"https://github.com/alameenshah","followers_url":"https://api.github.com/users/alameenshah/followers","following_url":"https://api.github.com/users/alameenshah/following{/other_user}","gists_url":"https://api.github.com/users/alameenshah/gists{/gist_id}","starred_url":"https://api.github.com/users/alameenshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alameenshah/subscriptions","organizations_url":"https://api.github.com/users/alameenshah/orgs","repos_url":"https://api.github.com/users/alameenshah/repos","events_url":"https://api.github.com/users/alameenshah/events{/privacy}","received_events_url":"https://api.github.com/users/alameenshah/received_events","type":"User","site_admin":false},"repo":{"id":146942500,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5NDI1MDA=","name":"VFSForGit","full_name":"alameenshah/VFSForGit","private":false,"owner":{"login":"alameenshah","id":378580,"node_id":"MDQ6VXNlcjM3ODU4MA==","avatar_url":"https://avatars2.githubusercontent.com/u/378580?v=4","gravatar_id":"","url":"https://api.github.com/users/alameenshah","html_url":"https://github.com/alameenshah","followers_url":"https://api.github.com/users/alameenshah/followers","following_url":"https://api.github.com/users/alameenshah/following{/other_user}","gists_url":"https://api.github.com/users/alameenshah/gists{/gist_id}","starred_url":"https://api.github.com/users/alameenshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alameenshah/subscriptions","organizations_url":"https://api.github.com/users/alameenshah/orgs","repos_url":"https://api.github.com/users/alameenshah/repos","events_url":"https://api.github.com/users/alameenshah/events{/privacy}","received_events_url":"https://api.github.com/users/alameenshah/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alameenshah/VFSForGit","description":"Virtual File System for Git: Enable Git at Enterprise Scale","fork":true,"url":"https://api.github.com/repos/alameenshah/VFSForGit","forks_url":"https://api.github.com/repos/alameenshah/VFSForGit/forks","keys_url":"https://api.github.com/repos/alameenshah/VFSForGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alameenshah/VFSForGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alameenshah/VFSForGit/teams","hooks_url":"https://api.github.com/repos/alameenshah/VFSForGit/hooks","issue_events_url":"https://api.github.com/repos/alameenshah/VFSForGit/issues/events{/number}","events_url":"https://api.github.com/repos/alameenshah/VFSForGit/events","assignees_url":"https://api.github.com/repos/alameenshah/VFSForGit/assignees{/user}","branches_url":"https://api.github.com/repos/alameenshah/VFSForGit/branches{/branch}","tags_url":"https://api.github.com/repos/alameenshah/VFSForGit/tags","blobs_url":"https://api.github.com/repos/alameenshah/VFSForGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alameenshah/VFSForGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alameenshah/VFSForGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alameenshah/VFSForGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alameenshah/VFSForGit/statuses/{sha}","languages_url":"https://api.github.com/repos/alameenshah/VFSForGit/languages","stargazers_url":"https://api.github.com/repos/alameenshah/VFSForGit/stargazers","contributors_url":"https://api.github.com/repos/alameenshah/VFSForGit/contributors","subscribers_url":"https://api.github.com/repos/alameenshah/VFSForGit/subscribers","subscription_url":"https://api.github.com/repos/alameenshah/VFSForGit/subscription","commits_url":"https://api.github.com/repos/alameenshah/VFSForGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alameenshah/VFSForGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alameenshah/VFSForGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alameenshah/VFSForGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alameenshah/VFSForGit/contents/{+path}","compare_url":"https://api.github.com/repos/alameenshah/VFSForGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alameenshah/VFSForGit/merges","archive_url":"https://api.github.com/repos/alameenshah/VFSForGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alameenshah/VFSForGit/downloads","issues_url":"https://api.github.com/repos/alameenshah/VFSForGit/issues{/number}","pulls_url":"https://api.github.com/repos/alameenshah/VFSForGit/pulls{/number}","milestones_url":"https://api.github.com/repos/alameenshah/VFSForGit/milestones{/number}","notifications_url":"https://api.github.com/repos/alameenshah/VFSForGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alameenshah/VFSForGit/labels{/name}","releases_url":"https://api.github.com/repos/alameenshah/VFSForGit/releases{/id}","deployments_url":"https://api.github.com/repos/alameenshah/VFSForGit/deployments","created_at":"2018-08-31T21:10:26Z","updated_at":"2018-10-29T19:32:05Z","pushed_at":"2018-10-29T19:35:25Z","git_url":"git://github.com/alameenshah/VFSForGit.git","ssh_url":"git@github.com:alameenshah/VFSForGit.git","clone_url":"https://github.com/alameenshah/VFSForGit.git","svn_url":"https://github.com/alameenshah/VFSForGit","homepage":"https://gvfs.io/","size":3405,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"85c5cb889d7ee70cf3bd1206e833bd59222e29db","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":80058269,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA1ODI2OQ==","name":"VFSForGit","full_name":"Microsoft/VFSForGit","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/VFSForGit","description":"Virtual File System for Git: Enable Git at Enterprise Scale","fork":false,"url":"https://api.github.com/repos/Microsoft/VFSForGit","forks_url":"https://api.github.com/repos/Microsoft/VFSForGit/forks","keys_url":"https://api.github.com/repos/Microsoft/VFSForGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/VFSForGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/VFSForGit/teams","hooks_url":"https://api.github.com/repos/Microsoft/VFSForGit/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/VFSForGit/events","assignees_url":"https://api.github.com/repos/Microsoft/VFSForGit/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/VFSForGit/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/VFSForGit/tags","blobs_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/VFSForGit/languages","stargazers_url":"https://api.github.com/repos/Microsoft/VFSForGit/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/VFSForGit/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/VFSForGit/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/VFSForGit/subscription","commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/VFSForGit/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/VFSForGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/VFSForGit/merges","archive_url":"https://api.github.com/repos/Microsoft/VFSForGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/VFSForGit/downloads","issues_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/VFSForGit/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/VFSForGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/VFSForGit/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/VFSForGit/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/VFSForGit/deployments","created_at":"2017-01-25T21:10:29Z","updated_at":"2018-10-29T23:44:15Z","pushed_at":"2018-10-29T23:44:12Z","git_url":"git://github.com/Microsoft/VFSForGit.git","ssh_url":"git@github.com:Microsoft/VFSForGit.git","clone_url":"https://github.com/Microsoft/VFSForGit.git","svn_url":"https://github.com/Microsoft/VFSForGit","homepage":"https://gvfs.io/","size":3296,"stargazers_count":4366,"watchers_count":4366,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":290,"open_issues":109,"watchers":4366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/438"},"html":{"href":"https://github.com/Microsoft/VFSForGit/pull/438"},"issue":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/issues/438"},"comments":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/69122987cc383bdd8869f2e016bab0942ab3108c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nickgra"}}