{"action":"created","comment":{"url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/comments/226863261","pull_request_review_id":166785533,"id":226863261,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjg2MzI2MQ==","diff_hunk":"@@ -19,91 +19,86 @@ describe('mathオブジェクトに実装されているメソッドのテスト\n       invalidValueList.forEach(invalidValue => {\n         let error = null;\n         try {\n-          Math.add(invalidValue, 2);\n+          Math.add(invalidValue, 1);\n         } catch (err) {\n           error = err;\n         }\n         assert.equal(error.message, '数値以外のものが引数に含まれています');\n       });\n     });\n   });\n-});\n \n-describe('mathオブジェクトに実装されているメソッドのテスト',() => {\n   describe('subメソッドのテスト', () => {\n     it('subメソッドの型はfunctionである', () => {\n-      assert.equal(typeof math.sub, 'function');\n+      assert.equal(typeof Math.sub, 'function');\n     });\n \n     it('正しく引き算ができる', () => {\n-      assert.equal(math.sub(2, 1), 1);\n-      assert.equal(math.sub(-99, -99), 0);\n-      assert.equal(math.sub(100, 1), 99);\n-      assert.equal(math.sub(0, 1), -1);\n+      assert.equal(Math.sub(2, 1), 1);\n+      assert.equal(Math.sub(-99, -99), 0);\n+      assert.equal(Math.sub(100, 1), 99);\n+      assert.equal(Math.sub(0, 1), -1);\n     });\n \n     it('数値以外がセットされたらエラーを返す', () => {\n       const invalidValueList = ['a', {}, [], null, undefined];\n       invalidValueList.forEach(invalidValue => {\n         let error = null;\n         try {\n-          math.sub(invalidValue, 2);\n+          Math.sub(invalidValue, 2);\n         } catch (err) {\n           error = err;\n         }\n         assert.equal(error.message, '数値以外のものが引数に含められています');\n       });\n     });\n   });","path":"test/libs/math.spec.js","position":55,"original_position":56,"commit_id":"ba980b4f90166ed98116e852e83181b7ac738dab","original_commit_id":"7f5441282904c9203fd4c77856ac1a0d8d96517c","user":{"login":"tsuyopon-xyz","id":43132642,"node_id":"MDQ6VXNlcjQzMTMyNjQy","avatar_url":"https://avatars0.githubusercontent.com/u/43132642?v=4","gravatar_id":"","url":"https://api.github.com/users/tsuyopon-xyz","html_url":"https://github.com/tsuyopon-xyz","followers_url":"https://api.github.com/users/tsuyopon-xyz/followers","following_url":"https://api.github.com/users/tsuyopon-xyz/following{/other_user}","gists_url":"https://api.github.com/users/tsuyopon-xyz/gists{/gist_id}","starred_url":"https://api.github.com/users/tsuyopon-xyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsuyopon-xyz/subscriptions","organizations_url":"https://api.github.com/users/tsuyopon-xyz/orgs","repos_url":"https://api.github.com/users/tsuyopon-xyz/repos","events_url":"https://api.github.com/users/tsuyopon-xyz/events{/privacy}","received_events_url":"https://api.github.com/users/tsuyopon-xyz/received_events","type":"User","site_admin":false},"body":"https://github.com/y-akamatsu/akamatsu-unit-test1/pull/1/files#r226856133\r\n↑\r\nこちらは上記にて解決済みという認識でスルーします。\r\n\r\n","created_at":"2018-10-21T13:35:19Z","updated_at":"2018-10-21T13:35:19Z","html_url":"https://github.com/y-akamatsu/akamatsu-unit-test1/pull/1#discussion_r226863261","pull_request_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/comments/226863261"},"html":{"href":"https://github.com/y-akamatsu/akamatsu-unit-test1/pull/1#discussion_r226863261"},"pull_request":{"href":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/1"}},"in_reply_to_id":226848171},"pull_request":{"url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/1","id":224316975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MzE2OTc1","html_url":"https://github.com/y-akamatsu/akamatsu-unit-test1/pull/1","diff_url":"https://github.com/y-akamatsu/akamatsu-unit-test1/pull/1.diff","patch_url":"https://github.com/y-akamatsu/akamatsu-unit-test1/pull/1.patch","issue_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/issues/1","number":1,"state":"open","locked":false,"title":"second commit","user":{"login":"y-akamatsu","id":37663570,"node_id":"MDQ6VXNlcjM3NjYzNTcw","avatar_url":"https://avatars2.githubusercontent.com/u/37663570?v=4","gravatar_id":"","url":"https://api.github.com/users/y-akamatsu","html_url":"https://github.com/y-akamatsu","followers_url":"https://api.github.com/users/y-akamatsu/followers","following_url":"https://api.github.com/users/y-akamatsu/following{/other_user}","gists_url":"https://api.github.com/users/y-akamatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/y-akamatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-akamatsu/subscriptions","organizations_url":"https://api.github.com/users/y-akamatsu/orgs","repos_url":"https://api.github.com/users/y-akamatsu/repos","events_url":"https://api.github.com/users/y-akamatsu/events{/privacy}","received_events_url":"https://api.github.com/users/y-akamatsu/received_events","type":"User","site_admin":false},"body":"何故かコード内にコメントが書けないためこちらに不明点を明記します。\r\n\r\nMath.js \r\nそもそものclassを使った記述が合っているのかがわかりません。\r\n\r\npackage.json \r\n```\r\n\"devDependencies\": {\r\n    \"mocha\": \"^5.2.0\",\r\n    \"power-assert\": \"^1.6.1\"\r\n  }\r\n```\r\n\r\nmath.spec.js\r\n```\r\n実装内容の場合現状全てテストが通っていないことが確認できます。\r\n\r\n  mathオブジェクトに実装されているメソッドのテスト\r\n    addメソッドのテスト\r\n      1) addメソッドの型はfunctionである\r\n      2) 正しく足し算ができる\r\n      3) 数値以外がセットされたらエラーを返す\r\n\r\n  mathオブジェクトに実装されているメソッドのテスト\r\n    subメソッドのテスト\r\n      4) subメソッドの型はfunctionである\r\n      5) 正しく引き算ができる\r\n      6) 数値以外がセットされたらエラーを返す\r\n\r\n  mathオブジェクトに実装されているメソッドのテスト\r\n    mulメソッドのテスト\r\n      7) mulメソッドの型はfunctionである\r\n      8) 正しく掛け算ができる\r\n      9) 数値以外がセットされたらエラーを返す\r\n\r\n  mathオブジェクトに実装されているメソッドのテスト\r\n    divメソッドのテスト\r\n      10) mulメソッドの型はfunctionである\r\n      11) 正しく割り算ができる\r\n      12) 数値以外がセットされたらエラーを返す\r\n\r\n```\r\n  0 passing (42ms)\r\n  12 failing\r\n上記エラーの場合\r\nテストコードのファイルから直せばよいか、テストするファイルを直せばよいかがわからないでいます。\r\n\r\n","created_at":"2018-10-19T14:59:30Z","updated_at":"2018-10-21T13:35:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7820846a5c3fe6f4262350f8f017045c572aa8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/1/commits","review_comments_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/1/comments","review_comment_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/issues/1/comments","statuses_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/statuses/ba980b4f90166ed98116e852e83181b7ac738dab","head":{"label":"y-akamatsu:develop","ref":"develop","sha":"ba980b4f90166ed98116e852e83181b7ac738dab","user":{"login":"y-akamatsu","id":37663570,"node_id":"MDQ6VXNlcjM3NjYzNTcw","avatar_url":"https://avatars2.githubusercontent.com/u/37663570?v=4","gravatar_id":"","url":"https://api.github.com/users/y-akamatsu","html_url":"https://github.com/y-akamatsu","followers_url":"https://api.github.com/users/y-akamatsu/followers","following_url":"https://api.github.com/users/y-akamatsu/following{/other_user}","gists_url":"https://api.github.com/users/y-akamatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/y-akamatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-akamatsu/subscriptions","organizations_url":"https://api.github.com/users/y-akamatsu/orgs","repos_url":"https://api.github.com/users/y-akamatsu/repos","events_url":"https://api.github.com/users/y-akamatsu/events{/privacy}","received_events_url":"https://api.github.com/users/y-akamatsu/received_events","type":"User","site_admin":false},"repo":{"id":153796454,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3OTY0NTQ=","name":"akamatsu-unit-test1","full_name":"y-akamatsu/akamatsu-unit-test1","private":false,"owner":{"login":"y-akamatsu","id":37663570,"node_id":"MDQ6VXNlcjM3NjYzNTcw","avatar_url":"https://avatars2.githubusercontent.com/u/37663570?v=4","gravatar_id":"","url":"https://api.github.com/users/y-akamatsu","html_url":"https://github.com/y-akamatsu","followers_url":"https://api.github.com/users/y-akamatsu/followers","following_url":"https://api.github.com/users/y-akamatsu/following{/other_user}","gists_url":"https://api.github.com/users/y-akamatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/y-akamatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-akamatsu/subscriptions","organizations_url":"https://api.github.com/users/y-akamatsu/orgs","repos_url":"https://api.github.com/users/y-akamatsu/repos","events_url":"https://api.github.com/users/y-akamatsu/events{/privacy}","received_events_url":"https://api.github.com/users/y-akamatsu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/y-akamatsu/akamatsu-unit-test1","description":null,"fork":false,"url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1","forks_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/forks","keys_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/teams","hooks_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/hooks","issue_events_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/issues/events{/number}","events_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/events","assignees_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/assignees{/user}","branches_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/branches{/branch}","tags_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/tags","blobs_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/git/refs{/sha}","trees_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/statuses/{sha}","languages_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/languages","stargazers_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/stargazers","contributors_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/contributors","subscribers_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/subscribers","subscription_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/subscription","commits_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/commits{/sha}","git_commits_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/git/commits{/sha}","comments_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/comments{/number}","issue_comment_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/issues/comments{/number}","contents_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/contents/{+path}","compare_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/merges","archive_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/downloads","issues_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/issues{/number}","pulls_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls{/number}","milestones_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/milestones{/number}","notifications_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/labels{/name}","releases_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/releases{/id}","deployments_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/deployments","created_at":"2018-10-19T14:33:15Z","updated_at":"2018-10-19T14:38:34Z","pushed_at":"2018-10-21T09:53:32Z","git_url":"git://github.com/y-akamatsu/akamatsu-unit-test1.git","ssh_url":"git@github.com:y-akamatsu/akamatsu-unit-test1.git","clone_url":"https://github.com/y-akamatsu/akamatsu-unit-test1.git","svn_url":"https://github.com/y-akamatsu/akamatsu-unit-test1","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"y-akamatsu:master","ref":"master","sha":"85ebf844859a41b0cf0f40e8683875c1123d9044","user":{"login":"y-akamatsu","id":37663570,"node_id":"MDQ6VXNlcjM3NjYzNTcw","avatar_url":"https://avatars2.githubusercontent.com/u/37663570?v=4","gravatar_id":"","url":"https://api.github.com/users/y-akamatsu","html_url":"https://github.com/y-akamatsu","followers_url":"https://api.github.com/users/y-akamatsu/followers","following_url":"https://api.github.com/users/y-akamatsu/following{/other_user}","gists_url":"https://api.github.com/users/y-akamatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/y-akamatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-akamatsu/subscriptions","organizations_url":"https://api.github.com/users/y-akamatsu/orgs","repos_url":"https://api.github.com/users/y-akamatsu/repos","events_url":"https://api.github.com/users/y-akamatsu/events{/privacy}","received_events_url":"https://api.github.com/users/y-akamatsu/received_events","type":"User","site_admin":false},"repo":{"id":153796454,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3OTY0NTQ=","name":"akamatsu-unit-test1","full_name":"y-akamatsu/akamatsu-unit-test1","private":false,"owner":{"login":"y-akamatsu","id":37663570,"node_id":"MDQ6VXNlcjM3NjYzNTcw","avatar_url":"https://avatars2.githubusercontent.com/u/37663570?v=4","gravatar_id":"","url":"https://api.github.com/users/y-akamatsu","html_url":"https://github.com/y-akamatsu","followers_url":"https://api.github.com/users/y-akamatsu/followers","following_url":"https://api.github.com/users/y-akamatsu/following{/other_user}","gists_url":"https://api.github.com/users/y-akamatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/y-akamatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-akamatsu/subscriptions","organizations_url":"https://api.github.com/users/y-akamatsu/orgs","repos_url":"https://api.github.com/users/y-akamatsu/repos","events_url":"https://api.github.com/users/y-akamatsu/events{/privacy}","received_events_url":"https://api.github.com/users/y-akamatsu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/y-akamatsu/akamatsu-unit-test1","description":null,"fork":false,"url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1","forks_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/forks","keys_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/teams","hooks_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/hooks","issue_events_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/issues/events{/number}","events_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/events","assignees_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/assignees{/user}","branches_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/branches{/branch}","tags_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/tags","blobs_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/git/refs{/sha}","trees_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/statuses/{sha}","languages_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/languages","stargazers_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/stargazers","contributors_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/contributors","subscribers_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/subscribers","subscription_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/subscription","commits_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/commits{/sha}","git_commits_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/git/commits{/sha}","comments_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/comments{/number}","issue_comment_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/issues/comments{/number}","contents_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/contents/{+path}","compare_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/merges","archive_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/downloads","issues_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/issues{/number}","pulls_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls{/number}","milestones_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/milestones{/number}","notifications_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/labels{/name}","releases_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/releases{/id}","deployments_url":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/deployments","created_at":"2018-10-19T14:33:15Z","updated_at":"2018-10-19T14:38:34Z","pushed_at":"2018-10-21T09:53:32Z","git_url":"git://github.com/y-akamatsu/akamatsu-unit-test1.git","ssh_url":"git@github.com:y-akamatsu/akamatsu-unit-test1.git","clone_url":"https://github.com/y-akamatsu/akamatsu-unit-test1.git","svn_url":"https://github.com/y-akamatsu/akamatsu-unit-test1","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/1"},"html":{"href":"https://github.com/y-akamatsu/akamatsu-unit-test1/pull/1"},"issue":{"href":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/issues/1"},"comments":{"href":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/y-akamatsu/akamatsu-unit-test1/statuses/ba980b4f90166ed98116e852e83181b7ac738dab"}},"author_association":"OWNER"}}
{"actor":{"display_login":"tsuyopon-xyz"}}