{"action":"created","comment":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/comments/198616279","pull_request_review_id":132578360,"id":198616279,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODYxNjI3OQ==","diff_hunk":"@@ -193,32 +193,34 @@ int ospf6_abr_originate_summary_to_area(struct ospf6_route *route,\n \tif (route->type == OSPF6_DEST_TYPE_ROUTER) {\n \t\tif (ADV_ROUTER_IN_PREFIX(&route->prefix)\n \t\t    == area->ospf6->router_id) {\n-\t\t\tinet_ntop(AF_INET,\n-\t\t\t\t  &(ADV_ROUTER_IN_PREFIX(&route->prefix)), buf,\n-\t\t\t\t  sizeof(buf));\n-\t\t\tzlog_debug(\n-\t\t\t\t\"%s: Skipping ASBR announcement for ABR (%s)\",\n-\t\t\t\t__func__, buf);\n+\t\t\tif (is_debug) {","path":"ospf6d/ospf6_abr.c","position":19,"original_position":19,"commit_id":"f3f5ba30274e143f918e08b0597b89b0d11ca000","original_commit_id":"f3f5ba30274e143f918e08b0597b89b0d11ca000","user":{"login":"qlyoung","id":6827003,"node_id":"MDQ6VXNlcjY4MjcwMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6827003?v=4","gravatar_id":"","url":"https://api.github.com/users/qlyoung","html_url":"https://github.com/qlyoung","followers_url":"https://api.github.com/users/qlyoung/followers","following_url":"https://api.github.com/users/qlyoung/following{/other_user}","gists_url":"https://api.github.com/users/qlyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/qlyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlyoung/subscriptions","organizations_url":"https://api.github.com/users/qlyoung/orgs","repos_url":"https://api.github.com/users/qlyoung/repos","events_url":"https://api.github.com/users/qlyoung/events{/privacy}","received_events_url":"https://api.github.com/users/qlyoung/received_events","type":"User","site_admin":false},"body":"The correct thing to do here is to determine (or create) the correct OSPF-level debug statement here and use that to determine whether or not this debugging code should be executed.","created_at":"2018-06-27T19:38:37Z","updated_at":"2018-06-27T19:39:10Z","html_url":"https://github.com/FRRouting/frr/pull/2561#discussion_r198616279","pull_request_url":"https://api.github.com/repos/FRRouting/frr/pulls/2561","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments/198616279"},"html":{"href":"https://github.com/FRRouting/frr/pull/2561#discussion_r198616279"},"pull_request":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2561"}}},"pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/2561","id":197525712,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTI1NzEy","html_url":"https://github.com/FRRouting/frr/pull/2561","diff_url":"https://github.com/FRRouting/frr/pull/2561.diff","patch_url":"https://github.com/FRRouting/frr/pull/2561.patch","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/2561","number":2561,"state":"open","locked":false,"title":"lib ospf6d: dead code (Coverity 1399231)","user":{"login":"pacovn","id":37577061,"node_id":"MDQ6VXNlcjM3NTc3MDYx","avatar_url":"https://avatars2.githubusercontent.com/u/37577061?v=4","gravatar_id":"","url":"https://api.github.com/users/pacovn","html_url":"https://github.com/pacovn","followers_url":"https://api.github.com/users/pacovn/followers","following_url":"https://api.github.com/users/pacovn/following{/other_user}","gists_url":"https://api.github.com/users/pacovn/gists{/gist_id}","starred_url":"https://api.github.com/users/pacovn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacovn/subscriptions","organizations_url":"https://api.github.com/users/pacovn/orgs","repos_url":"https://api.github.com/users/pacovn/repos","events_url":"https://api.github.com/users/pacovn/events{/privacy}","received_events_url":"https://api.github.com/users/pacovn/received_events","type":"User","site_admin":false},"body":"It should have the same behavior when debug not enabled, and slightly\r\ndifferent behavior when debug enabled (previously dead code now should\r\nshow debug messages in debug mode).\r\n\r\nNote: I've kept the 'is_debug'  logic because I guess that the original purpose of that is related to avoid a performance penalty when not in debug mode.\r\n","created_at":"2018-06-26T19:22:28Z","updated_at":"2018-06-27T19:39:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bc683c4ac7ee7606967b9e0e35e77e97343901d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FRRouting/frr/pulls/2561/commits","review_comments_url":"https://api.github.com/repos/FRRouting/frr/pulls/2561/comments","review_comment_url":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/2561/comments","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/f3f5ba30274e143f918e08b0597b89b0d11ca000","head":{"label":"pacovn:Coverity_1399231_Logically_dead_code","ref":"Coverity_1399231_Logically_dead_code","sha":"f3f5ba30274e143f918e08b0597b89b0d11ca000","user":{"login":"pacovn","id":37577061,"node_id":"MDQ6VXNlcjM3NTc3MDYx","avatar_url":"https://avatars2.githubusercontent.com/u/37577061?v=4","gravatar_id":"","url":"https://api.github.com/users/pacovn","html_url":"https://github.com/pacovn","followers_url":"https://api.github.com/users/pacovn/followers","following_url":"https://api.github.com/users/pacovn/following{/other_user}","gists_url":"https://api.github.com/users/pacovn/gists{/gist_id}","starred_url":"https://api.github.com/users/pacovn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacovn/subscriptions","organizations_url":"https://api.github.com/users/pacovn/orgs","repos_url":"https://api.github.com/users/pacovn/repos","events_url":"https://api.github.com/users/pacovn/events{/privacy}","received_events_url":"https://api.github.com/users/pacovn/received_events","type":"User","site_admin":false},"repo":{"id":135327685,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzMjc2ODU=","name":"frr","full_name":"pacovn/frr","owner":{"login":"pacovn","id":37577061,"node_id":"MDQ6VXNlcjM3NTc3MDYx","avatar_url":"https://avatars2.githubusercontent.com/u/37577061?v=4","gravatar_id":"","url":"https://api.github.com/users/pacovn","html_url":"https://github.com/pacovn","followers_url":"https://api.github.com/users/pacovn/followers","following_url":"https://api.github.com/users/pacovn/following{/other_user}","gists_url":"https://api.github.com/users/pacovn/gists{/gist_id}","starred_url":"https://api.github.com/users/pacovn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pacovn/subscriptions","organizations_url":"https://api.github.com/users/pacovn/orgs","repos_url":"https://api.github.com/users/pacovn/repos","events_url":"https://api.github.com/users/pacovn/events{/privacy}","received_events_url":"https://api.github.com/users/pacovn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pacovn/frr","description":"The FRRouting Protocol Suite","fork":true,"url":"https://api.github.com/repos/pacovn/frr","forks_url":"https://api.github.com/repos/pacovn/frr/forks","keys_url":"https://api.github.com/repos/pacovn/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pacovn/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pacovn/frr/teams","hooks_url":"https://api.github.com/repos/pacovn/frr/hooks","issue_events_url":"https://api.github.com/repos/pacovn/frr/issues/events{/number}","events_url":"https://api.github.com/repos/pacovn/frr/events","assignees_url":"https://api.github.com/repos/pacovn/frr/assignees{/user}","branches_url":"https://api.github.com/repos/pacovn/frr/branches{/branch}","tags_url":"https://api.github.com/repos/pacovn/frr/tags","blobs_url":"https://api.github.com/repos/pacovn/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pacovn/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pacovn/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pacovn/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pacovn/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/pacovn/frr/languages","stargazers_url":"https://api.github.com/repos/pacovn/frr/stargazers","contributors_url":"https://api.github.com/repos/pacovn/frr/contributors","subscribers_url":"https://api.github.com/repos/pacovn/frr/subscribers","subscription_url":"https://api.github.com/repos/pacovn/frr/subscription","commits_url":"https://api.github.com/repos/pacovn/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pacovn/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pacovn/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pacovn/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pacovn/frr/contents/{+path}","compare_url":"https://api.github.com/repos/pacovn/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pacovn/frr/merges","archive_url":"https://api.github.com/repos/pacovn/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pacovn/frr/downloads","issues_url":"https://api.github.com/repos/pacovn/frr/issues{/number}","pulls_url":"https://api.github.com/repos/pacovn/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/pacovn/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/pacovn/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pacovn/frr/labels{/name}","releases_url":"https://api.github.com/repos/pacovn/frr/releases{/id}","deployments_url":"https://api.github.com/repos/pacovn/frr/deployments","created_at":"2018-05-29T17:02:14Z","updated_at":"2018-06-27T09:01:44Z","pushed_at":"2018-06-27T13:51:50Z","git_url":"git://github.com/pacovn/frr.git","ssh_url":"git@github.com:pacovn/frr.git","clone_url":"https://github.com/pacovn/frr.git","svn_url":"https://github.com/pacovn/frr","homepage":"https://frrouting.org/","size":40953,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FRRouting:master","ref":"master","sha":"045a178c13386d81966e8d3cfeb3a1c24670691b","user":{"login":"FRRouting","id":24592672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTkyNjcy","avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"repo":{"id":76599439,"node_id":"MDEwOlJlcG9zaXRvcnk3NjU5OTQzOQ==","name":"frr","full_name":"FRRouting/frr","owner":{"login":"FRRouting","id":24592672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTkyNjcy","avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FRRouting/frr","description":"The FRRouting Protocol Suite","fork":false,"url":"https://api.github.com/repos/FRRouting/frr","forks_url":"https://api.github.com/repos/FRRouting/frr/forks","keys_url":"https://api.github.com/repos/FRRouting/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FRRouting/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FRRouting/frr/teams","hooks_url":"https://api.github.com/repos/FRRouting/frr/hooks","issue_events_url":"https://api.github.com/repos/FRRouting/frr/issues/events{/number}","events_url":"https://api.github.com/repos/FRRouting/frr/events","assignees_url":"https://api.github.com/repos/FRRouting/frr/assignees{/user}","branches_url":"https://api.github.com/repos/FRRouting/frr/branches{/branch}","tags_url":"https://api.github.com/repos/FRRouting/frr/tags","blobs_url":"https://api.github.com/repos/FRRouting/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FRRouting/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FRRouting/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/FRRouting/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/FRRouting/frr/languages","stargazers_url":"https://api.github.com/repos/FRRouting/frr/stargazers","contributors_url":"https://api.github.com/repos/FRRouting/frr/contributors","subscribers_url":"https://api.github.com/repos/FRRouting/frr/subscribers","subscription_url":"https://api.github.com/repos/FRRouting/frr/subscription","commits_url":"https://api.github.com/repos/FRRouting/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/FRRouting/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/FRRouting/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/FRRouting/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/FRRouting/frr/contents/{+path}","compare_url":"https://api.github.com/repos/FRRouting/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FRRouting/frr/merges","archive_url":"https://api.github.com/repos/FRRouting/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FRRouting/frr/downloads","issues_url":"https://api.github.com/repos/FRRouting/frr/issues{/number}","pulls_url":"https://api.github.com/repos/FRRouting/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/FRRouting/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/FRRouting/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FRRouting/frr/labels{/name}","releases_url":"https://api.github.com/repos/FRRouting/frr/releases{/id}","deployments_url":"https://api.github.com/repos/FRRouting/frr/deployments","created_at":"2016-12-15T21:56:38Z","updated_at":"2018-06-27T19:15:27Z","pushed_at":"2018-06-27T19:35:18Z","git_url":"git://github.com/FRRouting/frr.git","ssh_url":"git@github.com:FRRouting/frr.git","clone_url":"https://github.com/FRRouting/frr.git","svn_url":"https://github.com/FRRouting/frr","homepage":"https://frrouting.org/","size":41029,"stargazers_count":546,"watchers_count":546,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"archived":false,"open_issues_count":232,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":215,"open_issues":232,"watchers":546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2561"},"html":{"href":"https://github.com/FRRouting/frr/pull/2561"},"issue":{"href":"https://api.github.com/repos/FRRouting/frr/issues/2561"},"comments":{"href":"https://api.github.com/repos/FRRouting/frr/issues/2561/comments"},"review_comments":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2561/comments"},"review_comment":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/2561/commits"},"statuses":{"href":"https://api.github.com/repos/FRRouting/frr/statuses/f3f5ba30274e143f918e08b0597b89b0d11ca000"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qlyoung"}}