{"action":"opened","number":5308,"pull_request":{"url":"https://api.github.com/repos/protocolbuffers/protobuf/pulls/5308","id":227623599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjIzNTk5","html_url":"https://github.com/protocolbuffers/protobuf/pull/5308","diff_url":"https://github.com/protocolbuffers/protobuf/pull/5308.diff","patch_url":"https://github.com/protocolbuffers/protobuf/pull/5308.patch","issue_url":"https://api.github.com/repos/protocolbuffers/protobuf/issues/5308","number":5308,"state":"open","locked":false,"title":"Collapse :protobuf_objc and :objectivec targets.","user":{"login":"thomasvl","id":5279928,"node_id":"MDQ6VXNlcjUyNzk5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5279928?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasvl","html_url":"https://github.com/thomasvl","followers_url":"https://api.github.com/users/thomasvl/followers","following_url":"https://api.github.com/users/thomasvl/following{/other_user}","gists_url":"https://api.github.com/users/thomasvl/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasvl/subscriptions","organizations_url":"https://api.github.com/users/thomasvl/orgs","repos_url":"https://api.github.com/users/thomasvl/repos","events_url":"https://api.github.com/users/thomasvl/events{/privacy}","received_events_url":"https://api.github.com/users/thomasvl/received_events","type":"User","site_admin":false},"body":"Not sure the history for why there were two objc_library targets, but\r\ngiven the one has an issue about not working, merge them into a single\r\ntarget and an alias.\r\n\r\n- Use the alias for :objectivec since that naming doesn't seem to follow\r\n  the other targets *_library targets here.\r\n- Update :protobuf_objc to be use for the working target and just inline\r\n  the sources/headers lists so there is less indirection in the file.\r\n\r\nFixes #5284","created_at":"2018-11-01T13:45:14Z","updated_at":"2018-11-01T13:45:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"haberman","id":1270,"node_id":"MDQ6VXNlcjEyNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1270?v=4","gravatar_id":"","url":"https://api.github.com/users/haberman","html_url":"https://github.com/haberman","followers_url":"https://api.github.com/users/haberman/followers","following_url":"https://api.github.com/users/haberman/following{/other_user}","gists_url":"https://api.github.com/users/haberman/gists{/gist_id}","starred_url":"https://api.github.com/users/haberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haberman/subscriptions","organizations_url":"https://api.github.com/users/haberman/orgs","repos_url":"https://api.github.com/users/haberman/repos","events_url":"https://api.github.com/users/haberman/events{/privacy}","received_events_url":"https://api.github.com/users/haberman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/protocolbuffers/protobuf/pulls/5308/commits","review_comments_url":"https://api.github.com/repos/protocolbuffers/protobuf/pulls/5308/comments","review_comment_url":"https://api.github.com/repos/protocolbuffers/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/protocolbuffers/protobuf/issues/5308/comments","statuses_url":"https://api.github.com/repos/protocolbuffers/protobuf/statuses/e8e51408d624057863f80a62fd9b734356a4ff36","head":{"label":"thomasvl:build_5284","ref":"build_5284","sha":"e8e51408d624057863f80a62fd9b734356a4ff36","user":{"login":"thomasvl","id":5279928,"node_id":"MDQ6VXNlcjUyNzk5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5279928?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasvl","html_url":"https://github.com/thomasvl","followers_url":"https://api.github.com/users/thomasvl/followers","following_url":"https://api.github.com/users/thomasvl/following{/other_user}","gists_url":"https://api.github.com/users/thomasvl/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasvl/subscriptions","organizations_url":"https://api.github.com/users/thomasvl/orgs","repos_url":"https://api.github.com/users/thomasvl/repos","events_url":"https://api.github.com/users/thomasvl/events{/privacy}","received_events_url":"https://api.github.com/users/thomasvl/received_events","type":"User","site_admin":false},"repo":{"id":34861452,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg2MTQ1Mg==","name":"protobuf","full_name":"thomasvl/protobuf","private":false,"owner":{"login":"thomasvl","id":5279928,"node_id":"MDQ6VXNlcjUyNzk5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5279928?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasvl","html_url":"https://github.com/thomasvl","followers_url":"https://api.github.com/users/thomasvl/followers","following_url":"https://api.github.com/users/thomasvl/following{/other_user}","gists_url":"https://api.github.com/users/thomasvl/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasvl/subscriptions","organizations_url":"https://api.github.com/users/thomasvl/orgs","repos_url":"https://api.github.com/users/thomasvl/repos","events_url":"https://api.github.com/users/thomasvl/events{/privacy}","received_events_url":"https://api.github.com/users/thomasvl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thomasvl/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":true,"url":"https://api.github.com/repos/thomasvl/protobuf","forks_url":"https://api.github.com/repos/thomasvl/protobuf/forks","keys_url":"https://api.github.com/repos/thomasvl/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomasvl/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomasvl/protobuf/teams","hooks_url":"https://api.github.com/repos/thomasvl/protobuf/hooks","issue_events_url":"https://api.github.com/repos/thomasvl/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/thomasvl/protobuf/events","assignees_url":"https://api.github.com/repos/thomasvl/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/thomasvl/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/thomasvl/protobuf/tags","blobs_url":"https://api.github.com/repos/thomasvl/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomasvl/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomasvl/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomasvl/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomasvl/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/thomasvl/protobuf/languages","stargazers_url":"https://api.github.com/repos/thomasvl/protobuf/stargazers","contributors_url":"https://api.github.com/repos/thomasvl/protobuf/contributors","subscribers_url":"https://api.github.com/repos/thomasvl/protobuf/subscribers","subscription_url":"https://api.github.com/repos/thomasvl/protobuf/subscription","commits_url":"https://api.github.com/repos/thomasvl/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomasvl/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomasvl/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomasvl/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomasvl/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/thomasvl/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomasvl/protobuf/merges","archive_url":"https://api.github.com/repos/thomasvl/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomasvl/protobuf/downloads","issues_url":"https://api.github.com/repos/thomasvl/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/thomasvl/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/thomasvl/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/thomasvl/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomasvl/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/thomasvl/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/thomasvl/protobuf/deployments","created_at":"2015-04-30T15:20:32Z","updated_at":"2018-11-01T13:27:59Z","pushed_at":"2018-11-01T13:44:21Z","git_url":"git://github.com/thomasvl/protobuf.git","ssh_url":"git@github.com:thomasvl/protobuf.git","clone_url":"https://github.com/thomasvl/protobuf.git","svn_url":"https://github.com/thomasvl/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":48670,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"protocolbuffers:master","ref":"master","sha":"96f7c5383f257a44d8e290a10da5257be9500ad6","user":{"login":"protocolbuffers","id":26310541,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzEwNTQx","avatar_url":"https://avatars1.githubusercontent.com/u/26310541?v=4","gravatar_id":"","url":"https://api.github.com/users/protocolbuffers","html_url":"https://github.com/protocolbuffers","followers_url":"https://api.github.com/users/protocolbuffers/followers","following_url":"https://api.github.com/users/protocolbuffers/following{/other_user}","gists_url":"https://api.github.com/users/protocolbuffers/gists{/gist_id}","starred_url":"https://api.github.com/users/protocolbuffers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protocolbuffers/subscriptions","organizations_url":"https://api.github.com/users/protocolbuffers/orgs","repos_url":"https://api.github.com/users/protocolbuffers/repos","events_url":"https://api.github.com/users/protocolbuffers/events{/privacy}","received_events_url":"https://api.github.com/users/protocolbuffers/received_events","type":"Organization","site_admin":false},"repo":{"id":23357588,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM1NzU4OA==","name":"protobuf","full_name":"protocolbuffers/protobuf","private":false,"owner":{"login":"protocolbuffers","id":26310541,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzEwNTQx","avatar_url":"https://avatars1.githubusercontent.com/u/26310541?v=4","gravatar_id":"","url":"https://api.github.com/users/protocolbuffers","html_url":"https://github.com/protocolbuffers","followers_url":"https://api.github.com/users/protocolbuffers/followers","following_url":"https://api.github.com/users/protocolbuffers/following{/other_user}","gists_url":"https://api.github.com/users/protocolbuffers/gists{/gist_id}","starred_url":"https://api.github.com/users/protocolbuffers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protocolbuffers/subscriptions","organizations_url":"https://api.github.com/users/protocolbuffers/orgs","repos_url":"https://api.github.com/users/protocolbuffers/repos","events_url":"https://api.github.com/users/protocolbuffers/events{/privacy}","received_events_url":"https://api.github.com/users/protocolbuffers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/protocolbuffers/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":false,"url":"https://api.github.com/repos/protocolbuffers/protobuf","forks_url":"https://api.github.com/repos/protocolbuffers/protobuf/forks","keys_url":"https://api.github.com/repos/protocolbuffers/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/protocolbuffers/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/protocolbuffers/protobuf/teams","hooks_url":"https://api.github.com/repos/protocolbuffers/protobuf/hooks","issue_events_url":"https://api.github.com/repos/protocolbuffers/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/protocolbuffers/protobuf/events","assignees_url":"https://api.github.com/repos/protocolbuffers/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/protocolbuffers/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/protocolbuffers/protobuf/tags","blobs_url":"https://api.github.com/repos/protocolbuffers/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/protocolbuffers/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/protocolbuffers/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/protocolbuffers/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/protocolbuffers/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/protocolbuffers/protobuf/languages","stargazers_url":"https://api.github.com/repos/protocolbuffers/protobuf/stargazers","contributors_url":"https://api.github.com/repos/protocolbuffers/protobuf/contributors","subscribers_url":"https://api.github.com/repos/protocolbuffers/protobuf/subscribers","subscription_url":"https://api.github.com/repos/protocolbuffers/protobuf/subscription","commits_url":"https://api.github.com/repos/protocolbuffers/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/protocolbuffers/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/protocolbuffers/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/protocolbuffers/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/protocolbuffers/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/protocolbuffers/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/protocolbuffers/protobuf/merges","archive_url":"https://api.github.com/repos/protocolbuffers/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/protocolbuffers/protobuf/downloads","issues_url":"https://api.github.com/repos/protocolbuffers/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/protocolbuffers/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/protocolbuffers/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/protocolbuffers/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/protocolbuffers/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/protocolbuffers/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/protocolbuffers/protobuf/deployments","created_at":"2014-08-26T15:52:15Z","updated_at":"2018-11-01T13:34:41Z","pushed_at":"2018-10-31T16:48:54Z","git_url":"git://github.com/protocolbuffers/protobuf.git","ssh_url":"git@github.com:protocolbuffers/protobuf.git","clone_url":"https://github.com/protocolbuffers/protobuf.git","svn_url":"https://github.com/protocolbuffers/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":50055,"stargazers_count":29930,"watchers_count":29930,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8301,"mirror_url":null,"archived":false,"open_issues_count":521,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8301,"open_issues":521,"watchers":29930,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/protocolbuffers/protobuf/pulls/5308"},"html":{"href":"https://github.com/protocolbuffers/protobuf/pull/5308"},"issue":{"href":"https://api.github.com/repos/protocolbuffers/protobuf/issues/5308"},"comments":{"href":"https://api.github.com/repos/protocolbuffers/protobuf/issues/5308/comments"},"review_comments":{"href":"https://api.github.com/repos/protocolbuffers/protobuf/pulls/5308/comments"},"review_comment":{"href":"https://api.github.com/repos/protocolbuffers/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/protocolbuffers/protobuf/pulls/5308/commits"},"statuses":{"href":"https://api.github.com/repos/protocolbuffers/protobuf/statuses/e8e51408d624057863f80a62fd9b734356a4ff36"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":74,"deletions":81,"changed_files":1}}
{"actor":{"display_login":"thomasvl"}}