{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/243860059","pull_request_review_id":187732828,"id":243860059,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzg2MDA1OQ==","diff_hunk":"@@ -183,11 +195,11 @@ let\n       (let\n         knownPlugins = pathogen.knownPlugins or vimPlugins;\n \n-        plugins = map (name: knownPlugins.${name}) (findDependenciesRecursively { inherit knownPlugins; names = pathogen.pluginNames; });","path":"pkgs/misc/vim-plugins/vim-utils.nix","position":53,"original_position":53,"commit_id":"b1a5016c70fe3ad3f1e603501aaaeaf9ed0267d2","original_commit_id":"b1a5016c70fe3ad3f1e603501aaaeaf9ed0267d2","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"For users outside of nixpkgs we should leave at least an assertion, when they still use strings here.","created_at":"2018-12-24T22:06:56Z","updated_at":"2018-12-24T22:06:56Z","html_url":"https://github.com/NixOS/nixpkgs/pull/52767#discussion_r243860059","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52767","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/243860059"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/52767#discussion_r243860059"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52767"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52767","id":240768247,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNzY4MjQ3","html_url":"https://github.com/NixOS/nixpkgs/pull/52767","diff_url":"https://github.com/NixOS/nixpkgs/pull/52767.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/52767.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/52767","number":52767,"state":"open","locked":false,"title":"Fix vim-plugin dependencies","user":{"login":"timokau","id":3799330,"node_id":"MDQ6VXNlcjM3OTkzMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3799330?v=4","gravatar_id":"","url":"https://api.github.com/users/timokau","html_url":"https://github.com/timokau","followers_url":"https://api.github.com/users/timokau/followers","following_url":"https://api.github.com/users/timokau/following{/other_user}","gists_url":"https://api.github.com/users/timokau/gists{/gist_id}","starred_url":"https://api.github.com/users/timokau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timokau/subscriptions","organizations_url":"https://api.github.com/users/timokau/orgs","repos_url":"https://api.github.com/users/timokau/repos","events_url":"https://api.github.com/users/timokau/events{/privacy}","received_events_url":"https://api.github.com/users/timokau/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nI noticed that plugin dependencies simply did not work with the native vim plugin manager. It simply was not implemented, which was surprising.\r\n\r\nTo implement it, I first had to refactor vim-utils.nix. Now vim plugins are derivations by default, although the \"name + knownPlugins\" variant is still possible for backwards compatibility. I can't really see a reason why it was strings in the first place.\r\n\r\nI also added a new ncm2 completion backend and updated the plugins (same PR since it would conflict otherwise).\r\n\r\nBecause of the autogenerated file this will bitrot fast, so I would like to get this merged relatively quickly.\r\n\r\nBased on git-shortlog: @andsild, @jagajaga, @Mic92\r\n\r\nI have build and tested the provided test instances with the different plugin managers. While doing that I also fixed the pathogen implementation that was already broken. I verified that the installed plugins shows up under `:scriptnames`.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Assured whether relevant documentation is up to date\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-12-24T12:26:44Z","updated_at":"2018-12-24T22:06:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd5c28325b34858d1a8e2ad877fe0c1a811ed1b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731734374,"node_id":"MDU6TGFiZWw3MzE3MzQzNzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20101-500","name":"10.rebuild-linux: 101-500","color":"d93f0b","default":false},{"id":344191335,"node_id":"MDU6TGFiZWwzNDQxOTEzMzU=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20vim","name":"6.topic: vim","color":"fef2c0","default":false},{"id":290122655,"node_id":"MDU6TGFiZWwyOTAxMjI2NTU=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20documentation","name":"8.has: documentation","color":"009800","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52767/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52767/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/52767/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b1a5016c70fe3ad3f1e603501aaaeaf9ed0267d2","head":{"label":"timokau:vim-plugin-updates","ref":"vim-plugin-updates","sha":"b1a5016c70fe3ad3f1e603501aaaeaf9ed0267d2","user":{"login":"timokau","id":3799330,"node_id":"MDQ6VXNlcjM3OTkzMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3799330?v=4","gravatar_id":"","url":"https://api.github.com/users/timokau","html_url":"https://github.com/timokau","followers_url":"https://api.github.com/users/timokau/followers","following_url":"https://api.github.com/users/timokau/following{/other_user}","gists_url":"https://api.github.com/users/timokau/gists{/gist_id}","starred_url":"https://api.github.com/users/timokau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timokau/subscriptions","organizations_url":"https://api.github.com/users/timokau/orgs","repos_url":"https://api.github.com/users/timokau/repos","events_url":"https://api.github.com/users/timokau/events{/privacy}","received_events_url":"https://api.github.com/users/timokau/received_events","type":"User","site_admin":false},"repo":{"id":105080039,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUwODAwMzk=","name":"nixpkgs","full_name":"timokau/nixpkgs","private":false,"owner":{"login":"timokau","id":3799330,"node_id":"MDQ6VXNlcjM3OTkzMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3799330?v=4","gravatar_id":"","url":"https://api.github.com/users/timokau","html_url":"https://github.com/timokau","followers_url":"https://api.github.com/users/timokau/followers","following_url":"https://api.github.com/users/timokau/following{/other_user}","gists_url":"https://api.github.com/users/timokau/gists{/gist_id}","starred_url":"https://api.github.com/users/timokau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timokau/subscriptions","organizations_url":"https://api.github.com/users/timokau/orgs","repos_url":"https://api.github.com/users/timokau/repos","events_url":"https://api.github.com/users/timokau/events{/privacy}","received_events_url":"https://api.github.com/users/timokau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/timokau/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/timokau/nixpkgs","forks_url":"https://api.github.com/repos/timokau/nixpkgs/forks","keys_url":"https://api.github.com/repos/timokau/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timokau/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timokau/nixpkgs/teams","hooks_url":"https://api.github.com/repos/timokau/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/timokau/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/timokau/nixpkgs/events","assignees_url":"https://api.github.com/repos/timokau/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/timokau/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/timokau/nixpkgs/tags","blobs_url":"https://api.github.com/repos/timokau/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timokau/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timokau/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/timokau/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timokau/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/timokau/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/timokau/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/timokau/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/timokau/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/timokau/nixpkgs/subscription","commits_url":"https://api.github.com/repos/timokau/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/timokau/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/timokau/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/timokau/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/timokau/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/timokau/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timokau/nixpkgs/merges","archive_url":"https://api.github.com/repos/timokau/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timokau/nixpkgs/downloads","issues_url":"https://api.github.com/repos/timokau/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/timokau/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/timokau/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/timokau/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timokau/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/timokau/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/timokau/nixpkgs/deployments","created_at":"2017-09-27T23:33:42Z","updated_at":"2017-09-27T23:34:09Z","pushed_at":"2018-12-24T20:17:20Z","git_url":"git://github.com/timokau/nixpkgs.git","ssh_url":"git@github.com:timokau/nixpkgs.git","clone_url":"https://github.com/timokau/nixpkgs.git","svn_url":"https://github.com/timokau/nixpkgs","homepage":null,"size":831741,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"aac3ae3be619c0622e6df4ed6b58231ec4abfe4f","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-12-24T22:05:06Z","pushed_at":"2018-12-24T21:32:38Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":908633,"stargazers_count":3122,"watchers_count":3122,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3269,"mirror_url":null,"archived":false,"open_issues_count":3472,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3269,"open_issues":3472,"watchers":3122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52767"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/52767"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/52767"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/52767/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52767/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52767/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b1a5016c70fe3ad3f1e603501aaaeaf9ed0267d2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Mic92"}}