{"action":"opened","issue":{"url":"https://api.github.com/repos/kelley-sharp/hack-or-snooze-project/issues/1","repository_url":"https://api.github.com/repos/kelley-sharp/hack-or-snooze-project","labels_url":"https://api.github.com/repos/kelley-sharp/hack-or-snooze-project/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/kelley-sharp/hack-or-snooze-project/issues/1/comments","events_url":"https://api.github.com/repos/kelley-sharp/hack-or-snooze-project/issues/1/events","html_url":"https://github.com/kelley-sharp/hack-or-snooze-project/issues/1","id":332573197,"node_id":"MDU6SXNzdWUzMzI1NzMxOTc=","number":1,"title":"Feedback","user":{"login":"mmmaaatttttt","id":3916770,"node_id":"MDQ6VXNlcjM5MTY3NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/3916770?v=4","gravatar_id":"","url":"https://api.github.com/users/mmmaaatttttt","html_url":"https://github.com/mmmaaatttttt","followers_url":"https://api.github.com/users/mmmaaatttttt/followers","following_url":"https://api.github.com/users/mmmaaatttttt/following{/other_user}","gists_url":"https://api.github.com/users/mmmaaatttttt/gists{/gist_id}","starred_url":"https://api.github.com/users/mmmaaatttttt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmmaaatttttt/subscriptions","organizations_url":"https://api.github.com/users/mmmaaatttttt/orgs","repos_url":"https://api.github.com/users/mmmaaatttttt/repos","events_url":"https://api.github.com/users/mmmaaatttttt/events{/privacy}","received_events_url":"https://api.github.com/users/mmmaaatttttt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-14T21:36:42Z","updated_at":"2018-06-14T21:36:42Z","closed_at":null,"author_association":"NONE","body":"Hey @kelley-sharp - nice work on this! The code you've got is pretty clean and easy to read. If you ever want to revisit this project, for next steps I'd focus more on adding new features rather than refactoring a bunch of code. Here's some more specific feedback: let us know if you have any questions!\r\n\r\n**General**\r\n\r\n- [ ] Stars shouldn't appear if you aren't logged in, since only logged in users can favorite stories.\r\n- [ ] It looks like the navbar links change when you log in, but some of the functionality is broken (e.g. logging out)\r\n- [ ] Watch out with the bootstrap navbar component - on small screens the links collaps into a menu icon, but in order for the menu icon to work, you need to load the bootstrap javascript file. right now on small screens you can't access any of the navbar links.\r\n- [ ] It looks like favoriting isn't fully implemented - favorites don't persist. it would be cool to add that!\r\n- [ ] After submitting a story, it would be nice for the stories list to update automatically, right now it seems like i have to refresh the page\r\n- [ ] It's not clear that clicking on \"Profile\" when you're already on your profile will take you back to the main stories. Also, looks like the profile page can use some love :)\r\n- [ ] Nice to see a little bit of flexbox in your stylesheet!\r\n- [ ]  In the event that you add this to your portfolio, you should add a readme as well describing the project. The readme can include a description of the project, including technologies used, as well as a link to a live version of the app. This sort of bookkeeping is super helpful for recruiters who may be looking at your GitHub.\r\n\r\n**JS**\r\n\r\n- [ ] If you find yourself selecting something over and over, some selector caching might be nice. e.g. If you're grabbing `$(\"#login_link\")` over and over, it can be nice to cache the result of the selector: `let $loginLink = $(\"#login_link\")`. That way you don't need to go into the DOM over and over again to find the element.\r\n- Nice attribution [here](https://github.com/kelley-sharp/hack-or-snooze-project/blob/master/index.js#L71)!\r\n- [ ] You shouldn't need the `'json'` string [here](https://github.com/kelley-sharp/hack-or-snooze-project/blob/master/index.js#L97)"}}
{"actor":{"display_login":"mmmaaatttttt"}}