{"action":"created","issue":{"url":"https://api.github.com/repos/whitesmith/WSTagsField/issues/101","repository_url":"https://api.github.com/repos/whitesmith/WSTagsField","labels_url":"https://api.github.com/repos/whitesmith/WSTagsField/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/whitesmith/WSTagsField/issues/101/comments","events_url":"https://api.github.com/repos/whitesmith/WSTagsField/issues/101/events","html_url":"https://github.com/whitesmith/WSTagsField/issues/101","id":353301648,"node_id":"MDU6SXNzdWUzNTMzMDE2NDg=","number":101,"title":"we need to remove Observer in ios 11 - NSKeyValueObservation","user":{"login":"abufaeys","id":5054059,"node_id":"MDQ6VXNlcjUwNTQwNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/5054059?v=4","gravatar_id":"","url":"https://api.github.com/users/abufaeys","html_url":"https://github.com/abufaeys","followers_url":"https://api.github.com/users/abufaeys/followers","following_url":"https://api.github.com/users/abufaeys/following{/other_user}","gists_url":"https://api.github.com/users/abufaeys/gists{/gist_id}","starred_url":"https://api.github.com/users/abufaeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abufaeys/subscriptions","organizations_url":"https://api.github.com/users/abufaeys/orgs","repos_url":"https://api.github.com/users/abufaeys/repos","events_url":"https://api.github.com/users/abufaeys/events{/privacy}","received_events_url":"https://api.github.com/users/abufaeys/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-23T09:35:53Z","updated_at":"2018-08-28T07:32:05Z","closed_at":null,"author_association":"NONE","body":"### Which version of the WSTagsField are you using? \r\n3.1\r\n\r\n### On which platform does the issue happen? \r\niOS11\r\n\r\n### Are you using Carthage? \r\nno\r\n\r\n### Are you using Cocoapods? \r\n1.5.3\r\n\r\n### Which version of Xcode are you using? \r\nXcode 9.4.1\r\nBuild version 9F2000\r\n\r\n### What did you do?\r\n its good idea to  remove Observer in ios 11 , please check .\r\nhttps://stackoverflow.com/questions/46782372/ios-11-what-the-kvo-is-retaining-all-observers-of-this-object-if-it-crashes-an\r\n```\r\ncode :\r\ndeinit {\r\n        if ProcessInfo.processInfo.operatingSystemVersion.majorVersion < 11,let observer = layerBoundsObserver {\r\n            print(\"removeObserver\")\r\n            removeObserver(observer, forKeyPath: \"layer.bounds\")\r\n        }\r\n\r\nwe need to remove Observer in ios 11 ,so i change the code to \r\n\r\ndeinit {\r\n        if let observer = layerBoundsObserver {\r\n            print(\"removeObserver\")\r\n            removeObserver(observer, forKeyPath: \"layer.bounds\")\r\n        }\r\n\r\nthank  you"},"comment":{"url":"https://api.github.com/repos/whitesmith/WSTagsField/issues/comments/416480832","html_url":"https://github.com/whitesmith/WSTagsField/issues/101#issuecomment-416480832","issue_url":"https://api.github.com/repos/whitesmith/WSTagsField/issues/101","id":416480832,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjQ4MDgzMg==","user":{"login":"ricardopereira","id":3541185,"node_id":"MDQ6VXNlcjM1NDExODU=","avatar_url":"https://avatars1.githubusercontent.com/u/3541185?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardopereira","html_url":"https://github.com/ricardopereira","followers_url":"https://api.github.com/users/ricardopereira/followers","following_url":"https://api.github.com/users/ricardopereira/following{/other_user}","gists_url":"https://api.github.com/users/ricardopereira/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardopereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardopereira/subscriptions","organizations_url":"https://api.github.com/users/ricardopereira/orgs","repos_url":"https://api.github.com/users/ricardopereira/repos","events_url":"https://api.github.com/users/ricardopereira/events{/privacy}","received_events_url":"https://api.github.com/users/ricardopereira/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T07:32:05Z","updated_at":"2018-08-28T07:32:05Z","author_association":"MEMBER","body":"@hunasdf @abufaeys Thank you!\r\n\r\nI was convinced that iOS 11 and later would remove the `observer` automatically but if that doesn't work then I'll change the code."}}
{"actor":{"display_login":"ricardopereira"}}