{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/144","repository_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow","labels_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/144/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/144/events","html_url":"https://github.com/vaadin/vaadin-grid-flow/pull/144","id":313201930,"number":144,"title":"Add basic feature demo for grid","user":{"login":"ZheSun88","id":31067185,"avatar_url":"https://avatars2.githubusercontent.com/u/31067185?v=4","gravatar_id":"","url":"https://api.github.com/users/ZheSun88","html_url":"https://github.com/ZheSun88","followers_url":"https://api.github.com/users/ZheSun88/followers","following_url":"https://api.github.com/users/ZheSun88/following{/other_user}","gists_url":"https://api.github.com/users/ZheSun88/gists{/gist_id}","starred_url":"https://api.github.com/users/ZheSun88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZheSun88/subscriptions","organizations_url":"https://api.github.com/users/ZheSun88/orgs","repos_url":"https://api.github.com/users/ZheSun88/repos","events_url":"https://api.github.com/users/ZheSun88/events{/privacy}","received_events_url":"https://api.github.com/users/ZheSun88/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ZheSun88","id":31067185,"avatar_url":"https://avatars2.githubusercontent.com/u/31067185?v=4","gravatar_id":"","url":"https://api.github.com/users/ZheSun88","html_url":"https://github.com/ZheSun88","followers_url":"https://api.github.com/users/ZheSun88/followers","following_url":"https://api.github.com/users/ZheSun88/following{/other_user}","gists_url":"https://api.github.com/users/ZheSun88/gists{/gist_id}","starred_url":"https://api.github.com/users/ZheSun88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZheSun88/subscriptions","organizations_url":"https://api.github.com/users/ZheSun88/orgs","repos_url":"https://api.github.com/users/ZheSun88/repos","events_url":"https://api.github.com/users/ZheSun88/events{/privacy}","received_events_url":"https://api.github.com/users/ZheSun88/received_events","type":"User","site_admin":false},"assignees":[{"login":"ZheSun88","id":31067185,"avatar_url":"https://avatars2.githubusercontent.com/u/31067185?v=4","gravatar_id":"","url":"https://api.github.com/users/ZheSun88","html_url":"https://github.com/ZheSun88","followers_url":"https://api.github.com/users/ZheSun88/followers","following_url":"https://api.github.com/users/ZheSun88/following{/other_user}","gists_url":"https://api.github.com/users/ZheSun88/gists{/gist_id}","starred_url":"https://api.github.com/users/ZheSun88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZheSun88/subscriptions","organizations_url":"https://api.github.com/users/ZheSun88/orgs","repos_url":"https://api.github.com/users/ZheSun88/repos","events_url":"https://api.github.com/users/ZheSun88/events{/privacy}","received_events_url":"https://api.github.com/users/ZheSun88/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-04-11T07:20:56Z","updated_at":"2018-04-11T08:04:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/pulls/144","html_url":"https://github.com/vaadin/vaadin-grid-flow/pull/144","diff_url":"https://github.com/vaadin/vaadin-grid-flow/pull/144.diff","patch_url":"https://github.com/vaadin/vaadin-grid-flow/pull/144.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/144)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/comments/380364706","html_url":"https://github.com/vaadin/vaadin-grid-flow/pull/144#issuecomment-380364706","issue_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/144","id":380364706,"user":{"login":"gilberto-torrezan","id":7464735,"avatar_url":"https://avatars2.githubusercontent.com/u/7464735?v=4","gravatar_id":"","url":"https://api.github.com/users/gilberto-torrezan","html_url":"https://github.com/gilberto-torrezan","followers_url":"https://api.github.com/users/gilberto-torrezan/followers","following_url":"https://api.github.com/users/gilberto-torrezan/following{/other_user}","gists_url":"https://api.github.com/users/gilberto-torrezan/gists{/gist_id}","starred_url":"https://api.github.com/users/gilberto-torrezan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilberto-torrezan/subscriptions","organizations_url":"https://api.github.com/users/gilberto-torrezan/orgs","repos_url":"https://api.github.com/users/gilberto-torrezan/repos","events_url":"https://api.github.com/users/gilberto-torrezan/events{/privacy}","received_events_url":"https://api.github.com/users/gilberto-torrezan/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T08:04:53Z","updated_at":"2018-04-11T08:04:53Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReviewed 1 of 1 files at r1.\nReview status: all files reviewed at latest revision, all discussions resolved.\n\n---\n\n*[a discussion](https://beta.reviewable.io/reviews/vaadin/vaadin-grid-flow/144#-L9nipxaAcO2F0JCJ9pm:-L9nipxaAcO2F0JCJ9pn:bdwwc7f) (no related file):*\nNeeds a test just to make sure the demo is not broken. The features themselves are already tested, so only a basic test is needed (open the view, scroll to the grid, verify that the Grid has items and right number of columns, for instance).\n\n---\n\n*[src/test/java/com/vaadin/flow/component/grid/demo/GridView.java, line 913 at r1](https://beta.reviewable.io/reviews/vaadin/vaadin-grid-flow/144#-L9nie9PB6LMRf9TPH1y:-L9nie9PB6LMRf9TPH1z:b-po0fgk) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8522e638f18612efa3b3f23072b065a16ebfada1/src/test/java/com/vaadin/flow/component/grid/demo/GridView.java#L913)):*\n> ```Java\n>         final int numberOfYears = 5;\n> \n>         DecimalFormat dollarFormat = new DecimalFormat(\"$#,##0.00\");\n> ```\n\nPut this inside the viewable code, so users can copy paste it.\n\n---\n\n*[src/test/java/com/vaadin/flow/component/grid/demo/GridView.java, line 924 at r1](https://beta.reviewable.io/reviews/vaadin/vaadin-grid-flow/144#-L9niYynA-xU9UegpJ-U:-L9niYynA-xU9UegpJ-V:b-l78nzl) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8522e638f18612efa3b3f23072b065a16ebfada1/src/test/java/com/vaadin/flow/component/grid/demo/GridView.java#L924)):*\n> ```Java\n>         grid.setDataProvider(list);\n>         grid.addColumn(CompanyBudgetHistory::getCompany).setHeader(\"Company\")\n>                 .setId(\"CompanyNameColumn\");\n> ```\n\nThis Id is not used anywhere, you can remove it.\n\n---\n\n*[src/test/java/com/vaadin/flow/component/grid/demo/GridView.java, line 968 at r1](https://beta.reviewable.io/reviews/vaadin/vaadin-grid-flow/144#-L9niN3v8o4KoyNe90tx:-L9niN3v8o4KoyNe90ty:bu0l210) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8522e638f18612efa3b3f23072b065a16ebfada1/src/test/java/com/vaadin/flow/component/grid/demo/GridView.java#L968)):*\n> ```Java\n>         // end-source-example\n> \n>         grid.setId(\"grid-height-by-rows\");\n> ```\n\nThis Id was copy-pasted.\n\n---\n\n*[src/test/java/com/vaadin/flow/component/grid/demo/GridView.java, line 969 at r1](https://beta.reviewable.io/reviews/vaadin/vaadin-grid-flow/144#-L9niK4V95SQiUN_6QVF:-L9niK4V95SQiUN_6QVG:bi0773q) ([raw file](https://github.com/vaadin/vaadin-grid-flow/blob/8522e638f18612efa3b3f23072b065a16ebfada1/src/test/java/com/vaadin/flow/component/grid/demo/GridView.java#L969)):*\n> ```Java\n> \n>         grid.setId(\"grid-height-by-rows\");\n>         addCard(\"Basic Features\", \"Gird Basic Features Demo\", grid);\n> ```\n\nTypo on `Gird`\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/vaadin/vaadin-grid-flow/144)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"gilberto-torrezan"}}