{"action":"created","comment":{"url":"https://api.github.com/repos/DenisKolodin/yew/pulls/comments/180486586","pull_request_review_id":110913717,"id":180486586,"diff_hunk":"@@ -228,46 +332,56 @@ impl<CTX: 'static, COMP: Component<CTX>> VDiff for VTag<CTX, COMP> {\n         sibling\n     }\n \n-    /// Renders virtual tag over DOM `Element`, but it also compares this with an opposite `VTag`\n+    /// Renders virtual tag over DOM `Element`, but it also compares this with an ancestor `VTag`\n     /// to compute what to patch in the actual DOM nodes.\n+    ///\n+    /// Note that this does NOT actually modify the DOM -- that is done FIXME WHERE???","path":"src/virtual_dom/vtag.rs","position":196,"original_position":196,"commit_id":"1e3a878c4c8c459bbfdae4f013684d8df74a7e1d","original_commit_id":"1e3a878c4c8c459bbfdae4f013684d8df74a7e1d","user":{"login":"vitiral","id":5587659,"avatar_url":"https://avatars0.githubusercontent.com/u/5587659?v=4","gravatar_id":"","url":"https://api.github.com/users/vitiral","html_url":"https://github.com/vitiral","followers_url":"https://api.github.com/users/vitiral/followers","following_url":"https://api.github.com/users/vitiral/following{/other_user}","gists_url":"https://api.github.com/users/vitiral/gists{/gist_id}","starred_url":"https://api.github.com/users/vitiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitiral/subscriptions","organizations_url":"https://api.github.com/users/vitiral/orgs","repos_url":"https://api.github.com/users/vitiral/repos","events_url":"https://api.github.com/users/vitiral/events{/privacy}","received_events_url":"https://api.github.com/users/vitiral/received_events","type":"User","site_admin":false},"body":"I have to remove this, this _does_ modify the DOM.\r\n\r\nI still want to understand better when `self.reference` gets discarded. I'm a bit confused on that point.","created_at":"2018-04-10T16:31:48Z","updated_at":"2018-04-10T16:32:18Z","html_url":"https://github.com/DenisKolodin/yew/pull/197#discussion_r180486586","pull_request_url":"https://api.github.com/repos/DenisKolodin/yew/pulls/197","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DenisKolodin/yew/pulls/comments/180486586"},"html":{"href":"https://github.com/DenisKolodin/yew/pull/197#discussion_r180486586"},"pull_request":{"href":"https://api.github.com/repos/DenisKolodin/yew/pulls/197"}}},"pull_request":{"url":"https://api.github.com/repos/DenisKolodin/yew/pulls/197","id":180659128,"html_url":"https://github.com/DenisKolodin/yew/pull/197","diff_url":"https://github.com/DenisKolodin/yew/pull/197.diff","patch_url":"https://github.com/DenisKolodin/yew/pull/197.patch","issue_url":"https://api.github.com/repos/DenisKolodin/yew/issues/197","number":197,"state":"open","locked":false,"title":"add docs around `apply()` for VTag and items it depends on.","user":{"login":"vitiral","id":5587659,"avatar_url":"https://avatars0.githubusercontent.com/u/5587659?v=4","gravatar_id":"","url":"https://api.github.com/users/vitiral","html_url":"https://github.com/vitiral","followers_url":"https://api.github.com/users/vitiral/followers","following_url":"https://api.github.com/users/vitiral/following{/other_user}","gists_url":"https://api.github.com/users/vitiral/gists{/gist_id}","starred_url":"https://api.github.com/users/vitiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitiral/subscriptions","organizations_url":"https://api.github.com/users/vitiral/orgs","repos_url":"https://api.github.com/users/vitiral/repos","events_url":"https://api.github.com/users/vitiral/events{/privacy}","received_events_url":"https://api.github.com/users/vitiral/received_events","type":"User","site_admin":false},"body":"This is part of an effort to make this library more contributor friendly\r\n(I would like to contribute but am having trouble understanding the\r\nsource code as it is written).","created_at":"2018-04-10T16:26:59Z","updated_at":"2018-04-10T16:32:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DenisKolodin/yew/pulls/197/commits","review_comments_url":"https://api.github.com/repos/DenisKolodin/yew/pulls/197/comments","review_comment_url":"https://api.github.com/repos/DenisKolodin/yew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DenisKolodin/yew/issues/197/comments","statuses_url":"https://api.github.com/repos/DenisKolodin/yew/statuses/1e3a878c4c8c459bbfdae4f013684d8df74a7e1d","head":{"label":"vitiral:notes","ref":"notes","sha":"1e3a878c4c8c459bbfdae4f013684d8df74a7e1d","user":{"login":"vitiral","id":5587659,"avatar_url":"https://avatars0.githubusercontent.com/u/5587659?v=4","gravatar_id":"","url":"https://api.github.com/users/vitiral","html_url":"https://github.com/vitiral","followers_url":"https://api.github.com/users/vitiral/followers","following_url":"https://api.github.com/users/vitiral/following{/other_user}","gists_url":"https://api.github.com/users/vitiral/gists{/gist_id}","starred_url":"https://api.github.com/users/vitiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitiral/subscriptions","organizations_url":"https://api.github.com/users/vitiral/orgs","repos_url":"https://api.github.com/users/vitiral/repos","events_url":"https://api.github.com/users/vitiral/events{/privacy}","received_events_url":"https://api.github.com/users/vitiral/received_events","type":"User","site_admin":false},"repo":{"id":128274278,"name":"yew","full_name":"vitiral/yew","owner":{"login":"vitiral","id":5587659,"avatar_url":"https://avatars0.githubusercontent.com/u/5587659?v=4","gravatar_id":"","url":"https://api.github.com/users/vitiral","html_url":"https://github.com/vitiral","followers_url":"https://api.github.com/users/vitiral/followers","following_url":"https://api.github.com/users/vitiral/following{/other_user}","gists_url":"https://api.github.com/users/vitiral/gists{/gist_id}","starred_url":"https://api.github.com/users/vitiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitiral/subscriptions","organizations_url":"https://api.github.com/users/vitiral/orgs","repos_url":"https://api.github.com/users/vitiral/repos","events_url":"https://api.github.com/users/vitiral/events{/privacy}","received_events_url":"https://api.github.com/users/vitiral/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitiral/yew","description":"Rust framework for making client web apps","fork":true,"url":"https://api.github.com/repos/vitiral/yew","forks_url":"https://api.github.com/repos/vitiral/yew/forks","keys_url":"https://api.github.com/repos/vitiral/yew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitiral/yew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitiral/yew/teams","hooks_url":"https://api.github.com/repos/vitiral/yew/hooks","issue_events_url":"https://api.github.com/repos/vitiral/yew/issues/events{/number}","events_url":"https://api.github.com/repos/vitiral/yew/events","assignees_url":"https://api.github.com/repos/vitiral/yew/assignees{/user}","branches_url":"https://api.github.com/repos/vitiral/yew/branches{/branch}","tags_url":"https://api.github.com/repos/vitiral/yew/tags","blobs_url":"https://api.github.com/repos/vitiral/yew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitiral/yew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitiral/yew/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitiral/yew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitiral/yew/statuses/{sha}","languages_url":"https://api.github.com/repos/vitiral/yew/languages","stargazers_url":"https://api.github.com/repos/vitiral/yew/stargazers","contributors_url":"https://api.github.com/repos/vitiral/yew/contributors","subscribers_url":"https://api.github.com/repos/vitiral/yew/subscribers","subscription_url":"https://api.github.com/repos/vitiral/yew/subscription","commits_url":"https://api.github.com/repos/vitiral/yew/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitiral/yew/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitiral/yew/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitiral/yew/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitiral/yew/contents/{+path}","compare_url":"https://api.github.com/repos/vitiral/yew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitiral/yew/merges","archive_url":"https://api.github.com/repos/vitiral/yew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitiral/yew/downloads","issues_url":"https://api.github.com/repos/vitiral/yew/issues{/number}","pulls_url":"https://api.github.com/repos/vitiral/yew/pulls{/number}","milestones_url":"https://api.github.com/repos/vitiral/yew/milestones{/number}","notifications_url":"https://api.github.com/repos/vitiral/yew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitiral/yew/labels{/name}","releases_url":"https://api.github.com/repos/vitiral/yew/releases{/id}","deployments_url":"https://api.github.com/repos/vitiral/yew/deployments","created_at":"2018-04-05T23:11:07Z","updated_at":"2018-04-05T23:11:09Z","pushed_at":"2018-04-10T16:26:15Z","git_url":"git://github.com/vitiral/yew.git","ssh_url":"git@github.com:vitiral/yew.git","clone_url":"https://github.com/vitiral/yew.git","svn_url":"https://github.com/vitiral/yew","homepage":"","size":479,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DenisKolodin:master","ref":"master","sha":"aa48335a831ca9769774db07222f02da69e56aa7","user":{"login":"DenisKolodin","id":418920,"avatar_url":"https://avatars3.githubusercontent.com/u/418920?v=4","gravatar_id":"","url":"https://api.github.com/users/DenisKolodin","html_url":"https://github.com/DenisKolodin","followers_url":"https://api.github.com/users/DenisKolodin/followers","following_url":"https://api.github.com/users/DenisKolodin/following{/other_user}","gists_url":"https://api.github.com/users/DenisKolodin/gists{/gist_id}","starred_url":"https://api.github.com/users/DenisKolodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenisKolodin/subscriptions","organizations_url":"https://api.github.com/users/DenisKolodin/orgs","repos_url":"https://api.github.com/users/DenisKolodin/repos","events_url":"https://api.github.com/users/DenisKolodin/events{/privacy}","received_events_url":"https://api.github.com/users/DenisKolodin/received_events","type":"User","site_admin":false},"repo":{"id":114466145,"name":"yew","full_name":"DenisKolodin/yew","owner":{"login":"DenisKolodin","id":418920,"avatar_url":"https://avatars3.githubusercontent.com/u/418920?v=4","gravatar_id":"","url":"https://api.github.com/users/DenisKolodin","html_url":"https://github.com/DenisKolodin","followers_url":"https://api.github.com/users/DenisKolodin/followers","following_url":"https://api.github.com/users/DenisKolodin/following{/other_user}","gists_url":"https://api.github.com/users/DenisKolodin/gists{/gist_id}","starred_url":"https://api.github.com/users/DenisKolodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenisKolodin/subscriptions","organizations_url":"https://api.github.com/users/DenisKolodin/orgs","repos_url":"https://api.github.com/users/DenisKolodin/repos","events_url":"https://api.github.com/users/DenisKolodin/events{/privacy}","received_events_url":"https://api.github.com/users/DenisKolodin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DenisKolodin/yew","description":"Rust framework for making client web apps","fork":false,"url":"https://api.github.com/repos/DenisKolodin/yew","forks_url":"https://api.github.com/repos/DenisKolodin/yew/forks","keys_url":"https://api.github.com/repos/DenisKolodin/yew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DenisKolodin/yew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DenisKolodin/yew/teams","hooks_url":"https://api.github.com/repos/DenisKolodin/yew/hooks","issue_events_url":"https://api.github.com/repos/DenisKolodin/yew/issues/events{/number}","events_url":"https://api.github.com/repos/DenisKolodin/yew/events","assignees_url":"https://api.github.com/repos/DenisKolodin/yew/assignees{/user}","branches_url":"https://api.github.com/repos/DenisKolodin/yew/branches{/branch}","tags_url":"https://api.github.com/repos/DenisKolodin/yew/tags","blobs_url":"https://api.github.com/repos/DenisKolodin/yew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DenisKolodin/yew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DenisKolodin/yew/git/refs{/sha}","trees_url":"https://api.github.com/repos/DenisKolodin/yew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DenisKolodin/yew/statuses/{sha}","languages_url":"https://api.github.com/repos/DenisKolodin/yew/languages","stargazers_url":"https://api.github.com/repos/DenisKolodin/yew/stargazers","contributors_url":"https://api.github.com/repos/DenisKolodin/yew/contributors","subscribers_url":"https://api.github.com/repos/DenisKolodin/yew/subscribers","subscription_url":"https://api.github.com/repos/DenisKolodin/yew/subscription","commits_url":"https://api.github.com/repos/DenisKolodin/yew/commits{/sha}","git_commits_url":"https://api.github.com/repos/DenisKolodin/yew/git/commits{/sha}","comments_url":"https://api.github.com/repos/DenisKolodin/yew/comments{/number}","issue_comment_url":"https://api.github.com/repos/DenisKolodin/yew/issues/comments{/number}","contents_url":"https://api.github.com/repos/DenisKolodin/yew/contents/{+path}","compare_url":"https://api.github.com/repos/DenisKolodin/yew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DenisKolodin/yew/merges","archive_url":"https://api.github.com/repos/DenisKolodin/yew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DenisKolodin/yew/downloads","issues_url":"https://api.github.com/repos/DenisKolodin/yew/issues{/number}","pulls_url":"https://api.github.com/repos/DenisKolodin/yew/pulls{/number}","milestones_url":"https://api.github.com/repos/DenisKolodin/yew/milestones{/number}","notifications_url":"https://api.github.com/repos/DenisKolodin/yew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DenisKolodin/yew/labels{/name}","releases_url":"https://api.github.com/repos/DenisKolodin/yew/releases{/id}","deployments_url":"https://api.github.com/repos/DenisKolodin/yew/deployments","created_at":"2017-12-16T14:19:02Z","updated_at":"2018-04-10T15:54:51Z","pushed_at":"2018-04-10T16:27:00Z","git_url":"git://github.com/DenisKolodin/yew.git","ssh_url":"git@github.com:DenisKolodin/yew.git","clone_url":"https://github.com/DenisKolodin/yew.git","svn_url":"https://github.com/DenisKolodin/yew","homepage":"","size":514,"stargazers_count":3793,"watchers_count":3793,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":67,"license":null,"forks":119,"open_issues":67,"watchers":3793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DenisKolodin/yew/pulls/197"},"html":{"href":"https://github.com/DenisKolodin/yew/pull/197"},"issue":{"href":"https://api.github.com/repos/DenisKolodin/yew/issues/197"},"comments":{"href":"https://api.github.com/repos/DenisKolodin/yew/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/DenisKolodin/yew/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/DenisKolodin/yew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DenisKolodin/yew/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/DenisKolodin/yew/statuses/1e3a878c4c8c459bbfdae4f013684d8df74a7e1d"}},"author_association":"NONE"}}
{"actor":{"display_login":"vitiral"}}