{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-demo-helpers/issues/25","repository_url":"https://api.github.com/repos/vaadin/vaadin-demo-helpers","labels_url":"https://api.github.com/repos/vaadin/vaadin-demo-helpers/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-demo-helpers/issues/25/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-demo-helpers/issues/25/events","html_url":"https://github.com/vaadin/vaadin-demo-helpers/pull/25","id":305641351,"number":25,"title":"Update development mode detection","user":{"login":"web-padawan","id":10589913,"avatar_url":"https://avatars2.githubusercontent.com/u/10589913?v=4","gravatar_id":"","url":"https://api.github.com/users/web-padawan","html_url":"https://github.com/web-padawan","followers_url":"https://api.github.com/users/web-padawan/followers","following_url":"https://api.github.com/users/web-padawan/following{/other_user}","gists_url":"https://api.github.com/users/web-padawan/gists{/gist_id}","starred_url":"https://api.github.com/users/web-padawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-padawan/subscriptions","organizations_url":"https://api.github.com/users/web-padawan/orgs","repos_url":"https://api.github.com/users/web-padawan/repos","events_url":"https://api.github.com/users/web-padawan/events{/privacy}","received_events_url":"https://api.github.com/users/web-padawan/received_events","type":"User","site_admin":false},"labels":[{"id":724801665,"url":"https://api.github.com/repos/vaadin/vaadin-demo-helpers/labels/in%20review","name":"in review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-15T17:07:39Z","updated_at":"2018-03-16T10:23:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-demo-helpers/pulls/25","html_url":"https://github.com/vaadin/vaadin-demo-helpers/pull/25","diff_url":"https://github.com/vaadin/vaadin-demo-helpers/pull/25.diff","patch_url":"https://github.com/vaadin/vaadin-demo-helpers/pull/25.patch"},"body":"Fixes #24 \r\n\r\nActually, the only difference in `baseHref` is now `demo` for the local or CDN, and `html-examples` for vaadin.com\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-demo-helpers/25)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-demo-helpers/issues/comments/373669859","html_url":"https://github.com/vaadin/vaadin-demo-helpers/pull/25#issuecomment-373669859","issue_url":"https://api.github.com/repos/vaadin/vaadin-demo-helpers/issues/25","id":373669859,"user":{"login":"platosha","id":247998,"avatar_url":"https://avatars1.githubusercontent.com/u/247998?v=4","gravatar_id":"","url":"https://api.github.com/users/platosha","html_url":"https://github.com/platosha","followers_url":"https://api.github.com/users/platosha/followers","following_url":"https://api.github.com/users/platosha/following{/other_user}","gists_url":"https://api.github.com/users/platosha/gists{/gist_id}","starred_url":"https://api.github.com/users/platosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platosha/subscriptions","organizations_url":"https://api.github.com/users/platosha/orgs","repos_url":"https://api.github.com/users/platosha/repos","events_url":"https://api.github.com/users/platosha/events{/privacy}","received_events_url":"https://api.github.com/users/platosha/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T10:23:23Z","updated_at":"2018-03-16T10:23:23Z","author_association":"NONE","body":"\n\n\n\nReviewed 1 of 1 files at r1.\nReview status: all files reviewed at latest revision, all discussions resolved.\n\n---\n\n*[vaadin-component-demo.html, line 165 at r1](https://beta.reviewable.io/reviews/vaadin/vaadin-demo-helpers/25#-L7iKSAi0LolQjwV94zS:-L7iKSAi0LolQjwV94zT:b-39kvne) ([raw file](https://github.com/vaadin/vaadin-demo-helpers/blob/25337a10e7c4334551dc7a112039443a264a2729/vaadin-component-demo.html#L165)):*\n> ```HTML\n>       _isDevMode(baseHref) {\n>         // FIXME: find a better way to detect when demo is running in flow\n>         return /^cdn|appspot\\.com$/.test(location.hostname) || /\\/components\\/[a-z\\-]+\\/demo/.test(baseHref);\n> ```\n\nShould we accounts for tests too? `/(demo|test)/`?\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/vaadin/vaadin-demo-helpers/25)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"platosha"}}