{"action":"closed","number":3288,"pull_request":{"url":"https://api.github.com/repos/VSCodeVim/Vim/pulls/3288","id":240670050,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjcwMDUw","html_url":"https://github.com/VSCodeVim/Vim/pull/3288","diff_url":"https://github.com/VSCodeVim/Vim/pull/3288.diff","patch_url":"https://github.com/VSCodeVim/Vim/pull/3288.patch","issue_url":"https://api.github.com/repos/VSCodeVim/Vim/issues/3288","number":3288,"state":"closed","locked":false,"title":"fix: disable nvim shada","user":{"login":"jpoon","id":85374,"node_id":"MDQ6VXNlcjg1Mzc0","avatar_url":"https://avatars3.githubusercontent.com/u/85374?v=4","gravatar_id":"","url":"https://api.github.com/users/jpoon","html_url":"https://github.com/jpoon","followers_url":"https://api.github.com/users/jpoon/followers","following_url":"https://api.github.com/users/jpoon/following{/other_user}","gists_url":"https://api.github.com/users/jpoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jpoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpoon/subscriptions","organizations_url":"https://api.github.com/users/jpoon/orgs","repos_url":"https://api.github.com/users/jpoon/repos","events_url":"https://api.github.com/users/jpoon/events{/privacy}","received_events_url":"https://api.github.com/users/jpoon/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nAs recommended https://github.com/VSCodeVim/Vim/issues/3013#issuecomment-429335777, disable shada. @justinmk's second point has already been addressed: https://github.com/VSCodeVim/Vim/blob/master/src/neovim/neovim.ts#L32\r\n\r\n**Which issue(s) this PR fixes**\r\nhttps://github.com/VSCodeVim/Vim/issues/3013\r\n\r\n<!--\r\nCommits in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)\r\n-->\r\n\r\n**Special notes for your reviewer**:\r\n","created_at":"2018-12-23T07:46:42Z","updated_at":"2018-12-23T07:53:45Z","closed_at":"2018-12-23T07:53:45Z","merged_at":"2018-12-23T07:53:45Z","merge_commit_sha":"09886c548cca1268fae3dfa71b46d5bedca27b47","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VSCodeVim/Vim/pulls/3288/commits","review_comments_url":"https://api.github.com/repos/VSCodeVim/Vim/pulls/3288/comments","review_comment_url":"https://api.github.com/repos/VSCodeVim/Vim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VSCodeVim/Vim/issues/3288/comments","statuses_url":"https://api.github.com/repos/VSCodeVim/Vim/statuses/217d10beea0e44e41617c7e1cc9a8765749a4fe1","head":{"label":"VSCodeVim:disable_shada","ref":"disable_shada","sha":"217d10beea0e44e41617c7e1cc9a8765749a4fe1","user":{"login":"VSCodeVim","id":15813386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODEzMzg2","avatar_url":"https://avatars1.githubusercontent.com/u/15813386?v=4","gravatar_id":"","url":"https://api.github.com/users/VSCodeVim","html_url":"https://github.com/VSCodeVim","followers_url":"https://api.github.com/users/VSCodeVim/followers","following_url":"https://api.github.com/users/VSCodeVim/following{/other_user}","gists_url":"https://api.github.com/users/VSCodeVim/gists{/gist_id}","starred_url":"https://api.github.com/users/VSCodeVim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSCodeVim/subscriptions","organizations_url":"https://api.github.com/users/VSCodeVim/orgs","repos_url":"https://api.github.com/users/VSCodeVim/repos","events_url":"https://api.github.com/users/VSCodeVim/events{/privacy}","received_events_url":"https://api.github.com/users/VSCodeVim/received_events","type":"Organization","site_admin":false},"repo":{"id":46041284,"node_id":"MDEwOlJlcG9zaXRvcnk0NjA0MTI4NA==","name":"Vim","full_name":"VSCodeVim/Vim","private":false,"owner":{"login":"VSCodeVim","id":15813386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODEzMzg2","avatar_url":"https://avatars1.githubusercontent.com/u/15813386?v=4","gravatar_id":"","url":"https://api.github.com/users/VSCodeVim","html_url":"https://github.com/VSCodeVim","followers_url":"https://api.github.com/users/VSCodeVim/followers","following_url":"https://api.github.com/users/VSCodeVim/following{/other_user}","gists_url":"https://api.github.com/users/VSCodeVim/gists{/gist_id}","starred_url":"https://api.github.com/users/VSCodeVim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSCodeVim/subscriptions","organizations_url":"https://api.github.com/users/VSCodeVim/orgs","repos_url":"https://api.github.com/users/VSCodeVim/repos","events_url":"https://api.github.com/users/VSCodeVim/events{/privacy}","received_events_url":"https://api.github.com/users/VSCodeVim/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VSCodeVim/Vim","description":":star: Vim for Visual Studio Code","fork":false,"url":"https://api.github.com/repos/VSCodeVim/Vim","forks_url":"https://api.github.com/repos/VSCodeVim/Vim/forks","keys_url":"https://api.github.com/repos/VSCodeVim/Vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VSCodeVim/Vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VSCodeVim/Vim/teams","hooks_url":"https://api.github.com/repos/VSCodeVim/Vim/hooks","issue_events_url":"https://api.github.com/repos/VSCodeVim/Vim/issues/events{/number}","events_url":"https://api.github.com/repos/VSCodeVim/Vim/events","assignees_url":"https://api.github.com/repos/VSCodeVim/Vim/assignees{/user}","branches_url":"https://api.github.com/repos/VSCodeVim/Vim/branches{/branch}","tags_url":"https://api.github.com/repos/VSCodeVim/Vim/tags","blobs_url":"https://api.github.com/repos/VSCodeVim/Vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VSCodeVim/Vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VSCodeVim/Vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/VSCodeVim/Vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VSCodeVim/Vim/statuses/{sha}","languages_url":"https://api.github.com/repos/VSCodeVim/Vim/languages","stargazers_url":"https://api.github.com/repos/VSCodeVim/Vim/stargazers","contributors_url":"https://api.github.com/repos/VSCodeVim/Vim/contributors","subscribers_url":"https://api.github.com/repos/VSCodeVim/Vim/subscribers","subscription_url":"https://api.github.com/repos/VSCodeVim/Vim/subscription","commits_url":"https://api.github.com/repos/VSCodeVim/Vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/VSCodeVim/Vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/VSCodeVim/Vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/VSCodeVim/Vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/VSCodeVim/Vim/contents/{+path}","compare_url":"https://api.github.com/repos/VSCodeVim/Vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VSCodeVim/Vim/merges","archive_url":"https://api.github.com/repos/VSCodeVim/Vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VSCodeVim/Vim/downloads","issues_url":"https://api.github.com/repos/VSCodeVim/Vim/issues{/number}","pulls_url":"https://api.github.com/repos/VSCodeVim/Vim/pulls{/number}","milestones_url":"https://api.github.com/repos/VSCodeVim/Vim/milestones{/number}","notifications_url":"https://api.github.com/repos/VSCodeVim/Vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VSCodeVim/Vim/labels{/name}","releases_url":"https://api.github.com/repos/VSCodeVim/Vim/releases{/id}","deployments_url":"https://api.github.com/repos/VSCodeVim/Vim/deployments","created_at":"2015-11-12T09:02:23Z","updated_at":"2018-12-23T07:05:01Z","pushed_at":"2018-12-23T07:53:45Z","git_url":"git://github.com/VSCodeVim/Vim.git","ssh_url":"git@github.com:VSCodeVim/Vim.git","clone_url":"https://github.com/VSCodeVim/Vim.git","svn_url":"https://github.com/VSCodeVim/Vim","homepage":"http://aka.ms/vscodevim","size":8949,"stargazers_count":4484,"watchers_count":4484,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":470,"mirror_url":null,"archived":false,"open_issues_count":563,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":470,"open_issues":563,"watchers":4484,"default_branch":"master"}},"base":{"label":"VSCodeVim:master","ref":"master","sha":"954cdd9ff1834972c8296f62605dfa4243a0fea8","user":{"login":"VSCodeVim","id":15813386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODEzMzg2","avatar_url":"https://avatars1.githubusercontent.com/u/15813386?v=4","gravatar_id":"","url":"https://api.github.com/users/VSCodeVim","html_url":"https://github.com/VSCodeVim","followers_url":"https://api.github.com/users/VSCodeVim/followers","following_url":"https://api.github.com/users/VSCodeVim/following{/other_user}","gists_url":"https://api.github.com/users/VSCodeVim/gists{/gist_id}","starred_url":"https://api.github.com/users/VSCodeVim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSCodeVim/subscriptions","organizations_url":"https://api.github.com/users/VSCodeVim/orgs","repos_url":"https://api.github.com/users/VSCodeVim/repos","events_url":"https://api.github.com/users/VSCodeVim/events{/privacy}","received_events_url":"https://api.github.com/users/VSCodeVim/received_events","type":"Organization","site_admin":false},"repo":{"id":46041284,"node_id":"MDEwOlJlcG9zaXRvcnk0NjA0MTI4NA==","name":"Vim","full_name":"VSCodeVim/Vim","private":false,"owner":{"login":"VSCodeVim","id":15813386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODEzMzg2","avatar_url":"https://avatars1.githubusercontent.com/u/15813386?v=4","gravatar_id":"","url":"https://api.github.com/users/VSCodeVim","html_url":"https://github.com/VSCodeVim","followers_url":"https://api.github.com/users/VSCodeVim/followers","following_url":"https://api.github.com/users/VSCodeVim/following{/other_user}","gists_url":"https://api.github.com/users/VSCodeVim/gists{/gist_id}","starred_url":"https://api.github.com/users/VSCodeVim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSCodeVim/subscriptions","organizations_url":"https://api.github.com/users/VSCodeVim/orgs","repos_url":"https://api.github.com/users/VSCodeVim/repos","events_url":"https://api.github.com/users/VSCodeVim/events{/privacy}","received_events_url":"https://api.github.com/users/VSCodeVim/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VSCodeVim/Vim","description":":star: Vim for Visual Studio Code","fork":false,"url":"https://api.github.com/repos/VSCodeVim/Vim","forks_url":"https://api.github.com/repos/VSCodeVim/Vim/forks","keys_url":"https://api.github.com/repos/VSCodeVim/Vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VSCodeVim/Vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VSCodeVim/Vim/teams","hooks_url":"https://api.github.com/repos/VSCodeVim/Vim/hooks","issue_events_url":"https://api.github.com/repos/VSCodeVim/Vim/issues/events{/number}","events_url":"https://api.github.com/repos/VSCodeVim/Vim/events","assignees_url":"https://api.github.com/repos/VSCodeVim/Vim/assignees{/user}","branches_url":"https://api.github.com/repos/VSCodeVim/Vim/branches{/branch}","tags_url":"https://api.github.com/repos/VSCodeVim/Vim/tags","blobs_url":"https://api.github.com/repos/VSCodeVim/Vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VSCodeVim/Vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VSCodeVim/Vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/VSCodeVim/Vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VSCodeVim/Vim/statuses/{sha}","languages_url":"https://api.github.com/repos/VSCodeVim/Vim/languages","stargazers_url":"https://api.github.com/repos/VSCodeVim/Vim/stargazers","contributors_url":"https://api.github.com/repos/VSCodeVim/Vim/contributors","subscribers_url":"https://api.github.com/repos/VSCodeVim/Vim/subscribers","subscription_url":"https://api.github.com/repos/VSCodeVim/Vim/subscription","commits_url":"https://api.github.com/repos/VSCodeVim/Vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/VSCodeVim/Vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/VSCodeVim/Vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/VSCodeVim/Vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/VSCodeVim/Vim/contents/{+path}","compare_url":"https://api.github.com/repos/VSCodeVim/Vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VSCodeVim/Vim/merges","archive_url":"https://api.github.com/repos/VSCodeVim/Vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VSCodeVim/Vim/downloads","issues_url":"https://api.github.com/repos/VSCodeVim/Vim/issues{/number}","pulls_url":"https://api.github.com/repos/VSCodeVim/Vim/pulls{/number}","milestones_url":"https://api.github.com/repos/VSCodeVim/Vim/milestones{/number}","notifications_url":"https://api.github.com/repos/VSCodeVim/Vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VSCodeVim/Vim/labels{/name}","releases_url":"https://api.github.com/repos/VSCodeVim/Vim/releases{/id}","deployments_url":"https://api.github.com/repos/VSCodeVim/Vim/deployments","created_at":"2015-11-12T09:02:23Z","updated_at":"2018-12-23T07:05:01Z","pushed_at":"2018-12-23T07:53:45Z","git_url":"git://github.com/VSCodeVim/Vim.git","ssh_url":"git@github.com:VSCodeVim/Vim.git","clone_url":"https://github.com/VSCodeVim/Vim.git","svn_url":"https://github.com/VSCodeVim/Vim","homepage":"http://aka.ms/vscodevim","size":8949,"stargazers_count":4484,"watchers_count":4484,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":470,"mirror_url":null,"archived":false,"open_issues_count":563,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":470,"open_issues":563,"watchers":4484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VSCodeVim/Vim/pulls/3288"},"html":{"href":"https://github.com/VSCodeVim/Vim/pull/3288"},"issue":{"href":"https://api.github.com/repos/VSCodeVim/Vim/issues/3288"},"comments":{"href":"https://api.github.com/repos/VSCodeVim/Vim/issues/3288/comments"},"review_comments":{"href":"https://api.github.com/repos/VSCodeVim/Vim/pulls/3288/comments"},"review_comment":{"href":"https://api.github.com/repos/VSCodeVim/Vim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VSCodeVim/Vim/pulls/3288/commits"},"statuses":{"href":"https://api.github.com/repos/VSCodeVim/Vim/statuses/217d10beea0e44e41617c7e1cc9a8765749a4fe1"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jpoon","id":85374,"node_id":"MDQ6VXNlcjg1Mzc0","avatar_url":"https://avatars3.githubusercontent.com/u/85374?v=4","gravatar_id":"","url":"https://api.github.com/users/jpoon","html_url":"https://github.com/jpoon","followers_url":"https://api.github.com/users/jpoon/followers","following_url":"https://api.github.com/users/jpoon/following{/other_user}","gists_url":"https://api.github.com/users/jpoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jpoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpoon/subscriptions","organizations_url":"https://api.github.com/users/jpoon/orgs","repos_url":"https://api.github.com/users/jpoon/repos","events_url":"https://api.github.com/users/jpoon/events{/privacy}","received_events_url":"https://api.github.com/users/jpoon/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"jpoon"}}