{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/opm-common/issues/382","repository_url":"https://api.github.com/repos/OPM/opm-common","labels_url":"https://api.github.com/repos/OPM/opm-common/issues/382/labels{/name}","comments_url":"https://api.github.com/repos/OPM/opm-common/issues/382/comments","events_url":"https://api.github.com/repos/OPM/opm-common/issues/382/events","html_url":"https://github.com/OPM/opm-common/pull/382","id":314952920,"number":382,"title":"Add Initial Implementation of Correctly Sized Header Vectors for Restart","user":{"login":"bska","id":1871438,"avatar_url":"https://avatars0.githubusercontent.com/u/1871438?v=4","gravatar_id":"","url":"https://api.github.com/users/bska","html_url":"https://github.com/bska","followers_url":"https://api.github.com/users/bska/followers","following_url":"https://api.github.com/users/bska/following{/other_user}","gists_url":"https://api.github.com/users/bska/gists{/gist_id}","starred_url":"https://api.github.com/users/bska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bska/subscriptions","organizations_url":"https://api.github.com/users/bska/orgs","repos_url":"https://api.github.com/users/bska/repos","events_url":"https://api.github.com/users/bska/events{/privacy}","received_events_url":"https://api.github.com/users/bska/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-04-17T08:19:37Z","updated_at":"2018-04-17T19:16:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/OPM/opm-common/pulls/382","html_url":"https://github.com/OPM/opm-common/pull/382","diff_url":"https://github.com/OPM/opm-common/pull/382.diff","patch_url":"https://github.com/OPM/opm-common/pull/382.patch"},"body":"This is the result of a collaboration between myself and @jalvestad together with reservoir engineers at Statoil.\r\n\r\nThis change-set adds code to construct correctly sized `INTEHEAD`, `LOGIHEAD`, and `DOUBHEAD` header vectors and to fill in the contents of these vectors to the best of our knowledge.  We do not fill all items of the vectors and do not, at this time, activate the new code in [`RestartIO::save()`](https://github.com/OPM/opm-common/blob/master/src/opm/output/eclipse/RestartIO.cpp#L563-L572).  Activating this code will be the subject of a future pull request, once we have similar support for the `xWEL` vectors (`IWEL`, `SWEL`, `XWEL`, and `ZWEL`), and definitely not before the OPM 2018.04 release process is complete."},"comment":{"url":"https://api.github.com/repos/OPM/opm-common/issues/comments/382109788","html_url":"https://github.com/OPM/opm-common/pull/382#issuecomment-382109788","issue_url":"https://api.github.com/repos/OPM/opm-common/issues/382","id":382109788,"user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars3.githubusercontent.com/u/1321665?v=4","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T19:16:59Z","updated_at":"2018-04-17T19:16:59Z","author_association":"MEMBER","body":"Well - engineered; maybe over the top for one-off classes? But a joy to read anyway. I would like the following changes before merging:\r\n\r\nThe time step is a surprisingly difficult concept, and there are already bugs in current master, of which I am guilty[1]. For that reason I would like a very strict policy on:\r\n\r\n1. All time steps should have a prefix, the current PR has both `report_step`, `rptStep` and `step` for what is the same quantity - I suggest sticking to `report_step`.\r\n\r\n2. The \"other timestep\" - typically the index used to look up active wells and so on should also get a proper prefix - I have suggested `sim_step` - you might have a better alternative, instead of just `report_step - 1`.\r\n\r\nThe PR has quite many magic integers, they should get a name.\r\n\r\n\r\n[1]: Incidentally these two PR's: https://github.com/OPM/opm-common/pull/383 and https://github.com/OPM/opm-simulators/pull/1460 address exactly that."}}
{"actor":{"display_login":"joakim-hove"}}