{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/243378780","pull_request_review_id":187134373,"id":243378780,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzM3ODc4MA==","diff_hunk":"@@ -14,7 +14,7 @@ def initialize(path, substitutions)\n         @substitutions = substitutions\n         @path = path\n         @resolved = []\n-        generate_substitutions_from_path if @substitutions.empty?\n+        generate_substitutions_from_path if @substitutions.empty? && substitutions_needed.empty?","path":"app/lib/katello/util/path_with_substitutions.rb","position":13,"original_position":5,"commit_id":"8bc68b2ee4b045e46a5b79ac5dfd94bb30b3de6d","original_commit_id":"8bc68b2ee4b045e46a5b79ac5dfd94bb30b3de6d","user":{"login":"jlsherrill","id":395077,"node_id":"MDQ6VXNlcjM5NTA3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/395077?v=4","gravatar_id":"","url":"https://api.github.com/users/jlsherrill","html_url":"https://github.com/jlsherrill","followers_url":"https://api.github.com/users/jlsherrill/followers","following_url":"https://api.github.com/users/jlsherrill/following{/other_user}","gists_url":"https://api.github.com/users/jlsherrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jlsherrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlsherrill/subscriptions","organizations_url":"https://api.github.com/users/jlsherrill/orgs","repos_url":"https://api.github.com/users/jlsherrill/repos","events_url":"https://api.github.com/users/jlsherrill/events{/privacy}","received_events_url":"https://api.github.com/users/jlsherrill/received_events","type":"User","site_admin":false},"body":"How would this handle if you had a url like:   /content/$releasever/x86_64/,  wouldn't that fail to extract the substitutions?   Would it make more sense to check for the presence  of $basearch  specifically?","created_at":"2018-12-20T18:47:47Z","updated_at":"2018-12-20T18:47:48Z","html_url":"https://github.com/Katello/katello/pull/7882#discussion_r243378780","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/7882","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/243378780"},"html":{"href":"https://github.com/Katello/katello/pull/7882#discussion_r243378780"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/7882"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/7882","id":237831974,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODMxOTc0","html_url":"https://github.com/Katello/katello/pull/7882","diff_url":"https://github.com/Katello/katello/pull/7882.diff","patch_url":"https://github.com/Katello/katello/pull/7882.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/7882","number":7882,"state":"open","locked":false,"title":"Fixes #25224 - Fix RHEL8 arches in RH repo page","user":{"login":"johnpmitsch","id":5964462,"node_id":"MDQ6VXNlcjU5NjQ0NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5964462?v=4","gravatar_id":"","url":"https://api.github.com/users/johnpmitsch","html_url":"https://github.com/johnpmitsch","followers_url":"https://api.github.com/users/johnpmitsch/followers","following_url":"https://api.github.com/users/johnpmitsch/following{/other_user}","gists_url":"https://api.github.com/users/johnpmitsch/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpmitsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpmitsch/subscriptions","organizations_url":"https://api.github.com/users/johnpmitsch/orgs","repos_url":"https://api.github.com/users/johnpmitsch/repos","events_url":"https://api.github.com/users/johnpmitsch/events{/privacy}","received_events_url":"https://api.github.com/users/johnpmitsch/received_events","type":"User","site_admin":false},"body":"RHEL8 paths in the CDN no longer use substitutions, i.e.\r\n$basearch. The paths are now fixed, set paths that looks\r\nlike \"content/dist/rhel8/8.0/x86_64/baseos/os/\"\r\n\r\nWe make a lot of assumptions on  both the back-end and\r\nfront-end that the EL6 and EL7 substitution paths exist.\r\nBecause of this, I added methods to grab the info from\r\nthe url and add it to the substitutions hash we have\r\nbeen using.\r\n\r\nTo review, check that:\r\n- EL5, 6, and 7 repos act as expected on the RH repos page\r\n- You can now view the arch for the RHEL8 repos","created_at":"2018-12-11T21:24:23Z","updated_at":"2018-12-20T18:47:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c889eecf857677b38d3afc8592cf62cff3ae568e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":117819343,"node_id":"MDU6TGFiZWwxMTc4MTkzNDM=","url":"https://api.github.com/repos/Katello/katello/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":117819415,"node_id":"MDU6TGFiZWwxMTc4MTk0MTU=","url":"https://api.github.com/repos/Katello/katello/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/7882/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/7882/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/7882/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/8bc68b2ee4b045e46a5b79ac5dfd94bb30b3de6d","head":{"label":"johnpmitsch:rhel8_rh_repos","ref":"rhel8_rh_repos","sha":"8bc68b2ee4b045e46a5b79ac5dfd94bb30b3de6d","user":{"login":"johnpmitsch","id":5964462,"node_id":"MDQ6VXNlcjU5NjQ0NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5964462?v=4","gravatar_id":"","url":"https://api.github.com/users/johnpmitsch","html_url":"https://github.com/johnpmitsch","followers_url":"https://api.github.com/users/johnpmitsch/followers","following_url":"https://api.github.com/users/johnpmitsch/following{/other_user}","gists_url":"https://api.github.com/users/johnpmitsch/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpmitsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpmitsch/subscriptions","organizations_url":"https://api.github.com/users/johnpmitsch/orgs","repos_url":"https://api.github.com/users/johnpmitsch/repos","events_url":"https://api.github.com/users/johnpmitsch/events{/privacy}","received_events_url":"https://api.github.com/users/johnpmitsch/received_events","type":"User","site_admin":false},"repo":{"id":35971034,"node_id":"MDEwOlJlcG9zaXRvcnkzNTk3MTAzNA==","name":"katello","full_name":"johnpmitsch/katello","private":false,"owner":{"login":"johnpmitsch","id":5964462,"node_id":"MDQ6VXNlcjU5NjQ0NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5964462?v=4","gravatar_id":"","url":"https://api.github.com/users/johnpmitsch","html_url":"https://github.com/johnpmitsch","followers_url":"https://api.github.com/users/johnpmitsch/followers","following_url":"https://api.github.com/users/johnpmitsch/following{/other_user}","gists_url":"https://api.github.com/users/johnpmitsch/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpmitsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpmitsch/subscriptions","organizations_url":"https://api.github.com/users/johnpmitsch/orgs","repos_url":"https://api.github.com/users/johnpmitsch/repos","events_url":"https://api.github.com/users/johnpmitsch/events{/privacy}","received_events_url":"https://api.github.com/users/johnpmitsch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/johnpmitsch/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/johnpmitsch/katello","forks_url":"https://api.github.com/repos/johnpmitsch/katello/forks","keys_url":"https://api.github.com/repos/johnpmitsch/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnpmitsch/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnpmitsch/katello/teams","hooks_url":"https://api.github.com/repos/johnpmitsch/katello/hooks","issue_events_url":"https://api.github.com/repos/johnpmitsch/katello/issues/events{/number}","events_url":"https://api.github.com/repos/johnpmitsch/katello/events","assignees_url":"https://api.github.com/repos/johnpmitsch/katello/assignees{/user}","branches_url":"https://api.github.com/repos/johnpmitsch/katello/branches{/branch}","tags_url":"https://api.github.com/repos/johnpmitsch/katello/tags","blobs_url":"https://api.github.com/repos/johnpmitsch/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnpmitsch/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnpmitsch/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnpmitsch/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnpmitsch/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/johnpmitsch/katello/languages","stargazers_url":"https://api.github.com/repos/johnpmitsch/katello/stargazers","contributors_url":"https://api.github.com/repos/johnpmitsch/katello/contributors","subscribers_url":"https://api.github.com/repos/johnpmitsch/katello/subscribers","subscription_url":"https://api.github.com/repos/johnpmitsch/katello/subscription","commits_url":"https://api.github.com/repos/johnpmitsch/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnpmitsch/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnpmitsch/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnpmitsch/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnpmitsch/katello/contents/{+path}","compare_url":"https://api.github.com/repos/johnpmitsch/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnpmitsch/katello/merges","archive_url":"https://api.github.com/repos/johnpmitsch/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnpmitsch/katello/downloads","issues_url":"https://api.github.com/repos/johnpmitsch/katello/issues{/number}","pulls_url":"https://api.github.com/repos/johnpmitsch/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/johnpmitsch/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/johnpmitsch/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnpmitsch/katello/labels{/name}","releases_url":"https://api.github.com/repos/johnpmitsch/katello/releases{/id}","deployments_url":"https://api.github.com/repos/johnpmitsch/katello/deployments","created_at":"2015-05-20T19:57:53Z","updated_at":"2018-07-20T14:34:48Z","pushed_at":"2018-12-18T15:31:39Z","git_url":"git://github.com/johnpmitsch/katello.git","ssh_url":"git@github.com:johnpmitsch/katello.git","clone_url":"https://github.com/johnpmitsch/katello.git","svn_url":"https://github.com/johnpmitsch/katello","homepage":"katello.org","size":96763,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"269d516ced4adc230e67147b7c2a86cea46a2e0e","user":{"login":"Katello","id":1316386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1316386?v=4","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"node_id":"MDEwOlJlcG9zaXRvcnk0MDA3MDE4","name":"katello","full_name":"Katello/katello","private":false,"owner":{"login":"Katello","id":1316386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1316386?v=4","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","deployments_url":"https://api.github.com/repos/Katello/katello/deployments","created_at":"2012-04-12T16:59:08Z","updated_at":"2018-12-20T14:21:15Z","pushed_at":"2018-12-20T16:22:30Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":98277,"stargazers_count":253,"watchers_count":253,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":219,"open_issues":111,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/7882"},"html":{"href":"https://github.com/Katello/katello/pull/7882"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/7882"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/7882/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/7882/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/7882/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/8bc68b2ee4b045e46a5b79ac5dfd94bb30b3de6d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jlsherrill"}}