{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/224990478","pull_request_review_id":164496252,"id":224990478,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk5MDQ3OA==","diff_hunk":"@@ -194,12 +170,13 @@ def fft(a, n=None, axis=-1, norm=None):\n \n     \"\"\"\n \n-    a = asarray(a).astype(complex, copy=False)\n+    a = asarray(a)\n     if n is None:\n         n = a.shape[axis]\n-    output = _raw_fft(a, n, axis, fftpack.cffti, fftpack.cfftf, _fft_cache)\n-    if _unitary(norm):\n-        output *= 1 / sqrt(n)\n+    fct = 1.\n+    if norm is not None and _unitary(norm):\n+        fct = 1. / sqrt(n)","path":"numpy/fft/pocketfft.py","position":100,"original_position":100,"commit_id":"433122f602b8f31f564c88255fc3a100acecd114","original_commit_id":"433122f602b8f31f564c88255fc3a100acecd114","user":{"login":"mreineck","id":898507,"node_id":"MDQ6VXNlcjg5ODUwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/898507?v=4","gravatar_id":"","url":"https://api.github.com/users/mreineck","html_url":"https://github.com/mreineck","followers_url":"https://api.github.com/users/mreineck/followers","following_url":"https://api.github.com/users/mreineck/following{/other_user}","gists_url":"https://api.github.com/users/mreineck/gists{/gist_id}","starred_url":"https://api.github.com/users/mreineck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mreineck/subscriptions","organizations_url":"https://api.github.com/users/mreineck/orgs","repos_url":"https://api.github.com/users/mreineck/repos","events_url":"https://api.github.com/users/mreineck/events{/privacy}","received_events_url":"https://api.github.com/users/mreineck/received_events","type":"User","site_admin":false},"body":"Will do, thanks!","created_at":"2018-10-14T12:14:01Z","updated_at":"2018-10-14T12:14:01Z","html_url":"https://github.com/numpy/numpy/pull/11888#discussion_r224990478","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/11888","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/224990478"},"html":{"href":"https://github.com/numpy/numpy/pull/11888#discussion_r224990478"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11888"}},"in_reply_to_id":224960575},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/11888","id":213371738,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzcxNzM4","html_url":"https://github.com/numpy/numpy/pull/11888","diff_url":"https://github.com/numpy/numpy/pull/11888.diff","patch_url":"https://github.com/numpy/numpy/pull/11888.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/11888","number":11888,"state":"open","locked":false,"title":"WIP: Add pocketfft sources to numpy for testing, benchmarks, etc.","user":{"login":"mreineck","id":898507,"node_id":"MDQ6VXNlcjg5ODUwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/898507?v=4","gravatar_id":"","url":"https://api.github.com/users/mreineck","html_url":"https://github.com/mreineck","followers_url":"https://api.github.com/users/mreineck/followers","following_url":"https://api.github.com/users/mreineck/following{/other_user}","gists_url":"https://api.github.com/users/mreineck/gists{/gist_id}","starred_url":"https://api.github.com/users/mreineck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mreineck/subscriptions","organizations_url":"https://api.github.com/users/mreineck/orgs","repos_url":"https://api.github.com/users/mreineck/repos","events_url":"https://api.github.com/users/mreineck/events{/privacy}","received_events_url":"https://api.github.com/users/mreineck/received_events","type":"User","site_admin":false},"body":"This pull request was opened at the request of @matthew-brett and is related to issues #11885, #11886 and #10625.\r\n\r\n","created_at":"2018-09-05T17:29:46Z","updated_at":"2018-10-14T12:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e2e5228b7dbfb5eef2ab82ba61ad92d67124d68","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":6359239,"node_id":"MDU6TGFiZWw2MzU5MjM5","url":"https://api.github.com/repos/numpy/numpy/labels/01%20-%20Enhancement","name":"01 - Enhancement","color":"fef2c0","default":false},{"id":1042526606,"node_id":"MDU6TGFiZWwxMDQyNTI2NjA2","url":"https://api.github.com/repos/numpy/numpy/labels/27%20-%20Py3K","name":"27 - Py3K","color":"fef2c0","default":false},{"id":16917453,"node_id":"MDU6TGFiZWwxNjkxNzQ1Mw==","url":"https://api.github.com/repos/numpy/numpy/labels/component:%20numpy.fft","name":"component: numpy.fft","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/numpy/numpy/milestones/62","html_url":"https://github.com/numpy/numpy/milestone/62","labels_url":"https://api.github.com/repos/numpy/numpy/milestones/62/labels","id":3633188,"node_id":"MDk6TWlsZXN0b25lMzYzMzE4OA==","number":62,"title":" 1.17.0 release","description":"","creator":{"login":"charris","id":77272,"node_id":"MDQ6VXNlcjc3Mjcy","avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2018-09-07T16:24:30Z","updated_at":"2018-09-24T17:22:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/11888/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/11888/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/11888/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/433122f602b8f31f564c88255fc3a100acecd114","head":{"label":"mreineck:add_pocketfft","ref":"add_pocketfft","sha":"433122f602b8f31f564c88255fc3a100acecd114","user":{"login":"mreineck","id":898507,"node_id":"MDQ6VXNlcjg5ODUwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/898507?v=4","gravatar_id":"","url":"https://api.github.com/users/mreineck","html_url":"https://github.com/mreineck","followers_url":"https://api.github.com/users/mreineck/followers","following_url":"https://api.github.com/users/mreineck/following{/other_user}","gists_url":"https://api.github.com/users/mreineck/gists{/gist_id}","starred_url":"https://api.github.com/users/mreineck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mreineck/subscriptions","organizations_url":"https://api.github.com/users/mreineck/orgs","repos_url":"https://api.github.com/users/mreineck/repos","events_url":"https://api.github.com/users/mreineck/events{/privacy}","received_events_url":"https://api.github.com/users/mreineck/received_events","type":"User","site_admin":false},"repo":{"id":147553860,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1NTM4NjA=","name":"numpy","full_name":"mreineck/numpy","private":false,"owner":{"login":"mreineck","id":898507,"node_id":"MDQ6VXNlcjg5ODUwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/898507?v=4","gravatar_id":"","url":"https://api.github.com/users/mreineck","html_url":"https://github.com/mreineck","followers_url":"https://api.github.com/users/mreineck/followers","following_url":"https://api.github.com/users/mreineck/following{/other_user}","gists_url":"https://api.github.com/users/mreineck/gists{/gist_id}","starred_url":"https://api.github.com/users/mreineck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mreineck/subscriptions","organizations_url":"https://api.github.com/users/mreineck/orgs","repos_url":"https://api.github.com/users/mreineck/repos","events_url":"https://api.github.com/users/mreineck/events{/privacy}","received_events_url":"https://api.github.com/users/mreineck/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mreineck/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/mreineck/numpy","forks_url":"https://api.github.com/repos/mreineck/numpy/forks","keys_url":"https://api.github.com/repos/mreineck/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mreineck/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mreineck/numpy/teams","hooks_url":"https://api.github.com/repos/mreineck/numpy/hooks","issue_events_url":"https://api.github.com/repos/mreineck/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/mreineck/numpy/events","assignees_url":"https://api.github.com/repos/mreineck/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/mreineck/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/mreineck/numpy/tags","blobs_url":"https://api.github.com/repos/mreineck/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mreineck/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mreineck/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mreineck/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mreineck/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/mreineck/numpy/languages","stargazers_url":"https://api.github.com/repos/mreineck/numpy/stargazers","contributors_url":"https://api.github.com/repos/mreineck/numpy/contributors","subscribers_url":"https://api.github.com/repos/mreineck/numpy/subscribers","subscription_url":"https://api.github.com/repos/mreineck/numpy/subscription","commits_url":"https://api.github.com/repos/mreineck/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mreineck/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mreineck/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mreineck/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mreineck/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/mreineck/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mreineck/numpy/merges","archive_url":"https://api.github.com/repos/mreineck/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mreineck/numpy/downloads","issues_url":"https://api.github.com/repos/mreineck/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/mreineck/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/mreineck/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/mreineck/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mreineck/numpy/labels{/name}","releases_url":"https://api.github.com/repos/mreineck/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/mreineck/numpy/deployments","created_at":"2018-09-05T17:18:28Z","updated_at":"2018-09-05T17:18:35Z","pushed_at":"2018-10-14T12:14:01Z","git_url":"git://github.com/mreineck/numpy.git","ssh_url":"git@github.com:mreineck/numpy.git","clone_url":"https://github.com/mreineck/numpy.git","svn_url":"https://github.com/mreineck/numpy","homepage":"https://www.numpy.org/","size":60009,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"18c12106b1c59052ab9c94a5a67513120580a10b","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","private":false,"owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2018-10-14T03:18:30Z","pushed_at":"2018-10-14T11:13:17Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":61125,"stargazers_count":8366,"watchers_count":8366,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3040,"mirror_url":null,"archived":false,"open_issues_count":2001,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3040,"open_issues":2001,"watchers":8366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11888"},"html":{"href":"https://github.com/numpy/numpy/pull/11888"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/11888"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/11888/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11888/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11888/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/433122f602b8f31f564c88255fc3a100acecd114"}},"author_association":"NONE"}}
{"actor":{"display_login":"mreineck"}}