{"action":"closed","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/4113","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/4113/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/4113/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/4113/events","html_url":"https://github.com/publiclab/plots2/issues/4113","id":387121859,"node_id":"MDU6SXNzdWUzODcxMjE4NTk=","number":4113,"title":"Recenter 'Read more' button for note previews","user":{"login":"sashadev-sky","id":41092741,"node_id":"MDQ6VXNlcjQxMDkyNzQx","avatar_url":"https://avatars1.githubusercontent.com/u/41092741?v=4","gravatar_id":"","url":"https://api.github.com/users/sashadev-sky","html_url":"https://github.com/sashadev-sky","followers_url":"https://api.github.com/users/sashadev-sky/followers","following_url":"https://api.github.com/users/sashadev-sky/following{/other_user}","gists_url":"https://api.github.com/users/sashadev-sky/gists{/gist_id}","starred_url":"https://api.github.com/users/sashadev-sky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sashadev-sky/subscriptions","organizations_url":"https://api.github.com/users/sashadev-sky/orgs","repos_url":"https://api.github.com/users/sashadev-sky/repos","events_url":"https://api.github.com/users/sashadev-sky/events{/privacy}","received_events_url":"https://api.github.com/users/sashadev-sky/received_events","type":"User","site_admin":false},"labels":[{"id":476192506,"node_id":"MDU6TGFiZWw0NzYxOTI1MDY=","url":"https://api.github.com/repos/publiclab/plots2/labels/HTML","name":"HTML","color":"fbca04","default":false},{"id":963944413,"node_id":"MDU6TGFiZWw5NjM5NDQ0MTM=","url":"https://api.github.com/repos/publiclab/plots2/labels/css","name":"css","color":"fbca04","default":false},{"id":342625116,"node_id":"MDU6TGFiZWwzNDI2MjUxMTY=","url":"https://api.github.com/repos/publiclab/plots2/labels/first-timers-only","name":"first-timers-only","color":"e99695","default":false},{"id":1054549385,"node_id":"MDU6TGFiZWwxMDU0NTQ5Mzg1","url":"https://api.github.com/repos/publiclab/plots2/labels/gci-candidate","name":"gci-candidate","color":"16ba8b","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-12-04T05:02:28Z","updated_at":"2018-12-07T16:45:13Z","closed_at":"2018-12-07T16:45:12Z","author_association":"CONTRIBUTOR","body":"Hi, this is a [first-timers-only issue](https://code.publiclab.org/#r=all). This means we've worked to make it more legible to folks who either **haven't contributed to our codebase before, or even folks who haven't contributed to open source before**.\r\n\r\nIf that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!\r\n\r\nWe know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝\r\n\r\nIf you have contributed before, consider leaving this one for someone new, and looking through our general [help wanted](https://github.com/publiclab/plots2/labels/help-wanted) issues. Thanks!\r\n\r\n### 🤔 What you will need to know.\r\n\r\nNothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.\r\n\r\n## The problem\r\nThe 'notes' previews across the site are aligned right instead of centered! \r\n[https://publiclab.org/search/notes/balloon](https://publiclab.org/search/notes/balloon)\r\n\r\n<img width=\"573\" alt=\"screen shot 2018-12-03 at 10 47 06 pm\" src=\"https://user-images.githubusercontent.com/41092741/49417835-6ee76100-f74d-11e8-9e9d-640249fed7e8.png\">\r\n\r\n\r\n\r\n## Solution\r\nThis is a pretty easy one -- let's remove the CSS declarations from the notes HTML file that are overwriting the button's previously centered alignment:\r\n\r\n1) \r\nDelete line 69 (and line 70, which is overwritten by the declaration directly under it anyway):\r\nhttps://github.com/publiclab/plots2/blob/c204b268cd8dc1a713aeae15cc4222f0099d4d73/app/views/notes/_notes.html.erb#L66-L72\r\n\r\n2) \r\nDelete the entire inline `style` attribute.\r\nhttps://github.com/publiclab/plots2/blob/c204b268cd8dc1a713aeae15cc4222f0099d4d73/app/views/notes/_notes.html.erb#L51\r\n\r\nThanks!!\r\n\r\n## Steps to Fix\r\n \r\n- [ ] Claim this issue with a comment here, below, and ask any clarifying questions you need\r\n- [ ] Fork the repository and set it up locally following the main repo README instructions [https://github.com/publiclab/plots2](https://github.com/publiclab/plots2)\r\n - [ ] Create a new feature branch with a unique name descriptive to the issue\r\n- [ ] Try to fix the issue following the steps above, but even before you're done, you can:\r\n  commit your changes to your branch and start a pull request (see [contributing to Public Lab software](https://publiclab.org/wiki/contributing-to-public-lab-software)) but mark it as \"in progress\" if you have questions or if you haven't finished\r\n- [ ] Reference this issue in the pull request body\r\n- [ ] Once you submit your pull request, an additional checklist will be provided for getting it merged\r\n\r\n##  💬  Get help\r\nIf you need any help - here are some options: \r\n\r\n- Comment below\r\n- Join our gitter chat at https://gitter.im/publiclab/publiclab"}}
{"actor":{"display_login":"SidharthBansal"}}