{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/205357784","pull_request_review_id":140607861,"id":205357784,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTM1Nzc4NA==","diff_hunk":"@@ -0,0 +1,135 @@\n+==============\n+ DetectorInfo\n+==============\n+\n+This is a python binding to the C++ class Mantid::Geometry::DetectorInfo.\n+\n+--------\n+Purpose\n+--------\n+The purpose of the DetectorInfo object is to allow the user to access information about the detector(s) being used in an experiment. The DetectorInfo object can be used to access geometric information such as the number of detectors in the beamline, the absolute position of a detector as well as the absolute rotation of a detector.\n+\n+Many users may need this extra information so that they can have a better understanding of the beamline they are using. This extra information is also easy and fast to access meaning the users can make improvements to their experimental design with ease.","path":"docs/source/api/python/mantid/geometry/DetectorInfo.rst","position":12,"original_position":12,"commit_id":"69f489cf433410b5716f6156a496682756914d82","original_commit_id":"69f489cf433410b5716f6156a496682756914d82","user":{"login":"OwenArnold","id":1109536,"node_id":"MDQ6VXNlcjExMDk1MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1109536?v=4","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"body":"```This information is easy and fast to access. Some information like mask flags can be modified directly.```","created_at":"2018-07-26T07:38:02Z","updated_at":"2018-07-26T07:38:14Z","html_url":"https://github.com/mantidproject/mantid/pull/22919#discussion_r205357784","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22919","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/205357784"},"html":{"href":"https://github.com/mantidproject/mantid/pull/22919#discussion_r205357784"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22919"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/22919","id":201254256,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjU0MjU2","html_url":"https://github.com/mantidproject/mantid/pull/22919","diff_url":"https://github.com/mantidproject/mantid/pull/22919.diff","patch_url":"https://github.com/mantidproject/mantid/pull/22919.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/22919","number":22919,"state":"open","locked":false,"title":"Exported some methods from DetectorInfo","user":{"login":"BhuvanBezawada","id":23001942,"node_id":"MDQ6VXNlcjIzMDAxOTQy","avatar_url":"https://avatars1.githubusercontent.com/u/23001942?v=4","gravatar_id":"","url":"https://api.github.com/users/BhuvanBezawada","html_url":"https://github.com/BhuvanBezawada","followers_url":"https://api.github.com/users/BhuvanBezawada/followers","following_url":"https://api.github.com/users/BhuvanBezawada/following{/other_user}","gists_url":"https://api.github.com/users/BhuvanBezawada/gists{/gist_id}","starred_url":"https://api.github.com/users/BhuvanBezawada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BhuvanBezawada/subscriptions","organizations_url":"https://api.github.com/users/BhuvanBezawada/orgs","repos_url":"https://api.github.com/users/BhuvanBezawada/repos","events_url":"https://api.github.com/users/BhuvanBezawada/events{/privacy}","received_events_url":"https://api.github.com/users/BhuvanBezawada/received_events","type":"User","site_admin":false},"body":"**DO NOT MERGE**\r\n\r\n**Description of work.**\r\nExported some methods from DetectorInfo to the Python side.\r\nAdded in some more unit tests to check that the exports work as intended.\r\n\r\n**Report to:** @OwenArnold <!--If the original issue was raised by a user they should be named here.-->\r\n\r\n**To test:**\r\nNothing to test specifically.\r\n\r\n<!-- Instructions for testing. -->\r\nTo run the unit tests run the following command:\r\n`ctest -C Debug -R DetectorInfoTest -V`\r\n\r\nFixes #22885 . <!-- and fix #xxxx or close #xxxx xor resolves #xxxx -->\r\n\r\nDoes this update require release notes?\r\n- [x] Yes\r\n- [ ] No\r\n<!--\r\nIf yes, edit the file docs/source/release/... \r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2018-07-13T10:44:11Z","updated_at":"2018-07-26T07:38:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f95906778ec820dfb961432961a22de385dd5765","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":154208631,"node_id":"MDU6TGFiZWwxNTQyMDg2MzE=","url":"https://api.github.com/repos/mantidproject/mantid/labels/State:%20In%20Progress","name":"State: In Progress","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22919/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22919/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/22919/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/69f489cf433410b5716f6156a496682756914d82","head":{"label":"BhuvanBezawada:22885_export_detector_info","ref":"22885_export_detector_info","sha":"69f489cf433410b5716f6156a496682756914d82","user":{"login":"BhuvanBezawada","id":23001942,"node_id":"MDQ6VXNlcjIzMDAxOTQy","avatar_url":"https://avatars1.githubusercontent.com/u/23001942?v=4","gravatar_id":"","url":"https://api.github.com/users/BhuvanBezawada","html_url":"https://github.com/BhuvanBezawada","followers_url":"https://api.github.com/users/BhuvanBezawada/followers","following_url":"https://api.github.com/users/BhuvanBezawada/following{/other_user}","gists_url":"https://api.github.com/users/BhuvanBezawada/gists{/gist_id}","starred_url":"https://api.github.com/users/BhuvanBezawada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BhuvanBezawada/subscriptions","organizations_url":"https://api.github.com/users/BhuvanBezawada/orgs","repos_url":"https://api.github.com/users/BhuvanBezawada/repos","events_url":"https://api.github.com/users/BhuvanBezawada/events{/privacy}","received_events_url":"https://api.github.com/users/BhuvanBezawada/received_events","type":"User","site_admin":false},"repo":{"id":135714198,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3MTQxOTg=","name":"mantid","full_name":"BhuvanBezawada/mantid","owner":{"login":"BhuvanBezawada","id":23001942,"node_id":"MDQ6VXNlcjIzMDAxOTQy","avatar_url":"https://avatars1.githubusercontent.com/u/23001942?v=4","gravatar_id":"","url":"https://api.github.com/users/BhuvanBezawada","html_url":"https://github.com/BhuvanBezawada","followers_url":"https://api.github.com/users/BhuvanBezawada/followers","following_url":"https://api.github.com/users/BhuvanBezawada/following{/other_user}","gists_url":"https://api.github.com/users/BhuvanBezawada/gists{/gist_id}","starred_url":"https://api.github.com/users/BhuvanBezawada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BhuvanBezawada/subscriptions","organizations_url":"https://api.github.com/users/BhuvanBezawada/orgs","repos_url":"https://api.github.com/users/BhuvanBezawada/repos","events_url":"https://api.github.com/users/BhuvanBezawada/events{/privacy}","received_events_url":"https://api.github.com/users/BhuvanBezawada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BhuvanBezawada/mantid","description":"Main repository for Mantid code","fork":true,"url":"https://api.github.com/repos/BhuvanBezawada/mantid","forks_url":"https://api.github.com/repos/BhuvanBezawada/mantid/forks","keys_url":"https://api.github.com/repos/BhuvanBezawada/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BhuvanBezawada/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BhuvanBezawada/mantid/teams","hooks_url":"https://api.github.com/repos/BhuvanBezawada/mantid/hooks","issue_events_url":"https://api.github.com/repos/BhuvanBezawada/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/BhuvanBezawada/mantid/events","assignees_url":"https://api.github.com/repos/BhuvanBezawada/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/BhuvanBezawada/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/BhuvanBezawada/mantid/tags","blobs_url":"https://api.github.com/repos/BhuvanBezawada/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BhuvanBezawada/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BhuvanBezawada/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/BhuvanBezawada/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BhuvanBezawada/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/BhuvanBezawada/mantid/languages","stargazers_url":"https://api.github.com/repos/BhuvanBezawada/mantid/stargazers","contributors_url":"https://api.github.com/repos/BhuvanBezawada/mantid/contributors","subscribers_url":"https://api.github.com/repos/BhuvanBezawada/mantid/subscribers","subscription_url":"https://api.github.com/repos/BhuvanBezawada/mantid/subscription","commits_url":"https://api.github.com/repos/BhuvanBezawada/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/BhuvanBezawada/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/BhuvanBezawada/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/BhuvanBezawada/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/BhuvanBezawada/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/BhuvanBezawada/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BhuvanBezawada/mantid/merges","archive_url":"https://api.github.com/repos/BhuvanBezawada/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BhuvanBezawada/mantid/downloads","issues_url":"https://api.github.com/repos/BhuvanBezawada/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/BhuvanBezawada/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/BhuvanBezawada/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/BhuvanBezawada/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BhuvanBezawada/mantid/labels{/name}","releases_url":"https://api.github.com/repos/BhuvanBezawada/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/BhuvanBezawada/mantid/deployments","created_at":"2018-06-01T12:20:04Z","updated_at":"2018-06-28T12:19:00Z","pushed_at":"2018-07-25T16:13:10Z","git_url":"git://github.com/BhuvanBezawada/mantid.git","ssh_url":"git@github.com:BhuvanBezawada/mantid.git","clone_url":"https://github.com/BhuvanBezawada/mantid.git","svn_url":"https://github.com/BhuvanBezawada/mantid","homepage":"www.mantidproject.org","size":489759,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"3ba86000f09cba7b17ad97abe540215fc5b347c8","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-07-25T19:59:12Z","pushed_at":"2018-07-26T07:31:34Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":495014,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":1829,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":57,"open_issues":1829,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22919"},"html":{"href":"https://github.com/mantidproject/mantid/pull/22919"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/22919"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/22919/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22919/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22919/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/69f489cf433410b5716f6156a496682756914d82"}},"author_association":"NONE"}}
{"actor":{"display_login":"OwenArnold"}}