{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/XConf/XConf/pulls/11","id":182332639,"html_url":"https://github.com/XConf/XConf/pull/11","diff_url":"https://github.com/XConf/XConf/pull/11.diff","patch_url":"https://github.com/XConf/XConf/pull/11.patch","issue_url":"https://api.github.com/repos/XConf/XConf/issues/11","number":11,"state":"closed","locked":false,"title":"用 Conf Context 解偶 Resolver ","user":{"login":"yuchunc","id":1594682,"avatar_url":"https://avatars1.githubusercontent.com/u/1594682?v=4","gravatar_id":"","url":"https://api.github.com/users/yuchunc","html_url":"https://github.com/yuchunc","followers_url":"https://api.github.com/users/yuchunc/followers","following_url":"https://api.github.com/users/yuchunc/following{/other_user}","gists_url":"https://api.github.com/users/yuchunc/gists{/gist_id}","starred_url":"https://api.github.com/users/yuchunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuchunc/subscriptions","organizations_url":"https://api.github.com/users/yuchunc/orgs","repos_url":"https://api.github.com/users/yuchunc/repos","events_url":"https://api.github.com/users/yuchunc/events{/privacy}","received_events_url":"https://api.github.com/users/yuchunc/received_events","type":"User","site_admin":false},"body":"稍微移動了些東西 \r\n\r\n- Conf 是 context module 所以把 Enum 移出來\r\n- Resolver 不應該知道 Repo 的存在 所以用 Conf abstract 掉\r\n- 加了 mix test.watch，讓test auto run (最主要是要看 compile 結果)\r\n\r\n另外我目前在參考這個 project https://github.com/absinthe-graphql/absinthe_tutorial/\r\n我們要不要考慮把 `/types` 和 `types.ex` 併到 `/schema` 裡？\r\n\r\n順道一提 在elixir環境下會比較偏向使用單數 所以\r\n`schemas.ex` -> `schema.ex` 剛好跟上面的 `/schema` 相呼應","created_at":"2018-04-17T23:41:55Z","updated_at":"2018-04-18T04:54:37Z","closed_at":"2018-04-18T04:54:37Z","merged_at":"2018-04-18T04:54:37Z","merge_commit_sha":"4dab7b7f5947aee3ebb823e0ba327835221c04a1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zetavg","id":3784687,"avatar_url":"https://avatars2.githubusercontent.com/u/3784687?v=4","gravatar_id":"","url":"https://api.github.com/users/zetavg","html_url":"https://github.com/zetavg","followers_url":"https://api.github.com/users/zetavg/followers","following_url":"https://api.github.com/users/zetavg/following{/other_user}","gists_url":"https://api.github.com/users/zetavg/gists{/gist_id}","starred_url":"https://api.github.com/users/zetavg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetavg/subscriptions","organizations_url":"https://api.github.com/users/zetavg/orgs","repos_url":"https://api.github.com/users/zetavg/repos","events_url":"https://api.github.com/users/zetavg/events{/privacy}","received_events_url":"https://api.github.com/users/zetavg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/XConf/XConf/pulls/11/commits","review_comments_url":"https://api.github.com/repos/XConf/XConf/pulls/11/comments","review_comment_url":"https://api.github.com/repos/XConf/XConf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/XConf/XConf/issues/11/comments","statuses_url":"https://api.github.com/repos/XConf/XConf/statuses/80478ad775f39bb2cf537941cadae7f74b58ef7e","head":{"label":"XConf:refactor/cleanup-resolver","ref":"refactor/cleanup-resolver","sha":"80478ad775f39bb2cf537941cadae7f74b58ef7e","user":{"login":"XConf","id":34998180,"avatar_url":"https://avatars3.githubusercontent.com/u/34998180?v=4","gravatar_id":"","url":"https://api.github.com/users/XConf","html_url":"https://github.com/XConf","followers_url":"https://api.github.com/users/XConf/followers","following_url":"https://api.github.com/users/XConf/following{/other_user}","gists_url":"https://api.github.com/users/XConf/gists{/gist_id}","starred_url":"https://api.github.com/users/XConf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XConf/subscriptions","organizations_url":"https://api.github.com/users/XConf/orgs","repos_url":"https://api.github.com/users/XConf/repos","events_url":"https://api.github.com/users/XConf/events{/privacy}","received_events_url":"https://api.github.com/users/XConf/received_events","type":"Organization","site_admin":false},"repo":{"id":115919219,"name":"XConf","full_name":"XConf/XConf","owner":{"login":"XConf","id":34998180,"avatar_url":"https://avatars3.githubusercontent.com/u/34998180?v=4","gravatar_id":"","url":"https://api.github.com/users/XConf","html_url":"https://github.com/XConf","followers_url":"https://api.github.com/users/XConf/followers","following_url":"https://api.github.com/users/XConf/following{/other_user}","gists_url":"https://api.github.com/users/XConf/gists{/gist_id}","starred_url":"https://api.github.com/users/XConf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XConf/subscriptions","organizations_url":"https://api.github.com/users/XConf/orgs","repos_url":"https://api.github.com/users/XConf/repos","events_url":"https://api.github.com/users/XConf/events{/privacy}","received_events_url":"https://api.github.com/users/XConf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XConf/XConf","description":null,"fork":false,"url":"https://api.github.com/repos/XConf/XConf","forks_url":"https://api.github.com/repos/XConf/XConf/forks","keys_url":"https://api.github.com/repos/XConf/XConf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XConf/XConf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XConf/XConf/teams","hooks_url":"https://api.github.com/repos/XConf/XConf/hooks","issue_events_url":"https://api.github.com/repos/XConf/XConf/issues/events{/number}","events_url":"https://api.github.com/repos/XConf/XConf/events","assignees_url":"https://api.github.com/repos/XConf/XConf/assignees{/user}","branches_url":"https://api.github.com/repos/XConf/XConf/branches{/branch}","tags_url":"https://api.github.com/repos/XConf/XConf/tags","blobs_url":"https://api.github.com/repos/XConf/XConf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XConf/XConf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XConf/XConf/git/refs{/sha}","trees_url":"https://api.github.com/repos/XConf/XConf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XConf/XConf/statuses/{sha}","languages_url":"https://api.github.com/repos/XConf/XConf/languages","stargazers_url":"https://api.github.com/repos/XConf/XConf/stargazers","contributors_url":"https://api.github.com/repos/XConf/XConf/contributors","subscribers_url":"https://api.github.com/repos/XConf/XConf/subscribers","subscription_url":"https://api.github.com/repos/XConf/XConf/subscription","commits_url":"https://api.github.com/repos/XConf/XConf/commits{/sha}","git_commits_url":"https://api.github.com/repos/XConf/XConf/git/commits{/sha}","comments_url":"https://api.github.com/repos/XConf/XConf/comments{/number}","issue_comment_url":"https://api.github.com/repos/XConf/XConf/issues/comments{/number}","contents_url":"https://api.github.com/repos/XConf/XConf/contents/{+path}","compare_url":"https://api.github.com/repos/XConf/XConf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XConf/XConf/merges","archive_url":"https://api.github.com/repos/XConf/XConf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XConf/XConf/downloads","issues_url":"https://api.github.com/repos/XConf/XConf/issues{/number}","pulls_url":"https://api.github.com/repos/XConf/XConf/pulls{/number}","milestones_url":"https://api.github.com/repos/XConf/XConf/milestones{/number}","notifications_url":"https://api.github.com/repos/XConf/XConf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XConf/XConf/labels{/name}","releases_url":"https://api.github.com/repos/XConf/XConf/releases{/id}","deployments_url":"https://api.github.com/repos/XConf/XConf/deployments","created_at":"2018-01-01T12:56:08Z","updated_at":"2018-04-17T03:17:10Z","pushed_at":"2018-04-18T04:54:37Z","git_url":"git://github.com/XConf/XConf.git","ssh_url":"git@github.com:XConf/XConf.git","clone_url":"https://github.com/XConf/XConf.git","svn_url":"https://github.com/XConf/XConf","homepage":null,"size":108,"stargazers_count":5,"watchers_count":5,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":5,"default_branch":"develop"}},"base":{"label":"XConf:develop","ref":"develop","sha":"51ab2a0e70eeebe7f03b4f42f5d6f5740cf8bf18","user":{"login":"XConf","id":34998180,"avatar_url":"https://avatars3.githubusercontent.com/u/34998180?v=4","gravatar_id":"","url":"https://api.github.com/users/XConf","html_url":"https://github.com/XConf","followers_url":"https://api.github.com/users/XConf/followers","following_url":"https://api.github.com/users/XConf/following{/other_user}","gists_url":"https://api.github.com/users/XConf/gists{/gist_id}","starred_url":"https://api.github.com/users/XConf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XConf/subscriptions","organizations_url":"https://api.github.com/users/XConf/orgs","repos_url":"https://api.github.com/users/XConf/repos","events_url":"https://api.github.com/users/XConf/events{/privacy}","received_events_url":"https://api.github.com/users/XConf/received_events","type":"Organization","site_admin":false},"repo":{"id":115919219,"name":"XConf","full_name":"XConf/XConf","owner":{"login":"XConf","id":34998180,"avatar_url":"https://avatars3.githubusercontent.com/u/34998180?v=4","gravatar_id":"","url":"https://api.github.com/users/XConf","html_url":"https://github.com/XConf","followers_url":"https://api.github.com/users/XConf/followers","following_url":"https://api.github.com/users/XConf/following{/other_user}","gists_url":"https://api.github.com/users/XConf/gists{/gist_id}","starred_url":"https://api.github.com/users/XConf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XConf/subscriptions","organizations_url":"https://api.github.com/users/XConf/orgs","repos_url":"https://api.github.com/users/XConf/repos","events_url":"https://api.github.com/users/XConf/events{/privacy}","received_events_url":"https://api.github.com/users/XConf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XConf/XConf","description":null,"fork":false,"url":"https://api.github.com/repos/XConf/XConf","forks_url":"https://api.github.com/repos/XConf/XConf/forks","keys_url":"https://api.github.com/repos/XConf/XConf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XConf/XConf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XConf/XConf/teams","hooks_url":"https://api.github.com/repos/XConf/XConf/hooks","issue_events_url":"https://api.github.com/repos/XConf/XConf/issues/events{/number}","events_url":"https://api.github.com/repos/XConf/XConf/events","assignees_url":"https://api.github.com/repos/XConf/XConf/assignees{/user}","branches_url":"https://api.github.com/repos/XConf/XConf/branches{/branch}","tags_url":"https://api.github.com/repos/XConf/XConf/tags","blobs_url":"https://api.github.com/repos/XConf/XConf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XConf/XConf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XConf/XConf/git/refs{/sha}","trees_url":"https://api.github.com/repos/XConf/XConf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XConf/XConf/statuses/{sha}","languages_url":"https://api.github.com/repos/XConf/XConf/languages","stargazers_url":"https://api.github.com/repos/XConf/XConf/stargazers","contributors_url":"https://api.github.com/repos/XConf/XConf/contributors","subscribers_url":"https://api.github.com/repos/XConf/XConf/subscribers","subscription_url":"https://api.github.com/repos/XConf/XConf/subscription","commits_url":"https://api.github.com/repos/XConf/XConf/commits{/sha}","git_commits_url":"https://api.github.com/repos/XConf/XConf/git/commits{/sha}","comments_url":"https://api.github.com/repos/XConf/XConf/comments{/number}","issue_comment_url":"https://api.github.com/repos/XConf/XConf/issues/comments{/number}","contents_url":"https://api.github.com/repos/XConf/XConf/contents/{+path}","compare_url":"https://api.github.com/repos/XConf/XConf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XConf/XConf/merges","archive_url":"https://api.github.com/repos/XConf/XConf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XConf/XConf/downloads","issues_url":"https://api.github.com/repos/XConf/XConf/issues{/number}","pulls_url":"https://api.github.com/repos/XConf/XConf/pulls{/number}","milestones_url":"https://api.github.com/repos/XConf/XConf/milestones{/number}","notifications_url":"https://api.github.com/repos/XConf/XConf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XConf/XConf/labels{/name}","releases_url":"https://api.github.com/repos/XConf/XConf/releases{/id}","deployments_url":"https://api.github.com/repos/XConf/XConf/deployments","created_at":"2018-01-01T12:56:08Z","updated_at":"2018-04-17T03:17:10Z","pushed_at":"2018-04-18T04:54:37Z","git_url":"git://github.com/XConf/XConf.git","ssh_url":"git@github.com:XConf/XConf.git","clone_url":"https://github.com/XConf/XConf.git","svn_url":"https://github.com/XConf/XConf","homepage":null,"size":108,"stargazers_count":5,"watchers_count":5,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/XConf/XConf/pulls/11"},"html":{"href":"https://github.com/XConf/XConf/pull/11"},"issue":{"href":"https://api.github.com/repos/XConf/XConf/issues/11"},"comments":{"href":"https://api.github.com/repos/XConf/XConf/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/XConf/XConf/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/XConf/XConf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/XConf/XConf/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/XConf/XConf/statuses/80478ad775f39bb2cf537941cadae7f74b58ef7e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pastleo","id":3825526,"avatar_url":"https://avatars0.githubusercontent.com/u/3825526?v=4","gravatar_id":"","url":"https://api.github.com/users/pastleo","html_url":"https://github.com/pastleo","followers_url":"https://api.github.com/users/pastleo/followers","following_url":"https://api.github.com/users/pastleo/following{/other_user}","gists_url":"https://api.github.com/users/pastleo/gists{/gist_id}","starred_url":"https://api.github.com/users/pastleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pastleo/subscriptions","organizations_url":"https://api.github.com/users/pastleo/orgs","repos_url":"https://api.github.com/users/pastleo/repos","events_url":"https://api.github.com/users/pastleo/events{/privacy}","received_events_url":"https://api.github.com/users/pastleo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":32,"deletions":7,"changed_files":7}}
{"actor":{"display_login":"pastleo"}}