{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/jonekcode/Snow.ly/pulls/1","id":214106051,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTA2MDUx","html_url":"https://github.com/jonekcode/Snow.ly/pull/1","diff_url":"https://github.com/jonekcode/Snow.ly/pull/1.diff","patch_url":"https://github.com/jonekcode/Snow.ly/pull/1.patch","issue_url":"https://api.github.com/repos/jonekcode/Snow.ly/issues/1","number":1,"state":"open","locked":false,"title":"Make startup easier","user":{"login":"dominik-ba","id":28777818,"node_id":"MDQ6VXNlcjI4Nzc3ODE4","avatar_url":"https://avatars0.githubusercontent.com/u/28777818?v=4","gravatar_id":"","url":"https://api.github.com/users/dominik-ba","html_url":"https://github.com/dominik-ba","followers_url":"https://api.github.com/users/dominik-ba/followers","following_url":"https://api.github.com/users/dominik-ba/following{/other_user}","gists_url":"https://api.github.com/users/dominik-ba/gists{/gist_id}","starred_url":"https://api.github.com/users/dominik-ba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominik-ba/subscriptions","organizations_url":"https://api.github.com/users/dominik-ba/orgs","repos_url":"https://api.github.com/users/dominik-ba/repos","events_url":"https://api.github.com/users/dominik-ba/events{/privacy}","received_events_url":"https://api.github.com/users/dominik-ba/received_events","type":"User","site_admin":false},"body":"The project wouldn't complete composer post-install scripts without errors if no database connection was supplied.\r\nThis was due to the `SettingsServiceProvider.php` being discovered and registered by Laravel.\r\nAll this happened before the setup even took place.\r\n\r\nI removed the `SettingsServiceProvider.php` and moved the default configuration into database seeders and a configuration file specific to this repo.\r\n\r\nThe changes will likely __break__ some views, as the current implementation relies on the `SettingsServiceProvider.php` filling the config helper with values from the database. (The views should work but will display nothing where the values come from the `config` helper.)  \r\nThose views should be reworked, to get their data correctly from the controller, as the MVC pattern would suggest.\r\n\r\n__Accept this PR with caution, as it will require more work to refactor some other parts in the application!__","created_at":"2018-09-08T17:31:29Z","updated_at":"2018-09-08T17:31:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jonekcode/Snow.ly/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jonekcode/Snow.ly/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jonekcode/Snow.ly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jonekcode/Snow.ly/issues/1/comments","statuses_url":"https://api.github.com/repos/jonekcode/Snow.ly/statuses/02c9465da734294f5a1d24eab4618b1c3c9595f4","head":{"label":"dominik-ba:make-startup-easier","ref":"make-startup-easier","sha":"02c9465da734294f5a1d24eab4618b1c3c9595f4","user":{"login":"dominik-ba","id":28777818,"node_id":"MDQ6VXNlcjI4Nzc3ODE4","avatar_url":"https://avatars0.githubusercontent.com/u/28777818?v=4","gravatar_id":"","url":"https://api.github.com/users/dominik-ba","html_url":"https://github.com/dominik-ba","followers_url":"https://api.github.com/users/dominik-ba/followers","following_url":"https://api.github.com/users/dominik-ba/following{/other_user}","gists_url":"https://api.github.com/users/dominik-ba/gists{/gist_id}","starred_url":"https://api.github.com/users/dominik-ba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominik-ba/subscriptions","organizations_url":"https://api.github.com/users/dominik-ba/orgs","repos_url":"https://api.github.com/users/dominik-ba/repos","events_url":"https://api.github.com/users/dominik-ba/events{/privacy}","received_events_url":"https://api.github.com/users/dominik-ba/received_events","type":"User","site_admin":false},"repo":{"id":147950088,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc5NTAwODg=","name":"Snow.ly","full_name":"dominik-ba/Snow.ly","owner":{"login":"dominik-ba","id":28777818,"node_id":"MDQ6VXNlcjI4Nzc3ODE4","avatar_url":"https://avatars0.githubusercontent.com/u/28777818?v=4","gravatar_id":"","url":"https://api.github.com/users/dominik-ba","html_url":"https://github.com/dominik-ba","followers_url":"https://api.github.com/users/dominik-ba/followers","following_url":"https://api.github.com/users/dominik-ba/following{/other_user}","gists_url":"https://api.github.com/users/dominik-ba/gists{/gist_id}","starred_url":"https://api.github.com/users/dominik-ba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominik-ba/subscriptions","organizations_url":"https://api.github.com/users/dominik-ba/orgs","repos_url":"https://api.github.com/users/dominik-ba/repos","events_url":"https://api.github.com/users/dominik-ba/events{/privacy}","received_events_url":"https://api.github.com/users/dominik-ba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dominik-ba/Snow.ly","description":"A small, simple and efficient CMS built for programmers","fork":true,"url":"https://api.github.com/repos/dominik-ba/Snow.ly","forks_url":"https://api.github.com/repos/dominik-ba/Snow.ly/forks","keys_url":"https://api.github.com/repos/dominik-ba/Snow.ly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dominik-ba/Snow.ly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dominik-ba/Snow.ly/teams","hooks_url":"https://api.github.com/repos/dominik-ba/Snow.ly/hooks","issue_events_url":"https://api.github.com/repos/dominik-ba/Snow.ly/issues/events{/number}","events_url":"https://api.github.com/repos/dominik-ba/Snow.ly/events","assignees_url":"https://api.github.com/repos/dominik-ba/Snow.ly/assignees{/user}","branches_url":"https://api.github.com/repos/dominik-ba/Snow.ly/branches{/branch}","tags_url":"https://api.github.com/repos/dominik-ba/Snow.ly/tags","blobs_url":"https://api.github.com/repos/dominik-ba/Snow.ly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dominik-ba/Snow.ly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dominik-ba/Snow.ly/git/refs{/sha}","trees_url":"https://api.github.com/repos/dominik-ba/Snow.ly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dominik-ba/Snow.ly/statuses/{sha}","languages_url":"https://api.github.com/repos/dominik-ba/Snow.ly/languages","stargazers_url":"https://api.github.com/repos/dominik-ba/Snow.ly/stargazers","contributors_url":"https://api.github.com/repos/dominik-ba/Snow.ly/contributors","subscribers_url":"https://api.github.com/repos/dominik-ba/Snow.ly/subscribers","subscription_url":"https://api.github.com/repos/dominik-ba/Snow.ly/subscription","commits_url":"https://api.github.com/repos/dominik-ba/Snow.ly/commits{/sha}","git_commits_url":"https://api.github.com/repos/dominik-ba/Snow.ly/git/commits{/sha}","comments_url":"https://api.github.com/repos/dominik-ba/Snow.ly/comments{/number}","issue_comment_url":"https://api.github.com/repos/dominik-ba/Snow.ly/issues/comments{/number}","contents_url":"https://api.github.com/repos/dominik-ba/Snow.ly/contents/{+path}","compare_url":"https://api.github.com/repos/dominik-ba/Snow.ly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dominik-ba/Snow.ly/merges","archive_url":"https://api.github.com/repos/dominik-ba/Snow.ly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dominik-ba/Snow.ly/downloads","issues_url":"https://api.github.com/repos/dominik-ba/Snow.ly/issues{/number}","pulls_url":"https://api.github.com/repos/dominik-ba/Snow.ly/pulls{/number}","milestones_url":"https://api.github.com/repos/dominik-ba/Snow.ly/milestones{/number}","notifications_url":"https://api.github.com/repos/dominik-ba/Snow.ly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dominik-ba/Snow.ly/labels{/name}","releases_url":"https://api.github.com/repos/dominik-ba/Snow.ly/releases{/id}","deployments_url":"https://api.github.com/repos/dominik-ba/Snow.ly/deployments","created_at":"2018-09-08T16:23:50Z","updated_at":"2018-09-08T16:23:52Z","pushed_at":"2018-09-08T17:22:06Z","git_url":"git://github.com/dominik-ba/Snow.ly.git","ssh_url":"git@github.com:dominik-ba/Snow.ly.git","clone_url":"https://github.com/dominik-ba/Snow.ly.git","svn_url":"https://github.com/dominik-ba/Snow.ly","homepage":"","size":2400,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jonekcode:master","ref":"master","sha":"cb2a8768ff2aaffb48fc087fac9325f8fa343d57","user":{"login":"jonekcode","id":30983493,"node_id":"MDQ6VXNlcjMwOTgzNDkz","avatar_url":"https://avatars2.githubusercontent.com/u/30983493?v=4","gravatar_id":"","url":"https://api.github.com/users/jonekcode","html_url":"https://github.com/jonekcode","followers_url":"https://api.github.com/users/jonekcode/followers","following_url":"https://api.github.com/users/jonekcode/following{/other_user}","gists_url":"https://api.github.com/users/jonekcode/gists{/gist_id}","starred_url":"https://api.github.com/users/jonekcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonekcode/subscriptions","organizations_url":"https://api.github.com/users/jonekcode/orgs","repos_url":"https://api.github.com/users/jonekcode/repos","events_url":"https://api.github.com/users/jonekcode/events{/privacy}","received_events_url":"https://api.github.com/users/jonekcode/received_events","type":"User","site_admin":false},"repo":{"id":143524939,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1MjQ5Mzk=","name":"Snow.ly","full_name":"jonekcode/Snow.ly","owner":{"login":"jonekcode","id":30983493,"node_id":"MDQ6VXNlcjMwOTgzNDkz","avatar_url":"https://avatars2.githubusercontent.com/u/30983493?v=4","gravatar_id":"","url":"https://api.github.com/users/jonekcode","html_url":"https://github.com/jonekcode","followers_url":"https://api.github.com/users/jonekcode/followers","following_url":"https://api.github.com/users/jonekcode/following{/other_user}","gists_url":"https://api.github.com/users/jonekcode/gists{/gist_id}","starred_url":"https://api.github.com/users/jonekcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonekcode/subscriptions","organizations_url":"https://api.github.com/users/jonekcode/orgs","repos_url":"https://api.github.com/users/jonekcode/repos","events_url":"https://api.github.com/users/jonekcode/events{/privacy}","received_events_url":"https://api.github.com/users/jonekcode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonekcode/Snow.ly","description":"A small, simple and efficient CMS built for programmers","fork":false,"url":"https://api.github.com/repos/jonekcode/Snow.ly","forks_url":"https://api.github.com/repos/jonekcode/Snow.ly/forks","keys_url":"https://api.github.com/repos/jonekcode/Snow.ly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonekcode/Snow.ly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonekcode/Snow.ly/teams","hooks_url":"https://api.github.com/repos/jonekcode/Snow.ly/hooks","issue_events_url":"https://api.github.com/repos/jonekcode/Snow.ly/issues/events{/number}","events_url":"https://api.github.com/repos/jonekcode/Snow.ly/events","assignees_url":"https://api.github.com/repos/jonekcode/Snow.ly/assignees{/user}","branches_url":"https://api.github.com/repos/jonekcode/Snow.ly/branches{/branch}","tags_url":"https://api.github.com/repos/jonekcode/Snow.ly/tags","blobs_url":"https://api.github.com/repos/jonekcode/Snow.ly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonekcode/Snow.ly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonekcode/Snow.ly/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonekcode/Snow.ly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonekcode/Snow.ly/statuses/{sha}","languages_url":"https://api.github.com/repos/jonekcode/Snow.ly/languages","stargazers_url":"https://api.github.com/repos/jonekcode/Snow.ly/stargazers","contributors_url":"https://api.github.com/repos/jonekcode/Snow.ly/contributors","subscribers_url":"https://api.github.com/repos/jonekcode/Snow.ly/subscribers","subscription_url":"https://api.github.com/repos/jonekcode/Snow.ly/subscription","commits_url":"https://api.github.com/repos/jonekcode/Snow.ly/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonekcode/Snow.ly/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonekcode/Snow.ly/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonekcode/Snow.ly/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonekcode/Snow.ly/contents/{+path}","compare_url":"https://api.github.com/repos/jonekcode/Snow.ly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonekcode/Snow.ly/merges","archive_url":"https://api.github.com/repos/jonekcode/Snow.ly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonekcode/Snow.ly/downloads","issues_url":"https://api.github.com/repos/jonekcode/Snow.ly/issues{/number}","pulls_url":"https://api.github.com/repos/jonekcode/Snow.ly/pulls{/number}","milestones_url":"https://api.github.com/repos/jonekcode/Snow.ly/milestones{/number}","notifications_url":"https://api.github.com/repos/jonekcode/Snow.ly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonekcode/Snow.ly/labels{/name}","releases_url":"https://api.github.com/repos/jonekcode/Snow.ly/releases{/id}","deployments_url":"https://api.github.com/repos/jonekcode/Snow.ly/deployments","created_at":"2018-08-04T11:58:43Z","updated_at":"2018-09-08T12:33:30Z","pushed_at":"2018-09-08T12:33:28Z","git_url":"git://github.com/jonekcode/Snow.ly.git","ssh_url":"git@github.com:jonekcode/Snow.ly.git","clone_url":"https://github.com/jonekcode/Snow.ly.git","svn_url":"https://github.com/jonekcode/Snow.ly","homepage":"","size":2400,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jonekcode/Snow.ly/pulls/1"},"html":{"href":"https://github.com/jonekcode/Snow.ly/pull/1"},"issue":{"href":"https://api.github.com/repos/jonekcode/Snow.ly/issues/1"},"comments":{"href":"https://api.github.com/repos/jonekcode/Snow.ly/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jonekcode/Snow.ly/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jonekcode/Snow.ly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jonekcode/Snow.ly/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jonekcode/Snow.ly/statuses/02c9465da734294f5a1d24eab4618b1c3c9595f4"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":89,"deletions":77,"changed_files":11}}
{"actor":{"display_login":"dominik-ba"}}