{"action":"created","issue":{"url":"https://api.github.com/repos/mpdf/mpdf/issues/647","repository_url":"https://api.github.com/repos/mpdf/mpdf","labels_url":"https://api.github.com/repos/mpdf/mpdf/issues/647/labels{/name}","comments_url":"https://api.github.com/repos/mpdf/mpdf/issues/647/comments","events_url":"https://api.github.com/repos/mpdf/mpdf/issues/647/events","html_url":"https://github.com/mpdf/mpdf/pull/647","id":296186502,"number":647,"title":"Add support for \"orientation\" config key","user":{"login":"Dasc3er","id":15911489,"avatar_url":"https://avatars1.githubusercontent.com/u/15911489?v=4","gravatar_id":"","url":"https://api.github.com/users/Dasc3er","html_url":"https://github.com/Dasc3er","followers_url":"https://api.github.com/users/Dasc3er/followers","following_url":"https://api.github.com/users/Dasc3er/following{/other_user}","gists_url":"https://api.github.com/users/Dasc3er/gists{/gist_id}","starred_url":"https://api.github.com/users/Dasc3er/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dasc3er/subscriptions","organizations_url":"https://api.github.com/users/Dasc3er/orgs","repos_url":"https://api.github.com/users/Dasc3er/repos","events_url":"https://api.github.com/users/Dasc3er/events{/privacy}","received_events_url":"https://api.github.com/users/Dasc3er/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-11T12:31:13Z","updated_at":"2018-02-11T13:03:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mpdf/mpdf/pulls/647","html_url":"https://github.com/mpdf/mpdf/pull/647","diff_url":"https://github.com/mpdf/mpdf/pull/647.diff","patch_url":"https://github.com/mpdf/mpdf/pull/647.patch"},"body":"Add support for the \"orientation\" config key (issue #598), changing the way __setPageSize_ behaves when the orientation isn't defined in the \"format\" key.\r\n\r\nResults:\r\n```php\r\n// Behaves like before (set format to A4 and orientation to L)\r\n$mpdf = new \\Mpdf\\Mpdf([\r\n    'format' => 'A4-L',\r\n]);\r\n\r\n// Behaves like before (set format to A4 and orientation to P)\r\n$mpdf = new \\Mpdf\\Mpdf([\r\n    'format' => 'A4',\r\n]);\r\n\r\n// Added: set format to A4 and orientation to P\r\n$mpdf = new \\Mpdf\\Mpdf([\r\n    'format' => 'A4-P',\r\n]);\r\n\r\n// Behaves like before (set format to A4 and orientation to L, ignoring \"orientation\" key)\r\n$mpdf = new \\Mpdf\\Mpdf([\r\n    'format' => 'A4-L',\r\n    'orientation' => 'P',\r\n]);\r\n```\r\n\r\nHope this helps 😄 "},"comment":{"url":"https://api.github.com/repos/mpdf/mpdf/issues/comments/364750190","html_url":"https://github.com/mpdf/mpdf/pull/647#issuecomment-364750190","issue_url":"https://api.github.com/repos/mpdf/mpdf/issues/647","id":364750190,"user":{"login":"Klap-in","id":183250,"avatar_url":"https://avatars0.githubusercontent.com/u/183250?v=4","gravatar_id":"","url":"https://api.github.com/users/Klap-in","html_url":"https://github.com/Klap-in","followers_url":"https://api.github.com/users/Klap-in/followers","following_url":"https://api.github.com/users/Klap-in/following{/other_user}","gists_url":"https://api.github.com/users/Klap-in/gists{/gist_id}","starred_url":"https://api.github.com/users/Klap-in/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Klap-in/subscriptions","organizations_url":"https://api.github.com/users/Klap-in/orgs","repos_url":"https://api.github.com/users/Klap-in/repos","events_url":"https://api.github.com/users/Klap-in/events{/privacy}","received_events_url":"https://api.github.com/users/Klap-in/received_events","type":"User","site_admin":false},"created_at":"2018-02-11T13:03:58Z","updated_at":"2018-02-11T13:03:58Z","author_association":"CONTRIBUTOR","body":"Could you add the cases as unit tests to this pull request?"}}
{"actor":{"display_login":"Klap-in"}}