{"action":"created","comment":{"url":"https://api.github.com/repos/bus1/dbus-broker/pulls/comments/188223970","pull_request_review_id":120155289,"id":188223970,"diff_hunk":"@@ -1728,47 +1734,70 @@ static int driver_handle_method(const DriverMethod *method, Peer *peer, const ch\n         return 0;\n }\n \n-static int driver_dispatch_method(Peer *peer, uint32_t serial, const char *method, const char *path, const char *signature, Message *message) {\n-        static const DriverMethod methods[] = {\n-                { \"Hello\",                                      NULL,                           driver_method_hello,                                            c_dvar_type_unit,       driver_type_out_s },\n-                { \"RequestName\",                                NULL,                           driver_method_request_name,                                     driver_type_in_su,      driver_type_out_u },\n-                { \"ReleaseName\",                                NULL,                           driver_method_release_name,                                     driver_type_in_s,       driver_type_out_u },\n-                { \"ListQueuedOwners\",                           NULL,                           driver_method_list_queued_owners,                               driver_type_in_s,       driver_type_out_as },\n-                { \"ListNames\",                                  NULL,                           driver_method_list_names,                                       c_dvar_type_unit,       driver_type_out_as },\n-                { \"ListActivatableNames\",                       NULL,                           driver_method_list_activatable_names,                           c_dvar_type_unit,       driver_type_out_as },\n-                { \"NameHasOwner\",                               NULL,                           driver_method_name_has_owner,                                   driver_type_in_s,       driver_type_out_b },\n-                { \"StartServiceByName\",                         NULL,                           driver_method_start_service_by_name,                            driver_type_in_su,      driver_type_out_u },\n-                { \"UpdateActivationEnvironment\",                \"/org/freedesktop/DBus\",        driver_method_update_activation_environment,                    driver_type_in_apss,    driver_type_out_unit },\n-                { \"GetNameOwner\",                               NULL,                           driver_method_get_name_owner,                                   driver_type_in_s,       driver_type_out_s },\n-                { \"GetConnectionUnixUser\",                      NULL,                           driver_method_get_connection_unix_user,                         driver_type_in_s,       driver_type_out_u },\n-                { \"GetConnectionUnixProcessID\",                 NULL,                           driver_method_get_connection_unix_process_id,                   driver_type_in_s,       driver_type_out_u },\n-                { \"GetConnectionCredentials\",                   NULL,                           driver_method_get_connection_credentials,                       driver_type_in_s,       driver_type_out_apsv },\n-                { \"GetAdtAuditSessionData\",                     NULL,                           driver_method_get_adt_audit_session_data,                       driver_type_in_s,       driver_type_out_ay },\n-                { \"GetConnectionSELinuxSecurityContext\",        NULL,                           driver_method_get_connection_selinux_security_context,          driver_type_in_s,       driver_type_out_ay },\n-                { \"AddMatch\",                                   NULL,                           driver_method_add_match,                                        driver_type_in_s,       driver_type_out_unit },\n-                { \"RemoveMatch\",                                NULL,                           driver_method_remove_match,                                     driver_type_in_s,       driver_type_out_unit },\n-                { \"ReloadConfig\",                               NULL,                           driver_method_reload_config,                                    c_dvar_type_unit,       driver_type_out_unit },\n-                { \"GetId\",                                      NULL,                           driver_method_get_id,                                           c_dvar_type_unit,       driver_type_out_s },\n-                { \"Introspect\",                                 NULL,                           driver_method_introspect,                                       c_dvar_type_unit,       driver_type_out_s },\n-                { \"BecomeMonitor\",                              \"/org/freedesktop/DBus\",        driver_method_become_monitor,                                   driver_type_in_asu,     driver_type_out_unit },\n-                { \"Ping\",                                       NULL,                           driver_method_ping,                                             c_dvar_type_unit,       driver_type_out_unit },\n-                { \"GetMachineId\",                               NULL,                           driver_method_get_machine_id,                                   c_dvar_type_unit,       driver_type_out_s },\n-        };\n+static const DriverMethod driver_methods[] = {\n+        { \"Hello\",                                      NULL,                           driver_method_hello,                                            c_dvar_type_unit,       driver_type_out_s },\n+        { \"AddMatch\",                                   NULL,                           driver_method_add_match,                                        driver_type_in_s,       driver_type_out_unit },\n+        { \"RemoveMatch\",                                NULL,                           driver_method_remove_match,                                     driver_type_in_s,       driver_type_out_unit },\n+        { \"RequestName\",                                NULL,                           driver_method_request_name,                                     driver_type_in_su,      driver_type_out_u },\n+        { \"ReleaseName\",                                NULL,                           driver_method_release_name,                                     driver_type_in_s,       driver_type_out_u },\n+        { \"GetConnectionCredentials\",                   NULL,                           driver_method_get_connection_credentials,                       driver_type_in_s,       driver_type_out_apsv },\n+        { \"GetConnectionUnixUser\",                      NULL,                           driver_method_get_connection_unix_user,                         driver_type_in_s,       driver_type_out_u },\n+        { \"GetConnectionUnixProcessID\",                 NULL,                           driver_method_get_connection_unix_process_id,                   driver_type_in_s,       driver_type_out_u },\n+        { \"GetAdtAuditSessionData\",                     NULL,                           driver_method_get_adt_audit_session_data,                       driver_type_in_s,       driver_type_out_ay },\n+        { \"GetConnectionSELinuxSecurityContext\",        NULL,                           driver_method_get_connection_selinux_security_context,          driver_type_in_s,       driver_type_out_ay },\n+        { \"StartServiceByName\",                         NULL,                           driver_method_start_service_by_name,                            driver_type_in_su,      driver_type_out_u },\n+        { \"ListQueuedOwners\",                           NULL,                           driver_method_list_queued_owners,                               driver_type_in_s,       driver_type_out_as },\n+        { \"ListNames\",                                  NULL,                           driver_method_list_names,                                       c_dvar_type_unit,       driver_type_out_as },\n+        { \"ListActivatableNames\",                       NULL,                           driver_method_list_activatable_names,                           c_dvar_type_unit,       driver_type_out_as },\n+        { \"NameHasOwner\",                               NULL,                           driver_method_name_has_owner,                                   driver_type_in_s,       driver_type_out_b },\n+        { \"UpdateActivationEnvironment\",                \"/org/freedesktop/DBus\",        driver_method_update_activation_environment,                    driver_type_in_apss,    driver_type_out_unit },\n+        { \"GetNameOwner\",                               NULL,                           driver_method_get_name_owner,                                   driver_type_in_s,       driver_type_out_s },\n+        { \"ReloadConfig\",                               NULL,                           driver_method_reload_config,                                    c_dvar_type_unit,       driver_type_out_unit },\n+        { \"GetId\",                                      NULL,                           driver_method_get_id,                                           c_dvar_type_unit,       driver_type_out_s },\n+        { \"Introspect\",                                 NULL,                           driver_method_introspect,                                       c_dvar_type_unit,       driver_type_out_s },\n+        { \"BecomeMonitor\",                              \"/org/freedesktop/DBus\",        driver_method_become_monitor,                                   driver_type_in_asu,     driver_type_out_unit },\n+        { \"Ping\",                                       NULL,                           driver_method_ping,                                             c_dvar_type_unit,       driver_type_out_unit },\n+        { \"GetMachineId\",                               NULL,                           driver_method_get_machine_id,                                   c_dvar_type_unit,       driver_type_out_s },\n+        { },","path":"src/bus/driver.c","position":null,"original_position":74,"commit_id":"43e3a9f9afdbda68bd8f6ec7d67534a960c5c053","original_commit_id":"f4f1a21c0789d29634cce098923e9becc642cf15","user":{"login":"teg","id":5409,"avatar_url":"https://avatars3.githubusercontent.com/u/5409?v=4","gravatar_id":"","url":"https://api.github.com/users/teg","html_url":"https://github.com/teg","followers_url":"https://api.github.com/users/teg/followers","following_url":"https://api.github.com/users/teg/following{/other_user}","gists_url":"https://api.github.com/users/teg/gists{/gist_id}","starred_url":"https://api.github.com/users/teg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teg/subscriptions","organizations_url":"https://api.github.com/users/teg/orgs","repos_url":"https://api.github.com/users/teg/repos","events_url":"https://api.github.com/users/teg/events{/privacy}","received_events_url":"https://api.github.com/users/teg/received_events","type":"User","site_admin":false},"body":"You are right. That's an oversight. Will push fix.","created_at":"2018-05-15T09:36:11Z","updated_at":"2018-05-15T09:36:11Z","html_url":"https://github.com/bus1/dbus-broker/pull/125#discussion_r188223970","pull_request_url":"https://api.github.com/repos/bus1/dbus-broker/pulls/125","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bus1/dbus-broker/pulls/comments/188223970"},"html":{"href":"https://github.com/bus1/dbus-broker/pull/125#discussion_r188223970"},"pull_request":{"href":"https://api.github.com/repos/bus1/dbus-broker/pulls/125"}},"in_reply_to_id":188046657},"pull_request":{"url":"https://api.github.com/repos/bus1/dbus-broker/pulls/125","id":187834465,"html_url":"https://github.com/bus1/dbus-broker/pull/125","diff_url":"https://github.com/bus1/dbus-broker/pull/125.diff","patch_url":"https://github.com/bus1/dbus-broker/pull/125.patch","issue_url":"https://api.github.com/repos/bus1/dbus-broker/issues/125","number":125,"state":"open","locked":false,"title":"Registration","user":{"login":"teg","id":5409,"avatar_url":"https://avatars3.githubusercontent.com/u/5409?v=4","gravatar_id":"","url":"https://api.github.com/users/teg","html_url":"https://github.com/teg","followers_url":"https://api.github.com/users/teg/followers","following_url":"https://api.github.com/users/teg/following{/other_user}","gists_url":"https://api.github.com/users/teg/gists{/gist_id}","starred_url":"https://api.github.com/users/teg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teg/subscriptions","organizations_url":"https://api.github.com/users/teg/orgs","repos_url":"https://api.github.com/users/teg/repos","events_url":"https://api.github.com/users/teg/events{/privacy}","received_events_url":"https://api.github.com/users/teg/received_events","type":"User","site_admin":false},"body":"Fix the error handling related to the Hello() call.","created_at":"2018-05-14T13:52:54Z","updated_at":"2018-05-15T09:36:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff5c67eb68496396c9223ec8689c2847f13e521c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bus1/dbus-broker/pulls/125/commits","review_comments_url":"https://api.github.com/repos/bus1/dbus-broker/pulls/125/comments","review_comment_url":"https://api.github.com/repos/bus1/dbus-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bus1/dbus-broker/issues/125/comments","statuses_url":"https://api.github.com/repos/bus1/dbus-broker/statuses/43e3a9f9afdbda68bd8f6ec7d67534a960c5c053","head":{"label":"teg:registration","ref":"registration","sha":"43e3a9f9afdbda68bd8f6ec7d67534a960c5c053","user":{"login":"teg","id":5409,"avatar_url":"https://avatars3.githubusercontent.com/u/5409?v=4","gravatar_id":"","url":"https://api.github.com/users/teg","html_url":"https://github.com/teg","followers_url":"https://api.github.com/users/teg/followers","following_url":"https://api.github.com/users/teg/following{/other_user}","gists_url":"https://api.github.com/users/teg/gists{/gist_id}","starred_url":"https://api.github.com/users/teg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teg/subscriptions","organizations_url":"https://api.github.com/users/teg/orgs","repos_url":"https://api.github.com/users/teg/repos","events_url":"https://api.github.com/users/teg/events{/privacy}","received_events_url":"https://api.github.com/users/teg/received_events","type":"User","site_admin":false},"repo":{"id":98912245,"name":"dbus-broker","full_name":"teg/dbus-broker","owner":{"login":"teg","id":5409,"avatar_url":"https://avatars3.githubusercontent.com/u/5409?v=4","gravatar_id":"","url":"https://api.github.com/users/teg","html_url":"https://github.com/teg","followers_url":"https://api.github.com/users/teg/followers","following_url":"https://api.github.com/users/teg/following{/other_user}","gists_url":"https://api.github.com/users/teg/gists{/gist_id}","starred_url":"https://api.github.com/users/teg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teg/subscriptions","organizations_url":"https://api.github.com/users/teg/orgs","repos_url":"https://api.github.com/users/teg/repos","events_url":"https://api.github.com/users/teg/events{/privacy}","received_events_url":"https://api.github.com/users/teg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teg/dbus-broker","description":"Linux D-Bus Message Broker","fork":true,"url":"https://api.github.com/repos/teg/dbus-broker","forks_url":"https://api.github.com/repos/teg/dbus-broker/forks","keys_url":"https://api.github.com/repos/teg/dbus-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teg/dbus-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teg/dbus-broker/teams","hooks_url":"https://api.github.com/repos/teg/dbus-broker/hooks","issue_events_url":"https://api.github.com/repos/teg/dbus-broker/issues/events{/number}","events_url":"https://api.github.com/repos/teg/dbus-broker/events","assignees_url":"https://api.github.com/repos/teg/dbus-broker/assignees{/user}","branches_url":"https://api.github.com/repos/teg/dbus-broker/branches{/branch}","tags_url":"https://api.github.com/repos/teg/dbus-broker/tags","blobs_url":"https://api.github.com/repos/teg/dbus-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teg/dbus-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teg/dbus-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/teg/dbus-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teg/dbus-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/teg/dbus-broker/languages","stargazers_url":"https://api.github.com/repos/teg/dbus-broker/stargazers","contributors_url":"https://api.github.com/repos/teg/dbus-broker/contributors","subscribers_url":"https://api.github.com/repos/teg/dbus-broker/subscribers","subscription_url":"https://api.github.com/repos/teg/dbus-broker/subscription","commits_url":"https://api.github.com/repos/teg/dbus-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/teg/dbus-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/teg/dbus-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/teg/dbus-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/teg/dbus-broker/contents/{+path}","compare_url":"https://api.github.com/repos/teg/dbus-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teg/dbus-broker/merges","archive_url":"https://api.github.com/repos/teg/dbus-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teg/dbus-broker/downloads","issues_url":"https://api.github.com/repos/teg/dbus-broker/issues{/number}","pulls_url":"https://api.github.com/repos/teg/dbus-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/teg/dbus-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/teg/dbus-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teg/dbus-broker/labels{/name}","releases_url":"https://api.github.com/repos/teg/dbus-broker/releases{/id}","deployments_url":"https://api.github.com/repos/teg/dbus-broker/deployments","created_at":"2017-07-31T17:26:35Z","updated_at":"2017-07-31T17:26:37Z","pushed_at":"2018-05-14T15:40:31Z","git_url":"git://github.com/teg/dbus-broker.git","ssh_url":"git@github.com:teg/dbus-broker.git","clone_url":"https://github.com/teg/dbus-broker.git","svn_url":"https://github.com/teg/dbus-broker","homepage":"https://github.com/bus1/dbus-broker/wiki","size":1613,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bus1:master","ref":"master","sha":"f8e49e45ed8a85de1c699833a06a1703c2b4e227","user":{"login":"bus1","id":15194221,"avatar_url":"https://avatars0.githubusercontent.com/u/15194221?v=4","gravatar_id":"","url":"https://api.github.com/users/bus1","html_url":"https://github.com/bus1","followers_url":"https://api.github.com/users/bus1/followers","following_url":"https://api.github.com/users/bus1/following{/other_user}","gists_url":"https://api.github.com/users/bus1/gists{/gist_id}","starred_url":"https://api.github.com/users/bus1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bus1/subscriptions","organizations_url":"https://api.github.com/users/bus1/orgs","repos_url":"https://api.github.com/users/bus1/repos","events_url":"https://api.github.com/users/bus1/events{/privacy}","received_events_url":"https://api.github.com/users/bus1/received_events","type":"Organization","site_admin":false},"repo":{"id":84054474,"name":"dbus-broker","full_name":"bus1/dbus-broker","owner":{"login":"bus1","id":15194221,"avatar_url":"https://avatars0.githubusercontent.com/u/15194221?v=4","gravatar_id":"","url":"https://api.github.com/users/bus1","html_url":"https://github.com/bus1","followers_url":"https://api.github.com/users/bus1/followers","following_url":"https://api.github.com/users/bus1/following{/other_user}","gists_url":"https://api.github.com/users/bus1/gists{/gist_id}","starred_url":"https://api.github.com/users/bus1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bus1/subscriptions","organizations_url":"https://api.github.com/users/bus1/orgs","repos_url":"https://api.github.com/users/bus1/repos","events_url":"https://api.github.com/users/bus1/events{/privacy}","received_events_url":"https://api.github.com/users/bus1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bus1/dbus-broker","description":"Linux D-Bus Message Broker","fork":false,"url":"https://api.github.com/repos/bus1/dbus-broker","forks_url":"https://api.github.com/repos/bus1/dbus-broker/forks","keys_url":"https://api.github.com/repos/bus1/dbus-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bus1/dbus-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bus1/dbus-broker/teams","hooks_url":"https://api.github.com/repos/bus1/dbus-broker/hooks","issue_events_url":"https://api.github.com/repos/bus1/dbus-broker/issues/events{/number}","events_url":"https://api.github.com/repos/bus1/dbus-broker/events","assignees_url":"https://api.github.com/repos/bus1/dbus-broker/assignees{/user}","branches_url":"https://api.github.com/repos/bus1/dbus-broker/branches{/branch}","tags_url":"https://api.github.com/repos/bus1/dbus-broker/tags","blobs_url":"https://api.github.com/repos/bus1/dbus-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bus1/dbus-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bus1/dbus-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/bus1/dbus-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bus1/dbus-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/bus1/dbus-broker/languages","stargazers_url":"https://api.github.com/repos/bus1/dbus-broker/stargazers","contributors_url":"https://api.github.com/repos/bus1/dbus-broker/contributors","subscribers_url":"https://api.github.com/repos/bus1/dbus-broker/subscribers","subscription_url":"https://api.github.com/repos/bus1/dbus-broker/subscription","commits_url":"https://api.github.com/repos/bus1/dbus-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/bus1/dbus-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/bus1/dbus-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/bus1/dbus-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/bus1/dbus-broker/contents/{+path}","compare_url":"https://api.github.com/repos/bus1/dbus-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bus1/dbus-broker/merges","archive_url":"https://api.github.com/repos/bus1/dbus-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bus1/dbus-broker/downloads","issues_url":"https://api.github.com/repos/bus1/dbus-broker/issues{/number}","pulls_url":"https://api.github.com/repos/bus1/dbus-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/bus1/dbus-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/bus1/dbus-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bus1/dbus-broker/labels{/name}","releases_url":"https://api.github.com/repos/bus1/dbus-broker/releases{/id}","deployments_url":"https://api.github.com/repos/bus1/dbus-broker/deployments","created_at":"2017-03-06T09:28:09Z","updated_at":"2018-05-15T06:27:43Z","pushed_at":"2018-05-14T15:30:50Z","git_url":"git://github.com/bus1/dbus-broker.git","ssh_url":"git@github.com:bus1/dbus-broker.git","clone_url":"https://github.com/bus1/dbus-broker.git","svn_url":"https://github.com/bus1/dbus-broker","homepage":"https://github.com/bus1/dbus-broker/wiki","size":1543,"stargazers_count":212,"watchers_count":212,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":19,"open_issues":7,"watchers":212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bus1/dbus-broker/pulls/125"},"html":{"href":"https://github.com/bus1/dbus-broker/pull/125"},"issue":{"href":"https://api.github.com/repos/bus1/dbus-broker/issues/125"},"comments":{"href":"https://api.github.com/repos/bus1/dbus-broker/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/bus1/dbus-broker/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/bus1/dbus-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bus1/dbus-broker/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/bus1/dbus-broker/statuses/43e3a9f9afdbda68bd8f6ec7d67534a960c5c053"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"teg"}}