{"action":"created","comment":{"url":"https://api.github.com/repos/meteor/meteor/pulls/comments/205597753","pull_request_review_id":140903085,"id":205597753,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTU5Nzc1Mw==","diff_hunk":"@@ -195,7 +195,7 @@ BCp._inferFromBabelRc = function (inputFile, babelOptions, cacheDeps) {\n       try {\n         this._babelrcCache[babelrcPath] = {\n           controlFilePath: babelrcPath,\n-          controlFileData: JSON.parse(\n+          controlFileData: JSON5.parse(","path":"packages/babel-compiler/babel-compiler.js","position":12,"original_position":12,"commit_id":"a8044f2f2c5905e979cd8728e22268fca51ba270","original_commit_id":"a8044f2f2c5905e979cd8728e22268fca51ba270","user":{"login":"klaussner","id":1312807,"node_id":"MDQ6VXNlcjEzMTI4MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1312807?v=4","gravatar_id":"","url":"https://api.github.com/users/klaussner","html_url":"https://github.com/klaussner","followers_url":"https://api.github.com/users/klaussner/followers","following_url":"https://api.github.com/users/klaussner/following{/other_user}","gists_url":"https://api.github.com/users/klaussner/gists{/gist_id}","starred_url":"https://api.github.com/users/klaussner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaussner/subscriptions","organizations_url":"https://api.github.com/users/klaussner/orgs","repos_url":"https://api.github.com/users/klaussner/repos","events_url":"https://api.github.com/users/klaussner/events{/privacy}","received_events_url":"https://api.github.com/users/klaussner/received_events","type":"User","site_admin":false},"body":"Maybe update the error message below to `.babelrc is not a valid JSON5 file`? :slightly_smiling_face:","created_at":"2018-07-26T20:48:45Z","updated_at":"2018-07-26T20:48:45Z","html_url":"https://github.com/meteor/meteor/pull/10098#discussion_r205597753","pull_request_url":"https://api.github.com/repos/meteor/meteor/pulls/10098","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments/205597753"},"html":{"href":"https://github.com/meteor/meteor/pull/10098#discussion_r205597753"},"pull_request":{"href":"https://api.github.com/repos/meteor/meteor/pulls/10098"}}},"pull_request":{"url":"https://api.github.com/repos/meteor/meteor/pulls/10098","id":203986603,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTg2NjAz","html_url":"https://github.com/meteor/meteor/pull/10098","diff_url":"https://github.com/meteor/meteor/pull/10098.diff","patch_url":"https://github.com/meteor/meteor/pull/10098.patch","issue_url":"https://api.github.com/repos/meteor/meteor/issues/10098","number":10098,"state":"open","locked":false,"title":"Allow json5 in babelrc","user":{"login":"sakulstra","id":4396533,"node_id":"MDQ6VXNlcjQzOTY1MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4396533?v=4","gravatar_id":"","url":"https://api.github.com/users/sakulstra","html_url":"https://github.com/sakulstra","followers_url":"https://api.github.com/users/sakulstra/followers","following_url":"https://api.github.com/users/sakulstra/following{/other_user}","gists_url":"https://api.github.com/users/sakulstra/gists{/gist_id}","starred_url":"https://api.github.com/users/sakulstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakulstra/subscriptions","organizations_url":"https://api.github.com/users/sakulstra/orgs","repos_url":"https://api.github.com/users/sakulstra/repos","events_url":"https://api.github.com/users/sakulstra/events{/privacy}","received_events_url":"https://api.github.com/users/sakulstra/received_events","type":"User","site_admin":false},"body":"Currently we cannot us json5 in babel files which are used by meteor. That's a bit counter intuitive as babel itself supports json5 and we share babel files between jest and meteor. So atm we cannot e.g. add comments in babel files which are used by meteor.\r\n\r\nThis pr changes the parser the use json5 instead - which as i get should be fully backwards compatible and is already included via babel.\r\n\r\n- fixes #10068 \r\n\r\n-----\r\n\r\nNot sure how to properly add a test for this, but I tested locally by adding a json5 .babelrc and running from checkout:\r\n```\r\n{\r\n  env: {\r\n    test: {\r\n      plugins: ['dynamic-import-node']\r\n    }\r\n  }\r\n}\r\n```","created_at":"2018-07-25T23:02:05Z","updated_at":"2018-07-26T20:48:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fc93da0fab2fde422d35844872009f1a12bf468","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/meteor/meteor/pulls/10098/commits","review_comments_url":"https://api.github.com/repos/meteor/meteor/pulls/10098/comments","review_comment_url":"https://api.github.com/repos/meteor/meteor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meteor/meteor/issues/10098/comments","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/a8044f2f2c5905e979cd8728e22268fca51ba270","head":{"label":"sakulstra:allow-json5","ref":"allow-json5","sha":"a8044f2f2c5905e979cd8728e22268fca51ba270","user":{"login":"sakulstra","id":4396533,"node_id":"MDQ6VXNlcjQzOTY1MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4396533?v=4","gravatar_id":"","url":"https://api.github.com/users/sakulstra","html_url":"https://github.com/sakulstra","followers_url":"https://api.github.com/users/sakulstra/followers","following_url":"https://api.github.com/users/sakulstra/following{/other_user}","gists_url":"https://api.github.com/users/sakulstra/gists{/gist_id}","starred_url":"https://api.github.com/users/sakulstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakulstra/subscriptions","organizations_url":"https://api.github.com/users/sakulstra/orgs","repos_url":"https://api.github.com/users/sakulstra/repos","events_url":"https://api.github.com/users/sakulstra/events{/privacy}","received_events_url":"https://api.github.com/users/sakulstra/received_events","type":"User","site_admin":false},"repo":{"id":118827443,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4Mjc0NDM=","name":"meteor","full_name":"sakulstra/meteor","owner":{"login":"sakulstra","id":4396533,"node_id":"MDQ6VXNlcjQzOTY1MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4396533?v=4","gravatar_id":"","url":"https://api.github.com/users/sakulstra","html_url":"https://github.com/sakulstra","followers_url":"https://api.github.com/users/sakulstra/followers","following_url":"https://api.github.com/users/sakulstra/following{/other_user}","gists_url":"https://api.github.com/users/sakulstra/gists{/gist_id}","starred_url":"https://api.github.com/users/sakulstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakulstra/subscriptions","organizations_url":"https://api.github.com/users/sakulstra/orgs","repos_url":"https://api.github.com/users/sakulstra/repos","events_url":"https://api.github.com/users/sakulstra/events{/privacy}","received_events_url":"https://api.github.com/users/sakulstra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sakulstra/meteor","description":"Meteor, the JavaScript App Platform","fork":true,"url":"https://api.github.com/repos/sakulstra/meteor","forks_url":"https://api.github.com/repos/sakulstra/meteor/forks","keys_url":"https://api.github.com/repos/sakulstra/meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sakulstra/meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sakulstra/meteor/teams","hooks_url":"https://api.github.com/repos/sakulstra/meteor/hooks","issue_events_url":"https://api.github.com/repos/sakulstra/meteor/issues/events{/number}","events_url":"https://api.github.com/repos/sakulstra/meteor/events","assignees_url":"https://api.github.com/repos/sakulstra/meteor/assignees{/user}","branches_url":"https://api.github.com/repos/sakulstra/meteor/branches{/branch}","tags_url":"https://api.github.com/repos/sakulstra/meteor/tags","blobs_url":"https://api.github.com/repos/sakulstra/meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sakulstra/meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sakulstra/meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/sakulstra/meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sakulstra/meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/sakulstra/meteor/languages","stargazers_url":"https://api.github.com/repos/sakulstra/meteor/stargazers","contributors_url":"https://api.github.com/repos/sakulstra/meteor/contributors","subscribers_url":"https://api.github.com/repos/sakulstra/meteor/subscribers","subscription_url":"https://api.github.com/repos/sakulstra/meteor/subscription","commits_url":"https://api.github.com/repos/sakulstra/meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/sakulstra/meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/sakulstra/meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/sakulstra/meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/sakulstra/meteor/contents/{+path}","compare_url":"https://api.github.com/repos/sakulstra/meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sakulstra/meteor/merges","archive_url":"https://api.github.com/repos/sakulstra/meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sakulstra/meteor/downloads","issues_url":"https://api.github.com/repos/sakulstra/meteor/issues{/number}","pulls_url":"https://api.github.com/repos/sakulstra/meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/sakulstra/meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/sakulstra/meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sakulstra/meteor/labels{/name}","releases_url":"https://api.github.com/repos/sakulstra/meteor/releases{/id}","deployments_url":"https://api.github.com/repos/sakulstra/meteor/deployments","created_at":"2018-01-24T21:58:22Z","updated_at":"2018-05-12T12:54:50Z","pushed_at":"2018-07-25T22:49:53Z","git_url":"git://github.com/sakulstra/meteor.git","ssh_url":"git@github.com:sakulstra/meteor.git","clone_url":"https://github.com/sakulstra/meteor.git","svn_url":"https://github.com/sakulstra/meteor","homepage":"https://www.meteor.com","size":75667,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"devel"}},"base":{"label":"meteor:release-1.7.1","ref":"release-1.7.1","sha":"30df020c9ddf8c62d2c49d7829cfe661aa9699eb","user":{"login":"meteor","id":789528,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4OTUyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/789528?v=4","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"repo":{"id":3214406,"node_id":"MDEwOlJlcG9zaXRvcnkzMjE0NDA2","name":"meteor","full_name":"meteor/meteor","owner":{"login":"meteor","id":789528,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4OTUyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/789528?v=4","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meteor/meteor","description":"Meteor, the JavaScript App Platform","fork":false,"url":"https://api.github.com/repos/meteor/meteor","forks_url":"https://api.github.com/repos/meteor/meteor/forks","keys_url":"https://api.github.com/repos/meteor/meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteor/meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteor/meteor/teams","hooks_url":"https://api.github.com/repos/meteor/meteor/hooks","issue_events_url":"https://api.github.com/repos/meteor/meteor/issues/events{/number}","events_url":"https://api.github.com/repos/meteor/meteor/events","assignees_url":"https://api.github.com/repos/meteor/meteor/assignees{/user}","branches_url":"https://api.github.com/repos/meteor/meteor/branches{/branch}","tags_url":"https://api.github.com/repos/meteor/meteor/tags","blobs_url":"https://api.github.com/repos/meteor/meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteor/meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteor/meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteor/meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/meteor/meteor/languages","stargazers_url":"https://api.github.com/repos/meteor/meteor/stargazers","contributors_url":"https://api.github.com/repos/meteor/meteor/contributors","subscribers_url":"https://api.github.com/repos/meteor/meteor/subscribers","subscription_url":"https://api.github.com/repos/meteor/meteor/subscription","commits_url":"https://api.github.com/repos/meteor/meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteor/meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteor/meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteor/meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteor/meteor/contents/{+path}","compare_url":"https://api.github.com/repos/meteor/meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteor/meteor/merges","archive_url":"https://api.github.com/repos/meteor/meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteor/meteor/downloads","issues_url":"https://api.github.com/repos/meteor/meteor/issues{/number}","pulls_url":"https://api.github.com/repos/meteor/meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/meteor/meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/meteor/meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteor/meteor/labels{/name}","releases_url":"https://api.github.com/repos/meteor/meteor/releases{/id}","deployments_url":"https://api.github.com/repos/meteor/meteor/deployments","created_at":"2012-01-19T01:58:17Z","updated_at":"2018-07-26T17:16:11Z","pushed_at":"2018-07-26T15:24:37Z","git_url":"git://github.com/meteor/meteor.git","ssh_url":"git@github.com:meteor/meteor.git","clone_url":"https://github.com/meteor/meteor.git","svn_url":"https://github.com/meteor/meteor","homepage":"https://www.meteor.com","size":75704,"stargazers_count":40080,"watchers_count":40080,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4999,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4999,"open_issues":173,"watchers":40080,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/10098"},"html":{"href":"https://github.com/meteor/meteor/pull/10098"},"issue":{"href":"https://api.github.com/repos/meteor/meteor/issues/10098"},"comments":{"href":"https://api.github.com/repos/meteor/meteor/issues/10098/comments"},"review_comments":{"href":"https://api.github.com/repos/meteor/meteor/pulls/10098/comments"},"review_comment":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meteor/meteor/pulls/10098/commits"},"statuses":{"href":"https://api.github.com/repos/meteor/meteor/statuses/a8044f2f2c5905e979cd8728e22268fca51ba270"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"klaussner"}}