{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/pulls/1","id":228950066,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTUwMDY2","html_url":"https://github.com/intercom/ember-cli-addon-docs/pull/1","diff_url":"https://github.com/intercom/ember-cli-addon-docs/pull/1.diff","patch_url":"https://github.com/intercom/ember-cli-addon-docs/pull/1.patch","issue_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/issues/1","number":1,"state":"closed","locked":false,"title":"limit indexing to docs templates - use pageTitle if title is missing","user":{"login":"22a","id":7144173,"node_id":"MDQ6VXNlcjcxNDQxNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7144173?v=4","gravatar_id":"","url":"https://api.github.com/users/22a","html_url":"https://github.com/22a","followers_url":"https://api.github.com/users/22a/followers","following_url":"https://api.github.com/users/22a/following{/other_user}","gists_url":"https://api.github.com/users/22a/gists{/gist_id}","starred_url":"https://api.github.com/users/22a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/22a/subscriptions","organizations_url":"https://api.github.com/users/22a/orgs","repos_url":"https://api.github.com/users/22a/repos","events_url":"https://api.github.com/users/22a/events{/privacy}","received_events_url":"https://api.github.com/users/22a/received_events","type":"User","site_admin":false},"body":"This PR resolves DS-262 by modifying the ecad search indexing code to:\r\n\r\n* restrict indexing to only docs templates (those containing `/docs/` in the route)\r\n* attempt to generate the template's title from the hero component's pageTitle attribute if we couldn't find a h1 in the page by itself","created_at":"2018-11-07T08:27:06Z","updated_at":"2018-11-07T14:55:14Z","closed_at":"2018-11-07T14:55:14Z","merged_at":"2018-11-07T14:55:14Z","merge_commit_sha":"965835be7d2ef91be68b58e42f76ce9a9cb14562","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/pulls/1/commits","review_comments_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/pulls/1/comments","review_comment_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/issues/1/comments","statuses_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/statuses/3f1ecac7bdb154b2fe732952d58bce74c48b6ddb","head":{"label":"intercom:22a/search-indexing-tweaks","ref":"22a/search-indexing-tweaks","sha":"3f1ecac7bdb154b2fe732952d58bce74c48b6ddb","user":{"login":"intercom","id":6585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/6585?v=4","gravatar_id":"","url":"https://api.github.com/users/intercom","html_url":"https://github.com/intercom","followers_url":"https://api.github.com/users/intercom/followers","following_url":"https://api.github.com/users/intercom/following{/other_user}","gists_url":"https://api.github.com/users/intercom/gists{/gist_id}","starred_url":"https://api.github.com/users/intercom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intercom/subscriptions","organizations_url":"https://api.github.com/users/intercom/orgs","repos_url":"https://api.github.com/users/intercom/repos","events_url":"https://api.github.com/users/intercom/events{/privacy}","received_events_url":"https://api.github.com/users/intercom/received_events","type":"Organization","site_admin":false},"repo":{"id":154358414,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzNTg0MTQ=","name":"ember-cli-addon-docs","full_name":"intercom/ember-cli-addon-docs","private":false,"owner":{"login":"intercom","id":6585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/6585?v=4","gravatar_id":"","url":"https://api.github.com/users/intercom","html_url":"https://github.com/intercom","followers_url":"https://api.github.com/users/intercom/followers","following_url":"https://api.github.com/users/intercom/following{/other_user}","gists_url":"https://api.github.com/users/intercom/gists{/gist_id}","starred_url":"https://api.github.com/users/intercom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intercom/subscriptions","organizations_url":"https://api.github.com/users/intercom/orgs","repos_url":"https://api.github.com/users/intercom/repos","events_url":"https://api.github.com/users/intercom/events{/privacy}","received_events_url":"https://api.github.com/users/intercom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/intercom/ember-cli-addon-docs","description":"Easy, beautiful docs for your OSS Ember addons","fork":true,"url":"https://api.github.com/repos/intercom/ember-cli-addon-docs","forks_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/forks","keys_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/teams","hooks_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/hooks","issue_events_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/issues/events{/number}","events_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/events","assignees_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/assignees{/user}","branches_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/branches{/branch}","tags_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/tags","blobs_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/languages","stargazers_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/stargazers","contributors_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/contributors","subscribers_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/subscribers","subscription_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/subscription","commits_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/contents/{+path}","compare_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/merges","archive_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/downloads","issues_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/issues{/number}","pulls_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/labels{/name}","releases_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/releases{/id}","deployments_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/deployments","created_at":"2018-10-23T16:07:07Z","updated_at":"2018-11-07T10:09:34Z","pushed_at":"2018-11-07T14:55:14Z","git_url":"git://github.com/intercom/ember-cli-addon-docs.git","ssh_url":"git@github.com:intercom/ember-cli-addon-docs.git","clone_url":"https://github.com/intercom/ember-cli-addon-docs.git","svn_url":"https://github.com/intercom/ember-cli-addon-docs","homepage":"https://ember-learn.github.io/ember-cli-addon-docs","size":12950,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"intercom:master","ref":"master","sha":"e13a69010d95185ceb5672982a13cfedbd92763a","user":{"login":"intercom","id":6585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/6585?v=4","gravatar_id":"","url":"https://api.github.com/users/intercom","html_url":"https://github.com/intercom","followers_url":"https://api.github.com/users/intercom/followers","following_url":"https://api.github.com/users/intercom/following{/other_user}","gists_url":"https://api.github.com/users/intercom/gists{/gist_id}","starred_url":"https://api.github.com/users/intercom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intercom/subscriptions","organizations_url":"https://api.github.com/users/intercom/orgs","repos_url":"https://api.github.com/users/intercom/repos","events_url":"https://api.github.com/users/intercom/events{/privacy}","received_events_url":"https://api.github.com/users/intercom/received_events","type":"Organization","site_admin":false},"repo":{"id":154358414,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzNTg0MTQ=","name":"ember-cli-addon-docs","full_name":"intercom/ember-cli-addon-docs","private":false,"owner":{"login":"intercom","id":6585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/6585?v=4","gravatar_id":"","url":"https://api.github.com/users/intercom","html_url":"https://github.com/intercom","followers_url":"https://api.github.com/users/intercom/followers","following_url":"https://api.github.com/users/intercom/following{/other_user}","gists_url":"https://api.github.com/users/intercom/gists{/gist_id}","starred_url":"https://api.github.com/users/intercom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intercom/subscriptions","organizations_url":"https://api.github.com/users/intercom/orgs","repos_url":"https://api.github.com/users/intercom/repos","events_url":"https://api.github.com/users/intercom/events{/privacy}","received_events_url":"https://api.github.com/users/intercom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/intercom/ember-cli-addon-docs","description":"Easy, beautiful docs for your OSS Ember addons","fork":true,"url":"https://api.github.com/repos/intercom/ember-cli-addon-docs","forks_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/forks","keys_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/teams","hooks_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/hooks","issue_events_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/issues/events{/number}","events_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/events","assignees_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/assignees{/user}","branches_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/branches{/branch}","tags_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/tags","blobs_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/languages","stargazers_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/stargazers","contributors_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/contributors","subscribers_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/subscribers","subscription_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/subscription","commits_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/contents/{+path}","compare_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/merges","archive_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/downloads","issues_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/issues{/number}","pulls_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/labels{/name}","releases_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/releases{/id}","deployments_url":"https://api.github.com/repos/intercom/ember-cli-addon-docs/deployments","created_at":"2018-10-23T16:07:07Z","updated_at":"2018-11-07T10:09:34Z","pushed_at":"2018-11-07T14:55:14Z","git_url":"git://github.com/intercom/ember-cli-addon-docs.git","ssh_url":"git@github.com:intercom/ember-cli-addon-docs.git","clone_url":"https://github.com/intercom/ember-cli-addon-docs.git","svn_url":"https://github.com/intercom/ember-cli-addon-docs","homepage":"https://ember-learn.github.io/ember-cli-addon-docs","size":12950,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intercom/ember-cli-addon-docs/pulls/1"},"html":{"href":"https://github.com/intercom/ember-cli-addon-docs/pull/1"},"issue":{"href":"https://api.github.com/repos/intercom/ember-cli-addon-docs/issues/1"},"comments":{"href":"https://api.github.com/repos/intercom/ember-cli-addon-docs/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/intercom/ember-cli-addon-docs/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/intercom/ember-cli-addon-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intercom/ember-cli-addon-docs/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/intercom/ember-cli-addon-docs/statuses/3f1ecac7bdb154b2fe732952d58bce74c48b6ddb"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"22a","id":7144173,"node_id":"MDQ6VXNlcjcxNDQxNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7144173?v=4","gravatar_id":"","url":"https://api.github.com/users/22a","html_url":"https://github.com/22a","followers_url":"https://api.github.com/users/22a/followers","following_url":"https://api.github.com/users/22a/following{/other_user}","gists_url":"https://api.github.com/users/22a/gists{/gist_id}","starred_url":"https://api.github.com/users/22a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/22a/subscriptions","organizations_url":"https://api.github.com/users/22a/orgs","repos_url":"https://api.github.com/users/22a/repos","events_url":"https://api.github.com/users/22a/events{/privacy}","received_events_url":"https://api.github.com/users/22a/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":18,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"22a"}}