{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/223264183","pull_request_review_id":162346794,"id":223264183,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzI2NDE4Mw==","diff_hunk":"@@ -279,6 +279,13 @@ void ATHandler::cmd_stop()\n {\n }\n \n+void ATHandler::cmd_stop_read_resp()","path":"features/cellular/UNITTESTS/stubs/ATHandler_stub.cpp","position":4,"original_position":4,"commit_id":"c7db6210a2c7f3ae4f24a3945ea2bd363c64e3c4","original_commit_id":"c7db6210a2c7f3ae4f24a3945ea2bd363c64e3c4","user":{"login":"kivaisan","id":31539332,"node_id":"MDQ6VXNlcjMxNTM5MzMy","avatar_url":"https://avatars1.githubusercontent.com/u/31539332?v=4","gravatar_id":"","url":"https://api.github.com/users/kivaisan","html_url":"https://github.com/kivaisan","followers_url":"https://api.github.com/users/kivaisan/followers","following_url":"https://api.github.com/users/kivaisan/following{/other_user}","gists_url":"https://api.github.com/users/kivaisan/gists{/gist_id}","starred_url":"https://api.github.com/users/kivaisan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivaisan/subscriptions","organizations_url":"https://api.github.com/users/kivaisan/orgs","repos_url":"https://api.github.com/users/kivaisan/repos","events_url":"https://api.github.com/users/kivaisan/events{/privacy}","received_events_url":"https://api.github.com/users/kivaisan/received_events","type":"User","site_admin":false},"body":"@jarvte If these old unit tests can be removed, maybe those could be done with a own PR.","created_at":"2018-10-08T07:14:33Z","updated_at":"2018-10-08T07:14:33Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/8313#discussion_r223264183","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8313","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/223264183"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8313#discussion_r223264183"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8313"}},"in_reply_to_id":222533803},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8313","id":219955095,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTU1MDk1","html_url":"https://github.com/ARMmbed/mbed-os/pull/8313","diff_url":"https://github.com/ARMmbed/mbed-os/pull/8313.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/8313.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8313","number":8313,"state":"open","locked":false,"title":"Reduce cellular memory footprint","user":{"login":"kivaisan","id":31539332,"node_id":"MDQ6VXNlcjMxNTM5MzMy","avatar_url":"https://avatars1.githubusercontent.com/u/31539332?v=4","gravatar_id":"","url":"https://api.github.com/users/kivaisan","html_url":"https://github.com/kivaisan","followers_url":"https://api.github.com/users/kivaisan/followers","following_url":"https://api.github.com/users/kivaisan/following{/other_user}","gists_url":"https://api.github.com/users/kivaisan/gists{/gist_id}","starred_url":"https://api.github.com/users/kivaisan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivaisan/subscriptions","organizations_url":"https://api.github.com/users/kivaisan/orgs","repos_url":"https://api.github.com/users/kivaisan/repos","events_url":"https://api.github.com/users/kivaisan/events{/privacy}","received_events_url":"https://api.github.com/users/kivaisan/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nReduce cellular ROM usage with some optimizations. With ARMC5 this reduces cellular object size ~300Bytes and with GCC_ARM ~1kB.\r\n\r\nInternal ref: IOTCELL-1120\r\n\r\n### Pull request type\r\n\r\n    [ ] Fix\r\n    [X] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-10-03T08:35:19Z","updated_at":"2018-10-08T07:14:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b197f1920e630e7e439431ec5c4ce5e0935ee60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":144902129,"node_id":"MDU6TGFiZWwxNDQ5MDIxMjk=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8313/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8313/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8313/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/c7db6210a2c7f3ae4f24a3945ea2bd363c64e3c4","head":{"label":"kivaisan:reduce_memory_footprint","ref":"reduce_memory_footprint","sha":"c7db6210a2c7f3ae4f24a3945ea2bd363c64e3c4","user":{"login":"kivaisan","id":31539332,"node_id":"MDQ6VXNlcjMxNTM5MzMy","avatar_url":"https://avatars1.githubusercontent.com/u/31539332?v=4","gravatar_id":"","url":"https://api.github.com/users/kivaisan","html_url":"https://github.com/kivaisan","followers_url":"https://api.github.com/users/kivaisan/followers","following_url":"https://api.github.com/users/kivaisan/following{/other_user}","gists_url":"https://api.github.com/users/kivaisan/gists{/gist_id}","starred_url":"https://api.github.com/users/kivaisan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivaisan/subscriptions","organizations_url":"https://api.github.com/users/kivaisan/orgs","repos_url":"https://api.github.com/users/kivaisan/repos","events_url":"https://api.github.com/users/kivaisan/events{/privacy}","received_events_url":"https://api.github.com/users/kivaisan/received_events","type":"User","site_admin":false},"repo":{"id":119972617,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5NzI2MTc=","name":"mbed-os","full_name":"kivaisan/mbed-os","private":false,"owner":{"login":"kivaisan","id":31539332,"node_id":"MDQ6VXNlcjMxNTM5MzMy","avatar_url":"https://avatars1.githubusercontent.com/u/31539332?v=4","gravatar_id":"","url":"https://api.github.com/users/kivaisan","html_url":"https://github.com/kivaisan","followers_url":"https://api.github.com/users/kivaisan/followers","following_url":"https://api.github.com/users/kivaisan/following{/other_user}","gists_url":"https://api.github.com/users/kivaisan/gists{/gist_id}","starred_url":"https://api.github.com/users/kivaisan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivaisan/subscriptions","organizations_url":"https://api.github.com/users/kivaisan/orgs","repos_url":"https://api.github.com/users/kivaisan/repos","events_url":"https://api.github.com/users/kivaisan/events{/privacy}","received_events_url":"https://api.github.com/users/kivaisan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kivaisan/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/kivaisan/mbed-os","forks_url":"https://api.github.com/repos/kivaisan/mbed-os/forks","keys_url":"https://api.github.com/repos/kivaisan/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kivaisan/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kivaisan/mbed-os/teams","hooks_url":"https://api.github.com/repos/kivaisan/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/kivaisan/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/kivaisan/mbed-os/events","assignees_url":"https://api.github.com/repos/kivaisan/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/kivaisan/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/kivaisan/mbed-os/tags","blobs_url":"https://api.github.com/repos/kivaisan/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kivaisan/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kivaisan/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/kivaisan/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kivaisan/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/kivaisan/mbed-os/languages","stargazers_url":"https://api.github.com/repos/kivaisan/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/kivaisan/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/kivaisan/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/kivaisan/mbed-os/subscription","commits_url":"https://api.github.com/repos/kivaisan/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/kivaisan/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/kivaisan/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/kivaisan/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/kivaisan/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/kivaisan/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kivaisan/mbed-os/merges","archive_url":"https://api.github.com/repos/kivaisan/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kivaisan/mbed-os/downloads","issues_url":"https://api.github.com/repos/kivaisan/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/kivaisan/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/kivaisan/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/kivaisan/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kivaisan/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/kivaisan/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/kivaisan/mbed-os/deployments","created_at":"2018-02-02T11:16:04Z","updated_at":"2018-10-03T07:25:45Z","pushed_at":"2018-10-04T13:11:34Z","git_url":"git://github.com/kivaisan/mbed-os.git","ssh_url":"git@github.com:kivaisan/mbed-os.git","clone_url":"https://github.com/kivaisan/mbed-os.git","svn_url":"https://github.com/kivaisan/mbed-os","homepage":"https://mbed.com","size":229963,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"8b623156e5fe8e46b6d9ece9101515aa5d37ab13","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-10-07T19:33:25Z","pushed_at":"2018-10-06T20:02:25Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":232711,"stargazers_count":1979,"watchers_count":1979,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1629,"mirror_url":null,"archived":false,"open_issues_count":497,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1629,"open_issues":497,"watchers":1979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8313"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8313"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8313"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8313/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8313/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8313/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/c7db6210a2c7f3ae4f24a3945ea2bd363c64e3c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kivaisan"}}