{"action":"created","comment":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments/167748550","pull_request_review_id":96012283,"id":167748550,"diff_hunk":"@@ -928,23 +937,41 @@ def do_draw(self, data):\n \n @cacheable\n @defines_strategy\n-def builds(target, *args, **kwargs):\n+def builds(*target_and_args, **kwargs):","path":"src/hypothesis/strategies.py","position":31,"original_position":31,"commit_id":"f02799c0e0a1dbb90e52884b490b99bdcbd98eb7","original_commit_id":"f02799c0e0a1dbb90e52884b490b99bdcbd98eb7","user":{"login":"dchudz","id":1222726,"avatar_url":"https://avatars0.githubusercontent.com/u/1222726?v=4","gravatar_id":"","url":"https://api.github.com/users/dchudz","html_url":"https://github.com/dchudz","followers_url":"https://api.github.com/users/dchudz/followers","following_url":"https://api.github.com/users/dchudz/following{/other_user}","gists_url":"https://api.github.com/users/dchudz/gists{/gist_id}","starred_url":"https://api.github.com/users/dchudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchudz/subscriptions","organizations_url":"https://api.github.com/users/dchudz/orgs","repos_url":"https://api.github.com/users/dchudz/repos","events_url":"https://api.github.com/users/dchudz/events{/privacy}","received_events_url":"https://api.github.com/users/dchudz/received_events","type":"User","site_admin":false},"body":"Oh yeah, makes sense.","created_at":"2018-02-13T02:48:08Z","updated_at":"2018-02-13T02:48:08Z","html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106#discussion_r167748550","pull_request_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/1106","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments/167748550"},"html":{"href":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106#discussion_r167748550"},"pull_request":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/1106"}},"in_reply_to_id":167747784},"pull_request":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/1106","id":168494909,"html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106","diff_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106.diff","patch_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106.patch","issue_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1106","number":1106,"state":"open","locked":false,"title":"rename target arg so we can use targets requiring an argument 'target'","user":{"login":"dchudz","id":1222726,"avatar_url":"https://avatars0.githubusercontent.com/u/1222726?v=4","gravatar_id":"","url":"https://api.github.com/users/dchudz","html_url":"https://github.com/dchudz","followers_url":"https://api.github.com/users/dchudz/followers","following_url":"https://api.github.com/users/dchudz/following{/other_user}","gists_url":"https://api.github.com/users/dchudz/gists{/gist_id}","starred_url":"https://api.github.com/users/dchudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchudz/subscriptions","organizations_url":"https://api.github.com/users/dchudz/orgs","repos_url":"https://api.github.com/users/dchudz/repos","events_url":"https://api.github.com/users/dchudz/events{/privacy}","received_events_url":"https://api.github.com/users/dchudz/received_events","type":"User","site_admin":false},"body":"This is my attempt to address https://github.com/HypothesisWorks/hypothesis-python/issues/1104, following the suggestion in the comment from @DRMacIver on that issue.\r\n\r\nBut I don't think it's good:\r\n\r\n- calling `builds()` with no argument for the target no longer raises `TypeError` (`builds().example()` does), since the new code here isn't actually run when you call `builds()`\r\n- for the same reason, the deprecation warning doesn't show when you first call `builds()`\r\n\r\nI'm not thinking of any ways to fix this without adding a bunch of complication (I'd have to mess with `proxies()` and/or `base_defines_strategy()`?).\r\n\r\nI'm completely new here, but it seems to me that merging this would make life worse for users and developers.\r\n\r\nI figured I'd post it anyway, since (a) maybe I'm wrong about that or (b) I'd love to be pointed in a better direction if anyone has time to set me right.\r\n\r\nOr if not, we can just close this and add to the issue: \"Don't fix it THAT way!\"\r\n","created_at":"2018-02-12T03:37:20Z","updated_at":"2018-02-13T02:48:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3959463b13428e31fb006f3150716f3ca047ad7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/1106/commits","review_comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/1106/comments","review_comment_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1106/comments","statuses_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/statuses/f02799c0e0a1dbb90e52884b490b99bdcbd98eb7","head":{"label":"dchudz:rename-builds-target-arg","ref":"rename-builds-target-arg","sha":"f02799c0e0a1dbb90e52884b490b99bdcbd98eb7","user":{"login":"dchudz","id":1222726,"avatar_url":"https://avatars0.githubusercontent.com/u/1222726?v=4","gravatar_id":"","url":"https://api.github.com/users/dchudz","html_url":"https://github.com/dchudz","followers_url":"https://api.github.com/users/dchudz/followers","following_url":"https://api.github.com/users/dchudz/following{/other_user}","gists_url":"https://api.github.com/users/dchudz/gists{/gist_id}","starred_url":"https://api.github.com/users/dchudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchudz/subscriptions","organizations_url":"https://api.github.com/users/dchudz/orgs","repos_url":"https://api.github.com/users/dchudz/repos","events_url":"https://api.github.com/users/dchudz/events{/privacy}","received_events_url":"https://api.github.com/users/dchudz/received_events","type":"User","site_admin":false},"repo":{"id":121194738,"name":"hypothesis-python","full_name":"dchudz/hypothesis-python","owner":{"login":"dchudz","id":1222726,"avatar_url":"https://avatars0.githubusercontent.com/u/1222726?v=4","gravatar_id":"","url":"https://api.github.com/users/dchudz","html_url":"https://github.com/dchudz","followers_url":"https://api.github.com/users/dchudz/followers","following_url":"https://api.github.com/users/dchudz/following{/other_user}","gists_url":"https://api.github.com/users/dchudz/gists{/gist_id}","starred_url":"https://api.github.com/users/dchudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchudz/subscriptions","organizations_url":"https://api.github.com/users/dchudz/orgs","repos_url":"https://api.github.com/users/dchudz/repos","events_url":"https://api.github.com/users/dchudz/events{/privacy}","received_events_url":"https://api.github.com/users/dchudz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dchudz/hypothesis-python","description":"Advanced property-based (QuickCheck-like) testing for Python","fork":true,"url":"https://api.github.com/repos/dchudz/hypothesis-python","forks_url":"https://api.github.com/repos/dchudz/hypothesis-python/forks","keys_url":"https://api.github.com/repos/dchudz/hypothesis-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dchudz/hypothesis-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dchudz/hypothesis-python/teams","hooks_url":"https://api.github.com/repos/dchudz/hypothesis-python/hooks","issue_events_url":"https://api.github.com/repos/dchudz/hypothesis-python/issues/events{/number}","events_url":"https://api.github.com/repos/dchudz/hypothesis-python/events","assignees_url":"https://api.github.com/repos/dchudz/hypothesis-python/assignees{/user}","branches_url":"https://api.github.com/repos/dchudz/hypothesis-python/branches{/branch}","tags_url":"https://api.github.com/repos/dchudz/hypothesis-python/tags","blobs_url":"https://api.github.com/repos/dchudz/hypothesis-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dchudz/hypothesis-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dchudz/hypothesis-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dchudz/hypothesis-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dchudz/hypothesis-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dchudz/hypothesis-python/languages","stargazers_url":"https://api.github.com/repos/dchudz/hypothesis-python/stargazers","contributors_url":"https://api.github.com/repos/dchudz/hypothesis-python/contributors","subscribers_url":"https://api.github.com/repos/dchudz/hypothesis-python/subscribers","subscription_url":"https://api.github.com/repos/dchudz/hypothesis-python/subscription","commits_url":"https://api.github.com/repos/dchudz/hypothesis-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dchudz/hypothesis-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dchudz/hypothesis-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dchudz/hypothesis-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dchudz/hypothesis-python/contents/{+path}","compare_url":"https://api.github.com/repos/dchudz/hypothesis-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dchudz/hypothesis-python/merges","archive_url":"https://api.github.com/repos/dchudz/hypothesis-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dchudz/hypothesis-python/downloads","issues_url":"https://api.github.com/repos/dchudz/hypothesis-python/issues{/number}","pulls_url":"https://api.github.com/repos/dchudz/hypothesis-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dchudz/hypothesis-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dchudz/hypothesis-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dchudz/hypothesis-python/labels{/name}","releases_url":"https://api.github.com/repos/dchudz/hypothesis-python/releases{/id}","deployments_url":"https://api.github.com/repos/dchudz/hypothesis-python/deployments","created_at":"2018-02-12T03:21:31Z","updated_at":"2018-02-12T03:21:33Z","pushed_at":"2018-02-13T02:29:07Z","git_url":"git://github.com/dchudz/hypothesis-python.git","ssh_url":"git@github.com:dchudz/hypothesis-python.git","clone_url":"https://github.com/dchudz/hypothesis-python.git","svn_url":"https://github.com/dchudz/hypothesis-python","homepage":"http://hypothesis.works","size":10171,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HypothesisWorks:master","ref":"master","sha":"eacf7961e1bbc7426e7340f386a57e29d4b60a89","user":{"login":"HypothesisWorks","id":18481919,"avatar_url":"https://avatars1.githubusercontent.com/u/18481919?v=4","gravatar_id":"","url":"https://api.github.com/users/HypothesisWorks","html_url":"https://github.com/HypothesisWorks","followers_url":"https://api.github.com/users/HypothesisWorks/followers","following_url":"https://api.github.com/users/HypothesisWorks/following{/other_user}","gists_url":"https://api.github.com/users/HypothesisWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/HypothesisWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HypothesisWorks/subscriptions","organizations_url":"https://api.github.com/users/HypothesisWorks/orgs","repos_url":"https://api.github.com/users/HypothesisWorks/repos","events_url":"https://api.github.com/users/HypothesisWorks/events{/privacy}","received_events_url":"https://api.github.com/users/HypothesisWorks/received_events","type":"Organization","site_admin":false},"repo":{"id":8685799,"name":"hypothesis-python","full_name":"HypothesisWorks/hypothesis-python","owner":{"login":"HypothesisWorks","id":18481919,"avatar_url":"https://avatars1.githubusercontent.com/u/18481919?v=4","gravatar_id":"","url":"https://api.github.com/users/HypothesisWorks","html_url":"https://github.com/HypothesisWorks","followers_url":"https://api.github.com/users/HypothesisWorks/followers","following_url":"https://api.github.com/users/HypothesisWorks/following{/other_user}","gists_url":"https://api.github.com/users/HypothesisWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/HypothesisWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HypothesisWorks/subscriptions","organizations_url":"https://api.github.com/users/HypothesisWorks/orgs","repos_url":"https://api.github.com/users/HypothesisWorks/repos","events_url":"https://api.github.com/users/HypothesisWorks/events{/privacy}","received_events_url":"https://api.github.com/users/HypothesisWorks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HypothesisWorks/hypothesis-python","description":"Advanced property-based (QuickCheck-like) testing for Python","fork":false,"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python","forks_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/forks","keys_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/teams","hooks_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/hooks","issue_events_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/events{/number}","events_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/events","assignees_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/assignees{/user}","branches_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/branches{/branch}","tags_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/tags","blobs_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/statuses/{sha}","languages_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/languages","stargazers_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/stargazers","contributors_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/contributors","subscribers_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/subscribers","subscription_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/subscription","commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/contents/{+path}","compare_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/merges","archive_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/downloads","issues_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues{/number}","pulls_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls{/number}","milestones_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/milestones{/number}","notifications_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/labels{/name}","releases_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/releases{/id}","deployments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/deployments","created_at":"2013-03-10T13:51:19Z","updated_at":"2018-02-12T18:50:27Z","pushed_at":"2018-02-13T02:29:08Z","git_url":"git://github.com/HypothesisWorks/hypothesis-python.git","ssh_url":"git@github.com:HypothesisWorks/hypothesis-python.git","clone_url":"https://github.com/HypothesisWorks/hypothesis-python.git","svn_url":"https://github.com/HypothesisWorks/hypothesis-python","homepage":"http://hypothesis.works","size":10189,"stargazers_count":2460,"watchers_count":2460,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":213,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":213,"open_issues":116,"watchers":2460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/1106"},"html":{"href":"https://github.com/HypothesisWorks/hypothesis-python/pull/1106"},"issue":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1106"},"comments":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/1106/comments"},"review_comments":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/1106/comments"},"review_comment":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/1106/commits"},"statuses":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/statuses/f02799c0e0a1dbb90e52884b490b99bdcbd98eb7"}},"author_association":"NONE"}}
{"actor":{"display_login":"dchudz"}}