{"action":"created","comment":{"url":"https://api.github.com/repos/SvetaAn18/test/pulls/comments/212091975","pull_request_review_id":148649414,"id":212091975,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjA5MTk3NQ==","diff_hunk":"@@ -7,9 +7,7 @@\n # Ignore bundler config.\n /.bundle\n \n-# Ignore the default SQLite database.\n-/db/*.sqlite3\n-/db/*.sqlite3-journal\n+database.yml","path":".gitignore","position":7,"original_position":7,"commit_id":"285bcd788fc5de26d50925a11701058f7e358176","original_commit_id":"285bcd788fc5de26d50925a11701058f7e358176","user":{"login":"graffzon","id":701016,"node_id":"MDQ6VXNlcjcwMTAxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/701016?v=4","gravatar_id":"","url":"https://api.github.com/users/graffzon","html_url":"https://github.com/graffzon","followers_url":"https://api.github.com/users/graffzon/followers","following_url":"https://api.github.com/users/graffzon/following{/other_user}","gists_url":"https://api.github.com/users/graffzon/gists{/gist_id}","starred_url":"https://api.github.com/users/graffzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graffzon/subscriptions","organizations_url":"https://api.github.com/users/graffzon/orgs","repos_url":"https://api.github.com/users/graffzon/repos","events_url":"https://api.github.com/users/graffzon/events{/privacy}","received_events_url":"https://api.github.com/users/graffzon/received_events","type":"User","site_admin":false},"body":"Здорово, что ты знаешь, что такое gitignore!\r\nИ я рад, что ты понимаешь, что если у тебя в database.yml пароли - нельзя их хранить в гите, а нужно прятать в гитигнор.\r\nОднако я хочу предложить пару улучшений.\r\n1. Скорее фикс. Проверь, правильно ли ты указала путь к этому файлу, мне кажется, ты кое-что забыла.\r\n2. Как правило в реальном проекте тебе важно, чтобы твои коллеги могли знать, какого типа файл вообще ожидается. Поэтому обычно у тебя есть два файла: `database.yml`, который содержит твои пароли и который лежит в гитигноре, и `database.yml.example`, который на самом деле не обрабатывается рельсами и лежит просто как пример и НЕ содержит паролей. И вот он уже спокойно кладется в гит. Я предлагаю так и организовать.","created_at":"2018-08-22T20:12:51Z","updated_at":"2018-08-22T20:13:57Z","html_url":"https://github.com/SvetaAn18/test/pull/1#discussion_r212091975","pull_request_url":"https://api.github.com/repos/SvetaAn18/test/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SvetaAn18/test/pulls/comments/212091975"},"html":{"href":"https://github.com/SvetaAn18/test/pull/1#discussion_r212091975"},"pull_request":{"href":"https://api.github.com/repos/SvetaAn18/test/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/SvetaAn18/test/pulls/1","id":210099658,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDk5NjU4","html_url":"https://github.com/SvetaAn18/test/pull/1","diff_url":"https://github.com/SvetaAn18/test/pull/1.diff","patch_url":"https://github.com/SvetaAn18/test/pull/1.patch","issue_url":"https://api.github.com/repos/SvetaAn18/test/issues/1","number":1,"state":"open","locked":false,"title":"Change db","user":{"login":"SvetaAn18","id":40295495,"node_id":"MDQ6VXNlcjQwMjk1NDk1","avatar_url":"https://avatars2.githubusercontent.com/u/40295495?v=4","gravatar_id":"","url":"https://api.github.com/users/SvetaAn18","html_url":"https://github.com/SvetaAn18","followers_url":"https://api.github.com/users/SvetaAn18/followers","following_url":"https://api.github.com/users/SvetaAn18/following{/other_user}","gists_url":"https://api.github.com/users/SvetaAn18/gists{/gist_id}","starred_url":"https://api.github.com/users/SvetaAn18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvetaAn18/subscriptions","organizations_url":"https://api.github.com/users/SvetaAn18/orgs","repos_url":"https://api.github.com/users/SvetaAn18/repos","events_url":"https://api.github.com/users/SvetaAn18/events{/privacy}","received_events_url":"https://api.github.com/users/SvetaAn18/received_events","type":"User","site_admin":false},"body":"Change db (SQLite on PG)","created_at":"2018-08-22T11:16:15Z","updated_at":"2018-08-22T20:13:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f086900ef1d67865a416f97b454776764ed3a41e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SvetaAn18/test/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SvetaAn18/test/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SvetaAn18/test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SvetaAn18/test/issues/1/comments","statuses_url":"https://api.github.com/repos/SvetaAn18/test/statuses/285bcd788fc5de26d50925a11701058f7e358176","head":{"label":"SvetaAn18:change-db","ref":"change-db","sha":"285bcd788fc5de26d50925a11701058f7e358176","user":{"login":"SvetaAn18","id":40295495,"node_id":"MDQ6VXNlcjQwMjk1NDk1","avatar_url":"https://avatars2.githubusercontent.com/u/40295495?v=4","gravatar_id":"","url":"https://api.github.com/users/SvetaAn18","html_url":"https://github.com/SvetaAn18","followers_url":"https://api.github.com/users/SvetaAn18/followers","following_url":"https://api.github.com/users/SvetaAn18/following{/other_user}","gists_url":"https://api.github.com/users/SvetaAn18/gists{/gist_id}","starred_url":"https://api.github.com/users/SvetaAn18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvetaAn18/subscriptions","organizations_url":"https://api.github.com/users/SvetaAn18/orgs","repos_url":"https://api.github.com/users/SvetaAn18/repos","events_url":"https://api.github.com/users/SvetaAn18/events{/privacy}","received_events_url":"https://api.github.com/users/SvetaAn18/received_events","type":"User","site_admin":false},"repo":{"id":138420666,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0MjA2NjY=","name":"test","full_name":"SvetaAn18/test","owner":{"login":"SvetaAn18","id":40295495,"node_id":"MDQ6VXNlcjQwMjk1NDk1","avatar_url":"https://avatars2.githubusercontent.com/u/40295495?v=4","gravatar_id":"","url":"https://api.github.com/users/SvetaAn18","html_url":"https://github.com/SvetaAn18","followers_url":"https://api.github.com/users/SvetaAn18/followers","following_url":"https://api.github.com/users/SvetaAn18/following{/other_user}","gists_url":"https://api.github.com/users/SvetaAn18/gists{/gist_id}","starred_url":"https://api.github.com/users/SvetaAn18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvetaAn18/subscriptions","organizations_url":"https://api.github.com/users/SvetaAn18/orgs","repos_url":"https://api.github.com/users/SvetaAn18/repos","events_url":"https://api.github.com/users/SvetaAn18/events{/privacy}","received_events_url":"https://api.github.com/users/SvetaAn18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SvetaAn18/test","description":null,"fork":false,"url":"https://api.github.com/repos/SvetaAn18/test","forks_url":"https://api.github.com/repos/SvetaAn18/test/forks","keys_url":"https://api.github.com/repos/SvetaAn18/test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SvetaAn18/test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SvetaAn18/test/teams","hooks_url":"https://api.github.com/repos/SvetaAn18/test/hooks","issue_events_url":"https://api.github.com/repos/SvetaAn18/test/issues/events{/number}","events_url":"https://api.github.com/repos/SvetaAn18/test/events","assignees_url":"https://api.github.com/repos/SvetaAn18/test/assignees{/user}","branches_url":"https://api.github.com/repos/SvetaAn18/test/branches{/branch}","tags_url":"https://api.github.com/repos/SvetaAn18/test/tags","blobs_url":"https://api.github.com/repos/SvetaAn18/test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SvetaAn18/test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SvetaAn18/test/git/refs{/sha}","trees_url":"https://api.github.com/repos/SvetaAn18/test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SvetaAn18/test/statuses/{sha}","languages_url":"https://api.github.com/repos/SvetaAn18/test/languages","stargazers_url":"https://api.github.com/repos/SvetaAn18/test/stargazers","contributors_url":"https://api.github.com/repos/SvetaAn18/test/contributors","subscribers_url":"https://api.github.com/repos/SvetaAn18/test/subscribers","subscription_url":"https://api.github.com/repos/SvetaAn18/test/subscription","commits_url":"https://api.github.com/repos/SvetaAn18/test/commits{/sha}","git_commits_url":"https://api.github.com/repos/SvetaAn18/test/git/commits{/sha}","comments_url":"https://api.github.com/repos/SvetaAn18/test/comments{/number}","issue_comment_url":"https://api.github.com/repos/SvetaAn18/test/issues/comments{/number}","contents_url":"https://api.github.com/repos/SvetaAn18/test/contents/{+path}","compare_url":"https://api.github.com/repos/SvetaAn18/test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SvetaAn18/test/merges","archive_url":"https://api.github.com/repos/SvetaAn18/test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SvetaAn18/test/downloads","issues_url":"https://api.github.com/repos/SvetaAn18/test/issues{/number}","pulls_url":"https://api.github.com/repos/SvetaAn18/test/pulls{/number}","milestones_url":"https://api.github.com/repos/SvetaAn18/test/milestones{/number}","notifications_url":"https://api.github.com/repos/SvetaAn18/test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SvetaAn18/test/labels{/name}","releases_url":"https://api.github.com/repos/SvetaAn18/test/releases{/id}","deployments_url":"https://api.github.com/repos/SvetaAn18/test/deployments","created_at":"2018-06-23T17:25:18Z","updated_at":"2018-08-08T09:50:18Z","pushed_at":"2018-08-22T16:47:19Z","git_url":"git://github.com/SvetaAn18/test.git","ssh_url":"git@github.com:SvetaAn18/test.git","clone_url":"https://github.com/SvetaAn18/test.git","svn_url":"https://github.com/SvetaAn18/test","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"SvetaAn18:master","ref":"master","sha":"4847b9da64e94f10dfb42d8e3cc35504a22b8dc6","user":{"login":"SvetaAn18","id":40295495,"node_id":"MDQ6VXNlcjQwMjk1NDk1","avatar_url":"https://avatars2.githubusercontent.com/u/40295495?v=4","gravatar_id":"","url":"https://api.github.com/users/SvetaAn18","html_url":"https://github.com/SvetaAn18","followers_url":"https://api.github.com/users/SvetaAn18/followers","following_url":"https://api.github.com/users/SvetaAn18/following{/other_user}","gists_url":"https://api.github.com/users/SvetaAn18/gists{/gist_id}","starred_url":"https://api.github.com/users/SvetaAn18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvetaAn18/subscriptions","organizations_url":"https://api.github.com/users/SvetaAn18/orgs","repos_url":"https://api.github.com/users/SvetaAn18/repos","events_url":"https://api.github.com/users/SvetaAn18/events{/privacy}","received_events_url":"https://api.github.com/users/SvetaAn18/received_events","type":"User","site_admin":false},"repo":{"id":138420666,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0MjA2NjY=","name":"test","full_name":"SvetaAn18/test","owner":{"login":"SvetaAn18","id":40295495,"node_id":"MDQ6VXNlcjQwMjk1NDk1","avatar_url":"https://avatars2.githubusercontent.com/u/40295495?v=4","gravatar_id":"","url":"https://api.github.com/users/SvetaAn18","html_url":"https://github.com/SvetaAn18","followers_url":"https://api.github.com/users/SvetaAn18/followers","following_url":"https://api.github.com/users/SvetaAn18/following{/other_user}","gists_url":"https://api.github.com/users/SvetaAn18/gists{/gist_id}","starred_url":"https://api.github.com/users/SvetaAn18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvetaAn18/subscriptions","organizations_url":"https://api.github.com/users/SvetaAn18/orgs","repos_url":"https://api.github.com/users/SvetaAn18/repos","events_url":"https://api.github.com/users/SvetaAn18/events{/privacy}","received_events_url":"https://api.github.com/users/SvetaAn18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SvetaAn18/test","description":null,"fork":false,"url":"https://api.github.com/repos/SvetaAn18/test","forks_url":"https://api.github.com/repos/SvetaAn18/test/forks","keys_url":"https://api.github.com/repos/SvetaAn18/test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SvetaAn18/test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SvetaAn18/test/teams","hooks_url":"https://api.github.com/repos/SvetaAn18/test/hooks","issue_events_url":"https://api.github.com/repos/SvetaAn18/test/issues/events{/number}","events_url":"https://api.github.com/repos/SvetaAn18/test/events","assignees_url":"https://api.github.com/repos/SvetaAn18/test/assignees{/user}","branches_url":"https://api.github.com/repos/SvetaAn18/test/branches{/branch}","tags_url":"https://api.github.com/repos/SvetaAn18/test/tags","blobs_url":"https://api.github.com/repos/SvetaAn18/test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SvetaAn18/test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SvetaAn18/test/git/refs{/sha}","trees_url":"https://api.github.com/repos/SvetaAn18/test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SvetaAn18/test/statuses/{sha}","languages_url":"https://api.github.com/repos/SvetaAn18/test/languages","stargazers_url":"https://api.github.com/repos/SvetaAn18/test/stargazers","contributors_url":"https://api.github.com/repos/SvetaAn18/test/contributors","subscribers_url":"https://api.github.com/repos/SvetaAn18/test/subscribers","subscription_url":"https://api.github.com/repos/SvetaAn18/test/subscription","commits_url":"https://api.github.com/repos/SvetaAn18/test/commits{/sha}","git_commits_url":"https://api.github.com/repos/SvetaAn18/test/git/commits{/sha}","comments_url":"https://api.github.com/repos/SvetaAn18/test/comments{/number}","issue_comment_url":"https://api.github.com/repos/SvetaAn18/test/issues/comments{/number}","contents_url":"https://api.github.com/repos/SvetaAn18/test/contents/{+path}","compare_url":"https://api.github.com/repos/SvetaAn18/test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SvetaAn18/test/merges","archive_url":"https://api.github.com/repos/SvetaAn18/test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SvetaAn18/test/downloads","issues_url":"https://api.github.com/repos/SvetaAn18/test/issues{/number}","pulls_url":"https://api.github.com/repos/SvetaAn18/test/pulls{/number}","milestones_url":"https://api.github.com/repos/SvetaAn18/test/milestones{/number}","notifications_url":"https://api.github.com/repos/SvetaAn18/test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SvetaAn18/test/labels{/name}","releases_url":"https://api.github.com/repos/SvetaAn18/test/releases{/id}","deployments_url":"https://api.github.com/repos/SvetaAn18/test/deployments","created_at":"2018-06-23T17:25:18Z","updated_at":"2018-08-08T09:50:18Z","pushed_at":"2018-08-22T16:47:19Z","git_url":"git://github.com/SvetaAn18/test.git","ssh_url":"git@github.com:SvetaAn18/test.git","clone_url":"https://github.com/SvetaAn18/test.git","svn_url":"https://github.com/SvetaAn18/test","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SvetaAn18/test/pulls/1"},"html":{"href":"https://github.com/SvetaAn18/test/pull/1"},"issue":{"href":"https://api.github.com/repos/SvetaAn18/test/issues/1"},"comments":{"href":"https://api.github.com/repos/SvetaAn18/test/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SvetaAn18/test/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SvetaAn18/test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SvetaAn18/test/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SvetaAn18/test/statuses/285bcd788fc5de26d50925a11701058f7e358176"}},"author_association":"OWNER"}}
{"actor":{"display_login":"graffzon"}}