{"action":"created","comment":{"url":"https://api.github.com/repos/yt-project/yt/pulls/comments/216166221","pull_request_review_id":153589780,"id":216166221,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjE2NjIyMQ==","diff_hunk":"@@ -71,8 +71,9 @@ def _read_particle_coords(self, chunks, ptf):\n                 y = f[\"/%s/Coordinates\" % ptype][si:ei, 1].astype(\"float64\")\n                 z = f[\"/%s/Coordinates\" % ptype][si:ei, 2].astype(\"float64\")\n                 if ptype == self.ds._sph_ptype:\n-                    hsml = f[\n-                        \"/%s/SmoothingLength\" % ptype][si:ei].astype(\"float64\")\n+                    pdtype = f[\"/%s/Coordinates\" % ptype].dtype\n+                    pshape = f[\"/%s/Coordinates\" % ptype].shape\n+                    hsml = self._get_smoothing_length(data_file, pdtype, pshape)","path":"yt/frontends/gadget/io.py","position":8,"original_position":8,"commit_id":"3db048c6f32e7f5b5c05d6e3c6a01058f24765e3","original_commit_id":"3db048c6f32e7f5b5c05d6e3c6a01058f24765e3","user":{"login":"jzuhone","id":1914976,"node_id":"MDQ6VXNlcjE5MTQ5NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1914976?v=4","gravatar_id":"","url":"https://api.github.com/users/jzuhone","html_url":"https://github.com/jzuhone","followers_url":"https://api.github.com/users/jzuhone/followers","following_url":"https://api.github.com/users/jzuhone/following{/other_user}","gists_url":"https://api.github.com/users/jzuhone/gists{/gist_id}","starred_url":"https://api.github.com/users/jzuhone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzuhone/subscriptions","organizations_url":"https://api.github.com/users/jzuhone/orgs","repos_url":"https://api.github.com/users/jzuhone/repos","events_url":"https://api.github.com/users/jzuhone/events{/privacy}","received_events_url":"https://api.github.com/users/jzuhone/received_events","type":"User","site_admin":false},"body":"@MatthewTurk it shouldn't change anything, although I just noticed that I missed out the `astype(\"float64\")` bit. look below in the call to `_get_smoothing_length`.","created_at":"2018-09-09T18:58:02Z","updated_at":"2018-09-09T18:58:03Z","html_url":"https://github.com/yt-project/yt/pull/1807#discussion_r216166221","pull_request_url":"https://api.github.com/repos/yt-project/yt/pulls/1807","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yt-project/yt/pulls/comments/216166221"},"html":{"href":"https://github.com/yt-project/yt/pull/1807#discussion_r216166221"},"pull_request":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1807"}},"in_reply_to_id":216165993},"pull_request":{"url":"https://api.github.com/repos/yt-project/yt/pulls/1807","id":191257034,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjU3MDM0","html_url":"https://github.com/yt-project/yt/pull/1807","diff_url":"https://github.com/yt-project/yt/pull/1807.diff","patch_url":"https://github.com/yt-project/yt/pull/1807.patch","issue_url":"https://api.github.com/repos/yt-project/yt/issues/1807","number":1807,"state":"open","locked":false,"title":"[WIP] Support Arepo data as a modified Gadget dataset","user":{"login":"jzuhone","id":1914976,"node_id":"MDQ6VXNlcjE5MTQ5NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1914976?v=4","gravatar_id":"","url":"https://api.github.com/users/jzuhone","html_url":"https://github.com/jzuhone","followers_url":"https://api.github.com/users/jzuhone/followers","following_url":"https://api.github.com/users/jzuhone/following{/other_user}","gists_url":"https://api.github.com/users/jzuhone/gists{/gist_id}","starred_url":"https://api.github.com/users/jzuhone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzuhone/subscriptions","organizations_url":"https://api.github.com/users/jzuhone/orgs","repos_url":"https://api.github.com/users/jzuhone/repos","events_url":"https://api.github.com/users/jzuhone/events{/privacy}","received_events_url":"https://api.github.com/users/jzuhone/received_events","type":"User","site_admin":false},"body":"This PR enables support for Arepo data in the demeshening branch by setting up special classes for this dataset type. The main issue is that Arepo data has no smoothing length for the gas particles, so we have to estimate a smoothing length based on 2.5 * the radius of the cell volume, which was a suggestion given to me by some Arepo folks. ","created_at":"2018-05-29T20:12:10Z","updated_at":"2018-09-09T18:58:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edf245869ba9b1f5ec5e25686426959fb9b79224","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yt-project/yt/pulls/1807/commits","review_comments_url":"https://api.github.com/repos/yt-project/yt/pulls/1807/comments","review_comment_url":"https://api.github.com/repos/yt-project/yt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yt-project/yt/issues/1807/comments","statuses_url":"https://api.github.com/repos/yt-project/yt/statuses/3db048c6f32e7f5b5c05d6e3c6a01058f24765e3","head":{"label":"jzuhone:arepo","ref":"arepo","sha":"3db048c6f32e7f5b5c05d6e3c6a01058f24765e3","user":{"login":"jzuhone","id":1914976,"node_id":"MDQ6VXNlcjE5MTQ5NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1914976?v=4","gravatar_id":"","url":"https://api.github.com/users/jzuhone","html_url":"https://github.com/jzuhone","followers_url":"https://api.github.com/users/jzuhone/followers","following_url":"https://api.github.com/users/jzuhone/following{/other_user}","gists_url":"https://api.github.com/users/jzuhone/gists{/gist_id}","starred_url":"https://api.github.com/users/jzuhone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzuhone/subscriptions","organizations_url":"https://api.github.com/users/jzuhone/orgs","repos_url":"https://api.github.com/users/jzuhone/repos","events_url":"https://api.github.com/users/jzuhone/events{/privacy}","received_events_url":"https://api.github.com/users/jzuhone/received_events","type":"User","site_admin":false},"repo":{"id":89941829,"node_id":"MDEwOlJlcG9zaXRvcnk4OTk0MTgyOQ==","name":"yt","full_name":"jzuhone/yt","owner":{"login":"jzuhone","id":1914976,"node_id":"MDQ6VXNlcjE5MTQ5NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1914976?v=4","gravatar_id":"","url":"https://api.github.com/users/jzuhone","html_url":"https://github.com/jzuhone","followers_url":"https://api.github.com/users/jzuhone/followers","following_url":"https://api.github.com/users/jzuhone/following{/other_user}","gists_url":"https://api.github.com/users/jzuhone/gists{/gist_id}","starred_url":"https://api.github.com/users/jzuhone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzuhone/subscriptions","organizations_url":"https://api.github.com/users/jzuhone/orgs","repos_url":"https://api.github.com/users/jzuhone/repos","events_url":"https://api.github.com/users/jzuhone/events{/privacy}","received_events_url":"https://api.github.com/users/jzuhone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jzuhone/yt","description":"Main yt repository","fork":true,"url":"https://api.github.com/repos/jzuhone/yt","forks_url":"https://api.github.com/repos/jzuhone/yt/forks","keys_url":"https://api.github.com/repos/jzuhone/yt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jzuhone/yt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jzuhone/yt/teams","hooks_url":"https://api.github.com/repos/jzuhone/yt/hooks","issue_events_url":"https://api.github.com/repos/jzuhone/yt/issues/events{/number}","events_url":"https://api.github.com/repos/jzuhone/yt/events","assignees_url":"https://api.github.com/repos/jzuhone/yt/assignees{/user}","branches_url":"https://api.github.com/repos/jzuhone/yt/branches{/branch}","tags_url":"https://api.github.com/repos/jzuhone/yt/tags","blobs_url":"https://api.github.com/repos/jzuhone/yt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jzuhone/yt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jzuhone/yt/git/refs{/sha}","trees_url":"https://api.github.com/repos/jzuhone/yt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jzuhone/yt/statuses/{sha}","languages_url":"https://api.github.com/repos/jzuhone/yt/languages","stargazers_url":"https://api.github.com/repos/jzuhone/yt/stargazers","contributors_url":"https://api.github.com/repos/jzuhone/yt/contributors","subscribers_url":"https://api.github.com/repos/jzuhone/yt/subscribers","subscription_url":"https://api.github.com/repos/jzuhone/yt/subscription","commits_url":"https://api.github.com/repos/jzuhone/yt/commits{/sha}","git_commits_url":"https://api.github.com/repos/jzuhone/yt/git/commits{/sha}","comments_url":"https://api.github.com/repos/jzuhone/yt/comments{/number}","issue_comment_url":"https://api.github.com/repos/jzuhone/yt/issues/comments{/number}","contents_url":"https://api.github.com/repos/jzuhone/yt/contents/{+path}","compare_url":"https://api.github.com/repos/jzuhone/yt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jzuhone/yt/merges","archive_url":"https://api.github.com/repos/jzuhone/yt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jzuhone/yt/downloads","issues_url":"https://api.github.com/repos/jzuhone/yt/issues{/number}","pulls_url":"https://api.github.com/repos/jzuhone/yt/pulls{/number}","milestones_url":"https://api.github.com/repos/jzuhone/yt/milestones{/number}","notifications_url":"https://api.github.com/repos/jzuhone/yt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jzuhone/yt/labels{/name}","releases_url":"https://api.github.com/repos/jzuhone/yt/releases{/id}","deployments_url":"https://api.github.com/repos/jzuhone/yt/deployments","created_at":"2017-05-01T16:39:31Z","updated_at":"2018-08-30T14:55:59Z","pushed_at":"2018-08-30T18:04:02Z","git_url":"git://github.com/jzuhone/yt.git","ssh_url":"git@github.com:jzuhone/yt.git","clone_url":"https://github.com/jzuhone/yt.git","svn_url":"https://github.com/jzuhone/yt","homepage":"http://yt-project.org","size":314882,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"yt-project:yt-4.0","ref":"yt-4.0","sha":"ebf402f6efa80d9154e5888c8cee0cd38f9c0e6a","user":{"login":"yt-project","id":20566579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTY2NTc5","avatar_url":"https://avatars0.githubusercontent.com/u/20566579?v=4","gravatar_id":"","url":"https://api.github.com/users/yt-project","html_url":"https://github.com/yt-project","followers_url":"https://api.github.com/users/yt-project/followers","following_url":"https://api.github.com/users/yt-project/following{/other_user}","gists_url":"https://api.github.com/users/yt-project/gists{/gist_id}","starred_url":"https://api.github.com/users/yt-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yt-project/subscriptions","organizations_url":"https://api.github.com/users/yt-project/orgs","repos_url":"https://api.github.com/users/yt-project/repos","events_url":"https://api.github.com/users/yt-project/events{/privacy}","received_events_url":"https://api.github.com/users/yt-project/received_events","type":"Organization","site_admin":false},"repo":{"id":88776493,"node_id":"MDEwOlJlcG9zaXRvcnk4ODc3NjQ5Mw==","name":"yt","full_name":"yt-project/yt","owner":{"login":"yt-project","id":20566579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTY2NTc5","avatar_url":"https://avatars0.githubusercontent.com/u/20566579?v=4","gravatar_id":"","url":"https://api.github.com/users/yt-project","html_url":"https://github.com/yt-project","followers_url":"https://api.github.com/users/yt-project/followers","following_url":"https://api.github.com/users/yt-project/following{/other_user}","gists_url":"https://api.github.com/users/yt-project/gists{/gist_id}","starred_url":"https://api.github.com/users/yt-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yt-project/subscriptions","organizations_url":"https://api.github.com/users/yt-project/orgs","repos_url":"https://api.github.com/users/yt-project/repos","events_url":"https://api.github.com/users/yt-project/events{/privacy}","received_events_url":"https://api.github.com/users/yt-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yt-project/yt","description":"Main yt repository","fork":false,"url":"https://api.github.com/repos/yt-project/yt","forks_url":"https://api.github.com/repos/yt-project/yt/forks","keys_url":"https://api.github.com/repos/yt-project/yt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yt-project/yt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yt-project/yt/teams","hooks_url":"https://api.github.com/repos/yt-project/yt/hooks","issue_events_url":"https://api.github.com/repos/yt-project/yt/issues/events{/number}","events_url":"https://api.github.com/repos/yt-project/yt/events","assignees_url":"https://api.github.com/repos/yt-project/yt/assignees{/user}","branches_url":"https://api.github.com/repos/yt-project/yt/branches{/branch}","tags_url":"https://api.github.com/repos/yt-project/yt/tags","blobs_url":"https://api.github.com/repos/yt-project/yt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yt-project/yt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yt-project/yt/git/refs{/sha}","trees_url":"https://api.github.com/repos/yt-project/yt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yt-project/yt/statuses/{sha}","languages_url":"https://api.github.com/repos/yt-project/yt/languages","stargazers_url":"https://api.github.com/repos/yt-project/yt/stargazers","contributors_url":"https://api.github.com/repos/yt-project/yt/contributors","subscribers_url":"https://api.github.com/repos/yt-project/yt/subscribers","subscription_url":"https://api.github.com/repos/yt-project/yt/subscription","commits_url":"https://api.github.com/repos/yt-project/yt/commits{/sha}","git_commits_url":"https://api.github.com/repos/yt-project/yt/git/commits{/sha}","comments_url":"https://api.github.com/repos/yt-project/yt/comments{/number}","issue_comment_url":"https://api.github.com/repos/yt-project/yt/issues/comments{/number}","contents_url":"https://api.github.com/repos/yt-project/yt/contents/{+path}","compare_url":"https://api.github.com/repos/yt-project/yt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yt-project/yt/merges","archive_url":"https://api.github.com/repos/yt-project/yt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yt-project/yt/downloads","issues_url":"https://api.github.com/repos/yt-project/yt/issues{/number}","pulls_url":"https://api.github.com/repos/yt-project/yt/pulls{/number}","milestones_url":"https://api.github.com/repos/yt-project/yt/milestones{/number}","notifications_url":"https://api.github.com/repos/yt-project/yt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yt-project/yt/labels{/name}","releases_url":"https://api.github.com/repos/yt-project/yt/releases{/id}","deployments_url":"https://api.github.com/repos/yt-project/yt/deployments","created_at":"2017-04-19T18:16:11Z","updated_at":"2018-09-06T14:18:14Z","pushed_at":"2018-09-08T20:58:04Z","git_url":"git://github.com/yt-project/yt.git","ssh_url":"git@github.com:yt-project/yt.git","clone_url":"https://github.com/yt-project/yt.git","svn_url":"https://github.com/yt-project/yt","homepage":"http://yt-project.org","size":314397,"stargazers_count":127,"watchers_count":127,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"archived":false,"open_issues_count":192,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":104,"open_issues":192,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1807"},"html":{"href":"https://github.com/yt-project/yt/pull/1807"},"issue":{"href":"https://api.github.com/repos/yt-project/yt/issues/1807"},"comments":{"href":"https://api.github.com/repos/yt-project/yt/issues/1807/comments"},"review_comments":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1807/comments"},"review_comment":{"href":"https://api.github.com/repos/yt-project/yt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yt-project/yt/pulls/1807/commits"},"statuses":{"href":"https://api.github.com/repos/yt-project/yt/statuses/3db048c6f32e7f5b5c05d6e3c6a01058f24765e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jzuhone"}}