{"action":"created","issue":{"url":"https://api.github.com/repos/ove/ove-apps/issues/39","repository_url":"https://api.github.com/repos/ove/ove-apps","labels_url":"https://api.github.com/repos/ove/ove-apps/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/ove/ove-apps/issues/39/comments","events_url":"https://api.github.com/repos/ove/ove-apps/issues/39/events","html_url":"https://github.com/ove/ove-apps/pull/39","id":381879531,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzM3OTQ1","number":39,"title":"Operations for networks app such as search, color and labelNodes","user":{"login":"senakafdo","id":3415383,"node_id":"MDQ6VXNlcjM0MTUzODM=","avatar_url":"https://avatars3.githubusercontent.com/u/3415383?v=4","gravatar_id":"","url":"https://api.github.com/users/senakafdo","html_url":"https://github.com/senakafdo","followers_url":"https://api.github.com/users/senakafdo/followers","following_url":"https://api.github.com/users/senakafdo/following{/other_user}","gists_url":"https://api.github.com/users/senakafdo/gists{/gist_id}","starred_url":"https://api.github.com/users/senakafdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senakafdo/subscriptions","organizations_url":"https://api.github.com/users/senakafdo/orgs","repos_url":"https://api.github.com/users/senakafdo/repos","events_url":"https://api.github.com/users/senakafdo/events{/privacy}","received_events_url":"https://api.github.com/users/senakafdo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-17T16:48:09Z","updated_at":"2018-11-19T19:21:10Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ove/ove-apps/pulls/39","html_url":"https://github.com/ove/ove-apps/pull/39","diff_url":"https://github.com/ove/ove-apps/pull/39.diff","patch_url":"https://github.com/ove/ove-apps/pull/39.patch"},"body":"This functionality is required for making it possible to search within network diagrams using Sigma.js."},"comment":{"url":"https://api.github.com/repos/ove/ove-apps/issues/comments/440010771","html_url":"https://github.com/ove/ove-apps/pull/39#issuecomment-440010771","issue_url":"https://api.github.com/repos/ove/ove-apps/issues/39","id":440010771,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDAxMDc3MQ==","user":{"login":"senakafdo","id":3415383,"node_id":"MDQ6VXNlcjM0MTUzODM=","avatar_url":"https://avatars3.githubusercontent.com/u/3415383?v=4","gravatar_id":"","url":"https://api.github.com/users/senakafdo","html_url":"https://github.com/senakafdo","followers_url":"https://api.github.com/users/senakafdo/followers","following_url":"https://api.github.com/users/senakafdo/following{/other_user}","gists_url":"https://api.github.com/users/senakafdo/gists{/gist_id}","starred_url":"https://api.github.com/users/senakafdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senakafdo/subscriptions","organizations_url":"https://api.github.com/users/senakafdo/orgs","repos_url":"https://api.github.com/users/senakafdo/repos","events_url":"https://api.github.com/users/senakafdo/events{/privacy}","received_events_url":"https://api.github.com/users/senakafdo/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T19:21:10Z","updated_at":"2018-11-19T19:21:10Z","author_association":"MEMBER","body":"> @davidbirchwork, queries are never a part of the state of anything that we have implemented in any framework so far, I don't see the reason for making an exception here. It complicates the logic and may require introducing unwanted timeouts etc, because there is absolutely no way where our JS code can figure out whether Sigma has loaded the graphs or not.\r\n\r\n@jamesscottbrown and I did some research on this, and it seems that Sigma parsers do provide a callback function, which we infact are using in our code to refresh/load the graph once parsing is complete. We can run our queries at this point, without having to put in place any timeouts. Given that there are no animations etc, we do not need to ensure we have loaded the graphs across all the screens at the point we run the queries - which makes the implementation straightforward."}}
{"actor":{"display_login":"senakafdo"}}