{"action":"created","issue":{"url":"https://api.github.com/repos/linkedin/ambry/issues/961","repository_url":"https://api.github.com/repos/linkedin/ambry","labels_url":"https://api.github.com/repos/linkedin/ambry/issues/961/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/961/comments","events_url":"https://api.github.com/repos/linkedin/ambry/issues/961/events","html_url":"https://github.com/linkedin/ambry/pull/961","id":333784058,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTE1MjUy","number":961,"title":"Do storeKey convertion for keys in GET/DELETE requests","user":{"login":"zzmao","id":34247652,"node_id":"MDQ6VXNlcjM0MjQ3NjUy","avatar_url":"https://avatars3.githubusercontent.com/u/34247652?v=4","gravatar_id":"","url":"https://api.github.com/users/zzmao","html_url":"https://github.com/zzmao","followers_url":"https://api.github.com/users/zzmao/followers","following_url":"https://api.github.com/users/zzmao/following{/other_user}","gists_url":"https://api.github.com/users/zzmao/gists{/gist_id}","starred_url":"https://api.github.com/users/zzmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzmao/subscriptions","organizations_url":"https://api.github.com/users/zzmao/orgs","repos_url":"https://api.github.com/users/zzmao/repos","events_url":"https://api.github.com/users/zzmao/events{/privacy}","received_events_url":"https://api.github.com/users/zzmao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-19T18:17:26Z","updated_at":"2018-06-19T18:33:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/961","html_url":"https://github.com/linkedin/ambry/pull/961","diff_url":"https://github.com/linkedin/ambry/pull/961.diff","patch_url":"https://github.com/linkedin/ambry/pull/961.patch"},"body":"@dharju Looks like we don't need a mock `StoreKeyConverterFactory` for test. `StoreKeyConverterImplNoOp` with existing tests can cover the new added method `getConvertedStoreKeys`. "},"comment":{"url":"https://api.github.com/repos/linkedin/ambry/issues/comments/398500679","html_url":"https://github.com/linkedin/ambry/pull/961#issuecomment-398500679","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/961","id":398500679,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODUwMDY3OQ==","user":{"login":"zzmao","id":34247652,"node_id":"MDQ6VXNlcjM0MjQ3NjUy","avatar_url":"https://avatars3.githubusercontent.com/u/34247652?v=4","gravatar_id":"","url":"https://api.github.com/users/zzmao","html_url":"https://github.com/zzmao","followers_url":"https://api.github.com/users/zzmao/followers","following_url":"https://api.github.com/users/zzmao/following{/other_user}","gists_url":"https://api.github.com/users/zzmao/gists{/gist_id}","starred_url":"https://api.github.com/users/zzmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzmao/subscriptions","organizations_url":"https://api.github.com/users/zzmao/orgs","repos_url":"https://api.github.com/users/zzmao/repos","events_url":"https://api.github.com/users/zzmao/events{/privacy}","received_events_url":"https://api.github.com/users/zzmao/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T18:33:03Z","updated_at":"2018-06-19T18:33:03Z","author_association":"CONTRIBUTOR","body":"Nothing fail without `getConvertedStoreKeys()`. \r\n\r\n`getConvertedStoreKeys` 's convertion doesn't change any key because tests use `StoreKeyConverterImplNoOp `"}}
{"actor":{"display_login":"zzmao"}}