{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/19196","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/19196/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19196/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/19196/events","html_url":"https://github.com/nodejs/node/pull/19196","id":303035442,"number":19196,"title":"node_crypto: Use math.h definitions of isnan and isinf","user":{"login":"jer-gentoo","id":2178449,"avatar_url":"https://avatars0.githubusercontent.com/u/2178449?v=4","gravatar_id":"","url":"https://api.github.com/users/jer-gentoo","html_url":"https://github.com/jer-gentoo","followers_url":"https://api.github.com/users/jer-gentoo/followers","following_url":"https://api.github.com/users/jer-gentoo/following{/other_user}","gists_url":"https://api.github.com/users/jer-gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jer-gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jer-gentoo/subscriptions","organizations_url":"https://api.github.com/users/jer-gentoo/orgs","repos_url":"https://api.github.com/users/jer-gentoo/repos","events_url":"https://api.github.com/users/jer-gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/jer-gentoo/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":155267357,"url":"https://api.github.com/repos/nodejs/node/labels/crypto","name":"crypto","color":"009800","default":false},{"id":582285981,"url":"https://api.github.com/repos/nodejs/node/labels/v8.x","name":"v8.x","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-07T10:04:56Z","updated_at":"2018-03-07T10:07:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19196","html_url":"https://github.com/nodejs/node/pull/19196","diff_url":"https://github.com/nodejs/node/pull/19196.diff","patch_url":"https://github.com/nodejs/node/pull/19196.patch"},"body":"Unless you specify C++11, std::isnan and std::isinf are not guaranteed to be available. Instead, just use the math.h functions for now.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/371088621","html_url":"https://github.com/nodejs/node/pull/19196#issuecomment-371088621","issue_url":"https://api.github.com/repos/nodejs/node/issues/19196","id":371088621,"user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T10:07:11Z","updated_at":"2018-03-07T10:07:11Z","author_association":"OWNER","body":"> Unless you specify C++11\r\n\r\nI’m not sure I understand … building Node.js does require C++11 or above, so that’s something we shouldn’t have to worry about, right?"}}
{"actor":{"display_login":"addaleax"}}