{"action":"created","issue":{"url":"https://api.github.com/repos/knative/serving/issues/1830","repository_url":"https://api.github.com/repos/knative/serving","labels_url":"https://api.github.com/repos/knative/serving/issues/1830/labels{/name}","comments_url":"https://api.github.com/repos/knative/serving/issues/1830/comments","events_url":"https://api.github.com/repos/knative/serving/issues/1830/events","html_url":"https://github.com/knative/serving/pull/1830","id":349269840,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDI3Mzcx","number":1830,"title":"[WIP] Rework pkg/autoscaler in terms of KPA.","user":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"labels":[{"id":873831452,"node_id":"MDU6TGFiZWw4NzM4MzE0NTI=","url":"https://api.github.com/repos/knative/serving/labels/approved","name":"approved","color":"ededed","default":false},{"id":862161916,"node_id":"MDU6TGFiZWw4NjIxNjE5MTY=","url":"https://api.github.com/repos/knative/serving/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"b60205","default":false},{"id":862145007,"node_id":"MDU6TGFiZWw4NjIxNDUwMDc=","url":"https://api.github.com/repos/knative/serving/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"josephburnett","id":1103629,"node_id":"MDQ6VXNlcjExMDM2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1103629?v=4","gravatar_id":"","url":"https://api.github.com/users/josephburnett","html_url":"https://github.com/josephburnett","followers_url":"https://api.github.com/users/josephburnett/followers","following_url":"https://api.github.com/users/josephburnett/following{/other_user}","gists_url":"https://api.github.com/users/josephburnett/gists{/gist_id}","starred_url":"https://api.github.com/users/josephburnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephburnett/subscriptions","organizations_url":"https://api.github.com/users/josephburnett/orgs","repos_url":"https://api.github.com/users/josephburnett/repos","events_url":"https://api.github.com/users/josephburnett/events{/privacy}","received_events_url":"https://api.github.com/users/josephburnett/received_events","type":"User","site_admin":false},"assignees":[{"login":"josephburnett","id":1103629,"node_id":"MDQ6VXNlcjExMDM2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1103629?v=4","gravatar_id":"","url":"https://api.github.com/users/josephburnett","html_url":"https://github.com/josephburnett","followers_url":"https://api.github.com/users/josephburnett/followers","following_url":"https://api.github.com/users/josephburnett/following{/other_user}","gists_url":"https://api.github.com/users/josephburnett/gists{/gist_id}","starred_url":"https://api.github.com/users/josephburnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephburnett/subscriptions","organizations_url":"https://api.github.com/users/josephburnett/orgs","repos_url":"https://api.github.com/users/josephburnett/repos","events_url":"https://api.github.com/users/josephburnett/events{/privacy}","received_events_url":"https://api.github.com/users/josephburnett/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-08-09T20:02:29Z","updated_at":"2018-08-10T19:36:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/1830","html_url":"https://github.com/knative/serving/pull/1830","diff_url":"https://github.com/knative/serving/pull/1830.diff","patch_url":"https://github.com/knative/serving/pull/1830.patch"},"body":"This mostly reworks pkg/autoscaler to operate in terms of the KPA instead of Revisions.  This is essentially the third phase outlined in #1655, but this doesn't add logic to update the KPA status because it would be too awkward with the current interface with the RevisionSynchronizer (now KPASynchronizer).  This change is big enough so call it `3a.`, I will think on the best way to achieve `3b.` as a follow up.\r\n\r\nProgress towards: #1655\r\n\r\nWIP until https://github.com/knative/serving/pull/1826 lands (broken up by commits)."},"comment":{"url":"https://api.github.com/repos/knative/serving/issues/comments/412184176","html_url":"https://github.com/knative/serving/pull/1830#issuecomment-412184176","issue_url":"https://api.github.com/repos/knative/serving/issues/1830","id":412184176,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjE4NDE3Ng==","user":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T19:36:29Z","updated_at":"2018-08-10T19:36:29Z","author_association":"NONE","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/knative/serving/pull/1830#\" title=\"Author self-approved\">mattmoor</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[cmd/autoscaler/OWNERS](https://github.com/knative/serving/blob/master/cmd/autoscaler/OWNERS)~~ [mattmoor]\n- ~~[cmd/multitenant-autoscaler/OWNERS](https://github.com/knative/serving/blob/master/cmd/multitenant-autoscaler/OWNERS)~~ [mattmoor]\n- ~~[cmd/queue/OWNERS](https://github.com/knative/serving/blob/master/cmd/queue/OWNERS)~~ [mattmoor]\n- ~~[pkg/autoscaler/OWNERS](https://github.com/knative/serving/blob/master/pkg/autoscaler/OWNERS)~~ [mattmoor]\n- ~~[pkg/logging/OWNERS](https://github.com/knative/serving/blob/master/pkg/logging/OWNERS)~~ [mattmoor]\n- ~~[pkg/reconciler/OWNERS](https://github.com/knative/serving/blob/master/pkg/reconciler/OWNERS)~~ [mattmoor]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"knative-prow-robot"}}