{"action":"created","issue":{"url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/164","repository_url":"https://api.github.com/repos/fluent/fluentd-docker-image","labels_url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/164/labels{/name}","comments_url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/164/comments","events_url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/164/events","html_url":"https://github.com/fluent/fluentd-docker-image/pull/164","id":393505844,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTEwOTA3","number":164,"title":"Remove gosu/su-exec from entrypoint.sh","user":{"login":"stevenjm","id":9746410,"node_id":"MDQ6VXNlcjk3NDY0MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9746410?v=4","gravatar_id":"","url":"https://api.github.com/users/stevenjm","html_url":"https://github.com/stevenjm","followers_url":"https://api.github.com/users/stevenjm/followers","following_url":"https://api.github.com/users/stevenjm/following{/other_user}","gists_url":"https://api.github.com/users/stevenjm/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenjm/subscriptions","organizations_url":"https://api.github.com/users/stevenjm/orgs","repos_url":"https://api.github.com/users/stevenjm/repos","events_url":"https://api.github.com/users/stevenjm/events{/privacy}","received_events_url":"https://api.github.com/users/stevenjm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-21T15:53:47Z","updated_at":"2018-12-25T11:01:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/fluent/fluentd-docker-image/pulls/164","html_url":"https://github.com/fluent/fluentd-docker-image/pull/164","diff_url":"https://github.com/fluent/fluentd-docker-image/pull/164.diff","patch_url":"https://github.com/fluent/fluentd-docker-image/pull/164.patch"},"body":"34ed7d5697edf8cfcd1af518c5764fceb3073bff removed the `FLUENT_UID` environment variable to configure the fluent user, but did not allow the container image to run as an arbitrary uid as the comment linked from the commit message suggests. This leaves the administrator with no way of configuring the identity of the user the container runs as, which is necessary if mounting host volumes into the container with restricted permissions.\r\n\r\nHappily, `entrypoint.sh` no longer does anything that requires root access, so by simply removing `gosu`/`su-exec`, using the `-u` option with `docker run` just works. This also adds a `USER` instruction so that the default configuration with no `-u` option still works correctly.\r\n\r\nNote that with this change, `entrypoint.sh.erb` no longer actually contains any templating. This could be renamed to `entrypoint.sh` and just symlinked to where it is used, but I'm not doing that here to keep the diff straightforward."},"comment":{"url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/comments/449840281","html_url":"https://github.com/fluent/fluentd-docker-image/pull/164#issuecomment-449840281","issue_url":"https://api.github.com/repos/fluent/fluentd-docker-image/issues/164","id":449840281,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTg0MDI4MQ==","user":{"login":"repeatedly","id":16928,"node_id":"MDQ6VXNlcjE2OTI4","avatar_url":"https://avatars3.githubusercontent.com/u/16928?v=4","gravatar_id":"","url":"https://api.github.com/users/repeatedly","html_url":"https://github.com/repeatedly","followers_url":"https://api.github.com/users/repeatedly/followers","following_url":"https://api.github.com/users/repeatedly/following{/other_user}","gists_url":"https://api.github.com/users/repeatedly/gists{/gist_id}","starred_url":"https://api.github.com/users/repeatedly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repeatedly/subscriptions","organizations_url":"https://api.github.com/users/repeatedly/orgs","repos_url":"https://api.github.com/users/repeatedly/repos","events_url":"https://api.github.com/users/repeatedly/events{/privacy}","received_events_url":"https://api.github.com/users/repeatedly/received_events","type":"User","site_admin":false},"created_at":"2018-12-25T11:01:27Z","updated_at":"2018-12-25T11:01:27Z","author_association":"MEMBER","body":"Does anyone have a concern for this change?"}}
{"actor":{"display_login":"repeatedly"}}