{"action":"created","issue":{"url":"https://api.github.com/repos/PikaLabs/floyd/issues/37","repository_url":"https://api.github.com/repos/PikaLabs/floyd","labels_url":"https://api.github.com/repos/PikaLabs/floyd/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/PikaLabs/floyd/issues/37/comments","events_url":"https://api.github.com/repos/PikaLabs/floyd/issues/37/events","html_url":"https://github.com/PikaLabs/floyd/issues/37","id":327041691,"number":37,"title":"int FloydImpl::ReplyRequestVote里面有bug么？","user":{"login":"peacedog123","id":32981594,"avatar_url":"https://avatars2.githubusercontent.com/u/32981594?v=4","gravatar_id":"","url":"https://api.github.com/users/peacedog123","html_url":"https://github.com/peacedog123","followers_url":"https://api.github.com/users/peacedog123/followers","following_url":"https://api.github.com/users/peacedog123/following{/other_user}","gists_url":"https://api.github.com/users/peacedog123/gists{/gist_id}","starred_url":"https://api.github.com/users/peacedog123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peacedog123/subscriptions","organizations_url":"https://api.github.com/users/peacedog123/orgs","repos_url":"https://api.github.com/users/peacedog123/repos","events_url":"https://api.github.com/users/peacedog123/events{/privacy}","received_events_url":"https://api.github.com/users/peacedog123/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-28T14:17:51Z","updated_at":"2018-05-28T16:04:42Z","closed_at":null,"author_association":"NONE","body":"注释和论文里面有写：\r\n// if votedfor is null or candidateId, and candidated's log is at least as up-to-date\r\n  // as receiver's log, grant vote\r\n\r\n但是这个rpc实现逻辑里面，好像完全没有去判断FloydContext内部的vote_for_ip和vote_for_port, 事实是如果一个follower变成candidate后，首先会把vote_for_ip和vote_for_port设置成自己；此时如果收到RequestVoteRPC请求过来，应该直接return false, 表明自己这一轮已经投过票了（投给自己）\r\n\r\n不知道我理解的对不对？谢谢"},"comment":{"url":"https://api.github.com/repos/PikaLabs/floyd/issues/comments/392562162","html_url":"https://github.com/PikaLabs/floyd/issues/37#issuecomment-392562162","issue_url":"https://api.github.com/repos/PikaLabs/floyd/issues/37","id":392562162,"user":{"login":"gaodq","id":3005100,"avatar_url":"https://avatars2.githubusercontent.com/u/3005100?v=4","gravatar_id":"","url":"https://api.github.com/users/gaodq","html_url":"https://github.com/gaodq","followers_url":"https://api.github.com/users/gaodq/followers","following_url":"https://api.github.com/users/gaodq/following{/other_user}","gists_url":"https://api.github.com/users/gaodq/gists{/gist_id}","starred_url":"https://api.github.com/users/gaodq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaodq/subscriptions","organizations_url":"https://api.github.com/users/gaodq/orgs","repos_url":"https://api.github.com/users/gaodq/repos","events_url":"https://api.github.com/users/gaodq/events{/privacy}","received_events_url":"https://api.github.com/users/gaodq/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T16:04:42Z","updated_at":"2018-05-28T16:04:42Z","author_association":"CONTRIBUTOR","body":"在这里判断了\r\nhttps://github.com/PikaLabs/floyd/blob/4113bef85e7fec2db743b7833c870574e106e239/floyd/src/floyd_impl.cc#L747-L753"}}
{"actor":{"display_login":"gaodq"}}