{"action":"created","comment":{"url":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/comments/244879446","pull_request_review_id":188859978,"id":244879446,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDg3OTQ0Ng==","diff_hunk":"@@ -26,6 +26,8 @@ pub struct CodegenConfig {\n     pub shrink_level: u32,\n     /// 0, 1, 2 correspond to -O0, -O1, -O2, etc.\n     pub optimization_level: u32,\n+    /// If set, the namess section is emitted.\n+    pub debug_info: bool,","path":"src/lib.rs","position":5,"original_position":5,"commit_id":"3c8ed4fbc26b805459615da6a20bfa16900980b4","original_commit_id":"80a31dea9d1e9b877d698135ec2997ba27aa2a1a","user":{"login":"pepyakin","id":2205845,"node_id":"MDQ6VXNlcjIyMDU4NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2205845?v=4","gravatar_id":"","url":"https://api.github.com/users/pepyakin","html_url":"https://github.com/pepyakin","followers_url":"https://api.github.com/users/pepyakin/followers","following_url":"https://api.github.com/users/pepyakin/following{/other_user}","gists_url":"https://api.github.com/users/pepyakin/gists{/gist_id}","starred_url":"https://api.github.com/users/pepyakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepyakin/subscriptions","organizations_url":"https://api.github.com/users/pepyakin/orgs","repos_url":"https://api.github.com/users/pepyakin/repos","events_url":"https://api.github.com/users/pepyakin/events{/privacy}","received_events_url":"https://api.github.com/users/pepyakin/received_events","type":"User","site_admin":false},"body":"I think that doesn't matter too much. We can't really try to guess binaryen evolution too much. But If we can do a good guess, then it might make more sense to choose the most probable option.","created_at":"2019-01-02T22:58:25Z","updated_at":"2019-01-02T22:58:25Z","html_url":"https://github.com/pepyakin/binaryen-rs/pull/17#discussion_r244879446","pull_request_url":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/17","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/comments/244879446"},"html":{"href":"https://github.com/pepyakin/binaryen-rs/pull/17#discussion_r244879446"},"pull_request":{"href":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/17"}},"in_reply_to_id":244874442},"pull_request":{"url":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/17","id":241864751,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxODY0NzUx","html_url":"https://github.com/pepyakin/binaryen-rs/pull/17","diff_url":"https://github.com/pepyakin/binaryen-rs/pull/17.diff","patch_url":"https://github.com/pepyakin/binaryen-rs/pull/17.patch","issue_url":"https://api.github.com/repos/pepyakin/binaryen-rs/issues/17","number":17,"state":"open","locked":false,"title":"Add support for CodegenConfig::debug_info","user":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-01-02T22:31:17Z","updated_at":"2019-01-02T22:58:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ea018bf1a49cc28024b3b26fce11001927d4422","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/17/commits","review_comments_url":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/17/comments","review_comment_url":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pepyakin/binaryen-rs/issues/17/comments","statuses_url":"https://api.github.com/repos/pepyakin/binaryen-rs/statuses/3c8ed4fbc26b805459615da6a20bfa16900980b4","head":{"label":"axic:debug-info","ref":"debug-info","sha":"3c8ed4fbc26b805459615da6a20bfa16900980b4","user":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"repo":{"id":163889114,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM4ODkxMTQ=","name":"binaryen-rs","full_name":"axic/binaryen-rs","private":false,"owner":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/axic/binaryen-rs","description":"Binaryen bindings for Rust.","fork":true,"url":"https://api.github.com/repos/axic/binaryen-rs","forks_url":"https://api.github.com/repos/axic/binaryen-rs/forks","keys_url":"https://api.github.com/repos/axic/binaryen-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axic/binaryen-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axic/binaryen-rs/teams","hooks_url":"https://api.github.com/repos/axic/binaryen-rs/hooks","issue_events_url":"https://api.github.com/repos/axic/binaryen-rs/issues/events{/number}","events_url":"https://api.github.com/repos/axic/binaryen-rs/events","assignees_url":"https://api.github.com/repos/axic/binaryen-rs/assignees{/user}","branches_url":"https://api.github.com/repos/axic/binaryen-rs/branches{/branch}","tags_url":"https://api.github.com/repos/axic/binaryen-rs/tags","blobs_url":"https://api.github.com/repos/axic/binaryen-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axic/binaryen-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axic/binaryen-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/axic/binaryen-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axic/binaryen-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/axic/binaryen-rs/languages","stargazers_url":"https://api.github.com/repos/axic/binaryen-rs/stargazers","contributors_url":"https://api.github.com/repos/axic/binaryen-rs/contributors","subscribers_url":"https://api.github.com/repos/axic/binaryen-rs/subscribers","subscription_url":"https://api.github.com/repos/axic/binaryen-rs/subscription","commits_url":"https://api.github.com/repos/axic/binaryen-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/axic/binaryen-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/axic/binaryen-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/axic/binaryen-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/axic/binaryen-rs/contents/{+path}","compare_url":"https://api.github.com/repos/axic/binaryen-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axic/binaryen-rs/merges","archive_url":"https://api.github.com/repos/axic/binaryen-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axic/binaryen-rs/downloads","issues_url":"https://api.github.com/repos/axic/binaryen-rs/issues{/number}","pulls_url":"https://api.github.com/repos/axic/binaryen-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/axic/binaryen-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/axic/binaryen-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axic/binaryen-rs/labels{/name}","releases_url":"https://api.github.com/repos/axic/binaryen-rs/releases{/id}","deployments_url":"https://api.github.com/repos/axic/binaryen-rs/deployments","created_at":"2019-01-02T21:01:42Z","updated_at":"2019-01-02T21:01:45Z","pushed_at":"2019-01-02T22:32:25Z","git_url":"git://github.com/axic/binaryen-rs.git","ssh_url":"git@github.com:axic/binaryen-rs.git","clone_url":"https://github.com/axic/binaryen-rs.git","svn_url":"https://github.com/axic/binaryen-rs","homepage":"","size":98,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pepyakin:master","ref":"master","sha":"7a3b8fd92ef01ef18fdc080e859fabe388da5298","user":{"login":"pepyakin","id":2205845,"node_id":"MDQ6VXNlcjIyMDU4NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2205845?v=4","gravatar_id":"","url":"https://api.github.com/users/pepyakin","html_url":"https://github.com/pepyakin","followers_url":"https://api.github.com/users/pepyakin/followers","following_url":"https://api.github.com/users/pepyakin/following{/other_user}","gists_url":"https://api.github.com/users/pepyakin/gists{/gist_id}","starred_url":"https://api.github.com/users/pepyakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepyakin/subscriptions","organizations_url":"https://api.github.com/users/pepyakin/orgs","repos_url":"https://api.github.com/users/pepyakin/repos","events_url":"https://api.github.com/users/pepyakin/events{/privacy}","received_events_url":"https://api.github.com/users/pepyakin/received_events","type":"User","site_admin":false},"repo":{"id":98925020,"node_id":"MDEwOlJlcG9zaXRvcnk5ODkyNTAyMA==","name":"binaryen-rs","full_name":"pepyakin/binaryen-rs","private":false,"owner":{"login":"pepyakin","id":2205845,"node_id":"MDQ6VXNlcjIyMDU4NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2205845?v=4","gravatar_id":"","url":"https://api.github.com/users/pepyakin","html_url":"https://github.com/pepyakin","followers_url":"https://api.github.com/users/pepyakin/followers","following_url":"https://api.github.com/users/pepyakin/following{/other_user}","gists_url":"https://api.github.com/users/pepyakin/gists{/gist_id}","starred_url":"https://api.github.com/users/pepyakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepyakin/subscriptions","organizations_url":"https://api.github.com/users/pepyakin/orgs","repos_url":"https://api.github.com/users/pepyakin/repos","events_url":"https://api.github.com/users/pepyakin/events{/privacy}","received_events_url":"https://api.github.com/users/pepyakin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pepyakin/binaryen-rs","description":"Binaryen bindings for Rust.","fork":false,"url":"https://api.github.com/repos/pepyakin/binaryen-rs","forks_url":"https://api.github.com/repos/pepyakin/binaryen-rs/forks","keys_url":"https://api.github.com/repos/pepyakin/binaryen-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pepyakin/binaryen-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pepyakin/binaryen-rs/teams","hooks_url":"https://api.github.com/repos/pepyakin/binaryen-rs/hooks","issue_events_url":"https://api.github.com/repos/pepyakin/binaryen-rs/issues/events{/number}","events_url":"https://api.github.com/repos/pepyakin/binaryen-rs/events","assignees_url":"https://api.github.com/repos/pepyakin/binaryen-rs/assignees{/user}","branches_url":"https://api.github.com/repos/pepyakin/binaryen-rs/branches{/branch}","tags_url":"https://api.github.com/repos/pepyakin/binaryen-rs/tags","blobs_url":"https://api.github.com/repos/pepyakin/binaryen-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pepyakin/binaryen-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pepyakin/binaryen-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pepyakin/binaryen-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pepyakin/binaryen-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/pepyakin/binaryen-rs/languages","stargazers_url":"https://api.github.com/repos/pepyakin/binaryen-rs/stargazers","contributors_url":"https://api.github.com/repos/pepyakin/binaryen-rs/contributors","subscribers_url":"https://api.github.com/repos/pepyakin/binaryen-rs/subscribers","subscription_url":"https://api.github.com/repos/pepyakin/binaryen-rs/subscription","commits_url":"https://api.github.com/repos/pepyakin/binaryen-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pepyakin/binaryen-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pepyakin/binaryen-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pepyakin/binaryen-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pepyakin/binaryen-rs/contents/{+path}","compare_url":"https://api.github.com/repos/pepyakin/binaryen-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pepyakin/binaryen-rs/merges","archive_url":"https://api.github.com/repos/pepyakin/binaryen-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pepyakin/binaryen-rs/downloads","issues_url":"https://api.github.com/repos/pepyakin/binaryen-rs/issues{/number}","pulls_url":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/pepyakin/binaryen-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/pepyakin/binaryen-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pepyakin/binaryen-rs/labels{/name}","releases_url":"https://api.github.com/repos/pepyakin/binaryen-rs/releases{/id}","deployments_url":"https://api.github.com/repos/pepyakin/binaryen-rs/deployments","created_at":"2017-07-31T20:01:44Z","updated_at":"2019-01-02T22:48:32Z","pushed_at":"2019-01-02T22:48:30Z","git_url":"git://github.com/pepyakin/binaryen-rs.git","ssh_url":"git@github.com:pepyakin/binaryen-rs.git","clone_url":"https://github.com/pepyakin/binaryen-rs.git","svn_url":"https://github.com/pepyakin/binaryen-rs","homepage":"","size":96,"stargazers_count":26,"watchers_count":26,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":2,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/17"},"html":{"href":"https://github.com/pepyakin/binaryen-rs/pull/17"},"issue":{"href":"https://api.github.com/repos/pepyakin/binaryen-rs/issues/17"},"comments":{"href":"https://api.github.com/repos/pepyakin/binaryen-rs/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pepyakin/binaryen-rs/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/pepyakin/binaryen-rs/statuses/3c8ed4fbc26b805459615da6a20bfa16900980b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pepyakin"}}