{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/cortex/issues/723","repository_url":"https://api.github.com/repos/weaveworks/cortex","labels_url":"https://api.github.com/repos/weaveworks/cortex/issues/723/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/cortex/issues/723/comments","events_url":"https://api.github.com/repos/weaveworks/cortex/issues/723/events","html_url":"https://github.com/weaveworks/cortex/issues/723","id":300305914,"number":723,"title":"Ruler group execution can overlap with itself after rules update","user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars2.githubusercontent.com/u/8125524?v=4","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-26T16:30:11Z","updated_at":"2018-02-26T17:47:34Z","closed_at":null,"author_association":"OWNER","body":"When a rules update arrives, `scheduler.addNewConfigs()` calls `addWorkItem(now)`, and the ruler scheduler de-dupes items added to the queue on the basis of their userD.\r\n\r\nBut, the item is not in the queue while it is being executed.  Thus we can get something like this:\r\n\r\n![overlapping ruler group execution](https://user-images.githubusercontent.com/8125524/36681918-cdce606a-1b11-11e8-95c6-8967b8c8969b.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/weaveworks/cortex/issues/comments/368587218","html_url":"https://github.com/weaveworks/cortex/issues/723#issuecomment-368587218","issue_url":"https://api.github.com/repos/weaveworks/cortex/issues/723","id":368587218,"user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars2.githubusercontent.com/u/8125524?v=4","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T17:47:34Z","updated_at":"2018-02-26T17:47:34Z","author_association":"OWNER","body":"@leth I think you're right, in most cases, since the next execution point will be somewhere in the future and the re-add in `workItemDone` will then de-dupe against it.\r\n\r\nOne exception would be when the group takes so long to execute that it goes past the next scheduled point.  #719 would help that, but again not a complete fix."}}
{"actor":{"display_login":"bboreham"}}