{"action":"created","comment":{"url":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments/236100493","pull_request_review_id":178108467,"id":236100493,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjEwMDQ5Mw==","diff_hunk":"@@ -57,7 +57,23 @@ protected override void Run()\n         {\r\n             VM vm = Host.ControlDomainZero();\r\n \r\n-            XenAPI.VM.set_memory(Session, vm.opaque_ref, memory);\r\n+            try\r\n+            {\r\n+                XenAPI.VM.set_memory(Session, vm.opaque_ref, memory);\r\n+            }\r\n+            catch (Exception e)\r","path":"XenModel/Actions/Host/ChangeControlDomainMemoryAction.cs","position":9,"original_position":9,"commit_id":"8159ae6e54f4e2920be18297bc14bb2215d712fe","original_commit_id":"8159ae6e54f4e2920be18297bc14bb2215d712fe","user":{"login":"kc284","id":3705142,"node_id":"MDQ6VXNlcjM3MDUxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3705142?v=4","gravatar_id":"","url":"https://api.github.com/users/kc284","html_url":"https://github.com/kc284","followers_url":"https://api.github.com/users/kc284/followers","following_url":"https://api.github.com/users/kc284/following{/other_user}","gists_url":"https://api.github.com/users/kc284/gists{/gist_id}","starred_url":"https://api.github.com/users/kc284/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc284/subscriptions","organizations_url":"https://api.github.com/users/kc284/orgs","repos_url":"https://api.github.com/users/kc284/repos","events_url":"https://api.github.com/users/kc284/events{/privacy}","received_events_url":"https://api.github.com/users/kc284/received_events","type":"User","site_admin":false},"body":"`catch (Failure f)`  so we don't need the cast and null check","created_at":"2018-11-26T01:03:36Z","updated_at":"2018-11-26T01:03:36Z","html_url":"https://github.com/xenserver/xenadmin/pull/2330#discussion_r236100493","pull_request_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/2330","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments/236100493"},"html":{"href":"https://github.com/xenserver/xenadmin/pull/2330#discussion_r236100493"},"pull_request":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/2330"}}},"pull_request":{"url":"https://api.github.com/repos/xenserver/xenadmin/pulls/2330","id":233219334,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjE5MzM0","html_url":"https://github.com/xenserver/xenadmin/pull/2330","diff_url":"https://github.com/xenserver/xenadmin/pull/2330.diff","patch_url":"https://github.com/xenserver/xenadmin/pull/2330.patch","issue_url":"https://api.github.com/repos/xenserver/xenadmin/issues/2330","number":2330,"state":"open","locked":false,"title":"XOP-953: Cannot change dom0 memory via XenCenter (XC 7.5 RTM on XS 7.…","user":{"login":"AaronRobson","id":5177808,"node_id":"MDQ6VXNlcjUxNzc4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/5177808?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronRobson","html_url":"https://github.com/AaronRobson","followers_url":"https://api.github.com/users/AaronRobson/followers","following_url":"https://api.github.com/users/AaronRobson/following{/other_user}","gists_url":"https://api.github.com/users/AaronRobson/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronRobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronRobson/subscriptions","organizations_url":"https://api.github.com/users/AaronRobson/orgs","repos_url":"https://api.github.com/users/AaronRobson/repos","events_url":"https://api.github.com/users/AaronRobson/events{/privacy}","received_events_url":"https://api.github.com/users/AaronRobson/received_events","type":"User","site_admin":false},"body":"…5 RTM).\r\n\r\nAllowing the user to proceed (not set the value and min/max to 0.0GB) even if the memory static min and max is in the wrong order.\r\nAdding further detail to the error message in case an out of bounds value is sent to the API which could potentially happen due to the range widening that occurs if the min/max would invalidate the existing value.\r\n\r\nSigned-off-by: Aaron Robson <aaron.robson@citrix.com>","created_at":"2018-11-23T14:43:19Z","updated_at":"2018-11-26T01:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae921bd4f36598f77b87f5f2801fad5fa256f40f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/2330/commits","review_comments_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/2330/comments","review_comment_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xenserver/xenadmin/issues/2330/comments","statuses_url":"https://api.github.com/repos/xenserver/xenadmin/statuses/8159ae6e54f4e2920be18297bc14bb2215d712fe","head":{"label":"AaronRobson:XOP-953","ref":"XOP-953","sha":"8159ae6e54f4e2920be18297bc14bb2215d712fe","user":{"login":"AaronRobson","id":5177808,"node_id":"MDQ6VXNlcjUxNzc4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/5177808?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronRobson","html_url":"https://github.com/AaronRobson","followers_url":"https://api.github.com/users/AaronRobson/followers","following_url":"https://api.github.com/users/AaronRobson/following{/other_user}","gists_url":"https://api.github.com/users/AaronRobson/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronRobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronRobson/subscriptions","organizations_url":"https://api.github.com/users/AaronRobson/orgs","repos_url":"https://api.github.com/users/AaronRobson/repos","events_url":"https://api.github.com/users/AaronRobson/events{/privacy}","received_events_url":"https://api.github.com/users/AaronRobson/received_events","type":"User","site_admin":false},"repo":{"id":149129594,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxMjk1OTQ=","name":"xenadmin","full_name":"AaronRobson/xenadmin","private":false,"owner":{"login":"AaronRobson","id":5177808,"node_id":"MDQ6VXNlcjUxNzc4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/5177808?v=4","gravatar_id":"","url":"https://api.github.com/users/AaronRobson","html_url":"https://github.com/AaronRobson","followers_url":"https://api.github.com/users/AaronRobson/followers","following_url":"https://api.github.com/users/AaronRobson/following{/other_user}","gists_url":"https://api.github.com/users/AaronRobson/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronRobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronRobson/subscriptions","organizations_url":"https://api.github.com/users/AaronRobson/orgs","repos_url":"https://api.github.com/users/AaronRobson/repos","events_url":"https://api.github.com/users/AaronRobson/events{/privacy}","received_events_url":"https://api.github.com/users/AaronRobson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AaronRobson/xenadmin","description":"XenCenter, the Windows management console for XenServer","fork":true,"url":"https://api.github.com/repos/AaronRobson/xenadmin","forks_url":"https://api.github.com/repos/AaronRobson/xenadmin/forks","keys_url":"https://api.github.com/repos/AaronRobson/xenadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AaronRobson/xenadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AaronRobson/xenadmin/teams","hooks_url":"https://api.github.com/repos/AaronRobson/xenadmin/hooks","issue_events_url":"https://api.github.com/repos/AaronRobson/xenadmin/issues/events{/number}","events_url":"https://api.github.com/repos/AaronRobson/xenadmin/events","assignees_url":"https://api.github.com/repos/AaronRobson/xenadmin/assignees{/user}","branches_url":"https://api.github.com/repos/AaronRobson/xenadmin/branches{/branch}","tags_url":"https://api.github.com/repos/AaronRobson/xenadmin/tags","blobs_url":"https://api.github.com/repos/AaronRobson/xenadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AaronRobson/xenadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AaronRobson/xenadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/AaronRobson/xenadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AaronRobson/xenadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/AaronRobson/xenadmin/languages","stargazers_url":"https://api.github.com/repos/AaronRobson/xenadmin/stargazers","contributors_url":"https://api.github.com/repos/AaronRobson/xenadmin/contributors","subscribers_url":"https://api.github.com/repos/AaronRobson/xenadmin/subscribers","subscription_url":"https://api.github.com/repos/AaronRobson/xenadmin/subscription","commits_url":"https://api.github.com/repos/AaronRobson/xenadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/AaronRobson/xenadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/AaronRobson/xenadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/AaronRobson/xenadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/AaronRobson/xenadmin/contents/{+path}","compare_url":"https://api.github.com/repos/AaronRobson/xenadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AaronRobson/xenadmin/merges","archive_url":"https://api.github.com/repos/AaronRobson/xenadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AaronRobson/xenadmin/downloads","issues_url":"https://api.github.com/repos/AaronRobson/xenadmin/issues{/number}","pulls_url":"https://api.github.com/repos/AaronRobson/xenadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/AaronRobson/xenadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/AaronRobson/xenadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AaronRobson/xenadmin/labels{/name}","releases_url":"https://api.github.com/repos/AaronRobson/xenadmin/releases{/id}","deployments_url":"https://api.github.com/repos/AaronRobson/xenadmin/deployments","created_at":"2018-09-17T13:29:37Z","updated_at":"2018-11-23T08:47:27Z","pushed_at":"2018-11-23T14:42:47Z","git_url":"git://github.com/AaronRobson/xenadmin.git","ssh_url":"git@github.com:AaronRobson/xenadmin.git","clone_url":"https://github.com/AaronRobson/xenadmin.git","svn_url":"https://github.com/AaronRobson/xenadmin","homepage":"","size":166464,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"xenserver:master","ref":"master","sha":"a7d9c602391ec4f028fd05b2e6601e939b1a8b79","user":{"login":"xenserver","id":4669806,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Njk4MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/4669806?v=4","gravatar_id":"","url":"https://api.github.com/users/xenserver","html_url":"https://github.com/xenserver","followers_url":"https://api.github.com/users/xenserver/followers","following_url":"https://api.github.com/users/xenserver/following{/other_user}","gists_url":"https://api.github.com/users/xenserver/gists{/gist_id}","starred_url":"https://api.github.com/users/xenserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenserver/subscriptions","organizations_url":"https://api.github.com/users/xenserver/orgs","repos_url":"https://api.github.com/users/xenserver/repos","events_url":"https://api.github.com/users/xenserver/events{/privacy}","received_events_url":"https://api.github.com/users/xenserver/received_events","type":"Organization","site_admin":false},"repo":{"id":10915984,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkxNTk4NA==","name":"xenadmin","full_name":"xenserver/xenadmin","private":false,"owner":{"login":"xenserver","id":4669806,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Njk4MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/4669806?v=4","gravatar_id":"","url":"https://api.github.com/users/xenserver","html_url":"https://github.com/xenserver","followers_url":"https://api.github.com/users/xenserver/followers","following_url":"https://api.github.com/users/xenserver/following{/other_user}","gists_url":"https://api.github.com/users/xenserver/gists{/gist_id}","starred_url":"https://api.github.com/users/xenserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenserver/subscriptions","organizations_url":"https://api.github.com/users/xenserver/orgs","repos_url":"https://api.github.com/users/xenserver/repos","events_url":"https://api.github.com/users/xenserver/events{/privacy}","received_events_url":"https://api.github.com/users/xenserver/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xenserver/xenadmin","description":"XenCenter, the Windows management console for XenServer","fork":false,"url":"https://api.github.com/repos/xenserver/xenadmin","forks_url":"https://api.github.com/repos/xenserver/xenadmin/forks","keys_url":"https://api.github.com/repos/xenserver/xenadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xenserver/xenadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xenserver/xenadmin/teams","hooks_url":"https://api.github.com/repos/xenserver/xenadmin/hooks","issue_events_url":"https://api.github.com/repos/xenserver/xenadmin/issues/events{/number}","events_url":"https://api.github.com/repos/xenserver/xenadmin/events","assignees_url":"https://api.github.com/repos/xenserver/xenadmin/assignees{/user}","branches_url":"https://api.github.com/repos/xenserver/xenadmin/branches{/branch}","tags_url":"https://api.github.com/repos/xenserver/xenadmin/tags","blobs_url":"https://api.github.com/repos/xenserver/xenadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xenserver/xenadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xenserver/xenadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/xenserver/xenadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xenserver/xenadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/xenserver/xenadmin/languages","stargazers_url":"https://api.github.com/repos/xenserver/xenadmin/stargazers","contributors_url":"https://api.github.com/repos/xenserver/xenadmin/contributors","subscribers_url":"https://api.github.com/repos/xenserver/xenadmin/subscribers","subscription_url":"https://api.github.com/repos/xenserver/xenadmin/subscription","commits_url":"https://api.github.com/repos/xenserver/xenadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/xenserver/xenadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/xenserver/xenadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/xenserver/xenadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/xenserver/xenadmin/contents/{+path}","compare_url":"https://api.github.com/repos/xenserver/xenadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xenserver/xenadmin/merges","archive_url":"https://api.github.com/repos/xenserver/xenadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xenserver/xenadmin/downloads","issues_url":"https://api.github.com/repos/xenserver/xenadmin/issues{/number}","pulls_url":"https://api.github.com/repos/xenserver/xenadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/xenserver/xenadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/xenserver/xenadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xenserver/xenadmin/labels{/name}","releases_url":"https://api.github.com/repos/xenserver/xenadmin/releases{/id}","deployments_url":"https://api.github.com/repos/xenserver/xenadmin/deployments","created_at":"2013-06-24T18:10:24Z","updated_at":"2018-11-23T10:51:04Z","pushed_at":"2018-11-26T00:21:21Z","git_url":"git://github.com/xenserver/xenadmin.git","ssh_url":"git@github.com:xenserver/xenadmin.git","clone_url":"https://github.com/xenserver/xenadmin.git","svn_url":"https://github.com/xenserver/xenadmin","homepage":"","size":166434,"stargazers_count":168,"watchers_count":168,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":140,"open_issues":14,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/2330"},"html":{"href":"https://github.com/xenserver/xenadmin/pull/2330"},"issue":{"href":"https://api.github.com/repos/xenserver/xenadmin/issues/2330"},"comments":{"href":"https://api.github.com/repos/xenserver/xenadmin/issues/2330/comments"},"review_comments":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/2330/comments"},"review_comment":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/2330/commits"},"statuses":{"href":"https://api.github.com/repos/xenserver/xenadmin/statuses/8159ae6e54f4e2920be18297bc14bb2215d712fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kc284"}}