{"action":"created","comment":{"url":"https://api.github.com/repos/XENON1T/hax/pulls/comments/204563935","pull_request_review_id":139666536,"id":204563935,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU2MzkzNQ==","diff_hunk":"@@ -370,6 +370,8 @@ def load_single_dataset(run_id, treemakers, preselection=None, force_reload=Fals\n \n     :param event_list: List of event numbers to visit. Disables load from / save to file.\n \n+    :bypass_blinding: Flag to disable blinding cut (WARNING: analysts should not use this, only for production! See #211)","path":"hax/minitrees.py","position":13,"original_position":13,"commit_id":"672ce319693c4ba2f13c17970cac9bd661cfd5b1","original_commit_id":"672ce319693c4ba2f13c17970cac9bd661cfd5b1","user":{"login":"tunnell","id":2406627,"node_id":"MDQ6VXNlcjI0MDY2Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/2406627?v=4","gravatar_id":"","url":"https://api.github.com/users/tunnell","html_url":"https://github.com/tunnell","followers_url":"https://api.github.com/users/tunnell/followers","following_url":"https://api.github.com/users/tunnell/following{/other_user}","gists_url":"https://api.github.com/users/tunnell/gists{/gist_id}","starred_url":"https://api.github.com/users/tunnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunnell/subscriptions","organizations_url":"https://api.github.com/users/tunnell/orgs","repos_url":"https://api.github.com/users/tunnell/repos","events_url":"https://api.github.com/users/tunnell/events{/privacy}","received_events_url":"https://api.github.com/users/tunnell/received_events","type":"User","site_admin":false},"body":"__[Flake8]__\n\n[E501] line too long (121 > 120 characters)\n\n\n<!-- Comment by [Sider](https://sider.review) -->","created_at":"2018-07-23T21:45:14Z","updated_at":"2018-07-23T21:45:14Z","html_url":"https://github.com/XENON1T/hax/pull/211#discussion_r204563935","pull_request_url":"https://api.github.com/repos/XENON1T/hax/pulls/211","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/XENON1T/hax/pulls/comments/204563935"},"html":{"href":"https://github.com/XENON1T/hax/pull/211#discussion_r204563935"},"pull_request":{"href":"https://api.github.com/repos/XENON1T/hax/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/XENON1T/hax/pulls/211","id":166967118,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY2OTY3MTE4","html_url":"https://github.com/XENON1T/hax/pull/211","diff_url":"https://github.com/XENON1T/hax/pull/211.diff","patch_url":"https://github.com/XENON1T/hax/pull/211.patch","issue_url":"https://api.github.com/repos/XENON1T/hax/issues/211","number":211,"state":"open","locked":false,"title":"PosRec minitree unblinding","user":{"login":"pdeperio","id":8642192,"node_id":"MDQ6VXNlcjg2NDIxOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8642192?v=4","gravatar_id":"","url":"https://api.github.com/users/pdeperio","html_url":"https://github.com/pdeperio","followers_url":"https://api.github.com/users/pdeperio/followers","following_url":"https://api.github.com/users/pdeperio/following{/other_user}","gists_url":"https://api.github.com/users/pdeperio/gists{/gist_id}","starred_url":"https://api.github.com/users/pdeperio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdeperio/subscriptions","organizations_url":"https://api.github.com/users/pdeperio/orgs","repos_url":"https://api.github.com/users/pdeperio/repos","events_url":"https://api.github.com/users/pdeperio/events{/privacy}","received_events_url":"https://api.github.com/users/pdeperio/received_events","type":"User","site_admin":false},"body":"## _**((WARNING: DO NOT MERGE OR BLINDING WILL BREAK))**_\r\n\r\nThe ```PositionReconstruction``` minitrees (ROOT files on disk) are mistakenly blinded due to [this line](https://github.com/XENON1T/hax/blob/v2.3.3/hax/treemakers/posrec.py#L122). @feigaodm noticed after the recent ```s2 < 200``` unblinding attempt (https://github.com/XENON1T/hax/pull/208), all the ```PositionReconstruction``` variables of events in the previously blinded region were ```NaN```.\r\n\r\nTo not stop the analysis, I did something naughty and commented out the blinding in ```minitrees.py``` [here](https://github.com/XENON1T/hax/blob/v2.3.3/hax/minitrees.py#L404) in my local installation:\r\n```\r\n    #if (hax.unblinding.unblinding_selection not in preselection and\r\n    #    ('Corrections' in treemakers or\r\n    #     hax.treemakers.corrections.Corrections in treemakers) and\r\n    #        hax.unblinding.is_blind(run_id)):\r\n    #    preselection = [hax.unblinding.unblinding_selection] + preselection\r\n```\r\nand regenerated the minitrees with version ```1.2``` as of today.\r\n\r\nDo not merge this yet, in case someone is using some non-tagged runs that haven't been regenerated by cax yet, and end up regenerating themselves with the blinded version. We need to figure out how to fix [that line](https://github.com/XENON1T/hax/blob/v2.3.3/hax/treemakers/posrec.py#L122) and include in this PR.","created_at":"2018-02-03T15:44:13Z","updated_at":"2018-07-23T21:45:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7718fbd9053da4959ea434f7613ec0ef5f8275c3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"coderdj","id":4679809,"node_id":"MDQ6VXNlcjQ2Nzk4MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4679809?v=4","gravatar_id":"","url":"https://api.github.com/users/coderdj","html_url":"https://github.com/coderdj","followers_url":"https://api.github.com/users/coderdj/followers","following_url":"https://api.github.com/users/coderdj/following{/other_user}","gists_url":"https://api.github.com/users/coderdj/gists{/gist_id}","starred_url":"https://api.github.com/users/coderdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderdj/subscriptions","organizations_url":"https://api.github.com/users/coderdj/orgs","repos_url":"https://api.github.com/users/coderdj/repos","events_url":"https://api.github.com/users/coderdj/events{/privacy}","received_events_url":"https://api.github.com/users/coderdj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/XENON1T/hax/pulls/211/commits","review_comments_url":"https://api.github.com/repos/XENON1T/hax/pulls/211/comments","review_comment_url":"https://api.github.com/repos/XENON1T/hax/pulls/comments{/number}","comments_url":"https://api.github.com/repos/XENON1T/hax/issues/211/comments","statuses_url":"https://api.github.com/repos/XENON1T/hax/statuses/672ce319693c4ba2f13c17970cac9bd661cfd5b1","head":{"label":"XENON1T:posrec_unblinding","ref":"posrec_unblinding","sha":"672ce319693c4ba2f13c17970cac9bd661cfd5b1","user":{"login":"XENON1T","id":6840852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDA4NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6840852?v=4","gravatar_id":"","url":"https://api.github.com/users/XENON1T","html_url":"https://github.com/XENON1T","followers_url":"https://api.github.com/users/XENON1T/followers","following_url":"https://api.github.com/users/XENON1T/following{/other_user}","gists_url":"https://api.github.com/users/XENON1T/gists{/gist_id}","starred_url":"https://api.github.com/users/XENON1T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XENON1T/subscriptions","organizations_url":"https://api.github.com/users/XENON1T/orgs","repos_url":"https://api.github.com/users/XENON1T/repos","events_url":"https://api.github.com/users/XENON1T/events{/privacy}","received_events_url":"https://api.github.com/users/XENON1T/received_events","type":"Organization","site_admin":false},"repo":{"id":50927571,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkyNzU3MQ==","name":"hax","full_name":"XENON1T/hax","owner":{"login":"XENON1T","id":6840852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDA4NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6840852?v=4","gravatar_id":"","url":"https://api.github.com/users/XENON1T","html_url":"https://github.com/XENON1T","followers_url":"https://api.github.com/users/XENON1T/followers","following_url":"https://api.github.com/users/XENON1T/following{/other_user}","gists_url":"https://api.github.com/users/XENON1T/gists{/gist_id}","starred_url":"https://api.github.com/users/XENON1T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XENON1T/subscriptions","organizations_url":"https://api.github.com/users/XENON1T/orgs","repos_url":"https://api.github.com/users/XENON1T/repos","events_url":"https://api.github.com/users/XENON1T/events{/privacy}","received_events_url":"https://api.github.com/users/XENON1T/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XENON1T/hax","description":"Handy Analysis for XENON (reduce processed data)","fork":false,"url":"https://api.github.com/repos/XENON1T/hax","forks_url":"https://api.github.com/repos/XENON1T/hax/forks","keys_url":"https://api.github.com/repos/XENON1T/hax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XENON1T/hax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XENON1T/hax/teams","hooks_url":"https://api.github.com/repos/XENON1T/hax/hooks","issue_events_url":"https://api.github.com/repos/XENON1T/hax/issues/events{/number}","events_url":"https://api.github.com/repos/XENON1T/hax/events","assignees_url":"https://api.github.com/repos/XENON1T/hax/assignees{/user}","branches_url":"https://api.github.com/repos/XENON1T/hax/branches{/branch}","tags_url":"https://api.github.com/repos/XENON1T/hax/tags","blobs_url":"https://api.github.com/repos/XENON1T/hax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XENON1T/hax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XENON1T/hax/git/refs{/sha}","trees_url":"https://api.github.com/repos/XENON1T/hax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XENON1T/hax/statuses/{sha}","languages_url":"https://api.github.com/repos/XENON1T/hax/languages","stargazers_url":"https://api.github.com/repos/XENON1T/hax/stargazers","contributors_url":"https://api.github.com/repos/XENON1T/hax/contributors","subscribers_url":"https://api.github.com/repos/XENON1T/hax/subscribers","subscription_url":"https://api.github.com/repos/XENON1T/hax/subscription","commits_url":"https://api.github.com/repos/XENON1T/hax/commits{/sha}","git_commits_url":"https://api.github.com/repos/XENON1T/hax/git/commits{/sha}","comments_url":"https://api.github.com/repos/XENON1T/hax/comments{/number}","issue_comment_url":"https://api.github.com/repos/XENON1T/hax/issues/comments{/number}","contents_url":"https://api.github.com/repos/XENON1T/hax/contents/{+path}","compare_url":"https://api.github.com/repos/XENON1T/hax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XENON1T/hax/merges","archive_url":"https://api.github.com/repos/XENON1T/hax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XENON1T/hax/downloads","issues_url":"https://api.github.com/repos/XENON1T/hax/issues{/number}","pulls_url":"https://api.github.com/repos/XENON1T/hax/pulls{/number}","milestones_url":"https://api.github.com/repos/XENON1T/hax/milestones{/number}","notifications_url":"https://api.github.com/repos/XENON1T/hax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XENON1T/hax/labels{/name}","releases_url":"https://api.github.com/repos/XENON1T/hax/releases{/id}","deployments_url":"https://api.github.com/repos/XENON1T/hax/deployments","created_at":"2016-02-02T14:50:29Z","updated_at":"2018-07-23T19:47:54Z","pushed_at":"2018-07-23T21:44:33Z","git_url":"git://github.com/XENON1T/hax.git","ssh_url":"git@github.com:XENON1T/hax.git","clone_url":"https://github.com/XENON1T/hax.git","svn_url":"https://github.com/XENON1T/hax","homepage":"","size":13728,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":25,"license":null,"forks":0,"open_issues":25,"watchers":6,"default_branch":"master"}},"base":{"label":"XENON1T:master","ref":"master","sha":"f5d2232b406dc9bce492db422db6abc8fcc9aba1","user":{"login":"XENON1T","id":6840852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDA4NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6840852?v=4","gravatar_id":"","url":"https://api.github.com/users/XENON1T","html_url":"https://github.com/XENON1T","followers_url":"https://api.github.com/users/XENON1T/followers","following_url":"https://api.github.com/users/XENON1T/following{/other_user}","gists_url":"https://api.github.com/users/XENON1T/gists{/gist_id}","starred_url":"https://api.github.com/users/XENON1T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XENON1T/subscriptions","organizations_url":"https://api.github.com/users/XENON1T/orgs","repos_url":"https://api.github.com/users/XENON1T/repos","events_url":"https://api.github.com/users/XENON1T/events{/privacy}","received_events_url":"https://api.github.com/users/XENON1T/received_events","type":"Organization","site_admin":false},"repo":{"id":50927571,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkyNzU3MQ==","name":"hax","full_name":"XENON1T/hax","owner":{"login":"XENON1T","id":6840852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDA4NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6840852?v=4","gravatar_id":"","url":"https://api.github.com/users/XENON1T","html_url":"https://github.com/XENON1T","followers_url":"https://api.github.com/users/XENON1T/followers","following_url":"https://api.github.com/users/XENON1T/following{/other_user}","gists_url":"https://api.github.com/users/XENON1T/gists{/gist_id}","starred_url":"https://api.github.com/users/XENON1T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XENON1T/subscriptions","organizations_url":"https://api.github.com/users/XENON1T/orgs","repos_url":"https://api.github.com/users/XENON1T/repos","events_url":"https://api.github.com/users/XENON1T/events{/privacy}","received_events_url":"https://api.github.com/users/XENON1T/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XENON1T/hax","description":"Handy Analysis for XENON (reduce processed data)","fork":false,"url":"https://api.github.com/repos/XENON1T/hax","forks_url":"https://api.github.com/repos/XENON1T/hax/forks","keys_url":"https://api.github.com/repos/XENON1T/hax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XENON1T/hax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XENON1T/hax/teams","hooks_url":"https://api.github.com/repos/XENON1T/hax/hooks","issue_events_url":"https://api.github.com/repos/XENON1T/hax/issues/events{/number}","events_url":"https://api.github.com/repos/XENON1T/hax/events","assignees_url":"https://api.github.com/repos/XENON1T/hax/assignees{/user}","branches_url":"https://api.github.com/repos/XENON1T/hax/branches{/branch}","tags_url":"https://api.github.com/repos/XENON1T/hax/tags","blobs_url":"https://api.github.com/repos/XENON1T/hax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XENON1T/hax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XENON1T/hax/git/refs{/sha}","trees_url":"https://api.github.com/repos/XENON1T/hax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XENON1T/hax/statuses/{sha}","languages_url":"https://api.github.com/repos/XENON1T/hax/languages","stargazers_url":"https://api.github.com/repos/XENON1T/hax/stargazers","contributors_url":"https://api.github.com/repos/XENON1T/hax/contributors","subscribers_url":"https://api.github.com/repos/XENON1T/hax/subscribers","subscription_url":"https://api.github.com/repos/XENON1T/hax/subscription","commits_url":"https://api.github.com/repos/XENON1T/hax/commits{/sha}","git_commits_url":"https://api.github.com/repos/XENON1T/hax/git/commits{/sha}","comments_url":"https://api.github.com/repos/XENON1T/hax/comments{/number}","issue_comment_url":"https://api.github.com/repos/XENON1T/hax/issues/comments{/number}","contents_url":"https://api.github.com/repos/XENON1T/hax/contents/{+path}","compare_url":"https://api.github.com/repos/XENON1T/hax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XENON1T/hax/merges","archive_url":"https://api.github.com/repos/XENON1T/hax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XENON1T/hax/downloads","issues_url":"https://api.github.com/repos/XENON1T/hax/issues{/number}","pulls_url":"https://api.github.com/repos/XENON1T/hax/pulls{/number}","milestones_url":"https://api.github.com/repos/XENON1T/hax/milestones{/number}","notifications_url":"https://api.github.com/repos/XENON1T/hax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XENON1T/hax/labels{/name}","releases_url":"https://api.github.com/repos/XENON1T/hax/releases{/id}","deployments_url":"https://api.github.com/repos/XENON1T/hax/deployments","created_at":"2016-02-02T14:50:29Z","updated_at":"2018-07-23T19:47:54Z","pushed_at":"2018-07-23T21:44:33Z","git_url":"git://github.com/XENON1T/hax.git","ssh_url":"git@github.com:XENON1T/hax.git","clone_url":"https://github.com/XENON1T/hax.git","svn_url":"https://github.com/XENON1T/hax","homepage":"","size":13728,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":25,"license":null,"forks":0,"open_issues":25,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/XENON1T/hax/pulls/211"},"html":{"href":"https://github.com/XENON1T/hax/pull/211"},"issue":{"href":"https://api.github.com/repos/XENON1T/hax/issues/211"},"comments":{"href":"https://api.github.com/repos/XENON1T/hax/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/XENON1T/hax/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/XENON1T/hax/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/XENON1T/hax/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/XENON1T/hax/statuses/672ce319693c4ba2f13c17970cac9bd661cfd5b1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tunnell"}}