{"action":"created","comment":{"url":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/comments/169709213","pull_request_review_id":98279868,"id":169709213,"diff_hunk":"@@ -110,4 +110,24 @@ describe('IndicatorBoxComponent', () => {\n     expect(indicatorBoxTag.nativeElement.attributes['title'].value).toEqual('Last run of test \"test\" was successful');\n     expect(indicatorBoxTag.nativeElement.className).toEqual('fa fa-circle test-success');\n   });\n+\n+  it('handles exceptions in condition expressions gracefully', () => {\n+    // given\n+    hostComponent.path = 'sample/path/to/test.tcl';\n+    hostComponent.workspace = new Workspace();\n+    hostComponent.workspace.setMarkerValue(hostComponent.path, 'testStatus', ElementState.Running);\n+    hostComponent.workspace.setMarkerValue(hostComponent.path, 'name', 'test');\n+    hostComponent.states = sampleMarkerStates.slice()\n+    hostComponent.states.unshift({\n+      condition: (marker) => marker.nonExisting.property === true,\n+      cssClasses: 'fa fa-spinner fa-spin',\n+      label: (marker) => { throw new Error('broken label provider'); },\n+    });\n+\n+    // when\n+    fixture.detectChanges()\n+\n+    // then\n+    // expect no errors","path":"src/lib/src/component/tree-viewer/indicator.box.component.spec.ts","position":22,"original_position":22,"commit_id":"12988d89139f76867b28e1aa2d87c5e043c0b4a3","original_commit_id":"68cb0facf912171885124963e732d27b2d653b69","user":{"login":"jjelschen","id":2879473,"avatar_url":"https://avatars3.githubusercontent.com/u/2879473?v=4","gravatar_id":"","url":"https://api.github.com/users/jjelschen","html_url":"https://github.com/jjelschen","followers_url":"https://api.github.com/users/jjelschen/followers","following_url":"https://api.github.com/users/jjelschen/following{/other_user}","gists_url":"https://api.github.com/users/jjelschen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjelschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjelschen/subscriptions","organizations_url":"https://api.github.com/users/jjelschen/orgs","repos_url":"https://api.github.com/users/jjelschen/repos","events_url":"https://api.github.com/users/jjelschen/events{/privacy}","received_events_url":"https://api.github.com/users/jjelschen/received_events","type":"User","site_admin":false},"body":"My reasoning was that, if there is an exception while evaluating a state condition, it should be caught, and execution should proceed as if the condition evaluated to `false`. So, if there is another state whose condition evaluates to `true`, it will become active, and remain unaffected by other, potentially faulty states. Only if no state can become active are the defaults used.\r\n\r\nI modified the test as you suggested, but also added another one, to distinguish those two cases.","created_at":"2018-02-21T17:07:30Z","updated_at":"2018-02-21T17:07:30Z","html_url":"https://github.com/test-editor/web-workspace-navigator/pull/56#discussion_r169709213","pull_request_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/56","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/comments/169709213"},"html":{"href":"https://github.com/test-editor/web-workspace-navigator/pull/56#discussion_r169709213"},"pull_request":{"href":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/56"}},"in_reply_to_id":169685249},"pull_request":{"url":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/56","id":169408993,"html_url":"https://github.com/test-editor/web-workspace-navigator/pull/56","diff_url":"https://github.com/test-editor/web-workspace-navigator/pull/56.diff","patch_url":"https://github.com/test-editor/web-workspace-navigator/pull/56.patch","issue_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/issues/56","number":56,"state":"open","locked":false,"title":"Feature/validation indicators","user":{"login":"jjelschen","id":2879473,"avatar_url":"https://avatars3.githubusercontent.com/u/2879473?v=4","gravatar_id":"","url":"https://api.github.com/users/jjelschen","html_url":"https://github.com/jjelschen","followers_url":"https://api.github.com/users/jjelschen/followers","following_url":"https://api.github.com/users/jjelschen/following{/other_user}","gists_url":"https://api.github.com/users/jjelschen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjelschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjelschen/subscriptions","organizations_url":"https://api.github.com/users/jjelschen/orgs","repos_url":"https://api.github.com/users/jjelschen/repos","events_url":"https://api.github.com/users/jjelschen/events{/privacy}","received_events_url":"https://api.github.com/users/jjelschen/received_events","type":"User","site_admin":false},"body":"Web Workspace Navigator is prepared to display validation status markers (or any arbitrary marker information). This is fully configurable; an example is given in the demo app.\r\n\r\nThis branch is based on unmerged previous changes, which should be reviewed and merged first, to ease reviewing this pull request:\r\n* pull request [52](https://github.com/test-editor/web-workspace-navigator/pull/52)\r\n* pull request [54](https://github.com/test-editor/web-workspace-navigator/pull/54)\r\n* pull request [55](https://github.com/test-editor/web-workspace-navigator/pull/55)","created_at":"2018-02-15T15:51:12Z","updated_at":"2018-02-21T17:07:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e20939598cf512f405309a05b20e0dfff9581a2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/56/commits","review_comments_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/56/comments","review_comment_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/issues/56/comments","statuses_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/statuses/12988d89139f76867b28e1aa2d87c5e043c0b4a3","head":{"label":"test-editor:feature/validation-indicators","ref":"feature/validation-indicators","sha":"12988d89139f76867b28e1aa2d87c5e043c0b4a3","user":{"login":"test-editor","id":7946408,"avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":98202598,"name":"web-workspace-navigator","full_name":"test-editor/web-workspace-navigator","owner":{"login":"test-editor","id":7946408,"avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/test-editor/web-workspace-navigator","description":"Angular component for workspace handling and navigation.","fork":false,"url":"https://api.github.com/repos/test-editor/web-workspace-navigator","forks_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/forks","keys_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/teams","hooks_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/hooks","issue_events_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/issues/events{/number}","events_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/events","assignees_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/assignees{/user}","branches_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/branches{/branch}","tags_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/tags","blobs_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/languages","stargazers_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/stargazers","contributors_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/contributors","subscribers_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/subscribers","subscription_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/subscription","commits_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/contents/{+path}","compare_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/merges","archive_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/downloads","issues_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/issues{/number}","pulls_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/labels{/name}","releases_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/releases{/id}","deployments_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/deployments","created_at":"2017-07-24T14:55:08Z","updated_at":"2017-08-23T14:25:01Z","pushed_at":"2018-02-21T16:51:36Z","git_url":"git://github.com/test-editor/web-workspace-navigator.git","ssh_url":"git@github.com:test-editor/web-workspace-navigator.git","clone_url":"https://github.com/test-editor/web-workspace-navigator.git","svn_url":"https://github.com/test-editor/web-workspace-navigator","homepage":"","size":481,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"test-editor:master","ref":"master","sha":"d36c65bd935a4db8716dc6d50b713538a75040af","user":{"login":"test-editor","id":7946408,"avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":98202598,"name":"web-workspace-navigator","full_name":"test-editor/web-workspace-navigator","owner":{"login":"test-editor","id":7946408,"avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/test-editor/web-workspace-navigator","description":"Angular component for workspace handling and navigation.","fork":false,"url":"https://api.github.com/repos/test-editor/web-workspace-navigator","forks_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/forks","keys_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/teams","hooks_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/hooks","issue_events_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/issues/events{/number}","events_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/events","assignees_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/assignees{/user}","branches_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/branches{/branch}","tags_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/tags","blobs_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/languages","stargazers_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/stargazers","contributors_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/contributors","subscribers_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/subscribers","subscription_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/subscription","commits_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/contents/{+path}","compare_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/merges","archive_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/downloads","issues_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/issues{/number}","pulls_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/labels{/name}","releases_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/releases{/id}","deployments_url":"https://api.github.com/repos/test-editor/web-workspace-navigator/deployments","created_at":"2017-07-24T14:55:08Z","updated_at":"2017-08-23T14:25:01Z","pushed_at":"2018-02-21T16:51:36Z","git_url":"git://github.com/test-editor/web-workspace-navigator.git","ssh_url":"git@github.com:test-editor/web-workspace-navigator.git","clone_url":"https://github.com/test-editor/web-workspace-navigator.git","svn_url":"https://github.com/test-editor/web-workspace-navigator","homepage":"","size":481,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/56"},"html":{"href":"https://github.com/test-editor/web-workspace-navigator/pull/56"},"issue":{"href":"https://api.github.com/repos/test-editor/web-workspace-navigator/issues/56"},"comments":{"href":"https://api.github.com/repos/test-editor/web-workspace-navigator/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/test-editor/web-workspace-navigator/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/test-editor/web-workspace-navigator/statuses/12988d89139f76867b28e1aa2d87c5e043c0b4a3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jjelschen"}}