{"action":"closed","number":4953,"pull_request":{"url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/4953","id":182818219,"html_url":"https://github.com/deeplearning4j/deeplearning4j/pull/4953","diff_url":"https://github.com/deeplearning4j/deeplearning4j/pull/4953.diff","patch_url":"https://github.com/deeplearning4j/deeplearning4j/pull/4953.patch","issue_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/4953","number":4953,"state":"closed","locked":false,"title":"Make collectTrainingStats configurable in SharedTrainingMaster Builder","user":{"login":"romibuzi","id":2420675,"avatar_url":"https://avatars0.githubusercontent.com/u/2420675?v=4","gravatar_id":"","url":"https://api.github.com/users/romibuzi","html_url":"https://github.com/romibuzi","followers_url":"https://api.github.com/users/romibuzi/followers","following_url":"https://api.github.com/users/romibuzi/following{/other_user}","gists_url":"https://api.github.com/users/romibuzi/gists{/gist_id}","starred_url":"https://api.github.com/users/romibuzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romibuzi/subscriptions","organizations_url":"https://api.github.com/users/romibuzi/orgs","repos_url":"https://api.github.com/users/romibuzi/repos","events_url":"https://api.github.com/users/romibuzi/events{/privacy}","received_events_url":"https://api.github.com/users/romibuzi/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nWhen using `SharedTrainingMaster.Builder()`, there is no possibility to disable the collect of training stats. There is a `setCollectTrainingStats(boolean)` available on the `Builder` but it's not taken later during the `build()`. This PR aims to fix it.\r\n\r\n## How was this patch tested?\r\n\r\n`cd deeplearning4j-scaleout ; mvn test`\r\n\r\n## Quick checklist\r\n\r\n- [x] Reviewed the [Contributing Guidelines](https://github.com/deeplearning4j/deeplearning4j/blob/master/CONTRIBUTING.md) and followed the steps within.\r\n- [ ] Created tests for any significant new code additions.\r\n- [x] Relevant tests for your changes are passing.\r\n- [x] Ran mvn formatter:format (see [formatter instructions](http://code.revelc.net/formatter-maven-plugin/examples.html#Setting_Source_Files) for targeting your specific files).\r\n","created_at":"2018-04-19T15:41:08Z","updated_at":"2018-05-03T12:17:20Z","closed_at":"2018-05-03T12:17:20Z","merged_at":"2018-05-03T12:17:20Z","merge_commit_sha":"3ed7291e89bb0ade469fc9d910f65b690401d4ac","assignee":null,"assignees":[],"requested_reviewers":[{"login":"raver119","id":12250879,"avatar_url":"https://avatars2.githubusercontent.com/u/12250879?v=4","gravatar_id":"","url":"https://api.github.com/users/raver119","html_url":"https://github.com/raver119","followers_url":"https://api.github.com/users/raver119/followers","following_url":"https://api.github.com/users/raver119/following{/other_user}","gists_url":"https://api.github.com/users/raver119/gists{/gist_id}","starred_url":"https://api.github.com/users/raver119/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raver119/subscriptions","organizations_url":"https://api.github.com/users/raver119/orgs","repos_url":"https://api.github.com/users/raver119/repos","events_url":"https://api.github.com/users/raver119/events{/privacy}","received_events_url":"https://api.github.com/users/raver119/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/4953/commits","review_comments_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/4953/comments","review_comment_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/4953/comments","statuses_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/statuses/9cb1a5e0fd32e80a9d019305a64e86aec4b14332","head":{"label":"romibuzi:configurable-trainingstats","ref":"configurable-trainingstats","sha":"9cb1a5e0fd32e80a9d019305a64e86aec4b14332","user":{"login":"romibuzi","id":2420675,"avatar_url":"https://avatars0.githubusercontent.com/u/2420675?v=4","gravatar_id":"","url":"https://api.github.com/users/romibuzi","html_url":"https://github.com/romibuzi","followers_url":"https://api.github.com/users/romibuzi/followers","following_url":"https://api.github.com/users/romibuzi/following{/other_user}","gists_url":"https://api.github.com/users/romibuzi/gists{/gist_id}","starred_url":"https://api.github.com/users/romibuzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romibuzi/subscriptions","organizations_url":"https://api.github.com/users/romibuzi/orgs","repos_url":"https://api.github.com/users/romibuzi/repos","events_url":"https://api.github.com/users/romibuzi/events{/privacy}","received_events_url":"https://api.github.com/users/romibuzi/received_events","type":"User","site_admin":false},"repo":{"id":130215578,"name":"deeplearning4j","full_name":"romibuzi/deeplearning4j","owner":{"login":"romibuzi","id":2420675,"avatar_url":"https://avatars0.githubusercontent.com/u/2420675?v=4","gravatar_id":"","url":"https://api.github.com/users/romibuzi","html_url":"https://github.com/romibuzi","followers_url":"https://api.github.com/users/romibuzi/followers","following_url":"https://api.github.com/users/romibuzi/following{/other_user}","gists_url":"https://api.github.com/users/romibuzi/gists{/gist_id}","starred_url":"https://api.github.com/users/romibuzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romibuzi/subscriptions","organizations_url":"https://api.github.com/users/romibuzi/orgs","repos_url":"https://api.github.com/users/romibuzi/repos","events_url":"https://api.github.com/users/romibuzi/events{/privacy}","received_events_url":"https://api.github.com/users/romibuzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romibuzi/deeplearning4j","description":"Deep Learning for Java, Scala & Clojure on Hadoop & Spark With GPUs - From Skymind","fork":true,"url":"https://api.github.com/repos/romibuzi/deeplearning4j","forks_url":"https://api.github.com/repos/romibuzi/deeplearning4j/forks","keys_url":"https://api.github.com/repos/romibuzi/deeplearning4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romibuzi/deeplearning4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romibuzi/deeplearning4j/teams","hooks_url":"https://api.github.com/repos/romibuzi/deeplearning4j/hooks","issue_events_url":"https://api.github.com/repos/romibuzi/deeplearning4j/issues/events{/number}","events_url":"https://api.github.com/repos/romibuzi/deeplearning4j/events","assignees_url":"https://api.github.com/repos/romibuzi/deeplearning4j/assignees{/user}","branches_url":"https://api.github.com/repos/romibuzi/deeplearning4j/branches{/branch}","tags_url":"https://api.github.com/repos/romibuzi/deeplearning4j/tags","blobs_url":"https://api.github.com/repos/romibuzi/deeplearning4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romibuzi/deeplearning4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romibuzi/deeplearning4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/romibuzi/deeplearning4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romibuzi/deeplearning4j/statuses/{sha}","languages_url":"https://api.github.com/repos/romibuzi/deeplearning4j/languages","stargazers_url":"https://api.github.com/repos/romibuzi/deeplearning4j/stargazers","contributors_url":"https://api.github.com/repos/romibuzi/deeplearning4j/contributors","subscribers_url":"https://api.github.com/repos/romibuzi/deeplearning4j/subscribers","subscription_url":"https://api.github.com/repos/romibuzi/deeplearning4j/subscription","commits_url":"https://api.github.com/repos/romibuzi/deeplearning4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/romibuzi/deeplearning4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/romibuzi/deeplearning4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/romibuzi/deeplearning4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/romibuzi/deeplearning4j/contents/{+path}","compare_url":"https://api.github.com/repos/romibuzi/deeplearning4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romibuzi/deeplearning4j/merges","archive_url":"https://api.github.com/repos/romibuzi/deeplearning4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romibuzi/deeplearning4j/downloads","issues_url":"https://api.github.com/repos/romibuzi/deeplearning4j/issues{/number}","pulls_url":"https://api.github.com/repos/romibuzi/deeplearning4j/pulls{/number}","milestones_url":"https://api.github.com/repos/romibuzi/deeplearning4j/milestones{/number}","notifications_url":"https://api.github.com/repos/romibuzi/deeplearning4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romibuzi/deeplearning4j/labels{/name}","releases_url":"https://api.github.com/repos/romibuzi/deeplearning4j/releases{/id}","deployments_url":"https://api.github.com/repos/romibuzi/deeplearning4j/deployments","created_at":"2018-04-19T12:55:09Z","updated_at":"2018-04-19T12:55:21Z","pushed_at":"2018-04-19T15:30:18Z","git_url":"git://github.com/romibuzi/deeplearning4j.git","ssh_url":"git@github.com:romibuzi/deeplearning4j.git","clone_url":"https://github.com/romibuzi/deeplearning4j.git","svn_url":"https://github.com/romibuzi/deeplearning4j","homepage":"http://deeplearning4j.org","size":193558,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deeplearning4j:master","ref":"master","sha":"49ae461b8b52ad543aee086c9245283eac356dee","user":{"login":"deeplearning4j","id":10988606,"avatar_url":"https://avatars2.githubusercontent.com/u/10988606?v=4","gravatar_id":"","url":"https://api.github.com/users/deeplearning4j","html_url":"https://github.com/deeplearning4j","followers_url":"https://api.github.com/users/deeplearning4j/followers","following_url":"https://api.github.com/users/deeplearning4j/following{/other_user}","gists_url":"https://api.github.com/users/deeplearning4j/gists{/gist_id}","starred_url":"https://api.github.com/users/deeplearning4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeplearning4j/subscriptions","organizations_url":"https://api.github.com/users/deeplearning4j/orgs","repos_url":"https://api.github.com/users/deeplearning4j/repos","events_url":"https://api.github.com/users/deeplearning4j/events{/privacy}","received_events_url":"https://api.github.com/users/deeplearning4j/received_events","type":"Organization","site_admin":false},"repo":{"id":14734876,"name":"deeplearning4j","full_name":"deeplearning4j/deeplearning4j","owner":{"login":"deeplearning4j","id":10988606,"avatar_url":"https://avatars2.githubusercontent.com/u/10988606?v=4","gravatar_id":"","url":"https://api.github.com/users/deeplearning4j","html_url":"https://github.com/deeplearning4j","followers_url":"https://api.github.com/users/deeplearning4j/followers","following_url":"https://api.github.com/users/deeplearning4j/following{/other_user}","gists_url":"https://api.github.com/users/deeplearning4j/gists{/gist_id}","starred_url":"https://api.github.com/users/deeplearning4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeplearning4j/subscriptions","organizations_url":"https://api.github.com/users/deeplearning4j/orgs","repos_url":"https://api.github.com/users/deeplearning4j/repos","events_url":"https://api.github.com/users/deeplearning4j/events{/privacy}","received_events_url":"https://api.github.com/users/deeplearning4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deeplearning4j/deeplearning4j","description":"Deep Learning for Java, Scala & Clojure on Hadoop & Spark With GPUs - From Skymind","fork":false,"url":"https://api.github.com/repos/deeplearning4j/deeplearning4j","forks_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/forks","keys_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/teams","hooks_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/hooks","issue_events_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/events{/number}","events_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/events","assignees_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/assignees{/user}","branches_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/branches{/branch}","tags_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/tags","blobs_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/statuses/{sha}","languages_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/languages","stargazers_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/stargazers","contributors_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/contributors","subscribers_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/subscribers","subscription_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/subscription","commits_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/contents/{+path}","compare_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/merges","archive_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/downloads","issues_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues{/number}","pulls_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls{/number}","milestones_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/milestones{/number}","notifications_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/labels{/name}","releases_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/releases{/id}","deployments_url":"https://api.github.com/repos/deeplearning4j/deeplearning4j/deployments","created_at":"2013-11-27T02:03:28Z","updated_at":"2018-05-03T12:15:59Z","pushed_at":"2018-05-03T12:17:19Z","git_url":"git://github.com/deeplearning4j/deeplearning4j.git","ssh_url":"git@github.com:deeplearning4j/deeplearning4j.git","clone_url":"https://github.com/deeplearning4j/deeplearning4j.git","svn_url":"https://github.com/deeplearning4j/deeplearning4j","homepage":"http://deeplearning4j.org","size":194047,"stargazers_count":8820,"watchers_count":8820,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4222,"mirror_url":null,"archived":false,"open_issues_count":429,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4222,"open_issues":429,"watchers":8820,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/4953"},"html":{"href":"https://github.com/deeplearning4j/deeplearning4j/pull/4953"},"issue":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/4953"},"comments":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/issues/4953/comments"},"review_comments":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/4953/comments"},"review_comment":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/pulls/4953/commits"},"statuses":{"href":"https://api.github.com/repos/deeplearning4j/deeplearning4j/statuses/9cb1a5e0fd32e80a9d019305a64e86aec4b14332"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"agibsonccc","id":1144306,"avatar_url":"https://avatars2.githubusercontent.com/u/1144306?v=4","gravatar_id":"","url":"https://api.github.com/users/agibsonccc","html_url":"https://github.com/agibsonccc","followers_url":"https://api.github.com/users/agibsonccc/followers","following_url":"https://api.github.com/users/agibsonccc/following{/other_user}","gists_url":"https://api.github.com/users/agibsonccc/gists{/gist_id}","starred_url":"https://api.github.com/users/agibsonccc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agibsonccc/subscriptions","organizations_url":"https://api.github.com/users/agibsonccc/orgs","repos_url":"https://api.github.com/users/agibsonccc/repos","events_url":"https://api.github.com/users/agibsonccc/events{/privacy}","received_events_url":"https://api.github.com/users/agibsonccc/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"agibsonccc"}}