{"action":"created","comment":{"url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments/203174835","pull_request_review_id":138014125,"id":203174835,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzE3NDgzNQ==","diff_hunk":"@@ -292,7 +294,8 @@ class PIP : PackageManager() {\n         virtualEnvDir.safeDeleteRecursively()\n \n         // PIP does not support lock files, so hard-code \"allowDynamicVersions\" to \"true\".\n-        return ProjectAnalyzerResult(true, project, packages.map { it.toCuratedPackage() }.toSortedSet())\n+        val config = AnalyzerConfiguration(false, true)","path":"analyzer/src/main/kotlin/managers/PIP.kt","position":41,"original_position":41,"commit_id":"b94ada9ed1f73e6b330b60dc92b819d3143c883a","original_commit_id":"b94ada9ed1f73e6b330b60dc92b819d3143c883a","user":{"login":"sschuberth","id":349154,"node_id":"MDQ6VXNlcjM0OTE1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/349154?v=4","gravatar_id":"","url":"https://api.github.com/users/sschuberth","html_url":"https://github.com/sschuberth","followers_url":"https://api.github.com/users/sschuberth/followers","following_url":"https://api.github.com/users/sschuberth/following{/other_user}","gists_url":"https://api.github.com/users/sschuberth/gists{/gist_id}","starred_url":"https://api.github.com/users/sschuberth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschuberth/subscriptions","organizations_url":"https://api.github.com/users/sschuberth/orgs","repos_url":"https://api.github.com/users/sschuberth/repos","events_url":"https://api.github.com/users/sschuberth/events{/privacy}","received_events_url":"https://api.github.com/users/sschuberth/received_events","type":"User","site_admin":false},"body":"Thanks for catching this, done.","created_at":"2018-07-17T20:54:07Z","updated_at":"2018-07-17T20:54:07Z","html_url":"https://github.com/heremaps/oss-review-toolkit/pull/693#discussion_r203174835","pull_request_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/693","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments/203174835"},"html":{"href":"https://github.com/heremaps/oss-review-toolkit/pull/693#discussion_r203174835"},"pull_request":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/693"}},"in_reply_to_id":203013327},"pull_request":{"url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/693","id":201914750,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTE0NzUw","html_url":"https://github.com/heremaps/oss-review-toolkit/pull/693","diff_url":"https://github.com/heremaps/oss-review-toolkit/pull/693.diff","patch_url":"https://github.com/heremaps/oss-review-toolkit/pull/693.patch","issue_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/693","number":693,"state":"open","locked":false,"title":"Decouple PackageManagers from the Main class","user":{"login":"sschuberth","id":349154,"node_id":"MDQ6VXNlcjM0OTE1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/349154?v=4","gravatar_id":"","url":"https://api.github.com/users/sschuberth","html_url":"https://github.com/sschuberth","followers_url":"https://api.github.com/users/sschuberth/followers","following_url":"https://api.github.com/users/sschuberth/following{/other_user}","gists_url":"https://api.github.com/users/sschuberth/gists{/gist_id}","starred_url":"https://api.github.com/users/sschuberth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschuberth/subscriptions","organizations_url":"https://api.github.com/users/sschuberth/orgs","repos_url":"https://api.github.com/users/sschuberth/repos","events_url":"https://api.github.com/users/sschuberth/events{/privacy}","received_events_url":"https://api.github.com/users/sschuberth/received_events","type":"User","site_admin":false},"body":"As we aim for the ORT modules to be usable as independent libraries,\r\nPackageManagers should not depend on the Main entry point for command\r\nline usage. As a step into the right direction, avoid PackageManagers to\r\ndirectly access Main's command line parameters by introducing a\r\nAnalyzerConfiguration class that instead holds all relevant options.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/heremaps/oss-review-toolkit/693)\n<!-- Reviewable:end -->\n","created_at":"2018-07-17T11:49:30Z","updated_at":"2018-07-17T20:54:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5a0cc94c59974e62eef34e312ebf458f50f0f22","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/693/commits","review_comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/693/comments","review_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/693/comments","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/b94ada9ed1f73e6b330b60dc92b819d3143c883a","head":{"label":"heremaps:analyzer-config","ref":"analyzer-config","sha":"b94ada9ed1f73e6b330b60dc92b819d3143c883a","user":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"repo":{"id":107540288,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1NDAyODg=","name":"oss-review-toolkit","full_name":"heremaps/oss-review-toolkit","owner":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heremaps/oss-review-toolkit","description":"A suite of tools to assist with reviewing Open Source Software dependencies.","fork":false,"url":"https://api.github.com/repos/heremaps/oss-review-toolkit","forks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/forks","keys_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/teams","hooks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/hooks","issue_events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/events","assignees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/tags","blobs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/languages","stargazers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/stargazers","contributors_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contributors","subscribers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscribers","subscription_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscription","commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/merges","archive_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/downloads","issues_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/deployments","created_at":"2017-10-19T11:59:49Z","updated_at":"2018-07-17T09:38:03Z","pushed_at":"2018-07-17T11:49:36Z","git_url":"git://github.com/heremaps/oss-review-toolkit.git","ssh_url":"git@github.com:heremaps/oss-review-toolkit.git","clone_url":"https://github.com/heremaps/oss-review-toolkit.git","svn_url":"https://github.com/heremaps/oss-review-toolkit","homepage":null,"size":52537,"stargazers_count":73,"watchers_count":73,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":20,"watchers":73,"default_branch":"master"}},"base":{"label":"heremaps:master","ref":"master","sha":"74fe8b20401b08527b6d3f72182e43faad0c3013","user":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"repo":{"id":107540288,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1NDAyODg=","name":"oss-review-toolkit","full_name":"heremaps/oss-review-toolkit","owner":{"login":"heremaps","id":2835506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzU1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heremaps/oss-review-toolkit","description":"A suite of tools to assist with reviewing Open Source Software dependencies.","fork":false,"url":"https://api.github.com/repos/heremaps/oss-review-toolkit","forks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/forks","keys_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/teams","hooks_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/hooks","issue_events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/events","assignees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/tags","blobs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/languages","stargazers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/stargazers","contributors_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contributors","subscribers_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscribers","subscription_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/subscription","commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/merges","archive_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/downloads","issues_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/heremaps/oss-review-toolkit/deployments","created_at":"2017-10-19T11:59:49Z","updated_at":"2018-07-17T09:38:03Z","pushed_at":"2018-07-17T11:49:36Z","git_url":"git://github.com/heremaps/oss-review-toolkit.git","ssh_url":"git@github.com:heremaps/oss-review-toolkit.git","clone_url":"https://github.com/heremaps/oss-review-toolkit.git","svn_url":"https://github.com/heremaps/oss-review-toolkit","homepage":null,"size":52537,"stargazers_count":73,"watchers_count":73,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":20,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/693"},"html":{"href":"https://github.com/heremaps/oss-review-toolkit/pull/693"},"issue":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/693"},"comments":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/issues/693/comments"},"review_comments":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/693/comments"},"review_comment":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/pulls/693/commits"},"statuses":{"href":"https://api.github.com/repos/heremaps/oss-review-toolkit/statuses/b94ada9ed1f73e6b330b60dc92b819d3143c883a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sschuberth"}}