{"action":"created","issue":{"url":"https://api.github.com/repos/tbeu/ModelicaSpecification/issues/704","repository_url":"https://api.github.com/repos/tbeu/ModelicaSpecification","labels_url":"https://api.github.com/repos/tbeu/ModelicaSpecification/issues/704/labels{/name}","comments_url":"https://api.github.com/repos/tbeu/ModelicaSpecification/issues/704/comments","events_url":"https://api.github.com/repos/tbeu/ModelicaSpecification/issues/704/events","html_url":"https://github.com/tbeu/ModelicaSpecification/issues/704","id":372284311,"node_id":"MDU6SXNzdWUzNzIyODQzMTE=","number":704,"title":"Clarify conditional components","user":{"login":"modelica-trac-importer","id":22202507,"node_id":"MDQ6VXNlcjIyMjAyNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/22202507?v=4","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tbeu","id":5444067,"node_id":"MDQ6VXNlcjU0NDQwNjc=","avatar_url":"https://avatars0.githubusercontent.com/u/5444067?v=4","gravatar_id":"","url":"https://api.github.com/users/tbeu","html_url":"https://github.com/tbeu","followers_url":"https://api.github.com/users/tbeu/followers","following_url":"https://api.github.com/users/tbeu/following{/other_user}","gists_url":"https://api.github.com/users/tbeu/gists{/gist_id}","starred_url":"https://api.github.com/users/tbeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbeu/subscriptions","organizations_url":"https://api.github.com/users/tbeu/orgs","repos_url":"https://api.github.com/users/tbeu/repos","events_url":"https://api.github.com/users/tbeu/events{/privacy}","received_events_url":"https://api.github.com/users/tbeu/received_events","type":"User","site_admin":false},"assignees":[{"login":"tbeu","id":5444067,"node_id":"MDQ6VXNlcjU0NDQwNjc=","avatar_url":"https://avatars0.githubusercontent.com/u/5444067?v=4","gravatar_id":"","url":"https://api.github.com/users/tbeu","html_url":"https://github.com/tbeu","followers_url":"https://api.github.com/users/tbeu/followers","following_url":"https://api.github.com/users/tbeu/following{/other_user}","gists_url":"https://api.github.com/users/tbeu/gists{/gist_id}","starred_url":"https://api.github.com/users/tbeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbeu/subscriptions","organizations_url":"https://api.github.com/users/tbeu/orgs","repos_url":"https://api.github.com/users/tbeu/repos","events_url":"https://api.github.com/users/tbeu/events{/privacy}","received_events_url":"https://api.github.com/users/tbeu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-10-21T06:27:40Z","updated_at":"2018-10-21T06:29:01Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Reported by hansolsson on 6 Sep 2016 15:02 UTC**\nAdded this as part of #744, but better to have it separate - and there is a concrete proposal to vote on:\n\nThe specification in 4.4.5 states that conditional component with the condition being false is removed from the flattened DAE.\n\nThe issue is how valid the component must be when it is removed. \n\nThe term 'removed' to me indicates that the component is first added (which implies that it would be valid to add it), and then 'removed'.\n\nIn particular this means:\n\n* The type exists \n* The modifier is legal (the example in the spec confirms that) \n* A component with that type would not break restrictions on restricted classes (1) \n* If the component is declared using 'outer' the corresponding 'inner' component should exist \n\n(1): E.g. a block may not contain e.g. an Electrical pin with condition false.\n—\nThe proposal would be to clarify 4.4.5 to:\n\nThe component is first added to the flattened DAE regardless of the condition.\n If the Boolean expression is false the component (including its modifier) is removed from the flattened DAE , and connections to/from the component are removed. \n [Adding the component and then removing it ensures that the component is valid.]\n\n\n\n----\n\nMigrated-From: https://trac.modelica.org/Modelica/ticket/2057"},"comment":{"url":"https://api.github.com/repos/tbeu/ModelicaSpecification/issues/comments/431642703","html_url":"https://github.com/tbeu/ModelicaSpecification/issues/704#issuecomment-431642703","issue_url":"https://api.github.com/repos/tbeu/ModelicaSpecification/issues/704","id":431642703,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTY0MjcwMw==","user":{"login":"modelica-trac-importer","id":22202507,"node_id":"MDQ6VXNlcjIyMjAyNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/22202507?v=4","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"created_at":"2018-10-21T06:29:01Z","updated_at":"2018-10-21T06:29:01Z","author_association":"COLLABORATOR","body":"**Comment by hansolsson on 23 Sep 2016 15:15 UTC**\nResolved in r9491"}}
{"actor":{"display_login":"modelica-trac-importer"}}