{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/comments/167322623","pull_request_review_id":95534014,"id":167322623,"diff_hunk":"@@ -26,5 +26,8 @@ elif [[ $1 == \"lint\" ]]\n         echo \"Linting Checker...\"\n         launch_pylint ./src/checkers\n         r2=$?\n-        exit $((r1 + r2))\n+        echo $((r1 + r2))\n fi\n+","path":"scripts/verify.sh","position":7,"original_position":7,"commit_id":"523a473dec95244e7e80b59168311c057b15e3de","original_commit_id":"523a473dec95244e7e80b59168311c057b15e3de","user":{"login":"Christina-Kang","id":4260977,"avatar_url":"https://avatars1.githubusercontent.com/u/4260977?v=4","gravatar_id":"","url":"https://api.github.com/users/Christina-Kang","html_url":"https://github.com/Christina-Kang","followers_url":"https://api.github.com/users/Christina-Kang/followers","following_url":"https://api.github.com/users/Christina-Kang/following{/other_user}","gists_url":"https://api.github.com/users/Christina-Kang/gists{/gist_id}","starred_url":"https://api.github.com/users/Christina-Kang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christina-Kang/subscriptions","organizations_url":"https://api.github.com/users/Christina-Kang/orgs","repos_url":"https://api.github.com/users/Christina-Kang/repos","events_url":"https://api.github.com/users/Christina-Kang/events{/privacy}","received_events_url":"https://api.github.com/users/Christina-Kang/received_events","type":"User","site_admin":false},"body":"Because I don't want to have to change other parts of the the script. It doesn't seem worth the effort.","created_at":"2018-02-09T19:23:47Z","updated_at":"2018-02-09T19:23:47Z","html_url":"https://github.com/Azure/service-fabric-cli/pull/64#discussion_r167322623","pull_request_url":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/64","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/comments/167322623"},"html":{"href":"https://github.com/Azure/service-fabric-cli/pull/64#discussion_r167322623"},"pull_request":{"href":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/64"}},"in_reply_to_id":167046120},"pull_request":{"url":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/64","id":167237206,"html_url":"https://github.com/Azure/service-fabric-cli/pull/64","diff_url":"https://github.com/Azure/service-fabric-cli/pull/64.diff","patch_url":"https://github.com/Azure/service-fabric-cli/pull/64.patch","issue_url":"https://api.github.com/repos/Azure/service-fabric-cli/issues/64","number":64,"state":"open","locked":false,"title":"Adding provision application type, get container logs deployed on nod…","user":{"login":"Christina-Kang","id":4260977,"avatar_url":"https://avatars1.githubusercontent.com/u/4260977?v=4","gravatar_id":"","url":"https://api.github.com/users/Christina-Kang","html_url":"https://github.com/Christina-Kang","followers_url":"https://api.github.com/users/Christina-Kang/followers","following_url":"https://api.github.com/users/Christina-Kang/following{/other_user}","gists_url":"https://api.github.com/users/Christina-Kang/gists{/gist_id}","starred_url":"https://api.github.com/users/Christina-Kang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christina-Kang/subscriptions","organizations_url":"https://api.github.com/users/Christina-Kang/orgs","repos_url":"https://api.github.com/users/Christina-Kang/repos","events_url":"https://api.github.com/users/Christina-Kang/events{/privacy}","received_events_url":"https://api.github.com/users/Christina-Kang/received_events","type":"User","site_admin":false},"body":"- add new version of provision application type\r\n- add command to get container logs deployed on node\r\n- make queries with max results option accept max results option\r\n- add automated testing to verify correctness of generated HTTP request\r\n- added myself to repo owners\r\n- changed verify.sh script to not close automatically after run on windows (not tested on linux)\r\n- updated change log\r\n- updated service fabric SDK required version\r\n- changed command sfctl property put to be more flat with its parameters\r\n- fixed bug with infrastructure commands erroring out\r\n- Change imagestore upload command to generate rest API with version 6.1 instead of 3.0-preview","created_at":"2018-02-05T19:45:58Z","updated_at":"2018-02-09T19:23:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a00b5fcd7e1b9a99b4b72408a01a4c907b14e352","assignee":{"login":"samedder","id":26749906,"avatar_url":"https://avatars1.githubusercontent.com/u/26749906?v=4","gravatar_id":"","url":"https://api.github.com/users/samedder","html_url":"https://github.com/samedder","followers_url":"https://api.github.com/users/samedder/followers","following_url":"https://api.github.com/users/samedder/following{/other_user}","gists_url":"https://api.github.com/users/samedder/gists{/gist_id}","starred_url":"https://api.github.com/users/samedder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samedder/subscriptions","organizations_url":"https://api.github.com/users/samedder/orgs","repos_url":"https://api.github.com/users/samedder/repos","events_url":"https://api.github.com/users/samedder/events{/privacy}","received_events_url":"https://api.github.com/users/samedder/received_events","type":"User","site_admin":false},"assignees":[{"login":"samedder","id":26749906,"avatar_url":"https://avatars1.githubusercontent.com/u/26749906?v=4","gravatar_id":"","url":"https://api.github.com/users/samedder","html_url":"https://github.com/samedder","followers_url":"https://api.github.com/users/samedder/followers","following_url":"https://api.github.com/users/samedder/following{/other_user}","gists_url":"https://api.github.com/users/samedder/gists{/gist_id}","starred_url":"https://api.github.com/users/samedder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samedder/subscriptions","organizations_url":"https://api.github.com/users/samedder/orgs","repos_url":"https://api.github.com/users/samedder/repos","events_url":"https://api.github.com/users/samedder/events{/privacy}","received_events_url":"https://api.github.com/users/samedder/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jeffreychenmsft","id":28544976,"avatar_url":"https://avatars3.githubusercontent.com/u/28544976?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffreychenmsft","html_url":"https://github.com/jeffreychenmsft","followers_url":"https://api.github.com/users/jeffreychenmsft/followers","following_url":"https://api.github.com/users/jeffreychenmsft/following{/other_user}","gists_url":"https://api.github.com/users/jeffreychenmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffreychenmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffreychenmsft/subscriptions","organizations_url":"https://api.github.com/users/jeffreychenmsft/orgs","repos_url":"https://api.github.com/users/jeffreychenmsft/repos","events_url":"https://api.github.com/users/jeffreychenmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jeffreychenmsft/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/Azure/service-fabric-cli/milestones/2","html_url":"https://github.com/Azure/service-fabric-cli/milestone/2","labels_url":"https://api.github.com/repos/Azure/service-fabric-cli/milestones/2/labels","id":3044229,"number":2,"title":"6.1 SF Runtime Release","description":"6.1 Service Fabric release","creator":{"login":"samedder","id":26749906,"avatar_url":"https://avatars1.githubusercontent.com/u/26749906?v=4","gravatar_id":"","url":"https://api.github.com/users/samedder","html_url":"https://github.com/samedder","followers_url":"https://api.github.com/users/samedder/followers","following_url":"https://api.github.com/users/samedder/following{/other_user}","gists_url":"https://api.github.com/users/samedder/gists{/gist_id}","starred_url":"https://api.github.com/users/samedder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samedder/subscriptions","organizations_url":"https://api.github.com/users/samedder/orgs","repos_url":"https://api.github.com/users/samedder/repos","events_url":"https://api.github.com/users/samedder/events{/privacy}","received_events_url":"https://api.github.com/users/samedder/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":2,"state":"open","created_at":"2018-01-17T23:16:20Z","updated_at":"2018-02-08T20:02:03Z","due_on":"2018-01-25T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/64/commits","review_comments_url":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/64/comments","review_comment_url":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/service-fabric-cli/issues/64/comments","statuses_url":"https://api.github.com/repos/Azure/service-fabric-cli/statuses/523a473dec95244e7e80b59168311c057b15e3de","head":{"label":"Christina-Kang:bikangall","ref":"bikangall","sha":"523a473dec95244e7e80b59168311c057b15e3de","user":{"login":"Christina-Kang","id":4260977,"avatar_url":"https://avatars1.githubusercontent.com/u/4260977?v=4","gravatar_id":"","url":"https://api.github.com/users/Christina-Kang","html_url":"https://github.com/Christina-Kang","followers_url":"https://api.github.com/users/Christina-Kang/followers","following_url":"https://api.github.com/users/Christina-Kang/following{/other_user}","gists_url":"https://api.github.com/users/Christina-Kang/gists{/gist_id}","starred_url":"https://api.github.com/users/Christina-Kang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christina-Kang/subscriptions","organizations_url":"https://api.github.com/users/Christina-Kang/orgs","repos_url":"https://api.github.com/users/Christina-Kang/repos","events_url":"https://api.github.com/users/Christina-Kang/events{/privacy}","received_events_url":"https://api.github.com/users/Christina-Kang/received_events","type":"User","site_admin":false},"repo":{"id":120350246,"name":"service-fabric-cli","full_name":"Christina-Kang/service-fabric-cli","owner":{"login":"Christina-Kang","id":4260977,"avatar_url":"https://avatars1.githubusercontent.com/u/4260977?v=4","gravatar_id":"","url":"https://api.github.com/users/Christina-Kang","html_url":"https://github.com/Christina-Kang","followers_url":"https://api.github.com/users/Christina-Kang/followers","following_url":"https://api.github.com/users/Christina-Kang/following{/other_user}","gists_url":"https://api.github.com/users/Christina-Kang/gists{/gist_id}","starred_url":"https://api.github.com/users/Christina-Kang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christina-Kang/subscriptions","organizations_url":"https://api.github.com/users/Christina-Kang/orgs","repos_url":"https://api.github.com/users/Christina-Kang/repos","events_url":"https://api.github.com/users/Christina-Kang/events{/privacy}","received_events_url":"https://api.github.com/users/Christina-Kang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Christina-Kang/service-fabric-cli","description":"Service Fabric CLI Tools","fork":true,"url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli","forks_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/forks","keys_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/teams","hooks_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/hooks","issue_events_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/events","assignees_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/tags","blobs_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/languages","stargazers_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/stargazers","contributors_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/contributors","subscribers_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/subscribers","subscription_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/subscription","commits_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/merges","archive_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/downloads","issues_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/labels{/name}","releases_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Christina-Kang/service-fabric-cli/deployments","created_at":"2018-02-05T19:20:04Z","updated_at":"2018-02-05T19:20:06Z","pushed_at":"2018-02-05T19:32:42Z","git_url":"git://github.com/Christina-Kang/service-fabric-cli.git","ssh_url":"git@github.com:Christina-Kang/service-fabric-cli.git","clone_url":"https://github.com/Christina-Kang/service-fabric-cli.git","svn_url":"https://github.com/Christina-Kang/service-fabric-cli","homepage":null,"size":127,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"b2d8306376cbb993b92da648bc639c7c9a029f8a","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":94585736,"name":"service-fabric-cli","full_name":"Azure/service-fabric-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/service-fabric-cli","description":"Service Fabric CLI Tools","fork":false,"url":"https://api.github.com/repos/Azure/service-fabric-cli","forks_url":"https://api.github.com/repos/Azure/service-fabric-cli/forks","keys_url":"https://api.github.com/repos/Azure/service-fabric-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/service-fabric-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/service-fabric-cli/teams","hooks_url":"https://api.github.com/repos/Azure/service-fabric-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/service-fabric-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/service-fabric-cli/events","assignees_url":"https://api.github.com/repos/Azure/service-fabric-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/service-fabric-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/service-fabric-cli/tags","blobs_url":"https://api.github.com/repos/Azure/service-fabric-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/service-fabric-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/service-fabric-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/service-fabric-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/service-fabric-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/service-fabric-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/service-fabric-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/service-fabric-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/service-fabric-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/service-fabric-cli/subscription","commits_url":"https://api.github.com/repos/Azure/service-fabric-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/service-fabric-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/service-fabric-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/service-fabric-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/service-fabric-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/service-fabric-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/service-fabric-cli/merges","archive_url":"https://api.github.com/repos/Azure/service-fabric-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/service-fabric-cli/downloads","issues_url":"https://api.github.com/repos/Azure/service-fabric-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/service-fabric-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/service-fabric-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/service-fabric-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/service-fabric-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/service-fabric-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/service-fabric-cli/deployments","created_at":"2017-06-16T22:30:58Z","updated_at":"2018-01-16T09:56:15Z","pushed_at":"2018-02-08T20:02:03Z","git_url":"git://github.com/Azure/service-fabric-cli.git","ssh_url":"git@github.com:Azure/service-fabric-cli.git","clone_url":"https://github.com/Azure/service-fabric-cli.git","svn_url":"https://github.com/Azure/service-fabric-cli","homepage":null,"size":137,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":19,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/64"},"html":{"href":"https://github.com/Azure/service-fabric-cli/pull/64"},"issue":{"href":"https://api.github.com/repos/Azure/service-fabric-cli/issues/64"},"comments":{"href":"https://api.github.com/repos/Azure/service-fabric-cli/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/service-fabric-cli/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/service-fabric-cli/statuses/523a473dec95244e7e80b59168311c057b15e3de"}},"author_association":"NONE"}}
{"actor":{"display_login":"Christina-Kang"}}