{"action":"created","comment":{"url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/comments/221521734","pull_request_review_id":160187416,"id":221521734,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTUyMTczNA==","diff_hunk":"@@ -113,26 +113,18 @@ build_grub_efi() {\n   fi\n \n   mkdir -p $grub_arm\n-  mkdir -p $grub_linux\n-\n-  # First build linux tools.\n+  # Build GRUB tools (grub-mkimage) and ARM modules in one step\n   ./autogen.sh\n-  ./configure --quiet CC=gcc --target=x86_64 --with-platform=efi --prefix=$grub_linux\n-  make --quiet\n-  make --quiet install\n-\n-  # Clean workspace.\n-  make --quiet clean\n-  make --quiet distclean\n-\n-  # Now build ARM modules.\n-  ./configure --host=$toolchain --with-platform=efi --prefix=$grub_arm \\\n-      CFLAGS=\"-Os -march=armv7-a\" CCASFLAGS=\"-march=armv7-a\" --disable-werror\n-  make --quiet\n-  make --quiet install\n-\n-  # Build grub.efi binary.\n-  $grub_linux/bin/grub-mkimage  -v -p /$efi_boot -o grub.efi --format=arm-efi \\\n+  ./configure --host=x86_64-linux-gnu TARGET_CC=${toolchain}\"-\"gcc \\\n+     TARGET_OBJCOPY=${toolchain}\"-\"objcopy \\\n+     TARGET_STRIP=${toolchain}\"-\"strip \\\n+     TARGET_NM=${toolchain}\"-\"nm \\\n+     TARGET_RANLIB=${toolchain}\"-\"ranlib \\\n+     --target=arm --with-platform=efi --exec-prefix=$grub_arm \\\n+     --prefix=$grub_arm\n+  make -j4","path":"bbb-convert-stage-5.sh","position":32,"original_position":32,"commit_id":"fcb184b0408f91594e5720db6454140e320db61b","original_commit_id":"fcb184b0408f91594e5720db6454140e320db61b","user":{"login":"apodogrocki","id":16663797,"node_id":"MDQ6VXNlcjE2NjYzNzk3","avatar_url":"https://avatars0.githubusercontent.com/u/16663797?v=4","gravatar_id":"","url":"https://api.github.com/users/apodogrocki","html_url":"https://github.com/apodogrocki","followers_url":"https://api.github.com/users/apodogrocki/followers","following_url":"https://api.github.com/users/apodogrocki/following{/other_user}","gists_url":"https://api.github.com/users/apodogrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/apodogrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apodogrocki/subscriptions","organizations_url":"https://api.github.com/users/apodogrocki/orgs","repos_url":"https://api.github.com/users/apodogrocki/repos","events_url":"https://api.github.com/users/apodogrocki/events{/privacy}","received_events_url":"https://api.github.com/users/apodogrocki/received_events","type":"User","site_admin":false},"body":"add --quiet to make & make install","created_at":"2018-10-01T08:04:57Z","updated_at":"2018-10-01T08:07:42Z","html_url":"https://github.com/mendersoftware/mender-conversion-tools/pull/7#discussion_r221521734","pull_request_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/comments/221521734"},"html":{"href":"https://github.com/mendersoftware/mender-conversion-tools/pull/7#discussion_r221521734"},"pull_request":{"href":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/7","id":216600961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NjAwOTYx","html_url":"https://github.com/mendersoftware/mender-conversion-tools/pull/7","diff_url":"https://github.com/mendersoftware/mender-conversion-tools/pull/7.diff","patch_url":"https://github.com/mendersoftware/mender-conversion-tools/pull/7.patch","issue_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/issues/7","number":7,"state":"open","locked":false,"title":"Build GRUB in one step","user":{"login":"DominikAdamski","id":13538317,"node_id":"MDQ6VXNlcjEzNTM4MzE3","avatar_url":"https://avatars2.githubusercontent.com/u/13538317?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikAdamski","html_url":"https://github.com/DominikAdamski","followers_url":"https://api.github.com/users/DominikAdamski/followers","following_url":"https://api.github.com/users/DominikAdamski/following{/other_user}","gists_url":"https://api.github.com/users/DominikAdamski/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikAdamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikAdamski/subscriptions","organizations_url":"https://api.github.com/users/DominikAdamski/orgs","repos_url":"https://api.github.com/users/DominikAdamski/repos","events_url":"https://api.github.com/users/DominikAdamski/events{/privacy}","received_events_url":"https://api.github.com/users/DominikAdamski/received_events","type":"User","site_admin":false},"body":"Earlier GRUB needs to be configured and built twice for ARM and x86\r\ntargets separately. Now only one build is necessary.\r\n\r\nSigned-off-by: Dominik Adamski <adamski.dominik@gmail.com>","created_at":"2018-09-19T11:12:40Z","updated_at":"2018-10-01T08:07:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"774a33562fb33c036a118b0ff3178de3548c19a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/7/commits","review_comments_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/7/comments","review_comment_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/issues/7/comments","statuses_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/statuses/fcb184b0408f91594e5720db6454140e320db61b","head":{"label":"DominikAdamski:GRUB_one_build","ref":"GRUB_one_build","sha":"fcb184b0408f91594e5720db6454140e320db61b","user":{"login":"DominikAdamski","id":13538317,"node_id":"MDQ6VXNlcjEzNTM4MzE3","avatar_url":"https://avatars2.githubusercontent.com/u/13538317?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikAdamski","html_url":"https://github.com/DominikAdamski","followers_url":"https://api.github.com/users/DominikAdamski/followers","following_url":"https://api.github.com/users/DominikAdamski/following{/other_user}","gists_url":"https://api.github.com/users/DominikAdamski/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikAdamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikAdamski/subscriptions","organizations_url":"https://api.github.com/users/DominikAdamski/orgs","repos_url":"https://api.github.com/users/DominikAdamski/repos","events_url":"https://api.github.com/users/DominikAdamski/events{/privacy}","received_events_url":"https://api.github.com/users/DominikAdamski/received_events","type":"User","site_admin":false},"repo":{"id":149434868,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0MzQ4Njg=","name":"mender-conversion-tools","full_name":"DominikAdamski/mender-conversion-tools","private":false,"owner":{"login":"DominikAdamski","id":13538317,"node_id":"MDQ6VXNlcjEzNTM4MzE3","avatar_url":"https://avatars2.githubusercontent.com/u/13538317?v=4","gravatar_id":"","url":"https://api.github.com/users/DominikAdamski","html_url":"https://github.com/DominikAdamski","followers_url":"https://api.github.com/users/DominikAdamski/followers","following_url":"https://api.github.com/users/DominikAdamski/following{/other_user}","gists_url":"https://api.github.com/users/DominikAdamski/gists{/gist_id}","starred_url":"https://api.github.com/users/DominikAdamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominikAdamski/subscriptions","organizations_url":"https://api.github.com/users/DominikAdamski/orgs","repos_url":"https://api.github.com/users/DominikAdamski/repos","events_url":"https://api.github.com/users/DominikAdamski/events{/privacy}","received_events_url":"https://api.github.com/users/DominikAdamski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DominikAdamski/mender-conversion-tools","description":null,"fork":true,"url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools","forks_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/forks","keys_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/teams","hooks_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/hooks","issue_events_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/issues/events{/number}","events_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/events","assignees_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/assignees{/user}","branches_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/branches{/branch}","tags_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/tags","blobs_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/languages","stargazers_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/stargazers","contributors_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/contributors","subscribers_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/subscribers","subscription_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/subscription","commits_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/contents/{+path}","compare_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/merges","archive_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/downloads","issues_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/issues{/number}","pulls_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/labels{/name}","releases_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/releases{/id}","deployments_url":"https://api.github.com/repos/DominikAdamski/mender-conversion-tools/deployments","created_at":"2018-09-19T10:40:50Z","updated_at":"2018-09-24T10:48:19Z","pushed_at":"2018-09-28T09:08:37Z","git_url":"git://github.com/DominikAdamski/mender-conversion-tools.git","ssh_url":"git@github.com:DominikAdamski/mender-conversion-tools.git","clone_url":"https://github.com/DominikAdamski/mender-conversion-tools.git","svn_url":"https://github.com/DominikAdamski/mender-conversion-tools","homepage":null,"size":46,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mendersoftware:master","ref":"master","sha":"c562c9f5805b5d073a875f2f1a3bdb9389dc2ae9","user":{"login":"mendersoftware","id":15040539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDQwNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/15040539?v=4","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":137469060,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0NjkwNjA=","name":"mender-conversion-tools","full_name":"mendersoftware/mender-conversion-tools","private":false,"owner":{"login":"mendersoftware","id":15040539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDQwNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/15040539?v=4","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mendersoftware/mender-conversion-tools","description":null,"fork":false,"url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools","forks_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/forks","keys_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/teams","hooks_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/hooks","issue_events_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/issues/events{/number}","events_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/events","assignees_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/assignees{/user}","branches_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/branches{/branch}","tags_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/tags","blobs_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/languages","stargazers_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/stargazers","contributors_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/contributors","subscribers_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/subscribers","subscription_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/subscription","commits_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/contents/{+path}","compare_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/merges","archive_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/downloads","issues_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/issues{/number}","pulls_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/labels{/name}","releases_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/releases{/id}","deployments_url":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/deployments","created_at":"2018-06-15T09:32:53Z","updated_at":"2018-09-26T20:36:03Z","pushed_at":"2018-09-28T09:14:32Z","git_url":"git://github.com/mendersoftware/mender-conversion-tools.git","ssh_url":"git@github.com:mendersoftware/mender-conversion-tools.git","clone_url":"https://github.com/mendersoftware/mender-conversion-tools.git","svn_url":"https://github.com/mendersoftware/mender-conversion-tools","homepage":null,"size":37,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/7"},"html":{"href":"https://github.com/mendersoftware/mender-conversion-tools/pull/7"},"issue":{"href":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/issues/7"},"comments":{"href":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/mendersoftware/mender-conversion-tools/statuses/fcb184b0408f91594e5720db6454140e320db61b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apodogrocki"}}