{"action":"created","issue":{"url":"https://api.github.com/repos/jbevain/cecil/issues/521","repository_url":"https://api.github.com/repos/jbevain/cecil","labels_url":"https://api.github.com/repos/jbevain/cecil/issues/521/labels{/name}","comments_url":"https://api.github.com/repos/jbevain/cecil/issues/521/comments","events_url":"https://api.github.com/repos/jbevain/cecil/issues/521/events","html_url":"https://github.com/jbevain/cecil/pull/521","id":328393833,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTQyNzg0","number":521,"title":"Fully qualified name for mscorlib was not properly serialized in attribute metadata","user":{"login":"xen2","id":527565,"node_id":"MDQ6VXNlcjUyNzU2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/527565?v=4","gravatar_id":"","url":"https://api.github.com/users/xen2","html_url":"https://github.com/xen2","followers_url":"https://api.github.com/users/xen2/followers","following_url":"https://api.github.com/users/xen2/following{/other_user}","gists_url":"https://api.github.com/users/xen2/gists{/gist_id}","starred_url":"https://api.github.com/users/xen2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xen2/subscriptions","organizations_url":"https://api.github.com/users/xen2/orgs","repos_url":"https://api.github.com/users/xen2/repos","events_url":"https://api.github.com/users/xen2/events{/privacy}","received_events_url":"https://api.github.com/users/xen2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-01T06:13:05Z","updated_at":"2018-06-02T00:07:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jbevain/cecil/pulls/521","html_url":"https://github.com/jbevain/cecil/pull/521","diff_url":"https://github.com/jbevain/cecil/pull/521.diff","patch_url":"https://github.com/jbevain/cecil/pull/521.patch"},"body":"Easy to verify:\r\n\r\nCompile a project with:\r\n```\r\nstruct Test\r\n{\r\n    public fixed char Name[24];\r\n}\r\n```\r\n\r\nIL gives this:\r\n```\r\n.field private valuetype Test/'<Name>e__FixedBuffer0' Name\r\n.custom instance void [mscorlib]System.Runtime.CompilerServices.FixedBufferAttribute::.ctor(class [mscorlib]System.Type, int32) = (\r\n\t01 00 58 53 79 73 74 65 6d 2e 43 68 61 72 2c 20\r\n\t6d 73 63 6f 72 6c 69 62 2c 20 56 65 72 73 69 6f\r\n\t6e 3d 32 2e 30 2e 30 2e 30 2c 20 43 75 6c 74 75\r\n\t72 65 3d 6e 65 75 74 72 61 6c 2c 20 50 75 62 6c\r\n\t69 63 4b 65 79 54 6f 6b 65 6e 3d 62 37 37 61 35\r\n\t63 35 36 31 39 33 34 65 30 38 39 1e 00 00 00 00 00\r\n)\r\n```\r\n\r\nThis hexadecimal string decoded is:\r\n`XSystem.Char, mscorlib, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089`\r\n\r\nHowever, Mono.Cecil saves it as unqualified (only `System.Char`) because it's mscorlib. Removing mscorlib fully qualified name still applies in all other cases when serializating, but shouldn't be used in this specific case."},"comment":{"url":"https://api.github.com/repos/jbevain/cecil/issues/comments/394039448","html_url":"https://github.com/jbevain/cecil/pull/521#issuecomment-394039448","issue_url":"https://api.github.com/repos/jbevain/cecil/issues/521","id":394039448,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDAzOTQ0OA==","user":{"login":"xen2","id":527565,"node_id":"MDQ6VXNlcjUyNzU2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/527565?v=4","gravatar_id":"","url":"https://api.github.com/users/xen2","html_url":"https://github.com/xen2","followers_url":"https://api.github.com/users/xen2/followers","following_url":"https://api.github.com/users/xen2/following{/other_user}","gists_url":"https://api.github.com/users/xen2/gists{/gist_id}","starred_url":"https://api.github.com/users/xen2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xen2/subscriptions","organizations_url":"https://api.github.com/users/xen2/orgs","repos_url":"https://api.github.com/users/xen2/repos","events_url":"https://api.github.com/users/xen2/events{/privacy}","received_events_url":"https://api.github.com/users/xen2/received_events","type":"User","site_admin":false},"created_at":"2018-06-02T00:07:30Z","updated_at":"2018-06-02T00:07:30Z","author_association":"CONTRIBUTOR","body":"Thanks! Since PDB/async is now working fine, this was the latest custom change we had.\r\nLooking forward to using nuget cecil soon, once new version is released."}}
{"actor":{"display_login":"xen2"}}