{"action":"created","issue":{"url":"https://api.github.com/repos/arquillian/ike-prow-plugins/issues/131","repository_url":"https://api.github.com/repos/arquillian/ike-prow-plugins","labels_url":"https://api.github.com/repos/arquillian/ike-prow-plugins/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/arquillian/ike-prow-plugins/issues/131/comments","events_url":"https://api.github.com/repos/arquillian/ike-prow-plugins/issues/131/events","html_url":"https://github.com/arquillian/ike-prow-plugins/issues/131","id":317515765,"number":131,"title":"Should we not skip PRs where the only files edited had \"test\" in their names or path","user":{"login":"rgarg1","id":28748448,"avatar_url":"https://avatars2.githubusercontent.com/u/28748448?v=4","gravatar_id":"","url":"https://api.github.com/users/rgarg1","html_url":"https://github.com/rgarg1","followers_url":"https://api.github.com/users/rgarg1/followers","following_url":"https://api.github.com/users/rgarg1/following{/other_user}","gists_url":"https://api.github.com/users/rgarg1/gists{/gist_id}","starred_url":"https://api.github.com/users/rgarg1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgarg1/subscriptions","organizations_url":"https://api.github.com/users/rgarg1/orgs","repos_url":"https://api.github.com/users/rgarg1/repos","events_url":"https://api.github.com/users/rgarg1/events{/privacy}","received_events_url":"https://api.github.com/users/rgarg1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-04-25T07:50:54Z","updated_at":"2018-04-25T11:49:19Z","closed_at":null,"author_association":"NONE","body":"Writing tests for tests would be an overkill. No?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/arquillian/ike-prow-plugins/issues/comments/384259071","html_url":"https://github.com/arquillian/ike-prow-plugins/issues/131#issuecomment-384259071","issue_url":"https://api.github.com/repos/arquillian/ike-prow-plugins/issues/131","id":384259071,"user":{"login":"MatousJobanek","id":1510709,"avatar_url":"https://avatars3.githubusercontent.com/u/1510709?v=4","gravatar_id":"","url":"https://api.github.com/users/MatousJobanek","html_url":"https://github.com/MatousJobanek","followers_url":"https://api.github.com/users/MatousJobanek/followers","following_url":"https://api.github.com/users/MatousJobanek/following{/other_user}","gists_url":"https://api.github.com/users/MatousJobanek/gists{/gist_id}","starred_url":"https://api.github.com/users/MatousJobanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatousJobanek/subscriptions","organizations_url":"https://api.github.com/users/MatousJobanek/orgs","repos_url":"https://api.github.com/users/MatousJobanek/repos","events_url":"https://api.github.com/users/MatousJobanek/events{/privacy}","received_events_url":"https://api.github.com/users/MatousJobanek/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T11:49:19Z","updated_at":"2018-04-25T11:49:19Z","author_association":"CONTRIBUTOR","body":"Hi guys, the `test` directory is a bit tricky. Let me try to explain it to you.\r\n\r\n@rgarg1 correct me if I'm wrong, your PR has failed (for the test-keeper plugin) because you have changed some test logic/additional validation file/custom assertion or anything like that, but not really a test file. Unfortunately, we are not able to build a dependency tree (which files are used by some specific test files as an additional logic), so we cannot validate the change on this level and detect that it is only test-related file. We can work only with the file names and file paths.\r\n\r\nAs for the `test` directory. We cannot expect that all files in any `**/test/**` directory contain only test-related logic and at the same time we cannot expect that all files in this type of directory are not related to the production. When we validate the files, we take the whole path from the root of the project, so with the fact that we support a bunch of programming languages, it can very easily happen that the path can contain some `test` subdirectory. Consider for example the [arquillian-core](https://github.com/arquillian/arquillian-core) project - it has a test module containing a production code.\r\n\r\nAs for the proposition to add the test directories to the exclusions - that will cause an additional problem. If a file is excluded then it means that it is removed completely from the validation process, which means that it cannot be detected as a test. In other words, if the whole directory `test` was excluded then no test in this directory would be detected and could cause more false positives in additional PRs.\r\n\r\nSumming this up:\r\nWe cannot add the proposed directories to the list of exclusions nor inclusions. \r\nThere are 3 possible solutions for you:\r\n1. Use for such a cases `/ok-without-tests` command\r\n2. You can add the whole directory to inclusions in your configuration file so will be applied only to your repository. As a side effect, all files in the directory will be considered as test files. \r\n3. You can try to find some pattern of file names that would include such test-related files but not any production related code and add it to your list of inclusions in your config file."}}
{"actor":{"display_login":"MatousJobanek"}}