{"action":"created","comment":{"url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/comments/234426597","pull_request_review_id":176073201,"id":234426597,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQyNjU5Nw==","diff_hunk":"@@ -43,42 +42,42 @@ class MessagePopup\n     {\n     }\n \n-public:\n+    ~MessagePopup() = default;\n+    MessagePopup(const MessagePopup&) = delete;\n+    MessagePopup(MessagePopup&&) = default;","path":"src/RA_AchievementPopup.h","position":22,"original_position":22,"commit_id":"8e33272c1c6b50fbc305554e1ada5014f8cd02c1","original_commit_id":"8e33272c1c6b50fbc305554e1ada5014f8cd02c1","user":{"login":"SyrianBallaS","id":18649925,"node_id":"MDQ6VXNlcjE4NjQ5OTI1","avatar_url":"https://avatars2.githubusercontent.com/u/18649925?v=4","gravatar_id":"","url":"https://api.github.com/users/SyrianBallaS","html_url":"https://github.com/SyrianBallaS","followers_url":"https://api.github.com/users/SyrianBallaS/followers","following_url":"https://api.github.com/users/SyrianBallaS/following{/other_user}","gists_url":"https://api.github.com/users/SyrianBallaS/gists{/gist_id}","starred_url":"https://api.github.com/users/SyrianBallaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyrianBallaS/subscriptions","organizations_url":"https://api.github.com/users/SyrianBallaS/orgs","repos_url":"https://api.github.com/users/SyrianBallaS/repos","events_url":"https://api.github.com/users/SyrianBallaS/events{/privacy}","received_events_url":"https://api.github.com/users/SyrianBallaS/received_events","type":"User","site_admin":false},"body":"This one should be `noexcept`. I think you should `delete` the copy assignment since copying is deleting and the move assignment operator since all members are `const`.","created_at":"2018-11-18T01:40:11Z","updated_at":"2018-11-18T01:47:43Z","html_url":"https://github.com/RetroAchievements/RAIntegration/pull/194#discussion_r234426597","pull_request_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/194","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/comments/234426597"},"html":{"href":"https://github.com/RetroAchievements/RAIntegration/pull/194#discussion_r234426597"},"pull_request":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/194","id":231397123,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzk3MTIz","html_url":"https://github.com/RetroAchievements/RAIntegration/pull/194","diff_url":"https://github.com/RetroAchievements/RAIntegration/pull/194.diff","patch_url":"https://github.com/RetroAchievements/RAIntegration/pull/194.patch","issue_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/194","number":194,"state":"open","locked":false,"title":"Support offscreen rendering and alpha blending","user":{"login":"Jamiras","id":32680403,"node_id":"MDQ6VXNlcjMyNjgwNDAz","avatar_url":"https://avatars1.githubusercontent.com/u/32680403?v=4","gravatar_id":"","url":"https://api.github.com/users/Jamiras","html_url":"https://github.com/Jamiras","followers_url":"https://api.github.com/users/Jamiras/followers","following_url":"https://api.github.com/users/Jamiras/following{/other_user}","gists_url":"https://api.github.com/users/Jamiras/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamiras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamiras/subscriptions","organizations_url":"https://api.github.com/users/Jamiras/orgs","repos_url":"https://api.github.com/users/Jamiras/repos","events_url":"https://api.github.com/users/Jamiras/events{/privacy}","received_events_url":"https://api.github.com/users/Jamiras/received_events","type":"User","site_admin":false},"body":"* Add offscreen surface and offscreen surface with alpha channel (GDI doesn't implicitly support alpha channel)\r\n* Add factory for generating offscreen surfaces\r\n* Render popup to offscreen surface (with alpha)\r\n* Draw pre-rendered popup to screen during display pass.\r\n\r\nOpacity is currently set to 85%:\r\n![image](https://user-images.githubusercontent.com/32680403/48594103-b461fc80-e90c-11e8-815b-e5d4c75d210a.png)\r\n","created_at":"2018-11-16T02:30:09Z","updated_at":"2018-11-18T01:47:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f144c12a7b4572d8ce4194f121ae4c0e2a96fd6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/194/commits","review_comments_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/194/comments","review_comment_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/194/comments","statuses_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/statuses/8e33272c1c6b50fbc305554e1ada5014f8cd02c1","head":{"label":"Jamiras:ui_bitmap","ref":"ui_bitmap","sha":"8e33272c1c6b50fbc305554e1ada5014f8cd02c1","user":{"login":"Jamiras","id":32680403,"node_id":"MDQ6VXNlcjMyNjgwNDAz","avatar_url":"https://avatars1.githubusercontent.com/u/32680403?v=4","gravatar_id":"","url":"https://api.github.com/users/Jamiras","html_url":"https://github.com/Jamiras","followers_url":"https://api.github.com/users/Jamiras/followers","following_url":"https://api.github.com/users/Jamiras/following{/other_user}","gists_url":"https://api.github.com/users/Jamiras/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamiras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamiras/subscriptions","organizations_url":"https://api.github.com/users/Jamiras/orgs","repos_url":"https://api.github.com/users/Jamiras/repos","events_url":"https://api.github.com/users/Jamiras/events{/privacy}","received_events_url":"https://api.github.com/users/Jamiras/received_events","type":"User","site_admin":false},"repo":{"id":145124477,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxMjQ0Nzc=","name":"RAIntegration","full_name":"Jamiras/RAIntegration","private":false,"owner":{"login":"Jamiras","id":32680403,"node_id":"MDQ6VXNlcjMyNjgwNDAz","avatar_url":"https://avatars1.githubusercontent.com/u/32680403?v=4","gravatar_id":"","url":"https://api.github.com/users/Jamiras","html_url":"https://github.com/Jamiras","followers_url":"https://api.github.com/users/Jamiras/followers","following_url":"https://api.github.com/users/Jamiras/following{/other_user}","gists_url":"https://api.github.com/users/Jamiras/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamiras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamiras/subscriptions","organizations_url":"https://api.github.com/users/Jamiras/orgs","repos_url":"https://api.github.com/users/Jamiras/repos","events_url":"https://api.github.com/users/Jamiras/events{/privacy}","received_events_url":"https://api.github.com/users/Jamiras/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Jamiras/RAIntegration","description":"The DLL responsible to integrate emulators with RetroAchievements.org","fork":true,"url":"https://api.github.com/repos/Jamiras/RAIntegration","forks_url":"https://api.github.com/repos/Jamiras/RAIntegration/forks","keys_url":"https://api.github.com/repos/Jamiras/RAIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jamiras/RAIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jamiras/RAIntegration/teams","hooks_url":"https://api.github.com/repos/Jamiras/RAIntegration/hooks","issue_events_url":"https://api.github.com/repos/Jamiras/RAIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/Jamiras/RAIntegration/events","assignees_url":"https://api.github.com/repos/Jamiras/RAIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/Jamiras/RAIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/Jamiras/RAIntegration/tags","blobs_url":"https://api.github.com/repos/Jamiras/RAIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jamiras/RAIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jamiras/RAIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jamiras/RAIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jamiras/RAIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/Jamiras/RAIntegration/languages","stargazers_url":"https://api.github.com/repos/Jamiras/RAIntegration/stargazers","contributors_url":"https://api.github.com/repos/Jamiras/RAIntegration/contributors","subscribers_url":"https://api.github.com/repos/Jamiras/RAIntegration/subscribers","subscription_url":"https://api.github.com/repos/Jamiras/RAIntegration/subscription","commits_url":"https://api.github.com/repos/Jamiras/RAIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jamiras/RAIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jamiras/RAIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jamiras/RAIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jamiras/RAIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/Jamiras/RAIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jamiras/RAIntegration/merges","archive_url":"https://api.github.com/repos/Jamiras/RAIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jamiras/RAIntegration/downloads","issues_url":"https://api.github.com/repos/Jamiras/RAIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/Jamiras/RAIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/Jamiras/RAIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/Jamiras/RAIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jamiras/RAIntegration/labels{/name}","releases_url":"https://api.github.com/repos/Jamiras/RAIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/Jamiras/RAIntegration/deployments","created_at":"2018-08-17T13:34:57Z","updated_at":"2018-11-17T14:06:21Z","pushed_at":"2018-11-17T14:30:42Z","git_url":"git://github.com/Jamiras/RAIntegration.git","ssh_url":"git@github.com:Jamiras/RAIntegration.git","clone_url":"https://github.com/Jamiras/RAIntegration.git","svn_url":"https://github.com/Jamiras/RAIntegration","homepage":"http://retroachievements.org","size":3212,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RetroAchievements:master","ref":"master","sha":"b9f4273a2af0e44ee6ff76d5525967da79fcdfb7","user":{"login":"RetroAchievements","id":5411318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTEzMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5411318?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroAchievements","html_url":"https://github.com/RetroAchievements","followers_url":"https://api.github.com/users/RetroAchievements/followers","following_url":"https://api.github.com/users/RetroAchievements/following{/other_user}","gists_url":"https://api.github.com/users/RetroAchievements/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroAchievements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroAchievements/subscriptions","organizations_url":"https://api.github.com/users/RetroAchievements/orgs","repos_url":"https://api.github.com/users/RetroAchievements/repos","events_url":"https://api.github.com/users/RetroAchievements/events{/privacy}","received_events_url":"https://api.github.com/users/RetroAchievements/received_events","type":"Organization","site_admin":false},"repo":{"id":129603848,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk2MDM4NDg=","name":"RAIntegration","full_name":"RetroAchievements/RAIntegration","private":false,"owner":{"login":"RetroAchievements","id":5411318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTEzMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5411318?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroAchievements","html_url":"https://github.com/RetroAchievements","followers_url":"https://api.github.com/users/RetroAchievements/followers","following_url":"https://api.github.com/users/RetroAchievements/following{/other_user}","gists_url":"https://api.github.com/users/RetroAchievements/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroAchievements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroAchievements/subscriptions","organizations_url":"https://api.github.com/users/RetroAchievements/orgs","repos_url":"https://api.github.com/users/RetroAchievements/repos","events_url":"https://api.github.com/users/RetroAchievements/events{/privacy}","received_events_url":"https://api.github.com/users/RetroAchievements/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RetroAchievements/RAIntegration","description":"The DLL responsible to integrate emulators with RetroAchievements.org","fork":false,"url":"https://api.github.com/repos/RetroAchievements/RAIntegration","forks_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/forks","keys_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/teams","hooks_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/hooks","issue_events_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/events","assignees_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/tags","blobs_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/languages","stargazers_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/stargazers","contributors_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/contributors","subscribers_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/subscribers","subscription_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/subscription","commits_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/merges","archive_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/downloads","issues_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/labels{/name}","releases_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/deployments","created_at":"2018-04-15T11:33:17Z","updated_at":"2018-11-17T14:03:29Z","pushed_at":"2018-11-18T00:42:25Z","git_url":"git://github.com/RetroAchievements/RAIntegration.git","ssh_url":"git@github.com:RetroAchievements/RAIntegration.git","clone_url":"https://github.com/RetroAchievements/RAIntegration.git","svn_url":"https://github.com/RetroAchievements/RAIntegration","homepage":"http://retroachievements.org","size":3142,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":60,"license":null,"forks":5,"open_issues":60,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/194"},"html":{"href":"https://github.com/RetroAchievements/RAIntegration/pull/194"},"issue":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/194"},"comments":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/statuses/8e33272c1c6b50fbc305554e1ada5014f8cd02c1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"SyrianBallaS"}}