{"action":"created","issue":{"url":"https://api.github.com/repos/alibaba/pouch/issues/2109","repository_url":"https://api.github.com/repos/alibaba/pouch","labels_url":"https://api.github.com/repos/alibaba/pouch/issues/2109/labels{/name}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/2109/comments","events_url":"https://api.github.com/repos/alibaba/pouch/issues/2109/events","html_url":"https://github.com/alibaba/pouch/pull/2109","id":351441968,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDM1MTY1","number":2109,"title":"bugfix: return error when remove/stop containers of sandbox failed","user":{"login":"YaoZengzeng","id":8636562,"node_id":"MDQ6VXNlcjg2MzY1NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8636562?v=4","gravatar_id":"","url":"https://api.github.com/users/YaoZengzeng","html_url":"https://github.com/YaoZengzeng","followers_url":"https://api.github.com/users/YaoZengzeng/followers","following_url":"https://api.github.com/users/YaoZengzeng/following{/other_user}","gists_url":"https://api.github.com/users/YaoZengzeng/gists{/gist_id}","starred_url":"https://api.github.com/users/YaoZengzeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaoZengzeng/subscriptions","organizations_url":"https://api.github.com/users/YaoZengzeng/orgs","repos_url":"https://api.github.com/users/YaoZengzeng/repos","events_url":"https://api.github.com/users/YaoZengzeng/events{/privacy}","received_events_url":"https://api.github.com/users/YaoZengzeng/received_events","type":"User","site_admin":false},"labels":[{"id":684575943,"node_id":"MDU6TGFiZWw2ODQ1NzU5NDM=","url":"https://api.github.com/repos/alibaba/pouch/labels/kind/bug","name":"kind/bug","color":"f77e56","default":false},{"id":729585786,"node_id":"MDU6TGFiZWw3Mjk1ODU3ODY=","url":"https://api.github.com/repos/alibaba/pouch/labels/size/XS","name":"size/XS","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"Starnop","id":31209634,"node_id":"MDQ6VXNlcjMxMjA5NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/31209634?v=4","gravatar_id":"","url":"https://api.github.com/users/Starnop","html_url":"https://github.com/Starnop","followers_url":"https://api.github.com/users/Starnop/followers","following_url":"https://api.github.com/users/Starnop/following{/other_user}","gists_url":"https://api.github.com/users/Starnop/gists{/gist_id}","starred_url":"https://api.github.com/users/Starnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starnop/subscriptions","organizations_url":"https://api.github.com/users/Starnop/orgs","repos_url":"https://api.github.com/users/Starnop/repos","events_url":"https://api.github.com/users/Starnop/events{/privacy}","received_events_url":"https://api.github.com/users/Starnop/received_events","type":"User","site_admin":false},"assignees":[{"login":"Starnop","id":31209634,"node_id":"MDQ6VXNlcjMxMjA5NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/31209634?v=4","gravatar_id":"","url":"https://api.github.com/users/Starnop","html_url":"https://github.com/Starnop","followers_url":"https://api.github.com/users/Starnop/followers","following_url":"https://api.github.com/users/Starnop/following{/other_user}","gists_url":"https://api.github.com/users/Starnop/gists{/gist_id}","starred_url":"https://api.github.com/users/Starnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starnop/subscriptions","organizations_url":"https://api.github.com/users/Starnop/orgs","repos_url":"https://api.github.com/users/Starnop/repos","events_url":"https://api.github.com/users/Starnop/events{/privacy}","received_events_url":"https://api.github.com/users/Starnop/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-17T03:10:37Z","updated_at":"2018-08-17T03:55:47Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/2109","html_url":"https://github.com/alibaba/pouch/pull/2109","diff_url":"https://github.com/alibaba/pouch/pull/2109.diff","patch_url":"https://github.com/alibaba/pouch/pull/2109.patch"},"body":"Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>\r\n\r\n<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\n\r\nWhen stop/remove the sandbox, we should stop/remove the containers of the sandbox as well.\r\n\r\nHowever if we failed to stop/remove the containers, we should report the error to kubelet.\r\n\r\nOtherwise if the sandbox is removed successfully and the containers are failed to be removed,\r\n\r\nthe containers will be left and never be cleaned.\r\n\r\n\r\n\r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\n<!--If that, add \"fixes #xxxx\" below in the next line, for example, fixes #15. Otherwise, add \"NONE\" -->\r\n\r\n\r\n### Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)\r\n\r\n\r\n\r\n### Ⅳ. Describe how to verify it\r\n\r\n\r\n### Ⅴ. Special notes for reviews\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/alibaba/pouch/issues/comments/413750600","html_url":"https://github.com/alibaba/pouch/pull/2109#issuecomment-413750600","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/2109","id":413750600,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzc1MDYwMA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T03:55:47Z","updated_at":"2018-08-17T03:55:47Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/alibaba/pouch/pull/2109?src=pr&el=h1) Report\n> Merging [#2109](https://codecov.io/gh/alibaba/pouch/pull/2109?src=pr&el=desc) into [master](https://codecov.io/gh/alibaba/pouch/commit/bbbfc63900cc58c6b231c9dc4596cedad2dbc14b?src=pr&el=desc) will **increase** coverage by `0.02%`.\n> The diff coverage is `75%`.\n\n\n[![Impacted file tree graph](https://codecov.io/gh/alibaba/pouch/pull/2109/graphs/tree.svg?width=650&src=pr&token=AABQWPigYE&height=150)](https://codecov.io/gh/alibaba/pouch/pull/2109?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #2109      +/-   ##\n==========================================\n+ Coverage   65.11%   65.13%   +0.02%     \n==========================================\n  Files         208      208              \n  Lines       16409    16413       +4     \n==========================================\n+ Hits        10685    10691       +6     \n- Misses       4393     4395       +2     \n+ Partials     1331     1327       -4\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #criv1alpha1test | `33.34% <50%> (+0.12%)` | :arrow_up: |\n| #criv1alpha2test | `33.86% <25%> (-0.03%)` | :arrow_down: |\n| #integrationtest | `39.82% <0%> (-0.05%)` | :arrow_down: |\n| #unittest | `23.86% <0%> (-0.01%)` | :arrow_down: |\n\n| [Impacted Files](https://codecov.io/gh/alibaba/pouch/pull/2109?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [cri/v1alpha1/cri.go](https://codecov.io/gh/alibaba/pouch/pull/2109/diff?src=pr&el=tree#diff-Y3JpL3YxYWxwaGExL2NyaS5nbw==) | `64.13% <100%> (+0.29%)` | :arrow_up: |\n| [cri/v1alpha2/cri.go](https://codecov.io/gh/alibaba/pouch/pull/2109/diff?src=pr&el=tree#diff-Y3JpL3YxYWxwaGEyL2NyaS5nbw==) | `64.63% <50%> (-0.05%)` | :arrow_down: |\n| [ctrd/image.go](https://codecov.io/gh/alibaba/pouch/pull/2109/diff?src=pr&el=tree#diff-Y3RyZC9pbWFnZS5nbw==) | `75% <0%> (-2.2%)` | :arrow_down: |\n| [daemon/mgr/container.go](https://codecov.io/gh/alibaba/pouch/pull/2109/diff?src=pr&el=tree#diff-ZGFlbW9uL21nci9jb250YWluZXIuZ28=) | `56.5% <0%> (+0.4%)` | :arrow_up: |\n| [ctrd/watch.go](https://codecov.io/gh/alibaba/pouch/pull/2109/diff?src=pr&el=tree#diff-Y3RyZC93YXRjaC5nbw==) | `80.3% <0%> (+4.54%)` | :arrow_up: |\n"}}
{"actor":{"display_login":"codecov-io"}}