{"action":"created","comment":{"url":"https://api.github.com/repos/angular-klingon/klingon/pulls/comments/234640194","pull_request_review_id":176323405,"id":234640194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDY0MDE5NA==","diff_hunk":"@@ -100,6 +100,10 @@ export class TerminalService {\n     return this.cli.runNgCommand(data);\n   }\n \n+  command(data) {","path":"packages/klingon-ui/src/app/_shared/terminal/terminal.service.ts","position":15,"original_position":15,"commit_id":"5b63d463aa71eaf7aaac0fc4578d32a5d1a8ccdc","original_commit_id":"5b63d463aa71eaf7aaac0fc4578d32a5d1a8ccdc","user":{"login":"sumitparakh","id":4236211,"node_id":"MDQ6VXNlcjQyMzYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/4236211?v=4","gravatar_id":"","url":"https://api.github.com/users/sumitparakh","html_url":"https://github.com/sumitparakh","followers_url":"https://api.github.com/users/sumitparakh/followers","following_url":"https://api.github.com/users/sumitparakh/following{/other_user}","gists_url":"https://api.github.com/users/sumitparakh/gists{/gist_id}","starred_url":"https://api.github.com/users/sumitparakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumitparakh/subscriptions","organizations_url":"https://api.github.com/users/sumitparakh/orgs","repos_url":"https://api.github.com/users/sumitparakh/repos","events_url":"https://api.github.com/users/sumitparakh/events{/privacy}","received_events_url":"https://api.github.com/users/sumitparakh/received_events","type":"User","site_admin":false},"body":"I think server side validation would be better. We can allow only certain commands from server side. So, no matter what commands user run from client, server will run only allowed ones. @manekinekko ","created_at":"2018-11-19T14:34:29Z","updated_at":"2018-11-19T14:34:29Z","html_url":"https://github.com/angular-klingon/klingon/pull/71#discussion_r234640194","pull_request_url":"https://api.github.com/repos/angular-klingon/klingon/pulls/71","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/angular-klingon/klingon/pulls/comments/234640194"},"html":{"href":"https://github.com/angular-klingon/klingon/pull/71#discussion_r234640194"},"pull_request":{"href":"https://api.github.com/repos/angular-klingon/klingon/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/angular-klingon/klingon/pulls/71","id":231743229,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzQzMjI5","html_url":"https://github.com/angular-klingon/klingon/pull/71","diff_url":"https://github.com/angular-klingon/klingon/pull/71.diff","patch_url":"https://github.com/angular-klingon/klingon/pull/71.patch","issue_url":"https://api.github.com/repos/angular-klingon/klingon/issues/71","number":71,"state":"open","locked":false,"title":"feat: change shell/console path to newly created angular project path","user":{"login":"sumitparakh","id":4236211,"node_id":"MDQ6VXNlcjQyMzYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/4236211?v=4","gravatar_id":"","url":"https://api.github.com/users/sumitparakh","html_url":"https://github.com/sumitparakh","followers_url":"https://api.github.com/users/sumitparakh/followers","following_url":"https://api.github.com/users/sumitparakh/following{/other_user}","gists_url":"https://api.github.com/users/sumitparakh/gists{/gist_id}","starred_url":"https://api.github.com/users/sumitparakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumitparakh/subscriptions","organizations_url":"https://api.github.com/users/sumitparakh/orgs","repos_url":"https://api.github.com/users/sumitparakh/repos","events_url":"https://api.github.com/users/sumitparakh/events{/privacy}","received_events_url":"https://api.github.com/users/sumitparakh/received_events","type":"User","site_admin":false},"body":"once a new project is created, shell will prompt to the working directory of that project\r\n\r\nFixes #69","created_at":"2018-11-17T18:28:43Z","updated_at":"2018-11-19T14:34:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d98150d47e16e8e11dee8376fe94d2eb66e3f06f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"manekinekko","id":1699357,"node_id":"MDQ6VXNlcjE2OTkzNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1699357?v=4","gravatar_id":"","url":"https://api.github.com/users/manekinekko","html_url":"https://github.com/manekinekko","followers_url":"https://api.github.com/users/manekinekko/followers","following_url":"https://api.github.com/users/manekinekko/following{/other_user}","gists_url":"https://api.github.com/users/manekinekko/gists{/gist_id}","starred_url":"https://api.github.com/users/manekinekko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manekinekko/subscriptions","organizations_url":"https://api.github.com/users/manekinekko/orgs","repos_url":"https://api.github.com/users/manekinekko/repos","events_url":"https://api.github.com/users/manekinekko/events{/privacy}","received_events_url":"https://api.github.com/users/manekinekko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":687721676,"node_id":"MDU6TGFiZWw2ODc3MjE2NzY=","url":"https://api.github.com/repos/angular-klingon/klingon/labels/PR%20action:%20discuss","name":"PR action: discuss","color":"FFCC80","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular-klingon/klingon/pulls/71/commits","review_comments_url":"https://api.github.com/repos/angular-klingon/klingon/pulls/71/comments","review_comment_url":"https://api.github.com/repos/angular-klingon/klingon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-klingon/klingon/issues/71/comments","statuses_url":"https://api.github.com/repos/angular-klingon/klingon/statuses/5b63d463aa71eaf7aaac0fc4578d32a5d1a8ccdc","head":{"label":"sumitparakh:issue69","ref":"issue69","sha":"5b63d463aa71eaf7aaac0fc4578d32a5d1a8ccdc","user":{"login":"sumitparakh","id":4236211,"node_id":"MDQ6VXNlcjQyMzYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/4236211?v=4","gravatar_id":"","url":"https://api.github.com/users/sumitparakh","html_url":"https://github.com/sumitparakh","followers_url":"https://api.github.com/users/sumitparakh/followers","following_url":"https://api.github.com/users/sumitparakh/following{/other_user}","gists_url":"https://api.github.com/users/sumitparakh/gists{/gist_id}","starred_url":"https://api.github.com/users/sumitparakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumitparakh/subscriptions","organizations_url":"https://api.github.com/users/sumitparakh/orgs","repos_url":"https://api.github.com/users/sumitparakh/repos","events_url":"https://api.github.com/users/sumitparakh/events{/privacy}","received_events_url":"https://api.github.com/users/sumitparakh/received_events","type":"User","site_admin":false},"repo":{"id":146930405,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5MzA0MDU=","name":"klingon","full_name":"sumitparakh/klingon","private":false,"owner":{"login":"sumitparakh","id":4236211,"node_id":"MDQ6VXNlcjQyMzYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/4236211?v=4","gravatar_id":"","url":"https://api.github.com/users/sumitparakh","html_url":"https://github.com/sumitparakh","followers_url":"https://api.github.com/users/sumitparakh/followers","following_url":"https://api.github.com/users/sumitparakh/following{/other_user}","gists_url":"https://api.github.com/users/sumitparakh/gists{/gist_id}","starred_url":"https://api.github.com/users/sumitparakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumitparakh/subscriptions","organizations_url":"https://api.github.com/users/sumitparakh/orgs","repos_url":"https://api.github.com/users/sumitparakh/repos","events_url":"https://api.github.com/users/sumitparakh/events{/privacy}","received_events_url":"https://api.github.com/users/sumitparakh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sumitparakh/klingon","description":"Angular Klingon: The UI companion for the @angular/cli","fork":true,"url":"https://api.github.com/repos/sumitparakh/klingon","forks_url":"https://api.github.com/repos/sumitparakh/klingon/forks","keys_url":"https://api.github.com/repos/sumitparakh/klingon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumitparakh/klingon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumitparakh/klingon/teams","hooks_url":"https://api.github.com/repos/sumitparakh/klingon/hooks","issue_events_url":"https://api.github.com/repos/sumitparakh/klingon/issues/events{/number}","events_url":"https://api.github.com/repos/sumitparakh/klingon/events","assignees_url":"https://api.github.com/repos/sumitparakh/klingon/assignees{/user}","branches_url":"https://api.github.com/repos/sumitparakh/klingon/branches{/branch}","tags_url":"https://api.github.com/repos/sumitparakh/klingon/tags","blobs_url":"https://api.github.com/repos/sumitparakh/klingon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumitparakh/klingon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumitparakh/klingon/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumitparakh/klingon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumitparakh/klingon/statuses/{sha}","languages_url":"https://api.github.com/repos/sumitparakh/klingon/languages","stargazers_url":"https://api.github.com/repos/sumitparakh/klingon/stargazers","contributors_url":"https://api.github.com/repos/sumitparakh/klingon/contributors","subscribers_url":"https://api.github.com/repos/sumitparakh/klingon/subscribers","subscription_url":"https://api.github.com/repos/sumitparakh/klingon/subscription","commits_url":"https://api.github.com/repos/sumitparakh/klingon/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumitparakh/klingon/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumitparakh/klingon/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumitparakh/klingon/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumitparakh/klingon/contents/{+path}","compare_url":"https://api.github.com/repos/sumitparakh/klingon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumitparakh/klingon/merges","archive_url":"https://api.github.com/repos/sumitparakh/klingon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumitparakh/klingon/downloads","issues_url":"https://api.github.com/repos/sumitparakh/klingon/issues{/number}","pulls_url":"https://api.github.com/repos/sumitparakh/klingon/pulls{/number}","milestones_url":"https://api.github.com/repos/sumitparakh/klingon/milestones{/number}","notifications_url":"https://api.github.com/repos/sumitparakh/klingon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumitparakh/klingon/labels{/name}","releases_url":"https://api.github.com/repos/sumitparakh/klingon/releases{/id}","deployments_url":"https://api.github.com/repos/sumitparakh/klingon/deployments","created_at":"2018-08-31T18:42:37Z","updated_at":"2018-11-17T19:26:12Z","pushed_at":"2018-11-19T14:24:51Z","git_url":"git://github.com/sumitparakh/klingon.git","ssh_url":"git@github.com:sumitparakh/klingon.git","clone_url":"https://github.com/sumitparakh/klingon.git","svn_url":"https://github.com/sumitparakh/klingon","homepage":"https://angular.run","size":3692,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-klingon:master","ref":"master","sha":"af9940663990d12ffae0a060b5bcdddfe6c91e95","user":{"login":"angular-klingon","id":42866281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyODY2Mjgx","avatar_url":"https://avatars3.githubusercontent.com/u/42866281?v=4","gravatar_id":"","url":"https://api.github.com/users/angular-klingon","html_url":"https://github.com/angular-klingon","followers_url":"https://api.github.com/users/angular-klingon/followers","following_url":"https://api.github.com/users/angular-klingon/following{/other_user}","gists_url":"https://api.github.com/users/angular-klingon/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-klingon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-klingon/subscriptions","organizations_url":"https://api.github.com/users/angular-klingon/orgs","repos_url":"https://api.github.com/users/angular-klingon/repos","events_url":"https://api.github.com/users/angular-klingon/events{/privacy}","received_events_url":"https://api.github.com/users/angular-klingon/received_events","type":"Organization","site_admin":false},"repo":{"id":98092403,"node_id":"MDEwOlJlcG9zaXRvcnk5ODA5MjQwMw==","name":"klingon","full_name":"angular-klingon/klingon","private":false,"owner":{"login":"angular-klingon","id":42866281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyODY2Mjgx","avatar_url":"https://avatars3.githubusercontent.com/u/42866281?v=4","gravatar_id":"","url":"https://api.github.com/users/angular-klingon","html_url":"https://github.com/angular-klingon","followers_url":"https://api.github.com/users/angular-klingon/followers","following_url":"https://api.github.com/users/angular-klingon/following{/other_user}","gists_url":"https://api.github.com/users/angular-klingon/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-klingon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-klingon/subscriptions","organizations_url":"https://api.github.com/users/angular-klingon/orgs","repos_url":"https://api.github.com/users/angular-klingon/repos","events_url":"https://api.github.com/users/angular-klingon/events{/privacy}","received_events_url":"https://api.github.com/users/angular-klingon/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular-klingon/klingon","description":"Angular Klingon: The UI companion for the @angular/cli","fork":false,"url":"https://api.github.com/repos/angular-klingon/klingon","forks_url":"https://api.github.com/repos/angular-klingon/klingon/forks","keys_url":"https://api.github.com/repos/angular-klingon/klingon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-klingon/klingon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-klingon/klingon/teams","hooks_url":"https://api.github.com/repos/angular-klingon/klingon/hooks","issue_events_url":"https://api.github.com/repos/angular-klingon/klingon/issues/events{/number}","events_url":"https://api.github.com/repos/angular-klingon/klingon/events","assignees_url":"https://api.github.com/repos/angular-klingon/klingon/assignees{/user}","branches_url":"https://api.github.com/repos/angular-klingon/klingon/branches{/branch}","tags_url":"https://api.github.com/repos/angular-klingon/klingon/tags","blobs_url":"https://api.github.com/repos/angular-klingon/klingon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-klingon/klingon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-klingon/klingon/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-klingon/klingon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-klingon/klingon/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-klingon/klingon/languages","stargazers_url":"https://api.github.com/repos/angular-klingon/klingon/stargazers","contributors_url":"https://api.github.com/repos/angular-klingon/klingon/contributors","subscribers_url":"https://api.github.com/repos/angular-klingon/klingon/subscribers","subscription_url":"https://api.github.com/repos/angular-klingon/klingon/subscription","commits_url":"https://api.github.com/repos/angular-klingon/klingon/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-klingon/klingon/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-klingon/klingon/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-klingon/klingon/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-klingon/klingon/contents/{+path}","compare_url":"https://api.github.com/repos/angular-klingon/klingon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-klingon/klingon/merges","archive_url":"https://api.github.com/repos/angular-klingon/klingon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-klingon/klingon/downloads","issues_url":"https://api.github.com/repos/angular-klingon/klingon/issues{/number}","pulls_url":"https://api.github.com/repos/angular-klingon/klingon/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-klingon/klingon/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-klingon/klingon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-klingon/klingon/labels{/name}","releases_url":"https://api.github.com/repos/angular-klingon/klingon/releases{/id}","deployments_url":"https://api.github.com/repos/angular-klingon/klingon/deployments","created_at":"2017-07-23T11:08:46Z","updated_at":"2018-11-18T13:46:52Z","pushed_at":"2018-11-19T14:24:52Z","git_url":"git://github.com/angular-klingon/klingon.git","ssh_url":"git@github.com:angular-klingon/klingon.git","clone_url":"https://github.com/angular-klingon/klingon.git","svn_url":"https://github.com/angular-klingon/klingon","homepage":"https://angular.run","size":3659,"stargazers_count":178,"watchers_count":178,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":18,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-klingon/klingon/pulls/71"},"html":{"href":"https://github.com/angular-klingon/klingon/pull/71"},"issue":{"href":"https://api.github.com/repos/angular-klingon/klingon/issues/71"},"comments":{"href":"https://api.github.com/repos/angular-klingon/klingon/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-klingon/klingon/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-klingon/klingon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-klingon/klingon/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/angular-klingon/klingon/statuses/5b63d463aa71eaf7aaac0fc4578d32a5d1a8ccdc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sumitparakh"}}