{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/3124","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/3124/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/3124/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/3124/events","html_url":"https://github.com/triplea-game/triplea/pull/3124","id":299908367,"number":3124,"title":"Remove outdated TODOs and associated unused code","user":{"login":"ssoloff","id":4826349,"avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-24T03:46:21Z","updated_at":"2018-02-24T03:53:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/3124","html_url":"https://github.com/triplea-game/triplea/pull/3124","diff_url":"https://github.com/triplea-game/triplea/pull/3124.diff","patch_url":"https://github.com/triplea-game/triplea/pull/3124.patch"},"body":"These TODOs were added in 06dc3f2 (2013).  They haven't been addressed in almost five years and are unlikely to be on anybody's radar."},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/368197133","html_url":"https://github.com/triplea-game/triplea/pull/3124#issuecomment-368197133","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/3124","id":368197133,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-02-24T03:53:11Z","updated_at":"2018-02-24T03:53:11Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/3124?src=pr&el=h1) Report\n> Merging [#3124](https://codecov.io/gh/triplea-game/triplea/pull/3124?src=pr&el=desc) into [master](https://codecov.io/gh/triplea-game/triplea/commit/bb16778962a950a43bde65e844c25c790e5cfdad?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/triplea-game/triplea/pull/3124/graphs/tree.svg?height=150&width=650&token=QPS14q4xnG&src=pr)](https://codecov.io/gh/triplea-game/triplea/pull/3124?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #3124      +/-   ##\n============================================\n- Coverage     21.33%   21.33%   -0.01%     \n+ Complexity     5863     5862       -1     \n============================================\n  Files           822      822              \n  Lines         73284    73281       -3     \n  Branches      11947    11947              \n============================================\n- Hits          15636    15635       -1     \n+ Misses        55562    55560       -2     \n  Partials       2086     2086\n```\n\n\n| [Impacted Files](https://codecov.io/gh/triplea-game/triplea/pull/3124?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [.../main/java/games/strategy/net/ClientMessenger.java](https://codecov.io/gh/triplea-game/triplea/pull/3124/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvbmV0L0NsaWVudE1lc3Nlbmdlci5qYXZh) | `35.55% <ø> (+0.26%)` | `13 <0> (ø)` | :arrow_down: |\n| [.../main/java/games/strategy/net/ServerMessenger.java](https://codecov.io/gh/triplea-game/triplea/pull/3124/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvbmV0L1NlcnZlck1lc3Nlbmdlci5qYXZh) | `34.61% <ø> (+0.09%)` | `31 <0> (ø)` | :arrow_down: |\n| [.../main/java/games/strategy/engine/history/Step.java](https://codecov.io/gh/triplea-game/triplea/pull/3124/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvZW5naW5lL2hpc3RvcnkvU3RlcC5qYXZh) | `62.5% <ø> (+6.94%)` | `1 <0> (ø)` | :arrow_down: |\n| [.../src/main/java/games/strategy/net/nio/Decoder.java](https://codecov.io/gh/triplea-game/triplea/pull/3124/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvbmV0L25pby9EZWNvZGVyLmphdmE=) | `72.82% <0%> (-1.09%)` | `24% <0%> (-1%)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/triplea-game/triplea/pull/3124?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/3124?src=pr&el=footer). Last update [bb16778...13ba8a5](https://codecov.io/gh/triplea-game/triplea/pull/3124?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}