{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments/210665711","pull_request_review_id":146929796,"id":210665711,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDY2NTcxMQ==","diff_hunk":"@@ -46,6 +51,10 @@ extern apr_pool_t *tcn_global_pool;\n ENGINE *tcn_ssl_engine = NULL;\n void *SSL_temp_keys[SSL_TMP_KEY_MAX];\n \n+#ifndef OPENSSL_NO_ENGINE\n+UI_METHOD *ui_method = NULL;","path":"openssl-dynamic/src/main/c/ssl.c","position":17,"original_position":17,"commit_id":"ac4012563050cba0657590da8e4b74a016e8b68e","original_commit_id":"64d368cc534b411a1810a218b07b67dc13b3ae67","user":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"Can’t hurt... let me also make tcn_ssl_engine static while I am here","created_at":"2018-08-16T16:45:40Z","updated_at":"2018-08-16T16:45:49Z","html_url":"https://github.com/netty/netty-tcnative/pull/380#discussion_r210665711","pull_request_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/380","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments/210665711"},"html":{"href":"https://github.com/netty/netty-tcnative/pull/380#discussion_r210665711"},"pull_request":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/380"}},"in_reply_to_id":210663907},"pull_request":{"url":"https://api.github.com/repos/netty/netty-tcnative/pulls/380","id":208853727,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4ODUzNzI3","html_url":"https://github.com/netty/netty-tcnative/pull/380","diff_url":"https://github.com/netty/netty-tcnative/pull/380.diff","patch_url":"https://github.com/netty/netty-tcnative/pull/380.patch","issue_url":"https://api.github.com/repos/netty/netty-tcnative/issues/380","number":380,"state":"open","locked":false,"title":"Allow to load a private key from the OpenSSL engine.","user":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nIts possible to plugin different behavior into OpenSSL by providing a custom OpenSSL engine. When doing so it's possible to load a private key from the engine directly.\r\n\r\nModifications:\r\n\r\nAdd new method which allows to load a private key from the OpenSSL engine directly and so can be used later on.\r\n\r\nResult:\r\n\r\nBe able to implement custom loading / store mechanism of private keys via a custom OpenSSL engine.","created_at":"2018-08-16T13:09:30Z","updated_at":"2018-08-16T16:45:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91e77c83bd86f39cf04c033867d3cddd3a44244b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carl-mastrangelo","id":8943572,"node_id":"MDQ6VXNlcjg5NDM1NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/8943572?v=4","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":145159257,"node_id":"MDU6TGFiZWwxNDUxNTkyNTc=","url":"https://api.github.com/repos/netty/netty-tcnative/labels/feature","name":"feature","color":"009800","default":false},{"id":94161182,"node_id":"MDU6TGFiZWw5NDE2MTE4Mg==","url":"https://api.github.com/repos/netty/netty-tcnative/labels/improvement","name":"improvement","color":"0052cc","default":false}],"milestone":{"url":"https://api.github.com/repos/netty/netty-tcnative/milestones/50","html_url":"https://github.com/netty/netty-tcnative/milestone/50","labels_url":"https://api.github.com/repos/netty/netty-tcnative/milestones/50/labels","id":3455787,"node_id":"MDk6TWlsZXN0b25lMzQ1NTc4Nw==","number":50,"title":"2.0.13.Final","description":"","creator":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":6,"state":"open","created_at":"2018-06-27T12:10:30Z","updated_at":"2018-08-16T13:11:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/380/commits","review_comments_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/380/comments","review_comment_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty-tcnative/issues/380/comments","statuses_url":"https://api.github.com/repos/netty/netty-tcnative/statuses/ac4012563050cba0657590da8e4b74a016e8b68e","head":{"label":"netty:private_key_from_engine","ref":"private_key_from_engine","sha":"ac4012563050cba0657590da8e4b74a016e8b68e","user":{"login":"netty","id":473791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mzc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/473791?v=4","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":19016985,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAxNjk4NQ==","name":"netty-tcnative","full_name":"netty/netty-tcnative","owner":{"login":"netty","id":473791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mzc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/473791?v=4","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty-tcnative","description":"A fork of Apache Tomcat Native, based on finagle-native","fork":false,"url":"https://api.github.com/repos/netty/netty-tcnative","forks_url":"https://api.github.com/repos/netty/netty-tcnative/forks","keys_url":"https://api.github.com/repos/netty/netty-tcnative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty-tcnative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty-tcnative/teams","hooks_url":"https://api.github.com/repos/netty/netty-tcnative/hooks","issue_events_url":"https://api.github.com/repos/netty/netty-tcnative/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty-tcnative/events","assignees_url":"https://api.github.com/repos/netty/netty-tcnative/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty-tcnative/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty-tcnative/tags","blobs_url":"https://api.github.com/repos/netty/netty-tcnative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty-tcnative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty-tcnative/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty-tcnative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty-tcnative/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty-tcnative/languages","stargazers_url":"https://api.github.com/repos/netty/netty-tcnative/stargazers","contributors_url":"https://api.github.com/repos/netty/netty-tcnative/contributors","subscribers_url":"https://api.github.com/repos/netty/netty-tcnative/subscribers","subscription_url":"https://api.github.com/repos/netty/netty-tcnative/subscription","commits_url":"https://api.github.com/repos/netty/netty-tcnative/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty-tcnative/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty-tcnative/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty-tcnative/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty-tcnative/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty-tcnative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty-tcnative/merges","archive_url":"https://api.github.com/repos/netty/netty-tcnative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty-tcnative/downloads","issues_url":"https://api.github.com/repos/netty/netty-tcnative/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty-tcnative/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty-tcnative/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty-tcnative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty-tcnative/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty-tcnative/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty-tcnative/deployments","created_at":"2014-04-22T04:24:17Z","updated_at":"2018-08-16T05:37:18Z","pushed_at":"2018-08-16T16:09:43Z","git_url":"git://github.com/netty/netty-tcnative.git","ssh_url":"git@github.com:netty/netty-tcnative.git","clone_url":"https://github.com/netty/netty-tcnative.git","svn_url":"https://github.com/netty/netty-tcnative","homepage":null,"size":1571,"stargazers_count":116,"watchers_count":116,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":73,"open_issues":26,"watchers":116,"default_branch":"master"}},"base":{"label":"netty:master","ref":"master","sha":"6f19e60e2edd878d42fcff537691165ce670c120","user":{"login":"netty","id":473791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mzc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/473791?v=4","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":19016985,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAxNjk4NQ==","name":"netty-tcnative","full_name":"netty/netty-tcnative","owner":{"login":"netty","id":473791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mzc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/473791?v=4","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty-tcnative","description":"A fork of Apache Tomcat Native, based on finagle-native","fork":false,"url":"https://api.github.com/repos/netty/netty-tcnative","forks_url":"https://api.github.com/repos/netty/netty-tcnative/forks","keys_url":"https://api.github.com/repos/netty/netty-tcnative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty-tcnative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty-tcnative/teams","hooks_url":"https://api.github.com/repos/netty/netty-tcnative/hooks","issue_events_url":"https://api.github.com/repos/netty/netty-tcnative/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty-tcnative/events","assignees_url":"https://api.github.com/repos/netty/netty-tcnative/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty-tcnative/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty-tcnative/tags","blobs_url":"https://api.github.com/repos/netty/netty-tcnative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty-tcnative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty-tcnative/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty-tcnative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty-tcnative/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty-tcnative/languages","stargazers_url":"https://api.github.com/repos/netty/netty-tcnative/stargazers","contributors_url":"https://api.github.com/repos/netty/netty-tcnative/contributors","subscribers_url":"https://api.github.com/repos/netty/netty-tcnative/subscribers","subscription_url":"https://api.github.com/repos/netty/netty-tcnative/subscription","commits_url":"https://api.github.com/repos/netty/netty-tcnative/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty-tcnative/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty-tcnative/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty-tcnative/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty-tcnative/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty-tcnative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty-tcnative/merges","archive_url":"https://api.github.com/repos/netty/netty-tcnative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty-tcnative/downloads","issues_url":"https://api.github.com/repos/netty/netty-tcnative/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty-tcnative/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty-tcnative/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty-tcnative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty-tcnative/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty-tcnative/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty-tcnative/deployments","created_at":"2014-04-22T04:24:17Z","updated_at":"2018-08-16T05:37:18Z","pushed_at":"2018-08-16T16:09:43Z","git_url":"git://github.com/netty/netty-tcnative.git","ssh_url":"git@github.com:netty/netty-tcnative.git","clone_url":"https://github.com/netty/netty-tcnative.git","svn_url":"https://github.com/netty/netty-tcnative","homepage":null,"size":1571,"stargazers_count":116,"watchers_count":116,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":73,"open_issues":26,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/380"},"html":{"href":"https://github.com/netty/netty-tcnative/pull/380"},"issue":{"href":"https://api.github.com/repos/netty/netty-tcnative/issues/380"},"comments":{"href":"https://api.github.com/repos/netty/netty-tcnative/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty-tcnative/statuses/ac4012563050cba0657590da8e4b74a016e8b68e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"normanmaurer"}}