{"action":"created","issue":{"url":"https://api.github.com/repos/nkansal96/aurora-java/issues/22","repository_url":"https://api.github.com/repos/nkansal96/aurora-java","labels_url":"https://api.github.com/repos/nkansal96/aurora-java/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/nkansal96/aurora-java/issues/22/comments","events_url":"https://api.github.com/repos/nkansal96/aurora-java/issues/22/events","html_url":"https://github.com/nkansal96/aurora-java/issues/22","id":329702926,"node_id":"MDU6SXNzdWUzMjk3MDI5MjY=","number":22,"title":"Trimming beginning silence","user":{"login":"nkansal96","id":3259309,"node_id":"MDQ6VXNlcjMyNTkzMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3259309?v=4","gravatar_id":"","url":"https://api.github.com/users/nkansal96","html_url":"https://github.com/nkansal96","followers_url":"https://api.github.com/users/nkansal96/followers","following_url":"https://api.github.com/users/nkansal96/following{/other_user}","gists_url":"https://api.github.com/users/nkansal96/gists{/gist_id}","starred_url":"https://api.github.com/users/nkansal96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkansal96/subscriptions","organizations_url":"https://api.github.com/users/nkansal96/orgs","repos_url":"https://api.github.com/users/nkansal96/repos","events_url":"https://api.github.com/users/nkansal96/events{/privacy}","received_events_url":"https://api.github.com/users/nkansal96/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"vanshg","id":6133201,"node_id":"MDQ6VXNlcjYxMzMyMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6133201?v=4","gravatar_id":"","url":"https://api.github.com/users/vanshg","html_url":"https://github.com/vanshg","followers_url":"https://api.github.com/users/vanshg/followers","following_url":"https://api.github.com/users/vanshg/following{/other_user}","gists_url":"https://api.github.com/users/vanshg/gists{/gist_id}","starred_url":"https://api.github.com/users/vanshg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanshg/subscriptions","organizations_url":"https://api.github.com/users/vanshg/orgs","repos_url":"https://api.github.com/users/vanshg/repos","events_url":"https://api.github.com/users/vanshg/events{/privacy}","received_events_url":"https://api.github.com/users/vanshg/received_events","type":"User","site_admin":false},"assignees":[{"login":"vanshg","id":6133201,"node_id":"MDQ6VXNlcjYxMzMyMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6133201?v=4","gravatar_id":"","url":"https://api.github.com/users/vanshg","html_url":"https://github.com/vanshg","followers_url":"https://api.github.com/users/vanshg/followers","following_url":"https://api.github.com/users/vanshg/following{/other_user}","gists_url":"https://api.github.com/users/vanshg/gists{/gist_id}","starred_url":"https://api.github.com/users/vanshg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanshg/subscriptions","organizations_url":"https://api.github.com/users/vanshg/orgs","repos_url":"https://api.github.com/users/vanshg/repos","events_url":"https://api.github.com/users/vanshg/events{/privacy}","received_events_url":"https://api.github.com/users/vanshg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-06-06T04:04:17Z","updated_at":"2018-06-06T06:40:43Z","closed_at":"2018-06-06T06:40:43Z","author_association":"OWNER","body":"In reference to [this](https://github.com/nkansal96/aurora-java/blob/ea4c5ae9986154206eb08130811b8579cda16eeb/src/main/java/com/auroraapi/models/Audio.java#L102), I noticed that the silence is continuously accumulated until some noise is made, however there is no limit to the amount of data in the silence buffer. Would it be possible to make this in line with the [python implementation](https://github.com/auroraapi/aurora-python/blob/d092c9373648931def728e90fa84048a08849b44/auroraapi/audio.py#L181) which keeps the last 32 buffers worth of silence instead of all of it?\r\n\r\nThis should be the same behavior for the timed record as well – it should not start the timer (and should accumulate silence in the same way) while there is silence."},"comment":{"url":"https://api.github.com/repos/nkansal96/aurora-java/issues/comments/394957520","html_url":"https://github.com/nkansal96/aurora-java/issues/22#issuecomment-394957520","issue_url":"https://api.github.com/repos/nkansal96/aurora-java/issues/22","id":394957520,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDk1NzUyMA==","user":{"login":"vanshg","id":6133201,"node_id":"MDQ6VXNlcjYxMzMyMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6133201?v=4","gravatar_id":"","url":"https://api.github.com/users/vanshg","html_url":"https://github.com/vanshg","followers_url":"https://api.github.com/users/vanshg/followers","following_url":"https://api.github.com/users/vanshg/following{/other_user}","gists_url":"https://api.github.com/users/vanshg/gists{/gist_id}","starred_url":"https://api.github.com/users/vanshg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanshg/subscriptions","organizations_url":"https://api.github.com/users/vanshg/orgs","repos_url":"https://api.github.com/users/vanshg/repos","events_url":"https://api.github.com/users/vanshg/events{/privacy}","received_events_url":"https://api.github.com/users/vanshg/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T06:40:43Z","updated_at":"2018-06-06T06:40:43Z","author_association":"COLLABORATOR","body":"Fixed with https://github.com/nkansal96/aurora-java/commit/65363ba1f13e2675ab4f0721be8cf8ca79c48a9c, https://github.com/nkansal96/aurora-java/commit/a602468ecac526fd075d5bc2f8dda9d192483638, and https://github.com/nkansal96/aurora-java/commit/5f0c38443969e27f3a385728b103b457c7960b48"}}
{"actor":{"display_login":"vanshg"}}