{"action":"opened","number":1549,"pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1549","id":204900175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTAwMTc1","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1549","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/1549.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/1549.patch","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1549","number":1549,"state":"open","locked":false,"title":"Cleanup: Make WindowsTitleUpdate a global object","user":{"login":"bstoeger","id":32835590,"node_id":"MDQ6VXNlcjMyODM1NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/32835590?v=4","gravatar_id":"","url":"https://api.github.com/users/bstoeger","html_url":"https://github.com/bstoeger","followers_url":"https://api.github.com/users/bstoeger/followers","following_url":"https://api.github.com/users/bstoeger/following{/other_user}","gists_url":"https://api.github.com/users/bstoeger/gists{/gist_id}","starred_url":"https://api.github.com/users/bstoeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstoeger/subscriptions","organizations_url":"https://api.github.com/users/bstoeger/orgs","repos_url":"https://api.github.com/users/bstoeger/repos","events_url":"https://api.github.com/users/bstoeger/events{/privacy}","received_events_url":"https://api.github.com/users/bstoeger/received_events","type":"User","site_admin":false},"body":"WindowsTitleUpdate is such a trivial object (a QObject with a single\r\nsignal and no own state), that it's not really understandable why\r\nit would need all that \"singleton\" boiler-plate. Just make it\r\na default constructed/destructed global object.\r\n\r\nSigned-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>\r\n\r\n<!-- Lines like this one are comments and will not be shown in the final output. -->\r\n<!-- Make sure that you have read the \"Contributing\" section of the README and also the notes in CodingStyle. -->\r\n<!-- If you are a collaborator, please add labels and assign other collaborators for a review. -->\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [ ] Bug fix\r\n- [ ] Functional change\r\n- [ ] New feature\r\n- [x] Code cleanup\r\n- [ ] Build system change\r\n- [ ] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\n<!-- Describe your pull request in detail. -->\r\n`WindowsTitleUpdate` is such a trivial object, that I don't understand why it would need all that `instance()` boiler-plate. Simply make it a global (`extern`) object.\r\n","created_at":"2018-07-30T19:04:58Z","updated_at":"2018-07-30T19:04:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":753480128,"node_id":"MDU6TGFiZWw3NTM0ODAxMjg=","url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/code-cleanup","name":"code-cleanup","color":"fbca04","default":false},{"id":700934597,"node_id":"MDU6TGFiZWw3MDA5MzQ1OTc=","url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/complexity-low","name":"complexity-low","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1549/commits","review_comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1549/comments","review_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1549/comments","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/f9ad334f010a5ae5179b134a32ce8925cda7e59b","head":{"label":"bstoeger:clean21","ref":"clean21","sha":"f9ad334f010a5ae5179b134a32ce8925cda7e59b","user":{"login":"bstoeger","id":32835590,"node_id":"MDQ6VXNlcjMyODM1NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/32835590?v=4","gravatar_id":"","url":"https://api.github.com/users/bstoeger","html_url":"https://github.com/bstoeger","followers_url":"https://api.github.com/users/bstoeger/followers","following_url":"https://api.github.com/users/bstoeger/following{/other_user}","gists_url":"https://api.github.com/users/bstoeger/gists{/gist_id}","starred_url":"https://api.github.com/users/bstoeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstoeger/subscriptions","organizations_url":"https://api.github.com/users/bstoeger/orgs","repos_url":"https://api.github.com/users/bstoeger/repos","events_url":"https://api.github.com/users/bstoeger/events{/privacy}","received_events_url":"https://api.github.com/users/bstoeger/received_events","type":"User","site_admin":false},"repo":{"id":107111280,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcxMTEyODA=","name":"subsurface","full_name":"bstoeger/subsurface","owner":{"login":"bstoeger","id":32835590,"node_id":"MDQ6VXNlcjMyODM1NTkw","avatar_url":"https://avatars3.githubusercontent.com/u/32835590?v=4","gravatar_id":"","url":"https://api.github.com/users/bstoeger","html_url":"https://github.com/bstoeger","followers_url":"https://api.github.com/users/bstoeger/followers","following_url":"https://api.github.com/users/bstoeger/following{/other_user}","gists_url":"https://api.github.com/users/bstoeger/gists{/gist_id}","starred_url":"https://api.github.com/users/bstoeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstoeger/subscriptions","organizations_url":"https://api.github.com/users/bstoeger/orgs","repos_url":"https://api.github.com/users/bstoeger/repos","events_url":"https://api.github.com/users/bstoeger/events{/privacy}","received_events_url":"https://api.github.com/users/bstoeger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bstoeger/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":true,"url":"https://api.github.com/repos/bstoeger/subsurface","forks_url":"https://api.github.com/repos/bstoeger/subsurface/forks","keys_url":"https://api.github.com/repos/bstoeger/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bstoeger/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bstoeger/subsurface/teams","hooks_url":"https://api.github.com/repos/bstoeger/subsurface/hooks","issue_events_url":"https://api.github.com/repos/bstoeger/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/bstoeger/subsurface/events","assignees_url":"https://api.github.com/repos/bstoeger/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/bstoeger/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/bstoeger/subsurface/tags","blobs_url":"https://api.github.com/repos/bstoeger/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bstoeger/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bstoeger/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/bstoeger/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bstoeger/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/bstoeger/subsurface/languages","stargazers_url":"https://api.github.com/repos/bstoeger/subsurface/stargazers","contributors_url":"https://api.github.com/repos/bstoeger/subsurface/contributors","subscribers_url":"https://api.github.com/repos/bstoeger/subsurface/subscribers","subscription_url":"https://api.github.com/repos/bstoeger/subsurface/subscription","commits_url":"https://api.github.com/repos/bstoeger/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/bstoeger/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/bstoeger/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/bstoeger/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/bstoeger/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/bstoeger/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bstoeger/subsurface/merges","archive_url":"https://api.github.com/repos/bstoeger/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bstoeger/subsurface/downloads","issues_url":"https://api.github.com/repos/bstoeger/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/bstoeger/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/bstoeger/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/bstoeger/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bstoeger/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/bstoeger/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/bstoeger/subsurface/deployments","created_at":"2017-10-16T10:11:10Z","updated_at":"2018-06-12T10:57:12Z","pushed_at":"2018-07-30T19:01:22Z","git_url":"git://github.com/bstoeger/subsurface.git","ssh_url":"git@github.com:bstoeger/subsurface.git","clone_url":"https://github.com/bstoeger/subsurface.git","svn_url":"https://github.com/bstoeger/subsurface","homepage":"https://subsurface-divelog.org","size":95745,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Subsurface-divelog:master","ref":"master","sha":"d3f3d82abdaabebf5a8c83a57cc6b9e0b7aab1de","user":{"login":"Subsurface-divelog","id":24829199,"node_id":"MDQ6VXNlcjI0ODI5MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"repo":{"id":2319498,"node_id":"MDEwOlJlcG9zaXRvcnkyMzE5NDk4","name":"subsurface","full_name":"Subsurface-divelog/subsurface","owner":{"login":"Subsurface-divelog","id":24829199,"node_id":"MDQ6VXNlcjI0ODI5MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Subsurface-divelog/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":false,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface","forks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/forks","keys_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/teams","hooks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/hooks","issue_events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/events","assignees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/tags","blobs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/languages","stargazers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/stargazers","contributors_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contributors","subscribers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscribers","subscription_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscription","commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/merges","archive_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/downloads","issues_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/deployments","created_at":"2011-09-03T15:27:51Z","updated_at":"2018-07-30T14:43:28Z","pushed_at":"2018-07-30T18:49:27Z","git_url":"git://github.com/Subsurface-divelog/subsurface.git","ssh_url":"git@github.com:Subsurface-divelog/subsurface.git","clone_url":"https://github.com/Subsurface-divelog/subsurface.git","svn_url":"https://github.com/Subsurface-divelog/subsurface","homepage":"https://subsurface-divelog.org","size":95562,"stargazers_count":1402,"watchers_count":1402,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":355,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":355,"open_issues":87,"watchers":1402,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1549"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/1549"},"issue":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1549"},"comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1549/comments"},"review_comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1549/comments"},"review_comment":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1549/commits"},"statuses":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/f9ad334f010a5ae5179b134a32ce8925cda7e59b"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":5,"deletions":38,"changed_files":5}}
{"actor":{"display_login":"bstoeger"}}