{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/5492","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/5492/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/5492/comments","events_url":"https://api.github.com/repos/apache/flink/issues/5492/events","html_url":"https://github.com/apache/flink/pull/5492","id":297360664,"number":5492,"title":"[FLINK-5728] [kafka] Let FlinkKafkaProducers flush on checkpoints by default","user":{"login":"tzulitai","id":5284370,"avatar_url":"https://avatars3.githubusercontent.com/u/5284370?v=4","gravatar_id":"","url":"https://api.github.com/users/tzulitai","html_url":"https://github.com/tzulitai","followers_url":"https://api.github.com/users/tzulitai/followers","following_url":"https://api.github.com/users/tzulitai/following{/other_user}","gists_url":"https://api.github.com/users/tzulitai/gists{/gist_id}","starred_url":"https://api.github.com/users/tzulitai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzulitai/subscriptions","organizations_url":"https://api.github.com/users/tzulitai/orgs","repos_url":"https://api.github.com/users/tzulitai/repos","events_url":"https://api.github.com/users/tzulitai/events{/privacy}","received_events_url":"https://api.github.com/users/tzulitai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-15T08:17:36Z","updated_at":"2018-02-15T14:42:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/5492","html_url":"https://github.com/apache/flink/pull/5492","diff_url":"https://github.com/apache/flink/pull/5492.diff","patch_url":"https://github.com/apache/flink/pull/5492.patch"},"body":"## What is the purpose of the change\r\n\r\nThis pull request makes flushing on checkpoints in the Kafka producer the default behaviour.\r\nEffectively, the user now should not require any additional configuration for the producer to have at-least-once semantics.\r\n\r\n## Brief change log\r\n\r\n- initialize `flushOnCheckpoint` flag to be `true`\r\n- update documents\r\n\r\n## Verifying this change\r\n\r\nExisting tests should already cover this change.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (yes / **no**)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)\r\n  - The serializers: (yes / **no** / don't know)\r\n  - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)\r\n  - The S3 file system connector: (yes / **no** / don't know)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (yes / **no**)\r\n  - If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)\r\n"},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/365947140","html_url":"https://github.com/apache/flink/pull/5492#issuecomment-365947140","issue_url":"https://api.github.com/repos/apache/flink/issues/5492","id":365947140,"user":{"login":"aljoscha","id":68551,"avatar_url":"https://avatars1.githubusercontent.com/u/68551?v=4","gravatar_id":"","url":"https://api.github.com/users/aljoscha","html_url":"https://github.com/aljoscha","followers_url":"https://api.github.com/users/aljoscha/followers","following_url":"https://api.github.com/users/aljoscha/following{/other_user}","gists_url":"https://api.github.com/users/aljoscha/gists{/gist_id}","starred_url":"https://api.github.com/users/aljoscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljoscha/subscriptions","organizations_url":"https://api.github.com/users/aljoscha/orgs","repos_url":"https://api.github.com/users/aljoscha/repos","events_url":"https://api.github.com/users/aljoscha/events{/privacy}","received_events_url":"https://api.github.com/users/aljoscha/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T14:42:14Z","updated_at":"2018-02-15T14:42:14Z","author_association":"CONTRIBUTOR","body":"Had to change this line to use `StreamingRuntimeContext.class` because the Producer would now actually call this: https://github.com/apache/flink/blob/96e898f2923f6b68bc845facf9c2d7ce1a951bbb/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java#L100 😅 "}}
{"actor":{"display_login":"aljoscha"}}