{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/228070765","pull_request_review_id":168251460,"id":228070765,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODA3MDc2NQ==","diff_hunk":"@@ -353,25 +354,72 @@ typedef void (*uct_iface_mpool_init_obj_cb_t)(uct_iface_h iface, void *obj,\n \n \n /**\n- * Base structure for private data held inside a pending request. Contains\n- * a queue element so we can put this on a queue.\n+ * Base structure for private data held inside a pending request for TLs\n+ * which use ucs_arbiter_t to progress pending requests.\n  */\n typedef struct {\n-    ucs_queue_elem_t  queue;\n-} uct_pending_req_priv_t;\n+    ucs_arbiter_elem_t  arb_elem;\n+} uct_pending_req_priv_arb_base_t;\n \n \n+static UCS_F_ALWAYS_INLINE uct_pending_req_priv_arb_base_t *\n+uct_pending_req_priv_arb_base(uct_pending_req_t* req)\n+{\n+    return (uct_pending_req_priv_arb_base_t *)&req->priv;\n+}\n+\n+\n+static UCS_F_ALWAYS_INLINE ucs_arbiter_elem_t *\n+uct_pending_req_priv_arb_elem(uct_pending_req_t* req)\n+{\n+    return &(uct_pending_req_priv_arb_base(req))->arb_elem;\n+}\n+\n+\n+/**\n+ * Add a pending request to the arbiter.\n+ */\n+#define uct_pending_req_arb_group_push(_arbiter_group, _req) \\\n+    do { \\\n+        ucs_arbiter_elem_init(uct_pending_req_priv_arb_elem(_req)); \\\n+        ucs_arbiter_group_push_elem(_arbiter_group, \\\n+                                    uct_pending_req_priv_arb_elem(_req)); \\\n+    } while (0)\n+\n+\n+/**\n+ * Base structure for private data held inside a pending request for TLs\n+ * which use ucs_queue_t to progress pending requests.\n+ */\n typedef struct {\n-    uct_pending_purge_callback_t cb;\n-    void *arg;\n-} uct_purge_cb_args_t;\n+    ucs_queue_elem_t    queue_elem;\n+} uct_pending_req_priv_queue_base_t;\n+\n+\n+static UCS_F_ALWAYS_INLINE uct_pending_req_priv_queue_base_t *\n+uct_pending_req_priv_queue_base(uct_pending_req_t* req)","path":"src/uct/base/uct_iface.h","position":62,"original_position":62,"commit_id":"0e5bf59e66a34ff76781319e9f7275f299e8dbb6","original_commit_id":"0e5bf59e66a34ff76781319e9f7275f299e8dbb6","user":{"login":"yosefe","id":2255631,"node_id":"MDQ6VXNlcjIyNTU2MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2255631?v=4","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"same here, this function is redundant","created_at":"2018-10-25T08:04:50Z","updated_at":"2018-10-25T08:19:45Z","html_url":"https://github.com/openucx/ucx/pull/2965#discussion_r228070765","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/2965","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/228070765"},"html":{"href":"https://github.com/openucx/ucx/pull/2965#discussion_r228070765"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2965"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/2965","id":223575746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTc1NzQ2","html_url":"https://github.com/openucx/ucx/pull/2965","diff_url":"https://github.com/openucx/ucx/pull/2965.diff","patch_url":"https://github.com/openucx/ucx/pull/2965.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/2965","number":2965,"state":"open","locked":false,"title":"UCT: implement flags of uct_ep_pending_add","user":{"login":"evgeny-leksikov","id":15216359,"node_id":"MDQ6VXNlcjE1MjE2MzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15216359?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"body":"## What\r\nNext portion of #2864\r\n - UCT: implement flags of uct_ep_pending_add\r\n - GTEST/UCT: add uct_p2p_am_test.am_async_response\r\n\r\n## Why ?\r\nNext PR will add async wireup\r\n","created_at":"2018-10-17T12:03:07Z","updated_at":"2018-10-25T08:19:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"740172292c09b11675a1c52d9c530203d7fb0adc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hoopoepg","id":2535990,"node_id":"MDQ6VXNlcjI1MzU5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":350068719,"node_id":"MDU6TGFiZWwzNTAwNjg3MTk=","url":"https://api.github.com/repos/openucx/ucx/labels/Ready%20for%20Review","name":"Ready for Review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/2965/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/2965/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/2965/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/0e5bf59e66a34ff76781319e9f7275f299e8dbb6","head":{"label":"evgeny-leksikov:uct_pending_add_flags_impl","ref":"uct_pending_add_flags_impl","sha":"0e5bf59e66a34ff76781319e9f7275f299e8dbb6","user":{"login":"evgeny-leksikov","id":15216359,"node_id":"MDQ6VXNlcjE1MjE2MzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15216359?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"repo":{"id":77319416,"node_id":"MDEwOlJlcG9zaXRvcnk3NzMxOTQxNg==","name":"ucx","full_name":"evgeny-leksikov/ucx","private":false,"owner":{"login":"evgeny-leksikov","id":15216359,"node_id":"MDQ6VXNlcjE1MjE2MzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15216359?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/evgeny-leksikov/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/evgeny-leksikov/ucx","forks_url":"https://api.github.com/repos/evgeny-leksikov/ucx/forks","keys_url":"https://api.github.com/repos/evgeny-leksikov/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evgeny-leksikov/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evgeny-leksikov/ucx/teams","hooks_url":"https://api.github.com/repos/evgeny-leksikov/ucx/hooks","issue_events_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/evgeny-leksikov/ucx/events","assignees_url":"https://api.github.com/repos/evgeny-leksikov/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/evgeny-leksikov/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/evgeny-leksikov/ucx/tags","blobs_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evgeny-leksikov/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/evgeny-leksikov/ucx/languages","stargazers_url":"https://api.github.com/repos/evgeny-leksikov/ucx/stargazers","contributors_url":"https://api.github.com/repos/evgeny-leksikov/ucx/contributors","subscribers_url":"https://api.github.com/repos/evgeny-leksikov/ucx/subscribers","subscription_url":"https://api.github.com/repos/evgeny-leksikov/ucx/subscription","commits_url":"https://api.github.com/repos/evgeny-leksikov/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/evgeny-leksikov/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/evgeny-leksikov/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/evgeny-leksikov/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evgeny-leksikov/ucx/merges","archive_url":"https://api.github.com/repos/evgeny-leksikov/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evgeny-leksikov/ucx/downloads","issues_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/evgeny-leksikov/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/evgeny-leksikov/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/evgeny-leksikov/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evgeny-leksikov/ucx/labels{/name}","releases_url":"https://api.github.com/repos/evgeny-leksikov/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/evgeny-leksikov/ucx/deployments","created_at":"2016-12-25T09:34:08Z","updated_at":"2018-10-23T06:19:07Z","pushed_at":"2018-10-24T07:49:36Z","git_url":"git://github.com/evgeny-leksikov/ucx.git","ssh_url":"git@github.com:evgeny-leksikov/ucx.git","clone_url":"https://github.com/evgeny-leksikov/ucx.git","svn_url":"https://github.com/evgeny-leksikov/ucx","homepage":"http://www.openucx.org","size":14269,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"248641268011814a8ef641923f4f14080b7cb780","user":{"login":"openucx","id":13118737,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTE4NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"node_id":"MDEwOlJlcG9zaXRvcnkyNTM3OTM5MA==","name":"ucx","full_name":"openucx/ucx","private":false,"owner":{"login":"openucx","id":13118737,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTE4NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2018-10-25T08:00:58Z","pushed_at":"2018-10-25T08:00:55Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":14248,"stargazers_count":142,"watchers_count":142,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":165,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":76,"open_issues":165,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2965"},"html":{"href":"https://github.com/openucx/ucx/pull/2965"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/2965"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/2965/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2965/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2965/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/0e5bf59e66a34ff76781319e9f7275f299e8dbb6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yosefe"}}