{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/pulls/4","id":195841296,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODQxMjk2","html_url":"https://github.com/darioteixeira/ocaml-safepass/pull/4","diff_url":"https://github.com/darioteixeira/ocaml-safepass/pull/4.diff","patch_url":"https://github.com/darioteixeira/ocaml-safepass/pull/4.patch","issue_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/issues/4","number":4,"state":"closed","locked":false,"title":"Add support for selecting other variants than $2y$ hashes","user":{"login":"Leonidas-from-XIV","id":121531,"node_id":"MDQ6VXNlcjEyMTUzMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/121531?v=4","gravatar_id":"","url":"https://api.github.com/users/Leonidas-from-XIV","html_url":"https://github.com/Leonidas-from-XIV","followers_url":"https://api.github.com/users/Leonidas-from-XIV/followers","following_url":"https://api.github.com/users/Leonidas-from-XIV/following{/other_user}","gists_url":"https://api.github.com/users/Leonidas-from-XIV/gists{/gist_id}","starred_url":"https://api.github.com/users/Leonidas-from-XIV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leonidas-from-XIV/subscriptions","organizations_url":"https://api.github.com/users/Leonidas-from-XIV/orgs","repos_url":"https://api.github.com/users/Leonidas-from-XIV/repos","events_url":"https://api.github.com/users/Leonidas-from-XIV/events{/privacy}","received_events_url":"https://api.github.com/users/Leonidas-from-XIV/received_events","type":"User","site_admin":false},"body":"Basically what it says. There are `$2$` and `$2x` variants too, but they don't seem to be supported by `crypt_bcrypt`.\r\n\r\nI'm mapping the `char` type in OCaml to an `Int_val` in C as they do in [How to wrap C functions to OCaml](https://www.linux-nantes.org/~fmonnier/OCaml/ocaml-wrapping-c.html), just in case you're wondering.","created_at":"2018-06-19T14:09:53Z","updated_at":"2018-06-25T09:43:45Z","closed_at":"2018-06-25T09:43:45Z","merged_at":"2018-06-25T09:43:45Z","merge_commit_sha":"66546d730552f4056b542ec40947db4432a28e11","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/pulls/4/commits","review_comments_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/pulls/4/comments","review_comment_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/issues/4/comments","statuses_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/statuses/c6bdaf1eacac484618d48a0238f9cd92377e40e3","head":{"label":"Leonidas-from-XIV:bcrypt-versions","ref":"bcrypt-versions","sha":"c6bdaf1eacac484618d48a0238f9cd92377e40e3","user":{"login":"Leonidas-from-XIV","id":121531,"node_id":"MDQ6VXNlcjEyMTUzMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/121531?v=4","gravatar_id":"","url":"https://api.github.com/users/Leonidas-from-XIV","html_url":"https://github.com/Leonidas-from-XIV","followers_url":"https://api.github.com/users/Leonidas-from-XIV/followers","following_url":"https://api.github.com/users/Leonidas-from-XIV/following{/other_user}","gists_url":"https://api.github.com/users/Leonidas-from-XIV/gists{/gist_id}","starred_url":"https://api.github.com/users/Leonidas-from-XIV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leonidas-from-XIV/subscriptions","organizations_url":"https://api.github.com/users/Leonidas-from-XIV/orgs","repos_url":"https://api.github.com/users/Leonidas-from-XIV/repos","events_url":"https://api.github.com/users/Leonidas-from-XIV/events{/privacy}","received_events_url":"https://api.github.com/users/Leonidas-from-XIV/received_events","type":"User","site_admin":false},"repo":{"id":137897679,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4OTc2Nzk=","name":"ocaml-safepass","full_name":"Leonidas-from-XIV/ocaml-safepass","owner":{"login":"Leonidas-from-XIV","id":121531,"node_id":"MDQ6VXNlcjEyMTUzMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/121531?v=4","gravatar_id":"","url":"https://api.github.com/users/Leonidas-from-XIV","html_url":"https://github.com/Leonidas-from-XIV","followers_url":"https://api.github.com/users/Leonidas-from-XIV/followers","following_url":"https://api.github.com/users/Leonidas-from-XIV/following{/other_user}","gists_url":"https://api.github.com/users/Leonidas-from-XIV/gists{/gist_id}","starred_url":"https://api.github.com/users/Leonidas-from-XIV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leonidas-from-XIV/subscriptions","organizations_url":"https://api.github.com/users/Leonidas-from-XIV/orgs","repos_url":"https://api.github.com/users/Leonidas-from-XIV/repos","events_url":"https://api.github.com/users/Leonidas-from-XIV/events{/privacy}","received_events_url":"https://api.github.com/users/Leonidas-from-XIV/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Leonidas-from-XIV/ocaml-safepass","description":"OCaml-safepass is a library enabling the safe storage of user passwords, for use in web applications","fork":true,"url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass","forks_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/forks","keys_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/teams","hooks_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/hooks","issue_events_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/issues/events{/number}","events_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/events","assignees_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/assignees{/user}","branches_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/branches{/branch}","tags_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/tags","blobs_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/git/refs{/sha}","trees_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/statuses/{sha}","languages_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/languages","stargazers_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/stargazers","contributors_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/contributors","subscribers_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/subscribers","subscription_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/subscription","commits_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/commits{/sha}","git_commits_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/git/commits{/sha}","comments_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/comments{/number}","issue_comment_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/issues/comments{/number}","contents_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/contents/{+path}","compare_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/merges","archive_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/downloads","issues_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/issues{/number}","pulls_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/pulls{/number}","milestones_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/milestones{/number}","notifications_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/labels{/name}","releases_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/releases{/id}","deployments_url":"https://api.github.com/repos/Leonidas-from-XIV/ocaml-safepass/deployments","created_at":"2018-06-19T13:47:21Z","updated_at":"2018-06-19T13:47:23Z","pushed_at":"2018-06-20T15:05:46Z","git_url":"git://github.com/Leonidas-from-XIV/ocaml-safepass.git","ssh_url":"git@github.com:Leonidas-from-XIV/ocaml-safepass.git","clone_url":"https://github.com/Leonidas-from-XIV/ocaml-safepass.git","svn_url":"https://github.com/Leonidas-from-XIV/ocaml-safepass","homepage":null,"size":123,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"darioteixeira:master","ref":"master","sha":"545a3f6287ff95db54ac538e6ad1b237eb7f10d6","user":{"login":"darioteixeira","id":2505511,"node_id":"MDQ6VXNlcjI1MDU1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2505511?v=4","gravatar_id":"","url":"https://api.github.com/users/darioteixeira","html_url":"https://github.com/darioteixeira","followers_url":"https://api.github.com/users/darioteixeira/followers","following_url":"https://api.github.com/users/darioteixeira/following{/other_user}","gists_url":"https://api.github.com/users/darioteixeira/gists{/gist_id}","starred_url":"https://api.github.com/users/darioteixeira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darioteixeira/subscriptions","organizations_url":"https://api.github.com/users/darioteixeira/orgs","repos_url":"https://api.github.com/users/darioteixeira/repos","events_url":"https://api.github.com/users/darioteixeira/events{/privacy}","received_events_url":"https://api.github.com/users/darioteixeira/received_events","type":"User","site_admin":false},"repo":{"id":13220479,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIyMDQ3OQ==","name":"ocaml-safepass","full_name":"darioteixeira/ocaml-safepass","owner":{"login":"darioteixeira","id":2505511,"node_id":"MDQ6VXNlcjI1MDU1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2505511?v=4","gravatar_id":"","url":"https://api.github.com/users/darioteixeira","html_url":"https://github.com/darioteixeira","followers_url":"https://api.github.com/users/darioteixeira/followers","following_url":"https://api.github.com/users/darioteixeira/following{/other_user}","gists_url":"https://api.github.com/users/darioteixeira/gists{/gist_id}","starred_url":"https://api.github.com/users/darioteixeira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darioteixeira/subscriptions","organizations_url":"https://api.github.com/users/darioteixeira/orgs","repos_url":"https://api.github.com/users/darioteixeira/repos","events_url":"https://api.github.com/users/darioteixeira/events{/privacy}","received_events_url":"https://api.github.com/users/darioteixeira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darioteixeira/ocaml-safepass","description":"OCaml-safepass is a library enabling the safe storage of user passwords, for use in web applications","fork":false,"url":"https://api.github.com/repos/darioteixeira/ocaml-safepass","forks_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/forks","keys_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/teams","hooks_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/hooks","issue_events_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/issues/events{/number}","events_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/events","assignees_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/assignees{/user}","branches_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/branches{/branch}","tags_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/tags","blobs_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/git/refs{/sha}","trees_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/statuses/{sha}","languages_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/languages","stargazers_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/stargazers","contributors_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/contributors","subscribers_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/subscribers","subscription_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/subscription","commits_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/commits{/sha}","git_commits_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/git/commits{/sha}","comments_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/comments{/number}","issue_comment_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/issues/comments{/number}","contents_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/contents/{+path}","compare_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/merges","archive_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/downloads","issues_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/issues{/number}","pulls_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/pulls{/number}","milestones_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/milestones{/number}","notifications_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/labels{/name}","releases_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/releases{/id}","deployments_url":"https://api.github.com/repos/darioteixeira/ocaml-safepass/deployments","created_at":"2013-09-30T16:23:12Z","updated_at":"2018-06-20T11:34:51Z","pushed_at":"2018-06-25T09:43:45Z","git_url":"git://github.com/darioteixeira/ocaml-safepass.git","ssh_url":"git@github.com:darioteixeira/ocaml-safepass.git","clone_url":"https://github.com/darioteixeira/ocaml-safepass.git","svn_url":"https://github.com/darioteixeira/ocaml-safepass","homepage":null,"size":116,"stargazers_count":11,"watchers_count":11,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":3,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/darioteixeira/ocaml-safepass/pulls/4"},"html":{"href":"https://github.com/darioteixeira/ocaml-safepass/pull/4"},"issue":{"href":"https://api.github.com/repos/darioteixeira/ocaml-safepass/issues/4"},"comments":{"href":"https://api.github.com/repos/darioteixeira/ocaml-safepass/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/darioteixeira/ocaml-safepass/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/darioteixeira/ocaml-safepass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/darioteixeira/ocaml-safepass/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/darioteixeira/ocaml-safepass/statuses/c6bdaf1eacac484618d48a0238f9cd92377e40e3"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"darioteixeira","id":2505511,"node_id":"MDQ6VXNlcjI1MDU1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2505511?v=4","gravatar_id":"","url":"https://api.github.com/users/darioteixeira","html_url":"https://github.com/darioteixeira","followers_url":"https://api.github.com/users/darioteixeira/followers","following_url":"https://api.github.com/users/darioteixeira/following{/other_user}","gists_url":"https://api.github.com/users/darioteixeira/gists{/gist_id}","starred_url":"https://api.github.com/users/darioteixeira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darioteixeira/subscriptions","organizations_url":"https://api.github.com/users/darioteixeira/orgs","repos_url":"https://api.github.com/users/darioteixeira/repos","events_url":"https://api.github.com/users/darioteixeira/events{/privacy}","received_events_url":"https://api.github.com/users/darioteixeira/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":21,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"darioteixeira"}}