{"action":"created","comment":{"url":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/comments/236034871","pull_request_review_id":178043108,"id":236034871,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjAzNDg3MQ==","diff_hunk":"@@ -0,0 +1,70 @@\n+import {Metadata} from \"./metadata\";\n+import {ProtobufMessage} from \"./message\";\n+import {Code} from \"./Code\";\n+import {MethodDefinition} from \"./service\";\n+import {ClientRpcOptions} from \"./client\";\n+\n+const noop = () => void 0;","path":"client/grpc-web-client/src/middleware.ts","position":7,"original_position":7,"commit_id":"bc6b761bb98cabdc4a19870f18c8c9de72ba4f2d","original_commit_id":"bc6b761bb98cabdc4a19870f18c8c9de72ba4f2d","user":{"login":"jonnyreeves","id":200185,"node_id":"MDQ6VXNlcjIwMDE4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/200185?v=4","gravatar_id":"","url":"https://api.github.com/users/jonnyreeves","html_url":"https://github.com/jonnyreeves","followers_url":"https://api.github.com/users/jonnyreeves/followers","following_url":"https://api.github.com/users/jonnyreeves/following{/other_user}","gists_url":"https://api.github.com/users/jonnyreeves/gists{/gist_id}","starred_url":"https://api.github.com/users/jonnyreeves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonnyreeves/subscriptions","organizations_url":"https://api.github.com/users/jonnyreeves/orgs","repos_url":"https://api.github.com/users/jonnyreeves/repos","events_url":"https://api.github.com/users/jonnyreeves/events{/privacy}","received_events_url":"https://api.github.com/users/jonnyreeves/received_events","type":"User","site_admin":false},"body":"heh, for the 3 char saving, I think it's clearer to return `undefined` unless there's something I'm missing?","created_at":"2018-11-24T07:36:55Z","updated_at":"2018-11-24T07:36:55Z","html_url":"https://github.com/improbable-eng/grpc-web/pull/285#discussion_r236034871","pull_request_url":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/285","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/comments/236034871"},"html":{"href":"https://github.com/improbable-eng/grpc-web/pull/285#discussion_r236034871"},"pull_request":{"href":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/285"}}},"pull_request":{"url":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/285","id":232817066,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODE3MDY2","html_url":"https://github.com/improbable-eng/grpc-web/pull/285","diff_url":"https://github.com/improbable-eng/grpc-web/pull/285.diff","patch_url":"https://github.com/improbable-eng/grpc-web/pull/285.patch","issue_url":"https://api.github.com/repos/improbable-eng/grpc-web/issues/285","number":285,"state":"open","locked":false,"title":"gRPC web client middleware [WIP]","user":{"login":"easyCZ","id":1419286,"node_id":"MDQ6VXNlcjE0MTkyODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1419286?v=4","gravatar_id":"","url":"https://api.github.com/users/easyCZ","html_url":"https://github.com/easyCZ","followers_url":"https://api.github.com/users/easyCZ/followers","following_url":"https://api.github.com/users/easyCZ/following{/other_user}","gists_url":"https://api.github.com/users/easyCZ/gists{/gist_id}","starred_url":"https://api.github.com/users/easyCZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easyCZ/subscriptions","organizations_url":"https://api.github.com/users/easyCZ/orgs","repos_url":"https://api.github.com/users/easyCZ/repos","events_url":"https://api.github.com/users/easyCZ/events{/privacy}","received_events_url":"https://api.github.com/users/easyCZ/received_events","type":"User","site_admin":false},"body":"An implementation of the middleware pattern for the grpc-web-client.\r\n\r\n* A middleware allows requests to be intercepted and side-effects performed, ie *logging* or *timing*\r\n* Allows for a browser extension to be built acting as a middleware to show deserialized payloads, similar to Chrome's Network tab\r\n\r\nRemaining TODO:\r\n* [ ] Tests\r\n* [x] Example\r\n* [ ] Documentation\r\n\r\nDue to the type change on the request properties, this should be assumed to be a non-backwards compatible change and will require bumping of a major (pre-1.0) version","created_at":"2018-11-21T22:50:08Z","updated_at":"2018-11-24T07:36:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"384a8e5239fbc2120a722a001bb40cd5ad02d219","assignee":{"login":"easyCZ","id":1419286,"node_id":"MDQ6VXNlcjE0MTkyODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1419286?v=4","gravatar_id":"","url":"https://api.github.com/users/easyCZ","html_url":"https://github.com/easyCZ","followers_url":"https://api.github.com/users/easyCZ/followers","following_url":"https://api.github.com/users/easyCZ/following{/other_user}","gists_url":"https://api.github.com/users/easyCZ/gists{/gist_id}","starred_url":"https://api.github.com/users/easyCZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easyCZ/subscriptions","organizations_url":"https://api.github.com/users/easyCZ/orgs","repos_url":"https://api.github.com/users/easyCZ/repos","events_url":"https://api.github.com/users/easyCZ/events{/privacy}","received_events_url":"https://api.github.com/users/easyCZ/received_events","type":"User","site_admin":false},"assignees":[{"login":"easyCZ","id":1419286,"node_id":"MDQ6VXNlcjE0MTkyODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1419286?v=4","gravatar_id":"","url":"https://api.github.com/users/easyCZ","html_url":"https://github.com/easyCZ","followers_url":"https://api.github.com/users/easyCZ/followers","following_url":"https://api.github.com/users/easyCZ/following{/other_user}","gists_url":"https://api.github.com/users/easyCZ/gists{/gist_id}","starred_url":"https://api.github.com/users/easyCZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easyCZ/subscriptions","organizations_url":"https://api.github.com/users/easyCZ/orgs","repos_url":"https://api.github.com/users/easyCZ/repos","events_url":"https://api.github.com/users/easyCZ/events{/privacy}","received_events_url":"https://api.github.com/users/easyCZ/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/285/commits","review_comments_url":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/285/comments","review_comment_url":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/improbable-eng/grpc-web/issues/285/comments","statuses_url":"https://api.github.com/repos/improbable-eng/grpc-web/statuses/bc6b761bb98cabdc4a19870f18c8c9de72ba4f2d","head":{"label":"improbable-eng:feature/client-middleware","ref":"feature/client-middleware","sha":"bc6b761bb98cabdc4a19870f18c8c9de72ba4f2d","user":{"login":"improbable-eng","id":26084283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDg0Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"repo":{"id":64409189,"node_id":"MDEwOlJlcG9zaXRvcnk2NDQwOTE4OQ==","name":"grpc-web","full_name":"improbable-eng/grpc-web","private":false,"owner":{"login":"improbable-eng","id":26084283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDg0Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/improbable-eng/grpc-web","description":"gRPC Web implementation for Golang and TypeScript","fork":false,"url":"https://api.github.com/repos/improbable-eng/grpc-web","forks_url":"https://api.github.com/repos/improbable-eng/grpc-web/forks","keys_url":"https://api.github.com/repos/improbable-eng/grpc-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-eng/grpc-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-eng/grpc-web/teams","hooks_url":"https://api.github.com/repos/improbable-eng/grpc-web/hooks","issue_events_url":"https://api.github.com/repos/improbable-eng/grpc-web/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-eng/grpc-web/events","assignees_url":"https://api.github.com/repos/improbable-eng/grpc-web/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-eng/grpc-web/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-eng/grpc-web/tags","blobs_url":"https://api.github.com/repos/improbable-eng/grpc-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-eng/grpc-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-eng/grpc-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-eng/grpc-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-eng/grpc-web/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-eng/grpc-web/languages","stargazers_url":"https://api.github.com/repos/improbable-eng/grpc-web/stargazers","contributors_url":"https://api.github.com/repos/improbable-eng/grpc-web/contributors","subscribers_url":"https://api.github.com/repos/improbable-eng/grpc-web/subscribers","subscription_url":"https://api.github.com/repos/improbable-eng/grpc-web/subscription","commits_url":"https://api.github.com/repos/improbable-eng/grpc-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-eng/grpc-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-eng/grpc-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-eng/grpc-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-eng/grpc-web/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-eng/grpc-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-eng/grpc-web/merges","archive_url":"https://api.github.com/repos/improbable-eng/grpc-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-eng/grpc-web/downloads","issues_url":"https://api.github.com/repos/improbable-eng/grpc-web/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-eng/grpc-web/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-eng/grpc-web/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-eng/grpc-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-eng/grpc-web/labels{/name}","releases_url":"https://api.github.com/repos/improbable-eng/grpc-web/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-eng/grpc-web/deployments","created_at":"2016-07-28T15:58:43Z","updated_at":"2018-11-24T01:33:13Z","pushed_at":"2018-11-21T23:35:14Z","git_url":"git://github.com/improbable-eng/grpc-web.git","ssh_url":"git@github.com:improbable-eng/grpc-web.git","clone_url":"https://github.com/improbable-eng/grpc-web.git","svn_url":"https://github.com/improbable-eng/grpc-web","homepage":"","size":1278,"stargazers_count":1906,"watchers_count":1906,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":174,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":174,"open_issues":42,"watchers":1906,"default_branch":"master"}},"base":{"label":"improbable-eng:master","ref":"master","sha":"c99847a0e790e072db85718b5632156c4b4d0080","user":{"login":"improbable-eng","id":26084283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDg0Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"repo":{"id":64409189,"node_id":"MDEwOlJlcG9zaXRvcnk2NDQwOTE4OQ==","name":"grpc-web","full_name":"improbable-eng/grpc-web","private":false,"owner":{"login":"improbable-eng","id":26084283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDg0Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/improbable-eng/grpc-web","description":"gRPC Web implementation for Golang and TypeScript","fork":false,"url":"https://api.github.com/repos/improbable-eng/grpc-web","forks_url":"https://api.github.com/repos/improbable-eng/grpc-web/forks","keys_url":"https://api.github.com/repos/improbable-eng/grpc-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-eng/grpc-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-eng/grpc-web/teams","hooks_url":"https://api.github.com/repos/improbable-eng/grpc-web/hooks","issue_events_url":"https://api.github.com/repos/improbable-eng/grpc-web/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-eng/grpc-web/events","assignees_url":"https://api.github.com/repos/improbable-eng/grpc-web/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-eng/grpc-web/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-eng/grpc-web/tags","blobs_url":"https://api.github.com/repos/improbable-eng/grpc-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-eng/grpc-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-eng/grpc-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-eng/grpc-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-eng/grpc-web/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-eng/grpc-web/languages","stargazers_url":"https://api.github.com/repos/improbable-eng/grpc-web/stargazers","contributors_url":"https://api.github.com/repos/improbable-eng/grpc-web/contributors","subscribers_url":"https://api.github.com/repos/improbable-eng/grpc-web/subscribers","subscription_url":"https://api.github.com/repos/improbable-eng/grpc-web/subscription","commits_url":"https://api.github.com/repos/improbable-eng/grpc-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-eng/grpc-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-eng/grpc-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-eng/grpc-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-eng/grpc-web/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-eng/grpc-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-eng/grpc-web/merges","archive_url":"https://api.github.com/repos/improbable-eng/grpc-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-eng/grpc-web/downloads","issues_url":"https://api.github.com/repos/improbable-eng/grpc-web/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-eng/grpc-web/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-eng/grpc-web/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-eng/grpc-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-eng/grpc-web/labels{/name}","releases_url":"https://api.github.com/repos/improbable-eng/grpc-web/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-eng/grpc-web/deployments","created_at":"2016-07-28T15:58:43Z","updated_at":"2018-11-24T01:33:13Z","pushed_at":"2018-11-21T23:35:14Z","git_url":"git://github.com/improbable-eng/grpc-web.git","ssh_url":"git@github.com:improbable-eng/grpc-web.git","clone_url":"https://github.com/improbable-eng/grpc-web.git","svn_url":"https://github.com/improbable-eng/grpc-web","homepage":"","size":1278,"stargazers_count":1906,"watchers_count":1906,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":174,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":174,"open_issues":42,"watchers":1906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/285"},"html":{"href":"https://github.com/improbable-eng/grpc-web/pull/285"},"issue":{"href":"https://api.github.com/repos/improbable-eng/grpc-web/issues/285"},"comments":{"href":"https://api.github.com/repos/improbable-eng/grpc-web/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/improbable-eng/grpc-web/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/improbable-eng/grpc-web/statuses/bc6b761bb98cabdc4a19870f18c8c9de72ba4f2d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jonnyreeves"}}