{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/710","repository_url":"https://api.github.com/repos/spring-projects/spring-hateoas","labels_url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/710/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/710/comments","events_url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/710/events","html_url":"https://github.com/spring-projects/spring-hateoas/issues/710","id":322353899,"number":710,"title":"Link header full compliancy with RFC 5988","user":{"login":"Sir4ur0n","id":1204125,"avatar_url":"https://avatars3.githubusercontent.com/u/1204125?v=4","gravatar_id":"","url":"https://api.github.com/users/Sir4ur0n","html_url":"https://github.com/Sir4ur0n","followers_url":"https://api.github.com/users/Sir4ur0n/followers","following_url":"https://api.github.com/users/Sir4ur0n/following{/other_user}","gists_url":"https://api.github.com/users/Sir4ur0n/gists{/gist_id}","starred_url":"https://api.github.com/users/Sir4ur0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sir4ur0n/subscriptions","organizations_url":"https://api.github.com/users/Sir4ur0n/orgs","repos_url":"https://api.github.com/users/Sir4ur0n/repos","events_url":"https://api.github.com/users/Sir4ur0n/events{/privacy}","received_events_url":"https://api.github.com/users/Sir4ur0n/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-11T16:13:52Z","updated_at":"2018-05-14T11:02:13Z","closed_at":"2018-05-14T11:02:13Z","author_association":"NONE","body":"Hello,\r\n\r\nSpring HATEOAS seems to have at least partial support for web linking (as shown by class `org.springframework.hateoas.Links`) however its pattern does not support valid RFC 5988 headers.\r\n\r\nExample of header from the RFC: `<http://example.com/TheBook/chapter2>; rel=\"previous\";title=\"previous chapter\"`\r\n\r\nThis does not match `org.springframework.hateoas.Links#LINK_HEADER_PATTERN` because of the space between `;` and `rel`\r\n\r\nSome applications (e.g. JHipster) generate a Link header with space, thus `org.springframework.hateoas.Links#valueOf` does not parse its header.\r\n\r\nI admit I did not check if there are any other inconsistencies with the RFC, sorry about that, it's not exactly the most interesting RFC to read 😄 \r\n\r\nHere's the link to RFC 5988 about Web linking (Link header): https://tools.ietf.org/html/rfc5988\r\n\r\nBonus question: shouldn't `Links` and `Link` belong to spring-web instead of spring-hateoas? This way, there could be a method `public List<Link> getLinks()` or `public Links getLinks()` in `org.springframework.http.HttpHeaders`.\r\n\r\nCheers"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/comments/388778931","html_url":"https://github.com/spring-projects/spring-hateoas/issues/710#issuecomment-388778931","issue_url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/710","id":388778931,"user":{"login":"Sir4ur0n","id":1204125,"avatar_url":"https://avatars3.githubusercontent.com/u/1204125?v=4","gravatar_id":"","url":"https://api.github.com/users/Sir4ur0n","html_url":"https://github.com/Sir4ur0n","followers_url":"https://api.github.com/users/Sir4ur0n/followers","following_url":"https://api.github.com/users/Sir4ur0n/following{/other_user}","gists_url":"https://api.github.com/users/Sir4ur0n/gists{/gist_id}","starred_url":"https://api.github.com/users/Sir4ur0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sir4ur0n/subscriptions","organizations_url":"https://api.github.com/users/Sir4ur0n/orgs","repos_url":"https://api.github.com/users/Sir4ur0n/repos","events_url":"https://api.github.com/users/Sir4ur0n/events{/privacy}","received_events_url":"https://api.github.com/users/Sir4ur0n/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T11:02:12Z","updated_at":"2018-05-14T11:02:12Z","author_association":"NONE","body":"Hi @gregturn \r\n\r\nYou're right, I thought I had a recent version of Spring HATEOAS but apparently not, it's my bad :'(\r\nI see it's been fixed in recent versions (I dug up and found #686).\r\n\r\nSorry 😞 "}}
{"actor":{"display_login":"Sir4ur0n"}}