{"action":"opened","number":8091,"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/8091","id":240124443,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMTI0NDQz","html_url":"https://github.com/gradle/gradle/pull/8091","diff_url":"https://github.com/gradle/gradle/pull/8091.diff","patch_url":"https://github.com/gradle/gradle/pull/8091.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/8091","number":8091,"state":"open","locked":false,"title":"Update NTLM auth flags with the latest example code from HttpClient","user":{"login":"sbholmes","id":24832571,"node_id":"MDQ6VXNlcjI0ODMyNTcx","avatar_url":"https://avatars2.githubusercontent.com/u/24832571?v=4","gravatar_id":"","url":"https://api.github.com/users/sbholmes","html_url":"https://github.com/sbholmes","followers_url":"https://api.github.com/users/sbholmes/followers","following_url":"https://api.github.com/users/sbholmes/following{/other_user}","gists_url":"https://api.github.com/users/sbholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/sbholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbholmes/subscriptions","organizations_url":"https://api.github.com/users/sbholmes/orgs","repos_url":"https://api.github.com/users/sbholmes/repos","events_url":"https://api.github.com/users/sbholmes/events{/privacy}","received_events_url":"https://api.github.com/users/sbholmes/received_events","type":"User","site_admin":false},"body":"Issue: #8011\r\n\r\nSigned-off-by: Sam Holmes <sbholmes@gmail.com>\r\n\r\n### Context\r\nSee issue 8011 and for further context see the legacy issue here: https://discuss.gradle.org/t/issues-with-proxy-using-basic-authentication/13652\r\nI am unable to provide any new unit or integration tests - I've simply updated the original (copied) code with the latest version found at http://hc.apache.org/httpcomponents-client-ga/ntlm.html\r\n\r\n### Contributor Checklist\r\n- [x] [Review Contribution Guidelines](https://github.com/gradle/gradle/blob/master/CONTRIBUTING.md)\r\n- [x] Make sure that all commits are [signed off](https://git-scm.com/docs/git-commit#git-commit---signoff) to indicate that you agree to the terms of [Developer Certificate of Origin](https://developercertificate.org/).\r\n- [x] Check [\"Allow edit from maintainers\" option](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) in pull request so that additional changes can be pushed by Gradle team\r\n- [ ] Provide integration tests (under `<subproject>/src/integTest`) to verify changes from a user perspective\r\n- [ ] Provide unit tests (under `<subproject>/src/test`) to verify logic\r\n- [ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes\r\n- [x] Ensure that tests pass locally: `./gradlew <changed-subproject>:check`\r\n\r\n### Gradle Core Team Checklist\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation\r\n- [ ] Recognize contributor in release notes\r\n","created_at":"2018-12-20T10:40:36Z","updated_at":"2018-12-20T10:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/8091/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/8091/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/8091/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/7455f66f2999d80dc2576b30f360264a5a4f96db","head":{"label":"sbholmes:master","ref":"master","sha":"7455f66f2999d80dc2576b30f360264a5a4f96db","user":{"login":"sbholmes","id":24832571,"node_id":"MDQ6VXNlcjI0ODMyNTcx","avatar_url":"https://avatars2.githubusercontent.com/u/24832571?v=4","gravatar_id":"","url":"https://api.github.com/users/sbholmes","html_url":"https://github.com/sbholmes","followers_url":"https://api.github.com/users/sbholmes/followers","following_url":"https://api.github.com/users/sbholmes/following{/other_user}","gists_url":"https://api.github.com/users/sbholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/sbholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbholmes/subscriptions","organizations_url":"https://api.github.com/users/sbholmes/orgs","repos_url":"https://api.github.com/users/sbholmes/repos","events_url":"https://api.github.com/users/sbholmes/events{/privacy}","received_events_url":"https://api.github.com/users/sbholmes/received_events","type":"User","site_admin":false},"repo":{"id":162396291,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIzOTYyOTE=","name":"gradle","full_name":"sbholmes/gradle","private":false,"owner":{"login":"sbholmes","id":24832571,"node_id":"MDQ6VXNlcjI0ODMyNTcx","avatar_url":"https://avatars2.githubusercontent.com/u/24832571?v=4","gravatar_id":"","url":"https://api.github.com/users/sbholmes","html_url":"https://github.com/sbholmes","followers_url":"https://api.github.com/users/sbholmes/followers","following_url":"https://api.github.com/users/sbholmes/following{/other_user}","gists_url":"https://api.github.com/users/sbholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/sbholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbholmes/subscriptions","organizations_url":"https://api.github.com/users/sbholmes/orgs","repos_url":"https://api.github.com/users/sbholmes/repos","events_url":"https://api.github.com/users/sbholmes/events{/privacy}","received_events_url":"https://api.github.com/users/sbholmes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sbholmes/gradle","description":"Adaptable, fast automation for all","fork":true,"url":"https://api.github.com/repos/sbholmes/gradle","forks_url":"https://api.github.com/repos/sbholmes/gradle/forks","keys_url":"https://api.github.com/repos/sbholmes/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbholmes/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbholmes/gradle/teams","hooks_url":"https://api.github.com/repos/sbholmes/gradle/hooks","issue_events_url":"https://api.github.com/repos/sbholmes/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/sbholmes/gradle/events","assignees_url":"https://api.github.com/repos/sbholmes/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/sbholmes/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/sbholmes/gradle/tags","blobs_url":"https://api.github.com/repos/sbholmes/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbholmes/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbholmes/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbholmes/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbholmes/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/sbholmes/gradle/languages","stargazers_url":"https://api.github.com/repos/sbholmes/gradle/stargazers","contributors_url":"https://api.github.com/repos/sbholmes/gradle/contributors","subscribers_url":"https://api.github.com/repos/sbholmes/gradle/subscribers","subscription_url":"https://api.github.com/repos/sbholmes/gradle/subscription","commits_url":"https://api.github.com/repos/sbholmes/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbholmes/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbholmes/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbholmes/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbholmes/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/sbholmes/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbholmes/gradle/merges","archive_url":"https://api.github.com/repos/sbholmes/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbholmes/gradle/downloads","issues_url":"https://api.github.com/repos/sbholmes/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/sbholmes/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/sbholmes/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/sbholmes/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbholmes/gradle/labels{/name}","releases_url":"https://api.github.com/repos/sbholmes/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/sbholmes/gradle/deployments","created_at":"2018-12-19T07:02:04Z","updated_at":"2018-12-20T10:26:37Z","pushed_at":"2018-12-20T10:26:34Z","git_url":"git://github.com/sbholmes/gradle.git","ssh_url":"git@github.com:sbholmes/gradle.git","clone_url":"https://github.com/sbholmes/gradle.git","svn_url":"https://github.com/sbholmes/gradle","homepage":"https://gradle.org","size":245998,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gradle:master","ref":"master","sha":"e0ecd2e9d1a35ffacf862fdce349e4b41eb24754","user":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIzMjI=","name":"gradle","full_name":"gradle/gradle","private":false,"owner":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-12-20T09:51:19Z","pushed_at":"2018-12-20T10:32:30Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":246147,"stargazers_count":8106,"watchers_count":8106,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2440,"mirror_url":null,"archived":false,"open_issues_count":1361,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2440,"open_issues":1361,"watchers":8106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/8091"},"html":{"href":"https://github.com/gradle/gradle/pull/8091"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/8091"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/8091/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/8091/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/8091/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/7455f66f2999d80dc2576b30f360264a5a4f96db"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":24,"deletions":16,"changed_files":1}}
{"actor":{"display_login":"sbholmes"}}