{"action":"created","issue":{"url":"https://api.github.com/repos/google/earthenterprise/issues/697","repository_url":"https://api.github.com/repos/google/earthenterprise","labels_url":"https://api.github.com/repos/google/earthenterprise/issues/697/labels{/name}","comments_url":"https://api.github.com/repos/google/earthenterprise/issues/697/comments","events_url":"https://api.github.com/repos/google/earthenterprise/issues/697/events","html_url":"https://github.com/google/earthenterprise/pull/697","id":295304950,"number":697,"title":"test #668: Add unit tests for changes done for this fix","user":{"login":"tst-rwildes","id":34994386,"avatar_url":"https://avatars1.githubusercontent.com/u/34994386?v=4","gravatar_id":"","url":"https://api.github.com/users/tst-rwildes","html_url":"https://github.com/tst-rwildes","followers_url":"https://api.github.com/users/tst-rwildes/followers","following_url":"https://api.github.com/users/tst-rwildes/following{/other_user}","gists_url":"https://api.github.com/users/tst-rwildes/gists{/gist_id}","starred_url":"https://api.github.com/users/tst-rwildes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tst-rwildes/subscriptions","organizations_url":"https://api.github.com/users/tst-rwildes/orgs","repos_url":"https://api.github.com/users/tst-rwildes/repos","events_url":"https://api.github.com/users/tst-rwildes/events{/privacy}","received_events_url":"https://api.github.com/users/tst-rwildes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-07T21:48:07Z","updated_at":"2018-02-08T21:03:23Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/google/earthenterprise/pulls/697","html_url":"https://github.com/google/earthenterprise/pull/697","diff_url":"https://github.com/google/earthenterprise/pull/697.diff","patch_url":"https://github.com/google/earthenterprise/pull/697.patch"},"body":"Unit tests for changes done for fix of #668 "},"comment":{"url":"https://api.github.com/repos/google/earthenterprise/issues/comments/364247463","html_url":"https://github.com/google/earthenterprise/pull/697#issuecomment-364247463","issue_url":"https://api.github.com/repos/google/earthenterprise/issues/697","id":364247463,"user":{"login":"tst-rwildes","id":34994386,"avatar_url":"https://avatars1.githubusercontent.com/u/34994386?v=4","gravatar_id":"","url":"https://api.github.com/users/tst-rwildes","html_url":"https://github.com/tst-rwildes","followers_url":"https://api.github.com/users/tst-rwildes/followers","following_url":"https://api.github.com/users/tst-rwildes/following{/other_user}","gists_url":"https://api.github.com/users/tst-rwildes/gists{/gist_id}","starred_url":"https://api.github.com/users/tst-rwildes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tst-rwildes/subscriptions","organizations_url":"https://api.github.com/users/tst-rwildes/orgs","repos_url":"https://api.github.com/users/tst-rwildes/repos","events_url":"https://api.github.com/users/tst-rwildes/events{/privacy}","received_events_url":"https://api.github.com/users/tst-rwildes/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T21:03:23Z","updated_at":"2018-02-08T21:03:23Z","author_association":"COLLABORATOR","body":"@tst-nfarah I'm not sure if these are to high level or not to be termed 'unit tests' or if they are really functional tests.  I do 'mock' out a dependency but I also call methods that call other methods and even functions outside the class/method under test itself.  I like to lump tests into two broad categories: tests that can run at build time without installation/setup of product code and tests that require proper install/setup of full product before they can be run.  These tests are most defiantly of the former category.  I found tests that try to isolate things too much become less meaningful."}}
{"actor":{"display_login":"tst-rwildes"}}