{"action":"created","comment":{"url":"https://api.github.com/repos/lhc70000/iina/pulls/comments/184902678","pull_request_review_id":116186518,"id":184902678,"diff_hunk":"@@ -109,6 +109,9 @@\n \n \"track.none\" = \"<None>\";\n \n+\"subtrack.no_loaded\" = \"No subtitle loaded\";","path":"iina/Base.lproj/Localizable.strings","position":null,"original_position":4,"commit_id":"05d51842c5451e5d33d0a4318067cd1b56483d52","original_commit_id":"79b53ee262461613750d3bfcaa1f2b9f88c23f3f","user":{"login":"alejx","id":20237141,"avatar_url":"https://avatars0.githubusercontent.com/u/20237141?v=4","gravatar_id":"","url":"https://api.github.com/users/alejx","html_url":"https://github.com/alejx","followers_url":"https://api.github.com/users/alejx/followers","following_url":"https://api.github.com/users/alejx/following{/other_user}","gists_url":"https://api.github.com/users/alejx/gists{/gist_id}","starred_url":"https://api.github.com/users/alejx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejx/subscriptions","organizations_url":"https://api.github.com/users/alejx/orgs","repos_url":"https://api.github.com/users/alejx/repos","events_url":"https://api.github.com/users/alejx/events{/privacy}","received_events_url":"https://api.github.com/users/alejx/received_events","type":"User","site_admin":false},"body":"So it's because \"subtitle\" itself is usually in plural form, right?\r\n>  By the way, don't you need to update every instance of this, rather than just the ones you've done here?\r\n\r\nThose ones were generated by script, so I forgot them, sorry!","created_at":"2018-04-30T01:16:03Z","updated_at":"2018-04-30T01:16:03Z","html_url":"https://github.com/lhc70000/iina/pull/1656#discussion_r184902678","pull_request_url":"https://api.github.com/repos/lhc70000/iina/pulls/1656","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/comments/184902678"},"html":{"href":"https://github.com/lhc70000/iina/pull/1656#discussion_r184902678"},"pull_request":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/1656"}},"in_reply_to_id":184899968},"pull_request":{"url":"https://api.github.com/repos/lhc70000/iina/pulls/1656","id":184861116,"html_url":"https://github.com/lhc70000/iina/pull/1656","diff_url":"https://github.com/lhc70000/iina/pull/1656.diff","patch_url":"https://github.com/lhc70000/iina/pull/1656.patch","issue_url":"https://api.github.com/repos/lhc70000/iina/issues/1656","number":1656,"state":"open","locked":false,"title":"Add function to select None subtitle in menu, fix #1653","user":{"login":"alejx","id":20237141,"avatar_url":"https://avatars0.githubusercontent.com/u/20237141?v=4","gravatar_id":"","url":"https://api.github.com/users/alejx","html_url":"https://github.com/alejx","followers_url":"https://api.github.com/users/alejx/followers","following_url":"https://api.github.com/users/alejx/following{/other_user}","gists_url":"https://api.github.com/users/alejx/gists{/gist_id}","starred_url":"https://api.github.com/users/alejx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejx/subscriptions","organizations_url":"https://api.github.com/users/alejx/orgs","repos_url":"https://api.github.com/users/alejx/repos","events_url":"https://api.github.com/users/alejx/events{/privacy}","received_events_url":"https://api.github.com/users/alejx/received_events","type":"User","site_admin":false},"body":"- [x] This change has been discussed with the author.\r\n- [x] It implements / fixes issue #1653 .\r\n\r\n---\r\n\r\n**Description:**\r\nAdd function to select None subtitle in menu; use \"No subtitle loaded\" and \"No external subtitle found\" instead of \"\\<None\\>\" when no suitable subtitle.\r\n\r\nBefore: <img width=\"524\" alt=\"screen shot 2018-04-28 at 12 18 13\" src=\"https://user-images.githubusercontent.com/2270433/39394750-51598328-4ade-11e8-8fa0-79c0ef3334a8.png\">\r\n\r\nAfter: ![image](https://user-images.githubusercontent.com/20237141/39412015-d77a062e-4bda-11e8-8ed6-6747a4ca183f.png)\r\nClick \"\\<None\\>\" here now switch to \\<None\\>.\r\n\r\nIn case of there's no loaded subtitle and no external found:\r\n![image](https://user-images.githubusercontent.com/20237141/39412019-fa510986-4bda-11e8-8702-42054be99aae.png)\r\n\r\n","created_at":"2018-04-29T23:31:00Z","updated_at":"2018-04-30T01:16:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d510f5b1c2dbeb015afc897560a2b3dd4b2c1133","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lhc70000","id":8478049,"avatar_url":"https://avatars3.githubusercontent.com/u/8478049?v=4","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lhc70000/iina/pulls/1656/commits","review_comments_url":"https://api.github.com/repos/lhc70000/iina/pulls/1656/comments","review_comment_url":"https://api.github.com/repos/lhc70000/iina/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lhc70000/iina/issues/1656/comments","statuses_url":"https://api.github.com/repos/lhc70000/iina/statuses/05d51842c5451e5d33d0a4318067cd1b56483d52","head":{"label":"lhc70000:subtitle-menu","ref":"subtitle-menu","sha":"05d51842c5451e5d33d0a4318067cd1b56483d52","user":{"login":"lhc70000","id":8478049,"avatar_url":"https://avatars3.githubusercontent.com/u/8478049?v=4","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"repo":{"id":76838017,"name":"iina","full_name":"lhc70000/iina","owner":{"login":"lhc70000","id":8478049,"avatar_url":"https://avatars3.githubusercontent.com/u/8478049?v=4","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lhc70000/iina","description":"The modern video player for macOS.","fork":false,"url":"https://api.github.com/repos/lhc70000/iina","forks_url":"https://api.github.com/repos/lhc70000/iina/forks","keys_url":"https://api.github.com/repos/lhc70000/iina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lhc70000/iina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lhc70000/iina/teams","hooks_url":"https://api.github.com/repos/lhc70000/iina/hooks","issue_events_url":"https://api.github.com/repos/lhc70000/iina/issues/events{/number}","events_url":"https://api.github.com/repos/lhc70000/iina/events","assignees_url":"https://api.github.com/repos/lhc70000/iina/assignees{/user}","branches_url":"https://api.github.com/repos/lhc70000/iina/branches{/branch}","tags_url":"https://api.github.com/repos/lhc70000/iina/tags","blobs_url":"https://api.github.com/repos/lhc70000/iina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lhc70000/iina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lhc70000/iina/git/refs{/sha}","trees_url":"https://api.github.com/repos/lhc70000/iina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lhc70000/iina/statuses/{sha}","languages_url":"https://api.github.com/repos/lhc70000/iina/languages","stargazers_url":"https://api.github.com/repos/lhc70000/iina/stargazers","contributors_url":"https://api.github.com/repos/lhc70000/iina/contributors","subscribers_url":"https://api.github.com/repos/lhc70000/iina/subscribers","subscription_url":"https://api.github.com/repos/lhc70000/iina/subscription","commits_url":"https://api.github.com/repos/lhc70000/iina/commits{/sha}","git_commits_url":"https://api.github.com/repos/lhc70000/iina/git/commits{/sha}","comments_url":"https://api.github.com/repos/lhc70000/iina/comments{/number}","issue_comment_url":"https://api.github.com/repos/lhc70000/iina/issues/comments{/number}","contents_url":"https://api.github.com/repos/lhc70000/iina/contents/{+path}","compare_url":"https://api.github.com/repos/lhc70000/iina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lhc70000/iina/merges","archive_url":"https://api.github.com/repos/lhc70000/iina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lhc70000/iina/downloads","issues_url":"https://api.github.com/repos/lhc70000/iina/issues{/number}","pulls_url":"https://api.github.com/repos/lhc70000/iina/pulls{/number}","milestones_url":"https://api.github.com/repos/lhc70000/iina/milestones{/number}","notifications_url":"https://api.github.com/repos/lhc70000/iina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lhc70000/iina/labels{/name}","releases_url":"https://api.github.com/repos/lhc70000/iina/releases{/id}","deployments_url":"https://api.github.com/repos/lhc70000/iina/deployments","created_at":"2016-12-19T07:18:45Z","updated_at":"2018-04-30T01:04:46Z","pushed_at":"2018-04-30T01:04:41Z","git_url":"git://github.com/lhc70000/iina.git","ssh_url":"git@github.com:lhc70000/iina.git","clone_url":"https://github.com/lhc70000/iina.git","svn_url":"https://github.com/lhc70000/iina","homepage":"https://lhc70000.github.io/iina/","size":155331,"stargazers_count":11669,"watchers_count":11669,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":901,"mirror_url":null,"archived":false,"open_issues_count":496,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":901,"open_issues":496,"watchers":11669,"default_branch":"develop"}},"base":{"label":"lhc70000:develop","ref":"develop","sha":"ad5bb3a474ca5b27f79768a40cd4b90af6e47c21","user":{"login":"lhc70000","id":8478049,"avatar_url":"https://avatars3.githubusercontent.com/u/8478049?v=4","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"repo":{"id":76838017,"name":"iina","full_name":"lhc70000/iina","owner":{"login":"lhc70000","id":8478049,"avatar_url":"https://avatars3.githubusercontent.com/u/8478049?v=4","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lhc70000/iina","description":"The modern video player for macOS.","fork":false,"url":"https://api.github.com/repos/lhc70000/iina","forks_url":"https://api.github.com/repos/lhc70000/iina/forks","keys_url":"https://api.github.com/repos/lhc70000/iina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lhc70000/iina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lhc70000/iina/teams","hooks_url":"https://api.github.com/repos/lhc70000/iina/hooks","issue_events_url":"https://api.github.com/repos/lhc70000/iina/issues/events{/number}","events_url":"https://api.github.com/repos/lhc70000/iina/events","assignees_url":"https://api.github.com/repos/lhc70000/iina/assignees{/user}","branches_url":"https://api.github.com/repos/lhc70000/iina/branches{/branch}","tags_url":"https://api.github.com/repos/lhc70000/iina/tags","blobs_url":"https://api.github.com/repos/lhc70000/iina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lhc70000/iina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lhc70000/iina/git/refs{/sha}","trees_url":"https://api.github.com/repos/lhc70000/iina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lhc70000/iina/statuses/{sha}","languages_url":"https://api.github.com/repos/lhc70000/iina/languages","stargazers_url":"https://api.github.com/repos/lhc70000/iina/stargazers","contributors_url":"https://api.github.com/repos/lhc70000/iina/contributors","subscribers_url":"https://api.github.com/repos/lhc70000/iina/subscribers","subscription_url":"https://api.github.com/repos/lhc70000/iina/subscription","commits_url":"https://api.github.com/repos/lhc70000/iina/commits{/sha}","git_commits_url":"https://api.github.com/repos/lhc70000/iina/git/commits{/sha}","comments_url":"https://api.github.com/repos/lhc70000/iina/comments{/number}","issue_comment_url":"https://api.github.com/repos/lhc70000/iina/issues/comments{/number}","contents_url":"https://api.github.com/repos/lhc70000/iina/contents/{+path}","compare_url":"https://api.github.com/repos/lhc70000/iina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lhc70000/iina/merges","archive_url":"https://api.github.com/repos/lhc70000/iina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lhc70000/iina/downloads","issues_url":"https://api.github.com/repos/lhc70000/iina/issues{/number}","pulls_url":"https://api.github.com/repos/lhc70000/iina/pulls{/number}","milestones_url":"https://api.github.com/repos/lhc70000/iina/milestones{/number}","notifications_url":"https://api.github.com/repos/lhc70000/iina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lhc70000/iina/labels{/name}","releases_url":"https://api.github.com/repos/lhc70000/iina/releases{/id}","deployments_url":"https://api.github.com/repos/lhc70000/iina/deployments","created_at":"2016-12-19T07:18:45Z","updated_at":"2018-04-30T01:04:46Z","pushed_at":"2018-04-30T01:04:41Z","git_url":"git://github.com/lhc70000/iina.git","ssh_url":"git@github.com:lhc70000/iina.git","clone_url":"https://github.com/lhc70000/iina.git","svn_url":"https://github.com/lhc70000/iina","homepage":"https://lhc70000.github.io/iina/","size":155331,"stargazers_count":11669,"watchers_count":11669,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":901,"mirror_url":null,"archived":false,"open_issues_count":496,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":901,"open_issues":496,"watchers":11669,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/1656"},"html":{"href":"https://github.com/lhc70000/iina/pull/1656"},"issue":{"href":"https://api.github.com/repos/lhc70000/iina/issues/1656"},"comments":{"href":"https://api.github.com/repos/lhc70000/iina/issues/1656/comments"},"review_comments":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/1656/comments"},"review_comment":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/1656/commits"},"statuses":{"href":"https://api.github.com/repos/lhc70000/iina/statuses/05d51842c5451e5d33d0a4318067cd1b56483d52"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"alejx"}}