{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-container-networking/pulls/comments/192248921","pull_request_review_id":124988304,"id":192248921,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjI0ODkyMQ==","diff_hunk":"@@ -177,3 +151,39 @@ func (plugin *Plugin) Error(err error) *cniTypes.Error {\n func (plugin *Plugin) Errorf(format string, args ...interface{}) *cniTypes.Error {\n \treturn plugin.Error(fmt.Errorf(format, args...))\n }\n+\n+// Initialize key-value store\n+func (plugin *Plugin) InitializeKeyValueStore(config *common.PluginConfig) error {\n+\t// Create the key value store.\n+\tif plugin.Store == nil {\n+\t\tvar err error\n+\t\tplugin.Store, err = store.NewJsonFileStore(platform.CNIRuntimePath + plugin.Name + \".json\")\n+\t\tif err != nil {\n+\t\t\tlog.Printf(\"[cni] Failed to create store, err:%v.\", err)\n+\t\t\treturn err\n+\t\t}\n+\n+\t\t// Acquire store lock.\n+\t\terr = plugin.Store.Lock(true)\n+\t\tif err != nil {\n+\t\t\tlog.Printf(\"[cni] Timed out on locking store, err:%v.\", err)\n+\t\t\treturn err\n+\t\t}\n+\n+\t\tconfig.Store = plugin.Store\n+\t}","path":"cni/plugin.go","position":71,"original_position":71,"commit_id":"d3f20535c16ce7349e39e693bd79e0707d3ac4e2","original_commit_id":"d3f20535c16ce7349e39e693bd79e0707d3ac4e2","user":{"login":"tamilmani1989","id":1103826,"node_id":"MDQ6VXNlcjExMDM4MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1103826?v=4","gravatar_id":"","url":"https://api.github.com/users/tamilmani1989","html_url":"https://github.com/tamilmani1989","followers_url":"https://api.github.com/users/tamilmani1989/followers","following_url":"https://api.github.com/users/tamilmani1989/following{/other_user}","gists_url":"https://api.github.com/users/tamilmani1989/gists{/gist_id}","starred_url":"https://api.github.com/users/tamilmani1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamilmani1989/subscriptions","organizations_url":"https://api.github.com/users/tamilmani1989/orgs","repos_url":"https://api.github.com/users/tamilmani1989/repos","events_url":"https://api.github.com/users/tamilmani1989/events{/privacy}","received_events_url":"https://api.github.com/users/tamilmani1989/received_events","type":"User","site_admin":false},"body":"there should be a blank line before return","created_at":"2018-05-31T21:52:55Z","updated_at":"2018-05-31T22:03:17Z","html_url":"https://github.com/Azure/azure-container-networking/pull/161#discussion_r192248921","pull_request_url":"https://api.github.com/repos/Azure/azure-container-networking/pulls/161","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-container-networking/pulls/comments/192248921"},"html":{"href":"https://github.com/Azure/azure-container-networking/pull/161#discussion_r192248921"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-container-networking/pulls/161"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-container-networking/pulls/161","id":191838805,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODM4ODA1","html_url":"https://github.com/Azure/azure-container-networking/pull/161","diff_url":"https://github.com/Azure/azure-container-networking/pull/161.diff","patch_url":"https://github.com/Azure/azure-container-networking/pull/161.patch","issue_url":"https://api.github.com/repos/Azure/azure-container-networking/issues/161","number":161,"state":"open","locked":false,"title":"azure-vnet: Implement GET command","user":{"login":"ashvindeodhar","id":5004434,"node_id":"MDQ6VXNlcjUwMDQ0MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5004434?v=4","gravatar_id":"","url":"https://api.github.com/users/ashvindeodhar","html_url":"https://github.com/ashvindeodhar","followers_url":"https://api.github.com/users/ashvindeodhar/followers","following_url":"https://api.github.com/users/ashvindeodhar/following{/other_user}","gists_url":"https://api.github.com/users/ashvindeodhar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashvindeodhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashvindeodhar/subscriptions","organizations_url":"https://api.github.com/users/ashvindeodhar/orgs","repos_url":"https://api.github.com/users/ashvindeodhar/repos","events_url":"https://api.github.com/users/ashvindeodhar/events{/privacy}","received_events_url":"https://api.github.com/users/ashvindeodhar/received_events","type":"User","site_admin":false},"body":"CNI spec has added a new method : GET which allows the runtime / orchestrator to query the current state of the container networking configuration. This change adds the implementation for the GET method in azure-vnet plugin. The supported version changes to 0.4.0 to support GET API.\r\nThis PR fixes #148  ","created_at":"2018-05-31T18:36:36Z","updated_at":"2018-05-31T22:03:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1cc210cb359c32fe70987cd410e6bd364f29ad9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"saiyan86","id":6934678,"node_id":"MDQ6VXNlcjY5MzQ2Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6934678?v=4","gravatar_id":"","url":"https://api.github.com/users/saiyan86","html_url":"https://github.com/saiyan86","followers_url":"https://api.github.com/users/saiyan86/followers","following_url":"https://api.github.com/users/saiyan86/following{/other_user}","gists_url":"https://api.github.com/users/saiyan86/gists{/gist_id}","starred_url":"https://api.github.com/users/saiyan86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saiyan86/subscriptions","organizations_url":"https://api.github.com/users/saiyan86/orgs","repos_url":"https://api.github.com/users/saiyan86/repos","events_url":"https://api.github.com/users/saiyan86/events{/privacy}","received_events_url":"https://api.github.com/users/saiyan86/received_events","type":"User","site_admin":false},{"login":"sharmasushant","id":10674627,"node_id":"MDQ6VXNlcjEwNjc0NjI3","avatar_url":"https://avatars2.githubusercontent.com/u/10674627?v=4","gravatar_id":"","url":"https://api.github.com/users/sharmasushant","html_url":"https://github.com/sharmasushant","followers_url":"https://api.github.com/users/sharmasushant/followers","following_url":"https://api.github.com/users/sharmasushant/following{/other_user}","gists_url":"https://api.github.com/users/sharmasushant/gists{/gist_id}","starred_url":"https://api.github.com/users/sharmasushant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharmasushant/subscriptions","organizations_url":"https://api.github.com/users/sharmasushant/orgs","repos_url":"https://api.github.com/users/sharmasushant/repos","events_url":"https://api.github.com/users/sharmasushant/events{/privacy}","received_events_url":"https://api.github.com/users/sharmasushant/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-container-networking/pulls/161/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-container-networking/pulls/161/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-container-networking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-container-networking/issues/161/comments","statuses_url":"https://api.github.com/repos/Azure/azure-container-networking/statuses/d3f20535c16ce7349e39e693bd79e0707d3ac4e2","head":{"label":"ashvindeodhar:b-get-impl","ref":"b-get-impl","sha":"d3f20535c16ce7349e39e693bd79e0707d3ac4e2","user":{"login":"ashvindeodhar","id":5004434,"node_id":"MDQ6VXNlcjUwMDQ0MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5004434?v=4","gravatar_id":"","url":"https://api.github.com/users/ashvindeodhar","html_url":"https://github.com/ashvindeodhar","followers_url":"https://api.github.com/users/ashvindeodhar/followers","following_url":"https://api.github.com/users/ashvindeodhar/following{/other_user}","gists_url":"https://api.github.com/users/ashvindeodhar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashvindeodhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashvindeodhar/subscriptions","organizations_url":"https://api.github.com/users/ashvindeodhar/orgs","repos_url":"https://api.github.com/users/ashvindeodhar/repos","events_url":"https://api.github.com/users/ashvindeodhar/events{/privacy}","received_events_url":"https://api.github.com/users/ashvindeodhar/received_events","type":"User","site_admin":false},"repo":{"id":134636538,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2MzY1Mzg=","name":"azure-container-networking","full_name":"ashvindeodhar/azure-container-networking","owner":{"login":"ashvindeodhar","id":5004434,"node_id":"MDQ6VXNlcjUwMDQ0MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5004434?v=4","gravatar_id":"","url":"https://api.github.com/users/ashvindeodhar","html_url":"https://github.com/ashvindeodhar","followers_url":"https://api.github.com/users/ashvindeodhar/followers","following_url":"https://api.github.com/users/ashvindeodhar/following{/other_user}","gists_url":"https://api.github.com/users/ashvindeodhar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashvindeodhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashvindeodhar/subscriptions","organizations_url":"https://api.github.com/users/ashvindeodhar/orgs","repos_url":"https://api.github.com/users/ashvindeodhar/repos","events_url":"https://api.github.com/users/ashvindeodhar/events{/privacy}","received_events_url":"https://api.github.com/users/ashvindeodhar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashvindeodhar/azure-container-networking","description":"Azure Container Networking Plugins for Linux and Windows Containers","fork":true,"url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking","forks_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/forks","keys_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/teams","hooks_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/hooks","issue_events_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/issues/events{/number}","events_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/events","assignees_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/assignees{/user}","branches_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/branches{/branch}","tags_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/tags","blobs_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/statuses/{sha}","languages_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/languages","stargazers_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/stargazers","contributors_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/contributors","subscribers_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/subscribers","subscription_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/subscription","commits_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/contents/{+path}","compare_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/merges","archive_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/downloads","issues_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/issues{/number}","pulls_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/pulls{/number}","milestones_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/milestones{/number}","notifications_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/labels{/name}","releases_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/releases{/id}","deployments_url":"https://api.github.com/repos/ashvindeodhar/azure-container-networking/deployments","created_at":"2018-05-23T23:35:04Z","updated_at":"2018-05-23T23:35:06Z","pushed_at":"2018-05-31T18:19:04Z","git_url":"git://github.com/ashvindeodhar/azure-container-networking.git","ssh_url":"git@github.com:ashvindeodhar/azure-container-networking.git","clone_url":"https://github.com/ashvindeodhar/azure-container-networking.git","svn_url":"https://github.com/ashvindeodhar/azure-container-networking","homepage":"","size":4430,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"91b5e634a743abbf52c54f6e1bbdf653e76ba83c","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":53971519,"node_id":"MDEwOlJlcG9zaXRvcnk1Mzk3MTUxOQ==","name":"azure-container-networking","full_name":"Azure/azure-container-networking","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-container-networking","description":"Azure Container Networking Plugins for Linux and Windows Containers","fork":false,"url":"https://api.github.com/repos/Azure/azure-container-networking","forks_url":"https://api.github.com/repos/Azure/azure-container-networking/forks","keys_url":"https://api.github.com/repos/Azure/azure-container-networking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-container-networking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-container-networking/teams","hooks_url":"https://api.github.com/repos/Azure/azure-container-networking/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-container-networking/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-container-networking/events","assignees_url":"https://api.github.com/repos/Azure/azure-container-networking/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-container-networking/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-container-networking/tags","blobs_url":"https://api.github.com/repos/Azure/azure-container-networking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-container-networking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-container-networking/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-container-networking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-container-networking/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-container-networking/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-container-networking/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-container-networking/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-container-networking/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-container-networking/subscription","commits_url":"https://api.github.com/repos/Azure/azure-container-networking/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-container-networking/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-container-networking/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-container-networking/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-container-networking/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-container-networking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-container-networking/merges","archive_url":"https://api.github.com/repos/Azure/azure-container-networking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-container-networking/downloads","issues_url":"https://api.github.com/repos/Azure/azure-container-networking/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-container-networking/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-container-networking/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-container-networking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-container-networking/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-container-networking/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-container-networking/deployments","created_at":"2016-03-15T19:12:14Z","updated_at":"2018-05-31T21:49:21Z","pushed_at":"2018-05-31T21:49:18Z","git_url":"git://github.com/Azure/azure-container-networking.git","ssh_url":"git@github.com:Azure/azure-container-networking.git","clone_url":"https://github.com/Azure/azure-container-networking.git","svn_url":"https://github.com/Azure/azure-container-networking","homepage":"","size":4429,"stargazers_count":59,"watchers_count":59,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":26,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-container-networking/pulls/161"},"html":{"href":"https://github.com/Azure/azure-container-networking/pull/161"},"issue":{"href":"https://api.github.com/repos/Azure/azure-container-networking/issues/161"},"comments":{"href":"https://api.github.com/repos/Azure/azure-container-networking/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-container-networking/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-container-networking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-container-networking/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-container-networking/statuses/d3f20535c16ce7349e39e693bd79e0707d3ac4e2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tamilmani1989"}}