{"action":"created","comment":{"url":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments/175314988","pull_request_review_id":104822550,"id":175314988,"diff_hunk":"@@ -37,15 +38,17 @@ def find_disk(vm, cmd):\n         \"\"\"\n         Find all disks in guest.\n         \"\"\"\n+        session = vm.wait_for_login(timeout=timeout)\n         if params.get(\"os_type\") == \"linux\":\n             pattern = params.get(\"get_disk_pattern\", \"^/dev/vd[a-z]*$\")\n         elif params.get(\"os_type\") == \"windows\":\n+            disk_rescan_cmd = params.get(\"disk_rescan_cmd\")","path":"qemu/tests/block_hotplug.py","position":16,"original_position":16,"commit_id":"7a692af561ac645ef3d8e1e6ee1474b2225643ca","original_commit_id":"7a692af561ac645ef3d8e1e6ee1474b2225643ca","user":{"login":"peixiu","id":23209767,"avatar_url":"https://avatars3.githubusercontent.com/u/23209767?v=4","gravatar_id":"","url":"https://api.github.com/users/peixiu","html_url":"https://github.com/peixiu","followers_url":"https://api.github.com/users/peixiu/followers","following_url":"https://api.github.com/users/peixiu/following{/other_user}","gists_url":"https://api.github.com/users/peixiu/gists{/gist_id}","starred_url":"https://api.github.com/users/peixiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peixiu/subscriptions","organizations_url":"https://api.github.com/users/peixiu/orgs","repos_url":"https://api.github.com/users/peixiu/repos","events_url":"https://api.github.com/users/peixiu/events{/privacy}","received_events_url":"https://api.github.com/users/peixiu/received_events","type":"User","site_admin":false},"body":"Hi coli, please refer to the aliang's last comment, she suggest to replace the time.sleep(5) with rescan operation, due to not sue if 5 seconds is enough for guest rescan, so add a force rescan here.","created_at":"2018-03-19T01:29:43Z","updated_at":"2018-03-19T01:29:43Z","html_url":"https://github.com/autotest/tp-qemu/pull/1244#discussion_r175314988","pull_request_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1244","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments/175314988"},"html":{"href":"https://github.com/autotest/tp-qemu/pull/1244#discussion_r175314988"},"pull_request":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1244"}},"in_reply_to_id":173394886},"pull_request":{"url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1244","id":172781516,"html_url":"https://github.com/autotest/tp-qemu/pull/1244","diff_url":"https://github.com/autotest/tp-qemu/pull/1244.diff","patch_url":"https://github.com/autotest/tp-qemu/pull/1244.patch","issue_url":"https://api.github.com/repos/autotest/tp-qemu/issues/1244","number":1244,"state":"open","locked":false,"title":"Add verify_unplug() for controller","user":{"login":"peixiu","id":23209767,"avatar_url":"https://avatars3.githubusercontent.com/u/23209767?v=4","gravatar_id":"","url":"https://api.github.com/users/peixiu","html_url":"https://github.com/peixiu","followers_url":"https://api.github.com/users/peixiu/followers","following_url":"https://api.github.com/users/peixiu/following{/other_user}","gists_url":"https://api.github.com/users/peixiu/gists{/gist_id}","starred_url":"https://api.github.com/users/peixiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peixiu/subscriptions","organizations_url":"https://api.github.com/users/peixiu/orgs","repos_url":"https://api.github.com/users/peixiu/repos","events_url":"https://api.github.com/users/peixiu/events{/privacy}","received_events_url":"https://api.github.com/users/peixiu/received_events","type":"User","site_admin":false},"body":"1. Add verify_unplug() for controller.\r\n2. As our test experience before, after hot-unplug disk,\r\nthe guest will rescan the system device (include controller) automaticly,\r\nif not waiting this progress finished, do hotunplug immediatly,\r\nmay cannot delete this controller success(the guest cannot allow to delete a using device),\r\nso here add a few seconds sleep time after hot-unplug disk and controller\r\n\r\nid: 1549937\r\n\r\nSigned-off-by: Peixiu Hou <phou@redhat.com>","created_at":"2018-03-05T06:04:53Z","updated_at":"2018-03-19T01:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4daaa16286bda27a51a20d1ca3165e71b245a20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1244/commits","review_comments_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/1244/comments","review_comment_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/tp-qemu/issues/1244/comments","statuses_url":"https://api.github.com/repos/autotest/tp-qemu/statuses/7a692af561ac645ef3d8e1e6ee1474b2225643ca","head":{"label":"peixiu:bug1549937","ref":"bug1549937","sha":"7a692af561ac645ef3d8e1e6ee1474b2225643ca","user":{"login":"peixiu","id":23209767,"avatar_url":"https://avatars3.githubusercontent.com/u/23209767?v=4","gravatar_id":"","url":"https://api.github.com/users/peixiu","html_url":"https://github.com/peixiu","followers_url":"https://api.github.com/users/peixiu/followers","following_url":"https://api.github.com/users/peixiu/following{/other_user}","gists_url":"https://api.github.com/users/peixiu/gists{/gist_id}","starred_url":"https://api.github.com/users/peixiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peixiu/subscriptions","organizations_url":"https://api.github.com/users/peixiu/orgs","repos_url":"https://api.github.com/users/peixiu/repos","events_url":"https://api.github.com/users/peixiu/events{/privacy}","received_events_url":"https://api.github.com/users/peixiu/received_events","type":"User","site_admin":false},"repo":{"id":102077664,"name":"tp-qemu","full_name":"peixiu/tp-qemu","owner":{"login":"peixiu","id":23209767,"avatar_url":"https://avatars3.githubusercontent.com/u/23209767?v=4","gravatar_id":"","url":"https://api.github.com/users/peixiu","html_url":"https://github.com/peixiu","followers_url":"https://api.github.com/users/peixiu/followers","following_url":"https://api.github.com/users/peixiu/following{/other_user}","gists_url":"https://api.github.com/users/peixiu/gists{/gist_id}","starred_url":"https://api.github.com/users/peixiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peixiu/subscriptions","organizations_url":"https://api.github.com/users/peixiu/orgs","repos_url":"https://api.github.com/users/peixiu/repos","events_url":"https://api.github.com/users/peixiu/events{/privacy}","received_events_url":"https://api.github.com/users/peixiu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peixiu/tp-qemu","description":"Virt Test Provider for qemu and other related virtualization backends","fork":true,"url":"https://api.github.com/repos/peixiu/tp-qemu","forks_url":"https://api.github.com/repos/peixiu/tp-qemu/forks","keys_url":"https://api.github.com/repos/peixiu/tp-qemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peixiu/tp-qemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peixiu/tp-qemu/teams","hooks_url":"https://api.github.com/repos/peixiu/tp-qemu/hooks","issue_events_url":"https://api.github.com/repos/peixiu/tp-qemu/issues/events{/number}","events_url":"https://api.github.com/repos/peixiu/tp-qemu/events","assignees_url":"https://api.github.com/repos/peixiu/tp-qemu/assignees{/user}","branches_url":"https://api.github.com/repos/peixiu/tp-qemu/branches{/branch}","tags_url":"https://api.github.com/repos/peixiu/tp-qemu/tags","blobs_url":"https://api.github.com/repos/peixiu/tp-qemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peixiu/tp-qemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peixiu/tp-qemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/peixiu/tp-qemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peixiu/tp-qemu/statuses/{sha}","languages_url":"https://api.github.com/repos/peixiu/tp-qemu/languages","stargazers_url":"https://api.github.com/repos/peixiu/tp-qemu/stargazers","contributors_url":"https://api.github.com/repos/peixiu/tp-qemu/contributors","subscribers_url":"https://api.github.com/repos/peixiu/tp-qemu/subscribers","subscription_url":"https://api.github.com/repos/peixiu/tp-qemu/subscription","commits_url":"https://api.github.com/repos/peixiu/tp-qemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/peixiu/tp-qemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/peixiu/tp-qemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/peixiu/tp-qemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/peixiu/tp-qemu/contents/{+path}","compare_url":"https://api.github.com/repos/peixiu/tp-qemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peixiu/tp-qemu/merges","archive_url":"https://api.github.com/repos/peixiu/tp-qemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peixiu/tp-qemu/downloads","issues_url":"https://api.github.com/repos/peixiu/tp-qemu/issues{/number}","pulls_url":"https://api.github.com/repos/peixiu/tp-qemu/pulls{/number}","milestones_url":"https://api.github.com/repos/peixiu/tp-qemu/milestones{/number}","notifications_url":"https://api.github.com/repos/peixiu/tp-qemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peixiu/tp-qemu/labels{/name}","releases_url":"https://api.github.com/repos/peixiu/tp-qemu/releases{/id}","deployments_url":"https://api.github.com/repos/peixiu/tp-qemu/deployments","created_at":"2017-09-01T05:41:35Z","updated_at":"2017-09-01T05:41:39Z","pushed_at":"2018-03-07T10:39:55Z","git_url":"git://github.com/peixiu/tp-qemu.git","ssh_url":"git@github.com:peixiu/tp-qemu.git","clone_url":"https://github.com/peixiu/tp-qemu.git","svn_url":"https://github.com/peixiu/tp-qemu","homepage":null,"size":14195,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"bd33606601840b59ef2b039a1f4903f9769818f9","user":{"login":"autotest","id":472856,"avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":16180304,"name":"tp-qemu","full_name":"autotest/tp-qemu","owner":{"login":"autotest","id":472856,"avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/tp-qemu","description":"Virt Test Provider for qemu and other related virtualization backends","fork":false,"url":"https://api.github.com/repos/autotest/tp-qemu","forks_url":"https://api.github.com/repos/autotest/tp-qemu/forks","keys_url":"https://api.github.com/repos/autotest/tp-qemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/tp-qemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/tp-qemu/teams","hooks_url":"https://api.github.com/repos/autotest/tp-qemu/hooks","issue_events_url":"https://api.github.com/repos/autotest/tp-qemu/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/tp-qemu/events","assignees_url":"https://api.github.com/repos/autotest/tp-qemu/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/tp-qemu/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/tp-qemu/tags","blobs_url":"https://api.github.com/repos/autotest/tp-qemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/tp-qemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/tp-qemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/tp-qemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/tp-qemu/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/tp-qemu/languages","stargazers_url":"https://api.github.com/repos/autotest/tp-qemu/stargazers","contributors_url":"https://api.github.com/repos/autotest/tp-qemu/contributors","subscribers_url":"https://api.github.com/repos/autotest/tp-qemu/subscribers","subscription_url":"https://api.github.com/repos/autotest/tp-qemu/subscription","commits_url":"https://api.github.com/repos/autotest/tp-qemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/tp-qemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/tp-qemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/tp-qemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/tp-qemu/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/tp-qemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/tp-qemu/merges","archive_url":"https://api.github.com/repos/autotest/tp-qemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/tp-qemu/downloads","issues_url":"https://api.github.com/repos/autotest/tp-qemu/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/tp-qemu/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/tp-qemu/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/tp-qemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/tp-qemu/labels{/name}","releases_url":"https://api.github.com/repos/autotest/tp-qemu/releases{/id}","deployments_url":"https://api.github.com/repos/autotest/tp-qemu/deployments","created_at":"2014-01-23T17:51:34Z","updated_at":"2018-03-16T10:54:26Z","pushed_at":"2018-03-16T10:54:18Z","git_url":"git://github.com/autotest/tp-qemu.git","ssh_url":"git@github.com:autotest/tp-qemu.git","clone_url":"https://github.com/autotest/tp-qemu.git","svn_url":"https://github.com/autotest/tp-qemu","homepage":null,"size":14230,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":111,"open_issues":63,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1244"},"html":{"href":"https://github.com/autotest/tp-qemu/pull/1244"},"issue":{"href":"https://api.github.com/repos/autotest/tp-qemu/issues/1244"},"comments":{"href":"https://api.github.com/repos/autotest/tp-qemu/issues/1244/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1244/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/1244/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/tp-qemu/statuses/7a692af561ac645ef3d8e1e6ee1474b2225643ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"peixiu"}}