{"action":"created","comment":{"url":"https://api.github.com/repos/robotology/yarp/pulls/comments/192393110","pull_request_review_id":125163833,"id":192393110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjM5MzExMA==","diff_hunk":"@@ -0,0 +1,223 @@\n+/*\n+ * Copyright (C) 2006-2018 Istituto Italiano di Tecnologia (IIT)\n+ * Copyright (C) 2006-2010 RobotCub Consortium\n+ * All rights reserved.\n+ *\n+ * This software may be modified and distributed under the terms of the\n+ * BSD-3-Clause license. See the accompanying LICENSE file for details.\n+ */\n+\n+#ifndef YARP_OS_PERIODICTHREAD_H\n+#define YARP_OS_PERIODICTHREAD_H\n+\n+#include <yarp/os/Runnable.h>\n+\n+/**\n+ * \\ingroup key_class\n+ *\n+ * An abstraction for a periodic thread.\n+ */\n+namespace yarp {\n+namespace os {\n+\n+class YARP_OS_API PeriodicThread\n+{\n+public:\n+\n+    /**\n+     * Constructor.  Thread begins in a dormant state.  Call PeriodicThread::start\n+     * to get things going.\n+     * @param period The period in seconds [sec] between\n+     * successive calls to the RateThread::run method\n+     * (remember you need to call RateThread::start first\n+     * before anything happens)\n+     * @param useSystemClock whether the thread should always\n+     * use the system clock, or depend on the current\n+     * configuration of the network.\n+     */\n+    explicit PeriodicThread(double period, bool useSystemClock = false);","path":"src/libYARP_OS/include/yarp/os/PeriodicThread.h","position":38,"original_position":38,"commit_id":"148de1633c52e9489025a6be9af126f9befe3d36","original_commit_id":"148de1633c52e9489025a6be9af126f9befe3d36","user":{"login":"barbalberto","id":4061020,"node_id":"MDQ6VXNlcjQwNjEwMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/4061020?v=4","gravatar_id":"","url":"https://api.github.com/users/barbalberto","html_url":"https://github.com/barbalberto","followers_url":"https://api.github.com/users/barbalberto/followers","following_url":"https://api.github.com/users/barbalberto/following{/other_user}","gists_url":"https://api.github.com/users/barbalberto/gists{/gist_id}","starred_url":"https://api.github.com/users/barbalberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barbalberto/subscriptions","organizations_url":"https://api.github.com/users/barbalberto/orgs","repos_url":"https://api.github.com/users/barbalberto/repos","events_url":"https://api.github.com/users/barbalberto/events{/privacy}","received_events_url":"https://api.github.com/users/barbalberto/received_events","type":"User","site_admin":false},"body":"I like the idea too.\r\nIf we want to use enums, there is already the `yarpClockType` defined in Time.h, maybe we can use that one\r\n\r\n","created_at":"2018-06-01T13:20:24Z","updated_at":"2018-06-01T13:20:24Z","html_url":"https://github.com/robotology/yarp/pull/1718#discussion_r192393110","pull_request_url":"https://api.github.com/repos/robotology/yarp/pulls/1718","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/robotology/yarp/pulls/comments/192393110"},"html":{"href":"https://github.com/robotology/yarp/pull/1718#discussion_r192393110"},"pull_request":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1718"}},"in_reply_to_id":192360462},"pull_request":{"url":"https://api.github.com/repos/robotology/yarp/pulls/1718","id":191841692,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODQxNjky","html_url":"https://github.com/robotology/yarp/pull/1718","diff_url":"https://github.com/robotology/yarp/pull/1718.diff","patch_url":"https://github.com/robotology/yarp/pull/1718.patch","issue_url":"https://api.github.com/repos/robotology/yarp/issues/1718","number":1718,"state":"open","locked":false,"title":"[WIP]  Deprecate RateThread in favour of PeriodicThread ","user":{"login":"Nicogene","id":19152494,"node_id":"MDQ6VXNlcjE5MTUyNDk0","avatar_url":"https://avatars1.githubusercontent.com/u/19152494?v=4","gravatar_id":"","url":"https://api.github.com/users/Nicogene","html_url":"https://github.com/Nicogene","followers_url":"https://api.github.com/users/Nicogene/followers","following_url":"https://api.github.com/users/Nicogene/following{/other_user}","gists_url":"https://api.github.com/users/Nicogene/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicogene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicogene/subscriptions","organizations_url":"https://api.github.com/users/Nicogene/orgs","repos_url":"https://api.github.com/users/Nicogene/repos","events_url":"https://api.github.com/users/Nicogene/events{/privacy}","received_events_url":"https://api.github.com/users/Nicogene/received_events","type":"User","site_admin":false},"body":"Wip","created_at":"2018-05-31T18:48:27Z","updated_at":"2018-06-01T13:20:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"959e9fcf2fab3a5819dbe63abcbc9f9acd615f3e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"drdanz","id":1100056,"node_id":"MDQ6VXNlcjExMDAwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1100056?v=4","gravatar_id":"","url":"https://api.github.com/users/drdanz","html_url":"https://github.com/drdanz","followers_url":"https://api.github.com/users/drdanz/followers","following_url":"https://api.github.com/users/drdanz/following{/other_user}","gists_url":"https://api.github.com/users/drdanz/gists{/gist_id}","starred_url":"https://api.github.com/users/drdanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdanz/subscriptions","organizations_url":"https://api.github.com/users/drdanz/orgs","repos_url":"https://api.github.com/users/drdanz/repos","events_url":"https://api.github.com/users/drdanz/events{/privacy}","received_events_url":"https://api.github.com/users/drdanz/received_events","type":"User","site_admin":false},{"login":"randaz81","id":2869969,"node_id":"MDQ6VXNlcjI4Njk5Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/2869969?v=4","gravatar_id":"","url":"https://api.github.com/users/randaz81","html_url":"https://github.com/randaz81","followers_url":"https://api.github.com/users/randaz81/followers","following_url":"https://api.github.com/users/randaz81/following{/other_user}","gists_url":"https://api.github.com/users/randaz81/gists{/gist_id}","starred_url":"https://api.github.com/users/randaz81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randaz81/subscriptions","organizations_url":"https://api.github.com/users/randaz81/orgs","repos_url":"https://api.github.com/users/randaz81/repos","events_url":"https://api.github.com/users/randaz81/events{/privacy}","received_events_url":"https://api.github.com/users/randaz81/received_events","type":"User","site_admin":false},{"login":"vtikha","id":4537987,"node_id":"MDQ6VXNlcjQ1Mzc5ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/4537987?v=4","gravatar_id":"","url":"https://api.github.com/users/vtikha","html_url":"https://github.com/vtikha","followers_url":"https://api.github.com/users/vtikha/followers","following_url":"https://api.github.com/users/vtikha/following{/other_user}","gists_url":"https://api.github.com/users/vtikha/gists{/gist_id}","starred_url":"https://api.github.com/users/vtikha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtikha/subscriptions","organizations_url":"https://api.github.com/users/vtikha/orgs","repos_url":"https://api.github.com/users/vtikha/repos","events_url":"https://api.github.com/users/vtikha/events{/privacy}","received_events_url":"https://api.github.com/users/vtikha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":90676350,"node_id":"MDU6TGFiZWw5MDY3NjM1MA==","url":"https://api.github.com/repos/robotology/yarp/labels/Component:%20Devices","name":"Component: Devices","color":"bfe5bf","default":false},{"id":407409175,"node_id":"MDU6TGFiZWw0MDc0MDkxNzU=","url":"https://api.github.com/repos/robotology/yarp/labels/Component:%20Examples","name":"Component: Examples","color":"bfdadc","default":false},{"id":90673355,"node_id":"MDU6TGFiZWw5MDY3MzM1NQ==","url":"https://api.github.com/repos/robotology/yarp/labels/Component:%20Library%20-%20YARP_OS","name":"Component: Library - YARP_OS","color":"207de5","default":false},{"id":90673404,"node_id":"MDU6TGFiZWw5MDY3MzQwNA==","url":"https://api.github.com/repos/robotology/yarp/labels/Component:%20Library%20-%20YARP_dev","name":"Component: Library - YARP_dev","color":"207de5","default":false},{"id":90678054,"node_id":"MDU6TGFiZWw5MDY3ODA1NA==","url":"https://api.github.com/repos/robotology/yarp/labels/Component:%20Tests","name":"Component: Tests","color":"bfdadc","default":false},{"id":835114204,"node_id":"MDU6TGFiZWw4MzUxMTQyMDQ=","url":"https://api.github.com/repos/robotology/yarp/labels/Target:%20YARP%20v3.0.0","name":"Target: YARP v3.0.0","color":"d93f0b","default":false},{"id":469279033,"node_id":"MDU6TGFiZWw0NjkyNzkwMzM=","url":"https://api.github.com/repos/robotology/yarp/labels/Type:%20Cleanup","name":"Type: Cleanup","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/robotology/yarp/pulls/1718/commits","review_comments_url":"https://api.github.com/repos/robotology/yarp/pulls/1718/comments","review_comment_url":"https://api.github.com/repos/robotology/yarp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotology/yarp/issues/1718/comments","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/148de1633c52e9489025a6be9af126f9befe3d36","head":{"label":"Nicogene:timeYarp","ref":"timeYarp","sha":"148de1633c52e9489025a6be9af126f9befe3d36","user":{"login":"Nicogene","id":19152494,"node_id":"MDQ6VXNlcjE5MTUyNDk0","avatar_url":"https://avatars1.githubusercontent.com/u/19152494?v=4","gravatar_id":"","url":"https://api.github.com/users/Nicogene","html_url":"https://github.com/Nicogene","followers_url":"https://api.github.com/users/Nicogene/followers","following_url":"https://api.github.com/users/Nicogene/following{/other_user}","gists_url":"https://api.github.com/users/Nicogene/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicogene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicogene/subscriptions","organizations_url":"https://api.github.com/users/Nicogene/orgs","repos_url":"https://api.github.com/users/Nicogene/repos","events_url":"https://api.github.com/users/Nicogene/events{/privacy}","received_events_url":"https://api.github.com/users/Nicogene/received_events","type":"User","site_admin":false},"repo":{"id":76246068,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI0NjA2OA==","name":"yarp","full_name":"Nicogene/yarp","owner":{"login":"Nicogene","id":19152494,"node_id":"MDQ6VXNlcjE5MTUyNDk0","avatar_url":"https://avatars1.githubusercontent.com/u/19152494?v=4","gravatar_id":"","url":"https://api.github.com/users/Nicogene","html_url":"https://github.com/Nicogene","followers_url":"https://api.github.com/users/Nicogene/followers","following_url":"https://api.github.com/users/Nicogene/following{/other_user}","gists_url":"https://api.github.com/users/Nicogene/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicogene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicogene/subscriptions","organizations_url":"https://api.github.com/users/Nicogene/orgs","repos_url":"https://api.github.com/users/Nicogene/repos","events_url":"https://api.github.com/users/Nicogene/events{/privacy}","received_events_url":"https://api.github.com/users/Nicogene/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nicogene/yarp","description":"YARP - Yet Another Robot Platform","fork":true,"url":"https://api.github.com/repos/Nicogene/yarp","forks_url":"https://api.github.com/repos/Nicogene/yarp/forks","keys_url":"https://api.github.com/repos/Nicogene/yarp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nicogene/yarp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nicogene/yarp/teams","hooks_url":"https://api.github.com/repos/Nicogene/yarp/hooks","issue_events_url":"https://api.github.com/repos/Nicogene/yarp/issues/events{/number}","events_url":"https://api.github.com/repos/Nicogene/yarp/events","assignees_url":"https://api.github.com/repos/Nicogene/yarp/assignees{/user}","branches_url":"https://api.github.com/repos/Nicogene/yarp/branches{/branch}","tags_url":"https://api.github.com/repos/Nicogene/yarp/tags","blobs_url":"https://api.github.com/repos/Nicogene/yarp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nicogene/yarp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nicogene/yarp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nicogene/yarp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nicogene/yarp/statuses/{sha}","languages_url":"https://api.github.com/repos/Nicogene/yarp/languages","stargazers_url":"https://api.github.com/repos/Nicogene/yarp/stargazers","contributors_url":"https://api.github.com/repos/Nicogene/yarp/contributors","subscribers_url":"https://api.github.com/repos/Nicogene/yarp/subscribers","subscription_url":"https://api.github.com/repos/Nicogene/yarp/subscription","commits_url":"https://api.github.com/repos/Nicogene/yarp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nicogene/yarp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nicogene/yarp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nicogene/yarp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nicogene/yarp/contents/{+path}","compare_url":"https://api.github.com/repos/Nicogene/yarp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nicogene/yarp/merges","archive_url":"https://api.github.com/repos/Nicogene/yarp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nicogene/yarp/downloads","issues_url":"https://api.github.com/repos/Nicogene/yarp/issues{/number}","pulls_url":"https://api.github.com/repos/Nicogene/yarp/pulls{/number}","milestones_url":"https://api.github.com/repos/Nicogene/yarp/milestones{/number}","notifications_url":"https://api.github.com/repos/Nicogene/yarp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nicogene/yarp/labels{/name}","releases_url":"https://api.github.com/repos/Nicogene/yarp/releases{/id}","deployments_url":"https://api.github.com/repos/Nicogene/yarp/deployments","created_at":"2016-12-12T10:25:40Z","updated_at":"2016-12-12T10:25:48Z","pushed_at":"2018-05-31T18:47:21Z","git_url":"git://github.com/Nicogene/yarp.git","ssh_url":"git@github.com:Nicogene/yarp.git","clone_url":"https://github.com/Nicogene/yarp.git","svn_url":"https://github.com/Nicogene/yarp","homepage":"http://www.yarp.it","size":70111,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"robotology:devel","ref":"devel","sha":"fd087b27b3af74f41eeacf4313d99861fc232729","user":{"login":"robotology","id":1587191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODcxOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":9517720,"node_id":"MDEwOlJlcG9zaXRvcnk5NTE3NzIw","name":"yarp","full_name":"robotology/yarp","owner":{"login":"robotology","id":1587191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODcxOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotology/yarp","description":"YARP - Yet Another Robot Platform","fork":false,"url":"https://api.github.com/repos/robotology/yarp","forks_url":"https://api.github.com/repos/robotology/yarp/forks","keys_url":"https://api.github.com/repos/robotology/yarp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/yarp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/yarp/teams","hooks_url":"https://api.github.com/repos/robotology/yarp/hooks","issue_events_url":"https://api.github.com/repos/robotology/yarp/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/yarp/events","assignees_url":"https://api.github.com/repos/robotology/yarp/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/yarp/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/yarp/tags","blobs_url":"https://api.github.com/repos/robotology/yarp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/yarp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/yarp/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/yarp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/yarp/languages","stargazers_url":"https://api.github.com/repos/robotology/yarp/stargazers","contributors_url":"https://api.github.com/repos/robotology/yarp/contributors","subscribers_url":"https://api.github.com/repos/robotology/yarp/subscribers","subscription_url":"https://api.github.com/repos/robotology/yarp/subscription","commits_url":"https://api.github.com/repos/robotology/yarp/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/yarp/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/yarp/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/yarp/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/yarp/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/yarp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/yarp/merges","archive_url":"https://api.github.com/repos/robotology/yarp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/yarp/downloads","issues_url":"https://api.github.com/repos/robotology/yarp/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/yarp/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/yarp/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/yarp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/yarp/labels{/name}","releases_url":"https://api.github.com/repos/robotology/yarp/releases{/id}","deployments_url":"https://api.github.com/repos/robotology/yarp/deployments","created_at":"2013-04-18T09:13:24Z","updated_at":"2018-05-30T12:29:12Z","pushed_at":"2018-06-01T11:35:20Z","git_url":"git://github.com/robotology/yarp.git","ssh_url":"git@github.com:robotology/yarp.git","clone_url":"https://github.com/robotology/yarp.git","svn_url":"https://github.com/robotology/yarp","homepage":"http://www.yarp.it","size":70025,"stargazers_count":203,"watchers_count":203,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":104,"mirror_url":null,"archived":false,"open_issues_count":214,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":104,"open_issues":214,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1718"},"html":{"href":"https://github.com/robotology/yarp/pull/1718"},"issue":{"href":"https://api.github.com/repos/robotology/yarp/issues/1718"},"comments":{"href":"https://api.github.com/repos/robotology/yarp/issues/1718/comments"},"review_comments":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1718/comments"},"review_comment":{"href":"https://api.github.com/repos/robotology/yarp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1718/commits"},"statuses":{"href":"https://api.github.com/repos/robotology/yarp/statuses/148de1633c52e9489025a6be9af126f9befe3d36"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"barbalberto"}}