{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/182411934","pull_request_review_id":113200268,"id":182411934,"diff_hunk":"@@ -118,13 +118,17 @@ func NewCmdImage(f cmdutil.Factory, out, err io.Writer) *cobra.Command {\n \treturn cmd\n }\n \n+func (o *ImageOptions) simpleResolveImage(name string) (string, error) {","path":"pkg/kubectl/cmd/set/set_image.go","position":36,"original_position":36,"commit_id":"71f8b01a0a10f5d272d1b63ecf0a7af522e55261","original_commit_id":"71f8b01a0a10f5d272d1b63ecf0a7af522e55261","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"> actually I can just embed the function\r\n\r\nseparate function, just no receiver","created_at":"2018-04-18T12:44:30Z","updated_at":"2018-04-18T12:44:30Z","html_url":"https://github.com/kubernetes/kubernetes/pull/62771#discussion_r182411934","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62771","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/182411934"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/62771#discussion_r182411934"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62771"}},"in_reply_to_id":182410536},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62771","id":182407951,"html_url":"https://github.com/kubernetes/kubernetes/pull/62771","diff_url":"https://github.com/kubernetes/kubernetes/pull/62771.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/62771.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62771","number":62771,"state":"open","locked":false,"title":"kubectl: remote ResolveImage shim","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nThis PR removes the `ResolveImage()` shim in kubectl factory that was used to plug custom behavior when resolving the images\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\nNONE","created_at":"2018-04-18T08:49:29Z","updated_at":"2018-04-18T12:44:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3d016ba03e072a6f4d1f406b321b7ec20263d39","assignee":{"login":"soltysh","id":576341,"avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"assignees":[{"login":"soltysh","id":576341,"avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false},{"login":"eparis","id":8093535,"avatar_url":"https://avatars3.githubusercontent.com/u/8093535?v=4","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680152113,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":450823910,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cli","name":"sig/cli","color":"d2b48c","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62771/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62771/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62771/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/71f8b01a0a10f5d272d1b63ecf0a7af522e55261","head":{"label":"mfojtik:remove-resolve-images","ref":"remove-resolve-images","sha":"71f8b01a0a10f5d272d1b63ecf0a7af522e55261","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":22151842,"name":"kubernetes","full_name":"mfojtik/kubernetes","owner":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfojtik/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/mfojtik/kubernetes","forks_url":"https://api.github.com/repos/mfojtik/kubernetes/forks","keys_url":"https://api.github.com/repos/mfojtik/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/kubernetes/teams","hooks_url":"https://api.github.com/repos/mfojtik/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/kubernetes/events","assignees_url":"https://api.github.com/repos/mfojtik/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/kubernetes/tags","blobs_url":"https://api.github.com/repos/mfojtik/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mfojtik/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/kubernetes/subscription","commits_url":"https://api.github.com/repos/mfojtik/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfojtik/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/kubernetes/merges","archive_url":"https://api.github.com/repos/mfojtik/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/kubernetes/downloads","issues_url":"https://api.github.com/repos/mfojtik/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mfojtik/kubernetes/deployments","created_at":"2014-07-23T14:06:52Z","updated_at":"2018-04-18T08:26:53Z","pushed_at":"2018-04-18T12:37:28Z","git_url":"git://github.com/mfojtik/kubernetes.git","ssh_url":"git@github.com:mfojtik/kubernetes.git","clone_url":"https://github.com/mfojtik/kubernetes.git","svn_url":"https://github.com/mfojtik/kubernetes","homepage":null,"size":556745,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"fcfdda854c9240b0f63ddb74e37cc3ab62c5e226","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-04-18T12:22:28Z","pushed_at":"2018-04-18T12:37:32Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":771139,"stargazers_count":35207,"watchers_count":35207,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12455,"mirror_url":null,"archived":false,"open_issues_count":3460,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12455,"open_issues":3460,"watchers":35207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62771"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/62771"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/62771"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/62771/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62771/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62771/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/71f8b01a0a10f5d272d1b63ecf0a7af522e55261"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"deads2k"}}