{"action":"created","issue":{"url":"https://api.github.com/repos/IAMconsortium/pyam/issues/132","repository_url":"https://api.github.com/repos/IAMconsortium/pyam","labels_url":"https://api.github.com/repos/IAMconsortium/pyam/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/IAMconsortium/pyam/issues/132/comments","events_url":"https://api.github.com/repos/IAMconsortium/pyam/issues/132/events","html_url":"https://github.com/IAMconsortium/pyam/pull/132","id":376720673,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3ODY5MTc2","number":132,"title":"extend IamDataFrame to use extra data columns and sub-annual time","user":{"login":"danielhuppmann","id":16931589,"node_id":"MDQ6VXNlcjE2OTMxNTg5","avatar_url":"https://avatars2.githubusercontent.com/u/16931589?v=4","gravatar_id":"","url":"https://api.github.com/users/danielhuppmann","html_url":"https://github.com/danielhuppmann","followers_url":"https://api.github.com/users/danielhuppmann/followers","following_url":"https://api.github.com/users/danielhuppmann/following{/other_user}","gists_url":"https://api.github.com/users/danielhuppmann/gists{/gist_id}","starred_url":"https://api.github.com/users/danielhuppmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielhuppmann/subscriptions","organizations_url":"https://api.github.com/users/danielhuppmann/orgs","repos_url":"https://api.github.com/users/danielhuppmann/repos","events_url":"https://api.github.com/users/danielhuppmann/events{/privacy}","received_events_url":"https://api.github.com/users/danielhuppmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-11-02T08:54:20Z","updated_at":"2018-12-03T19:13:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/IAMconsortium/pyam/pulls/132","html_url":"https://github.com/IAMconsortium/pyam/pull/132","diff_url":"https://github.com/IAMconsortium/pyam/pull/132.diff","patch_url":"https://github.com/IAMconsortium/pyam/pull/132.patch"},"body":"# Please confirm that this PR has done the following:\r\n\r\n- [x] Tests Added\r\n- [x] Documentation Added\r\n- [x] Description in RELEASE_NOTES.md Added\r\n\r\n# Description of PR\r\n\r\nThis PR extends an `IamDataFrame` to have extra (custom) columns in the `data` data frame, and to distinguish between\r\n - years (as integers, possibly with a column `subannual` (as string)\r\n - continuous time using `pd.to_datetime()`\r\nThe \"type\" of time representation is stored in `self.time_col`, the additional custom columns in `self.data` in `self.extra_cols`.\r\n\r\nOne quickfix required to get stuff working: `read_files()` is downgraded to take only one file, not a list of files. Because this would require checking that all imported data has the same time format and same extra columns (or add them on the fly).\r\n\r\n## ToDo:\r\n - [x] change `\"year\"` to `self.time_col` for basic functionality (e.g., in `timeseries()`)\r\n - [ ] change `*_IDX` usage in the package to replace `\"year\"` by `self.time_col` and use `self.extra_cols`\r\n - [ ] figure out how to refactor `append()` (see issue above with `read_files()`)\r\n - [ ] reimplement multiple files in `read_files()`\r\n\r\n## Related issue and discussion\r\nCloses #123 \r\n"},"comment":{"url":"https://api.github.com/repos/IAMconsortium/pyam/issues/comments/443832941","html_url":"https://github.com/IAMconsortium/pyam/pull/132#issuecomment-443832941","issue_url":"https://api.github.com/repos/IAMconsortium/pyam/issues/132","id":443832941,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzgzMjk0MQ==","user":{"login":"danielhuppmann","id":16931589,"node_id":"MDQ6VXNlcjE2OTMxNTg5","avatar_url":"https://avatars2.githubusercontent.com/u/16931589?v=4","gravatar_id":"","url":"https://api.github.com/users/danielhuppmann","html_url":"https://github.com/danielhuppmann","followers_url":"https://api.github.com/users/danielhuppmann/followers","following_url":"https://api.github.com/users/danielhuppmann/following{/other_user}","gists_url":"https://api.github.com/users/danielhuppmann/gists{/gist_id}","starred_url":"https://api.github.com/users/danielhuppmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielhuppmann/subscriptions","organizations_url":"https://api.github.com/users/danielhuppmann/orgs","repos_url":"https://api.github.com/users/danielhuppmann/repos","events_url":"https://api.github.com/users/danielhuppmann/events{/privacy}","received_events_url":"https://api.github.com/users/danielhuppmann/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T19:13:44Z","updated_at":"2018-12-03T19:13:44Z","author_association":"MEMBER","body":"@znicholls, yes, I meant that we would add these issues after the merge - just thought that it would be clearer what still needs to be done for the larger picture when I spell it out here. Thanks for volunteering!"}}
{"actor":{"display_login":"danielhuppmann"}}