{"action":"closed","number":870,"pull_request":{"url":"https://api.github.com/repos/dcodeIO/protobuf.js/pulls/870","id":131681801,"html_url":"https://github.com/dcodeIO/protobuf.js/pull/870","diff_url":"https://github.com/dcodeIO/protobuf.js/pull/870.diff","patch_url":"https://github.com/dcodeIO/protobuf.js/pull/870.patch","issue_url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/870","number":870,"state":"closed","locked":false,"title":"Fixed: prevent codegen'ing a function with an invalid name.","user":{"login":"eventualbuddha","id":1938,"avatar_url":"https://avatars3.githubusercontent.com/u/1938?v=4","gravatar_id":"","url":"https://api.github.com/users/eventualbuddha","html_url":"https://github.com/eventualbuddha","followers_url":"https://api.github.com/users/eventualbuddha/followers","following_url":"https://api.github.com/users/eventualbuddha/following{/other_user}","gists_url":"https://api.github.com/users/eventualbuddha/gists{/gist_id}","starred_url":"https://api.github.com/users/eventualbuddha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventualbuddha/subscriptions","organizations_url":"https://api.github.com/users/eventualbuddha/orgs","repos_url":"https://api.github.com/users/eventualbuddha/repos","events_url":"https://api.github.com/users/eventualbuddha/events{/privacy}","received_events_url":"https://api.github.com/users/eventualbuddha/received_events","type":"User","site_admin":false},"body":"This can happen when, for example, an RPC method name is the uppercase of a keyword like \"Delete\". I tried to retain the performance of the original, but since the test just uses the same names over and over again and they're memoized it's not a super representative set of test data to really understand how the performance changed.","created_at":"2017-07-21T01:29:12Z","updated_at":"2018-02-06T12:48:22Z","closed_at":"2018-02-06T12:48:22Z","merged_at":null,"merge_commit_sha":"c65a9b8defe3850d2cbde9b1a0c884c6bed39e00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcodeIO/protobuf.js/pulls/870/commits","review_comments_url":"https://api.github.com/repos/dcodeIO/protobuf.js/pulls/870/comments","review_comment_url":"https://api.github.com/repos/dcodeIO/protobuf.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/870/comments","statuses_url":"https://api.github.com/repos/dcodeIO/protobuf.js/statuses/380157040afdb8d9260438d59c73a48e273303ca","head":{"label":"eventualbuddha:prevent-codegen-from-using-keyword-function-names","ref":"prevent-codegen-from-using-keyword-function-names","sha":"380157040afdb8d9260438d59c73a48e273303ca","user":{"login":"eventualbuddha","id":1938,"avatar_url":"https://avatars3.githubusercontent.com/u/1938?v=4","gravatar_id":"","url":"https://api.github.com/users/eventualbuddha","html_url":"https://github.com/eventualbuddha","followers_url":"https://api.github.com/users/eventualbuddha/followers","following_url":"https://api.github.com/users/eventualbuddha/following{/other_user}","gists_url":"https://api.github.com/users/eventualbuddha/gists{/gist_id}","starred_url":"https://api.github.com/users/eventualbuddha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventualbuddha/subscriptions","organizations_url":"https://api.github.com/users/eventualbuddha/orgs","repos_url":"https://api.github.com/users/eventualbuddha/repos","events_url":"https://api.github.com/users/eventualbuddha/events{/privacy}","received_events_url":"https://api.github.com/users/eventualbuddha/received_events","type":"User","site_admin":false},"repo":{"id":96910826,"name":"protobuf.js","full_name":"eventualbuddha/protobuf.js","owner":{"login":"eventualbuddha","id":1938,"avatar_url":"https://avatars3.githubusercontent.com/u/1938?v=4","gravatar_id":"","url":"https://api.github.com/users/eventualbuddha","html_url":"https://github.com/eventualbuddha","followers_url":"https://api.github.com/users/eventualbuddha/followers","following_url":"https://api.github.com/users/eventualbuddha/following{/other_user}","gists_url":"https://api.github.com/users/eventualbuddha/gists{/gist_id}","starred_url":"https://api.github.com/users/eventualbuddha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventualbuddha/subscriptions","organizations_url":"https://api.github.com/users/eventualbuddha/orgs","repos_url":"https://api.github.com/users/eventualbuddha/repos","events_url":"https://api.github.com/users/eventualbuddha/events{/privacy}","received_events_url":"https://api.github.com/users/eventualbuddha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eventualbuddha/protobuf.js","description":"Protocol Buffers for JavaScript (& TypeScript).","fork":true,"url":"https://api.github.com/repos/eventualbuddha/protobuf.js","forks_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/forks","keys_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/teams","hooks_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/hooks","issue_events_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/issues/events{/number}","events_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/events","assignees_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/assignees{/user}","branches_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/branches{/branch}","tags_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/tags","blobs_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/languages","stargazers_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/stargazers","contributors_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/contributors","subscribers_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/subscribers","subscription_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/subscription","commits_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/contents/{+path}","compare_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/merges","archive_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/downloads","issues_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/issues{/number}","pulls_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/labels{/name}","releases_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/releases{/id}","deployments_url":"https://api.github.com/repos/eventualbuddha/protobuf.js/deployments","created_at":"2017-07-11T15:52:31Z","updated_at":"2017-07-13T03:18:15Z","pushed_at":"2017-07-21T01:27:36Z","git_url":"git://github.com/eventualbuddha/protobuf.js.git","ssh_url":"git@github.com:eventualbuddha/protobuf.js.git","clone_url":"https://github.com/eventualbuddha/protobuf.js.git","svn_url":"https://github.com/eventualbuddha/protobuf.js","homepage":"http://dcode.io/protobuf.js","size":35045,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcodeIO:master","ref":"master","sha":"bda1bc6917c681516f6be8be8f0e84ba1262c4ce","user":{"login":"dcodeIO","id":1136893,"avatar_url":"https://avatars0.githubusercontent.com/u/1136893?v=4","gravatar_id":"","url":"https://api.github.com/users/dcodeIO","html_url":"https://github.com/dcodeIO","followers_url":"https://api.github.com/users/dcodeIO/followers","following_url":"https://api.github.com/users/dcodeIO/following{/other_user}","gists_url":"https://api.github.com/users/dcodeIO/gists{/gist_id}","starred_url":"https://api.github.com/users/dcodeIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcodeIO/subscriptions","organizations_url":"https://api.github.com/users/dcodeIO/orgs","repos_url":"https://api.github.com/users/dcodeIO/repos","events_url":"https://api.github.com/users/dcodeIO/events{/privacy}","received_events_url":"https://api.github.com/users/dcodeIO/received_events","type":"User","site_admin":false},"repo":{"id":8507859,"name":"protobuf.js","full_name":"dcodeIO/protobuf.js","owner":{"login":"dcodeIO","id":1136893,"avatar_url":"https://avatars0.githubusercontent.com/u/1136893?v=4","gravatar_id":"","url":"https://api.github.com/users/dcodeIO","html_url":"https://github.com/dcodeIO","followers_url":"https://api.github.com/users/dcodeIO/followers","following_url":"https://api.github.com/users/dcodeIO/following{/other_user}","gists_url":"https://api.github.com/users/dcodeIO/gists{/gist_id}","starred_url":"https://api.github.com/users/dcodeIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcodeIO/subscriptions","organizations_url":"https://api.github.com/users/dcodeIO/orgs","repos_url":"https://api.github.com/users/dcodeIO/repos","events_url":"https://api.github.com/users/dcodeIO/events{/privacy}","received_events_url":"https://api.github.com/users/dcodeIO/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcodeIO/protobuf.js","description":"Protocol Buffers for JavaScript (& TypeScript).","fork":false,"url":"https://api.github.com/repos/dcodeIO/protobuf.js","forks_url":"https://api.github.com/repos/dcodeIO/protobuf.js/forks","keys_url":"https://api.github.com/repos/dcodeIO/protobuf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcodeIO/protobuf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcodeIO/protobuf.js/teams","hooks_url":"https://api.github.com/repos/dcodeIO/protobuf.js/hooks","issue_events_url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/events{/number}","events_url":"https://api.github.com/repos/dcodeIO/protobuf.js/events","assignees_url":"https://api.github.com/repos/dcodeIO/protobuf.js/assignees{/user}","branches_url":"https://api.github.com/repos/dcodeIO/protobuf.js/branches{/branch}","tags_url":"https://api.github.com/repos/dcodeIO/protobuf.js/tags","blobs_url":"https://api.github.com/repos/dcodeIO/protobuf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcodeIO/protobuf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcodeIO/protobuf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcodeIO/protobuf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcodeIO/protobuf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/dcodeIO/protobuf.js/languages","stargazers_url":"https://api.github.com/repos/dcodeIO/protobuf.js/stargazers","contributors_url":"https://api.github.com/repos/dcodeIO/protobuf.js/contributors","subscribers_url":"https://api.github.com/repos/dcodeIO/protobuf.js/subscribers","subscription_url":"https://api.github.com/repos/dcodeIO/protobuf.js/subscription","commits_url":"https://api.github.com/repos/dcodeIO/protobuf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcodeIO/protobuf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcodeIO/protobuf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcodeIO/protobuf.js/contents/{+path}","compare_url":"https://api.github.com/repos/dcodeIO/protobuf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcodeIO/protobuf.js/merges","archive_url":"https://api.github.com/repos/dcodeIO/protobuf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcodeIO/protobuf.js/downloads","issues_url":"https://api.github.com/repos/dcodeIO/protobuf.js/issues{/number}","pulls_url":"https://api.github.com/repos/dcodeIO/protobuf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/dcodeIO/protobuf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/dcodeIO/protobuf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcodeIO/protobuf.js/labels{/name}","releases_url":"https://api.github.com/repos/dcodeIO/protobuf.js/releases{/id}","deployments_url":"https://api.github.com/repos/dcodeIO/protobuf.js/deployments","created_at":"2013-03-01T18:46:54Z","updated_at":"2018-02-06T12:29:34Z","pushed_at":"2018-02-06T12:41:31Z","git_url":"git://github.com/dcodeIO/protobuf.js.git","ssh_url":"git@github.com:dcodeIO/protobuf.js.git","clone_url":"https://github.com/dcodeIO/protobuf.js.git","svn_url":"https://github.com/dcodeIO/protobuf.js","homepage":"http://dcode.io/protobuf.js","size":35707,"stargazers_count":3947,"watchers_count":3947,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":575,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":575,"open_issues":115,"watchers":3947,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcodeIO/protobuf.js/pulls/870"},"html":{"href":"https://github.com/dcodeIO/protobuf.js/pull/870"},"issue":{"href":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/870"},"comments":{"href":"https://api.github.com/repos/dcodeIO/protobuf.js/issues/870/comments"},"review_comments":{"href":"https://api.github.com/repos/dcodeIO/protobuf.js/pulls/870/comments"},"review_comment":{"href":"https://api.github.com/repos/dcodeIO/protobuf.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcodeIO/protobuf.js/pulls/870/commits"},"statuses":{"href":"https://api.github.com/repos/dcodeIO/protobuf.js/statuses/380157040afdb8d9260438d59c73a48e273303ca"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":9,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":43,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"dcodeIO"}}