{"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/198024025","pull_request_review_id":131871124,"id":198024025,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODAyNDAyNQ==","diff_hunk":"@@ -341,6 +353,16 @@ namespace aspect\n                            \"implemented in a plugin in the BoundaryTemperature \"\n                            \"group, unless an existing implementation in this group \"\n                            \"already provides what you want.\");\n+        prm.declare_entry (\"Allow fixed temperature on outflow boundaries\", \"true\",\n+                           Patterns::Bool (),\n+                           \"When the temperature is fixed on a given boundary as determined \"\n+                           \"by the list of 'Fixed temperature boundary indicators', there \"\n+                           \"might be parts of the boundary where material flows out and \"\n+                           \"one may want to prescribe the temperature only on the parts of \"\n+                           \"the boundary where there is inflow. This parameter determines \"\n+                           \"if temperatures are only prescribed at these inflow parts of the \"\n+                           \"boundary (if false) or everywhere on a given boundary, independent \"\n+                           \"of the flow direction (if true).\");","path":"source/boundary_temperature/interface.cc","position":39,"original_position":39,"commit_id":"7a51cfc5bc49cc71c53ec1d37dca3abe74b5676d","original_commit_id":"7a51cfc5bc49cc71c53ec1d37dca3abe74b5676d","user":{"login":"bangerth","id":7504421,"node_id":"MDQ6VXNlcjc1MDQ0MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7504421?v=4","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"here add something similar, except that it is necessary to state that mathematically it is allowed to prescribe the temperature even on outflow boundaries *as long as the diffusion coefficient is nonzero*. In practice, however, this would only make physical sense if the diffusion coefficient is actually quite large to prevent the creation of a boundary layer.","created_at":"2018-06-26T06:17:45Z","updated_at":"2018-06-26T06:18:20Z","html_url":"https://github.com/geodynamics/aspect/pull/2419#discussion_r198024025","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2419","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/198024025"},"html":{"href":"https://github.com/geodynamics/aspect/pull/2419#discussion_r198024025"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2419"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/2419","id":196963722,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTYzNzIy","html_url":"https://github.com/geodynamics/aspect/pull/2419","diff_url":"https://github.com/geodynamics/aspect/pull/2419.diff","patch_url":"https://github.com/geodynamics/aspect/pull/2419.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/2419","number":2419,"state":"open","locked":false,"title":"[Bugfix] add an option that fixes temperature/composition only on inflow/close…","user":{"login":"jdannberg","id":7517347,"node_id":"MDQ6VXNlcjc1MTczNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7517347?v=4","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"body":"…d boundaries, but not on outflow boundaries. \r\n\r\nFixes #903.\r\n\r\nWe can discuss what the default for the temperature equation should be. \r\n\r\nAnd I still have to add a changelog entry (which I will do after we've agreed on a the default for the temperature). ","created_at":"2018-06-24T18:44:38Z","updated_at":"2018-06-26T06:18:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d64ead03c1fd59ead5dad91eb50a3b19d8a301d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2419/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2419/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/2419/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/7a51cfc5bc49cc71c53ec1d37dca3abe74b5676d","head":{"label":"jdannberg:no_dirichlet_on_outflow","ref":"no_dirichlet_on_outflow","sha":"7a51cfc5bc49cc71c53ec1d37dca3abe74b5676d","user":{"login":"jdannberg","id":7517347,"node_id":"MDQ6VXNlcjc1MTczNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7517347?v=4","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"repo":{"id":19785028,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc4NTAyOA==","name":"aspect","full_name":"jdannberg/aspect","owner":{"login":"jdannberg","id":7517347,"node_id":"MDQ6VXNlcjc1MTczNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7517347?v=4","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdannberg/aspect","description":"Finite element parallel code to simulate problems in thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/jdannberg/aspect","forks_url":"https://api.github.com/repos/jdannberg/aspect/forks","keys_url":"https://api.github.com/repos/jdannberg/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdannberg/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdannberg/aspect/teams","hooks_url":"https://api.github.com/repos/jdannberg/aspect/hooks","issue_events_url":"https://api.github.com/repos/jdannberg/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/jdannberg/aspect/events","assignees_url":"https://api.github.com/repos/jdannberg/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/jdannberg/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/jdannberg/aspect/tags","blobs_url":"https://api.github.com/repos/jdannberg/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdannberg/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdannberg/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdannberg/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdannberg/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/jdannberg/aspect/languages","stargazers_url":"https://api.github.com/repos/jdannberg/aspect/stargazers","contributors_url":"https://api.github.com/repos/jdannberg/aspect/contributors","subscribers_url":"https://api.github.com/repos/jdannberg/aspect/subscribers","subscription_url":"https://api.github.com/repos/jdannberg/aspect/subscription","commits_url":"https://api.github.com/repos/jdannberg/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdannberg/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdannberg/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdannberg/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdannberg/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/jdannberg/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdannberg/aspect/merges","archive_url":"https://api.github.com/repos/jdannberg/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdannberg/aspect/downloads","issues_url":"https://api.github.com/repos/jdannberg/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/jdannberg/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/jdannberg/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/jdannberg/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdannberg/aspect/labels{/name}","releases_url":"https://api.github.com/repos/jdannberg/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/jdannberg/aspect/deployments","created_at":"2014-05-14T15:28:24Z","updated_at":"2015-09-22T19:25:32Z","pushed_at":"2018-06-26T06:01:28Z","git_url":"git://github.com/jdannberg/aspect.git","ssh_url":"git@github.com:jdannberg/aspect.git","clone_url":"https://github.com/jdannberg/aspect.git","svn_url":"https://github.com/jdannberg/aspect","homepage":null,"size":168925,"stargazers_count":0,"watchers_count":0,"language":"Gnuplot","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"bd0a0d83c5aa898528863ffe35d1b15b7793d4e2","user":{"login":"geodynamics","id":4052461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTI0NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4052461?v=4","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"node_id":"MDEwOlJlcG9zaXRvcnkxOTUwMjQ1Mg==","name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTI0NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4052461?v=4","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extensible finite element code to simulate convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/geodynamics/aspect/deployments","created_at":"2014-05-06T16:47:18Z","updated_at":"2018-06-26T04:52:08Z","pushed_at":"2018-06-26T06:14:15Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"https://aspect.geodynamics.org/","size":175941,"stargazers_count":53,"watchers_count":53,"language":"Gnuplot","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":190,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":98,"open_issues":190,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2419"},"html":{"href":"https://github.com/geodynamics/aspect/pull/2419"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/2419"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/2419/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2419/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2419/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/7a51cfc5bc49cc71c53ec1d37dca3abe74b5676d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bangerth"}}