{"action":"created","comment":{"url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments/204147168","pull_request_review_id":139183157,"id":204147168,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE0NzE2OA==","diff_hunk":"@@ -35,10 +35,10 @@ def initialize(user, time, signature)\n     end\n \n     def to_s\n-      \"#{formatted_time}: #{user} #{archive_s(signature.source)} \" \\\n-        \"w/ #{archive_s(signature.deploy)}\\n\" \\\n-        \"  #{archive_s(signature.unshared)}\\n\" \\\n-        \"  #{archive_s(signature.shared)}\"\n+      \"#{formatted_time}: #{user} #{signature.source.commitish} \" \\\n+        \"w/ #{signature.deploy.commitish}\\n\" \\\n+        \"  #{signature.unshared.commitish}\\n\" \\\n+        \"  #{signature.shared.commitish}\"","path":"lib/fauxpaas/logged_release.rb","position":11,"original_position":11,"commit_id":"d411311d82cd7df3af46e4ae2b65a1b5784b4938","original_commit_id":"d411311d82cd7df3af46e4ae2b65a1b5784b4938","user":{"login":"daaang","id":8156920,"node_id":"MDQ6VXNlcjgxNTY5MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8156920?v=4","gravatar_id":"","url":"https://api.github.com/users/daaang","html_url":"https://github.com/daaang","followers_url":"https://api.github.com/users/daaang/followers","following_url":"https://api.github.com/users/daaang/following{/other_user}","gists_url":"https://api.github.com/users/daaang/gists{/gist_id}","starred_url":"https://api.github.com/users/daaang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daaang/subscriptions","organizations_url":"https://api.github.com/users/daaang/orgs","repos_url":"https://api.github.com/users/daaang/repos","events_url":"https://api.github.com/users/daaang/events{/privacy}","received_events_url":"https://api.github.com/users/daaang/received_events","type":"User","site_admin":false},"body":"I don't know what commitish is but I see that this allows for the deletion of archive_s.","created_at":"2018-07-20T19:27:53Z","updated_at":"2018-07-20T19:42:13Z","html_url":"https://github.com/mlibrary/fauxpaas/pull/44#discussion_r204147168","pull_request_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/44","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments/204147168"},"html":{"href":"https://github.com/mlibrary/fauxpaas/pull/44#discussion_r204147168"},"pull_request":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/44","id":200190737,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTkwNzM3","html_url":"https://github.com/mlibrary/fauxpaas/pull/44","diff_url":"https://github.com/mlibrary/fauxpaas/pull/44.diff","patch_url":"https://github.com/mlibrary/fauxpaas/pull/44.patch","issue_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/44","number":44,"state":"open","locked":false,"title":"Remove support for >1 shared/unshared configs","user":{"login":"malakai97","id":3486429,"node_id":"MDQ6VXNlcjM0ODY0Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/3486429?v=4","gravatar_id":"","url":"https://api.github.com/users/malakai97","html_url":"https://github.com/malakai97","followers_url":"https://api.github.com/users/malakai97/followers","following_url":"https://api.github.com/users/malakai97/following{/other_user}","gists_url":"https://api.github.com/users/malakai97/gists{/gist_id}","starred_url":"https://api.github.com/users/malakai97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malakai97/subscriptions","organizations_url":"https://api.github.com/users/malakai97/orgs","repos_url":"https://api.github.com/users/malakai97/repos","events_url":"https://api.github.com/users/malakai97/events{/privacy}","received_events_url":"https://api.github.com/users/malakai97/received_events","type":"User","site_admin":false},"body":"* Removes support for multiple shared configs per instance/release\r\n* Removes support for multiple unshared configs per instance/release\r\n* Adds legacy support for existing instances\r\n* Removes current and legacy support for instances without at least\r\n  one shared and one unshared config.\r\n\r\nThe generality in this support was adding complexity with no material benefit. This PR removes the support, and configures the file repositories to automatically migrate legacy data files on the next read+save.  Notably, it is okay to modify the legacy fixtures such that they never have an empty shared/unshared keypair because none of the data in production shares that quality.","created_at":"2018-07-09T19:02:11Z","updated_at":"2018-07-20T19:42:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8752420abcbd6d245cf46a7368029a7520584a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/44/commits","review_comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/44/comments","review_comment_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/44/comments","statuses_url":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/d411311d82cd7df3af46e4ae2b65a1b5784b4938","head":{"label":"mlibrary:single_configs","ref":"single_configs","sha":"d411311d82cd7df3af46e4ae2b65a1b5784b4938","user":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":102662551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2NjI1NTE=","name":"fauxpaas","full_name":"mlibrary/fauxpaas","owner":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlibrary/fauxpaas","description":"Deployment tooling for Ruby projects at MLibrary","fork":false,"url":"https://api.github.com/repos/mlibrary/fauxpaas","forks_url":"https://api.github.com/repos/mlibrary/fauxpaas/forks","keys_url":"https://api.github.com/repos/mlibrary/fauxpaas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlibrary/fauxpaas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlibrary/fauxpaas/teams","hooks_url":"https://api.github.com/repos/mlibrary/fauxpaas/hooks","issue_events_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/events{/number}","events_url":"https://api.github.com/repos/mlibrary/fauxpaas/events","assignees_url":"https://api.github.com/repos/mlibrary/fauxpaas/assignees{/user}","branches_url":"https://api.github.com/repos/mlibrary/fauxpaas/branches{/branch}","tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/tags","blobs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/{sha}","languages_url":"https://api.github.com/repos/mlibrary/fauxpaas/languages","stargazers_url":"https://api.github.com/repos/mlibrary/fauxpaas/stargazers","contributors_url":"https://api.github.com/repos/mlibrary/fauxpaas/contributors","subscribers_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscribers","subscription_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscription","commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlibrary/fauxpaas/contents/{+path}","compare_url":"https://api.github.com/repos/mlibrary/fauxpaas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlibrary/fauxpaas/merges","archive_url":"https://api.github.com/repos/mlibrary/fauxpaas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlibrary/fauxpaas/downloads","issues_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues{/number}","pulls_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls{/number}","milestones_url":"https://api.github.com/repos/mlibrary/fauxpaas/milestones{/number}","notifications_url":"https://api.github.com/repos/mlibrary/fauxpaas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlibrary/fauxpaas/labels{/name}","releases_url":"https://api.github.com/repos/mlibrary/fauxpaas/releases{/id}","deployments_url":"https://api.github.com/repos/mlibrary/fauxpaas/deployments","created_at":"2017-09-06T22:01:59Z","updated_at":"2018-07-20T16:55:53Z","pushed_at":"2018-07-20T18:12:15Z","git_url":"git://github.com/mlibrary/fauxpaas.git","ssh_url":"git@github.com:mlibrary/fauxpaas.git","clone_url":"https://github.com/mlibrary/fauxpaas.git","svn_url":"https://github.com/mlibrary/fauxpaas","homepage":"","size":405,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"mlibrary:develop","ref":"develop","sha":"02898f6bf7b4d627737695d8bdf4f4af0f8de821","user":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":102662551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2NjI1NTE=","name":"fauxpaas","full_name":"mlibrary/fauxpaas","owner":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlibrary/fauxpaas","description":"Deployment tooling for Ruby projects at MLibrary","fork":false,"url":"https://api.github.com/repos/mlibrary/fauxpaas","forks_url":"https://api.github.com/repos/mlibrary/fauxpaas/forks","keys_url":"https://api.github.com/repos/mlibrary/fauxpaas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlibrary/fauxpaas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlibrary/fauxpaas/teams","hooks_url":"https://api.github.com/repos/mlibrary/fauxpaas/hooks","issue_events_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/events{/number}","events_url":"https://api.github.com/repos/mlibrary/fauxpaas/events","assignees_url":"https://api.github.com/repos/mlibrary/fauxpaas/assignees{/user}","branches_url":"https://api.github.com/repos/mlibrary/fauxpaas/branches{/branch}","tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/tags","blobs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/{sha}","languages_url":"https://api.github.com/repos/mlibrary/fauxpaas/languages","stargazers_url":"https://api.github.com/repos/mlibrary/fauxpaas/stargazers","contributors_url":"https://api.github.com/repos/mlibrary/fauxpaas/contributors","subscribers_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscribers","subscription_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscription","commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlibrary/fauxpaas/contents/{+path}","compare_url":"https://api.github.com/repos/mlibrary/fauxpaas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlibrary/fauxpaas/merges","archive_url":"https://api.github.com/repos/mlibrary/fauxpaas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlibrary/fauxpaas/downloads","issues_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues{/number}","pulls_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls{/number}","milestones_url":"https://api.github.com/repos/mlibrary/fauxpaas/milestones{/number}","notifications_url":"https://api.github.com/repos/mlibrary/fauxpaas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlibrary/fauxpaas/labels{/name}","releases_url":"https://api.github.com/repos/mlibrary/fauxpaas/releases{/id}","deployments_url":"https://api.github.com/repos/mlibrary/fauxpaas/deployments","created_at":"2017-09-06T22:01:59Z","updated_at":"2018-07-20T16:55:53Z","pushed_at":"2018-07-20T18:12:15Z","git_url":"git://github.com/mlibrary/fauxpaas.git","ssh_url":"git@github.com:mlibrary/fauxpaas.git","clone_url":"https://github.com/mlibrary/fauxpaas.git","svn_url":"https://github.com/mlibrary/fauxpaas","homepage":"","size":405,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/44"},"html":{"href":"https://github.com/mlibrary/fauxpaas/pull/44"},"issue":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/issues/44"},"comments":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/d411311d82cd7df3af46e4ae2b65a1b5784b4938"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"daaang"}}