{"action":"closed","number":1431,"pull_request":{"url":"https://api.github.com/repos/DeviaVir/zenbot/pulls/1431","id":171696196,"html_url":"https://github.com/DeviaVir/zenbot/pull/1431","diff_url":"https://github.com/DeviaVir/zenbot/pull/1431.diff","patch_url":"https://github.com/DeviaVir/zenbot/pull/1431.patch","issue_url":"https://api.github.com/repos/DeviaVir/zenbot/issues/1431","number":1431,"state":"closed","locked":false,"title":"Small tweak to make getQuote in sim a bit more realistic","user":{"login":"glennfu","id":20549,"avatar_url":"https://avatars0.githubusercontent.com/u/20549?v=4","gravatar_id":"","url":"https://api.github.com/users/glennfu","html_url":"https://github.com/glennfu","followers_url":"https://api.github.com/users/glennfu/followers","following_url":"https://api.github.com/users/glennfu/following{/other_user}","gists_url":"https://api.github.com/users/glennfu/gists{/gist_id}","starred_url":"https://api.github.com/users/glennfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennfu/subscriptions","organizations_url":"https://api.github.com/users/glennfu/orgs","repos_url":"https://api.github.com/users/glennfu/repos","events_url":"https://api.github.com/users/glennfu/events{/privacy}","received_events_url":"https://api.github.com/users/glennfu/received_events","type":"User","site_admin":false},"body":"Right now `getQuote` gets called by the engine many times a minute. To be more precise, it gets call every `order_adjust_time` milliseconds. However, right now the sim exchange just returns the last period close for the `getQuote` value which is constant per-period. This change pulls from the last trade value. While this is not the same as the REAL `ask` or `bid` from `getQuote`, currently Zenbot doesn't store this kind of orderbook data so faking it this way is the best we can do. Still not perfect, but hopefully a bit more realistic than last period close.","created_at":"2018-02-27T15:28:32Z","updated_at":"2018-02-28T11:15:13Z","closed_at":"2018-02-28T11:15:13Z","merged_at":"2018-02-28T11:15:13Z","merge_commit_sha":"2224806ad6e1bcd5389abc41a20f99a5be8f1e03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DeviaVir/zenbot/pulls/1431/commits","review_comments_url":"https://api.github.com/repos/DeviaVir/zenbot/pulls/1431/comments","review_comment_url":"https://api.github.com/repos/DeviaVir/zenbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DeviaVir/zenbot/issues/1431/comments","statuses_url":"https://api.github.com/repos/DeviaVir/zenbot/statuses/ed6cbb03da3f1f2a0e8b1ddece37974e6188c658","head":{"label":"glennfu:getquote_sim","ref":"getquote_sim","sha":"ed6cbb03da3f1f2a0e8b1ddece37974e6188c658","user":{"login":"glennfu","id":20549,"avatar_url":"https://avatars0.githubusercontent.com/u/20549?v=4","gravatar_id":"","url":"https://api.github.com/users/glennfu","html_url":"https://github.com/glennfu","followers_url":"https://api.github.com/users/glennfu/followers","following_url":"https://api.github.com/users/glennfu/following{/other_user}","gists_url":"https://api.github.com/users/glennfu/gists{/gist_id}","starred_url":"https://api.github.com/users/glennfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennfu/subscriptions","organizations_url":"https://api.github.com/users/glennfu/orgs","repos_url":"https://api.github.com/users/glennfu/repos","events_url":"https://api.github.com/users/glennfu/events{/privacy}","received_events_url":"https://api.github.com/users/glennfu/received_events","type":"User","site_admin":false},"repo":{"id":115549980,"name":"zenbot","full_name":"glennfu/zenbot","owner":{"login":"glennfu","id":20549,"avatar_url":"https://avatars0.githubusercontent.com/u/20549?v=4","gravatar_id":"","url":"https://api.github.com/users/glennfu","html_url":"https://github.com/glennfu","followers_url":"https://api.github.com/users/glennfu/followers","following_url":"https://api.github.com/users/glennfu/following{/other_user}","gists_url":"https://api.github.com/users/glennfu/gists{/gist_id}","starred_url":"https://api.github.com/users/glennfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennfu/subscriptions","organizations_url":"https://api.github.com/users/glennfu/orgs","repos_url":"https://api.github.com/users/glennfu/repos","events_url":"https://api.github.com/users/glennfu/events{/privacy}","received_events_url":"https://api.github.com/users/glennfu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glennfu/zenbot","description":"Zenbot is a command-line cryptocurrency trading bot using Node.js and MongoDB.","fork":true,"url":"https://api.github.com/repos/glennfu/zenbot","forks_url":"https://api.github.com/repos/glennfu/zenbot/forks","keys_url":"https://api.github.com/repos/glennfu/zenbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glennfu/zenbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glennfu/zenbot/teams","hooks_url":"https://api.github.com/repos/glennfu/zenbot/hooks","issue_events_url":"https://api.github.com/repos/glennfu/zenbot/issues/events{/number}","events_url":"https://api.github.com/repos/glennfu/zenbot/events","assignees_url":"https://api.github.com/repos/glennfu/zenbot/assignees{/user}","branches_url":"https://api.github.com/repos/glennfu/zenbot/branches{/branch}","tags_url":"https://api.github.com/repos/glennfu/zenbot/tags","blobs_url":"https://api.github.com/repos/glennfu/zenbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glennfu/zenbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glennfu/zenbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/glennfu/zenbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glennfu/zenbot/statuses/{sha}","languages_url":"https://api.github.com/repos/glennfu/zenbot/languages","stargazers_url":"https://api.github.com/repos/glennfu/zenbot/stargazers","contributors_url":"https://api.github.com/repos/glennfu/zenbot/contributors","subscribers_url":"https://api.github.com/repos/glennfu/zenbot/subscribers","subscription_url":"https://api.github.com/repos/glennfu/zenbot/subscription","commits_url":"https://api.github.com/repos/glennfu/zenbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/glennfu/zenbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/glennfu/zenbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/glennfu/zenbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/glennfu/zenbot/contents/{+path}","compare_url":"https://api.github.com/repos/glennfu/zenbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glennfu/zenbot/merges","archive_url":"https://api.github.com/repos/glennfu/zenbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glennfu/zenbot/downloads","issues_url":"https://api.github.com/repos/glennfu/zenbot/issues{/number}","pulls_url":"https://api.github.com/repos/glennfu/zenbot/pulls{/number}","milestones_url":"https://api.github.com/repos/glennfu/zenbot/milestones{/number}","notifications_url":"https://api.github.com/repos/glennfu/zenbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glennfu/zenbot/labels{/name}","releases_url":"https://api.github.com/repos/glennfu/zenbot/releases{/id}","deployments_url":"https://api.github.com/repos/glennfu/zenbot/deployments","created_at":"2017-12-27T19:08:38Z","updated_at":"2018-02-20T02:56:51Z","pushed_at":"2018-02-27T20:45:54Z","git_url":"git://github.com/glennfu/zenbot.git","ssh_url":"git@github.com:glennfu/zenbot.git","clone_url":"https://github.com/glennfu/zenbot.git","svn_url":"https://github.com/glennfu/zenbot","homepage":"","size":10872,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DeviaVir:unstable","ref":"unstable","sha":"fc28a42d7320b76e9b4b4369e540652b3dbe71de","user":{"login":"DeviaVir","id":777823,"avatar_url":"https://avatars2.githubusercontent.com/u/777823?v=4","gravatar_id":"","url":"https://api.github.com/users/DeviaVir","html_url":"https://github.com/DeviaVir","followers_url":"https://api.github.com/users/DeviaVir/followers","following_url":"https://api.github.com/users/DeviaVir/following{/other_user}","gists_url":"https://api.github.com/users/DeviaVir/gists{/gist_id}","starred_url":"https://api.github.com/users/DeviaVir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeviaVir/subscriptions","organizations_url":"https://api.github.com/users/DeviaVir/orgs","repos_url":"https://api.github.com/users/DeviaVir/repos","events_url":"https://api.github.com/users/DeviaVir/events{/privacy}","received_events_url":"https://api.github.com/users/DeviaVir/received_events","type":"User","site_admin":false},"repo":{"id":62025838,"name":"zenbot","full_name":"DeviaVir/zenbot","owner":{"login":"DeviaVir","id":777823,"avatar_url":"https://avatars2.githubusercontent.com/u/777823?v=4","gravatar_id":"","url":"https://api.github.com/users/DeviaVir","html_url":"https://github.com/DeviaVir","followers_url":"https://api.github.com/users/DeviaVir/followers","following_url":"https://api.github.com/users/DeviaVir/following{/other_user}","gists_url":"https://api.github.com/users/DeviaVir/gists{/gist_id}","starred_url":"https://api.github.com/users/DeviaVir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeviaVir/subscriptions","organizations_url":"https://api.github.com/users/DeviaVir/orgs","repos_url":"https://api.github.com/users/DeviaVir/repos","events_url":"https://api.github.com/users/DeviaVir/events{/privacy}","received_events_url":"https://api.github.com/users/DeviaVir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DeviaVir/zenbot","description":"Zenbot is a command-line cryptocurrency trading bot using Node.js and MongoDB.","fork":false,"url":"https://api.github.com/repos/DeviaVir/zenbot","forks_url":"https://api.github.com/repos/DeviaVir/zenbot/forks","keys_url":"https://api.github.com/repos/DeviaVir/zenbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeviaVir/zenbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeviaVir/zenbot/teams","hooks_url":"https://api.github.com/repos/DeviaVir/zenbot/hooks","issue_events_url":"https://api.github.com/repos/DeviaVir/zenbot/issues/events{/number}","events_url":"https://api.github.com/repos/DeviaVir/zenbot/events","assignees_url":"https://api.github.com/repos/DeviaVir/zenbot/assignees{/user}","branches_url":"https://api.github.com/repos/DeviaVir/zenbot/branches{/branch}","tags_url":"https://api.github.com/repos/DeviaVir/zenbot/tags","blobs_url":"https://api.github.com/repos/DeviaVir/zenbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeviaVir/zenbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeviaVir/zenbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeviaVir/zenbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeviaVir/zenbot/statuses/{sha}","languages_url":"https://api.github.com/repos/DeviaVir/zenbot/languages","stargazers_url":"https://api.github.com/repos/DeviaVir/zenbot/stargazers","contributors_url":"https://api.github.com/repos/DeviaVir/zenbot/contributors","subscribers_url":"https://api.github.com/repos/DeviaVir/zenbot/subscribers","subscription_url":"https://api.github.com/repos/DeviaVir/zenbot/subscription","commits_url":"https://api.github.com/repos/DeviaVir/zenbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeviaVir/zenbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeviaVir/zenbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeviaVir/zenbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeviaVir/zenbot/contents/{+path}","compare_url":"https://api.github.com/repos/DeviaVir/zenbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeviaVir/zenbot/merges","archive_url":"https://api.github.com/repos/DeviaVir/zenbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeviaVir/zenbot/downloads","issues_url":"https://api.github.com/repos/DeviaVir/zenbot/issues{/number}","pulls_url":"https://api.github.com/repos/DeviaVir/zenbot/pulls{/number}","milestones_url":"https://api.github.com/repos/DeviaVir/zenbot/milestones{/number}","notifications_url":"https://api.github.com/repos/DeviaVir/zenbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeviaVir/zenbot/labels{/name}","releases_url":"https://api.github.com/repos/DeviaVir/zenbot/releases{/id}","deployments_url":"https://api.github.com/repos/DeviaVir/zenbot/deployments","created_at":"2016-06-27T04:38:18Z","updated_at":"2018-02-28T08:22:32Z","pushed_at":"2018-02-28T11:15:13Z","git_url":"git://github.com/DeviaVir/zenbot.git","ssh_url":"git@github.com:DeviaVir/zenbot.git","clone_url":"https://github.com/DeviaVir/zenbot.git","svn_url":"https://github.com/DeviaVir/zenbot","homepage":"","size":10816,"stargazers_count":4398,"watchers_count":4398,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1140,"mirror_url":null,"archived":false,"open_issues_count":325,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1140,"open_issues":325,"watchers":4398,"default_branch":"unstable"}},"_links":{"self":{"href":"https://api.github.com/repos/DeviaVir/zenbot/pulls/1431"},"html":{"href":"https://github.com/DeviaVir/zenbot/pull/1431"},"issue":{"href":"https://api.github.com/repos/DeviaVir/zenbot/issues/1431"},"comments":{"href":"https://api.github.com/repos/DeviaVir/zenbot/issues/1431/comments"},"review_comments":{"href":"https://api.github.com/repos/DeviaVir/zenbot/pulls/1431/comments"},"review_comment":{"href":"https://api.github.com/repos/DeviaVir/zenbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DeviaVir/zenbot/pulls/1431/commits"},"statuses":{"href":"https://api.github.com/repos/DeviaVir/zenbot/statuses/ed6cbb03da3f1f2a0e8b1ddece37974e6188c658"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"DeviaVir","id":777823,"avatar_url":"https://avatars2.githubusercontent.com/u/777823?v=4","gravatar_id":"","url":"https://api.github.com/users/DeviaVir","html_url":"https://github.com/DeviaVir","followers_url":"https://api.github.com/users/DeviaVir/followers","following_url":"https://api.github.com/users/DeviaVir/following{/other_user}","gists_url":"https://api.github.com/users/DeviaVir/gists{/gist_id}","starred_url":"https://api.github.com/users/DeviaVir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeviaVir/subscriptions","organizations_url":"https://api.github.com/users/DeviaVir/orgs","repos_url":"https://api.github.com/users/DeviaVir/repos","events_url":"https://api.github.com/users/DeviaVir/events{/privacy}","received_events_url":"https://api.github.com/users/DeviaVir/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"DeviaVir"}}