{"action":"created","issue":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/631","repository_url":"https://api.github.com/repos/openpgpjs/openpgpjs","labels_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/631/labels{/name}","comments_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/631/comments","events_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/631/events","html_url":"https://github.com/openpgpjs/openpgpjs/issues/631","id":295634126,"number":631,"title":"Unify BN libraries","user":{"login":"bartbutler","id":5491415,"avatar_url":"https://avatars0.githubusercontent.com/u/5491415?v=4","gravatar_id":"","url":"https://api.github.com/users/bartbutler","html_url":"https://github.com/bartbutler","followers_url":"https://api.github.com/users/bartbutler/followers","following_url":"https://api.github.com/users/bartbutler/following{/other_user}","gists_url":"https://api.github.com/users/bartbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/bartbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartbutler/subscriptions","organizations_url":"https://api.github.com/users/bartbutler/orgs","repos_url":"https://api.github.com/users/bartbutler/repos","events_url":"https://api.github.com/users/bartbutler/events{/privacy}","received_events_url":"https://api.github.com/users/bartbutler/received_events","type":"User","site_admin":false},"labels":[{"id":78309042,"url":"https://api.github.com/repos/openpgpjs/openpgpjs/labels/Performance","name":"Performance","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-08T19:20:42Z","updated_at":"2018-02-09T09:12:46Z","closed_at":null,"author_association":"OWNER","body":"Eliminate jsbn in favor of one of the modern BN libraries, probably BN.js or asmCrypto's bn library. Need to do appropriate benchmarks first:\r\n\r\nhttps://peterolson.github.io/BigInteger.js/benchmark/"},"comment":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/comments/364377480","html_url":"https://github.com/openpgpjs/openpgpjs/issues/631#issuecomment-364377480","issue_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/631","id":364377480,"user":{"login":"mahrud","id":3147718,"avatar_url":"https://avatars3.githubusercontent.com/u/3147718?v=4","gravatar_id":"","url":"https://api.github.com/users/mahrud","html_url":"https://github.com/mahrud","followers_url":"https://api.github.com/users/mahrud/followers","following_url":"https://api.github.com/users/mahrud/following{/other_user}","gists_url":"https://api.github.com/users/mahrud/gists{/gist_id}","starred_url":"https://api.github.com/users/mahrud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahrud/subscriptions","organizations_url":"https://api.github.com/users/mahrud/orgs","repos_url":"https://api.github.com/users/mahrud/repos","events_url":"https://api.github.com/users/mahrud/events{/privacy}","received_events_url":"https://api.github.com/users/mahrud/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T09:12:46Z","updated_at":"2018-02-09T09:12:46Z","author_association":"CONTRIBUTOR","body":"In case we do decide to go with asmcrypto, I made a branch [feat/asmcrypto](https://github.com/openpgpjs/openpgpjs/commits/feat/asmcrypto) that uses a minimal asmcrypto bundle for AES and SHA256 and bignum (I can later add RSA as well, but I'm not sure which specific RSA modules we need).\r\n\r\nI decided not go with asmcrypto-lite because it's outdated and making a minimal asmcrypto bundle is as easy as adding and removing 11 lines now: https://github.com/mahrud/asmcrypto.js/commit/32ab996fac3e9bff62a53ce279c72f483a66771e\r\n\r\nOne potential thing to worry about is the size. asmCrypto is significantly faster but it seems to be bulkier than counterparts."}}
{"actor":{"display_login":"mahrud"}}