{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/198433367","pull_request_review_id":132360734,"id":198433367,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQzMzM2Nw==","diff_hunk":"@@ -121,6 +129,54 @@ private static void addPrivateCredential(final Subject subject, final Object cre\n         }\n     }\n \n+    public static SecurityIdentity convertToSecurityIdentity(Subject subject, Principal principal, SecurityDomain domain,","path":"webservices/server-integration/src/main/java/org/jboss/as/webservices/util/SubjectUtil.java","position":40,"original_position":40,"commit_id":"dd6e947ba70e14cdd939bd301c7757bb980f5d09","original_commit_id":"dd6e947ba70e14cdd939bd301c7757bb980f5d09","user":{"login":"hkalina","id":3178122,"node_id":"MDQ6VXNlcjMxNzgxMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3178122?v=4","gravatar_id":"","url":"https://api.github.com/users/hkalina","html_url":"https://github.com/hkalina","followers_url":"https://api.github.com/users/hkalina/followers","following_url":"https://api.github.com/users/hkalina/following{/other_user}","gists_url":"https://api.github.com/users/hkalina/gists{/gist_id}","starred_url":"https://api.github.com/users/hkalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkalina/subscriptions","organizations_url":"https://api.github.com/users/hkalina/orgs","repos_url":"https://api.github.com/users/hkalina/repos","events_url":"https://api.github.com/users/hkalina/events{/privacy}","received_events_url":"https://api.github.com/users/hkalina/received_events","type":"User","site_admin":false},"body":"Maybe just `toSecurityIdentity` name would be more consistent with existing `fromSecurityIdentity` method.\r\nOtherwise looks ok I think.","created_at":"2018-06-27T09:50:12Z","updated_at":"2018-06-27T09:50:12Z","html_url":"https://github.com/wildfly/wildfly/pull/11383#discussion_r198433367","pull_request_url":"https://api.github.com/repos/wildfly/wildfly/pulls/11383","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/198433367"},"html":{"href":"https://github.com/wildfly/wildfly/pull/11383#discussion_r198433367"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11383"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/11383","id":197665386,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjY1Mzg2","html_url":"https://github.com/wildfly/wildfly/pull/11383","diff_url":"https://github.com/wildfly/wildfly/pull/11383.diff","patch_url":"https://github.com/wildfly/wildfly/pull/11383.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly/issues/11383","number":11383,"state":"open","locked":false,"title":"[WFLY-10480]:Convert subject to Elytron securityIdentity ","user":{"login":"jimma","id":91742,"node_id":"MDQ6VXNlcjkxNzQy","avatar_url":"https://avatars3.githubusercontent.com/u/91742?v=4","gravatar_id":"","url":"https://api.github.com/users/jimma","html_url":"https://github.com/jimma","followers_url":"https://api.github.com/users/jimma/followers","following_url":"https://api.github.com/users/jimma/following{/other_user}","gists_url":"https://api.github.com/users/jimma/gists{/gist_id}","starred_url":"https://api.github.com/users/jimma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimma/subscriptions","organizations_url":"https://api.github.com/users/jimma/orgs","repos_url":"https://api.github.com/users/jimma/repos","events_url":"https://api.github.com/users/jimma/events{/privacy}","received_events_url":"https://api.github.com/users/jimma/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/WFLY-10480","created_at":"2018-06-27T09:12:21Z","updated_at":"2018-06-27T09:50:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34e4e7bd9659afdead9af02a8b03332089c48709","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly/pulls/11383/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly/pulls/11383/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly/issues/11383/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/dd6e947ba70e14cdd939bd301c7757bb980f5d09","head":{"label":"jimma:WFLY-10480","ref":"WFLY-10480","sha":"dd6e947ba70e14cdd939bd301c7757bb980f5d09","user":{"login":"jimma","id":91742,"node_id":"MDQ6VXNlcjkxNzQy","avatar_url":"https://avatars3.githubusercontent.com/u/91742?v=4","gravatar_id":"","url":"https://api.github.com/users/jimma","html_url":"https://github.com/jimma","followers_url":"https://api.github.com/users/jimma/followers","following_url":"https://api.github.com/users/jimma/following{/other_user}","gists_url":"https://api.github.com/users/jimma/gists{/gist_id}","starred_url":"https://api.github.com/users/jimma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimma/subscriptions","organizations_url":"https://api.github.com/users/jimma/orgs","repos_url":"https://api.github.com/users/jimma/repos","events_url":"https://api.github.com/users/jimma/events{/privacy}","received_events_url":"https://api.github.com/users/jimma/received_events","type":"User","site_admin":false},"repo":{"id":9808749,"node_id":"MDEwOlJlcG9zaXRvcnk5ODA4NzQ5","name":"wildfly","full_name":"jimma/wildfly","owner":{"login":"jimma","id":91742,"node_id":"MDQ6VXNlcjkxNzQy","avatar_url":"https://avatars3.githubusercontent.com/u/91742?v=4","gravatar_id":"","url":"https://api.github.com/users/jimma","html_url":"https://github.com/jimma","followers_url":"https://api.github.com/users/jimma/followers","following_url":"https://api.github.com/users/jimma/following{/other_user}","gists_url":"https://api.github.com/users/jimma/gists{/gist_id}","starred_url":"https://api.github.com/users/jimma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimma/subscriptions","organizations_url":"https://api.github.com/users/jimma/orgs","repos_url":"https://api.github.com/users/jimma/repos","events_url":"https://api.github.com/users/jimma/events{/privacy}","received_events_url":"https://api.github.com/users/jimma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimma/wildfly","description":"WildFly Application Server","fork":true,"url":"https://api.github.com/repos/jimma/wildfly","forks_url":"https://api.github.com/repos/jimma/wildfly/forks","keys_url":"https://api.github.com/repos/jimma/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimma/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimma/wildfly/teams","hooks_url":"https://api.github.com/repos/jimma/wildfly/hooks","issue_events_url":"https://api.github.com/repos/jimma/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/jimma/wildfly/events","assignees_url":"https://api.github.com/repos/jimma/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/jimma/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/jimma/wildfly/tags","blobs_url":"https://api.github.com/repos/jimma/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimma/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimma/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimma/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimma/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/jimma/wildfly/languages","stargazers_url":"https://api.github.com/repos/jimma/wildfly/stargazers","contributors_url":"https://api.github.com/repos/jimma/wildfly/contributors","subscribers_url":"https://api.github.com/repos/jimma/wildfly/subscribers","subscription_url":"https://api.github.com/repos/jimma/wildfly/subscription","commits_url":"https://api.github.com/repos/jimma/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimma/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimma/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimma/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimma/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/jimma/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimma/wildfly/merges","archive_url":"https://api.github.com/repos/jimma/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimma/wildfly/downloads","issues_url":"https://api.github.com/repos/jimma/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/jimma/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/jimma/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/jimma/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimma/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/jimma/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/jimma/wildfly/deployments","created_at":"2013-05-02T08:19:09Z","updated_at":"2015-01-14T09:06:09Z","pushed_at":"2018-06-27T03:47:54Z","git_url":"git://github.com/jimma/wildfly.git","ssh_url":"git@github.com:jimma/wildfly.git","clone_url":"https://github.com/jimma/wildfly.git","svn_url":"https://github.com/jimma/wildfly","homepage":"http://wildfly.org","size":183922,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"7ac602394b4785f51e836346c8211f469df9e7b3","user":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":764708,"node_id":"MDEwOlJlcG9zaXRvcnk3NjQ3MDg=","name":"wildfly","full_name":"wildfly/wildfly","owner":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly","description":"WildFly Application Server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly","forks_url":"https://api.github.com/repos/wildfly/wildfly/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly/deployments","created_at":"2010-07-08T20:46:07Z","updated_at":"2018-06-26T16:37:44Z","pushed_at":"2018-06-27T09:20:43Z","git_url":"git://github.com/wildfly/wildfly.git","ssh_url":"git@github.com:wildfly/wildfly.git","clone_url":"https://github.com/wildfly/wildfly.git","svn_url":"https://github.com/wildfly/wildfly","homepage":"http://wildfly.org","size":185460,"stargazers_count":2011,"watchers_count":2011,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1797,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1797,"open_issues":38,"watchers":2011,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11383"},"html":{"href":"https://github.com/wildfly/wildfly/pull/11383"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/11383"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/11383/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11383/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11383/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly/statuses/dd6e947ba70e14cdd939bd301c7757bb980f5d09"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hkalina"}}