{"action":"created","comment":{"url":"https://api.github.com/repos/python-visualization/folium/pulls/comments/243759776","pull_request_review_id":187616494,"id":243759776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc1OTc3Ng==","diff_hunk":"@@ -66,27 +66,15 @@ def path_options(**kwargs):\n     http://leafletjs.com/reference-1.2.0.html#path\n \n     \"\"\"\n-    valid_options = (","path":"folium/vector_layers.py","position":13,"original_position":13,"commit_id":"a63ed203932c6404a33763638f4f794b7989acf8","original_commit_id":"a63ed203932c6404a33763638f4f794b7989acf8","user":{"login":"Conengmo","id":33519926,"node_id":"MDQ6VXNlcjMzNTE5OTI2","avatar_url":"https://avatars1.githubusercontent.com/u/33519926?v=4","gravatar_id":"","url":"https://api.github.com/users/Conengmo","html_url":"https://github.com/Conengmo","followers_url":"https://api.github.com/users/Conengmo/followers","following_url":"https://api.github.com/users/Conengmo/following{/other_user}","gists_url":"https://api.github.com/users/Conengmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Conengmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Conengmo/subscriptions","organizations_url":"https://api.github.com/users/Conengmo/orgs","repos_url":"https://api.github.com/users/Conengmo/repos","events_url":"https://api.github.com/users/Conengmo/events{/privacy}","received_events_url":"https://api.github.com/users/Conengmo/received_events","type":"User","site_admin":false},"body":"I get that it's cleaner to not have to define and maintain this list. But now if someone passes a faulty option it gets ignored silently, which is a problem because a user may not exactly know which options are valid. When no error is raised it's hard to find out. Can we add a check at the bottom of this function that warns when any kwargs have not been popped?","created_at":"2018-12-23T11:06:32Z","updated_at":"2018-12-23T11:19:21Z","html_url":"https://github.com/python-visualization/folium/pull/1016#discussion_r243759776","pull_request_url":"https://api.github.com/repos/python-visualization/folium/pulls/1016","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/comments/243759776"},"html":{"href":"https://github.com/python-visualization/folium/pull/1016#discussion_r243759776"},"pull_request":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/1016"}}},"pull_request":{"url":"https://api.github.com/repos/python-visualization/folium/pulls/1016","id":229459817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDU5ODE3","html_url":"https://github.com/python-visualization/folium/pull/1016","diff_url":"https://github.com/python-visualization/folium/pull/1016.diff","patch_url":"https://github.com/python-visualization/folium/pull/1016.patch","issue_url":"https://api.github.com/repos/python-visualization/folium/issues/1016","number":1016,"state":"open","locked":false,"title":"Antpath","user":{"login":"ocefpaf","id":950575,"node_id":"MDQ6VXNlcjk1MDU3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/950575?v=4","gravatar_id":"","url":"https://api.github.com/users/ocefpaf","html_url":"https://github.com/ocefpaf","followers_url":"https://api.github.com/users/ocefpaf/followers","following_url":"https://api.github.com/users/ocefpaf/following{/other_user}","gists_url":"https://api.github.com/users/ocefpaf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocefpaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocefpaf/subscriptions","organizations_url":"https://api.github.com/users/ocefpaf/orgs","repos_url":"https://api.github.com/users/ocefpaf/repos","events_url":"https://api.github.com/users/ocefpaf/events{/privacy}","received_events_url":"https://api.github.com/users/ocefpaf/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/python-visualization/folium/issues/522","created_at":"2018-11-08T18:07:36Z","updated_at":"2018-12-23T11:19:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fcaf32e7c99dd5d78c2d006a280c0a63449f47d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1091376071,"node_id":"MDU6TGFiZWwxMDkxMzc2MDcx","url":"https://api.github.com/repos/python-visualization/folium/labels/review%20needed","name":"review needed","color":"fc9496","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python-visualization/folium/pulls/1016/commits","review_comments_url":"https://api.github.com/repos/python-visualization/folium/pulls/1016/comments","review_comment_url":"https://api.github.com/repos/python-visualization/folium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-visualization/folium/issues/1016/comments","statuses_url":"https://api.github.com/repos/python-visualization/folium/statuses/a63ed203932c6404a33763638f4f794b7989acf8","head":{"label":"ocefpaf:antpath","ref":"antpath","sha":"a63ed203932c6404a33763638f4f794b7989acf8","user":{"login":"ocefpaf","id":950575,"node_id":"MDQ6VXNlcjk1MDU3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/950575?v=4","gravatar_id":"","url":"https://api.github.com/users/ocefpaf","html_url":"https://github.com/ocefpaf","followers_url":"https://api.github.com/users/ocefpaf/followers","following_url":"https://api.github.com/users/ocefpaf/following{/other_user}","gists_url":"https://api.github.com/users/ocefpaf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocefpaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocefpaf/subscriptions","organizations_url":"https://api.github.com/users/ocefpaf/orgs","repos_url":"https://api.github.com/users/ocefpaf/repos","events_url":"https://api.github.com/users/ocefpaf/events{/privacy}","received_events_url":"https://api.github.com/users/ocefpaf/received_events","type":"User","site_admin":false},"repo":{"id":21402651,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQwMjY1MQ==","name":"folium","full_name":"ocefpaf/folium","private":false,"owner":{"login":"ocefpaf","id":950575,"node_id":"MDQ6VXNlcjk1MDU3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/950575?v=4","gravatar_id":"","url":"https://api.github.com/users/ocefpaf","html_url":"https://github.com/ocefpaf","followers_url":"https://api.github.com/users/ocefpaf/followers","following_url":"https://api.github.com/users/ocefpaf/following{/other_user}","gists_url":"https://api.github.com/users/ocefpaf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocefpaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocefpaf/subscriptions","organizations_url":"https://api.github.com/users/ocefpaf/orgs","repos_url":"https://api.github.com/users/ocefpaf/repos","events_url":"https://api.github.com/users/ocefpaf/events{/privacy}","received_events_url":"https://api.github.com/users/ocefpaf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ocefpaf/folium","description":"Python Data. Leaflet.js Maps. ","fork":true,"url":"https://api.github.com/repos/ocefpaf/folium","forks_url":"https://api.github.com/repos/ocefpaf/folium/forks","keys_url":"https://api.github.com/repos/ocefpaf/folium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocefpaf/folium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocefpaf/folium/teams","hooks_url":"https://api.github.com/repos/ocefpaf/folium/hooks","issue_events_url":"https://api.github.com/repos/ocefpaf/folium/issues/events{/number}","events_url":"https://api.github.com/repos/ocefpaf/folium/events","assignees_url":"https://api.github.com/repos/ocefpaf/folium/assignees{/user}","branches_url":"https://api.github.com/repos/ocefpaf/folium/branches{/branch}","tags_url":"https://api.github.com/repos/ocefpaf/folium/tags","blobs_url":"https://api.github.com/repos/ocefpaf/folium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocefpaf/folium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocefpaf/folium/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocefpaf/folium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocefpaf/folium/statuses/{sha}","languages_url":"https://api.github.com/repos/ocefpaf/folium/languages","stargazers_url":"https://api.github.com/repos/ocefpaf/folium/stargazers","contributors_url":"https://api.github.com/repos/ocefpaf/folium/contributors","subscribers_url":"https://api.github.com/repos/ocefpaf/folium/subscribers","subscription_url":"https://api.github.com/repos/ocefpaf/folium/subscription","commits_url":"https://api.github.com/repos/ocefpaf/folium/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocefpaf/folium/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocefpaf/folium/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocefpaf/folium/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocefpaf/folium/contents/{+path}","compare_url":"https://api.github.com/repos/ocefpaf/folium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocefpaf/folium/merges","archive_url":"https://api.github.com/repos/ocefpaf/folium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocefpaf/folium/downloads","issues_url":"https://api.github.com/repos/ocefpaf/folium/issues{/number}","pulls_url":"https://api.github.com/repos/ocefpaf/folium/pulls{/number}","milestones_url":"https://api.github.com/repos/ocefpaf/folium/milestones{/number}","notifications_url":"https://api.github.com/repos/ocefpaf/folium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocefpaf/folium/labels{/name}","releases_url":"https://api.github.com/repos/ocefpaf/folium/releases{/id}","deployments_url":"https://api.github.com/repos/ocefpaf/folium/deployments","created_at":"2014-07-01T21:13:24Z","updated_at":"2018-10-19T11:37:00Z","pushed_at":"2018-12-11T19:05:41Z","git_url":"git://github.com/ocefpaf/folium.git","ssh_url":"git@github.com:ocefpaf/folium.git","clone_url":"https://github.com/ocefpaf/folium.git","svn_url":"https://github.com/ocefpaf/folium","homepage":"","size":73360,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-visualization:master","ref":"master","sha":"f4d024d97c20a51e14169f671411ef0a2fa85d07","user":{"login":"python-visualization","id":9969242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjkyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9969242?v=4","gravatar_id":"","url":"https://api.github.com/users/python-visualization","html_url":"https://github.com/python-visualization","followers_url":"https://api.github.com/users/python-visualization/followers","following_url":"https://api.github.com/users/python-visualization/following{/other_user}","gists_url":"https://api.github.com/users/python-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/python-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-visualization/subscriptions","organizations_url":"https://api.github.com/users/python-visualization/orgs","repos_url":"https://api.github.com/users/python-visualization/repos","events_url":"https://api.github.com/users/python-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/python-visualization/received_events","type":"Organization","site_admin":false},"repo":{"id":9952134,"node_id":"MDEwOlJlcG9zaXRvcnk5OTUyMTM0","name":"folium","full_name":"python-visualization/folium","private":false,"owner":{"login":"python-visualization","id":9969242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjkyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9969242?v=4","gravatar_id":"","url":"https://api.github.com/users/python-visualization","html_url":"https://github.com/python-visualization","followers_url":"https://api.github.com/users/python-visualization/followers","following_url":"https://api.github.com/users/python-visualization/following{/other_user}","gists_url":"https://api.github.com/users/python-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/python-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-visualization/subscriptions","organizations_url":"https://api.github.com/users/python-visualization/orgs","repos_url":"https://api.github.com/users/python-visualization/repos","events_url":"https://api.github.com/users/python-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/python-visualization/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python-visualization/folium","description":"Python Data. Leaflet.js Maps. ","fork":false,"url":"https://api.github.com/repos/python-visualization/folium","forks_url":"https://api.github.com/repos/python-visualization/folium/forks","keys_url":"https://api.github.com/repos/python-visualization/folium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-visualization/folium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-visualization/folium/teams","hooks_url":"https://api.github.com/repos/python-visualization/folium/hooks","issue_events_url":"https://api.github.com/repos/python-visualization/folium/issues/events{/number}","events_url":"https://api.github.com/repos/python-visualization/folium/events","assignees_url":"https://api.github.com/repos/python-visualization/folium/assignees{/user}","branches_url":"https://api.github.com/repos/python-visualization/folium/branches{/branch}","tags_url":"https://api.github.com/repos/python-visualization/folium/tags","blobs_url":"https://api.github.com/repos/python-visualization/folium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-visualization/folium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-visualization/folium/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-visualization/folium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-visualization/folium/statuses/{sha}","languages_url":"https://api.github.com/repos/python-visualization/folium/languages","stargazers_url":"https://api.github.com/repos/python-visualization/folium/stargazers","contributors_url":"https://api.github.com/repos/python-visualization/folium/contributors","subscribers_url":"https://api.github.com/repos/python-visualization/folium/subscribers","subscription_url":"https://api.github.com/repos/python-visualization/folium/subscription","commits_url":"https://api.github.com/repos/python-visualization/folium/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-visualization/folium/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-visualization/folium/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-visualization/folium/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-visualization/folium/contents/{+path}","compare_url":"https://api.github.com/repos/python-visualization/folium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-visualization/folium/merges","archive_url":"https://api.github.com/repos/python-visualization/folium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-visualization/folium/downloads","issues_url":"https://api.github.com/repos/python-visualization/folium/issues{/number}","pulls_url":"https://api.github.com/repos/python-visualization/folium/pulls{/number}","milestones_url":"https://api.github.com/repos/python-visualization/folium/milestones{/number}","notifications_url":"https://api.github.com/repos/python-visualization/folium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-visualization/folium/labels{/name}","releases_url":"https://api.github.com/repos/python-visualization/folium/releases{/id}","deployments_url":"https://api.github.com/repos/python-visualization/folium/deployments","created_at":"2013-05-09T04:21:35Z","updated_at":"2018-12-23T10:42:31Z","pushed_at":"2018-12-23T10:42:28Z","git_url":"git://github.com/python-visualization/folium.git","ssh_url":"git@github.com:python-visualization/folium.git","clone_url":"https://github.com/python-visualization/folium.git","svn_url":"https://github.com/python-visualization/folium","homepage":"http://python-visualization.github.io/folium/","size":81351,"stargazers_count":3547,"watchers_count":3547,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1049,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1049,"open_issues":51,"watchers":3547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/1016"},"html":{"href":"https://github.com/python-visualization/folium/pull/1016"},"issue":{"href":"https://api.github.com/repos/python-visualization/folium/issues/1016"},"comments":{"href":"https://api.github.com/repos/python-visualization/folium/issues/1016/comments"},"review_comments":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/1016/comments"},"review_comment":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-visualization/folium/pulls/1016/commits"},"statuses":{"href":"https://api.github.com/repos/python-visualization/folium/statuses/a63ed203932c6404a33763638f4f794b7989acf8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Conengmo"}}