{"push_id":2618429970,"size":2,"distinct_size":2,"ref":"refs/heads/staging","head":"2964917b8c360367b66c6ac440aafca3515b8c45","before":"4def0eef551019408322dbd6548fd5d668fb21c1","commits":[{"sha":"6e9ad403b3cbab4ec1d36f390b26fa19d0fac255","author":{"name":"marc","email":"d33c80bc45d65303e33ca83108a9952b745af9ef@cockroachlabs.com"},"message":"libroach: fix concurrent access to same file when using encryption\n\nFixes #26261.\n\nThe various `Env::***File` objects are used concurrently by rocksdb (eg: in the compaction code).\nIf multiple reads occur on the same encrypted file handle and CryptoPP is using the software AES implementation, some working state in the cipher gets corrupted by the other calls. This results in broken decryption bubbling up as checksum failures on rocksdb.\n\nFix this by passing the key to the `CTRCipherStream` and initializing a new `Cipher` object for each block of data (the `RandomAccessFile::Read` block. This will still use one `Cipher` for multiple AES blocks).\n\nRelease note (bug fix): fix concurrent access to same file when using encryption","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/6e9ad403b3cbab4ec1d36f390b26fa19d0fac255"},{"sha":"2964917b8c360367b66c6ac440aafca3515b8c45","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #26377\n\n26377: libroach: fix concurrent access to same file when using encryption r=mberhault a=mberhault\n\nFixes #26261.\r\n\r\nThe various `Env::***File` objects are used concurrently by rocksdb (eg: in the compaction code).\r\nIf multiple reads occur on the same encrypted file handle and CryptoPP is using the software AES implementation, some working state in the cipher gets corrupted by the other calls. This results in broken decryption bubbling up as checksum failures on rocksdb.\r\n\r\nFix this by passing the key to the `CTRCipherStream` and initializing a new `Cipher` object for each block of data (the `RandomAccessFile::Read` block. This will still use one `Cipher` for multiple AES blocks).\r\n\r\nRelease note (bug fix): fix concurrent access to same file when using encryption\n\nCo-authored-by: marc <marc@cockroachlabs.com>","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/2964917b8c360367b66c6ac440aafca3515b8c45"}]}
{"actor":{"display_login":"craig"}}