{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/226298395","pull_request_review_id":166085042,"id":226298395,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI5ODM5NQ==","diff_hunk":"@@ -98,14 +98,6 @@ private function collectMessage(string $busName, array $tracedMessage)\n             'caller' => $tracedMessage['caller'],\n         );\n \n-        if (array_key_exists('result', $tracedMessage)) {","path":"src/Symfony/Component/Messenger/DataCollector/MessengerDataCollector.php","position":4,"original_position":4,"commit_id":"d81d9075f29debc7ee369824b75735ceabdd23d7","original_commit_id":"53cecc4d0f9211d8489aa32bd3af83d0c8a9f5d9","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"fixed thanks","created_at":"2018-10-18T13:13:50Z","updated_at":"2018-10-18T13:13:50Z","html_url":"https://github.com/symfony/symfony/pull/28909#discussion_r226298395","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/28909","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/226298395"},"html":{"href":"https://github.com/symfony/symfony/pull/28909#discussion_r226298395"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28909"}},"in_reply_to_id":226199465},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/28909","id":223686182,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjg2MTgy","html_url":"https://github.com/symfony/symfony/pull/28909","diff_url":"https://github.com/symfony/symfony/pull/28909.diff","patch_url":"https://github.com/symfony/symfony/pull/28909.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/28909","number":28909,"state":"open","locked":false,"title":"[Messenger] made dispatch() and handle() return void","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 4.2\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nMiddlewares and dispatchers should not return any value. Forwarding back the results from handlers breaks the scope of the component. The canonical example of some bad design this can lead to is `ChainHandler`: how can the caller know that there is one in the chain and that it should expect an array as a return value? More generally, how can a caller know what to expect back from a call to dispatch()? I think we should not allow such broken designs.\r\n\r\nInstead, we should favor east-oriented design: if one needs a command bus, one would have to dispatch a proper command object - and if a result is expected back, it should be done via a setter on the dispatched command - or better, a callback set on the command object. This way we play *by the rules* of the type-system, not against.","created_at":"2018-10-17T17:15:13Z","updated_at":"2018-10-18T13:13:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"955d49f2597cacc58040a3aef976ec6e2fe7be0f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sroze","id":804625,"node_id":"MDQ6VXNlcjgwNDYyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/804625?v=4","gravatar_id":"","url":"https://api.github.com/users/sroze","html_url":"https://github.com/sroze","followers_url":"https://api.github.com/users/sroze/followers","following_url":"https://api.github.com/users/sroze/following{/other_user}","gists_url":"https://api.github.com/users/sroze/gists{/gist_id}","starred_url":"https://api.github.com/users/sroze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sroze/subscriptions","organizations_url":"https://api.github.com/users/sroze/orgs","repos_url":"https://api.github.com/users/sroze/repos","events_url":"https://api.github.com/users/sroze/events{/privacy}","received_events_url":"https://api.github.com/users/sroze/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":231677,"node_id":"MDU6TGFiZWwyMzE2Nzc=","url":"https://api.github.com/repos/symfony/symfony/labels/BC%20Break","name":"BC Break","color":"e10c02","default":false},{"id":877085690,"node_id":"MDU6TGFiZWw4NzcwODU2OTA=","url":"https://api.github.com/repos/symfony/symfony/labels/Messenger","name":"Messenger","color":"dddddd","default":false},{"id":237550465,"node_id":"MDU6TGFiZWwyMzc1NTA0NjU=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Reviewed","name":"Status: Reviewed","color":"bfe5bf","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/19","html_url":"https://github.com/symfony/symfony/milestone/19","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/19/labels","id":3698991,"node_id":"MDk6TWlsZXN0b25lMzY5ODk5MQ==","number":19,"title":"4.2","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":14,"state":"open","created_at":"2018-09-30T09:27:56Z","updated_at":"2018-10-18T12:58:16Z","due_on":"2018-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/28909/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/28909/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/28909/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/d81d9075f29debc7ee369824b75735ceabdd23d7","head":{"label":"nicolas-grekas:messenger-no-return","ref":"messenger-no-return","sha":"d81d9075f29debc7ee369824b75735ceabdd23d7","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"repo":{"id":15110606,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMDYwNg==","name":"symfony","full_name":"nicolas-grekas/symfony","private":false,"owner":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nicolas-grekas/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony","forks_url":"https://api.github.com/repos/nicolas-grekas/symfony/forks","keys_url":"https://api.github.com/repos/nicolas-grekas/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolas-grekas/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolas-grekas/symfony/teams","hooks_url":"https://api.github.com/repos/nicolas-grekas/symfony/hooks","issue_events_url":"https://api.github.com/repos/nicolas-grekas/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/nicolas-grekas/symfony/events","assignees_url":"https://api.github.com/repos/nicolas-grekas/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/nicolas-grekas/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/nicolas-grekas/symfony/tags","blobs_url":"https://api.github.com/repos/nicolas-grekas/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolas-grekas/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolas-grekas/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolas-grekas/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolas-grekas/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolas-grekas/symfony/languages","stargazers_url":"https://api.github.com/repos/nicolas-grekas/symfony/stargazers","contributors_url":"https://api.github.com/repos/nicolas-grekas/symfony/contributors","subscribers_url":"https://api.github.com/repos/nicolas-grekas/symfony/subscribers","subscription_url":"https://api.github.com/repos/nicolas-grekas/symfony/subscription","commits_url":"https://api.github.com/repos/nicolas-grekas/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolas-grekas/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolas-grekas/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolas-grekas/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolas-grekas/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/nicolas-grekas/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolas-grekas/symfony/merges","archive_url":"https://api.github.com/repos/nicolas-grekas/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolas-grekas/symfony/downloads","issues_url":"https://api.github.com/repos/nicolas-grekas/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/nicolas-grekas/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolas-grekas/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolas-grekas/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolas-grekas/symfony/labels{/name}","releases_url":"https://api.github.com/repos/nicolas-grekas/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/nicolas-grekas/symfony/deployments","created_at":"2013-12-11T15:13:36Z","updated_at":"2018-10-04T05:54:12Z","pushed_at":"2018-10-18T13:13:42Z","git_url":"git://github.com/nicolas-grekas/symfony.git","ssh_url":"git@github.com:nicolas-grekas/symfony.git","clone_url":"https://github.com/nicolas-grekas/symfony.git","svn_url":"https://github.com/nicolas-grekas/symfony","homepage":"symfony.com","size":121530,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"bcff6474685cccdaa20c3fc10e353e61c3be66e2","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-10-18T12:34:19Z","pushed_at":"2018-10-18T13:01:14Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":126737,"stargazers_count":18824,"watchers_count":18824,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6466,"mirror_url":null,"archived":false,"open_issues_count":821,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6466,"open_issues":821,"watchers":18824,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28909"},"html":{"href":"https://github.com/symfony/symfony/pull/28909"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/28909"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/28909/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28909/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28909/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/d81d9075f29debc7ee369824b75735ceabdd23d7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nicolas-grekas"}}