{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/sun/issues/351","repository_url":"https://api.github.com/repos/phetsims/sun","labels_url":"https://api.github.com/repos/phetsims/sun/issues/351/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/sun/issues/351/comments","events_url":"https://api.github.com/repos/phetsims/sun/issues/351/events","html_url":"https://github.com/phetsims/sun/issues/351","id":313527919,"number":351,"title":"Visual appearance of rectangular buttons","user":{"login":"jonathanolson","id":480878,"avatar_url":"https://avatars3.githubusercontent.com/u/480878?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanolson","html_url":"https://github.com/jonathanolson","followers_url":"https://api.github.com/users/jonathanolson/followers","following_url":"https://api.github.com/users/jonathanolson/following{/other_user}","gists_url":"https://api.github.com/users/jonathanolson/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanolson/subscriptions","organizations_url":"https://api.github.com/users/jonathanolson/orgs","repos_url":"https://api.github.com/users/jonathanolson/repos","events_url":"https://api.github.com/users/jonathanolson/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanolson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ariel-phet","id":4051174,"avatar_url":"https://avatars0.githubusercontent.com/u/4051174?v=4","gravatar_id":"","url":"https://api.github.com/users/ariel-phet","html_url":"https://github.com/ariel-phet","followers_url":"https://api.github.com/users/ariel-phet/followers","following_url":"https://api.github.com/users/ariel-phet/following{/other_user}","gists_url":"https://api.github.com/users/ariel-phet/gists{/gist_id}","starred_url":"https://api.github.com/users/ariel-phet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariel-phet/subscriptions","organizations_url":"https://api.github.com/users/ariel-phet/orgs","repos_url":"https://api.github.com/users/ariel-phet/repos","events_url":"https://api.github.com/users/ariel-phet/events{/privacy}","received_events_url":"https://api.github.com/users/ariel-phet/received_events","type":"User","site_admin":false},"assignees":[{"login":"ariel-phet","id":4051174,"avatar_url":"https://avatars0.githubusercontent.com/u/4051174?v=4","gravatar_id":"","url":"https://api.github.com/users/ariel-phet","html_url":"https://github.com/ariel-phet","followers_url":"https://api.github.com/users/ariel-phet/followers","following_url":"https://api.github.com/users/ariel-phet/following{/other_user}","gists_url":"https://api.github.com/users/ariel-phet/gists{/gist_id}","starred_url":"https://api.github.com/users/ariel-phet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariel-phet/subscriptions","organizations_url":"https://api.github.com/users/ariel-phet/orgs","repos_url":"https://api.github.com/users/ariel-phet/repos","events_url":"https://api.github.com/users/ariel-phet/events{/privacy}","received_events_url":"https://api.github.com/users/ariel-phet/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-04-11T23:53:58Z","updated_at":"2018-04-13T15:52:44Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Noticed with mockups and current vegas level selection buttons:\r\n\r\nThe lower-right corner of our rectangular buttons look kind of weirdly unshadowed:\r\n![button-current](https://user-images.githubusercontent.com/480878/38648933-1adf3598-3db1-11e8-86d8-20b5917a99f0.PNG)\r\n\r\nwhereas things like ShadedRectangle have a shadow along the corner:\r\n![button-desired](https://user-images.githubusercontent.com/480878/38648952-2b910dbc-3db1-11e8-9b3a-df088705868e.PNG)\r\n\r\nIt's been bugging me, so I figured I'd report it. Assigning @ariel-phet to see what priority it is, and @jbphet in case the current appearance is unintended (i.e. a regression)."},"comment":{"url":"https://api.github.com/repos/phetsims/sun/issues/comments/381179426","html_url":"https://github.com/phetsims/sun/issues/351#issuecomment-381179426","issue_url":"https://api.github.com/repos/phetsims/sun/issues/351","id":381179426,"user":{"login":"jbphet","id":3082831,"avatar_url":"https://avatars2.githubusercontent.com/u/3082831?v=4","gravatar_id":"","url":"https://api.github.com/users/jbphet","html_url":"https://github.com/jbphet","followers_url":"https://api.github.com/users/jbphet/followers","following_url":"https://api.github.com/users/jbphet/following{/other_user}","gists_url":"https://api.github.com/users/jbphet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbphet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbphet/subscriptions","organizations_url":"https://api.github.com/users/jbphet/orgs","repos_url":"https://api.github.com/users/jbphet/repos","events_url":"https://api.github.com/users/jbphet/events{/privacy}","received_events_url":"https://api.github.com/users/jbphet/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T15:52:44Z","updated_at":"2018-04-13T15:52:44Z","author_association":"CONTRIBUTOR","body":"The rectangular buttons have been like this since they were created.  It's because they use two separate linear gradients - one the is horizontal and one that is vertical - to create both the shading and the pressed appearance, and there isn't any ability to round those at the corner.  If you look closely at the highlight in the upper left corner, it has the same problem.\r\n\r\nI don't think ShadedRectangle existed when the buttons were created, so perhaps we could switch to that now.  We'd still need a gradient to create the pressed appearance, but I assume a shaded rectangle could have a gradient fill that doesn't mess with the appearance of the sides.\r\n\r\n@jonathanolson - I don't know if you remember, but we discussed this back when the buttons were first created, and you said that you were thinking of adding some other 2D gradients that might solve this problem as well.\r\n\r\nHaving said this, I just looked at all the buttons in the Sun demo, and this issue is barely noticable there.  It seems like it is most visible on large, lightly colored buttons, like those used on the game screens.  We should address it at some point, but @ariel-phet should factor this in when setting priority."}}
{"actor":{"display_login":"jbphet"}}