{"push_id":2780196497,"size":9,"distinct_size":9,"ref":"refs/heads/master","head":"04ca0d5411e565b6bddf583b60b428134ebe36ce","before":"a279d097309aaf15546f8b6846287ffb661fa50d","commits":[{"sha":"c72491aee7cdbc744afd9edf3d6ba94f32419353","author":{"name":"WanLinghao","email":"7c0edcb066d78e845f27e883eaa8e4af59f164ed@cn.fujitsu.com"},"message":"improve serviceaccount projected volume validation error info by providing source index info","distinct":true,"url":"https://api.github.com/repos/ddebroy/kubernetes/commits/c72491aee7cdbc744afd9edf3d6ba94f32419353"},{"sha":"d8a70254106b6f2db9a6f381ff9b3a7d89d761f4","author":{"name":"Koonwah Chen","email":"f5e94bfdd79050d5ca904857466962fd62e77e1b@google.com"},"message":"delete broken test for a deprecated feature.","distinct":true,"url":"https://api.github.com/repos/ddebroy/kubernetes/commits/d8a70254106b6f2db9a6f381ff9b3a7d89d761f4"},{"sha":"7d2f3a048809bbd0de4e571818ab540a643e1482","author":{"name":"Ken'ichi Ohmichi","email":"042467275b8ad813c1a31af724a412901aa80cf8@wx.jp.nec.com"},"message":"HPA: Make dynamicRequestSizeInMillicores bigger\n\nHPA e2e tests specify 20 as requestSizeMillicores on resource-consumer\nfor making CPU workload to test HPA feature, and the value is\nhard-coded as 20. That means the tests expect 2% CPU workload on every\nresource-consumer processes, but actual CPU usage(4 - 6%) is over than\nthe expected usage on some environment. Then HPA scales many pods than\nthe test expected, and the test is failed.\n\nTo make these tests stable, this changes the value to 100 (10% CPU\nworkload on each process).","distinct":true,"url":"https://api.github.com/repos/ddebroy/kubernetes/commits/7d2f3a048809bbd0de4e571818ab540a643e1482"},{"sha":"e5e0de1b9d3ebe0ba4ba78547e2558fe030cd28b","author":{"name":"Wei Huang","email":"65859adc7bda5d75014c0a9618b5dac12189e489@ibm.com"},"message":"fix sorting behavior in selector.go\n\n- move sorting from NewRequirement() out to String()\n- add related unit tests\n- add unit tests in one of outer callers (pkg/apis/core/v1/helper)\n\nCloses #66298","distinct":true,"url":"https://api.github.com/repos/ddebroy/kubernetes/commits/e5e0de1b9d3ebe0ba4ba78547e2558fe030cd28b"},{"sha":"645d36754b1ed5d0bc4b393e55a303fb3541b244","author":{"name":"Koonwah Chen","email":"f5e94bfdd79050d5ca904857466962fd62e77e1b@google.com"},"message":"run ./hack/update-bazel.sh","distinct":true,"url":"https://api.github.com/repos/ddebroy/kubernetes/commits/645d36754b1ed5d0bc4b393e55a303fb3541b244"},{"sha":"d863adedfeddb29ea386a8d4c4ba004604cc06da","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #67042 from cadmuxe/delete_test\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\ndelete broken test for a deprecated feature.\n\n**What this PR does / why we need it**:\r\nThis test is broken and it's for a deprecated feature. \r\nhttps://github.com/kubernetes/contrib/tree/master/service-loadbalancer\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```","distinct":true,"url":"https://api.github.com/repos/ddebroy/kubernetes/commits/d863adedfeddb29ea386a8d4c4ba004604cc06da"},{"sha":"00bf292cdcd3e2d2e26ef0a46e1529e4628d31b6","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #66480 from Huang-Wei/stateless-MatchNodeSelectorTerms\n\nAutomatic merge from submit-queue (batch tested with PRs 67042, 66480, 67053). If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nensure MatchNodeSelectorTerms() runs statelessly\n\n**What this PR does**:\r\n\r\nFix sorting behavior in selector.go:\r\n\r\n- move sorting from NewRequirement() out to String()\r\n- add related unit tests\r\n- add unit tests in one of outer callers (pkg/apis/core/v1/helper)\r\n\r\n**Why we need it**:\r\n- Without this fix, scheduling and daemonset controller doesn't work well in some (corner) cases\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes #66298\r\n\r\n**Special notes for your reviewer**:\r\nParameter `nodeSelectorTerms` in method MatchNodeSelectorTerms() is a slice, which is fundamentally a {*elements, len, cap} tuple - i.e. it's passing in a pointer. In that method, NodeSelectorRequirementsAsSelector() -> NewRequirement() is invoked, and the `matchExpressions[*].values` is passed into and **modified** via `sort.Strings(vals)`.\r\n\r\nThis will cause following daemonset pod fall into an infinite create/delete loop:\r\n\r\n```yaml\r\napiVersion: apps/v1\r\nkind: DaemonSet\r\nmetadata:\r\n  name: problem\r\nspec:\r\n  selector:\r\n    matchLabels:\r\n      app: sleeper\r\n  template:\r\n    metadata:\r\n      labels:\r\n        app: sleeper\r\n    spec:\r\n      affinity:\r\n        nodeAffinity:\r\n          requiredDuringSchedulingIgnoredDuringExecution:\r\n            nodeSelectorTerms:\r\n            - matchExpressions:\r\n              - key: kubernetes.io/hostname\r\n                operator: In\r\n                values:\r\n                - 127.0.0.2\r\n                - 127.0.0.1\r\n      containers:\r\n      - name: busybox\r\n        image: busybox\r\n        command: [\"/bin/sleep\", \"7200\"]\r\n```\r\n\r\n(the problem can be stably reproduced on a local cluster started by `hack/local-up-cluster.sh`)\r\n\r\nThe first time daemonset yaml is handled by apiserver and persisted in etcd with original format (original order of values was kept - 127.0.0.2, 127.0.0.1). After that, daemonset controller tries to schedule pod, and it reuses the predicates logic in scheduler component - where the values are **sorted** deeply. This not only causes the pod to be created in sorted order (127.0.0.1, 127.0.0.2), but also introduced a bug when updating daemonset - internally ds controller use a \"rawMessage\" (bytes of an object) to calculate hash acting as a \"controller-revision-hash\" to control revision rollingUpdate/rollBack, so it keeps killing \"old\" pod and spawning \"new\" pod back and forth, and fall into an infinite loop.\r\n\r\nThe issue exists in `master`, `release-1.11` and `release-1.10`.\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```","distinct":true,"url":"https://api.github.com/repos/ddebroy/kubernetes/commits/00bf292cdcd3e2d2e26ef0a46e1529e4628d31b6"},{"sha":"3ed8b49e9f86a76bfea85bab3f6e3ba8e3115345","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #67053 from oomichi/issue/67051\n\nAutomatic merge from submit-queue (batch tested with PRs 67042, 66480, 67053). If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nHPA: Make dynamicRequestSizeInMillicores bigger\n\n**What this PR does / why we need it**:\r\n\r\nHPA e2e tests specify 20 as requestSizeMillicores on resource-consumer\r\nfor making CPU workload to test HPA feature, and the value is\r\nhard-coded as 20. That means the tests expect 2% CPU workload on every\r\nresource-consumer process, but actual CPU usage(4 - 6%) is over than\r\nthe expected usage on some environment. Then HPA scales many pods than\r\nthe test expected, and the test is failed.\r\n\r\nTo make these tests stable, this changes the value to 100 (10% CPU\r\nworkload on each process).\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #67051\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**: None","distinct":true,"url":"https://api.github.com/repos/ddebroy/kubernetes/commits/3ed8b49e9f86a76bfea85bab3f6e3ba8e3115345"},{"sha":"04ca0d5411e565b6bddf583b60b428134ebe36ce","author":{"name":"Kubernetes Submit Queue","email":"5239ff46b5e3e621e3f6a652ec59210ae096c8ec@users.noreply.github.com"},"message":"Merge pull request #66894 from WanLinghao/token_projected_validation_improve\n\nAutomatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href=\"https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md\">here</a>.\n\nimprove serviceaccount projected volume validation error info\n\n**What this PR does / why we need it**:\r\nFix a small bug here;\r\nWe should use srcPath instead fldPath here like other projection volume do which could give info \r\nabout which source triggered the error.\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nNONE\r\n```","distinct":true,"url":"https://api.github.com/repos/ddebroy/kubernetes/commits/04ca0d5411e565b6bddf583b60b428134ebe36ce"}]}
{"actor":{"display_login":"ddebroy"}}