{"action":"created","comment":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments/205409755","pull_request_review_id":140671248,"id":205409755,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTQwOTc1NQ==","diff_hunk":"@@ -472,6 +512,9 @@ public function rememberCredentials()\n     {\n         // Name and password cookies need to be refreshed each time\n         // Duration = one month for username\n+        \n+        // check if the user trying to login after session expiration is the same user as before\n+        $user_changed = !hash_equals($_COOKIE['pmaUserHashed-' . $GLOBALS['server']], crypt($this->user, \"SillYSAlTstRInG\"));","path":"libraries/classes/Plugins/Auth/AuthenticationCookie.php","position":93,"original_position":93,"commit_id":"a16959071c2c414576b7f33f8636ab23bb7ce618","original_commit_id":"a16959071c2c414576b7f33f8636ab23bb7ce618","user":{"login":"nulll-pointer","id":20344314,"node_id":"MDQ6VXNlcjIwMzQ0MzE0","avatar_url":"https://avatars2.githubusercontent.com/u/20344314?v=4","gravatar_id":"","url":"https://api.github.com/users/nulll-pointer","html_url":"https://github.com/nulll-pointer","followers_url":"https://api.github.com/users/nulll-pointer/followers","following_url":"https://api.github.com/users/nulll-pointer/following{/other_user}","gists_url":"https://api.github.com/users/nulll-pointer/gists{/gist_id}","starred_url":"https://api.github.com/users/nulll-pointer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nulll-pointer/subscriptions","organizations_url":"https://api.github.com/users/nulll-pointer/orgs","repos_url":"https://api.github.com/users/nulll-pointer/repos","events_url":"https://api.github.com/users/nulll-pointer/events{/privacy}","received_events_url":"https://api.github.com/users/nulll-pointer/received_events","type":"User","site_admin":false},"body":"I have an idea, we can use session storage to store the hash of the user, whenever user logs in again, we can validate if the new user is different from the old one their, this way, we don't need an extra cookie. But, this won't work if session storage is not supported.","created_at":"2018-07-26T10:39:14Z","updated_at":"2018-07-26T10:39:14Z","html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/14313#discussion_r205409755","pull_request_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14313","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments/205409755"},"html":{"href":"https://github.com/phpmyadmin/phpmyadmin/pull/14313#discussion_r205409755"},"pull_request":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14313"}},"in_reply_to_id":204226473},"pull_request":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14313","id":189248354,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MjQ4MzU0","html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/14313","diff_url":"https://github.com/phpmyadmin/phpmyadmin/pull/14313.diff","patch_url":"https://github.com/phpmyadmin/phpmyadmin/pull/14313.patch","issue_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/14313","number":14313,"state":"open","locked":false,"title":" Login modal after session expiration","user":{"login":"nulll-pointer","id":20344314,"node_id":"MDQ6VXNlcjIwMzQ0MzE0","avatar_url":"https://avatars2.githubusercontent.com/u/20344314?v=4","gravatar_id":"","url":"https://api.github.com/users/nulll-pointer","html_url":"https://github.com/nulll-pointer","followers_url":"https://api.github.com/users/nulll-pointer/followers","following_url":"https://api.github.com/users/nulll-pointer/following{/other_user}","gists_url":"https://api.github.com/users/nulll-pointer/gists{/gist_id}","starred_url":"https://api.github.com/users/nulll-pointer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nulll-pointer/subscriptions","organizations_url":"https://api.github.com/users/nulll-pointer/orgs","repos_url":"https://api.github.com/users/nulll-pointer/repos","events_url":"https://api.github.com/users/nulll-pointer/events{/privacy}","received_events_url":"https://api.github.com/users/nulll-pointer/received_events","type":"User","site_admin":false},"body":"\r\nBefore submitting pull request, please check that every commit:\r\n\r\n- [ ] Has proper Signed-Off-By\r\n- [ ] Has commit message which describes it\r\n- [ ] Is needed on it's own, if you have just minor fixes to previous commits, you can squash them\r\n- [ ] Any new functionality is covered by tests\r\n","created_at":"2018-05-20T19:23:08Z","updated_at":"2018-07-26T10:39:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"258bcfa96375bbff6eb0f7398d5e7effdbdafc98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14313/commits","review_comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14313/comments","review_comment_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/14313/comments","statuses_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/a16959071c2c414576b7f33f8636ab23bb7ce618","head":{"label":"nulll-pointer:enh_1","ref":"enh_1","sha":"a16959071c2c414576b7f33f8636ab23bb7ce618","user":{"login":"nulll-pointer","id":20344314,"node_id":"MDQ6VXNlcjIwMzQ0MzE0","avatar_url":"https://avatars2.githubusercontent.com/u/20344314?v=4","gravatar_id":"","url":"https://api.github.com/users/nulll-pointer","html_url":"https://github.com/nulll-pointer","followers_url":"https://api.github.com/users/nulll-pointer/followers","following_url":"https://api.github.com/users/nulll-pointer/following{/other_user}","gists_url":"https://api.github.com/users/nulll-pointer/gists{/gist_id}","starred_url":"https://api.github.com/users/nulll-pointer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nulll-pointer/subscriptions","organizations_url":"https://api.github.com/users/nulll-pointer/orgs","repos_url":"https://api.github.com/users/nulll-pointer/repos","events_url":"https://api.github.com/users/nulll-pointer/events{/privacy}","received_events_url":"https://api.github.com/users/nulll-pointer/received_events","type":"User","site_admin":false},"repo":{"id":120941339,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NDEzMzk=","name":"phpmyadmin","full_name":"nulll-pointer/phpmyadmin","owner":{"login":"nulll-pointer","id":20344314,"node_id":"MDQ6VXNlcjIwMzQ0MzE0","avatar_url":"https://avatars2.githubusercontent.com/u/20344314?v=4","gravatar_id":"","url":"https://api.github.com/users/nulll-pointer","html_url":"https://github.com/nulll-pointer","followers_url":"https://api.github.com/users/nulll-pointer/followers","following_url":"https://api.github.com/users/nulll-pointer/following{/other_user}","gists_url":"https://api.github.com/users/nulll-pointer/gists{/gist_id}","starred_url":"https://api.github.com/users/nulll-pointer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nulll-pointer/subscriptions","organizations_url":"https://api.github.com/users/nulll-pointer/orgs","repos_url":"https://api.github.com/users/nulll-pointer/repos","events_url":"https://api.github.com/users/nulll-pointer/events{/privacy}","received_events_url":"https://api.github.com/users/nulll-pointer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nulll-pointer/phpmyadmin","description":"A web interface for MySQL and MariaDB","fork":true,"url":"https://api.github.com/repos/nulll-pointer/phpmyadmin","forks_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/forks","keys_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/teams","hooks_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/hooks","issue_events_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/issues/events{/number}","events_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/events","assignees_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/assignees{/user}","branches_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/branches{/branch}","tags_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/tags","blobs_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/languages","stargazers_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/stargazers","contributors_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/contributors","subscribers_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/subscribers","subscription_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/subscription","commits_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/contents/{+path}","compare_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/merges","archive_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/downloads","issues_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/issues{/number}","pulls_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/labels{/name}","releases_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/releases{/id}","deployments_url":"https://api.github.com/repos/nulll-pointer/phpmyadmin/deployments","created_at":"2018-02-09T18:32:38Z","updated_at":"2018-05-20T20:52:41Z","pushed_at":"2018-07-22T07:51:37Z","git_url":"git://github.com/nulll-pointer/phpmyadmin.git","ssh_url":"git@github.com:nulll-pointer/phpmyadmin.git","clone_url":"https://github.com/nulll-pointer/phpmyadmin.git","svn_url":"https://github.com/nulll-pointer/phpmyadmin","homepage":"https://www.phpmyadmin.net/","size":554944,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpmyadmin:master","ref":"master","sha":"13874a6937e78031741f858fad4eadd769cc3303","user":{"login":"phpmyadmin","id":1351977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTE5Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1351977?v=4","gravatar_id":"","url":"https://api.github.com/users/phpmyadmin","html_url":"https://github.com/phpmyadmin","followers_url":"https://api.github.com/users/phpmyadmin/followers","following_url":"https://api.github.com/users/phpmyadmin/following{/other_user}","gists_url":"https://api.github.com/users/phpmyadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/phpmyadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpmyadmin/subscriptions","organizations_url":"https://api.github.com/users/phpmyadmin/orgs","repos_url":"https://api.github.com/users/phpmyadmin/repos","events_url":"https://api.github.com/users/phpmyadmin/events{/privacy}","received_events_url":"https://api.github.com/users/phpmyadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":3217621,"node_id":"MDEwOlJlcG9zaXRvcnkzMjE3NjIx","name":"phpmyadmin","full_name":"phpmyadmin/phpmyadmin","owner":{"login":"phpmyadmin","id":1351977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTE5Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1351977?v=4","gravatar_id":"","url":"https://api.github.com/users/phpmyadmin","html_url":"https://github.com/phpmyadmin","followers_url":"https://api.github.com/users/phpmyadmin/followers","following_url":"https://api.github.com/users/phpmyadmin/following{/other_user}","gists_url":"https://api.github.com/users/phpmyadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/phpmyadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpmyadmin/subscriptions","organizations_url":"https://api.github.com/users/phpmyadmin/orgs","repos_url":"https://api.github.com/users/phpmyadmin/repos","events_url":"https://api.github.com/users/phpmyadmin/events{/privacy}","received_events_url":"https://api.github.com/users/phpmyadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpmyadmin/phpmyadmin","description":"A web interface for MySQL and MariaDB","fork":false,"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin","forks_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/forks","keys_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/teams","hooks_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/hooks","issue_events_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/events{/number}","events_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/events","assignees_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/assignees{/user}","branches_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/branches{/branch}","tags_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/tags","blobs_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/languages","stargazers_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/stargazers","contributors_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/contributors","subscribers_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/subscribers","subscription_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/subscription","commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/contents/{+path}","compare_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/merges","archive_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/downloads","issues_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues{/number}","pulls_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/labels{/name}","releases_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/releases{/id}","deployments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/deployments","created_at":"2012-01-19T13:21:52Z","updated_at":"2018-07-25T16:12:22Z","pushed_at":"2018-07-25T21:54:05Z","git_url":"git://github.com/phpmyadmin/phpmyadmin.git","ssh_url":"git@github.com:phpmyadmin/phpmyadmin.git","clone_url":"https://github.com/phpmyadmin/phpmyadmin.git","svn_url":"https://github.com/phpmyadmin/phpmyadmin","homepage":"https://www.phpmyadmin.net/","size":556283,"stargazers_count":3216,"watchers_count":3216,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1830,"mirror_url":null,"archived":false,"open_issues_count":460,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1830,"open_issues":460,"watchers":3216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14313"},"html":{"href":"https://github.com/phpmyadmin/phpmyadmin/pull/14313"},"issue":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/14313"},"comments":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/14313/comments"},"review_comments":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14313/comments"},"review_comment":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/14313/commits"},"statuses":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/a16959071c2c414576b7f33f8636ab23bb7ce618"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nulll-pointer"}}