{"action":"created","comment":{"url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/comments/224169503","pull_request_review_id":163467956,"id":224169503,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDE2OTUwMw==","diff_hunk":"@@ -119,15 +119,15 @@ GTCodeGen::IntervalDefinitions::IntervalDefinitions(const iir::Stencil& stencil)\n /// every field is a template argument.\n class StencilFunctionAsBCGenerator : public ASTCodeGenCXX {\n private:\n-  std::shared_ptr<sir::StencilFunction> function;\n-  const std::shared_ptr<iir::StencilInstantiation> instantiation_;\n+   const std::shared_ptr<iir::StencilFunctionInstantiation>& function_;\n+  //  const std::shared_ptr<iir::StencilInstantiation> instantiation_;\n+  const iir::IIR* iir_;","path":"src/dawn/CodeGen/GridTools/GTCodeGen.cpp","position":30,"original_position":30,"commit_id":"36b417fce2f35299bd729b21f5aca6385c25236e","original_commit_id":"36b417fce2f35299bd729b21f5aca6385c25236e","user":{"login":"cosunae","id":6085761,"node_id":"MDQ6VXNlcjYwODU3NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/6085761?v=4","gravatar_id":"","url":"https://api.github.com/users/cosunae","html_url":"https://github.com/cosunae","followers_url":"https://api.github.com/users/cosunae/followers","following_url":"https://api.github.com/users/cosunae/following{/other_user}","gists_url":"https://api.github.com/users/cosunae/gists{/gist_id}","starred_url":"https://api.github.com/users/cosunae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosunae/subscriptions","organizations_url":"https://api.github.com/users/cosunae/orgs","repos_url":"https://api.github.com/users/cosunae/repos","events_url":"https://api.github.com/users/cosunae/events{/privacy}","received_events_url":"https://api.github.com/users/cosunae/received_events","type":"User","site_admin":false},"body":"I think const std::shared_ptr<>& would be better than iir* ? better not getting out of smart ptr into raw ptr ","created_at":"2018-10-10T17:24:48Z","updated_at":"2018-10-10T17:29:12Z","html_url":"https://github.com/MeteoSwiss-APN/dawn/pull/136#discussion_r224169503","pull_request_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/136","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/comments/224169503"},"html":{"href":"https://github.com/MeteoSwiss-APN/dawn/pull/136#discussion_r224169503"},"pull_request":{"href":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/136","id":221693772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjkzNzcy","html_url":"https://github.com/MeteoSwiss-APN/dawn/pull/136","diff_url":"https://github.com/MeteoSwiss-APN/dawn/pull/136.diff","patch_url":"https://github.com/MeteoSwiss-APN/dawn/pull/136.patch","issue_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/issues/136","number":136,"state":"open","locked":false,"title":"Move iir stencilinstantiation","user":{"login":"twicki","id":5988437,"node_id":"MDQ6VXNlcjU5ODg0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5988437?v=4","gravatar_id":"","url":"https://api.github.com/users/twicki","html_url":"https://github.com/twicki","followers_url":"https://api.github.com/users/twicki/followers","following_url":"https://api.github.com/users/twicki/following{/other_user}","gists_url":"https://api.github.com/users/twicki/gists{/gist_id}","starred_url":"https://api.github.com/users/twicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twicki/subscriptions","organizations_url":"https://api.github.com/users/twicki/orgs","repos_url":"https://api.github.com/users/twicki/repos","events_url":"https://api.github.com/users/twicki/events{/privacy}","received_events_url":"https://api.github.com/users/twicki/received_events","type":"User","site_admin":false},"body":"## Do not review yet","created_at":"2018-10-10T08:07:22Z","updated_at":"2018-10-10T17:29:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ba8685ff8f1ef9af7bed3c111a746a5ea1afb41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/136/commits","review_comments_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/136/comments","review_comment_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/issues/136/comments","statuses_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/statuses/36b417fce2f35299bd729b21f5aca6385c25236e","head":{"label":"twicki:move_iir_stencilinstantiation","ref":"move_iir_stencilinstantiation","sha":"36b417fce2f35299bd729b21f5aca6385c25236e","user":{"login":"twicki","id":5988437,"node_id":"MDQ6VXNlcjU5ODg0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5988437?v=4","gravatar_id":"","url":"https://api.github.com/users/twicki","html_url":"https://github.com/twicki","followers_url":"https://api.github.com/users/twicki/followers","following_url":"https://api.github.com/users/twicki/following{/other_user}","gists_url":"https://api.github.com/users/twicki/gists{/gist_id}","starred_url":"https://api.github.com/users/twicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twicki/subscriptions","organizations_url":"https://api.github.com/users/twicki/orgs","repos_url":"https://api.github.com/users/twicki/repos","events_url":"https://api.github.com/users/twicki/events{/privacy}","received_events_url":"https://api.github.com/users/twicki/received_events","type":"User","site_admin":false},"repo":{"id":104907412,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MDc0MTI=","name":"dawn","full_name":"twicki/dawn","private":false,"owner":{"login":"twicki","id":5988437,"node_id":"MDQ6VXNlcjU5ODg0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5988437?v=4","gravatar_id":"","url":"https://api.github.com/users/twicki","html_url":"https://github.com/twicki","followers_url":"https://api.github.com/users/twicki/followers","following_url":"https://api.github.com/users/twicki/following{/other_user}","gists_url":"https://api.github.com/users/twicki/gists{/gist_id}","starred_url":"https://api.github.com/users/twicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twicki/subscriptions","organizations_url":"https://api.github.com/users/twicki/orgs","repos_url":"https://api.github.com/users/twicki/repos","events_url":"https://api.github.com/users/twicki/events{/privacy}","received_events_url":"https://api.github.com/users/twicki/received_events","type":"User","site_admin":false},"html_url":"https://github.com/twicki/dawn","description":"Compiler toolchain to enable generation of high-level DSLs for geophysical fluid dynamics models  ","fork":true,"url":"https://api.github.com/repos/twicki/dawn","forks_url":"https://api.github.com/repos/twicki/dawn/forks","keys_url":"https://api.github.com/repos/twicki/dawn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twicki/dawn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twicki/dawn/teams","hooks_url":"https://api.github.com/repos/twicki/dawn/hooks","issue_events_url":"https://api.github.com/repos/twicki/dawn/issues/events{/number}","events_url":"https://api.github.com/repos/twicki/dawn/events","assignees_url":"https://api.github.com/repos/twicki/dawn/assignees{/user}","branches_url":"https://api.github.com/repos/twicki/dawn/branches{/branch}","tags_url":"https://api.github.com/repos/twicki/dawn/tags","blobs_url":"https://api.github.com/repos/twicki/dawn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twicki/dawn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twicki/dawn/git/refs{/sha}","trees_url":"https://api.github.com/repos/twicki/dawn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twicki/dawn/statuses/{sha}","languages_url":"https://api.github.com/repos/twicki/dawn/languages","stargazers_url":"https://api.github.com/repos/twicki/dawn/stargazers","contributors_url":"https://api.github.com/repos/twicki/dawn/contributors","subscribers_url":"https://api.github.com/repos/twicki/dawn/subscribers","subscription_url":"https://api.github.com/repos/twicki/dawn/subscription","commits_url":"https://api.github.com/repos/twicki/dawn/commits{/sha}","git_commits_url":"https://api.github.com/repos/twicki/dawn/git/commits{/sha}","comments_url":"https://api.github.com/repos/twicki/dawn/comments{/number}","issue_comment_url":"https://api.github.com/repos/twicki/dawn/issues/comments{/number}","contents_url":"https://api.github.com/repos/twicki/dawn/contents/{+path}","compare_url":"https://api.github.com/repos/twicki/dawn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twicki/dawn/merges","archive_url":"https://api.github.com/repos/twicki/dawn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twicki/dawn/downloads","issues_url":"https://api.github.com/repos/twicki/dawn/issues{/number}","pulls_url":"https://api.github.com/repos/twicki/dawn/pulls{/number}","milestones_url":"https://api.github.com/repos/twicki/dawn/milestones{/number}","notifications_url":"https://api.github.com/repos/twicki/dawn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twicki/dawn/labels{/name}","releases_url":"https://api.github.com/repos/twicki/dawn/releases{/id}","deployments_url":"https://api.github.com/repos/twicki/dawn/deployments","created_at":"2017-09-26T16:02:55Z","updated_at":"2018-05-09T09:38:42Z","pushed_at":"2018-10-10T15:05:13Z","git_url":"git://github.com/twicki/dawn.git","ssh_url":"git@github.com:twicki/dawn.git","clone_url":"https://github.com/twicki/dawn.git","svn_url":"https://github.com/twicki/dawn","homepage":null,"size":15479,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MeteoSwiss-APN:master","ref":"master","sha":"e916076569d56c9bbd9cce551c7c172c873c665e","user":{"login":"MeteoSwiss-APN","id":15251199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjUxMTk5","avatar_url":"https://avatars0.githubusercontent.com/u/15251199?v=4","gravatar_id":"","url":"https://api.github.com/users/MeteoSwiss-APN","html_url":"https://github.com/MeteoSwiss-APN","followers_url":"https://api.github.com/users/MeteoSwiss-APN/followers","following_url":"https://api.github.com/users/MeteoSwiss-APN/following{/other_user}","gists_url":"https://api.github.com/users/MeteoSwiss-APN/gists{/gist_id}","starred_url":"https://api.github.com/users/MeteoSwiss-APN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeteoSwiss-APN/subscriptions","organizations_url":"https://api.github.com/users/MeteoSwiss-APN/orgs","repos_url":"https://api.github.com/users/MeteoSwiss-APN/repos","events_url":"https://api.github.com/users/MeteoSwiss-APN/events{/privacy}","received_events_url":"https://api.github.com/users/MeteoSwiss-APN/received_events","type":"Organization","site_admin":false},"repo":{"id":104239379,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQyMzkzNzk=","name":"dawn","full_name":"MeteoSwiss-APN/dawn","private":false,"owner":{"login":"MeteoSwiss-APN","id":15251199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjUxMTk5","avatar_url":"https://avatars0.githubusercontent.com/u/15251199?v=4","gravatar_id":"","url":"https://api.github.com/users/MeteoSwiss-APN","html_url":"https://github.com/MeteoSwiss-APN","followers_url":"https://api.github.com/users/MeteoSwiss-APN/followers","following_url":"https://api.github.com/users/MeteoSwiss-APN/following{/other_user}","gists_url":"https://api.github.com/users/MeteoSwiss-APN/gists{/gist_id}","starred_url":"https://api.github.com/users/MeteoSwiss-APN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeteoSwiss-APN/subscriptions","organizations_url":"https://api.github.com/users/MeteoSwiss-APN/orgs","repos_url":"https://api.github.com/users/MeteoSwiss-APN/repos","events_url":"https://api.github.com/users/MeteoSwiss-APN/events{/privacy}","received_events_url":"https://api.github.com/users/MeteoSwiss-APN/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MeteoSwiss-APN/dawn","description":"Compiler toolchain to enable generation of high-level DSLs for geophysical fluid dynamics models  ","fork":false,"url":"https://api.github.com/repos/MeteoSwiss-APN/dawn","forks_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/forks","keys_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/teams","hooks_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/hooks","issue_events_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/issues/events{/number}","events_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/events","assignees_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/assignees{/user}","branches_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/branches{/branch}","tags_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/tags","blobs_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/git/refs{/sha}","trees_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/statuses/{sha}","languages_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/languages","stargazers_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/stargazers","contributors_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/contributors","subscribers_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/subscribers","subscription_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/subscription","commits_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/commits{/sha}","git_commits_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/git/commits{/sha}","comments_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/comments{/number}","issue_comment_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/issues/comments{/number}","contents_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/contents/{+path}","compare_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/merges","archive_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/downloads","issues_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/issues{/number}","pulls_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls{/number}","milestones_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/milestones{/number}","notifications_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/labels{/name}","releases_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/releases{/id}","deployments_url":"https://api.github.com/repos/MeteoSwiss-APN/dawn/deployments","created_at":"2017-09-20T16:17:56Z","updated_at":"2018-10-10T16:02:03Z","pushed_at":"2018-10-10T16:02:00Z","git_url":"git://github.com/MeteoSwiss-APN/dawn.git","ssh_url":"git@github.com:MeteoSwiss-APN/dawn.git","clone_url":"https://github.com/MeteoSwiss-APN/dawn.git","svn_url":"https://github.com/MeteoSwiss-APN/dawn","homepage":null,"size":21195,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":33,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/136"},"html":{"href":"https://github.com/MeteoSwiss-APN/dawn/pull/136"},"issue":{"href":"https://api.github.com/repos/MeteoSwiss-APN/dawn/issues/136"},"comments":{"href":"https://api.github.com/repos/MeteoSwiss-APN/dawn/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MeteoSwiss-APN/dawn/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/MeteoSwiss-APN/dawn/statuses/36b417fce2f35299bd729b21f5aca6385c25236e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cosunae"}}