{"action":"created","comment":{"url":"https://api.github.com/repos/asticode/go-astisub/pulls/comments/244708205","pull_request_review_id":188642178,"id":244708205,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDcwODIwNQ==","diff_hunk":"@@ -594,14 +600,20 @@ func newSSAStyleFromString(content string, format map[int]string) (s *ssaStyle,\n \t\t\t\ts.scaleX = astiptr.Float(f)\n \t\t\tcase ssaStyleFormatNameScaleY:\n \t\t\t\ts.scaleY = astiptr.Float(f)\n+\t\t\tcase ssaStyleFormatNameOutline:\n+\t\t\t\ts.outline = astiptr.Float(f)\n+\t\t\tcase ssaStyleFormatNameShadow:\n+\t\t\t\ts.shadow = astiptr.Float(f)\n+\t\t\tcase ssaStyleFormatNameSpacing:\n+\t\t\t\ts.spacing = astiptr.Float(f)\n \t\t\t}\n \t\t// Int\n \t\tcase ssaStyleFormatNameAlignment, ssaStyleFormatNameBorderStyle, ssaStyleFormatNameEncoding,\n-\t\t\tssaStyleFormatNameMarginL, ssaStyleFormatNameMarginR, ssaStyleFormatNameMarginV,\n-\t\t\tssaStyleFormatNameOutline, ssaStyleFormatNameShadow, ssaStyleFormatNameSpacing:\n+\t\t\tssaStyleFormatNameMarginL, ssaStyleFormatNameMarginR, ssaStyleFormatNameMarginV:\n \t\t\t// Parse int\n \t\t\tvar i int\n \t\t\tif i, err = strconv.Atoi(item); err != nil {\n+\t\t\t\tfmt.Printf(\"%q\\n\", attr)","path":"ssa.go","position":99,"original_position":99,"commit_id":"ee4838562fcea5adcf38e1e806b35ab1a35a0b1f","original_commit_id":"ee4838562fcea5adcf38e1e806b35ab1a35a0b1f","user":{"login":"Des-Nerger","id":7359990,"node_id":"MDQ6VXNlcjczNTk5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/7359990?v=4","gravatar_id":"","url":"https://api.github.com/users/Des-Nerger","html_url":"https://github.com/Des-Nerger","followers_url":"https://api.github.com/users/Des-Nerger/followers","following_url":"https://api.github.com/users/Des-Nerger/following{/other_user}","gists_url":"https://api.github.com/users/Des-Nerger/gists{/gist_id}","starred_url":"https://api.github.com/users/Des-Nerger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Des-Nerger/subscriptions","organizations_url":"https://api.github.com/users/Des-Nerger/orgs","repos_url":"https://api.github.com/users/Des-Nerger/repos","events_url":"https://api.github.com/users/Des-Nerger/events{/privacy}","received_events_url":"https://api.github.com/users/Des-Nerger/received_events","type":"User","site_admin":false},"body":"Yes. Sorry, I was mean to remove it, but forgot.","created_at":"2019-01-02T10:57:44Z","updated_at":"2019-01-02T10:57:44Z","html_url":"https://github.com/asticode/go-astisub/pull/7#discussion_r244708205","pull_request_url":"https://api.github.com/repos/asticode/go-astisub/pulls/7","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/asticode/go-astisub/pulls/comments/244708205"},"html":{"href":"https://github.com/asticode/go-astisub/pull/7#discussion_r244708205"},"pull_request":{"href":"https://api.github.com/repos/asticode/go-astisub/pulls/7"}},"in_reply_to_id":244685623},"pull_request":{"url":"https://api.github.com/repos/asticode/go-astisub/pulls/7","id":241539597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTM5NTk3","html_url":"https://github.com/asticode/go-astisub/pull/7","diff_url":"https://github.com/asticode/go-astisub/pull/7.diff","patch_url":"https://github.com/asticode/go-astisub/pull/7.patch","issue_url":"https://api.github.com/repos/asticode/go-astisub/issues/7","number":7,"state":"open","locked":false,"title":"Added BOM-handling to SSA.","user":{"login":"Des-Nerger","id":7359990,"node_id":"MDQ6VXNlcjczNTk5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/7359990?v=4","gravatar_id":"","url":"https://api.github.com/users/Des-Nerger","html_url":"https://github.com/Des-Nerger","followers_url":"https://api.github.com/users/Des-Nerger/followers","following_url":"https://api.github.com/users/Des-Nerger/following{/other_user}","gists_url":"https://api.github.com/users/Des-Nerger/gists{/gist_id}","starred_url":"https://api.github.com/users/Des-Nerger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Des-Nerger/subscriptions","organizations_url":"https://api.github.com/users/Des-Nerger/orgs","repos_url":"https://api.github.com/users/Des-Nerger/repos","events_url":"https://api.github.com/users/Des-Nerger/events{/privacy}","received_events_url":"https://api.github.com/users/Des-Nerger/received_events","type":"User","site_admin":false},"body":"When I tried to give astisub an .ass file containing the BOM-header I got the following error:\r\n`astisub: line '<U+FEFF>[Script Info]' should contain at least one ':'`\r\nThis commit fixes the problem.","created_at":"2018-12-31T08:44:40Z","updated_at":"2019-01-02T10:57:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25082f62e5fe43ee4b58cc49fdd83425097dfe71","assignee":{"login":"asticode","id":11619296,"node_id":"MDQ6VXNlcjExNjE5Mjk2","avatar_url":"https://avatars1.githubusercontent.com/u/11619296?v=4","gravatar_id":"","url":"https://api.github.com/users/asticode","html_url":"https://github.com/asticode","followers_url":"https://api.github.com/users/asticode/followers","following_url":"https://api.github.com/users/asticode/following{/other_user}","gists_url":"https://api.github.com/users/asticode/gists{/gist_id}","starred_url":"https://api.github.com/users/asticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asticode/subscriptions","organizations_url":"https://api.github.com/users/asticode/orgs","repos_url":"https://api.github.com/users/asticode/repos","events_url":"https://api.github.com/users/asticode/events{/privacy}","received_events_url":"https://api.github.com/users/asticode/received_events","type":"User","site_admin":false},"assignees":[{"login":"asticode","id":11619296,"node_id":"MDQ6VXNlcjExNjE5Mjk2","avatar_url":"https://avatars1.githubusercontent.com/u/11619296?v=4","gravatar_id":"","url":"https://api.github.com/users/asticode","html_url":"https://github.com/asticode","followers_url":"https://api.github.com/users/asticode/followers","following_url":"https://api.github.com/users/asticode/following{/other_user}","gists_url":"https://api.github.com/users/asticode/gists{/gist_id}","starred_url":"https://api.github.com/users/asticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asticode/subscriptions","organizations_url":"https://api.github.com/users/asticode/orgs","repos_url":"https://api.github.com/users/asticode/repos","events_url":"https://api.github.com/users/asticode/events{/privacy}","received_events_url":"https://api.github.com/users/asticode/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/asticode/go-astisub/pulls/7/commits","review_comments_url":"https://api.github.com/repos/asticode/go-astisub/pulls/7/comments","review_comment_url":"https://api.github.com/repos/asticode/go-astisub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asticode/go-astisub/issues/7/comments","statuses_url":"https://api.github.com/repos/asticode/go-astisub/statuses/ee4838562fcea5adcf38e1e806b35ab1a35a0b1f","head":{"label":"Des-Nerger:master","ref":"master","sha":"ee4838562fcea5adcf38e1e806b35ab1a35a0b1f","user":{"login":"Des-Nerger","id":7359990,"node_id":"MDQ6VXNlcjczNTk5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/7359990?v=4","gravatar_id":"","url":"https://api.github.com/users/Des-Nerger","html_url":"https://github.com/Des-Nerger","followers_url":"https://api.github.com/users/Des-Nerger/followers","following_url":"https://api.github.com/users/Des-Nerger/following{/other_user}","gists_url":"https://api.github.com/users/Des-Nerger/gists{/gist_id}","starred_url":"https://api.github.com/users/Des-Nerger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Des-Nerger/subscriptions","organizations_url":"https://api.github.com/users/Des-Nerger/orgs","repos_url":"https://api.github.com/users/Des-Nerger/repos","events_url":"https://api.github.com/users/Des-Nerger/events{/privacy}","received_events_url":"https://api.github.com/users/Des-Nerger/received_events","type":"User","site_admin":false},"repo":{"id":163645273,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM2NDUyNzM=","name":"go-astisub","full_name":"Des-Nerger/go-astisub","private":false,"owner":{"login":"Des-Nerger","id":7359990,"node_id":"MDQ6VXNlcjczNTk5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/7359990?v=4","gravatar_id":"","url":"https://api.github.com/users/Des-Nerger","html_url":"https://github.com/Des-Nerger","followers_url":"https://api.github.com/users/Des-Nerger/followers","following_url":"https://api.github.com/users/Des-Nerger/following{/other_user}","gists_url":"https://api.github.com/users/Des-Nerger/gists{/gist_id}","starred_url":"https://api.github.com/users/Des-Nerger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Des-Nerger/subscriptions","organizations_url":"https://api.github.com/users/Des-Nerger/orgs","repos_url":"https://api.github.com/users/Des-Nerger/repos","events_url":"https://api.github.com/users/Des-Nerger/events{/privacy}","received_events_url":"https://api.github.com/users/Des-Nerger/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Des-Nerger/go-astisub","description":"Manipulate subtitles in GO (.srt, .ssa/.ass, .stl, .ttml, .vtt (webvtt), teletext, etc.)","fork":true,"url":"https://api.github.com/repos/Des-Nerger/go-astisub","forks_url":"https://api.github.com/repos/Des-Nerger/go-astisub/forks","keys_url":"https://api.github.com/repos/Des-Nerger/go-astisub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Des-Nerger/go-astisub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Des-Nerger/go-astisub/teams","hooks_url":"https://api.github.com/repos/Des-Nerger/go-astisub/hooks","issue_events_url":"https://api.github.com/repos/Des-Nerger/go-astisub/issues/events{/number}","events_url":"https://api.github.com/repos/Des-Nerger/go-astisub/events","assignees_url":"https://api.github.com/repos/Des-Nerger/go-astisub/assignees{/user}","branches_url":"https://api.github.com/repos/Des-Nerger/go-astisub/branches{/branch}","tags_url":"https://api.github.com/repos/Des-Nerger/go-astisub/tags","blobs_url":"https://api.github.com/repos/Des-Nerger/go-astisub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Des-Nerger/go-astisub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Des-Nerger/go-astisub/git/refs{/sha}","trees_url":"https://api.github.com/repos/Des-Nerger/go-astisub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Des-Nerger/go-astisub/statuses/{sha}","languages_url":"https://api.github.com/repos/Des-Nerger/go-astisub/languages","stargazers_url":"https://api.github.com/repos/Des-Nerger/go-astisub/stargazers","contributors_url":"https://api.github.com/repos/Des-Nerger/go-astisub/contributors","subscribers_url":"https://api.github.com/repos/Des-Nerger/go-astisub/subscribers","subscription_url":"https://api.github.com/repos/Des-Nerger/go-astisub/subscription","commits_url":"https://api.github.com/repos/Des-Nerger/go-astisub/commits{/sha}","git_commits_url":"https://api.github.com/repos/Des-Nerger/go-astisub/git/commits{/sha}","comments_url":"https://api.github.com/repos/Des-Nerger/go-astisub/comments{/number}","issue_comment_url":"https://api.github.com/repos/Des-Nerger/go-astisub/issues/comments{/number}","contents_url":"https://api.github.com/repos/Des-Nerger/go-astisub/contents/{+path}","compare_url":"https://api.github.com/repos/Des-Nerger/go-astisub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Des-Nerger/go-astisub/merges","archive_url":"https://api.github.com/repos/Des-Nerger/go-astisub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Des-Nerger/go-astisub/downloads","issues_url":"https://api.github.com/repos/Des-Nerger/go-astisub/issues{/number}","pulls_url":"https://api.github.com/repos/Des-Nerger/go-astisub/pulls{/number}","milestones_url":"https://api.github.com/repos/Des-Nerger/go-astisub/milestones{/number}","notifications_url":"https://api.github.com/repos/Des-Nerger/go-astisub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Des-Nerger/go-astisub/labels{/name}","releases_url":"https://api.github.com/repos/Des-Nerger/go-astisub/releases{/id}","deployments_url":"https://api.github.com/repos/Des-Nerger/go-astisub/deployments","created_at":"2018-12-31T06:30:29Z","updated_at":"2019-01-01T11:18:41Z","pushed_at":"2019-01-01T11:18:39Z","git_url":"git://github.com/Des-Nerger/go-astisub.git","ssh_url":"git@github.com:Des-Nerger/go-astisub.git","clone_url":"https://github.com/Des-Nerger/go-astisub.git","svn_url":"https://github.com/Des-Nerger/go-astisub","homepage":"","size":122,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asticode:master","ref":"master","sha":"146a999907c1a4109762a49dd2f8702cc8b9ed7b","user":{"login":"asticode","id":11619296,"node_id":"MDQ6VXNlcjExNjE5Mjk2","avatar_url":"https://avatars1.githubusercontent.com/u/11619296?v=4","gravatar_id":"","url":"https://api.github.com/users/asticode","html_url":"https://github.com/asticode","followers_url":"https://api.github.com/users/asticode/followers","following_url":"https://api.github.com/users/asticode/following{/other_user}","gists_url":"https://api.github.com/users/asticode/gists{/gist_id}","starred_url":"https://api.github.com/users/asticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asticode/subscriptions","organizations_url":"https://api.github.com/users/asticode/orgs","repos_url":"https://api.github.com/users/asticode/repos","events_url":"https://api.github.com/users/asticode/events{/privacy}","received_events_url":"https://api.github.com/users/asticode/received_events","type":"User","site_admin":false},"repo":{"id":76661194,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY2MTE5NA==","name":"go-astisub","full_name":"asticode/go-astisub","private":false,"owner":{"login":"asticode","id":11619296,"node_id":"MDQ6VXNlcjExNjE5Mjk2","avatar_url":"https://avatars1.githubusercontent.com/u/11619296?v=4","gravatar_id":"","url":"https://api.github.com/users/asticode","html_url":"https://github.com/asticode","followers_url":"https://api.github.com/users/asticode/followers","following_url":"https://api.github.com/users/asticode/following{/other_user}","gists_url":"https://api.github.com/users/asticode/gists{/gist_id}","starred_url":"https://api.github.com/users/asticode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asticode/subscriptions","organizations_url":"https://api.github.com/users/asticode/orgs","repos_url":"https://api.github.com/users/asticode/repos","events_url":"https://api.github.com/users/asticode/events{/privacy}","received_events_url":"https://api.github.com/users/asticode/received_events","type":"User","site_admin":false},"html_url":"https://github.com/asticode/go-astisub","description":"Manipulate subtitles in GO (.srt, .ssa/.ass, .stl, .ttml, .vtt (webvtt), teletext, etc.)","fork":false,"url":"https://api.github.com/repos/asticode/go-astisub","forks_url":"https://api.github.com/repos/asticode/go-astisub/forks","keys_url":"https://api.github.com/repos/asticode/go-astisub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asticode/go-astisub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asticode/go-astisub/teams","hooks_url":"https://api.github.com/repos/asticode/go-astisub/hooks","issue_events_url":"https://api.github.com/repos/asticode/go-astisub/issues/events{/number}","events_url":"https://api.github.com/repos/asticode/go-astisub/events","assignees_url":"https://api.github.com/repos/asticode/go-astisub/assignees{/user}","branches_url":"https://api.github.com/repos/asticode/go-astisub/branches{/branch}","tags_url":"https://api.github.com/repos/asticode/go-astisub/tags","blobs_url":"https://api.github.com/repos/asticode/go-astisub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asticode/go-astisub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asticode/go-astisub/git/refs{/sha}","trees_url":"https://api.github.com/repos/asticode/go-astisub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asticode/go-astisub/statuses/{sha}","languages_url":"https://api.github.com/repos/asticode/go-astisub/languages","stargazers_url":"https://api.github.com/repos/asticode/go-astisub/stargazers","contributors_url":"https://api.github.com/repos/asticode/go-astisub/contributors","subscribers_url":"https://api.github.com/repos/asticode/go-astisub/subscribers","subscription_url":"https://api.github.com/repos/asticode/go-astisub/subscription","commits_url":"https://api.github.com/repos/asticode/go-astisub/commits{/sha}","git_commits_url":"https://api.github.com/repos/asticode/go-astisub/git/commits{/sha}","comments_url":"https://api.github.com/repos/asticode/go-astisub/comments{/number}","issue_comment_url":"https://api.github.com/repos/asticode/go-astisub/issues/comments{/number}","contents_url":"https://api.github.com/repos/asticode/go-astisub/contents/{+path}","compare_url":"https://api.github.com/repos/asticode/go-astisub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asticode/go-astisub/merges","archive_url":"https://api.github.com/repos/asticode/go-astisub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asticode/go-astisub/downloads","issues_url":"https://api.github.com/repos/asticode/go-astisub/issues{/number}","pulls_url":"https://api.github.com/repos/asticode/go-astisub/pulls{/number}","milestones_url":"https://api.github.com/repos/asticode/go-astisub/milestones{/number}","notifications_url":"https://api.github.com/repos/asticode/go-astisub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asticode/go-astisub/labels{/name}","releases_url":"https://api.github.com/repos/asticode/go-astisub/releases{/id}","deployments_url":"https://api.github.com/repos/asticode/go-astisub/deployments","created_at":"2016-12-16T14:47:59Z","updated_at":"2018-12-25T07:52:21Z","pushed_at":"2019-01-01T11:18:40Z","git_url":"git://github.com/asticode/go-astisub.git","ssh_url":"git@github.com:asticode/go-astisub.git","clone_url":"https://github.com/asticode/go-astisub.git","svn_url":"https://github.com/asticode/go-astisub","homepage":"","size":101,"stargazers_count":139,"watchers_count":139,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":1,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asticode/go-astisub/pulls/7"},"html":{"href":"https://github.com/asticode/go-astisub/pull/7"},"issue":{"href":"https://api.github.com/repos/asticode/go-astisub/issues/7"},"comments":{"href":"https://api.github.com/repos/asticode/go-astisub/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/asticode/go-astisub/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/asticode/go-astisub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asticode/go-astisub/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/asticode/go-astisub/statuses/ee4838562fcea5adcf38e1e806b35ab1a35a0b1f"}},"author_association":"NONE"}}
{"actor":{"display_login":"Des-Nerger"}}