{"action":"created","comment":{"url":"https://api.github.com/repos/angular/protractor/pulls/comments/233320641","pull_request_review_id":174705125,"id":233320641,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzMyMDY0MQ==","diff_hunk":"@@ -193,24 +193,18 @@ export class ProtractorBrowser extends AbstractExtendedWebDriver {\n    * this method is called use the new app root. Pass nothing to get a promise that\n    * resolves to the value of the selector.\n    *\n-   * @param {string|webdriver.promise.Promise<string>} value The new selector.\n+   * @param {string|webdriver.promise.Promise<string>} valuePromise The new selector.\n    * @returns A promise that resolves with the value of the selector.\n    */\n-  angularAppRoot(value: string|wdpromise.Promise<string> = null): wdpromise.Promise<string> {\n-    return this.driver.controlFlow().execute(() => {\n-      if (value != null) {\n-        return wdpromise.when(value).then((value: string) => {\n-          this.internalRootEl = value;\n-          if (this.bpClient) {\n-            const bpCommandPromise = this.bpClient.setWaitParams(value);\n-            // Convert to webdriver promise as best as possible\n-            return wdpromise.when(bpCommandPromise as any).then(() => this.internalRootEl);\n-          }\n-          return this.internalRootEl;\n-        });\n+  async angularAppRoot(valuePromise: string|wdpromise.Promise<string> = null): Promise<string> {\n+    if (valuePromise != null) {\n+      const value = await Promise.resolve(valuePromise);","path":"lib/browser.ts","position":22,"original_position":22,"commit_id":"052b5919b4dc3a0256202ffa8eecba4715980409","original_commit_id":"052b5919b4dc3a0256202ffa8eecba4715980409","user":{"login":"heathkit","id":9543,"node_id":"MDQ6VXNlcjk1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/9543?v=4","gravatar_id":"","url":"https://api.github.com/users/heathkit","html_url":"https://github.com/heathkit","followers_url":"https://api.github.com/users/heathkit/followers","following_url":"https://api.github.com/users/heathkit/following{/other_user}","gists_url":"https://api.github.com/users/heathkit/gists{/gist_id}","starred_url":"https://api.github.com/users/heathkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heathkit/subscriptions","organizations_url":"https://api.github.com/users/heathkit/orgs","repos_url":"https://api.github.com/users/heathkit/repos","events_url":"https://api.github.com/users/heathkit/events{/privacy}","received_events_url":"https://api.github.com/users/heathkit/received_events","type":"User","site_admin":false},"body":"You don't need the Promise.resolve. You can just `await valuePromise`. If It's not a promise, await will just return the string.","created_at":"2018-11-14T05:47:43Z","updated_at":"2018-11-14T05:58:33Z","html_url":"https://github.com/angular/protractor/pull/5034#discussion_r233320641","pull_request_url":"https://api.github.com/repos/angular/protractor/pulls/5034","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/protractor/pulls/comments/233320641"},"html":{"href":"https://github.com/angular/protractor/pull/5034#discussion_r233320641"},"pull_request":{"href":"https://api.github.com/repos/angular/protractor/pulls/5034"}}},"pull_request":{"url":"https://api.github.com/repos/angular/protractor/pulls/5034","id":230300346,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzAwMzQ2","html_url":"https://github.com/angular/protractor/pull/5034","diff_url":"https://github.com/angular/protractor/pull/5034.diff","patch_url":"https://github.com/angular/protractor/pull/5034.patch","issue_url":"https://api.github.com/repos/angular/protractor/issues/5034","number":5034,"state":"open","locked":false,"title":"chore(driverProviders): clean up driver provider q usage","user":{"login":"cnishina","id":1559007,"node_id":"MDQ6VXNlcjE1NTkwMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1559007?v=4","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"body":"- Remove driverProviderUseExistingWebDriver since the generation of the selenium server is already accomplished when providing a selenium address in driverProvider.ts. Also clean up docs and tests.\r\n- Use native promises over q promises.","created_at":"2018-11-12T23:27:19Z","updated_at":"2018-11-14T05:58:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a76174a3c5e9f76a4e44be59967b31553544c44d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"juliemr","id":2081709,"node_id":"MDQ6VXNlcjIwODE3MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2081709?v=4","gravatar_id":"","url":"https://api.github.com/users/juliemr","html_url":"https://github.com/juliemr","followers_url":"https://api.github.com/users/juliemr/followers","following_url":"https://api.github.com/users/juliemr/following{/other_user}","gists_url":"https://api.github.com/users/juliemr/gists{/gist_id}","starred_url":"https://api.github.com/users/juliemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliemr/subscriptions","organizations_url":"https://api.github.com/users/juliemr/orgs","repos_url":"https://api.github.com/users/juliemr/repos","events_url":"https://api.github.com/users/juliemr/events{/privacy}","received_events_url":"https://api.github.com/users/juliemr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":70978687,"node_id":"MDU6TGFiZWw3MDk3ODY4Nw==","url":"https://api.github.com/repos/angular/protractor/labels/cla:%20yes","name":"cla: yes","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/protractor/pulls/5034/commits","review_comments_url":"https://api.github.com/repos/angular/protractor/pulls/5034/comments","review_comment_url":"https://api.github.com/repos/angular/protractor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/protractor/issues/5034/comments","statuses_url":"https://api.github.com/repos/angular/protractor/statuses/052b5919b4dc3a0256202ffa8eecba4715980409","head":{"label":"cnishina:driverProviderUseExisting","ref":"driverProviderUseExisting","sha":"052b5919b4dc3a0256202ffa8eecba4715980409","user":{"login":"cnishina","id":1559007,"node_id":"MDQ6VXNlcjE1NTkwMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1559007?v=4","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"repo":{"id":49972885,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3Mjg4NQ==","name":"protractor","full_name":"cnishina/protractor","private":false,"owner":{"login":"cnishina","id":1559007,"node_id":"MDQ6VXNlcjE1NTkwMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1559007?v=4","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cnishina/protractor","description":"E2E test framework for Angular apps","fork":true,"url":"https://api.github.com/repos/cnishina/protractor","forks_url":"https://api.github.com/repos/cnishina/protractor/forks","keys_url":"https://api.github.com/repos/cnishina/protractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cnishina/protractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cnishina/protractor/teams","hooks_url":"https://api.github.com/repos/cnishina/protractor/hooks","issue_events_url":"https://api.github.com/repos/cnishina/protractor/issues/events{/number}","events_url":"https://api.github.com/repos/cnishina/protractor/events","assignees_url":"https://api.github.com/repos/cnishina/protractor/assignees{/user}","branches_url":"https://api.github.com/repos/cnishina/protractor/branches{/branch}","tags_url":"https://api.github.com/repos/cnishina/protractor/tags","blobs_url":"https://api.github.com/repos/cnishina/protractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cnishina/protractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cnishina/protractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/cnishina/protractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cnishina/protractor/statuses/{sha}","languages_url":"https://api.github.com/repos/cnishina/protractor/languages","stargazers_url":"https://api.github.com/repos/cnishina/protractor/stargazers","contributors_url":"https://api.github.com/repos/cnishina/protractor/contributors","subscribers_url":"https://api.github.com/repos/cnishina/protractor/subscribers","subscription_url":"https://api.github.com/repos/cnishina/protractor/subscription","commits_url":"https://api.github.com/repos/cnishina/protractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/cnishina/protractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/cnishina/protractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/cnishina/protractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/cnishina/protractor/contents/{+path}","compare_url":"https://api.github.com/repos/cnishina/protractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cnishina/protractor/merges","archive_url":"https://api.github.com/repos/cnishina/protractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cnishina/protractor/downloads","issues_url":"https://api.github.com/repos/cnishina/protractor/issues{/number}","pulls_url":"https://api.github.com/repos/cnishina/protractor/pulls{/number}","milestones_url":"https://api.github.com/repos/cnishina/protractor/milestones{/number}","notifications_url":"https://api.github.com/repos/cnishina/protractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cnishina/protractor/labels{/name}","releases_url":"https://api.github.com/repos/cnishina/protractor/releases{/id}","deployments_url":"https://api.github.com/repos/cnishina/protractor/deployments","created_at":"2016-01-19T18:15:59Z","updated_at":"2018-11-05T17:28:45Z","pushed_at":"2018-11-14T01:35:03Z","git_url":"git://github.com/cnishina/protractor.git","ssh_url":"git@github.com:cnishina/protractor.git","clone_url":"https://github.com/cnishina/protractor.git","svn_url":"https://github.com/cnishina/protractor","homepage":"http://www.protractortest.org","size":8274,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"angular:selenium4","ref":"selenium4","sha":"02b3cb95d69fcf344a27da8a125db2a01ca073c1","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":7639232,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM5MjMy","name":"protractor","full_name":"angular/protractor","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/protractor","description":"E2E test framework for Angular apps","fork":false,"url":"https://api.github.com/repos/angular/protractor","forks_url":"https://api.github.com/repos/angular/protractor/forks","keys_url":"https://api.github.com/repos/angular/protractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/protractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/protractor/teams","hooks_url":"https://api.github.com/repos/angular/protractor/hooks","issue_events_url":"https://api.github.com/repos/angular/protractor/issues/events{/number}","events_url":"https://api.github.com/repos/angular/protractor/events","assignees_url":"https://api.github.com/repos/angular/protractor/assignees{/user}","branches_url":"https://api.github.com/repos/angular/protractor/branches{/branch}","tags_url":"https://api.github.com/repos/angular/protractor/tags","blobs_url":"https://api.github.com/repos/angular/protractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/protractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/protractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/protractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/protractor/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/protractor/languages","stargazers_url":"https://api.github.com/repos/angular/protractor/stargazers","contributors_url":"https://api.github.com/repos/angular/protractor/contributors","subscribers_url":"https://api.github.com/repos/angular/protractor/subscribers","subscription_url":"https://api.github.com/repos/angular/protractor/subscription","commits_url":"https://api.github.com/repos/angular/protractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/protractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/protractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/protractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/protractor/contents/{+path}","compare_url":"https://api.github.com/repos/angular/protractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/protractor/merges","archive_url":"https://api.github.com/repos/angular/protractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/protractor/downloads","issues_url":"https://api.github.com/repos/angular/protractor/issues{/number}","pulls_url":"https://api.github.com/repos/angular/protractor/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/protractor/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/protractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/protractor/labels{/name}","releases_url":"https://api.github.com/repos/angular/protractor/releases{/id}","deployments_url":"https://api.github.com/repos/angular/protractor/deployments","created_at":"2013-01-16T04:30:53Z","updated_at":"2018-11-14T05:06:18Z","pushed_at":"2018-11-14T01:35:05Z","git_url":"git://github.com/angular/protractor.git","ssh_url":"git@github.com:angular/protractor.git","clone_url":"https://github.com/angular/protractor.git","svn_url":"https://github.com/angular/protractor","homepage":"http://www.protractortest.org","size":8951,"stargazers_count":7887,"watchers_count":7887,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2095,"mirror_url":null,"archived":false,"open_issues_count":442,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2095,"open_issues":442,"watchers":7887,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/protractor/pulls/5034"},"html":{"href":"https://github.com/angular/protractor/pull/5034"},"issue":{"href":"https://api.github.com/repos/angular/protractor/issues/5034"},"comments":{"href":"https://api.github.com/repos/angular/protractor/issues/5034/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/protractor/pulls/5034/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/protractor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/protractor/pulls/5034/commits"},"statuses":{"href":"https://api.github.com/repos/angular/protractor/statuses/052b5919b4dc3a0256202ffa8eecba4715980409"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"heathkit"}}