{"action":"created","comment":{"url":"https://api.github.com/repos/iodide-project/iodide/pulls/comments/222964842","pull_request_review_id":161980963,"id":222964842,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjk2NDg0Mg==","diff_hunk":"@@ -0,0 +1,9 @@\n+import { addChangeLanguageTask } from './actions/task-definitions'\n+\n+export default function handleLanguageDefinitions(store) {\n+  const state = store.getState();\n+  const { languageDefinitions } = state;\n+  for (const language of Object.values(languageDefinitions)) {\n+    addChangeLanguageTask(language.languageId, language.displayName, language.keybinding);","path":"src/handle-language-definitions.js","position":7,"original_position":7,"commit_id":"280d48232893e8042e23ce2beeec25db6f83cee6","original_commit_id":"3be994bb66b8da4b554774e9f7c476f148319092","user":{"login":"mdboom","id":38294,"node_id":"MDQ6VXNlcjM4Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/38294?v=4","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"body":"I think this is fixed now.","created_at":"2018-10-05T10:46:19Z","updated_at":"2018-10-05T10:46:19Z","html_url":"https://github.com/iodide-project/iodide/pull/1014#discussion_r222964842","pull_request_url":"https://api.github.com/repos/iodide-project/iodide/pulls/1014","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iodide-project/iodide/pulls/comments/222964842"},"html":{"href":"https://github.com/iodide-project/iodide/pull/1014#discussion_r222964842"},"pull_request":{"href":"https://api.github.com/repos/iodide-project/iodide/pulls/1014"}},"in_reply_to_id":222859713},"pull_request":{"url":"https://api.github.com/repos/iodide-project/iodide/pulls/1014","id":220534556,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNTM0NTU2","html_url":"https://github.com/iodide-project/iodide/pull/1014","diff_url":"https://github.com/iodide-project/iodide/pull/1014.diff","patch_url":"https://github.com/iodide-project/iodide/pull/1014.patch","issue_url":"https://api.github.com/repos/iodide-project/iodide/issues/1014","number":1014,"state":"open","locked":false,"title":"Fix #1011: Seamlessly load language plugins","user":{"login":"mdboom","id":38294,"node_id":"MDQ6VXNlcjM4Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/38294?v=4","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"body":"The idea here is:\r\n\r\nThere's a set of \"known\" language plugins that exist in the store (`languageDefinitions`).  At sometime in the future, we might fetch these from a \"directory\" of plugins online somewhere, but for now it's semi-hardcoded.  These get tasks and cell menu items automatically.\r\n\r\nWhen you evaluate a code cell, it checks if the given language is already loaded (in `loadedLanguages`).  If not, it does the whole async dance just like the language plugin cell, and then evaluates the cell.\r\n\r\nThe language plugin cell should continue to work for non-\"known\" language plugins.","created_at":"2018-10-04T22:19:52Z","updated_at":"2018-10-05T10:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efecb4eaeef7fe93217a16cf5f8b5255f579ca70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iodide-project/iodide/pulls/1014/commits","review_comments_url":"https://api.github.com/repos/iodide-project/iodide/pulls/1014/comments","review_comment_url":"https://api.github.com/repos/iodide-project/iodide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iodide-project/iodide/issues/1014/comments","statuses_url":"https://api.github.com/repos/iodide-project/iodide/statuses/280d48232893e8042e23ce2beeec25db6f83cee6","head":{"label":"mdboom:seamless-python","ref":"seamless-python","sha":"280d48232893e8042e23ce2beeec25db6f83cee6","user":{"login":"mdboom","id":38294,"node_id":"MDQ6VXNlcjM4Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/38294?v=4","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"repo":{"id":121528398,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1MjgzOTg=","name":"iodide","full_name":"mdboom/iodide","private":false,"owner":{"login":"mdboom","id":38294,"node_id":"MDQ6VXNlcjM4Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/38294?v=4","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mdboom/iodide","description":"A notebook-style interface for literate scientific computing in javascript.","fork":true,"url":"https://api.github.com/repos/mdboom/iodide","forks_url":"https://api.github.com/repos/mdboom/iodide/forks","keys_url":"https://api.github.com/repos/mdboom/iodide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdboom/iodide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdboom/iodide/teams","hooks_url":"https://api.github.com/repos/mdboom/iodide/hooks","issue_events_url":"https://api.github.com/repos/mdboom/iodide/issues/events{/number}","events_url":"https://api.github.com/repos/mdboom/iodide/events","assignees_url":"https://api.github.com/repos/mdboom/iodide/assignees{/user}","branches_url":"https://api.github.com/repos/mdboom/iodide/branches{/branch}","tags_url":"https://api.github.com/repos/mdboom/iodide/tags","blobs_url":"https://api.github.com/repos/mdboom/iodide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdboom/iodide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdboom/iodide/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdboom/iodide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdboom/iodide/statuses/{sha}","languages_url":"https://api.github.com/repos/mdboom/iodide/languages","stargazers_url":"https://api.github.com/repos/mdboom/iodide/stargazers","contributors_url":"https://api.github.com/repos/mdboom/iodide/contributors","subscribers_url":"https://api.github.com/repos/mdboom/iodide/subscribers","subscription_url":"https://api.github.com/repos/mdboom/iodide/subscription","commits_url":"https://api.github.com/repos/mdboom/iodide/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdboom/iodide/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdboom/iodide/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdboom/iodide/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdboom/iodide/contents/{+path}","compare_url":"https://api.github.com/repos/mdboom/iodide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdboom/iodide/merges","archive_url":"https://api.github.com/repos/mdboom/iodide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdboom/iodide/downloads","issues_url":"https://api.github.com/repos/mdboom/iodide/issues{/number}","pulls_url":"https://api.github.com/repos/mdboom/iodide/pulls{/number}","milestones_url":"https://api.github.com/repos/mdboom/iodide/milestones{/number}","notifications_url":"https://api.github.com/repos/mdboom/iodide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdboom/iodide/labels{/name}","releases_url":"https://api.github.com/repos/mdboom/iodide/releases{/id}","deployments_url":"https://api.github.com/repos/mdboom/iodide/deployments","created_at":"2018-02-14T15:44:42Z","updated_at":"2018-09-18T22:34:55Z","pushed_at":"2018-10-05T10:46:10Z","git_url":"git://github.com/mdboom/iodide.git","ssh_url":"git@github.com:mdboom/iodide.git","clone_url":"https://github.com/mdboom/iodide.git","svn_url":"https://github.com/mdboom/iodide","homepage":null,"size":18174,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iodide-project:master","ref":"master","sha":"b822ad7c157aa4db68e2b2dcb4b77cb1e0d65d3f","user":{"login":"iodide-project","id":36210752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjEwNzUy","avatar_url":"https://avatars0.githubusercontent.com/u/36210752?v=4","gravatar_id":"","url":"https://api.github.com/users/iodide-project","html_url":"https://github.com/iodide-project","followers_url":"https://api.github.com/users/iodide-project/followers","following_url":"https://api.github.com/users/iodide-project/following{/other_user}","gists_url":"https://api.github.com/users/iodide-project/gists{/gist_id}","starred_url":"https://api.github.com/users/iodide-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iodide-project/subscriptions","organizations_url":"https://api.github.com/users/iodide-project/orgs","repos_url":"https://api.github.com/users/iodide-project/repos","events_url":"https://api.github.com/users/iodide-project/events{/privacy}","received_events_url":"https://api.github.com/users/iodide-project/received_events","type":"Organization","site_admin":false},"repo":{"id":99938998,"node_id":"MDEwOlJlcG9zaXRvcnk5OTkzODk5OA==","name":"iodide","full_name":"iodide-project/iodide","private":false,"owner":{"login":"iodide-project","id":36210752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjEwNzUy","avatar_url":"https://avatars0.githubusercontent.com/u/36210752?v=4","gravatar_id":"","url":"https://api.github.com/users/iodide-project","html_url":"https://github.com/iodide-project","followers_url":"https://api.github.com/users/iodide-project/followers","following_url":"https://api.github.com/users/iodide-project/following{/other_user}","gists_url":"https://api.github.com/users/iodide-project/gists{/gist_id}","starred_url":"https://api.github.com/users/iodide-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iodide-project/subscriptions","organizations_url":"https://api.github.com/users/iodide-project/orgs","repos_url":"https://api.github.com/users/iodide-project/repos","events_url":"https://api.github.com/users/iodide-project/events{/privacy}","received_events_url":"https://api.github.com/users/iodide-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iodide-project/iodide","description":"A frictionlessly portable interface for literate scientific computing in the browser","fork":false,"url":"https://api.github.com/repos/iodide-project/iodide","forks_url":"https://api.github.com/repos/iodide-project/iodide/forks","keys_url":"https://api.github.com/repos/iodide-project/iodide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iodide-project/iodide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iodide-project/iodide/teams","hooks_url":"https://api.github.com/repos/iodide-project/iodide/hooks","issue_events_url":"https://api.github.com/repos/iodide-project/iodide/issues/events{/number}","events_url":"https://api.github.com/repos/iodide-project/iodide/events","assignees_url":"https://api.github.com/repos/iodide-project/iodide/assignees{/user}","branches_url":"https://api.github.com/repos/iodide-project/iodide/branches{/branch}","tags_url":"https://api.github.com/repos/iodide-project/iodide/tags","blobs_url":"https://api.github.com/repos/iodide-project/iodide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iodide-project/iodide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iodide-project/iodide/git/refs{/sha}","trees_url":"https://api.github.com/repos/iodide-project/iodide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iodide-project/iodide/statuses/{sha}","languages_url":"https://api.github.com/repos/iodide-project/iodide/languages","stargazers_url":"https://api.github.com/repos/iodide-project/iodide/stargazers","contributors_url":"https://api.github.com/repos/iodide-project/iodide/contributors","subscribers_url":"https://api.github.com/repos/iodide-project/iodide/subscribers","subscription_url":"https://api.github.com/repos/iodide-project/iodide/subscription","commits_url":"https://api.github.com/repos/iodide-project/iodide/commits{/sha}","git_commits_url":"https://api.github.com/repos/iodide-project/iodide/git/commits{/sha}","comments_url":"https://api.github.com/repos/iodide-project/iodide/comments{/number}","issue_comment_url":"https://api.github.com/repos/iodide-project/iodide/issues/comments{/number}","contents_url":"https://api.github.com/repos/iodide-project/iodide/contents/{+path}","compare_url":"https://api.github.com/repos/iodide-project/iodide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iodide-project/iodide/merges","archive_url":"https://api.github.com/repos/iodide-project/iodide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iodide-project/iodide/downloads","issues_url":"https://api.github.com/repos/iodide-project/iodide/issues{/number}","pulls_url":"https://api.github.com/repos/iodide-project/iodide/pulls{/number}","milestones_url":"https://api.github.com/repos/iodide-project/iodide/milestones{/number}","notifications_url":"https://api.github.com/repos/iodide-project/iodide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iodide-project/iodide/labels{/name}","releases_url":"https://api.github.com/repos/iodide-project/iodide/releases{/id}","deployments_url":"https://api.github.com/repos/iodide-project/iodide/deployments","created_at":"2017-08-10T15:38:35Z","updated_at":"2018-10-05T06:49:09Z","pushed_at":"2018-10-05T10:46:12Z","git_url":"git://github.com/iodide-project/iodide.git","ssh_url":"git@github.com:iodide-project/iodide.git","clone_url":"https://github.com/iodide-project/iodide.git","svn_url":"https://github.com/iodide-project/iodide","homepage":"","size":18475,"stargazers_count":249,"watchers_count":249,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":43,"open_issues":135,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iodide-project/iodide/pulls/1014"},"html":{"href":"https://github.com/iodide-project/iodide/pull/1014"},"issue":{"href":"https://api.github.com/repos/iodide-project/iodide/issues/1014"},"comments":{"href":"https://api.github.com/repos/iodide-project/iodide/issues/1014/comments"},"review_comments":{"href":"https://api.github.com/repos/iodide-project/iodide/pulls/1014/comments"},"review_comment":{"href":"https://api.github.com/repos/iodide-project/iodide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iodide-project/iodide/pulls/1014/commits"},"statuses":{"href":"https://api.github.com/repos/iodide-project/iodide/statuses/280d48232893e8042e23ce2beeec25db6f83cee6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mdboom"}}