{"action":"created","issue":{"url":"https://api.github.com/repos/videojs/video.js/issues/5702","repository_url":"https://api.github.com/repos/videojs/video.js","labels_url":"https://api.github.com/repos/videojs/video.js/issues/5702/labels{/name}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/5702/comments","events_url":"https://api.github.com/repos/videojs/video.js/issues/5702/events","html_url":"https://github.com/videojs/video.js/pull/5702","id":392856412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMDMwNzA4","number":5702,"title":"fix: remove child from old parent when moving to new parent via addChild","user":{"login":"dustin71728","id":13027159,"node_id":"MDQ6VXNlcjEzMDI3MTU5","avatar_url":"https://avatars3.githubusercontent.com/u/13027159?v=4","gravatar_id":"","url":"https://api.github.com/users/dustin71728","html_url":"https://github.com/dustin71728","followers_url":"https://api.github.com/users/dustin71728/followers","following_url":"https://api.github.com/users/dustin71728/following{/other_user}","gists_url":"https://api.github.com/users/dustin71728/gists{/gist_id}","starred_url":"https://api.github.com/users/dustin71728/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustin71728/subscriptions","organizations_url":"https://api.github.com/users/dustin71728/orgs","repos_url":"https://api.github.com/users/dustin71728/repos","events_url":"https://api.github.com/users/dustin71728/events{/privacy}","received_events_url":"https://api.github.com/users/dustin71728/received_events","type":"User","site_admin":false},"labels":[{"id":289859212,"node_id":"MDU6TGFiZWwyODk4NTkyMTI=","url":"https://api.github.com/repos/videojs/video.js/labels/needs:%20LGTM","name":"needs: LGTM","color":"207de5","default":false},{"id":289859133,"node_id":"MDU6TGFiZWwyODk4NTkxMzM=","url":"https://api.github.com/repos/videojs/video.js/labels/patch","name":"patch","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/videojs/video.js/milestones/16","html_url":"https://github.com/videojs/video.js/milestone/16","labels_url":"https://api.github.com/repos/videojs/video.js/milestones/16/labels","id":3940030,"node_id":"MDk6TWlsZXN0b25lMzk0MDAzMA==","number":16,"title":"7.4.x","description":"","creator":{"login":"gkatsev","id":535884,"node_id":"MDQ6VXNlcjUzNTg4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/535884?v=4","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2019-01-03T20:19:22Z","updated_at":"2019-01-03T22:32:14Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-12-20T02:06:18Z","updated_at":"2019-01-04T05:36:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/5702","html_url":"https://github.com/videojs/video.js/pull/5702","diff_url":"https://github.com/videojs/video.js/pull/5702.diff","patch_url":"https://github.com/videojs/video.js/pull/5702.patch"},"body":"## Description\r\nA child component may have been assigned to another\r\nparent before assigning that child component to the\r\nnew parent via \"addChild\" method. In this case, the\r\noriginal parent should remove the child then it can\r\nbe safely added back to the new parent. This commit\r\nwill keep the parent's \"children_\" and its DOM\r\nelement's child nodes in the consistent state.\r\n\r\n## Specific Changes proposed\r\nRemove the specific child component from the old parent component before adding the child component to the new parent\r\n\r\n## Requirements Checklist\r\n- [x] Feature implemented / Bug fixed\r\n- [ ] If necessary, more likely in a feature request than a bug fix\r\n  - [x] Change has been verified in an actual browser (Chome, Firefox, IE)\r\n  - [ ] Unit Tests updated or fixed\r\n  - [ ] Docs/guides updated\r\n  - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))\r\n- [ ] Reviewed by Two Core Contributors\r\n"},"comment":{"url":"https://api.github.com/repos/videojs/video.js/issues/comments/451357318","html_url":"https://github.com/videojs/video.js/pull/5702#issuecomment-451357318","issue_url":"https://api.github.com/repos/videojs/video.js/issues/5702","id":451357318,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTM1NzMxOA==","user":{"login":"dustin71728","id":13027159,"node_id":"MDQ6VXNlcjEzMDI3MTU5","avatar_url":"https://avatars3.githubusercontent.com/u/13027159?v=4","gravatar_id":"","url":"https://api.github.com/users/dustin71728","html_url":"https://github.com/dustin71728","followers_url":"https://api.github.com/users/dustin71728/followers","following_url":"https://api.github.com/users/dustin71728/following{/other_user}","gists_url":"https://api.github.com/users/dustin71728/gists{/gist_id}","starred_url":"https://api.github.com/users/dustin71728/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustin71728/subscriptions","organizations_url":"https://api.github.com/users/dustin71728/orgs","repos_url":"https://api.github.com/users/dustin71728/repos","events_url":"https://api.github.com/users/dustin71728/events{/privacy}","received_events_url":"https://api.github.com/users/dustin71728/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T05:36:50Z","updated_at":"2019-01-04T05:36:50Z","author_association":"NONE","body":"It is my pleasure. :smile:"}}
{"actor":{"display_login":"dustin71728"}}