{"action":"created","comment":{"url":"https://api.github.com/repos/gluster/glusterd2/pulls/comments/210806277","pull_request_review_id":147099799,"id":210806277,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDgwNjI3Nw==","diff_hunk":"@@ -218,6 +219,9 @@ var volumeDeleteCmd = &cobra.Command{\n \tArgs:  cobra.ExactArgs(1),\n \tRun: func(cmd *cobra.Command, args []string) {\n \t\tvolname := cmd.Flags().Args()[0]\n+\t\tif ok := prompt.Confirm(\"Are you sure you want to delete volume %s [yes/no]\", volname); !ok {","path":"glustercli/cmd/volume.go","position":12,"original_position":12,"commit_id":"9421109504745c0a95b6aa731d17a6aeacc3b843","original_commit_id":"9421109504745c0a95b6aa731d17a6aeacc3b843","user":{"login":"Madhu-1","id":18114231,"node_id":"MDQ6VXNlcjE4MTE0MjMx","avatar_url":"https://avatars2.githubusercontent.com/u/18114231?v=4","gravatar_id":"","url":"https://api.github.com/users/Madhu-1","html_url":"https://github.com/Madhu-1","followers_url":"https://api.github.com/users/Madhu-1/followers","following_url":"https://api.github.com/users/Madhu-1/following{/other_user}","gists_url":"https://api.github.com/users/Madhu-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhu-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhu-1/subscriptions","organizations_url":"https://api.github.com/users/Madhu-1/orgs","repos_url":"https://api.github.com/users/Madhu-1/repos","events_url":"https://api.github.com/users/Madhu-1/events{/privacy}","received_events_url":"https://api.github.com/users/Madhu-1/received_events","type":"User","site_admin":false},"body":"question: why can't we implement this functionality in glusterd2 instead of importing external package for this?","created_at":"2018-08-17T05:14:49Z","updated_at":"2018-08-17T05:14:50Z","html_url":"https://github.com/gluster/glusterd2/pull/1181#discussion_r210806277","pull_request_url":"https://api.github.com/repos/gluster/glusterd2/pulls/1181","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/comments/210806277"},"html":{"href":"https://github.com/gluster/glusterd2/pull/1181#discussion_r210806277"},"pull_request":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1181"}}},"pull_request":{"url":"https://api.github.com/repos/gluster/glusterd2/pulls/1181","id":208890940,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4ODkwOTQw","html_url":"https://github.com/gluster/glusterd2/pull/1181","diff_url":"https://github.com/gluster/glusterd2/pull/1181.diff","patch_url":"https://github.com/gluster/glusterd2/pull/1181.patch","issue_url":"https://api.github.com/repos/gluster/glusterd2/issues/1181","number":1181,"state":"open","locked":false,"title":"cli: warning prompt yes/no before volume deletion","user":{"login":"oshankkumar","id":16084968,"node_id":"MDQ6VXNlcjE2MDg0OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/16084968?v=4","gravatar_id":"","url":"https://api.github.com/users/oshankkumar","html_url":"https://github.com/oshankkumar","followers_url":"https://api.github.com/users/oshankkumar/followers","following_url":"https://api.github.com/users/oshankkumar/following{/other_user}","gists_url":"https://api.github.com/users/oshankkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/oshankkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshankkumar/subscriptions","organizations_url":"https://api.github.com/users/oshankkumar/orgs","repos_url":"https://api.github.com/users/oshankkumar/repos","events_url":"https://api.github.com/users/oshankkumar/events{/privacy}","received_events_url":"https://api.github.com/users/oshankkumar/received_events","type":"User","site_admin":false},"body":"closes: #1163\r\n\r\nSigned-off-by: Oshank Kumar <okumar@redhat.com>","created_at":"2018-08-16T15:05:02Z","updated_at":"2018-08-17T05:14:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c2f7d0b3e84640db014a7b8ac0cb900eff91ee2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gluster/glusterd2/pulls/1181/commits","review_comments_url":"https://api.github.com/repos/gluster/glusterd2/pulls/1181/comments","review_comment_url":"https://api.github.com/repos/gluster/glusterd2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluster/glusterd2/issues/1181/comments","statuses_url":"https://api.github.com/repos/gluster/glusterd2/statuses/9421109504745c0a95b6aa731d17a6aeacc3b843","head":{"label":"oshankkumar:volumeDelete-prompt","ref":"volumeDelete-prompt","sha":"9421109504745c0a95b6aa731d17a6aeacc3b843","user":{"login":"oshankkumar","id":16084968,"node_id":"MDQ6VXNlcjE2MDg0OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/16084968?v=4","gravatar_id":"","url":"https://api.github.com/users/oshankkumar","html_url":"https://github.com/oshankkumar","followers_url":"https://api.github.com/users/oshankkumar/followers","following_url":"https://api.github.com/users/oshankkumar/following{/other_user}","gists_url":"https://api.github.com/users/oshankkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/oshankkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshankkumar/subscriptions","organizations_url":"https://api.github.com/users/oshankkumar/orgs","repos_url":"https://api.github.com/users/oshankkumar/repos","events_url":"https://api.github.com/users/oshankkumar/events{/privacy}","received_events_url":"https://api.github.com/users/oshankkumar/received_events","type":"User","site_admin":false},"repo":{"id":142281882,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyODE4ODI=","name":"glusterd2","full_name":"oshankkumar/glusterd2","owner":{"login":"oshankkumar","id":16084968,"node_id":"MDQ6VXNlcjE2MDg0OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/16084968?v=4","gravatar_id":"","url":"https://api.github.com/users/oshankkumar","html_url":"https://github.com/oshankkumar","followers_url":"https://api.github.com/users/oshankkumar/followers","following_url":"https://api.github.com/users/oshankkumar/following{/other_user}","gists_url":"https://api.github.com/users/oshankkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/oshankkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshankkumar/subscriptions","organizations_url":"https://api.github.com/users/oshankkumar/orgs","repos_url":"https://api.github.com/users/oshankkumar/repos","events_url":"https://api.github.com/users/oshankkumar/events{/privacy}","received_events_url":"https://api.github.com/users/oshankkumar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oshankkumar/glusterd2","description":"GlusterD-2.0 is the distributed management framework to be used for GlusterFS-4.0","fork":true,"url":"https://api.github.com/repos/oshankkumar/glusterd2","forks_url":"https://api.github.com/repos/oshankkumar/glusterd2/forks","keys_url":"https://api.github.com/repos/oshankkumar/glusterd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oshankkumar/glusterd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oshankkumar/glusterd2/teams","hooks_url":"https://api.github.com/repos/oshankkumar/glusterd2/hooks","issue_events_url":"https://api.github.com/repos/oshankkumar/glusterd2/issues/events{/number}","events_url":"https://api.github.com/repos/oshankkumar/glusterd2/events","assignees_url":"https://api.github.com/repos/oshankkumar/glusterd2/assignees{/user}","branches_url":"https://api.github.com/repos/oshankkumar/glusterd2/branches{/branch}","tags_url":"https://api.github.com/repos/oshankkumar/glusterd2/tags","blobs_url":"https://api.github.com/repos/oshankkumar/glusterd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oshankkumar/glusterd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oshankkumar/glusterd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/oshankkumar/glusterd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oshankkumar/glusterd2/statuses/{sha}","languages_url":"https://api.github.com/repos/oshankkumar/glusterd2/languages","stargazers_url":"https://api.github.com/repos/oshankkumar/glusterd2/stargazers","contributors_url":"https://api.github.com/repos/oshankkumar/glusterd2/contributors","subscribers_url":"https://api.github.com/repos/oshankkumar/glusterd2/subscribers","subscription_url":"https://api.github.com/repos/oshankkumar/glusterd2/subscription","commits_url":"https://api.github.com/repos/oshankkumar/glusterd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/oshankkumar/glusterd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/oshankkumar/glusterd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/oshankkumar/glusterd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/oshankkumar/glusterd2/contents/{+path}","compare_url":"https://api.github.com/repos/oshankkumar/glusterd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oshankkumar/glusterd2/merges","archive_url":"https://api.github.com/repos/oshankkumar/glusterd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oshankkumar/glusterd2/downloads","issues_url":"https://api.github.com/repos/oshankkumar/glusterd2/issues{/number}","pulls_url":"https://api.github.com/repos/oshankkumar/glusterd2/pulls{/number}","milestones_url":"https://api.github.com/repos/oshankkumar/glusterd2/milestones{/number}","notifications_url":"https://api.github.com/repos/oshankkumar/glusterd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oshankkumar/glusterd2/labels{/name}","releases_url":"https://api.github.com/repos/oshankkumar/glusterd2/releases{/id}","deployments_url":"https://api.github.com/repos/oshankkumar/glusterd2/deployments","created_at":"2018-07-25T10:00:04Z","updated_at":"2018-08-16T14:18:59Z","pushed_at":"2018-08-16T15:18:24Z","git_url":"git://github.com/oshankkumar/glusterd2.git","ssh_url":"git@github.com:oshankkumar/glusterd2.git","clone_url":"https://github.com/oshankkumar/glusterd2.git","svn_url":"https://github.com/oshankkumar/glusterd2","homepage":"","size":12875,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gluster:master","ref":"master","sha":"94d9434b14cfe944ea8c1b6a033121ebd332aef6","user":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"repo":{"id":24369600,"node_id":"MDEwOlJlcG9zaXRvcnkyNDM2OTYwMA==","name":"glusterd2","full_name":"gluster/glusterd2","owner":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gluster/glusterd2","description":"GlusterD-2.0 is the distributed management framework to be used for GlusterFS-4.0","fork":false,"url":"https://api.github.com/repos/gluster/glusterd2","forks_url":"https://api.github.com/repos/gluster/glusterd2/forks","keys_url":"https://api.github.com/repos/gluster/glusterd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluster/glusterd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluster/glusterd2/teams","hooks_url":"https://api.github.com/repos/gluster/glusterd2/hooks","issue_events_url":"https://api.github.com/repos/gluster/glusterd2/issues/events{/number}","events_url":"https://api.github.com/repos/gluster/glusterd2/events","assignees_url":"https://api.github.com/repos/gluster/glusterd2/assignees{/user}","branches_url":"https://api.github.com/repos/gluster/glusterd2/branches{/branch}","tags_url":"https://api.github.com/repos/gluster/glusterd2/tags","blobs_url":"https://api.github.com/repos/gluster/glusterd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluster/glusterd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluster/glusterd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluster/glusterd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluster/glusterd2/statuses/{sha}","languages_url":"https://api.github.com/repos/gluster/glusterd2/languages","stargazers_url":"https://api.github.com/repos/gluster/glusterd2/stargazers","contributors_url":"https://api.github.com/repos/gluster/glusterd2/contributors","subscribers_url":"https://api.github.com/repos/gluster/glusterd2/subscribers","subscription_url":"https://api.github.com/repos/gluster/glusterd2/subscription","commits_url":"https://api.github.com/repos/gluster/glusterd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluster/glusterd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluster/glusterd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluster/glusterd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluster/glusterd2/contents/{+path}","compare_url":"https://api.github.com/repos/gluster/glusterd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluster/glusterd2/merges","archive_url":"https://api.github.com/repos/gluster/glusterd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluster/glusterd2/downloads","issues_url":"https://api.github.com/repos/gluster/glusterd2/issues{/number}","pulls_url":"https://api.github.com/repos/gluster/glusterd2/pulls{/number}","milestones_url":"https://api.github.com/repos/gluster/glusterd2/milestones{/number}","notifications_url":"https://api.github.com/repos/gluster/glusterd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluster/glusterd2/labels{/name}","releases_url":"https://api.github.com/repos/gluster/glusterd2/releases{/id}","deployments_url":"https://api.github.com/repos/gluster/glusterd2/deployments","created_at":"2014-09-23T12:02:13Z","updated_at":"2018-08-16T10:19:21Z","pushed_at":"2018-08-16T15:18:25Z","git_url":"git://github.com/gluster/glusterd2.git","ssh_url":"git@github.com:gluster/glusterd2.git","clone_url":"https://github.com/gluster/glusterd2.git","svn_url":"https://github.com/gluster/glusterd2","homepage":"","size":12897,"stargazers_count":103,"watchers_count":103,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":65,"open_issues":246,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1181"},"html":{"href":"https://github.com/gluster/glusterd2/pull/1181"},"issue":{"href":"https://api.github.com/repos/gluster/glusterd2/issues/1181"},"comments":{"href":"https://api.github.com/repos/gluster/glusterd2/issues/1181/comments"},"review_comments":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1181/comments"},"review_comment":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1181/commits"},"statuses":{"href":"https://api.github.com/repos/gluster/glusterd2/statuses/9421109504745c0a95b6aa731d17a6aeacc3b843"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Madhu-1"}}