{"action":"created","issue":{"url":"https://api.github.com/repos/aio-libs/aiomysql/issues/309","repository_url":"https://api.github.com/repos/aio-libs/aiomysql","labels_url":"https://api.github.com/repos/aio-libs/aiomysql/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/aio-libs/aiomysql/issues/309/comments","events_url":"https://api.github.com/repos/aio-libs/aiomysql/issues/309/events","html_url":"https://github.com/aio-libs/aiomysql/pull/309","id":338362905,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MzE0NjU5","number":309,"title":"PyMySQL 0.9 Update","user":{"login":"terrycain","id":1986397,"node_id":"MDQ6VXNlcjE5ODYzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1986397?v=4","gravatar_id":"","url":"https://api.github.com/users/terrycain","html_url":"https://github.com/terrycain","followers_url":"https://api.github.com/users/terrycain/followers","following_url":"https://api.github.com/users/terrycain/following{/other_user}","gists_url":"https://api.github.com/users/terrycain/gists{/gist_id}","starred_url":"https://api.github.com/users/terrycain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrycain/subscriptions","organizations_url":"https://api.github.com/users/terrycain/orgs","repos_url":"https://api.github.com/users/terrycain/repos","events_url":"https://api.github.com/users/terrycain/events{/privacy}","received_events_url":"https://api.github.com/users/terrycain/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-07-04T19:37:02Z","updated_at":"2018-07-07T12:45:46Z","closed_at":"2018-07-07T12:45:25Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/aio-libs/aiomysql/pulls/309","html_url":"https://github.com/aio-libs/aiomysql/pull/309","diff_url":"https://github.com/aio-libs/aiomysql/pull/309.diff","patch_url":"https://github.com/aio-libs/aiomysql/pull/309.patch"},"body":"Fixes #303 #302 \r\n\r\nSo this was a weird one. I'm assuming PyMySQL changed some flag somewhere but it was refusing to connect unless we provided some client connection arguments.  I just mimic'd how PyMySQL does it, so when connecting it will send across pid, program name, library name etc...\r\n\r\nAlso fixed the obvious moving of password functions. Am going to add support for authentication_plugins `caching_sha2_password` and `sha256_password` after this PR is merged as those require PyMySQL methods to be rewritten async-style.\r\n\r\nPyMySQL has also changed the default charset so that pwn'd a few tests so have updated the checks which should do for now.\r\n\r\nOnly this thats annoying me is getting the version in connection.py as one cant import __init__.py, simple answer would be to use bumpversion and that'll replace the version numbers :), else another option would be to be real hacky and read the __init__.py file upon load and extract the version :D\r\n\r\n@jettify this look ok?"},"comment":{"url":"https://api.github.com/repos/aio-libs/aiomysql/issues/comments/403213374","html_url":"https://github.com/aio-libs/aiomysql/pull/309#issuecomment-403213374","issue_url":"https://api.github.com/repos/aio-libs/aiomysql/issues/309","id":403213374,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzIxMzM3NA==","user":{"login":"terrycain","id":1986397,"node_id":"MDQ6VXNlcjE5ODYzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1986397?v=4","gravatar_id":"","url":"https://api.github.com/users/terrycain","html_url":"https://github.com/terrycain","followers_url":"https://api.github.com/users/terrycain/followers","following_url":"https://api.github.com/users/terrycain/following{/other_user}","gists_url":"https://api.github.com/users/terrycain/gists{/gist_id}","starred_url":"https://api.github.com/users/terrycain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrycain/subscriptions","organizations_url":"https://api.github.com/users/terrycain/orgs","repos_url":"https://api.github.com/users/terrycain/repos","events_url":"https://api.github.com/users/terrycain/events{/privacy}","received_events_url":"https://api.github.com/users/terrycain/received_events","type":"User","site_admin":false},"created_at":"2018-07-07T12:45:46Z","updated_at":"2018-07-07T12:45:46Z","author_association":"COLLABORATOR","body":"I'll queue up PR for MySQL8+ Support in the next day or so."}}
{"actor":{"display_login":"terrycain"}}