{"action":"created","comment":{"url":"https://api.github.com/repos/jjaniec/21sh/pulls/comments/227122200","pull_request_review_id":167089829,"id":227122200,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzEyMjIwMA==","diff_hunk":"@@ -0,0 +1,52 @@\n+/* ************************************************************************** */\n+/*                                                                            */\n+/*                                                        :::      ::::::::   */\n+/*   ht_hash.c                                          :+:      :+:    :+:   */\n+/*                                                    +:+ +:+         +:+     */\n+/*   By: cgaspart <cgaspart@student.42.fr>          +#+  +:+       +#+        */\n+/*                                                +#+#+#+#+#+   +#+           */\n+/*   Created: 2018/10/11 17:24:39 by cgaspart          #+#    #+#             */\n+/*   Updated: 2018/10/21 16:55:35 by cgaspart         ###   ########.fr       */\n+/*                                                                            */\n+/* ************************************************************************** */\n+\n+#include <forty_two_sh.h>\n+\n+int\t\tht_hash(t_hashtable *hashtable, char *key)\n+{\n+\tunsigned long int\thashval;\n+\tint\t\t\t\t\ti;\n+\n+\thashval = 0;\n+\ti = 0;\n+\twhile (hashval < ULONG_MAX && i < (int)ft_strlen(key))","path":"srcs/hash_table/ht_hash.c","position":22,"original_position":22,"commit_id":"61bba3542f3763326afb9350d9483781741bd491","original_commit_id":"61bba3542f3763326afb9350d9483781741bd491","user":{"login":"sonarcloud[bot]","id":39514782,"node_id":"MDM6Qm90Mzk1MTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/in/12526?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarcloud%5Bbot%5D","html_url":"https://github.com/apps/sonarcloud","followers_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/followers","following_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/repos","events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"![Bug](https://sonarsource.github.io/sonar-github/bug.png 'Bug') Bug: Change this condition so that it does not always evaluate to \"false\"; some subsequent code is never executed. ([c:S2583](https://sonarcloud.io/organizations/jjaniec-github/rules#rule_key=c%3AS2583))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=jjaniec_21sh&pullRequest=45&issues=AWadZlzsdPPRVdwyRhJN&open=AWadZlzsdPPRVdwyRhJN)\n\n[ISSUE_KEY]: AWadZlzsdPPRVdwyRhJN","created_at":"2018-10-22T20:16:05Z","updated_at":"2018-10-22T20:16:06Z","html_url":"https://github.com/jjaniec/21sh/pull/45#discussion_r227122200","pull_request_url":"https://api.github.com/repos/jjaniec/21sh/pulls/45","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/comments/227122200"},"html":{"href":"https://github.com/jjaniec/21sh/pull/45#discussion_r227122200"},"pull_request":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/jjaniec/21sh/pulls/45","id":224730349,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzMwMzQ5","html_url":"https://github.com/jjaniec/21sh/pull/45","diff_url":"https://github.com/jjaniec/21sh/pull/45.diff","patch_url":"https://github.com/jjaniec/21sh/pull/45.patch","issue_url":"https://api.github.com/repos/jjaniec/21sh/issues/45","number":45,"state":"open","locked":false,"title":"Hash table","user":{"login":"cgaspart","id":33488209,"node_id":"MDQ6VXNlcjMzNDg4MjA5","avatar_url":"https://avatars2.githubusercontent.com/u/33488209?v=4","gravatar_id":"","url":"https://api.github.com/users/cgaspart","html_url":"https://github.com/cgaspart","followers_url":"https://api.github.com/users/cgaspart/followers","following_url":"https://api.github.com/users/cgaspart/following{/other_user}","gists_url":"https://api.github.com/users/cgaspart/gists{/gist_id}","starred_url":"https://api.github.com/users/cgaspart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgaspart/subscriptions","organizations_url":"https://api.github.com/users/cgaspart/orgs","repos_url":"https://api.github.com/users/cgaspart/repos","events_url":"https://api.github.com/users/cgaspart/events{/privacy}","received_events_url":"https://api.github.com/users/cgaspart/received_events","type":"User","site_admin":false},"body":"Implementation de la table de hash.\r\n\r\n- syntax_highlighting with hash_table: OK\r\n- exec with hash_table: OK\r\n\r\nCas d'update:\r\n- La variable PATH à été modifié dans l'env\r\n- Un des PATH à été modifié\r\n\r\nNorme and leaks should be ok :)\r\nMerci de tester si tout est ok pour vous 👍 \r\n\r\nPeace ☮️ \r\n","created_at":"2018-10-22T16:06:55Z","updated_at":"2018-10-22T20:16:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3268ba4d407d9204948b4660b99c00cd992aba3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},{"login":"Gamouche","id":22396445,"node_id":"MDQ6VXNlcjIyMzk2NDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/22396445?v=4","gravatar_id":"","url":"https://api.github.com/users/Gamouche","html_url":"https://github.com/Gamouche","followers_url":"https://api.github.com/users/Gamouche/followers","following_url":"https://api.github.com/users/Gamouche/following{/other_user}","gists_url":"https://api.github.com/users/Gamouche/gists{/gist_id}","starred_url":"https://api.github.com/users/Gamouche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gamouche/subscriptions","organizations_url":"https://api.github.com/users/Gamouche/orgs","repos_url":"https://api.github.com/users/Gamouche/repos","events_url":"https://api.github.com/users/Gamouche/events{/privacy}","received_events_url":"https://api.github.com/users/Gamouche/received_events","type":"User","site_admin":false},{"login":"SebastienBruckert","id":25817270,"node_id":"MDQ6VXNlcjI1ODE3Mjcw","avatar_url":"https://avatars2.githubusercontent.com/u/25817270?v=4","gravatar_id":"","url":"https://api.github.com/users/SebastienBruckert","html_url":"https://github.com/SebastienBruckert","followers_url":"https://api.github.com/users/SebastienBruckert/followers","following_url":"https://api.github.com/users/SebastienBruckert/following{/other_user}","gists_url":"https://api.github.com/users/SebastienBruckert/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastienBruckert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastienBruckert/subscriptions","organizations_url":"https://api.github.com/users/SebastienBruckert/orgs","repos_url":"https://api.github.com/users/SebastienBruckert/repos","events_url":"https://api.github.com/users/SebastienBruckert/events{/privacy}","received_events_url":"https://api.github.com/users/SebastienBruckert/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":934078151,"node_id":"MDU6TGFiZWw5MzQwNzgxNTE=","url":"https://api.github.com/repos/jjaniec/21sh/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/jjaniec/21sh/pulls/45/commits","review_comments_url":"https://api.github.com/repos/jjaniec/21sh/pulls/45/comments","review_comment_url":"https://api.github.com/repos/jjaniec/21sh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jjaniec/21sh/issues/45/comments","statuses_url":"https://api.github.com/repos/jjaniec/21sh/statuses/61bba3542f3763326afb9350d9483781741bd491","head":{"label":"jjaniec:hash_table","ref":"hash_table","sha":"61bba3542f3763326afb9350d9483781741bd491","user":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"repo":{"id":133548605,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NDg2MDU=","name":"21sh","full_name":"jjaniec/21sh","private":false,"owner":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jjaniec/21sh","description":"Our own shell - wip","fork":false,"url":"https://api.github.com/repos/jjaniec/21sh","forks_url":"https://api.github.com/repos/jjaniec/21sh/forks","keys_url":"https://api.github.com/repos/jjaniec/21sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjaniec/21sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjaniec/21sh/teams","hooks_url":"https://api.github.com/repos/jjaniec/21sh/hooks","issue_events_url":"https://api.github.com/repos/jjaniec/21sh/issues/events{/number}","events_url":"https://api.github.com/repos/jjaniec/21sh/events","assignees_url":"https://api.github.com/repos/jjaniec/21sh/assignees{/user}","branches_url":"https://api.github.com/repos/jjaniec/21sh/branches{/branch}","tags_url":"https://api.github.com/repos/jjaniec/21sh/tags","blobs_url":"https://api.github.com/repos/jjaniec/21sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjaniec/21sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjaniec/21sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjaniec/21sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjaniec/21sh/statuses/{sha}","languages_url":"https://api.github.com/repos/jjaniec/21sh/languages","stargazers_url":"https://api.github.com/repos/jjaniec/21sh/stargazers","contributors_url":"https://api.github.com/repos/jjaniec/21sh/contributors","subscribers_url":"https://api.github.com/repos/jjaniec/21sh/subscribers","subscription_url":"https://api.github.com/repos/jjaniec/21sh/subscription","commits_url":"https://api.github.com/repos/jjaniec/21sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjaniec/21sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjaniec/21sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjaniec/21sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjaniec/21sh/contents/{+path}","compare_url":"https://api.github.com/repos/jjaniec/21sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjaniec/21sh/merges","archive_url":"https://api.github.com/repos/jjaniec/21sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjaniec/21sh/downloads","issues_url":"https://api.github.com/repos/jjaniec/21sh/issues{/number}","pulls_url":"https://api.github.com/repos/jjaniec/21sh/pulls{/number}","milestones_url":"https://api.github.com/repos/jjaniec/21sh/milestones{/number}","notifications_url":"https://api.github.com/repos/jjaniec/21sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjaniec/21sh/labels{/name}","releases_url":"https://api.github.com/repos/jjaniec/21sh/releases{/id}","deployments_url":"https://api.github.com/repos/jjaniec/21sh/deployments","created_at":"2018-05-15T17:10:47Z","updated_at":"2018-10-21T15:44:00Z","pushed_at":"2018-10-22T17:41:29Z","git_url":"git://github.com/jjaniec/21sh.git","ssh_url":"git@github.com:jjaniec/21sh.git","clone_url":"https://github.com/jjaniec/21sh.git","svn_url":"https://github.com/jjaniec/21sh","homepage":"","size":2940,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":3,"default_branch":"develop"}},"base":{"label":"jjaniec:develop","ref":"develop","sha":"96beaac67acb9b79f6d66b3dc3e16de255b14e4d","user":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"repo":{"id":133548605,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NDg2MDU=","name":"21sh","full_name":"jjaniec/21sh","private":false,"owner":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jjaniec/21sh","description":"Our own shell - wip","fork":false,"url":"https://api.github.com/repos/jjaniec/21sh","forks_url":"https://api.github.com/repos/jjaniec/21sh/forks","keys_url":"https://api.github.com/repos/jjaniec/21sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjaniec/21sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjaniec/21sh/teams","hooks_url":"https://api.github.com/repos/jjaniec/21sh/hooks","issue_events_url":"https://api.github.com/repos/jjaniec/21sh/issues/events{/number}","events_url":"https://api.github.com/repos/jjaniec/21sh/events","assignees_url":"https://api.github.com/repos/jjaniec/21sh/assignees{/user}","branches_url":"https://api.github.com/repos/jjaniec/21sh/branches{/branch}","tags_url":"https://api.github.com/repos/jjaniec/21sh/tags","blobs_url":"https://api.github.com/repos/jjaniec/21sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjaniec/21sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjaniec/21sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjaniec/21sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjaniec/21sh/statuses/{sha}","languages_url":"https://api.github.com/repos/jjaniec/21sh/languages","stargazers_url":"https://api.github.com/repos/jjaniec/21sh/stargazers","contributors_url":"https://api.github.com/repos/jjaniec/21sh/contributors","subscribers_url":"https://api.github.com/repos/jjaniec/21sh/subscribers","subscription_url":"https://api.github.com/repos/jjaniec/21sh/subscription","commits_url":"https://api.github.com/repos/jjaniec/21sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjaniec/21sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjaniec/21sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjaniec/21sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjaniec/21sh/contents/{+path}","compare_url":"https://api.github.com/repos/jjaniec/21sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjaniec/21sh/merges","archive_url":"https://api.github.com/repos/jjaniec/21sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjaniec/21sh/downloads","issues_url":"https://api.github.com/repos/jjaniec/21sh/issues{/number}","pulls_url":"https://api.github.com/repos/jjaniec/21sh/pulls{/number}","milestones_url":"https://api.github.com/repos/jjaniec/21sh/milestones{/number}","notifications_url":"https://api.github.com/repos/jjaniec/21sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjaniec/21sh/labels{/name}","releases_url":"https://api.github.com/repos/jjaniec/21sh/releases{/id}","deployments_url":"https://api.github.com/repos/jjaniec/21sh/deployments","created_at":"2018-05-15T17:10:47Z","updated_at":"2018-10-21T15:44:00Z","pushed_at":"2018-10-22T17:41:29Z","git_url":"git://github.com/jjaniec/21sh.git","ssh_url":"git@github.com:jjaniec/21sh.git","clone_url":"https://github.com/jjaniec/21sh.git","svn_url":"https://github.com/jjaniec/21sh","homepage":"","size":2940,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/45"},"html":{"href":"https://github.com/jjaniec/21sh/pull/45"},"issue":{"href":"https://api.github.com/repos/jjaniec/21sh/issues/45"},"comments":{"href":"https://api.github.com/repos/jjaniec/21sh/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/jjaniec/21sh/statuses/61bba3542f3763326afb9350d9483781741bd491"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sonarcloud"}}