{"action":"created","comment":{"url":"https://api.github.com/repos/apple/foundationdb/pulls/comments/202195143","pull_request_review_id":136848673,"id":202195143,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjE5NTE0Mw==","diff_hunk":"@@ -28,19 +28,19 @@\n \n #include \"FDBLibTLSPlugin.h\"\n #include \"FDBLibTLSVerify.h\"\n+#include \"Trace.h\"","path":"FDBLibTLS/FDBLibTLSPolicy.h","position":4,"original_position":4,"commit_id":"6e4265fcc72b1978e6cbb4f621a76a43cf1b1f5c","original_commit_id":"6e4265fcc72b1978e6cbb4f621a76a43cf1b1f5c","user":{"login":"alexmiller-apple","id":35046903,"node_id":"MDQ6VXNlcjM1MDQ2OTAz","avatar_url":"https://avatars2.githubusercontent.com/u/35046903?v=4","gravatar_id":"","url":"https://api.github.com/users/alexmiller-apple","html_url":"https://github.com/alexmiller-apple","followers_url":"https://api.github.com/users/alexmiller-apple/followers","following_url":"https://api.github.com/users/alexmiller-apple/following{/other_user}","gists_url":"https://api.github.com/users/alexmiller-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmiller-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmiller-apple/subscriptions","organizations_url":"https://api.github.com/users/alexmiller-apple/orgs","repos_url":"https://api.github.com/users/alexmiller-apple/repos","events_url":"https://api.github.com/users/alexmiller-apple/events{/privacy}","received_events_url":"https://api.github.com/users/alexmiller-apple/received_events","type":"User","site_admin":false},"body":"This should be #included in the .cpp files.","created_at":"2018-07-12T22:12:53Z","updated_at":"2018-07-12T22:16:26Z","html_url":"https://github.com/apple/foundationdb/pull/593#discussion_r202195143","pull_request_url":"https://api.github.com/repos/apple/foundationdb/pulls/593","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/comments/202195143"},"html":{"href":"https://github.com/apple/foundationdb/pull/593#discussion_r202195143"},"pull_request":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/593"}}},"pull_request":{"url":"https://api.github.com/repos/apple/foundationdb/pulls/593","id":200870711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODcwNzEx","html_url":"https://github.com/apple/foundationdb/pull/593","diff_url":"https://github.com/apple/foundationdb/pull/593.diff","patch_url":"https://github.com/apple/foundationdb/pull/593.patch","issue_url":"https://api.github.com/repos/apple/foundationdb/issues/593","number":593,"state":"open","locked":false,"title":"Replaced separate TLS Log function with FDB TraceEvent logger","user":{"login":"AlvinMooreSr","id":36203359,"node_id":"MDQ6VXNlcjM2MjAzMzU5","avatar_url":"https://avatars2.githubusercontent.com/u/36203359?v=4","gravatar_id":"","url":"https://api.github.com/users/AlvinMooreSr","html_url":"https://github.com/AlvinMooreSr","followers_url":"https://api.github.com/users/AlvinMooreSr/followers","following_url":"https://api.github.com/users/AlvinMooreSr/following{/other_user}","gists_url":"https://api.github.com/users/AlvinMooreSr/gists{/gist_id}","starred_url":"https://api.github.com/users/AlvinMooreSr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlvinMooreSr/subscriptions","organizations_url":"https://api.github.com/users/AlvinMooreSr/orgs","repos_url":"https://api.github.com/users/AlvinMooreSr/repos","events_url":"https://api.github.com/users/AlvinMooreSr/events{/privacy}","received_events_url":"https://api.github.com/users/AlvinMooreSr/received_events","type":"User","site_admin":false},"body":"Resolves Issue #433 ","created_at":"2018-07-12T02:10:56Z","updated_at":"2018-07-12T22:16:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44c5403ac5915341d2d94ba780a2f38fdde57313","assignee":{"login":"alexmiller-apple","id":35046903,"node_id":"MDQ6VXNlcjM1MDQ2OTAz","avatar_url":"https://avatars2.githubusercontent.com/u/35046903?v=4","gravatar_id":"","url":"https://api.github.com/users/alexmiller-apple","html_url":"https://github.com/alexmiller-apple","followers_url":"https://api.github.com/users/alexmiller-apple/followers","following_url":"https://api.github.com/users/alexmiller-apple/following{/other_user}","gists_url":"https://api.github.com/users/alexmiller-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmiller-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmiller-apple/subscriptions","organizations_url":"https://api.github.com/users/alexmiller-apple/orgs","repos_url":"https://api.github.com/users/alexmiller-apple/repos","events_url":"https://api.github.com/users/alexmiller-apple/events{/privacy}","received_events_url":"https://api.github.com/users/alexmiller-apple/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexmiller-apple","id":35046903,"node_id":"MDQ6VXNlcjM1MDQ2OTAz","avatar_url":"https://avatars2.githubusercontent.com/u/35046903?v=4","gravatar_id":"","url":"https://api.github.com/users/alexmiller-apple","html_url":"https://github.com/alexmiller-apple","followers_url":"https://api.github.com/users/alexmiller-apple/followers","following_url":"https://api.github.com/users/alexmiller-apple/following{/other_user}","gists_url":"https://api.github.com/users/alexmiller-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmiller-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmiller-apple/subscriptions","organizations_url":"https://api.github.com/users/alexmiller-apple/orgs","repos_url":"https://api.github.com/users/alexmiller-apple/repos","events_url":"https://api.github.com/users/alexmiller-apple/events{/privacy}","received_events_url":"https://api.github.com/users/alexmiller-apple/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/foundationdb/pulls/593/commits","review_comments_url":"https://api.github.com/repos/apple/foundationdb/pulls/593/comments","review_comment_url":"https://api.github.com/repos/apple/foundationdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/foundationdb/issues/593/comments","statuses_url":"https://api.github.com/repos/apple/foundationdb/statuses/6e4265fcc72b1978e6cbb4f621a76a43cf1b1f5c","head":{"label":"AlvinMooreSr:release-6.0-tls-funct","ref":"release-6.0-tls-funct","sha":"6e4265fcc72b1978e6cbb4f621a76a43cf1b1f5c","user":{"login":"AlvinMooreSr","id":36203359,"node_id":"MDQ6VXNlcjM2MjAzMzU5","avatar_url":"https://avatars2.githubusercontent.com/u/36203359?v=4","gravatar_id":"","url":"https://api.github.com/users/AlvinMooreSr","html_url":"https://github.com/AlvinMooreSr","followers_url":"https://api.github.com/users/AlvinMooreSr/followers","following_url":"https://api.github.com/users/AlvinMooreSr/following{/other_user}","gists_url":"https://api.github.com/users/AlvinMooreSr/gists{/gist_id}","starred_url":"https://api.github.com/users/AlvinMooreSr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlvinMooreSr/subscriptions","organizations_url":"https://api.github.com/users/AlvinMooreSr/orgs","repos_url":"https://api.github.com/users/AlvinMooreSr/repos","events_url":"https://api.github.com/users/AlvinMooreSr/events{/privacy}","received_events_url":"https://api.github.com/users/AlvinMooreSr/received_events","type":"User","site_admin":false},"repo":{"id":130735596,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3MzU1OTY=","name":"foundationdb","full_name":"AlvinMooreSr/foundationdb","owner":{"login":"AlvinMooreSr","id":36203359,"node_id":"MDQ6VXNlcjM2MjAzMzU5","avatar_url":"https://avatars2.githubusercontent.com/u/36203359?v=4","gravatar_id":"","url":"https://api.github.com/users/AlvinMooreSr","html_url":"https://github.com/AlvinMooreSr","followers_url":"https://api.github.com/users/AlvinMooreSr/followers","following_url":"https://api.github.com/users/AlvinMooreSr/following{/other_user}","gists_url":"https://api.github.com/users/AlvinMooreSr/gists{/gist_id}","starred_url":"https://api.github.com/users/AlvinMooreSr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlvinMooreSr/subscriptions","organizations_url":"https://api.github.com/users/AlvinMooreSr/orgs","repos_url":"https://api.github.com/users/AlvinMooreSr/repos","events_url":"https://api.github.com/users/AlvinMooreSr/events{/privacy}","received_events_url":"https://api.github.com/users/AlvinMooreSr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlvinMooreSr/foundationdb","description":"FoundationDB - the open source, distributed, transactional key-value store","fork":true,"url":"https://api.github.com/repos/AlvinMooreSr/foundationdb","forks_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/forks","keys_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/teams","hooks_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/hooks","issue_events_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/issues/events{/number}","events_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/events","assignees_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/assignees{/user}","branches_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/branches{/branch}","tags_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/tags","blobs_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/statuses/{sha}","languages_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/languages","stargazers_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/stargazers","contributors_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/contributors","subscribers_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/subscribers","subscription_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/subscription","commits_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/contents/{+path}","compare_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/merges","archive_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/downloads","issues_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/issues{/number}","pulls_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/pulls{/number}","milestones_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/milestones{/number}","notifications_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/labels{/name}","releases_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/releases{/id}","deployments_url":"https://api.github.com/repos/AlvinMooreSr/foundationdb/deployments","created_at":"2018-04-23T17:54:16Z","updated_at":"2018-07-12T17:09:51Z","pushed_at":"2018-07-12T20:24:46Z","git_url":"git://github.com/AlvinMooreSr/foundationdb.git","ssh_url":"git@github.com:AlvinMooreSr/foundationdb.git","clone_url":"https://github.com/AlvinMooreSr/foundationdb.git","svn_url":"https://github.com/AlvinMooreSr/foundationdb","homepage":"https://www.foundationdb.org","size":10160,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apple:release-6.0","ref":"release-6.0","sha":"16b171e93bd2a5948ad440f0b811d438bc97b3e8","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":114187903,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQxODc5MDM=","name":"foundationdb","full_name":"apple/foundationdb","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/foundationdb","description":"FoundationDB - the open source, distributed, transactional key-value store","fork":false,"url":"https://api.github.com/repos/apple/foundationdb","forks_url":"https://api.github.com/repos/apple/foundationdb/forks","keys_url":"https://api.github.com/repos/apple/foundationdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/foundationdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/foundationdb/teams","hooks_url":"https://api.github.com/repos/apple/foundationdb/hooks","issue_events_url":"https://api.github.com/repos/apple/foundationdb/issues/events{/number}","events_url":"https://api.github.com/repos/apple/foundationdb/events","assignees_url":"https://api.github.com/repos/apple/foundationdb/assignees{/user}","branches_url":"https://api.github.com/repos/apple/foundationdb/branches{/branch}","tags_url":"https://api.github.com/repos/apple/foundationdb/tags","blobs_url":"https://api.github.com/repos/apple/foundationdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/foundationdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/foundationdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/foundationdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/foundationdb/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/foundationdb/languages","stargazers_url":"https://api.github.com/repos/apple/foundationdb/stargazers","contributors_url":"https://api.github.com/repos/apple/foundationdb/contributors","subscribers_url":"https://api.github.com/repos/apple/foundationdb/subscribers","subscription_url":"https://api.github.com/repos/apple/foundationdb/subscription","commits_url":"https://api.github.com/repos/apple/foundationdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/foundationdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/foundationdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/foundationdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/foundationdb/contents/{+path}","compare_url":"https://api.github.com/repos/apple/foundationdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/foundationdb/merges","archive_url":"https://api.github.com/repos/apple/foundationdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/foundationdb/downloads","issues_url":"https://api.github.com/repos/apple/foundationdb/issues{/number}","pulls_url":"https://api.github.com/repos/apple/foundationdb/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/foundationdb/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/foundationdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/foundationdb/labels{/name}","releases_url":"https://api.github.com/repos/apple/foundationdb/releases{/id}","deployments_url":"https://api.github.com/repos/apple/foundationdb/deployments","created_at":"2017-12-14T01:40:42Z","updated_at":"2018-07-12T17:08:27Z","pushed_at":"2018-07-12T21:18:31Z","git_url":"git://github.com/apple/foundationdb.git","ssh_url":"git@github.com:apple/foundationdb.git","clone_url":"https://github.com/apple/foundationdb.git","svn_url":"https://github.com/apple/foundationdb","homepage":"https://www.foundationdb.org","size":10381,"stargazers_count":8108,"watchers_count":8108,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":535,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":535,"open_issues":91,"watchers":8108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/593"},"html":{"href":"https://github.com/apple/foundationdb/pull/593"},"issue":{"href":"https://api.github.com/repos/apple/foundationdb/issues/593"},"comments":{"href":"https://api.github.com/repos/apple/foundationdb/issues/593/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/593/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/593/commits"},"statuses":{"href":"https://api.github.com/repos/apple/foundationdb/statuses/6e4265fcc72b1978e6cbb4f621a76a43cf1b1f5c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alexmiller-apple"}}