{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/166056154","pull_request_review_id":94083763,"id":166056154,"diff_hunk":"@@ -112,6 +112,26 @@ pub enum OutputType {\n     DepInfo,\n }\n \n+/// The epoch of the compiler (RFC 2052)\n+///\n+/// Pronounced e-poach","path":"src/librustc/session/config.rs","position":6,"original_position":6,"commit_id":"23fb447264a924cdfec861f46402f682244d0130","original_commit_id":"4894c9b035e65bfbd454f1712f3ce61171173241","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"I would rather we remove \"E-poach\" -- I like a funny comment as much as the next person, but I worry that people will actually believe us! (And this is part of rustc's public API)\r\n\r\nMore importantly, we should comment that the ordering of this enum is significant, and that epochs must go from \"early to late\" (since there is code that tests e.g., `>= Epoch2018`).","created_at":"2018-02-05T18:00:36Z","updated_at":"2018-02-05T18:11:11Z","html_url":"https://github.com/rust-lang/rust/pull/48014#discussion_r166056154","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/48014","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/166056154"},"html":{"href":"https://github.com/rust-lang/rust/pull/48014#discussion_r166056154"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48014"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/48014","id":167157383,"html_url":"https://github.com/rust-lang/rust/pull/48014","diff_url":"https://github.com/rust-lang/rust/pull/48014.diff","patch_url":"https://github.com/rust-lang/rust/pull/48014.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/48014","number":48014,"state":"open","locked":false,"title":"Implement RFC 2052 (Epochs)","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars2.githubusercontent.com/u/1617736?v=4","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"body":"This adds -Zepochs and uses it for tyvar_behind_raw_pointer (#46906)\n\n\nWhen we move this to --epoch=XXX, we'll need to gate the 2018 epoch on nightly, but not the 2015 one. I can make these changes here itself though it's kinda pointless given that the entire flag is nightly-only.\n\n\nr? @nikomatsakis @aturon\n\ncc #44581 (epoch tracking)\ncc #46906 (tyvar_behind_raw_pointer)","created_at":"2018-02-05T14:25:23Z","updated_at":"2018-02-05T18:11:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af2a111ad6ca5c383eccfc7d7a44c61ffed4c8c0","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/48014/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/48014/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/48014/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/23fb447264a924cdfec861f46402f682244d0130","head":{"label":"Manishearth:stealing-chickens-on-the-internet","ref":"stealing-chickens-on-the-internet","sha":"23fb447264a924cdfec861f46402f682244d0130","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars2.githubusercontent.com/u/1617736?v=4","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"repo":{"id":18477516,"name":"rust","full_name":"Manishearth/rust","owner":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars2.githubusercontent.com/u/1617736?v=4","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Manishearth/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/Manishearth/rust","forks_url":"https://api.github.com/repos/Manishearth/rust/forks","keys_url":"https://api.github.com/repos/Manishearth/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manishearth/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manishearth/rust/teams","hooks_url":"https://api.github.com/repos/Manishearth/rust/hooks","issue_events_url":"https://api.github.com/repos/Manishearth/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Manishearth/rust/events","assignees_url":"https://api.github.com/repos/Manishearth/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Manishearth/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Manishearth/rust/tags","blobs_url":"https://api.github.com/repos/Manishearth/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manishearth/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manishearth/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manishearth/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manishearth/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Manishearth/rust/languages","stargazers_url":"https://api.github.com/repos/Manishearth/rust/stargazers","contributors_url":"https://api.github.com/repos/Manishearth/rust/contributors","subscribers_url":"https://api.github.com/repos/Manishearth/rust/subscribers","subscription_url":"https://api.github.com/repos/Manishearth/rust/subscription","commits_url":"https://api.github.com/repos/Manishearth/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manishearth/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manishearth/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manishearth/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manishearth/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Manishearth/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manishearth/rust/merges","archive_url":"https://api.github.com/repos/Manishearth/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manishearth/rust/downloads","issues_url":"https://api.github.com/repos/Manishearth/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Manishearth/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Manishearth/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Manishearth/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manishearth/rust/labels{/name}","releases_url":"https://api.github.com/repos/Manishearth/rust/releases{/id}","deployments_url":"https://api.github.com/repos/Manishearth/rust/deployments","created_at":"2014-04-05T21:54:27Z","updated_at":"2016-12-02T22:31:57Z","pushed_at":"2018-02-05T15:34:42Z","git_url":"git://github.com/Manishearth/rust.git","ssh_url":"git@github.com:Manishearth/rust.git","clone_url":"https://github.com/Manishearth/rust.git","svn_url":"https://github.com/Manishearth/rust","homepage":"http://www.rust-lang.org","size":342012,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"b0a396bb0af5ad7706ffa2fafdec761012df200d","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-02-05T17:56:37Z","pushed_at":"2018-02-05T18:03:45Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":345834,"stargazers_count":26332,"watchers_count":26332,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4698,"mirror_url":null,"archived":false,"open_issues_count":3314,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4698,"open_issues":3314,"watchers":26332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48014"},"html":{"href":"https://github.com/rust-lang/rust/pull/48014"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/48014"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/48014/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48014/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48014/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/23fb447264a924cdfec861f46402f682244d0130"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nikomatsakis"}}