{"action":"created","comment":{"url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/comments/196901088","pull_request_review_id":130538815,"id":196901088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkwMTA4OA==","diff_hunk":"@@ -1697,6 +1704,21 @@ filters:\n     output:\n       <<: *output_properties\n       kind: quarry\n+  - filter:\n+      leisure:\n+        - adult_gaming_centre\n+        # fairly common misspelling\n+        - adult_gaming_center\n+    min_zoom: 17\n+    output:\n+      <<: *output_properties\n+      kind: gaming","path":"yaml/pois.yaml","position":null,"original_position":83,"commit_id":"96110df9d1f8eb96e9a2f2a20a1b43f8b146db69","original_commit_id":"18c9c1d2e18f478c95e5c36f47f388b1a2c25264","user":{"login":"zerebubuth","id":271360,"node_id":"MDQ6VXNlcjI3MTM2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/271360?v=4","gravatar_id":"","url":"https://api.github.com/users/zerebubuth","html_url":"https://github.com/zerebubuth","followers_url":"https://api.github.com/users/zerebubuth/followers","following_url":"https://api.github.com/users/zerebubuth/following{/other_user}","gists_url":"https://api.github.com/users/zerebubuth/gists{/gist_id}","starred_url":"https://api.github.com/users/zerebubuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerebubuth/subscriptions","organizations_url":"https://api.github.com/users/zerebubuth/orgs","repos_url":"https://api.github.com/users/zerebubuth/repos","events_url":"https://api.github.com/users/zerebubuth/events{/privacy}","received_events_url":"https://api.github.com/users/zerebubuth/received_events","type":"User","site_admin":false},"body":"Changed in 96110df.","created_at":"2018-06-20T18:41:10Z","updated_at":"2018-06-20T18:41:10Z","html_url":"https://github.com/tilezen/vector-datasource/pull/1541#discussion_r196901088","pull_request_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1541","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/comments/196901088"},"html":{"href":"https://github.com/tilezen/vector-datasource/pull/1541#discussion_r196901088"},"pull_request":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1541"}},"in_reply_to_id":196862861},"pull_request":{"url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1541","id":196205577,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjA1NTc3","html_url":"https://github.com/tilezen/vector-datasource/pull/1541","diff_url":"https://github.com/tilezen/vector-datasource/pull/1541.diff","patch_url":"https://github.com/tilezen/vector-datasource/pull/1541.patch","issue_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/1541","number":1541,"state":"open","locked":false,"title":"More kinds for maki icon library support","user":{"login":"zerebubuth","id":271360,"node_id":"MDQ6VXNlcjI3MTM2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/271360?v=4","gravatar_id":"","url":"https://api.github.com/users/zerebubuth","html_url":"https://github.com/zerebubuth","followers_url":"https://api.github.com/users/zerebubuth/followers","following_url":"https://api.github.com/users/zerebubuth/following{/other_user}","gists_url":"https://api.github.com/users/zerebubuth/gists{/gist_id}","starred_url":"https://api.github.com/users/zerebubuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerebubuth/subscriptions","organizations_url":"https://api.github.com/users/zerebubuth/orgs","repos_url":"https://api.github.com/users/zerebubuth/repos","events_url":"https://api.github.com/users/zerebubuth/events{/privacy}","received_events_url":"https://api.github.com/users/zerebubuth/received_events","type":"User","site_admin":false},"body":"Added some more kinds related to #1423.\r\n\r\n* `gaming`\r\n* `garden_centre`\r\n* `golf`\r\n* `grocery`\r\n* `harbor`\r\n* `naval_base`\r\n* `port_terminal`\r\n* `ferry_terminal` landuse\r\n* `container_terminal`\r\n* `shipyard`\r\n* `wharf`\r\n* `quay`\r\n* `boatyard`\r\n* `boat_lift`\r\n* `ship_chandler`\r\n* `customs`\r\n\r\n(NOTE: we already had `man_made=crane` mapped to `kind: crane`, so there wasn't a need to add that.)\r\n\r\nSome follow-ups:\r\n\r\n* Added a kind for `grocery`. We already had `greengrocer` and, looking at the Wikipedia pages for [grocery](https://en.wikipedia.org/wiki/Grocery_store) compared with [greengrocer](https://en.wikipedia.org/wiki/Greengrocer), I'm not sure that they're the same thing. For the moment, I've left them as separate kinds.\r\n* Many items tagged as `harbour=yes` are also tagged as other things. For example, this [port terminal](https://www.openstreetmap.org/way/256125920) is tagged `harbour=yes, landuse=port_terminal, man_made=pier`; should that be output as a harbour, port terminal or pier - or should we split the geometry to allow multiple features for the harbour landuse and pier, with a POI for the port terminal? Also, this [pier](https://www.openstreetmap.org/way/183049783) is tagged `harbour=yes, man_made=pier` - should that be harbour, pier or split into two features?\r\n* The `customs` kind mentions the [`amenity=customs`](http://wiki.openstreetmap.org/wiki/Tag:amenity=customs) tag, which has only 742 uses. Should we also include the [`barrier=border_control`](https://wiki.openstreetmap.org/wiki/Tag:barrier%3Dborder_control) tag, which has over 5,000 uses? Should they _both_ be mapped to kind `customs`, or are customs (i.e: taxation) and border control sufficiently distinct things to deserve distinct kinds?\r\n","created_at":"2018-06-20T16:42:05Z","updated_at":"2018-06-20T18:41:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a4a0900caad84aa1d10e2b088605969456311c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1541/commits","review_comments_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1541/comments","review_comment_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/1541/comments","statuses_url":"https://api.github.com/repos/tilezen/vector-datasource/statuses/96110df9d1f8eb96e9a2f2a20a1b43f8b146db69","head":{"label":"tilezen:zerebubuth/1423-kinds-for-maki-icon-library-support","ref":"zerebubuth/1423-kinds-for-maki-icon-library-support","sha":"96110df9d1f8eb96e9a2f2a20a1b43f8b146db69","user":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"repo":{"id":13446739,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NjczOQ==","name":"vector-datasource","full_name":"tilezen/vector-datasource","owner":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tilezen/vector-datasource","description":"Mapzen vector tile service - OpenStreetMap data in several formats","fork":false,"url":"https://api.github.com/repos/tilezen/vector-datasource","forks_url":"https://api.github.com/repos/tilezen/vector-datasource/forks","keys_url":"https://api.github.com/repos/tilezen/vector-datasource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilezen/vector-datasource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilezen/vector-datasource/teams","hooks_url":"https://api.github.com/repos/tilezen/vector-datasource/hooks","issue_events_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/events{/number}","events_url":"https://api.github.com/repos/tilezen/vector-datasource/events","assignees_url":"https://api.github.com/repos/tilezen/vector-datasource/assignees{/user}","branches_url":"https://api.github.com/repos/tilezen/vector-datasource/branches{/branch}","tags_url":"https://api.github.com/repos/tilezen/vector-datasource/tags","blobs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilezen/vector-datasource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilezen/vector-datasource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilezen/vector-datasource/statuses/{sha}","languages_url":"https://api.github.com/repos/tilezen/vector-datasource/languages","stargazers_url":"https://api.github.com/repos/tilezen/vector-datasource/stargazers","contributors_url":"https://api.github.com/repos/tilezen/vector-datasource/contributors","subscribers_url":"https://api.github.com/repos/tilezen/vector-datasource/subscribers","subscription_url":"https://api.github.com/repos/tilezen/vector-datasource/subscription","commits_url":"https://api.github.com/repos/tilezen/vector-datasource/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilezen/vector-datasource/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilezen/vector-datasource/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/comments{/number}","contents_url":"https://api.github.com/repos/tilezen/vector-datasource/contents/{+path}","compare_url":"https://api.github.com/repos/tilezen/vector-datasource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilezen/vector-datasource/merges","archive_url":"https://api.github.com/repos/tilezen/vector-datasource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilezen/vector-datasource/downloads","issues_url":"https://api.github.com/repos/tilezen/vector-datasource/issues{/number}","pulls_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls{/number}","milestones_url":"https://api.github.com/repos/tilezen/vector-datasource/milestones{/number}","notifications_url":"https://api.github.com/repos/tilezen/vector-datasource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilezen/vector-datasource/labels{/name}","releases_url":"https://api.github.com/repos/tilezen/vector-datasource/releases{/id}","deployments_url":"https://api.github.com/repos/tilezen/vector-datasource/deployments","created_at":"2013-10-09T15:54:45Z","updated_at":"2018-06-20T09:14:34Z","pushed_at":"2018-06-20T18:40:30Z","git_url":"git://github.com/tilezen/vector-datasource.git","ssh_url":"git@github.com:tilezen/vector-datasource.git","clone_url":"https://github.com/tilezen/vector-datasource.git","svn_url":"https://github.com/tilezen/vector-datasource","homepage":"https://mapzen.com/projects/vector-tiles/","size":66012,"stargazers_count":344,"watchers_count":344,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":97,"open_issues":246,"watchers":344,"default_branch":"master"}},"base":{"label":"tilezen:master","ref":"master","sha":"108db28921496b68989524f85c39f5751246c56a","user":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"repo":{"id":13446739,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NjczOQ==","name":"vector-datasource","full_name":"tilezen/vector-datasource","owner":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tilezen/vector-datasource","description":"Mapzen vector tile service - OpenStreetMap data in several formats","fork":false,"url":"https://api.github.com/repos/tilezen/vector-datasource","forks_url":"https://api.github.com/repos/tilezen/vector-datasource/forks","keys_url":"https://api.github.com/repos/tilezen/vector-datasource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilezen/vector-datasource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilezen/vector-datasource/teams","hooks_url":"https://api.github.com/repos/tilezen/vector-datasource/hooks","issue_events_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/events{/number}","events_url":"https://api.github.com/repos/tilezen/vector-datasource/events","assignees_url":"https://api.github.com/repos/tilezen/vector-datasource/assignees{/user}","branches_url":"https://api.github.com/repos/tilezen/vector-datasource/branches{/branch}","tags_url":"https://api.github.com/repos/tilezen/vector-datasource/tags","blobs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilezen/vector-datasource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilezen/vector-datasource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilezen/vector-datasource/statuses/{sha}","languages_url":"https://api.github.com/repos/tilezen/vector-datasource/languages","stargazers_url":"https://api.github.com/repos/tilezen/vector-datasource/stargazers","contributors_url":"https://api.github.com/repos/tilezen/vector-datasource/contributors","subscribers_url":"https://api.github.com/repos/tilezen/vector-datasource/subscribers","subscription_url":"https://api.github.com/repos/tilezen/vector-datasource/subscription","commits_url":"https://api.github.com/repos/tilezen/vector-datasource/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilezen/vector-datasource/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilezen/vector-datasource/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/comments{/number}","contents_url":"https://api.github.com/repos/tilezen/vector-datasource/contents/{+path}","compare_url":"https://api.github.com/repos/tilezen/vector-datasource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilezen/vector-datasource/merges","archive_url":"https://api.github.com/repos/tilezen/vector-datasource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilezen/vector-datasource/downloads","issues_url":"https://api.github.com/repos/tilezen/vector-datasource/issues{/number}","pulls_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls{/number}","milestones_url":"https://api.github.com/repos/tilezen/vector-datasource/milestones{/number}","notifications_url":"https://api.github.com/repos/tilezen/vector-datasource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilezen/vector-datasource/labels{/name}","releases_url":"https://api.github.com/repos/tilezen/vector-datasource/releases{/id}","deployments_url":"https://api.github.com/repos/tilezen/vector-datasource/deployments","created_at":"2013-10-09T15:54:45Z","updated_at":"2018-06-20T09:14:34Z","pushed_at":"2018-06-20T18:40:30Z","git_url":"git://github.com/tilezen/vector-datasource.git","ssh_url":"git@github.com:tilezen/vector-datasource.git","clone_url":"https://github.com/tilezen/vector-datasource.git","svn_url":"https://github.com/tilezen/vector-datasource","homepage":"https://mapzen.com/projects/vector-tiles/","size":66012,"stargazers_count":344,"watchers_count":344,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":97,"open_issues":246,"watchers":344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1541"},"html":{"href":"https://github.com/tilezen/vector-datasource/pull/1541"},"issue":{"href":"https://api.github.com/repos/tilezen/vector-datasource/issues/1541"},"comments":{"href":"https://api.github.com/repos/tilezen/vector-datasource/issues/1541/comments"},"review_comments":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1541/comments"},"review_comment":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1541/commits"},"statuses":{"href":"https://api.github.com/repos/tilezen/vector-datasource/statuses/96110df9d1f8eb96e9a2f2a20a1b43f8b146db69"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"zerebubuth"}}