{"action":"created","issue":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/58","repository_url":"https://api.github.com/repos/KratosMultiphysics/Kratos","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/58/comments","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/58/events","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/58","id":209117219,"node_id":"MDExOlB1bGxSZXF1ZXN0MTA3MTY4NTM4","number":58,"title":"Replace rapidjson to nlohmann json","user":{"login":"RiccardoRossi","id":8059665,"node_id":"MDQ6VXNlcjgwNTk2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/8059665?v=4","gravatar_id":"","url":"https://api.github.com/users/RiccardoRossi","html_url":"https://github.com/RiccardoRossi","followers_url":"https://api.github.com/users/RiccardoRossi/followers","following_url":"https://api.github.com/users/RiccardoRossi/following{/other_user}","gists_url":"https://api.github.com/users/RiccardoRossi/gists{/gist_id}","starred_url":"https://api.github.com/users/RiccardoRossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RiccardoRossi/subscriptions","organizations_url":"https://api.github.com/users/RiccardoRossi/orgs","repos_url":"https://api.github.com/users/RiccardoRossi/repos","events_url":"https://api.github.com/users/RiccardoRossi/events{/privacy}","received_events_url":"https://api.github.com/users/RiccardoRossi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":53,"created_at":"2017-02-21T11:30:11Z","updated_at":"2018-11-06T15:54:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/58","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/58","diff_url":"https://github.com/KratosMultiphysics/Kratos/pull/58.diff","patch_url":"https://github.com/KratosMultiphysics/Kratos/pull/58.patch"},"body":"Hello,\r\n         this branch removes rapidjson as support library for the KratosParameters and replaces it to the \"nlohmann\" json library.\r\n\r\nThis is more or less a complete rewrite of the kratos_parameters, which however maintains the same API and should (hopefully) not affect at any user. It passes  all of the existing unit tests.\r\n\r\ni believe that the new code base is sensibly cleaner than the old version and the nlohmann library is more modern than rapidjson, apart for being contained within a single header.\r\nThe most important advantage is that json objects are stored in a std::map instead in a list as happend with rapidjson, making unordered insertion/search much faster.\r\n\r\nA nice feature is also that the new lib should also allow serializing/reading to a binary format\r\n\r\nWARNING: the current version has not been tested on windows, so before accepting the pull request someone should try that out.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments/436303364","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/58#issuecomment-436303364","issue_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/58","id":436303364,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjMwMzM2NA==","user":{"login":"pooyan-dadvand","id":8911479,"node_id":"MDQ6VXNlcjg5MTE0Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/8911479?v=4","gravatar_id":"","url":"https://api.github.com/users/pooyan-dadvand","html_url":"https://github.com/pooyan-dadvand","followers_url":"https://api.github.com/users/pooyan-dadvand/followers","following_url":"https://api.github.com/users/pooyan-dadvand/following{/other_user}","gists_url":"https://api.github.com/users/pooyan-dadvand/gists{/gist_id}","starred_url":"https://api.github.com/users/pooyan-dadvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pooyan-dadvand/subscriptions","organizations_url":"https://api.github.com/users/pooyan-dadvand/orgs","repos_url":"https://api.github.com/users/pooyan-dadvand/repos","events_url":"https://api.github.com/users/pooyan-dadvand/events{/privacy}","received_events_url":"https://api.github.com/users/pooyan-dadvand/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T15:54:47Z","updated_at":"2018-11-06T15:54:47Z","author_association":"MEMBER","body":"Is it the oldest open PR?"}}
{"actor":{"display_login":"pooyan-dadvand"}}