{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60525","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60525/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60525/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60525/events","html_url":"https://github.com/kubernetes/kubernetes/pull/60525","id":300801472,"number":60525,"title":"Balanced resource allocation priority to include volume count on nodes.","user":{"login":"ravisantoshgudimetla","id":11657829,"avatar_url":"https://avatars3.githubusercontent.com/u/11657829?v=4","gravatar_id":"","url":"https://api.github.com/users/ravisantoshgudimetla","html_url":"https://github.com/ravisantoshgudimetla","followers_url":"https://api.github.com/users/ravisantoshgudimetla/followers","following_url":"https://api.github.com/users/ravisantoshgudimetla/following{/other_user}","gists_url":"https://api.github.com/users/ravisantoshgudimetla/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisantoshgudimetla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisantoshgudimetla/subscriptions","organizations_url":"https://api.github.com/users/ravisantoshgudimetla/orgs","repos_url":"https://api.github.com/users/ravisantoshgudimetla/repos","events_url":"https://api.github.com/users/ravisantoshgudimetla/events{/privacy}","received_events_url":"https://api.github.com/users/ravisantoshgudimetla/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":240247879,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":125550211,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":253451057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-02-27T21:34:38Z","updated_at":"2018-03-16T17:31:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60525","html_url":"https://github.com/kubernetes/kubernetes/pull/60525","diff_url":"https://github.com/kubernetes/kubernetes/pull/60525.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/60525.patch"},"body":"Scheduler balanced resource allocation priority to include volume count on nodes.\r\n\r\n/cc @aveshagarwal @abhgupta\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #58232\r\n\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/373787997","html_url":"https://github.com/kubernetes/kubernetes/pull/60525#issuecomment-373787997","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60525","id":373787997,"user":{"login":"bsalamat","id":14308438,"avatar_url":"https://avatars3.githubusercontent.com/u/14308438?v=4","gravatar_id":"","url":"https://api.github.com/users/bsalamat","html_url":"https://github.com/bsalamat","followers_url":"https://api.github.com/users/bsalamat/followers","following_url":"https://api.github.com/users/bsalamat/following{/other_user}","gists_url":"https://api.github.com/users/bsalamat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsalamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsalamat/subscriptions","organizations_url":"https://api.github.com/users/bsalamat/orgs","repos_url":"https://api.github.com/users/bsalamat/repos","events_url":"https://api.github.com/users/bsalamat/events{/privacy}","received_events_url":"https://api.github.com/users/bsalamat/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T17:31:57Z","updated_at":"2018-03-16T17:31:57Z","author_association":"CONTRIBUTOR","body":"@ravisantoshgudimetla \r\nTwo issues that I see with the current approach:\r\n1. It needs passing the transient node info to predicate and priority functions. This needs changes to many places including modules other than the scheduler. Unfortunately, I can't think of a clean option at the moment. One not-so-clean option is to add the new structure under NodeInfo with \"Transient\" in the name and a clear comment that the information in this struct is valid only during one schedule cycle.\r\n2. Predicate and priority functions run in parallel for different nodes. So, reading and writing the transient node info requires synchronization.\r\n"}}
{"actor":{"display_login":"bsalamat"}}