{"action":"created","issue":{"url":"https://api.github.com/repos/zsmartsystems/com.zsmartsystems.zigbee/issues/349","repository_url":"https://api.github.com/repos/zsmartsystems/com.zsmartsystems.zigbee","labels_url":"https://api.github.com/repos/zsmartsystems/com.zsmartsystems.zigbee/issues/349/labels{/name}","comments_url":"https://api.github.com/repos/zsmartsystems/com.zsmartsystems.zigbee/issues/349/comments","events_url":"https://api.github.com/repos/zsmartsystems/com.zsmartsystems.zigbee/issues/349/events","html_url":"https://github.com/zsmartsystems/com.zsmartsystems.zigbee/pull/349","id":347699323,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjM5Mzcz","number":349,"title":"Add address and counter options to ZigBeeKey","user":{"login":"cdjackson","id":1041475,"node_id":"MDQ6VXNlcjEwNDE0NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1041475?v=4","gravatar_id":"","url":"https://api.github.com/users/cdjackson","html_url":"https://github.com/cdjackson","followers_url":"https://api.github.com/users/cdjackson/followers","following_url":"https://api.github.com/users/cdjackson/following{/other_user}","gists_url":"https://api.github.com/users/cdjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/cdjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdjackson/subscriptions","organizations_url":"https://api.github.com/users/cdjackson/orgs","repos_url":"https://api.github.com/users/cdjackson/repos","events_url":"https://api.github.com/users/cdjackson/events{/privacy}","received_events_url":"https://api.github.com/users/cdjackson/received_events","type":"User","site_admin":false},"labels":[{"id":898690481,"node_id":"MDU6TGFiZWw4OTg2OTA0ODE=","url":"https://api.github.com/repos/zsmartsystems/com.zsmartsystems.zigbee/labels/EMBER","name":"EMBER","color":"bfd4f2","default":false},{"id":740753782,"node_id":"MDU6TGFiZWw3NDA3NTM3ODI=","url":"https://api.github.com/repos/zsmartsystems/com.zsmartsystems.zigbee/labels/breaking%20change","name":"breaking change","color":"f7b2f1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-05T13:41:19Z","updated_at":"2018-08-05T20:25:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zsmartsystems/com.zsmartsystems.zigbee/pulls/349","html_url":"https://github.com/zsmartsystems/com.zsmartsystems.zigbee/pull/349","diff_url":"https://github.com/zsmartsystems/com.zsmartsystems.zigbee/pull/349.diff","patch_url":"https://github.com/zsmartsystems/com.zsmartsystems.zigbee/pull/349.patch"},"body":"To avoid having multiple key types, each with different options, the options have been added directly to the ```ZigBeeKey``` Class. This allows a counter, and/or an address to be associated with a key and removes the need for the separate ```ZigBeeNodeKey``` class.\r\nThis also more closely reflects the Ember key definition where keys have attributes.\r\n\r\nThe ```ZigBeeKey``` class is also refactored into the security package, so this is a minor breaking change that will require imports to be updated.\r\n\r\nEmber initialisation now carries the ```ZigBeeKey``` into the initialisation methods rather than using the internal ```EmberKeyData``` class, so that this additional information is available.\r\n\r\nSigned-off-by: Chris Jackson <chris@cd-jackson.com>"},"comment":{"url":"https://api.github.com/repos/zsmartsystems/com.zsmartsystems.zigbee/issues/comments/410545565","html_url":"https://github.com/zsmartsystems/com.zsmartsystems.zigbee/pull/349#issuecomment-410545565","issue_url":"https://api.github.com/repos/zsmartsystems/com.zsmartsystems.zigbee/issues/349","id":410545565,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDU0NTU2NQ==","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"created_at":"2018-08-05T20:25:37Z","updated_at":"2018-08-05T20:25:37Z","author_association":"NONE","body":"\n![Codacy](https://app.codacy.com/assets/images/favicon.png) Here is an overview of what got changed by this pull request:\n\n\n```diff\n\nIssues\n======\n- Added 2\n           \n\nComplexity increasing per file\n==============================\n- com.zsmartsystems.zigbee.dongle.ember/src/main/java/com/zsmartsystems/zigbee/dongle/ember/internal/EmberNetworkInitialisation.java  1\n         \n```\n\n\nSee the complete overview on [Codacy](https://app.codacy.com/app/zsmartsystems/com-zsmartsystems-zigbee/pullRequest?prid=1999499&bid=8279666)\n        "}}
{"actor":{"display_login":"codacy-bot"}}