{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/221258530","pull_request_review_id":159866977,"id":221258530,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTI1ODUzMA==","diff_hunk":"@@ -21,8 +21,46 @@\n #include \"cpu.h\"\n #include \"board.h\"\n \n+#if defined(BOARD_NRF52DK)\n+#define RESET_PIN       (21U)","path":"boards/common/nrf52xxxdk/board.c","position":5,"original_position":5,"commit_id":"2cf17049719e52381a57e2fda2ab6f91b3ae29e5","original_commit_id":"2cf17049719e52381a57e2fda2ab6f91b3ae29e5","user":{"login":"MrKevinWeiss","id":19396439,"node_id":"MDQ6VXNlcjE5Mzk2NDM5","avatar_url":"https://avatars1.githubusercontent.com/u/19396439?v=4","gravatar_id":"","url":"https://api.github.com/users/MrKevinWeiss","html_url":"https://github.com/MrKevinWeiss","followers_url":"https://api.github.com/users/MrKevinWeiss/followers","following_url":"https://api.github.com/users/MrKevinWeiss/following{/other_user}","gists_url":"https://api.github.com/users/MrKevinWeiss/gists{/gist_id}","starred_url":"https://api.github.com/users/MrKevinWeiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrKevinWeiss/subscriptions","organizations_url":"https://api.github.com/users/MrKevinWeiss/orgs","repos_url":"https://api.github.com/users/MrKevinWeiss/repos","events_url":"https://api.github.com/users/MrKevinWeiss/events{/privacy}","received_events_url":"https://api.github.com/users/MrKevinWeiss/received_events","type":"User","site_admin":false},"body":"Ah thanks.","created_at":"2018-09-28T13:48:37Z","updated_at":"2018-09-28T13:48:37Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/10072#discussion_r221258530","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10072","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/221258530"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/10072#discussion_r221258530"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10072"}},"in_reply_to_id":221230530},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10072","id":218937835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTM3ODM1","html_url":"https://github.com/RIOT-OS/RIOT/pull/10072","diff_url":"https://github.com/RIOT-OS/RIOT/pull/10072.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/10072.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10072","number":10072,"state":"open","locked":false,"title":"boards/nrf52xxxdk: make reset pin work","user":{"login":"haukepetersen","id":620834,"node_id":"MDQ6VXNlcjYyMDgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/620834?v=4","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"body":"### Contribution description\r\nEver wondered why on most/all of our `nrf52dk` and `nrf52840dk` boards the reset pin is not working? Just stumbled upon the doc, where it states that the pin needs to be manually programmed (at least once) to work. This PR does exactly that, and voila, not the reset pins on those boards work like a charm.\r\n\r\n### Testing procedure\r\n- take a `nrf52dk` or `nrf52840dk` board where the reset pin is not working\r\n- flash any RIOT example on the board\r\n- reset the board (do a power-off-on or use `make reset`, as the changes take one reset cycle to take effect)\r\n- enjoy a working reset pin\r\n\r\n### Issues/PRs references\r\nnone","created_at":"2018-09-28T11:28:49Z","updated_at":"2018-09-28T13:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03aaf0402022c80fbd3d78dd0eb2efabb53b86bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":87985768,"node_id":"MDU6TGFiZWw4Nzk4NTc2OA==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/WIP","name":"WIP","color":"009800","default":false},{"id":718655339,"node_id":"MDU6TGFiZWw3MTg2NTUzMzk=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/board","name":"board","color":"4fb72a","default":false},{"id":237926357,"node_id":"MDU6TGFiZWwyMzc5MjYzNTc=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/tools","name":"tools","color":"ff6000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10072/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10072/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10072/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/2cf17049719e52381a57e2fda2ab6f91b3ae29e5","head":{"label":"haukepetersen:fix_nrf52xxxdk_resetpin","ref":"fix_nrf52xxxdk_resetpin","sha":"2cf17049719e52381a57e2fda2ab6f91b3ae29e5","user":{"login":"haukepetersen","id":620834,"node_id":"MDQ6VXNlcjYyMDgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/620834?v=4","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"repo":{"id":13741766,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0MTc2Ng==","name":"RIOT","full_name":"haukepetersen/RIOT","private":false,"owner":{"login":"haukepetersen","id":620834,"node_id":"MDQ6VXNlcjYyMDgzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/620834?v=4","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/haukepetersen/RIOT","description":"RIOT OS -  The revolutionary IoT OS","fork":true,"url":"https://api.github.com/repos/haukepetersen/RIOT","forks_url":"https://api.github.com/repos/haukepetersen/RIOT/forks","keys_url":"https://api.github.com/repos/haukepetersen/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haukepetersen/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haukepetersen/RIOT/teams","hooks_url":"https://api.github.com/repos/haukepetersen/RIOT/hooks","issue_events_url":"https://api.github.com/repos/haukepetersen/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/haukepetersen/RIOT/events","assignees_url":"https://api.github.com/repos/haukepetersen/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/haukepetersen/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/haukepetersen/RIOT/tags","blobs_url":"https://api.github.com/repos/haukepetersen/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haukepetersen/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haukepetersen/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/haukepetersen/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haukepetersen/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/haukepetersen/RIOT/languages","stargazers_url":"https://api.github.com/repos/haukepetersen/RIOT/stargazers","contributors_url":"https://api.github.com/repos/haukepetersen/RIOT/contributors","subscribers_url":"https://api.github.com/repos/haukepetersen/RIOT/subscribers","subscription_url":"https://api.github.com/repos/haukepetersen/RIOT/subscription","commits_url":"https://api.github.com/repos/haukepetersen/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/haukepetersen/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/haukepetersen/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/haukepetersen/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/haukepetersen/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/haukepetersen/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haukepetersen/RIOT/merges","archive_url":"https://api.github.com/repos/haukepetersen/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haukepetersen/RIOT/downloads","issues_url":"https://api.github.com/repos/haukepetersen/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/haukepetersen/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/haukepetersen/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/haukepetersen/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haukepetersen/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/haukepetersen/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/haukepetersen/RIOT/deployments","created_at":"2013-10-21T12:31:38Z","updated_at":"2018-03-19T11:46:00Z","pushed_at":"2018-09-28T11:26:18Z","git_url":"git://github.com/haukepetersen/RIOT.git","ssh_url":"git@github.com:haukepetersen/RIOT.git","clone_url":"https://github.com/haukepetersen/RIOT.git","svn_url":"https://github.com/haukepetersen/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":59096,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"b4664a5bd307f1ba408223f360ee6a6c00ee1320","user":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcwMjQx","name":"RIOT","full_name":"RIOT-OS/RIOT","private":false,"owner":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-09-28T08:17:12Z","pushed_at":"2018-09-28T12:11:42Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":57251,"stargazers_count":2032,"watchers_count":2032,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1149,"mirror_url":null,"archived":false,"open_issues_count":839,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1149,"open_issues":839,"watchers":2032,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10072"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/10072"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10072"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10072/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10072/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10072/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/2cf17049719e52381a57e2fda2ab6f91b3ae29e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MrKevinWeiss"}}