{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/collection/pulls/comments/175537373","pull_request_review_id":105079018,"id":175537373,"diff_hunk":"@@ -258,6 +258,25 @@ void main() {\n     expect(queue.cast<Pattern>(), same(queue));\n   }, skip: isDart2 ? false : 'Requires a Dart2 runtime');\n \n+  test(\"cast does not throw on mutation when the type is valid\", () {\n+    var patternQueue = new QueueList<Pattern>()..addAll(['a', 'b']);\n+    QueueList<Object> untypedQueue = patternQueue;\n+    var stringQueue = untypedQueue.cast<String>();\n+    stringQueue.addAll(['c', 'd']);\n+\n+    expect(stringQueue, ['a', 'b', 'c', 'd']);","path":"test/queue_list_test.dart","position":10,"original_position":10,"commit_id":"2bf2cd69a4a61947e36b4118b5086128868e125e","original_commit_id":"2bf2cd69a4a61947e36b4118b5086128868e125e","user":{"login":"lrhn","id":4865287,"avatar_url":"https://avatars3.githubusercontent.com/u/4865287?v=4","gravatar_id":"","url":"https://api.github.com/users/lrhn","html_url":"https://github.com/lrhn","followers_url":"https://api.github.com/users/lrhn/followers","following_url":"https://api.github.com/users/lrhn/following{/other_user}","gists_url":"https://api.github.com/users/lrhn/gists{/gist_id}","starred_url":"https://api.github.com/users/lrhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrhn/subscriptions","organizations_url":"https://api.github.com/users/lrhn/orgs","repos_url":"https://api.github.com/users/lrhn/repos","events_url":"https://api.github.com/users/lrhn/events{/privacy}","received_events_url":"https://api.github.com/users/lrhn/received_events","type":"User","site_admin":false},"body":"Check that `patternQueue` was also modified.","created_at":"2018-03-19T18:19:19Z","updated_at":"2018-03-19T18:19:29Z","html_url":"https://github.com/dart-lang/collection/pull/88#discussion_r175537373","pull_request_url":"https://api.github.com/repos/dart-lang/collection/pulls/88","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/collection/pulls/comments/175537373"},"html":{"href":"https://github.com/dart-lang/collection/pull/88#discussion_r175537373"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/collection/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/collection/pulls/88","id":175804424,"html_url":"https://github.com/dart-lang/collection/pull/88","diff_url":"https://github.com/dart-lang/collection/pull/88.diff","patch_url":"https://github.com/dart-lang/collection/pull/88.patch","issue_url":"https://api.github.com/repos/dart-lang/collection/issues/88","number":88,"state":"open","locked":false,"title":"Fix cast and retype implementations.","user":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars2.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/dart-lang/collection/issues/87.\r\n\r\nI had to be a little creative for `QueueList`. The others seem OK enough.","created_at":"2018-03-19T04:50:17Z","updated_at":"2018-03-19T18:19:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c71de3aa5c803912b3d94220491fbe85dea3cac","assignee":null,"assignees":[],"requested_reviewers":[{"login":"srawlins","id":103167,"avatar_url":"https://avatars3.githubusercontent.com/u/103167?v=4","gravatar_id":"","url":"https://api.github.com/users/srawlins","html_url":"https://github.com/srawlins","followers_url":"https://api.github.com/users/srawlins/followers","following_url":"https://api.github.com/users/srawlins/following{/other_user}","gists_url":"https://api.github.com/users/srawlins/gists{/gist_id}","starred_url":"https://api.github.com/users/srawlins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srawlins/subscriptions","organizations_url":"https://api.github.com/users/srawlins/orgs","repos_url":"https://api.github.com/users/srawlins/repos","events_url":"https://api.github.com/users/srawlins/events{/privacy}","received_events_url":"https://api.github.com/users/srawlins/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":421017844,"url":"https://api.github.com/repos/dart-lang/collection/labels/cla:%20yes","name":"cla: yes","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/collection/pulls/88/commits","review_comments_url":"https://api.github.com/repos/dart-lang/collection/pulls/88/comments","review_comment_url":"https://api.github.com/repos/dart-lang/collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/collection/issues/88/comments","statuses_url":"https://api.github.com/repos/dart-lang/collection/statuses/2bf2cd69a4a61947e36b4118b5086128868e125e","head":{"label":"matanlurey:fix-cast-retype","ref":"fix-cast-retype","sha":"2bf2cd69a4a61947e36b4118b5086128868e125e","user":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars2.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"repo":{"id":73758016,"name":"collection","full_name":"matanlurey/collection","owner":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars2.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matanlurey/collection","description":"The collection package for Dart contains a number of separate libraries with utility functions and classes that makes working with collections easier.","fork":true,"url":"https://api.github.com/repos/matanlurey/collection","forks_url":"https://api.github.com/repos/matanlurey/collection/forks","keys_url":"https://api.github.com/repos/matanlurey/collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matanlurey/collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matanlurey/collection/teams","hooks_url":"https://api.github.com/repos/matanlurey/collection/hooks","issue_events_url":"https://api.github.com/repos/matanlurey/collection/issues/events{/number}","events_url":"https://api.github.com/repos/matanlurey/collection/events","assignees_url":"https://api.github.com/repos/matanlurey/collection/assignees{/user}","branches_url":"https://api.github.com/repos/matanlurey/collection/branches{/branch}","tags_url":"https://api.github.com/repos/matanlurey/collection/tags","blobs_url":"https://api.github.com/repos/matanlurey/collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matanlurey/collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matanlurey/collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/matanlurey/collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matanlurey/collection/statuses/{sha}","languages_url":"https://api.github.com/repos/matanlurey/collection/languages","stargazers_url":"https://api.github.com/repos/matanlurey/collection/stargazers","contributors_url":"https://api.github.com/repos/matanlurey/collection/contributors","subscribers_url":"https://api.github.com/repos/matanlurey/collection/subscribers","subscription_url":"https://api.github.com/repos/matanlurey/collection/subscription","commits_url":"https://api.github.com/repos/matanlurey/collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/matanlurey/collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/matanlurey/collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/matanlurey/collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/matanlurey/collection/contents/{+path}","compare_url":"https://api.github.com/repos/matanlurey/collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matanlurey/collection/merges","archive_url":"https://api.github.com/repos/matanlurey/collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matanlurey/collection/downloads","issues_url":"https://api.github.com/repos/matanlurey/collection/issues{/number}","pulls_url":"https://api.github.com/repos/matanlurey/collection/pulls{/number}","milestones_url":"https://api.github.com/repos/matanlurey/collection/milestones{/number}","notifications_url":"https://api.github.com/repos/matanlurey/collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matanlurey/collection/labels{/name}","releases_url":"https://api.github.com/repos/matanlurey/collection/releases{/id}","deployments_url":"https://api.github.com/repos/matanlurey/collection/deployments","created_at":"2016-11-15T00:00:19Z","updated_at":"2016-11-15T00:00:22Z","pushed_at":"2018-03-19T17:26:06Z","git_url":"git://github.com/matanlurey/collection.git","ssh_url":"git@github.com:matanlurey/collection.git","clone_url":"https://github.com/matanlurey/collection.git","svn_url":"https://github.com/matanlurey/collection","homepage":"https://pub.dartlang.org/packages/collection","size":228,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"ac08b43b7d5723da993b80ed164b392f0c192c4b","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":31254008,"name":"collection","full_name":"dart-lang/collection","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/collection","description":"The collection package for Dart contains a number of separate libraries with utility functions and classes that makes working with collections easier.","fork":false,"url":"https://api.github.com/repos/dart-lang/collection","forks_url":"https://api.github.com/repos/dart-lang/collection/forks","keys_url":"https://api.github.com/repos/dart-lang/collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/collection/teams","hooks_url":"https://api.github.com/repos/dart-lang/collection/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/collection/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/collection/events","assignees_url":"https://api.github.com/repos/dart-lang/collection/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/collection/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/collection/tags","blobs_url":"https://api.github.com/repos/dart-lang/collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/collection/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/collection/languages","stargazers_url":"https://api.github.com/repos/dart-lang/collection/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/collection/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/collection/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/collection/subscription","commits_url":"https://api.github.com/repos/dart-lang/collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/collection/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/collection/merges","archive_url":"https://api.github.com/repos/dart-lang/collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/collection/downloads","issues_url":"https://api.github.com/repos/dart-lang/collection/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/collection/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/collection/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/collection/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/collection/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/collection/deployments","created_at":"2015-02-24T09:58:44Z","updated_at":"2018-03-16T19:18:14Z","pushed_at":"2018-03-19T17:26:07Z","git_url":"git://github.com/dart-lang/collection.git","ssh_url":"git@github.com:dart-lang/collection.git","clone_url":"https://github.com/dart-lang/collection.git","svn_url":"https://github.com/dart-lang/collection","homepage":"https://pub.dartlang.org/packages/collection","size":215,"stargazers_count":14,"watchers_count":14,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":15,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/collection/pulls/88"},"html":{"href":"https://github.com/dart-lang/collection/pull/88"},"issue":{"href":"https://api.github.com/repos/dart-lang/collection/issues/88"},"comments":{"href":"https://api.github.com/repos/dart-lang/collection/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/collection/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/collection/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/collection/statuses/2bf2cd69a4a61947e36b4118b5086128868e125e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lrhn"}}