{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/176613328","pull_request_review_id":106349636,"id":176613328,"diff_hunk":"@@ -0,0 +1,61 @@\n+#!/usr/bin/env bash\n+\n+set -e\n+\n+BASE_URL=''\n+DEVICE=''\n+\n+while getopts 'd:r:' flag; do\n+  case \"${flag}\" in\n+    d) DEVICE=$OPTARG;;\n+    r) BASE_URL=$OPTARG;;\n+  esac\n+done\n+\n+DASH_DIR=`pwd`\n+\n+cd ../../../../build\n+BUILD_DIR=`pwd`\n+\n+if [ \"$BASE_URL\" == \"\" ]; then\n+    ../src/stop.sh","path":"src/pybind/mgr/dashboard/run-frontend-e2e-tests.sh","position":null,"original_position":21,"commit_id":"79b079fdeeb32e84c11ccd76a56429d63184fd45","original_commit_id":"2cc835c8e4a3c11383de324cb7337e134114f130","user":{"login":"tspmelo","id":399326,"avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-03-23T00:42:41Z","updated_at":"2018-03-23T00:42:42Z","html_url":"https://github.com/ceph/ceph/pull/20943#discussion_r176613328","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/20943","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/176613328"},"html":{"href":"https://github.com/ceph/ceph/pull/20943#discussion_r176613328"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20943"}},"in_reply_to_id":176497082},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/20943","id":175608591,"html_url":"https://github.com/ceph/ceph/pull/20943","diff_url":"https://github.com/ceph/ceph/pull/20943.diff","patch_url":"https://github.com/ceph/ceph/pull/20943.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/20943","number":20943,"state":"open","locked":false,"title":"mgr/dashboard: fix frontend e2e tests","user":{"login":"tspmelo","id":399326,"avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},"body":"Updated protractor configuration: now it's possible to run the tests inside a\r\ndocker container, added params for the username and password and added login\r\nduring the prepare phase.\r\n\r\nChrome is required to run the e2e tests. This can be achieved by installing\r\nChrome in your system or by using a docker container with Chrome installed.\r\n\r\nChanged some timer calls, so they are runned outside of angular. This was\r\npreventing protractor from running the tests.\r\n\r\n`Signed-off-by: Tiago Melo <tmelo@suse.com>`","created_at":"2018-03-16T18:10:18Z","updated_at":"2018-03-23T00:42:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45c64cc48efe2921e6913c68694be0617d190a40","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tchaikov","id":59071,"avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":850326757,"url":"https://api.github.com/repos/ceph/ceph/labels/dashboard","name":"dashboard","color":"68a2c1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/20943/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/20943/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/20943/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/79b079fdeeb32e84c11ccd76a56429d63184fd45","head":{"label":"tspmelo:fix-e2e","ref":"fix-e2e","sha":"79b079fdeeb32e84c11ccd76a56429d63184fd45","user":{"login":"tspmelo","id":399326,"avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},"repo":{"id":116847827,"name":"ceph","full_name":"tspmelo/ceph","owner":{"login":"tspmelo","id":399326,"avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tspmelo/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/tspmelo/ceph","forks_url":"https://api.github.com/repos/tspmelo/ceph/forks","keys_url":"https://api.github.com/repos/tspmelo/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tspmelo/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tspmelo/ceph/teams","hooks_url":"https://api.github.com/repos/tspmelo/ceph/hooks","issue_events_url":"https://api.github.com/repos/tspmelo/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/tspmelo/ceph/events","assignees_url":"https://api.github.com/repos/tspmelo/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/tspmelo/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/tspmelo/ceph/tags","blobs_url":"https://api.github.com/repos/tspmelo/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tspmelo/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tspmelo/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/tspmelo/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tspmelo/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/tspmelo/ceph/languages","stargazers_url":"https://api.github.com/repos/tspmelo/ceph/stargazers","contributors_url":"https://api.github.com/repos/tspmelo/ceph/contributors","subscribers_url":"https://api.github.com/repos/tspmelo/ceph/subscribers","subscription_url":"https://api.github.com/repos/tspmelo/ceph/subscription","commits_url":"https://api.github.com/repos/tspmelo/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/tspmelo/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/tspmelo/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/tspmelo/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/tspmelo/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/tspmelo/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tspmelo/ceph/merges","archive_url":"https://api.github.com/repos/tspmelo/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tspmelo/ceph/downloads","issues_url":"https://api.github.com/repos/tspmelo/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/tspmelo/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/tspmelo/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/tspmelo/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tspmelo/ceph/labels{/name}","releases_url":"https://api.github.com/repos/tspmelo/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/tspmelo/ceph/deployments","created_at":"2018-01-09T17:26:17Z","updated_at":"2018-01-09T17:26:38Z","pushed_at":"2018-03-23T00:33:13Z","git_url":"git://github.com/tspmelo/ceph.git","ssh_url":"git@github.com:tspmelo/ceph.git","clone_url":"https://github.com/tspmelo/ceph.git","svn_url":"https://github.com/tspmelo/ceph","homepage":"http://ceph.com","size":272371,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"44f16c903a88bd02cdf27100eaeb47dd67a1d802","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-03-22T16:28:45Z","pushed_at":"2018-03-23T00:33:17Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":274413,"stargazers_count":4241,"watchers_count":4241,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2360,"mirror_url":null,"archived":false,"open_issues_count":712,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2360,"open_issues":712,"watchers":4241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20943"},"html":{"href":"https://github.com/ceph/ceph/pull/20943"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/20943"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/20943/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20943/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20943/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/79b079fdeeb32e84c11ccd76a56429d63184fd45"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tspmelo"}}