{"action":"closed","number":109,"pull_request":{"url":"https://api.github.com/repos/pull-stream/pull-stream/pulls/109","id":176300717,"html_url":"https://github.com/pull-stream/pull-stream/pull/109","diff_url":"https://github.com/pull-stream/pull-stream/pull/109.diff","patch_url":"https://github.com/pull-stream/pull-stream/pull/109.patch","issue_url":"https://api.github.com/repos/pull-stream/pull-stream/issues/109","number":109,"state":"closed","locked":false,"title":"take should pass error on last read","user":{"login":"ruifortes","id":4864714,"avatar_url":"https://avatars2.githubusercontent.com/u/4864714?v=4","gravatar_id":"","url":"https://api.github.com/users/ruifortes","html_url":"https://github.com/ruifortes","followers_url":"https://api.github.com/users/ruifortes/followers","following_url":"https://api.github.com/users/ruifortes/following{/other_user}","gists_url":"https://api.github.com/users/ruifortes/gists{/gist_id}","starred_url":"https://api.github.com/users/ruifortes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruifortes/subscriptions","organizations_url":"https://api.github.com/users/ruifortes/orgs","repos_url":"https://api.github.com/users/ruifortes/repos","events_url":"https://api.github.com/users/ruifortes/events{/privacy}","received_events_url":"https://api.github.com/users/ruifortes/received_events","type":"User","site_admin":false},"body":"Hi\r\n\"take\" should pass error on last read shouldn't it?\r\nCurrently sink doesn't get the error thrown in \"asyncMap\" although strangelly \"map\" works\r\n\r\n```\r\n  pull(\r\n    pull.values([1,2,3,4,5,6,7,8,9,10]),\r\n    pull.take(function(n) {return n<5}, {last: true}),\r\n    // pull.take(5),\r\n    pull.asyncMap((data, cb) => {\r\n      setTimeout(() => {\r\n        if(++i < 5) cb(null, data)\r\n        else cb(error)\r\n      }, 100)  \r\n    }),\r\n    pull.collect(function (err, five) {\r\n      // *** currently err is null ******\r\n      t.equal(err, error, 'should return err')\r\n      t.deepEqual(five, [1,2,3,4], 'should skip failed item')\r\n      t.end()\r\n    })\r\n  )\r\n```","created_at":"2018-03-20T19:38:17Z","updated_at":"2018-03-27T20:00:12Z","closed_at":"2018-03-27T20:00:12Z","merged_at":"2018-03-27T20:00:12Z","merge_commit_sha":"744a32f088257090b77a81f895a62305118a7934","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pull-stream/pull-stream/pulls/109/commits","review_comments_url":"https://api.github.com/repos/pull-stream/pull-stream/pulls/109/comments","review_comment_url":"https://api.github.com/repos/pull-stream/pull-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pull-stream/pull-stream/issues/109/comments","statuses_url":"https://api.github.com/repos/pull-stream/pull-stream/statuses/744a32f088257090b77a81f895a62305118a7934","head":{"label":"ruifortes:master","ref":"master","sha":"744a32f088257090b77a81f895a62305118a7934","user":{"login":"ruifortes","id":4864714,"avatar_url":"https://avatars2.githubusercontent.com/u/4864714?v=4","gravatar_id":"","url":"https://api.github.com/users/ruifortes","html_url":"https://github.com/ruifortes","followers_url":"https://api.github.com/users/ruifortes/followers","following_url":"https://api.github.com/users/ruifortes/following{/other_user}","gists_url":"https://api.github.com/users/ruifortes/gists{/gist_id}","starred_url":"https://api.github.com/users/ruifortes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruifortes/subscriptions","organizations_url":"https://api.github.com/users/ruifortes/orgs","repos_url":"https://api.github.com/users/ruifortes/repos","events_url":"https://api.github.com/users/ruifortes/events{/privacy}","received_events_url":"https://api.github.com/users/ruifortes/received_events","type":"User","site_admin":false},"repo":{"id":113489172,"name":"pull-stream","full_name":"ruifortes/pull-stream","owner":{"login":"ruifortes","id":4864714,"avatar_url":"https://avatars2.githubusercontent.com/u/4864714?v=4","gravatar_id":"","url":"https://api.github.com/users/ruifortes","html_url":"https://github.com/ruifortes","followers_url":"https://api.github.com/users/ruifortes/followers","following_url":"https://api.github.com/users/ruifortes/following{/other_user}","gists_url":"https://api.github.com/users/ruifortes/gists{/gist_id}","starred_url":"https://api.github.com/users/ruifortes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruifortes/subscriptions","organizations_url":"https://api.github.com/users/ruifortes/orgs","repos_url":"https://api.github.com/users/ruifortes/repos","events_url":"https://api.github.com/users/ruifortes/events{/privacy}","received_events_url":"https://api.github.com/users/ruifortes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ruifortes/pull-stream","description":"minimal streams","fork":true,"url":"https://api.github.com/repos/ruifortes/pull-stream","forks_url":"https://api.github.com/repos/ruifortes/pull-stream/forks","keys_url":"https://api.github.com/repos/ruifortes/pull-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruifortes/pull-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruifortes/pull-stream/teams","hooks_url":"https://api.github.com/repos/ruifortes/pull-stream/hooks","issue_events_url":"https://api.github.com/repos/ruifortes/pull-stream/issues/events{/number}","events_url":"https://api.github.com/repos/ruifortes/pull-stream/events","assignees_url":"https://api.github.com/repos/ruifortes/pull-stream/assignees{/user}","branches_url":"https://api.github.com/repos/ruifortes/pull-stream/branches{/branch}","tags_url":"https://api.github.com/repos/ruifortes/pull-stream/tags","blobs_url":"https://api.github.com/repos/ruifortes/pull-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruifortes/pull-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruifortes/pull-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruifortes/pull-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruifortes/pull-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/ruifortes/pull-stream/languages","stargazers_url":"https://api.github.com/repos/ruifortes/pull-stream/stargazers","contributors_url":"https://api.github.com/repos/ruifortes/pull-stream/contributors","subscribers_url":"https://api.github.com/repos/ruifortes/pull-stream/subscribers","subscription_url":"https://api.github.com/repos/ruifortes/pull-stream/subscription","commits_url":"https://api.github.com/repos/ruifortes/pull-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruifortes/pull-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruifortes/pull-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruifortes/pull-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruifortes/pull-stream/contents/{+path}","compare_url":"https://api.github.com/repos/ruifortes/pull-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruifortes/pull-stream/merges","archive_url":"https://api.github.com/repos/ruifortes/pull-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruifortes/pull-stream/downloads","issues_url":"https://api.github.com/repos/ruifortes/pull-stream/issues{/number}","pulls_url":"https://api.github.com/repos/ruifortes/pull-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/ruifortes/pull-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/ruifortes/pull-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruifortes/pull-stream/labels{/name}","releases_url":"https://api.github.com/repos/ruifortes/pull-stream/releases{/id}","deployments_url":"https://api.github.com/repos/ruifortes/pull-stream/deployments","created_at":"2017-12-07T19:16:53Z","updated_at":"2018-03-20T19:15:31Z","pushed_at":"2018-03-20T19:15:30Z","git_url":"git://github.com/ruifortes/pull-stream.git","ssh_url":"git@github.com:ruifortes/pull-stream.git","clone_url":"https://github.com/ruifortes/pull-stream.git","svn_url":"https://github.com/ruifortes/pull-stream","homepage":"https://pull-stream.github.io/","size":217,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pull-stream:master","ref":"master","sha":"f36f573a08e0cea7121c24a9b3466616a0f94484","user":{"login":"pull-stream","id":19355812,"avatar_url":"https://avatars0.githubusercontent.com/u/19355812?v=4","gravatar_id":"","url":"https://api.github.com/users/pull-stream","html_url":"https://github.com/pull-stream","followers_url":"https://api.github.com/users/pull-stream/followers","following_url":"https://api.github.com/users/pull-stream/following{/other_user}","gists_url":"https://api.github.com/users/pull-stream/gists{/gist_id}","starred_url":"https://api.github.com/users/pull-stream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pull-stream/subscriptions","organizations_url":"https://api.github.com/users/pull-stream/orgs","repos_url":"https://api.github.com/users/pull-stream/repos","events_url":"https://api.github.com/users/pull-stream/events{/privacy}","received_events_url":"https://api.github.com/users/pull-stream/received_events","type":"Organization","site_admin":false},"repo":{"id":8946748,"name":"pull-stream","full_name":"pull-stream/pull-stream","owner":{"login":"pull-stream","id":19355812,"avatar_url":"https://avatars0.githubusercontent.com/u/19355812?v=4","gravatar_id":"","url":"https://api.github.com/users/pull-stream","html_url":"https://github.com/pull-stream","followers_url":"https://api.github.com/users/pull-stream/followers","following_url":"https://api.github.com/users/pull-stream/following{/other_user}","gists_url":"https://api.github.com/users/pull-stream/gists{/gist_id}","starred_url":"https://api.github.com/users/pull-stream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pull-stream/subscriptions","organizations_url":"https://api.github.com/users/pull-stream/orgs","repos_url":"https://api.github.com/users/pull-stream/repos","events_url":"https://api.github.com/users/pull-stream/events{/privacy}","received_events_url":"https://api.github.com/users/pull-stream/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pull-stream/pull-stream","description":"minimal streams","fork":false,"url":"https://api.github.com/repos/pull-stream/pull-stream","forks_url":"https://api.github.com/repos/pull-stream/pull-stream/forks","keys_url":"https://api.github.com/repos/pull-stream/pull-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pull-stream/pull-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pull-stream/pull-stream/teams","hooks_url":"https://api.github.com/repos/pull-stream/pull-stream/hooks","issue_events_url":"https://api.github.com/repos/pull-stream/pull-stream/issues/events{/number}","events_url":"https://api.github.com/repos/pull-stream/pull-stream/events","assignees_url":"https://api.github.com/repos/pull-stream/pull-stream/assignees{/user}","branches_url":"https://api.github.com/repos/pull-stream/pull-stream/branches{/branch}","tags_url":"https://api.github.com/repos/pull-stream/pull-stream/tags","blobs_url":"https://api.github.com/repos/pull-stream/pull-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pull-stream/pull-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pull-stream/pull-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/pull-stream/pull-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pull-stream/pull-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/pull-stream/pull-stream/languages","stargazers_url":"https://api.github.com/repos/pull-stream/pull-stream/stargazers","contributors_url":"https://api.github.com/repos/pull-stream/pull-stream/contributors","subscribers_url":"https://api.github.com/repos/pull-stream/pull-stream/subscribers","subscription_url":"https://api.github.com/repos/pull-stream/pull-stream/subscription","commits_url":"https://api.github.com/repos/pull-stream/pull-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/pull-stream/pull-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/pull-stream/pull-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/pull-stream/pull-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/pull-stream/pull-stream/contents/{+path}","compare_url":"https://api.github.com/repos/pull-stream/pull-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pull-stream/pull-stream/merges","archive_url":"https://api.github.com/repos/pull-stream/pull-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pull-stream/pull-stream/downloads","issues_url":"https://api.github.com/repos/pull-stream/pull-stream/issues{/number}","pulls_url":"https://api.github.com/repos/pull-stream/pull-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/pull-stream/pull-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/pull-stream/pull-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pull-stream/pull-stream/labels{/name}","releases_url":"https://api.github.com/repos/pull-stream/pull-stream/releases{/id}","deployments_url":"https://api.github.com/repos/pull-stream/pull-stream/deployments","created_at":"2013-03-22T07:09:12Z","updated_at":"2018-03-22T05:33:07Z","pushed_at":"2018-03-27T20:00:10Z","git_url":"git://github.com/pull-stream/pull-stream.git","ssh_url":"git@github.com:pull-stream/pull-stream.git","clone_url":"https://github.com/pull-stream/pull-stream.git","svn_url":"https://github.com/pull-stream/pull-stream","homepage":"https://pull-stream.github.io/","size":219,"stargazers_count":537,"watchers_count":537,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":46,"open_issues":26,"watchers":537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pull-stream/pull-stream/pulls/109"},"html":{"href":"https://github.com/pull-stream/pull-stream/pull/109"},"issue":{"href":"https://api.github.com/repos/pull-stream/pull-stream/issues/109"},"comments":{"href":"https://api.github.com/repos/pull-stream/pull-stream/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/pull-stream/pull-stream/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/pull-stream/pull-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pull-stream/pull-stream/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/pull-stream/pull-stream/statuses/744a32f088257090b77a81f895a62305118a7934"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dominictarr","id":259374,"avatar_url":"https://avatars3.githubusercontent.com/u/259374?v=4","gravatar_id":"","url":"https://api.github.com/users/dominictarr","html_url":"https://github.com/dominictarr","followers_url":"https://api.github.com/users/dominictarr/followers","following_url":"https://api.github.com/users/dominictarr/following{/other_user}","gists_url":"https://api.github.com/users/dominictarr/gists{/gist_id}","starred_url":"https://api.github.com/users/dominictarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominictarr/subscriptions","organizations_url":"https://api.github.com/users/dominictarr/orgs","repos_url":"https://api.github.com/users/dominictarr/repos","events_url":"https://api.github.com/users/dominictarr/events{/privacy}","received_events_url":"https://api.github.com/users/dominictarr/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"dominictarr"}}