{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/203629973","pull_request_review_id":138555740,"id":203629973,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzYyOTk3Mw==","diff_hunk":"@@ -409,6 +409,7 @@ var defaultKubernetesFeatureGates = map[utilfeature.Feature]utilfeature.FeatureS\n \tgenericfeatures.APIResponseCompression:  {Default: false, PreRelease: utilfeature.Alpha},\n \tgenericfeatures.Initializers:            {Default: false, PreRelease: utilfeature.Alpha},\n \tgenericfeatures.APIListChunking:         {Default: true, PreRelease: utilfeature.Beta},\n+\tgenericfeatures.DryRun:                  {Default: false, PreRelease: utilfeature.Alpha},","path":"pkg/features/kube_features.go","position":4,"original_position":4,"commit_id":"5357d2610d87a51066ad41b2bfe26b5ec3709cae","original_commit_id":"5357d2610d87a51066ad41b2bfe26b5ec3709cae","user":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"We have it at two places intentionally. But there is code to detect when it diverges.\r\n\r\nThe reason to have all of them here is to have an overview over all existing feature flags.\r\n\r\nI would not worry about this for the moment. We are going to refactor this structure to avoid leakage of the gates into other, unintended components. But we don't have to solve this here.","created_at":"2018-07-19T07:46:52Z","updated_at":"2018-07-19T07:46:52Z","html_url":"https://github.com/kubernetes/kubernetes/pull/65558#discussion_r203629973","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65558","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/203629973"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/65558#discussion_r203629973"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65558"}},"in_reply_to_id":203368311},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65558","id":197883572,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODgzNTcy","html_url":"https://github.com/kubernetes/kubernetes/pull/65558","diff_url":"https://github.com/kubernetes/kubernetes/pull/65558.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/65558.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65558","number":65558,"state":"open","locked":false,"title":"dry-run: Create feature-gate flag","user":{"login":"apelisse","id":1929644,"node_id":"MDQ6VXNlcjE5Mjk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},"body":"Creates a feature gate flag for dry-run. Currently, dry-run query parameter is completely blocking all requests, once the feature is implemented, the flag will allow the parameter to pass if enabled.\r\n\r\ncc @jennybuckley @deads2k @liggitt @lavalamp \r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-06-27T23:55:22Z","updated_at":"2018-07-19T07:46:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7639fb0197242e0fd9dc1a4fc211b87b953a1a1","assignee":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"caesarxuchao","id":2823529,"node_id":"MDQ6VXNlcjI4MjM1Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2823529?v=4","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},{"login":"brendandburns","id":5751682,"node_id":"MDQ6VXNlcjU3NTE2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65558/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65558/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65558/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5357d2610d87a51066ad41b2bfe26b5ec3709cae","head":{"label":"apelisse:dry-run-feature-gate","ref":"dry-run-feature-gate","sha":"5357d2610d87a51066ad41b2bfe26b5ec3709cae","user":{"login":"apelisse","id":1929644,"node_id":"MDQ6VXNlcjE5Mjk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},"repo":{"id":63436806,"node_id":"MDEwOlJlcG9zaXRvcnk2MzQzNjgwNg==","name":"kubernetes","full_name":"apelisse/kubernetes","owner":{"login":"apelisse","id":1929644,"node_id":"MDQ6VXNlcjE5Mjk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apelisse/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/apelisse/kubernetes","forks_url":"https://api.github.com/repos/apelisse/kubernetes/forks","keys_url":"https://api.github.com/repos/apelisse/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apelisse/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apelisse/kubernetes/teams","hooks_url":"https://api.github.com/repos/apelisse/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/apelisse/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/apelisse/kubernetes/events","assignees_url":"https://api.github.com/repos/apelisse/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/apelisse/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/apelisse/kubernetes/tags","blobs_url":"https://api.github.com/repos/apelisse/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apelisse/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apelisse/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/apelisse/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apelisse/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/apelisse/kubernetes/languages","stargazers_url":"https://api.github.com/repos/apelisse/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/apelisse/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/apelisse/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/apelisse/kubernetes/subscription","commits_url":"https://api.github.com/repos/apelisse/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/apelisse/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/apelisse/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/apelisse/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/apelisse/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/apelisse/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apelisse/kubernetes/merges","archive_url":"https://api.github.com/repos/apelisse/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apelisse/kubernetes/downloads","issues_url":"https://api.github.com/repos/apelisse/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/apelisse/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/apelisse/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/apelisse/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apelisse/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/apelisse/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/apelisse/kubernetes/deployments","created_at":"2016-07-15T16:43:21Z","updated_at":"2016-07-15T16:43:39Z","pushed_at":"2018-07-17T23:46:24Z","git_url":"git://github.com/apelisse/kubernetes.git","ssh_url":"git@github.com:apelisse/kubernetes.git","clone_url":"https://github.com/apelisse/kubernetes.git","svn_url":"https://github.com/apelisse/kubernetes","homepage":"http://kubernetes.io","size":559402,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"1a538daf44135edccdc927781adc98a301a7b08d","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-07-19T07:43:04Z","pushed_at":"2018-07-19T06:59:52Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":794002,"stargazers_count":38888,"watchers_count":38888,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13593,"mirror_url":null,"archived":false,"open_issues_count":3107,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13593,"open_issues":3107,"watchers":38888,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65558"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/65558"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/65558"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/65558/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65558/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65558/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5357d2610d87a51066ad41b2bfe26b5ec3709cae"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sttts"}}