{"action":"created","comment":{"url":"https://api.github.com/repos/mono/corefx/pulls/comments/215974392","pull_request_review_id":153361645,"id":215974392,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTk3NDM5Mg==","diff_hunk":"@@ -27,6 +27,7 @@ internal LightDelegateCreator(Interpreter interpreter, LambdaExpression lambda)\n \n         public Delegate CreateDelegate() => CreateDelegate(closure: null);\n \n+        [PreserveDependency(\"System.Linq.Expressions.Interpreter.LightLambda\")]","path":"src/System.Linq.Expressions/src/System/Linq/Expressions/Interpreter/LightDelegateCreator.cs","position":null,"original_position":4,"commit_id":"8123cd46aa216c0ba0e9f7d8594f94433aee41bd","original_commit_id":"b12b8e25e4764046066b25ffb6aa27f1bb0bb1b6","user":{"login":"joshpeterson","id":123220,"node_id":"MDQ6VXNlcjEyMzIyMA==","avatar_url":"https://avatars2.githubusercontent.com/u/123220?v=4","gravatar_id":"","url":"https://api.github.com/users/joshpeterson","html_url":"https://github.com/joshpeterson","followers_url":"https://api.github.com/users/joshpeterson/followers","following_url":"https://api.github.com/users/joshpeterson/following{/other_user}","gists_url":"https://api.github.com/users/joshpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/joshpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshpeterson/subscriptions","organizations_url":"https://api.github.com/users/joshpeterson/orgs","repos_url":"https://api.github.com/users/joshpeterson/repos","events_url":"https://api.github.com/users/joshpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/joshpeterson/received_events","type":"User","site_admin":false},"body":"I've force pushed a new new changeset that add the attributes for each method to the `MakeRunDelegateCtor` method as you suggested.","created_at":"2018-09-07T14:19:25Z","updated_at":"2018-09-07T14:19:25Z","html_url":"https://github.com/mono/corefx/pull/132#discussion_r215974392","pull_request_url":"https://api.github.com/repos/mono/corefx/pulls/132","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mono/corefx/pulls/comments/215974392"},"html":{"href":"https://github.com/mono/corefx/pull/132#discussion_r215974392"},"pull_request":{"href":"https://api.github.com/repos/mono/corefx/pulls/132"}},"in_reply_to_id":215576934},"pull_request":{"url":"https://api.github.com/repos/mono/corefx/pulls/132","id":213400930,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDAwOTMw","html_url":"https://github.com/mono/corefx/pull/132","diff_url":"https://github.com/mono/corefx/pull/132.diff","patch_url":"https://github.com/mono/corefx/pull/132.patch","issue_url":"https://api.github.com/repos/mono/corefx/issues/132","number":132,"state":"open","locked":false,"title":"Preserve LightLambda from linking","user":{"login":"joshpeterson","id":123220,"node_id":"MDQ6VXNlcjEyMzIyMA==","avatar_url":"https://avatars2.githubusercontent.com/u/123220?v=4","gravatar_id":"","url":"https://api.github.com/users/joshpeterson","html_url":"https://github.com/joshpeterson","followers_url":"https://api.github.com/users/joshpeterson/followers","following_url":"https://api.github.com/users/joshpeterson/following{/other_user}","gists_url":"https://api.github.com/users/joshpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/joshpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshpeterson/subscriptions","organizations_url":"https://api.github.com/users/joshpeterson/orgs","repos_url":"https://api.github.com/users/joshpeterson/repos","events_url":"https://api.github.com/users/joshpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/joshpeterson/received_events","type":"User","site_admin":false},"body":"When `CreateDelegate` is used, we need to keep `LightLambda` as well,\r\nsince `CreateDelegate` implicitly depends on `LightLambda`. This change\r\nexpresses that dependency to the managed code linker.","created_at":"2018-09-05T19:21:23Z","updated_at":"2018-09-07T14:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43eb7db36235a3b36988bb1cbbd99679148ea1c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/corefx/pulls/132/commits","review_comments_url":"https://api.github.com/repos/mono/corefx/pulls/132/comments","review_comment_url":"https://api.github.com/repos/mono/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/corefx/issues/132/comments","statuses_url":"https://api.github.com/repos/mono/corefx/statuses/8123cd46aa216c0ba0e9f7d8594f94433aee41bd","head":{"label":"Unity-Technologies:preserve-dependency-of-linq-interpreter","ref":"preserve-dependency-of-linq-interpreter","sha":"8123cd46aa216c0ba0e9f7d8594f94433aee41bd","user":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":147567851,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1Njc4NTE=","name":"corefx","full_name":"Unity-Technologies/corefx","owner":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/Unity-Technologies/corefx","forks_url":"https://api.github.com/repos/Unity-Technologies/corefx/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/corefx/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/corefx/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/corefx/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/corefx/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/corefx/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/corefx/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/corefx/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/corefx/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/corefx/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/corefx/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/corefx/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/corefx/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/corefx/deployments","created_at":"2018-09-05T19:16:12Z","updated_at":"2018-09-06T21:25:27Z","pushed_at":"2018-09-07T14:18:26Z","git_url":"git://github.com/Unity-Technologies/corefx.git","ssh_url":"git@github.com:Unity-Technologies/corefx.git","clone_url":"https://github.com/Unity-Technologies/corefx.git","svn_url":"https://github.com/Unity-Technologies/corefx","homepage":"","size":171616,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"1011665e56d38aa482c2d596db40809f5e40064d","user":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":26547395,"node_id":"MDEwOlJlcG9zaXRvcnkyNjU0NzM5NQ==","name":"corefx","full_name":"mono/corefx","owner":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/mono/corefx","forks_url":"https://api.github.com/repos/mono/corefx/forks","keys_url":"https://api.github.com/repos/mono/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/corefx/teams","hooks_url":"https://api.github.com/repos/mono/corefx/hooks","issue_events_url":"https://api.github.com/repos/mono/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/mono/corefx/events","assignees_url":"https://api.github.com/repos/mono/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/mono/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/mono/corefx/tags","blobs_url":"https://api.github.com/repos/mono/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/corefx/languages","stargazers_url":"https://api.github.com/repos/mono/corefx/stargazers","contributors_url":"https://api.github.com/repos/mono/corefx/contributors","subscribers_url":"https://api.github.com/repos/mono/corefx/subscribers","subscription_url":"https://api.github.com/repos/mono/corefx/subscription","commits_url":"https://api.github.com/repos/mono/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/mono/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/corefx/merges","archive_url":"https://api.github.com/repos/mono/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/corefx/downloads","issues_url":"https://api.github.com/repos/mono/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/mono/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/corefx/labels{/name}","releases_url":"https://api.github.com/repos/mono/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/mono/corefx/deployments","created_at":"2014-11-12T17:26:25Z","updated_at":"2018-09-05T07:01:29Z","pushed_at":"2018-09-07T14:18:33Z","git_url":"git://github.com/mono/corefx.git","ssh_url":"git@github.com:mono/corefx.git","clone_url":"https://github.com/mono/corefx.git","svn_url":"https://github.com/mono/corefx","homepage":"","size":171616,"stargazers_count":6,"watchers_count":6,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/corefx/pulls/132"},"html":{"href":"https://github.com/mono/corefx/pull/132"},"issue":{"href":"https://api.github.com/repos/mono/corefx/issues/132"},"comments":{"href":"https://api.github.com/repos/mono/corefx/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/corefx/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/corefx/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/mono/corefx/statuses/8123cd46aa216c0ba0e9f7d8594f94433aee41bd"}},"author_association":"NONE"}}
{"actor":{"display_login":"joshpeterson"}}