{"action":"created","issue":{"url":"https://api.github.com/repos/tgriesser/knex/issues/2339","repository_url":"https://api.github.com/repos/tgriesser/knex","labels_url":"https://api.github.com/repos/tgriesser/knex/issues/2339/labels{/name}","comments_url":"https://api.github.com/repos/tgriesser/knex/issues/2339/comments","events_url":"https://api.github.com/repos/tgriesser/knex/issues/2339/events","html_url":"https://github.com/tgriesser/knex/issues/2339","id":275079738,"number":2339,"title":"Lets use Tarn.js as a pool instead of generic-pool","user":{"login":"elhigu","id":696345,"avatar_url":"https://avatars3.githubusercontent.com/u/696345?v=4","gravatar_id":"","url":"https://api.github.com/users/elhigu","html_url":"https://github.com/elhigu","followers_url":"https://api.github.com/users/elhigu/followers","following_url":"https://api.github.com/users/elhigu/following{/other_user}","gists_url":"https://api.github.com/users/elhigu/gists{/gist_id}","starred_url":"https://api.github.com/users/elhigu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elhigu/subscriptions","organizations_url":"https://api.github.com/users/elhigu/orgs","repos_url":"https://api.github.com/users/elhigu/repos","events_url":"https://api.github.com/users/elhigu/events{/privacy}","received_events_url":"https://api.github.com/users/elhigu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-11-18T13:33:21Z","updated_at":"2018-02-16T01:39:50Z","closed_at":"2018-02-07T09:17:56Z","author_association":"COLLABORATOR","body":"# Environment\r\n\r\nKnex version: > 0.8\r\nDatabase + version: all\r\nOS: all\r\n\r\n# Feature discussion / request\r\n\r\nKnex uses currently `generic-pool`, which has been source of multiple problems and it is not very actively maintained (author is not replying to issues / pull requests). I opened this issue, after I noticed that the `testOnBorrow` feature, which is needed by `knex` didn't have any tests (had one that was just commented out).\r\n\r\nAlso the `generic-pool` is lacking tests, which means we cannot trust that it works correctly when it is updated. For example `testOnBorrow` feature which should be used to prevent returning dead connections (e.g. closed by database)\r\n\r\nI would like to open up discussion https://github.com/tgriesser/knex/pull/1702 again about using own pool component  [Tarn.js](https://github.com/Vincit/tarn.js), which we can update / fix when ever there is need and whose API can be extended to support `knex` usage so that we don't need to write work arounds to support `generic-pool`.\r\n\r\nSome related issues: \r\nhttps://github.com/tgriesser/knex/issues/2321\r\nhttps://github.com/tgriesser/knex/issues/1833\r\nhttps://github.com/tgriesser/knex/issues/2325\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/tgriesser/knex/issues/comments/366120725","html_url":"https://github.com/tgriesser/knex/issues/2339#issuecomment-366120725","issue_url":"https://api.github.com/repos/tgriesser/knex/issues/2339","id":366120725,"user":{"login":"LewisJEllis","id":1445984,"avatar_url":"https://avatars3.githubusercontent.com/u/1445984?v=4","gravatar_id":"","url":"https://api.github.com/users/LewisJEllis","html_url":"https://github.com/LewisJEllis","followers_url":"https://api.github.com/users/LewisJEllis/followers","following_url":"https://api.github.com/users/LewisJEllis/following{/other_user}","gists_url":"https://api.github.com/users/LewisJEllis/gists{/gist_id}","starred_url":"https://api.github.com/users/LewisJEllis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LewisJEllis/subscriptions","organizations_url":"https://api.github.com/users/LewisJEllis/orgs","repos_url":"https://api.github.com/users/LewisJEllis/repos","events_url":"https://api.github.com/users/LewisJEllis/events{/privacy}","received_events_url":"https://api.github.com/users/LewisJEllis/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T01:39:50Z","updated_at":"2018-02-16T01:39:50Z","author_association":"NONE","body":"> Maybe it would be worth looking how pooling is done in sequelize if they are using driver builtin pools?\r\n\r\nThey don't, they do their own generic-pool-based connection pool on top of the drivers."}}
{"actor":{"display_login":"LewisJEllis"}}