{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/210","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/210/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/210/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/210/events","html_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/210","id":298409328,"number":210,"title":"Allow users to choose public or private IP when provisioning multiple VMs","user":{"login":"djberg96","id":78529,"avatar_url":"https://avatars3.githubusercontent.com/u/78529?v=4","gravatar_id":"","url":"https://api.github.com/users/djberg96","html_url":"https://github.com/djberg96","followers_url":"https://api.github.com/users/djberg96/followers","following_url":"https://api.github.com/users/djberg96/following{/other_user}","gists_url":"https://api.github.com/users/djberg96/gists{/gist_id}","starred_url":"https://api.github.com/users/djberg96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djberg96/subscriptions","organizations_url":"https://api.github.com/users/djberg96/orgs","repos_url":"https://api.github.com/users/djberg96/repos","events_url":"https://api.github.com/users/djberg96/events{/privacy}","received_events_url":"https://api.github.com/users/djberg96/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-19T21:46:15Z","updated_at":"2018-02-22T23:23:21Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/210","html_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/210","diff_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/210.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/210.patch"},"body":"When we introduced https://github.com/ManageIQ/manageiq-providers-azure/pull/172, we defaulted to a private IP for provisioning a single VM. This had the unintended side effect of making multi-vm provisioning private by default, with no way for the user to choose.\r\n\r\nThis PR addresses that by giving the users two choices - new or none - when selecting an IP during the provisioning process for multiple vm's.\r\n\r\nRather than making specialized PR's based on provider on the UI side, this PR uses custom service subclasses that allow us to govern the UI behavior without modifying any core code.\r\n\r\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=1531275\r\n\r\nI have sanity checked this by provisioning two VM's with \"none\" selected, and two with \"new\" selected. The app behaved as expected, i.e. the vm's with \"none\" selected did not have a public IP attached, while those with \"new\" selected did.\r\n\r\n~~WIP for now until I get some specs added.~~"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/comments/367857312","html_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/210#issuecomment-367857312","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/210","id":367857312,"user":{"login":"bronaghs","id":4379675,"avatar_url":"https://avatars2.githubusercontent.com/u/4379675?v=4","gravatar_id":"","url":"https://api.github.com/users/bronaghs","html_url":"https://github.com/bronaghs","followers_url":"https://api.github.com/users/bronaghs/followers","following_url":"https://api.github.com/users/bronaghs/following{/other_user}","gists_url":"https://api.github.com/users/bronaghs/gists{/gist_id}","starred_url":"https://api.github.com/users/bronaghs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bronaghs/subscriptions","organizations_url":"https://api.github.com/users/bronaghs/orgs","repos_url":"https://api.github.com/users/bronaghs/repos","events_url":"https://api.github.com/users/bronaghs/events{/privacy}","received_events_url":"https://api.github.com/users/bronaghs/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T23:23:21Z","updated_at":"2018-02-22T23:23:21Z","author_association":"COLLABORATOR","body":"Ok, let’s see if we can get the UI PR merged promptly."}}
{"actor":{"display_login":"bronaghs"}}