{"action":"created","comment":{"url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/comments/244955092","pull_request_review_id":188954942,"id":244955092,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk1NTA5Mg==","diff_hunk":"@@ -60,6 +60,11 @@ variable \"ecs_log_level\" {\n   default     = \"info\"\n }\n \n+variable \"retention_in_days\" {\n+  description = \"Log retention given in days.\"\n+  default     = \"0\"","path":"modules/cluster/variables.tf","position":6,"original_position":6,"commit_id":"3a95b1fe09139e4782364864833c32056e555c62","original_commit_id":"390fef61c0427197ba68056b9f137c3bd8a47afe","user":{"login":"itsdalmo","id":6603877,"node_id":"MDQ6VXNlcjY2MDM4Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/6603877?v=4","gravatar_id":"","url":"https://api.github.com/users/itsdalmo","html_url":"https://github.com/itsdalmo","followers_url":"https://api.github.com/users/itsdalmo/followers","following_url":"https://api.github.com/users/itsdalmo/following{/other_user}","gists_url":"https://api.github.com/users/itsdalmo/gists{/gist_id}","starred_url":"https://api.github.com/users/itsdalmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsdalmo/subscriptions","organizations_url":"https://api.github.com/users/itsdalmo/orgs","repos_url":"https://api.github.com/users/itsdalmo/repos","events_url":"https://api.github.com/users/itsdalmo/events{/privacy}","received_events_url":"https://api.github.com/users/itsdalmo/received_events","type":"User","site_admin":false},"body":"Thanks!","created_at":"2019-01-03T10:14:32Z","updated_at":"2019-01-03T10:14:32Z","html_url":"https://github.com/telia-oss/terraform-aws-ecs/pull/24#discussion_r244955092","pull_request_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/24","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/comments/244955092"},"html":{"href":"https://github.com/telia-oss/terraform-aws-ecs/pull/24#discussion_r244955092"},"pull_request":{"href":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/24"}},"in_reply_to_id":244952060},"pull_request":{"url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/24","id":241772543,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNzcyNTQz","html_url":"https://github.com/telia-oss/terraform-aws-ecs/pull/24","diff_url":"https://github.com/telia-oss/terraform-aws-ecs/pull/24.diff","patch_url":"https://github.com/telia-oss/terraform-aws-ecs/pull/24.patch","issue_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/issues/24","number":24,"state":"open","locked":false,"title":"Add retention to log group","user":{"login":"lukaspour","id":8102576,"node_id":"MDQ6VXNlcjgxMDI1NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8102576?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaspour","html_url":"https://github.com/lukaspour","followers_url":"https://api.github.com/users/lukaspour/followers","following_url":"https://api.github.com/users/lukaspour/following{/other_user}","gists_url":"https://api.github.com/users/lukaspour/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaspour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaspour/subscriptions","organizations_url":"https://api.github.com/users/lukaspour/orgs","repos_url":"https://api.github.com/users/lukaspour/repos","events_url":"https://api.github.com/users/lukaspour/events{/privacy}","received_events_url":"https://api.github.com/users/lukaspour/received_events","type":"User","site_admin":false},"body":"By default zero should be infinity. We would like to customize this variable, that's why this PR.","created_at":"2019-01-02T15:21:38Z","updated_at":"2019-01-03T10:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b30fea9e96d15b522c3b1fdcf57b966ef2c47ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/24/commits","review_comments_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/24/comments","review_comment_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/issues/24/comments","statuses_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/statuses/3a95b1fe09139e4782364864833c32056e555c62","head":{"label":"lukaspour:master","ref":"master","sha":"3a95b1fe09139e4782364864833c32056e555c62","user":{"login":"lukaspour","id":8102576,"node_id":"MDQ6VXNlcjgxMDI1NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8102576?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaspour","html_url":"https://github.com/lukaspour","followers_url":"https://api.github.com/users/lukaspour/followers","following_url":"https://api.github.com/users/lukaspour/following{/other_user}","gists_url":"https://api.github.com/users/lukaspour/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaspour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaspour/subscriptions","organizations_url":"https://api.github.com/users/lukaspour/orgs","repos_url":"https://api.github.com/users/lukaspour/repos","events_url":"https://api.github.com/users/lukaspour/events{/privacy}","received_events_url":"https://api.github.com/users/lukaspour/received_events","type":"User","site_admin":false},"repo":{"id":139453164,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0NTMxNjQ=","name":"terraform-aws-ecs","full_name":"lukaspour/terraform-aws-ecs","private":false,"owner":{"login":"lukaspour","id":8102576,"node_id":"MDQ6VXNlcjgxMDI1NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8102576?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaspour","html_url":"https://github.com/lukaspour","followers_url":"https://api.github.com/users/lukaspour/followers","following_url":"https://api.github.com/users/lukaspour/following{/other_user}","gists_url":"https://api.github.com/users/lukaspour/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaspour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaspour/subscriptions","organizations_url":"https://api.github.com/users/lukaspour/orgs","repos_url":"https://api.github.com/users/lukaspour/repos","events_url":"https://api.github.com/users/lukaspour/events{/privacy}","received_events_url":"https://api.github.com/users/lukaspour/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lukaspour/terraform-aws-ecs","description":"Collection of ECS modules for Terraform.","fork":true,"url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs","forks_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/forks","keys_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/teams","hooks_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/hooks","issue_events_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/issues/events{/number}","events_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/events","assignees_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/assignees{/user}","branches_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/branches{/branch}","tags_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/tags","blobs_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/statuses/{sha}","languages_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/languages","stargazers_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/stargazers","contributors_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/contributors","subscribers_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/subscribers","subscription_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/subscription","commits_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/contents/{+path}","compare_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/merges","archive_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/downloads","issues_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/issues{/number}","pulls_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/pulls{/number}","milestones_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/milestones{/number}","notifications_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/labels{/name}","releases_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/releases{/id}","deployments_url":"https://api.github.com/repos/lukaspour/terraform-aws-ecs/deployments","created_at":"2018-07-02T14:16:45Z","updated_at":"2019-01-03T10:11:58Z","pushed_at":"2019-01-03T10:11:56Z","git_url":"git://github.com/lukaspour/terraform-aws-ecs.git","ssh_url":"git@github.com:lukaspour/terraform-aws-ecs.git","clone_url":"https://github.com/lukaspour/terraform-aws-ecs.git","svn_url":"https://github.com/lukaspour/terraform-aws-ecs","homepage":"https://registry.terraform.io/modules/telia-oss/ecs/aws","size":55,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"telia-oss:master","ref":"master","sha":"900671dcc8042573e2d910d4c841f876e772661c","user":{"login":"telia-oss","id":40239564,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjM5NTY0","avatar_url":"https://avatars2.githubusercontent.com/u/40239564?v=4","gravatar_id":"","url":"https://api.github.com/users/telia-oss","html_url":"https://github.com/telia-oss","followers_url":"https://api.github.com/users/telia-oss/followers","following_url":"https://api.github.com/users/telia-oss/following{/other_user}","gists_url":"https://api.github.com/users/telia-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/telia-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telia-oss/subscriptions","organizations_url":"https://api.github.com/users/telia-oss/orgs","repos_url":"https://api.github.com/users/telia-oss/repos","events_url":"https://api.github.com/users/telia-oss/events{/privacy}","received_events_url":"https://api.github.com/users/telia-oss/received_events","type":"Organization","site_admin":false},"repo":{"id":137669436,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc2Njk0MzY=","name":"terraform-aws-ecs","full_name":"telia-oss/terraform-aws-ecs","private":false,"owner":{"login":"telia-oss","id":40239564,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjM5NTY0","avatar_url":"https://avatars2.githubusercontent.com/u/40239564?v=4","gravatar_id":"","url":"https://api.github.com/users/telia-oss","html_url":"https://github.com/telia-oss","followers_url":"https://api.github.com/users/telia-oss/followers","following_url":"https://api.github.com/users/telia-oss/following{/other_user}","gists_url":"https://api.github.com/users/telia-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/telia-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telia-oss/subscriptions","organizations_url":"https://api.github.com/users/telia-oss/orgs","repos_url":"https://api.github.com/users/telia-oss/repos","events_url":"https://api.github.com/users/telia-oss/events{/privacy}","received_events_url":"https://api.github.com/users/telia-oss/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telia-oss/terraform-aws-ecs","description":"Collection of ECS modules for Terraform.","fork":false,"url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs","forks_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/forks","keys_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/teams","hooks_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/hooks","issue_events_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/issues/events{/number}","events_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/events","assignees_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/assignees{/user}","branches_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/branches{/branch}","tags_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/tags","blobs_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/git/refs{/sha}","trees_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/statuses/{sha}","languages_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/languages","stargazers_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/stargazers","contributors_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/contributors","subscribers_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/subscribers","subscription_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/subscription","commits_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/commits{/sha}","git_commits_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/git/commits{/sha}","comments_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/comments{/number}","issue_comment_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/issues/comments{/number}","contents_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/contents/{+path}","compare_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/merges","archive_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/downloads","issues_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/issues{/number}","pulls_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls{/number}","milestones_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/milestones{/number}","notifications_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/labels{/name}","releases_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/releases{/id}","deployments_url":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/deployments","created_at":"2018-06-17T16:28:32Z","updated_at":"2018-11-21T12:04:49Z","pushed_at":"2019-01-03T10:11:57Z","git_url":"git://github.com/telia-oss/terraform-aws-ecs.git","ssh_url":"git@github.com:telia-oss/terraform-aws-ecs.git","clone_url":"https://github.com/telia-oss/terraform-aws-ecs.git","svn_url":"https://github.com/telia-oss/terraform-aws-ecs","homepage":"https://registry.terraform.io/modules/telia-oss/ecs/aws","size":62,"stargazers_count":2,"watchers_count":2,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/24"},"html":{"href":"https://github.com/telia-oss/terraform-aws-ecs/pull/24"},"issue":{"href":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/issues/24"},"comments":{"href":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/telia-oss/terraform-aws-ecs/statuses/3a95b1fe09139e4782364864833c32056e555c62"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"itsdalmo"}}