{"action":"created","comment":{"url":"https://api.github.com/repos/splunk/docker-splunk/pulls/comments/233169099","pull_request_review_id":174520610,"id":233169099,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE2OTA5OQ==","diff_hunk":"@@ -0,0 +1,25 @@\n+---\n+apiVersion: v1\n+kind: PersistentVolumeClaim\n+metadata:","path":"test_scenarios/kubernetes/3idx1sh1cm-pvc/splunk-master-pvc.yaml","position":4,"original_position":4,"commit_id":"dd1c3e5cccfefac18ef559e4d6b6454917cc86e1","original_commit_id":"dd1c3e5cccfefac18ef559e4d6b6454917cc86e1","user":{"login":"jmervine","id":837893,"node_id":"MDQ6VXNlcjgzNzg5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/837893?v=4","gravatar_id":"","url":"https://api.github.com/users/jmervine","html_url":"https://github.com/jmervine","followers_url":"https://api.github.com/users/jmervine/followers","following_url":"https://api.github.com/users/jmervine/following{/other_user}","gists_url":"https://api.github.com/users/jmervine/gists{/gist_id}","starred_url":"https://api.github.com/users/jmervine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmervine/subscriptions","organizations_url":"https://api.github.com/users/jmervine/orgs","repos_url":"https://api.github.com/users/jmervine/repos","events_url":"https://api.github.com/users/jmervine/events{/privacy}","received_events_url":"https://api.github.com/users/jmervine/received_events","type":"User","site_admin":false},"body":"This is super pedantic, but in the interest of consistency, I prefer to match labels across the board. So in the example PVCs, I'd use the same labels as the deployment that's using it. Especially in this case where the PVC is targeted to that specifc deployment.","created_at":"2018-11-13T18:31:07Z","updated_at":"2018-11-13T18:31:08Z","html_url":"https://github.com/splunk/docker-splunk/pull/54#discussion_r233169099","pull_request_url":"https://api.github.com/repos/splunk/docker-splunk/pulls/54","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/comments/233169099"},"html":{"href":"https://github.com/splunk/docker-splunk/pull/54#discussion_r233169099"},"pull_request":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/splunk/docker-splunk/pulls/54","id":229532687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTMyNjg3","html_url":"https://github.com/splunk/docker-splunk/pull/54","diff_url":"https://github.com/splunk/docker-splunk/pull/54.diff","patch_url":"https://github.com/splunk/docker-splunk/pull/54.patch","issue_url":"https://api.github.com/repos/splunk/docker-splunk/issues/54","number":54,"state":"open","locked":false,"title":"added persistent volume examples, cleaned up license uri","user":{"login":"matthewmodestino","id":31549209,"node_id":"MDQ6VXNlcjMxNTQ5MjA5","avatar_url":"https://avatars3.githubusercontent.com/u/31549209?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewmodestino","html_url":"https://github.com/matthewmodestino","followers_url":"https://api.github.com/users/matthewmodestino/followers","following_url":"https://api.github.com/users/matthewmodestino/following{/other_user}","gists_url":"https://api.github.com/users/matthewmodestino/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewmodestino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewmodestino/subscriptions","organizations_url":"https://api.github.com/users/matthewmodestino/orgs","repos_url":"https://api.github.com/users/matthewmodestino/repos","events_url":"https://api.github.com/users/matthewmodestino/events{/privacy}","received_events_url":"https://api.github.com/users/matthewmodestino/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-08T22:42:04Z","updated_at":"2018-11-13T18:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63272ce784486ff6f6b7b822bc218a1f9a76129e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mikedickey","id":1159596,"node_id":"MDQ6VXNlcjExNTk1OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1159596?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedickey","html_url":"https://github.com/mikedickey","followers_url":"https://api.github.com/users/mikedickey/followers","following_url":"https://api.github.com/users/mikedickey/following{/other_user}","gists_url":"https://api.github.com/users/mikedickey/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedickey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedickey/subscriptions","organizations_url":"https://api.github.com/users/mikedickey/orgs","repos_url":"https://api.github.com/users/mikedickey/repos","events_url":"https://api.github.com/users/mikedickey/events{/privacy}","received_events_url":"https://api.github.com/users/mikedickey/received_events","type":"User","site_admin":false},{"login":"lephino","id":2249857,"node_id":"MDQ6VXNlcjIyNDk4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2249857?v=4","gravatar_id":"","url":"https://api.github.com/users/lephino","html_url":"https://github.com/lephino","followers_url":"https://api.github.com/users/lephino/followers","following_url":"https://api.github.com/users/lephino/following{/other_user}","gists_url":"https://api.github.com/users/lephino/gists{/gist_id}","starred_url":"https://api.github.com/users/lephino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lephino/subscriptions","organizations_url":"https://api.github.com/users/lephino/orgs","repos_url":"https://api.github.com/users/lephino/repos","events_url":"https://api.github.com/users/lephino/events{/privacy}","received_events_url":"https://api.github.com/users/lephino/received_events","type":"User","site_admin":false},{"login":"arctan5x","id":6732195,"node_id":"MDQ6VXNlcjY3MzIxOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/6732195?v=4","gravatar_id":"","url":"https://api.github.com/users/arctan5x","html_url":"https://github.com/arctan5x","followers_url":"https://api.github.com/users/arctan5x/followers","following_url":"https://api.github.com/users/arctan5x/following{/other_user}","gists_url":"https://api.github.com/users/arctan5x/gists{/gist_id}","starred_url":"https://api.github.com/users/arctan5x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arctan5x/subscriptions","organizations_url":"https://api.github.com/users/arctan5x/orgs","repos_url":"https://api.github.com/users/arctan5x/repos","events_url":"https://api.github.com/users/arctan5x/events{/privacy}","received_events_url":"https://api.github.com/users/arctan5x/received_events","type":"User","site_admin":false},{"login":"amitmookerjee","id":40574846,"node_id":"MDQ6VXNlcjQwNTc0ODQ2","avatar_url":"https://avatars1.githubusercontent.com/u/40574846?v=4","gravatar_id":"","url":"https://api.github.com/users/amitmookerjee","html_url":"https://github.com/amitmookerjee","followers_url":"https://api.github.com/users/amitmookerjee/followers","following_url":"https://api.github.com/users/amitmookerjee/following{/other_user}","gists_url":"https://api.github.com/users/amitmookerjee/gists{/gist_id}","starred_url":"https://api.github.com/users/amitmookerjee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitmookerjee/subscriptions","organizations_url":"https://api.github.com/users/amitmookerjee/orgs","repos_url":"https://api.github.com/users/amitmookerjee/repos","events_url":"https://api.github.com/users/amitmookerjee/events{/privacy}","received_events_url":"https://api.github.com/users/amitmookerjee/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/splunk/docker-splunk/pulls/54/commits","review_comments_url":"https://api.github.com/repos/splunk/docker-splunk/pulls/54/comments","review_comment_url":"https://api.github.com/repos/splunk/docker-splunk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/splunk/docker-splunk/issues/54/comments","statuses_url":"https://api.github.com/repos/splunk/docker-splunk/statuses/dd1c3e5cccfefac18ef559e4d6b6454917cc86e1","head":{"label":"matthewmodestino:kube-persist","ref":"kube-persist","sha":"dd1c3e5cccfefac18ef559e4d6b6454917cc86e1","user":{"login":"matthewmodestino","id":31549209,"node_id":"MDQ6VXNlcjMxNTQ5MjA5","avatar_url":"https://avatars3.githubusercontent.com/u/31549209?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewmodestino","html_url":"https://github.com/matthewmodestino","followers_url":"https://api.github.com/users/matthewmodestino/followers","following_url":"https://api.github.com/users/matthewmodestino/following{/other_user}","gists_url":"https://api.github.com/users/matthewmodestino/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewmodestino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewmodestino/subscriptions","organizations_url":"https://api.github.com/users/matthewmodestino/orgs","repos_url":"https://api.github.com/users/matthewmodestino/repos","events_url":"https://api.github.com/users/matthewmodestino/events{/privacy}","received_events_url":"https://api.github.com/users/matthewmodestino/received_events","type":"User","site_admin":false},"repo":{"id":151211435,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyMTE0MzU=","name":"docker-splunk","full_name":"matthewmodestino/docker-splunk","private":false,"owner":{"login":"matthewmodestino","id":31549209,"node_id":"MDQ6VXNlcjMxNTQ5MjA5","avatar_url":"https://avatars3.githubusercontent.com/u/31549209?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewmodestino","html_url":"https://github.com/matthewmodestino","followers_url":"https://api.github.com/users/matthewmodestino/followers","following_url":"https://api.github.com/users/matthewmodestino/following{/other_user}","gists_url":"https://api.github.com/users/matthewmodestino/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewmodestino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewmodestino/subscriptions","organizations_url":"https://api.github.com/users/matthewmodestino/orgs","repos_url":"https://api.github.com/users/matthewmodestino/repos","events_url":"https://api.github.com/users/matthewmodestino/events{/privacy}","received_events_url":"https://api.github.com/users/matthewmodestino/received_events","type":"User","site_admin":false},"html_url":"https://github.com/matthewmodestino/docker-splunk","description":"Splunk Docker GitHub Repository","fork":true,"url":"https://api.github.com/repos/matthewmodestino/docker-splunk","forks_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/forks","keys_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/teams","hooks_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/hooks","issue_events_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/issues/events{/number}","events_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/events","assignees_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/assignees{/user}","branches_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/branches{/branch}","tags_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/tags","blobs_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/languages","stargazers_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/stargazers","contributors_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/contributors","subscribers_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/subscribers","subscription_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/subscription","commits_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/contents/{+path}","compare_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/merges","archive_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/downloads","issues_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/issues{/number}","pulls_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/labels{/name}","releases_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/releases{/id}","deployments_url":"https://api.github.com/repos/matthewmodestino/docker-splunk/deployments","created_at":"2018-10-02T06:43:25Z","updated_at":"2018-11-08T14:41:49Z","pushed_at":"2018-11-09T02:18:20Z","git_url":"git://github.com/matthewmodestino/docker-splunk.git","ssh_url":"git@github.com:matthewmodestino/docker-splunk.git","clone_url":"https://github.com/matthewmodestino/docker-splunk.git","svn_url":"https://github.com/matthewmodestino/docker-splunk","homepage":null,"size":248,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"splunk:master","ref":"master","sha":"bb9b033c8781e6e64dffbf9c69db2b5460194ce5","user":{"login":"splunk","id":651467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTQ2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/651467?v=4","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"repo":{"id":150320454,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzMjA0NTQ=","name":"docker-splunk","full_name":"splunk/docker-splunk","private":false,"owner":{"login":"splunk","id":651467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTQ2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/651467?v=4","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/splunk/docker-splunk","description":"Splunk Docker GitHub Repository","fork":false,"url":"https://api.github.com/repos/splunk/docker-splunk","forks_url":"https://api.github.com/repos/splunk/docker-splunk/forks","keys_url":"https://api.github.com/repos/splunk/docker-splunk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splunk/docker-splunk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splunk/docker-splunk/teams","hooks_url":"https://api.github.com/repos/splunk/docker-splunk/hooks","issue_events_url":"https://api.github.com/repos/splunk/docker-splunk/issues/events{/number}","events_url":"https://api.github.com/repos/splunk/docker-splunk/events","assignees_url":"https://api.github.com/repos/splunk/docker-splunk/assignees{/user}","branches_url":"https://api.github.com/repos/splunk/docker-splunk/branches{/branch}","tags_url":"https://api.github.com/repos/splunk/docker-splunk/tags","blobs_url":"https://api.github.com/repos/splunk/docker-splunk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splunk/docker-splunk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splunk/docker-splunk/git/refs{/sha}","trees_url":"https://api.github.com/repos/splunk/docker-splunk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splunk/docker-splunk/statuses/{sha}","languages_url":"https://api.github.com/repos/splunk/docker-splunk/languages","stargazers_url":"https://api.github.com/repos/splunk/docker-splunk/stargazers","contributors_url":"https://api.github.com/repos/splunk/docker-splunk/contributors","subscribers_url":"https://api.github.com/repos/splunk/docker-splunk/subscribers","subscription_url":"https://api.github.com/repos/splunk/docker-splunk/subscription","commits_url":"https://api.github.com/repos/splunk/docker-splunk/commits{/sha}","git_commits_url":"https://api.github.com/repos/splunk/docker-splunk/git/commits{/sha}","comments_url":"https://api.github.com/repos/splunk/docker-splunk/comments{/number}","issue_comment_url":"https://api.github.com/repos/splunk/docker-splunk/issues/comments{/number}","contents_url":"https://api.github.com/repos/splunk/docker-splunk/contents/{+path}","compare_url":"https://api.github.com/repos/splunk/docker-splunk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splunk/docker-splunk/merges","archive_url":"https://api.github.com/repos/splunk/docker-splunk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splunk/docker-splunk/downloads","issues_url":"https://api.github.com/repos/splunk/docker-splunk/issues{/number}","pulls_url":"https://api.github.com/repos/splunk/docker-splunk/pulls{/number}","milestones_url":"https://api.github.com/repos/splunk/docker-splunk/milestones{/number}","notifications_url":"https://api.github.com/repos/splunk/docker-splunk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splunk/docker-splunk/labels{/name}","releases_url":"https://api.github.com/repos/splunk/docker-splunk/releases{/id}","deployments_url":"https://api.github.com/repos/splunk/docker-splunk/deployments","created_at":"2018-09-25T19:43:22Z","updated_at":"2018-11-12T23:47:27Z","pushed_at":"2018-11-13T00:35:32Z","git_url":"git://github.com/splunk/docker-splunk.git","ssh_url":"git@github.com:splunk/docker-splunk.git","clone_url":"https://github.com/splunk/docker-splunk.git","svn_url":"https://github.com/splunk/docker-splunk","homepage":null,"size":235,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":24,"open_issues":11,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/54"},"html":{"href":"https://github.com/splunk/docker-splunk/pull/54"},"issue":{"href":"https://api.github.com/repos/splunk/docker-splunk/issues/54"},"comments":{"href":"https://api.github.com/repos/splunk/docker-splunk/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/splunk/docker-splunk/statuses/dd1c3e5cccfefac18ef559e4d6b6454917cc86e1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmervine"}}