{"action":"created","issue":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/18603","repository_url":"https://api.github.com/repos/vgstation-coders/vgstation13","labels_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/18603/labels{/name}","comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/18603/comments","events_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/18603/events","html_url":"https://github.com/vgstation-coders/vgstation13/pull/18603","id":335203646,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTY0NzI0","number":18603,"title":"Tweaks gas inside disposals","user":{"login":"Pathid","id":31839805,"node_id":"MDQ6VXNlcjMxODM5ODA1","avatar_url":"https://avatars1.githubusercontent.com/u/31839805?v=4","gravatar_id":"","url":"https://api.github.com/users/Pathid","html_url":"https://github.com/Pathid","followers_url":"https://api.github.com/users/Pathid/followers","following_url":"https://api.github.com/users/Pathid/following{/other_user}","gists_url":"https://api.github.com/users/Pathid/gists{/gist_id}","starred_url":"https://api.github.com/users/Pathid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pathid/subscriptions","organizations_url":"https://api.github.com/users/Pathid/orgs","repos_url":"https://api.github.com/users/Pathid/repos","events_url":"https://api.github.com/users/Pathid/events{/privacy}","received_events_url":"https://api.github.com/users/Pathid/received_events","type":"User","site_admin":false},"labels":[{"id":712160647,"node_id":"MDU6TGFiZWw3MTIxNjA2NDc=","url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels/Tweak","name":"Tweak","color":"E79871","default":false},{"id":735774687,"node_id":"MDU6TGFiZWw3MzU3NzQ2ODc=","url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels/WiP","name":"WiP","color":"e11d21","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-06-24T19:09:42Z","updated_at":"2018-10-31T14:13:11Z","closed_at":"2018-10-31T14:13:11Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/18603","html_url":"https://github.com/vgstation-coders/vgstation13/pull/18603","diff_url":"https://github.com/vgstation-coders/vgstation13/pull/18603.diff","patch_url":"https://github.com/vgstation-coders/vgstation13/pull/18603.patch"},"body":"Resolves #18590\r\n\r\nI started this by just overriding ``return_air()`` inside disposal holders, since although they had their own gas mix, nothing inside was getting a reference to it instead of the gas above the pipe. Turns out I had to change a few more things to get it to work the way I wanted.\r\n\r\nPart of this is reverting a change (https://github.com/vgstation-coders/vgstation13/commit/d521357c068fc3cc86a6dcdf339e3fd24f95e8d2) that made the air pressure inside these things cap out at 5 kPa. Instead I'm dealing with the \"hungry for air\" issue by reducing the volume of the gas mix.\r\n\r\nUpshot of this change is, while you're being flushed through disposals, your environment will be the air that the disposal bin/chute sucked up earlier. Disposals will now also move quite a bit more air than they did, though not as much as before https://github.com/vgstation-coders/vgstation13/commit/d521357c068fc3cc86a6dcdf339e3fd24f95e8d2. (To replicate the current amount of air they move I'd have to reduce the gas volume to less than the volume of a human. Which is doable, but I dunno if it makes sense.) At any rate the air volume might have to be adjusted. 21% of the cell volume is 525 liters and it's probably too high.\r\n\r\nAlso I'm sure that what I did for chutes is bad and will need to be revised, since it's just the bin process behavior shitcoded to happen instantly.\r\n\r\n:cl:\r\n* experiment: The way that disposal pipes handle gasses has been adjusted. Lifeforms inside the pipes will be exposed to the air that the disposal equipment sucked up earlier, instead of the air above the pipe. Disposal bins will move significantly more gas than they did, and delivery chutes will now also move gas when they didn't before."},"comment":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/comments/434702568","html_url":"https://github.com/vgstation-coders/vgstation13/pull/18603#issuecomment-434702568","issue_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/18603","id":434702568,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDcwMjU2OA==","user":{"login":"jknpj","id":17928298,"node_id":"MDQ6VXNlcjE3OTI4Mjk4","avatar_url":"https://avatars1.githubusercontent.com/u/17928298?v=4","gravatar_id":"","url":"https://api.github.com/users/jknpj","html_url":"https://github.com/jknpj","followers_url":"https://api.github.com/users/jknpj/followers","following_url":"https://api.github.com/users/jknpj/following{/other_user}","gists_url":"https://api.github.com/users/jknpj/gists{/gist_id}","starred_url":"https://api.github.com/users/jknpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknpj/subscriptions","organizations_url":"https://api.github.com/users/jknpj/orgs","repos_url":"https://api.github.com/users/jknpj/repos","events_url":"https://api.github.com/users/jknpj/events{/privacy}","received_events_url":"https://api.github.com/users/jknpj/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T14:13:11Z","updated_at":"2018-10-31T14:13:11Z","author_association":"COLLABORATOR","body":"It's been too long already so i'll justslap derelict on this. Ping us in the coder discord when you want it reopened."}}
{"actor":{"display_login":"jknpj"}}