{"action":"created","issue":{"url":"https://api.github.com/repos/enactjs/enact/issues/1928","repository_url":"https://api.github.com/repos/enactjs/enact","labels_url":"https://api.github.com/repos/enactjs/enact/issues/1928/labels{/name}","comments_url":"https://api.github.com/repos/enactjs/enact/issues/1928/comments","events_url":"https://api.github.com/repos/enactjs/enact/issues/1928/events","html_url":"https://github.com/enactjs/enact/pull/1928","id":357026765,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTQxNDg1","number":1928,"title":"ENYO-5603: Clean up spotlight container disabled prop propagation","user":{"login":"viodragon2","id":3284947,"node_id":"MDQ6VXNlcjMyODQ5NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/3284947?v=4","gravatar_id":"","url":"https://api.github.com/users/viodragon2","html_url":"https://github.com/viodragon2","followers_url":"https://api.github.com/users/viodragon2/followers","following_url":"https://api.github.com/users/viodragon2/following{/other_user}","gists_url":"https://api.github.com/users/viodragon2/gists{/gist_id}","starred_url":"https://api.github.com/users/viodragon2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viodragon2/subscriptions","organizations_url":"https://api.github.com/users/viodragon2/orgs","repos_url":"https://api.github.com/users/viodragon2/repos","events_url":"https://api.github.com/users/viodragon2/events{/privacy}","received_events_url":"https://api.github.com/users/viodragon2/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-05T00:56:03Z","updated_at":"2018-09-08T00:05:56Z","closed_at":"2018-09-08T00:05:56Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/enactjs/enact/pulls/1928","html_url":"https://github.com/enactjs/enact/pull/1928","diff_url":"https://github.com/enactjs/enact/pull/1928.diff","patch_url":"https://github.com/enactjs/enact/pull/1928.patch"},"body":"### Checklist\r\n\r\n* [x] I have read and understand the [contribution guide](http://enactjs.com/docs/developer-guide/contributing/)\r\n* [ ] A [CHANGELOG entry](http://enactjs.com/docs/developer-guide/contributing/changelogs/) is included\r\n* [ ] At least one test case is included for this feature or bug fix\r\n* [ ] Documentation was added or is not needed\r\n\r\n* [ ] This is an API breaking change\r\n\r\n### Issue Resolved / Feature Added\r\n[//]: # (Describe the issue resolved or feature added by this pull request)\r\n`SpotlightContainer` is declared in `Scrollable`s and yet it's propagating `data-spotlight-disabled` property down to its children. I believe this is a cruft left over from #1553\r\n\r\n### Resolution\r\n[//]: # (Does the code work as intended?)\r\n[//]: # (What is the impact of this change and *why* was it made?)\r\nRemoved all `setContainerDisabled` from `moonstone/Scrollable`, `moonstone/Scroller` and `moonstone/ScrollableNative`\r\n\r\nEnact-DCO-1.0-Signed-off-by: Stephen Choi <stephen.choi@lge.com>\r\n"},"comment":{"url":"https://api.github.com/repos/enactjs/enact/issues/comments/419596111","html_url":"https://github.com/enactjs/enact/pull/1928#issuecomment-419596111","issue_url":"https://api.github.com/repos/enactjs/enact/issues/1928","id":419596111,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTU5NjExMQ==","user":{"login":"viodragon2","id":3284947,"node_id":"MDQ6VXNlcjMyODQ5NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/3284947?v=4","gravatar_id":"","url":"https://api.github.com/users/viodragon2","html_url":"https://github.com/viodragon2","followers_url":"https://api.github.com/users/viodragon2/followers","following_url":"https://api.github.com/users/viodragon2/following{/other_user}","gists_url":"https://api.github.com/users/viodragon2/gists{/gist_id}","starred_url":"https://api.github.com/users/viodragon2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viodragon2/subscriptions","organizations_url":"https://api.github.com/users/viodragon2/orgs","repos_url":"https://api.github.com/users/viodragon2/repos","events_url":"https://api.github.com/users/viodragon2/events{/privacy}","received_events_url":"https://api.github.com/users/viodragon2/received_events","type":"User","site_admin":false},"created_at":"2018-09-08T00:05:56Z","updated_at":"2018-09-08T00:05:56Z","author_association":"CONTRIBUTOR","body":"The more I look into this, the more complicated it becomes to untangle spotlight from `Scrollable`. I don't think there's a clean or an easy way to address this issue, but the benefits of cleaning this up at this point seem tiny. I'll close this issue for now and reconsider this later as a bigger part of `Scroller`, `VirtualList`, and `Scrollable` refactor work."}}
{"actor":{"display_login":"viodragon2"}}