{"action":"created","comment":{"url":"https://api.github.com/repos/containous/traefik/pulls/comments/242242088","pull_request_review_id":185707147,"id":242242088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjI0MjA4OA==","diff_hunk":"@@ -165,6 +169,13 @@ func (c *clientImpl) GetIngresses() []*extensionsv1beta1.Ingress {\n \t\t\tresult = append(result, ing)\n \t\t}\n \t}\n+\n+\tsort.Slice(result, func(i, j int) bool {\n+\t\ti1 := result[i]\n+\t\ti2 := result[j]","path":"provider/kubernetes/client.go","position":27,"original_position":27,"commit_id":"392040ac3f1f50199063306fa898ff9744ea48dd","original_commit_id":"392040ac3f1f50199063306fa898ff9744ea48dd","user":{"login":"ldez","id":5674651,"node_id":"MDQ6VXNlcjU2NzQ2NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5674651?v=4","gravatar_id":"","url":"https://api.github.com/users/ldez","html_url":"https://github.com/ldez","followers_url":"https://api.github.com/users/ldez/followers","following_url":"https://api.github.com/users/ldez/following{/other_user}","gists_url":"https://api.github.com/users/ldez/gists{/gist_id}","starred_url":"https://api.github.com/users/ldez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldez/subscriptions","organizations_url":"https://api.github.com/users/ldez/orgs","repos_url":"https://api.github.com/users/ldez/repos","events_url":"https://api.github.com/users/ldez/events{/privacy}","received_events_url":"https://api.github.com/users/ldez/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n```","created_at":"2018-12-17T17:26:55Z","updated_at":"2018-12-17T17:39:58Z","html_url":"https://github.com/containous/traefik/pull/4305#discussion_r242242088","pull_request_url":"https://api.github.com/repos/containous/traefik/pulls/4305","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/containous/traefik/pulls/comments/242242088"},"html":{"href":"https://github.com/containous/traefik/pull/4305#discussion_r242242088"},"pull_request":{"href":"https://api.github.com/repos/containous/traefik/pulls/4305"}}},"pull_request":{"url":"https://api.github.com/repos/containous/traefik/pulls/4305","id":239214437,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjE0NDM3","html_url":"https://github.com/containous/traefik/pull/4305","diff_url":"https://github.com/containous/traefik/pull/4305.diff","patch_url":"https://github.com/containous/traefik/pull/4305.patch","issue_url":"https://api.github.com/repos/containous/traefik/issues/4305","number":4305,"state":"open","locked":false,"title":"Fix OOM killer in Kubernetes","user":{"login":"coufalja","id":23357992,"node_id":"MDQ6VXNlcjIzMzU3OTky","avatar_url":"https://avatars0.githubusercontent.com/u/23357992?v=4","gravatar_id":"","url":"https://api.github.com/users/coufalja","html_url":"https://github.com/coufalja","followers_url":"https://api.github.com/users/coufalja/followers","following_url":"https://api.github.com/users/coufalja/following{/other_user}","gists_url":"https://api.github.com/users/coufalja/gists{/gist_id}","starred_url":"https://api.github.com/users/coufalja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coufalja/subscriptions","organizations_url":"https://api.github.com/users/coufalja/orgs","repos_url":"https://api.github.com/users/coufalja/repos","events_url":"https://api.github.com/users/coufalja/events{/privacy}","received_events_url":"https://api.github.com/users/coufalja/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nFixes #4245\r\n\r\n\r\n### Motivation\r\n\r\nIn our Kubernetes cluster our Traefik pods were frequently killed by OOM killer.\r\n\r\n### Additional Notes\r\n\r\nIssue with leaking memory was actually not about leaking memory, but rather about GC not being able to keep up with the amount of garbage created. That was because DeepEquals of Ingresses loaded was almost always returning false due to Ingresses loaded in unspecified order. The problem was caused by TLS field as our services has wildcard certificate defined and if there are multiple Ingresses with the same TLS section (same wildcard certificate in the same secret) the latter ones are skipped. Unspecified order of processing leads to different results from the struct POV while functionally the same but returning false for mentioned DeepEquals function.\r\n","created_at":"2018-12-17T16:53:23Z","updated_at":"2018-12-17T17:39:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ae593040c359078404dc58042a068c0dbae6a13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"kubernetes","id":2410741,"node_id":"MDQ6VGVhbTI0MTA3NDE=","slug":"kubernetes","description":"","privacy":"closed","url":"https://api.github.com/teams/2410741","members_url":"https://api.github.com/teams/2410741/members{/member}","repositories_url":"https://api.github.com/teams/2410741/repos","permission":"pull"}],"labels":[{"id":410567211,"node_id":"MDU6TGFiZWw0MTA1NjcyMTE=","url":"https://api.github.com/repos/containous/traefik/labels/area/provider/k8s","name":"area/provider/k8s","color":"d4c5f9","default":false},{"id":602267628,"node_id":"MDU6TGFiZWw2MDIyNjc2Mjg=","url":"https://api.github.com/repos/containous/traefik/labels/size/S","name":"size/S","color":"0e8a16","default":false},{"id":407670336,"node_id":"MDU6TGFiZWw0MDc2NzAzMzY=","url":"https://api.github.com/repos/containous/traefik/labels/status/0-needs-triage","name":"status/0-needs-triage","color":"EEEEEE","default":false}],"milestone":{"url":"https://api.github.com/repos/containous/traefik/milestones/9","html_url":"https://github.com/containous/traefik/milestone/9","labels_url":"https://api.github.com/repos/containous/traefik/milestones/9/labels","id":3212132,"node_id":"MDk6TWlsZXN0b25lMzIxMjEzMg==","number":9,"title":"1.7","description":"","creator":{"login":"ldez","id":5674651,"node_id":"MDQ6VXNlcjU2NzQ2NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5674651?v=4","gravatar_id":"","url":"https://api.github.com/users/ldez","html_url":"https://github.com/ldez","followers_url":"https://api.github.com/users/ldez/followers","following_url":"https://api.github.com/users/ldez/following{/other_user}","gists_url":"https://api.github.com/users/ldez/gists{/gist_id}","starred_url":"https://api.github.com/users/ldez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldez/subscriptions","organizations_url":"https://api.github.com/users/ldez/orgs","repos_url":"https://api.github.com/users/ldez/repos","events_url":"https://api.github.com/users/ldez/events{/privacy}","received_events_url":"https://api.github.com/users/ldez/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":386,"state":"open","created_at":"2018-03-23T12:54:13Z","updated_at":"2018-12-17T16:53:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/containous/traefik/pulls/4305/commits","review_comments_url":"https://api.github.com/repos/containous/traefik/pulls/4305/comments","review_comment_url":"https://api.github.com/repos/containous/traefik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containous/traefik/issues/4305/comments","statuses_url":"https://api.github.com/repos/containous/traefik/statuses/392040ac3f1f50199063306fa898ff9744ea48dd","head":{"label":"WanderaOrg:v1.7","ref":"v1.7","sha":"392040ac3f1f50199063306fa898ff9744ea48dd","user":{"login":"WanderaOrg","id":26625551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NjI1NTUx","avatar_url":"https://avatars1.githubusercontent.com/u/26625551?v=4","gravatar_id":"","url":"https://api.github.com/users/WanderaOrg","html_url":"https://github.com/WanderaOrg","followers_url":"https://api.github.com/users/WanderaOrg/followers","following_url":"https://api.github.com/users/WanderaOrg/following{/other_user}","gists_url":"https://api.github.com/users/WanderaOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/WanderaOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WanderaOrg/subscriptions","organizations_url":"https://api.github.com/users/WanderaOrg/orgs","repos_url":"https://api.github.com/users/WanderaOrg/repos","events_url":"https://api.github.com/users/WanderaOrg/events{/privacy}","received_events_url":"https://api.github.com/users/WanderaOrg/received_events","type":"Organization","site_admin":false},"repo":{"id":145003206,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMDMyMDY=","name":"traefik","full_name":"WanderaOrg/traefik","private":false,"owner":{"login":"WanderaOrg","id":26625551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NjI1NTUx","avatar_url":"https://avatars1.githubusercontent.com/u/26625551?v=4","gravatar_id":"","url":"https://api.github.com/users/WanderaOrg","html_url":"https://github.com/WanderaOrg","followers_url":"https://api.github.com/users/WanderaOrg/followers","following_url":"https://api.github.com/users/WanderaOrg/following{/other_user}","gists_url":"https://api.github.com/users/WanderaOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/WanderaOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WanderaOrg/subscriptions","organizations_url":"https://api.github.com/users/WanderaOrg/orgs","repos_url":"https://api.github.com/users/WanderaOrg/repos","events_url":"https://api.github.com/users/WanderaOrg/events{/privacy}","received_events_url":"https://api.github.com/users/WanderaOrg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WanderaOrg/traefik","description":"The Cloud Native Edge Router","fork":true,"url":"https://api.github.com/repos/WanderaOrg/traefik","forks_url":"https://api.github.com/repos/WanderaOrg/traefik/forks","keys_url":"https://api.github.com/repos/WanderaOrg/traefik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WanderaOrg/traefik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WanderaOrg/traefik/teams","hooks_url":"https://api.github.com/repos/WanderaOrg/traefik/hooks","issue_events_url":"https://api.github.com/repos/WanderaOrg/traefik/issues/events{/number}","events_url":"https://api.github.com/repos/WanderaOrg/traefik/events","assignees_url":"https://api.github.com/repos/WanderaOrg/traefik/assignees{/user}","branches_url":"https://api.github.com/repos/WanderaOrg/traefik/branches{/branch}","tags_url":"https://api.github.com/repos/WanderaOrg/traefik/tags","blobs_url":"https://api.github.com/repos/WanderaOrg/traefik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WanderaOrg/traefik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WanderaOrg/traefik/git/refs{/sha}","trees_url":"https://api.github.com/repos/WanderaOrg/traefik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WanderaOrg/traefik/statuses/{sha}","languages_url":"https://api.github.com/repos/WanderaOrg/traefik/languages","stargazers_url":"https://api.github.com/repos/WanderaOrg/traefik/stargazers","contributors_url":"https://api.github.com/repos/WanderaOrg/traefik/contributors","subscribers_url":"https://api.github.com/repos/WanderaOrg/traefik/subscribers","subscription_url":"https://api.github.com/repos/WanderaOrg/traefik/subscription","commits_url":"https://api.github.com/repos/WanderaOrg/traefik/commits{/sha}","git_commits_url":"https://api.github.com/repos/WanderaOrg/traefik/git/commits{/sha}","comments_url":"https://api.github.com/repos/WanderaOrg/traefik/comments{/number}","issue_comment_url":"https://api.github.com/repos/WanderaOrg/traefik/issues/comments{/number}","contents_url":"https://api.github.com/repos/WanderaOrg/traefik/contents/{+path}","compare_url":"https://api.github.com/repos/WanderaOrg/traefik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WanderaOrg/traefik/merges","archive_url":"https://api.github.com/repos/WanderaOrg/traefik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WanderaOrg/traefik/downloads","issues_url":"https://api.github.com/repos/WanderaOrg/traefik/issues{/number}","pulls_url":"https://api.github.com/repos/WanderaOrg/traefik/pulls{/number}","milestones_url":"https://api.github.com/repos/WanderaOrg/traefik/milestones{/number}","notifications_url":"https://api.github.com/repos/WanderaOrg/traefik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WanderaOrg/traefik/labels{/name}","releases_url":"https://api.github.com/repos/WanderaOrg/traefik/releases{/id}","deployments_url":"https://api.github.com/repos/WanderaOrg/traefik/deployments","created_at":"2018-08-16T14:59:37Z","updated_at":"2018-08-16T14:59:42Z","pushed_at":"2018-12-17T16:58:24Z","git_url":"git://github.com/WanderaOrg/traefik.git","ssh_url":"git@github.com:WanderaOrg/traefik.git","clone_url":"https://github.com/WanderaOrg/traefik.git","svn_url":"https://github.com/WanderaOrg/traefik","homepage":"https://traefik.io","size":30802,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containous:v1.7","ref":"v1.7","sha":"9203ba5f950c306f2c58cc20b9f90381c056450d","user":{"login":"containous","id":16349663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzQ5NjYz","avatar_url":"https://avatars3.githubusercontent.com/u/16349663?v=4","gravatar_id":"","url":"https://api.github.com/users/containous","html_url":"https://github.com/containous","followers_url":"https://api.github.com/users/containous/followers","following_url":"https://api.github.com/users/containous/following{/other_user}","gists_url":"https://api.github.com/users/containous/gists{/gist_id}","starred_url":"https://api.github.com/users/containous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containous/subscriptions","organizations_url":"https://api.github.com/users/containous/orgs","repos_url":"https://api.github.com/users/containous/repos","events_url":"https://api.github.com/users/containous/events{/privacy}","received_events_url":"https://api.github.com/users/containous/received_events","type":"Organization","site_admin":false},"repo":{"id":42408804,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQwODgwNA==","name":"traefik","full_name":"containous/traefik","private":false,"owner":{"login":"containous","id":16349663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzQ5NjYz","avatar_url":"https://avatars3.githubusercontent.com/u/16349663?v=4","gravatar_id":"","url":"https://api.github.com/users/containous","html_url":"https://github.com/containous","followers_url":"https://api.github.com/users/containous/followers","following_url":"https://api.github.com/users/containous/following{/other_user}","gists_url":"https://api.github.com/users/containous/gists{/gist_id}","starred_url":"https://api.github.com/users/containous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containous/subscriptions","organizations_url":"https://api.github.com/users/containous/orgs","repos_url":"https://api.github.com/users/containous/repos","events_url":"https://api.github.com/users/containous/events{/privacy}","received_events_url":"https://api.github.com/users/containous/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/containous/traefik","description":"The Cloud Native Edge Router","fork":false,"url":"https://api.github.com/repos/containous/traefik","forks_url":"https://api.github.com/repos/containous/traefik/forks","keys_url":"https://api.github.com/repos/containous/traefik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containous/traefik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containous/traefik/teams","hooks_url":"https://api.github.com/repos/containous/traefik/hooks","issue_events_url":"https://api.github.com/repos/containous/traefik/issues/events{/number}","events_url":"https://api.github.com/repos/containous/traefik/events","assignees_url":"https://api.github.com/repos/containous/traefik/assignees{/user}","branches_url":"https://api.github.com/repos/containous/traefik/branches{/branch}","tags_url":"https://api.github.com/repos/containous/traefik/tags","blobs_url":"https://api.github.com/repos/containous/traefik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containous/traefik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containous/traefik/git/refs{/sha}","trees_url":"https://api.github.com/repos/containous/traefik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containous/traefik/statuses/{sha}","languages_url":"https://api.github.com/repos/containous/traefik/languages","stargazers_url":"https://api.github.com/repos/containous/traefik/stargazers","contributors_url":"https://api.github.com/repos/containous/traefik/contributors","subscribers_url":"https://api.github.com/repos/containous/traefik/subscribers","subscription_url":"https://api.github.com/repos/containous/traefik/subscription","commits_url":"https://api.github.com/repos/containous/traefik/commits{/sha}","git_commits_url":"https://api.github.com/repos/containous/traefik/git/commits{/sha}","comments_url":"https://api.github.com/repos/containous/traefik/comments{/number}","issue_comment_url":"https://api.github.com/repos/containous/traefik/issues/comments{/number}","contents_url":"https://api.github.com/repos/containous/traefik/contents/{+path}","compare_url":"https://api.github.com/repos/containous/traefik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containous/traefik/merges","archive_url":"https://api.github.com/repos/containous/traefik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containous/traefik/downloads","issues_url":"https://api.github.com/repos/containous/traefik/issues{/number}","pulls_url":"https://api.github.com/repos/containous/traefik/pulls{/number}","milestones_url":"https://api.github.com/repos/containous/traefik/milestones{/number}","notifications_url":"https://api.github.com/repos/containous/traefik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containous/traefik/labels{/name}","releases_url":"https://api.github.com/repos/containous/traefik/releases{/id}","deployments_url":"https://api.github.com/repos/containous/traefik/deployments","created_at":"2015-09-13T19:04:02Z","updated_at":"2018-12-17T17:30:09Z","pushed_at":"2018-12-17T16:58:27Z","git_url":"git://github.com/containous/traefik.git","ssh_url":"git@github.com:containous/traefik.git","clone_url":"https://github.com/containous/traefik.git","svn_url":"https://github.com/containous/traefik","homepage":"https://traefik.io","size":33101,"stargazers_count":19258,"watchers_count":19258,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1974,"mirror_url":null,"archived":false,"open_issues_count":354,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1974,"open_issues":354,"watchers":19258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containous/traefik/pulls/4305"},"html":{"href":"https://github.com/containous/traefik/pull/4305"},"issue":{"href":"https://api.github.com/repos/containous/traefik/issues/4305"},"comments":{"href":"https://api.github.com/repos/containous/traefik/issues/4305/comments"},"review_comments":{"href":"https://api.github.com/repos/containous/traefik/pulls/4305/comments"},"review_comment":{"href":"https://api.github.com/repos/containous/traefik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containous/traefik/pulls/4305/commits"},"statuses":{"href":"https://api.github.com/repos/containous/traefik/statuses/392040ac3f1f50199063306fa898ff9744ea48dd"}},"author_association":"NONE"}}
{"actor":{"display_login":"ldez"}}