{"action":"created","issue":{"url":"https://api.github.com/repos/marko-js/marko/issues/1091","repository_url":"https://api.github.com/repos/marko-js/marko","labels_url":"https://api.github.com/repos/marko-js/marko/issues/1091/labels{/name}","comments_url":"https://api.github.com/repos/marko-js/marko/issues/1091/comments","events_url":"https://api.github.com/repos/marko-js/marko/issues/1091/events","html_url":"https://github.com/marko-js/marko/pull/1091","id":342923560,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzEwMjE4","number":1091,"title":"fix all for loop types","user":{"login":"mlrawlings","id":1958812,"node_id":"MDQ6VXNlcjE5NTg4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1958812?v=4","gravatar_id":"","url":"https://api.github.com/users/mlrawlings","html_url":"https://github.com/mlrawlings","followers_url":"https://api.github.com/users/mlrawlings/followers","following_url":"https://api.github.com/users/mlrawlings/following{/other_user}","gists_url":"https://api.github.com/users/mlrawlings/gists{/gist_id}","starred_url":"https://api.github.com/users/mlrawlings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlrawlings/subscriptions","organizations_url":"https://api.github.com/users/mlrawlings/orgs","repos_url":"https://api.github.com/users/mlrawlings/repos","events_url":"https://api.github.com/users/mlrawlings/events{/privacy}","received_events_url":"https://api.github.com/users/mlrawlings/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-19T23:31:13Z","updated_at":"2018-07-19T23:38:43Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/marko-js/marko/pulls/1091","html_url":"https://github.com/marko-js/marko/pull/1091","diff_url":"https://github.com/marko-js/marko/pull/1091.diff","patch_url":"https://github.com/marko-js/marko/pull/1091.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n\r\nThe fix in #1067 did not cover the `for()` attribute:\r\n```\r\n<div for(x in array)/>\r\n```\r\n\r\nNow it does.\r\n\r\n## Checklist:\r\n\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n- [x] My code follows the code style of this project.\r\n- [ ] I have updated/added documentation affected by my changes.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n_Disclaimer: Contributions via GitHub pull requests are gladly accepted from their original author. Along with any pull requests, please state that the contribution is your original work and that you license the work to the project under the project's open source license. Whether or not you state this explicitly, by submitting any copyrighted material via pull request, email, or other means you agree to license the material under the project's open source license and warrant that you have the legal authority to do so._\r\n"},"comment":{"url":"https://api.github.com/repos/marko-js/marko/issues/comments/406445851","html_url":"https://github.com/marko-js/marko/pull/1091#issuecomment-406445851","issue_url":"https://api.github.com/repos/marko-js/marko/issues/1091","id":406445851,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjQ0NTg1MQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-07-19T23:38:43Z","updated_at":"2018-07-19T23:38:43Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/marko-js/marko/pull/1091?src=pr&el=h1) Report\n> Merging [#1091](https://codecov.io/gh/marko-js/marko/pull/1091?src=pr&el=desc) into [master](https://codecov.io/gh/marko-js/marko/commit/14d29438632bfd96479cdda8be9cb6cc2721945d?src=pr&el=desc) will **increase** coverage by `0.01%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/marko-js/marko/pull/1091/graphs/tree.svg?width=650&height=150&src=pr&token=nTbyWfZ2ka)](https://codecov.io/gh/marko-js/marko/pull/1091?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##           master   #1091      +/-   ##\n=========================================\n+ Coverage   90.59%   90.6%   +0.01%     \n=========================================\n  Files         308     308              \n  Lines       11658   11660       +2     \n=========================================\n+ Hits        10561   10564       +3     \n+ Misses       1097    1096       -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/marko-js/marko/pull/1091?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...onents/taglib/TransformHelper/assignComponentId.js](https://codecov.io/gh/marko-js/marko/pull/1091/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvdGFnbGliL1RyYW5zZm9ybUhlbHBlci9hc3NpZ25Db21wb25lbnRJZC5qcw==) | `94.23% <100%> (+0.11%)` | :arrow_up: |\n| [src/compiler/ast/Expression.js](https://codecov.io/gh/marko-js/marko/pull/1091/diff?src=pr&el=tree#diff-c3JjL2NvbXBpbGVyL2FzdC9FeHByZXNzaW9uLmpz) | `90% <0%> (+10%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/marko-js/marko/pull/1091?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/marko-js/marko/pull/1091?src=pr&el=footer). Last update [14d2943...5641fb9](https://codecov.io/gh/marko-js/marko/pull/1091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}