{"action":"created","issue":{"url":"https://api.github.com/repos/IanMitchell/discord-notifier/issues/9","repository_url":"https://api.github.com/repos/IanMitchell/discord-notifier","labels_url":"https://api.github.com/repos/IanMitchell/discord-notifier/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/IanMitchell/discord-notifier/issues/9/comments","events_url":"https://api.github.com/repos/IanMitchell/discord-notifier/issues/9/events","html_url":"https://github.com/IanMitchell/discord-notifier/issues/9","id":342359853,"node_id":"MDU6SXNzdWUzNDIzNTk4NTM=","number":9,"title":"Image Sending Error - probably affect every kinda file","user":{"login":"quirinux","id":3593363,"node_id":"MDQ6VXNlcjM1OTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3593363?v=4","gravatar_id":"","url":"https://api.github.com/users/quirinux","html_url":"https://github.com/quirinux","followers_url":"https://api.github.com/users/quirinux/followers","following_url":"https://api.github.com/users/quirinux/following{/other_user}","gists_url":"https://api.github.com/users/quirinux/gists{/gist_id}","starred_url":"https://api.github.com/users/quirinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quirinux/subscriptions","organizations_url":"https://api.github.com/users/quirinux/orgs","repos_url":"https://api.github.com/users/quirinux/repos","events_url":"https://api.github.com/users/quirinux/events{/privacy}","received_events_url":"https://api.github.com/users/quirinux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-18T14:43:34Z","updated_at":"2018-07-18T16:10:23Z","closed_at":null,"author_association":"NONE","body":"First of all, thanks @IanMitchell for this awesome work, it helped me a lot on my projects and help me to save a good bunch of hours.\r\n\r\nI got myself trying to send a file with simply sending a File object like described on README page, but once on discord channel it didn't download complaining about wrong file format, it failed for a sort kind of files like PNG, JPG, ZIP and just worked for pure text files.\r\n\r\nSo I compared the text file that I sent to channel with the original one and for my surprise the sent one had CRLF ending lines chars, even though the original didn't.\r\n\r\nAt line #33 of [form_data.rb](https://github.com/IanMitchell/discord-notifier/blob/master/lib/discord_notifier/form_data.rb) file there is a line that adds those CRLF chars into the stream, so I commented this line and it worked like a charm.\r\n\r\nMy question, do you like a PR to apply that change?\r\nIs this line important for anything else? Not sure yet if it impacts on any other file format"},"comment":{"url":"https://api.github.com/repos/IanMitchell/discord-notifier/issues/comments/405987330","html_url":"https://github.com/IanMitchell/discord-notifier/issues/9#issuecomment-405987330","issue_url":"https://api.github.com/repos/IanMitchell/discord-notifier/issues/9","id":405987330,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTk4NzMzMA==","user":{"login":"IanMitchell","id":603872,"node_id":"MDQ6VXNlcjYwMzg3Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/603872?v=4","gravatar_id":"","url":"https://api.github.com/users/IanMitchell","html_url":"https://github.com/IanMitchell","followers_url":"https://api.github.com/users/IanMitchell/followers","following_url":"https://api.github.com/users/IanMitchell/following{/other_user}","gists_url":"https://api.github.com/users/IanMitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/IanMitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanMitchell/subscriptions","organizations_url":"https://api.github.com/users/IanMitchell/orgs","repos_url":"https://api.github.com/users/IanMitchell/repos","events_url":"https://api.github.com/users/IanMitchell/events{/privacy}","received_events_url":"https://api.github.com/users/IanMitchell/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T16:10:23Z","updated_at":"2018-07-18T16:10:23Z","author_association":"OWNER","body":"Yeah, see it working without the line. I'll remove it and publish a new version - my guess is I shouldn't be encoding the file contents with a CRLF, but splitting that out would be more difficult than just dropping the one line, and if it works... ¯\\_(ツ)_/¯  "}}
{"actor":{"display_login":"IanMitchell"}}