{"action":"closed","number":474,"pull_request":{"url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/474","id":210246482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjQ2NDgy","html_url":"https://github.com/fastbuild/fastbuild/pull/474","diff_url":"https://github.com/fastbuild/fastbuild/pull/474.diff","patch_url":"https://github.com/fastbuild/fastbuild/pull/474.patch","issue_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/474","number":474,"state":"closed","locked":false,"title":"Crash fixes","user":{"login":"bburgin","id":5349024,"node_id":"MDQ6VXNlcjUzNDkwMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5349024?v=4","gravatar_id":"","url":"https://api.github.com/users/bburgin","html_url":"https://github.com/bburgin","followers_url":"https://api.github.com/users/bburgin/followers","following_url":"https://api.github.com/users/bburgin/following{/other_user}","gists_url":"https://api.github.com/users/bburgin/gists{/gist_id}","starred_url":"https://api.github.com/users/bburgin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bburgin/subscriptions","organizations_url":"https://api.github.com/users/bburgin/orgs","repos_url":"https://api.github.com/users/bburgin/repos","events_url":"https://api.github.com/users/bburgin/events{/privacy}","received_events_url":"https://api.github.com/users/bburgin/received_events","type":"User","site_admin":false},"body":"1. Call InitBuckets() in SmallBlockAllocator::Alloc() even if size too big, to avoid later crash if only too big allocs exist in a run.\r\n2. Added some nullptr checks to avoid nullptr dereference crashes.\r\n3. Set some ptrs to nullptr during cleanup steps, to avoid later deference crashes.\r\n4. Changed some methods to pass NodeGraph by pointer instead of by reference, since the DoBuild part of the logic in the methods still needs to run. So, I have it check for nullptr in lower methods.","created_at":"2018-08-22T19:56:26Z","updated_at":"2018-09-29T16:58:44Z","closed_at":"2018-09-29T16:58:44Z","merged_at":null,"merge_commit_sha":"ca867ee6fa73de4bf17c1450834f237f37219227","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":190299604,"node_id":"MDU6TGFiZWwxOTAyOTk2MDQ=","url":"https://api.github.com/repos/fastbuild/fastbuild/labels/Bug","name":"Bug","color":"fc2929","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/474/commits","review_comments_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/474/comments","review_comment_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/474/comments","statuses_url":"https://api.github.com/repos/fastbuild/fastbuild/statuses/dd4194255fa69a989ef46e8af396adf8418d63f6","head":{"label":"bburgin:crashfixes","ref":"crashfixes","sha":"dd4194255fa69a989ef46e8af396adf8418d63f6","user":{"login":"bburgin","id":5349024,"node_id":"MDQ6VXNlcjUzNDkwMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5349024?v=4","gravatar_id":"","url":"https://api.github.com/users/bburgin","html_url":"https://github.com/bburgin","followers_url":"https://api.github.com/users/bburgin/followers","following_url":"https://api.github.com/users/bburgin/following{/other_user}","gists_url":"https://api.github.com/users/bburgin/gists{/gist_id}","starred_url":"https://api.github.com/users/bburgin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bburgin/subscriptions","organizations_url":"https://api.github.com/users/bburgin/orgs","repos_url":"https://api.github.com/users/bburgin/repos","events_url":"https://api.github.com/users/bburgin/events{/privacy}","received_events_url":"https://api.github.com/users/bburgin/received_events","type":"User","site_admin":false},"repo":{"id":139478353,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0NzgzNTM=","name":"fastbuild","full_name":"bburgin/fastbuild","private":false,"owner":{"login":"bburgin","id":5349024,"node_id":"MDQ6VXNlcjUzNDkwMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5349024?v=4","gravatar_id":"","url":"https://api.github.com/users/bburgin","html_url":"https://github.com/bburgin","followers_url":"https://api.github.com/users/bburgin/followers","following_url":"https://api.github.com/users/bburgin/following{/other_user}","gists_url":"https://api.github.com/users/bburgin/gists{/gist_id}","starred_url":"https://api.github.com/users/bburgin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bburgin/subscriptions","organizations_url":"https://api.github.com/users/bburgin/orgs","repos_url":"https://api.github.com/users/bburgin/repos","events_url":"https://api.github.com/users/bburgin/events{/privacy}","received_events_url":"https://api.github.com/users/bburgin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bburgin/fastbuild","description":"High performance build system for Windows, OSX and Linux. Supporting caching, network distribution and more.","fork":true,"url":"https://api.github.com/repos/bburgin/fastbuild","forks_url":"https://api.github.com/repos/bburgin/fastbuild/forks","keys_url":"https://api.github.com/repos/bburgin/fastbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bburgin/fastbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bburgin/fastbuild/teams","hooks_url":"https://api.github.com/repos/bburgin/fastbuild/hooks","issue_events_url":"https://api.github.com/repos/bburgin/fastbuild/issues/events{/number}","events_url":"https://api.github.com/repos/bburgin/fastbuild/events","assignees_url":"https://api.github.com/repos/bburgin/fastbuild/assignees{/user}","branches_url":"https://api.github.com/repos/bburgin/fastbuild/branches{/branch}","tags_url":"https://api.github.com/repos/bburgin/fastbuild/tags","blobs_url":"https://api.github.com/repos/bburgin/fastbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bburgin/fastbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bburgin/fastbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/bburgin/fastbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bburgin/fastbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/bburgin/fastbuild/languages","stargazers_url":"https://api.github.com/repos/bburgin/fastbuild/stargazers","contributors_url":"https://api.github.com/repos/bburgin/fastbuild/contributors","subscribers_url":"https://api.github.com/repos/bburgin/fastbuild/subscribers","subscription_url":"https://api.github.com/repos/bburgin/fastbuild/subscription","commits_url":"https://api.github.com/repos/bburgin/fastbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/bburgin/fastbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/bburgin/fastbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/bburgin/fastbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/bburgin/fastbuild/contents/{+path}","compare_url":"https://api.github.com/repos/bburgin/fastbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bburgin/fastbuild/merges","archive_url":"https://api.github.com/repos/bburgin/fastbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bburgin/fastbuild/downloads","issues_url":"https://api.github.com/repos/bburgin/fastbuild/issues{/number}","pulls_url":"https://api.github.com/repos/bburgin/fastbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/bburgin/fastbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/bburgin/fastbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bburgin/fastbuild/labels{/name}","releases_url":"https://api.github.com/repos/bburgin/fastbuild/releases{/id}","deployments_url":"https://api.github.com/repos/bburgin/fastbuild/deployments","created_at":"2018-07-02T18:13:57Z","updated_at":"2018-07-02T18:14:01Z","pushed_at":"2018-09-20T04:57:54Z","git_url":"git://github.com/bburgin/fastbuild.git","ssh_url":"git@github.com:bburgin/fastbuild.git","clone_url":"https://github.com/bburgin/fastbuild.git","svn_url":"https://github.com/bburgin/fastbuild","homepage":"http://fastbuild.org","size":7377,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastbuild:dev","ref":"dev","sha":"75f411d2f407dfefb7da644e886d33b947753cbc","user":{"login":"fastbuild","id":11589493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTg5NDkz","avatar_url":"https://avatars3.githubusercontent.com/u/11589493?v=4","gravatar_id":"","url":"https://api.github.com/users/fastbuild","html_url":"https://github.com/fastbuild","followers_url":"https://api.github.com/users/fastbuild/followers","following_url":"https://api.github.com/users/fastbuild/following{/other_user}","gists_url":"https://api.github.com/users/fastbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/fastbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastbuild/subscriptions","organizations_url":"https://api.github.com/users/fastbuild/orgs","repos_url":"https://api.github.com/users/fastbuild/repos","events_url":"https://api.github.com/users/fastbuild/events{/privacy}","received_events_url":"https://api.github.com/users/fastbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":32647696,"node_id":"MDEwOlJlcG9zaXRvcnkzMjY0NzY5Ng==","name":"fastbuild","full_name":"fastbuild/fastbuild","private":false,"owner":{"login":"fastbuild","id":11589493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTg5NDkz","avatar_url":"https://avatars3.githubusercontent.com/u/11589493?v=4","gravatar_id":"","url":"https://api.github.com/users/fastbuild","html_url":"https://github.com/fastbuild","followers_url":"https://api.github.com/users/fastbuild/followers","following_url":"https://api.github.com/users/fastbuild/following{/other_user}","gists_url":"https://api.github.com/users/fastbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/fastbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastbuild/subscriptions","organizations_url":"https://api.github.com/users/fastbuild/orgs","repos_url":"https://api.github.com/users/fastbuild/repos","events_url":"https://api.github.com/users/fastbuild/events{/privacy}","received_events_url":"https://api.github.com/users/fastbuild/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fastbuild/fastbuild","description":"High performance build system for Windows, OSX and Linux. Supporting caching, network distribution and more.","fork":false,"url":"https://api.github.com/repos/fastbuild/fastbuild","forks_url":"https://api.github.com/repos/fastbuild/fastbuild/forks","keys_url":"https://api.github.com/repos/fastbuild/fastbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastbuild/fastbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastbuild/fastbuild/teams","hooks_url":"https://api.github.com/repos/fastbuild/fastbuild/hooks","issue_events_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/events{/number}","events_url":"https://api.github.com/repos/fastbuild/fastbuild/events","assignees_url":"https://api.github.com/repos/fastbuild/fastbuild/assignees{/user}","branches_url":"https://api.github.com/repos/fastbuild/fastbuild/branches{/branch}","tags_url":"https://api.github.com/repos/fastbuild/fastbuild/tags","blobs_url":"https://api.github.com/repos/fastbuild/fastbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastbuild/fastbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastbuild/fastbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastbuild/fastbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastbuild/fastbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/fastbuild/fastbuild/languages","stargazers_url":"https://api.github.com/repos/fastbuild/fastbuild/stargazers","contributors_url":"https://api.github.com/repos/fastbuild/fastbuild/contributors","subscribers_url":"https://api.github.com/repos/fastbuild/fastbuild/subscribers","subscription_url":"https://api.github.com/repos/fastbuild/fastbuild/subscription","commits_url":"https://api.github.com/repos/fastbuild/fastbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastbuild/fastbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastbuild/fastbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastbuild/fastbuild/contents/{+path}","compare_url":"https://api.github.com/repos/fastbuild/fastbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastbuild/fastbuild/merges","archive_url":"https://api.github.com/repos/fastbuild/fastbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastbuild/fastbuild/downloads","issues_url":"https://api.github.com/repos/fastbuild/fastbuild/issues{/number}","pulls_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/fastbuild/fastbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/fastbuild/fastbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastbuild/fastbuild/labels{/name}","releases_url":"https://api.github.com/repos/fastbuild/fastbuild/releases{/id}","deployments_url":"https://api.github.com/repos/fastbuild/fastbuild/deployments","created_at":"2015-03-21T19:53:07Z","updated_at":"2018-09-27T09:28:30Z","pushed_at":"2018-09-29T16:54:38Z","git_url":"git://github.com/fastbuild/fastbuild.git","ssh_url":"git@github.com:fastbuild/fastbuild.git","clone_url":"https://github.com/fastbuild/fastbuild.git","svn_url":"https://github.com/fastbuild/fastbuild","homepage":"http://fastbuild.org","size":7200,"stargazers_count":349,"watchers_count":349,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":106,"license":null,"forks":134,"open_issues":106,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/474"},"html":{"href":"https://github.com/fastbuild/fastbuild/pull/474"},"issue":{"href":"https://api.github.com/repos/fastbuild/fastbuild/issues/474"},"comments":{"href":"https://api.github.com/repos/fastbuild/fastbuild/issues/474/comments"},"review_comments":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/474/comments"},"review_comment":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/474/commits"},"statuses":{"href":"https://api.github.com/repos/fastbuild/fastbuild/statuses/dd4194255fa69a989ef46e8af396adf8418d63f6"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":19,"maintainer_can_modify":false,"commits":1,"additions":431,"deletions":332,"changed_files":14}}
{"actor":{"display_login":"ffulin"}}