{"action":"created","comment":{"url":"https://api.github.com/repos/mrniko/netty-socketio/pulls/comments/200057708","pull_request_review_id":134296082,"id":200057708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDA1NzcwOA==","diff_hunk":"@@ -186,4 +179,16 @@ private void sendError(ChannelHandlerContext ctx) {\n         ctx.channel().writeAndFlush(res).addListener(ChannelFutureListener.CLOSE);\n     }\n \n+    @Override\n+    public void channelInactive(ChannelHandlerContext ctx) throws Exception {\n+        final Channel channel = ctx.channel();\n+        ClientHead client = clientsBox.get(channel);\n+        if (client != null && client.isTransportChannel(ctx.channel(), Transport.POLLING)) {\n+            log.debug(\"channel inactive {}\", client.getSessionId());\n+            client.onChannelDisconnect();\n+        }\n+        channel.close();","path":"src/main/java/com/corundumstudio/socketio/transport/PollingTransport.java","position":null,"original_position":58,"commit_id":"9ed48eabff6689e791c345bad75c2ea970d725b0","original_commit_id":"183bdebda86d6fe2d55927d2edf86586d55069a5","user":{"login":"mrniko","id":1104661,"node_id":"MDQ6VXNlcjExMDQ2NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1104661?v=4","gravatar_id":"","url":"https://api.github.com/users/mrniko","html_url":"https://github.com/mrniko","followers_url":"https://api.github.com/users/mrniko/followers","following_url":"https://api.github.com/users/mrniko/following{/other_user}","gists_url":"https://api.github.com/users/mrniko/gists{/gist_id}","starred_url":"https://api.github.com/users/mrniko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrniko/subscriptions","organizations_url":"https://api.github.com/users/mrniko/orgs","repos_url":"https://api.github.com/users/mrniko/repos","events_url":"https://api.github.com/users/mrniko/events{/privacy}","received_events_url":"https://api.github.com/users/mrniko/received_events","type":"User","site_admin":false},"body":"@dawnbreaks You don't need to invoke channel close() method.","created_at":"2018-07-04T09:05:57Z","updated_at":"2018-07-04T09:06:47Z","html_url":"https://github.com/mrniko/netty-socketio/pull/572#discussion_r200057708","pull_request_url":"https://api.github.com/repos/mrniko/netty-socketio/pulls/572","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mrniko/netty-socketio/pulls/comments/200057708"},"html":{"href":"https://github.com/mrniko/netty-socketio/pull/572#discussion_r200057708"},"pull_request":{"href":"https://api.github.com/repos/mrniko/netty-socketio/pulls/572"}}},"pull_request":{"url":"https://api.github.com/repos/mrniko/netty-socketio/pulls/572","id":198222604,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MjIyNjA0","html_url":"https://github.com/mrniko/netty-socketio/pull/572","diff_url":"https://github.com/mrniko/netty-socketio/pull/572.diff","patch_url":"https://github.com/mrniko/netty-socketio/pull/572.patch","issue_url":"https://api.github.com/repos/mrniko/netty-socketio/issues/572","number":572,"state":"open","locked":false,"title":"fix memory leak issue","user":{"login":"dawnbreaks","id":1875073,"node_id":"MDQ6VXNlcjE4NzUwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1875073?v=4","gravatar_id":"","url":"https://api.github.com/users/dawnbreaks","html_url":"https://github.com/dawnbreaks","followers_url":"https://api.github.com/users/dawnbreaks/followers","following_url":"https://api.github.com/users/dawnbreaks/following{/other_user}","gists_url":"https://api.github.com/users/dawnbreaks/gists{/gist_id}","starred_url":"https://api.github.com/users/dawnbreaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawnbreaks/subscriptions","organizations_url":"https://api.github.com/users/dawnbreaks/orgs","repos_url":"https://api.github.com/users/dawnbreaks/repos","events_url":"https://api.github.com/users/dawnbreaks/events{/privacy}","received_events_url":"https://api.github.com/users/dawnbreaks/received_events","type":"User","site_admin":false},"body":"release inactive long-polling channel from ClientsBox to avoid memory leak","created_at":"2018-06-29T06:03:20Z","updated_at":"2018-07-04T09:06:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4b602b38f7e4da492aa3e290dc2ac6b74cc2daf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrniko/netty-socketio/pulls/572/commits","review_comments_url":"https://api.github.com/repos/mrniko/netty-socketio/pulls/572/comments","review_comment_url":"https://api.github.com/repos/mrniko/netty-socketio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrniko/netty-socketio/issues/572/comments","statuses_url":"https://api.github.com/repos/mrniko/netty-socketio/statuses/9ed48eabff6689e791c345bad75c2ea970d725b0","head":{"label":"dawnbreaks:master","ref":"master","sha":"9ed48eabff6689e791c345bad75c2ea970d725b0","user":{"login":"dawnbreaks","id":1875073,"node_id":"MDQ6VXNlcjE4NzUwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1875073?v=4","gravatar_id":"","url":"https://api.github.com/users/dawnbreaks","html_url":"https://github.com/dawnbreaks","followers_url":"https://api.github.com/users/dawnbreaks/followers","following_url":"https://api.github.com/users/dawnbreaks/following{/other_user}","gists_url":"https://api.github.com/users/dawnbreaks/gists{/gist_id}","starred_url":"https://api.github.com/users/dawnbreaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawnbreaks/subscriptions","organizations_url":"https://api.github.com/users/dawnbreaks/orgs","repos_url":"https://api.github.com/users/dawnbreaks/repos","events_url":"https://api.github.com/users/dawnbreaks/events{/privacy}","received_events_url":"https://api.github.com/users/dawnbreaks/received_events","type":"User","site_admin":false},"repo":{"id":139095195,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwOTUxOTU=","name":"netty-socketio","full_name":"dawnbreaks/netty-socketio","owner":{"login":"dawnbreaks","id":1875073,"node_id":"MDQ6VXNlcjE4NzUwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1875073?v=4","gravatar_id":"","url":"https://api.github.com/users/dawnbreaks","html_url":"https://github.com/dawnbreaks","followers_url":"https://api.github.com/users/dawnbreaks/followers","following_url":"https://api.github.com/users/dawnbreaks/following{/other_user}","gists_url":"https://api.github.com/users/dawnbreaks/gists{/gist_id}","starred_url":"https://api.github.com/users/dawnbreaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawnbreaks/subscriptions","organizations_url":"https://api.github.com/users/dawnbreaks/orgs","repos_url":"https://api.github.com/users/dawnbreaks/repos","events_url":"https://api.github.com/users/dawnbreaks/events{/privacy}","received_events_url":"https://api.github.com/users/dawnbreaks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dawnbreaks/netty-socketio","description":"Socket.IO server implemented on Java. Realtime java framework","fork":true,"url":"https://api.github.com/repos/dawnbreaks/netty-socketio","forks_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/forks","keys_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/teams","hooks_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/hooks","issue_events_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/issues/events{/number}","events_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/events","assignees_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/assignees{/user}","branches_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/branches{/branch}","tags_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/tags","blobs_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/git/refs{/sha}","trees_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/statuses/{sha}","languages_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/languages","stargazers_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/stargazers","contributors_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/contributors","subscribers_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/subscribers","subscription_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/subscription","commits_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/commits{/sha}","git_commits_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/git/commits{/sha}","comments_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/comments{/number}","issue_comment_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/issues/comments{/number}","contents_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/contents/{+path}","compare_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/merges","archive_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/downloads","issues_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/issues{/number}","pulls_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/pulls{/number}","milestones_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/milestones{/number}","notifications_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/labels{/name}","releases_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/releases{/id}","deployments_url":"https://api.github.com/repos/dawnbreaks/netty-socketio/deployments","created_at":"2018-06-29T03:14:20Z","updated_at":"2018-07-04T07:47:11Z","pushed_at":"2018-07-04T07:47:08Z","git_url":"git://github.com/dawnbreaks/netty-socketio.git","ssh_url":"git@github.com:dawnbreaks/netty-socketio.git","clone_url":"https://github.com/dawnbreaks/netty-socketio.git","svn_url":"https://github.com/dawnbreaks/netty-socketio","homepage":"","size":1840,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrniko:master","ref":"master","sha":"f2e2be1b7f6c04108ce9d90d7988be3059214dfb","user":{"login":"mrniko","id":1104661,"node_id":"MDQ6VXNlcjExMDQ2NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1104661?v=4","gravatar_id":"","url":"https://api.github.com/users/mrniko","html_url":"https://github.com/mrniko","followers_url":"https://api.github.com/users/mrniko/followers","following_url":"https://api.github.com/users/mrniko/following{/other_user}","gists_url":"https://api.github.com/users/mrniko/gists{/gist_id}","starred_url":"https://api.github.com/users/mrniko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrniko/subscriptions","organizations_url":"https://api.github.com/users/mrniko/orgs","repos_url":"https://api.github.com/users/mrniko/repos","events_url":"https://api.github.com/users/mrniko/events{/privacy}","received_events_url":"https://api.github.com/users/mrniko/received_events","type":"User","site_admin":false},"repo":{"id":3161748,"node_id":"MDEwOlJlcG9zaXRvcnkzMTYxNzQ4","name":"netty-socketio","full_name":"mrniko/netty-socketio","owner":{"login":"mrniko","id":1104661,"node_id":"MDQ6VXNlcjExMDQ2NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1104661?v=4","gravatar_id":"","url":"https://api.github.com/users/mrniko","html_url":"https://github.com/mrniko","followers_url":"https://api.github.com/users/mrniko/followers","following_url":"https://api.github.com/users/mrniko/following{/other_user}","gists_url":"https://api.github.com/users/mrniko/gists{/gist_id}","starred_url":"https://api.github.com/users/mrniko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrniko/subscriptions","organizations_url":"https://api.github.com/users/mrniko/orgs","repos_url":"https://api.github.com/users/mrniko/repos","events_url":"https://api.github.com/users/mrniko/events{/privacy}","received_events_url":"https://api.github.com/users/mrniko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrniko/netty-socketio","description":"Socket.IO server implemented on Java. Realtime java framework","fork":false,"url":"https://api.github.com/repos/mrniko/netty-socketio","forks_url":"https://api.github.com/repos/mrniko/netty-socketio/forks","keys_url":"https://api.github.com/repos/mrniko/netty-socketio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrniko/netty-socketio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrniko/netty-socketio/teams","hooks_url":"https://api.github.com/repos/mrniko/netty-socketio/hooks","issue_events_url":"https://api.github.com/repos/mrniko/netty-socketio/issues/events{/number}","events_url":"https://api.github.com/repos/mrniko/netty-socketio/events","assignees_url":"https://api.github.com/repos/mrniko/netty-socketio/assignees{/user}","branches_url":"https://api.github.com/repos/mrniko/netty-socketio/branches{/branch}","tags_url":"https://api.github.com/repos/mrniko/netty-socketio/tags","blobs_url":"https://api.github.com/repos/mrniko/netty-socketio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrniko/netty-socketio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrniko/netty-socketio/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrniko/netty-socketio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrniko/netty-socketio/statuses/{sha}","languages_url":"https://api.github.com/repos/mrniko/netty-socketio/languages","stargazers_url":"https://api.github.com/repos/mrniko/netty-socketio/stargazers","contributors_url":"https://api.github.com/repos/mrniko/netty-socketio/contributors","subscribers_url":"https://api.github.com/repos/mrniko/netty-socketio/subscribers","subscription_url":"https://api.github.com/repos/mrniko/netty-socketio/subscription","commits_url":"https://api.github.com/repos/mrniko/netty-socketio/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrniko/netty-socketio/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrniko/netty-socketio/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrniko/netty-socketio/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrniko/netty-socketio/contents/{+path}","compare_url":"https://api.github.com/repos/mrniko/netty-socketio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrniko/netty-socketio/merges","archive_url":"https://api.github.com/repos/mrniko/netty-socketio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrniko/netty-socketio/downloads","issues_url":"https://api.github.com/repos/mrniko/netty-socketio/issues{/number}","pulls_url":"https://api.github.com/repos/mrniko/netty-socketio/pulls{/number}","milestones_url":"https://api.github.com/repos/mrniko/netty-socketio/milestones{/number}","notifications_url":"https://api.github.com/repos/mrniko/netty-socketio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrniko/netty-socketio/labels{/name}","releases_url":"https://api.github.com/repos/mrniko/netty-socketio/releases{/id}","deployments_url":"https://api.github.com/repos/mrniko/netty-socketio/deployments","created_at":"2012-01-12T11:43:49Z","updated_at":"2018-07-04T08:54:21Z","pushed_at":"2018-07-04T07:47:10Z","git_url":"git://github.com/mrniko/netty-socketio.git","ssh_url":"git@github.com:mrniko/netty-socketio.git","clone_url":"https://github.com/mrniko/netty-socketio.git","svn_url":"https://github.com/mrniko/netty-socketio","homepage":"","size":1846,"stargazers_count":2851,"watchers_count":2851,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":867,"mirror_url":null,"archived":false,"open_issues_count":192,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":867,"open_issues":192,"watchers":2851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrniko/netty-socketio/pulls/572"},"html":{"href":"https://github.com/mrniko/netty-socketio/pull/572"},"issue":{"href":"https://api.github.com/repos/mrniko/netty-socketio/issues/572"},"comments":{"href":"https://api.github.com/repos/mrniko/netty-socketio/issues/572/comments"},"review_comments":{"href":"https://api.github.com/repos/mrniko/netty-socketio/pulls/572/comments"},"review_comment":{"href":"https://api.github.com/repos/mrniko/netty-socketio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrniko/netty-socketio/pulls/572/commits"},"statuses":{"href":"https://api.github.com/repos/mrniko/netty-socketio/statuses/9ed48eabff6689e791c345bad75c2ea970d725b0"}},"author_association":"NONE"}}
{"actor":{"display_login":"mrniko"}}