{"action":"created","comment":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/comments/226023087","pull_request_review_id":165739431,"id":226023087,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjAyMzA4Nw==","diff_hunk":"@@ -65,3 +67,19 @@ src_configure() {\n \t)\n \tcmake-utils_src_configure\n }\n+\n+src_install() {\n+\tcmake-utils_src_install\n+\n+\t# upstreams installs doc/ into a into a hardcoded directory\n+\tmv \"${ED}/usr/share/doc/${PN}\"/config \"${ED}/usr/share/doc/${P}\"\n+\trmdir \"${ED}/usr/share/doc/${PN}\"","path":"x11-misc/polybar/polybar-3.2.1.ebuild","position":39,"original_position":39,"commit_id":"398bbdc2c8b3fbd8dfaecef57ecc92787bec9367","original_commit_id":"398bbdc2c8b3fbd8dfaecef57ecc92787bec9367","user":{"login":"gyakovlev","id":168902,"node_id":"MDQ6VXNlcjE2ODkwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/168902?v=4","gravatar_id":"","url":"https://api.github.com/users/gyakovlev","html_url":"https://github.com/gyakovlev","followers_url":"https://api.github.com/users/gyakovlev/followers","following_url":"https://api.github.com/users/gyakovlev/following{/other_user}","gists_url":"https://api.github.com/users/gyakovlev/gists{/gist_id}","starred_url":"https://api.github.com/users/gyakovlev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyakovlev/subscriptions","organizations_url":"https://api.github.com/users/gyakovlev/orgs","repos_url":"https://api.github.com/users/gyakovlev/repos","events_url":"https://api.github.com/users/gyakovlev/events{/privacy}","received_events_url":"https://api.github.com/users/gyakovlev/received_events","type":"User","site_admin":false},"body":"missing `|| die` on both calls, but\r\ninstead of moving files around, this should work\r\n`-DCMAKE_INSTALL_DOCDIR=\"share/doc/${PF}\"`\r\n\r\npatch those lines to either respect above variable or `sed` it to install into desired location.\r\n\r\nhttps://github.com/jaagr/polybar/blob/134d33d1bb776d607ee89b181f93326f0482d87f/doc/CMakeLists.txt#L90-L92\r\n\r\nand it'll be very cool if you submit a patch upstream fixing hardcoded paths.\r\n\r\nbecause currently it creates both directories\r\n```\r\n/usr/share/doc/polybar-3.2.1/README.md.xz\r\n/usr/share/doc/polybar/config.xz\r\n```\r\n\r\nso just make it use versioned dir.\r\n\r\n","created_at":"2018-10-17T17:23:02Z","updated_at":"2018-10-17T17:33:35Z","html_url":"https://github.com/gentoo/gentoo/pull/10158#discussion_r226023087","pull_request_url":"https://api.github.com/repos/gentoo/gentoo/pulls/10158","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/comments/226023087"},"html":{"href":"https://github.com/gentoo/gentoo/pull/10158#discussion_r226023087"},"pull_request":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/10158"}}},"pull_request":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/10158","id":223298992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjk4OTky","html_url":"https://github.com/gentoo/gentoo/pull/10158","diff_url":"https://github.com/gentoo/gentoo/pull/10158.diff","patch_url":"https://github.com/gentoo/gentoo/pull/10158.patch","issue_url":"https://api.github.com/repos/gentoo/gentoo/issues/10158","number":10158,"state":"open","locked":false,"title":"x11-misc/polybar: Add {bash,zsh}-completion use flags","user":{"login":"hallabro","id":44033026,"node_id":"MDQ6VXNlcjQ0MDMzMDI2","avatar_url":"https://avatars0.githubusercontent.com/u/44033026?v=4","gravatar_id":"","url":"https://api.github.com/users/hallabro","html_url":"https://github.com/hallabro","followers_url":"https://api.github.com/users/hallabro/followers","following_url":"https://api.github.com/users/hallabro/following{/other_user}","gists_url":"https://api.github.com/users/hallabro/gists{/gist_id}","starred_url":"https://api.github.com/users/hallabro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallabro/subscriptions","organizations_url":"https://api.github.com/users/hallabro/orgs","repos_url":"https://api.github.com/users/hallabro/repos","events_url":"https://api.github.com/users/hallabro/events{/privacy}","received_events_url":"https://api.github.com/users/hallabro/received_events","type":"User","site_admin":false},"body":"* Add `{bash,zsh}-completion` use flags\r\n* Example config is properly installed into `${P}` instead pf `${PN}`","created_at":"2018-10-16T15:36:49Z","updated_at":"2018-10-17T17:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85ebacbfce47415552b108dc106d77fc1c70ae73","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":257560845,"node_id":"MDU6TGFiZWwyNTc1NjA4NDU=","url":"https://api.github.com/repos/gentoo/gentoo/labels/assigned","name":"assigned","color":"5319e7","default":false},{"id":740399504,"node_id":"MDU6TGFiZWw3NDAzOTk1MDQ=","url":"https://api.github.com/repos/gentoo/gentoo/labels/no%20bug%20found","name":"no bug found","color":"b78a0e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gentoo/gentoo/pulls/10158/commits","review_comments_url":"https://api.github.com/repos/gentoo/gentoo/pulls/10158/comments","review_comment_url":"https://api.github.com/repos/gentoo/gentoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gentoo/gentoo/issues/10158/comments","statuses_url":"https://api.github.com/repos/gentoo/gentoo/statuses/398bbdc2c8b3fbd8dfaecef57ecc92787bec9367","head":{"label":"hallabro:x11-misc/polybar","ref":"x11-misc/polybar","sha":"398bbdc2c8b3fbd8dfaecef57ecc92787bec9367","user":{"login":"hallabro","id":44033026,"node_id":"MDQ6VXNlcjQ0MDMzMDI2","avatar_url":"https://avatars0.githubusercontent.com/u/44033026?v=4","gravatar_id":"","url":"https://api.github.com/users/hallabro","html_url":"https://github.com/hallabro","followers_url":"https://api.github.com/users/hallabro/followers","following_url":"https://api.github.com/users/hallabro/following{/other_user}","gists_url":"https://api.github.com/users/hallabro/gists{/gist_id}","starred_url":"https://api.github.com/users/hallabro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallabro/subscriptions","organizations_url":"https://api.github.com/users/hallabro/orgs","repos_url":"https://api.github.com/users/hallabro/repos","events_url":"https://api.github.com/users/hallabro/events{/privacy}","received_events_url":"https://api.github.com/users/hallabro/received_events","type":"User","site_admin":false},"repo":{"id":153296489,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyOTY0ODk=","name":"gentoo","full_name":"hallabro/gentoo","private":false,"owner":{"login":"hallabro","id":44033026,"node_id":"MDQ6VXNlcjQ0MDMzMDI2","avatar_url":"https://avatars0.githubusercontent.com/u/44033026?v=4","gravatar_id":"","url":"https://api.github.com/users/hallabro","html_url":"https://github.com/hallabro","followers_url":"https://api.github.com/users/hallabro/followers","following_url":"https://api.github.com/users/hallabro/following{/other_user}","gists_url":"https://api.github.com/users/hallabro/gists{/gist_id}","starred_url":"https://api.github.com/users/hallabro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallabro/subscriptions","organizations_url":"https://api.github.com/users/hallabro/orgs","repos_url":"https://api.github.com/users/hallabro/repos","events_url":"https://api.github.com/users/hallabro/events{/privacy}","received_events_url":"https://api.github.com/users/hallabro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hallabro/gentoo","description":"The Gentoo ebuild repository mirror","fork":true,"url":"https://api.github.com/repos/hallabro/gentoo","forks_url":"https://api.github.com/repos/hallabro/gentoo/forks","keys_url":"https://api.github.com/repos/hallabro/gentoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hallabro/gentoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hallabro/gentoo/teams","hooks_url":"https://api.github.com/repos/hallabro/gentoo/hooks","issue_events_url":"https://api.github.com/repos/hallabro/gentoo/issues/events{/number}","events_url":"https://api.github.com/repos/hallabro/gentoo/events","assignees_url":"https://api.github.com/repos/hallabro/gentoo/assignees{/user}","branches_url":"https://api.github.com/repos/hallabro/gentoo/branches{/branch}","tags_url":"https://api.github.com/repos/hallabro/gentoo/tags","blobs_url":"https://api.github.com/repos/hallabro/gentoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hallabro/gentoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hallabro/gentoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/hallabro/gentoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hallabro/gentoo/statuses/{sha}","languages_url":"https://api.github.com/repos/hallabro/gentoo/languages","stargazers_url":"https://api.github.com/repos/hallabro/gentoo/stargazers","contributors_url":"https://api.github.com/repos/hallabro/gentoo/contributors","subscribers_url":"https://api.github.com/repos/hallabro/gentoo/subscribers","subscription_url":"https://api.github.com/repos/hallabro/gentoo/subscription","commits_url":"https://api.github.com/repos/hallabro/gentoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/hallabro/gentoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/hallabro/gentoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/hallabro/gentoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/hallabro/gentoo/contents/{+path}","compare_url":"https://api.github.com/repos/hallabro/gentoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hallabro/gentoo/merges","archive_url":"https://api.github.com/repos/hallabro/gentoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hallabro/gentoo/downloads","issues_url":"https://api.github.com/repos/hallabro/gentoo/issues{/number}","pulls_url":"https://api.github.com/repos/hallabro/gentoo/pulls{/number}","milestones_url":"https://api.github.com/repos/hallabro/gentoo/milestones{/number}","notifications_url":"https://api.github.com/repos/hallabro/gentoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hallabro/gentoo/labels{/name}","releases_url":"https://api.github.com/repos/hallabro/gentoo/releases{/id}","deployments_url":"https://api.github.com/repos/hallabro/gentoo/deployments","created_at":"2018-10-16T14:08:03Z","updated_at":"2018-10-16T14:10:02Z","pushed_at":"2018-10-16T16:14:38Z","git_url":"git://github.com/hallabro/gentoo.git","ssh_url":"git@github.com:hallabro/gentoo.git","clone_url":"https://github.com/hallabro/gentoo.git","svn_url":"https://github.com/hallabro/gentoo","homepage":"https://www.gentoo.org","size":581900,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gentoo:master","ref":"master","sha":"9f42bca0ef67645dad2c6aaac71aef0f37f549aa","user":{"login":"gentoo","id":52242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjQy","avatar_url":"https://avatars3.githubusercontent.com/u/52242?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"repo":{"id":40499714,"node_id":"MDEwOlJlcG9zaXRvcnk0MDQ5OTcxNA==","name":"gentoo","full_name":"gentoo/gentoo","private":false,"owner":{"login":"gentoo","id":52242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjQy","avatar_url":"https://avatars3.githubusercontent.com/u/52242?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gentoo/gentoo","description":"The Gentoo ebuild repository mirror","fork":false,"url":"https://api.github.com/repos/gentoo/gentoo","forks_url":"https://api.github.com/repos/gentoo/gentoo/forks","keys_url":"https://api.github.com/repos/gentoo/gentoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gentoo/gentoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gentoo/gentoo/teams","hooks_url":"https://api.github.com/repos/gentoo/gentoo/hooks","issue_events_url":"https://api.github.com/repos/gentoo/gentoo/issues/events{/number}","events_url":"https://api.github.com/repos/gentoo/gentoo/events","assignees_url":"https://api.github.com/repos/gentoo/gentoo/assignees{/user}","branches_url":"https://api.github.com/repos/gentoo/gentoo/branches{/branch}","tags_url":"https://api.github.com/repos/gentoo/gentoo/tags","blobs_url":"https://api.github.com/repos/gentoo/gentoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gentoo/gentoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gentoo/gentoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gentoo/gentoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gentoo/gentoo/statuses/{sha}","languages_url":"https://api.github.com/repos/gentoo/gentoo/languages","stargazers_url":"https://api.github.com/repos/gentoo/gentoo/stargazers","contributors_url":"https://api.github.com/repos/gentoo/gentoo/contributors","subscribers_url":"https://api.github.com/repos/gentoo/gentoo/subscribers","subscription_url":"https://api.github.com/repos/gentoo/gentoo/subscription","commits_url":"https://api.github.com/repos/gentoo/gentoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gentoo/gentoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gentoo/gentoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gentoo/gentoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gentoo/gentoo/contents/{+path}","compare_url":"https://api.github.com/repos/gentoo/gentoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gentoo/gentoo/merges","archive_url":"https://api.github.com/repos/gentoo/gentoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gentoo/gentoo/downloads","issues_url":"https://api.github.com/repos/gentoo/gentoo/issues{/number}","pulls_url":"https://api.github.com/repos/gentoo/gentoo/pulls{/number}","milestones_url":"https://api.github.com/repos/gentoo/gentoo/milestones{/number}","notifications_url":"https://api.github.com/repos/gentoo/gentoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gentoo/gentoo/labels{/name}","releases_url":"https://api.github.com/repos/gentoo/gentoo/releases{/id}","deployments_url":"https://api.github.com/repos/gentoo/gentoo/deployments","created_at":"2015-08-10T18:47:32Z","updated_at":"2018-10-17T17:33:18Z","pushed_at":"2018-10-17T17:32:22Z","git_url":"git://github.com/gentoo/gentoo.git","ssh_url":"git@github.com:gentoo/gentoo.git","clone_url":"https://github.com/gentoo/gentoo.git","svn_url":"https://github.com/gentoo/gentoo","homepage":"https://www.gentoo.org","size":582535,"stargazers_count":919,"watchers_count":919,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":836,"mirror_url":null,"archived":false,"open_issues_count":203,"license":null,"forks":836,"open_issues":203,"watchers":919,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/10158"},"html":{"href":"https://github.com/gentoo/gentoo/pull/10158"},"issue":{"href":"https://api.github.com/repos/gentoo/gentoo/issues/10158"},"comments":{"href":"https://api.github.com/repos/gentoo/gentoo/issues/10158/comments"},"review_comments":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/10158/comments"},"review_comment":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/10158/commits"},"statuses":{"href":"https://api.github.com/repos/gentoo/gentoo/statuses/398bbdc2c8b3fbd8dfaecef57ecc92787bec9367"}},"author_association":"NONE"}}
{"actor":{"display_login":"gyakovlev"}}