{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11526","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11526/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11526/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11526/events","html_url":"https://github.com/bitcoin/bitcoin/pull/11526","id":266792436,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQ3NTE4NDEz","number":11526,"title":"Visual Studio build configuration for Bitcoin Core","user":{"login":"sipsorcery","id":197660,"node_id":"MDQ6VXNlcjE5NzY2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/197660?v=4","gravatar_id":"","url":"https://api.github.com/users/sipsorcery","html_url":"https://github.com/sipsorcery","followers_url":"https://api.github.com/users/sipsorcery/followers","following_url":"https://api.github.com/users/sipsorcery/following{/other_user}","gists_url":"https://api.github.com/users/sipsorcery/gists{/gist_id}","starred_url":"https://api.github.com/users/sipsorcery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipsorcery/subscriptions","organizations_url":"https://api.github.com/users/sipsorcery/orgs","repos_url":"https://api.github.com/users/sipsorcery/repos","events_url":"https://api.github.com/users/sipsorcery/events{/privacy}","received_events_url":"https://api.github.com/users/sipsorcery/received_events","type":"User","site_admin":false},"labels":[{"id":234877,"node_id":"MDU6TGFiZWwyMzQ4Nzc=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Windows","name":"Windows","color":"884400","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":67,"created_at":"2017-10-19T10:21:33Z","updated_at":"2018-08-08T13:10:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11526","html_url":"https://github.com/bitcoin/bitcoin/pull/11526","diff_url":"https://github.com/bitcoin/bitcoin/pull/11526.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/11526.patch"},"body":"This PR allows Bitcoin Core to be relatively easily built with Visual Studio 2017. It's anticipated that it could be useful for devs familiar with Visual Studio and Microsoft's tooling. In particular the ability to use the VS debugger is a big benefit.\r\n\r\n~~Caveats:~~\r\n- ~~There are some minor code changes required on Bitcoin Core in order for msvc to be able to successfully compile. I'll submit them in a separate PR, The code changes are available in #11528 #11558 and #11562~~.\r\n- ~~The vcpkg for SECP256K1 has not yet been accepted by Microsoft. The files are available from this [PR](https://github.com/Microsoft/vcpkg/pull/2005) and should be copied into a vcpkg/ports/secp256k1 directory prior to vcpkg install steps.~~\r\n\r\n**Update:** For anyone wishing to test out the Visual Studio build with the various open pull requests the steps are:\r\n\r\n- Clone and build [Vcpkg](https://github.com/Microsoft/vcpkg) (Microsoft's new open source C/C++ package manager)\r\n    - git clone https://github.com/Microsoft/vcpkg\r\n    - .\\bootstrap-vcpkg.bat\r\n- Set up Visual Studio to automatically reference vcpkg installs: .\\vcpkg integrate install\r\n- Install the required packages (replace x86 with x64 as required):\r\n    - vcpkg install boost:x86-windows-static\r\n    - vcpkg install libevent:x86-windows-static\r\n    - vcpkg install openssl:x86-windows-static\r\n    - vcpkg install zeromq:x86-windows-static\r\n    - vcpkg install berkeleydb:x86-windows-static\r\n    - vcpkg install secp256k1:x86-windows-static\r\n    - vcpkg install leveldb:x86-windows-static\r\n- git clone https://github.com/bitcoin/bitcoin.git\r\n- git checkout -b testbuild\r\n- git pull origin pull/11526/head # Visual Studio build configuration for Bitcoin Core\r\n- ~~git pull origin pull/11558/head # Minimal code changes to allow msvc compilation~~\r\n- ~~git pull origin pull/11562/head # bench: use std::chrono rather than gettimeofday~~\r\n- ~~Copy and unzip attached bitcoin-config.h to src/config, edit as required [bitcoin-config.zip](https://github.com/bitcoin/bitcoin/files/1429484/bitcoin-config.zip)~~\r\n- ~~git pull origin pull/13031/head # gmtime fix for msvc~~\r\n- Build the Visual Studio solution which, if successful, will result in all but the Qt dependent libraries/programs being built. If the build fails please add a comment.\r\n"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/411399255","html_url":"https://github.com/bitcoin/bitcoin/pull/11526#issuecomment-411399255","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11526","id":411399255,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTM5OTI1NQ==","user":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T13:10:02Z","updated_at":"2018-08-08T13:10:02Z","author_association":"MEMBER","body":"Could you please squash the commits a bit to get rid of the intermediate merge commit? For example something like this:\r\n\r\n```\r\ngit fetch upstream\r\ngit merge upstream/master\r\ngit reset --soft upstream/master\r\ngit commit -m \"Visual Studio build configuration for Bitcoin Core\"\r\ngit push origin build_msvc -f"}}
{"actor":{"display_login":"MarcoFalke"}}