{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1917","repository_url":"https://api.github.com/repos/apache/incubator-dubbo","labels_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1917/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1917/comments","events_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1917/events","html_url":"https://github.com/apache/incubator-dubbo/issues/1917","id":331129789,"node_id":"MDU6SXNzdWUzMzExMjk3ODk=","number":1917,"title":"Condition is not properly used ?","user":{"login":"SoyeeDst","id":17094236,"node_id":"MDQ6VXNlcjE3MDk0MjM2","avatar_url":"https://avatars2.githubusercontent.com/u/17094236?v=4","gravatar_id":"","url":"https://api.github.com/users/SoyeeDst","html_url":"https://github.com/SoyeeDst","followers_url":"https://api.github.com/users/SoyeeDst/followers","following_url":"https://api.github.com/users/SoyeeDst/following{/other_user}","gists_url":"https://api.github.com/users/SoyeeDst/gists{/gist_id}","starred_url":"https://api.github.com/users/SoyeeDst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SoyeeDst/subscriptions","organizations_url":"https://api.github.com/users/SoyeeDst/orgs","repos_url":"https://api.github.com/users/SoyeeDst/repos","events_url":"https://api.github.com/users/SoyeeDst/events{/privacy}","received_events_url":"https://api.github.com/users/SoyeeDst/received_events","type":"User","site_admin":false},"labels":[{"id":717526953,"node_id":"MDU6TGFiZWw3MTc1MjY5NTM=","url":"https://api.github.com/repos/apache/incubator-dubbo/labels/good%20first%20issue","name":"good first issue","color":"0e8a16","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-11T10:22:39Z","updated_at":"2018-12-29T05:39:36Z","closed_at":null,"author_association":"NONE","body":"https://github.com/apache/incubator-dubbo/blob/3e9b66854c6f70b1dfa7dd19e689bd04ae0ecb41/dubbo-registry/dubbo-registry-redis/src/main/java/com/alibaba/dubbo/registry/redis/RedisRegistry.java#L590\r\n\r\nhttps://github.com/apache/incubator-dubbo/blob/3e9b66854c6f70b1dfa7dd19e689bd04ae0ecb41/dubbo-registry/dubbo-registry-redis/src/main/java/com/alibaba/dubbo/registry/redis/RedisRegistry.java#L602\r\n\r\nJust read the RedisRegistry.java and got doubtful about the above lines. Is the following code more appropriate ?\r\n\r\n```\r\nif (first) {\r\n   // blah blah\t\t\t\t\t\t\t\t\t\t\t\t\r\n} \r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-dubbo/issues/comments/450467504","html_url":"https://github.com/apache/incubator-dubbo/issues/1917#issuecomment-450467504","issue_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1917","id":450467504,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDQ2NzUwNA==","user":{"login":"CrazyHZM","id":19588788,"node_id":"MDQ6VXNlcjE5NTg4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/19588788?v=4","gravatar_id":"","url":"https://api.github.com/users/CrazyHZM","html_url":"https://github.com/CrazyHZM","followers_url":"https://api.github.com/users/CrazyHZM/followers","following_url":"https://api.github.com/users/CrazyHZM/following{/other_user}","gists_url":"https://api.github.com/users/CrazyHZM/gists{/gist_id}","starred_url":"https://api.github.com/users/CrazyHZM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrazyHZM/subscriptions","organizations_url":"https://api.github.com/users/CrazyHZM/orgs","repos_url":"https://api.github.com/users/CrazyHZM/repos","events_url":"https://api.github.com/users/CrazyHZM/events{/privacy}","received_events_url":"https://api.github.com/users/CrazyHZM/received_events","type":"User","site_admin":false},"created_at":"2018-12-29T05:39:36Z","updated_at":"2018-12-29T05:39:36Z","author_association":"CONTRIBUTOR","body":"if there is an exception in the subscription to Redis, when the disconnection is successful, we can think that the Redis connection is broken, we need to re-initiate the subscription, and we need to get the latest data from Redis again. But in JedisPool, no connection monitoring mechanism is provided.\r\nThe first attribute is to achieve the effect of connection monitoring.\r\nIf my idea is correct, I will submit  the PR to fix it #3087"}}
{"actor":{"display_login":"CrazyHZM"}}