{"action":"created","issue":{"url":"https://api.github.com/repos/mui-org/material-ui/issues/11854","repository_url":"https://api.github.com/repos/mui-org/material-ui","labels_url":"https://api.github.com/repos/mui-org/material-ui/issues/11854/labels{/name}","comments_url":"https://api.github.com/repos/mui-org/material-ui/issues/11854/comments","events_url":"https://api.github.com/repos/mui-org/material-ui/issues/11854/events","html_url":"https://github.com/mui-org/material-ui/issues/11854","id":332309031,"node_id":"MDU6SXNzdWUzMzIzMDkwMzE=","number":11854,"title":"[ButtonBase] Proptype warning when passing the component prop","user":{"login":"jgoux","id":1443499,"node_id":"MDQ6VXNlcjE0NDM0OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1443499?v=4","gravatar_id":"","url":"https://api.github.com/users/jgoux","html_url":"https://github.com/jgoux","followers_url":"https://api.github.com/users/jgoux/followers","following_url":"https://api.github.com/users/jgoux/following{/other_user}","gists_url":"https://api.github.com/users/jgoux/gists{/gist_id}","starred_url":"https://api.github.com/users/jgoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgoux/subscriptions","organizations_url":"https://api.github.com/users/jgoux/orgs","repos_url":"https://api.github.com/users/jgoux/repos","events_url":"https://api.github.com/users/jgoux/events{/privacy}","received_events_url":"https://api.github.com/users/jgoux/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-14T08:53:27Z","updated_at":"2018-06-14T10:03:10Z","closed_at":"2018-06-14T10:03:10Z","author_association":"NONE","body":"Hello,\r\n\r\n<!--- Provide a general summary of the issue in the Title above -->\r\n\r\n<!--\r\n    Thank you very much for contributing to Material-UI by creating an issue! ❤️\r\n    To avoid duplicate issues we ask you to check off the following list.\r\n-->\r\n\r\n<!-- Checked checkbox should look like this: [x] -->\r\n- [x] This is a v1.x issue (v0.x is no longer maintained).\r\n- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.\r\n\r\n## Expected Behavior\r\n<!---\r\n    If you're describing a bug, tell us what should happen.\r\n    If you're suggesting a change/improvement, tell us how it should work.\r\n-->\r\nThe `ButtonBase` component shouldn't trigger a warning when passing a value to its `component` prop.\r\n## Current Behavior\r\n<!---\r\n    If describing a bug, tell us what happens instead of the expected behavior.\r\n    If suggesting a change/improvement, explain the difference from current behavior.\r\n-->\r\nA warning is triggered : `Warning: Failed prop type: Invalid prop component supplied to ButtonBase.`\r\n## Steps to Reproduce (for bugs)\r\n<!---\r\n    Provide a link to a live example (you can use codesandbox.io) and an unambiguous set of steps to reproduce this bug.\r\n    Include code to reproduce, if relevant (which it most likely is).\r\n\r\n    This codesandbox.io template _may_ be a good starting point:\r\n    https://codesandbox.io/s/github/mui-org/material-ui/tree/master/examples/create-react-app\r\n\r\n\r\n    If YOU DO NOT take time to provide a codesandbox.io reproduction, should the COMMUNITY take time to help you?\r\n\r\n-->\r\n\r\nhttps://codesandbox.io/s/w6ln223vz5\r\n\r\n## Context\r\n<!---\r\n    How has this issue affected you? What are you trying to accomplish?\r\n    Providing context helps us come up with a solution that is most useful in the real world.\r\n-->\r\n\r\n## Your Environment\r\n<!--- Include as many relevant details about the environment with which you experienced the bug. -->\r\n\r\n| Tech         | Version |\r\n|--------------|---------|\r\n| Material-UI  | v1.2.1 |\r\n| React        |  v16.3.2  |\r\n"},"comment":{"url":"https://api.github.com/repos/mui-org/material-ui/issues/comments/397241933","html_url":"https://github.com/mui-org/material-ui/issues/11854#issuecomment-397241933","issue_url":"https://api.github.com/repos/mui-org/material-ui/issues/11854","id":397241933,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzI0MTkzMw==","user":{"login":"jgoux","id":1443499,"node_id":"MDQ6VXNlcjE0NDM0OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1443499?v=4","gravatar_id":"","url":"https://api.github.com/users/jgoux","html_url":"https://github.com/jgoux","followers_url":"https://api.github.com/users/jgoux/followers","following_url":"https://api.github.com/users/jgoux/following{/other_user}","gists_url":"https://api.github.com/users/jgoux/gists{/gist_id}","starred_url":"https://api.github.com/users/jgoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgoux/subscriptions","organizations_url":"https://api.github.com/users/jgoux/orgs","repos_url":"https://api.github.com/users/jgoux/repos","events_url":"https://api.github.com/users/jgoux/events{/privacy}","received_events_url":"https://api.github.com/users/jgoux/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T10:03:10Z","updated_at":"2018-06-14T10:03:10Z","author_association":"NONE","body":"Indeed! I'm ok with this solution, thanks a lot Olivier. 😉 "}}
{"actor":{"display_login":"jgoux"}}