{"action":"created","issue":{"url":"https://api.github.com/repos/catchorg/Catch2/issues/1474","repository_url":"https://api.github.com/repos/catchorg/Catch2","labels_url":"https://api.github.com/repos/catchorg/Catch2/issues/1474/labels{/name}","comments_url":"https://api.github.com/repos/catchorg/Catch2/issues/1474/comments","events_url":"https://api.github.com/repos/catchorg/Catch2/issues/1474/events","html_url":"https://github.com/catchorg/Catch2/pull/1474","id":391959038,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MzM3MjIz","number":1474,"title":"Remove redundant move","user":{"login":"kraj","id":465279,"node_id":"MDQ6VXNlcjQ2NTI3OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/465279?v=4","gravatar_id":"","url":"https://api.github.com/users/kraj","html_url":"https://github.com/kraj","followers_url":"https://api.github.com/users/kraj/followers","following_url":"https://api.github.com/users/kraj/following{/other_user}","gists_url":"https://api.github.com/users/kraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraj/subscriptions","organizations_url":"https://api.github.com/users/kraj/orgs","repos_url":"https://api.github.com/users/kraj/repos","events_url":"https://api.github.com/users/kraj/events{/privacy}","received_events_url":"https://api.github.com/users/kraj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-18T01:30:05Z","updated_at":"2018-12-27T15:08:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/catchorg/Catch2/pulls/1474","html_url":"https://github.com/catchorg/Catch2/pull/1474","diff_url":"https://github.com/catchorg/Catch2/pull/1474.diff","patch_url":"https://github.com/catchorg/Catch2/pull/1474.patch"},"body":"fixes errors like below\r\n\r\n/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/catch2/2.5.0-r0/git/include/internal/catch_session.cpp:52:29:\r\nerror: redundant move in return statement [-Werror=redundant-move]\r\n   52 |             return std::move(multi);\r\n      |                    ~~~~~~~~~^~~~~~~\r\n/mnt/a/yoe/build/tmp/work/aarch64-yoe-linux-musl/catch2/2.5.0-r0/git/include/internal/catch_session.cpp:52:29:\r\nnote: remove 'std::move' call\r\n\r\nSigned-off-by: Khem Raj <raj.khem@gmail.com>\r\n\r\n<!--\r\nPlease do not submit pull requests changing the `version.hpp`\r\nor the single-include `catch.hpp` file, these are changed\r\nonly when a new release is made.\r\n\r\nBefore submitting a PR you should probably read the contributor documentation\r\nat docs/contributing.md. It will tell you how to properly test your changes.\r\n-->\r\n\r\n\r\n## Description\r\n<!--\r\nDescribe the what and the why of your pull request. Remember that these two\r\nare usually a bit different. As an example, if you have made various changes\r\nto decrease the number of new strings allocated, thats what. The why probably\r\nwas that you have a large set of tests and found that this speeds them up.\r\n-->\r\n\r\n## GitHub Issues\r\n<!-- \r\nIf this PR was motivated by some existing issues, reference them here.\r\n\r\nIf it is a simple bug-fix, please also add a line like 'Closes #123'\r\nto your commit message, so that it is automatically closed.\r\nIf it is not, don't, as it might take several iterations for a feature\r\nto be done properly. If in doubt, leave it open and reference it in the\r\nPR itself, so that maintainers can decide.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/catchorg/Catch2/issues/comments/450167708","html_url":"https://github.com/catchorg/Catch2/pull/1474#issuecomment-450167708","issue_url":"https://api.github.com/repos/catchorg/Catch2/issues/1474","id":450167708,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDE2NzcwOA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-27T15:08:12Z","updated_at":"2018-12-27T15:08:12Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/catchorg/Catch2/pull/1474?src=pr&el=h1) Report\n> Merging [#1474](https://codecov.io/gh/catchorg/Catch2/pull/1474?src=pr&el=desc) into [master](https://codecov.io/gh/catchorg/Catch2/commit/461843b1f02a4bf5c59db88ff201d2c56fabf3a4?src=pr&el=desc) will **increase** coverage by `0.04%`.\n> The diff coverage is `100%`.\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1474      +/-   ##\n==========================================\n+ Coverage   80.38%   80.42%   +0.04%     \n==========================================\n  Files         121      121              \n  Lines        3425     3422       -3     \n==========================================\n- Hits         2753     2752       -1     \n+ Misses        672      670       -2\n```\n"}}
{"actor":{"display_login":"codecov"}}