{"action":"created","comment":{"url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/comments/192627368","pull_request_review_id":125436109,"id":192627368,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjYyNzM2OA==","diff_hunk":"@@ -339,15 +339,15 @@ private void BuildTree(DNNNode objNode, bool blnPODRequest)\n             {\n                 if (!string.IsNullOrEmpty(Level))\n                 {\n-                    switch (Level.ToLower())\n+                    switch (Level.ToLowerInvariant())\n                     {\n                         case \"root\":\n                             break;\n                         case \"child\":\n                             blnAddUpNode = true;\n                             break;\n                         default:\n-                            if (Level.ToLower() != \"root\" && PortalSettings.ActiveTab.BreadCrumbs.Count > 1)\n+                            if (Level.ToLowerInvariant() != \"root\" && PortalSettings.ActiveTab.BreadCrumbs.Count > 1)","path":"Website/admin/Skins/TreeViewMenu.ascx.cs","position":14,"original_position":14,"commit_id":"d31976999bf049e5e733ed214414fbb8dd275e87","original_commit_id":"d31976999bf049e5e733ed214414fbb8dd275e87","user":{"login":"tpluscode","id":588128,"node_id":"MDQ6VXNlcjU4ODEyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/588128?v=4","gravatar_id":"","url":"https://api.github.com/users/tpluscode","html_url":"https://github.com/tpluscode","followers_url":"https://api.github.com/users/tpluscode/followers","following_url":"https://api.github.com/users/tpluscode/following{/other_user}","gists_url":"https://api.github.com/users/tpluscode/gists{/gist_id}","starred_url":"https://api.github.com/users/tpluscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpluscode/subscriptions","organizations_url":"https://api.github.com/users/tpluscode/orgs","repos_url":"https://api.github.com/users/tpluscode/repos","events_url":"https://api.github.com/users/tpluscode/events{/privacy}","received_events_url":"https://api.github.com/users/tpluscode/received_events","type":"User","site_admin":false},"body":"Why was it hard to review? Which issue was that? I shall think that the diffs will be pretty much the same. One line removed, one line added.\r\n\r\nAnd I don't understand your argument. In terms of functionality, the two alternatives yield same result\r\n\r\n```c#\r\nLevel.ToLower() != \"root\"\r\n\"root\".Equals(Level, StringComparison.InvariantCultureIgnoreCase) == false\r\n```\r\n\r\nThe latter is just more efficient. Given how many of those we have it could make quite a bit of a difference.","created_at":"2018-06-04T05:00:50Z","updated_at":"2018-06-04T05:00:50Z","html_url":"https://github.com/dnnsoftware/Dnn.Platform/pull/2083#discussion_r192627368","pull_request_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/2083","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/comments/192627368"},"html":{"href":"https://github.com/dnnsoftware/Dnn.Platform/pull/2083#discussion_r192627368"},"pull_request":{"href":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/2083"}},"in_reply_to_id":192326128},"pull_request":{"url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/2083","id":191654834,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjU0ODM0","html_url":"https://github.com/dnnsoftware/Dnn.Platform/pull/2083","diff_url":"https://github.com/dnnsoftware/Dnn.Platform/pull/2083.diff","patch_url":"https://github.com/dnnsoftware/Dnn.Platform/pull/2083.patch","issue_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/2083","number":2083,"state":"open","locked":false,"title":"DNN-20802: use ToLowerInvariant instead of ToLower.","user":{"login":"zyhfish","id":3364448,"node_id":"MDQ6VXNlcjMzNjQ0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3364448?v=4","gravatar_id":"","url":"https://api.github.com/users/zyhfish","html_url":"https://github.com/zyhfish","followers_url":"https://api.github.com/users/zyhfish/followers","following_url":"https://api.github.com/users/zyhfish/following{/other_user}","gists_url":"https://api.github.com/users/zyhfish/gists{/gist_id}","starred_url":"https://api.github.com/users/zyhfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyhfish/subscriptions","organizations_url":"https://api.github.com/users/zyhfish/orgs","repos_url":"https://api.github.com/users/zyhfish/repos","events_url":"https://api.github.com/users/zyhfish/events{/privacy}","received_events_url":"https://api.github.com/users/zyhfish/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-31T06:24:28Z","updated_at":"2018-06-04T05:00:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4dcf4fdc7beb92e07e77e070815fc997e277438","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/2083/commits","review_comments_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/2083/comments","review_comment_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/2083/comments","statuses_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/statuses/d31976999bf049e5e733ed214414fbb8dd275e87","head":{"label":"dnnsoftware:bug/DNN-20802","ref":"bug/DNN-20802","sha":"d31976999bf049e5e733ed214414fbb8dd275e87","user":{"login":"dnnsoftware","id":5099054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTkwNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5099054?v=4","gravatar_id":"","url":"https://api.github.com/users/dnnsoftware","html_url":"https://github.com/dnnsoftware","followers_url":"https://api.github.com/users/dnnsoftware/followers","following_url":"https://api.github.com/users/dnnsoftware/following{/other_user}","gists_url":"https://api.github.com/users/dnnsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/dnnsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnnsoftware/subscriptions","organizations_url":"https://api.github.com/users/dnnsoftware/orgs","repos_url":"https://api.github.com/users/dnnsoftware/repos","events_url":"https://api.github.com/users/dnnsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/dnnsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":12095044,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NTA0NA==","name":"Dnn.Platform","full_name":"dnnsoftware/Dnn.Platform","owner":{"login":"dnnsoftware","id":5099054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTkwNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5099054?v=4","gravatar_id":"","url":"https://api.github.com/users/dnnsoftware","html_url":"https://github.com/dnnsoftware","followers_url":"https://api.github.com/users/dnnsoftware/followers","following_url":"https://api.github.com/users/dnnsoftware/following{/other_user}","gists_url":"https://api.github.com/users/dnnsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/dnnsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnnsoftware/subscriptions","organizations_url":"https://api.github.com/users/dnnsoftware/orgs","repos_url":"https://api.github.com/users/dnnsoftware/repos","events_url":"https://api.github.com/users/dnnsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/dnnsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dnnsoftware/Dnn.Platform","description":"DNN Corp Platform Repository.","fork":false,"url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform","forks_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/forks","keys_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/teams","hooks_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/hooks","issue_events_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/events{/number}","events_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/events","assignees_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/assignees{/user}","branches_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/branches{/branch}","tags_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/tags","blobs_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/languages","stargazers_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/stargazers","contributors_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/contributors","subscribers_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/subscribers","subscription_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/subscription","commits_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/contents/{+path}","compare_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/merges","archive_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/downloads","issues_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues{/number}","pulls_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/labels{/name}","releases_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/releases{/id}","deployments_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/deployments","created_at":"2013-08-13T22:58:08Z","updated_at":"2018-06-01T10:52:48Z","pushed_at":"2018-06-02T09:44:40Z","git_url":"git://github.com/dnnsoftware/Dnn.Platform.git","ssh_url":"git@github.com:dnnsoftware/Dnn.Platform.git","clone_url":"https://github.com/dnnsoftware/Dnn.Platform.git","svn_url":"https://github.com/dnnsoftware/Dnn.Platform","homepage":null,"size":738188,"stargazers_count":467,"watchers_count":467,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":393,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":393,"open_issues":45,"watchers":467,"default_branch":"development"}},"base":{"label":"dnnsoftware:development","ref":"development","sha":"06ed6d018a206083f4f4acd10169af71f79737e3","user":{"login":"dnnsoftware","id":5099054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTkwNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5099054?v=4","gravatar_id":"","url":"https://api.github.com/users/dnnsoftware","html_url":"https://github.com/dnnsoftware","followers_url":"https://api.github.com/users/dnnsoftware/followers","following_url":"https://api.github.com/users/dnnsoftware/following{/other_user}","gists_url":"https://api.github.com/users/dnnsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/dnnsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnnsoftware/subscriptions","organizations_url":"https://api.github.com/users/dnnsoftware/orgs","repos_url":"https://api.github.com/users/dnnsoftware/repos","events_url":"https://api.github.com/users/dnnsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/dnnsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":12095044,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NTA0NA==","name":"Dnn.Platform","full_name":"dnnsoftware/Dnn.Platform","owner":{"login":"dnnsoftware","id":5099054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTkwNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5099054?v=4","gravatar_id":"","url":"https://api.github.com/users/dnnsoftware","html_url":"https://github.com/dnnsoftware","followers_url":"https://api.github.com/users/dnnsoftware/followers","following_url":"https://api.github.com/users/dnnsoftware/following{/other_user}","gists_url":"https://api.github.com/users/dnnsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/dnnsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnnsoftware/subscriptions","organizations_url":"https://api.github.com/users/dnnsoftware/orgs","repos_url":"https://api.github.com/users/dnnsoftware/repos","events_url":"https://api.github.com/users/dnnsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/dnnsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dnnsoftware/Dnn.Platform","description":"DNN Corp Platform Repository.","fork":false,"url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform","forks_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/forks","keys_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/teams","hooks_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/hooks","issue_events_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/events{/number}","events_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/events","assignees_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/assignees{/user}","branches_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/branches{/branch}","tags_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/tags","blobs_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/languages","stargazers_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/stargazers","contributors_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/contributors","subscribers_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/subscribers","subscription_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/subscription","commits_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/contents/{+path}","compare_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/merges","archive_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/downloads","issues_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues{/number}","pulls_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/labels{/name}","releases_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/releases{/id}","deployments_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/deployments","created_at":"2013-08-13T22:58:08Z","updated_at":"2018-06-01T10:52:48Z","pushed_at":"2018-06-02T09:44:40Z","git_url":"git://github.com/dnnsoftware/Dnn.Platform.git","ssh_url":"git@github.com:dnnsoftware/Dnn.Platform.git","clone_url":"https://github.com/dnnsoftware/Dnn.Platform.git","svn_url":"https://github.com/dnnsoftware/Dnn.Platform","homepage":null,"size":738188,"stargazers_count":467,"watchers_count":467,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":393,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":393,"open_issues":45,"watchers":467,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/2083"},"html":{"href":"https://github.com/dnnsoftware/Dnn.Platform/pull/2083"},"issue":{"href":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/2083"},"comments":{"href":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/2083/comments"},"review_comments":{"href":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/2083/comments"},"review_comment":{"href":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/2083/commits"},"statuses":{"href":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/statuses/d31976999bf049e5e733ed214414fbb8dd275e87"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tpluscode"}}