{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7837","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7837/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7837/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7837/events","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7837","id":328263015,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODQ3OTc2","number":7837,"title":"Added documentation and methods","user":{"login":"ThodwrisKanellopoulos","id":22801260,"node_id":"MDQ6VXNlcjIyODAxMjYw","avatar_url":"https://avatars0.githubusercontent.com/u/22801260?v=4","gravatar_id":"","url":"https://api.github.com/users/ThodwrisKanellopoulos","html_url":"https://github.com/ThodwrisKanellopoulos","followers_url":"https://api.github.com/users/ThodwrisKanellopoulos/followers","following_url":"https://api.github.com/users/ThodwrisKanellopoulos/following{/other_user}","gists_url":"https://api.github.com/users/ThodwrisKanellopoulos/gists{/gist_id}","starred_url":"https://api.github.com/users/ThodwrisKanellopoulos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThodwrisKanellopoulos/subscriptions","organizations_url":"https://api.github.com/users/ThodwrisKanellopoulos/orgs","repos_url":"https://api.github.com/users/ThodwrisKanellopoulos/repos","events_url":"https://api.github.com/users/ThodwrisKanellopoulos/events{/privacy}","received_events_url":"https://api.github.com/users/ThodwrisKanellopoulos/received_events","type":"User","site_admin":false},"labels":[{"id":90791782,"node_id":"MDU6TGFiZWw5MDc5MTc4Mg==","url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Notifications","name":"Notifications","color":"006b75","default":false},{"id":211243162,"node_id":"MDU6TGFiZWwyMTEyNDMxNjI=","url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/[Status]%20Needs%20Code%20Review","name":"[Status] Needs Code Review","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"oguzkocer","id":662023,"node_id":"MDQ6VXNlcjY2MjAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/662023?v=4","gravatar_id":"","url":"https://api.github.com/users/oguzkocer","html_url":"https://github.com/oguzkocer","followers_url":"https://api.github.com/users/oguzkocer/followers","following_url":"https://api.github.com/users/oguzkocer/following{/other_user}","gists_url":"https://api.github.com/users/oguzkocer/gists{/gist_id}","starred_url":"https://api.github.com/users/oguzkocer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oguzkocer/subscriptions","organizations_url":"https://api.github.com/users/oguzkocer/orgs","repos_url":"https://api.github.com/users/oguzkocer/repos","events_url":"https://api.github.com/users/oguzkocer/events{/privacy}","received_events_url":"https://api.github.com/users/oguzkocer/received_events","type":"User","site_admin":false},"assignees":[{"login":"oguzkocer","id":662023,"node_id":"MDQ6VXNlcjY2MjAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/662023?v=4","gravatar_id":"","url":"https://api.github.com/users/oguzkocer","html_url":"https://github.com/oguzkocer","followers_url":"https://api.github.com/users/oguzkocer/followers","following_url":"https://api.github.com/users/oguzkocer/following{/other_user}","gists_url":"https://api.github.com/users/oguzkocer/gists{/gist_id}","starred_url":"https://api.github.com/users/oguzkocer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oguzkocer/subscriptions","organizations_url":"https://api.github.com/users/oguzkocer/orgs","repos_url":"https://api.github.com/users/oguzkocer/repos","events_url":"https://api.github.com/users/oguzkocer/events{/privacy}","received_events_url":"https://api.github.com/users/oguzkocer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-05-31T19:15:15Z","updated_at":"2018-06-01T19:12:41Z","closed_at":"2018-06-01T19:12:41Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/7837","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7837","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7837.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7837.patch"},"body":"Fixes #7037 \r\nTo test:\r\n"},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments/393981983","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7837#issuecomment-393981983","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7837","id":393981983,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Mzk4MTk4Mw==","user":{"login":"oguzkocer","id":662023,"node_id":"MDQ6VXNlcjY2MjAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/662023?v=4","gravatar_id":"","url":"https://api.github.com/users/oguzkocer","html_url":"https://github.com/oguzkocer","followers_url":"https://api.github.com/users/oguzkocer/followers","following_url":"https://api.github.com/users/oguzkocer/following{/other_user}","gists_url":"https://api.github.com/users/oguzkocer/gists{/gist_id}","starred_url":"https://api.github.com/users/oguzkocer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oguzkocer/subscriptions","organizations_url":"https://api.github.com/users/oguzkocer/orgs","repos_url":"https://api.github.com/users/oguzkocer/repos","events_url":"https://api.github.com/users/oguzkocer/events{/privacy}","received_events_url":"https://api.github.com/users/oguzkocer/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T19:12:41Z","updated_at":"2018-06-01T19:12:41Z","author_association":"CONTRIBUTOR","body":"@ThodwrisKanellopoulos It doesn't look like your PR is fixing the issue mentioned in the PR description. It also changes the style of the code unnecessarily (in most cases) and adds documentation that's not very useful. I don't think we can merge this PR as is and giving feedback on all the issues would simply take too much time. So, I think it's best to close this PR.\r\n\r\nIf you'd like to contribute, maybe it's best if you can tell us what you're trying to achieve. That way we can point you in the right direction. Some general feedback:\r\n\r\n* We prefer PRs to have a single goal. This PR doesn't seem to have any and just has some random changes all over. They don't seem to be very meaningful changes either.\r\n* I think it's best if you can document your own code, before starting to document others. The code should be self-documenting as much as possible and comments should be used when it contributes to the understanding of it. If a developer can read the code faster than the documentation, in most cases that's not very helpful documentation. An exception to that is documenting libraries.\r\n* It'd be better if the PR is from a single user. That way we can avoid people cherry-picking others' code and pushing them to our code base. (I am not saying you have done that here)\r\n* Smaller commits is something we try to do as much as possible. Commit messages give context to what you're trying to accomplish.\r\n\r\nHope these tips would help. If you have any questions, please let us know."}}
{"actor":{"display_login":"oguzkocer"}}