{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/comments/182485298","pull_request_review_id":113290176,"id":182485298,"diff_hunk":"@@ -171,6 +170,31 @@ public Container create(String appId, AppDeploymentRequest request, Integer port\n \t\t\t}\n \t\t}\n \n+        if(properties.getReadinessProbePort() != null) {\n+            container.withReadinessProbe(\n+                    new ProbeCreator(properties.getReadinessProbePort(), properties.getReadinessProbePath(), properties.getReadinessProbeTimeout(),\n+                            properties.getReadinessProbeDelay(), properties.getReadinessProbePeriod(), \"readiness\",\n+                            request.getDeploymentProperties()).create());\n+        }\n+\n+        if (properties.getLivenessProbePort() != null) {\n+            container.withLivenessProbe(\n+                    new ProbeCreator(properties.getLivenessProbePort(), properties.getLivenessProbePath(), properties.getLivenessProbeTimeout(),\n+                            properties.getLivenessProbeDelay(), properties.getLivenessProbePeriod(), \"liveness\",\n+                            request.getDeploymentProperties()).create());\n+        }\n+\n+        if (properties.getReadinessProbePort() == null && properties.getLivenessProbePort() == null && port != null) {","path":"src/main/java/org/springframework/cloud/deployer/spi/kubernetes/DefaultContainerFactory.java","position":45,"original_position":45,"commit_id":"0bc2f5f17423f80c46ffeb9a61e0b2adfafd4436","original_commit_id":"0bc2f5f17423f80c46ffeb9a61e0b2adfafd4436","user":{"login":"chrisjs","id":539358,"avatar_url":"https://avatars2.githubusercontent.com/u/539358?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisjs","html_url":"https://github.com/chrisjs","followers_url":"https://api.github.com/users/chrisjs/followers","following_url":"https://api.github.com/users/chrisjs/following{/other_user}","gists_url":"https://api.github.com/users/chrisjs/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisjs/subscriptions","organizations_url":"https://api.github.com/users/chrisjs/orgs","repos_url":"https://api.github.com/users/chrisjs/repos","events_url":"https://api.github.com/users/chrisjs/events{/privacy}","received_events_url":"https://api.github.com/users/chrisjs/received_events","type":"User","site_admin":false},"body":"Hi @kmoroe22 yes that sounds correct. Then the probe ports can be defined on the CLI and per app rather than just in the server yaml which would populate `KubernetesDeployerProperties` at startup.","created_at":"2018-04-18T16:13:16Z","updated_at":"2018-04-18T16:13:16Z","html_url":"https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/pull/200#discussion_r182485298","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/200","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/comments/182485298"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/pull/200#discussion_r182485298"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/200"}},"in_reply_to_id":177943132},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/200","id":176455048,"html_url":"https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/pull/200","diff_url":"https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/pull/200.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/pull/200.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues/200","number":200,"state":"open","locked":false,"title":"Closes #199 added custom liveness and readiness probe ports","user":{"login":"kmoroe22","id":10706799,"avatar_url":"https://avatars2.githubusercontent.com/u/10706799?v=4","gravatar_id":"","url":"https://api.github.com/users/kmoroe22","html_url":"https://github.com/kmoroe22","followers_url":"https://api.github.com/users/kmoroe22/followers","following_url":"https://api.github.com/users/kmoroe22/following{/other_user}","gists_url":"https://api.github.com/users/kmoroe22/gists{/gist_id}","starred_url":"https://api.github.com/users/kmoroe22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmoroe22/subscriptions","organizations_url":"https://api.github.com/users/kmoroe22/orgs","repos_url":"https://api.github.com/users/kmoroe22/repos","events_url":"https://api.github.com/users/kmoroe22/events{/privacy}","received_events_url":"https://api.github.com/users/kmoroe22/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-21T12:05:23Z","updated_at":"2018-04-18T16:13:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d2cd3af1943ad0a85a2d360079a8eb76b5b7f54","assignee":{"login":"chrisjs","id":539358,"avatar_url":"https://avatars2.githubusercontent.com/u/539358?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisjs","html_url":"https://github.com/chrisjs","followers_url":"https://api.github.com/users/chrisjs/followers","following_url":"https://api.github.com/users/chrisjs/following{/other_user}","gists_url":"https://api.github.com/users/chrisjs/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisjs/subscriptions","organizations_url":"https://api.github.com/users/chrisjs/orgs","repos_url":"https://api.github.com/users/chrisjs/repos","events_url":"https://api.github.com/users/chrisjs/events{/privacy}","received_events_url":"https://api.github.com/users/chrisjs/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisjs","id":539358,"avatar_url":"https://avatars2.githubusercontent.com/u/539358?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisjs","html_url":"https://github.com/chrisjs","followers_url":"https://api.github.com/users/chrisjs/followers","following_url":"https://api.github.com/users/chrisjs/following{/other_user}","gists_url":"https://api.github.com/users/chrisjs/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisjs/subscriptions","organizations_url":"https://api.github.com/users/chrisjs/orgs","repos_url":"https://api.github.com/users/chrisjs/repos","events_url":"https://api.github.com/users/chrisjs/events{/privacy}","received_events_url":"https://api.github.com/users/chrisjs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":357499647,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/labels/in%20pr","name":"in pr","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/200/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/200/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues/200/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/statuses/0bc2f5f17423f80c46ffeb9a61e0b2adfafd4436","head":{"label":"kmoroe22:enhancement/allow-custom-health-and-liveness-ports","ref":"enhancement/allow-custom-health-and-liveness-ports","sha":"0bc2f5f17423f80c46ffeb9a61e0b2adfafd4436","user":{"login":"kmoroe22","id":10706799,"avatar_url":"https://avatars2.githubusercontent.com/u/10706799?v=4","gravatar_id":"","url":"https://api.github.com/users/kmoroe22","html_url":"https://github.com/kmoroe22","followers_url":"https://api.github.com/users/kmoroe22/followers","following_url":"https://api.github.com/users/kmoroe22/following{/other_user}","gists_url":"https://api.github.com/users/kmoroe22/gists{/gist_id}","starred_url":"https://api.github.com/users/kmoroe22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmoroe22/subscriptions","organizations_url":"https://api.github.com/users/kmoroe22/orgs","repos_url":"https://api.github.com/users/kmoroe22/repos","events_url":"https://api.github.com/users/kmoroe22/events{/privacy}","received_events_url":"https://api.github.com/users/kmoroe22/received_events","type":"User","site_admin":false},"repo":{"id":126171697,"name":"spring-cloud-deployer-kubernetes","full_name":"kmoroe22/spring-cloud-deployer-kubernetes","owner":{"login":"kmoroe22","id":10706799,"avatar_url":"https://avatars2.githubusercontent.com/u/10706799?v=4","gravatar_id":"","url":"https://api.github.com/users/kmoroe22","html_url":"https://github.com/kmoroe22","followers_url":"https://api.github.com/users/kmoroe22/followers","following_url":"https://api.github.com/users/kmoroe22/following{/other_user}","gists_url":"https://api.github.com/users/kmoroe22/gists{/gist_id}","starred_url":"https://api.github.com/users/kmoroe22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmoroe22/subscriptions","organizations_url":"https://api.github.com/users/kmoroe22/orgs","repos_url":"https://api.github.com/users/kmoroe22/repos","events_url":"https://api.github.com/users/kmoroe22/events{/privacy}","received_events_url":"https://api.github.com/users/kmoroe22/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmoroe22/spring-cloud-deployer-kubernetes","description":"The Spring Cloud Deployer implementation for Kubernetes","fork":true,"url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes","forks_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/forks","keys_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/teams","hooks_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/events","assignees_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/tags","blobs_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/languages","stargazers_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/subscription","commits_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/merges","archive_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/downloads","issues_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kmoroe22/spring-cloud-deployer-kubernetes/deployments","created_at":"2018-03-21T11:56:13Z","updated_at":"2018-03-21T11:56:15Z","pushed_at":"2018-03-21T12:03:59Z","git_url":"git://github.com/kmoroe22/spring-cloud-deployer-kubernetes.git","ssh_url":"git@github.com:kmoroe22/spring-cloud-deployer-kubernetes.git","clone_url":"https://github.com/kmoroe22/spring-cloud-deployer-kubernetes.git","svn_url":"https://github.com/kmoroe22/spring-cloud-deployer-kubernetes","homepage":"","size":305,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"4c26b79f9710b65b36c67518012d4ad1436be773","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":52819699,"name":"spring-cloud-deployer-kubernetes","full_name":"spring-cloud/spring-cloud-deployer-kubernetes","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-deployer-kubernetes","description":"The Spring Cloud Deployer implementation for Kubernetes","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/deployments","created_at":"2016-02-29T19:53:03Z","updated_at":"2018-04-18T16:01:59Z","pushed_at":"2018-04-18T16:01:57Z","git_url":"git://github.com/spring-cloud/spring-cloud-deployer-kubernetes.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-deployer-kubernetes.git","clone_url":"https://github.com/spring-cloud/spring-cloud-deployer-kubernetes.git","svn_url":"https://github.com/spring-cloud/spring-cloud-deployer-kubernetes","homepage":"","size":327,"stargazers_count":43,"watchers_count":43,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":34,"open_issues":21,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/200"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/pull/200"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues/200"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer-kubernetes/statuses/0bc2f5f17423f80c46ffeb9a61e0b2adfafd4436"}},"author_association":"NONE"}}
{"actor":{"display_login":"chrisjs"}}