{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/235190413","pull_request_review_id":177000990,"id":235190413,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTE5MDQxMw==","diff_hunk":"@@ -0,0 +1,44 @@\n+// Copyright Joyent, Inc. and other Node contributors.","path":"test/parallel/test-child-process-fork-detached.js","position":1,"original_position":1,"commit_id":"2b18e0386f42a50bba9891753600bd9f37435f9f","original_commit_id":"2b18e0386f42a50bba9891753600bd9f37435f9f","user":{"login":"nanomosfet","id":21000341,"node_id":"MDQ6VXNlcjIxMDAwMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/21000341?v=4","gravatar_id":"","url":"https://api.github.com/users/nanomosfet","html_url":"https://github.com/nanomosfet","followers_url":"https://api.github.com/users/nanomosfet/followers","following_url":"https://api.github.com/users/nanomosfet/following{/other_user}","gists_url":"https://api.github.com/users/nanomosfet/gists{/gist_id}","starred_url":"https://api.github.com/users/nanomosfet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanomosfet/subscriptions","organizations_url":"https://api.github.com/users/nanomosfet/orgs","repos_url":"https://api.github.com/users/nanomosfet/repos","events_url":"https://api.github.com/users/nanomosfet/events{/privacy}","received_events_url":"https://api.github.com/users/nanomosfet/received_events","type":"User","site_admin":false},"body":"Will remove it. Thanks for letting me know.","created_at":"2018-11-20T22:19:41Z","updated_at":"2018-11-20T22:19:41Z","html_url":"https://github.com/nodejs/node/pull/24524#discussion_r235190413","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/24524","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/235190413"},"html":{"href":"https://github.com/nodejs/node/pull/24524#discussion_r235190413"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/24524"}},"in_reply_to_id":235152255},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24524","id":232417189,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDE3MTg5","html_url":"https://github.com/nodejs/node/pull/24524","diff_url":"https://github.com/nodejs/node/pull/24524.diff","patch_url":"https://github.com/nodejs/node/pull/24524.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/24524","number":24524,"state":"open","locked":false,"title":"add test and docs update for detached fork process","user":{"login":"nanomosfet","id":21000341,"node_id":"MDQ6VXNlcjIxMDAwMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/21000341?v=4","gravatar_id":"","url":"https://api.github.com/users/nanomosfet","html_url":"https://github.com/nanomosfet","followers_url":"https://api.github.com/users/nanomosfet/followers","following_url":"https://api.github.com/users/nanomosfet/following{/other_user}","gists_url":"https://api.github.com/users/nanomosfet/gists{/gist_id}","starred_url":"https://api.github.com/users/nanomosfet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanomosfet/subscriptions","organizations_url":"https://api.github.com/users/nanomosfet/orgs","repos_url":"https://api.github.com/users/nanomosfet/repos","events_url":"https://api.github.com/users/nanomosfet/events{/privacy}","received_events_url":"https://api.github.com/users/nanomosfet/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\nThis addresses issue #17592 \r\n","created_at":"2018-11-20T18:26:00Z","updated_at":"2018-11-20T22:19:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bde80a1dea350acfed994648fc420859e65df7fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267478,"node_id":"MDU6TGFiZWwxNTUyNjc0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/child_process","name":"child_process","color":"f7c6c7","default":false},{"id":155267517,"node_id":"MDU6TGFiZWwxNTUyNjc1MTc=","url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/24524/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/24524/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24524/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/2b18e0386f42a50bba9891753600bd9f37435f9f","head":{"label":"nanomosfet:add-fork-detached-test","ref":"add-fork-detached-test","sha":"2b18e0386f42a50bba9891753600bd9f37435f9f","user":{"login":"nanomosfet","id":21000341,"node_id":"MDQ6VXNlcjIxMDAwMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/21000341?v=4","gravatar_id":"","url":"https://api.github.com/users/nanomosfet","html_url":"https://github.com/nanomosfet","followers_url":"https://api.github.com/users/nanomosfet/followers","following_url":"https://api.github.com/users/nanomosfet/following{/other_user}","gists_url":"https://api.github.com/users/nanomosfet/gists{/gist_id}","starred_url":"https://api.github.com/users/nanomosfet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanomosfet/subscriptions","organizations_url":"https://api.github.com/users/nanomosfet/orgs","repos_url":"https://api.github.com/users/nanomosfet/repos","events_url":"https://api.github.com/users/nanomosfet/events{/privacy}","received_events_url":"https://api.github.com/users/nanomosfet/received_events","type":"User","site_admin":false},"repo":{"id":153058488,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMwNTg0ODg=","name":"node","full_name":"nanomosfet/node","private":false,"owner":{"login":"nanomosfet","id":21000341,"node_id":"MDQ6VXNlcjIxMDAwMzQx","avatar_url":"https://avatars0.githubusercontent.com/u/21000341?v=4","gravatar_id":"","url":"https://api.github.com/users/nanomosfet","html_url":"https://github.com/nanomosfet","followers_url":"https://api.github.com/users/nanomosfet/followers","following_url":"https://api.github.com/users/nanomosfet/following{/other_user}","gists_url":"https://api.github.com/users/nanomosfet/gists{/gist_id}","starred_url":"https://api.github.com/users/nanomosfet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanomosfet/subscriptions","organizations_url":"https://api.github.com/users/nanomosfet/orgs","repos_url":"https://api.github.com/users/nanomosfet/repos","events_url":"https://api.github.com/users/nanomosfet/events{/privacy}","received_events_url":"https://api.github.com/users/nanomosfet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nanomosfet/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/nanomosfet/node","forks_url":"https://api.github.com/repos/nanomosfet/node/forks","keys_url":"https://api.github.com/repos/nanomosfet/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nanomosfet/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nanomosfet/node/teams","hooks_url":"https://api.github.com/repos/nanomosfet/node/hooks","issue_events_url":"https://api.github.com/repos/nanomosfet/node/issues/events{/number}","events_url":"https://api.github.com/repos/nanomosfet/node/events","assignees_url":"https://api.github.com/repos/nanomosfet/node/assignees{/user}","branches_url":"https://api.github.com/repos/nanomosfet/node/branches{/branch}","tags_url":"https://api.github.com/repos/nanomosfet/node/tags","blobs_url":"https://api.github.com/repos/nanomosfet/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nanomosfet/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nanomosfet/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nanomosfet/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nanomosfet/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nanomosfet/node/languages","stargazers_url":"https://api.github.com/repos/nanomosfet/node/stargazers","contributors_url":"https://api.github.com/repos/nanomosfet/node/contributors","subscribers_url":"https://api.github.com/repos/nanomosfet/node/subscribers","subscription_url":"https://api.github.com/repos/nanomosfet/node/subscription","commits_url":"https://api.github.com/repos/nanomosfet/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nanomosfet/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nanomosfet/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nanomosfet/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nanomosfet/node/contents/{+path}","compare_url":"https://api.github.com/repos/nanomosfet/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nanomosfet/node/merges","archive_url":"https://api.github.com/repos/nanomosfet/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nanomosfet/node/downloads","issues_url":"https://api.github.com/repos/nanomosfet/node/issues{/number}","pulls_url":"https://api.github.com/repos/nanomosfet/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nanomosfet/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nanomosfet/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nanomosfet/node/labels{/name}","releases_url":"https://api.github.com/repos/nanomosfet/node/releases{/id}","deployments_url":"https://api.github.com/repos/nanomosfet/node/deployments","created_at":"2018-10-15T05:38:41Z","updated_at":"2018-11-20T07:22:33Z","pushed_at":"2018-11-20T18:23:36Z","git_url":"git://github.com/nanomosfet/node.git","ssh_url":"git@github.com:nanomosfet/node.git","clone_url":"https://github.com/nanomosfet/node.git","svn_url":"https://github.com/nanomosfet/node","homepage":"https://nodejs.org","size":430567,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"2c2e6ec38d1f033676e462aa5ac0cc24efb7b4ef","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-11-20T21:37:05Z","pushed_at":"2018-11-20T21:45:13Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":433120,"stargazers_count":55577,"watchers_count":55577,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12209,"mirror_url":null,"archived":false,"open_issues_count":838,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12209,"open_issues":838,"watchers":55577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/24524"},"html":{"href":"https://github.com/nodejs/node/pull/24524"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/24524"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/24524/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/24524/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/24524/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/2b18e0386f42a50bba9891753600bd9f37435f9f"}},"author_association":"NONE"}}
{"actor":{"display_login":"nanomosfet"}}