{"action":"created","comment":{"url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/comments/244963989","pull_request_review_id":188966065,"id":244963989,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk2Mzk4OQ==","diff_hunk":"@@ -49,9 +49,9 @@ public static function fromInteger(string $integer): self\n     /**\n      * @param int|string $node\n      *\n-     * @return static\n-     *\n      * @throws \\Exception\n+     *\n+     * @return static","path":"src/Domain/Shared/ValueObject/AbstractUuid.php","position":54,"original_position":8,"commit_id":"ea1899a8b7d0f413b60769c0a7fc9559013d434f","original_commit_id":"ea1899a8b7d0f413b60769c0a7fc9559013d434f","user":{"login":"jorge07","id":4022187,"node_id":"MDQ6VXNlcjQwMjIxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/4022187?v=4","gravatar_id":"","url":"https://api.github.com/users/jorge07","html_url":"https://github.com/jorge07","followers_url":"https://api.github.com/users/jorge07/followers","following_url":"https://api.github.com/users/jorge07/following{/other_user}","gists_url":"https://api.github.com/users/jorge07/gists{/gist_id}","starred_url":"https://api.github.com/users/jorge07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorge07/subscriptions","organizations_url":"https://api.github.com/users/jorge07/orgs","repos_url":"https://api.github.com/users/jorge07/repos","events_url":"https://api.github.com/users/jorge07/events{/privacy}","received_events_url":"https://api.github.com/users/jorge07/received_events","type":"User","site_admin":false},"body":"`static` and `self` are too different things. I really prefer avoid return type if this is a problem for phpstan","created_at":"2019-01-03T10:50:11Z","updated_at":"2019-01-03T10:50:11Z","html_url":"https://github.com/jorge07/symfony-4-es-cqrs-boilerplate/pull/78#discussion_r244963989","pull_request_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/78","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/comments/244963989"},"html":{"href":"https://github.com/jorge07/symfony-4-es-cqrs-boilerplate/pull/78#discussion_r244963989"},"pull_request":{"href":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/78","id":223393222,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzkzMjIy","html_url":"https://github.com/jorge07/symfony-4-es-cqrs-boilerplate/pull/78","diff_url":"https://github.com/jorge07/symfony-4-es-cqrs-boilerplate/pull/78.diff","patch_url":"https://github.com/jorge07/symfony-4-es-cqrs-boilerplate/pull/78.patch","issue_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/issues/78","number":78,"state":"open","locked":false,"title":"DBAL types for value object","user":{"login":"alekseytupichenkov","id":8191991,"node_id":"MDQ6VXNlcjgxOTE5OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8191991?v=4","gravatar_id":"","url":"https://api.github.com/users/alekseytupichenkov","html_url":"https://github.com/alekseytupichenkov","followers_url":"https://api.github.com/users/alekseytupichenkov/followers","following_url":"https://api.github.com/users/alekseytupichenkov/following{/other_user}","gists_url":"https://api.github.com/users/alekseytupichenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/alekseytupichenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alekseytupichenkov/subscriptions","organizations_url":"https://api.github.com/users/alekseytupichenkov/orgs","repos_url":"https://api.github.com/users/alekseytupichenkov/repos","events_url":"https://api.github.com/users/alekseytupichenkov/events{/privacy}","received_events_url":"https://api.github.com/users/alekseytupichenkov/received_events","type":"User","site_admin":false},"body":"I'm not sure, but, what do you think about using DBAL types for value objects?\r\nIn case of using DBAL types, we can guarantee that all entities have or VO or null\r\n\r\nPS: It's just proposal, so code can have code-style or other problems :)","created_at":"2018-10-16T20:55:43Z","updated_at":"2019-01-03T10:50:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36678e2c26919615e74d53886be033ce2b66005a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/78/commits","review_comments_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/78/comments","review_comment_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/issues/78/comments","statuses_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/statuses/ea1899a8b7d0f413b60769c0a7fc9559013d434f","head":{"label":"alekseytupichenkov:dbal_types_for_vo","ref":"dbal_types_for_vo","sha":"ea1899a8b7d0f413b60769c0a7fc9559013d434f","user":{"login":"alekseytupichenkov","id":8191991,"node_id":"MDQ6VXNlcjgxOTE5OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8191991?v=4","gravatar_id":"","url":"https://api.github.com/users/alekseytupichenkov","html_url":"https://github.com/alekseytupichenkov","followers_url":"https://api.github.com/users/alekseytupichenkov/followers","following_url":"https://api.github.com/users/alekseytupichenkov/following{/other_user}","gists_url":"https://api.github.com/users/alekseytupichenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/alekseytupichenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alekseytupichenkov/subscriptions","organizations_url":"https://api.github.com/users/alekseytupichenkov/orgs","repos_url":"https://api.github.com/users/alekseytupichenkov/repos","events_url":"https://api.github.com/users/alekseytupichenkov/events{/privacy}","received_events_url":"https://api.github.com/users/alekseytupichenkov/received_events","type":"User","site_admin":false},"repo":{"id":153319901,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMTk5MDE=","name":"symfony-4-es-cqrs-boilerplate","full_name":"alekseytupichenkov/symfony-4-es-cqrs-boilerplate","private":false,"owner":{"login":"alekseytupichenkov","id":8191991,"node_id":"MDQ6VXNlcjgxOTE5OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8191991?v=4","gravatar_id":"","url":"https://api.github.com/users/alekseytupichenkov","html_url":"https://github.com/alekseytupichenkov","followers_url":"https://api.github.com/users/alekseytupichenkov/followers","following_url":"https://api.github.com/users/alekseytupichenkov/following{/other_user}","gists_url":"https://api.github.com/users/alekseytupichenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/alekseytupichenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alekseytupichenkov/subscriptions","organizations_url":"https://api.github.com/users/alekseytupichenkov/orgs","repos_url":"https://api.github.com/users/alekseytupichenkov/repos","events_url":"https://api.github.com/users/alekseytupichenkov/events{/privacy}","received_events_url":"https://api.github.com/users/alekseytupichenkov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alekseytupichenkov/symfony-4-es-cqrs-boilerplate","description":"Symfony 4 DDD ES CQRS backend boilerplate","fork":true,"url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate","forks_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/forks","keys_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/teams","hooks_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/events","assignees_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/tags","blobs_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/languages","stargazers_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/subscription","commits_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/merges","archive_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/downloads","issues_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/alekseytupichenkov/symfony-4-es-cqrs-boilerplate/deployments","created_at":"2018-10-16T16:41:15Z","updated_at":"2018-10-16T16:41:17Z","pushed_at":"2019-01-03T07:18:11Z","git_url":"git://github.com/alekseytupichenkov/symfony-4-es-cqrs-boilerplate.git","ssh_url":"git@github.com:alekseytupichenkov/symfony-4-es-cqrs-boilerplate.git","clone_url":"https://github.com/alekseytupichenkov/symfony-4-es-cqrs-boilerplate.git","svn_url":"https://github.com/alekseytupichenkov/symfony-4-es-cqrs-boilerplate","homepage":"","size":1544,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jorge07:master","ref":"master","sha":"bdf7e909fd656c6b63791293de5c6d45a1b17123","user":{"login":"jorge07","id":4022187,"node_id":"MDQ6VXNlcjQwMjIxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/4022187?v=4","gravatar_id":"","url":"https://api.github.com/users/jorge07","html_url":"https://github.com/jorge07","followers_url":"https://api.github.com/users/jorge07/followers","following_url":"https://api.github.com/users/jorge07/following{/other_user}","gists_url":"https://api.github.com/users/jorge07/gists{/gist_id}","starred_url":"https://api.github.com/users/jorge07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorge07/subscriptions","organizations_url":"https://api.github.com/users/jorge07/orgs","repos_url":"https://api.github.com/users/jorge07/repos","events_url":"https://api.github.com/users/jorge07/events{/privacy}","received_events_url":"https://api.github.com/users/jorge07/received_events","type":"User","site_admin":false},"repo":{"id":116064483,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwNjQ0ODM=","name":"symfony-4-es-cqrs-boilerplate","full_name":"jorge07/symfony-4-es-cqrs-boilerplate","private":false,"owner":{"login":"jorge07","id":4022187,"node_id":"MDQ6VXNlcjQwMjIxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/4022187?v=4","gravatar_id":"","url":"https://api.github.com/users/jorge07","html_url":"https://github.com/jorge07","followers_url":"https://api.github.com/users/jorge07/followers","following_url":"https://api.github.com/users/jorge07/following{/other_user}","gists_url":"https://api.github.com/users/jorge07/gists{/gist_id}","starred_url":"https://api.github.com/users/jorge07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorge07/subscriptions","organizations_url":"https://api.github.com/users/jorge07/orgs","repos_url":"https://api.github.com/users/jorge07/repos","events_url":"https://api.github.com/users/jorge07/events{/privacy}","received_events_url":"https://api.github.com/users/jorge07/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jorge07/symfony-4-es-cqrs-boilerplate","description":"Symfony 4 DDD ES CQRS backend boilerplate","fork":false,"url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate","forks_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/forks","keys_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/teams","hooks_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/events","assignees_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/tags","blobs_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/languages","stargazers_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/subscription","commits_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/merges","archive_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/downloads","issues_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/deployments","created_at":"2018-01-02T22:39:20Z","updated_at":"2019-01-02T18:28:19Z","pushed_at":"2019-01-03T07:18:13Z","git_url":"git://github.com/jorge07/symfony-4-es-cqrs-boilerplate.git","ssh_url":"git@github.com:jorge07/symfony-4-es-cqrs-boilerplate.git","clone_url":"https://github.com/jorge07/symfony-4-es-cqrs-boilerplate.git","svn_url":"https://github.com/jorge07/symfony-4-es-cqrs-boilerplate","homepage":"","size":1521,"stargazers_count":215,"watchers_count":215,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":47,"open_issues":8,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/78"},"html":{"href":"https://github.com/jorge07/symfony-4-es-cqrs-boilerplate/pull/78"},"issue":{"href":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/issues/78"},"comments":{"href":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/jorge07/symfony-4-es-cqrs-boilerplate/statuses/ea1899a8b7d0f413b60769c0a7fc9559013d434f"}},"author_association":"NONE"}}
{"actor":{"display_login":"jorge07"}}