{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/installer/pulls/comments/232077491","pull_request_review_id":173193680,"id":232077491,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjA3NzQ5MQ==","diff_hunk":"@@ -0,0 +1,40 @@\n+## Image to enable launching a libvirt cluster nested in a GCE instance, for libvirt CI testing.\n+\n+This image contains [nss_wrapper](https://cwrap.org/nss_wrapper.html) to execute ssh commands as \n+a mock user to interact with a GCE instance from an OpenShift container.\n+\n+OpenShift containers run with an arbitrary uid, but ssh requires a valid user.  `nss_wrapper`\n+allows for the container's uid to be mapped to a user inside of a container.\n+\n+\n+### Example Usage\n+\n+You can override the container's current uid and gid by providing NSS_USERNAME, NSS_UID, NSS_GROUPNAME, and/or NSS_GID.\n+\n+```\n+$ docker run --rm \\\n+-e NSS_USERNAME=packer \\\n+-e NSS_GROUPNAME=packer \\\n+nss_wrapper-image -c '/generate-user.sh && id packer'\n+```\n+\n+OR, in an OpenShift container:","path":"images/installer/nested-libvirt/README.md","position":22,"original_position":21,"commit_id":"88c0aff4b5632578051bf4dd1babd7c537cedcc2","original_commit_id":"e776c9b5aadfef7920e2c2972dffbe81e7930fff","user":{"login":"sallyom","id":11166065,"node_id":"MDQ6VXNlcjExMTY2MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/11166065?v=4","gravatar_id":"","url":"https://api.github.com/users/sallyom","html_url":"https://github.com/sallyom","followers_url":"https://api.github.com/users/sallyom/followers","following_url":"https://api.github.com/users/sallyom/following{/other_user}","gists_url":"https://api.github.com/users/sallyom/gists{/gist_id}","starred_url":"https://api.github.com/users/sallyom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sallyom/subscriptions","organizations_url":"https://api.github.com/users/sallyom/orgs","repos_url":"https://api.github.com/users/sallyom/repos","events_url":"https://api.github.com/users/sallyom/events{/privacy}","received_events_url":"https://api.github.com/users/sallyom/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-11-08T22:03:03Z","updated_at":"2018-11-08T22:03:03Z","html_url":"https://github.com/openshift/installer/pull/625#discussion_r232077491","pull_request_url":"https://api.github.com/repos/openshift/installer/pulls/625","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments/232077491"},"html":{"href":"https://github.com/openshift/installer/pull/625#discussion_r232077491"},"pull_request":{"href":"https://api.github.com/repos/openshift/installer/pulls/625"}},"in_reply_to_id":231779731},"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/625","id":228803857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODAzODU3","html_url":"https://github.com/openshift/installer/pull/625","diff_url":"https://github.com/openshift/installer/pull/625.diff","patch_url":"https://github.com/openshift/installer/pull/625.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/625","number":625,"state":"open","locked":false,"title":"scripts for nested-libvirt ci","user":{"login":"sallyom","id":11166065,"node_id":"MDQ6VXNlcjExMTY2MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/11166065?v=4","gravatar_id":"","url":"https://api.github.com/users/sallyom","html_url":"https://github.com/sallyom","followers_url":"https://api.github.com/users/sallyom/followers","following_url":"https://api.github.com/users/sallyom/following{/other_user}","gists_url":"https://api.github.com/users/sallyom/gists{/gist_id}","starred_url":"https://api.github.com/users/sallyom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sallyom/subscriptions","organizations_url":"https://api.github.com/users/sallyom/orgs","repos_url":"https://api.github.com/users/sallyom/repos","events_url":"https://api.github.com/users/sallyom/events{/privacy}","received_events_url":"https://api.github.com/users/sallyom/received_events","type":"User","site_admin":false},"body":"This PR enables testing of libvirt cluster in a GCE instance, for a CI job to ensure developer libvirt workflow is not broken.\r\n* for use with this: https://github.com/openshift/release/pull/2078\r\n* can test with this: https://github.com/sallyom/installer-e2e/blob/master/templates/nested-libvirt-installer-e2e-modified.yaml until 2078 merges\r\n    ","created_at":"2018-11-06T19:13:50Z","updated_at":"2018-11-08T22:03:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a6e727fd81a53fa7a3b3d76f970424edf327c3e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aaronlevy","id":374924,"node_id":"MDQ6VXNlcjM3NDkyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/374924?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronlevy","html_url":"https://github.com/aaronlevy","followers_url":"https://api.github.com/users/aaronlevy/followers","following_url":"https://api.github.com/users/aaronlevy/following{/other_user}","gists_url":"https://api.github.com/users/aaronlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlevy/subscriptions","organizations_url":"https://api.github.com/users/aaronlevy/orgs","repos_url":"https://api.github.com/users/aaronlevy/repos","events_url":"https://api.github.com/users/aaronlevy/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlevy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":959732835,"node_id":"MDU6TGFiZWw5NTk3MzI4MzU=","url":"https://api.github.com/repos/openshift/installer/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/625/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/625/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/625/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/88c0aff4b5632578051bf4dd1babd7c537cedcc2","head":{"label":"sallyom:danmace-libvirt-scripts","ref":"danmace-libvirt-scripts","sha":"88c0aff4b5632578051bf4dd1babd7c537cedcc2","user":{"login":"sallyom","id":11166065,"node_id":"MDQ6VXNlcjExMTY2MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/11166065?v=4","gravatar_id":"","url":"https://api.github.com/users/sallyom","html_url":"https://github.com/sallyom","followers_url":"https://api.github.com/users/sallyom/followers","following_url":"https://api.github.com/users/sallyom/following{/other_user}","gists_url":"https://api.github.com/users/sallyom/gists{/gist_id}","starred_url":"https://api.github.com/users/sallyom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sallyom/subscriptions","organizations_url":"https://api.github.com/users/sallyom/orgs","repos_url":"https://api.github.com/users/sallyom/repos","events_url":"https://api.github.com/users/sallyom/events{/privacy}","received_events_url":"https://api.github.com/users/sallyom/received_events","type":"User","site_admin":false},"repo":{"id":142900511,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MDA1MTE=","name":"installer","full_name":"sallyom/installer","private":false,"owner":{"login":"sallyom","id":11166065,"node_id":"MDQ6VXNlcjExMTY2MDY1","avatar_url":"https://avatars1.githubusercontent.com/u/11166065?v=4","gravatar_id":"","url":"https://api.github.com/users/sallyom","html_url":"https://github.com/sallyom","followers_url":"https://api.github.com/users/sallyom/followers","following_url":"https://api.github.com/users/sallyom/following{/other_user}","gists_url":"https://api.github.com/users/sallyom/gists{/gist_id}","starred_url":"https://api.github.com/users/sallyom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sallyom/subscriptions","organizations_url":"https://api.github.com/users/sallyom/orgs","repos_url":"https://api.github.com/users/sallyom/repos","events_url":"https://api.github.com/users/sallyom/events{/privacy}","received_events_url":"https://api.github.com/users/sallyom/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sallyom/installer","description":"Install an OpenShift cluster","fork":true,"url":"https://api.github.com/repos/sallyom/installer","forks_url":"https://api.github.com/repos/sallyom/installer/forks","keys_url":"https://api.github.com/repos/sallyom/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sallyom/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sallyom/installer/teams","hooks_url":"https://api.github.com/repos/sallyom/installer/hooks","issue_events_url":"https://api.github.com/repos/sallyom/installer/issues/events{/number}","events_url":"https://api.github.com/repos/sallyom/installer/events","assignees_url":"https://api.github.com/repos/sallyom/installer/assignees{/user}","branches_url":"https://api.github.com/repos/sallyom/installer/branches{/branch}","tags_url":"https://api.github.com/repos/sallyom/installer/tags","blobs_url":"https://api.github.com/repos/sallyom/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sallyom/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sallyom/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/sallyom/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sallyom/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/sallyom/installer/languages","stargazers_url":"https://api.github.com/repos/sallyom/installer/stargazers","contributors_url":"https://api.github.com/repos/sallyom/installer/contributors","subscribers_url":"https://api.github.com/repos/sallyom/installer/subscribers","subscription_url":"https://api.github.com/repos/sallyom/installer/subscription","commits_url":"https://api.github.com/repos/sallyom/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/sallyom/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/sallyom/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/sallyom/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/sallyom/installer/contents/{+path}","compare_url":"https://api.github.com/repos/sallyom/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sallyom/installer/merges","archive_url":"https://api.github.com/repos/sallyom/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sallyom/installer/downloads","issues_url":"https://api.github.com/repos/sallyom/installer/issues{/number}","pulls_url":"https://api.github.com/repos/sallyom/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/sallyom/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/sallyom/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sallyom/installer/labels{/name}","releases_url":"https://api.github.com/repos/sallyom/installer/releases{/id}","deployments_url":"https://api.github.com/repos/sallyom/installer/deployments","created_at":"2018-07-30T16:25:19Z","updated_at":"2018-11-08T21:57:00Z","pushed_at":"2018-11-08T21:56:58Z","git_url":"git://github.com/sallyom/installer.git","ssh_url":"git@github.com:sallyom/installer.git","clone_url":"https://github.com/sallyom/installer.git","svn_url":"https://github.com/sallyom/installer","homepage":"","size":43621,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e64a43d293f594c1d51a317822aa6b4783295ecb","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-11-08T20:31:34Z","pushed_at":"2018-11-08T20:51:51Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":43627,"stargazers_count":82,"watchers_count":82,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":95,"open_issues":66,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/625"},"html":{"href":"https://github.com/openshift/installer/pull/625"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/625"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/625/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/625/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/625/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/88c0aff4b5632578051bf4dd1babd7c537cedcc2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sallyom"}}