{"action":"created","issue":{"url":"https://api.github.com/repos/lanl/Draco/issues/447","repository_url":"https://api.github.com/repos/lanl/Draco","labels_url":"https://api.github.com/repos/lanl/Draco/issues/447/labels{/name}","comments_url":"https://api.github.com/repos/lanl/Draco/issues/447/comments","events_url":"https://api.github.com/repos/lanl/Draco/issues/447/events","html_url":"https://github.com/lanl/Draco/pull/447","id":350084243,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDE5NjU3","number":447,"title":"WIP: Begin requiring cmake-3.11+.","user":{"login":"KineticTheory","id":17579601,"node_id":"MDQ6VXNlcjE3NTc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/17579601?v=4","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false},"labels":[{"id":442749287,"node_id":"MDU6TGFiZWw0NDI3NDkyODc=","url":"https://api.github.com/repos/lanl/Draco/labels/dev-env","name":"dev-env","color":"d4c5f9","default":false},{"id":442748551,"node_id":"MDU6TGFiZWw0NDI3NDg1NTE=","url":"https://api.github.com/repos/lanl/Draco/labels/needs-review","name":"needs-review","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"KineticTheory","id":17579601,"node_id":"MDQ6VXNlcjE3NTc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/17579601?v=4","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false},"assignees":[{"login":"KineticTheory","id":17579601,"node_id":"MDQ6VXNlcjE3NTc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/17579601?v=4","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-08-13T15:41:25Z","updated_at":"2018-08-13T22:17:43Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/lanl/Draco/pulls/447","html_url":"https://github.com/lanl/Draco/pull/447","diff_url":"https://github.com/lanl/Draco/pull/447.diff","patch_url":"https://github.com/lanl/Draco/pull/447.patch"},"body":"### Background\r\n\r\n* I've started using a couple of newer features of cmake that weren't introduced until version 3.11.  Since cmake/3.11+ is already available on all supported platforms, make this a requirement. and update the regression scripts and developer environment files.\r\n\r\n### Modifications\r\n\r\n* In the top level `CMakeLists.txt` set `cmake_minimum_required` to `3.11`.\r\n* Ensure dev environment files (e.g.: `.bashrc`) load the module for `cmake/3.11.4`.\r\n* Ensure regression scripts  load the module for `cmake/3.11.4`.\r\n* Variables related to MPI have changed.  Update build scripts to reflect this change: `MPIEXEC --> MPIEXEC_EXECUTABLE`.\r\n* Remove some dead code.\r\n* The Cray specific code in `setupMPI.cmake` needed to be tweaked.  It was finding `/opt/slurm/bin/mpiexec` instead of `/opt/slurm/bin/srun`.\r\n+ Updated git pre-commit scripts because they were failing when run from trinitite. (*I really hate cray machines!*)\r\n\r\n### Status\r\n\r\n* Reference:\r\n  * [Pre-Merge Code Review](https://github.com/lanl/Draco/wiki/Style-Guide)\r\n  * [CDash Status](https://rtt.lanl.gov/cdash/index.php?project=Draco&filtercount=1&showfilters=1&field1=buildname&compare1=63&value1=-pr)\r\n* Checks\r\n  * [x] Travis CI checks pass\r\n  * [x] Code coverage does not decrease\r\n  * [x] [Valgrind test passes](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [x] [Toss3 checks pass](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [x] [Trinitite checks pass](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [ ] Code reviewed/approved, sufficient DbC checks, testing, documentation\r\n"},"comment":{"url":"https://api.github.com/repos/lanl/Draco/issues/comments/412684026","html_url":"https://github.com/lanl/Draco/pull/447#issuecomment-412684026","issue_url":"https://api.github.com/repos/lanl/Draco/issues/447","id":412684026,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjY4NDAyNg==","user":{"login":"KineticTheory","id":17579601,"node_id":"MDQ6VXNlcjE3NTc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/17579601?v=4","gravatar_id":"","url":"https://api.github.com/users/KineticTheory","html_url":"https://github.com/KineticTheory","followers_url":"https://api.github.com/users/KineticTheory/followers","following_url":"https://api.github.com/users/KineticTheory/following{/other_user}","gists_url":"https://api.github.com/users/KineticTheory/gists{/gist_id}","starred_url":"https://api.github.com/users/KineticTheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KineticTheory/subscriptions","organizations_url":"https://api.github.com/users/KineticTheory/orgs","repos_url":"https://api.github.com/users/KineticTheory/repos","events_url":"https://api.github.com/users/KineticTheory/events{/privacy}","received_events_url":"https://api.github.com/users/KineticTheory/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T22:17:43Z","updated_at":"2018-08-13T22:17:43Z","author_association":"COLLABORATOR","body":"@along Can you review/merge this PR?  Jayenne !285 depends on this one, so I would like to get it merged tonight - if possible."}}
{"actor":{"display_login":"KineticTheory"}}