{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/209218661","pull_request_review_id":145190336,"id":209218661,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTIxODY2MQ==","diff_hunk":"@@ -595,6 +602,109 @@ void parseMonitors(const H5::Group &root, InstrumentBuilder &builder) {\n   }\n }\n \n+class Tube {\n+private:\n+  Eigen::Vector3d axis;\n+  double height = 0;","path":"Framework/NexusGeometry/src/NexusGeometryParser.cpp","position":null,"original_position":53,"commit_id":"fd7ecdd7a1cd0e96e6efc61221d2765e8bef1237","original_commit_id":"fd7ecdd7a1cd0e96e6efc61221d2765e8bef1237","user":{"login":"OwenArnold","id":1109536,"node_id":"MDQ6VXNlcjExMDk1MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1109536?v=4","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"body":"Should be `const`","created_at":"2018-08-10T10:40:51Z","updated_at":"2018-08-10T10:40:51Z","html_url":"https://github.com/mantidproject/mantid/pull/21369#discussion_r209218661","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/21369","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/209218661"},"html":{"href":"https://github.com/mantidproject/mantid/pull/21369#discussion_r209218661"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/21369"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/21369","id":156786218,"node_id":"MDExOlB1bGxSZXF1ZXN0MTU2Nzg2MjE4","html_url":"https://github.com/mantidproject/mantid/pull/21369","diff_url":"https://github.com/mantidproject/mantid/pull/21369.diff","patch_url":"https://github.com/mantidproject/mantid/pull/21369.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/21369","number":21369,"state":"open","locked":false,"title":"Basic Nexus Geometry Loader","user":{"login":"OwenArnold","id":1109536,"node_id":"MDQ6VXNlcjExMDk1MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1109536?v=4","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"body":"**DO NOT MERGE THIS.**\r\n**This is not ready for review**\r\n\r\nAims to build a Beamline (via an Instrument) which uses the Nexus entries for geometry and completely bypasses IDFs.\r\n\r\nThe scope of this will have to be limited.\r\n","created_at":"2017-12-06T17:05:49Z","updated_at":"2018-08-10T10:40:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7972a525c7f186729a049a1425f9dd98d646a21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":725950332,"node_id":"MDU6TGFiZWw3MjU5NTAzMzI=","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Beamline","name":"Component: Beamline","color":"009800","default":false},{"id":154208631,"node_id":"MDU6TGFiZWwxNTQyMDg2MzE=","url":"https://api.github.com/repos/mantidproject/mantid/labels/State:%20In%20Progress","name":"State: In Progress","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/21369/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/21369/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/21369/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/fd7ecdd7a1cd0e96e6efc61221d2765e8bef1237","head":{"label":"ScreamingUdder:37_off_instrument_geometry","ref":"37_off_instrument_geometry","sha":"fd7ecdd7a1cd0e96e6efc61221d2765e8bef1237","user":{"login":"ScreamingUdder","id":19463930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/19463930?v=4","gravatar_id":"","url":"https://api.github.com/users/ScreamingUdder","html_url":"https://github.com/ScreamingUdder","followers_url":"https://api.github.com/users/ScreamingUdder/followers","following_url":"https://api.github.com/users/ScreamingUdder/following{/other_user}","gists_url":"https://api.github.com/users/ScreamingUdder/gists{/gist_id}","starred_url":"https://api.github.com/users/ScreamingUdder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScreamingUdder/subscriptions","organizations_url":"https://api.github.com/users/ScreamingUdder/orgs","repos_url":"https://api.github.com/users/ScreamingUdder/repos","events_url":"https://api.github.com/users/ScreamingUdder/events{/privacy}","received_events_url":"https://api.github.com/users/ScreamingUdder/received_events","type":"Organization","site_admin":false},"repo":{"id":78116126,"node_id":"MDEwOlJlcG9zaXRvcnk3ODExNjEyNg==","name":"mantid","full_name":"ScreamingUdder/mantid","owner":{"login":"ScreamingUdder","id":19463930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/19463930?v=4","gravatar_id":"","url":"https://api.github.com/users/ScreamingUdder","html_url":"https://github.com/ScreamingUdder","followers_url":"https://api.github.com/users/ScreamingUdder/followers","following_url":"https://api.github.com/users/ScreamingUdder/following{/other_user}","gists_url":"https://api.github.com/users/ScreamingUdder/gists{/gist_id}","starred_url":"https://api.github.com/users/ScreamingUdder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScreamingUdder/subscriptions","organizations_url":"https://api.github.com/users/ScreamingUdder/orgs","repos_url":"https://api.github.com/users/ScreamingUdder/repos","events_url":"https://api.github.com/users/ScreamingUdder/events{/privacy}","received_events_url":"https://api.github.com/users/ScreamingUdder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScreamingUdder/mantid","description":"Fork of mantidproject/mantid for working on the Kafka Live Listener and NeXus geometry","fork":true,"url":"https://api.github.com/repos/ScreamingUdder/mantid","forks_url":"https://api.github.com/repos/ScreamingUdder/mantid/forks","keys_url":"https://api.github.com/repos/ScreamingUdder/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScreamingUdder/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScreamingUdder/mantid/teams","hooks_url":"https://api.github.com/repos/ScreamingUdder/mantid/hooks","issue_events_url":"https://api.github.com/repos/ScreamingUdder/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/ScreamingUdder/mantid/events","assignees_url":"https://api.github.com/repos/ScreamingUdder/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/ScreamingUdder/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/ScreamingUdder/mantid/tags","blobs_url":"https://api.github.com/repos/ScreamingUdder/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScreamingUdder/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScreamingUdder/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScreamingUdder/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScreamingUdder/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/ScreamingUdder/mantid/languages","stargazers_url":"https://api.github.com/repos/ScreamingUdder/mantid/stargazers","contributors_url":"https://api.github.com/repos/ScreamingUdder/mantid/contributors","subscribers_url":"https://api.github.com/repos/ScreamingUdder/mantid/subscribers","subscription_url":"https://api.github.com/repos/ScreamingUdder/mantid/subscription","commits_url":"https://api.github.com/repos/ScreamingUdder/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScreamingUdder/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScreamingUdder/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScreamingUdder/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScreamingUdder/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/ScreamingUdder/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScreamingUdder/mantid/merges","archive_url":"https://api.github.com/repos/ScreamingUdder/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScreamingUdder/mantid/downloads","issues_url":"https://api.github.com/repos/ScreamingUdder/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/ScreamingUdder/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/ScreamingUdder/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/ScreamingUdder/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScreamingUdder/mantid/labels{/name}","releases_url":"https://api.github.com/repos/ScreamingUdder/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/ScreamingUdder/mantid/deployments","created_at":"2017-01-05T13:41:35Z","updated_at":"2018-04-09T12:23:35Z","pushed_at":"2018-08-09T14:51:01Z","git_url":"git://github.com/ScreamingUdder/mantid.git","ssh_url":"git@github.com:ScreamingUdder/mantid.git","clone_url":"https://github.com/ScreamingUdder/mantid.git","svn_url":"https://github.com/ScreamingUdder/mantid","homepage":"http://www.mantidproject.org","size":488358,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"80ac6e7ef38610ae8b391ebb21c59a10ee11aaee","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-08-10T10:11:51Z","pushed_at":"2018-08-10T10:11:30Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":498070,"stargazers_count":74,"watchers_count":74,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":1835,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":56,"open_issues":1835,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/21369"},"html":{"href":"https://github.com/mantidproject/mantid/pull/21369"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/21369"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/21369/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/21369/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/21369/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/fd7ecdd7a1cd0e96e6efc61221d2765e8bef1237"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"OwenArnold"}}