{"action":"created","issue":{"url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/1205","repository_url":"https://api.github.com/repos/Chocobozzz/PeerTube","labels_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/1205/labels{/name}","comments_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/1205/comments","events_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/1205/events","html_url":"https://github.com/Chocobozzz/PeerTube/pull/1205","id":367401412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODQ5OTc1","number":1205,"title":"Set keyframe interval","user":{"login":"Nutomic","id":1044450,"node_id":"MDQ6VXNlcjEwNDQ0NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1044450?v=4","gravatar_id":"","url":"https://api.github.com/users/Nutomic","html_url":"https://github.com/Nutomic","followers_url":"https://api.github.com/users/Nutomic/followers","following_url":"https://api.github.com/users/Nutomic/following{/other_user}","gists_url":"https://api.github.com/users/Nutomic/gists{/gist_id}","starred_url":"https://api.github.com/users/Nutomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nutomic/subscriptions","organizations_url":"https://api.github.com/users/Nutomic/orgs","repos_url":"https://api.github.com/users/Nutomic/repos","events_url":"https://api.github.com/users/Nutomic/events{/privacy}","received_events_url":"https://api.github.com/users/Nutomic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rigelk","id":6329880,"node_id":"MDQ6VXNlcjYzMjk4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/6329880?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelk","html_url":"https://github.com/rigelk","followers_url":"https://api.github.com/users/rigelk/followers","following_url":"https://api.github.com/users/rigelk/following{/other_user}","gists_url":"https://api.github.com/users/rigelk/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelk/subscriptions","organizations_url":"https://api.github.com/users/rigelk/orgs","repos_url":"https://api.github.com/users/rigelk/repos","events_url":"https://api.github.com/users/rigelk/events{/privacy}","received_events_url":"https://api.github.com/users/rigelk/received_events","type":"User","site_admin":false},"assignees":[{"login":"rigelk","id":6329880,"node_id":"MDQ6VXNlcjYzMjk4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/6329880?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelk","html_url":"https://github.com/rigelk","followers_url":"https://api.github.com/users/rigelk/followers","following_url":"https://api.github.com/users/rigelk/following{/other_user}","gists_url":"https://api.github.com/users/rigelk/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelk/subscriptions","organizations_url":"https://api.github.com/users/rigelk/orgs","repos_url":"https://api.github.com/users/rigelk/repos","events_url":"https://api.github.com/users/rigelk/events{/privacy}","received_events_url":"https://api.github.com/users/rigelk/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-10-05T23:50:49Z","updated_at":"2018-10-09T18:10:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/1205","html_url":"https://github.com/Chocobozzz/PeerTube/pull/1205","diff_url":"https://github.com/Chocobozzz/PeerTube/pull/1205.diff","patch_url":"https://github.com/Chocobozzz/PeerTube/pull/1205.patch"},"body":"Turns out that I was wrong in #1147, the `-g` paramater for keyframes is only deprecated for H265, but works fine for H264. \r\n\r\nUnfortunately fluent-ffmpeg doesn't return the keyframe interval, and doesn't have an option to set parameters. So I think the only way to get the keyframe interval of an existing video (for tests and `optimize-old-videos.ts`) is by running the command on a shell. But I'm not sure how that works, or if it's a good idea. This is the command to list all keyframe times ([source](https://stackoverflow.com/a/18088156)):\r\n```\r\nffprobe -loglevel error -skip_frame nokey -select_streams v:0 -show_entries frame=pkt_pts_time -of csv=print_section=0\r\n```\r\nThis PR depends on #1135."},"comment":{"url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/comments/428293688","html_url":"https://github.com/Chocobozzz/PeerTube/pull/1205#issuecomment-428293688","issue_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/1205","id":428293688,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODI5MzY4OA==","user":{"login":"rigelk","id":6329880,"node_id":"MDQ6VXNlcjYzMjk4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/6329880?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelk","html_url":"https://github.com/rigelk","followers_url":"https://api.github.com/users/rigelk/followers","following_url":"https://api.github.com/users/rigelk/following{/other_user}","gists_url":"https://api.github.com/users/rigelk/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelk/subscriptions","organizations_url":"https://api.github.com/users/rigelk/orgs","repos_url":"https://api.github.com/users/rigelk/repos","events_url":"https://api.github.com/users/rigelk/events{/privacy}","received_events_url":"https://api.github.com/users/rigelk/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T18:10:26Z","updated_at":"2018-10-09T18:10:26Z","author_association":"COLLABORATOR","body":"@Nutomic could you rebase your PR now that the `ffmpeg-utils` have changed in develop?"}}
{"actor":{"display_login":"rigelk"}}