{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/213865173","pull_request_review_id":150791848,"id":213865173,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzg2NTE3Mw==","diff_hunk":"@@ -50,12 +50,12 @@ func run(flags *flags, cmd *cobra.Command, args []string) {\n \t// TODO(bentheelder): make this more configurable\n \tctx, err := cluster.NewContext(flags.Name)\n \tif err != nil {\n-\t\tglog.Error(\"Failed to create cluster context! %v\", err)\n+\t\tlog.Errorf(\"Failed to create cluster context! %v\", err)","path":"kind/cmd/kind/delete/delete.go","position":14,"original_position":14,"commit_id":"f5bc37fda3ff0ebd9554e2adf99980555a964e18","original_commit_id":"f5bc37fda3ff0ebd9554e2adf99980555a964e18","user":{"login":"BenTheElder","id":917931,"node_id":"MDQ6VXNlcjkxNzkzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"body":"sure, will do. I also want to take a look at the actual logging patterns more broadly in follow up(s), EG I'm debating the merits of `WithError` for cli tools for example.","created_at":"2018-08-29T23:27:36Z","updated_at":"2018-08-29T23:27:36Z","html_url":"https://github.com/kubernetes/test-infra/pull/9202#discussion_r213865173","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/9202","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/213865173"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/9202#discussion_r213865173"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/9202"}},"in_reply_to_id":213863839},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/9202","id":211912519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTEyNTE5","html_url":"https://github.com/kubernetes/test-infra/pull/9202","diff_url":"https://github.com/kubernetes/test-infra/pull/9202.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/9202.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9202","number":9202,"state":"open","locked":false,"title":"kind: ditch glog for logrus","user":{"login":"BenTheElder","id":917931,"node_id":"MDQ6VXNlcjkxNzkzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"body":"cons:\r\n- glog has arbitrary logging levels (-v=9999 anyone?)\r\n- glog is used in most of the kubernetes code base :(\r\n\r\npros:\r\n- test-infra tooling generally uses logrus\r\n- other than arbitrary integer log levels, logrus is very flexible\r\n- logrus does not require gross hacks in `main()` to deal with `glog`'s global flags\r\n- logrus has different formatters, in particular switching to json formatting can be very good for automation logs, while text formatting is nicer for CLI users\r\n- logrus also does colored output, structured logging, etc.\r\n","created_at":"2018-08-29T23:08:26Z","updated_at":"2018-08-29T23:27:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"582e5b258946b74127e5332ebeca828d79cd03a8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"munnerz","id":203583,"node_id":"MDQ6VXNlcjIwMzU4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":705940018,"node_id":"MDU6TGFiZWw3MDU5NDAwMTg=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1038274939,"node_id":"MDU6TGFiZWwxMDM4Mjc0OTM5","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/kind","name":"area/kind","color":"0052cc","default":false},{"id":484580953,"node_id":"MDU6TGFiZWw0ODQ1ODA5NTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":671133125,"node_id":"MDU6TGFiZWw2NzExMzMxMjU=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/9202/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/9202/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9202/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/f5bc37fda3ff0ebd9554e2adf99980555a964e18","head":{"label":"BenTheElder:walrus","ref":"walrus","sha":"f5bc37fda3ff0ebd9554e2adf99980555a964e18","user":{"login":"BenTheElder","id":917931,"node_id":"MDQ6VXNlcjkxNzkzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"repo":{"id":97753110,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzc1MzExMA==","name":"test-infra","full_name":"BenTheElder/test-infra","owner":{"login":"BenTheElder","id":917931,"node_id":"MDQ6VXNlcjkxNzkzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BenTheElder/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/BenTheElder/test-infra","forks_url":"https://api.github.com/repos/BenTheElder/test-infra/forks","keys_url":"https://api.github.com/repos/BenTheElder/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BenTheElder/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BenTheElder/test-infra/teams","hooks_url":"https://api.github.com/repos/BenTheElder/test-infra/hooks","issue_events_url":"https://api.github.com/repos/BenTheElder/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/BenTheElder/test-infra/events","assignees_url":"https://api.github.com/repos/BenTheElder/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/BenTheElder/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/BenTheElder/test-infra/tags","blobs_url":"https://api.github.com/repos/BenTheElder/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BenTheElder/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BenTheElder/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/BenTheElder/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BenTheElder/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/BenTheElder/test-infra/languages","stargazers_url":"https://api.github.com/repos/BenTheElder/test-infra/stargazers","contributors_url":"https://api.github.com/repos/BenTheElder/test-infra/contributors","subscribers_url":"https://api.github.com/repos/BenTheElder/test-infra/subscribers","subscription_url":"https://api.github.com/repos/BenTheElder/test-infra/subscription","commits_url":"https://api.github.com/repos/BenTheElder/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/BenTheElder/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/BenTheElder/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/BenTheElder/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/BenTheElder/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/BenTheElder/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BenTheElder/test-infra/merges","archive_url":"https://api.github.com/repos/BenTheElder/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BenTheElder/test-infra/downloads","issues_url":"https://api.github.com/repos/BenTheElder/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/BenTheElder/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/BenTheElder/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/BenTheElder/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BenTheElder/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/BenTheElder/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/BenTheElder/test-infra/deployments","created_at":"2017-07-19T19:21:39Z","updated_at":"2018-08-29T20:52:52Z","pushed_at":"2018-08-29T23:18:38Z","git_url":"git://github.com/BenTheElder/test-infra.git","ssh_url":"git@github.com:BenTheElder/test-infra.git","clone_url":"https://github.com/BenTheElder/test-infra.git","svn_url":"https://github.com/BenTheElder/test-infra","homepage":null,"size":59296,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a8cee5a60a2d9476341cf843867221a8bd18a3e8","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"node_id":"MDEwOlJlcG9zaXRvcnk1NzMzMzcwOQ==","name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2018-08-29T22:54:12Z","pushed_at":"2018-08-29T23:26:29Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":60044,"stargazers_count":556,"watchers_count":556,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":541,"mirror_url":null,"archived":false,"open_issues_count":327,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":541,"open_issues":327,"watchers":556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/9202"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/9202"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/9202"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/9202/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/9202/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/9202/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/f5bc37fda3ff0ebd9554e2adf99980555a964e18"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"BenTheElder"}}