{"action":"created","issue":{"url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/384","repository_url":"https://api.github.com/repos/MaslowCNC/Firmware","labels_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/384/labels{/name}","comments_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/384/comments","events_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/384/events","html_url":"https://github.com/MaslowCNC/Firmware/pull/384","id":294633388,"number":384,"title":"Forward kinematic improvements; Sync Settings","user":{"login":"krkeegan","id":3046315,"avatar_url":"https://avatars1.githubusercontent.com/u/3046315?v=4","gravatar_id":"","url":"https://api.github.com/users/krkeegan","html_url":"https://github.com/krkeegan","followers_url":"https://api.github.com/users/krkeegan/followers","following_url":"https://api.github.com/users/krkeegan/following{/other_user}","gists_url":"https://api.github.com/users/krkeegan/gists{/gist_id}","starred_url":"https://api.github.com/users/krkeegan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krkeegan/subscriptions","organizations_url":"https://api.github.com/users/krkeegan/orgs","repos_url":"https://api.github.com/users/krkeegan/repos","events_url":"https://api.github.com/users/krkeegan/events{/privacy}","received_events_url":"https://api.github.com/users/krkeegan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-06T05:03:29Z","updated_at":"2018-02-06T23:33:29Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/384","html_url":"https://github.com/MaslowCNC/Firmware/pull/384","diff_url":"https://github.com/MaslowCNC/Firmware/pull/384.diff","patch_url":"https://github.com/MaslowCNC/Firmware/pull/384.patch"},"body":"This enables the sync settings function from https://github.com/MaslowCNC/GroundControl/pull/608\r\n\r\nIt removes the concept of $K.  Now anytime a setting which alters the kinematics calculation is changed, the forward position is recalculated.\r\n\r\nPreviously forward calculations could take up to 6 seconds, this change limits the search space to no more than the length of the chain, which can be set in ground control.  This results in a maximum search of about .6 seconds.\r\n\r\nThis requires a simultaneous update to GC, so the versions numbers should be changed."},"comment":{"url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/comments/363602846","html_url":"https://github.com/MaslowCNC/Firmware/pull/384#issuecomment-363602846","issue_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/384","id":363602846,"user":{"login":"krkeegan","id":3046315,"avatar_url":"https://avatars1.githubusercontent.com/u/3046315?v=4","gravatar_id":"","url":"https://api.github.com/users/krkeegan","html_url":"https://github.com/krkeegan","followers_url":"https://api.github.com/users/krkeegan/followers","following_url":"https://api.github.com/users/krkeegan/following{/other_user}","gists_url":"https://api.github.com/users/krkeegan/gists{/gist_id}","starred_url":"https://api.github.com/users/krkeegan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krkeegan/subscriptions","organizations_url":"https://api.github.com/users/krkeegan/orgs","repos_url":"https://api.github.com/users/krkeegan/repos","events_url":"https://api.github.com/users/krkeegan/events{/privacy}","received_events_url":"https://api.github.com/users/krkeegan/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T23:33:29Z","updated_at":"2018-02-06T23:33:29Z","author_association":"COLLABORATOR","body":"I think this is working now.\r\n\r\nI have found a reproducible bug, at least when using Fake_Servo(I doubt that matters).  The process is:\r\n\r\n1. Load up GC.\r\n2. Manually move the sled up\r\n3. Stop before the move is complete\r\n4. Somewhat quickly (not sure if this matters) open up advanced settings\r\n5. Enable or disable custom PID position settings\r\n6. GC will then send about 4 of the 6 commands and get stuck\r\n7. No further commands can be sent\r\n\r\nThis seems like an ok/bufferspace issue.  I really wish these things would die.  At first glance I don't see any problems in the log.  So I have to add some debugging to GC to see if the bufferspace is the issue."}}
{"actor":{"display_login":"krkeegan"}}