{"push_id":2908845302,"size":37,"distinct_size":32,"ref":"refs/heads/master","head":"8970638b7d22fb6206f5b03567a215eadc68c951","before":"b31aed0c1123fa8b95acf6af83220075d3c81ba3","commits":[{"sha":"6a15e54097c7cc2d9ec9d0f9790982253f160aea","author":{"name":"Scott Lanning","email":"55746cdfc34815fb7cc2d5c71b63445a84ea9920@booking.com"},"message":"add MysqlServerConnCountPerUser to vtgate /debug/vars\n\nThis keeps the count of connections per user.\nLike MySQL, it also tracks whether the user is authenticated\nor not yet (\"unauthenticated user\")\n(that was suggested by Simon Mudd).\n\nI'm not\tsure if\tit would be necessary to delete\nusers that go to 0 count (if there are many users),\nand that isn't supported yet with vitess counters,\nso I didn't bother with it.\n\n(It looks simpler with `git diff -w`. I used an inline func/closure\nto make a scope for defer connCountPerUser.Add(unauthenticatedUsername, -1)\nwhich re-indented some code. The real changes\ncan mostly be seen by looking for connCountPerUser.)\n\nSigned-off-by: Scott Lanning <scott.lanning@booking.com>","distinct":false,"url":"https://api.github.com/repos/slanning/vitess/commits/6a15e54097c7cc2d9ec9d0f9790982253f160aea"},{"sha":"ec3662c8eb0c31890e6ff92814fcc8ca0201bd4f","author":{"name":"Scott Lanning","email":"55746cdfc34815fb7cc2d5c71b63445a84ea9920@booking.com"},"message":"removed \"func scope\" as suggested\n\nEnded up not putting \"unauthenticated user\" in with the others.\nIt's really simpler not to and, as Sougou mentioned, it can be computed.\n\nI did add MysqlServerConnCountUnauthenticated as a NewGaugeFunc\nso that it can show up in `/debug/vars`. We could also not have that\nand do it from whatever reads `/debug/vars`.\nI think that variable isn't reliable, since I didn't put\na mutex around all the user counts (seemed like a bad idea...).\n\nAlso added some tests. I ended up commenting out the last two,\nwhich test the count after `c.Close()`, because they seemed to need\na little sleep and I didn't see how to test them without them\nbeing flakey.\n(I also have no idea how to test MysqlServerConnCountUnauthenticated ,\nbut for what it's worth verified that it shows up ephemerally\nby running `curl ... /debug/vars` in a loop and throwing 1000 connections at it.)\n\nSigned-off-by: Scott Lanning <scott.lanning@booking.com>","distinct":false,"url":"https://api.github.com/repos/slanning/vitess/commits/ec3662c8eb0c31890e6ff92814fcc8ca0201bd4f"},{"sha":"3550f7bff5223f6d835ce74329eb4329abe5bc7f","author":{"name":"Michael Demmer","email":"4b836671cce77b1b2fbe63e5b2a1661879d8af44@slack-corp.com"},"message":"enable query logging to file in the local examples\n\nSigned-off-by: Michael Demmer <mdemmer@slack-corp.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/3550f7bff5223f6d835ce74329eb4329abe5bc7f"},{"sha":"72f2a007f4b09b2364a5e69acf40927034828aaf","author":{"name":"Dan Kozlowski","email":"62be18c2012b04d2150831e4c6b124c4d64035a8@planetscale.com"},"message":"Adding FIELDS as a option for SHOW\n\nFIELDS is now a valid alternative for SHOW COLUMNS\n\nSigned-off-by: Dan Kozlowski <koz@planetscale.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/72f2a007f4b09b2364a5e69acf40927034828aaf"},{"sha":"0d544957368955c9d1e9aa6370edf3c51e98166e","author":{"name":"Dan Kozlowski","email":"62be18c2012b04d2150831e4c6b124c4d64035a8@planetscale.com"},"message":"Adding in support for MariaDB 10.3\n\nSigned-off-by: Dan Kozlowski <koz@planetscale.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/0d544957368955c9d1e9aa6370edf3c51e98166e"},{"sha":"3c8d86f9fe7883cadb2f21cbc9399f2a5f7ab5fd","author":{"name":"Dan Kozlowski","email":"62be18c2012b04d2150831e4c6b124c4d64035a8@planetscale.com"},"message":"Adding in backwards compatability for those who might not have set EXTRA_MY_CNF's correctly\n\nSigned-off-by: Dan Kozlowski <koz@planetscale.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/3c8d86f9fe7883cadb2f21cbc9399f2a5f7ab5fd"},{"sha":"a14e38c492d121ed714f7cb44aefcb744aaf7125","author":{"name":"Dan Kozlowski","email":"62be18c2012b04d2150831e4c6b124c4d64035a8@planetscale.com"},"message":"Adding full support for parsing SHOW FIELDS\n\nSigned-off-by: Dan Kozlowski <koz@planetscale.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/a14e38c492d121ed714f7cb44aefcb744aaf7125"},{"sha":"b4fb53266659ae8af8efa2cf2eb4827b42c43d1c","author":{"name":"Dan Kozlowski","email":"62be18c2012b04d2150831e4c6b124c4d64035a8@planetscale.com"},"message":"Adding the config root for the extra config files\n\nSigned-off-by: Dan Kozlowski <koz@planetscale.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/b4fb53266659ae8af8efa2cf2eb4827b42c43d1c"},{"sha":"f3b6a3902334da32ce43d05c6b5bcad8bab230be","author":{"name":"Jon Tirsen","email":"a563f38b2a987e2aee263634a499e77cd89fe2fc@squareup.com"},"message":"Support setting the vtcombo transaction_mode\n\nSigned-off-by: Jon Tirsen <jontirsen@squareup.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/f3b6a3902334da32ce43d05c6b5bcad8bab230be"},{"sha":"8d43431bb3efbb83e343259e14964bc772e65a58","author":{"name":"Simon Mudd","email":"0e87671a4e0943f05e606228a64d33c271721c98@booking.com"},"message":"Add S3 support for appliance: Cloudian HyperStore\n\n* Add logging when using s3 for: StartBackup / ListBackups / RemoveBackup\n* Added options to enable usage of an S3 appliance: Cloudian HyperStore:\n      -s3_backup_aws_endpoint <host:port> (port is required)\n      -s3_backup_force_path_style=true/false\n\n  By default the s3 client will try to connect to\n  <path>.<region>.amazonaws.com.  Adjusting the endpoint will allow this\n  to be changed.\n\n  Given the way the FQDN is configured the TLS certificate may not match the\n  server's \"base\" (<region>.<end_point_address>) due to the leading <path>\n  so setting -s3_backup_force_path_style=true will force the s3 client to\n  connect to <region>.<endpoint> and then make a request using the full\n  path within the http calls.\n\nSigned-off-by: Simon Mudd <simon.mudd@booking.com>","distinct":false,"url":"https://api.github.com/repos/slanning/vitess/commits/8d43431bb3efbb83e343259e14964bc772e65a58"},{"sha":"68630f3f6ed6c39775b92055eb701777e90f40bd","author":{"name":"Scott Lanning","email":"55746cdfc34815fb7cc2d5c71b63445a84ea9920@booking.com"},"message":"dereference bucket, which is a string pointer\n\nSigned-off-by: Scott Lanning <scott.lanning@booking.com>","distinct":false,"url":"https://api.github.com/repos/slanning/vitess/commits/68630f3f6ed6c39775b92055eb701777e90f40bd"},{"sha":"5940b272d612baa9b5e4b8707b66edb03a5fc194","author":{"name":"Scott Lanning","email":"55746cdfc34815fb7cc2d5c71b63445a84ea9920@booking.com"},"message":"add -s3_backup_tls_skip_verify_cert flag\n\nIn case for some reason the SSL certificate is invalid...\nthis flag allows disabling the validity check.\n\nSigned-off-by: Scott Lanning <scott.lanning@booking.com>","distinct":false,"url":"https://api.github.com/repos/slanning/vitess/commits/5940b272d612baa9b5e4b8707b66edb03a5fc194"},{"sha":"f760bc5ad3f720007e013d6e0ed283c3f9b5dd1f","author":{"name":"Arthur Neves","email":"a97c4d522bbf25700c868f6869652a8e7e938a5c@gmail.com"},"message":"Update ffi\n\nSigned-off-by: Arthur Neves <arthurnn@gmail.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/f760bc5ad3f720007e013d6e0ed283c3f9b5dd1f"},{"sha":"0666c45f079036aafcbc8c9501e673cceb43c003","author":{"name":"Rafael Chacon","email":"2d8d596a0b97569f9226a8c33ed9c6dbc8d88120@slack-corp.com"},"message":"Adds batch time as parameter\n\nSigned-off-by: Rafael Chacon <rafael@slack-corp.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/0666c45f079036aafcbc8c9501e673cceb43c003"},{"sha":"ecedd214fd212946d7f684fcede1f1a7a8a5a7b0","author":{"name":"Rafael Chacon","email":"2d8d596a0b97569f9226a8c33ed9c6dbc8d88120@slack-corp.com"},"message":"Better naming for variable\n\nSigned-off-by: Rafael Chacon <rafael@slack-corp.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/ecedd214fd212946d7f684fcede1f1a7a8a5a7b0"},{"sha":"9f54f6c5631bb90d82877a9f9c2fb224cd8f738a","author":{"name":"Rafael Chacon","email":"2d8d596a0b97569f9226a8c33ed9c6dbc8d88120@slack-corp.com"},"message":"Updates per code review\n\nSigned-off-by: Rafael Chacon <rafael@slack-corp.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/9f54f6c5631bb90d82877a9f9c2fb224cd8f738a"},{"sha":"7806eb4fd618f23e6b4fff31f1096fe455114545","author":{"name":"Michael Demmer","email":"28fd8c9e6b827484080d2495ad7b7a2e946b3763@gmail.com"},"message":"Merge pull request #4211 from tinyspeck/batch-time-parameter\n\nAdds batch time as parameter","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/7806eb4fd618f23e6b4fff31f1096fe455114545"},{"sha":"cbcebfd2c6dfb9f99a9891cf436367b342e2981b","author":{"name":"Sugu Sougoumarane","email":"b9023a093a3fde2f5ed7cdf696263add90aef9db@gmail.com"},"message":"Merge pull request #4210 from arthurnn/update_ffi_gem\n\nUpdate ffi gem","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/cbcebfd2c6dfb9f99a9891cf436367b342e2981b"},{"sha":"18edbf275f465dfcfb895c3c46c7187ef93e040b","author":{"name":"Dan Kozlowski","email":"62be18c2012b04d2150831e4c6b124c4d64035a8@planetscale.com"},"message":"Removing Tabs, Adding grouping to logical conditions\n\nRemoving tabs from Grammer\nAdding logical grouping to condition\n\nSigned-off-by: Dan Kozlowski <koz@planetscale.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/18edbf275f465dfcfb895c3c46c7187ef93e040b"},{"sha":"c1a2311c903aeed81538cfb40c044ae7776ea0c3","author":{"name":"Rafael Chacon","email":"2d8d596a0b97569f9226a8c33ed9c6dbc8d88120@slack-corp.com"},"message":"Cleans up vtexplain environment\n\nSigned-off-by: Rafael Chacon <rafael@slack-corp.com>","distinct":true,"url":"https://api.github.com/repos/slanning/vitess/commits/c1a2311c903aeed81538cfb40c044ae7776ea0c3"}]}
{"actor":{"display_login":"slanning"}}