{"action":"created","issue":{"url":"https://api.github.com/repos/quanteda/quanteda/issues/1530","repository_url":"https://api.github.com/repos/quanteda/quanteda","labels_url":"https://api.github.com/repos/quanteda/quanteda/issues/1530/labels{/name}","comments_url":"https://api.github.com/repos/quanteda/quanteda/issues/1530/comments","events_url":"https://api.github.com/repos/quanteda/quanteda/issues/1530/events","html_url":"https://github.com/quanteda/quanteda/pull/1530","id":393815531,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNzI0MjAw","number":1530,"title":"Remove unnecessary check","user":{"login":"koheiw","id":6572963,"node_id":"MDQ6VXNlcjY1NzI5NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6572963?v=4","gravatar_id":"","url":"https://api.github.com/users/koheiw","html_url":"https://github.com/koheiw","followers_url":"https://api.github.com/users/koheiw/followers","following_url":"https://api.github.com/users/koheiw/following{/other_user}","gists_url":"https://api.github.com/users/koheiw/gists{/gist_id}","starred_url":"https://api.github.com/users/koheiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koheiw/subscriptions","organizations_url":"https://api.github.com/users/koheiw/orgs","repos_url":"https://api.github.com/users/koheiw/repos","events_url":"https://api.github.com/users/koheiw/events{/privacy}","received_events_url":"https://api.github.com/users/koheiw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-12-24T05:56:19Z","updated_at":"2019-01-01T12:41:39Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/quanteda/quanteda/pulls/1530","html_url":"https://github.com/quanteda/quanteda/pull/1530","diff_url":"https://github.com/quanteda/quanteda/pull/1530.diff","patch_url":"https://github.com/quanteda/quanteda/pull/1530.patch"},"body":"This branch was originally change `textstat_proxy()` to allow users to pass empty DFMs, but it turned out that there are deeper issues with Matrix's dimnames: `dimnames()`, `colnames()` and `rownames()` convert `character()` to `NULL` automatically, and and cause caches in several functions. So I added functions such as `set_dfm_dimnames()` that directly write to the S4 slot. I am open to different names of the internal functions, nonetheless."},"comment":{"url":"https://api.github.com/repos/quanteda/quanteda/issues/comments/450726588","html_url":"https://github.com/quanteda/quanteda/pull/1530#issuecomment-450726588","issue_url":"https://api.github.com/repos/quanteda/quanteda/issues/1530","id":450726588,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDcyNjU4OA==","user":{"login":"kbenoit","id":2182246,"node_id":"MDQ6VXNlcjIxODIyNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2182246?v=4","gravatar_id":"","url":"https://api.github.com/users/kbenoit","html_url":"https://github.com/kbenoit","followers_url":"https://api.github.com/users/kbenoit/followers","following_url":"https://api.github.com/users/kbenoit/following{/other_user}","gists_url":"https://api.github.com/users/kbenoit/gists{/gist_id}","starred_url":"https://api.github.com/users/kbenoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbenoit/subscriptions","organizations_url":"https://api.github.com/users/kbenoit/orgs","repos_url":"https://api.github.com/users/kbenoit/repos","events_url":"https://api.github.com/users/kbenoit/events{/privacy}","received_events_url":"https://api.github.com/users/kbenoit/received_events","type":"User","site_admin":false},"created_at":"2019-01-01T12:41:39Z","updated_at":"2019-01-01T12:41:39Z","author_association":"COLLABORATOR","body":"@koheiw I just added some breaking tests, which I will let you address where you see most appropriate, but I would strongly suggest they be made in `textstat_proxy()` since there zeros currently returned are incorrect.\r\n\r\nWhen those tests pass I think this PR is ready to merge."}}
{"actor":{"display_login":"kbenoit"}}