{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/184903439","pull_request_review_id":116187356,"id":184903439,"diff_hunk":"@@ -73,23 +77,33 @@\n                     \" header values to strings and deserialize them by inferring the schemas.\";\n     public static final String HEADER_CONVERTER_CLASS_DEFAULT = SimpleHeaderConverter.class.getName();\n \n+    /**\n+     * @deprecated As of 1.2.0\n+     */\n+    @Deprecated\n     public static final String INTERNAL_KEY_CONVERTER_CLASS_CONFIG = \"internal.key.converter\";\n     public static final String INTERNAL_KEY_CONVERTER_CLASS_DOC =\n             \"Converter class used to convert between Kafka Connect format and the serialized form that is written to Kafka.\" +\n                     \" This controls the format of the keys in messages written to or read from Kafka, and since this is\" +\n                     \" independent of connectors it allows any connector to work with any serialization format.\" +\n                     \" Examples of common formats include JSON and Avro.\" +\n                     \" This setting controls the format used for internal bookkeeping data used by the framework, such as\" +\n-                    \" configs and offsets, so users can typically use any functioning Converter implementation.\";\n+                    \" configs and offsets, so users can typically use any functioning Converter implementation.\" +\n+                    \" Deprecated; will be removed in an upcoming version.\";\n \n+    /**\n+     * @deprecated As of 1.2.0","path":"connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java","position":39,"original_position":39,"commit_id":"bfba3b1ecf160f2148e7ea4ed03c39e2ee65a665","original_commit_id":"bfba3b1ecf160f2148e7ea4ed03c39e2ee65a665","user":{"login":"ewencp","id":47366,"avatar_url":"https://avatars3.githubusercontent.com/u/47366?v=4","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"body":"Same change here.","created_at":"2018-04-30T01:36:02Z","updated_at":"2018-04-30T01:56:50Z","html_url":"https://github.com/apache/kafka/pull/4693#discussion_r184903439","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4693","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/184903439"},"html":{"href":"https://github.com/apache/kafka/pull/4693#discussion_r184903439"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4693"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4693","id":174508230,"html_url":"https://github.com/apache/kafka/pull/4693","diff_url":"https://github.com/apache/kafka/pull/4693.diff","patch_url":"https://github.com/apache/kafka/pull/4693.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4693","number":4693,"state":"open","locked":false,"title":"KAFKA-5540: Deprecate internal converter configs","user":{"login":"C0urante","id":8636148,"avatar_url":"https://avatars0.githubusercontent.com/u/8636148?v=4","gravatar_id":"","url":"https://api.github.com/users/C0urante","html_url":"https://github.com/C0urante","followers_url":"https://api.github.com/users/C0urante/followers","following_url":"https://api.github.com/users/C0urante/following{/other_user}","gists_url":"https://api.github.com/users/C0urante/gists{/gist_id}","starred_url":"https://api.github.com/users/C0urante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C0urante/subscriptions","organizations_url":"https://api.github.com/users/C0urante/orgs","repos_url":"https://api.github.com/users/C0urante/repos","events_url":"https://api.github.com/users/C0urante/events{/privacy}","received_events_url":"https://api.github.com/users/C0urante/received_events","type":"User","site_admin":false},"body":"Configuration properties 'internal.key.converter' and 'internal.value.converter'\r\nare deprecated, and default to org.apache.kafka.connect.json.JsonConverter.\r\n\r\nWarnings are logged if values are specified for either, or if properties that\r\nappear to configure instances of internal converters (i.e., ones prefixed with\r\neither 'internal.key.converter.' or 'internal.value.converter.') are given.\r\n\r\nThe property 'schemas.enable' is also defaulted to false for internal\r\nJsonConverter instances (both for keys and values) if it isn't specified.\r\n\r\nDocumentation and code have also been updated with deprecation notices and\r\nannotations, respectively.\r\n\r\nUnit tests have been updated in `PluginsTest` to account for the new defaults for `schemas.enable` for internal key/value converters, and to ensure that (for the time being), internal key/value converters are still configurable despite being deprecated.\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-03-12T22:07:23Z","updated_at":"2018-04-30T01:56:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b7505645eec5703057254de20a551b6e334ba82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4693/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4693/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4693/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/bfba3b1ecf160f2148e7ea4ed03c39e2ee65a665","head":{"label":"C0urante:kafka-5540","ref":"kafka-5540","sha":"bfba3b1ecf160f2148e7ea4ed03c39e2ee65a665","user":{"login":"C0urante","id":8636148,"avatar_url":"https://avatars0.githubusercontent.com/u/8636148?v=4","gravatar_id":"","url":"https://api.github.com/users/C0urante","html_url":"https://github.com/C0urante","followers_url":"https://api.github.com/users/C0urante/followers","following_url":"https://api.github.com/users/C0urante/following{/other_user}","gists_url":"https://api.github.com/users/C0urante/gists{/gist_id}","starred_url":"https://api.github.com/users/C0urante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C0urante/subscriptions","organizations_url":"https://api.github.com/users/C0urante/orgs","repos_url":"https://api.github.com/users/C0urante/repos","events_url":"https://api.github.com/users/C0urante/events{/privacy}","received_events_url":"https://api.github.com/users/C0urante/received_events","type":"User","site_admin":false},"repo":{"id":83460713,"name":"kafka","full_name":"C0urante/kafka","owner":{"login":"C0urante","id":8636148,"avatar_url":"https://avatars0.githubusercontent.com/u/8636148?v=4","gravatar_id":"","url":"https://api.github.com/users/C0urante","html_url":"https://github.com/C0urante","followers_url":"https://api.github.com/users/C0urante/followers","following_url":"https://api.github.com/users/C0urante/following{/other_user}","gists_url":"https://api.github.com/users/C0urante/gists{/gist_id}","starred_url":"https://api.github.com/users/C0urante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C0urante/subscriptions","organizations_url":"https://api.github.com/users/C0urante/orgs","repos_url":"https://api.github.com/users/C0urante/repos","events_url":"https://api.github.com/users/C0urante/events{/privacy}","received_events_url":"https://api.github.com/users/C0urante/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/C0urante/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/C0urante/kafka","forks_url":"https://api.github.com/repos/C0urante/kafka/forks","keys_url":"https://api.github.com/repos/C0urante/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/C0urante/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/C0urante/kafka/teams","hooks_url":"https://api.github.com/repos/C0urante/kafka/hooks","issue_events_url":"https://api.github.com/repos/C0urante/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/C0urante/kafka/events","assignees_url":"https://api.github.com/repos/C0urante/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/C0urante/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/C0urante/kafka/tags","blobs_url":"https://api.github.com/repos/C0urante/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/C0urante/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/C0urante/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/C0urante/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/C0urante/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/C0urante/kafka/languages","stargazers_url":"https://api.github.com/repos/C0urante/kafka/stargazers","contributors_url":"https://api.github.com/repos/C0urante/kafka/contributors","subscribers_url":"https://api.github.com/repos/C0urante/kafka/subscribers","subscription_url":"https://api.github.com/repos/C0urante/kafka/subscription","commits_url":"https://api.github.com/repos/C0urante/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/C0urante/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/C0urante/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/C0urante/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/C0urante/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/C0urante/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/C0urante/kafka/merges","archive_url":"https://api.github.com/repos/C0urante/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/C0urante/kafka/downloads","issues_url":"https://api.github.com/repos/C0urante/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/C0urante/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/C0urante/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/C0urante/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/C0urante/kafka/labels{/name}","releases_url":"https://api.github.com/repos/C0urante/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/C0urante/kafka/deployments","created_at":"2017-02-28T17:29:19Z","updated_at":"2017-02-28T17:29:27Z","pushed_at":"2018-04-20T23:55:37Z","git_url":"git://github.com/C0urante/kafka.git","ssh_url":"git@github.com:C0urante/kafka.git","clone_url":"https://github.com/C0urante/kafka.git","svn_url":"https://github.com/C0urante/kafka","homepage":null,"size":61623,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"9eb32eaad5fa3863d60b84ef095fa041e83b7b47","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-04-29T18:01:09Z","pushed_at":"2018-04-29T22:26:49Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":64634,"stargazers_count":8132,"watchers_count":8132,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4783,"mirror_url":null,"archived":false,"open_issues_count":457,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4783,"open_issues":457,"watchers":8132,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4693"},"html":{"href":"https://github.com/apache/kafka/pull/4693"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4693"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4693/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4693/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4693/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/bfba3b1ecf160f2148e7ea4ed03c39e2ee65a665"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ewencp"}}