{"action":"created","comment":{"url":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments/175039739","pull_request_review_id":104505259,"id":175039739,"diff_hunk":"@@ -433,28 +433,43 @@ frame.\n \n ## Server Push\n \n-HTTP/QUIC supports server push as described in {{!RFC7540}}. During connection\n-establishment, the client enables server push by sending a MAX_PUSH_ID frame\n-(see {{frame-max-push-id}}).  A server cannot use server push until it receives\n-a MAX_PUSH_ID frame.\n+HTTP/QUIC supports server push in a similar manner to {{!RFC7540}}, but uses\n+different mechanisms. During connection establishment, the client enables server\n+push by sending a MAX_PUSH_ID frame (see {{frame-max-push-id}}). A server cannot\n+use server push until it receives a MAX_PUSH_ID frame.\n \n As with server push for HTTP/2, the server initiates a server push by sending a\n-PUSH_PROMISE frame that includes request header fields attributed to the\n-request. The PUSH_PROMISE frame is sent on the client-initiated, bidirectional\n-stream that carried the request that generated the push.  This allows the server\n-push to be associated with a request.  Ordering of a PUSH_PROMISE in relation to\n+PUSH_PROMISE frame (see {{frame-push-promise}}) that includes request headers\n+for the promised request.  Promised requests MUST be cacheable (see\n+{{!RFC7231}}, Section 4.2.3), MUST be safe (see {{RFC7231}}, Section 4.2.1), and\n+MUST NOT include a request body.","path":"draft-ietf-quic-http.md","position":21,"original_position":21,"commit_id":"b9875e760dcd1ab161d4eb1b5ab1e0dc0b221c73","original_commit_id":"b9875e760dcd1ab161d4eb1b5ab1e0dc0b221c73","user":{"login":"LPardue","id":6571445,"avatar_url":"https://avatars2.githubusercontent.com/u/6571445?v=4","gravatar_id":"","url":"https://api.github.com/users/LPardue","html_url":"https://github.com/LPardue","followers_url":"https://api.github.com/users/LPardue/followers","following_url":"https://api.github.com/users/LPardue/following{/other_user}","gists_url":"https://api.github.com/users/LPardue/gists{/gist_id}","starred_url":"https://api.github.com/users/LPardue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LPardue/subscriptions","organizations_url":"https://api.github.com/users/LPardue/orgs","repos_url":"https://api.github.com/users/LPardue/repos","events_url":"https://api.github.com/users/LPardue/events{/privacy}","received_events_url":"https://api.github.com/users/LPardue/received_events","type":"User","site_admin":false},"body":"I'd be happy with that","created_at":"2018-03-16T09:49:01Z","updated_at":"2018-03-16T09:49:01Z","html_url":"https://github.com/quicwg/base-drafts/pull/1210#discussion_r175039739","pull_request_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1210","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments/175039739"},"html":{"href":"https://github.com/quicwg/base-drafts/pull/1210#discussion_r175039739"},"pull_request":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1210"}},"in_reply_to_id":175034480},"pull_request":{"url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1210","id":175269213,"html_url":"https://github.com/quicwg/base-drafts/pull/1210","diff_url":"https://github.com/quicwg/base-drafts/pull/1210.diff","patch_url":"https://github.com/quicwg/base-drafts/pull/1210.patch","issue_url":"https://api.github.com/repos/quicwg/base-drafts/issues/1210","number":1210,"state":"open","locked":false,"title":"Improve Push text","user":{"login":"MikeBishop","id":4273797,"avatar_url":"https://avatars0.githubusercontent.com/u/4273797?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeBishop","html_url":"https://github.com/MikeBishop","followers_url":"https://api.github.com/users/MikeBishop/followers","following_url":"https://api.github.com/users/MikeBishop/following{/other_user}","gists_url":"https://api.github.com/users/MikeBishop/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeBishop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeBishop/subscriptions","organizations_url":"https://api.github.com/users/MikeBishop/orgs","repos_url":"https://api.github.com/users/MikeBishop/repos","events_url":"https://api.github.com/users/MikeBishop/events{/privacy}","received_events_url":"https://api.github.com/users/MikeBishop/received_events","type":"User","site_admin":false},"body":"Attempts to resolve #1175.","created_at":"2018-03-15T14:32:32Z","updated_at":"2018-03-16T09:49:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d133f4ae271079e6ae98bd4722b1d75dbaad3e26","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":481871627,"url":"https://api.github.com/repos/quicwg/base-drafts/labels/-http","name":"-http","color":"fbca04","default":false},{"id":481871311,"url":"https://api.github.com/repos/quicwg/base-drafts/labels/editorial","name":"editorial","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1210/commits","review_comments_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/1210/comments","review_comment_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/issues/1210/comments","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/b9875e760dcd1ab161d4eb1b5ab1e0dc0b221c73","head":{"label":"quicwg:http_push","ref":"http_push","sha":"b9875e760dcd1ab161d4eb1b5ab1e0dc0b221c73","user":{"login":"quicwg","id":22631371,"avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"repo":{"id":73779599,"name":"base-drafts","full_name":"quicwg/base-drafts","owner":{"login":"quicwg","id":22631371,"avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quicwg/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":false,"url":"https://api.github.com/repos/quicwg/base-drafts","forks_url":"https://api.github.com/repos/quicwg/base-drafts/forks","keys_url":"https://api.github.com/repos/quicwg/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quicwg/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quicwg/base-drafts/teams","hooks_url":"https://api.github.com/repos/quicwg/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/quicwg/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/quicwg/base-drafts/events","assignees_url":"https://api.github.com/repos/quicwg/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/quicwg/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/quicwg/base-drafts/tags","blobs_url":"https://api.github.com/repos/quicwg/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quicwg/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quicwg/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/quicwg/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/quicwg/base-drafts/languages","stargazers_url":"https://api.github.com/repos/quicwg/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/quicwg/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/quicwg/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/quicwg/base-drafts/subscription","commits_url":"https://api.github.com/repos/quicwg/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/quicwg/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/quicwg/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/quicwg/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/quicwg/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quicwg/base-drafts/merges","archive_url":"https://api.github.com/repos/quicwg/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quicwg/base-drafts/downloads","issues_url":"https://api.github.com/repos/quicwg/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/quicwg/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/quicwg/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/quicwg/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quicwg/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/quicwg/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/quicwg/base-drafts/deployments","created_at":"2016-11-15T05:30:30Z","updated_at":"2018-03-16T09:33:07Z","pushed_at":"2018-03-16T09:40:44Z","git_url":"git://github.com/quicwg/base-drafts.git","ssh_url":"git@github.com:quicwg/base-drafts.git","clone_url":"https://github.com/quicwg/base-drafts.git","svn_url":"https://github.com/quicwg/base-drafts","homepage":"https://quicwg.github.io/","size":44389,"stargazers_count":215,"watchers_count":215,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":115,"license":null,"forks":50,"open_issues":115,"watchers":215,"default_branch":"master"}},"base":{"label":"quicwg:master","ref":"master","sha":"2019b0d94826ede3cf96667d3a960bae16156924","user":{"login":"quicwg","id":22631371,"avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"repo":{"id":73779599,"name":"base-drafts","full_name":"quicwg/base-drafts","owner":{"login":"quicwg","id":22631371,"avatar_url":"https://avatars3.githubusercontent.com/u/22631371?v=4","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quicwg/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":false,"url":"https://api.github.com/repos/quicwg/base-drafts","forks_url":"https://api.github.com/repos/quicwg/base-drafts/forks","keys_url":"https://api.github.com/repos/quicwg/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quicwg/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quicwg/base-drafts/teams","hooks_url":"https://api.github.com/repos/quicwg/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/quicwg/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/quicwg/base-drafts/events","assignees_url":"https://api.github.com/repos/quicwg/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/quicwg/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/quicwg/base-drafts/tags","blobs_url":"https://api.github.com/repos/quicwg/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quicwg/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quicwg/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/quicwg/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/quicwg/base-drafts/languages","stargazers_url":"https://api.github.com/repos/quicwg/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/quicwg/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/quicwg/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/quicwg/base-drafts/subscription","commits_url":"https://api.github.com/repos/quicwg/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/quicwg/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/quicwg/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/quicwg/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/quicwg/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quicwg/base-drafts/merges","archive_url":"https://api.github.com/repos/quicwg/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quicwg/base-drafts/downloads","issues_url":"https://api.github.com/repos/quicwg/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/quicwg/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/quicwg/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/quicwg/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quicwg/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/quicwg/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/quicwg/base-drafts/deployments","created_at":"2016-11-15T05:30:30Z","updated_at":"2018-03-16T09:33:07Z","pushed_at":"2018-03-16T09:40:44Z","git_url":"git://github.com/quicwg/base-drafts.git","ssh_url":"git@github.com:quicwg/base-drafts.git","clone_url":"https://github.com/quicwg/base-drafts.git","svn_url":"https://github.com/quicwg/base-drafts","homepage":"https://quicwg.github.io/","size":44389,"stargazers_count":215,"watchers_count":215,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":115,"license":null,"forks":50,"open_issues":115,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1210"},"html":{"href":"https://github.com/quicwg/base-drafts/pull/1210"},"issue":{"href":"https://api.github.com/repos/quicwg/base-drafts/issues/1210"},"comments":{"href":"https://api.github.com/repos/quicwg/base-drafts/issues/1210/comments"},"review_comments":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1210/comments"},"review_comment":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/1210/commits"},"statuses":{"href":"https://api.github.com/repos/quicwg/base-drafts/statuses/b9875e760dcd1ab161d4eb1b5ab1e0dc0b221c73"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LPardue"}}