{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/202982133","pull_request_review_id":137780017,"id":202982133,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjk4MjEzMw==","diff_hunk":"@@ -1081,12 +1200,22 @@ def define_schreier_generators(C):\n             C.P[beta][C.A_dict_inv[x]] = \"<identity>\"\n             gamma += 1\n         elif x in X and C.P[alpha][C.A_dict[x]] is None:\n+            if rel:\n+                # The schreier generators are defined as\n+                # coset_rep(alpha)*x = schrier_gen*coset_rep(beta)\n+                rh = C.coset_representative(alpha)*x\n+                lh_suffix = C.coset_representative(beta)\n+                for i in range(1, len(rh)):\n+                    if rh.subword(i, len(rh)) == lh_suffix:\n+                        _gens.append(rh.subword(0, i))","path":"sympy/combinatorics/fp_groups.py","position":157,"original_position":157,"commit_id":"92caed859635a0f077ded9c4214576331d5bd424","original_commit_id":"92caed859635a0f077ded9c4214576331d5bd424","user":{"login":"RavicharanN","id":22046387,"node_id":"MDQ6VXNlcjIyMDQ2Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/22046387?v=4","gravatar_id":"","url":"https://api.github.com/users/RavicharanN","html_url":"https://github.com/RavicharanN","followers_url":"https://api.github.com/users/RavicharanN/followers","following_url":"https://api.github.com/users/RavicharanN/following{/other_user}","gists_url":"https://api.github.com/users/RavicharanN/gists{/gist_id}","starred_url":"https://api.github.com/users/RavicharanN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavicharanN/subscriptions","organizations_url":"https://api.github.com/users/RavicharanN/orgs","repos_url":"https://api.github.com/users/RavicharanN/repos","events_url":"https://api.github.com/users/RavicharanN/events{/privacy}","received_events_url":"https://api.github.com/users/RavicharanN/received_events","type":"User","site_admin":false},"body":"Yeah, I've changed it. I just haven't pushed that yet. Also, can we reduce the word after `tau(alpha)*x*tau(beta)**-1` is computed?","created_at":"2018-07-17T11:13:31Z","updated_at":"2018-07-17T11:13:31Z","html_url":"https://github.com/sympy/sympy/pull/14879#discussion_r202982133","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/14879","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/202982133"},"html":{"href":"https://github.com/sympy/sympy/pull/14879#discussion_r202982133"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14879"}},"in_reply_to_id":202981053},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/14879","id":199893795,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODkzNzk1","html_url":"https://github.com/sympy/sympy/pull/14879","diff_url":"https://github.com/sympy/sympy/pull/14879.diff","patch_url":"https://github.com/sympy/sympy/pull/14879.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/14879","number":14879,"state":"open","locked":false,"title":"[WIP] Add methods for Polycyclic Groups ","user":{"login":"RavicharanN","id":22046387,"node_id":"MDQ6VXNlcjIyMDQ2Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/22046387?v=4","gravatar_id":"","url":"https://api.github.com/users/RavicharanN","html_url":"https://github.com/RavicharanN","followers_url":"https://api.github.com/users/RavicharanN/followers","following_url":"https://api.github.com/users/RavicharanN/following{/other_user}","gists_url":"https://api.github.com/users/RavicharanN/gists{/gist_id}","starred_url":"https://api.github.com/users/RavicharanN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavicharanN/subscriptions","organizations_url":"https://api.github.com/users/RavicharanN/orgs","repos_url":"https://api.github.com/users/RavicharanN/repos","events_url":"https://api.github.com/users/RavicharanN/events{/privacy}","received_events_url":"https://api.github.com/users/RavicharanN/received_events","type":"User","site_admin":false},"body":"<!-- Your title above should be a short description of what\r\nwas changed. Do not include the issue number in the title. -->\r\n\r\n#### References to other Issues or PRs\r\n<!-- If this pull request fixes an issue, write \"Fixes #NNNN\" in that exact\r\nformat, e.g. \"Fixes #1234\". See\r\nhttps://github.com/blog/1506-closing-issues-via-pull-requests .-->\r\n\r\n\r\n#### Brief description of what is fixed or changed\r\nCurrently, a few methods are defined to compute the polycyclic series for a solvable `FpGroup`.\r\n\r\n#### To-Do \r\n* Compute the quotient presentation when both `G` and `H` are lists. \r\n* Add class for `PcGroup` \r\n* Elementary methods for `PcGroup` which include `relative_orders`, `compute_pcgs`, `is_prime_order` and collection algorithm.\r\n","created_at":"2018-07-07T11:54:31Z","updated_at":"2018-07-17T11:13:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8818f529ff5b83e5c16133f8d959a59ac722455e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":222449974,"node_id":"MDU6TGFiZWwyMjI0NDk5NzQ=","url":"https://api.github.com/repos/sympy/sympy/labels/PR:%20author's%20turn","name":"PR: author's turn","color":"ffff80","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/14879/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/14879/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/14879/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/92caed859635a0f077ded9c4214576331d5bd424","head":{"label":"RavicharanN:polycyclic","ref":"polycyclic","sha":"92caed859635a0f077ded9c4214576331d5bd424","user":{"login":"RavicharanN","id":22046387,"node_id":"MDQ6VXNlcjIyMDQ2Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/22046387?v=4","gravatar_id":"","url":"https://api.github.com/users/RavicharanN","html_url":"https://github.com/RavicharanN","followers_url":"https://api.github.com/users/RavicharanN/followers","following_url":"https://api.github.com/users/RavicharanN/following{/other_user}","gists_url":"https://api.github.com/users/RavicharanN/gists{/gist_id}","starred_url":"https://api.github.com/users/RavicharanN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavicharanN/subscriptions","organizations_url":"https://api.github.com/users/RavicharanN/orgs","repos_url":"https://api.github.com/users/RavicharanN/repos","events_url":"https://api.github.com/users/RavicharanN/events{/privacy}","received_events_url":"https://api.github.com/users/RavicharanN/received_events","type":"User","site_admin":false},"repo":{"id":118352566,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgzNTI1NjY=","name":"sympy","full_name":"RavicharanN/sympy","owner":{"login":"RavicharanN","id":22046387,"node_id":"MDQ6VXNlcjIyMDQ2Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/22046387?v=4","gravatar_id":"","url":"https://api.github.com/users/RavicharanN","html_url":"https://github.com/RavicharanN","followers_url":"https://api.github.com/users/RavicharanN/followers","following_url":"https://api.github.com/users/RavicharanN/following{/other_user}","gists_url":"https://api.github.com/users/RavicharanN/gists{/gist_id}","starred_url":"https://api.github.com/users/RavicharanN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavicharanN/subscriptions","organizations_url":"https://api.github.com/users/RavicharanN/orgs","repos_url":"https://api.github.com/users/RavicharanN/repos","events_url":"https://api.github.com/users/RavicharanN/events{/privacy}","received_events_url":"https://api.github.com/users/RavicharanN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RavicharanN/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/RavicharanN/sympy","forks_url":"https://api.github.com/repos/RavicharanN/sympy/forks","keys_url":"https://api.github.com/repos/RavicharanN/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RavicharanN/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RavicharanN/sympy/teams","hooks_url":"https://api.github.com/repos/RavicharanN/sympy/hooks","issue_events_url":"https://api.github.com/repos/RavicharanN/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/RavicharanN/sympy/events","assignees_url":"https://api.github.com/repos/RavicharanN/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/RavicharanN/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/RavicharanN/sympy/tags","blobs_url":"https://api.github.com/repos/RavicharanN/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RavicharanN/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RavicharanN/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/RavicharanN/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RavicharanN/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/RavicharanN/sympy/languages","stargazers_url":"https://api.github.com/repos/RavicharanN/sympy/stargazers","contributors_url":"https://api.github.com/repos/RavicharanN/sympy/contributors","subscribers_url":"https://api.github.com/repos/RavicharanN/sympy/subscribers","subscription_url":"https://api.github.com/repos/RavicharanN/sympy/subscription","commits_url":"https://api.github.com/repos/RavicharanN/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/RavicharanN/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/RavicharanN/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/RavicharanN/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/RavicharanN/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/RavicharanN/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RavicharanN/sympy/merges","archive_url":"https://api.github.com/repos/RavicharanN/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RavicharanN/sympy/downloads","issues_url":"https://api.github.com/repos/RavicharanN/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/RavicharanN/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/RavicharanN/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/RavicharanN/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RavicharanN/sympy/labels{/name}","releases_url":"https://api.github.com/repos/RavicharanN/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/RavicharanN/sympy/deployments","created_at":"2018-01-21T16:33:46Z","updated_at":"2018-06-18T17:31:39Z","pushed_at":"2018-07-14T07:44:27Z","git_url":"git://github.com/RavicharanN/sympy.git","ssh_url":"git@github.com:RavicharanN/sympy.git","clone_url":"https://github.com/RavicharanN/sympy.git","svn_url":"https://github.com/RavicharanN/sympy","homepage":"http://sympy.org/","size":91221,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"92d4924237026e105c32cda6db1d575fb3c41f13","user":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MzQ=","name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2018-07-16T19:40:23Z","pushed_at":"2018-07-17T09:39:11Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":91774,"stargazers_count":4945,"watchers_count":4945,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2307,"mirror_url":null,"archived":false,"open_issues_count":3393,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2307,"open_issues":3393,"watchers":4945,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14879"},"html":{"href":"https://github.com/sympy/sympy/pull/14879"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/14879"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/14879/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14879/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14879/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/92caed859635a0f077ded9c4214576331d5bd424"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RavicharanN"}}