{"action":"created","comment":{"url":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/comments/187247422","pull_request_review_id":118987060,"id":187247422,"diff_hunk":"@@ -0,0 +1,29 @@\n+//\n+//  SlideViewController.swift\n+//  RakutenRanking\n+//\n+//  Created by mao takagai on 2018/05/10.\n+//  Copyright © 2018年 mao takagai. All rights reserved.\n+//\n+\n+import Foundation\n+import SlideMenuControllerSwift\n+\n+class SlideViewController: SlideMenuController, SlideMenuControllerDelegate {\n+    \n+    override func viewDidLoad() {\n+        // メニューの横幅\n+        SlideMenuOptions.leftViewWidth = 320\n+        // 画面スワイプ時に感知する左からの横幅\n+        SlideMenuOptions.leftBezelWidth = 20.0\n+        // メニューを開いた時のViewControllerの縮小率\n+        SlideMenuOptions.contentViewScale = 1\n+        // メニューを開いた時にViewControllerをメニューのwidth分ずらす\n+        SlideMenuOptions.contentViewDrag = true\n+        // メニューを表示する速度\n+        SlideMenuOptions.animationDuration = 0.2\n+        ","path":"RakutenRanking/SlideViewController.swift","position":25,"original_position":25,"commit_id":"23a168f7e80fb3868d6fa5f78f4c7d826e40c906","original_commit_id":"23a168f7e80fb3868d6fa5f78f4c7d826e40c906","user":{"login":"sasagawanoriyuki","id":19679548,"avatar_url":"https://avatars3.githubusercontent.com/u/19679548?v=4","gravatar_id":"","url":"https://api.github.com/users/sasagawanoriyuki","html_url":"https://github.com/sasagawanoriyuki","followers_url":"https://api.github.com/users/sasagawanoriyuki/followers","following_url":"https://api.github.com/users/sasagawanoriyuki/following{/other_user}","gists_url":"https://api.github.com/users/sasagawanoriyuki/gists{/gist_id}","starred_url":"https://api.github.com/users/sasagawanoriyuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasagawanoriyuki/subscriptions","organizations_url":"https://api.github.com/users/sasagawanoriyuki/orgs","repos_url":"https://api.github.com/users/sasagawanoriyuki/repos","events_url":"https://api.github.com/users/sasagawanoriyuki/events{/privacy}","received_events_url":"https://api.github.com/users/sasagawanoriyuki/received_events","type":"User","site_admin":false},"body":"MenuViewControllerのスクロールイベントをメインの方でも感知してるので、そこらへん制御できれば直せそうな気がします。","created_at":"2018-05-10T06:07:19Z","updated_at":"2018-05-10T06:07:19Z","html_url":"https://github.com/takagai2/RakutenRanking/pull/95#discussion_r187247422","pull_request_url":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/95","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/comments/187247422"},"html":{"href":"https://github.com/takagai2/RakutenRanking/pull/95#discussion_r187247422"},"pull_request":{"href":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/95"}},"in_reply_to_id":187235185},"pull_request":{"url":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/95","id":187094888,"html_url":"https://github.com/takagai2/RakutenRanking/pull/95","diff_url":"https://github.com/takagai2/RakutenRanking/pull/95.diff","patch_url":"https://github.com/takagai2/RakutenRanking/pull/95.patch","issue_url":"https://api.github.com/repos/takagai2/RakutenRanking/issues/95","number":95,"state":"open","locked":false,"title":"#3 サイドメニューの表示方法変更","user":{"login":"takagai2","id":36285711,"avatar_url":"https://avatars1.githubusercontent.com/u/36285711?v=4","gravatar_id":"","url":"https://api.github.com/users/takagai2","html_url":"https://github.com/takagai2","followers_url":"https://api.github.com/users/takagai2/followers","following_url":"https://api.github.com/users/takagai2/following{/other_user}","gists_url":"https://api.github.com/users/takagai2/gists{/gist_id}","starred_url":"https://api.github.com/users/takagai2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takagai2/subscriptions","organizations_url":"https://api.github.com/users/takagai2/orgs","repos_url":"https://api.github.com/users/takagai2/repos","events_url":"https://api.github.com/users/takagai2/events{/privacy}","received_events_url":"https://api.github.com/users/takagai2/received_events","type":"User","site_admin":false},"body":"# issue\r\n#3 \r\n\r\n# 実装内容\r\n* `SlideMenuControllerSwift` のインポート\r\n* メニューを左から出現させる(スワイプ・ボタンタップ)\r\n* README.mdの修正\r\n* メニューの幅を調整\r\n\r\n# 実装できない内容\r\n* メニューを表示した際のスワイプを一部の領域で無効にしたい\r\n -> メニューを開いた状態でメニュー内の右ページに移動する際、画面のどこで右スワイプを行なっても感知してしまい、メニューを閉じようとするため。\r\n\r\n# 試した事\r\n```\r\n// メニューが表示された時\r\n    func leftDidOpen() {\r\n        // 画面スワイプ時に感知する左からの横幅\r\n        SlideMenuOptions.leftBezelWidth = 0.0\r\n        // 画面スワイプ時に感知する右からの横幅\r\n        SlideMenuOptions.rightBezelWidth = 20.0\r\n    }\r\n    \r\n// メニューが閉じた時\r\n    func leftDidClose() {\r\n        SlideMenuOptions.leftBezelWidth = 20.0\r\n    }\r\n```\r\nメニューが表示された時/閉じた時に呼ばれるメソッド内で\r\nオプションの値を書き換えて見ましたが、反映されませんでした。","created_at":"2018-05-10T03:52:47Z","updated_at":"2018-05-10T06:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f7f86ed594a5e2245974064f2a543d98b66fa2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/95/commits","review_comments_url":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/95/comments","review_comment_url":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/takagai2/RakutenRanking/issues/95/comments","statuses_url":"https://api.github.com/repos/takagai2/RakutenRanking/statuses/23a168f7e80fb3868d6fa5f78f4c7d826e40c906","head":{"label":"takagai2:feature/3-change-how-to-display-the-menu","ref":"feature/3-change-how-to-display-the-menu","sha":"23a168f7e80fb3868d6fa5f78f4c7d826e40c906","user":{"login":"takagai2","id":36285711,"avatar_url":"https://avatars1.githubusercontent.com/u/36285711?v=4","gravatar_id":"","url":"https://api.github.com/users/takagai2","html_url":"https://github.com/takagai2","followers_url":"https://api.github.com/users/takagai2/followers","following_url":"https://api.github.com/users/takagai2/following{/other_user}","gists_url":"https://api.github.com/users/takagai2/gists{/gist_id}","starred_url":"https://api.github.com/users/takagai2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takagai2/subscriptions","organizations_url":"https://api.github.com/users/takagai2/orgs","repos_url":"https://api.github.com/users/takagai2/repos","events_url":"https://api.github.com/users/takagai2/events{/privacy}","received_events_url":"https://api.github.com/users/takagai2/received_events","type":"User","site_admin":false},"repo":{"id":124824410,"name":"RakutenRanking","full_name":"takagai2/RakutenRanking","owner":{"login":"takagai2","id":36285711,"avatar_url":"https://avatars1.githubusercontent.com/u/36285711?v=4","gravatar_id":"","url":"https://api.github.com/users/takagai2","html_url":"https://github.com/takagai2","followers_url":"https://api.github.com/users/takagai2/followers","following_url":"https://api.github.com/users/takagai2/following{/other_user}","gists_url":"https://api.github.com/users/takagai2/gists{/gist_id}","starred_url":"https://api.github.com/users/takagai2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takagai2/subscriptions","organizations_url":"https://api.github.com/users/takagai2/orgs","repos_url":"https://api.github.com/users/takagai2/repos","events_url":"https://api.github.com/users/takagai2/events{/privacy}","received_events_url":"https://api.github.com/users/takagai2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takagai2/RakutenRanking","description":null,"fork":false,"url":"https://api.github.com/repos/takagai2/RakutenRanking","forks_url":"https://api.github.com/repos/takagai2/RakutenRanking/forks","keys_url":"https://api.github.com/repos/takagai2/RakutenRanking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takagai2/RakutenRanking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takagai2/RakutenRanking/teams","hooks_url":"https://api.github.com/repos/takagai2/RakutenRanking/hooks","issue_events_url":"https://api.github.com/repos/takagai2/RakutenRanking/issues/events{/number}","events_url":"https://api.github.com/repos/takagai2/RakutenRanking/events","assignees_url":"https://api.github.com/repos/takagai2/RakutenRanking/assignees{/user}","branches_url":"https://api.github.com/repos/takagai2/RakutenRanking/branches{/branch}","tags_url":"https://api.github.com/repos/takagai2/RakutenRanking/tags","blobs_url":"https://api.github.com/repos/takagai2/RakutenRanking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takagai2/RakutenRanking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takagai2/RakutenRanking/git/refs{/sha}","trees_url":"https://api.github.com/repos/takagai2/RakutenRanking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takagai2/RakutenRanking/statuses/{sha}","languages_url":"https://api.github.com/repos/takagai2/RakutenRanking/languages","stargazers_url":"https://api.github.com/repos/takagai2/RakutenRanking/stargazers","contributors_url":"https://api.github.com/repos/takagai2/RakutenRanking/contributors","subscribers_url":"https://api.github.com/repos/takagai2/RakutenRanking/subscribers","subscription_url":"https://api.github.com/repos/takagai2/RakutenRanking/subscription","commits_url":"https://api.github.com/repos/takagai2/RakutenRanking/commits{/sha}","git_commits_url":"https://api.github.com/repos/takagai2/RakutenRanking/git/commits{/sha}","comments_url":"https://api.github.com/repos/takagai2/RakutenRanking/comments{/number}","issue_comment_url":"https://api.github.com/repos/takagai2/RakutenRanking/issues/comments{/number}","contents_url":"https://api.github.com/repos/takagai2/RakutenRanking/contents/{+path}","compare_url":"https://api.github.com/repos/takagai2/RakutenRanking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takagai2/RakutenRanking/merges","archive_url":"https://api.github.com/repos/takagai2/RakutenRanking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takagai2/RakutenRanking/downloads","issues_url":"https://api.github.com/repos/takagai2/RakutenRanking/issues{/number}","pulls_url":"https://api.github.com/repos/takagai2/RakutenRanking/pulls{/number}","milestones_url":"https://api.github.com/repos/takagai2/RakutenRanking/milestones{/number}","notifications_url":"https://api.github.com/repos/takagai2/RakutenRanking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takagai2/RakutenRanking/labels{/name}","releases_url":"https://api.github.com/repos/takagai2/RakutenRanking/releases{/id}","deployments_url":"https://api.github.com/repos/takagai2/RakutenRanking/deployments","created_at":"2018-03-12T02:44:38Z","updated_at":"2018-05-08T09:55:19Z","pushed_at":"2018-05-10T03:52:48Z","git_url":"git://github.com/takagai2/RakutenRanking.git","ssh_url":"git@github.com:takagai2/RakutenRanking.git","clone_url":"https://github.com/takagai2/RakutenRanking.git","svn_url":"https://github.com/takagai2/RakutenRanking","homepage":null,"size":24396,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":0,"open_issues":15,"watchers":1,"default_branch":"master"}},"base":{"label":"takagai2:master","ref":"master","sha":"4c2a76273e8c6eac6aa7b83b36381f1bfe8b99bf","user":{"login":"takagai2","id":36285711,"avatar_url":"https://avatars1.githubusercontent.com/u/36285711?v=4","gravatar_id":"","url":"https://api.github.com/users/takagai2","html_url":"https://github.com/takagai2","followers_url":"https://api.github.com/users/takagai2/followers","following_url":"https://api.github.com/users/takagai2/following{/other_user}","gists_url":"https://api.github.com/users/takagai2/gists{/gist_id}","starred_url":"https://api.github.com/users/takagai2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takagai2/subscriptions","organizations_url":"https://api.github.com/users/takagai2/orgs","repos_url":"https://api.github.com/users/takagai2/repos","events_url":"https://api.github.com/users/takagai2/events{/privacy}","received_events_url":"https://api.github.com/users/takagai2/received_events","type":"User","site_admin":false},"repo":{"id":124824410,"name":"RakutenRanking","full_name":"takagai2/RakutenRanking","owner":{"login":"takagai2","id":36285711,"avatar_url":"https://avatars1.githubusercontent.com/u/36285711?v=4","gravatar_id":"","url":"https://api.github.com/users/takagai2","html_url":"https://github.com/takagai2","followers_url":"https://api.github.com/users/takagai2/followers","following_url":"https://api.github.com/users/takagai2/following{/other_user}","gists_url":"https://api.github.com/users/takagai2/gists{/gist_id}","starred_url":"https://api.github.com/users/takagai2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takagai2/subscriptions","organizations_url":"https://api.github.com/users/takagai2/orgs","repos_url":"https://api.github.com/users/takagai2/repos","events_url":"https://api.github.com/users/takagai2/events{/privacy}","received_events_url":"https://api.github.com/users/takagai2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takagai2/RakutenRanking","description":null,"fork":false,"url":"https://api.github.com/repos/takagai2/RakutenRanking","forks_url":"https://api.github.com/repos/takagai2/RakutenRanking/forks","keys_url":"https://api.github.com/repos/takagai2/RakutenRanking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takagai2/RakutenRanking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takagai2/RakutenRanking/teams","hooks_url":"https://api.github.com/repos/takagai2/RakutenRanking/hooks","issue_events_url":"https://api.github.com/repos/takagai2/RakutenRanking/issues/events{/number}","events_url":"https://api.github.com/repos/takagai2/RakutenRanking/events","assignees_url":"https://api.github.com/repos/takagai2/RakutenRanking/assignees{/user}","branches_url":"https://api.github.com/repos/takagai2/RakutenRanking/branches{/branch}","tags_url":"https://api.github.com/repos/takagai2/RakutenRanking/tags","blobs_url":"https://api.github.com/repos/takagai2/RakutenRanking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takagai2/RakutenRanking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takagai2/RakutenRanking/git/refs{/sha}","trees_url":"https://api.github.com/repos/takagai2/RakutenRanking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takagai2/RakutenRanking/statuses/{sha}","languages_url":"https://api.github.com/repos/takagai2/RakutenRanking/languages","stargazers_url":"https://api.github.com/repos/takagai2/RakutenRanking/stargazers","contributors_url":"https://api.github.com/repos/takagai2/RakutenRanking/contributors","subscribers_url":"https://api.github.com/repos/takagai2/RakutenRanking/subscribers","subscription_url":"https://api.github.com/repos/takagai2/RakutenRanking/subscription","commits_url":"https://api.github.com/repos/takagai2/RakutenRanking/commits{/sha}","git_commits_url":"https://api.github.com/repos/takagai2/RakutenRanking/git/commits{/sha}","comments_url":"https://api.github.com/repos/takagai2/RakutenRanking/comments{/number}","issue_comment_url":"https://api.github.com/repos/takagai2/RakutenRanking/issues/comments{/number}","contents_url":"https://api.github.com/repos/takagai2/RakutenRanking/contents/{+path}","compare_url":"https://api.github.com/repos/takagai2/RakutenRanking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takagai2/RakutenRanking/merges","archive_url":"https://api.github.com/repos/takagai2/RakutenRanking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takagai2/RakutenRanking/downloads","issues_url":"https://api.github.com/repos/takagai2/RakutenRanking/issues{/number}","pulls_url":"https://api.github.com/repos/takagai2/RakutenRanking/pulls{/number}","milestones_url":"https://api.github.com/repos/takagai2/RakutenRanking/milestones{/number}","notifications_url":"https://api.github.com/repos/takagai2/RakutenRanking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takagai2/RakutenRanking/labels{/name}","releases_url":"https://api.github.com/repos/takagai2/RakutenRanking/releases{/id}","deployments_url":"https://api.github.com/repos/takagai2/RakutenRanking/deployments","created_at":"2018-03-12T02:44:38Z","updated_at":"2018-05-08T09:55:19Z","pushed_at":"2018-05-10T03:52:48Z","git_url":"git://github.com/takagai2/RakutenRanking.git","ssh_url":"git@github.com:takagai2/RakutenRanking.git","clone_url":"https://github.com/takagai2/RakutenRanking.git","svn_url":"https://github.com/takagai2/RakutenRanking","homepage":null,"size":24396,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":0,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/95"},"html":{"href":"https://github.com/takagai2/RakutenRanking/pull/95"},"issue":{"href":"https://api.github.com/repos/takagai2/RakutenRanking/issues/95"},"comments":{"href":"https://api.github.com/repos/takagai2/RakutenRanking/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/takagai2/RakutenRanking/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/takagai2/RakutenRanking/statuses/23a168f7e80fb3868d6fa5f78f4c7d826e40c906"}},"author_association":"OWNER"}}
{"actor":{"display_login":"sasagawanoriyuki"}}