{"action":"created","comment":{"url":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/comments/199426218","pull_request_review_id":133541136,"id":199426218,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTQyNjIxOA==","diff_hunk":"@@ -2,12 +2,13 @@\n \n Rails.application.routes.draw do\n   root controller: :matches, action: :index\n-  \n+\n   namespace :api do\n     resources :matches, only: :create\n   end\n   resources :matches, only: :index\n \n   resources :players, only: [:index, :show]\n   get :ranking, action: :ranking, controller: :players\n+  get 'ranking/elo', action: :show, controller: :ranking","path":"config/routes.rb","position":13,"original_position":13,"commit_id":"e1942ef7b8ce5aa4f973194c0c42f6e33e75a06e","original_commit_id":"e1942ef7b8ce5aa4f973194c0c42f6e33e75a06e","user":{"login":"shadre","id":19561672,"node_id":"MDQ6VXNlcjE5NTYxNjcy","avatar_url":"https://avatars0.githubusercontent.com/u/19561672?v=4","gravatar_id":"","url":"https://api.github.com/users/shadre","html_url":"https://github.com/shadre","followers_url":"https://api.github.com/users/shadre/followers","following_url":"https://api.github.com/users/shadre/following{/other_user}","gists_url":"https://api.github.com/users/shadre/gists{/gist_id}","starred_url":"https://api.github.com/users/shadre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadre/subscriptions","organizations_url":"https://api.github.com/users/shadre/orgs","repos_url":"https://api.github.com/users/shadre/repos","events_url":"https://api.github.com/users/shadre/events{/privacy}","received_events_url":"https://api.github.com/users/shadre/received_events","type":"User","site_admin":false},"body":"I'm unsure about this division between two controllers (lines 12-13).\r\nSo, the `Players` controller currently responds to a request at the `/ranking/` path, and the `Ranking` controller is responsible for `/ranking/elo`.\r\nIt does seem a little confusing to me.","created_at":"2018-07-02T08:54:29Z","updated_at":"2018-07-02T08:54:30Z","html_url":"https://github.com/LunarLogic/foosball-app/pull/87#discussion_r199426218","pull_request_url":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/87","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/comments/199426218"},"html":{"href":"https://github.com/LunarLogic/foosball-app/pull/87#discussion_r199426218"},"pull_request":{"href":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/87","id":198288061,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Mjg4MDYx","html_url":"https://github.com/LunarLogic/foosball-app/pull/87","diff_url":"https://github.com/LunarLogic/foosball-app/pull/87.diff","patch_url":"https://github.com/LunarLogic/foosball-app/pull/87.patch","issue_url":"https://api.github.com/repos/LunarLogic/foosball-app/issues/87","number":87,"state":"open","locked":false,"title":"Elo ranking base","user":{"login":"AkkarinForest","id":30773137,"node_id":"MDQ6VXNlcjMwNzczMTM3","avatar_url":"https://avatars1.githubusercontent.com/u/30773137?v=4","gravatar_id":"","url":"https://api.github.com/users/AkkarinForest","html_url":"https://github.com/AkkarinForest","followers_url":"https://api.github.com/users/AkkarinForest/followers","following_url":"https://api.github.com/users/AkkarinForest/following{/other_user}","gists_url":"https://api.github.com/users/AkkarinForest/gists{/gist_id}","starred_url":"https://api.github.com/users/AkkarinForest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkkarinForest/subscriptions","organizations_url":"https://api.github.com/users/AkkarinForest/orgs","repos_url":"https://api.github.com/users/AkkarinForest/repos","events_url":"https://api.github.com/users/AkkarinForest/events{/privacy}","received_events_url":"https://api.github.com/users/AkkarinForest/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-29T11:17:52Z","updated_at":"2018-07-02T08:54:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4930c2a21a39b7451b65882c76fce282033b174","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/87/commits","review_comments_url":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/87/comments","review_comment_url":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LunarLogic/foosball-app/issues/87/comments","statuses_url":"https://api.github.com/repos/LunarLogic/foosball-app/statuses/e1942ef7b8ce5aa4f973194c0c42f6e33e75a06e","head":{"label":"LunarLogic:elo-ranking","ref":"elo-ranking","sha":"e1942ef7b8ce5aa4f973194c0c42f6e33e75a06e","user":{"login":"LunarLogic","id":32623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjIz","avatar_url":"https://avatars3.githubusercontent.com/u/32623?v=4","gravatar_id":"","url":"https://api.github.com/users/LunarLogic","html_url":"https://github.com/LunarLogic","followers_url":"https://api.github.com/users/LunarLogic/followers","following_url":"https://api.github.com/users/LunarLogic/following{/other_user}","gists_url":"https://api.github.com/users/LunarLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/LunarLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunarLogic/subscriptions","organizations_url":"https://api.github.com/users/LunarLogic/orgs","repos_url":"https://api.github.com/users/LunarLogic/repos","events_url":"https://api.github.com/users/LunarLogic/events{/privacy}","received_events_url":"https://api.github.com/users/LunarLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":129111132,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxMTExMzI=","name":"foosball-app","full_name":"LunarLogic/foosball-app","owner":{"login":"LunarLogic","id":32623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjIz","avatar_url":"https://avatars3.githubusercontent.com/u/32623?v=4","gravatar_id":"","url":"https://api.github.com/users/LunarLogic","html_url":"https://github.com/LunarLogic","followers_url":"https://api.github.com/users/LunarLogic/followers","following_url":"https://api.github.com/users/LunarLogic/following{/other_user}","gists_url":"https://api.github.com/users/LunarLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/LunarLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunarLogic/subscriptions","organizations_url":"https://api.github.com/users/LunarLogic/orgs","repos_url":"https://api.github.com/users/LunarLogic/repos","events_url":"https://api.github.com/users/LunarLogic/events{/privacy}","received_events_url":"https://api.github.com/users/LunarLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LunarLogic/foosball-app","description":"Slack bot project for foosball","fork":false,"url":"https://api.github.com/repos/LunarLogic/foosball-app","forks_url":"https://api.github.com/repos/LunarLogic/foosball-app/forks","keys_url":"https://api.github.com/repos/LunarLogic/foosball-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LunarLogic/foosball-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LunarLogic/foosball-app/teams","hooks_url":"https://api.github.com/repos/LunarLogic/foosball-app/hooks","issue_events_url":"https://api.github.com/repos/LunarLogic/foosball-app/issues/events{/number}","events_url":"https://api.github.com/repos/LunarLogic/foosball-app/events","assignees_url":"https://api.github.com/repos/LunarLogic/foosball-app/assignees{/user}","branches_url":"https://api.github.com/repos/LunarLogic/foosball-app/branches{/branch}","tags_url":"https://api.github.com/repos/LunarLogic/foosball-app/tags","blobs_url":"https://api.github.com/repos/LunarLogic/foosball-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LunarLogic/foosball-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LunarLogic/foosball-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/LunarLogic/foosball-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LunarLogic/foosball-app/statuses/{sha}","languages_url":"https://api.github.com/repos/LunarLogic/foosball-app/languages","stargazers_url":"https://api.github.com/repos/LunarLogic/foosball-app/stargazers","contributors_url":"https://api.github.com/repos/LunarLogic/foosball-app/contributors","subscribers_url":"https://api.github.com/repos/LunarLogic/foosball-app/subscribers","subscription_url":"https://api.github.com/repos/LunarLogic/foosball-app/subscription","commits_url":"https://api.github.com/repos/LunarLogic/foosball-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/LunarLogic/foosball-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/LunarLogic/foosball-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/LunarLogic/foosball-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/LunarLogic/foosball-app/contents/{+path}","compare_url":"https://api.github.com/repos/LunarLogic/foosball-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LunarLogic/foosball-app/merges","archive_url":"https://api.github.com/repos/LunarLogic/foosball-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LunarLogic/foosball-app/downloads","issues_url":"https://api.github.com/repos/LunarLogic/foosball-app/issues{/number}","pulls_url":"https://api.github.com/repos/LunarLogic/foosball-app/pulls{/number}","milestones_url":"https://api.github.com/repos/LunarLogic/foosball-app/milestones{/number}","notifications_url":"https://api.github.com/repos/LunarLogic/foosball-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LunarLogic/foosball-app/labels{/name}","releases_url":"https://api.github.com/repos/LunarLogic/foosball-app/releases{/id}","deployments_url":"https://api.github.com/repos/LunarLogic/foosball-app/deployments","created_at":"2018-04-11T14:59:41Z","updated_at":"2018-06-30T11:54:11Z","pushed_at":"2018-06-30T11:54:10Z","git_url":"git://github.com/LunarLogic/foosball-app.git","ssh_url":"git@github.com:LunarLogic/foosball-app.git","clone_url":"https://github.com/LunarLogic/foosball-app.git","svn_url":"https://github.com/LunarLogic/foosball-app","homepage":null,"size":372,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"LunarLogic:master","ref":"master","sha":"7e8f73ebfc1dcdc0d9452f49fddc1684f4fa12c6","user":{"login":"LunarLogic","id":32623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjIz","avatar_url":"https://avatars3.githubusercontent.com/u/32623?v=4","gravatar_id":"","url":"https://api.github.com/users/LunarLogic","html_url":"https://github.com/LunarLogic","followers_url":"https://api.github.com/users/LunarLogic/followers","following_url":"https://api.github.com/users/LunarLogic/following{/other_user}","gists_url":"https://api.github.com/users/LunarLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/LunarLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunarLogic/subscriptions","organizations_url":"https://api.github.com/users/LunarLogic/orgs","repos_url":"https://api.github.com/users/LunarLogic/repos","events_url":"https://api.github.com/users/LunarLogic/events{/privacy}","received_events_url":"https://api.github.com/users/LunarLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":129111132,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxMTExMzI=","name":"foosball-app","full_name":"LunarLogic/foosball-app","owner":{"login":"LunarLogic","id":32623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjIz","avatar_url":"https://avatars3.githubusercontent.com/u/32623?v=4","gravatar_id":"","url":"https://api.github.com/users/LunarLogic","html_url":"https://github.com/LunarLogic","followers_url":"https://api.github.com/users/LunarLogic/followers","following_url":"https://api.github.com/users/LunarLogic/following{/other_user}","gists_url":"https://api.github.com/users/LunarLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/LunarLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunarLogic/subscriptions","organizations_url":"https://api.github.com/users/LunarLogic/orgs","repos_url":"https://api.github.com/users/LunarLogic/repos","events_url":"https://api.github.com/users/LunarLogic/events{/privacy}","received_events_url":"https://api.github.com/users/LunarLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LunarLogic/foosball-app","description":"Slack bot project for foosball","fork":false,"url":"https://api.github.com/repos/LunarLogic/foosball-app","forks_url":"https://api.github.com/repos/LunarLogic/foosball-app/forks","keys_url":"https://api.github.com/repos/LunarLogic/foosball-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LunarLogic/foosball-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LunarLogic/foosball-app/teams","hooks_url":"https://api.github.com/repos/LunarLogic/foosball-app/hooks","issue_events_url":"https://api.github.com/repos/LunarLogic/foosball-app/issues/events{/number}","events_url":"https://api.github.com/repos/LunarLogic/foosball-app/events","assignees_url":"https://api.github.com/repos/LunarLogic/foosball-app/assignees{/user}","branches_url":"https://api.github.com/repos/LunarLogic/foosball-app/branches{/branch}","tags_url":"https://api.github.com/repos/LunarLogic/foosball-app/tags","blobs_url":"https://api.github.com/repos/LunarLogic/foosball-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LunarLogic/foosball-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LunarLogic/foosball-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/LunarLogic/foosball-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LunarLogic/foosball-app/statuses/{sha}","languages_url":"https://api.github.com/repos/LunarLogic/foosball-app/languages","stargazers_url":"https://api.github.com/repos/LunarLogic/foosball-app/stargazers","contributors_url":"https://api.github.com/repos/LunarLogic/foosball-app/contributors","subscribers_url":"https://api.github.com/repos/LunarLogic/foosball-app/subscribers","subscription_url":"https://api.github.com/repos/LunarLogic/foosball-app/subscription","commits_url":"https://api.github.com/repos/LunarLogic/foosball-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/LunarLogic/foosball-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/LunarLogic/foosball-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/LunarLogic/foosball-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/LunarLogic/foosball-app/contents/{+path}","compare_url":"https://api.github.com/repos/LunarLogic/foosball-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LunarLogic/foosball-app/merges","archive_url":"https://api.github.com/repos/LunarLogic/foosball-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LunarLogic/foosball-app/downloads","issues_url":"https://api.github.com/repos/LunarLogic/foosball-app/issues{/number}","pulls_url":"https://api.github.com/repos/LunarLogic/foosball-app/pulls{/number}","milestones_url":"https://api.github.com/repos/LunarLogic/foosball-app/milestones{/number}","notifications_url":"https://api.github.com/repos/LunarLogic/foosball-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LunarLogic/foosball-app/labels{/name}","releases_url":"https://api.github.com/repos/LunarLogic/foosball-app/releases{/id}","deployments_url":"https://api.github.com/repos/LunarLogic/foosball-app/deployments","created_at":"2018-04-11T14:59:41Z","updated_at":"2018-06-30T11:54:11Z","pushed_at":"2018-06-30T11:54:10Z","git_url":"git://github.com/LunarLogic/foosball-app.git","ssh_url":"git@github.com:LunarLogic/foosball-app.git","clone_url":"https://github.com/LunarLogic/foosball-app.git","svn_url":"https://github.com/LunarLogic/foosball-app","homepage":null,"size":372,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/87"},"html":{"href":"https://github.com/LunarLogic/foosball-app/pull/87"},"issue":{"href":"https://api.github.com/repos/LunarLogic/foosball-app/issues/87"},"comments":{"href":"https://api.github.com/repos/LunarLogic/foosball-app/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LunarLogic/foosball-app/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/LunarLogic/foosball-app/statuses/e1942ef7b8ce5aa4f973194c0c42f6e33e75a06e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"shadre"}}