{"action":"created","comment":{"url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments/243417721","pull_request_review_id":187184504,"id":243417721,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQxNzcyMQ==","diff_hunk":"@@ -285,7 +290,7 @@ def share(self):\n \n     def update_params(self):\n         \"\"\"Do optim step and clip gradients if needed.\"\"\"\n-        if self.clip > 0:\n+        if hasattr(self, 'clip') and self.clip > 0:","path":"parlai/core/torch_ranker_agent.py","position":35,"original_position":35,"commit_id":"eb322bf2df06318a1597bd51f961e12ace3e144b","original_commit_id":"eb322bf2df06318a1597bd51f961e12ace3e144b","user":{"login":"stephenroller","id":31896,"node_id":"MDQ6VXNlcjMxODk2","avatar_url":"https://avatars2.githubusercontent.com/u/31896?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenroller","html_url":"https://github.com/stephenroller","followers_url":"https://api.github.com/users/stephenroller/followers","following_url":"https://api.github.com/users/stephenroller/following{/other_user}","gists_url":"https://api.github.com/users/stephenroller/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenroller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenroller/subscriptions","organizations_url":"https://api.github.com/users/stephenroller/orgs","repos_url":"https://api.github.com/users/stephenroller/repos","events_url":"https://api.github.com/users/stephenroller/events{/privacy}","received_events_url":"https://api.github.com/users/stephenroller/received_events","type":"User","site_admin":false},"body":"Should be `self.get('gradient_clip', 0)` I believe.","created_at":"2018-12-20T21:06:33Z","updated_at":"2018-12-20T21:06:34Z","html_url":"https://github.com/facebookresearch/ParlAI/pull/1326#discussion_r243417721","pull_request_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/1326","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments/243417721"},"html":{"href":"https://github.com/facebookresearch/ParlAI/pull/1326#discussion_r243417721"},"pull_request":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/1326"}},"in_reply_to_id":243386872},"pull_request":{"url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/1326","id":240268108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjY4MTA4","html_url":"https://github.com/facebookresearch/ParlAI/pull/1326","diff_url":"https://github.com/facebookresearch/ParlAI/pull/1326.diff","patch_url":"https://github.com/facebookresearch/ParlAI/pull/1326.patch","issue_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/1326","number":1326,"state":"open","locked":false,"title":"Bunch of bugs/corner cases fixes for TRA","user":{"login":"samhumeau","id":4238961,"node_id":"MDQ6VXNlcjQyMzg5NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/4238961?v=4","gravatar_id":"","url":"https://api.github.com/users/samhumeau","html_url":"https://github.com/samhumeau","followers_url":"https://api.github.com/users/samhumeau/followers","following_url":"https://api.github.com/users/samhumeau/following{/other_user}","gists_url":"https://api.github.com/users/samhumeau/gists{/gist_id}","starred_url":"https://api.github.com/users/samhumeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhumeau/subscriptions","organizations_url":"https://api.github.com/users/samhumeau/orgs","repos_url":"https://api.github.com/users/samhumeau/repos","events_url":"https://api.github.com/users/samhumeau/events{/privacy}","received_events_url":"https://api.github.com/users/samhumeau/received_events","type":"User","site_admin":false},"body":"- Do not define optimizer for every agent\r\n- handle case where NULL_IDX is not 0 \r\n- clip is not really defined anywhere is it? added the case where it's not define\r\n- In some weird cases you can expect the text vec to have been over padded. The text + pad can end up being longer than candidates.  ","created_at":"2018-12-20T18:50:44Z","updated_at":"2018-12-20T21:06:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"298d29790539504b3b68b25c2bd0ff949248cf1e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"stephenroller","id":31896,"node_id":"MDQ6VXNlcjMxODk2","avatar_url":"https://avatars2.githubusercontent.com/u/31896?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenroller","html_url":"https://github.com/stephenroller","followers_url":"https://api.github.com/users/stephenroller/followers","following_url":"https://api.github.com/users/stephenroller/following{/other_user}","gists_url":"https://api.github.com/users/stephenroller/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenroller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenroller/subscriptions","organizations_url":"https://api.github.com/users/stephenroller/orgs","repos_url":"https://api.github.com/users/stephenroller/repos","events_url":"https://api.github.com/users/stephenroller/events{/privacy}","received_events_url":"https://api.github.com/users/stephenroller/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":590886701,"node_id":"MDU6TGFiZWw1OTA4ODY3MDE=","url":"https://api.github.com/repos/facebookresearch/ParlAI/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/1326/commits","review_comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/1326/comments","review_comment_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/1326/comments","statuses_url":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/eb322bf2df06318a1597bd51f961e12ace3e144b","head":{"label":"facebookresearch:tra_bug_fixes","ref":"tra_bug_fixes","sha":"eb322bf2df06318a1597bd51f961e12ace3e144b","user":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":89266735,"node_id":"MDEwOlJlcG9zaXRvcnk4OTI2NjczNQ==","name":"ParlAI","full_name":"facebookresearch/ParlAI","private":false,"owner":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebookresearch/ParlAI","description":"A framework for training and evaluating AI models on a variety of openly available dialog datasets.","fork":false,"url":"https://api.github.com/repos/facebookresearch/ParlAI","forks_url":"https://api.github.com/repos/facebookresearch/ParlAI/forks","keys_url":"https://api.github.com/repos/facebookresearch/ParlAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/ParlAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/ParlAI/teams","hooks_url":"https://api.github.com/repos/facebookresearch/ParlAI/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/ParlAI/events","assignees_url":"https://api.github.com/repos/facebookresearch/ParlAI/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/ParlAI/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/tags","blobs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/ParlAI/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/ParlAI/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/ParlAI/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscription","commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/ParlAI/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/ParlAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/ParlAI/merges","archive_url":"https://api.github.com/repos/facebookresearch/ParlAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/ParlAI/downloads","issues_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/ParlAI/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/ParlAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/ParlAI/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/ParlAI/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/ParlAI/deployments","created_at":"2017-04-24T17:10:44Z","updated_at":"2018-12-20T18:22:33Z","pushed_at":"2018-12-20T20:30:15Z","git_url":"git://github.com/facebookresearch/ParlAI.git","ssh_url":"git@github.com:facebookresearch/ParlAI.git","clone_url":"https://github.com/facebookresearch/ParlAI.git","svn_url":"https://github.com/facebookresearch/ParlAI","homepage":"parl.ai","size":13518,"stargazers_count":3968,"watchers_count":3968,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":715,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":715,"open_issues":23,"watchers":3968,"default_branch":"master"}},"base":{"label":"facebookresearch:master","ref":"master","sha":"75bab7b6ac295b0a525e0056414c52dbab19e408","user":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":89266735,"node_id":"MDEwOlJlcG9zaXRvcnk4OTI2NjczNQ==","name":"ParlAI","full_name":"facebookresearch/ParlAI","private":false,"owner":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebookresearch/ParlAI","description":"A framework for training and evaluating AI models on a variety of openly available dialog datasets.","fork":false,"url":"https://api.github.com/repos/facebookresearch/ParlAI","forks_url":"https://api.github.com/repos/facebookresearch/ParlAI/forks","keys_url":"https://api.github.com/repos/facebookresearch/ParlAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/ParlAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/ParlAI/teams","hooks_url":"https://api.github.com/repos/facebookresearch/ParlAI/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/ParlAI/events","assignees_url":"https://api.github.com/repos/facebookresearch/ParlAI/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/ParlAI/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/tags","blobs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/ParlAI/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/ParlAI/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/ParlAI/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscription","commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/ParlAI/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/ParlAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/ParlAI/merges","archive_url":"https://api.github.com/repos/facebookresearch/ParlAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/ParlAI/downloads","issues_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/ParlAI/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/ParlAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/ParlAI/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/ParlAI/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/ParlAI/deployments","created_at":"2017-04-24T17:10:44Z","updated_at":"2018-12-20T18:22:33Z","pushed_at":"2018-12-20T20:30:15Z","git_url":"git://github.com/facebookresearch/ParlAI.git","ssh_url":"git@github.com:facebookresearch/ParlAI.git","clone_url":"https://github.com/facebookresearch/ParlAI.git","svn_url":"https://github.com/facebookresearch/ParlAI","homepage":"parl.ai","size":13518,"stargazers_count":3968,"watchers_count":3968,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":715,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":715,"open_issues":23,"watchers":3968,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/1326"},"html":{"href":"https://github.com/facebookresearch/ParlAI/pull/1326"},"issue":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/issues/1326"},"comments":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/issues/1326/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/1326/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/1326/commits"},"statuses":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/eb322bf2df06318a1597bd51f961e12ace3e144b"}},"author_association":"NONE"}}
{"actor":{"display_login":"stephenroller"}}