{"action":"created","issue":{"url":"https://api.github.com/repos/highcharts/node-export-server/issues/146","repository_url":"https://api.github.com/repos/highcharts/node-export-server","labels_url":"https://api.github.com/repos/highcharts/node-export-server/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/highcharts/node-export-server/issues/146/comments","events_url":"https://api.github.com/repos/highcharts/node-export-server/issues/146/events","html_url":"https://github.com/highcharts/node-export-server/issues/146","id":334866457,"node_id":"MDU6SXNzdWUzMzQ4NjY0NTc=","number":146,"title":"Silent install of node-export server","user":{"login":"PaulDalek","id":19933566,"node_id":"MDQ6VXNlcjE5OTMzNTY2","avatar_url":"https://avatars0.githubusercontent.com/u/19933566?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulDalek","html_url":"https://github.com/PaulDalek","followers_url":"https://api.github.com/users/PaulDalek/followers","following_url":"https://api.github.com/users/PaulDalek/following{/other_user}","gists_url":"https://api.github.com/users/PaulDalek/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulDalek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulDalek/subscriptions","organizations_url":"https://api.github.com/users/PaulDalek/orgs","repos_url":"https://api.github.com/users/PaulDalek/repos","events_url":"https://api.github.com/users/PaulDalek/events{/privacy}","received_events_url":"https://api.github.com/users/PaulDalek/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-22T12:49:59Z","updated_at":"2018-07-27T11:40:30Z","closed_at":"2018-07-27T11:40:30Z","author_association":"NONE","body":"#### Actual behaviour\r\nIt seems that when installing node-export server silently, environment variables HIGHCHARTS_USE_MAPS and HIGHCHARTS_USE_STYLED evaluate always to true.\r\n\r\n#### Suggested solution\r\nReplace:\r\n\r\n```\r\nembedAll(process.env.HIGHCHARTS_VERSION || 'latest',\r\n  process.env.HIGHCHARTS_USE_STYLED || true,\r\n  process.env.HIGHCHARTS_USE_MAPS || true,\r\n  process.env.HIGHCHARTS_MOMENT || false\r\n);\r\n```\r\n\r\nwith:\r\n\r\n```\r\nembedAll(process.env.HIGHCHARTS_VERSION || 'latest',\r\n  affirmative(process.env.HIGHCHARTS_USE_STYLED),\r\n  affirmative(process.env.HIGHCHARTS_USE_MAPS),\r\n  affirmative(process.env.HIGHCHARTS_MOMENT)\r\n);\r\n```"},"comment":{"url":"https://api.github.com/repos/highcharts/node-export-server/issues/comments/408394079","html_url":"https://github.com/highcharts/node-export-server/issues/146#issuecomment-408394079","issue_url":"https://api.github.com/repos/highcharts/node-export-server/issues/146","id":408394079,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODM5NDA3OQ==","user":{"login":"cvasseng","id":1998167,"node_id":"MDQ6VXNlcjE5OTgxNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1998167?v=4","gravatar_id":"","url":"https://api.github.com/users/cvasseng","html_url":"https://github.com/cvasseng","followers_url":"https://api.github.com/users/cvasseng/followers","following_url":"https://api.github.com/users/cvasseng/following{/other_user}","gists_url":"https://api.github.com/users/cvasseng/gists{/gist_id}","starred_url":"https://api.github.com/users/cvasseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvasseng/subscriptions","organizations_url":"https://api.github.com/users/cvasseng/orgs","repos_url":"https://api.github.com/users/cvasseng/repos","events_url":"https://api.github.com/users/cvasseng/events{/privacy}","received_events_url":"https://api.github.com/users/cvasseng/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T11:40:30Z","updated_at":"2018-07-27T11:40:30Z","author_association":"CONTRIBUTOR","body":"Thanks for reporting, I've committed a fix.\r\n\r\nWe need the defaults so we don't break backwards compatibility (for the public server especially), so implemented it a bit differently."}}
{"actor":{"display_login":"cvasseng"}}