{"action":"closed","number":5364,"pull_request":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/5364","id":172596643,"html_url":"https://github.com/sakaiproject/sakai/pull/5364","diff_url":"https://github.com/sakaiproject/sakai/pull/5364.diff","patch_url":"https://github.com/sakaiproject/sakai/pull/5364.patch","issue_url":"https://api.github.com/repos/sakaiproject/sakai/issues/5364","number":5364,"state":"closed","locked":false,"title":"SAK-33977 - The worksitesetup.filtertermdropdowns property should refine results further","user":{"login":"bbailla2","id":10620229,"avatar_url":"https://avatars1.githubusercontent.com/u/10620229?v=4","gravatar_id":"","url":"https://api.github.com/users/bbailla2","html_url":"https://github.com/bbailla2","followers_url":"https://api.github.com/users/bbailla2/followers","following_url":"https://api.github.com/users/bbailla2/following{/other_user}","gists_url":"https://api.github.com/users/bbailla2/gists{/gist_id}","starred_url":"https://api.github.com/users/bbailla2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbailla2/subscriptions","organizations_url":"https://api.github.com/users/bbailla2/orgs","repos_url":"https://api.github.com/users/bbailla2/repos","events_url":"https://api.github.com/users/bbailla2/events{/privacy}","received_events_url":"https://api.github.com/users/bbailla2/received_events","type":"User","site_admin":false},"body":"Consider a Sakai instance configured with the property:\r\nworksitesetup.filtertermdropdowns=true\r\nIe. this property controls Worksite Setup -> New -> Course Site, so that the displayed courses are filtered to contain only those in which the user has enrolments\r\n\r\nNow, consider an instructor who's about to study a course outside their field. Since the user is an instructor in their own field, they would have the site.add.course permission on their user role (E.g. 'registered'); yet they exist in the new roster as a student. Currently the instructor could go into Worksite Setup-> New -> Course Site, and proceed to create the course site in which they are enrolled as a student. That is, the filtertermdropdowns logic looks at their user role, then searches for any enrolments regardless of the user's roster role to populate the course creation dropdowns. We would like course sites to be creatable only by users with the appropriate roster roles. And of course, the site role permissions won't do since the site doesn't exist yet.\r\n\r\nThis ticket will introduce a sakai.property to determine which roster roles are allowed to create course sites:\r\n```\r\n# Default is empty, but to set it to Instructors and TAs for instance:\r\nwsetup.create.course.allowedRoles=I,GSI\r\n```","created_at":"2018-03-02T20:27:05Z","updated_at":"2018-03-27T15:14:31Z","closed_at":"2018-03-27T15:14:31Z","merged_at":"2018-03-27T15:14:31Z","merge_commit_sha":"50b550c8dba84ec49d1f4db7727f7b39c9676d8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/5364/commits","review_comments_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/5364/comments","review_comment_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/issues/5364/comments","statuses_url":"https://api.github.com/repos/sakaiproject/sakai/statuses/0c52c25a49031eee3720e2f532ef3ce17eee07e5","head":{"label":"bbailla2:SAK-33977","ref":"SAK-33977","sha":"0c52c25a49031eee3720e2f532ef3ce17eee07e5","user":{"login":"bbailla2","id":10620229,"avatar_url":"https://avatars1.githubusercontent.com/u/10620229?v=4","gravatar_id":"","url":"https://api.github.com/users/bbailla2","html_url":"https://github.com/bbailla2","followers_url":"https://api.github.com/users/bbailla2/followers","following_url":"https://api.github.com/users/bbailla2/following{/other_user}","gists_url":"https://api.github.com/users/bbailla2/gists{/gist_id}","starred_url":"https://api.github.com/users/bbailla2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbailla2/subscriptions","organizations_url":"https://api.github.com/users/bbailla2/orgs","repos_url":"https://api.github.com/users/bbailla2/repos","events_url":"https://api.github.com/users/bbailla2/events{/privacy}","received_events_url":"https://api.github.com/users/bbailla2/received_events","type":"User","site_admin":false},"repo":{"id":29549815,"name":"sakai","full_name":"bbailla2/sakai","owner":{"login":"bbailla2","id":10620229,"avatar_url":"https://avatars1.githubusercontent.com/u/10620229?v=4","gravatar_id":"","url":"https://api.github.com/users/bbailla2","html_url":"https://github.com/bbailla2","followers_url":"https://api.github.com/users/bbailla2/followers","following_url":"https://api.github.com/users/bbailla2/following{/other_user}","gists_url":"https://api.github.com/users/bbailla2/gists{/gist_id}","starred_url":"https://api.github.com/users/bbailla2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbailla2/subscriptions","organizations_url":"https://api.github.com/users/bbailla2/orgs","repos_url":"https://api.github.com/users/bbailla2/repos","events_url":"https://api.github.com/users/bbailla2/events{/privacy}","received_events_url":"https://api.github.com/users/bbailla2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbailla2/sakai","description":"Sakai is a freely available, feature-rich technology solution for learning, teaching, research and collaboration. Sakai is an open source software suite developed by a diverse and global adopter community.","fork":true,"url":"https://api.github.com/repos/bbailla2/sakai","forks_url":"https://api.github.com/repos/bbailla2/sakai/forks","keys_url":"https://api.github.com/repos/bbailla2/sakai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbailla2/sakai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbailla2/sakai/teams","hooks_url":"https://api.github.com/repos/bbailla2/sakai/hooks","issue_events_url":"https://api.github.com/repos/bbailla2/sakai/issues/events{/number}","events_url":"https://api.github.com/repos/bbailla2/sakai/events","assignees_url":"https://api.github.com/repos/bbailla2/sakai/assignees{/user}","branches_url":"https://api.github.com/repos/bbailla2/sakai/branches{/branch}","tags_url":"https://api.github.com/repos/bbailla2/sakai/tags","blobs_url":"https://api.github.com/repos/bbailla2/sakai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbailla2/sakai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbailla2/sakai/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbailla2/sakai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbailla2/sakai/statuses/{sha}","languages_url":"https://api.github.com/repos/bbailla2/sakai/languages","stargazers_url":"https://api.github.com/repos/bbailla2/sakai/stargazers","contributors_url":"https://api.github.com/repos/bbailla2/sakai/contributors","subscribers_url":"https://api.github.com/repos/bbailla2/sakai/subscribers","subscription_url":"https://api.github.com/repos/bbailla2/sakai/subscription","commits_url":"https://api.github.com/repos/bbailla2/sakai/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbailla2/sakai/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbailla2/sakai/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbailla2/sakai/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbailla2/sakai/contents/{+path}","compare_url":"https://api.github.com/repos/bbailla2/sakai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbailla2/sakai/merges","archive_url":"https://api.github.com/repos/bbailla2/sakai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbailla2/sakai/downloads","issues_url":"https://api.github.com/repos/bbailla2/sakai/issues{/number}","pulls_url":"https://api.github.com/repos/bbailla2/sakai/pulls{/number}","milestones_url":"https://api.github.com/repos/bbailla2/sakai/milestones{/number}","notifications_url":"https://api.github.com/repos/bbailla2/sakai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbailla2/sakai/labels{/name}","releases_url":"https://api.github.com/repos/bbailla2/sakai/releases{/id}","deployments_url":"https://api.github.com/repos/bbailla2/sakai/deployments","created_at":"2015-01-20T20:13:54Z","updated_at":"2018-03-16T18:54:56Z","pushed_at":"2018-03-16T18:54:45Z","git_url":"git://github.com/bbailla2/sakai.git","ssh_url":"git@github.com:bbailla2/sakai.git","clone_url":"https://github.com/bbailla2/sakai.git","svn_url":"https://github.com/bbailla2/sakai","homepage":"https://www.sakaiproject.org","size":348925,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"ecl-2.0","name":"Educational Community License v2.0","spdx_id":"ECL-2.0","url":"https://api.github.com/licenses/ecl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sakaiproject:master","ref":"master","sha":"72f83dddd904f26e4dfd8b92369fbefc6e78e14d","user":{"login":"sakaiproject","id":314726,"avatar_url":"https://avatars0.githubusercontent.com/u/314726?v=4","gravatar_id":"","url":"https://api.github.com/users/sakaiproject","html_url":"https://github.com/sakaiproject","followers_url":"https://api.github.com/users/sakaiproject/followers","following_url":"https://api.github.com/users/sakaiproject/following{/other_user}","gists_url":"https://api.github.com/users/sakaiproject/gists{/gist_id}","starred_url":"https://api.github.com/users/sakaiproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakaiproject/subscriptions","organizations_url":"https://api.github.com/users/sakaiproject/orgs","repos_url":"https://api.github.com/users/sakaiproject/repos","events_url":"https://api.github.com/users/sakaiproject/events{/privacy}","received_events_url":"https://api.github.com/users/sakaiproject/received_events","type":"Organization","site_admin":false},"repo":{"id":28589709,"name":"sakai","full_name":"sakaiproject/sakai","owner":{"login":"sakaiproject","id":314726,"avatar_url":"https://avatars0.githubusercontent.com/u/314726?v=4","gravatar_id":"","url":"https://api.github.com/users/sakaiproject","html_url":"https://github.com/sakaiproject","followers_url":"https://api.github.com/users/sakaiproject/followers","following_url":"https://api.github.com/users/sakaiproject/following{/other_user}","gists_url":"https://api.github.com/users/sakaiproject/gists{/gist_id}","starred_url":"https://api.github.com/users/sakaiproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakaiproject/subscriptions","organizations_url":"https://api.github.com/users/sakaiproject/orgs","repos_url":"https://api.github.com/users/sakaiproject/repos","events_url":"https://api.github.com/users/sakaiproject/events{/privacy}","received_events_url":"https://api.github.com/users/sakaiproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sakaiproject/sakai","description":"Sakai is a freely available, feature-rich technology solution for learning, teaching, research and collaboration. Sakai is an open source software suite developed by a diverse and global adopter community.","fork":false,"url":"https://api.github.com/repos/sakaiproject/sakai","forks_url":"https://api.github.com/repos/sakaiproject/sakai/forks","keys_url":"https://api.github.com/repos/sakaiproject/sakai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sakaiproject/sakai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sakaiproject/sakai/teams","hooks_url":"https://api.github.com/repos/sakaiproject/sakai/hooks","issue_events_url":"https://api.github.com/repos/sakaiproject/sakai/issues/events{/number}","events_url":"https://api.github.com/repos/sakaiproject/sakai/events","assignees_url":"https://api.github.com/repos/sakaiproject/sakai/assignees{/user}","branches_url":"https://api.github.com/repos/sakaiproject/sakai/branches{/branch}","tags_url":"https://api.github.com/repos/sakaiproject/sakai/tags","blobs_url":"https://api.github.com/repos/sakaiproject/sakai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sakaiproject/sakai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sakaiproject/sakai/git/refs{/sha}","trees_url":"https://api.github.com/repos/sakaiproject/sakai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sakaiproject/sakai/statuses/{sha}","languages_url":"https://api.github.com/repos/sakaiproject/sakai/languages","stargazers_url":"https://api.github.com/repos/sakaiproject/sakai/stargazers","contributors_url":"https://api.github.com/repos/sakaiproject/sakai/contributors","subscribers_url":"https://api.github.com/repos/sakaiproject/sakai/subscribers","subscription_url":"https://api.github.com/repos/sakaiproject/sakai/subscription","commits_url":"https://api.github.com/repos/sakaiproject/sakai/commits{/sha}","git_commits_url":"https://api.github.com/repos/sakaiproject/sakai/git/commits{/sha}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/comments{/number}","issue_comment_url":"https://api.github.com/repos/sakaiproject/sakai/issues/comments{/number}","contents_url":"https://api.github.com/repos/sakaiproject/sakai/contents/{+path}","compare_url":"https://api.github.com/repos/sakaiproject/sakai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sakaiproject/sakai/merges","archive_url":"https://api.github.com/repos/sakaiproject/sakai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sakaiproject/sakai/downloads","issues_url":"https://api.github.com/repos/sakaiproject/sakai/issues{/number}","pulls_url":"https://api.github.com/repos/sakaiproject/sakai/pulls{/number}","milestones_url":"https://api.github.com/repos/sakaiproject/sakai/milestones{/number}","notifications_url":"https://api.github.com/repos/sakaiproject/sakai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sakaiproject/sakai/labels{/name}","releases_url":"https://api.github.com/repos/sakaiproject/sakai/releases{/id}","deployments_url":"https://api.github.com/repos/sakaiproject/sakai/deployments","created_at":"2014-12-29T11:14:17Z","updated_at":"2018-03-27T15:10:44Z","pushed_at":"2018-03-27T15:14:31Z","git_url":"git://github.com/sakaiproject/sakai.git","ssh_url":"git@github.com:sakaiproject/sakai.git","clone_url":"https://github.com/sakaiproject/sakai.git","svn_url":"https://github.com/sakaiproject/sakai","homepage":"https://www.sakaiproject.org","size":358470,"stargazers_count":354,"watchers_count":354,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":501,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"ecl-2.0","name":"Educational Community License v2.0","spdx_id":"ECL-2.0","url":"https://api.github.com/licenses/ecl-2.0"},"forks":501,"open_issues":61,"watchers":354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/5364"},"html":{"href":"https://github.com/sakaiproject/sakai/pull/5364"},"issue":{"href":"https://api.github.com/repos/sakaiproject/sakai/issues/5364"},"comments":{"href":"https://api.github.com/repos/sakaiproject/sakai/issues/5364/comments"},"review_comments":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/5364/comments"},"review_comment":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/5364/commits"},"statuses":{"href":"https://api.github.com/repos/sakaiproject/sakai/statuses/0c52c25a49031eee3720e2f532ef3ce17eee07e5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ern","id":209420,"avatar_url":"https://avatars1.githubusercontent.com/u/209420?v=4","gravatar_id":"","url":"https://api.github.com/users/ern","html_url":"https://github.com/ern","followers_url":"https://api.github.com/users/ern/followers","following_url":"https://api.github.com/users/ern/following{/other_user}","gists_url":"https://api.github.com/users/ern/gists{/gist_id}","starred_url":"https://api.github.com/users/ern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ern/subscriptions","organizations_url":"https://api.github.com/users/ern/orgs","repos_url":"https://api.github.com/users/ern/repos","events_url":"https://api.github.com/users/ern/events{/privacy}","received_events_url":"https://api.github.com/users/ern/received_events","type":"User","site_admin":false},"comments":3,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":19,"changed_files":1}}
{"actor":{"display_login":"ern"}}