{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/236134416","pull_request_review_id":178144552,"id":236134416,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjEzNDQxNg==","diff_hunk":"@@ -1161,10 +1175,12 @@ func (env *azureEnviron) StopInstances(ctx context.ProviderCallContext, ids ...i\n \t\t}\n \t\t// The deployment does not exist, so there's nothing more to do.\n \t\tlogger.Debugf(\"deleting instance %q\", id)\n+\t\tsdkCtx := stdcontext.Background()","path":"provider/azure/environ.go","position":189,"original_position":189,"commit_id":"d95fcb99e6b29ca06e33000aa7bb090abebd3949","original_commit_id":"d95fcb99e6b29ca06e33000aa7bb090abebd3949","user":{"login":"wallyworld","id":5808968,"node_id":"MDQ6VXNlcjU4MDg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/5808968?v=4","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"body":"ditto etc","created_at":"2018-11-26T06:30:15Z","updated_at":"2018-11-26T06:34:09Z","html_url":"https://github.com/juju/juju/pull/9499#discussion_r236134416","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/9499","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/236134416"},"html":{"href":"https://github.com/juju/juju/pull/9499#discussion_r236134416"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/9499"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/9499","id":233414835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDE0ODM1","html_url":"https://github.com/juju/juju/pull/9499","diff_url":"https://github.com/juju/juju/pull/9499.diff","patch_url":"https://github.com/juju/juju/pull/9499.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/9499","number":9499,"state":"open","locked":false,"title":"Azure: Use standard sku Public IP addresses","user":{"login":"Veebers","id":936365,"node_id":"MDQ6VXNlcjkzNjM2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/936365?v=4","gravatar_id":"","url":"https://api.github.com/users/Veebers","html_url":"https://github.com/Veebers","followers_url":"https://api.github.com/users/Veebers/followers","following_url":"https://api.github.com/users/Veebers/following{/other_user}","gists_url":"https://api.github.com/users/Veebers/gists{/gist_id}","starred_url":"https://api.github.com/users/Veebers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Veebers/subscriptions","organizations_url":"https://api.github.com/users/Veebers/orgs","repos_url":"https://api.github.com/users/Veebers/repos","events_url":"https://api.github.com/users/Veebers/events{/privacy}","received_events_url":"https://api.github.com/users/Veebers/received_events","type":"User","site_admin":false},"body":"## Description of change\r\n\r\nAs per the bug below, use the standard sku for any public IP address that is created (this allows the use of the standard load balancer etc.)\r\n\r\nThis branch also updates the azure SKU used to the newest version.\r\n\r\n\r\n## QA steps\r\n\r\nWhen you deploy any machines to an Azure provider, using the Azure we UI inspect the created public IP addresses in the resources viewer and see the SKU states 'standard' (as opposed to 'basic').\r\n\r\n## Documentation changes\r\n n/a\r\n\r\n## Bug reference\r\n\r\nhttps://bugs.launchpad.net/juju/+bug/1799238","created_at":"2018-11-26T01:05:05Z","updated_at":"2018-11-26T06:34:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51e88ba528266140069d55ca47b65c204cd1591f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/9499/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/9499/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/9499/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/d95fcb99e6b29ca06e33000aa7bb090abebd3949","head":{"label":"Veebers:azure-standard-sku","ref":"azure-standard-sku","sha":"d95fcb99e6b29ca06e33000aa7bb090abebd3949","user":{"login":"Veebers","id":936365,"node_id":"MDQ6VXNlcjkzNjM2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/936365?v=4","gravatar_id":"","url":"https://api.github.com/users/Veebers","html_url":"https://github.com/Veebers","followers_url":"https://api.github.com/users/Veebers/followers","following_url":"https://api.github.com/users/Veebers/following{/other_user}","gists_url":"https://api.github.com/users/Veebers/gists{/gist_id}","starred_url":"https://api.github.com/users/Veebers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Veebers/subscriptions","organizations_url":"https://api.github.com/users/Veebers/orgs","repos_url":"https://api.github.com/users/Veebers/repos","events_url":"https://api.github.com/users/Veebers/events{/privacy}","received_events_url":"https://api.github.com/users/Veebers/received_events","type":"User","site_admin":false},"repo":{"id":57357633,"node_id":"MDEwOlJlcG9zaXRvcnk1NzM1NzYzMw==","name":"juju","full_name":"Veebers/juju","private":false,"owner":{"login":"Veebers","id":936365,"node_id":"MDQ6VXNlcjkzNjM2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/936365?v=4","gravatar_id":"","url":"https://api.github.com/users/Veebers","html_url":"https://github.com/Veebers","followers_url":"https://api.github.com/users/Veebers/followers","following_url":"https://api.github.com/users/Veebers/following{/other_user}","gists_url":"https://api.github.com/users/Veebers/gists{/gist_id}","starred_url":"https://api.github.com/users/Veebers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Veebers/subscriptions","organizations_url":"https://api.github.com/users/Veebers/orgs","repos_url":"https://api.github.com/users/Veebers/repos","events_url":"https://api.github.com/users/Veebers/events{/privacy}","received_events_url":"https://api.github.com/users/Veebers/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Veebers/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/Veebers/juju","forks_url":"https://api.github.com/repos/Veebers/juju/forks","keys_url":"https://api.github.com/repos/Veebers/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Veebers/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Veebers/juju/teams","hooks_url":"https://api.github.com/repos/Veebers/juju/hooks","issue_events_url":"https://api.github.com/repos/Veebers/juju/issues/events{/number}","events_url":"https://api.github.com/repos/Veebers/juju/events","assignees_url":"https://api.github.com/repos/Veebers/juju/assignees{/user}","branches_url":"https://api.github.com/repos/Veebers/juju/branches{/branch}","tags_url":"https://api.github.com/repos/Veebers/juju/tags","blobs_url":"https://api.github.com/repos/Veebers/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Veebers/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Veebers/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/Veebers/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Veebers/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/Veebers/juju/languages","stargazers_url":"https://api.github.com/repos/Veebers/juju/stargazers","contributors_url":"https://api.github.com/repos/Veebers/juju/contributors","subscribers_url":"https://api.github.com/repos/Veebers/juju/subscribers","subscription_url":"https://api.github.com/repos/Veebers/juju/subscription","commits_url":"https://api.github.com/repos/Veebers/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/Veebers/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/Veebers/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/Veebers/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/Veebers/juju/contents/{+path}","compare_url":"https://api.github.com/repos/Veebers/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Veebers/juju/merges","archive_url":"https://api.github.com/repos/Veebers/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Veebers/juju/downloads","issues_url":"https://api.github.com/repos/Veebers/juju/issues{/number}","pulls_url":"https://api.github.com/repos/Veebers/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/Veebers/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/Veebers/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Veebers/juju/labels{/name}","releases_url":"https://api.github.com/repos/Veebers/juju/releases{/id}","deployments_url":"https://api.github.com/repos/Veebers/juju/deployments","created_at":"2016-04-29T05:45:44Z","updated_at":"2016-04-29T05:45:53Z","pushed_at":"2018-11-26T06:14:31Z","git_url":"git://github.com/Veebers/juju.git","ssh_url":"git@github.com:Veebers/juju.git","clone_url":"https://github.com/Veebers/juju.git","svn_url":"https://github.com/Veebers/juju","homepage":"juju.ubuntu.com","size":231445,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:2.4","ref":"2.4","sha":"d16ff787c7836399f7fa21c27f36e647ed6109f2","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NTk0Nw==","name":"juju","full_name":"juju/juju","private":false,"owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-11-26T04:02:42Z","pushed_at":"2018-11-26T06:14:33Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":231925,"stargazers_count":1275,"watchers_count":1275,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":295,"open_issues":9,"watchers":1275,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/9499"},"html":{"href":"https://github.com/juju/juju/pull/9499"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/9499"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/9499/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/9499/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/9499/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/d95fcb99e6b29ca06e33000aa7bb090abebd3949"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wallyworld"}}