{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/via/issues/146","repository_url":"https://api.github.com/repos/hypothesis/via","labels_url":"https://api.github.com/repos/hypothesis/via/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/via/issues/146/comments","events_url":"https://api.github.com/repos/hypothesis/via/issues/146/events","html_url":"https://github.com/hypothesis/via/pull/146","id":390633251,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MzUzMzAx","number":146,"title":"Support serving via over SSL","user":{"login":"robertknight","id":2458,"node_id":"MDQ6VXNlcjI0NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2458?v=4","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"labels":[{"id":976837355,"node_id":"MDU6TGFiZWw5NzY4MzczNTU=","url":"https://api.github.com/repos/hypothesis/via/labels/WIP","name":"WIP","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-13T11:21:13Z","updated_at":"2018-12-13T12:07:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hypothesis/via/pulls/146","html_url":"https://github.com/hypothesis/via/pull/146","diff_url":"https://github.com/hypothesis/via/pull/146.diff","patch_url":"https://github.com/hypothesis/via/pull/146.patch"},"body":"In certain testing scenarios it is easier to serve Hypothesis components over SSL rather than bypassing HTTPS checks in the browser. Typically the SSL certificate only has to be registered once with the device's certificate store whereas bypassing HTTPS checks has to be done for each browser and site.\r\n\r\nh and the client already support serving via SSL by putting a copy (or symlink) of the certificate and private key files in a standard location (.tlscert.key and .tlskey.pem) in the root of the project directory.\r\n\r\nThis PR makes the same convention work in Via."},"comment":{"url":"https://api.github.com/repos/hypothesis/via/issues/comments/446946101","html_url":"https://github.com/hypothesis/via/pull/146#issuecomment-446946101","issue_url":"https://api.github.com/repos/hypothesis/via/issues/146","id":446946101,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njk0NjEwMQ==","user":{"login":"robertknight","id":2458,"node_id":"MDQ6VXNlcjI0NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2458?v=4","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T12:07:38Z","updated_at":"2018-12-13T12:07:38Z","author_association":"CONTRIBUTOR","body":"Indeed, looks like uwsgi installed in a freshly created tox env doesn't support HTTPS:\r\n\r\n```sh\r\n# uwsgi installed through pip via tox:\r\n$ .tox/py27-dev/bin/uwsgi --version\r\n2.0.17.1\r\n$ .tox/py27-dev/bin/uwsgi --help | grep https\r\n\r\n# my local build of uwsgi from source:\r\n$ uwsgi --version\r\n2.0.17.1\r\n$ uwsgi --help | grep https\r\n    --https-socket                          bind to the specified UNIX/TCP socket using HTTPS protocol\r\n    --https-socket-modifier1                force the specified modifier1 when using HTTPS protocol\r\n    --https-socket-modifier2                force the specified modifier2 when using HTTPS protocol\r\n    --https                                 add an https router/server on the specified address with specified certificate and key\r\n    --https2                                add an https/spdy router/server using keyval options\r\n    --https-export-cert                     export uwsgi variable HTTPS_CC containing the raw client certificate\r\n    --https-session-context                 set the session id context to the specified value\r\n    --http-to-https                         add an http router/server on the specified address and redirect all of the requests to https\r\n```\r\n\r\nIt looks like it is possible to install UWSGI with SSL support via pip, but the process is non-obvious. See https://stackoverflow.com/a/38842664/434243"}}
{"actor":{"display_login":"robertknight"}}