{"action":"created","issue":{"url":"https://api.github.com/repos/07th-mod/umineko-question/issues/92","repository_url":"https://api.github.com/repos/07th-mod/umineko-question","labels_url":"https://api.github.com/repos/07th-mod/umineko-question/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/07th-mod/umineko-question/issues/92/comments","events_url":"https://api.github.com/repos/07th-mod/umineko-question/issues/92/events","html_url":"https://github.com/07th-mod/umineko-question/issues/92","id":304125097,"number":92,"title":"Voiced and Unvoiced Delay Bugs","user":{"login":"drojf","id":1249449,"avatar_url":"https://avatars1.githubusercontent.com/u/1249449?v=4","gravatar_id":"","url":"https://api.github.com/users/drojf","html_url":"https://github.com/drojf","followers_url":"https://api.github.com/users/drojf/followers","following_url":"https://api.github.com/users/drojf/following{/other_user}","gists_url":"https://api.github.com/users/drojf/gists{/gist_id}","starred_url":"https://api.github.com/users/drojf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drojf/subscriptions","organizations_url":"https://api.github.com/users/drojf/orgs","repos_url":"https://api.github.com/users/drojf/repos","events_url":"https://api.github.com/users/drojf/events{/privacy}","received_events_url":"https://api.github.com/users/drojf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-11T02:47:54Z","updated_at":"2018-04-23T10:16:51Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"the scene immediately following this line has the !s0 problem (text doesn't appear until line is finished)\r\n\r\n`She took it, ......and after hesitating, opened it...and read what was inside`\r\n\r\n```\r\nlangjp^^!s0　そして、真に謝るのは自分の方であることを自覚し、/\r\nlangjp^^!d800…/\r\nlangjp^^!d500…/\r\nlangjp^^!d500…/\r\nlangjp^^!d500…/\r\nlangjp^^!d500謝罪した。/\r\nlangen^^!s0^\u0010Then, realizing that she was the one who should be apologizing, ^/\r\nlangen:delay 1600^\u0010...^/\r\nlangen:delay 1000^\u0010...^/\r\nlangen:delay 1000^\u0010...^/\r\nlangen:delay 1000^\u0010...^/\r\nlangen:delay 1000^\u0010she apologized.^/\r\n```\r\n\r\nOn chiru, the bug only affected voice lines? but maybe that was just a coincidence and there was something else breaking the automatically displaying text lines.\r\n\r\nAlso, the delays haven't been adjusted? They seem too short most of the time.\r\n\r\nEdit: somehow changing the 'delay [delaytime]' commands to '!d[delaytime]` makes it show up correctly (as per japanese mode):\r\n```\r\nlangen^^!s0^Then, after letting two large tears...^/\r\nlangen!d1600^drip down the paper, ^@/\r\nlangen^...she flew out of the room, ^/\r\nlangen!d1600^hugged Maria from behind as she headed for the bathroom, ^@/\r\nlangen^......buried her face into her daughter's back...^/\r\nlangen!d3000^and cried.^/\r\nlangjp!sd\\\r\nlangen!sd\\\r\n```\r\n\r\nAlso, why are all the delay values multiplied by 2 as compared to the japanese lines? Will have to check the git logs to see if someone just doubled all t he delays in the entire script.\r\n\r\n----\r\n\r\nI think the following steps are required:\r\n\r\n- change all the `delay X` to `!d`. This fixes the strange 'delay before line is shown' bug.  (Sometimes the `delay X` used to be `!w` which has slightly different behavior - `!w` is a forced wait which stops you from clicking through. But fixing that can be done later)\r\n\r\n- divide the delay amount by 2. I think the 2x delay was added in this commit: 0625660 (\"Fixing issue with delay lines part 2\", 2016-07-18) . However, it was applied globally, even to lines which had no voices on them.\r\n\r\n- for lines with voices only, scale the delay by the amount necessary + 100ms buffer. Also, test that the delay seems the correct amount.\r\n"},"comment":{"url":"https://api.github.com/repos/07th-mod/umineko-question/issues/comments/383526118","html_url":"https://github.com/07th-mod/umineko-question/issues/92#issuecomment-383526118","issue_url":"https://api.github.com/repos/07th-mod/umineko-question/issues/92","id":383526118,"user":{"login":"drojf","id":1249449,"avatar_url":"https://avatars1.githubusercontent.com/u/1249449?v=4","gravatar_id":"","url":"https://api.github.com/users/drojf","html_url":"https://github.com/drojf","followers_url":"https://api.github.com/users/drojf/followers","following_url":"https://api.github.com/users/drojf/following{/other_user}","gists_url":"https://api.github.com/users/drojf/gists{/gist_id}","starred_url":"https://api.github.com/users/drojf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drojf/subscriptions","organizations_url":"https://api.github.com/users/drojf/orgs","repos_url":"https://api.github.com/users/drojf/repos","events_url":"https://api.github.com/users/drojf/events{/privacy}","received_events_url":"https://api.github.com/users/drojf/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T10:16:51Z","updated_at":"2018-04-23T10:16:51Z","author_association":"CONTRIBUTOR","body":"While I was fixing this issue, I found some voice files present in the script (but not necessarily **used** in the script) which don't exist on disk:\r\n\r\n```\r\n35 Missing voice files:\r\nvoice\\16\\10600020.ogg\r\nvoice\\12\\20100250_1.ogg\r\nvoice\\27\\20701429.ogg\r\nvoice\\10\\20101212.ogg\r\nvoice\\10\\20101219.ogg\r\nvoice\\10\\20101220.ogg\r\nvoice\\10\\20101265.ogg\r\nvoice\\01\\31500075.ogg\r\nvoice\\01\\31500079.ogg\r\nvoice\\01\\31500080.ogg\r\nvoice\\01\\31500093.ogg\r\nvoice\\10\\30100414.ogg\r\nvoice\\10\\30100657.ogg\r\nvoice\\03\\30900096.ogg\r\nvoice\\10\\30101271.ogg\r\nvoice\\10\\30101469.ogg\r\nvoice\\10\\30101613.ogg\r\nvoice\\11\\32000001.ogg\r\nvoice\\11\\42000026.ogg\r\nvoice\\11\\42000045.ogg\r\nvoice\\11\\42000117.ogg\r\nvoice\\11\\42000277.ogg\r\nvoice\\11\\42000951.ogg\r\nvoice\\11\\42000972.ogg\r\nvoice\\11\\42001053.ogg\r\nvoice\\13\\40401069.ogg\r\nvoice\\11\\42001401.ogg\r\nvoice\\11\\42001463.ogg\r\nvoice\\10\\40100727.ogg\r\nvoice\\10\\40100821.ogg\r\nvoice\\11\\42001671.ogg\r\nvoice\\11\\42001693.ogg\r\nvoice\\11\\42001698.ogg\r\nvoice\\11\\42001746.ogg\r\nvoice\\10\\90100412.ogg\r\n```\r\n\r\nIf anyone wants to go through these and check whether they're actually used or not, be my guest (but leave a comment here if you decide to do it)\r\n"}}
{"actor":{"display_login":"drojf"}}