{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/51463","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/51463/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/51463/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/51463/events","html_url":"https://github.com/rust-lang/rust/pull/51463","id":330926188,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODAwNjA0","number":51463,"title":"Various changes to existing diagnostics","user":{"login":"estebank","id":1606434,"node_id":"MDQ6VXNlcjE2MDY0MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1606434?v=4","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false},"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"state":"open","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-06-09T23:19:44Z","updated_at":"2018-06-18T09:23:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/51463","html_url":"https://github.com/rust-lang/rust/pull/51463","diff_url":"https://github.com/rust-lang/rust/pull/51463.diff","patch_url":"https://github.com/rust-lang/rust/pull/51463.patch"},"body":"* [Add code to `invalid ABI` error, add span label, move list to help to make message shorter](https://github.com/rust-lang/rust/pull/51463/commits/23ae5af274defa9ff884f593e44a2bbcaf814a02):\r\n```\r\nerror[E0697]: invalid ABI: found `路濫狼á́́`\r\n  --> $DIR/unicode.rs:11:8\r\n   |\r\nLL | extern \"路濫狼á́́\" fn foo() {} //~ ERROR invalid ABI\r\n   |        ^^^^^^^^^ invalid ABI\r\n   |\r\n   = help: valid ABIs: cdecl, stdcall, fastcall, vectorcall, thiscall, aapcs, win64, sysv64, ptx-kernel, msp430-interrupt, x86-interrupt, Rust, C, system, rust-intrinsic, rust-call, platform-intrinsic, unadjusted\r\n``` \r\n* [Add code to incorrect `pub` restriction error](https://github.com/rust-lang/rust/pull/51463/commits/e96fdea8a38f39f99f8b9a4000a689187a457e08)\r\n* [Add message to `rustc_on_unimplemented` attributes in core to have them set a custom message _and_ label](https://github.com/rust-lang/rust/pull/51463/commits/2cc7e5ed307aee936c20479cfdc7409d6b52a464):\r\n```\r\nerror[E0277]: `W` does not have a constant size known at compile-time\r\n  --> $DIR/unsized-enum2.rs:33:8\r\n   |\r\nLL |     VA(W),\r\n   |        ^ `W` does not have a constant size known at compile-time\r\n   |\r\n   = help: the trait `std::marker::Sized` is not implemented for `W`\r\n   = help: consider adding a `where W: std::marker::Sized` bound\r\n   = note: no field of an enum variant may have a dynamically sized type\r\n```\r\n```\r\nerror[E0277]: `Foo` cannot be sent between threads safely\r\n  --> $DIR/E0277-2.rs:26:5\r\n   |\r\nLL |     is_send::<Foo>();\r\n   |     ^^^^^^^^^^^^^^ `Foo` cannot be sent between threads safely\r\n   |\r\n   = help: the trait `std::marker::Send` is not implemented for `Foo`\r\n```\r\n```\r\nerror[E0277]: can't compare `{integer}` with `std::string::String`\r\n  --> $DIR/binops.rs:16:7\r\n   |\r\nLL |     5 < String::new();\r\n   |       ^ no implementation for `{integer} < std::string::String` and `{integer} > std::string::String`\r\n   |\r\n   = help: the trait `std::cmp::PartialOrd<std::string::String>` is not implemented for `{integer}`\r\n```\r\n```\r\nerror[E0277]: can't compare `{integer}` with `std::result::Result<{integer}, _>`\r\n  --> $DIR/binops.rs:17:7\r\n   |\r\nLL |     6 == Ok(1);\r\n   |       ^^ no implementation for `{integer} == std::result::Result<{integer}, _>`\r\n   |\r\n   = help: the trait `std::cmp::PartialEq<std::result::Result<{integer}, _>>` is not implemented for `{integer}`\r\n```\r\n```\r\nerror[E0277]: a collection of type `i32` cannot be built from an iterator over elements of type `i32`\r\n  --> $DIR/type-check-defaults.rs:16:19\r\n   |\r\nLL | struct WellFormed<Z = Foo<i32, i32>>(Z);\r\n   |                   ^ a collection of type `i32` cannot be built from `std::iter::Iterator<Item=i32>`\r\n   |\r\n   = help: the trait `std::iter::FromIterator<i32>` is not implemented for `i32`\r\nnote: required by `Foo`\r\n  --> $DIR/type-check-defaults.rs:15:1\r\n   |\r\nLL | struct Foo<T, U: FromIterator<T>>(T, U);\r\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n```\r\n* [Add link to book for `Sized` errors](https://github.com/rust-lang/rust/pull/51463/commits/1244dc7c283323aea1a3457a4458d590a3e160c8):\r\n```\r\nerror[E0277]: `std::fmt::Debug + std::marker::Sync + 'static` does not have a constant size known at compile-time\r\n  --> $DIR/const-unsized.rs:13:29\r\n   |\r\nLL | const CONST_0: Debug+Sync = *(&0 as &(Debug+Sync));\r\n   |                             ^^^^^^^^^^^^^^^^^^^^^^ `std::fmt::Debug + std::marker::Sync + 'static` does not have a constant size known at compile-time\r\n   |\r\n   = help: the trait `std::marker::Sized` is not implemented for `std::fmt::Debug + std::marker::Sync + 'static`\r\n   = note: to learn more, visit <https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types--sized>\r\n   = note: constant expressions must have a statically known size\r\n```\r\n* [Point to previous line for single expected token not found](https://github.com/rust-lang/rust/pull/51463/commits/48165168fb0f059d8536cd4a2276b609d4a7f721) (if the current token is in a different line)"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/397994354","html_url":"https://github.com/rust-lang/rust/pull/51463#issuecomment-397994354","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/51463","id":397994354,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzk5NDM1NA==","user":{"login":"pietroalbini","id":2299951,"node_id":"MDQ6VXNlcjIyOTk5NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2299951?v=4","gravatar_id":"","url":"https://api.github.com/users/pietroalbini","html_url":"https://github.com/pietroalbini","followers_url":"https://api.github.com/users/pietroalbini/followers","following_url":"https://api.github.com/users/pietroalbini/following{/other_user}","gists_url":"https://api.github.com/users/pietroalbini/gists{/gist_id}","starred_url":"https://api.github.com/users/pietroalbini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietroalbini/subscriptions","organizations_url":"https://api.github.com/users/pietroalbini/orgs","repos_url":"https://api.github.com/users/pietroalbini/repos","events_url":"https://api.github.com/users/pietroalbini/events{/privacy}","received_events_url":"https://api.github.com/users/pietroalbini/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T09:23:59Z","updated_at":"2018-06-18T09:23:59Z","author_association":"MEMBER","body":"Ping from triage @nikomatsakis! This PR needs your review."}}
{"actor":{"display_login":"pietroalbini"}}