{"action":"closed","number":366,"pull_request":{"url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/366","id":218161548,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTYxNTQ4","html_url":"https://github.com/awslabs/cfn-python-lint/pull/366","diff_url":"https://github.com/awslabs/cfn-python-lint/pull/366.diff","patch_url":"https://github.com/awslabs/cfn-python-lint/pull/366.patch","issue_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/366","number":366,"state":"closed","locked":false,"title":"Fixed E2521 to check against other properties instead of values","user":{"login":"cmmeyer","id":5632125,"node_id":"MDQ6VXNlcjU2MzIxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5632125?v=4","gravatar_id":"","url":"https://api.github.com/users/cmmeyer","html_url":"https://github.com/cmmeyer","followers_url":"https://api.github.com/users/cmmeyer/followers","following_url":"https://api.github.com/users/cmmeyer/following{/other_user}","gists_url":"https://api.github.com/users/cmmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/cmmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmmeyer/subscriptions","organizations_url":"https://api.github.com/users/cmmeyer/orgs","repos_url":"https://api.github.com/users/cmmeyer/repos","events_url":"https://api.github.com/users/cmmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/cmmeyer/received_events","type":"User","site_admin":false},"body":"*Issue #, if available:*\r\n#364 \r\n\r\n*Description of changes:*\r\n\r\nE2521 (inclusive properties) was checking required properties against values instead of other properties in resource, causing false positives.\r\n\r\nBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.\r\n","created_at":"2018-09-26T01:06:00Z","updated_at":"2018-09-27T15:02:44Z","closed_at":"2018-09-27T15:02:44Z","merged_at":"2018-09-27T15:02:44Z","merge_commit_sha":"9a24d2511624e07e09709f5f018a2b778a18125c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/366/commits","review_comments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/366/comments","review_comment_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/366/comments","statuses_url":"https://api.github.com/repos/awslabs/cfn-python-lint/statuses/753fbcc44ceceb52426676ceb2c03399aeefcc59","head":{"label":"cmmeyer:cmmeyer-Fix/E2521","ref":"cmmeyer-Fix/E2521","sha":"753fbcc44ceceb52426676ceb2c03399aeefcc59","user":{"login":"cmmeyer","id":5632125,"node_id":"MDQ6VXNlcjU2MzIxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5632125?v=4","gravatar_id":"","url":"https://api.github.com/users/cmmeyer","html_url":"https://github.com/cmmeyer","followers_url":"https://api.github.com/users/cmmeyer/followers","following_url":"https://api.github.com/users/cmmeyer/following{/other_user}","gists_url":"https://api.github.com/users/cmmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/cmmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmmeyer/subscriptions","organizations_url":"https://api.github.com/users/cmmeyer/orgs","repos_url":"https://api.github.com/users/cmmeyer/repos","events_url":"https://api.github.com/users/cmmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/cmmeyer/received_events","type":"User","site_admin":false},"repo":{"id":137382532,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczODI1MzI=","name":"cfn-python-lint","full_name":"cmmeyer/cfn-python-lint","private":false,"owner":{"login":"cmmeyer","id":5632125,"node_id":"MDQ6VXNlcjU2MzIxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5632125?v=4","gravatar_id":"","url":"https://api.github.com/users/cmmeyer","html_url":"https://github.com/cmmeyer","followers_url":"https://api.github.com/users/cmmeyer/followers","following_url":"https://api.github.com/users/cmmeyer/following{/other_user}","gists_url":"https://api.github.com/users/cmmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/cmmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmmeyer/subscriptions","organizations_url":"https://api.github.com/users/cmmeyer/orgs","repos_url":"https://api.github.com/users/cmmeyer/repos","events_url":"https://api.github.com/users/cmmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/cmmeyer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cmmeyer/cfn-python-lint","description":"CloudFormation Linter","fork":true,"url":"https://api.github.com/repos/cmmeyer/cfn-python-lint","forks_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/forks","keys_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/teams","hooks_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/hooks","issue_events_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/issues/events{/number}","events_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/events","assignees_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/assignees{/user}","branches_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/branches{/branch}","tags_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/tags","blobs_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/languages","stargazers_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/stargazers","contributors_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/contributors","subscribers_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/subscribers","subscription_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/subscription","commits_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/contents/{+path}","compare_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/merges","archive_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/downloads","issues_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/issues{/number}","pulls_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/labels{/name}","releases_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/releases{/id}","deployments_url":"https://api.github.com/repos/cmmeyer/cfn-python-lint/deployments","created_at":"2018-06-14T16:24:33Z","updated_at":"2018-09-26T16:43:38Z","pushed_at":"2018-09-27T12:45:54Z","git_url":"git://github.com/cmmeyer/cfn-python-lint.git","ssh_url":"git@github.com:cmmeyer/cfn-python-lint.git","clone_url":"https://github.com/cmmeyer/cfn-python-lint.git","svn_url":"https://github.com/cmmeyer/cfn-python-lint","homepage":null,"size":1481,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"f2baadfb98e250ded4f1561b0b64a2602e5825e2","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":129005655,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkwMDU2NTU=","name":"cfn-python-lint","full_name":"awslabs/cfn-python-lint","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/cfn-python-lint","description":"CloudFormation Linter","fork":false,"url":"https://api.github.com/repos/awslabs/cfn-python-lint","forks_url":"https://api.github.com/repos/awslabs/cfn-python-lint/forks","keys_url":"https://api.github.com/repos/awslabs/cfn-python-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/cfn-python-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/cfn-python-lint/teams","hooks_url":"https://api.github.com/repos/awslabs/cfn-python-lint/hooks","issue_events_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/cfn-python-lint/events","assignees_url":"https://api.github.com/repos/awslabs/cfn-python-lint/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/cfn-python-lint/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/cfn-python-lint/tags","blobs_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/cfn-python-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/cfn-python-lint/languages","stargazers_url":"https://api.github.com/repos/awslabs/cfn-python-lint/stargazers","contributors_url":"https://api.github.com/repos/awslabs/cfn-python-lint/contributors","subscribers_url":"https://api.github.com/repos/awslabs/cfn-python-lint/subscribers","subscription_url":"https://api.github.com/repos/awslabs/cfn-python-lint/subscription","commits_url":"https://api.github.com/repos/awslabs/cfn-python-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/cfn-python-lint/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/cfn-python-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/cfn-python-lint/merges","archive_url":"https://api.github.com/repos/awslabs/cfn-python-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/cfn-python-lint/downloads","issues_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/cfn-python-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/cfn-python-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/cfn-python-lint/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/cfn-python-lint/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/deployments","created_at":"2018-04-10T23:16:16Z","updated_at":"2018-09-27T08:35:59Z","pushed_at":"2018-09-27T15:02:44Z","git_url":"git://github.com/awslabs/cfn-python-lint.git","ssh_url":"git@github.com:awslabs/cfn-python-lint.git","clone_url":"https://github.com/awslabs/cfn-python-lint.git","svn_url":"https://github.com/awslabs/cfn-python-lint","homepage":null,"size":1479,"stargazers_count":232,"watchers_count":232,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":48,"open_issues":44,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/366"},"html":{"href":"https://github.com/awslabs/cfn-python-lint/pull/366"},"issue":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/366"},"comments":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/statuses/753fbcc44ceceb52426676ceb2c03399aeefcc59"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kddejong","id":36457093,"node_id":"MDQ6VXNlcjM2NDU3MDkz","avatar_url":"https://avatars3.githubusercontent.com/u/36457093?v=4","gravatar_id":"","url":"https://api.github.com/users/kddejong","html_url":"https://github.com/kddejong","followers_url":"https://api.github.com/users/kddejong/followers","following_url":"https://api.github.com/users/kddejong/following{/other_user}","gists_url":"https://api.github.com/users/kddejong/gists{/gist_id}","starred_url":"https://api.github.com/users/kddejong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kddejong/subscriptions","organizations_url":"https://api.github.com/users/kddejong/orgs","repos_url":"https://api.github.com/users/kddejong/repos","events_url":"https://api.github.com/users/kddejong/events{/privacy}","received_events_url":"https://api.github.com/users/kddejong/received_events","type":"User","site_admin":false},"comments":1,"review_comments":6,"maintainer_can_modify":false,"commits":6,"additions":40,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"kddejong"}}