{"action":"closed","number":1087,"pull_request":{"url":"https://api.github.com/repos/mozilla/pontoon/pulls/1087","id":217351714,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzUxNzE0","html_url":"https://github.com/mozilla/pontoon/pull/1087","diff_url":"https://github.com/mozilla/pontoon/pull/1087.diff","patch_url":"https://github.com/mozilla/pontoon/pull/1087.patch","issue_url":"https://api.github.com/repos/mozilla/pontoon/issues/1087","number":1087,"state":"closed","locked":false,"title":"Fix bug 1491027 - Filter on project when searching for tags.","user":{"login":"adngdb","id":328790,"node_id":"MDQ6VXNlcjMyODc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/328790?v=4","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false},"body":"The lack of filtering on projects means that before this patch, finding the tag that was being concerned only took the slug into consideration. Thus, if two tags, under different projects, used the same slug, one of them would show up for all projects, leading to an incorrect listing of resources, and impossibility to manage that tag.\r\n\r\nNote that I didn't add a test case for this, because of the amount of energy it took me to just find the one line where the fix was needed. I might reconsider next week, but by that time my understanding of this code might have faded away (I hope) so it's also possible that I'll never add that test case.","created_at":"2018-09-21T17:31:08Z","updated_at":"2018-09-24T07:55:56Z","closed_at":"2018-09-24T07:55:56Z","merged_at":"2018-09-24T07:55:56Z","merge_commit_sha":"1b6e3b40bfef7f1eb63430c7abac6c26c6ece092","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pontoon/pulls/1087/commits","review_comments_url":"https://api.github.com/repos/mozilla/pontoon/pulls/1087/comments","review_comment_url":"https://api.github.com/repos/mozilla/pontoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pontoon/issues/1087/comments","statuses_url":"https://api.github.com/repos/mozilla/pontoon/statuses/9298cd52363882cf29bb5d2d882a99c5234408e9","head":{"label":"adngdb:1491027-tag-wrong-resources","ref":"1491027-tag-wrong-resources","sha":"9298cd52363882cf29bb5d2d882a99c5234408e9","user":{"login":"adngdb","id":328790,"node_id":"MDQ6VXNlcjMyODc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/328790?v=4","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false},"repo":{"id":95442996,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQ0Mjk5Ng==","name":"pontoon","full_name":"adngdb/pontoon","private":false,"owner":{"login":"adngdb","id":328790,"node_id":"MDQ6VXNlcjMyODc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/328790?v=4","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adngdb/pontoon","description":"In-place localization tool","fork":true,"url":"https://api.github.com/repos/adngdb/pontoon","forks_url":"https://api.github.com/repos/adngdb/pontoon/forks","keys_url":"https://api.github.com/repos/adngdb/pontoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adngdb/pontoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adngdb/pontoon/teams","hooks_url":"https://api.github.com/repos/adngdb/pontoon/hooks","issue_events_url":"https://api.github.com/repos/adngdb/pontoon/issues/events{/number}","events_url":"https://api.github.com/repos/adngdb/pontoon/events","assignees_url":"https://api.github.com/repos/adngdb/pontoon/assignees{/user}","branches_url":"https://api.github.com/repos/adngdb/pontoon/branches{/branch}","tags_url":"https://api.github.com/repos/adngdb/pontoon/tags","blobs_url":"https://api.github.com/repos/adngdb/pontoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adngdb/pontoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adngdb/pontoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/adngdb/pontoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adngdb/pontoon/statuses/{sha}","languages_url":"https://api.github.com/repos/adngdb/pontoon/languages","stargazers_url":"https://api.github.com/repos/adngdb/pontoon/stargazers","contributors_url":"https://api.github.com/repos/adngdb/pontoon/contributors","subscribers_url":"https://api.github.com/repos/adngdb/pontoon/subscribers","subscription_url":"https://api.github.com/repos/adngdb/pontoon/subscription","commits_url":"https://api.github.com/repos/adngdb/pontoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/adngdb/pontoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/adngdb/pontoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/adngdb/pontoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/adngdb/pontoon/contents/{+path}","compare_url":"https://api.github.com/repos/adngdb/pontoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adngdb/pontoon/merges","archive_url":"https://api.github.com/repos/adngdb/pontoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adngdb/pontoon/downloads","issues_url":"https://api.github.com/repos/adngdb/pontoon/issues{/number}","pulls_url":"https://api.github.com/repos/adngdb/pontoon/pulls{/number}","milestones_url":"https://api.github.com/repos/adngdb/pontoon/milestones{/number}","notifications_url":"https://api.github.com/repos/adngdb/pontoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adngdb/pontoon/labels{/name}","releases_url":"https://api.github.com/repos/adngdb/pontoon/releases{/id}","deployments_url":"https://api.github.com/repos/adngdb/pontoon/deployments","created_at":"2017-06-26T12:14:01Z","updated_at":"2018-09-20T13:22:14Z","pushed_at":"2018-09-21T17:28:54Z","git_url":"git://github.com/adngdb/pontoon.git","ssh_url":"git@github.com:adngdb/pontoon.git","clone_url":"https://github.com/adngdb/pontoon.git","svn_url":"https://github.com/adngdb/pontoon","homepage":"https://pontoon.mozilla.org/","size":25673,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"ebd342922d04df2dfbbce23ac5a15ee1e71d50fe","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1385890,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1ODkw","name":"pontoon","full_name":"mozilla/pontoon","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/pontoon","description":"Mozilla's Localization Platform","fork":false,"url":"https://api.github.com/repos/mozilla/pontoon","forks_url":"https://api.github.com/repos/mozilla/pontoon/forks","keys_url":"https://api.github.com/repos/mozilla/pontoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pontoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pontoon/teams","hooks_url":"https://api.github.com/repos/mozilla/pontoon/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pontoon/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pontoon/events","assignees_url":"https://api.github.com/repos/mozilla/pontoon/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pontoon/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pontoon/tags","blobs_url":"https://api.github.com/repos/mozilla/pontoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pontoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pontoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pontoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pontoon/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pontoon/languages","stargazers_url":"https://api.github.com/repos/mozilla/pontoon/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pontoon/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pontoon/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pontoon/subscription","commits_url":"https://api.github.com/repos/mozilla/pontoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pontoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pontoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pontoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pontoon/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pontoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pontoon/merges","archive_url":"https://api.github.com/repos/mozilla/pontoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pontoon/downloads","issues_url":"https://api.github.com/repos/mozilla/pontoon/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pontoon/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pontoon/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pontoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pontoon/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pontoon/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/pontoon/deployments","created_at":"2011-02-19T11:25:51Z","updated_at":"2018-09-22T14:11:34Z","pushed_at":"2018-09-24T07:55:56Z","git_url":"git://github.com/mozilla/pontoon.git","ssh_url":"git@github.com:mozilla/pontoon.git","clone_url":"https://github.com/mozilla/pontoon.git","svn_url":"https://github.com/mozilla/pontoon","homepage":"https://pontoon.mozilla.org/","size":25506,"stargazers_count":446,"watchers_count":446,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":139,"open_issues":2,"watchers":446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/1087"},"html":{"href":"https://github.com/mozilla/pontoon/pull/1087"},"issue":{"href":"https://api.github.com/repos/mozilla/pontoon/issues/1087"},"comments":{"href":"https://api.github.com/repos/mozilla/pontoon/issues/1087/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/1087/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/1087/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pontoon/statuses/9298cd52363882cf29bb5d2d882a99c5234408e9"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"adngdb","id":328790,"node_id":"MDQ6VXNlcjMyODc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/328790?v=4","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"adngdb"}}