{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/console/pulls/comments/195225908","pull_request_review_id":128552381,"id":195225908,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTIyNTkwOA==","diff_hunk":"@@ -3,16 +3,37 @@ import * as React from 'react';\n \n import { Dropdown, ResourceLog, ResourceName } from './utils';\n \n-// Component to container dropdown or conatiner name if only one container in pod.\n-const ContainerDropdown = ({currentContainer, containers, kind, onChange}) => {\n-  const resourceName = (container) => {\n-    return <ResourceName name={container.name} kind={kind} />;\n+const reduceContainerStatuses = (accumulator, container, order) => {\n+  return {\n+    ...accumulator,\n+    [container.name]: { ...container, order }\n   };\n-  const dropdownItems = _.mapValues(containers, resourceName);\n+};\n+\n+const containerLabel = (container) => {\n+  return <ResourceName name={container.name} kind=\"Container\" />;\n+};\n+\n+const ContainerDropdown = ({currentKey, containers, initContainers = {}, onChange}) => {\n+  let spacerBefore = new Set();\n+  let headerBefore = {};\n+  if (!_.isEmpty(initContainers)) {","path":"frontend/public/components/pod-logs.jsx","position":23,"original_position":23,"commit_id":"231b85201d2edb99a9a7e7f5de60a9f753f52f3d","original_commit_id":"231b85201d2edb99a9a7e7f5de60a9f753f52f3d","user":{"login":"benjaminapetersen","id":280512,"node_id":"MDQ6VXNlcjI4MDUxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"I don't have a problem with the fact that they would not be reused (still local to the file, not exported)... but that does seem heavy-handed, might not be a great refactor.","created_at":"2018-06-13T20:32:28Z","updated_at":"2018-06-13T20:32:29Z","html_url":"https://github.com/openshift/console/pull/127#discussion_r195225908","pull_request_url":"https://api.github.com/repos/openshift/console/pulls/127","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/comments/195225908"},"html":{"href":"https://github.com/openshift/console/pull/127#discussion_r195225908"},"pull_request":{"href":"https://api.github.com/repos/openshift/console/pulls/127"}},"in_reply_to_id":195211866},"pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/127","id":194682525,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjgyNTI1","html_url":"https://github.com/openshift/console/pull/127","diff_url":"https://github.com/openshift/console/pull/127.diff","patch_url":"https://github.com/openshift/console/pull/127.patch","issue_url":"https://api.github.com/repos/openshift/console/issues/127","number":127,"state":"open","locked":false,"title":"Add separator and header to pod logs with init containers.","user":{"login":"TheRealJon","id":22625502,"node_id":"MDQ6VXNlcjIyNjI1NTAy","avatar_url":"https://avatars0.githubusercontent.com/u/22625502?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealJon","html_url":"https://github.com/TheRealJon","followers_url":"https://api.github.com/users/TheRealJon/followers","following_url":"https://api.github.com/users/TheRealJon/following{/other_user}","gists_url":"https://api.github.com/users/TheRealJon/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealJon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealJon/subscriptions","organizations_url":"https://api.github.com/users/TheRealJon/orgs","repos_url":"https://api.github.com/users/TheRealJon/repos","events_url":"https://api.github.com/users/TheRealJon/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealJon/received_events","type":"User","site_admin":false},"body":"Add separator and header to pod logs container dropdown if the pod has init containers.\r\n\r\n![screenshot-localhost-9000-2018 06 13-15-08-18](https://user-images.githubusercontent.com/22625502/41372604-cc19a35c-6f1b-11e8-89fa-5d3c8dd38dcf.png)\r\n\r\n\r\n@openshift/team-ux-review ","created_at":"2018-06-13T18:54:38Z","updated_at":"2018-06-13T20:32:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb3a9d46703b874796747aa06c4e4349d66df8ed","assignee":null,"assignees":[],"requested_reviewers":[{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},{"login":"serenamarie125","id":12504403,"node_id":"MDQ6VXNlcjEyNTA0NDAz","avatar_url":"https://avatars3.githubusercontent.com/u/12504403?v=4","gravatar_id":"","url":"https://api.github.com/users/serenamarie125","html_url":"https://github.com/serenamarie125","followers_url":"https://api.github.com/users/serenamarie125/followers","following_url":"https://api.github.com/users/serenamarie125/following{/other_user}","gists_url":"https://api.github.com/users/serenamarie125/gists{/gist_id}","starred_url":"https://api.github.com/users/serenamarie125/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serenamarie125/subscriptions","organizations_url":"https://api.github.com/users/serenamarie125/orgs","repos_url":"https://api.github.com/users/serenamarie125/repos","events_url":"https://api.github.com/users/serenamarie125/events{/privacy}","received_events_url":"https://api.github.com/users/serenamarie125/received_events","type":"User","site_admin":false},{"login":"beanh66","id":18057044,"node_id":"MDQ6VXNlcjE4MDU3MDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/18057044?v=4","gravatar_id":"","url":"https://api.github.com/users/beanh66","html_url":"https://github.com/beanh66","followers_url":"https://api.github.com/users/beanh66/followers","following_url":"https://api.github.com/users/beanh66/following{/other_user}","gists_url":"https://api.github.com/users/beanh66/gists{/gist_id}","starred_url":"https://api.github.com/users/beanh66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beanh66/subscriptions","organizations_url":"https://api.github.com/users/beanh66/orgs","repos_url":"https://api.github.com/users/beanh66/repos","events_url":"https://api.github.com/users/beanh66/events{/privacy}","received_events_url":"https://api.github.com/users/beanh66/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":926923478,"node_id":"MDU6TGFiZWw5MjY5MjM0Nzg=","url":"https://api.github.com/repos/openshift/console/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/console/pulls/127/commits","review_comments_url":"https://api.github.com/repos/openshift/console/pulls/127/comments","review_comment_url":"https://api.github.com/repos/openshift/console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/console/issues/127/comments","statuses_url":"https://api.github.com/repos/openshift/console/statuses/231b85201d2edb99a9a7e7f5de60a9f753f52f3d","head":{"label":"TheRealJon:pod-log-dropdown-sep","ref":"pod-log-dropdown-sep","sha":"231b85201d2edb99a9a7e7f5de60a9f753f52f3d","user":{"login":"TheRealJon","id":22625502,"node_id":"MDQ6VXNlcjIyNjI1NTAy","avatar_url":"https://avatars0.githubusercontent.com/u/22625502?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealJon","html_url":"https://github.com/TheRealJon","followers_url":"https://api.github.com/users/TheRealJon/followers","following_url":"https://api.github.com/users/TheRealJon/following{/other_user}","gists_url":"https://api.github.com/users/TheRealJon/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealJon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealJon/subscriptions","organizations_url":"https://api.github.com/users/TheRealJon/orgs","repos_url":"https://api.github.com/users/TheRealJon/repos","events_url":"https://api.github.com/users/TheRealJon/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealJon/received_events","type":"User","site_admin":false},"repo":{"id":133359680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzNTk2ODA=","name":"console","full_name":"TheRealJon/console","owner":{"login":"TheRealJon","id":22625502,"node_id":"MDQ6VXNlcjIyNjI1NTAy","avatar_url":"https://avatars0.githubusercontent.com/u/22625502?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealJon","html_url":"https://github.com/TheRealJon","followers_url":"https://api.github.com/users/TheRealJon/followers","following_url":"https://api.github.com/users/TheRealJon/following{/other_user}","gists_url":"https://api.github.com/users/TheRealJon/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealJon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealJon/subscriptions","organizations_url":"https://api.github.com/users/TheRealJon/orgs","repos_url":"https://api.github.com/users/TheRealJon/repos","events_url":"https://api.github.com/users/TheRealJon/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealJon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheRealJon/console","description":"Tectonic Console UI","fork":true,"url":"https://api.github.com/repos/TheRealJon/console","forks_url":"https://api.github.com/repos/TheRealJon/console/forks","keys_url":"https://api.github.com/repos/TheRealJon/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheRealJon/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheRealJon/console/teams","hooks_url":"https://api.github.com/repos/TheRealJon/console/hooks","issue_events_url":"https://api.github.com/repos/TheRealJon/console/issues/events{/number}","events_url":"https://api.github.com/repos/TheRealJon/console/events","assignees_url":"https://api.github.com/repos/TheRealJon/console/assignees{/user}","branches_url":"https://api.github.com/repos/TheRealJon/console/branches{/branch}","tags_url":"https://api.github.com/repos/TheRealJon/console/tags","blobs_url":"https://api.github.com/repos/TheRealJon/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheRealJon/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheRealJon/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheRealJon/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheRealJon/console/statuses/{sha}","languages_url":"https://api.github.com/repos/TheRealJon/console/languages","stargazers_url":"https://api.github.com/repos/TheRealJon/console/stargazers","contributors_url":"https://api.github.com/repos/TheRealJon/console/contributors","subscribers_url":"https://api.github.com/repos/TheRealJon/console/subscribers","subscription_url":"https://api.github.com/repos/TheRealJon/console/subscription","commits_url":"https://api.github.com/repos/TheRealJon/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheRealJon/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheRealJon/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheRealJon/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheRealJon/console/contents/{+path}","compare_url":"https://api.github.com/repos/TheRealJon/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheRealJon/console/merges","archive_url":"https://api.github.com/repos/TheRealJon/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheRealJon/console/downloads","issues_url":"https://api.github.com/repos/TheRealJon/console/issues{/number}","pulls_url":"https://api.github.com/repos/TheRealJon/console/pulls{/number}","milestones_url":"https://api.github.com/repos/TheRealJon/console/milestones{/number}","notifications_url":"https://api.github.com/repos/TheRealJon/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheRealJon/console/labels{/name}","releases_url":"https://api.github.com/repos/TheRealJon/console/releases{/id}","deployments_url":"https://api.github.com/repos/TheRealJon/console/deployments","created_at":"2018-05-14T12:48:17Z","updated_at":"2018-06-11T20:46:20Z","pushed_at":"2018-06-13T19:07:31Z","git_url":"git://github.com/TheRealJon/console.git","ssh_url":"git@github.com:TheRealJon/console.git","clone_url":"https://github.com/TheRealJon/console.git","svn_url":"https://github.com/TheRealJon/console","homepage":null,"size":86478,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"4d46f3e292c76f24d494259f03e81845bbac96b9","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":129436456,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MzY0NTY=","name":"console","full_name":"openshift/console","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/console","description":"OpenShift Cluster Console UI","fork":false,"url":"https://api.github.com/repos/openshift/console","forks_url":"https://api.github.com/repos/openshift/console/forks","keys_url":"https://api.github.com/repos/openshift/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/console/teams","hooks_url":"https://api.github.com/repos/openshift/console/hooks","issue_events_url":"https://api.github.com/repos/openshift/console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/console/events","assignees_url":"https://api.github.com/repos/openshift/console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/console/tags","blobs_url":"https://api.github.com/repos/openshift/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/console/languages","stargazers_url":"https://api.github.com/repos/openshift/console/stargazers","contributors_url":"https://api.github.com/repos/openshift/console/contributors","subscribers_url":"https://api.github.com/repos/openshift/console/subscribers","subscription_url":"https://api.github.com/repos/openshift/console/subscription","commits_url":"https://api.github.com/repos/openshift/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/console/merges","archive_url":"https://api.github.com/repos/openshift/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/console/downloads","issues_url":"https://api.github.com/repos/openshift/console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/console/deployments","created_at":"2018-04-13T17:54:59Z","updated_at":"2018-06-13T19:18:37Z","pushed_at":"2018-06-13T20:17:32Z","git_url":"git://github.com/openshift/console.git","ssh_url":"git@github.com:openshift/console.git","clone_url":"https://github.com/openshift/console.git","svn_url":"https://github.com/openshift/console","homepage":"https://www.openshift.org","size":86472,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":24,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/127"},"html":{"href":"https://github.com/openshift/console/pull/127"},"issue":{"href":"https://api.github.com/repos/openshift/console/issues/127"},"comments":{"href":"https://api.github.com/repos/openshift/console/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/console/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/console/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/console/statuses/231b85201d2edb99a9a7e7f5de60a9f753f52f3d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"benjaminapetersen"}}