{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/solidity/issues/4211","repository_url":"https://api.github.com/repos/ethereum/solidity","labels_url":"https://api.github.com/repos/ethereum/solidity/issues/4211/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/4211/comments","events_url":"https://api.github.com/repos/ethereum/solidity/issues/4211/events","html_url":"https://github.com/ethereum/solidity/issues/4211","id":328027195,"node_id":"MDU6SXNzdWUzMjgwMjcxOTU=","number":4211,"title":"Update \"Safe Remote Payments\" example with non-truncating division","user":{"login":"kronosapiens","id":1874062,"node_id":"MDQ6VXNlcjE4NzQwNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1874062?v=4","gravatar_id":"","url":"https://api.github.com/users/kronosapiens","html_url":"https://github.com/kronosapiens","followers_url":"https://api.github.com/users/kronosapiens/followers","following_url":"https://api.github.com/users/kronosapiens/following{/other_user}","gists_url":"https://api.github.com/users/kronosapiens/gists{/gist_id}","starred_url":"https://api.github.com/users/kronosapiens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronosapiens/subscriptions","organizations_url":"https://api.github.com/users/kronosapiens/orgs","repos_url":"https://api.github.com/users/kronosapiens/repos","events_url":"https://api.github.com/users/kronosapiens/events{/privacy}","received_events_url":"https://api.github.com/users/kronosapiens/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-31T07:38:19Z","updated_at":"2018-05-31T10:20:12Z","closed_at":"2018-05-31T10:20:12Z","author_association":"NONE","body":"The \"Safe Remote Payments\" example in the solidity tutorial (https://github.com/ethereum/solidity/blob/v0.4.24/docs/solidity-by-example.rst) assumes truncating division.\r\n\r\nAs division is no longer truncating, this example should probably be updated."},"comment":{"url":"https://api.github.com/repos/ethereum/solidity/issues/comments/393485646","html_url":"https://github.com/ethereum/solidity/issues/4211#issuecomment-393485646","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/4211","id":393485646,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzQ4NTY0Ng==","user":{"login":"kronosapiens","id":1874062,"node_id":"MDQ6VXNlcjE4NzQwNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1874062?v=4","gravatar_id":"","url":"https://api.github.com/users/kronosapiens","html_url":"https://github.com/kronosapiens","followers_url":"https://api.github.com/users/kronosapiens/followers","following_url":"https://api.github.com/users/kronosapiens/following{/other_user}","gists_url":"https://api.github.com/users/kronosapiens/gists{/gist_id}","starred_url":"https://api.github.com/users/kronosapiens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronosapiens/subscriptions","organizations_url":"https://api.github.com/users/kronosapiens/orgs","repos_url":"https://api.github.com/users/kronosapiens/repos","events_url":"https://api.github.com/users/kronosapiens/events{/privacy}","received_events_url":"https://api.github.com/users/kronosapiens/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T10:20:12Z","updated_at":"2018-05-31T10:20:12Z","author_association":"NONE","body":"I was referring to the note here: http://solidity.readthedocs.io/en/v0.4.24/types.html#rational-and-integer-literals\r\n\r\n```\r\nDivision on integer literals used to truncate in earlier versions, but it will now convert into a rational number, i.e. 5 / 2 is not equal to 2, but to 2.5.\r\n```\r\n\r\nI was confusing the handling of integer literals with `uint`-valued variables. It's a non-issue."}}
{"actor":{"display_login":"kronosapiens"}}