{"action":"created","comment":{"url":"https://api.github.com/repos/eBay/skin/pulls/comments/183943730","pull_request_review_id":115038394,"id":183943730,"diff_hunk":"@@ -37,29 +37,44 @@\n     //-----------------------------\n \n     &__window {\n-        background-color: @ds6-color-g201-gray;\n         left: 0;\n         margin: auto;\n-        margin-bottom: 15vh;\n         min-height: 55px;\n+        padding-bottom: 15vh;\n         position: absolute;\n         right: 0;\n         top: 15%;\n         will-change: opacity, transform;\n         .create-grid(@cols: 8, @gutter: 8px, @size: 7, @min: 6, @max: 8);\n \n+        // The background for the dialog window is on this pseudo element.\n+        // This was done because `margin-bottom` in safari does not work properly with position absolute elements.\n+        &::before {\n+            background-color: @ds6-color-g201-gray;\n+            bottom: 15vh;\n+            content: \"\";\n+            left: 0;\n+            position: absolute;\n+            right: 0;","path":"src/less/dialog/ds6/dialog-base.less","position":24,"original_position":24,"commit_id":"13e19fd83cee62e8dfcbb3d116dbc17ca49ad5f6","original_commit_id":"13e19fd83cee62e8dfcbb3d116dbc17ca49ad5f6","user":{"login":"DylanPiercey","id":4985201,"avatar_url":"https://avatars2.githubusercontent.com/u/4985201?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanPiercey","html_url":"https://github.com/DylanPiercey","followers_url":"https://api.github.com/users/DylanPiercey/followers","following_url":"https://api.github.com/users/DylanPiercey/following{/other_user}","gists_url":"https://api.github.com/users/DylanPiercey/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanPiercey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanPiercey/subscriptions","organizations_url":"https://api.github.com/users/DylanPiercey/orgs","repos_url":"https://api.github.com/users/DylanPiercey/repos","events_url":"https://api.github.com/users/DylanPiercey/events{/privacy}","received_events_url":"https://api.github.com/users/DylanPiercey/received_events","type":"User","site_admin":false},"body":"I’ve seen both used but if we prefer `width` then I’m fine with switching. Will update the PR in the morning.","created_at":"2018-04-25T05:11:48Z","updated_at":"2018-04-25T05:11:48Z","html_url":"https://github.com/eBay/skin/pull/164#discussion_r183943730","pull_request_url":"https://api.github.com/repos/eBay/skin/pulls/164","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eBay/skin/pulls/comments/183943730"},"html":{"href":"https://github.com/eBay/skin/pull/164#discussion_r183943730"},"pull_request":{"href":"https://api.github.com/repos/eBay/skin/pulls/164"}},"in_reply_to_id":183928057},"pull_request":{"url":"https://api.github.com/repos/eBay/skin/pulls/164","id":183854177,"html_url":"https://github.com/eBay/skin/pull/164","diff_url":"https://github.com/eBay/skin/pull/164.diff","patch_url":"https://github.com/eBay/skin/pull/164.patch","issue_url":"https://api.github.com/repos/eBay/skin/issues/164","number":164,"state":"open","locked":false,"title":"Dialog margin fix","user":{"login":"DylanPiercey","id":4985201,"avatar_url":"https://avatars2.githubusercontent.com/u/4985201?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanPiercey","html_url":"https://github.com/DylanPiercey","followers_url":"https://api.github.com/users/DylanPiercey/followers","following_url":"https://api.github.com/users/DylanPiercey/following{/other_user}","gists_url":"https://api.github.com/users/DylanPiercey/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanPiercey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanPiercey/subscriptions","organizations_url":"https://api.github.com/users/DylanPiercey/orgs","repos_url":"https://api.github.com/users/DylanPiercey/repos","events_url":"https://api.github.com/users/DylanPiercey/events{/privacy}","received_events_url":"https://api.github.com/users/DylanPiercey/received_events","type":"User","site_admin":false},"body":"## Description\r\nIn this PR the margin at the bottom of the `fill` and `default` dialog's has been fixed.\r\nThis was done by changing the `margin-bottom` on the `dialog__window` to use `padding-bottom` and having the actual `background-color` applied to a pseudo element which accounts for this padding.\r\n\r\nIt is kind of tacky to be sure, but the best solution I have found.\r\n\r\n## References\r\n#162 ","created_at":"2018-04-24T20:26:50Z","updated_at":"2018-04-25T05:11:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d583a9da4930d6b59b61d53c0a1c91608551eec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":659666601,"url":"https://api.github.com/repos/eBay/skin/labels/design%20system:%20DS6","name":"design system: DS6","color":"6a4fcc","default":false},{"id":659666612,"url":"https://api.github.com/repos/eBay/skin/labels/module:%20dialog","name":"module: dialog","color":"147133","default":false},{"id":659666658,"url":"https://api.github.com/repos/eBay/skin/labels/type:%20bug","name":"type: bug","color":"000000","default":false}],"milestone":{"url":"https://api.github.com/repos/eBay/skin/milestones/10","html_url":"https://github.com/eBay/skin/milestone/10","labels_url":"https://api.github.com/repos/eBay/skin/milestones/10/labels","id":3167055,"number":10,"title":"4.1.0","description":"Textbox (DS6), Checkbox (DS6), Radio (DS6)","creator":{"login":"ianmcburnie","id":38065,"avatar_url":"https://avatars3.githubusercontent.com/u/38065?v=4","gravatar_id":"","url":"https://api.github.com/users/ianmcburnie","html_url":"https://github.com/ianmcburnie","followers_url":"https://api.github.com/users/ianmcburnie/followers","following_url":"https://api.github.com/users/ianmcburnie/following{/other_user}","gists_url":"https://api.github.com/users/ianmcburnie/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcburnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcburnie/subscriptions","organizations_url":"https://api.github.com/users/ianmcburnie/orgs","repos_url":"https://api.github.com/users/ianmcburnie/repos","events_url":"https://api.github.com/users/ianmcburnie/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcburnie/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":1,"state":"open","created_at":"2018-03-06T20:14:59Z","updated_at":"2018-04-24T23:05:19Z","due_on":"2018-05-04T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/eBay/skin/pulls/164/commits","review_comments_url":"https://api.github.com/repos/eBay/skin/pulls/164/comments","review_comment_url":"https://api.github.com/repos/eBay/skin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eBay/skin/issues/164/comments","statuses_url":"https://api.github.com/repos/eBay/skin/statuses/13e19fd83cee62e8dfcbb3d116dbc17ca49ad5f6","head":{"label":"eBay:162-dialog-margin-bottom","ref":"162-dialog-margin-bottom","sha":"13e19fd83cee62e8dfcbb3d116dbc17ca49ad5f6","user":{"login":"eBay","id":3639281,"avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"repo":{"id":13373214,"name":"skin","full_name":"eBay/skin","owner":{"login":"eBay","id":3639281,"avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eBay/skin","description":"CSS modules designed by eBay to help build a branded, e-commerce marketplace.","fork":false,"url":"https://api.github.com/repos/eBay/skin","forks_url":"https://api.github.com/repos/eBay/skin/forks","keys_url":"https://api.github.com/repos/eBay/skin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eBay/skin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eBay/skin/teams","hooks_url":"https://api.github.com/repos/eBay/skin/hooks","issue_events_url":"https://api.github.com/repos/eBay/skin/issues/events{/number}","events_url":"https://api.github.com/repos/eBay/skin/events","assignees_url":"https://api.github.com/repos/eBay/skin/assignees{/user}","branches_url":"https://api.github.com/repos/eBay/skin/branches{/branch}","tags_url":"https://api.github.com/repos/eBay/skin/tags","blobs_url":"https://api.github.com/repos/eBay/skin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eBay/skin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eBay/skin/git/refs{/sha}","trees_url":"https://api.github.com/repos/eBay/skin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eBay/skin/statuses/{sha}","languages_url":"https://api.github.com/repos/eBay/skin/languages","stargazers_url":"https://api.github.com/repos/eBay/skin/stargazers","contributors_url":"https://api.github.com/repos/eBay/skin/contributors","subscribers_url":"https://api.github.com/repos/eBay/skin/subscribers","subscription_url":"https://api.github.com/repos/eBay/skin/subscription","commits_url":"https://api.github.com/repos/eBay/skin/commits{/sha}","git_commits_url":"https://api.github.com/repos/eBay/skin/git/commits{/sha}","comments_url":"https://api.github.com/repos/eBay/skin/comments{/number}","issue_comment_url":"https://api.github.com/repos/eBay/skin/issues/comments{/number}","contents_url":"https://api.github.com/repos/eBay/skin/contents/{+path}","compare_url":"https://api.github.com/repos/eBay/skin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eBay/skin/merges","archive_url":"https://api.github.com/repos/eBay/skin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eBay/skin/downloads","issues_url":"https://api.github.com/repos/eBay/skin/issues{/number}","pulls_url":"https://api.github.com/repos/eBay/skin/pulls{/number}","milestones_url":"https://api.github.com/repos/eBay/skin/milestones{/number}","notifications_url":"https://api.github.com/repos/eBay/skin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eBay/skin/labels{/name}","releases_url":"https://api.github.com/repos/eBay/skin/releases{/id}","deployments_url":"https://api.github.com/repos/eBay/skin/deployments","created_at":"2013-10-07T02:02:31Z","updated_at":"2018-04-20T07:16:26Z","pushed_at":"2018-04-25T02:10:05Z","git_url":"git://github.com/eBay/skin.git","ssh_url":"git@github.com:eBay/skin.git","clone_url":"https://github.com/eBay/skin.git","svn_url":"https://github.com/eBay/skin","homepage":"https://ebay.github.io/skin/","size":19907,"stargazers_count":60,"watchers_count":60,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":21,"open_issues":29,"watchers":60,"default_branch":"master"}},"base":{"label":"eBay:4.1.0","ref":"4.1.0","sha":"b41e47b434f05f9582811b687f2308081a7d4248","user":{"login":"eBay","id":3639281,"avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"repo":{"id":13373214,"name":"skin","full_name":"eBay/skin","owner":{"login":"eBay","id":3639281,"avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eBay/skin","description":"CSS modules designed by eBay to help build a branded, e-commerce marketplace.","fork":false,"url":"https://api.github.com/repos/eBay/skin","forks_url":"https://api.github.com/repos/eBay/skin/forks","keys_url":"https://api.github.com/repos/eBay/skin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eBay/skin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eBay/skin/teams","hooks_url":"https://api.github.com/repos/eBay/skin/hooks","issue_events_url":"https://api.github.com/repos/eBay/skin/issues/events{/number}","events_url":"https://api.github.com/repos/eBay/skin/events","assignees_url":"https://api.github.com/repos/eBay/skin/assignees{/user}","branches_url":"https://api.github.com/repos/eBay/skin/branches{/branch}","tags_url":"https://api.github.com/repos/eBay/skin/tags","blobs_url":"https://api.github.com/repos/eBay/skin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eBay/skin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eBay/skin/git/refs{/sha}","trees_url":"https://api.github.com/repos/eBay/skin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eBay/skin/statuses/{sha}","languages_url":"https://api.github.com/repos/eBay/skin/languages","stargazers_url":"https://api.github.com/repos/eBay/skin/stargazers","contributors_url":"https://api.github.com/repos/eBay/skin/contributors","subscribers_url":"https://api.github.com/repos/eBay/skin/subscribers","subscription_url":"https://api.github.com/repos/eBay/skin/subscription","commits_url":"https://api.github.com/repos/eBay/skin/commits{/sha}","git_commits_url":"https://api.github.com/repos/eBay/skin/git/commits{/sha}","comments_url":"https://api.github.com/repos/eBay/skin/comments{/number}","issue_comment_url":"https://api.github.com/repos/eBay/skin/issues/comments{/number}","contents_url":"https://api.github.com/repos/eBay/skin/contents/{+path}","compare_url":"https://api.github.com/repos/eBay/skin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eBay/skin/merges","archive_url":"https://api.github.com/repos/eBay/skin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eBay/skin/downloads","issues_url":"https://api.github.com/repos/eBay/skin/issues{/number}","pulls_url":"https://api.github.com/repos/eBay/skin/pulls{/number}","milestones_url":"https://api.github.com/repos/eBay/skin/milestones{/number}","notifications_url":"https://api.github.com/repos/eBay/skin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eBay/skin/labels{/name}","releases_url":"https://api.github.com/repos/eBay/skin/releases{/id}","deployments_url":"https://api.github.com/repos/eBay/skin/deployments","created_at":"2013-10-07T02:02:31Z","updated_at":"2018-04-20T07:16:26Z","pushed_at":"2018-04-25T02:10:05Z","git_url":"git://github.com/eBay/skin.git","ssh_url":"git@github.com:eBay/skin.git","clone_url":"https://github.com/eBay/skin.git","svn_url":"https://github.com/eBay/skin","homepage":"https://ebay.github.io/skin/","size":19907,"stargazers_count":60,"watchers_count":60,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":21,"open_issues":29,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eBay/skin/pulls/164"},"html":{"href":"https://github.com/eBay/skin/pull/164"},"issue":{"href":"https://api.github.com/repos/eBay/skin/issues/164"},"comments":{"href":"https://api.github.com/repos/eBay/skin/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/eBay/skin/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/eBay/skin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eBay/skin/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/eBay/skin/statuses/13e19fd83cee62e8dfcbb3d116dbc17ca49ad5f6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DylanPiercey"}}