{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/219808346","pull_request_review_id":158068423,"id":219808346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTgwODM0Ng==","diff_hunk":"@@ -96,6 +96,27 @@ static ssize_t read_appearance(struct bt_conn *conn,\n \t\t\t\t sizeof(appearance));\n }\n \n+#if defined (CONFIG_BT_GAP_PERIPHERAL_PREF_PARAMS)\n+static ssize_t read_ppcp(struct bt_conn *conn, const struct bt_gatt_attr *attr,\n+\t\t\t void *buf, u16_t len, u16_t offset)\n+{\n+\tstruct __packed {\n+\t\tuint16_t min_int;\n+\t\tuint16_t max_int;\n+\t\tuint16_t latency;\n+\t\tuint16_t timeout;\n+\t} ppcp;","path":"subsys/bluetooth/host/gatt.c","position":13,"original_position":13,"commit_id":"63c6ee37fbbe041b750ceb5c4e0907ac2a6fbf80","original_commit_id":"63c6ee37fbbe041b750ceb5c4e0907ac2a6fbf80","user":{"login":"jhedberg","id":1032570,"node_id":"MDQ6VXNlcjEwMzI1NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1032570?v=4","gravatar_id":"","url":"https://api.github.com/users/jhedberg","html_url":"https://github.com/jhedberg","followers_url":"https://api.github.com/users/jhedberg/followers","following_url":"https://api.github.com/users/jhedberg/following{/other_user}","gists_url":"https://api.github.com/users/jhedberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jhedberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhedberg/subscriptions","organizations_url":"https://api.github.com/users/jhedberg/orgs","repos_url":"https://api.github.com/users/jhedberg/repos","events_url":"https://api.github.com/users/jhedberg/events{/privacy}","received_events_url":"https://api.github.com/users/jhedberg/received_events","type":"User","site_admin":false},"body":"By struct I meant something in gatt.h - it might become convenient if we ever add the client-side implementation to this. Anyway, I suppose it's ok to just have this anonymous struct here and then refactor later.","created_at":"2018-09-24T11:52:41Z","updated_at":"2018-09-24T11:52:41Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10176#discussion_r219808346","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10176","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/219808346"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/10176#discussion_r219808346"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10176"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10176","id":217608203,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjA4MjAz","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10176","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10176.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10176.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10176","number":10176,"state":"open","locked":false,"title":"slave connection parameters updated fixes","user":{"login":"sjanc","id":10303625,"node_id":"MDQ6VXNlcjEwMzAzNjI1","avatar_url":"https://avatars2.githubusercontent.com/u/10303625?v=4","gravatar_id":"","url":"https://api.github.com/users/sjanc","html_url":"https://github.com/sjanc","followers_url":"https://api.github.com/users/sjanc/followers","following_url":"https://api.github.com/users/sjanc/following{/other_user}","gists_url":"https://api.github.com/users/sjanc/gists{/gist_id}","starred_url":"https://api.github.com/users/sjanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjanc/subscriptions","organizations_url":"https://api.github.com/users/sjanc/orgs","repos_url":"https://api.github.com/users/sjanc/repos","events_url":"https://api.github.com/users/sjanc/events{/privacy}","received_events_url":"https://api.github.com/users/sjanc/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-24T10:12:18Z","updated_at":"2018-09-24T11:52:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e35eaf4aeab39a41248b37fc0611a4784bf0e705","assignee":null,"assignees":[],"requested_reviewers":[{"login":"joerchan","id":1413276,"node_id":"MDQ6VXNlcjE0MTMyNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1413276?v=4","gravatar_id":"","url":"https://api.github.com/users/joerchan","html_url":"https://github.com/joerchan","followers_url":"https://api.github.com/users/joerchan/followers","following_url":"https://api.github.com/users/joerchan/following{/other_user}","gists_url":"https://api.github.com/users/joerchan/gists{/gist_id}","starred_url":"https://api.github.com/users/joerchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerchan/subscriptions","organizations_url":"https://api.github.com/users/joerchan/orgs","repos_url":"https://api.github.com/users/joerchan/repos","events_url":"https://api.github.com/users/joerchan/events{/privacy}","received_events_url":"https://api.github.com/users/joerchan/received_events","type":"User","site_admin":false},{"login":"Vudentz","id":2156363,"node_id":"MDQ6VXNlcjIxNTYzNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2156363?v=4","gravatar_id":"","url":"https://api.github.com/users/Vudentz","html_url":"https://github.com/Vudentz","followers_url":"https://api.github.com/users/Vudentz/followers","following_url":"https://api.github.com/users/Vudentz/following{/other_user}","gists_url":"https://api.github.com/users/Vudentz/gists{/gist_id}","starred_url":"https://api.github.com/users/Vudentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vudentz/subscriptions","organizations_url":"https://api.github.com/users/Vudentz/orgs","repos_url":"https://api.github.com/users/Vudentz/repos","events_url":"https://api.github.com/users/Vudentz/events{/privacy}","received_events_url":"https://api.github.com/users/Vudentz/received_events","type":"User","site_admin":false},{"login":"cvinayak","id":6350656,"node_id":"MDQ6VXNlcjYzNTA2NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6350656?v=4","gravatar_id":"","url":"https://api.github.com/users/cvinayak","html_url":"https://github.com/cvinayak","followers_url":"https://api.github.com/users/cvinayak/followers","following_url":"https://api.github.com/users/cvinayak/following{/other_user}","gists_url":"https://api.github.com/users/cvinayak/gists{/gist_id}","starred_url":"https://api.github.com/users/cvinayak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvinayak/subscriptions","organizations_url":"https://api.github.com/users/cvinayak/orgs","repos_url":"https://api.github.com/users/cvinayak/repos","events_url":"https://api.github.com/users/cvinayak/events{/privacy}","received_events_url":"https://api.github.com/users/cvinayak/received_events","type":"User","site_admin":false},{"login":"carlescufi","id":12450381,"node_id":"MDQ6VXNlcjEyNDUwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12450381?v=4","gravatar_id":"","url":"https://api.github.com/users/carlescufi","html_url":"https://github.com/carlescufi","followers_url":"https://api.github.com/users/carlescufi/followers","following_url":"https://api.github.com/users/carlescufi/following{/other_user}","gists_url":"https://api.github.com/users/carlescufi/gists{/gist_id}","starred_url":"https://api.github.com/users/carlescufi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlescufi/subscriptions","organizations_url":"https://api.github.com/users/carlescufi/orgs","repos_url":"https://api.github.com/users/carlescufi/repos","events_url":"https://api.github.com/users/carlescufi/events{/privacy}","received_events_url":"https://api.github.com/users/carlescufi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":700751342,"node_id":"MDU6TGFiZWw3MDA3NTEzNDI=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Bluetooth","name":"area: Bluetooth","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10176/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10176/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10176/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/63c6ee37fbbe041b750ceb5c4e0907ac2a6fbf80","head":{"label":"sjanc:conn_param","ref":"conn_param","sha":"63c6ee37fbbe041b750ceb5c4e0907ac2a6fbf80","user":{"login":"sjanc","id":10303625,"node_id":"MDQ6VXNlcjEwMzAzNjI1","avatar_url":"https://avatars2.githubusercontent.com/u/10303625?v=4","gravatar_id":"","url":"https://api.github.com/users/sjanc","html_url":"https://github.com/sjanc","followers_url":"https://api.github.com/users/sjanc/followers","following_url":"https://api.github.com/users/sjanc/following{/other_user}","gists_url":"https://api.github.com/users/sjanc/gists{/gist_id}","starred_url":"https://api.github.com/users/sjanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjanc/subscriptions","organizations_url":"https://api.github.com/users/sjanc/orgs","repos_url":"https://api.github.com/users/sjanc/repos","events_url":"https://api.github.com/users/sjanc/events{/privacy}","received_events_url":"https://api.github.com/users/sjanc/received_events","type":"User","site_admin":false},"repo":{"id":90262393,"node_id":"MDEwOlJlcG9zaXRvcnk5MDI2MjM5Mw==","name":"zephyr","full_name":"sjanc/zephyr","private":false,"owner":{"login":"sjanc","id":10303625,"node_id":"MDQ6VXNlcjEwMzAzNjI1","avatar_url":"https://avatars2.githubusercontent.com/u/10303625?v=4","gravatar_id":"","url":"https://api.github.com/users/sjanc","html_url":"https://github.com/sjanc","followers_url":"https://api.github.com/users/sjanc/followers","following_url":"https://api.github.com/users/sjanc/following{/other_user}","gists_url":"https://api.github.com/users/sjanc/gists{/gist_id}","starred_url":"https://api.github.com/users/sjanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjanc/subscriptions","organizations_url":"https://api.github.com/users/sjanc/orgs","repos_url":"https://api.github.com/users/sjanc/repos","events_url":"https://api.github.com/users/sjanc/events{/privacy}","received_events_url":"https://api.github.com/users/sjanc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sjanc/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/sjanc/zephyr","forks_url":"https://api.github.com/repos/sjanc/zephyr/forks","keys_url":"https://api.github.com/repos/sjanc/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjanc/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjanc/zephyr/teams","hooks_url":"https://api.github.com/repos/sjanc/zephyr/hooks","issue_events_url":"https://api.github.com/repos/sjanc/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/sjanc/zephyr/events","assignees_url":"https://api.github.com/repos/sjanc/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/sjanc/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/sjanc/zephyr/tags","blobs_url":"https://api.github.com/repos/sjanc/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjanc/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjanc/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjanc/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjanc/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/sjanc/zephyr/languages","stargazers_url":"https://api.github.com/repos/sjanc/zephyr/stargazers","contributors_url":"https://api.github.com/repos/sjanc/zephyr/contributors","subscribers_url":"https://api.github.com/repos/sjanc/zephyr/subscribers","subscription_url":"https://api.github.com/repos/sjanc/zephyr/subscription","commits_url":"https://api.github.com/repos/sjanc/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjanc/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjanc/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjanc/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjanc/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/sjanc/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjanc/zephyr/merges","archive_url":"https://api.github.com/repos/sjanc/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjanc/zephyr/downloads","issues_url":"https://api.github.com/repos/sjanc/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/sjanc/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/sjanc/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/sjanc/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjanc/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/sjanc/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/sjanc/zephyr/deployments","created_at":"2017-05-04T12:48:58Z","updated_at":"2017-05-04T12:49:35Z","pushed_at":"2018-09-24T11:42:31Z","git_url":"git://github.com/sjanc/zephyr.git","ssh_url":"git@github.com:sjanc/zephyr.git","clone_url":"https://github.com/sjanc/zephyr.git","svn_url":"https://github.com/sjanc/zephyr","homepage":"http://zephyrproject.org/doc","size":138621,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"e59b8cbef970b4d4f07ff52c9cb7e024d62e5316","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","private":false,"owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-09-24T11:18:12Z","pushed_at":"2018-09-24T11:52:29Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":139047,"stargazers_count":1206,"watchers_count":1206,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":801,"mirror_url":null,"archived":false,"open_issues_count":1035,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":801,"open_issues":1035,"watchers":1206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10176"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/10176"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10176"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10176/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10176/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10176/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/63c6ee37fbbe041b750ceb5c4e0907ac2a6fbf80"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jhedberg"}}