{"action":"created","comment":{"url":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/comments/244976796","pull_request_review_id":188982164,"id":244976796,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk3Njc5Ng==","diff_hunk":"@@ -13,6 +14,7 @@ angular\n     ngTranslate,\n   ])\n   .run(/* @ngTranslationsInject ./translations */)\n-  .provider('ovhPaymentMethod', paymentMethodProvider);\n+  .provider('ovhPaymentMethod', paymentMethodProvider)\n+  .service('ovhPaymentMethodHelper', paymentMethodHelperService);","path":"src/index.js","position":14,"original_position":14,"commit_id":"f028b87b1e159f9e5bed7d082079cacdaca809a6","original_commit_id":"f028b87b1e159f9e5bed7d082079cacdaca809a6","user":{"login":"marie-j","id":14836007,"node_id":"MDQ6VXNlcjE0ODM2MDA3","avatar_url":"https://avatars3.githubusercontent.com/u/14836007?v=4","gravatar_id":"","url":"https://api.github.com/users/marie-j","html_url":"https://github.com/marie-j","followers_url":"https://api.github.com/users/marie-j/followers","following_url":"https://api.github.com/users/marie-j/following{/other_user}","gists_url":"https://api.github.com/users/marie-j/gists{/gist_id}","starred_url":"https://api.github.com/users/marie-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marie-j/subscriptions","organizations_url":"https://api.github.com/users/marie-j/orgs","repos_url":"https://api.github.com/users/marie-j/repos","events_url":"https://api.github.com/users/marie-j/events{/privacy}","received_events_url":"https://api.github.com/users/marie-j/received_events","type":"User","site_admin":false},"body":"Would it make sense to also declare other services and constants as `angular` providers ? ","created_at":"2019-01-03T11:49:40Z","updated_at":"2019-01-03T11:59:17Z","html_url":"https://github.com/ovh-ux/ng-payment-method/pull/4#discussion_r244976796","pull_request_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/comments/244976796"},"html":{"href":"https://github.com/ovh-ux/ng-payment-method/pull/4#discussion_r244976796"},"pull_request":{"href":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/4","id":241956450,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTU2NDUw","html_url":"https://github.com/ovh-ux/ng-payment-method/pull/4","diff_url":"https://github.com/ovh-ux/ng-payment-method/pull/4.diff","patch_url":"https://github.com/ovh-ux/ng-payment-method/pull/4.patch","issue_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/issues/4","number":4,"state":"open","locked":false,"title":"Feat/hipay","user":{"login":"Jisay","id":1774679,"node_id":"MDQ6VXNlcjE3NzQ2Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1774679?v=4","gravatar_id":"","url":"https://api.github.com/users/Jisay","html_url":"https://github.com/Jisay","followers_url":"https://api.github.com/users/Jisay/followers","following_url":"https://api.github.com/users/Jisay/following{/other_user}","gists_url":"https://api.github.com/users/Jisay/gists{/gist_id}","starred_url":"https://api.github.com/users/Jisay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jisay/subscriptions","organizations_url":"https://api.github.com/users/Jisay/orgs","repos_url":"https://api.github.com/users/Jisay/repos","events_url":"https://api.github.com/users/Jisay/events{/privacy}","received_events_url":"https://api.github.com/users/Jisay/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-01-03T10:32:42Z","updated_at":"2019-01-03T11:59:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49a14b4a7022e05faf82f8ee51124dd4e525b8a7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cbourgois","id":56223,"node_id":"MDQ6VXNlcjU2MjIz","avatar_url":"https://avatars0.githubusercontent.com/u/56223?v=4","gravatar_id":"","url":"https://api.github.com/users/cbourgois","html_url":"https://github.com/cbourgois","followers_url":"https://api.github.com/users/cbourgois/followers","following_url":"https://api.github.com/users/cbourgois/following{/other_user}","gists_url":"https://api.github.com/users/cbourgois/gists{/gist_id}","starred_url":"https://api.github.com/users/cbourgois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbourgois/subscriptions","organizations_url":"https://api.github.com/users/cbourgois/orgs","repos_url":"https://api.github.com/users/cbourgois/repos","events_url":"https://api.github.com/users/cbourgois/events{/privacy}","received_events_url":"https://api.github.com/users/cbourgois/received_events","type":"User","site_admin":false},{"login":"antleblanc","id":428384,"node_id":"MDQ6VXNlcjQyODM4NA==","avatar_url":"https://avatars2.githubusercontent.com/u/428384?v=4","gravatar_id":"","url":"https://api.github.com/users/antleblanc","html_url":"https://github.com/antleblanc","followers_url":"https://api.github.com/users/antleblanc/followers","following_url":"https://api.github.com/users/antleblanc/following{/other_user}","gists_url":"https://api.github.com/users/antleblanc/gists{/gist_id}","starred_url":"https://api.github.com/users/antleblanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antleblanc/subscriptions","organizations_url":"https://api.github.com/users/antleblanc/orgs","repos_url":"https://api.github.com/users/antleblanc/repos","events_url":"https://api.github.com/users/antleblanc/events{/privacy}","received_events_url":"https://api.github.com/users/antleblanc/received_events","type":"User","site_admin":false},{"login":"jleveugle","id":1357733,"node_id":"MDQ6VXNlcjEzNTc3MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1357733?v=4","gravatar_id":"","url":"https://api.github.com/users/jleveugle","html_url":"https://github.com/jleveugle","followers_url":"https://api.github.com/users/jleveugle/followers","following_url":"https://api.github.com/users/jleveugle/following{/other_user}","gists_url":"https://api.github.com/users/jleveugle/gists{/gist_id}","starred_url":"https://api.github.com/users/jleveugle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleveugle/subscriptions","organizations_url":"https://api.github.com/users/jleveugle/orgs","repos_url":"https://api.github.com/users/jleveugle/repos","events_url":"https://api.github.com/users/jleveugle/events{/privacy}","received_events_url":"https://api.github.com/users/jleveugle/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/4/commits","review_comments_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/4/comments","review_comment_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/issues/4/comments","statuses_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/statuses/f028b87b1e159f9e5bed7d082079cacdaca809a6","head":{"label":"ovh-ux:feat/hipay","ref":"feat/hipay","sha":"f028b87b1e159f9e5bed7d082079cacdaca809a6","user":{"login":"ovh-ux","id":26575234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTc1MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"repo":{"id":161200435,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEyMDA0MzU=","name":"ng-payment-method","full_name":"ovh-ux/ng-payment-method","private":false,"owner":{"login":"ovh-ux","id":26575234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTc1MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ovh-ux/ng-payment-method","description":"Help you to get payment methods from different OVH APIs","fork":false,"url":"https://api.github.com/repos/ovh-ux/ng-payment-method","forks_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/forks","keys_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/teams","hooks_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/hooks","issue_events_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/issues/events{/number}","events_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/events","assignees_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/assignees{/user}","branches_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/branches{/branch}","tags_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/tags","blobs_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/languages","stargazers_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/stargazers","contributors_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/contributors","subscribers_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/subscribers","subscription_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/subscription","commits_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/contents/{+path}","compare_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/merges","archive_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/downloads","issues_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/issues{/number}","pulls_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/labels{/name}","releases_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/releases{/id}","deployments_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/deployments","created_at":"2018-12-10T16:03:59Z","updated_at":"2019-01-02T09:18:01Z","pushed_at":"2019-01-03T10:32:43Z","git_url":"git://github.com/ovh-ux/ng-payment-method.git","ssh_url":"git@github.com:ovh-ux/ng-payment-method.git","clone_url":"https://github.com/ovh-ux/ng-payment-method.git","svn_url":"https://github.com/ovh-ux/ng-payment-method","homepage":"","size":130,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ovh-ux:develop","ref":"develop","sha":"d8549b1bb09b02cb723def878b027095ad48814b","user":{"login":"ovh-ux","id":26575234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTc1MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"repo":{"id":161200435,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEyMDA0MzU=","name":"ng-payment-method","full_name":"ovh-ux/ng-payment-method","private":false,"owner":{"login":"ovh-ux","id":26575234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTc1MjM0","avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ovh-ux/ng-payment-method","description":"Help you to get payment methods from different OVH APIs","fork":false,"url":"https://api.github.com/repos/ovh-ux/ng-payment-method","forks_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/forks","keys_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/teams","hooks_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/hooks","issue_events_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/issues/events{/number}","events_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/events","assignees_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/assignees{/user}","branches_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/branches{/branch}","tags_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/tags","blobs_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/languages","stargazers_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/stargazers","contributors_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/contributors","subscribers_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/subscribers","subscription_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/subscription","commits_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/contents/{+path}","compare_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/merges","archive_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/downloads","issues_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/issues{/number}","pulls_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/labels{/name}","releases_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/releases{/id}","deployments_url":"https://api.github.com/repos/ovh-ux/ng-payment-method/deployments","created_at":"2018-12-10T16:03:59Z","updated_at":"2019-01-02T09:18:01Z","pushed_at":"2019-01-03T10:32:43Z","git_url":"git://github.com/ovh-ux/ng-payment-method.git","ssh_url":"git@github.com:ovh-ux/ng-payment-method.git","clone_url":"https://github.com/ovh-ux/ng-payment-method.git","svn_url":"https://github.com/ovh-ux/ng-payment-method","homepage":"","size":130,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/4"},"html":{"href":"https://github.com/ovh-ux/ng-payment-method/pull/4"},"issue":{"href":"https://api.github.com/repos/ovh-ux/ng-payment-method/issues/4"},"comments":{"href":"https://api.github.com/repos/ovh-ux/ng-payment-method/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ovh-ux/ng-payment-method/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/ovh-ux/ng-payment-method/statuses/f028b87b1e159f9e5bed7d082079cacdaca809a6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marie-j"}}