{"action":"created","issue":{"url":"https://api.github.com/repos/m-lab/etl/issues/530","repository_url":"https://api.github.com/repos/m-lab/etl","labels_url":"https://api.github.com/repos/m-lab/etl/issues/530/labels{/name}","comments_url":"https://api.github.com/repos/m-lab/etl/issues/530/comments","events_url":"https://api.github.com/repos/m-lab/etl/issues/530/events","html_url":"https://github.com/m-lab/etl/pull/530","id":336359611,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODMxNDc2","number":530,"title":"Use standard columns for switch schema","user":{"login":"stephen-soltesz","id":1085316,"node_id":"MDQ6VXNlcjEwODUzMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1085316?v=4","gravatar_id":"","url":"https://api.github.com/users/stephen-soltesz","html_url":"https://github.com/stephen-soltesz","followers_url":"https://api.github.com/users/stephen-soltesz/followers","following_url":"https://api.github.com/users/stephen-soltesz/following{/other_user}","gists_url":"https://api.github.com/users/stephen-soltesz/gists{/gist_id}","starred_url":"https://api.github.com/users/stephen-soltesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephen-soltesz/subscriptions","organizations_url":"https://api.github.com/users/stephen-soltesz/orgs","repos_url":"https://api.github.com/users/stephen-soltesz/repos","events_url":"https://api.github.com/users/stephen-soltesz/events{/privacy}","received_events_url":"https://api.github.com/users/stephen-soltesz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-27T19:34:40Z","updated_at":"2018-06-28T17:07:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/m-lab/etl/pulls/530","html_url":"https://github.com/m-lab/etl/pull/530","diff_url":"https://github.com/m-lab/etl/pull/530.diff","patch_url":"https://github.com/m-lab/etl/pull/530.patch"},"body":"This change is a companion to https://github.com/m-lab/etl-schema/pull/5\r\n\r\nThis change updates the disco switch schema to use standard columns for `test_id`, `task_filename` and `parse_time`.\r\n\r\nAs well, this change should resolve https://github.com/m-lab/etl/issues/462\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/m-lab/etl/530)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/m-lab/etl/issues/comments/401106312","html_url":"https://github.com/m-lab/etl/pull/530#issuecomment-401106312","issue_url":"https://api.github.com/repos/m-lab/etl/issues/530","id":401106312,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTEwNjMxMg==","user":{"login":"gfr10598","id":20915834,"node_id":"MDQ6VXNlcjIwOTE1ODM0","avatar_url":"https://avatars3.githubusercontent.com/u/20915834?v=4","gravatar_id":"","url":"https://api.github.com/users/gfr10598","html_url":"https://github.com/gfr10598","followers_url":"https://api.github.com/users/gfr10598/followers","following_url":"https://api.github.com/users/gfr10598/following{/other_user}","gists_url":"https://api.github.com/users/gfr10598/gists{/gist_id}","starred_url":"https://api.github.com/users/gfr10598/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfr10598/subscriptions","organizations_url":"https://api.github.com/users/gfr10598/orgs","repos_url":"https://api.github.com/users/gfr10598/repos","events_url":"https://api.github.com/users/gfr10598/events{/privacy}","received_events_url":"https://api.github.com/users/gfr10598/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T17:07:04Z","updated_at":"2018-06-28T17:07:04Z","author_association":"CONTRIBUTOR","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>  after resolving one question\n\n---\n\nReview status: :shipit: complete! 1 of 1 LGTMs obtained\n\n---\n\n*[schema/switch_schema.go, line 13 at r2](https://reviewable.io/reviews/m-lab/etl/530#-LG6Fm8pE3s6v-dojaRJ:-LG6Fm922lBn3m_taTEu:b-fba416) ([raw file](https://github.com/m-lab/etl/blob/c8a5d263f916b540366fcd9719e4f1f633260653/schema/switch_schema.go#L13)):*\n> ```Go\n> \tTaskFilename  string   `json:\"task_filename,string\" bigquery:\"task_filename\"`\n> \tTestID        string   `json:\"test_id,string\" bigquery:\"test_id\"`\n> \tParseTime     int64    `json:\"parse_time,int64\" bigquery:\"parse_time\"`\n> ```\n\nWe want the BQ field to be a timestamp.  Does this result in a correct timestamp value?  I think SS uses struct with a time.Time field, and NDT uses a map with a timestamp marshalled to a string.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/m-lab/etl/530#-:-LG6M65q-YYwTv3uWGu8:b1equz0)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"gfr10598"}}