{"action":"created","issue":{"url":"https://api.github.com/repos/CDrummond/cantata/issues/1400","repository_url":"https://api.github.com/repos/CDrummond/cantata","labels_url":"https://api.github.com/repos/CDrummond/cantata/issues/1400/labels{/name}","comments_url":"https://api.github.com/repos/CDrummond/cantata/issues/1400/comments","events_url":"https://api.github.com/repos/CDrummond/cantata/issues/1400/events","html_url":"https://github.com/CDrummond/cantata/issues/1400","id":379005568,"node_id":"MDU6SXNzdWUzNzkwMDU1Njg=","number":1400,"title":"Support album art using MPD's (new) protocol extension","user":{"login":"hdak1945git","id":7365358,"node_id":"MDQ6VXNlcjczNjUzNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/7365358?v=4","gravatar_id":"","url":"https://api.github.com/users/hdak1945git","html_url":"https://github.com/hdak1945git","followers_url":"https://api.github.com/users/hdak1945git/followers","following_url":"https://api.github.com/users/hdak1945git/following{/other_user}","gists_url":"https://api.github.com/users/hdak1945git/gists{/gist_id}","starred_url":"https://api.github.com/users/hdak1945git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdak1945git/subscriptions","organizations_url":"https://api.github.com/users/hdak1945git/orgs","repos_url":"https://api.github.com/users/hdak1945git/repos","events_url":"https://api.github.com/users/hdak1945git/events{/privacy}","received_events_url":"https://api.github.com/users/hdak1945git/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-09T03:09:51Z","updated_at":"2018-11-12T06:16:08Z","closed_at":null,"author_association":"NONE","body":"**Is your feature request related to a problem? Please describe.**\r\nTangentially related: I have an album name with a pound/number sign (`#`) embedded in the middle of it. Unfortunately, cantata doesn't seem to properly escape these path names, or simply truncates it, when it requests album art from my web server. I later confirmed this by watching my server logs for the requested album art while cantata was running.\r\n\r\n**Describe the solution you'd like**\r\nBeyond fixing the above, a nicer solution would be cut out the middle man altogether, by implementing the new `albumart` command recently added to MPD and [described here](https://github.com/MusicPlayerDaemon/MPD/blob/master/doc/protocol.rst#id172). This would negate the need to run a separate HTTP server (for the sole use of album art at least).\r\n\r\n**Describe alternatives you've considered**\r\nRenaming the files would be a workaround -- but it wouldn't fix the URL encoding bug.\r\n\r\n**Additional context**\r\nI know the Android client M.A.L.P. supports this feature (and I have tested it--it works), their project page is located over at [Gitlab](https://gitlab.com/gateship-one/malp) (GPLv3) which may serve as a useful reference.\r\nArch Linux recently pushed a stable version of the mpd (0.21.1-1 in their repository) which supports the `albumart` command.\r\n"},"comment":{"url":"https://api.github.com/repos/CDrummond/cantata/issues/comments/437768686","html_url":"https://github.com/CDrummond/cantata/issues/1400#issuecomment-437768686","issue_url":"https://api.github.com/repos/CDrummond/cantata/issues/1400","id":437768686,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzc2ODY4Ng==","user":{"login":"hdak1945git","id":7365358,"node_id":"MDQ6VXNlcjczNjUzNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/7365358?v=4","gravatar_id":"","url":"https://api.github.com/users/hdak1945git","html_url":"https://github.com/hdak1945git","followers_url":"https://api.github.com/users/hdak1945git/followers","following_url":"https://api.github.com/users/hdak1945git/following{/other_user}","gists_url":"https://api.github.com/users/hdak1945git/gists{/gist_id}","starred_url":"https://api.github.com/users/hdak1945git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdak1945git/subscriptions","organizations_url":"https://api.github.com/users/hdak1945git/orgs","repos_url":"https://api.github.com/users/hdak1945git/repos","events_url":"https://api.github.com/users/hdak1945git/events{/privacy}","received_events_url":"https://api.github.com/users/hdak1945git/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T06:16:08Z","updated_at":"2018-11-12T06:16:08Z","author_association":"NONE","body":"Updated as requested--still exhibiting the problems mentioned above...\r\n\r\nLuckily it seems like a simple change was in order, the \"job queue\" (for lack of a better phrase) seemed to be be setup incorrectly. Simply put, a line in `CoverDownloader::downloadViaMpd(...)` invokes `jobs.insert(nullptr, job)`, which overwrites any existing job entry. `CoverDownloader::mpdAlbumArt(...)` later on attempts to verify the job it's working on using `findJob(...)` which will fail most of the time because the fields it compares are likely completely different due to the aforementioned insert.\r\n\r\nI've made another patch for you to review: https://gist.github.com/hdak1945git/5c1335f9599296965a8a75fdc7708d54 it's based on your latest push (e039683be75b58bd6163926a485639ab11b0cd00) I've tried to mirror what was intended and refrain from modifying existing `DBUG` messages.\r\n\r\nFeature wise at least, the above patch and recent commits fulfills what I need, all my album art is served locally using MPD 🎉 (Save a few I found were missing in testing...)"}}
{"actor":{"display_login":"hdak1945git"}}