{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/ewoms/issues/373","repository_url":"https://api.github.com/repos/OPM/ewoms","labels_url":"https://api.github.com/repos/OPM/ewoms/issues/373/labels{/name}","comments_url":"https://api.github.com/repos/OPM/ewoms/issues/373/comments","events_url":"https://api.github.com/repos/OPM/ewoms/issues/373/events","html_url":"https://github.com/OPM/ewoms/issues/373","id":355105370,"node_id":"MDU6SXNzdWUzNTUxMDUzNzA=","number":373,"title":"Barriers when writing ECL output with tasklets.","user":{"login":"blattms","id":1944640,"node_id":"MDQ6VXNlcjE5NDQ2NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1944640?v=4","gravatar_id":"","url":"https://api.github.com/users/blattms","html_url":"https://github.com/blattms","followers_url":"https://api.github.com/users/blattms/followers","following_url":"https://api.github.com/users/blattms/following{/other_user}","gists_url":"https://api.github.com/users/blattms/gists{/gist_id}","starred_url":"https://api.github.com/users/blattms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blattms/subscriptions","organizations_url":"https://api.github.com/users/blattms/orgs","repos_url":"https://api.github.com/users/blattms/repos","events_url":"https://api.github.com/users/blattms/events{/privacy}","received_events_url":"https://api.github.com/users/blattms/received_events","type":"User","site_admin":false},"labels":[{"id":8228664,"node_id":"MDU6TGFiZWw4MjI4NjY0","url":"https://api.github.com/repos/OPM/ewoms/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-29T10:54:32Z","updated_at":"2018-08-29T11:16:15Z","closed_at":null,"author_association":"MEMBER","body":"I just took a look at the code of ECLWriter and could not help but wonder:\r\n\r\nWhy do we need to wait [here](/OPM/ewoms/blob/3a03f35acf78b9aa3b3a954a5254a7c3161e1219/ebos/eclwriter.hh#L229) until a previous write finishes before dispatching the next write? \r\nYet there is no barrier in the destructor of EclWriter to make sure that the last write actually finishes before program shutdown. Don't we need that and are just lucky (maybe because of the other barrier) that all the writes finished until now? Or did I miss something?"},"comment":{"url":"https://api.github.com/repos/OPM/ewoms/issues/comments/416916560","html_url":"https://github.com/OPM/ewoms/issues/373#issuecomment-416916560","issue_url":"https://api.github.com/repos/OPM/ewoms/issues/373","id":416916560,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjkxNjU2MA==","user":{"login":"blattms","id":1944640,"node_id":"MDQ6VXNlcjE5NDQ2NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1944640?v=4","gravatar_id":"","url":"https://api.github.com/users/blattms","html_url":"https://github.com/blattms","followers_url":"https://api.github.com/users/blattms/followers","following_url":"https://api.github.com/users/blattms/following{/other_user}","gists_url":"https://api.github.com/users/blattms/gists{/gist_id}","starred_url":"https://api.github.com/users/blattms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blattms/subscriptions","organizations_url":"https://api.github.com/users/blattms/orgs","repos_url":"https://api.github.com/users/blattms/repos","events_url":"https://api.github.com/users/blattms/events{/privacy}","received_events_url":"https://api.github.com/users/blattms/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T11:16:15Z","updated_at":"2018-08-29T11:16:15Z","author_association":"MEMBER","body":"It also seems like there might be issues when the number of worker threads of the Taskletrunner is more than 1. In that case the BarrierTasklet is only executed by one thread. So we are waiting only for one thread. Not a big problem (even less synchronization), but the function name is a bit misleading.\r\n\r\nBut in the destructor of the TaskletRunner this seems to mean that only one thread will get the TerminateTaklet that will end its run methods. All other threads seem to running for ever and as they are joined so should the program."}}
{"actor":{"display_login":"blattms"}}