{"action":"created","comment":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/245479880","pull_request_review_id":189598947,"id":245479880,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ3OTg4MA==","diff_hunk":"@@ -297,30 +297,26 @@ module Iterator(T)\n   # * If *reuse* is given, the array can be reused\n   # * If *reuse* is an `Array`, this array will be reused","path":"src/iterator.cr","position":2,"original_position":2,"commit_id":"2de99c972416b476a9ac4e48b75fadbc7fcd4c48","original_commit_id":"2de99c972416b476a9ac4e48b75fadbc7fcd4c48","user":{"login":"straight-shoota","id":466378,"node_id":"MDQ6VXNlcjQ2NjM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/466378?v=4","gravatar_id":"","url":"https://api.github.com/users/straight-shoota","html_url":"https://github.com/straight-shoota","followers_url":"https://api.github.com/users/straight-shoota/followers","following_url":"https://api.github.com/users/straight-shoota/following{/other_user}","gists_url":"https://api.github.com/users/straight-shoota/gists{/gist_id}","starred_url":"https://api.github.com/users/straight-shoota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/straight-shoota/subscriptions","organizations_url":"https://api.github.com/users/straight-shoota/orgs","repos_url":"https://api.github.com/users/straight-shoota/repos","events_url":"https://api.github.com/users/straight-shoota/events{/privacy}","received_events_url":"https://api.github.com/users/straight-shoota/received_events","type":"User","site_admin":false},"body":"This should be updated to allow `Array`, `Deque` or any collection type with a matching interface.","created_at":"2019-01-05T15:00:46Z","updated_at":"2019-01-05T15:01:39Z","html_url":"https://github.com/crystal-lang/crystal/pull/7233#discussion_r245479880","pull_request_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/7233","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/245479880"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/7233#discussion_r245479880"},"pull_request":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/7233"}}},"pull_request":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/7233","id":241447940,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDQ3OTQw","html_url":"https://github.com/crystal-lang/crystal/pull/7233","diff_url":"https://github.com/crystal-lang/crystal/pull/7233.diff","patch_url":"https://github.com/crystal-lang/crystal/pull/7233.patch","issue_url":"https://api.github.com/repos/crystal-lang/crystal/issues/7233","number":7233,"state":"open","locked":false,"title":"Enumerable#each_cons support for accepting deque as a reuse buffer","user":{"login":"yxhuvud","id":155895,"node_id":"MDQ6VXNlcjE1NTg5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/155895?v=4","gravatar_id":"","url":"https://api.github.com/users/yxhuvud","html_url":"https://github.com/yxhuvud","followers_url":"https://api.github.com/users/yxhuvud/followers","following_url":"https://api.github.com/users/yxhuvud/following{/other_user}","gists_url":"https://api.github.com/users/yxhuvud/gists{/gist_id}","starred_url":"https://api.github.com/users/yxhuvud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yxhuvud/subscriptions","organizations_url":"https://api.github.com/users/yxhuvud/orgs","repos_url":"https://api.github.com/users/yxhuvud/repos","events_url":"https://api.github.com/users/yxhuvud/events{/privacy}","received_events_url":"https://api.github.com/users/yxhuvud/received_events","type":"User","site_admin":false},"body":"This removes the restriction on `Enumerable#each_cons` and `Iterator#cons` to only accept arrays as a container to reuse. With this, it will be possible to use a Deque instead, for better performance.\r\n\r\nAlso adds some missing tests in iterator_spec.cr\r\n\r\nSolves #7189 ","created_at":"2018-12-29T13:54:38Z","updated_at":"2019-01-05T15:01:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d33fec1033671a5331693f22b13bf032b239798","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":20487869,"node_id":"MDU6TGFiZWwyMDQ4Nzg2OQ==","url":"https://api.github.com/repos/crystal-lang/crystal/labels/kind:feature","name":"kind:feature","color":"84b6eb","default":false},{"id":253750561,"node_id":"MDU6TGFiZWwyNTM3NTA1NjE=","url":"https://api.github.com/repos/crystal-lang/crystal/labels/performance","name":"performance","color":"811d21","default":false},{"id":1166993673,"node_id":"MDU6TGFiZWwxMTY2OTkzNjcz","url":"https://api.github.com/repos/crystal-lang/crystal/labels/topic:stdlib:collection","name":"topic:stdlib:collection","color":"e8ea5b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/7233/commits","review_comments_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/7233/comments","review_comment_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/issues/7233/comments","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/2de99c972416b476a9ac4e48b75fadbc7fcd4c48","head":{"label":"yxhuvud:feat/each_cons_support_for_deque","ref":"feat/each_cons_support_for_deque","sha":"2de99c972416b476a9ac4e48b75fadbc7fcd4c48","user":{"login":"yxhuvud","id":155895,"node_id":"MDQ6VXNlcjE1NTg5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/155895?v=4","gravatar_id":"","url":"https://api.github.com/users/yxhuvud","html_url":"https://github.com/yxhuvud","followers_url":"https://api.github.com/users/yxhuvud/followers","following_url":"https://api.github.com/users/yxhuvud/following{/other_user}","gists_url":"https://api.github.com/users/yxhuvud/gists{/gist_id}","starred_url":"https://api.github.com/users/yxhuvud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yxhuvud/subscriptions","organizations_url":"https://api.github.com/users/yxhuvud/orgs","repos_url":"https://api.github.com/users/yxhuvud/repos","events_url":"https://api.github.com/users/yxhuvud/events{/privacy}","received_events_url":"https://api.github.com/users/yxhuvud/received_events","type":"User","site_admin":false},"repo":{"id":73706141,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcwNjE0MQ==","name":"crystal","full_name":"yxhuvud/crystal","private":false,"owner":{"login":"yxhuvud","id":155895,"node_id":"MDQ6VXNlcjE1NTg5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/155895?v=4","gravatar_id":"","url":"https://api.github.com/users/yxhuvud","html_url":"https://github.com/yxhuvud","followers_url":"https://api.github.com/users/yxhuvud/followers","following_url":"https://api.github.com/users/yxhuvud/following{/other_user}","gists_url":"https://api.github.com/users/yxhuvud/gists{/gist_id}","starred_url":"https://api.github.com/users/yxhuvud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yxhuvud/subscriptions","organizations_url":"https://api.github.com/users/yxhuvud/orgs","repos_url":"https://api.github.com/users/yxhuvud/repos","events_url":"https://api.github.com/users/yxhuvud/events{/privacy}","received_events_url":"https://api.github.com/users/yxhuvud/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yxhuvud/crystal","description":"The Crystal Programming Language","fork":true,"url":"https://api.github.com/repos/yxhuvud/crystal","forks_url":"https://api.github.com/repos/yxhuvud/crystal/forks","keys_url":"https://api.github.com/repos/yxhuvud/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yxhuvud/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yxhuvud/crystal/teams","hooks_url":"https://api.github.com/repos/yxhuvud/crystal/hooks","issue_events_url":"https://api.github.com/repos/yxhuvud/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/yxhuvud/crystal/events","assignees_url":"https://api.github.com/repos/yxhuvud/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/yxhuvud/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/yxhuvud/crystal/tags","blobs_url":"https://api.github.com/repos/yxhuvud/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yxhuvud/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yxhuvud/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/yxhuvud/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yxhuvud/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/yxhuvud/crystal/languages","stargazers_url":"https://api.github.com/repos/yxhuvud/crystal/stargazers","contributors_url":"https://api.github.com/repos/yxhuvud/crystal/contributors","subscribers_url":"https://api.github.com/repos/yxhuvud/crystal/subscribers","subscription_url":"https://api.github.com/repos/yxhuvud/crystal/subscription","commits_url":"https://api.github.com/repos/yxhuvud/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/yxhuvud/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/yxhuvud/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/yxhuvud/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/yxhuvud/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/yxhuvud/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yxhuvud/crystal/merges","archive_url":"https://api.github.com/repos/yxhuvud/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yxhuvud/crystal/downloads","issues_url":"https://api.github.com/repos/yxhuvud/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/yxhuvud/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/yxhuvud/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/yxhuvud/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yxhuvud/crystal/labels{/name}","releases_url":"https://api.github.com/repos/yxhuvud/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/yxhuvud/crystal/deployments","created_at":"2016-11-14T13:16:32Z","updated_at":"2016-11-14T13:16:36Z","pushed_at":"2019-01-05T10:29:58Z","git_url":"git://github.com/yxhuvud/crystal.git","ssh_url":"git@github.com:yxhuvud/crystal.git","clone_url":"https://github.com/yxhuvud/crystal.git","svn_url":"https://github.com/yxhuvud/crystal","homepage":"http://crystal-lang.org","size":38013,"stargazers_count":0,"watchers_count":0,"language":"Crystal","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crystal-lang:master","ref":"master","sha":"d6f9f1dcae76ba118d7fdc6b32656edf426e934a","user":{"login":"crystal-lang","id":6539796,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1Mzk3OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":6887813,"node_id":"MDEwOlJlcG9zaXRvcnk2ODg3ODEz","name":"crystal","full_name":"crystal-lang/crystal","private":false,"owner":{"login":"crystal-lang","id":6539796,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1Mzk3OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crystal-lang/crystal","description":"The Crystal Programming Language","fork":false,"url":"https://api.github.com/repos/crystal-lang/crystal","forks_url":"https://api.github.com/repos/crystal-lang/crystal/forks","keys_url":"https://api.github.com/repos/crystal-lang/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crystal-lang/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crystal-lang/crystal/teams","hooks_url":"https://api.github.com/repos/crystal-lang/crystal/hooks","issue_events_url":"https://api.github.com/repos/crystal-lang/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/crystal-lang/crystal/events","assignees_url":"https://api.github.com/repos/crystal-lang/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/crystal-lang/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/crystal-lang/crystal/tags","blobs_url":"https://api.github.com/repos/crystal-lang/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crystal-lang/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crystal-lang/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/crystal-lang/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/crystal-lang/crystal/languages","stargazers_url":"https://api.github.com/repos/crystal-lang/crystal/stargazers","contributors_url":"https://api.github.com/repos/crystal-lang/crystal/contributors","subscribers_url":"https://api.github.com/repos/crystal-lang/crystal/subscribers","subscription_url":"https://api.github.com/repos/crystal-lang/crystal/subscription","commits_url":"https://api.github.com/repos/crystal-lang/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/crystal-lang/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/crystal-lang/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/crystal-lang/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/crystal-lang/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crystal-lang/crystal/merges","archive_url":"https://api.github.com/repos/crystal-lang/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crystal-lang/crystal/downloads","issues_url":"https://api.github.com/repos/crystal-lang/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/crystal-lang/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/crystal-lang/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/crystal-lang/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crystal-lang/crystal/labels{/name}","releases_url":"https://api.github.com/repos/crystal-lang/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/crystal-lang/crystal/deployments","created_at":"2012-11-27T17:32:32Z","updated_at":"2019-01-05T14:03:57Z","pushed_at":"2019-01-05T14:48:48Z","git_url":"git://github.com/crystal-lang/crystal.git","ssh_url":"git@github.com:crystal-lang/crystal.git","clone_url":"https://github.com/crystal-lang/crystal.git","svn_url":"https://github.com/crystal-lang/crystal","homepage":"https://crystal-lang.org","size":38247,"stargazers_count":12435,"watchers_count":12435,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":962,"mirror_url":null,"archived":false,"open_issues_count":810,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":962,"open_issues":810,"watchers":12435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/7233"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/7233"},"issue":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/7233"},"comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/7233/comments"},"review_comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/7233/comments"},"review_comment":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/7233/commits"},"statuses":{"href":"https://api.github.com/repos/crystal-lang/crystal/statuses/2de99c972416b476a9ac4e48b75fadbc7fcd4c48"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"straight-shoota"}}