{"action":"closed","number":638,"pull_request":{"url":"https://api.github.com/repos/sofa-framework/sofa/pulls/638","id":181802664,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgxODAyNjY0","html_url":"https://github.com/sofa-framework/sofa/pull/638","diff_url":"https://github.com/sofa-framework/sofa/pull/638.diff","patch_url":"https://github.com/sofa-framework/sofa/pull/638.patch","issue_url":"https://api.github.com/repos/sofa-framework/sofa/issues/638","number":638,"state":"closed","locked":false,"title":"[SofaKernel] Header include cleanup","user":{"login":"epernod","id":21199245,"node_id":"MDQ6VXNlcjIxMTk5MjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/21199245?v=4","gravatar_id":"","url":"https://api.github.com/users/epernod","html_url":"https://github.com/epernod","followers_url":"https://api.github.com/users/epernod/followers","following_url":"https://api.github.com/users/epernod/following{/other_user}","gists_url":"https://api.github.com/users/epernod/gists{/gist_id}","starred_url":"https://api.github.com/users/epernod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epernod/subscriptions","organizations_url":"https://api.github.com/users/epernod/orgs","repos_url":"https://api.github.com/users/epernod/repos","events_url":"https://api.github.com/users/epernod/events{/privacy}","received_events_url":"https://api.github.com/users/epernod/received_events","type":"User","site_admin":false},"body":"Just removing unnecessary headers include inside header in sofa::core\r\nNo forward class or intelligent refactoring.\r\n\r\nany suggestion/remark is welcomed. \r\n\r\n______________________________________________________\r\n<!--- Please leave this at the end of your message -->\r\nThis PR: \r\n- [x] builds with SUCCESS for all platforms on the CI.\r\n- [x] does not generate new warnings.\r\n- [x] does not generate new unit test failures.\r\n- [x] does not generate new scene test failures.\r\n- [x] does not break API compatibility.\r\n- [x] is more than 1 week old (or has fast-merge label).\r\n\r\n**Reviewers will merge only if all these checks are true.**\r\n","created_at":"2018-04-16T09:34:26Z","updated_at":"2018-05-31T07:34:27Z","closed_at":"2018-05-31T07:34:27Z","merged_at":"2018-05-31T07:34:27Z","merge_commit_sha":"e959abb9fe029ded35852b6698fde7abee7e8c4e","assignee":{"login":"epernod","id":21199245,"node_id":"MDQ6VXNlcjIxMTk5MjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/21199245?v=4","gravatar_id":"","url":"https://api.github.com/users/epernod","html_url":"https://github.com/epernod","followers_url":"https://api.github.com/users/epernod/followers","following_url":"https://api.github.com/users/epernod/following{/other_user}","gists_url":"https://api.github.com/users/epernod/gists{/gist_id}","starred_url":"https://api.github.com/users/epernod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epernod/subscriptions","organizations_url":"https://api.github.com/users/epernod/orgs","repos_url":"https://api.github.com/users/epernod/repos","events_url":"https://api.github.com/users/epernod/events{/privacy}","received_events_url":"https://api.github.com/users/epernod/received_events","type":"User","site_admin":false},"assignees":[{"login":"epernod","id":21199245,"node_id":"MDQ6VXNlcjIxMTk5MjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/21199245?v=4","gravatar_id":"","url":"https://api.github.com/users/epernod","html_url":"https://github.com/epernod","followers_url":"https://api.github.com/users/epernod/followers","following_url":"https://api.github.com/users/epernod/following{/other_user}","gists_url":"https://api.github.com/users/epernod/gists{/gist_id}","starred_url":"https://api.github.com/users/epernod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epernod/subscriptions","organizations_url":"https://api.github.com/users/epernod/orgs","repos_url":"https://api.github.com/users/epernod/repos","events_url":"https://api.github.com/users/epernod/events{/privacy}","received_events_url":"https://api.github.com/users/epernod/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":636783176,"node_id":"MDU6TGFiZWw2MzY3ODMxNzY=","url":"https://api.github.com/repos/sofa-framework/sofa/labels/pr:%20clean","name":"pr: clean","color":"0e8a16","default":false},{"id":568527180,"node_id":"MDU6TGFiZWw1Njg1MjcxODA=","url":"https://api.github.com/repos/sofa-framework/sofa/labels/status:%20ready","name":"status: ready","color":"909090","default":false}],"milestone":{"url":"https://api.github.com/repos/sofa-framework/sofa/milestones/8","html_url":"https://github.com/sofa-framework/sofa/milestone/8","labels_url":"https://api.github.com/repos/sofa-framework/sofa/milestones/8/labels","id":2864309,"node_id":"MDk6TWlsZXN0b25lMjg2NDMwOQ==","number":8,"title":"v18.06","description":"","creator":{"login":"guparan","id":1651667,"node_id":"MDQ6VXNlcjE2NTE2Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/1651667?v=4","gravatar_id":"","url":"https://api.github.com/users/guparan","html_url":"https://github.com/guparan","followers_url":"https://api.github.com/users/guparan/followers","following_url":"https://api.github.com/users/guparan/following{/other_user}","gists_url":"https://api.github.com/users/guparan/gists{/gist_id}","starred_url":"https://api.github.com/users/guparan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guparan/subscriptions","organizations_url":"https://api.github.com/users/guparan/orgs","repos_url":"https://api.github.com/users/guparan/repos","events_url":"https://api.github.com/users/guparan/events{/privacy}","received_events_url":"https://api.github.com/users/guparan/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":30,"state":"open","created_at":"2017-10-25T09:34:45Z","updated_at":"2018-05-31T07:34:27Z","due_on":"2018-06-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/sofa-framework/sofa/pulls/638/commits","review_comments_url":"https://api.github.com/repos/sofa-framework/sofa/pulls/638/comments","review_comment_url":"https://api.github.com/repos/sofa-framework/sofa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sofa-framework/sofa/issues/638/comments","statuses_url":"https://api.github.com/repos/sofa-framework/sofa/statuses/bb4e3d21bdba3ca633a866c69d019f56b28c3c7a","head":{"label":"epernod:header_include_cleanup","ref":"header_include_cleanup","sha":"bb4e3d21bdba3ca633a866c69d019f56b28c3c7a","user":{"login":"epernod","id":21199245,"node_id":"MDQ6VXNlcjIxMTk5MjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/21199245?v=4","gravatar_id":"","url":"https://api.github.com/users/epernod","html_url":"https://github.com/epernod","followers_url":"https://api.github.com/users/epernod/followers","following_url":"https://api.github.com/users/epernod/following{/other_user}","gists_url":"https://api.github.com/users/epernod/gists{/gist_id}","starred_url":"https://api.github.com/users/epernod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epernod/subscriptions","organizations_url":"https://api.github.com/users/epernod/orgs","repos_url":"https://api.github.com/users/epernod/repos","events_url":"https://api.github.com/users/epernod/events{/privacy}","received_events_url":"https://api.github.com/users/epernod/received_events","type":"User","site_admin":false},"repo":{"id":70585413,"node_id":"MDEwOlJlcG9zaXRvcnk3MDU4NTQxMw==","name":"sofa","full_name":"epernod/sofa","owner":{"login":"epernod","id":21199245,"node_id":"MDQ6VXNlcjIxMTk5MjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/21199245?v=4","gravatar_id":"","url":"https://api.github.com/users/epernod","html_url":"https://github.com/epernod","followers_url":"https://api.github.com/users/epernod/followers","following_url":"https://api.github.com/users/epernod/following{/other_user}","gists_url":"https://api.github.com/users/epernod/gists{/gist_id}","starred_url":"https://api.github.com/users/epernod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epernod/subscriptions","organizations_url":"https://api.github.com/users/epernod/orgs","repos_url":"https://api.github.com/users/epernod/repos","events_url":"https://api.github.com/users/epernod/events{/privacy}","received_events_url":"https://api.github.com/users/epernod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/epernod/sofa","description":"SOFA, open source framework for multi-physics simulation.","fork":true,"url":"https://api.github.com/repos/epernod/sofa","forks_url":"https://api.github.com/repos/epernod/sofa/forks","keys_url":"https://api.github.com/repos/epernod/sofa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epernod/sofa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epernod/sofa/teams","hooks_url":"https://api.github.com/repos/epernod/sofa/hooks","issue_events_url":"https://api.github.com/repos/epernod/sofa/issues/events{/number}","events_url":"https://api.github.com/repos/epernod/sofa/events","assignees_url":"https://api.github.com/repos/epernod/sofa/assignees{/user}","branches_url":"https://api.github.com/repos/epernod/sofa/branches{/branch}","tags_url":"https://api.github.com/repos/epernod/sofa/tags","blobs_url":"https://api.github.com/repos/epernod/sofa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epernod/sofa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epernod/sofa/git/refs{/sha}","trees_url":"https://api.github.com/repos/epernod/sofa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epernod/sofa/statuses/{sha}","languages_url":"https://api.github.com/repos/epernod/sofa/languages","stargazers_url":"https://api.github.com/repos/epernod/sofa/stargazers","contributors_url":"https://api.github.com/repos/epernod/sofa/contributors","subscribers_url":"https://api.github.com/repos/epernod/sofa/subscribers","subscription_url":"https://api.github.com/repos/epernod/sofa/subscription","commits_url":"https://api.github.com/repos/epernod/sofa/commits{/sha}","git_commits_url":"https://api.github.com/repos/epernod/sofa/git/commits{/sha}","comments_url":"https://api.github.com/repos/epernod/sofa/comments{/number}","issue_comment_url":"https://api.github.com/repos/epernod/sofa/issues/comments{/number}","contents_url":"https://api.github.com/repos/epernod/sofa/contents/{+path}","compare_url":"https://api.github.com/repos/epernod/sofa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epernod/sofa/merges","archive_url":"https://api.github.com/repos/epernod/sofa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epernod/sofa/downloads","issues_url":"https://api.github.com/repos/epernod/sofa/issues{/number}","pulls_url":"https://api.github.com/repos/epernod/sofa/pulls{/number}","milestones_url":"https://api.github.com/repos/epernod/sofa/milestones{/number}","notifications_url":"https://api.github.com/repos/epernod/sofa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epernod/sofa/labels{/name}","releases_url":"https://api.github.com/repos/epernod/sofa/releases{/id}","deployments_url":"https://api.github.com/repos/epernod/sofa/deployments","created_at":"2016-10-11T11:13:07Z","updated_at":"2018-04-18T08:32:36Z","pushed_at":"2018-05-30T23:51:33Z","git_url":"git://github.com/epernod/sofa.git","ssh_url":"git@github.com:epernod/sofa.git","clone_url":"https://github.com/epernod/sofa.git","svn_url":"https://github.com/epernod/sofa","homepage":"https://www.sofa-framework.org","size":310789,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sofa-framework:master","ref":"master","sha":"8667226f573015609775a9440711bc22db8fa359","user":{"login":"sofa-framework","id":11028508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDI4NTA4","avatar_url":"https://avatars2.githubusercontent.com/u/11028508?v=4","gravatar_id":"","url":"https://api.github.com/users/sofa-framework","html_url":"https://github.com/sofa-framework","followers_url":"https://api.github.com/users/sofa-framework/followers","following_url":"https://api.github.com/users/sofa-framework/following{/other_user}","gists_url":"https://api.github.com/users/sofa-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/sofa-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofa-framework/subscriptions","organizations_url":"https://api.github.com/users/sofa-framework/orgs","repos_url":"https://api.github.com/users/sofa-framework/repos","events_url":"https://api.github.com/users/sofa-framework/events{/privacy}","received_events_url":"https://api.github.com/users/sofa-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":60089478,"node_id":"MDEwOlJlcG9zaXRvcnk2MDA4OTQ3OA==","name":"sofa","full_name":"sofa-framework/sofa","owner":{"login":"sofa-framework","id":11028508,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDI4NTA4","avatar_url":"https://avatars2.githubusercontent.com/u/11028508?v=4","gravatar_id":"","url":"https://api.github.com/users/sofa-framework","html_url":"https://github.com/sofa-framework","followers_url":"https://api.github.com/users/sofa-framework/followers","following_url":"https://api.github.com/users/sofa-framework/following{/other_user}","gists_url":"https://api.github.com/users/sofa-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/sofa-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofa-framework/subscriptions","organizations_url":"https://api.github.com/users/sofa-framework/orgs","repos_url":"https://api.github.com/users/sofa-framework/repos","events_url":"https://api.github.com/users/sofa-framework/events{/privacy}","received_events_url":"https://api.github.com/users/sofa-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sofa-framework/sofa","description":"Real-time multi-physics simulation with an emphasis on medical simulation.","fork":false,"url":"https://api.github.com/repos/sofa-framework/sofa","forks_url":"https://api.github.com/repos/sofa-framework/sofa/forks","keys_url":"https://api.github.com/repos/sofa-framework/sofa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sofa-framework/sofa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sofa-framework/sofa/teams","hooks_url":"https://api.github.com/repos/sofa-framework/sofa/hooks","issue_events_url":"https://api.github.com/repos/sofa-framework/sofa/issues/events{/number}","events_url":"https://api.github.com/repos/sofa-framework/sofa/events","assignees_url":"https://api.github.com/repos/sofa-framework/sofa/assignees{/user}","branches_url":"https://api.github.com/repos/sofa-framework/sofa/branches{/branch}","tags_url":"https://api.github.com/repos/sofa-framework/sofa/tags","blobs_url":"https://api.github.com/repos/sofa-framework/sofa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sofa-framework/sofa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sofa-framework/sofa/git/refs{/sha}","trees_url":"https://api.github.com/repos/sofa-framework/sofa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sofa-framework/sofa/statuses/{sha}","languages_url":"https://api.github.com/repos/sofa-framework/sofa/languages","stargazers_url":"https://api.github.com/repos/sofa-framework/sofa/stargazers","contributors_url":"https://api.github.com/repos/sofa-framework/sofa/contributors","subscribers_url":"https://api.github.com/repos/sofa-framework/sofa/subscribers","subscription_url":"https://api.github.com/repos/sofa-framework/sofa/subscription","commits_url":"https://api.github.com/repos/sofa-framework/sofa/commits{/sha}","git_commits_url":"https://api.github.com/repos/sofa-framework/sofa/git/commits{/sha}","comments_url":"https://api.github.com/repos/sofa-framework/sofa/comments{/number}","issue_comment_url":"https://api.github.com/repos/sofa-framework/sofa/issues/comments{/number}","contents_url":"https://api.github.com/repos/sofa-framework/sofa/contents/{+path}","compare_url":"https://api.github.com/repos/sofa-framework/sofa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sofa-framework/sofa/merges","archive_url":"https://api.github.com/repos/sofa-framework/sofa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sofa-framework/sofa/downloads","issues_url":"https://api.github.com/repos/sofa-framework/sofa/issues{/number}","pulls_url":"https://api.github.com/repos/sofa-framework/sofa/pulls{/number}","milestones_url":"https://api.github.com/repos/sofa-framework/sofa/milestones{/number}","notifications_url":"https://api.github.com/repos/sofa-framework/sofa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sofa-framework/sofa/labels{/name}","releases_url":"https://api.github.com/repos/sofa-framework/sofa/releases{/id}","deployments_url":"https://api.github.com/repos/sofa-framework/sofa/deployments","created_at":"2016-05-31T12:57:59Z","updated_at":"2018-05-30T13:10:59Z","pushed_at":"2018-05-31T07:34:27Z","git_url":"git://github.com/sofa-framework/sofa.git","ssh_url":"git@github.com:sofa-framework/sofa.git","clone_url":"https://github.com/sofa-framework/sofa.git","svn_url":"https://github.com/sofa-framework/sofa","homepage":"https://www.sofa-framework.org","size":315064,"stargazers_count":162,"watchers_count":162,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":103,"license":null,"forks":98,"open_issues":103,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/638"},"html":{"href":"https://github.com/sofa-framework/sofa/pull/638"},"issue":{"href":"https://api.github.com/repos/sofa-framework/sofa/issues/638"},"comments":{"href":"https://api.github.com/repos/sofa-framework/sofa/issues/638/comments"},"review_comments":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/638/comments"},"review_comment":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/638/commits"},"statuses":{"href":"https://api.github.com/repos/sofa-framework/sofa/statuses/bb4e3d21bdba3ca633a866c69d019f56b28c3c7a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"damienmarchal","id":12644882,"node_id":"MDQ6VXNlcjEyNjQ0ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/12644882?v=4","gravatar_id":"","url":"https://api.github.com/users/damienmarchal","html_url":"https://github.com/damienmarchal","followers_url":"https://api.github.com/users/damienmarchal/followers","following_url":"https://api.github.com/users/damienmarchal/following{/other_user}","gists_url":"https://api.github.com/users/damienmarchal/gists{/gist_id}","starred_url":"https://api.github.com/users/damienmarchal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienmarchal/subscriptions","organizations_url":"https://api.github.com/users/damienmarchal/orgs","repos_url":"https://api.github.com/users/damienmarchal/repos","events_url":"https://api.github.com/users/damienmarchal/events{/privacy}","received_events_url":"https://api.github.com/users/damienmarchal/received_events","type":"User","site_admin":false},"comments":2,"review_comments":9,"maintainer_can_modify":false,"commits":30,"additions":52,"deletions":359,"changed_files":133}}
{"actor":{"display_login":"damienmarchal"}}