{"action":"created","issue":{"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/16825","repository_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp","labels_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/16825/labels{/name}","comments_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/16825/comments","events_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/16825/events","html_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/16825","id":302007055,"number":16825,"title":"Refactored Docker environment.","user":{"login":"otarza","id":1330491,"avatar_url":"https://avatars2.githubusercontent.com/u/1330491?v=4","gravatar_id":"","url":"https://api.github.com/users/otarza","html_url":"https://github.com/otarza","followers_url":"https://api.github.com/users/otarza/followers","following_url":"https://api.github.com/users/otarza/following{/other_user}","gists_url":"https://api.github.com/users/otarza/gists{/gist_id}","starred_url":"https://api.github.com/users/otarza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otarza/subscriptions","organizations_url":"https://api.github.com/users/otarza/orgs","repos_url":"https://api.github.com/users/otarza/repos","events_url":"https://api.github.com/users/otarza/events{/privacy}","received_events_url":"https://api.github.com/users/otarza/received_events","type":"User","site_admin":false},"labels":[{"id":199856930,"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/labels/status:%20ready%20for%20QA","name":"status: ready for QA","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-03-03T15:32:02Z","updated_at":"2018-03-16T00:49:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/16825","html_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/16825","diff_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/16825.diff","patch_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/16825.patch"},"body":"docker-compose.yml renamed to sample.docker-compose.yml.\r\ndocker-compose.yml added to .gitignore so every developer can copy it from sample.docker-compose.yml and make changes according to their local needs.\r\n\r\ndocs(Docker): Updated docs for Docker install.\r\nAdded Docker specific installation instructions.\r\n\r\n<!-- freeCodeCamp Pull Request Template -->\r\n\r\n<!-- IMPORTANT Please review https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/CONTRIBUTING.md for detailed contributing guidelines -->\r\n<!-- Help with PRs can be found at https://gitter.im/FreeCodeCamp/Contributors -->\r\n<!-- Make sure that your PR is not a duplicate -->\r\n\r\n#### Pre-Submission Checklist\r\n<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply. -->\r\n<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->\r\n<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] Your pull request targets the `staging` branch of freeCodeCamp.\r\n- [x] Branch starts with either `fix/`, `feature/`, or `translate/` (e.g. `fix/signin-issue`)\r\n- [x] You have only one commit (if not, [squash](http://forum.freecodecamp.org/t/how-to-squash-multiple-commits-into-one-with-git/13231) them into one commit).\r\n- [x] All new and existing tests pass the command `npm test`. Use `git commit --amend` to amend any fixes.\r\n\r\n#### Type of Change\r\n<!-- What type of change does your code introduce? After creating the PR, tick the checkboxes that apply. -->\r\n- [x] Small bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds new functionality)\r\n- [ ] Breaking change (fix or feature that would change existing functionality)\r\n- [ ] Add new translation (feature adding new translations)\r\n\r\n#### Checklist:\r\n<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply. -->\r\n<!-- If you're unsure about any of these, don't hesitate to ask in the Contributors room linked above. We're here to help! -->\r\n- [x] Tested changes locally.\r\n- [x] Addressed currently open issue (replace XXXXX with an issue no in next line)\r\n\r\nCloses #16642\r\n\r\n#### Description\r\n<!-- Describe your changes in detail -->\r\n"},"comment":{"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/comments/373568474","html_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/16825#issuecomment-373568474","issue_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/16825","id":373568474,"user":{"login":"ojongerius","id":1726055,"avatar_url":"https://avatars0.githubusercontent.com/u/1726055?v=4","gravatar_id":"","url":"https://api.github.com/users/ojongerius","html_url":"https://github.com/ojongerius","followers_url":"https://api.github.com/users/ojongerius/followers","following_url":"https://api.github.com/users/ojongerius/following{/other_user}","gists_url":"https://api.github.com/users/ojongerius/gists{/gist_id}","starred_url":"https://api.github.com/users/ojongerius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojongerius/subscriptions","organizations_url":"https://api.github.com/users/ojongerius/orgs","repos_url":"https://api.github.com/users/ojongerius/repos","events_url":"https://api.github.com/users/ojongerius/events{/privacy}","received_events_url":"https://api.github.com/users/ojongerius/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T00:49:32Z","updated_at":"2018-03-16T00:49:32Z","author_association":"NONE","body":"Hey there, great work so far 😺  \r\n\r\nI'm sceptical of the strategy of having a sample file, and adding the Docker Compose file to .gitignore.\r\nWhat were the use cases you had in mind that made you chose this solution?\r\nCould those cases be solved by using an override file (`docker-compose.override.yml`)? If so I'd suggest keeping a default `docker-compose.yml`, and adding `docker-compose-override.yml` to `.gitignore`.\r\n\r\nThoughts?"}}
{"actor":{"display_login":"ojongerius"}}