{"action":"created","comment":{"url":"https://api.github.com/repos/emersion/mako/pulls/comments/187485009","pull_request_review_id":119277437,"id":187485009,"diff_hunk":"@@ -28,6 +28,11 @@ int render(struct mako_state *state, struct pool_buffer *buffer) {\n \tint border_size = 2 * config->border_size;\n \tint padding_size = 2 * config->padding;\n \n+    int inner_margin = config->margin.top;\n+    if (config->margin.bottom > config->margin.top) {\n+        inner_margin = config->margin.bottom;\n+    }","path":"render.c","position":null,"original_position":7,"commit_id":"4056deba3c72a9914334e57786aa6fda421fb5f6","original_commit_id":"c94982af9a960a77d4d2d95e28748e08288d027a","user":{"login":"vilhalmer","id":201439,"avatar_url":"https://avatars0.githubusercontent.com/u/201439?v=4","gravatar_id":"","url":"https://api.github.com/users/vilhalmer","html_url":"https://github.com/vilhalmer","followers_url":"https://api.github.com/users/vilhalmer/followers","following_url":"https://api.github.com/users/vilhalmer/following{/other_user}","gists_url":"https://api.github.com/users/vilhalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/vilhalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilhalmer/subscriptions","organizations_url":"https://api.github.com/users/vilhalmer/orgs","repos_url":"https://api.github.com/users/vilhalmer/repos","events_url":"https://api.github.com/users/vilhalmer/events{/privacy}","received_events_url":"https://api.github.com/users/vilhalmer/received_events","type":"User","site_admin":false},"body":"I installed vim-sleuth so this will hopefully stop happening. :)","created_at":"2018-05-10T23:13:15Z","updated_at":"2018-05-10T23:13:15Z","html_url":"https://github.com/emersion/mako/pull/16#discussion_r187485009","pull_request_url":"https://api.github.com/repos/emersion/mako/pulls/16","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/emersion/mako/pulls/comments/187485009"},"html":{"href":"https://github.com/emersion/mako/pull/16#discussion_r187485009"},"pull_request":{"href":"https://api.github.com/repos/emersion/mako/pulls/16"}},"in_reply_to_id":187279783},"pull_request":{"url":"https://api.github.com/repos/emersion/mako/pulls/16","id":186783074,"html_url":"https://github.com/emersion/mako/pull/16","diff_url":"https://github.com/emersion/mako/pull/16.diff","patch_url":"https://github.com/emersion/mako/pull/16.patch","issue_url":"https://api.github.com/repos/emersion/mako/issues/16","number":16,"state":"open","locked":false,"title":"Allow margin to be specified per direction","user":{"login":"vilhalmer","id":201439,"avatar_url":"https://avatars0.githubusercontent.com/u/201439?v=4","gravatar_id":"","url":"https://api.github.com/users/vilhalmer","html_url":"https://github.com/vilhalmer","followers_url":"https://api.github.com/users/vilhalmer/followers","following_url":"https://api.github.com/users/vilhalmer/following{/other_user}","gists_url":"https://api.github.com/users/vilhalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/vilhalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilhalmer/subscriptions","organizations_url":"https://api.github.com/users/vilhalmer/orgs","repos_url":"https://api.github.com/users/vilhalmer/repos","events_url":"https://api.github.com/users/vilhalmer/events{/privacy}","received_events_url":"https://api.github.com/users/vilhalmer/received_events","type":"User","site_admin":false},"body":"This adds CSS-style margin syntax parsing. That is, you can provide up to four values to `--margin`, comma-separated. A single value specifies all directions, two specify vertical/horizontal, three specify top/horizontal/bottom, and four specify top/right/bottom/left. This might be overkill, it's up to you if you want to have all four modes or cut out the third.\r\n\r\nLet me know what you think! If you like this, I'd also plan on adding this to `--padding`, and doing an option to change the anchor corner. Also, my C was a bit rusty so there might be a few things that are suboptimal.","created_at":"2018-05-08T23:37:28Z","updated_at":"2018-05-10T23:13:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2fe178735724245740e6a3fa88d1c5de9889f11","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emersion/mako/pulls/16/commits","review_comments_url":"https://api.github.com/repos/emersion/mako/pulls/16/comments","review_comment_url":"https://api.github.com/repos/emersion/mako/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emersion/mako/issues/16/comments","statuses_url":"https://api.github.com/repos/emersion/mako/statuses/4056deba3c72a9914334e57786aa6fda421fb5f6","head":{"label":"vilhalmer:directional-margins","ref":"directional-margins","sha":"4056deba3c72a9914334e57786aa6fda421fb5f6","user":{"login":"vilhalmer","id":201439,"avatar_url":"https://avatars0.githubusercontent.com/u/201439?v=4","gravatar_id":"","url":"https://api.github.com/users/vilhalmer","html_url":"https://github.com/vilhalmer","followers_url":"https://api.github.com/users/vilhalmer/followers","following_url":"https://api.github.com/users/vilhalmer/following{/other_user}","gists_url":"https://api.github.com/users/vilhalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/vilhalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilhalmer/subscriptions","organizations_url":"https://api.github.com/users/vilhalmer/orgs","repos_url":"https://api.github.com/users/vilhalmer/repos","events_url":"https://api.github.com/users/vilhalmer/events{/privacy}","received_events_url":"https://api.github.com/users/vilhalmer/received_events","type":"User","site_admin":false},"repo":{"id":132676151,"name":"mako","full_name":"vilhalmer/mako","owner":{"login":"vilhalmer","id":201439,"avatar_url":"https://avatars0.githubusercontent.com/u/201439?v=4","gravatar_id":"","url":"https://api.github.com/users/vilhalmer","html_url":"https://github.com/vilhalmer","followers_url":"https://api.github.com/users/vilhalmer/followers","following_url":"https://api.github.com/users/vilhalmer/following{/other_user}","gists_url":"https://api.github.com/users/vilhalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/vilhalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilhalmer/subscriptions","organizations_url":"https://api.github.com/users/vilhalmer/orgs","repos_url":"https://api.github.com/users/vilhalmer/repos","events_url":"https://api.github.com/users/vilhalmer/events{/privacy}","received_events_url":"https://api.github.com/users/vilhalmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vilhalmer/mako","description":"A lightweight Wayland notification daemon","fork":true,"url":"https://api.github.com/repos/vilhalmer/mako","forks_url":"https://api.github.com/repos/vilhalmer/mako/forks","keys_url":"https://api.github.com/repos/vilhalmer/mako/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vilhalmer/mako/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vilhalmer/mako/teams","hooks_url":"https://api.github.com/repos/vilhalmer/mako/hooks","issue_events_url":"https://api.github.com/repos/vilhalmer/mako/issues/events{/number}","events_url":"https://api.github.com/repos/vilhalmer/mako/events","assignees_url":"https://api.github.com/repos/vilhalmer/mako/assignees{/user}","branches_url":"https://api.github.com/repos/vilhalmer/mako/branches{/branch}","tags_url":"https://api.github.com/repos/vilhalmer/mako/tags","blobs_url":"https://api.github.com/repos/vilhalmer/mako/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vilhalmer/mako/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vilhalmer/mako/git/refs{/sha}","trees_url":"https://api.github.com/repos/vilhalmer/mako/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vilhalmer/mako/statuses/{sha}","languages_url":"https://api.github.com/repos/vilhalmer/mako/languages","stargazers_url":"https://api.github.com/repos/vilhalmer/mako/stargazers","contributors_url":"https://api.github.com/repos/vilhalmer/mako/contributors","subscribers_url":"https://api.github.com/repos/vilhalmer/mako/subscribers","subscription_url":"https://api.github.com/repos/vilhalmer/mako/subscription","commits_url":"https://api.github.com/repos/vilhalmer/mako/commits{/sha}","git_commits_url":"https://api.github.com/repos/vilhalmer/mako/git/commits{/sha}","comments_url":"https://api.github.com/repos/vilhalmer/mako/comments{/number}","issue_comment_url":"https://api.github.com/repos/vilhalmer/mako/issues/comments{/number}","contents_url":"https://api.github.com/repos/vilhalmer/mako/contents/{+path}","compare_url":"https://api.github.com/repos/vilhalmer/mako/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vilhalmer/mako/merges","archive_url":"https://api.github.com/repos/vilhalmer/mako/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vilhalmer/mako/downloads","issues_url":"https://api.github.com/repos/vilhalmer/mako/issues{/number}","pulls_url":"https://api.github.com/repos/vilhalmer/mako/pulls{/number}","milestones_url":"https://api.github.com/repos/vilhalmer/mako/milestones{/number}","notifications_url":"https://api.github.com/repos/vilhalmer/mako/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vilhalmer/mako/labels{/name}","releases_url":"https://api.github.com/repos/vilhalmer/mako/releases{/id}","deployments_url":"https://api.github.com/repos/vilhalmer/mako/deployments","created_at":"2018-05-08T23:29:39Z","updated_at":"2018-05-10T00:10:01Z","pushed_at":"2018-05-10T23:12:50Z","git_url":"git://github.com/vilhalmer/mako.git","ssh_url":"git@github.com:vilhalmer/mako.git","clone_url":"https://github.com/vilhalmer/mako.git","svn_url":"https://github.com/vilhalmer/mako","homepage":"","size":130,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emersion:master","ref":"master","sha":"325055701405242a644486e1f313cf4bf9daf020","user":{"login":"emersion","id":506932,"avatar_url":"https://avatars1.githubusercontent.com/u/506932?v=4","gravatar_id":"","url":"https://api.github.com/users/emersion","html_url":"https://github.com/emersion","followers_url":"https://api.github.com/users/emersion/followers","following_url":"https://api.github.com/users/emersion/following{/other_user}","gists_url":"https://api.github.com/users/emersion/gists{/gist_id}","starred_url":"https://api.github.com/users/emersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emersion/subscriptions","organizations_url":"https://api.github.com/users/emersion/orgs","repos_url":"https://api.github.com/users/emersion/repos","events_url":"https://api.github.com/users/emersion/events{/privacy}","received_events_url":"https://api.github.com/users/emersion/received_events","type":"User","site_admin":false},"repo":{"id":130588871,"name":"mako","full_name":"emersion/mako","owner":{"login":"emersion","id":506932,"avatar_url":"https://avatars1.githubusercontent.com/u/506932?v=4","gravatar_id":"","url":"https://api.github.com/users/emersion","html_url":"https://github.com/emersion","followers_url":"https://api.github.com/users/emersion/followers","following_url":"https://api.github.com/users/emersion/following{/other_user}","gists_url":"https://api.github.com/users/emersion/gists{/gist_id}","starred_url":"https://api.github.com/users/emersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emersion/subscriptions","organizations_url":"https://api.github.com/users/emersion/orgs","repos_url":"https://api.github.com/users/emersion/repos","events_url":"https://api.github.com/users/emersion/events{/privacy}","received_events_url":"https://api.github.com/users/emersion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emersion/mako","description":"A lightweight Wayland notification daemon","fork":false,"url":"https://api.github.com/repos/emersion/mako","forks_url":"https://api.github.com/repos/emersion/mako/forks","keys_url":"https://api.github.com/repos/emersion/mako/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emersion/mako/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emersion/mako/teams","hooks_url":"https://api.github.com/repos/emersion/mako/hooks","issue_events_url":"https://api.github.com/repos/emersion/mako/issues/events{/number}","events_url":"https://api.github.com/repos/emersion/mako/events","assignees_url":"https://api.github.com/repos/emersion/mako/assignees{/user}","branches_url":"https://api.github.com/repos/emersion/mako/branches{/branch}","tags_url":"https://api.github.com/repos/emersion/mako/tags","blobs_url":"https://api.github.com/repos/emersion/mako/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emersion/mako/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emersion/mako/git/refs{/sha}","trees_url":"https://api.github.com/repos/emersion/mako/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emersion/mako/statuses/{sha}","languages_url":"https://api.github.com/repos/emersion/mako/languages","stargazers_url":"https://api.github.com/repos/emersion/mako/stargazers","contributors_url":"https://api.github.com/repos/emersion/mako/contributors","subscribers_url":"https://api.github.com/repos/emersion/mako/subscribers","subscription_url":"https://api.github.com/repos/emersion/mako/subscription","commits_url":"https://api.github.com/repos/emersion/mako/commits{/sha}","git_commits_url":"https://api.github.com/repos/emersion/mako/git/commits{/sha}","comments_url":"https://api.github.com/repos/emersion/mako/comments{/number}","issue_comment_url":"https://api.github.com/repos/emersion/mako/issues/comments{/number}","contents_url":"https://api.github.com/repos/emersion/mako/contents/{+path}","compare_url":"https://api.github.com/repos/emersion/mako/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emersion/mako/merges","archive_url":"https://api.github.com/repos/emersion/mako/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emersion/mako/downloads","issues_url":"https://api.github.com/repos/emersion/mako/issues{/number}","pulls_url":"https://api.github.com/repos/emersion/mako/pulls{/number}","milestones_url":"https://api.github.com/repos/emersion/mako/milestones{/number}","notifications_url":"https://api.github.com/repos/emersion/mako/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emersion/mako/labels{/name}","releases_url":"https://api.github.com/repos/emersion/mako/releases{/id}","deployments_url":"https://api.github.com/repos/emersion/mako/deployments","created_at":"2018-04-22T17:05:22Z","updated_at":"2018-05-10T21:21:08Z","pushed_at":"2018-05-10T23:12:51Z","git_url":"git://github.com/emersion/mako.git","ssh_url":"git@github.com:emersion/mako.git","clone_url":"https://github.com/emersion/mako.git","svn_url":"https://github.com/emersion/mako","homepage":"https://mako-project.org/","size":122,"stargazers_count":34,"watchers_count":34,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":7,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emersion/mako/pulls/16"},"html":{"href":"https://github.com/emersion/mako/pull/16"},"issue":{"href":"https://api.github.com/repos/emersion/mako/issues/16"},"comments":{"href":"https://api.github.com/repos/emersion/mako/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/emersion/mako/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/emersion/mako/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emersion/mako/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/emersion/mako/statuses/4056deba3c72a9914334e57786aa6fda421fb5f6"}},"author_association":"NONE"}}
{"actor":{"display_login":"vilhalmer"}}