{"action":"created","comment":{"url":"https://api.github.com/repos/iov-one/iov-core/pulls/comments/234989062","pull_request_review_id":176749138,"id":234989062,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDk4OTA2Mg==","diff_hunk":"@@ -188,6 +188,197 @@ function kvTestSuite(rpcFactory: () => RpcClient): void {\n   });\n }\n \n+function websocketTestSuite(rpcFactory: () => RpcClient, adaptor: Adaptor): void {\n+  // don't print out WebSocket errors if marked pending\n+  kvTestSuite(rpcFactory, adaptor);\n+\n+  it(\"can subscribe to block header events\", done => {\n+    pendingWithoutTendermint();\n+\n+    // seems that tendermint just guarantees within the last second for timestamp\n+    const testStart = ReadonlyDate.now() - 1000;","path":"packages/iov-tendermint-rpc/src/client.spec.ts","position":82,"original_position":82,"commit_id":"dceaaf3cdd7578706d92c398a4ee5a87a3eb1888","original_commit_id":"dceaaf3cdd7578706d92c398a4ee5a87a3eb1888","user":{"login":"ethanfrey","id":5689864,"node_id":"MDQ6VXNlcjU2ODk4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5689864?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanfrey","html_url":"https://github.com/ethanfrey","followers_url":"https://api.github.com/users/ethanfrey/followers","following_url":"https://api.github.com/users/ethanfrey/following{/other_user}","gists_url":"https://api.github.com/users/ethanfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanfrey/subscriptions","organizations_url":"https://api.github.com/users/ethanfrey/orgs","repos_url":"https://api.github.com/users/ethanfrey/repos","events_url":"https://api.github.com/users/ethanfrey/events{/privacy}","received_events_url":"https://api.github.com/users/ethanfrey/received_events","type":"User","site_admin":false},"body":"Nice","created_at":"2018-11-20T12:51:33Z","updated_at":"2018-11-20T12:51:34Z","html_url":"https://github.com/iov-one/iov-core/pull/539#discussion_r234989062","pull_request_url":"https://api.github.com/repos/iov-one/iov-core/pulls/539","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/comments/234989062"},"html":{"href":"https://github.com/iov-one/iov-core/pull/539#discussion_r234989062"},"pull_request":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/539"}},"in_reply_to_id":234942079},"pull_request":{"url":"https://api.github.com/repos/iov-one/iov-core/pulls/539","id":231612330,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjEyMzMw","html_url":"https://github.com/iov-one/iov-core/pull/539","diff_url":"https://github.com/iov-one/iov-core/pull/539.diff","patch_url":"https://github.com/iov-one/iov-core/pull/539.patch","issue_url":"https://api.github.com/repos/iov-one/iov-core/issues/539","number":539,"state":"open","locked":false,"title":"Add support for tendermint 0.25","user":{"login":"ethanfrey","id":5689864,"node_id":"MDQ6VXNlcjU2ODk4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5689864?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanfrey","html_url":"https://github.com/ethanfrey","followers_url":"https://api.github.com/users/ethanfrey/followers","following_url":"https://api.github.com/users/ethanfrey/following{/other_user}","gists_url":"https://api.github.com/users/ethanfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanfrey/subscriptions","organizations_url":"https://api.github.com/users/ethanfrey/orgs","repos_url":"https://api.github.com/users/ethanfrey/repos","events_url":"https://api.github.com/users/ethanfrey/events{/privacy}","received_events_url":"https://api.github.com/users/ethanfrey/received_events","type":"User","site_admin":false},"body":"Closes #295 \r\n\r\n- [x] Update request formatting (integers as strings)\r\n- [x] Update response formatting (quite a bit)\r\n- [x] Test compatibility with basic tendermint rpc kvstore\r\n","created_at":"2018-11-16T18:06:07Z","updated_at":"2018-11-20T12:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fe4f6854804a5ccc5064412d561bacafd6d8a88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iov-one/iov-core/pulls/539/commits","review_comments_url":"https://api.github.com/repos/iov-one/iov-core/pulls/539/comments","review_comment_url":"https://api.github.com/repos/iov-one/iov-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iov-one/iov-core/issues/539/comments","statuses_url":"https://api.github.com/repos/iov-one/iov-core/statuses/dceaaf3cdd7578706d92c398a4ee5a87a3eb1888","head":{"label":"iov-one:tendermint-0.25-support","ref":"tendermint-0.25-support","sha":"dceaaf3cdd7578706d92c398a4ee5a87a3eb1888","user":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"repo":{"id":129950372,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5NTAzNzI=","name":"iov-core","full_name":"iov-one/iov-core","private":false,"owner":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iov-one/iov-core","description":"Client library for secure key management and multi-blockchain communication","fork":false,"url":"https://api.github.com/repos/iov-one/iov-core","forks_url":"https://api.github.com/repos/iov-one/iov-core/forks","keys_url":"https://api.github.com/repos/iov-one/iov-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iov-one/iov-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iov-one/iov-core/teams","hooks_url":"https://api.github.com/repos/iov-one/iov-core/hooks","issue_events_url":"https://api.github.com/repos/iov-one/iov-core/issues/events{/number}","events_url":"https://api.github.com/repos/iov-one/iov-core/events","assignees_url":"https://api.github.com/repos/iov-one/iov-core/assignees{/user}","branches_url":"https://api.github.com/repos/iov-one/iov-core/branches{/branch}","tags_url":"https://api.github.com/repos/iov-one/iov-core/tags","blobs_url":"https://api.github.com/repos/iov-one/iov-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iov-one/iov-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iov-one/iov-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/iov-one/iov-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iov-one/iov-core/statuses/{sha}","languages_url":"https://api.github.com/repos/iov-one/iov-core/languages","stargazers_url":"https://api.github.com/repos/iov-one/iov-core/stargazers","contributors_url":"https://api.github.com/repos/iov-one/iov-core/contributors","subscribers_url":"https://api.github.com/repos/iov-one/iov-core/subscribers","subscription_url":"https://api.github.com/repos/iov-one/iov-core/subscription","commits_url":"https://api.github.com/repos/iov-one/iov-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/iov-one/iov-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/iov-one/iov-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/iov-one/iov-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/iov-one/iov-core/contents/{+path}","compare_url":"https://api.github.com/repos/iov-one/iov-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iov-one/iov-core/merges","archive_url":"https://api.github.com/repos/iov-one/iov-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iov-one/iov-core/downloads","issues_url":"https://api.github.com/repos/iov-one/iov-core/issues{/number}","pulls_url":"https://api.github.com/repos/iov-one/iov-core/pulls{/number}","milestones_url":"https://api.github.com/repos/iov-one/iov-core/milestones{/number}","notifications_url":"https://api.github.com/repos/iov-one/iov-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iov-one/iov-core/labels{/name}","releases_url":"https://api.github.com/repos/iov-one/iov-core/releases{/id}","deployments_url":"https://api.github.com/repos/iov-one/iov-core/deployments","created_at":"2018-04-17T18:46:16Z","updated_at":"2018-11-20T11:28:45Z","pushed_at":"2018-11-20T11:28:45Z","git_url":"git://github.com/iov-one/iov-core.git","ssh_url":"git@github.com:iov-one/iov-core.git","clone_url":"https://github.com/iov-one/iov-core.git","svn_url":"https://github.com/iov-one/iov-core","homepage":"https://iov-one.github.io/iov-core-docs/","size":3808,"stargazers_count":174,"watchers_count":174,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":54,"watchers":174,"default_branch":"master"}},"base":{"label":"iov-one:master","ref":"master","sha":"7059a0e0c0b419f66ee920124efc5ccf0d75b93c","user":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"repo":{"id":129950372,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5NTAzNzI=","name":"iov-core","full_name":"iov-one/iov-core","private":false,"owner":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iov-one/iov-core","description":"Client library for secure key management and multi-blockchain communication","fork":false,"url":"https://api.github.com/repos/iov-one/iov-core","forks_url":"https://api.github.com/repos/iov-one/iov-core/forks","keys_url":"https://api.github.com/repos/iov-one/iov-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iov-one/iov-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iov-one/iov-core/teams","hooks_url":"https://api.github.com/repos/iov-one/iov-core/hooks","issue_events_url":"https://api.github.com/repos/iov-one/iov-core/issues/events{/number}","events_url":"https://api.github.com/repos/iov-one/iov-core/events","assignees_url":"https://api.github.com/repos/iov-one/iov-core/assignees{/user}","branches_url":"https://api.github.com/repos/iov-one/iov-core/branches{/branch}","tags_url":"https://api.github.com/repos/iov-one/iov-core/tags","blobs_url":"https://api.github.com/repos/iov-one/iov-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iov-one/iov-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iov-one/iov-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/iov-one/iov-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iov-one/iov-core/statuses/{sha}","languages_url":"https://api.github.com/repos/iov-one/iov-core/languages","stargazers_url":"https://api.github.com/repos/iov-one/iov-core/stargazers","contributors_url":"https://api.github.com/repos/iov-one/iov-core/contributors","subscribers_url":"https://api.github.com/repos/iov-one/iov-core/subscribers","subscription_url":"https://api.github.com/repos/iov-one/iov-core/subscription","commits_url":"https://api.github.com/repos/iov-one/iov-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/iov-one/iov-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/iov-one/iov-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/iov-one/iov-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/iov-one/iov-core/contents/{+path}","compare_url":"https://api.github.com/repos/iov-one/iov-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iov-one/iov-core/merges","archive_url":"https://api.github.com/repos/iov-one/iov-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iov-one/iov-core/downloads","issues_url":"https://api.github.com/repos/iov-one/iov-core/issues{/number}","pulls_url":"https://api.github.com/repos/iov-one/iov-core/pulls{/number}","milestones_url":"https://api.github.com/repos/iov-one/iov-core/milestones{/number}","notifications_url":"https://api.github.com/repos/iov-one/iov-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iov-one/iov-core/labels{/name}","releases_url":"https://api.github.com/repos/iov-one/iov-core/releases{/id}","deployments_url":"https://api.github.com/repos/iov-one/iov-core/deployments","created_at":"2018-04-17T18:46:16Z","updated_at":"2018-11-20T11:28:45Z","pushed_at":"2018-11-20T11:28:45Z","git_url":"git://github.com/iov-one/iov-core.git","ssh_url":"git@github.com:iov-one/iov-core.git","clone_url":"https://github.com/iov-one/iov-core.git","svn_url":"https://github.com/iov-one/iov-core","homepage":"https://iov-one.github.io/iov-core-docs/","size":3808,"stargazers_count":174,"watchers_count":174,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":54,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/539"},"html":{"href":"https://github.com/iov-one/iov-core/pull/539"},"issue":{"href":"https://api.github.com/repos/iov-one/iov-core/issues/539"},"comments":{"href":"https://api.github.com/repos/iov-one/iov-core/issues/539/comments"},"review_comments":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/539/comments"},"review_comment":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/539/commits"},"statuses":{"href":"https://api.github.com/repos/iov-one/iov-core/statuses/dceaaf3cdd7578706d92c398a4ee5a87a3eb1888"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ethanfrey"}}