{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/console/pulls/comments/201471066","pull_request_review_id":135980817,"id":201471066,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQ3MTA2Ng==","diff_hunk":"@@ -0,0 +1,46 @@\n+FROM openshift/origin-base\n+\n+ENV GOPATH=/go\n+\n+RUN mkdir -p /go/src/github.com/openshift/console/\n+ADD . /go/src/github.com/openshift/console/\n+WORKDIR /go/src/github.com/openshift/console/\n+ADD etc/ssl /etc/ssl\n+\n+# TODO: Switch to multistage builds as soon as we can.\n+#\n+# Multi stage builds are not yet supported for product builds. For now, install\n+# dependencies and do our best to clean up after building.\n+#\n+# Node.js 8+ is required, but EPEL only has Node.js 6.\n+#\n+# `rm -rf /tmp/*` is needed to remove chromedriver and other temporary files\n+# created while building frontend assets.\n+\n+RUN curl --silent --location https://rpm.nodesource.com/setup_8.x | bash - && \\\n+    curl --silent --location https://dl.yarnpkg.com/rpm/yarn.repo | tee /etc/yum.repos.d/yarn.repo && \\\n+    INSTALL_PKGS=\"git golang nodejs yarn\" && \\","path":"Dockerfile.product","position":22,"original_position":22,"commit_id":"cf7923694332361f745f4cd0f1ccb3fb66d59988","original_commit_id":"cf7923694332361f745f4cd0f1ccb3fb66d59988","user":{"login":"sosiouxme","id":29690,"node_id":"MDQ6VXNlcjI5Njkw","avatar_url":"https://avatars1.githubusercontent.com/u/29690?v=4","gravatar_id":"","url":"https://api.github.com/users/sosiouxme","html_url":"https://github.com/sosiouxme","followers_url":"https://api.github.com/users/sosiouxme/followers","following_url":"https://api.github.com/users/sosiouxme/following{/other_user}","gists_url":"https://api.github.com/users/sosiouxme/gists{/gist_id}","starred_url":"https://api.github.com/users/sosiouxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosiouxme/subscriptions","organizations_url":"https://api.github.com/users/sosiouxme/orgs","repos_url":"https://api.github.com/users/sosiouxme/repos","events_url":"https://api.github.com/users/sosiouxme/events{/privacy}","received_events_url":"https://api.github.com/users/sosiouxme/received_events","type":"User","site_admin":false},"body":"Working on a scheme to ease the go-toolset-7 transition. As for the other tools, I'd say we should look for internal builds ASAP, but it need not hold up this PR.","created_at":"2018-07-10T19:47:36Z","updated_at":"2018-07-10T19:47:37Z","html_url":"https://github.com/openshift/console/pull/173#discussion_r201471066","pull_request_url":"https://api.github.com/repos/openshift/console/pulls/173","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/comments/201471066"},"html":{"href":"https://github.com/openshift/console/pull/173#discussion_r201471066"},"pull_request":{"href":"https://api.github.com/repos/openshift/console/pulls/173"}},"in_reply_to_id":198694608},"pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/173","id":197586926,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTg2OTI2","html_url":"https://github.com/openshift/console/pull/173","diff_url":"https://github.com/openshift/console/pull/173.diff","patch_url":"https://github.com/openshift/console/pull/173.patch","issue_url":"https://api.github.com/repos/openshift/console/issues/173","number":173,"state":"open","locked":false,"title":"[WIP] Add Dockerfile.product","user":{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"This Dockerfile is a bit crazy, but avoids multi stage builds. It results in a final image that is about twice the size of the one built using https://github.com/openshift/console/blob/master/Dockerfile\r\n\r\nBest I can tell the culprit is\r\n\r\n```\r\nADD . /go/src/github.com/openshift/console/\r\n```\r\n\r\nwhich creates a 178MB layer and bloats the final image size even if `rm -rf /go` is called later. Maybe we can squash the layers.\r\n\r\nWill this work? Let me know if there is a better way.\r\n\r\n/cc @adammhaile @sosiouxme \r\n/hold\r\n\r\n@jwforres FYI","created_at":"2018-06-27T00:30:47Z","updated_at":"2018-07-10T19:47:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ff674193d1c0dd074a7cf8ceef8a99fde09b8de","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adammhaile","id":957162,"node_id":"MDQ6VXNlcjk1NzE2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/957162?v=4","gravatar_id":"","url":"https://api.github.com/users/adammhaile","html_url":"https://github.com/adammhaile","followers_url":"https://api.github.com/users/adammhaile/followers","following_url":"https://api.github.com/users/adammhaile/following{/other_user}","gists_url":"https://api.github.com/users/adammhaile/gists{/gist_id}","starred_url":"https://api.github.com/users/adammhaile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammhaile/subscriptions","organizations_url":"https://api.github.com/users/adammhaile/orgs","repos_url":"https://api.github.com/users/adammhaile/repos","events_url":"https://api.github.com/users/adammhaile/events{/privacy}","received_events_url":"https://api.github.com/users/adammhaile/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":926926285,"node_id":"MDU6TGFiZWw5MjY5MjYyODU=","url":"https://api.github.com/repos/openshift/console/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":926924641,"node_id":"MDU6TGFiZWw5MjY5MjQ2NDE=","url":"https://api.github.com/repos/openshift/console/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":926923478,"node_id":"MDU6TGFiZWw5MjY5MjM0Nzg=","url":"https://api.github.com/repos/openshift/console/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/console/pulls/173/commits","review_comments_url":"https://api.github.com/repos/openshift/console/pulls/173/comments","review_comment_url":"https://api.github.com/repos/openshift/console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/console/issues/173/comments","statuses_url":"https://api.github.com/repos/openshift/console/statuses/cf7923694332361f745f4cd0f1ccb3fb66d59988","head":{"label":"spadgett:dockerfile-product","ref":"dockerfile-product","sha":"cf7923694332361f745f4cd0f1ccb3fb66d59988","user":{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"repo":{"id":133148407,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxNDg0MDc=","name":"console","full_name":"spadgett/console","owner":{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spadgett/console","description":"Tectonic Console UI","fork":true,"url":"https://api.github.com/repos/spadgett/console","forks_url":"https://api.github.com/repos/spadgett/console/forks","keys_url":"https://api.github.com/repos/spadgett/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spadgett/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spadgett/console/teams","hooks_url":"https://api.github.com/repos/spadgett/console/hooks","issue_events_url":"https://api.github.com/repos/spadgett/console/issues/events{/number}","events_url":"https://api.github.com/repos/spadgett/console/events","assignees_url":"https://api.github.com/repos/spadgett/console/assignees{/user}","branches_url":"https://api.github.com/repos/spadgett/console/branches{/branch}","tags_url":"https://api.github.com/repos/spadgett/console/tags","blobs_url":"https://api.github.com/repos/spadgett/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spadgett/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spadgett/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/spadgett/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spadgett/console/statuses/{sha}","languages_url":"https://api.github.com/repos/spadgett/console/languages","stargazers_url":"https://api.github.com/repos/spadgett/console/stargazers","contributors_url":"https://api.github.com/repos/spadgett/console/contributors","subscribers_url":"https://api.github.com/repos/spadgett/console/subscribers","subscription_url":"https://api.github.com/repos/spadgett/console/subscription","commits_url":"https://api.github.com/repos/spadgett/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/spadgett/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/spadgett/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/spadgett/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/spadgett/console/contents/{+path}","compare_url":"https://api.github.com/repos/spadgett/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spadgett/console/merges","archive_url":"https://api.github.com/repos/spadgett/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spadgett/console/downloads","issues_url":"https://api.github.com/repos/spadgett/console/issues{/number}","pulls_url":"https://api.github.com/repos/spadgett/console/pulls{/number}","milestones_url":"https://api.github.com/repos/spadgett/console/milestones{/number}","notifications_url":"https://api.github.com/repos/spadgett/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spadgett/console/labels{/name}","releases_url":"https://api.github.com/repos/spadgett/console/releases{/id}","deployments_url":"https://api.github.com/repos/spadgett/console/deployments","created_at":"2018-05-12T13:24:35Z","updated_at":"2018-07-10T16:02:51Z","pushed_at":"2018-07-10T16:04:21Z","git_url":"git://github.com/spadgett/console.git","ssh_url":"git@github.com:spadgett/console.git","clone_url":"https://github.com/spadgett/console.git","svn_url":"https://github.com/spadgett/console","homepage":null,"size":86796,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"758da79cd2bc6b817e30eae8b498c2204d471317","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":129436456,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MzY0NTY=","name":"console","full_name":"openshift/console","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/console","description":"OpenShift Cluster Console UI","fork":false,"url":"https://api.github.com/repos/openshift/console","forks_url":"https://api.github.com/repos/openshift/console/forks","keys_url":"https://api.github.com/repos/openshift/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/console/teams","hooks_url":"https://api.github.com/repos/openshift/console/hooks","issue_events_url":"https://api.github.com/repos/openshift/console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/console/events","assignees_url":"https://api.github.com/repos/openshift/console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/console/tags","blobs_url":"https://api.github.com/repos/openshift/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/console/languages","stargazers_url":"https://api.github.com/repos/openshift/console/stargazers","contributors_url":"https://api.github.com/repos/openshift/console/contributors","subscribers_url":"https://api.github.com/repos/openshift/console/subscribers","subscription_url":"https://api.github.com/repos/openshift/console/subscription","commits_url":"https://api.github.com/repos/openshift/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/console/merges","archive_url":"https://api.github.com/repos/openshift/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/console/downloads","issues_url":"https://api.github.com/repos/openshift/console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/console/deployments","created_at":"2018-04-13T17:54:59Z","updated_at":"2018-07-10T15:57:50Z","pushed_at":"2018-07-10T19:36:29Z","git_url":"git://github.com/openshift/console.git","ssh_url":"git@github.com:openshift/console.git","clone_url":"https://github.com/openshift/console.git","svn_url":"https://github.com/openshift/console","homepage":"https://www.openshift.org","size":86790,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":21,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/173"},"html":{"href":"https://github.com/openshift/console/pull/173"},"issue":{"href":"https://api.github.com/repos/openshift/console/issues/173"},"comments":{"href":"https://api.github.com/repos/openshift/console/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/console/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/console/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/console/statuses/cf7923694332361f745f4cd0f1ccb3fb66d59988"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sosiouxme"}}