{"action":"created","issue":{"url":"https://api.github.com/repos/Thutmose/Pokecube/issues/287","repository_url":"https://api.github.com/repos/Thutmose/Pokecube","labels_url":"https://api.github.com/repos/Thutmose/Pokecube/issues/287/labels{/name}","comments_url":"https://api.github.com/repos/Thutmose/Pokecube/issues/287/comments","events_url":"https://api.github.com/repos/Thutmose/Pokecube/issues/287/events","html_url":"https://github.com/Thutmose/Pokecube/issues/287","id":322486978,"number":287,"title":"Config Suggestions: Dimension whitelist for village structures & villager trainers","user":{"login":"Ligands","id":3400211,"avatar_url":"https://avatars0.githubusercontent.com/u/3400211?v=4","gravatar_id":"","url":"https://api.github.com/users/Ligands","html_url":"https://github.com/Ligands","followers_url":"https://api.github.com/users/Ligands/followers","following_url":"https://api.github.com/users/Ligands/following{/other_user}","gists_url":"https://api.github.com/users/Ligands/gists{/gist_id}","starred_url":"https://api.github.com/users/Ligands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ligands/subscriptions","organizations_url":"https://api.github.com/users/Ligands/orgs","repos_url":"https://api.github.com/users/Ligands/repos","events_url":"https://api.github.com/users/Ligands/events{/privacy}","received_events_url":"https://api.github.com/users/Ligands/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-12T06:20:46Z","updated_at":"2018-05-12T14:28:36Z","closed_at":null,"author_association":"NONE","body":"#### Suggestion:\r\nA configuration option allowing dimension ID white/blacklisting for the village-related configuration options:\r\n\r\n- _B:npcsAreTrainers_\r\n- _B:villagePokecenters_\r\n- _B:villagePokemarts_\r\n\r\n\r\n#### Reasoning:\r\nIn pokecube.cfg, there is an option '_I:dimensionWhitelist_' (along with _I:dimensionBlacklist_ / _B:whiteListEnabled_) which can be specified to only spawn pokecube mons in a specific dimension. This can be used alongside the configuration setting _I:spawnDimension_, to configure a particular dimension where players will be introduced to Pokecube & asked to select their starter 'mon.\r\n\r\nFor example, in my instance, I'm using these properties to whitelist the Lost Cities dimension (ID=111) for all Pokecube-related activities. (This dimension still has regular village generation.)\r\n\r\nHowever, even with this configuration, players can still get a pokecube before visiting the intended dimension, by simply finding any village in the overworld & using the Pokecube Table in the corner. To avoid this, I have to disable _B:villagePokecenters_, though this will prevent Pokemon Centers from generating in the whitelisted dimension also- which is undesirable. \r\n\r\nI also don't want villagers in the overworld to be calling out Pokemon to defend themselves, because those 'mons shouldn't exist in this dimension; so I have to disable _B:npcsAreTrainers_ also, which unfortunately also affects the whitelisted dimension.\r\n\r\n\r\n#### Notes:\r\nLong story short, I think it would be useful if we could white/blacklist the generation of pokecenters & marts per-dimension, as well as the whole villagers-being-trainers thing. Either they could be affected by the dimensionBlacklist & dimensionWhitelist options (probably not good for encapsulation), or separate whitelists for all 3 options (probably too verbose), or maybe just a master dimension whitelist for all village/villager-related options?"},"comment":{"url":"https://api.github.com/repos/Thutmose/Pokecube/issues/comments/388558930","html_url":"https://github.com/Thutmose/Pokecube/issues/287#issuecomment-388558930","issue_url":"https://api.github.com/repos/Thutmose/Pokecube/issues/287","id":388558930,"user":{"login":"Thutmose","id":2363472,"avatar_url":"https://avatars3.githubusercontent.com/u/2363472?v=4","gravatar_id":"","url":"https://api.github.com/users/Thutmose","html_url":"https://github.com/Thutmose","followers_url":"https://api.github.com/users/Thutmose/followers","following_url":"https://api.github.com/users/Thutmose/following{/other_user}","gists_url":"https://api.github.com/users/Thutmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Thutmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thutmose/subscriptions","organizations_url":"https://api.github.com/users/Thutmose/orgs","repos_url":"https://api.github.com/users/Thutmose/repos","events_url":"https://api.github.com/users/Thutmose/events{/privacy}","received_events_url":"https://api.github.com/users/Thutmose/received_events","type":"User","site_admin":false},"created_at":"2018-05-12T14:28:36Z","updated_at":"2018-05-12T14:28:36Z","author_association":"OWNER","body":"This should be possible to do, I can look into adding black and white list capabilities to all of the villager and village related features"}}
{"actor":{"display_login":"Thutmose"}}