{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/193371787","pull_request_review_id":126327023,"id":193371787,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzM3MTc4Nw==","diff_hunk":"@@ -44,29 +44,17 @@ Starting PostgreSQL Container\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n \n Now we need to run ``PostgreSQL`` in a container, attach it to the network you\n-have created before, and expose ports for communication:\n+have created before:\n \n .. code-block:: shell\n \n   docker run --name some-postgres \\\n   -e POSTGRES_USER=postgres \\\n   -e POSTGRES_PASSWORD=mysecretpassword \\\n-  -p 5432:5432 \\","path":"docs/source/getting_started/index.rst","position":12,"original_position":12,"commit_id":"abf62d33aeac3bb0daab04df35587db6fc8dfe15","original_commit_id":"abf62d33aeac3bb0daab04df35587db6fc8dfe15","user":{"login":"laSinteZ","id":10958990,"node_id":"MDQ6VXNlcjEwOTU4OTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10958990?v=4","gravatar_id":"","url":"https://api.github.com/users/laSinteZ","html_url":"https://github.com/laSinteZ","followers_url":"https://api.github.com/users/laSinteZ/followers","following_url":"https://api.github.com/users/laSinteZ/following{/other_user}","gists_url":"https://api.github.com/users/laSinteZ/gists{/gist_id}","starred_url":"https://api.github.com/users/laSinteZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laSinteZ/subscriptions","organizations_url":"https://api.github.com/users/laSinteZ/orgs","repos_url":"https://api.github.com/users/laSinteZ/repos","events_url":"https://api.github.com/users/laSinteZ/events{/privacy}","received_events_url":"https://api.github.com/users/laSinteZ/received_events","type":"User","site_admin":false},"body":"Will it work w/o exposing the port? Also, what if user has something on this port?","created_at":"2018-06-06T11:03:26Z","updated_at":"2018-06-06T11:03:26Z","html_url":"https://github.com/hyperledger/iroha/pull/1418#discussion_r193371787","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1418","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/193371787"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1418#discussion_r193371787"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1418"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1418","id":192936827,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTM2ODI3","html_url":"https://github.com/hyperledger/iroha/pull/1418","diff_url":"https://github.com/hyperledger/iroha/pull/1418.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1418.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1418","number":1418,"state":"open","locked":false,"title":"Fix getting started docs","user":{"login":"bakhtin","id":8650477,"node_id":"MDQ6VXNlcjg2NTA0Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/8650477?v=4","gravatar_id":"","url":"https://api.github.com/users/bakhtin","html_url":"https://github.com/bakhtin","followers_url":"https://api.github.com/users/bakhtin/followers","following_url":"https://api.github.com/users/bakhtin/following{/other_user}","gists_url":"https://api.github.com/users/bakhtin/gists{/gist_id}","starred_url":"https://api.github.com/users/bakhtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakhtin/subscriptions","organizations_url":"https://api.github.com/users/bakhtin/orgs","repos_url":"https://api.github.com/users/bakhtin/repos","events_url":"https://api.github.com/users/bakhtin/events{/privacy}","received_events_url":"https://api.github.com/users/bakhtin/received_events","type":"User","site_admin":false},"body":"<!-- You will not see HTML commented line in Pull Request body -->\r\n<!-- Optional sections may be omitted. Just remove them or write None -->\r\n\r\n<!-- ### Requirements -->\r\n<!-- * Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. -->\r\n<!-- * All new code must have code coverage above 70% (https://docs.codecov.io/docs/about-code-coverage). -->\r\n<!-- * CircleCI builds must be passed. -->\r\n<!-- * Critical and blocker issues reported by Sorabot must be fixed. -->\r\n<!-- * Branch must be rebased onto base branch (https://soramitsu.atlassian.net/wiki/spaces/IS/pages/11173889/Rebase+and+merge+guide). -->\r\n\r\n\r\n### Description of the Change\r\n- Getting started guide did not reflect changes required to run Iroha with Postgres. `config.sample` file from `example` directory uses `localhost` as a Postgres host Iroha should connect to. It actually should connect to the host matching Postgres container name.\r\n- Removed block storage creation step as Docker creates it automatically on container start up.\r\n- The other section suggested to override entrypoint and run Iroha manually. Rewrite it so Iroha uses entrypoint defined on Docker image creation. Supplement `docker run` command with `KEY` environment variable. That is to instruct Iroha container using keys from `example` directory.\r\n<!-- We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. -->\r\n<!-- Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts. -->\r\n\r\n### Benefits\r\nStreamlined Iroha launching process\r\n<!-- What benefits will be realized by the code change? -->\r\n\r\n### Possible Drawbacks \r\nNone\r\n<!-- What are the possible side-effects or negative impacts of the code change? -->\r\n<!-- If no drawbacks, explicitly mention this (write None) -->\r\n","created_at":"2018-06-06T08:29:43Z","updated_at":"2018-06-06T11:03:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ced460d3545f6b0cf9bae29f540d17fd1fcd6f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":858348494,"node_id":"MDU6TGFiZWw4NTgzNDg0OTQ=","url":"https://api.github.com/repos/hyperledger/iroha/labels/documentation","name":"documentation","color":"87a805","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1418/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1418/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1418/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/abf62d33aeac3bb0daab04df35587db6fc8dfe15","head":{"label":"hyperledger:fix/docker-env-docs","ref":"fix/docker-env-docs","sha":"abf62d33aeac3bb0daab04df35587db6fc8dfe15","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-06-05T19:27:31Z","pushed_at":"2018-06-06T10:57:33Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":48458,"stargazers_count":809,"watchers_count":809,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":251,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":251,"open_issues":53,"watchers":809,"default_branch":"master"}},"base":{"label":"hyperledger:develop","ref":"develop","sha":"bf21d81bc1b6b6fdad49bae2f6ee61770223fc36","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-06-05T19:27:31Z","pushed_at":"2018-06-06T10:57:33Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":48458,"stargazers_count":809,"watchers_count":809,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":251,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":251,"open_issues":53,"watchers":809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1418"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1418"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1418"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1418/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1418/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1418/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/abf62d33aeac3bb0daab04df35587db6fc8dfe15"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"laSinteZ"}}