{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58169","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58169/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58169/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58169/events","html_url":"https://github.com/kubernetes/kubernetes/pull/58169","id":287881432,"number":58169,"title":"decrease pod with pvc failover time in case of node is shutdowned.","user":{"login":"zetaab","id":22482503,"avatar_url":"https://avatars2.githubusercontent.com/u/22482503?v=4","gravatar_id":"","url":"https://api.github.com/users/zetaab","html_url":"https://github.com/zetaab","followers_url":"https://api.github.com/users/zetaab/followers","following_url":"https://api.github.com/users/zetaab/following{/other_user}","gists_url":"https://api.github.com/users/zetaab/gists{/gist_id}","starred_url":"https://api.github.com/users/zetaab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetaab/subscriptions","organizations_url":"https://api.github.com/users/zetaab/orgs","repos_url":"https://api.github.com/users/zetaab/repos","events_url":"https://api.github.com/users/zetaab/events{/privacy}","received_events_url":"https://api.github.com/users/zetaab/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":240247879,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"davidz627","id":5459214,"avatar_url":"https://avatars3.githubusercontent.com/u/5459214?v=4","gravatar_id":"","url":"https://api.github.com/users/davidz627","html_url":"https://github.com/davidz627","followers_url":"https://api.github.com/users/davidz627/followers","following_url":"https://api.github.com/users/davidz627/following{/other_user}","gists_url":"https://api.github.com/users/davidz627/gists{/gist_id}","starred_url":"https://api.github.com/users/davidz627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidz627/subscriptions","organizations_url":"https://api.github.com/users/davidz627/orgs","repos_url":"https://api.github.com/users/davidz627/repos","events_url":"https://api.github.com/users/davidz627/events{/privacy}","received_events_url":"https://api.github.com/users/davidz627/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidz627","id":5459214,"avatar_url":"https://avatars3.githubusercontent.com/u/5459214?v=4","gravatar_id":"","url":"https://api.github.com/users/davidz627","html_url":"https://github.com/davidz627","followers_url":"https://api.github.com/users/davidz627/followers","following_url":"https://api.github.com/users/davidz627/following{/other_user}","gists_url":"https://api.github.com/users/davidz627/gists{/gist_id}","starred_url":"https://api.github.com/users/davidz627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidz627/subscriptions","organizations_url":"https://api.github.com/users/davidz627/orgs","repos_url":"https://api.github.com/users/davidz627/repos","events_url":"https://api.github.com/users/davidz627/events{/privacy}","received_events_url":"https://api.github.com/users/davidz627/received_events","type":"User","site_admin":false},{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars3.githubusercontent.com/u/19172805?v=4","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false},{"login":"msau42","id":24448061,"avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false}],"milestone":null,"comments":23,"created_at":"2018-01-11T18:34:23Z","updated_at":"2018-02-04T06:18:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58169","html_url":"https://github.com/kubernetes/kubernetes/pull/58169","diff_url":"https://github.com/kubernetes/kubernetes/pull/58169.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/58169.patch"},"body":"**What this PR does / why we need it**: this PR decreases the failover time when node is shutdowned which contains POD which have PVC attached. Before this fix the time was something between 8-10minutes because the reconciler will always wait maxWaitForUnmountDuration in https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/volume/attachdetach/reconciler/reconciler.go#L201 However, that wait is not always needed if the node is in safe state to detach volume. For instance in openstack this safe state is at least SHUTOFF\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes #58079\r\nFixes #53059\r\n\r\n**Special notes for your reviewer**: \r\nThis PR contains only implementation to openstack cloudprovider. That is implemented as example to others. All other cloudproviders should implement SafeToDetachFromNode in order to get this working like should. This implementation does not change any behaviour how it is working currently in other cloud providers. In openstack this decreases failover time **from 9-10minutes to 1min 10seconds** - which is quite huge improvement.\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nNONE\r\n```\r\n\r\ncc @gnufied @jingxu97 "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/362883987","html_url":"https://github.com/kubernetes/kubernetes/pull/58169#issuecomment-362883987","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58169","id":362883987,"user":{"login":"zetaab","id":22482503,"avatar_url":"https://avatars2.githubusercontent.com/u/22482503?v=4","gravatar_id":"","url":"https://api.github.com/users/zetaab","html_url":"https://github.com/zetaab","followers_url":"https://api.github.com/users/zetaab/followers","following_url":"https://api.github.com/users/zetaab/following{/other_user}","gists_url":"https://api.github.com/users/zetaab/gists{/gist_id}","starred_url":"https://api.github.com/users/zetaab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetaab/subscriptions","organizations_url":"https://api.github.com/users/zetaab/orgs","repos_url":"https://api.github.com/users/zetaab/repos","events_url":"https://api.github.com/users/zetaab/events{/privacy}","received_events_url":"https://api.github.com/users/zetaab/received_events","type":"User","site_admin":false},"created_at":"2018-02-04T06:18:27Z","updated_at":"2018-02-04T06:18:27Z","author_association":"CONTRIBUTOR","body":"@dims no problem. I think this PR is not moving forward. This is replaced with node taints \r\n\r\ncc @jingxu97 "}}
{"actor":{"display_login":"zetaab"}}