{"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/173650753","pull_request_review_id":102878147,"id":173650753,"diff_hunk":"@@ -21,36 +35,72 @@\n      * @throws IllegalValueException if given address string is invalid.\n      */\n     public Address(String address, boolean isPrivate) throws IllegalValueException {\n-        String trimmedAddress = address.trim();\n         this.isPrivate = isPrivate;\n-        if (!isValidAddress(trimmedAddress)) {\n+        if (!isValidAddress(address.trim())) {\n             throw new IllegalValueException(MESSAGE_ADDRESS_CONSTRAINTS);\n         }\n-        this.value = trimmedAddress;\n+        this.block = new Block(matcher.group(\"block\"));","path":"src/seedu/addressbook/data/person/Address.java","position":47,"original_position":47,"commit_id":"328573d48d69199fa214b71de5502c74a560a71c","original_commit_id":"328573d48d69199fa214b71de5502c74a560a71c","user":{"login":"erik0704","id":28505595,"avatar_url":"https://avatars1.githubusercontent.com/u/28505595?v=4","gravatar_id":"","url":"https://api.github.com/users/erik0704","html_url":"https://github.com/erik0704","followers_url":"https://api.github.com/users/erik0704/followers","following_url":"https://api.github.com/users/erik0704/following{/other_user}","gists_url":"https://api.github.com/users/erik0704/gists{/gist_id}","starred_url":"https://api.github.com/users/erik0704/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erik0704/subscriptions","organizations_url":"https://api.github.com/users/erik0704/orgs","repos_url":"https://api.github.com/users/erik0704/repos","events_url":"https://api.github.com/users/erik0704/events{/privacy}","received_events_url":"https://api.github.com/users/erik0704/received_events","type":"User","site_admin":false},"body":"Good job user `matcher` here. ","created_at":"2018-03-11T11:10:45Z","updated_at":"2018-03-11T11:11:17Z","html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/849#discussion_r173650753","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/849","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/173650753"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/849#discussion_r173650753"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/849"}}},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/849","id":170277293,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/849","diff_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/849.diff","patch_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/849.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/849","number":849,"state":"open","locked":false,"title":"[W4.4b][F12-A1]Seunghwan Choi","user":{"login":"shadow2496","id":17617775,"avatar_url":"https://avatars3.githubusercontent.com/u/17617775?v=4","gravatar_id":"","url":"https://api.github.com/users/shadow2496","html_url":"https://github.com/shadow2496","followers_url":"https://api.github.com/users/shadow2496/followers","following_url":"https://api.github.com/users/shadow2496/following{/other_user}","gists_url":"https://api.github.com/users/shadow2496/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow2496/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow2496/subscriptions","organizations_url":"https://api.github.com/users/shadow2496/orgs","repos_url":"https://api.github.com/users/shadow2496/repos","events_url":"https://api.github.com/users/shadow2496/events{/privacy}","received_events_url":"https://api.github.com/users/shadow2496/received_events","type":"User","site_admin":false},"body":"Implement a class [LO-ImplementClass]","created_at":"2018-02-20T18:49:47Z","updated_at":"2018-03-11T11:11:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c87f3d6a764a32b6421cc01c7e3e13c7c5228e74","assignee":{"login":"okkhoy","id":1023494,"avatar_url":"https://avatars1.githubusercontent.com/u/1023494?v=4","gravatar_id":"","url":"https://api.github.com/users/okkhoy","html_url":"https://github.com/okkhoy","followers_url":"https://api.github.com/users/okkhoy/followers","following_url":"https://api.github.com/users/okkhoy/following{/other_user}","gists_url":"https://api.github.com/users/okkhoy/gists{/gist_id}","starred_url":"https://api.github.com/users/okkhoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkhoy/subscriptions","organizations_url":"https://api.github.com/users/okkhoy/orgs","repos_url":"https://api.github.com/users/okkhoy/repos","events_url":"https://api.github.com/users/okkhoy/events{/privacy}","received_events_url":"https://api.github.com/users/okkhoy/received_events","type":"User","site_admin":false},"assignees":[{"login":"okkhoy","id":1023494,"avatar_url":"https://avatars1.githubusercontent.com/u/1023494?v=4","gravatar_id":"","url":"https://api.github.com/users/okkhoy","html_url":"https://github.com/okkhoy","followers_url":"https://api.github.com/users/okkhoy/followers","following_url":"https://api.github.com/users/okkhoy/following{/other_user}","gists_url":"https://api.github.com/users/okkhoy/gists{/gist_id}","starred_url":"https://api.github.com/users/okkhoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkhoy/subscriptions","organizations_url":"https://api.github.com/users/okkhoy/orgs","repos_url":"https://api.github.com/users/okkhoy/repos","events_url":"https://api.github.com/users/okkhoy/events{/privacy}","received_events_url":"https://api.github.com/users/okkhoy/received_events","type":"User","site_admin":false},{"login":"erik0704","id":28505595,"avatar_url":"https://avatars1.githubusercontent.com/u/28505595?v=4","gravatar_id":"","url":"https://api.github.com/users/erik0704","html_url":"https://github.com/erik0704","followers_url":"https://api.github.com/users/erik0704/followers","following_url":"https://api.github.com/users/erik0704/following{/other_user}","gists_url":"https://api.github.com/users/erik0704/gists{/gist_id}","starred_url":"https://api.github.com/users/erik0704/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erik0704/subscriptions","organizations_url":"https://api.github.com/users/erik0704/orgs","repos_url":"https://api.github.com/users/erik0704/repos","events_url":"https://api.github.com/users/erik0704/events{/privacy}","received_events_url":"https://api.github.com/users/erik0704/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":784873013,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/team.A1","name":"team.A1","color":"ededed","default":false},{"id":831807660,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/tutorial.F12","name":"tutorial.F12","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/849/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/849/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/849/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/328573d48d69199fa214b71de5502c74a560a71c","head":{"label":"shadow2496:W4.4b","ref":"W4.4b","sha":"328573d48d69199fa214b71de5502c74a560a71c","user":{"login":"shadow2496","id":17617775,"avatar_url":"https://avatars3.githubusercontent.com/u/17617775?v=4","gravatar_id":"","url":"https://api.github.com/users/shadow2496","html_url":"https://github.com/shadow2496","followers_url":"https://api.github.com/users/shadow2496/followers","following_url":"https://api.github.com/users/shadow2496/following{/other_user}","gists_url":"https://api.github.com/users/shadow2496/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow2496/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow2496/subscriptions","organizations_url":"https://api.github.com/users/shadow2496/orgs","repos_url":"https://api.github.com/users/shadow2496/repos","events_url":"https://api.github.com/users/shadow2496/events{/privacy}","received_events_url":"https://api.github.com/users/shadow2496/received_events","type":"User","site_admin":false},"repo":{"id":119879979,"name":"addressbook-level2","full_name":"shadow2496/addressbook-level2","owner":{"login":"shadow2496","id":17617775,"avatar_url":"https://avatars3.githubusercontent.com/u/17617775?v=4","gravatar_id":"","url":"https://api.github.com/users/shadow2496","html_url":"https://github.com/shadow2496","followers_url":"https://api.github.com/users/shadow2496/followers","following_url":"https://api.github.com/users/shadow2496/following{/other_user}","gists_url":"https://api.github.com/users/shadow2496/gists{/gist_id}","starred_url":"https://api.github.com/users/shadow2496/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shadow2496/subscriptions","organizations_url":"https://api.github.com/users/shadow2496/orgs","repos_url":"https://api.github.com/users/shadow2496/repos","events_url":"https://api.github.com/users/shadow2496/events{/privacy}","received_events_url":"https://api.github.com/users/shadow2496/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shadow2496/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/shadow2496/addressbook-level2","forks_url":"https://api.github.com/repos/shadow2496/addressbook-level2/forks","keys_url":"https://api.github.com/repos/shadow2496/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shadow2496/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shadow2496/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/shadow2496/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/shadow2496/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/shadow2496/addressbook-level2/events","assignees_url":"https://api.github.com/repos/shadow2496/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/shadow2496/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/shadow2496/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/shadow2496/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shadow2496/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shadow2496/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/shadow2496/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shadow2496/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/shadow2496/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/shadow2496/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/shadow2496/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/shadow2496/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/shadow2496/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/shadow2496/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/shadow2496/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/shadow2496/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/shadow2496/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/shadow2496/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/shadow2496/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shadow2496/addressbook-level2/merges","archive_url":"https://api.github.com/repos/shadow2496/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shadow2496/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/shadow2496/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/shadow2496/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/shadow2496/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/shadow2496/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shadow2496/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/shadow2496/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/shadow2496/addressbook-level2/deployments","created_at":"2018-02-01T19:02:22Z","updated_at":"2018-02-01T19:02:24Z","pushed_at":"2018-03-01T16:37:58Z","git_url":"git://github.com/shadow2496/addressbook-level2.git","ssh_url":"git@github.com:shadow2496/addressbook-level2.git","clone_url":"https://github.com/shadow2496/addressbook-level2.git","svn_url":"https://github.com/shadow2496/addressbook-level2","homepage":null,"size":3312,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1718S2:master","ref":"master","sha":"23644b1848abac9a973179ad015e20b7292394f5","user":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"repo":{"id":115011334,"name":"addressbook-level2","full_name":"nus-cs2103-AY1718S2/addressbook-level2","owner":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2","forks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/deployments","created_at":"2017-12-21T13:56:37Z","updated_at":"2018-02-18T02:32:33Z","pushed_at":"2018-03-11T03:19:32Z","git_url":"git://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","ssh_url":"git@github.com:nus-cs2103-AY1718S2/addressbook-level2.git","clone_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","svn_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","homepage":null,"size":3419,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"archived":false,"open_issues_count":359,"license":null,"forks":190,"open_issues":359,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/849"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/849"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/849"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/849/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/849/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/849/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/328573d48d69199fa214b71de5502c74a560a71c"}},"author_association":"NONE"}}
{"actor":{"display_login":"erik0704"}}