{"action":"closed","number":1022,"pull_request":{"url":"https://api.github.com/repos/kiegroup/drools-wb/pulls/1022","id":236821796,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODIxNzk2","html_url":"https://github.com/kiegroup/drools-wb/pull/1022","diff_url":"https://github.com/kiegroup/drools-wb/pull/1022.diff","patch_url":"https://github.com/kiegroup/drools-wb/pull/1022.patch","issue_url":"https://api.github.com/repos/kiegroup/drools-wb/issues/1022","number":1022,"state":"closed","locked":false,"title":"[DROOLS-3417] Avoiding endless loop on ScenarioSimulationGridHeaderUtilitiesTest","user":{"login":"gitgabrio","id":765578,"node_id":"MDQ6VXNlcjc2NTU3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/765578?v=4","gravatar_id":"","url":"https://api.github.com/users/gitgabrio","html_url":"https://github.com/gitgabrio","followers_url":"https://api.github.com/users/gitgabrio/followers","following_url":"https://api.github.com/users/gitgabrio/following{/other_user}","gists_url":"https://api.github.com/users/gitgabrio/gists{/gist_id}","starred_url":"https://api.github.com/users/gitgabrio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitgabrio/subscriptions","organizations_url":"https://api.github.com/users/gitgabrio/orgs","repos_url":"https://api.github.com/users/gitgabrio/repos","events_url":"https://api.github.com/users/gitgabrio/events{/privacy}","received_events_url":"https://api.github.com/users/gitgabrio/received_events","type":"User","site_admin":false},"body":"@kkufova @jomarko @Rikkola \r\n\r\nThat loop was caused by a change inside upper layer.\r\nBefore this change, by default ScenariogridModel had 1 header row, even when called by the default constructor. After the change, the default header row number is 0.\r\nInside ScenarioSimulationGridHeaderUtilities there is a method that uses that row number in a \"while\" loop for a subtraction, but since now that number is 0, that loop will never end.\r\nThe fix has been to check for \"0\" rows before that loop, eventually returning null.\r\nTests have been modified as per @jomarko suggestion. A new one has been added.\r\n\r\nPlease check ASAP to merge it.\r\n ","created_at":"2018-12-07T10:32:30Z","updated_at":"2018-12-10T13:19:07Z","closed_at":"2018-12-10T13:19:07Z","merged_at":"2018-12-10T13:19:07Z","merge_commit_sha":"69c83f805ffa99e43c21d20ea80f15095ee3a737","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiegroup/drools-wb/pulls/1022/commits","review_comments_url":"https://api.github.com/repos/kiegroup/drools-wb/pulls/1022/comments","review_comment_url":"https://api.github.com/repos/kiegroup/drools-wb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiegroup/drools-wb/issues/1022/comments","statuses_url":"https://api.github.com/repos/kiegroup/drools-wb/statuses/292e15384f1fb17f2cc59cb636d75126bd384afb","head":{"label":"gitgabrio:DROOLS-3417","ref":"DROOLS-3417","sha":"292e15384f1fb17f2cc59cb636d75126bd384afb","user":{"login":"gitgabrio","id":765578,"node_id":"MDQ6VXNlcjc2NTU3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/765578?v=4","gravatar_id":"","url":"https://api.github.com/users/gitgabrio","html_url":"https://github.com/gitgabrio","followers_url":"https://api.github.com/users/gitgabrio/followers","following_url":"https://api.github.com/users/gitgabrio/following{/other_user}","gists_url":"https://api.github.com/users/gitgabrio/gists{/gist_id}","starred_url":"https://api.github.com/users/gitgabrio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitgabrio/subscriptions","organizations_url":"https://api.github.com/users/gitgabrio/orgs","repos_url":"https://api.github.com/users/gitgabrio/repos","events_url":"https://api.github.com/users/gitgabrio/events{/privacy}","received_events_url":"https://api.github.com/users/gitgabrio/received_events","type":"User","site_admin":false},"repo":{"id":138327005,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzMjcwMDU=","name":"drools-wb","full_name":"gitgabrio/drools-wb","private":false,"owner":{"login":"gitgabrio","id":765578,"node_id":"MDQ6VXNlcjc2NTU3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/765578?v=4","gravatar_id":"","url":"https://api.github.com/users/gitgabrio","html_url":"https://github.com/gitgabrio","followers_url":"https://api.github.com/users/gitgabrio/followers","following_url":"https://api.github.com/users/gitgabrio/following{/other_user}","gists_url":"https://api.github.com/users/gitgabrio/gists{/gist_id}","starred_url":"https://api.github.com/users/gitgabrio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitgabrio/subscriptions","organizations_url":"https://api.github.com/users/gitgabrio/orgs","repos_url":"https://api.github.com/users/gitgabrio/repos","events_url":"https://api.github.com/users/gitgabrio/events{/privacy}","received_events_url":"https://api.github.com/users/gitgabrio/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gitgabrio/drools-wb","description":"Drools Workbench is the web application and repository to govern Drools assets.","fork":true,"url":"https://api.github.com/repos/gitgabrio/drools-wb","forks_url":"https://api.github.com/repos/gitgabrio/drools-wb/forks","keys_url":"https://api.github.com/repos/gitgabrio/drools-wb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitgabrio/drools-wb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitgabrio/drools-wb/teams","hooks_url":"https://api.github.com/repos/gitgabrio/drools-wb/hooks","issue_events_url":"https://api.github.com/repos/gitgabrio/drools-wb/issues/events{/number}","events_url":"https://api.github.com/repos/gitgabrio/drools-wb/events","assignees_url":"https://api.github.com/repos/gitgabrio/drools-wb/assignees{/user}","branches_url":"https://api.github.com/repos/gitgabrio/drools-wb/branches{/branch}","tags_url":"https://api.github.com/repos/gitgabrio/drools-wb/tags","blobs_url":"https://api.github.com/repos/gitgabrio/drools-wb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitgabrio/drools-wb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitgabrio/drools-wb/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitgabrio/drools-wb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitgabrio/drools-wb/statuses/{sha}","languages_url":"https://api.github.com/repos/gitgabrio/drools-wb/languages","stargazers_url":"https://api.github.com/repos/gitgabrio/drools-wb/stargazers","contributors_url":"https://api.github.com/repos/gitgabrio/drools-wb/contributors","subscribers_url":"https://api.github.com/repos/gitgabrio/drools-wb/subscribers","subscription_url":"https://api.github.com/repos/gitgabrio/drools-wb/subscription","commits_url":"https://api.github.com/repos/gitgabrio/drools-wb/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitgabrio/drools-wb/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitgabrio/drools-wb/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitgabrio/drools-wb/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitgabrio/drools-wb/contents/{+path}","compare_url":"https://api.github.com/repos/gitgabrio/drools-wb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitgabrio/drools-wb/merges","archive_url":"https://api.github.com/repos/gitgabrio/drools-wb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitgabrio/drools-wb/downloads","issues_url":"https://api.github.com/repos/gitgabrio/drools-wb/issues{/number}","pulls_url":"https://api.github.com/repos/gitgabrio/drools-wb/pulls{/number}","milestones_url":"https://api.github.com/repos/gitgabrio/drools-wb/milestones{/number}","notifications_url":"https://api.github.com/repos/gitgabrio/drools-wb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitgabrio/drools-wb/labels{/name}","releases_url":"https://api.github.com/repos/gitgabrio/drools-wb/releases{/id}","deployments_url":"https://api.github.com/repos/gitgabrio/drools-wb/deployments","created_at":"2018-06-22T16:52:35Z","updated_at":"2018-11-28T16:19:26Z","pushed_at":"2018-12-10T10:13:04Z","git_url":"git://github.com/gitgabrio/drools-wb.git","ssh_url":"git@github.com:gitgabrio/drools-wb.git","clone_url":"https://github.com/gitgabrio/drools-wb.git","svn_url":"https://github.com/gitgabrio/drools-wb","homepage":"","size":141712,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiegroup:master","ref":"master","sha":"4e296b0a8d4577c3005fbcc7382664a20657f526","user":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":10522020,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyMjAyMA==","name":"drools-wb","full_name":"kiegroup/drools-wb","private":false,"owner":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiegroup/drools-wb","description":"Drools Workbench is the web application and repository to govern Drools assets.","fork":false,"url":"https://api.github.com/repos/kiegroup/drools-wb","forks_url":"https://api.github.com/repos/kiegroup/drools-wb/forks","keys_url":"https://api.github.com/repos/kiegroup/drools-wb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiegroup/drools-wb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiegroup/drools-wb/teams","hooks_url":"https://api.github.com/repos/kiegroup/drools-wb/hooks","issue_events_url":"https://api.github.com/repos/kiegroup/drools-wb/issues/events{/number}","events_url":"https://api.github.com/repos/kiegroup/drools-wb/events","assignees_url":"https://api.github.com/repos/kiegroup/drools-wb/assignees{/user}","branches_url":"https://api.github.com/repos/kiegroup/drools-wb/branches{/branch}","tags_url":"https://api.github.com/repos/kiegroup/drools-wb/tags","blobs_url":"https://api.github.com/repos/kiegroup/drools-wb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiegroup/drools-wb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiegroup/drools-wb/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiegroup/drools-wb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiegroup/drools-wb/statuses/{sha}","languages_url":"https://api.github.com/repos/kiegroup/drools-wb/languages","stargazers_url":"https://api.github.com/repos/kiegroup/drools-wb/stargazers","contributors_url":"https://api.github.com/repos/kiegroup/drools-wb/contributors","subscribers_url":"https://api.github.com/repos/kiegroup/drools-wb/subscribers","subscription_url":"https://api.github.com/repos/kiegroup/drools-wb/subscription","commits_url":"https://api.github.com/repos/kiegroup/drools-wb/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiegroup/drools-wb/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiegroup/drools-wb/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiegroup/drools-wb/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiegroup/drools-wb/contents/{+path}","compare_url":"https://api.github.com/repos/kiegroup/drools-wb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiegroup/drools-wb/merges","archive_url":"https://api.github.com/repos/kiegroup/drools-wb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiegroup/drools-wb/downloads","issues_url":"https://api.github.com/repos/kiegroup/drools-wb/issues{/number}","pulls_url":"https://api.github.com/repos/kiegroup/drools-wb/pulls{/number}","milestones_url":"https://api.github.com/repos/kiegroup/drools-wb/milestones{/number}","notifications_url":"https://api.github.com/repos/kiegroup/drools-wb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiegroup/drools-wb/labels{/name}","releases_url":"https://api.github.com/repos/kiegroup/drools-wb/releases{/id}","deployments_url":"https://api.github.com/repos/kiegroup/drools-wb/deployments","created_at":"2013-06-06T08:26:25Z","updated_at":"2018-12-10T13:17:58Z","pushed_at":"2018-12-10T13:19:07Z","git_url":"git://github.com/kiegroup/drools-wb.git","ssh_url":"git@github.com:kiegroup/drools-wb.git","clone_url":"https://github.com/kiegroup/drools-wb.git","svn_url":"https://github.com/kiegroup/drools-wb","homepage":"","size":143190,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":176,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":176,"open_issues":14,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiegroup/drools-wb/pulls/1022"},"html":{"href":"https://github.com/kiegroup/drools-wb/pull/1022"},"issue":{"href":"https://api.github.com/repos/kiegroup/drools-wb/issues/1022"},"comments":{"href":"https://api.github.com/repos/kiegroup/drools-wb/issues/1022/comments"},"review_comments":{"href":"https://api.github.com/repos/kiegroup/drools-wb/pulls/1022/comments"},"review_comment":{"href":"https://api.github.com/repos/kiegroup/drools-wb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiegroup/drools-wb/pulls/1022/commits"},"statuses":{"href":"https://api.github.com/repos/kiegroup/drools-wb/statuses/292e15384f1fb17f2cc59cb636d75126bd384afb"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"triceo","id":247403,"node_id":"MDQ6VXNlcjI0NzQwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/247403?v=4","gravatar_id":"","url":"https://api.github.com/users/triceo","html_url":"https://github.com/triceo","followers_url":"https://api.github.com/users/triceo/followers","following_url":"https://api.github.com/users/triceo/following{/other_user}","gists_url":"https://api.github.com/users/triceo/gists{/gist_id}","starred_url":"https://api.github.com/users/triceo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triceo/subscriptions","organizations_url":"https://api.github.com/users/triceo/orgs","repos_url":"https://api.github.com/users/triceo/repos","events_url":"https://api.github.com/users/triceo/events{/privacy}","received_events_url":"https://api.github.com/users/triceo/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"triceo"}}