{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/comments/223853214","pull_request_review_id":163084169,"id":223853214,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzg1MzIxNA==","diff_hunk":"@@ -288,15 +297,15 @@ def execute_once(client)\n             request_header = header.dup\n             apply_request_options(request_header)\n \n-            http_res = client.request(method.to_s.upcase,\n-                                      url.to_s,\n-                                      query: nil,\n-                                      body: body,\n-                                      header: request_header,\n-                                      follow_redirect: true)\n-            logger.debug { http_res.status }\n-            logger.debug { http_res.inspect }\n-            response = process_response(http_res.status.to_i, http_res.header, http_res.body)\n+            @http_res = client.request(method.to_s.upcase,","path":"lib/google/apis/core/http_command.rb","position":59,"original_position":59,"commit_id":"48c227b4443ac2c6c731550f77132633003241c5","original_commit_id":"48c227b4443ac2c6c731550f77132633003241c5","user":{"login":"blowmage","id":730,"node_id":"MDQ6VXNlcjczMA==","avatar_url":"https://avatars0.githubusercontent.com/u/730?v=4","gravatar_id":"","url":"https://api.github.com/users/blowmage","html_url":"https://github.com/blowmage","followers_url":"https://api.github.com/users/blowmage/followers","following_url":"https://api.github.com/users/blowmage/following{/other_user}","gists_url":"https://api.github.com/users/blowmage/gists{/gist_id}","starred_url":"https://api.github.com/users/blowmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowmage/subscriptions","organizations_url":"https://api.github.com/users/blowmage/orgs","repos_url":"https://api.github.com/users/blowmage/repos","events_url":"https://api.github.com/users/blowmage/events{/privacy}","received_events_url":"https://api.github.com/users/blowmage/received_events","type":"User","site_admin":false},"body":"Should we worry that this ivar could be held on to longer than wanted? Should the `ensure` block in `execute` set this ivar to `nil`?","created_at":"2018-10-09T20:33:54Z","updated_at":"2018-10-09T20:33:54Z","html_url":"https://github.com/googleapis/google-api-ruby-client/pull/724#discussion_r223853214","pull_request_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/724","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/comments/223853214"},"html":{"href":"https://github.com/googleapis/google-api-ruby-client/pull/724#discussion_r223853214"},"pull_request":{"href":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/724"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/724","id":221280014,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjgwMDE0","html_url":"https://github.com/googleapis/google-api-ruby-client/pull/724","diff_url":"https://github.com/googleapis/google-api-ruby-client/pull/724.diff","patch_url":"https://github.com/googleapis/google-api-ruby-client/pull/724.patch","issue_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/issues/724","number":724,"state":"open","locked":false,"title":"OpenCensus integration for outgoing requests","user":{"login":"dazuma","id":8911,"node_id":"MDQ6VXNlcjg5MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8911?v=4","gravatar_id":"","url":"https://api.github.com/users/dazuma","html_url":"https://github.com/dazuma","followers_url":"https://api.github.com/users/dazuma/followers","following_url":"https://api.github.com/users/dazuma/following{/other_user}","gists_url":"https://api.github.com/users/dazuma/gists{/gist_id}","starred_url":"https://api.github.com/users/dazuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dazuma/subscriptions","organizations_url":"https://api.github.com/users/dazuma/orgs","repos_url":"https://api.github.com/users/dazuma/repos","events_url":"https://api.github.com/users/dazuma/events{/privacy}","received_events_url":"https://api.github.com/users/dazuma/received_events","type":"User","site_admin":false},"body":"Add OpenCensus instrumentation for all outgoing HTTP requests.\r\n\r\nIf the OpenCensus gem is present, AND there is an OpenCensus span context present, AND OpenCensus instrumentation is enabled in the request options, then outgoing HTTP requests will be wrapped in an OpenCensus span. This will make OpenCensus \"just work\" by default for all outgoing Google API REST calls, if the application uses OpenCensus. At the same time, OpenCensus for these calls can be disabled in the RequestOptions. OpenCensus is *not* required, and this code has no effect if the OpenCensus gem is not present.\r\n\r\nCurrently, the URI of the API call is used as the span name.\r\n\r\n/cc @bogdandrutu","created_at":"2018-10-09T00:51:46Z","updated_at":"2018-10-09T20:33:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbadf126675a22e21e954f5d6acaba3daeb59251","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":293598976,"node_id":"MDU6TGFiZWwyOTM1OTg5NzY=","url":"https://api.github.com/repos/googleapis/google-api-ruby-client/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/724/commits","review_comments_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/724/comments","review_comment_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/issues/724/comments","statuses_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/statuses/48c227b4443ac2c6c731550f77132633003241c5","head":{"label":"googleapis:opencensus","ref":"opencensus","sha":"48c227b4443ac2c6c731550f77132633003241c5","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":3277842,"node_id":"MDEwOlJlcG9zaXRvcnkzMjc3ODQy","name":"google-api-ruby-client","full_name":"googleapis/google-api-ruby-client","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/google-api-ruby-client","description":null,"fork":false,"url":"https://api.github.com/repos/googleapis/google-api-ruby-client","forks_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/forks","keys_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/teams","hooks_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/hooks","issue_events_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/events","assignees_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/tags","blobs_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/languages","stargazers_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/stargazers","contributors_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/contributors","subscribers_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/subscribers","subscription_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/subscription","commits_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/merges","archive_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/downloads","issues_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/deployments","created_at":"2012-01-26T21:54:39Z","updated_at":"2018-10-09T17:48:35Z","pushed_at":"2018-10-09T19:45:17Z","git_url":"git://github.com/googleapis/google-api-ruby-client.git","ssh_url":"git@github.com:googleapis/google-api-ruby-client.git","clone_url":"https://github.com/googleapis/google-api-ruby-client.git","svn_url":"https://github.com/googleapis/google-api-ruby-client","homepage":"https://developers.google.com/api-client-library/ruby/","size":38178,"stargazers_count":1919,"watchers_count":1919,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":584,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":584,"open_issues":59,"watchers":1919,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"1fd5929d7cc6d3c556be26f487f438bb30270905","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":3277842,"node_id":"MDEwOlJlcG9zaXRvcnkzMjc3ODQy","name":"google-api-ruby-client","full_name":"googleapis/google-api-ruby-client","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/google-api-ruby-client","description":null,"fork":false,"url":"https://api.github.com/repos/googleapis/google-api-ruby-client","forks_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/forks","keys_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/teams","hooks_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/hooks","issue_events_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/events","assignees_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/tags","blobs_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/languages","stargazers_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/stargazers","contributors_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/contributors","subscribers_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/subscribers","subscription_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/subscription","commits_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/merges","archive_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/downloads","issues_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/google-api-ruby-client/deployments","created_at":"2012-01-26T21:54:39Z","updated_at":"2018-10-09T17:48:35Z","pushed_at":"2018-10-09T19:45:17Z","git_url":"git://github.com/googleapis/google-api-ruby-client.git","ssh_url":"git@github.com:googleapis/google-api-ruby-client.git","clone_url":"https://github.com/googleapis/google-api-ruby-client.git","svn_url":"https://github.com/googleapis/google-api-ruby-client","homepage":"https://developers.google.com/api-client-library/ruby/","size":38178,"stargazers_count":1919,"watchers_count":1919,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":584,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":584,"open_issues":59,"watchers":1919,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/724"},"html":{"href":"https://github.com/googleapis/google-api-ruby-client/pull/724"},"issue":{"href":"https://api.github.com/repos/googleapis/google-api-ruby-client/issues/724"},"comments":{"href":"https://api.github.com/repos/googleapis/google-api-ruby-client/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/google-api-ruby-client/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/google-api-ruby-client/statuses/48c227b4443ac2c6c731550f77132633003241c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"blowmage"}}