{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1999","repository_url":"https://api.github.com/repos/ARMmbed/mbedtls","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1999/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1999/comments","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1999/events","html_url":"https://github.com/ARMmbed/mbedtls/pull/1999","id":356144509,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTEwMDg1","number":1999,"title":"Add limits.h inclusion to ssl_tls.c and udp_proxy.c","user":{"login":"redtangent","id":15527065,"node_id":"MDQ6VXNlcjE1NTI3MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/15527065?v=4","gravatar_id":"","url":"https://api.github.com/users/redtangent","html_url":"https://github.com/redtangent","followers_url":"https://api.github.com/users/redtangent/followers","following_url":"https://api.github.com/users/redtangent/following{/other_user}","gists_url":"https://api.github.com/users/redtangent/gists{/gist_id}","starred_url":"https://api.github.com/users/redtangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redtangent/subscriptions","organizations_url":"https://api.github.com/users/redtangent/orgs","repos_url":"https://api.github.com/users/redtangent/repos","events_url":"https://api.github.com/users/redtangent/events{/privacy}","received_events_url":"https://api.github.com/users/redtangent/received_events","type":"User","site_admin":false},"labels":[{"id":475902534,"node_id":"MDU6TGFiZWw0NzU5MDI1MzQ=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/CLA%20not%20applicable","name":"CLA not applicable","color":"bfbfbf","default":false},{"id":19280384,"node_id":"MDU6TGFiZWwxOTI4MDM4NA==","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/bug","name":"bug","color":"d93f0b","default":true},{"id":937147638,"node_id":"MDU6TGFiZWw5MzcxNDc2Mzg=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/component:%20TLS","name":"component: TLS","color":"CEE3F6","default":false},{"id":435765575,"node_id":"MDU6TGFiZWw0MzU3NjU1NzU=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs%20work","name":"needs work","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-31T22:54:30Z","updated_at":"2018-09-04T21:36:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1999","html_url":"https://github.com/ARMmbed/mbedtls/pull/1999","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1999.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1999.patch"},"body":"## Description\r\nThe standard C library header limits.h was only being included by `check_config.h` so was being missing if users provided their own config.h that didn't include `check_config.h`.\r\n\r\nThis fixes #1803.\r\n\r\n## Status\r\n**READY**\r\n\r\n## Requires Backporting\r\nYes\r\nWhich branch?\r\n`mbedtls-2.7` and `mbedtls-2.1`\r\n\r\n## Todos\r\n- [ ] Tests\r\n- [ ] Documentation\r\n- [ ] Changelog updated\r\n- [ ] Backported\r\n"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments/418526198","html_url":"https://github.com/ARMmbed/mbedtls/pull/1999#issuecomment-418526198","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1999","id":418526198,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODUyNjE5OA==","user":{"login":"redtangent","id":15527065,"node_id":"MDQ6VXNlcjE1NTI3MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/15527065?v=4","gravatar_id":"","url":"https://api.github.com/users/redtangent","html_url":"https://github.com/redtangent","followers_url":"https://api.github.com/users/redtangent/followers","following_url":"https://api.github.com/users/redtangent/following{/other_user}","gists_url":"https://api.github.com/users/redtangent/gists{/gist_id}","starred_url":"https://api.github.com/users/redtangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redtangent/subscriptions","organizations_url":"https://api.github.com/users/redtangent/orgs","repos_url":"https://api.github.com/users/redtangent/repos","events_url":"https://api.github.com/users/redtangent/events{/privacy}","received_events_url":"https://api.github.com/users/redtangent/received_events","type":"User","site_admin":false},"created_at":"2018-09-04T21:36:36Z","updated_at":"2018-09-04T21:36:36Z","author_association":"CONTRIBUTOR","body":"Added the test to `all.sh` as requested. I toyed with the idea of moving `limits.h` out of `check_config.h` but then the problem will become wherever it goes, every single include of `config.h` and therefore `check_config.h` will also have to include. Better keep it where it is in my view."}}
{"actor":{"display_login":"redtangent"}}