{"action":"created","issue":{"url":"https://api.github.com/repos/atom/atom/issues/10479","repository_url":"https://api.github.com/repos/atom/atom","labels_url":"https://api.github.com/repos/atom/atom/issues/10479/labels{/name}","comments_url":"https://api.github.com/repos/atom/atom/issues/10479/comments","events_url":"https://api.github.com/repos/atom/atom/issues/10479/events","html_url":"https://github.com/atom/atom/issues/10479","id":127281359,"number":10479,"title":"Disposing of commands doesn't remove them from the command palette?","user":{"login":"lee-dohm","id":1038121,"avatar_url":"https://avatars0.githubusercontent.com/u/1038121?v=4","gravatar_id":"","url":"https://api.github.com/users/lee-dohm","html_url":"https://github.com/lee-dohm","followers_url":"https://api.github.com/users/lee-dohm/followers","following_url":"https://api.github.com/users/lee-dohm/following{/other_user}","gists_url":"https://api.github.com/users/lee-dohm/gists{/gist_id}","starred_url":"https://api.github.com/users/lee-dohm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lee-dohm/subscriptions","organizations_url":"https://api.github.com/users/lee-dohm/orgs","repos_url":"https://api.github.com/users/lee-dohm/repos","events_url":"https://api.github.com/users/lee-dohm/events{/privacy}","received_events_url":"https://api.github.com/users/lee-dohm/received_events","type":"User","site_admin":true},"labels":[{"id":171329633,"url":"https://api.github.com/repos/atom/atom/labels/needs-reproduction","name":"needs-reproduction","color":"009800","default":false},{"id":175213356,"url":"https://api.github.com/repos/atom/atom/labels/question","name":"question","color":"ededed","default":true},{"id":601496052,"url":"https://api.github.com/repos/atom/atom/labels/stale","name":"stale","color":"e6e6e6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-01-18T18:04:24Z","updated_at":"2018-03-30T03:36:31Z","closed_at":"2017-09-12T21:09:19Z","author_association":"OWNER","body":"Trying to get to the bottom of atom/sort-lines#45, I created the code you can find on the [`ld-dispose-commands` branch of the sort-lines package.](https://github.com/atom/sort-lines/tree/ld-dispose-commands) It seems now that disposed commands don't remove themselves from the Command Palette, so they can perhaps go screwy when a package updates itself while Atom is running.\n\n**Repro Steps**\n1. Clone `ld-dispose-commands` branch of sort-lines package\n2. Execute `apm link --dev` from sort-lines repo\n3. Launch Atom in Dev Mode\n4. Open an editor using <kbd>Cmd+N</kbd>\n5. Open the Command Palette using <kbd>Shift+Cmd+P</kbd>\n6. Type `sort` to bring \"Sort Lines: Sort\" to the top\n7. Close Command Palette with <kbd>Esc</kbd>\n8. Open the Settings View with <kbd>Cmd+,</kbd>\n9. Click the Packages tab\n10. Search for `sort-lines`\n11. Click the Disable button\n12. Select the tab for the open editor\n13. Open the Command Palette using <kbd>Shift+Cmd+P</kbd>\n14. Type `sort` to bring \"Sort Lines: Sort\" to the top\n\n**Expected:** \"Sort Lines: Sort\" to **not** show up in the list\n**Actual:** \"Sort Lines: Sort\" does show up in the list\n\nTested on Atom v1.6.0-dev-f826d38 on Mac OS X 10.11.2 and Atom v1.4.0 on Mac OS X 10.11.2.\n\n/cc @atom/feedback \n"},"comment":{"url":"https://api.github.com/repos/atom/atom/issues/comments/377436685","html_url":"https://github.com/atom/atom/issues/10479#issuecomment-377436685","issue_url":"https://api.github.com/repos/atom/atom/issues/10479","id":377436685,"user":{"login":"lock[bot]","id":33595554,"avatar_url":"https://avatars1.githubusercontent.com/in/6672?v=4","gravatar_id":"","url":"https://api.github.com/users/lock%5Bbot%5D","html_url":"https://github.com/apps/lock","followers_url":"https://api.github.com/users/lock%5Bbot%5D/followers","following_url":"https://api.github.com/users/lock%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/lock%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/lock%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lock%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/lock%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/lock%5Bbot%5D/repos","events_url":"https://api.github.com/users/lock%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/lock%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-03-30T03:36:31Z","updated_at":"2018-03-30T03:36:31Z","author_association":"NONE","body":"This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in [Safe Mode](https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode) then please open a new issue and fill out [the entire issue template](https://github.com/atom/atom/blob/master/ISSUE_TEMPLATE.md) to ensure that we have enough information to address your issue. Thanks!\n"}}
{"actor":{"display_login":"lock"}}