{"action":"created","comment":{"url":"https://api.github.com/repos/modm-io/modm/pulls/comments/207747495","pull_request_review_id":143421919,"id":207747495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzc0NzQ5NQ==","diff_hunk":"@@ -72,6 +72,7 @@ program = env.Program(target=project_name+\".elf\", source=sources)\n \n # SCons functions\n env.Alias(\"cmakewrapper\", env.CMakeWrapper())\n+env.Alias(\"qtcreator\", env.QtCreatorProject(sources))","path":"tools/build_script_generator/scons/resources/SConstruct.in","position":4,"original_position":4,"commit_id":"72188b75ddaee391f45267bced0e784569e7b1b3","original_commit_id":"72188b75ddaee391f45267bced0e784569e7b1b3","user":{"login":"salkinium","id":163066,"node_id":"MDQ6VXNlcjE2MzA2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/163066?v=4","gravatar_id":"","url":"https://api.github.com/users/salkinium","html_url":"https://github.com/salkinium","followers_url":"https://api.github.com/users/salkinium/followers","following_url":"https://api.github.com/users/salkinium/following{/other_user}","gists_url":"https://api.github.com/users/salkinium/gists{/gist_id}","starred_url":"https://api.github.com/users/salkinium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salkinium/subscriptions","organizations_url":"https://api.github.com/users/salkinium/orgs","repos_url":"https://api.github.com/users/salkinium/repos","events_url":"https://api.github.com/users/salkinium/events{/privacy}","received_events_url":"https://api.github.com/users/salkinium/received_events","type":"User","site_admin":false},"body":"@rleh @chris-durand wasn't this supposed to include all files (ie. sources *and* headers)?","created_at":"2018-08-05T20:25:54Z","updated_at":"2018-08-05T20:25:55Z","html_url":"https://github.com/modm-io/modm/pull/53#discussion_r207747495","pull_request_url":"https://api.github.com/repos/modm-io/modm/pulls/53","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/modm-io/modm/pulls/comments/207747495"},"html":{"href":"https://github.com/modm-io/modm/pull/53#discussion_r207747495"},"pull_request":{"href":"https://api.github.com/repos/modm-io/modm/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/modm-io/modm/pulls/53","id":205976820,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTc2ODIw","html_url":"https://github.com/modm-io/modm/pull/53","diff_url":"https://github.com/modm-io/modm/pull/53.diff","patch_url":"https://github.com/modm-io/modm/pull/53.patch","issue_url":"https://api.github.com/repos/modm-io/modm/issues/53","number":53,"state":"open","locked":false,"title":"QtCreator project generation","user":{"login":"chris-durand","id":25187160,"node_id":"MDQ6VXNlcjI1MTg3MTYw","avatar_url":"https://avatars3.githubusercontent.com/u/25187160?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-durand","html_url":"https://github.com/chris-durand","followers_url":"https://api.github.com/users/chris-durand/followers","following_url":"https://api.github.com/users/chris-durand/following{/other_user}","gists_url":"https://api.github.com/users/chris-durand/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-durand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-durand/subscriptions","organizations_url":"https://api.github.com/users/chris-durand/orgs","repos_url":"https://api.github.com/users/chris-durand/repos","events_url":"https://api.github.com/users/chris-durand/events{/privacy}","received_events_url":"https://api.github.com/users/chris-durand/received_events","type":"User","site_admin":false},"body":"This enables the qtcreator project generator for modm. As known from xpcc, a `scons qtcreator` target is added to the generated SConstruct file, which generates a basic qtcreator project with auto-completion support.\r\n\r\n@salkinium  I don't know how to port the C++-defines feature of the xpcc qtcreator generator to modm. Is it still needed for modm? In contrast to xpcc the modm examples don't set any defines via `-D` compiler arguments.\r\n","created_at":"2018-08-03T09:36:18Z","updated_at":"2018-08-05T20:25:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13db47fbf2bd3eaf960693ea3e2664ef663cf96e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/modm-io/modm/pulls/53/commits","review_comments_url":"https://api.github.com/repos/modm-io/modm/pulls/53/comments","review_comment_url":"https://api.github.com/repos/modm-io/modm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modm-io/modm/issues/53/comments","statuses_url":"https://api.github.com/repos/modm-io/modm/statuses/72188b75ddaee391f45267bced0e784569e7b1b3","head":{"label":"chris-durand:feature/qtcreator","ref":"feature/qtcreator","sha":"72188b75ddaee391f45267bced0e784569e7b1b3","user":{"login":"chris-durand","id":25187160,"node_id":"MDQ6VXNlcjI1MTg3MTYw","avatar_url":"https://avatars3.githubusercontent.com/u/25187160?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-durand","html_url":"https://github.com/chris-durand","followers_url":"https://api.github.com/users/chris-durand/followers","following_url":"https://api.github.com/users/chris-durand/following{/other_user}","gists_url":"https://api.github.com/users/chris-durand/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-durand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-durand/subscriptions","organizations_url":"https://api.github.com/users/chris-durand/orgs","repos_url":"https://api.github.com/users/chris-durand/repos","events_url":"https://api.github.com/users/chris-durand/events{/privacy}","received_events_url":"https://api.github.com/users/chris-durand/received_events","type":"User","site_admin":false},"repo":{"id":143406949,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0MDY5NDk=","name":"modm","full_name":"chris-durand/modm","owner":{"login":"chris-durand","id":25187160,"node_id":"MDQ6VXNlcjI1MTg3MTYw","avatar_url":"https://avatars3.githubusercontent.com/u/25187160?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-durand","html_url":"https://github.com/chris-durand","followers_url":"https://api.github.com/users/chris-durand/followers","following_url":"https://api.github.com/users/chris-durand/following{/other_user}","gists_url":"https://api.github.com/users/chris-durand/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-durand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-durand/subscriptions","organizations_url":"https://api.github.com/users/chris-durand/orgs","repos_url":"https://api.github.com/users/chris-durand/repos","events_url":"https://api.github.com/users/chris-durand/events{/privacy}","received_events_url":"https://api.github.com/users/chris-durand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chris-durand/modm","description":"modm: a C++17 library generator for AVR and ARM Cortex-M devices","fork":true,"url":"https://api.github.com/repos/chris-durand/modm","forks_url":"https://api.github.com/repos/chris-durand/modm/forks","keys_url":"https://api.github.com/repos/chris-durand/modm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chris-durand/modm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chris-durand/modm/teams","hooks_url":"https://api.github.com/repos/chris-durand/modm/hooks","issue_events_url":"https://api.github.com/repos/chris-durand/modm/issues/events{/number}","events_url":"https://api.github.com/repos/chris-durand/modm/events","assignees_url":"https://api.github.com/repos/chris-durand/modm/assignees{/user}","branches_url":"https://api.github.com/repos/chris-durand/modm/branches{/branch}","tags_url":"https://api.github.com/repos/chris-durand/modm/tags","blobs_url":"https://api.github.com/repos/chris-durand/modm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chris-durand/modm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chris-durand/modm/git/refs{/sha}","trees_url":"https://api.github.com/repos/chris-durand/modm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chris-durand/modm/statuses/{sha}","languages_url":"https://api.github.com/repos/chris-durand/modm/languages","stargazers_url":"https://api.github.com/repos/chris-durand/modm/stargazers","contributors_url":"https://api.github.com/repos/chris-durand/modm/contributors","subscribers_url":"https://api.github.com/repos/chris-durand/modm/subscribers","subscription_url":"https://api.github.com/repos/chris-durand/modm/subscription","commits_url":"https://api.github.com/repos/chris-durand/modm/commits{/sha}","git_commits_url":"https://api.github.com/repos/chris-durand/modm/git/commits{/sha}","comments_url":"https://api.github.com/repos/chris-durand/modm/comments{/number}","issue_comment_url":"https://api.github.com/repos/chris-durand/modm/issues/comments{/number}","contents_url":"https://api.github.com/repos/chris-durand/modm/contents/{+path}","compare_url":"https://api.github.com/repos/chris-durand/modm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chris-durand/modm/merges","archive_url":"https://api.github.com/repos/chris-durand/modm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chris-durand/modm/downloads","issues_url":"https://api.github.com/repos/chris-durand/modm/issues{/number}","pulls_url":"https://api.github.com/repos/chris-durand/modm/pulls{/number}","milestones_url":"https://api.github.com/repos/chris-durand/modm/milestones{/number}","notifications_url":"https://api.github.com/repos/chris-durand/modm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chris-durand/modm/labels{/name}","releases_url":"https://api.github.com/repos/chris-durand/modm/releases{/id}","deployments_url":"https://api.github.com/repos/chris-durand/modm/deployments","created_at":"2018-08-03T09:21:36Z","updated_at":"2018-08-03T09:21:41Z","pushed_at":"2018-08-05T19:38:37Z","git_url":"git://github.com/chris-durand/modm.git","ssh_url":"git@github.com:chris-durand/modm.git","clone_url":"https://github.com/chris-durand/modm.git","svn_url":"https://github.com/chris-durand/modm","homepage":"http://modm.io","size":45928,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"modm-io:develop","ref":"develop","sha":"6f9fb408435e7016f1727fcb7f5fcac4ec3c19fd","user":{"login":"modm-io","id":16440376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDQwMzc2","avatar_url":"https://avatars3.githubusercontent.com/u/16440376?v=4","gravatar_id":"","url":"https://api.github.com/users/modm-io","html_url":"https://github.com/modm-io","followers_url":"https://api.github.com/users/modm-io/followers","following_url":"https://api.github.com/users/modm-io/following{/other_user}","gists_url":"https://api.github.com/users/modm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/modm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modm-io/subscriptions","organizations_url":"https://api.github.com/users/modm-io/orgs","repos_url":"https://api.github.com/users/modm-io/repos","events_url":"https://api.github.com/users/modm-io/events{/privacy}","received_events_url":"https://api.github.com/users/modm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":77459564,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQ1OTU2NA==","name":"modm","full_name":"modm-io/modm","owner":{"login":"modm-io","id":16440376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDQwMzc2","avatar_url":"https://avatars3.githubusercontent.com/u/16440376?v=4","gravatar_id":"","url":"https://api.github.com/users/modm-io","html_url":"https://github.com/modm-io","followers_url":"https://api.github.com/users/modm-io/followers","following_url":"https://api.github.com/users/modm-io/following{/other_user}","gists_url":"https://api.github.com/users/modm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/modm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modm-io/subscriptions","organizations_url":"https://api.github.com/users/modm-io/orgs","repos_url":"https://api.github.com/users/modm-io/repos","events_url":"https://api.github.com/users/modm-io/events{/privacy}","received_events_url":"https://api.github.com/users/modm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modm-io/modm","description":"modm: a C++17 library generator for AVR and ARM Cortex-M devices","fork":false,"url":"https://api.github.com/repos/modm-io/modm","forks_url":"https://api.github.com/repos/modm-io/modm/forks","keys_url":"https://api.github.com/repos/modm-io/modm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modm-io/modm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modm-io/modm/teams","hooks_url":"https://api.github.com/repos/modm-io/modm/hooks","issue_events_url":"https://api.github.com/repos/modm-io/modm/issues/events{/number}","events_url":"https://api.github.com/repos/modm-io/modm/events","assignees_url":"https://api.github.com/repos/modm-io/modm/assignees{/user}","branches_url":"https://api.github.com/repos/modm-io/modm/branches{/branch}","tags_url":"https://api.github.com/repos/modm-io/modm/tags","blobs_url":"https://api.github.com/repos/modm-io/modm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modm-io/modm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modm-io/modm/git/refs{/sha}","trees_url":"https://api.github.com/repos/modm-io/modm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modm-io/modm/statuses/{sha}","languages_url":"https://api.github.com/repos/modm-io/modm/languages","stargazers_url":"https://api.github.com/repos/modm-io/modm/stargazers","contributors_url":"https://api.github.com/repos/modm-io/modm/contributors","subscribers_url":"https://api.github.com/repos/modm-io/modm/subscribers","subscription_url":"https://api.github.com/repos/modm-io/modm/subscription","commits_url":"https://api.github.com/repos/modm-io/modm/commits{/sha}","git_commits_url":"https://api.github.com/repos/modm-io/modm/git/commits{/sha}","comments_url":"https://api.github.com/repos/modm-io/modm/comments{/number}","issue_comment_url":"https://api.github.com/repos/modm-io/modm/issues/comments{/number}","contents_url":"https://api.github.com/repos/modm-io/modm/contents/{+path}","compare_url":"https://api.github.com/repos/modm-io/modm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modm-io/modm/merges","archive_url":"https://api.github.com/repos/modm-io/modm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modm-io/modm/downloads","issues_url":"https://api.github.com/repos/modm-io/modm/issues{/number}","pulls_url":"https://api.github.com/repos/modm-io/modm/pulls{/number}","milestones_url":"https://api.github.com/repos/modm-io/modm/milestones{/number}","notifications_url":"https://api.github.com/repos/modm-io/modm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modm-io/modm/labels{/name}","releases_url":"https://api.github.com/repos/modm-io/modm/releases{/id}","deployments_url":"https://api.github.com/repos/modm-io/modm/deployments","created_at":"2016-12-27T14:01:35Z","updated_at":"2018-08-05T19:23:13Z","pushed_at":"2018-08-05T19:38:38Z","git_url":"git://github.com/modm-io/modm.git","ssh_url":"git@github.com:modm-io/modm.git","clone_url":"https://github.com/modm-io/modm.git","svn_url":"https://github.com/modm-io/modm","homepage":"http://modm.io","size":45963,"stargazers_count":58,"watchers_count":58,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":10,"watchers":58,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/modm-io/modm/pulls/53"},"html":{"href":"https://github.com/modm-io/modm/pull/53"},"issue":{"href":"https://api.github.com/repos/modm-io/modm/issues/53"},"comments":{"href":"https://api.github.com/repos/modm-io/modm/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/modm-io/modm/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/modm-io/modm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modm-io/modm/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/modm-io/modm/statuses/72188b75ddaee391f45267bced0e784569e7b1b3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"salkinium"}}