{"action":"created","issue":{"url":"https://api.github.com/repos/marshmallow-code/apispec/issues/179","repository_url":"https://api.github.com/repos/marshmallow-code/apispec","labels_url":"https://api.github.com/repos/marshmallow-code/apispec/issues/179/labels{/name}","comments_url":"https://api.github.com/repos/marshmallow-code/apispec/issues/179/comments","events_url":"https://api.github.com/repos/marshmallow-code/apispec/issues/179/events","html_url":"https://github.com/marshmallow-code/apispec/pull/179","id":289194657,"number":179,"title":"Manage only/exclude marshmallow attributes on autoreferencing schema","user":{"login":"inkhey","id":7851652,"avatar_url":"https://avatars0.githubusercontent.com/u/7851652?v=4","gravatar_id":"","url":"https://api.github.com/users/inkhey","html_url":"https://github.com/inkhey","followers_url":"https://api.github.com/users/inkhey/followers","following_url":"https://api.github.com/users/inkhey/following{/other_user}","gists_url":"https://api.github.com/users/inkhey/gists{/gist_id}","starred_url":"https://api.github.com/users/inkhey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inkhey/subscriptions","organizations_url":"https://api.github.com/users/inkhey/orgs","repos_url":"https://api.github.com/users/inkhey/repos","events_url":"https://api.github.com/users/inkhey/events{/privacy}","received_events_url":"https://api.github.com/users/inkhey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-01-17T09:25:07Z","updated_at":"2018-04-24T16:03:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/marshmallow-code/apispec/pulls/179","html_url":"https://github.com/marshmallow-code/apispec/pull/179","diff_url":"https://github.com/marshmallow-code/apispec/pull/179.diff","patch_url":"https://github.com/marshmallow-code/apispec/pull/179.patch"},"body":"Auto-referencing schema feature doesn't support specific parameters from marshmallow schema instance like `only` and `exclude`.\r\n\r\nThat's why this pull request is about auto-generate new schema class when `only` and `exclude` appear using `exclude` parameters in `opts` of schema. Apispec save also a dict of auto-generated schema class with and id system to avoid uniqueness trouble.\r\n\r\nThis patch break compatibility with old auto-referencing schema feature because `auto_referencing` boolean is now needed to activate auto-referencing and schema class returned by default to `auto_schema_name_resolver `may be not the same as before.\r\n\r\nI do think that's not a big deal because auto-ref is probably not used widely now, but this need to be discussed."},"comment":{"url":"https://api.github.com/repos/marshmallow-code/apispec/issues/comments/383987821","html_url":"https://github.com/marshmallow-code/apispec/pull/179#issuecomment-383987821","issue_url":"https://api.github.com/repos/marshmallow-code/apispec/issues/179","id":383987821,"user":{"login":"lebouquetin","id":907161,"avatar_url":"https://avatars1.githubusercontent.com/u/907161?v=4","gravatar_id":"","url":"https://api.github.com/users/lebouquetin","html_url":"https://github.com/lebouquetin","followers_url":"https://api.github.com/users/lebouquetin/followers","following_url":"https://api.github.com/users/lebouquetin/following{/other_user}","gists_url":"https://api.github.com/users/lebouquetin/gists{/gist_id}","starred_url":"https://api.github.com/users/lebouquetin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lebouquetin/subscriptions","organizations_url":"https://api.github.com/users/lebouquetin/orgs","repos_url":"https://api.github.com/users/lebouquetin/repos","events_url":"https://api.github.com/users/lebouquetin/events{/privacy}","received_events_url":"https://api.github.com/users/lebouquetin/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T16:03:22Z","updated_at":"2018-04-24T16:03:22Z","author_association":"NONE","body":"hey @sloria what about merging this MR ? \r\n\r\nFor history, we (@buxx @inkhey and I) did propose merged MR in the past. See : \r\n\r\n- https://github.com/marshmallow-code/apispec/pull/167\r\n- https://github.com/marshmallow-code/apispec/pull/162\r\n\r\nWe are working on hapic, based on apispec and we need some improvments that we prefer to have upstream.\r\n\r\nAuto-referencing feature with include/exclude support in Marshmallow schemas would be very helpfull.\r\n\r\nThank's for your answer"}}
{"actor":{"display_login":"lebouquetin"}}