{"action":"created","issue":{"url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/314","repository_url":"https://api.github.com/repos/rebeccahughes/react-native-device-info","labels_url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/314/comments","events_url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/314/events","html_url":"https://github.com/rebeccahughes/react-native-device-info/issues/314","id":294836957,"number":314,"title":"API inconsistent about how to write ID or Id","user":{"login":"ddresch","id":986306,"avatar_url":"https://avatars3.githubusercontent.com/u/986306?v=4","gravatar_id":"","url":"https://api.github.com/users/ddresch","html_url":"https://github.com/ddresch","followers_url":"https://api.github.com/users/ddresch/followers","following_url":"https://api.github.com/users/ddresch/following{/other_user}","gists_url":"https://api.github.com/users/ddresch/gists{/gist_id}","starred_url":"https://api.github.com/users/ddresch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddresch/subscriptions","organizations_url":"https://api.github.com/users/ddresch/orgs","repos_url":"https://api.github.com/users/ddresch/repos","events_url":"https://api.github.com/users/ddresch/events{/privacy}","received_events_url":"https://api.github.com/users/ddresch/received_events","type":"User","site_admin":false},"labels":[{"id":825607590,"url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/labels/docs","name":"docs","color":"89b4f9","default":false},{"id":261170316,"url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/labels/help%20wanted","name":"help wanted","color":"159818","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-06T17:02:25Z","updated_at":"2018-02-06T19:20:17Z","closed_at":null,"author_association":"NONE","body":"I ran into the problem the method `getUniqueId()` was not found. Checking the README you can see the example for this method is incorrect.\r\n\r\n```JS\r\nconst uniqueId = DeviceInfo.getUniqueId();\r\n\r\n// iOS: \"FCDBD8EF-62FC-4ECB-B2F5-92C9E79AC7F9\"\r\n// Android: \"dd96dec43fb81c97\"\r\n// Windows: ?\r\n```\r\n\r\nThe method is called `getUniqueID()` so changing the Docs is the simple way but I think it's better to make it more consistent across the API.\r\n\r\n```JS\r\ngetBundleId()\r\ngetDeviceId()\r\ngetInstanceID()\r\ngetUniqueID()\r\n```\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/comments/363534663","html_url":"https://github.com/rebeccahughes/react-native-device-info/issues/314#issuecomment-363534663","issue_url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/314","id":363534663,"user":{"login":"ddresch","id":986306,"avatar_url":"https://avatars3.githubusercontent.com/u/986306?v=4","gravatar_id":"","url":"https://api.github.com/users/ddresch","html_url":"https://github.com/ddresch","followers_url":"https://api.github.com/users/ddresch/followers","following_url":"https://api.github.com/users/ddresch/following{/other_user}","gists_url":"https://api.github.com/users/ddresch/gists{/gist_id}","starred_url":"https://api.github.com/users/ddresch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddresch/subscriptions","organizations_url":"https://api.github.com/users/ddresch/orgs","repos_url":"https://api.github.com/users/ddresch/repos","events_url":"https://api.github.com/users/ddresch/events{/privacy}","received_events_url":"https://api.github.com/users/ddresch/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T19:20:17Z","updated_at":"2018-02-06T19:20:17Z","author_association":"NONE","body":"PR is done ;-) #315 "}}
{"actor":{"display_login":"ddresch"}}