{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/content-publisher/pulls/comments/214391013","pull_request_review_id":151444313,"id":214391013,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDM5MTAxMw==","diff_hunk":"@@ -20,5 +20,6 @@ def then_i_see_the_document_summary\n     expect(page).to have_content(@document.summary)\n     expect(page).to have_content(@document.created_at.strftime(\"%l:%M%P on %d %B %Y\"))\n     expect(page).to have_content(@document.updated_at.strftime(\"%l:%M%P on %d %B %Y\"))\n+    expect(page).to have_content(I18n.t(\"documents.show.metadata.created_by\") + \": \" + @document.creator.name)","path":"spec/features/show_a_document_spec.rb","position":4,"original_position":4,"commit_id":"55ca176aa37301eafe1a6a91800fdbae94ac6ffe","original_commit_id":"55ca176aa37301eafe1a6a91800fdbae94ac6ffe","user":{"login":"emmabeynon","id":13434452,"node_id":"MDQ6VXNlcjEzNDM0NDUy","avatar_url":"https://avatars3.githubusercontent.com/u/13434452?v=4","gravatar_id":"","url":"https://api.github.com/users/emmabeynon","html_url":"https://github.com/emmabeynon","followers_url":"https://api.github.com/users/emmabeynon/followers","following_url":"https://api.github.com/users/emmabeynon/following{/other_user}","gists_url":"https://api.github.com/users/emmabeynon/gists{/gist_id}","starred_url":"https://api.github.com/users/emmabeynon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmabeynon/subscriptions","organizations_url":"https://api.github.com/users/emmabeynon/orgs","repos_url":"https://api.github.com/users/emmabeynon/repos","events_url":"https://api.github.com/users/emmabeynon/events{/privacy}","received_events_url":"https://api.github.com/users/emmabeynon/received_events","type":"User","site_admin":false},"body":"Ah so the reason I had to include this was that without it the test would pass as the creator's name would already appear in the page in the top right hand corner.  This helps make sure we're testing the right thing.","created_at":"2018-08-31T15:28:30Z","updated_at":"2018-08-31T15:28:30Z","html_url":"https://github.com/alphagov/content-publisher/pull/189#discussion_r214391013","pull_request_url":"https://api.github.com/repos/alphagov/content-publisher/pulls/189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/content-publisher/pulls/comments/214391013"},"html":{"href":"https://github.com/alphagov/content-publisher/pull/189#discussion_r214391013"},"pull_request":{"href":"https://api.github.com/repos/alphagov/content-publisher/pulls/189"}},"in_reply_to_id":214383770},"pull_request":{"url":"https://api.github.com/repos/alphagov/content-publisher/pulls/189","id":212091252,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDkxMjUy","html_url":"https://github.com/alphagov/content-publisher/pull/189","diff_url":"https://github.com/alphagov/content-publisher/pull/189.diff","patch_url":"https://github.com/alphagov/content-publisher/pull/189.patch","issue_url":"https://api.github.com/repos/alphagov/content-publisher/issues/189","number":189,"state":"open","locked":false,"title":"Associate document with user who created it","user":{"login":"emmabeynon","id":13434452,"node_id":"MDQ6VXNlcjEzNDM0NDUy","avatar_url":"https://avatars3.githubusercontent.com/u/13434452?v=4","gravatar_id":"","url":"https://api.github.com/users/emmabeynon","html_url":"https://github.com/emmabeynon","followers_url":"https://api.github.com/users/emmabeynon/followers","following_url":"https://api.github.com/users/emmabeynon/following{/other_user}","gists_url":"https://api.github.com/users/emmabeynon/gists{/gist_id}","starred_url":"https://api.github.com/users/emmabeynon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmabeynon/subscriptions","organizations_url":"https://api.github.com/users/emmabeynon/orgs","repos_url":"https://api.github.com/users/emmabeynon/repos","events_url":"https://api.github.com/users/emmabeynon/events{/privacy}","received_events_url":"https://api.github.com/users/emmabeynon/received_events","type":"User","site_admin":false},"body":"For https://trello.com/c/Th0t8cUb/165-associate-a-document-with-the-user-who-created-it\r\n\r\nIn this PR we associate a document with a creator so we're able to look up who created it.  This allows us to display information about the person who created the document; for now it will just be the creator's name on the document summary page, but in future could include their organisation for example.\r\n\r\n<img width=\"370\" alt=\"screen shot 2018-08-30 at 14 13 36\" src=\"https://user-images.githubusercontent.com/13434452/44856763-227c1900-ac66-11e8-9b16-aa5b4e13e387.png\">\r\n\r\nWe also handle instances where a document has no creator by displaying it as \"Unknown\".","created_at":"2018-08-30T14:03:58Z","updated_at":"2018-08-31T15:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e9381e740fa3a704d0147941120e902a7f83f58","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/content-publisher/pulls/189/commits","review_comments_url":"https://api.github.com/repos/alphagov/content-publisher/pulls/189/comments","review_comment_url":"https://api.github.com/repos/alphagov/content-publisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/content-publisher/issues/189/comments","statuses_url":"https://api.github.com/repos/alphagov/content-publisher/statuses/55ca176aa37301eafe1a6a91800fdbae94ac6ffe","head":{"label":"alphagov:associate-document-with-user-who-created-it","ref":"associate-document-with-user-who-created-it","sha":"55ca176aa37301eafe1a6a91800fdbae94ac6ffe","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":140405637,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MDU2Mzc=","name":"content-publisher","full_name":"alphagov/content-publisher","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/content-publisher","description":"WIP - Future publisher of content on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/content-publisher","forks_url":"https://api.github.com/repos/alphagov/content-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/content-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/content-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/content-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/content-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/content-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/content-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/content-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/content-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/content-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/content-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/content-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/content-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/content-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/content-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/content-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/content-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/content-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/content-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/content-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/content-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/content-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/content-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/content-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/content-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/content-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/content-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/content-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/content-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/content-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/content-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/content-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/content-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/content-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/content-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/content-publisher/deployments","created_at":"2018-07-10T09:00:26Z","updated_at":"2018-08-31T09:42:19Z","pushed_at":"2018-08-31T13:01:20Z","git_url":"git://github.com/alphagov/content-publisher.git","ssh_url":"git@github.com:alphagov/content-publisher.git","clone_url":"https://github.com/alphagov/content-publisher.git","svn_url":"https://github.com/alphagov/content-publisher","homepage":"https://docs.publishing.service.gov.uk/apps/content-publisher.html","size":1459,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"24dffe1a5132cf47a1cfff99c5ecd59d190e5c25","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":140405637,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MDU2Mzc=","name":"content-publisher","full_name":"alphagov/content-publisher","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/content-publisher","description":"WIP - Future publisher of content on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/content-publisher","forks_url":"https://api.github.com/repos/alphagov/content-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/content-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/content-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/content-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/content-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/content-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/content-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/content-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/content-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/content-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/content-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/content-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/content-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/content-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/content-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/content-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/content-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/content-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/content-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/content-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/content-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/content-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/content-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/content-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/content-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/content-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/content-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/content-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/content-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/content-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/content-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/content-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/content-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/content-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/content-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/content-publisher/deployments","created_at":"2018-07-10T09:00:26Z","updated_at":"2018-08-31T09:42:19Z","pushed_at":"2018-08-31T13:01:20Z","git_url":"git://github.com/alphagov/content-publisher.git","ssh_url":"git@github.com:alphagov/content-publisher.git","clone_url":"https://github.com/alphagov/content-publisher.git","svn_url":"https://github.com/alphagov/content-publisher","homepage":"https://docs.publishing.service.gov.uk/apps/content-publisher.html","size":1459,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/content-publisher/pulls/189"},"html":{"href":"https://github.com/alphagov/content-publisher/pull/189"},"issue":{"href":"https://api.github.com/repos/alphagov/content-publisher/issues/189"},"comments":{"href":"https://api.github.com/repos/alphagov/content-publisher/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/content-publisher/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/content-publisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/content-publisher/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/content-publisher/statuses/55ca176aa37301eafe1a6a91800fdbae94ac6ffe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"emmabeynon"}}