{"action":"created","comment":{"url":"https://api.github.com/repos/rustwasm/twiggy/pulls/comments/201470126","pull_request_review_id":135979691,"id":201470126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQ3MDEyNg==","diff_hunk":"@@ -13,6 +13,7 @@ path = \"./traits.rs\"\n \n [dependencies]\n failure = \"0.1.1\"\n+gimli = \"0.16.0\"","path":"traits/Cargo.toml","position":4,"original_position":4,"commit_id":"82ecd65dac9128f1e8b66e1896e5f83852c90b09","original_commit_id":"82ecd65dac9128f1e8b66e1896e5f83852c90b09","user":{"login":"fitzgen","id":74571,"node_id":"MDQ6VXNlcjc0NTcx","avatar_url":"https://avatars2.githubusercontent.com/u/74571?v=4","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"body":"This dependency should be optional, and only enabled when the parser has the `dwarf` feature enabled.","created_at":"2018-07-10T19:44:13Z","updated_at":"2018-07-10T19:46:06Z","html_url":"https://github.com/rustwasm/twiggy/pull/74#discussion_r201470126","pull_request_url":"https://api.github.com/repos/rustwasm/twiggy/pulls/74","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rustwasm/twiggy/pulls/comments/201470126"},"html":{"href":"https://github.com/rustwasm/twiggy/pull/74#discussion_r201470126"},"pull_request":{"href":"https://api.github.com/repos/rustwasm/twiggy/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/rustwasm/twiggy/pulls/74","id":198784907,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Nzg0OTA3","html_url":"https://github.com/rustwasm/twiggy/pull/74","diff_url":"https://github.com/rustwasm/twiggy/pull/74.diff","patch_url":"https://github.com/rustwasm/twiggy/pull/74.patch","issue_url":"https://api.github.com/repos/rustwasm/twiggy/issues/74","number":74,"state":"open","locked":false,"title":"Added experimental ELF/Mach-O/PE compatibility using gimli/object.","user":{"login":"data-pup","id":16364986,"node_id":"MDQ6VXNlcjE2MzY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/16364986?v=4","gravatar_id":"","url":"https://api.github.com/users/data-pup","html_url":"https://github.com/data-pup","followers_url":"https://api.github.com/users/data-pup/followers","following_url":"https://api.github.com/users/data-pup/following{/other_user}","gists_url":"https://api.github.com/users/data-pup/gists{/gist_id}","starred_url":"https://api.github.com/users/data-pup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/data-pup/subscriptions","organizations_url":"https://api.github.com/users/data-pup/orgs","repos_url":"https://api.github.com/users/data-pup/repos","events_url":"https://api.github.com/users/data-pup/events{/privacy}","received_events_url":"https://api.github.com/users/data-pup/received_events","type":"User","site_admin":false},"body":"This PR aims to introduce the ability to parse subroutines from an ELF/Mach-O binary, using the gimli/object crates.\r\n\r\nFixes #69.","created_at":"2018-07-02T20:44:49Z","updated_at":"2018-07-10T19:46:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7de28d14edb32a92d54f01aede99f85bf09dda74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rustwasm/twiggy/pulls/74/commits","review_comments_url":"https://api.github.com/repos/rustwasm/twiggy/pulls/74/comments","review_comment_url":"https://api.github.com/repos/rustwasm/twiggy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rustwasm/twiggy/issues/74/comments","statuses_url":"https://api.github.com/repos/rustwasm/twiggy/statuses/82ecd65dac9128f1e8b66e1896e5f83852c90b09","head":{"label":"data-pup:binary-compat","ref":"binary-compat","sha":"82ecd65dac9128f1e8b66e1896e5f83852c90b09","user":{"login":"data-pup","id":16364986,"node_id":"MDQ6VXNlcjE2MzY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/16364986?v=4","gravatar_id":"","url":"https://api.github.com/users/data-pup","html_url":"https://github.com/data-pup","followers_url":"https://api.github.com/users/data-pup/followers","following_url":"https://api.github.com/users/data-pup/following{/other_user}","gists_url":"https://api.github.com/users/data-pup/gists{/gist_id}","starred_url":"https://api.github.com/users/data-pup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/data-pup/subscriptions","organizations_url":"https://api.github.com/users/data-pup/orgs","repos_url":"https://api.github.com/users/data-pup/repos","events_url":"https://api.github.com/users/data-pup/events{/privacy}","received_events_url":"https://api.github.com/users/data-pup/received_events","type":"User","site_admin":false},"repo":{"id":132482832,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0ODI4MzI=","name":"twiggy","full_name":"data-pup/twiggy","owner":{"login":"data-pup","id":16364986,"node_id":"MDQ6VXNlcjE2MzY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/16364986?v=4","gravatar_id":"","url":"https://api.github.com/users/data-pup","html_url":"https://github.com/data-pup","followers_url":"https://api.github.com/users/data-pup/followers","following_url":"https://api.github.com/users/data-pup/following{/other_user}","gists_url":"https://api.github.com/users/data-pup/gists{/gist_id}","starred_url":"https://api.github.com/users/data-pup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/data-pup/subscriptions","organizations_url":"https://api.github.com/users/data-pup/orgs","repos_url":"https://api.github.com/users/data-pup/repos","events_url":"https://api.github.com/users/data-pup/events{/privacy}","received_events_url":"https://api.github.com/users/data-pup/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/data-pup/twiggy","description":"Twiggy is a code size profiler","fork":true,"url":"https://api.github.com/repos/data-pup/twiggy","forks_url":"https://api.github.com/repos/data-pup/twiggy/forks","keys_url":"https://api.github.com/repos/data-pup/twiggy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/data-pup/twiggy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/data-pup/twiggy/teams","hooks_url":"https://api.github.com/repos/data-pup/twiggy/hooks","issue_events_url":"https://api.github.com/repos/data-pup/twiggy/issues/events{/number}","events_url":"https://api.github.com/repos/data-pup/twiggy/events","assignees_url":"https://api.github.com/repos/data-pup/twiggy/assignees{/user}","branches_url":"https://api.github.com/repos/data-pup/twiggy/branches{/branch}","tags_url":"https://api.github.com/repos/data-pup/twiggy/tags","blobs_url":"https://api.github.com/repos/data-pup/twiggy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/data-pup/twiggy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/data-pup/twiggy/git/refs{/sha}","trees_url":"https://api.github.com/repos/data-pup/twiggy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/data-pup/twiggy/statuses/{sha}","languages_url":"https://api.github.com/repos/data-pup/twiggy/languages","stargazers_url":"https://api.github.com/repos/data-pup/twiggy/stargazers","contributors_url":"https://api.github.com/repos/data-pup/twiggy/contributors","subscribers_url":"https://api.github.com/repos/data-pup/twiggy/subscribers","subscription_url":"https://api.github.com/repos/data-pup/twiggy/subscription","commits_url":"https://api.github.com/repos/data-pup/twiggy/commits{/sha}","git_commits_url":"https://api.github.com/repos/data-pup/twiggy/git/commits{/sha}","comments_url":"https://api.github.com/repos/data-pup/twiggy/comments{/number}","issue_comment_url":"https://api.github.com/repos/data-pup/twiggy/issues/comments{/number}","contents_url":"https://api.github.com/repos/data-pup/twiggy/contents/{+path}","compare_url":"https://api.github.com/repos/data-pup/twiggy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/data-pup/twiggy/merges","archive_url":"https://api.github.com/repos/data-pup/twiggy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/data-pup/twiggy/downloads","issues_url":"https://api.github.com/repos/data-pup/twiggy/issues{/number}","pulls_url":"https://api.github.com/repos/data-pup/twiggy/pulls{/number}","milestones_url":"https://api.github.com/repos/data-pup/twiggy/milestones{/number}","notifications_url":"https://api.github.com/repos/data-pup/twiggy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/data-pup/twiggy/labels{/name}","releases_url":"https://api.github.com/repos/data-pup/twiggy/releases{/id}","deployments_url":"https://api.github.com/repos/data-pup/twiggy/deployments","created_at":"2018-05-07T15:46:32Z","updated_at":"2018-07-10T17:25:34Z","pushed_at":"2018-07-10T18:10:40Z","git_url":"git://github.com/data-pup/twiggy.git","ssh_url":"git@github.com:data-pup/twiggy.git","clone_url":"https://github.com/data-pup/twiggy.git","svn_url":"https://github.com/data-pup/twiggy","homepage":"","size":1881,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rustwasm:master","ref":"master","sha":"05881eedb20a15b89ce9c4c4002ed19c3cc14ee8","user":{"login":"rustwasm","id":37272798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjcyNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/37272798?v=4","gravatar_id":"","url":"https://api.github.com/users/rustwasm","html_url":"https://github.com/rustwasm","followers_url":"https://api.github.com/users/rustwasm/followers","following_url":"https://api.github.com/users/rustwasm/following{/other_user}","gists_url":"https://api.github.com/users/rustwasm/gists{/gist_id}","starred_url":"https://api.github.com/users/rustwasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustwasm/subscriptions","organizations_url":"https://api.github.com/users/rustwasm/orgs","repos_url":"https://api.github.com/users/rustwasm/repos","events_url":"https://api.github.com/users/rustwasm/events{/privacy}","received_events_url":"https://api.github.com/users/rustwasm/received_events","type":"Organization","site_admin":false},"repo":{"id":120971961,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NzE5NjE=","name":"twiggy","full_name":"rustwasm/twiggy","owner":{"login":"rustwasm","id":37272798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjcyNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/37272798?v=4","gravatar_id":"","url":"https://api.github.com/users/rustwasm","html_url":"https://github.com/rustwasm","followers_url":"https://api.github.com/users/rustwasm/followers","following_url":"https://api.github.com/users/rustwasm/following{/other_user}","gists_url":"https://api.github.com/users/rustwasm/gists{/gist_id}","starred_url":"https://api.github.com/users/rustwasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustwasm/subscriptions","organizations_url":"https://api.github.com/users/rustwasm/orgs","repos_url":"https://api.github.com/users/rustwasm/repos","events_url":"https://api.github.com/users/rustwasm/events{/privacy}","received_events_url":"https://api.github.com/users/rustwasm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rustwasm/twiggy","description":"Twiggy is a code size profiler","fork":false,"url":"https://api.github.com/repos/rustwasm/twiggy","forks_url":"https://api.github.com/repos/rustwasm/twiggy/forks","keys_url":"https://api.github.com/repos/rustwasm/twiggy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rustwasm/twiggy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rustwasm/twiggy/teams","hooks_url":"https://api.github.com/repos/rustwasm/twiggy/hooks","issue_events_url":"https://api.github.com/repos/rustwasm/twiggy/issues/events{/number}","events_url":"https://api.github.com/repos/rustwasm/twiggy/events","assignees_url":"https://api.github.com/repos/rustwasm/twiggy/assignees{/user}","branches_url":"https://api.github.com/repos/rustwasm/twiggy/branches{/branch}","tags_url":"https://api.github.com/repos/rustwasm/twiggy/tags","blobs_url":"https://api.github.com/repos/rustwasm/twiggy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rustwasm/twiggy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rustwasm/twiggy/git/refs{/sha}","trees_url":"https://api.github.com/repos/rustwasm/twiggy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rustwasm/twiggy/statuses/{sha}","languages_url":"https://api.github.com/repos/rustwasm/twiggy/languages","stargazers_url":"https://api.github.com/repos/rustwasm/twiggy/stargazers","contributors_url":"https://api.github.com/repos/rustwasm/twiggy/contributors","subscribers_url":"https://api.github.com/repos/rustwasm/twiggy/subscribers","subscription_url":"https://api.github.com/repos/rustwasm/twiggy/subscription","commits_url":"https://api.github.com/repos/rustwasm/twiggy/commits{/sha}","git_commits_url":"https://api.github.com/repos/rustwasm/twiggy/git/commits{/sha}","comments_url":"https://api.github.com/repos/rustwasm/twiggy/comments{/number}","issue_comment_url":"https://api.github.com/repos/rustwasm/twiggy/issues/comments{/number}","contents_url":"https://api.github.com/repos/rustwasm/twiggy/contents/{+path}","compare_url":"https://api.github.com/repos/rustwasm/twiggy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rustwasm/twiggy/merges","archive_url":"https://api.github.com/repos/rustwasm/twiggy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rustwasm/twiggy/downloads","issues_url":"https://api.github.com/repos/rustwasm/twiggy/issues{/number}","pulls_url":"https://api.github.com/repos/rustwasm/twiggy/pulls{/number}","milestones_url":"https://api.github.com/repos/rustwasm/twiggy/milestones{/number}","notifications_url":"https://api.github.com/repos/rustwasm/twiggy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rustwasm/twiggy/labels{/name}","releases_url":"https://api.github.com/repos/rustwasm/twiggy/releases{/id}","deployments_url":"https://api.github.com/repos/rustwasm/twiggy/deployments","created_at":"2018-02-10T01:01:51Z","updated_at":"2018-07-09T11:46:07Z","pushed_at":"2018-07-10T18:10:42Z","git_url":"git://github.com/rustwasm/twiggy.git","ssh_url":"git@github.com:rustwasm/twiggy.git","clone_url":"https://github.com/rustwasm/twiggy.git","svn_url":"https://github.com/rustwasm/twiggy","homepage":"","size":399,"stargazers_count":170,"watchers_count":170,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":12,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rustwasm/twiggy/pulls/74"},"html":{"href":"https://github.com/rustwasm/twiggy/pull/74"},"issue":{"href":"https://api.github.com/repos/rustwasm/twiggy/issues/74"},"comments":{"href":"https://api.github.com/repos/rustwasm/twiggy/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/rustwasm/twiggy/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/rustwasm/twiggy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rustwasm/twiggy/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/rustwasm/twiggy/statuses/82ecd65dac9128f1e8b66e1896e5f83852c90b09"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fitzgen"}}