{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/che/issues/11446","repository_url":"https://api.github.com/repos/eclipse/che","labels_url":"https://api.github.com/repos/eclipse/che/issues/11446/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/che/issues/11446/comments","events_url":"https://api.github.com/repos/eclipse/che/issues/11446/events","html_url":"https://github.com/eclipse/che/pull/11446","id":366073980,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODQwNjEz","number":11446,"title":"Don't stop workspace recovery when error is encountered","user":{"login":"amisevsk","id":16168279,"node_id":"MDQ6VXNlcjE2MTY4Mjc5","avatar_url":"https://avatars1.githubusercontent.com/u/16168279?v=4","gravatar_id":"","url":"https://api.github.com/users/amisevsk","html_url":"https://github.com/amisevsk","followers_url":"https://api.github.com/users/amisevsk/followers","following_url":"https://api.github.com/users/amisevsk/following{/other_user}","gists_url":"https://api.github.com/users/amisevsk/gists{/gist_id}","starred_url":"https://api.github.com/users/amisevsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amisevsk/subscriptions","organizations_url":"https://api.github.com/users/amisevsk/orgs","repos_url":"https://api.github.com/users/amisevsk/repos","events_url":"https://api.github.com/users/amisevsk/events{/privacy}","received_events_url":"https://api.github.com/users/amisevsk/received_events","type":"User","site_admin":false},"labels":[{"id":192367926,"node_id":"MDU6TGFiZWwxOTIzNjc5MjY=","url":"https://api.github.com/repos/eclipse/che/labels/kind/bug","name":"kind/bug","color":"fc2929","default":false},{"id":345100523,"node_id":"MDU6TGFiZWwzNDUxMDA1MjM=","url":"https://api.github.com/repos/eclipse/che/labels/status/code-review","name":"status/code-review","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-02T20:49:43Z","updated_at":"2018-10-03T14:19:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/che/pulls/11446","html_url":"https://github.com/eclipse/che/pull/11446","diff_url":"https://github.com/eclipse/che/pull/11446.diff","patch_url":"https://github.com/eclipse/che/pull/11446.patch"},"body":"Fix issue where encountering an exception while recovering workspaces on startup prevents recovery of further workspaces.\r\n\r\n### What does this PR do?\r\nFix issue where encountering an exception while recovering workspaces on startup prevents recovery of further workspaces.\r\n\r\n### What issues does this PR fix or reference?\r\nhttps://github.com/eclipse/che/issues/11445\r\n\r\n### Testing\r\n1. Start Che multiuser on minishift\r\n2. Start a few workspaces\r\n3. Scale Che server down to 0\r\n4. modify postgres database to set `owner_id` to 0 for some workspace in table `che_k8s_runtime`\r\n5. restart Che server\r\nlogs contain something like:\r\n```\r\n2018-10-02 20:41:56,358[ost-startStop-1]  [ERROR] [o.e.c.a.w.s.WorkspaceRuntimes 544]   - An error occurred while attempted to recover runtimes using infrastructure 'openshift'. Reason: 'Couldn't recover runtime 'workspace3ob15dnpujw9eamy:default'. Error: The user `0` doesn't have the required `use` permission for workspace `workspace3ob15dnpujw9eamy`'\r\n2018-10-02 20:41:57,647[ost-startStop-1]  [INFO ] [o.e.c.a.w.s.WorkspaceRuntimes 590]   - Successfully recovered workspace runtime 'workspacekvgznl4cdef4u8r7'\r\n2018-10-02 20:41:57,739[ost-startStop-1]  [INFO ] [o.e.c.a.w.s.WorkspaceRuntimes 590]   - Successfully recovered workspace runtime 'workspacec7tt9hc681m1uvr7'\r\n```\r\nand workspaces that can be recovered are. Workspace that had `owner_id` modified is listed as \"not running\" in Che, and deployment is not cleaned up, but there's not much we can do there.\r\n\r\nAdditionally, this will allow logging of all recovery errors, so this could be used to better track recovery bugs."},"comment":{"url":"https://api.github.com/repos/eclipse/che/issues/comments/426655175","html_url":"https://github.com/eclipse/che/pull/11446#issuecomment-426655175","issue_url":"https://api.github.com/repos/eclipse/che/issues/11446","id":426655175,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjY1NTE3NQ==","user":{"login":"amisevsk","id":16168279,"node_id":"MDQ6VXNlcjE2MTY4Mjc5","avatar_url":"https://avatars1.githubusercontent.com/u/16168279?v=4","gravatar_id":"","url":"https://api.github.com/users/amisevsk","html_url":"https://github.com/amisevsk","followers_url":"https://api.github.com/users/amisevsk/followers","following_url":"https://api.github.com/users/amisevsk/following{/other_user}","gists_url":"https://api.github.com/users/amisevsk/gists{/gist_id}","starred_url":"https://api.github.com/users/amisevsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amisevsk/subscriptions","organizations_url":"https://api.github.com/users/amisevsk/orgs","repos_url":"https://api.github.com/users/amisevsk/repos","events_url":"https://api.github.com/users/amisevsk/events{/privacy}","received_events_url":"https://api.github.com/users/amisevsk/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T14:19:40Z","updated_at":"2018-10-03T14:19:40Z","author_association":"CONTRIBUTOR","body":"ci-test"}}
{"actor":{"display_login":"amisevsk"}}