{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/che/pulls/comments/191668797","pull_request_review_id":124281312,"id":191668797,"diff_hunk":"@@ -318,8 +319,7 @@ private RegisteredProject doImportInternally(\n         projectConfigRegistry.put(newProjectConfig, true, false);\n       }\n \n-      return projectConfigRegistry\n-          .get(wsPath)\n+      return Optional.ofNullable(projectConfigRegistry.getOrNull(wsPath))","path":"wsagent/che-core-api-project/src/main/java/org/eclipse/che/api/project/server/impl/ProjectImportManager.java","position":14,"original_position":14,"commit_id":"56377b857d3442772374684d8f9c18d49e645570","original_commit_id":"3a680bc380cb50857875e0e8714a010f788b1fe3","user":{"login":"gazarenkov","id":578124,"avatar_url":"https://avatars0.githubusercontent.com/u/578124?v=4","gravatar_id":"","url":"https://api.github.com/users/gazarenkov","html_url":"https://github.com/gazarenkov","followers_url":"https://api.github.com/users/gazarenkov/followers","following_url":"https://api.github.com/users/gazarenkov/following{/other_user}","gists_url":"https://api.github.com/users/gazarenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/gazarenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gazarenkov/subscriptions","organizations_url":"https://api.github.com/users/gazarenkov/orgs","repos_url":"https://api.github.com/users/gazarenkov/repos","events_url":"https://api.github.com/users/gazarenkov/events{/privacy}","received_events_url":"https://api.github.com/users/gazarenkov/received_events","type":"User","site_admin":false},"body":"@RomanNikitenko I guess you are right, just considered it as risky at that time :)\r\nif you or @dkuleshov think it is totally safe - will fix it immediatelly\r\nWDYT?","created_at":"2018-05-30T07:39:36Z","updated_at":"2018-05-30T07:39:37Z","html_url":"https://github.com/eclipse/che/pull/9848#discussion_r191668797","pull_request_url":"https://api.github.com/repos/eclipse/che/pulls/9848","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments/191668797"},"html":{"href":"https://github.com/eclipse/che/pull/9848#discussion_r191668797"},"pull_request":{"href":"https://api.github.com/repos/eclipse/che/pulls/9848"}},"in_reply_to_id":191668144},"pull_request":{"url":"https://api.github.com/repos/eclipse/che/pulls/9848","id":191100981,"html_url":"https://github.com/eclipse/che/pull/9848","diff_url":"https://github.com/eclipse/che/pull/9848.diff","patch_url":"https://github.com/eclipse/che/pull/9848.patch","issue_url":"https://api.github.com/repos/eclipse/che/issues/9848","number":9848,"state":"open","locked":false,"title":"Make it possible to have distributed ProjectRegistry","user":{"login":"gazarenkov","id":578124,"avatar_url":"https://avatars0.githubusercontent.com/u/578124?v=4","gravatar_id":"","url":"https://api.github.com/users/gazarenkov","html_url":"https://github.com/gazarenkov","followers_url":"https://api.github.com/users/gazarenkov/followers","following_url":"https://api.github.com/users/gazarenkov/following{/other_user}","gists_url":"https://api.github.com/users/gazarenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/gazarenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gazarenkov/subscriptions","organizations_url":"https://api.github.com/users/gazarenkov/orgs","repos_url":"https://api.github.com/users/gazarenkov/repos","events_url":"https://api.github.com/users/gazarenkov/events{/privacy}","received_events_url":"https://api.github.com/users/gazarenkov/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n- Remake ProjectRegistry as interface and make current (inmemory) registry as default implementation\r\n- Create RegisteredProject as interface (moved to shared package) with corresponding DTO\r\n- Create experimental PersistingProjectRegistry implementation which caches current project state in the shared Project storage (under /<projects-root>/.che/tmp/projectConfig directory)\r\n- RootDirPathProvider instead of direct using property for flexibility (caused a lot of changes in code)\r\n\r\n### What issues does this PR fix or reference?\r\nas stated in the title\r\n\r\n\r\n#### Docs PR\r\nn/a yet\r\n","created_at":"2018-05-29T10:32:17Z","updated_at":"2018-05-30T07:39:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f196e5a70e708b9a17bce444f49d077dc715ef4a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"evidolob","id":929743,"avatar_url":"https://avatars0.githubusercontent.com/u/929743?v=4","gravatar_id":"","url":"https://api.github.com/users/evidolob","html_url":"https://github.com/evidolob","followers_url":"https://api.github.com/users/evidolob/followers","following_url":"https://api.github.com/users/evidolob/following{/other_user}","gists_url":"https://api.github.com/users/evidolob/gists{/gist_id}","starred_url":"https://api.github.com/users/evidolob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evidolob/subscriptions","organizations_url":"https://api.github.com/users/evidolob/orgs","repos_url":"https://api.github.com/users/evidolob/repos","events_url":"https://api.github.com/users/evidolob/events{/privacy}","received_events_url":"https://api.github.com/users/evidolob/received_events","type":"User","site_admin":false},{"login":"musienko-maxim","id":1640058,"avatar_url":"https://avatars2.githubusercontent.com/u/1640058?v=4","gravatar_id":"","url":"https://api.github.com/users/musienko-maxim","html_url":"https://github.com/musienko-maxim","followers_url":"https://api.github.com/users/musienko-maxim/followers","following_url":"https://api.github.com/users/musienko-maxim/following{/other_user}","gists_url":"https://api.github.com/users/musienko-maxim/gists{/gist_id}","starred_url":"https://api.github.com/users/musienko-maxim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musienko-maxim/subscriptions","organizations_url":"https://api.github.com/users/musienko-maxim/orgs","repos_url":"https://api.github.com/users/musienko-maxim/repos","events_url":"https://api.github.com/users/musienko-maxim/events{/privacy}","received_events_url":"https://api.github.com/users/musienko-maxim/received_events","type":"User","site_admin":false},{"login":"tolusha","id":1640675,"avatar_url":"https://avatars2.githubusercontent.com/u/1640675?v=4","gravatar_id":"","url":"https://api.github.com/users/tolusha","html_url":"https://github.com/tolusha","followers_url":"https://api.github.com/users/tolusha/followers","following_url":"https://api.github.com/users/tolusha/following{/other_user}","gists_url":"https://api.github.com/users/tolusha/gists{/gist_id}","starred_url":"https://api.github.com/users/tolusha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tolusha/subscriptions","organizations_url":"https://api.github.com/users/tolusha/orgs","repos_url":"https://api.github.com/users/tolusha/repos","events_url":"https://api.github.com/users/tolusha/events{/privacy}","received_events_url":"https://api.github.com/users/tolusha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":345100523,"url":"https://api.github.com/repos/eclipse/che/labels/status/code-review","name":"status/code-review","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/che/pulls/9848/commits","review_comments_url":"https://api.github.com/repos/eclipse/che/pulls/9848/comments","review_comment_url":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/che/issues/9848/comments","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/56377b857d3442772374684d8f9c18d49e645570","head":{"label":"gazarenkov:master","ref":"master","sha":"56377b857d3442772374684d8f9c18d49e645570","user":{"login":"gazarenkov","id":578124,"avatar_url":"https://avatars0.githubusercontent.com/u/578124?v=4","gravatar_id":"","url":"https://api.github.com/users/gazarenkov","html_url":"https://github.com/gazarenkov","followers_url":"https://api.github.com/users/gazarenkov/followers","following_url":"https://api.github.com/users/gazarenkov/following{/other_user}","gists_url":"https://api.github.com/users/gazarenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/gazarenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gazarenkov/subscriptions","organizations_url":"https://api.github.com/users/gazarenkov/orgs","repos_url":"https://api.github.com/users/gazarenkov/repos","events_url":"https://api.github.com/users/gazarenkov/events{/privacy}","received_events_url":"https://api.github.com/users/gazarenkov/received_events","type":"User","site_admin":false},"repo":{"id":85542028,"name":"che","full_name":"gazarenkov/che","owner":{"login":"gazarenkov","id":578124,"avatar_url":"https://avatars0.githubusercontent.com/u/578124?v=4","gravatar_id":"","url":"https://api.github.com/users/gazarenkov","html_url":"https://github.com/gazarenkov","followers_url":"https://api.github.com/users/gazarenkov/followers","following_url":"https://api.github.com/users/gazarenkov/following{/other_user}","gists_url":"https://api.github.com/users/gazarenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/gazarenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gazarenkov/subscriptions","organizations_url":"https://api.github.com/users/gazarenkov/orgs","repos_url":"https://api.github.com/users/gazarenkov/repos","events_url":"https://api.github.com/users/gazarenkov/events{/privacy}","received_events_url":"https://api.github.com/users/gazarenkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gazarenkov/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":true,"url":"https://api.github.com/repos/gazarenkov/che","forks_url":"https://api.github.com/repos/gazarenkov/che/forks","keys_url":"https://api.github.com/repos/gazarenkov/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gazarenkov/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gazarenkov/che/teams","hooks_url":"https://api.github.com/repos/gazarenkov/che/hooks","issue_events_url":"https://api.github.com/repos/gazarenkov/che/issues/events{/number}","events_url":"https://api.github.com/repos/gazarenkov/che/events","assignees_url":"https://api.github.com/repos/gazarenkov/che/assignees{/user}","branches_url":"https://api.github.com/repos/gazarenkov/che/branches{/branch}","tags_url":"https://api.github.com/repos/gazarenkov/che/tags","blobs_url":"https://api.github.com/repos/gazarenkov/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gazarenkov/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gazarenkov/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/gazarenkov/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gazarenkov/che/statuses/{sha}","languages_url":"https://api.github.com/repos/gazarenkov/che/languages","stargazers_url":"https://api.github.com/repos/gazarenkov/che/stargazers","contributors_url":"https://api.github.com/repos/gazarenkov/che/contributors","subscribers_url":"https://api.github.com/repos/gazarenkov/che/subscribers","subscription_url":"https://api.github.com/repos/gazarenkov/che/subscription","commits_url":"https://api.github.com/repos/gazarenkov/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/gazarenkov/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/gazarenkov/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/gazarenkov/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/gazarenkov/che/contents/{+path}","compare_url":"https://api.github.com/repos/gazarenkov/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gazarenkov/che/merges","archive_url":"https://api.github.com/repos/gazarenkov/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gazarenkov/che/downloads","issues_url":"https://api.github.com/repos/gazarenkov/che/issues{/number}","pulls_url":"https://api.github.com/repos/gazarenkov/che/pulls{/number}","milestones_url":"https://api.github.com/repos/gazarenkov/che/milestones{/number}","notifications_url":"https://api.github.com/repos/gazarenkov/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gazarenkov/che/labels{/name}","releases_url":"https://api.github.com/repos/gazarenkov/che/releases{/id}","deployments_url":"https://api.github.com/repos/gazarenkov/che/deployments","created_at":"2017-03-20T06:21:12Z","updated_at":"2018-05-30T07:35:25Z","pushed_at":"2018-05-30T07:35:22Z","git_url":"git://github.com/gazarenkov/che.git","ssh_url":"git@github.com:gazarenkov/che.git","clone_url":"https://github.com/gazarenkov/che.git","svn_url":"https://github.com/gazarenkov/che","homepage":"http://eclipse.org/che","size":145021,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"e0890235fa2a8db8177799e41d672fb5e256abed","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":32935745,"name":"che","full_name":"eclipse/che","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":false,"url":"https://api.github.com/repos/eclipse/che","forks_url":"https://api.github.com/repos/eclipse/che/forks","keys_url":"https://api.github.com/repos/eclipse/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/che/teams","hooks_url":"https://api.github.com/repos/eclipse/che/hooks","issue_events_url":"https://api.github.com/repos/eclipse/che/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/che/events","assignees_url":"https://api.github.com/repos/eclipse/che/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/che/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/che/tags","blobs_url":"https://api.github.com/repos/eclipse/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/che/languages","stargazers_url":"https://api.github.com/repos/eclipse/che/stargazers","contributors_url":"https://api.github.com/repos/eclipse/che/contributors","subscribers_url":"https://api.github.com/repos/eclipse/che/subscribers","subscription_url":"https://api.github.com/repos/eclipse/che/subscription","commits_url":"https://api.github.com/repos/eclipse/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/che/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/che/merges","archive_url":"https://api.github.com/repos/eclipse/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/che/downloads","issues_url":"https://api.github.com/repos/eclipse/che/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/che/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/che/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/che/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/che/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/che/deployments","created_at":"2015-03-26T15:31:01Z","updated_at":"2018-05-29T22:02:55Z","pushed_at":"2018-05-30T07:38:00Z","git_url":"git://github.com/eclipse/che.git","ssh_url":"git@github.com:eclipse/che.git","clone_url":"https://github.com/eclipse/che.git","svn_url":"https://github.com/eclipse/che","homepage":"http://eclipse.org/che","size":86251,"stargazers_count":4819,"watchers_count":4819,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":853,"mirror_url":null,"archived":false,"open_issues_count":747,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":853,"open_issues":747,"watchers":4819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/9848"},"html":{"href":"https://github.com/eclipse/che/pull/9848"},"issue":{"href":"https://api.github.com/repos/eclipse/che/issues/9848"},"comments":{"href":"https://api.github.com/repos/eclipse/che/issues/9848/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/che/pulls/9848/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/che/pulls/9848/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/che/statuses/56377b857d3442772374684d8f9c18d49e645570"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gazarenkov"}}