{"action":"created","comment":{"url":"https://api.github.com/repos/supercollider/supercollider/pulls/comments/203363054","pull_request_review_id":138235233,"id":203363054,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzM2MzA1NA==","diff_hunk":"@@ -339,6 +340,8 @@ Server {\n \t\tthis.name = argName;\n \t\tall.add(this);\n \n+\t\tpidReleaseCondition = Condition({ this.pid == nil });","path":"SCClassLibrary/Common/Control/Server.sc","position":12,"original_position":12,"commit_id":"47825d0230d50114ee29e7fe5dd104974e47f11a","original_commit_id":"ec59abdd95fd3bac32223f941fdf23925fcdb2c3","user":{"login":"adcxyz","id":3518579,"node_id":"MDQ6VXNlcjM1MTg1Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3518579?v=4","gravatar_id":"","url":"https://api.github.com/users/adcxyz","html_url":"https://github.com/adcxyz","followers_url":"https://api.github.com/users/adcxyz/followers","following_url":"https://api.github.com/users/adcxyz/following{/other_user}","gists_url":"https://api.github.com/users/adcxyz/gists{/gist_id}","starred_url":"https://api.github.com/users/adcxyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adcxyz/subscriptions","organizations_url":"https://api.github.com/users/adcxyz/orgs","repos_url":"https://api.github.com/users/adcxyz/repos","events_url":"https://api.github.com/users/adcxyz/events{/privacy}","received_events_url":"https://api.github.com/users/adcxyz/received_events","type":"User","site_admin":false},"body":"will go over this anyway in the ServerProcess refactor/cleanup, where every ServerProcess state gets its own condition, so this is just to make all tests with supernova to run now, rather than waiting for the  ServerProcess refactor/cleanup to get through.","created_at":"2018-07-18T12:44:03Z","updated_at":"2018-07-18T12:44:03Z","html_url":"https://github.com/supercollider/supercollider/pull/3848#discussion_r203363054","pull_request_url":"https://api.github.com/repos/supercollider/supercollider/pulls/3848","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/comments/203363054"},"html":{"href":"https://github.com/supercollider/supercollider/pull/3848#discussion_r203363054"},"pull_request":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/3848"}},"in_reply_to_id":203357624},"pull_request":{"url":"https://api.github.com/repos/supercollider/supercollider/pulls/3848","id":199889993,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODg5OTkz","html_url":"https://github.com/supercollider/supercollider/pull/3848","diff_url":"https://github.com/supercollider/supercollider/pull/3848.diff","patch_url":"https://github.com/supercollider/supercollider/pull/3848.patch","issue_url":"https://api.github.com/repos/supercollider/supercollider/issues/3848","number":3848,"state":"open","locked":false,"title":"Fix supernova reboot bug, add reboot tests","user":{"login":"adcxyz","id":3518579,"node_id":"MDQ6VXNlcjM1MTg1Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3518579?v=4","gravatar_id":"","url":"https://api.github.com/users/adcxyz","html_url":"https://github.com/adcxyz","followers_url":"https://api.github.com/users/adcxyz/followers","following_url":"https://api.github.com/users/adcxyz/following{/other_user}","gists_url":"https://api.github.com/users/adcxyz/gists{/gist_id}","starred_url":"https://api.github.com/users/adcxyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adcxyz/subscriptions","organizations_url":"https://api.github.com/users/adcxyz/orgs","repos_url":"https://api.github.com/users/adcxyz/repos","events_url":"https://api.github.com/users/adcxyz/events{/privacy}","received_events_url":"https://api.github.com/users/adcxyz/received_events","type":"User","site_admin":false},"body":"currently supernova servers tends to hang on reboot (macOS 10.13.4):\r\n```\r\nServer.supernova; \r\ns.reboot; // first time usually works\r\ns.reboot; // second time usually hangs, because notify does not happen.\r\n```\r\nthis is a timing issue: supernova sends back the quit message early, but the supernova process still lives long enough to interfere with the boot messaging traffic with the rebooted instance. \r\nThus, this PR adds waiting for release of the (previous) process PID when booting, which fixes the hang condition.\r\nThis PR includes\r\n* waiting for quitting process to release server.pid\r\n* safer testing for notify clientID info from server (supernova messages are not identical yet)\r\n* new unit tests for reboot method \r\n* fix to cycleNotify which tends to hang up TestServer_boot methods\r\n\r\nResult: All tests invoving booted servers now run with supernova!\r\nThey all pass, except test_getn still fails because of a bug in supernova handle_s_getn #3841 \r\n\r\nI believe supernova will be part of the 3.10 release, yes? \r\nIf so, I would be happy if this bug fix went into 3.10, so supernova supported as fully as possible.\r\n\r\n","created_at":"2018-07-07T09:56:58Z","updated_at":"2018-07-18T12:44:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27c1b0b76065e0546373db318d7664b3e7d9af65","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":4413795,"node_id":"MDU6TGFiZWw0NDEzNzk1","url":"https://api.github.com/repos/supercollider/supercollider/labels/bug","name":"bug","color":"fc2929","default":true},{"id":4477106,"node_id":"MDU6TGFiZWw0NDc3MTA2","url":"https://api.github.com/repos/supercollider/supercollider/labels/comp:%20supernova","name":"comp: supernova","color":"F4FF75","default":false},{"id":775030890,"node_id":"MDU6TGFiZWw3NzUwMzA4OTA=","url":"https://api.github.com/repos/supercollider/supercollider/labels/comp:%20test%20suite","name":"comp: test suite","color":"CFFF7D","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/supercollider/supercollider/pulls/3848/commits","review_comments_url":"https://api.github.com/repos/supercollider/supercollider/pulls/3848/comments","review_comment_url":"https://api.github.com/repos/supercollider/supercollider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/supercollider/supercollider/issues/3848/comments","statuses_url":"https://api.github.com/repos/supercollider/supercollider/statuses/47825d0230d50114ee29e7fe5dd104974e47f11a","head":{"label":"adcxyz:fixRebootSupernova","ref":"fixRebootSupernova","sha":"47825d0230d50114ee29e7fe5dd104974e47f11a","user":{"login":"adcxyz","id":3518579,"node_id":"MDQ6VXNlcjM1MTg1Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3518579?v=4","gravatar_id":"","url":"https://api.github.com/users/adcxyz","html_url":"https://github.com/adcxyz","followers_url":"https://api.github.com/users/adcxyz/followers","following_url":"https://api.github.com/users/adcxyz/following{/other_user}","gists_url":"https://api.github.com/users/adcxyz/gists{/gist_id}","starred_url":"https://api.github.com/users/adcxyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adcxyz/subscriptions","organizations_url":"https://api.github.com/users/adcxyz/orgs","repos_url":"https://api.github.com/users/adcxyz/repos","events_url":"https://api.github.com/users/adcxyz/events{/privacy}","received_events_url":"https://api.github.com/users/adcxyz/received_events","type":"User","site_admin":false},"repo":{"id":76972671,"node_id":"MDEwOlJlcG9zaXRvcnk3Njk3MjY3MQ==","name":"supercollider","full_name":"adcxyz/supercollider","owner":{"login":"adcxyz","id":3518579,"node_id":"MDQ6VXNlcjM1MTg1Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3518579?v=4","gravatar_id":"","url":"https://api.github.com/users/adcxyz","html_url":"https://github.com/adcxyz","followers_url":"https://api.github.com/users/adcxyz/followers","following_url":"https://api.github.com/users/adcxyz/following{/other_user}","gists_url":"https://api.github.com/users/adcxyz/gists{/gist_id}","starred_url":"https://api.github.com/users/adcxyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adcxyz/subscriptions","organizations_url":"https://api.github.com/users/adcxyz/orgs","repos_url":"https://api.github.com/users/adcxyz/repos","events_url":"https://api.github.com/users/adcxyz/events{/privacy}","received_events_url":"https://api.github.com/users/adcxyz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adcxyz/supercollider","description":"An audio server, programming language, and IDE for sound synthesis and algorithmic composition.","fork":true,"url":"https://api.github.com/repos/adcxyz/supercollider","forks_url":"https://api.github.com/repos/adcxyz/supercollider/forks","keys_url":"https://api.github.com/repos/adcxyz/supercollider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adcxyz/supercollider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adcxyz/supercollider/teams","hooks_url":"https://api.github.com/repos/adcxyz/supercollider/hooks","issue_events_url":"https://api.github.com/repos/adcxyz/supercollider/issues/events{/number}","events_url":"https://api.github.com/repos/adcxyz/supercollider/events","assignees_url":"https://api.github.com/repos/adcxyz/supercollider/assignees{/user}","branches_url":"https://api.github.com/repos/adcxyz/supercollider/branches{/branch}","tags_url":"https://api.github.com/repos/adcxyz/supercollider/tags","blobs_url":"https://api.github.com/repos/adcxyz/supercollider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adcxyz/supercollider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adcxyz/supercollider/git/refs{/sha}","trees_url":"https://api.github.com/repos/adcxyz/supercollider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adcxyz/supercollider/statuses/{sha}","languages_url":"https://api.github.com/repos/adcxyz/supercollider/languages","stargazers_url":"https://api.github.com/repos/adcxyz/supercollider/stargazers","contributors_url":"https://api.github.com/repos/adcxyz/supercollider/contributors","subscribers_url":"https://api.github.com/repos/adcxyz/supercollider/subscribers","subscription_url":"https://api.github.com/repos/adcxyz/supercollider/subscription","commits_url":"https://api.github.com/repos/adcxyz/supercollider/commits{/sha}","git_commits_url":"https://api.github.com/repos/adcxyz/supercollider/git/commits{/sha}","comments_url":"https://api.github.com/repos/adcxyz/supercollider/comments{/number}","issue_comment_url":"https://api.github.com/repos/adcxyz/supercollider/issues/comments{/number}","contents_url":"https://api.github.com/repos/adcxyz/supercollider/contents/{+path}","compare_url":"https://api.github.com/repos/adcxyz/supercollider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adcxyz/supercollider/merges","archive_url":"https://api.github.com/repos/adcxyz/supercollider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adcxyz/supercollider/downloads","issues_url":"https://api.github.com/repos/adcxyz/supercollider/issues{/number}","pulls_url":"https://api.github.com/repos/adcxyz/supercollider/pulls{/number}","milestones_url":"https://api.github.com/repos/adcxyz/supercollider/milestones{/number}","notifications_url":"https://api.github.com/repos/adcxyz/supercollider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adcxyz/supercollider/labels{/name}","releases_url":"https://api.github.com/repos/adcxyz/supercollider/releases{/id}","deployments_url":"https://api.github.com/repos/adcxyz/supercollider/deployments","created_at":"2016-12-20T16:26:20Z","updated_at":"2016-12-20T16:26:42Z","pushed_at":"2018-07-18T09:14:59Z","git_url":"git://github.com/adcxyz/supercollider.git","ssh_url":"git@github.com:adcxyz/supercollider.git","clone_url":"https://github.com/adcxyz/supercollider.git","svn_url":"https://github.com/adcxyz/supercollider","homepage":"http://supercollider.github.io","size":135716,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"supercollider:3.10","ref":"3.10","sha":"1e75f4d92bf4dff25a58cefe110446032f6fa659","user":{"login":"supercollider","id":1706741,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDY3NDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1706741?v=4","gravatar_id":"","url":"https://api.github.com/users/supercollider","html_url":"https://github.com/supercollider","followers_url":"https://api.github.com/users/supercollider/followers","following_url":"https://api.github.com/users/supercollider/following{/other_user}","gists_url":"https://api.github.com/users/supercollider/gists{/gist_id}","starred_url":"https://api.github.com/users/supercollider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supercollider/subscriptions","organizations_url":"https://api.github.com/users/supercollider/orgs","repos_url":"https://api.github.com/users/supercollider/repos","events_url":"https://api.github.com/users/supercollider/events{/privacy}","received_events_url":"https://api.github.com/users/supercollider/received_events","type":"Organization","site_admin":false},"repo":{"id":4228314,"node_id":"MDEwOlJlcG9zaXRvcnk0MjI4MzE0","name":"supercollider","full_name":"supercollider/supercollider","owner":{"login":"supercollider","id":1706741,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDY3NDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1706741?v=4","gravatar_id":"","url":"https://api.github.com/users/supercollider","html_url":"https://github.com/supercollider","followers_url":"https://api.github.com/users/supercollider/followers","following_url":"https://api.github.com/users/supercollider/following{/other_user}","gists_url":"https://api.github.com/users/supercollider/gists{/gist_id}","starred_url":"https://api.github.com/users/supercollider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supercollider/subscriptions","organizations_url":"https://api.github.com/users/supercollider/orgs","repos_url":"https://api.github.com/users/supercollider/repos","events_url":"https://api.github.com/users/supercollider/events{/privacy}","received_events_url":"https://api.github.com/users/supercollider/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/supercollider/supercollider","description":"An audio server, programming language, and IDE for sound synthesis and algorithmic composition.","fork":false,"url":"https://api.github.com/repos/supercollider/supercollider","forks_url":"https://api.github.com/repos/supercollider/supercollider/forks","keys_url":"https://api.github.com/repos/supercollider/supercollider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/supercollider/supercollider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/supercollider/supercollider/teams","hooks_url":"https://api.github.com/repos/supercollider/supercollider/hooks","issue_events_url":"https://api.github.com/repos/supercollider/supercollider/issues/events{/number}","events_url":"https://api.github.com/repos/supercollider/supercollider/events","assignees_url":"https://api.github.com/repos/supercollider/supercollider/assignees{/user}","branches_url":"https://api.github.com/repos/supercollider/supercollider/branches{/branch}","tags_url":"https://api.github.com/repos/supercollider/supercollider/tags","blobs_url":"https://api.github.com/repos/supercollider/supercollider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/supercollider/supercollider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/supercollider/supercollider/git/refs{/sha}","trees_url":"https://api.github.com/repos/supercollider/supercollider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/supercollider/supercollider/statuses/{sha}","languages_url":"https://api.github.com/repos/supercollider/supercollider/languages","stargazers_url":"https://api.github.com/repos/supercollider/supercollider/stargazers","contributors_url":"https://api.github.com/repos/supercollider/supercollider/contributors","subscribers_url":"https://api.github.com/repos/supercollider/supercollider/subscribers","subscription_url":"https://api.github.com/repos/supercollider/supercollider/subscription","commits_url":"https://api.github.com/repos/supercollider/supercollider/commits{/sha}","git_commits_url":"https://api.github.com/repos/supercollider/supercollider/git/commits{/sha}","comments_url":"https://api.github.com/repos/supercollider/supercollider/comments{/number}","issue_comment_url":"https://api.github.com/repos/supercollider/supercollider/issues/comments{/number}","contents_url":"https://api.github.com/repos/supercollider/supercollider/contents/{+path}","compare_url":"https://api.github.com/repos/supercollider/supercollider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/supercollider/supercollider/merges","archive_url":"https://api.github.com/repos/supercollider/supercollider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/supercollider/supercollider/downloads","issues_url":"https://api.github.com/repos/supercollider/supercollider/issues{/number}","pulls_url":"https://api.github.com/repos/supercollider/supercollider/pulls{/number}","milestones_url":"https://api.github.com/repos/supercollider/supercollider/milestones{/number}","notifications_url":"https://api.github.com/repos/supercollider/supercollider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/supercollider/supercollider/labels{/name}","releases_url":"https://api.github.com/repos/supercollider/supercollider/releases{/id}","deployments_url":"https://api.github.com/repos/supercollider/supercollider/deployments","created_at":"2012-05-04T19:24:51Z","updated_at":"2018-07-18T11:57:38Z","pushed_at":"2018-07-18T11:35:59Z","git_url":"git://github.com/supercollider/supercollider.git","ssh_url":"git@github.com:supercollider/supercollider.git","clone_url":"https://github.com/supercollider/supercollider.git","svn_url":"https://github.com/supercollider/supercollider","homepage":"http://supercollider.github.io","size":155419,"stargazers_count":2023,"watchers_count":2023,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"archived":false,"open_issues_count":641,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":390,"open_issues":641,"watchers":2023,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/3848"},"html":{"href":"https://github.com/supercollider/supercollider/pull/3848"},"issue":{"href":"https://api.github.com/repos/supercollider/supercollider/issues/3848"},"comments":{"href":"https://api.github.com/repos/supercollider/supercollider/issues/3848/comments"},"review_comments":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/3848/comments"},"review_comment":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/3848/commits"},"statuses":{"href":"https://api.github.com/repos/supercollider/supercollider/statuses/47825d0230d50114ee29e7fe5dd104974e47f11a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adcxyz"}}