{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments/166689590","pull_request_review_id":94793588,"id":166689590,"diff_hunk":"@@ -341,18 +394,18 @@ protected boolean persistSession(BackedSession d2, boolean propHit) {\n     @Override\n     protected BackedSession readFromExternal(String id) {\n         String appName = getIStore().getId();\n-        SessionKey key = new SessionKey(id, appName);\n+        String key = createSessionKey(id, appName);\n \n         CacheSession sess = null;\n-        SessionData sessionData = cacheStoreService.cache.get(key);\n+        ArrayList<?> sessionData = cacheStoreService.cache.get(key);","path":"dev/com.ibm.ws.session.cache/src/com/ibm/ws/session/store/cache/CacheHashMap.java","position":327,"original_position":227,"commit_id":"eccab85040d7d3ecba7a03ef8115e517ec0fd1b7","original_commit_id":"eccab85040d7d3ecba7a03ef8115e517ec0fd1b7","user":{"login":"njr-11","id":13710803,"avatar_url":"https://avatars3.githubusercontent.com/u/13710803?v=4","gravatar_id":"","url":"https://api.github.com/users/njr-11","html_url":"https://github.com/njr-11","followers_url":"https://api.github.com/users/njr-11/followers","following_url":"https://api.github.com/users/njr-11/following{/other_user}","gists_url":"https://api.github.com/users/njr-11/gists{/gist_id}","starred_url":"https://api.github.com/users/njr-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njr-11/subscriptions","organizations_url":"https://api.github.com/users/njr-11/orgs","repos_url":"https://api.github.com/users/njr-11/repos","events_url":"https://api.github.com/users/njr-11/events{/privacy}","received_events_url":"https://api.github.com/users/njr-11/received_events","type":"User","site_admin":false},"body":"I suppose we could do that.  I'll work on making this change.","created_at":"2018-02-07T17:17:23Z","updated_at":"2018-02-07T17:17:23Z","html_url":"https://github.com/OpenLiberty/open-liberty/pull/2064#discussion_r166689590","pull_request_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2064","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments/166689590"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/2064#discussion_r166689590"},"pull_request":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2064"}},"in_reply_to_id":166685952},"pull_request":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2064","id":167747369,"html_url":"https://github.com/OpenLiberty/open-liberty/pull/2064","diff_url":"https://github.com/OpenLiberty/open-liberty/pull/2064.diff","patch_url":"https://github.com/OpenLiberty/open-liberty/pull/2064.patch","issue_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/2064","number":2064,"state":"open","locked":false,"title":"remove cache dependency on liberty classes","user":{"login":"njr-11","id":13710803,"avatar_url":"https://avatars3.githubusercontent.com/u/13710803?v=4","gravatar_id":"","url":"https://api.github.com/users/njr-11","html_url":"https://github.com/njr-11","followers_url":"https://api.github.com/users/njr-11/followers","following_url":"https://api.github.com/users/njr-11/following{/other_user}","gists_url":"https://api.github.com/users/njr-11/gists{/gist_id}","starred_url":"https://api.github.com/users/njr-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njr-11/subscriptions","organizations_url":"https://api.github.com/users/njr-11/orgs","repos_url":"https://api.github.com/users/njr-11/repos","events_url":"https://api.github.com/users/njr-11/events{/privacy}","received_events_url":"https://api.github.com/users/njr-11/received_events","type":"User","site_admin":false},"body":"Replace the key/value classes with classes from the JDK such that the JCache server will not have any dependency on being able to load classes from Liberty.","created_at":"2018-02-07T16:47:20Z","updated_at":"2018-02-07T17:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ee5c90bec1194632370dd1a893a2720ff2fb542","assignee":{"login":"njr-11","id":13710803,"avatar_url":"https://avatars3.githubusercontent.com/u/13710803?v=4","gravatar_id":"","url":"https://api.github.com/users/njr-11","html_url":"https://github.com/njr-11","followers_url":"https://api.github.com/users/njr-11/followers","following_url":"https://api.github.com/users/njr-11/following{/other_user}","gists_url":"https://api.github.com/users/njr-11/gists{/gist_id}","starred_url":"https://api.github.com/users/njr-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njr-11/subscriptions","organizations_url":"https://api.github.com/users/njr-11/orgs","repos_url":"https://api.github.com/users/njr-11/repos","events_url":"https://api.github.com/users/njr-11/events{/privacy}","received_events_url":"https://api.github.com/users/njr-11/received_events","type":"User","site_admin":false},"assignees":[{"login":"njr-11","id":13710803,"avatar_url":"https://avatars3.githubusercontent.com/u/13710803?v=4","gravatar_id":"","url":"https://api.github.com/users/njr-11","html_url":"https://github.com/njr-11","followers_url":"https://api.github.com/users/njr-11/followers","following_url":"https://api.github.com/users/njr-11/following{/other_user}","gists_url":"https://api.github.com/users/njr-11/gists{/gist_id}","starred_url":"https://api.github.com/users/njr-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njr-11/subscriptions","organizations_url":"https://api.github.com/users/njr-11/orgs","repos_url":"https://api.github.com/users/njr-11/repos","events_url":"https://api.github.com/users/njr-11/events{/privacy}","received_events_url":"https://api.github.com/users/njr-11/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/milestones/11","html_url":"https://github.com/OpenLiberty/open-liberty/milestone/11","labels_url":"https://api.github.com/repos/OpenLiberty/open-liberty/milestones/11/labels","id":2993812,"number":11,"title":"[Iteration 18.3] January 29 - February 9","description":"","creator":{"login":"njr-11","id":13710803,"avatar_url":"https://avatars3.githubusercontent.com/u/13710803?v=4","gravatar_id":"","url":"https://api.github.com/users/njr-11","html_url":"https://github.com/njr-11","followers_url":"https://api.github.com/users/njr-11/followers","following_url":"https://api.github.com/users/njr-11/following{/other_user}","gists_url":"https://api.github.com/users/njr-11/gists{/gist_id}","starred_url":"https://api.github.com/users/njr-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njr-11/subscriptions","organizations_url":"https://api.github.com/users/njr-11/orgs","repos_url":"https://api.github.com/users/njr-11/repos","events_url":"https://api.github.com/users/njr-11/events{/privacy}","received_events_url":"https://api.github.com/users/njr-11/received_events","type":"User","site_admin":false},"open_issues":63,"closed_issues":28,"state":"open","created_at":"2017-12-21T20:29:11Z","updated_at":"2018-02-07T16:47:20Z","due_on":"2018-02-09T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2064/commits","review_comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2064/comments","review_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/2064/comments","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/eccab85040d7d3ecba7a03ef8115e517ec0fd1b7","head":{"label":"njr-11:1825-remove-cache-dependency-on-Liberty-classes","ref":"1825-remove-cache-dependency-on-Liberty-classes","sha":"eccab85040d7d3ecba7a03ef8115e517ec0fd1b7","user":{"login":"njr-11","id":13710803,"avatar_url":"https://avatars3.githubusercontent.com/u/13710803?v=4","gravatar_id":"","url":"https://api.github.com/users/njr-11","html_url":"https://github.com/njr-11","followers_url":"https://api.github.com/users/njr-11/followers","following_url":"https://api.github.com/users/njr-11/following{/other_user}","gists_url":"https://api.github.com/users/njr-11/gists{/gist_id}","starred_url":"https://api.github.com/users/njr-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njr-11/subscriptions","organizations_url":"https://api.github.com/users/njr-11/orgs","repos_url":"https://api.github.com/users/njr-11/repos","events_url":"https://api.github.com/users/njr-11/events{/privacy}","received_events_url":"https://api.github.com/users/njr-11/received_events","type":"User","site_admin":false},"repo":{"id":103995417,"name":"open-liberty","full_name":"njr-11/open-liberty","owner":{"login":"njr-11","id":13710803,"avatar_url":"https://avatars3.githubusercontent.com/u/13710803?v=4","gravatar_id":"","url":"https://api.github.com/users/njr-11","html_url":"https://github.com/njr-11","followers_url":"https://api.github.com/users/njr-11/followers","following_url":"https://api.github.com/users/njr-11/following{/other_user}","gists_url":"https://api.github.com/users/njr-11/gists{/gist_id}","starred_url":"https://api.github.com/users/njr-11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njr-11/subscriptions","organizations_url":"https://api.github.com/users/njr-11/orgs","repos_url":"https://api.github.com/users/njr-11/repos","events_url":"https://api.github.com/users/njr-11/events{/privacy}","received_events_url":"https://api.github.com/users/njr-11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/njr-11/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":true,"url":"https://api.github.com/repos/njr-11/open-liberty","forks_url":"https://api.github.com/repos/njr-11/open-liberty/forks","keys_url":"https://api.github.com/repos/njr-11/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njr-11/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njr-11/open-liberty/teams","hooks_url":"https://api.github.com/repos/njr-11/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/njr-11/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/njr-11/open-liberty/events","assignees_url":"https://api.github.com/repos/njr-11/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/njr-11/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/njr-11/open-liberty/tags","blobs_url":"https://api.github.com/repos/njr-11/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njr-11/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njr-11/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/njr-11/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njr-11/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/njr-11/open-liberty/languages","stargazers_url":"https://api.github.com/repos/njr-11/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/njr-11/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/njr-11/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/njr-11/open-liberty/subscription","commits_url":"https://api.github.com/repos/njr-11/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/njr-11/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/njr-11/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/njr-11/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/njr-11/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/njr-11/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njr-11/open-liberty/merges","archive_url":"https://api.github.com/repos/njr-11/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njr-11/open-liberty/downloads","issues_url":"https://api.github.com/repos/njr-11/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/njr-11/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/njr-11/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/njr-11/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njr-11/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/njr-11/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/njr-11/open-liberty/deployments","created_at":"2017-09-18T21:47:49Z","updated_at":"2017-09-18T21:48:47Z","pushed_at":"2018-02-07T16:48:19Z","git_url":"git://github.com/njr-11/open-liberty.git","ssh_url":"git@github.com:njr-11/open-liberty.git","clone_url":"https://github.com/njr-11/open-liberty.git","svn_url":"https://github.com/njr-11/open-liberty","homepage":"http://openliberty.io","size":109319,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"integration"}},"base":{"label":"OpenLiberty:integration","ref":"integration","sha":"b7a2f4c3e66bc54d32dc086aed2d9291f23fe86b","user":{"login":"OpenLiberty","id":28316667,"avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"repo":{"id":103694377,"name":"open-liberty","full_name":"OpenLiberty/open-liberty","owner":{"login":"OpenLiberty","id":28316667,"avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenLiberty/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":false,"url":"https://api.github.com/repos/OpenLiberty/open-liberty","forks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/forks","keys_url":"https://api.github.com/repos/OpenLiberty/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLiberty/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLiberty/open-liberty/teams","hooks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/events","assignees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLiberty/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/tags","blobs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLiberty/open-liberty/languages","stargazers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscription","commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLiberty/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLiberty/open-liberty/merges","archive_url":"https://api.github.com/repos/OpenLiberty/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLiberty/open-liberty/downloads","issues_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLiberty/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLiberty/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/OpenLiberty/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/deployments","created_at":"2017-09-15T19:34:25Z","updated_at":"2018-02-06T01:32:12Z","pushed_at":"2018-02-07T17:10:52Z","git_url":"git://github.com/OpenLiberty/open-liberty.git","ssh_url":"git@github.com:OpenLiberty/open-liberty.git","clone_url":"https://github.com/OpenLiberty/open-liberty.git","svn_url":"https://github.com/OpenLiberty/open-liberty","homepage":"http://openliberty.io","size":109389,"stargazers_count":260,"watchers_count":260,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"archived":false,"open_issues_count":413,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":213,"open_issues":413,"watchers":260,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2064"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/2064"},"issue":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/2064"},"comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/2064/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2064/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/2064/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/eccab85040d7d3ecba7a03ef8115e517ec0fd1b7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"njr-11"}}