{"action":"closed","issue":{"url":"https://api.github.com/repos/sizeight/vinderjs/issues/14","repository_url":"https://api.github.com/repos/sizeight/vinderjs","labels_url":"https://api.github.com/repos/sizeight/vinderjs/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/sizeight/vinderjs/issues/14/comments","events_url":"https://api.github.com/repos/sizeight/vinderjs/issues/14/events","html_url":"https://github.com/sizeight/vinderjs/issues/14","id":382520995,"node_id":"MDU6SXNzdWUzODI1MjA5OTU=","number":14,"title":"Upgrade react-datepicker 1.6.0 -> 2.0.0","user":{"login":"sizeight","id":232198,"node_id":"MDQ6VXNlcjIzMjE5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/232198?v=4","gravatar_id":"","url":"https://api.github.com/users/sizeight","html_url":"https://github.com/sizeight","followers_url":"https://api.github.com/users/sizeight/followers","following_url":"https://api.github.com/users/sizeight/following{/other_user}","gists_url":"https://api.github.com/users/sizeight/gists{/gist_id}","starred_url":"https://api.github.com/users/sizeight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sizeight/subscriptions","organizations_url":"https://api.github.com/users/sizeight/orgs","repos_url":"https://api.github.com/users/sizeight/repos","events_url":"https://api.github.com/users/sizeight/events{/privacy}","received_events_url":"https://api.github.com/users/sizeight/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-20T06:37:00Z","updated_at":"2018-11-20T07:30:14Z","closed_at":"2018-11-20T07:30:14Z","author_association":"OWNER","body":"# react-popper dependency conflict\r\nreact-datepicker upgraded the react-popper dependency in the 1.6.0 -> 1.7.0 release. This caused our code to break. The reason has to do with **reactstrap** depending on **react-popper 0.10.4** and **react-datepicker** now depending on a new **react-popper major release 1.x.x**.\r\n\r\nWhy would their differing dependencies cause a crash? isn't NPM supposed to manage conflicts like this? Yes, but the issue is inour **webpack config**. \r\n\r\nOur config:\r\n```\r\nmodules: [\r\n  path.join(__dirname, '../node_modules')\r\n]\r\n```\r\nThis forces all modules to resolve from the root node_modules, causing reactstrap to reslover the wrong react-popper.\r\n\r\nChange webpack config to:\r\n```\r\nmodules: [\r\n  'node_modules'\r\n]\r\n```\r\nThis resolves node_modules hierarchically.\r\n\r\nHoorah! Changing this fixed the problem!\r\n\r\n# Moment.js\r\nreact-datepicker 2.0.0 drops dependency on **moment.js**. We should adapt our code to now work without moment.js."}}
{"actor":{"display_login":"sizeight"}}