{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/186550877","pull_request_review_id":118152168,"id":186550877,"diff_hunk":"@@ -104,8 +104,8 @@ const (\n \tDefaultACIConnectorAddonName = \"aci-connector\"\n \t// DefaultDashboardAddonName is the name of the kubernetes-dashboard addon deployment\n \tDefaultDashboardAddonName = \"kubernetes-dashboard\"\n-\t// DefaultACIConnectorImage defines the ACI Connector deployment version on Kubernetes Clusters\n-\tDefaultACIConnectorImage = \"virtual-kubelet:latest\"","path":"pkg/acsengine/const.go","position":5,"original_position":5,"commit_id":"adebbec923d00533267deb948f2c353f019d2a5d","original_commit_id":"adebbec923d00533267deb948f2c353f019d2a5d","user":{"login":"jackfrancis","id":1494193,"avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"body":"Did we want to delete this const?","created_at":"2018-05-07T21:05:13Z","updated_at":"2018-05-07T21:05:14Z","html_url":"https://github.com/Azure/acs-engine/pull/2637#discussion_r186550877","pull_request_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2637","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/186550877"},"html":{"href":"https://github.com/Azure/acs-engine/pull/2637#discussion_r186550877"},"pull_request":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2637"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/2637","id":180397370,"html_url":"https://github.com/Azure/acs-engine/pull/2637","diff_url":"https://github.com/Azure/acs-engine/pull/2637.diff","patch_url":"https://github.com/Azure/acs-engine/pull/2637.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/2637","number":2637,"state":"open","locked":false,"title":"Kubernetes Cluster Autoscaler (VMSS) addon","user":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis PR adds Azure Virtual Machine Scale Set cluster autoscaler (https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler/cloudprovider/azure) as an add-on for acs-engine\r\n\r\nIt automatically pulls in and converts to base64 all required values for credentials (such as clientId, clientSecret, subscriptionId, tentantId, etc) and other required values (scale set name, resource group, etc) from the deployment.\r\n\r\nUser can override minNodes (default to 1), maxNodes (default to 5), image, limits, and requests.\r\n\r\nDocumentation: https://github.com/sozercan/acs-engine/blob/autoscaler-vmss/examples/addons/cluster-autoscaler/README.md\r\n\r\n**Special notes for your reviewer**:\r\nMerge after #2620 \r\n\r\n**If applicable**:\r\n- [x] documentation\r\n- [x] unit tests\r\n- [x] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)\r\n- [x] managed identity support\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nAdded cluster-autoscaler addon for Virtual Machine Scale Sets\r\n```\r\n","created_at":"2018-04-09T19:00:46Z","updated_at":"2018-05-07T21:05:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90561786439dd7d614cb66b912bea4f2959eb4e0","assignee":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"assignees":[{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":671011863,"url":"https://api.github.com/repos/Azure/acs-engine/labels/awaiting%20review","name":"awaiting review","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2637/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2637/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/2637/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/adebbec923d00533267deb948f2c353f019d2a5d","head":{"label":"sozercan:autoscaler-vmss","ref":"autoscaler-vmss","sha":"adebbec923d00533267deb948f2c353f019d2a5d","user":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"repo":{"id":83094157,"name":"acs-engine","full_name":"sozercan/acs-engine","owner":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sozercan/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/sozercan/acs-engine","forks_url":"https://api.github.com/repos/sozercan/acs-engine/forks","keys_url":"https://api.github.com/repos/sozercan/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sozercan/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sozercan/acs-engine/teams","hooks_url":"https://api.github.com/repos/sozercan/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/sozercan/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/sozercan/acs-engine/events","assignees_url":"https://api.github.com/repos/sozercan/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/sozercan/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/sozercan/acs-engine/tags","blobs_url":"https://api.github.com/repos/sozercan/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sozercan/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sozercan/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/sozercan/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sozercan/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/sozercan/acs-engine/languages","stargazers_url":"https://api.github.com/repos/sozercan/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/sozercan/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/sozercan/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/sozercan/acs-engine/subscription","commits_url":"https://api.github.com/repos/sozercan/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/sozercan/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/sozercan/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/sozercan/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/sozercan/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/sozercan/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sozercan/acs-engine/merges","archive_url":"https://api.github.com/repos/sozercan/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sozercan/acs-engine/downloads","issues_url":"https://api.github.com/repos/sozercan/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/sozercan/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/sozercan/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/sozercan/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sozercan/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/sozercan/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/sozercan/acs-engine/deployments","created_at":"2017-02-25T00:23:46Z","updated_at":"2018-04-27T20:30:36Z","pushed_at":"2018-05-07T20:33:04Z","git_url":"git://github.com/sozercan/acs-engine.git","ssh_url":"git@github.com:sozercan/acs-engine.git","clone_url":"https://github.com/sozercan/acs-engine.git","svn_url":"https://github.com/sozercan/acs-engine","homepage":"","size":67061,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"8d05c7343bdcacd0e281c56e106394198b6d1c04","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2018-05-07T20:10:54Z","pushed_at":"2018-05-07T20:33:06Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"git@github.com:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":77477,"stargazers_count":776,"watchers_count":776,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":501,"mirror_url":null,"archived":false,"open_issues_count":432,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":501,"open_issues":432,"watchers":776,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2637"},"html":{"href":"https://github.com/Azure/acs-engine/pull/2637"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/2637"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/2637/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2637/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2637/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/adebbec923d00533267deb948f2c353f019d2a5d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jackfrancis"}}