{"action":"created","comment":{"url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/comments/217927929","pull_request_review_id":155758133,"id":217927929,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkyNzkyOQ==","diff_hunk":"@@ -0,0 +1,12 @@\n+namespace Avalonia.Rendering\n+{\n+    /// <summary>\n+    /// An interface to allow non-templated controls to customize their hit-testing\n+    /// when using a renderer with a simple hit-testing algorithm without a scene graph,\n+    /// such as <see cref=\"ImmediateRenderer\" />\n+    /// </summary>\n+    public interface ICustomSimpleHitTest","path":"src/Avalonia.Visuals/Rendering/ICustomSimpleHitTest.cs","position":8,"original_position":8,"commit_id":"bc850b49c16090d81d5d049dd9ff2cfc7efa0de1","original_commit_id":"bc850b49c16090d81d5d049dd9ff2cfc7efa0de1","user":{"login":"grokys","id":1775141,"node_id":"MDQ6VXNlcjE3NzUxNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1775141?v=4","gravatar_id":"","url":"https://api.github.com/users/grokys","html_url":"https://github.com/grokys","followers_url":"https://api.github.com/users/grokys/followers","following_url":"https://api.github.com/users/grokys/following{/other_user}","gists_url":"https://api.github.com/users/grokys/gists{/gist_id}","starred_url":"https://api.github.com/users/grokys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grokys/subscriptions","organizations_url":"https://api.github.com/users/grokys/orgs","repos_url":"https://api.github.com/users/grokys/repos","events_url":"https://api.github.com/users/grokys/events{/privacy}","received_events_url":"https://api.github.com/users/grokys/received_events","type":"User","site_admin":true},"body":"I'd prefer something like `ImmediateHitTest` but I'll let you decide, it's your PR ;)","created_at":"2018-09-16T21:08:33Z","updated_at":"2018-09-16T21:08:33Z","html_url":"https://github.com/AvaloniaUI/Avalonia/pull/1901#discussion_r217927929","pull_request_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/1901","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/comments/217927929"},"html":{"href":"https://github.com/AvaloniaUI/Avalonia/pull/1901#discussion_r217927929"},"pull_request":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/1901"}},"in_reply_to_id":217924306},"pull_request":{"url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/1901","id":215802200,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODAyMjAw","html_url":"https://github.com/AvaloniaUI/Avalonia/pull/1901","diff_url":"https://github.com/AvaloniaUI/Avalonia/pull/1901.diff","patch_url":"https://github.com/AvaloniaUI/Avalonia/pull/1901.patch","issue_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/1901","number":1901,"state":"open","locked":false,"title":"Add in custom hit testing for ImmediateRenderer.","user":{"login":"jkoritzinsky","id":1571408,"node_id":"MDQ6VXNlcjE1NzE0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1571408?v=4","gravatar_id":"","url":"https://api.github.com/users/jkoritzinsky","html_url":"https://github.com/jkoritzinsky","followers_url":"https://api.github.com/users/jkoritzinsky/followers","following_url":"https://api.github.com/users/jkoritzinsky/following{/other_user}","gists_url":"https://api.github.com/users/jkoritzinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/jkoritzinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkoritzinsky/subscriptions","organizations_url":"https://api.github.com/users/jkoritzinsky/orgs","repos_url":"https://api.github.com/users/jkoritzinsky/repos","events_url":"https://api.github.com/users/jkoritzinsky/events{/privacy}","received_events_url":"https://api.github.com/users/jkoritzinsky/received_events","type":"User","site_admin":false},"body":"- What does the pull request do?\r\nAllows controls to specify their own simple (non-scenegraph-based) hit testing. Implement this on AdornerLayer.\r\n- What is the current behavior?\r\nImmediateRenderer's hit testing is broken since all hits get sent to `AdornerLayer`.\r\n- What is the updated/expected behavior with this PR?\r\nHit testing functions as normal with `ImmediateRenderer`.\r\n\r\nChecklist:\r\n\r\n- [ ] Added unit tests (if possible)?\r\n- [x] Added XML documentation to any related classes?\r\n\r\n Fixes #1879.","created_at":"2018-09-16T04:14:56Z","updated_at":"2018-09-16T21:08:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30ee5404ddd68b03f7b82e302981e611641f3ef6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/1901/commits","review_comments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/1901/comments","review_comment_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/1901/comments","statuses_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/statuses/bc850b49c16090d81d5d049dd9ff2cfc7efa0de1","head":{"label":"jkoritzinsky:custom-hittesting","ref":"custom-hittesting","sha":"bc850b49c16090d81d5d049dd9ff2cfc7efa0de1","user":{"login":"jkoritzinsky","id":1571408,"node_id":"MDQ6VXNlcjE1NzE0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1571408?v=4","gravatar_id":"","url":"https://api.github.com/users/jkoritzinsky","html_url":"https://github.com/jkoritzinsky","followers_url":"https://api.github.com/users/jkoritzinsky/followers","following_url":"https://api.github.com/users/jkoritzinsky/following{/other_user}","gists_url":"https://api.github.com/users/jkoritzinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/jkoritzinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkoritzinsky/subscriptions","organizations_url":"https://api.github.com/users/jkoritzinsky/orgs","repos_url":"https://api.github.com/users/jkoritzinsky/repos","events_url":"https://api.github.com/users/jkoritzinsky/events{/privacy}","received_events_url":"https://api.github.com/users/jkoritzinsky/received_events","type":"User","site_admin":false},"repo":{"id":51102048,"node_id":"MDEwOlJlcG9zaXRvcnk1MTEwMjA0OA==","name":"Avalonia","full_name":"jkoritzinsky/Avalonia","private":false,"owner":{"login":"jkoritzinsky","id":1571408,"node_id":"MDQ6VXNlcjE1NzE0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1571408?v=4","gravatar_id":"","url":"https://api.github.com/users/jkoritzinsky","html_url":"https://github.com/jkoritzinsky","followers_url":"https://api.github.com/users/jkoritzinsky/followers","following_url":"https://api.github.com/users/jkoritzinsky/following{/other_user}","gists_url":"https://api.github.com/users/jkoritzinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/jkoritzinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkoritzinsky/subscriptions","organizations_url":"https://api.github.com/users/jkoritzinsky/orgs","repos_url":"https://api.github.com/users/jkoritzinsky/repos","events_url":"https://api.github.com/users/jkoritzinsky/events{/privacy}","received_events_url":"https://api.github.com/users/jkoritzinsky/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jkoritzinsky/Avalonia","description":"A multi-platform .NET UI framework.","fork":true,"url":"https://api.github.com/repos/jkoritzinsky/Avalonia","forks_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/forks","keys_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/teams","hooks_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/hooks","issue_events_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/issues/events{/number}","events_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/events","assignees_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/assignees{/user}","branches_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/branches{/branch}","tags_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/tags","blobs_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/statuses/{sha}","languages_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/languages","stargazers_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/stargazers","contributors_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/contributors","subscribers_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/subscribers","subscription_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/subscription","commits_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/contents/{+path}","compare_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/merges","archive_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/downloads","issues_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/issues{/number}","pulls_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/pulls{/number}","milestones_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/milestones{/number}","notifications_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/labels{/name}","releases_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/releases{/id}","deployments_url":"https://api.github.com/repos/jkoritzinsky/Avalonia/deployments","created_at":"2016-02-04T20:08:07Z","updated_at":"2018-09-09T20:55:05Z","pushed_at":"2018-09-16T04:11:25Z","git_url":"git://github.com/jkoritzinsky/Avalonia.git","ssh_url":"git@github.com:jkoritzinsky/Avalonia.git","clone_url":"https://github.com/jkoritzinsky/Avalonia.git","svn_url":"https://github.com/jkoritzinsky/Avalonia","homepage":"","size":52152,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AvaloniaUI:master","ref":"master","sha":"44226cf8f76db4a6f229f1130a3c882dca59d2ed","user":{"login":"AvaloniaUI","id":14075148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDc1MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/14075148?v=4","gravatar_id":"","url":"https://api.github.com/users/AvaloniaUI","html_url":"https://github.com/AvaloniaUI","followers_url":"https://api.github.com/users/AvaloniaUI/followers","following_url":"https://api.github.com/users/AvaloniaUI/following{/other_user}","gists_url":"https://api.github.com/users/AvaloniaUI/gists{/gist_id}","starred_url":"https://api.github.com/users/AvaloniaUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvaloniaUI/subscriptions","organizations_url":"https://api.github.com/users/AvaloniaUI/orgs","repos_url":"https://api.github.com/users/AvaloniaUI/repos","events_url":"https://api.github.com/users/AvaloniaUI/events{/privacy}","received_events_url":"https://api.github.com/users/AvaloniaUI/received_events","type":"Organization","site_admin":false},"repo":{"id":14964475,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NDQ3NQ==","name":"Avalonia","full_name":"AvaloniaUI/Avalonia","private":false,"owner":{"login":"AvaloniaUI","id":14075148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDc1MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/14075148?v=4","gravatar_id":"","url":"https://api.github.com/users/AvaloniaUI","html_url":"https://github.com/AvaloniaUI","followers_url":"https://api.github.com/users/AvaloniaUI/followers","following_url":"https://api.github.com/users/AvaloniaUI/following{/other_user}","gists_url":"https://api.github.com/users/AvaloniaUI/gists{/gist_id}","starred_url":"https://api.github.com/users/AvaloniaUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvaloniaUI/subscriptions","organizations_url":"https://api.github.com/users/AvaloniaUI/orgs","repos_url":"https://api.github.com/users/AvaloniaUI/repos","events_url":"https://api.github.com/users/AvaloniaUI/events{/privacy}","received_events_url":"https://api.github.com/users/AvaloniaUI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AvaloniaUI/Avalonia","description":"A multi-platform .NET UI framework","fork":false,"url":"https://api.github.com/repos/AvaloniaUI/Avalonia","forks_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/forks","keys_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/teams","hooks_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/hooks","issue_events_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/events{/number}","events_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/events","assignees_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/assignees{/user}","branches_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/branches{/branch}","tags_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/tags","blobs_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/refs{/sha}","trees_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/statuses/{sha}","languages_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/languages","stargazers_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/stargazers","contributors_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/contributors","subscribers_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/subscribers","subscription_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/subscription","commits_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/commits{/sha}","git_commits_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/git/commits{/sha}","comments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/comments{/number}","issue_comment_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/comments{/number}","contents_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/contents/{+path}","compare_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/merges","archive_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/downloads","issues_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues{/number}","pulls_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls{/number}","milestones_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/milestones{/number}","notifications_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/labels{/name}","releases_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/releases{/id}","deployments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/deployments","created_at":"2013-12-05T20:13:21Z","updated_at":"2018-09-16T18:48:07Z","pushed_at":"2018-09-16T18:48:02Z","git_url":"git://github.com/AvaloniaUI/Avalonia.git","ssh_url":"git@github.com:AvaloniaUI/Avalonia.git","clone_url":"https://github.com/AvaloniaUI/Avalonia.git","svn_url":"https://github.com/AvaloniaUI/Avalonia","homepage":"http://avaloniaui.net","size":52309,"stargazers_count":4997,"watchers_count":4997,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":469,"mirror_url":null,"archived":false,"open_issues_count":235,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":469,"open_issues":235,"watchers":4997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/1901"},"html":{"href":"https://github.com/AvaloniaUI/Avalonia/pull/1901"},"issue":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/1901"},"comments":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/1901/comments"},"review_comments":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/1901/comments"},"review_comment":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/1901/commits"},"statuses":{"href":"https://api.github.com/repos/AvaloniaUI/Avalonia/statuses/bc850b49c16090d81d5d049dd9ff2cfc7efa0de1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"grokys"}}