{"action":"created","comment":{"url":"https://api.github.com/repos/ngrx/platform/pulls/comments/212827823","pull_request_review_id":149539890,"id":212827823,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjgyNzgyMw==","diff_hunk":"@@ -119,7 +126,7 @@ describe('integration spec', () => {\n       });\n   });\n \n-  it('should support rolling back if navigation gets canceled', (done: any) => {\n+  it('should support rolling back if navigation gets canceled (navigation initialized through roter)', (done: any) => {","path":"modules/router-store/spec/integration.spec.ts","position":28,"original_position":28,"commit_id":"8070323437a8755f323ae2f0d861d490ae8e2f15","original_commit_id":"8070323437a8755f323ae2f0d861d490ae8e2f15","user":{"login":"timdeschryver","id":28659384,"node_id":"MDQ6VXNlcjI4NjU5Mzg0","avatar_url":"https://avatars1.githubusercontent.com/u/28659384?v=4","gravatar_id":"","url":"https://api.github.com/users/timdeschryver","html_url":"https://github.com/timdeschryver","followers_url":"https://api.github.com/users/timdeschryver/followers","following_url":"https://api.github.com/users/timdeschryver/following{/other_user}","gists_url":"https://api.github.com/users/timdeschryver/gists{/gist_id}","starred_url":"https://api.github.com/users/timdeschryver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timdeschryver/subscriptions","organizations_url":"https://api.github.com/users/timdeschryver/orgs","repos_url":"https://api.github.com/users/timdeschryver/repos","events_url":"https://api.github.com/users/timdeschryver/events{/privacy}","received_events_url":"https://api.github.com/users/timdeschryver/received_events","type":"User","site_admin":false},"body":"typo, roter -> router","created_at":"2018-08-26T14:18:02Z","updated_at":"2018-08-26T14:58:36Z","html_url":"https://github.com/ngrx/platform/pull/1294#discussion_r212827823","pull_request_url":"https://api.github.com/repos/ngrx/platform/pulls/1294","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ngrx/platform/pulls/comments/212827823"},"html":{"href":"https://github.com/ngrx/platform/pull/1294#discussion_r212827823"},"pull_request":{"href":"https://api.github.com/repos/ngrx/platform/pulls/1294"}}},"pull_request":{"url":"https://api.github.com/repos/ngrx/platform/pulls/1294","id":210901839,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTAxODM5","html_url":"https://github.com/ngrx/platform/pull/1294","diff_url":"https://github.com/ngrx/platform/pull/1294.diff","patch_url":"https://github.com/ngrx/platform/pull/1294.patch","issue_url":"https://api.github.com/repos/ngrx/platform/issues/1294","number":1294,"state":"open","locked":false,"title":"fix(router-store): Handle navigation error, cancel/error action contain real previous state","user":{"login":"dummdidumm","id":5968653,"node_id":"MDQ6VXNlcjU5Njg2NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5968653?v=4","gravatar_id":"","url":"https://api.github.com/users/dummdidumm","html_url":"https://github.com/dummdidumm","followers_url":"https://api.github.com/users/dummdidumm/followers","following_url":"https://api.github.com/users/dummdidumm/following{/other_user}","gists_url":"https://api.github.com/users/dummdidumm/gists{/gist_id}","starred_url":"https://api.github.com/users/dummdidumm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dummdidumm/subscriptions","organizations_url":"https://api.github.com/users/dummdidumm/orgs","repos_url":"https://api.github.com/users/dummdidumm/repos","events_url":"https://api.github.com/users/dummdidumm/events{/privacy}","received_events_url":"https://api.github.com/users/dummdidumm/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\n\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n## PR Type\r\n\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n\r\n```\r\n[x] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the new behavior?\r\n\r\nFixes #1292, #1293 \r\n\r\n- Error during navigation initiated by store is caught and handed to ErrorHandler\r\n- `ROUTER_ERROR` / `ROUTER_CANCEL` action now contain previos router and store state \r\n\r\n## Does this PR introduce a breaking change?\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n## Other information\r\n","created_at":"2018-08-25T13:06:17Z","updated_at":"2018-08-26T14:58:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"927e079d1684de7d0f63b26f928816a41b48271e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ngrx/platform/pulls/1294/commits","review_comments_url":"https://api.github.com/repos/ngrx/platform/pulls/1294/comments","review_comment_url":"https://api.github.com/repos/ngrx/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ngrx/platform/issues/1294/comments","statuses_url":"https://api.github.com/repos/ngrx/platform/statuses/8070323437a8755f323ae2f0d861d490ae8e2f15","head":{"label":"dummdidumm:feature/router","ref":"feature/router","sha":"8070323437a8755f323ae2f0d861d490ae8e2f15","user":{"login":"dummdidumm","id":5968653,"node_id":"MDQ6VXNlcjU5Njg2NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5968653?v=4","gravatar_id":"","url":"https://api.github.com/users/dummdidumm","html_url":"https://github.com/dummdidumm","followers_url":"https://api.github.com/users/dummdidumm/followers","following_url":"https://api.github.com/users/dummdidumm/following{/other_user}","gists_url":"https://api.github.com/users/dummdidumm/gists{/gist_id}","starred_url":"https://api.github.com/users/dummdidumm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dummdidumm/subscriptions","organizations_url":"https://api.github.com/users/dummdidumm/orgs","repos_url":"https://api.github.com/users/dummdidumm/repos","events_url":"https://api.github.com/users/dummdidumm/events{/privacy}","received_events_url":"https://api.github.com/users/dummdidumm/received_events","type":"User","site_admin":false},"repo":{"id":122660965,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NjA5NjU=","name":"platform","full_name":"dummdidumm/platform","owner":{"login":"dummdidumm","id":5968653,"node_id":"MDQ6VXNlcjU5Njg2NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5968653?v=4","gravatar_id":"","url":"https://api.github.com/users/dummdidumm","html_url":"https://github.com/dummdidumm","followers_url":"https://api.github.com/users/dummdidumm/followers","following_url":"https://api.github.com/users/dummdidumm/following{/other_user}","gists_url":"https://api.github.com/users/dummdidumm/gists{/gist_id}","starred_url":"https://api.github.com/users/dummdidumm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dummdidumm/subscriptions","organizations_url":"https://api.github.com/users/dummdidumm/orgs","repos_url":"https://api.github.com/users/dummdidumm/repos","events_url":"https://api.github.com/users/dummdidumm/events{/privacy}","received_events_url":"https://api.github.com/users/dummdidumm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dummdidumm/platform","description":"Monorepo for ngrx codebase","fork":true,"url":"https://api.github.com/repos/dummdidumm/platform","forks_url":"https://api.github.com/repos/dummdidumm/platform/forks","keys_url":"https://api.github.com/repos/dummdidumm/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dummdidumm/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dummdidumm/platform/teams","hooks_url":"https://api.github.com/repos/dummdidumm/platform/hooks","issue_events_url":"https://api.github.com/repos/dummdidumm/platform/issues/events{/number}","events_url":"https://api.github.com/repos/dummdidumm/platform/events","assignees_url":"https://api.github.com/repos/dummdidumm/platform/assignees{/user}","branches_url":"https://api.github.com/repos/dummdidumm/platform/branches{/branch}","tags_url":"https://api.github.com/repos/dummdidumm/platform/tags","blobs_url":"https://api.github.com/repos/dummdidumm/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dummdidumm/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dummdidumm/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/dummdidumm/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dummdidumm/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/dummdidumm/platform/languages","stargazers_url":"https://api.github.com/repos/dummdidumm/platform/stargazers","contributors_url":"https://api.github.com/repos/dummdidumm/platform/contributors","subscribers_url":"https://api.github.com/repos/dummdidumm/platform/subscribers","subscription_url":"https://api.github.com/repos/dummdidumm/platform/subscription","commits_url":"https://api.github.com/repos/dummdidumm/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/dummdidumm/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/dummdidumm/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/dummdidumm/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/dummdidumm/platform/contents/{+path}","compare_url":"https://api.github.com/repos/dummdidumm/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dummdidumm/platform/merges","archive_url":"https://api.github.com/repos/dummdidumm/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dummdidumm/platform/downloads","issues_url":"https://api.github.com/repos/dummdidumm/platform/issues{/number}","pulls_url":"https://api.github.com/repos/dummdidumm/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/dummdidumm/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/dummdidumm/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dummdidumm/platform/labels{/name}","releases_url":"https://api.github.com/repos/dummdidumm/platform/releases{/id}","deployments_url":"https://api.github.com/repos/dummdidumm/platform/deployments","created_at":"2018-02-23T18:59:21Z","updated_at":"2018-08-22T07:14:15Z","pushed_at":"2018-08-25T13:02:26Z","git_url":"git://github.com/dummdidumm/platform.git","ssh_url":"git@github.com:dummdidumm/platform.git","clone_url":"https://github.com/dummdidumm/platform.git","svn_url":"https://github.com/dummdidumm/platform","homepage":null,"size":2850,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ngrx:master","ref":"master","sha":"5dac795a5d2d650ba402172989b381a486d193f5","user":{"login":"ngrx","id":16272733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjcyNzMz","avatar_url":"https://avatars1.githubusercontent.com/u/16272733?v=4","gravatar_id":"","url":"https://api.github.com/users/ngrx","html_url":"https://github.com/ngrx","followers_url":"https://api.github.com/users/ngrx/followers","following_url":"https://api.github.com/users/ngrx/following{/other_user}","gists_url":"https://api.github.com/users/ngrx/gists{/gist_id}","starred_url":"https://api.github.com/users/ngrx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngrx/subscriptions","organizations_url":"https://api.github.com/users/ngrx/orgs","repos_url":"https://api.github.com/users/ngrx/repos","events_url":"https://api.github.com/users/ngrx/events{/privacy}","received_events_url":"https://api.github.com/users/ngrx/received_events","type":"Organization","site_admin":false},"repo":{"id":83716883,"node_id":"MDEwOlJlcG9zaXRvcnk4MzcxNjg4Mw==","name":"platform","full_name":"ngrx/platform","owner":{"login":"ngrx","id":16272733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjcyNzMz","avatar_url":"https://avatars1.githubusercontent.com/u/16272733?v=4","gravatar_id":"","url":"https://api.github.com/users/ngrx","html_url":"https://github.com/ngrx","followers_url":"https://api.github.com/users/ngrx/followers","following_url":"https://api.github.com/users/ngrx/following{/other_user}","gists_url":"https://api.github.com/users/ngrx/gists{/gist_id}","starred_url":"https://api.github.com/users/ngrx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngrx/subscriptions","organizations_url":"https://api.github.com/users/ngrx/orgs","repos_url":"https://api.github.com/users/ngrx/repos","events_url":"https://api.github.com/users/ngrx/events{/privacy}","received_events_url":"https://api.github.com/users/ngrx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ngrx/platform","description":"Reactive libraries for Angular","fork":false,"url":"https://api.github.com/repos/ngrx/platform","forks_url":"https://api.github.com/repos/ngrx/platform/forks","keys_url":"https://api.github.com/repos/ngrx/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngrx/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngrx/platform/teams","hooks_url":"https://api.github.com/repos/ngrx/platform/hooks","issue_events_url":"https://api.github.com/repos/ngrx/platform/issues/events{/number}","events_url":"https://api.github.com/repos/ngrx/platform/events","assignees_url":"https://api.github.com/repos/ngrx/platform/assignees{/user}","branches_url":"https://api.github.com/repos/ngrx/platform/branches{/branch}","tags_url":"https://api.github.com/repos/ngrx/platform/tags","blobs_url":"https://api.github.com/repos/ngrx/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngrx/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngrx/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngrx/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngrx/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/ngrx/platform/languages","stargazers_url":"https://api.github.com/repos/ngrx/platform/stargazers","contributors_url":"https://api.github.com/repos/ngrx/platform/contributors","subscribers_url":"https://api.github.com/repos/ngrx/platform/subscribers","subscription_url":"https://api.github.com/repos/ngrx/platform/subscription","commits_url":"https://api.github.com/repos/ngrx/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngrx/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngrx/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngrx/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngrx/platform/contents/{+path}","compare_url":"https://api.github.com/repos/ngrx/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngrx/platform/merges","archive_url":"https://api.github.com/repos/ngrx/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngrx/platform/downloads","issues_url":"https://api.github.com/repos/ngrx/platform/issues{/number}","pulls_url":"https://api.github.com/repos/ngrx/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/ngrx/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/ngrx/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngrx/platform/labels{/name}","releases_url":"https://api.github.com/repos/ngrx/platform/releases{/id}","deployments_url":"https://api.github.com/repos/ngrx/platform/deployments","created_at":"2017-03-02T19:34:15Z","updated_at":"2018-08-26T08:38:05Z","pushed_at":"2018-08-26T13:11:47Z","git_url":"git://github.com/ngrx/platform.git","ssh_url":"git@github.com:ngrx/platform.git","clone_url":"https://github.com/ngrx/platform.git","svn_url":"https://github.com/ngrx/platform","homepage":"","size":2863,"stargazers_count":3514,"watchers_count":3514,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":947,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":947,"open_issues":68,"watchers":3514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ngrx/platform/pulls/1294"},"html":{"href":"https://github.com/ngrx/platform/pull/1294"},"issue":{"href":"https://api.github.com/repos/ngrx/platform/issues/1294"},"comments":{"href":"https://api.github.com/repos/ngrx/platform/issues/1294/comments"},"review_comments":{"href":"https://api.github.com/repos/ngrx/platform/pulls/1294/comments"},"review_comment":{"href":"https://api.github.com/repos/ngrx/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ngrx/platform/pulls/1294/commits"},"statuses":{"href":"https://api.github.com/repos/ngrx/platform/statuses/8070323437a8755f323ae2f0d861d490ae8e2f15"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timdeschryver"}}