{"action":"created","comment":{"url":"https://api.github.com/repos/binaris/binaris/pulls/comments/237456003","pull_request_review_id":179755964,"id":237456003,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzQ1NjAwMw==","diff_hunk":"@@ -607,6 +607,9 @@\n         err: |-\n              Invalid offset format, unknown unit \"daysf\"\n         exit: 1\n+    -   in: BINARIS_LOG_ENDPOINT=fake.binaris.com bn logs amillionamillion","path":"test/spec.yml","position":4,"original_position":4,"commit_id":"9311b5f17089539dc069c34681af3d47339b8450","original_commit_id":"9311b5f17089539dc069c34681af3d47339b8450","user":{"login":"vogre","id":334187,"node_id":"MDQ6VXNlcjMzNDE4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/334187?v=4","gravatar_id":"","url":"https://api.github.com/users/vogre","html_url":"https://github.com/vogre","followers_url":"https://api.github.com/users/vogre/followers","following_url":"https://api.github.com/users/vogre/following{/other_user}","gists_url":"https://api.github.com/users/vogre/gists{/gist_id}","starred_url":"https://api.github.com/users/vogre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogre/subscriptions","organizations_url":"https://api.github.com/users/vogre/orgs","repos_url":"https://api.github.com/users/vogre/repos","events_url":"https://api.github.com/users/vogre/events{/privacy}","received_events_url":"https://api.github.com/users/vogre/received_events","type":"User","site_admin":false},"body":"Fake domains tend to be problematic when ISP / Hotel inject their page on NXDOMAIN - so won't happen in CI, but will annoy someone one day. Hopefully they won't break `.invalid`.","created_at":"2018-11-29T11:52:24Z","updated_at":"2018-11-29T11:52:24Z","html_url":"https://github.com/binaris/binaris/pull/386#discussion_r237456003","pull_request_url":"https://api.github.com/repos/binaris/binaris/pulls/386","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/binaris/binaris/pulls/comments/237456003"},"html":{"href":"https://github.com/binaris/binaris/pull/386#discussion_r237456003"},"pull_request":{"href":"https://api.github.com/repos/binaris/binaris/pulls/386"}},"in_reply_to_id":237365397},"pull_request":{"url":"https://api.github.com/repos/binaris/binaris/pulls/386","id":234475712,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDc1NzEy","html_url":"https://github.com/binaris/binaris/pull/386","diff_url":"https://github.com/binaris/binaris/pull/386.diff","patch_url":"https://github.com/binaris/binaris/pull/386.patch","issue_url":"https://api.github.com/repos/binaris/binaris/issues/386","number":386,"state":"open","locked":false,"title":"small fix for log endpoint issue","user":{"login":"rylandg","id":27736122,"node_id":"MDQ6VXNlcjI3NzM2MTIy","avatar_url":"https://avatars0.githubusercontent.com/u/27736122?v=4","gravatar_id":"","url":"https://api.github.com/users/rylandg","html_url":"https://github.com/rylandg","followers_url":"https://api.github.com/users/rylandg/followers","following_url":"https://api.github.com/users/rylandg/following{/other_user}","gists_url":"https://api.github.com/users/rylandg/gists{/gist_id}","starred_url":"https://api.github.com/users/rylandg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rylandg/subscriptions","organizations_url":"https://api.github.com/users/rylandg/orgs","repos_url":"https://api.github.com/users/rylandg/repos","events_url":"https://api.github.com/users/rylandg/events{/privacy}","received_events_url":"https://api.github.com/users/rylandg/received_events","type":"User","site_admin":false},"body":"Users will now get a relevant error when a bad log endpoint is provided.","created_at":"2018-11-29T01:04:05Z","updated_at":"2018-11-29T11:52:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ed6bbb9d57ad67fdac2d676a0aafe4e9929a618","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/binaris/binaris/pulls/386/commits","review_comments_url":"https://api.github.com/repos/binaris/binaris/pulls/386/comments","review_comment_url":"https://api.github.com/repos/binaris/binaris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binaris/binaris/issues/386/comments","statuses_url":"https://api.github.com/repos/binaris/binaris/statuses/9311b5f17089539dc069c34681af3d47339b8450","head":{"label":"binaris:feature-better-log-endpoint-error","ref":"feature-better-log-endpoint-error","sha":"9311b5f17089539dc069c34681af3d47339b8450","user":{"login":"binaris","id":27725492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/27725492?v=4","gravatar_id":"","url":"https://api.github.com/users/binaris","html_url":"https://github.com/binaris","followers_url":"https://api.github.com/users/binaris/followers","following_url":"https://api.github.com/users/binaris/following{/other_user}","gists_url":"https://api.github.com/users/binaris/gists{/gist_id}","starred_url":"https://api.github.com/users/binaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binaris/subscriptions","organizations_url":"https://api.github.com/users/binaris/orgs","repos_url":"https://api.github.com/users/binaris/repos","events_url":"https://api.github.com/users/binaris/events{/privacy}","received_events_url":"https://api.github.com/users/binaris/received_events","type":"Organization","site_admin":false},"repo":{"id":103460196,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM0NjAxOTY=","name":"binaris","full_name":"binaris/binaris","private":false,"owner":{"login":"binaris","id":27725492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/27725492?v=4","gravatar_id":"","url":"https://api.github.com/users/binaris","html_url":"https://github.com/binaris","followers_url":"https://api.github.com/users/binaris/followers","following_url":"https://api.github.com/users/binaris/following{/other_user}","gists_url":"https://api.github.com/users/binaris/gists{/gist_id}","starred_url":"https://api.github.com/users/binaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binaris/subscriptions","organizations_url":"https://api.github.com/users/binaris/orgs","repos_url":"https://api.github.com/users/binaris/repos","events_url":"https://api.github.com/users/binaris/events{/privacy}","received_events_url":"https://api.github.com/users/binaris/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/binaris/binaris","description":"Binaris Function as a Service CLI","fork":false,"url":"https://api.github.com/repos/binaris/binaris","forks_url":"https://api.github.com/repos/binaris/binaris/forks","keys_url":"https://api.github.com/repos/binaris/binaris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binaris/binaris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binaris/binaris/teams","hooks_url":"https://api.github.com/repos/binaris/binaris/hooks","issue_events_url":"https://api.github.com/repos/binaris/binaris/issues/events{/number}","events_url":"https://api.github.com/repos/binaris/binaris/events","assignees_url":"https://api.github.com/repos/binaris/binaris/assignees{/user}","branches_url":"https://api.github.com/repos/binaris/binaris/branches{/branch}","tags_url":"https://api.github.com/repos/binaris/binaris/tags","blobs_url":"https://api.github.com/repos/binaris/binaris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binaris/binaris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binaris/binaris/git/refs{/sha}","trees_url":"https://api.github.com/repos/binaris/binaris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binaris/binaris/statuses/{sha}","languages_url":"https://api.github.com/repos/binaris/binaris/languages","stargazers_url":"https://api.github.com/repos/binaris/binaris/stargazers","contributors_url":"https://api.github.com/repos/binaris/binaris/contributors","subscribers_url":"https://api.github.com/repos/binaris/binaris/subscribers","subscription_url":"https://api.github.com/repos/binaris/binaris/subscription","commits_url":"https://api.github.com/repos/binaris/binaris/commits{/sha}","git_commits_url":"https://api.github.com/repos/binaris/binaris/git/commits{/sha}","comments_url":"https://api.github.com/repos/binaris/binaris/comments{/number}","issue_comment_url":"https://api.github.com/repos/binaris/binaris/issues/comments{/number}","contents_url":"https://api.github.com/repos/binaris/binaris/contents/{+path}","compare_url":"https://api.github.com/repos/binaris/binaris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binaris/binaris/merges","archive_url":"https://api.github.com/repos/binaris/binaris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binaris/binaris/downloads","issues_url":"https://api.github.com/repos/binaris/binaris/issues{/number}","pulls_url":"https://api.github.com/repos/binaris/binaris/pulls{/number}","milestones_url":"https://api.github.com/repos/binaris/binaris/milestones{/number}","notifications_url":"https://api.github.com/repos/binaris/binaris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binaris/binaris/labels{/name}","releases_url":"https://api.github.com/repos/binaris/binaris/releases{/id}","deployments_url":"https://api.github.com/repos/binaris/binaris/deployments","created_at":"2017-09-13T22:57:26Z","updated_at":"2018-11-28T23:02:56Z","pushed_at":"2018-11-29T01:04:06Z","git_url":"git://github.com/binaris/binaris.git","ssh_url":"git@github.com:binaris/binaris.git","clone_url":"https://github.com/binaris/binaris.git","svn_url":"https://github.com/binaris/binaris","homepage":"https://dev.binaris.com/","size":445,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":38,"watchers":10,"default_branch":"master"}},"base":{"label":"binaris:master","ref":"master","sha":"22024baf88e4b462fb1c312fd52771ecc62305c2","user":{"login":"binaris","id":27725492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/27725492?v=4","gravatar_id":"","url":"https://api.github.com/users/binaris","html_url":"https://github.com/binaris","followers_url":"https://api.github.com/users/binaris/followers","following_url":"https://api.github.com/users/binaris/following{/other_user}","gists_url":"https://api.github.com/users/binaris/gists{/gist_id}","starred_url":"https://api.github.com/users/binaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binaris/subscriptions","organizations_url":"https://api.github.com/users/binaris/orgs","repos_url":"https://api.github.com/users/binaris/repos","events_url":"https://api.github.com/users/binaris/events{/privacy}","received_events_url":"https://api.github.com/users/binaris/received_events","type":"Organization","site_admin":false},"repo":{"id":103460196,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM0NjAxOTY=","name":"binaris","full_name":"binaris/binaris","private":false,"owner":{"login":"binaris","id":27725492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/27725492?v=4","gravatar_id":"","url":"https://api.github.com/users/binaris","html_url":"https://github.com/binaris","followers_url":"https://api.github.com/users/binaris/followers","following_url":"https://api.github.com/users/binaris/following{/other_user}","gists_url":"https://api.github.com/users/binaris/gists{/gist_id}","starred_url":"https://api.github.com/users/binaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binaris/subscriptions","organizations_url":"https://api.github.com/users/binaris/orgs","repos_url":"https://api.github.com/users/binaris/repos","events_url":"https://api.github.com/users/binaris/events{/privacy}","received_events_url":"https://api.github.com/users/binaris/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/binaris/binaris","description":"Binaris Function as a Service CLI","fork":false,"url":"https://api.github.com/repos/binaris/binaris","forks_url":"https://api.github.com/repos/binaris/binaris/forks","keys_url":"https://api.github.com/repos/binaris/binaris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binaris/binaris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binaris/binaris/teams","hooks_url":"https://api.github.com/repos/binaris/binaris/hooks","issue_events_url":"https://api.github.com/repos/binaris/binaris/issues/events{/number}","events_url":"https://api.github.com/repos/binaris/binaris/events","assignees_url":"https://api.github.com/repos/binaris/binaris/assignees{/user}","branches_url":"https://api.github.com/repos/binaris/binaris/branches{/branch}","tags_url":"https://api.github.com/repos/binaris/binaris/tags","blobs_url":"https://api.github.com/repos/binaris/binaris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binaris/binaris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binaris/binaris/git/refs{/sha}","trees_url":"https://api.github.com/repos/binaris/binaris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binaris/binaris/statuses/{sha}","languages_url":"https://api.github.com/repos/binaris/binaris/languages","stargazers_url":"https://api.github.com/repos/binaris/binaris/stargazers","contributors_url":"https://api.github.com/repos/binaris/binaris/contributors","subscribers_url":"https://api.github.com/repos/binaris/binaris/subscribers","subscription_url":"https://api.github.com/repos/binaris/binaris/subscription","commits_url":"https://api.github.com/repos/binaris/binaris/commits{/sha}","git_commits_url":"https://api.github.com/repos/binaris/binaris/git/commits{/sha}","comments_url":"https://api.github.com/repos/binaris/binaris/comments{/number}","issue_comment_url":"https://api.github.com/repos/binaris/binaris/issues/comments{/number}","contents_url":"https://api.github.com/repos/binaris/binaris/contents/{+path}","compare_url":"https://api.github.com/repos/binaris/binaris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binaris/binaris/merges","archive_url":"https://api.github.com/repos/binaris/binaris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binaris/binaris/downloads","issues_url":"https://api.github.com/repos/binaris/binaris/issues{/number}","pulls_url":"https://api.github.com/repos/binaris/binaris/pulls{/number}","milestones_url":"https://api.github.com/repos/binaris/binaris/milestones{/number}","notifications_url":"https://api.github.com/repos/binaris/binaris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binaris/binaris/labels{/name}","releases_url":"https://api.github.com/repos/binaris/binaris/releases{/id}","deployments_url":"https://api.github.com/repos/binaris/binaris/deployments","created_at":"2017-09-13T22:57:26Z","updated_at":"2018-11-28T23:02:56Z","pushed_at":"2018-11-29T01:04:06Z","git_url":"git://github.com/binaris/binaris.git","ssh_url":"git@github.com:binaris/binaris.git","clone_url":"https://github.com/binaris/binaris.git","svn_url":"https://github.com/binaris/binaris","homepage":"https://dev.binaris.com/","size":445,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":38,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binaris/binaris/pulls/386"},"html":{"href":"https://github.com/binaris/binaris/pull/386"},"issue":{"href":"https://api.github.com/repos/binaris/binaris/issues/386"},"comments":{"href":"https://api.github.com/repos/binaris/binaris/issues/386/comments"},"review_comments":{"href":"https://api.github.com/repos/binaris/binaris/pulls/386/comments"},"review_comment":{"href":"https://api.github.com/repos/binaris/binaris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binaris/binaris/pulls/386/commits"},"statuses":{"href":"https://api.github.com/repos/binaris/binaris/statuses/9311b5f17089539dc069c34681af3d47339b8450"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vogre"}}