{"action":"created","issue":{"url":"https://api.github.com/repos/apache/systemml/issues/740","repository_url":"https://api.github.com/repos/apache/systemml","labels_url":"https://api.github.com/repos/apache/systemml/issues/740/labels{/name}","comments_url":"https://api.github.com/repos/apache/systemml/issues/740/comments","events_url":"https://api.github.com/repos/apache/systemml/issues/740/events","html_url":"https://github.com/apache/systemml/pull/740","id":302502514,"number":740,"title":"[SYSTEMML-2077] New eval builtin function","user":{"login":"EdgarLGB","id":15153347,"avatar_url":"https://avatars0.githubusercontent.com/u/15153347?v=4","gravatar_id":"","url":"https://api.github.com/users/EdgarLGB","html_url":"https://github.com/EdgarLGB","followers_url":"https://api.github.com/users/EdgarLGB/followers","following_url":"https://api.github.com/users/EdgarLGB/following{/other_user}","gists_url":"https://api.github.com/users/EdgarLGB/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgarLGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgarLGB/subscriptions","organizations_url":"https://api.github.com/users/EdgarLGB/orgs","repos_url":"https://api.github.com/users/EdgarLGB/repos","events_url":"https://api.github.com/users/EdgarLGB/events{/privacy}","received_events_url":"https://api.github.com/users/EdgarLGB/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-03-05T23:17:42Z","updated_at":"2018-03-09T08:06:28Z","closed_at":"2018-03-09T07:59:57Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/systemml/pulls/740","html_url":"https://github.com/apache/systemml/pull/740","diff_url":"https://github.com/apache/systemml/pull/740.diff","patch_url":"https://github.com/apache/systemml/pull/740.patch"},"body":"Hi,\r\nI made an another PR for the new eval built-in function. I made a code refactoring and fixed the code format problem. And I put all the commits into the master branch. Thanks for review.\r\n\r\nRegards,\r\nGuobao"},"comment":{"url":"https://api.github.com/repos/apache/systemml/issues/comments/371741968","html_url":"https://github.com/apache/systemml/pull/740#issuecomment-371741968","issue_url":"https://api.github.com/repos/apache/systemml/issues/740","id":371741968,"user":{"login":"mboehm7","id":13721609,"avatar_url":"https://avatars0.githubusercontent.com/u/13721609?v=4","gravatar_id":"","url":"https://api.github.com/users/mboehm7","html_url":"https://github.com/mboehm7","followers_url":"https://api.github.com/users/mboehm7/followers","following_url":"https://api.github.com/users/mboehm7/following{/other_user}","gists_url":"https://api.github.com/users/mboehm7/gists{/gist_id}","starred_url":"https://api.github.com/users/mboehm7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboehm7/subscriptions","organizations_url":"https://api.github.com/users/mboehm7/orgs","repos_url":"https://api.github.com/users/mboehm7/repos","events_url":"https://api.github.com/users/mboehm7/events{/privacy}","received_events_url":"https://api.github.com/users/mboehm7/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T08:06:28Z","updated_at":"2018-03-09T08:06:28Z","author_association":"CONTRIBUTOR","body":"Thanks again @EdgarLGB for your contribution - it worked like a charm. I further added the support for function name expressions, but removed the support for function calls outside the default namespace for two reasons. First, there were potential conflicts with constant variables, which could have caused incorrect results and runtime failures. Second, the call to namespace functions would still be limited to static names, which could simply be called directly. However, I took a note and will extend that once we cleaned up the entire meta data management of namespaces. Thanks."}}
{"actor":{"display_login":"mboehm7"}}