{"action":"created","issue":{"url":"https://api.github.com/repos/argoproj/argo/issues/862","repository_url":"https://api.github.com/repos/argoproj/argo","labels_url":"https://api.github.com/repos/argoproj/argo/issues/862/labels{/name}","comments_url":"https://api.github.com/repos/argoproj/argo/issues/862/comments","events_url":"https://api.github.com/repos/argoproj/argo/issues/862/events","html_url":"https://github.com/argoproj/argo/issues/862","id":324935523,"number":862,"title":"Parameterize imagePullSecrets for private authenticated repositories","user":{"login":"patrickstjohn","id":7337041,"avatar_url":"https://avatars1.githubusercontent.com/u/7337041?v=4","gravatar_id":"","url":"https://api.github.com/users/patrickstjohn","html_url":"https://github.com/patrickstjohn","followers_url":"https://api.github.com/users/patrickstjohn/followers","following_url":"https://api.github.com/users/patrickstjohn/following{/other_user}","gists_url":"https://api.github.com/users/patrickstjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickstjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickstjohn/subscriptions","organizations_url":"https://api.github.com/users/patrickstjohn/orgs","repos_url":"https://api.github.com/users/patrickstjohn/repos","events_url":"https://api.github.com/users/patrickstjohn/events{/privacy}","received_events_url":"https://api.github.com/users/patrickstjohn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-21T14:25:23Z","updated_at":"2018-05-22T02:10:49Z","closed_at":null,"author_association":"NONE","body":"**Is this a BUG REPORT or FEATURE REQUEST?**:\r\n\r\nFEATURE REQUEST\r\n\r\n**What happened**:\r\n\r\nAttempted to install argo in an offline environment against an authenticated private repository and had to edit the deployments manually for it to work.\r\n\r\nAdditionally, attempting to run a workflow pulling containers from an authenticated repository does not appear to work. Specifying imagePullSecret in the template does not appear to be respected.\r\n\r\n**What you expected to happen**:\r\n\r\nAllow for a flag to supply a imagePullSecrets name to properly pull from the Docker registry at installation time. Workflows should also respect imagePullSecret in the template.\r\n\r\n**How to reproduce it (as minimally and precisely as possible)**:\r\n1. Set up a private repository that requires authentication (Harbor, etc.)\r\n2. Run the following command pointing to the private repo:\r\n`\r\nargo install --controller-image private-registry.io/argo/workflow-controller:latest  --executor-image private-registry.io/argo/argoexec:latest --ui-image private-registry.io/argo/argoui:latest --ui-base-href /argo/ --enable-web-console -n argo\r\n`\r\n\r\n**Anything else we need to know?**:\r\n\r\n**Environment**:\r\n- Argo version:\r\n```\r\n$ argo version\r\nargo: v2.1.0\r\n  BuildDate: 2018-05-01T20:04:30Z\r\n  GitCommit: 9379638189cc194f1b34ff7295f0832eac1c1651\r\n  GitTreeState: clean\r\n  GitTag: v2.1.0\r\n  GoVersion: go1.9.3\r\n  Compiler: gc\r\n  Platform: linux/amd64\r\n```\r\n- Kubernetes version :\r\n```\r\n$ kubectl version -o yaml\r\nclientVersion:\r\n  buildDate: 2018-04-12T14:26:04Z\r\n  compiler: gc\r\n  gitCommit: d4ab47518836c750f9949b9e0d387f20fb92260b\r\n  gitTreeState: clean\r\n  gitVersion: v1.10.1\r\n  goVersion: go1.9.3\r\n  major: \"1\"\r\n  minor: \"10\"\r\n  platform: linux/amd64\r\nserverVersion:\r\n  buildDate: 2018-04-12T14:14:26Z\r\n  compiler: gc\r\n  gitCommit: d4ab47518836c750f9949b9e0d387f20fb92260b\r\n  gitTreeState: clean\r\n  gitVersion: v1.10.1\r\n  goVersion: go1.9.3\r\n  major: \"1\"\r\n  minor: \"10\"\r\n  platform: linux/amd64\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/argoproj/argo/issues/comments/390840363","html_url":"https://github.com/argoproj/argo/issues/862#issuecomment-390840363","issue_url":"https://api.github.com/repos/argoproj/argo/issues/862","id":390840363,"user":{"login":"jessesuen","id":12677113,"avatar_url":"https://avatars0.githubusercontent.com/u/12677113?v=4","gravatar_id":"","url":"https://api.github.com/users/jessesuen","html_url":"https://github.com/jessesuen","followers_url":"https://api.github.com/users/jessesuen/followers","following_url":"https://api.github.com/users/jessesuen/following{/other_user}","gists_url":"https://api.github.com/users/jessesuen/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesuen/subscriptions","organizations_url":"https://api.github.com/users/jessesuen/orgs","repos_url":"https://api.github.com/users/jessesuen/repos","events_url":"https://api.github.com/users/jessesuen/events{/privacy}","received_events_url":"https://api.github.com/users/jessesuen/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T02:10:49Z","updated_at":"2018-05-22T02:10:49Z","author_association":"CONTRIBUTOR","body":"> Specifying imagePullSecret in the template does not appear to be respected\r\n\r\nImagePullSecrets is actually at the workflow spec, and no the template level. So if you specify `spec.imagePullSecrets`, it will be carried forward to the pod.\r\n\r\nAdditionally, I believe kubernetes provides ways to supply image pull secrets at a namespace level, so that you don't have to always specify imagePullSecrets per pod.\r\n\r\nDo the above techniques work for you?"}}
{"actor":{"display_login":"jessesuen"}}