{"action":"created","comment":{"url":"https://api.github.com/repos/percona/rds_exporter/pulls/comments/209186071","pull_request_review_id":145150738,"id":209186071,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTE4NjA3MQ==","diff_hunk":"@@ -111,7 +111,7 @@ var Metrics = []Metric{\n \t\t\t\"node_cpu_average\",\n \t\t\t\"The percentage of CPU utilization. Units: Percent\",\n \t\t\t[]string{\"instance\", \"region\"},\n-\t\t\tmap[string]string{\"cpu\": \"All\", \"mode\": \"idle\"},\n+\t\t\tmap[string]string{\"cpu\": \"All\", \"mode\": \"total\"},","path":"basic/metrics.go","position":5,"original_position":5,"commit_id":"b75a4f31bb20dff9f1cb335cd9f24ded330fd4e4","original_commit_id":"b75a4f31bb20dff9f1cb335cd9f24ded330fd4e4","user":{"login":"delgod","id":303592,"node_id":"MDQ6VXNlcjMwMzU5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/303592?v=4","gravatar_id":"","url":"https://api.github.com/users/delgod","html_url":"https://github.com/delgod","followers_url":"https://api.github.com/users/delgod/followers","following_url":"https://api.github.com/users/delgod/following{/other_user}","gists_url":"https://api.github.com/users/delgod/gists{/gist_id}","starred_url":"https://api.github.com/users/delgod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delgod/subscriptions","organizations_url":"https://api.github.com/users/delgod/orgs","repos_url":"https://api.github.com/users/delgod/repos","events_url":"https://api.github.com/users/delgod/events{/privacy}","received_events_url":"https://api.github.com/users/delgod/received_events","type":"User","site_admin":false},"body":"no broke, only fix bug :)","created_at":"2018-08-10T08:35:33Z","updated_at":"2018-08-10T08:35:33Z","html_url":"https://github.com/percona/rds_exporter/pull/12#discussion_r209186071","pull_request_url":"https://api.github.com/repos/percona/rds_exporter/pulls/12","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/percona/rds_exporter/pulls/comments/209186071"},"html":{"href":"https://github.com/percona/rds_exporter/pull/12#discussion_r209186071"},"pull_request":{"href":"https://api.github.com/repos/percona/rds_exporter/pulls/12"}},"in_reply_to_id":208934997},"pull_request":{"url":"https://api.github.com/repos/percona/rds_exporter/pulls/12","id":205650835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjUwODM1","html_url":"https://github.com/percona/rds_exporter/pull/12","diff_url":"https://github.com/percona/rds_exporter/pull/12.diff","patch_url":"https://github.com/percona/rds_exporter/pull/12.patch","issue_url":"https://api.github.com/repos/percona/rds_exporter/issues/12","number":12,"state":"open","locked":false,"title":"Added granularity interval for scraping AWS api","user":{"login":"alexandrst88","id":8613199,"node_id":"MDQ6VXNlcjg2MTMxOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/8613199?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandrst88","html_url":"https://github.com/alexandrst88","followers_url":"https://api.github.com/users/alexandrst88/followers","following_url":"https://api.github.com/users/alexandrst88/following{/other_user}","gists_url":"https://api.github.com/users/alexandrst88/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrst88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrst88/subscriptions","organizations_url":"https://api.github.com/users/alexandrst88/orgs","repos_url":"https://api.github.com/users/alexandrst88/repos","events_url":"https://api.github.com/users/alexandrst88/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrst88/received_events","type":"User","site_admin":false},"body":"This PR fix the issues, \r\n- which related to AWS api limits(https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/cloudwatch_limits_cwl.html). Basically, if you set granularity in rds console for small time interval, like 5/10 seconds, and have 2 mins, you will faced with\r\n```\r\ntime=\"2018-08-01T08:12:26Z\" level=error msg=\"unable to get logs for instance : ThrottlingException: Rate exceeded\\n\\tstatus code: 400, request id: a02da727-9562-11e8-86c9-0d07b3aaf681\" source=\"enhanced.go:109\"\r\n```\r\n\r\nAnd you will have spots in promethues graph. it will be good to have this interval set via configuration file.\r\n\r\n- In basic metrics, it will be nice to see cpu utilization set to `total` or `user` instead of `idle`. \r\n\r\n- Small fixes in Dockerfile","created_at":"2018-08-02T08:07:23Z","updated_at":"2018-08-10T08:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ec5beaf6b43598d9c9a52f91af406a7ba6446e1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"delgod","id":303592,"node_id":"MDQ6VXNlcjMwMzU5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/303592?v=4","gravatar_id":"","url":"https://api.github.com/users/delgod","html_url":"https://github.com/delgod","followers_url":"https://api.github.com/users/delgod/followers","following_url":"https://api.github.com/users/delgod/following{/other_user}","gists_url":"https://api.github.com/users/delgod/gists{/gist_id}","starred_url":"https://api.github.com/users/delgod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delgod/subscriptions","organizations_url":"https://api.github.com/users/delgod/orgs","repos_url":"https://api.github.com/users/delgod/repos","events_url":"https://api.github.com/users/delgod/events{/privacy}","received_events_url":"https://api.github.com/users/delgod/received_events","type":"User","site_admin":false},{"login":"rnovikovP","id":25495422,"node_id":"MDQ6VXNlcjI1NDk1NDIy","avatar_url":"https://avatars0.githubusercontent.com/u/25495422?v=4","gravatar_id":"","url":"https://api.github.com/users/rnovikovP","html_url":"https://github.com/rnovikovP","followers_url":"https://api.github.com/users/rnovikovP/followers","following_url":"https://api.github.com/users/rnovikovP/following{/other_user}","gists_url":"https://api.github.com/users/rnovikovP/gists{/gist_id}","starred_url":"https://api.github.com/users/rnovikovP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnovikovP/subscriptions","organizations_url":"https://api.github.com/users/rnovikovP/orgs","repos_url":"https://api.github.com/users/rnovikovP/repos","events_url":"https://api.github.com/users/rnovikovP/events{/privacy}","received_events_url":"https://api.github.com/users/rnovikovP/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/rds_exporter/pulls/12/commits","review_comments_url":"https://api.github.com/repos/percona/rds_exporter/pulls/12/comments","review_comment_url":"https://api.github.com/repos/percona/rds_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/rds_exporter/issues/12/comments","statuses_url":"https://api.github.com/repos/percona/rds_exporter/statuses/b75a4f31bb20dff9f1cb335cd9f24ded330fd4e4","head":{"label":"dreamteam-gg:fix-granularity-interval","ref":"fix-granularity-interval","sha":"b75a4f31bb20dff9f1cb335cd9f24ded330fd4e4","user":{"login":"dreamteam-gg","id":37930087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTMwMDg3","avatar_url":"https://avatars1.githubusercontent.com/u/37930087?v=4","gravatar_id":"","url":"https://api.github.com/users/dreamteam-gg","html_url":"https://github.com/dreamteam-gg","followers_url":"https://api.github.com/users/dreamteam-gg/followers","following_url":"https://api.github.com/users/dreamteam-gg/following{/other_user}","gists_url":"https://api.github.com/users/dreamteam-gg/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamteam-gg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamteam-gg/subscriptions","organizations_url":"https://api.github.com/users/dreamteam-gg/orgs","repos_url":"https://api.github.com/users/dreamteam-gg/repos","events_url":"https://api.github.com/users/dreamteam-gg/events{/privacy}","received_events_url":"https://api.github.com/users/dreamteam-gg/received_events","type":"Organization","site_admin":false},"repo":{"id":143158512,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxNTg1MTI=","name":"rds_exporter","full_name":"dreamteam-gg/rds_exporter","owner":{"login":"dreamteam-gg","id":37930087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTMwMDg3","avatar_url":"https://avatars1.githubusercontent.com/u/37930087?v=4","gravatar_id":"","url":"https://api.github.com/users/dreamteam-gg","html_url":"https://github.com/dreamteam-gg","followers_url":"https://api.github.com/users/dreamteam-gg/followers","following_url":"https://api.github.com/users/dreamteam-gg/following{/other_user}","gists_url":"https://api.github.com/users/dreamteam-gg/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamteam-gg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamteam-gg/subscriptions","organizations_url":"https://api.github.com/users/dreamteam-gg/orgs","repos_url":"https://api.github.com/users/dreamteam-gg/repos","events_url":"https://api.github.com/users/dreamteam-gg/events{/privacy}","received_events_url":"https://api.github.com/users/dreamteam-gg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dreamteam-gg/rds_exporter","description":"RDS exporter for Prometheus","fork":true,"url":"https://api.github.com/repos/dreamteam-gg/rds_exporter","forks_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/forks","keys_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/teams","hooks_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/hooks","issue_events_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/events","assignees_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/tags","blobs_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/languages","stargazers_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/stargazers","contributors_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/contributors","subscribers_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/subscribers","subscription_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/subscription","commits_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/merges","archive_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/downloads","issues_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/labels{/name}","releases_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/dreamteam-gg/rds_exporter/deployments","created_at":"2018-08-01T13:17:14Z","updated_at":"2018-08-01T13:17:16Z","pushed_at":"2018-08-09T11:49:44Z","git_url":"git://github.com/dreamteam-gg/rds_exporter.git","ssh_url":"git@github.com:dreamteam-gg/rds_exporter.git","clone_url":"https://github.com/dreamteam-gg/rds_exporter.git","svn_url":"https://github.com/dreamteam-gg/rds_exporter","homepage":"","size":12862,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"percona:master","ref":"master","sha":"2023b9a664ce84b742ff8e81b079a56d76a01d10","user":{"login":"percona","id":1683025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODMwMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":108108265,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxMDgyNjU=","name":"rds_exporter","full_name":"percona/rds_exporter","owner":{"login":"percona","id":1683025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODMwMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/rds_exporter","description":"RDS exporter for Prometheus","fork":true,"url":"https://api.github.com/repos/percona/rds_exporter","forks_url":"https://api.github.com/repos/percona/rds_exporter/forks","keys_url":"https://api.github.com/repos/percona/rds_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/rds_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/rds_exporter/teams","hooks_url":"https://api.github.com/repos/percona/rds_exporter/hooks","issue_events_url":"https://api.github.com/repos/percona/rds_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/percona/rds_exporter/events","assignees_url":"https://api.github.com/repos/percona/rds_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/percona/rds_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/percona/rds_exporter/tags","blobs_url":"https://api.github.com/repos/percona/rds_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/rds_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/rds_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/rds_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/rds_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/rds_exporter/languages","stargazers_url":"https://api.github.com/repos/percona/rds_exporter/stargazers","contributors_url":"https://api.github.com/repos/percona/rds_exporter/contributors","subscribers_url":"https://api.github.com/repos/percona/rds_exporter/subscribers","subscription_url":"https://api.github.com/repos/percona/rds_exporter/subscription","commits_url":"https://api.github.com/repos/percona/rds_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/rds_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/rds_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/rds_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/rds_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/percona/rds_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/rds_exporter/merges","archive_url":"https://api.github.com/repos/percona/rds_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/rds_exporter/downloads","issues_url":"https://api.github.com/repos/percona/rds_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/percona/rds_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/rds_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/rds_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/rds_exporter/labels{/name}","releases_url":"https://api.github.com/repos/percona/rds_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/percona/rds_exporter/deployments","created_at":"2017-10-24T09:54:18Z","updated_at":"2018-08-09T16:05:00Z","pushed_at":"2018-08-09T16:04:58Z","git_url":"git://github.com/percona/rds_exporter.git","ssh_url":"git@github.com:percona/rds_exporter.git","clone_url":"https://github.com/percona/rds_exporter.git","svn_url":"https://github.com/percona/rds_exporter","homepage":"","size":12857,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/rds_exporter/pulls/12"},"html":{"href":"https://github.com/percona/rds_exporter/pull/12"},"issue":{"href":"https://api.github.com/repos/percona/rds_exporter/issues/12"},"comments":{"href":"https://api.github.com/repos/percona/rds_exporter/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/rds_exporter/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/rds_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/rds_exporter/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/percona/rds_exporter/statuses/b75a4f31bb20dff9f1cb335cd9f24ded330fd4e4"}},"author_association":"NONE"}}
{"actor":{"display_login":"delgod"}}