{"action":"created","issue":{"url":"https://api.github.com/repos/jeuxdeau/Vaseline/issues/22","repository_url":"https://api.github.com/repos/jeuxdeau/Vaseline","labels_url":"https://api.github.com/repos/jeuxdeau/Vaseline/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/jeuxdeau/Vaseline/issues/22/comments","events_url":"https://api.github.com/repos/jeuxdeau/Vaseline/issues/22/events","html_url":"https://github.com/jeuxdeau/Vaseline/issues/22","id":324036278,"number":22,"title":"5월 17일 회의 요약","user":{"login":"jeuxdeau","id":22112344,"avatar_url":"https://avatars1.githubusercontent.com/u/22112344?v=4","gravatar_id":"","url":"https://api.github.com/users/jeuxdeau","html_url":"https://github.com/jeuxdeau","followers_url":"https://api.github.com/users/jeuxdeau/followers","following_url":"https://api.github.com/users/jeuxdeau/following{/other_user}","gists_url":"https://api.github.com/users/jeuxdeau/gists{/gist_id}","starred_url":"https://api.github.com/users/jeuxdeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeuxdeau/subscriptions","organizations_url":"https://api.github.com/users/jeuxdeau/orgs","repos_url":"https://api.github.com/users/jeuxdeau/repos","events_url":"https://api.github.com/users/jeuxdeau/events{/privacy}","received_events_url":"https://api.github.com/users/jeuxdeau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"AirHorizons","id":14194412,"avatar_url":"https://avatars0.githubusercontent.com/u/14194412?v=4","gravatar_id":"","url":"https://api.github.com/users/AirHorizons","html_url":"https://github.com/AirHorizons","followers_url":"https://api.github.com/users/AirHorizons/followers","following_url":"https://api.github.com/users/AirHorizons/following{/other_user}","gists_url":"https://api.github.com/users/AirHorizons/gists{/gist_id}","starred_url":"https://api.github.com/users/AirHorizons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AirHorizons/subscriptions","organizations_url":"https://api.github.com/users/AirHorizons/orgs","repos_url":"https://api.github.com/users/AirHorizons/repos","events_url":"https://api.github.com/users/AirHorizons/events{/privacy}","received_events_url":"https://api.github.com/users/AirHorizons/received_events","type":"User","site_admin":false},"assignees":[{"login":"AirHorizons","id":14194412,"avatar_url":"https://avatars0.githubusercontent.com/u/14194412?v=4","gravatar_id":"","url":"https://api.github.com/users/AirHorizons","html_url":"https://github.com/AirHorizons","followers_url":"https://api.github.com/users/AirHorizons/followers","following_url":"https://api.github.com/users/AirHorizons/following{/other_user}","gists_url":"https://api.github.com/users/AirHorizons/gists{/gist_id}","starred_url":"https://api.github.com/users/AirHorizons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AirHorizons/subscriptions","organizations_url":"https://api.github.com/users/AirHorizons/orgs","repos_url":"https://api.github.com/users/AirHorizons/repos","events_url":"https://api.github.com/users/AirHorizons/events{/privacy}","received_events_url":"https://api.github.com/users/AirHorizons/received_events","type":"User","site_admin":false},{"login":"SonSang","id":20263232,"avatar_url":"https://avatars0.githubusercontent.com/u/20263232?v=4","gravatar_id":"","url":"https://api.github.com/users/SonSang","html_url":"https://github.com/SonSang","followers_url":"https://api.github.com/users/SonSang/followers","following_url":"https://api.github.com/users/SonSang/following{/other_user}","gists_url":"https://api.github.com/users/SonSang/gists{/gist_id}","starred_url":"https://api.github.com/users/SonSang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonSang/subscriptions","organizations_url":"https://api.github.com/users/SonSang/orgs","repos_url":"https://api.github.com/users/SonSang/repos","events_url":"https://api.github.com/users/SonSang/events{/privacy}","received_events_url":"https://api.github.com/users/SonSang/received_events","type":"User","site_admin":false},{"login":"jeuxdeau","id":22112344,"avatar_url":"https://avatars1.githubusercontent.com/u/22112344?v=4","gravatar_id":"","url":"https://api.github.com/users/jeuxdeau","html_url":"https://github.com/jeuxdeau","followers_url":"https://api.github.com/users/jeuxdeau/followers","following_url":"https://api.github.com/users/jeuxdeau/following{/other_user}","gists_url":"https://api.github.com/users/jeuxdeau/gists{/gist_id}","starred_url":"https://api.github.com/users/jeuxdeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeuxdeau/subscriptions","organizations_url":"https://api.github.com/users/jeuxdeau/orgs","repos_url":"https://api.github.com/users/jeuxdeau/repos","events_url":"https://api.github.com/users/jeuxdeau/events{/privacy}","received_events_url":"https://api.github.com/users/jeuxdeau/received_events","type":"User","site_admin":false},{"login":"jinwoo71","id":37094648,"avatar_url":"https://avatars3.githubusercontent.com/u/37094648?v=4","gravatar_id":"","url":"https://api.github.com/users/jinwoo71","html_url":"https://github.com/jinwoo71","followers_url":"https://api.github.com/users/jinwoo71/followers","following_url":"https://api.github.com/users/jinwoo71/following{/other_user}","gists_url":"https://api.github.com/users/jinwoo71/gists{/gist_id}","starred_url":"https://api.github.com/users/jinwoo71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinwoo71/subscriptions","organizations_url":"https://api.github.com/users/jinwoo71/orgs","repos_url":"https://api.github.com/users/jinwoo71/repos","events_url":"https://api.github.com/users/jinwoo71/events{/privacy}","received_events_url":"https://api.github.com/users/jinwoo71/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-05-17T14:00:23Z","updated_at":"2018-05-25T13:03:37Z","closed_at":null,"author_association":"OWNER","body":"**backend**\r\n- companion, personality, desired mate 등을 새로운 모델로 만들어서 onetoone으로 받는 것 외에 다른 대안이 없어 보인다. (그렇게 하지 않으면 model field를 쓸 수 있는지?)\r\n- [TODO] 주소 우편번호 빼고 1차(시/도) 2차(시/군/구) 두 가지로만 받기\r\n- ~~[TODO] desired mate의 성격도 받아야 한다~~\r\n- ~~[TODO] 성별, 품종은 enum으로 받고 있는데, 뭐든 상관없음~~ 또는 개중에서 여러가지 선택 가능해야\r\n- ~~[TODO] 그냥 리트리버 만들기, 한국 토종견 지우기 (귀찮으면, 어차피 예외 인풋 안 들어오므로 텍스트 필드로 날려버리는 방법이 있다)~~\r\n- 모델에서 사진 영상 저장할 필드 있긴 해야 되는데, 이건 프론트에서 사진 영상을 어떻게 넘기는지를 보고 생각해보는 게 좋을 것 같네요.\r\n- email, username 한글이나 특수문자 섞여도 상관 없는 것 같다(?)\r\n- mating season datetime 말고 date field 있는 것 같은데 고치고 싶으면 고치고 아니면 프론트에서 00:00:00 붙여서 넘겨드림\r\n\r\n**frontend**\r\n- saga와 redux api middleware (특히 post할 때) 장단점이 뭔지 정 귀찮으면 전부 미들웨어로 통일하자. saga 쓸 거면 store/configure.js에서 등록이 필요하다.\r\n- privateroute 관련: 왜 자꾸 메인으로 넘어갈까요? invalid url 왜 signin으로 넘어갈까요?\r\n- react bootstrap에서 전체 form 단위 말고 개별 인풋에 대해 reference 달 수 있는지\r\n- [TODO: 우빈] id, username, email에 대한 중복확인\r\n- [TODO: 우빈] 사진, 영상 첨부\r\n- 가이드 페이지를 언제 보여줘야 할까. 가입했을 때? 매칭 성사됐을 때? 체크박스로 읽었음 표시해야 하나? 그러면 그냥 다시 보고 싶어서 들어간 경우는 어떡하지?\r\n- 중요한 건 아니고 아크로 만들어진 디렉토리 구조(component/molecule, atom, pages...) 심심하면 통일할 것\r\n\r\n**etc**\r\n- 주소를 1차, 2차로만 받을 때 가까운 거리를 계산하는 방법\r\n- 패스워드, 장고 기본 해싱으로 뭐 하는지. JWT랑 어떻게 연결하는지 등등. 헷갈리는 부분이 많아서 연구가 필요해 보인다.\r\n- 데모 브랜치를 날려 버려서 가이드 페이지가 진우의 git/vaseline... component/pages/intropage 여기에만 있을 건데 (마스터로 바로 푸시해도 좋고) 하여튼 올려주세요\r\n- 해결된 이슈 적당히 닫자 (근데 지금까지 해결된 거 딱히 없어 보인다)\r\n- 다음 발표때부터는 기술적인 얘기를 더 많이 넣자\r\n- 다른 조들 발표 다들 멋있었고 가져가 쓰고 싶은 것들 배우고 싶은 점 많다. 리포나 발표 자료를 공유했으면 좋겠다.\r\n- 오늘 수업때 Travis CI 하면서 등록은 해놨는데 아직 잘 모르겠어서 조교님 자료 올라오면 좀 더 공부해보고 정리해서 올리겠습니다.\r\n\r\n빼먹은 부분 있으면 이 글 수정해 주세요. 즐거웠고 오늘 저녁 내내 수고 많으셨습니다."},"comment":{"url":"https://api.github.com/repos/jeuxdeau/Vaseline/issues/comments/392051246","html_url":"https://github.com/jeuxdeau/Vaseline/issues/22#issuecomment-392051246","issue_url":"https://api.github.com/repos/jeuxdeau/Vaseline/issues/22","id":392051246,"user":{"login":"jinwoo71","id":37094648,"avatar_url":"https://avatars3.githubusercontent.com/u/37094648?v=4","gravatar_id":"","url":"https://api.github.com/users/jinwoo71","html_url":"https://github.com/jinwoo71","followers_url":"https://api.github.com/users/jinwoo71/followers","following_url":"https://api.github.com/users/jinwoo71/following{/other_user}","gists_url":"https://api.github.com/users/jinwoo71/gists{/gist_id}","starred_url":"https://api.github.com/users/jinwoo71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinwoo71/subscriptions","organizations_url":"https://api.github.com/users/jinwoo71/orgs","repos_url":"https://api.github.com/users/jinwoo71/repos","events_url":"https://api.github.com/users/jinwoo71/events{/privacy}","received_events_url":"https://api.github.com/users/jinwoo71/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T13:03:37Z","updated_at":"2018-05-25T13:03:37Z","author_association":"COLLABORATOR","body":"음.. 너무 고민된다\r\n지금 first address랑 second address 받는게 잘 안돼서 text로 받으면 나는 엄청 편하긴 한데 ㅠ\r\n혹시 모를 상황 (프론트에서 잘못된 형식의 데이터 전송)에 대비해서 백엔드도 enum 타입으로 저장해놓아야 올바른 것 같은데 과한 생각일까?"}}
{"actor":{"display_login":"jinwoo71"}}