{"action":"created","issue":{"url":"https://api.github.com/repos/weavejester/ring-oauth2/issues/19","repository_url":"https://api.github.com/repos/weavejester/ring-oauth2","labels_url":"https://api.github.com/repos/weavejester/ring-oauth2/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/weavejester/ring-oauth2/issues/19/comments","events_url":"https://api.github.com/repos/weavejester/ring-oauth2/issues/19/events","html_url":"https://github.com/weavejester/ring-oauth2/issues/19","id":367953375,"node_id":"MDU6SXNzdWUzNjc5NTMzNzU=","number":19,"title":"Scary error when forgetting `client_id` or `client_secret`","user":{"login":"AndreaCrotti","id":53640,"node_id":"MDQ6VXNlcjUzNjQw","avatar_url":"https://avatars2.githubusercontent.com/u/53640?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreaCrotti","html_url":"https://github.com/AndreaCrotti","followers_url":"https://api.github.com/users/AndreaCrotti/followers","following_url":"https://api.github.com/users/AndreaCrotti/following{/other_user}","gists_url":"https://api.github.com/users/AndreaCrotti/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreaCrotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreaCrotti/subscriptions","organizations_url":"https://api.github.com/users/AndreaCrotti/orgs","repos_url":"https://api.github.com/users/AndreaCrotti/repos","events_url":"https://api.github.com/users/AndreaCrotti/events{/privacy}","received_events_url":"https://api.github.com/users/AndreaCrotti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-08T21:07:22Z","updated_at":"2018-10-08T23:08:03Z","closed_at":null,"author_association":"NONE","body":"At the moment if by any chance `client_id` or `client_secret` are `nil` you would eventually get this error:\r\n\r\n```\r\njava.lang.IllegalArgumentException\r\nNo implementation of method: :form-encode* of protocol: #'ring.util.codec/FormEncodeable found for class: nil \r\n```\r\n\r\nWhich is kind of cryptic, and the thing is that since most of the times `client_id` `client_secret` would passed in (I guess) often as environment variables, it's probably easy to forget they are not set locally, and thus spending a lot of time trying to figure out what's wrong (as it happened to me). Some basic validation at least on these two fields would be enough imho."},"comment":{"url":"https://api.github.com/repos/weavejester/ring-oauth2/issues/comments/428007472","html_url":"https://github.com/weavejester/ring-oauth2/issues/19#issuecomment-428007472","issue_url":"https://api.github.com/repos/weavejester/ring-oauth2/issues/19","id":428007472,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODAwNzQ3Mg==","user":{"login":"weavejester","id":8780,"node_id":"MDQ6VXNlcjg3ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/8780?v=4","gravatar_id":"","url":"https://api.github.com/users/weavejester","html_url":"https://github.com/weavejester","followers_url":"https://api.github.com/users/weavejester/followers","following_url":"https://api.github.com/users/weavejester/following{/other_user}","gists_url":"https://api.github.com/users/weavejester/gists{/gist_id}","starred_url":"https://api.github.com/users/weavejester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weavejester/subscriptions","organizations_url":"https://api.github.com/users/weavejester/orgs","repos_url":"https://api.github.com/users/weavejester/repos","events_url":"https://api.github.com/users/weavejester/events{/privacy}","received_events_url":"https://api.github.com/users/weavejester/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T23:08:03Z","updated_at":"2018-10-08T23:08:03Z","author_association":"OWNER","body":"This would be a good addition. Perhaps an `assert` or precondition could be used."}}
{"actor":{"display_login":"weavejester"}}