{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/190702189","pull_request_review_id":123130854,"id":190702189,"diff_hunk":"@@ -267,6 +282,23 @@ def get_all_commits(cls, page_size, urlsafe_start_cursor):\n         return cls._fetch_page_sorted_by_last_updated(\n             cls.query(), page_size, urlsafe_start_cursor)\n \n+    @classmethod\n+    def get_commit(cls, instance_id, version):\n+        \"\"\"Returns the commit corresponding to an instance id and\n+        version number.\n+\n+        Args:\n+            instance_id: str. The id of the particular construct, from which","path":"core/storage/base_model/gae_models.py","position":72,"original_position":32,"commit_id":"0d5c1c55a4f7bfc47793060223c2d322fc76a5c3","original_commit_id":"0d5c1c55a4f7bfc47793060223c2d322fc76a5c3","user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"body":"The effect of naming both the arg and the function above as instance_id has the consequence that now, I don't know what instance_id actually refers to :)\r\n\r\nProbably it means the same thing as above, in which case please see previous comment.","created_at":"2018-05-24T19:19:52Z","updated_at":"2018-05-24T19:30:05Z","html_url":"https://github.com/oppia/oppia/pull/4953#discussion_r190702189","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/4953","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/190702189"},"html":{"href":"https://github.com/oppia/oppia/pull/4953#discussion_r190702189"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4953"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/4953","id":189039713,"html_url":"https://github.com/oppia/oppia/pull/4953","diff_url":"https://github.com/oppia/oppia/pull/4953.diff","patch_url":"https://github.com/oppia/oppia/pull/4953.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/4953","number":4953,"state":"open","locked":false,"title":"Add Functionality for Skills: Milestone 1.1","user":{"login":"aks681","id":22347970,"avatar_url":"https://avatars3.githubusercontent.com/u/22347970?v=4","gravatar_id":"","url":"https://api.github.com/users/aks681","html_url":"https://github.com/aks681","followers_url":"https://api.github.com/users/aks681/followers","following_url":"https://api.github.com/users/aks681/following{/other_user}","gists_url":"https://api.github.com/users/aks681/gists{/gist_id}","starred_url":"https://api.github.com/users/aks681/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aks681/subscriptions","organizations_url":"https://api.github.com/users/aks681/orgs","repos_url":"https://api.github.com/users/aks681/repos","events_url":"https://api.github.com/users/aks681/events{/privacy}","received_events_url":"https://api.github.com/users/aks681/received_events","type":"User","site_admin":false},"body":"In this PR, all the backend models for Skill, Story and Topic have been created in core/storage. Also, the story_domain.py and story_services.py files are done.\r\n\r\nFor testing, I tried with the developer console and was able to save a story to datastore and retrieve it later by its id. \r\n","created_at":"2018-05-18T14:15:24Z","updated_at":"2018-05-24T19:30:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d70c04220c30495785819c7f5cbcd5292a115f11","assignee":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"assignees":[{"login":"seanlip","id":10575562,"avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/4953/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/4953/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/4953/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/0d5c1c55a4f7bfc47793060223c2d322fc76a5c3","head":{"label":"aks681:milestone_1.1","ref":"milestone_1.1","sha":"0d5c1c55a4f7bfc47793060223c2d322fc76a5c3","user":{"login":"aks681","id":22347970,"avatar_url":"https://avatars3.githubusercontent.com/u/22347970?v=4","gravatar_id":"","url":"https://api.github.com/users/aks681","html_url":"https://github.com/aks681","followers_url":"https://api.github.com/users/aks681/followers","following_url":"https://api.github.com/users/aks681/following{/other_user}","gists_url":"https://api.github.com/users/aks681/gists{/gist_id}","starred_url":"https://api.github.com/users/aks681/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aks681/subscriptions","organizations_url":"https://api.github.com/users/aks681/orgs","repos_url":"https://api.github.com/users/aks681/repos","events_url":"https://api.github.com/users/aks681/events{/privacy}","received_events_url":"https://api.github.com/users/aks681/received_events","type":"User","site_admin":false},"repo":{"id":112202645,"name":"oppia","full_name":"aks681/oppia","owner":{"login":"aks681","id":22347970,"avatar_url":"https://avatars3.githubusercontent.com/u/22347970?v=4","gravatar_id":"","url":"https://api.github.com/users/aks681","html_url":"https://github.com/aks681","followers_url":"https://api.github.com/users/aks681/followers","following_url":"https://api.github.com/users/aks681/following{/other_user}","gists_url":"https://api.github.com/users/aks681/gists{/gist_id}","starred_url":"https://api.github.com/users/aks681/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aks681/subscriptions","organizations_url":"https://api.github.com/users/aks681/orgs","repos_url":"https://api.github.com/users/aks681/repos","events_url":"https://api.github.com/users/aks681/events{/privacy}","received_events_url":"https://api.github.com/users/aks681/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aks681/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/aks681/oppia","forks_url":"https://api.github.com/repos/aks681/oppia/forks","keys_url":"https://api.github.com/repos/aks681/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aks681/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aks681/oppia/teams","hooks_url":"https://api.github.com/repos/aks681/oppia/hooks","issue_events_url":"https://api.github.com/repos/aks681/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/aks681/oppia/events","assignees_url":"https://api.github.com/repos/aks681/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/aks681/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/aks681/oppia/tags","blobs_url":"https://api.github.com/repos/aks681/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aks681/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aks681/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/aks681/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aks681/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/aks681/oppia/languages","stargazers_url":"https://api.github.com/repos/aks681/oppia/stargazers","contributors_url":"https://api.github.com/repos/aks681/oppia/contributors","subscribers_url":"https://api.github.com/repos/aks681/oppia/subscribers","subscription_url":"https://api.github.com/repos/aks681/oppia/subscription","commits_url":"https://api.github.com/repos/aks681/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/aks681/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/aks681/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/aks681/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/aks681/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/aks681/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aks681/oppia/merges","archive_url":"https://api.github.com/repos/aks681/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aks681/oppia/downloads","issues_url":"https://api.github.com/repos/aks681/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/aks681/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/aks681/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/aks681/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aks681/oppia/labels{/name}","releases_url":"https://api.github.com/repos/aks681/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/aks681/oppia/deployments","created_at":"2017-11-27T13:56:34Z","updated_at":"2018-05-24T19:02:03Z","pushed_at":"2018-05-24T19:04:57Z","git_url":"git://github.com/aks681/oppia.git","ssh_url":"git@github.com:aks681/oppia.git","clone_url":"https://github.com/aks681/oppia.git","svn_url":"https://github.com/aks681/oppia","homepage":"https://www.oppia.org","size":102764,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"da8ba55f88795610de444252ba19c15e5663ff2c","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-05-24T18:45:28Z","pushed_at":"2018-05-24T19:11:59Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":102945,"stargazers_count":651,"watchers_count":651,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":629,"mirror_url":null,"archived":false,"open_issues_count":296,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":629,"open_issues":296,"watchers":651,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4953"},"html":{"href":"https://github.com/oppia/oppia/pull/4953"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/4953"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/4953/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4953/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4953/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/0d5c1c55a4f7bfc47793060223c2d322fc76a5c3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"seanlip"}}