{"action":"created","issue":{"url":"https://api.github.com/repos/openfaas/faas/issues/556","repository_url":"https://api.github.com/repos/openfaas/faas","labels_url":"https://api.github.com/repos/openfaas/faas/issues/556/labels{/name}","comments_url":"https://api.github.com/repos/openfaas/faas/issues/556/comments","events_url":"https://api.github.com/repos/openfaas/faas/issues/556/events","html_url":"https://github.com/openfaas/faas/pull/556","id":302017170,"number":556,"title":"Make UI block until function reports readiness","user":{"login":"alexellis","id":6358735,"avatar_url":"https://avatars1.githubusercontent.com/u/6358735?v=4","gravatar_id":"","url":"https://api.github.com/users/alexellis","html_url":"https://github.com/alexellis","followers_url":"https://api.github.com/users/alexellis/followers","following_url":"https://api.github.com/users/alexellis/following{/other_user}","gists_url":"https://api.github.com/users/alexellis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexellis/subscriptions","organizations_url":"https://api.github.com/users/alexellis/orgs","repos_url":"https://api.github.com/users/alexellis/repos","events_url":"https://api.github.com/users/alexellis/events{/privacy}","received_events_url":"https://api.github.com/users/alexellis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-03T17:40:30Z","updated_at":"2018-03-03T17:46:42Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/openfaas/faas/pulls/556","html_url":"https://github.com/openfaas/faas/pull/556","diff_url":"https://github.com/openfaas/faas/pull/556.diff","patch_url":"https://github.com/openfaas/faas/pull/556.patch"},"body":"Signed-off-by: Alex Ellis <alexellis2@gmail.com>\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\nFixes #555 \r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n- [x] I have raised an issue to propose this change ([required](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md))\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\nTested with faas-netes which provides `availableReplicas` on the `/system/function/<name>` endpoint.\r\n\r\nThis change requires a change to faas-swarm and faas-nomad to report `availableReplicas` = 1 all the time, or optionally when the underlying container is ready.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\nBreaking change to UI only, not to the API.\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I've read the [CONTRIBUTION](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md) guide\r\n- [x] I have signed-off my commits with `git commit -s`\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/openfaas/faas/issues/comments/370166188","html_url":"https://github.com/openfaas/faas/pull/556#issuecomment-370166188","issue_url":"https://api.github.com/repos/openfaas/faas/issues/556","id":370166188,"user":{"login":"alexellis","id":6358735,"avatar_url":"https://avatars1.githubusercontent.com/u/6358735?v=4","gravatar_id":"","url":"https://api.github.com/users/alexellis","html_url":"https://github.com/alexellis","followers_url":"https://api.github.com/users/alexellis/followers","following_url":"https://api.github.com/users/alexellis/following{/other_user}","gists_url":"https://api.github.com/users/alexellis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexellis/subscriptions","organizations_url":"https://api.github.com/users/alexellis/orgs","repos_url":"https://api.github.com/users/alexellis/repos","events_url":"https://api.github.com/users/alexellis/events{/privacy}","received_events_url":"https://api.github.com/users/alexellis/received_events","type":"User","site_admin":false},"created_at":"2018-03-03T17:46:42Z","updated_at":"2018-03-03T17:46:42Z","author_association":"OWNER","body":"@kenfdev please could you review / test? @dungeonmaster18 could you help with testing?"}}
{"actor":{"display_login":"alexellis"}}