{"action":"created","issue":{"url":"https://api.github.com/repos/lxc/lxc/issues/2259","repository_url":"https://api.github.com/repos/lxc/lxc","labels_url":"https://api.github.com/repos/lxc/lxc/issues/2259/labels{/name}","comments_url":"https://api.github.com/repos/lxc/lxc/issues/2259/comments","events_url":"https://api.github.com/repos/lxc/lxc/issues/2259/events","html_url":"https://github.com/lxc/lxc/pull/2259","id":311875193,"number":2259,"title":"rootfs pinning: On NFS, make file hidden but don't delete it","user":{"login":"gjaekel","id":19855721,"avatar_url":"https://avatars0.githubusercontent.com/u/19855721?v=4","gravatar_id":"","url":"https://api.github.com/users/gjaekel","html_url":"https://github.com/gjaekel","followers_url":"https://api.github.com/users/gjaekel/followers","following_url":"https://api.github.com/users/gjaekel/following{/other_user}","gists_url":"https://api.github.com/users/gjaekel/gists{/gist_id}","starred_url":"https://api.github.com/users/gjaekel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjaekel/subscriptions","organizations_url":"https://api.github.com/users/gjaekel/orgs","repos_url":"https://api.github.com/users/gjaekel/repos","events_url":"https://api.github.com/users/gjaekel/events{/privacy}","received_events_url":"https://api.github.com/users/gjaekel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-06T07:38:47Z","updated_at":"2018-04-06T09:24:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/lxc/lxc/pulls/2259","html_url":"https://github.com/lxc/lxc/pull/2259","diff_url":"https://github.com/lxc/lxc/pull/2259.diff","patch_url":"https://github.com/lxc/lxc/pull/2259.patch"},"body":"On NFS, avoid random names of the root pin file due to \"NFS silly renaming\" but use a fixed hidden name instead.\r\n\r\nIMHO this is a better solution because one is able to relate the anyway vislble file to a purpose.\r\n\r\nSigned-off-by: <G.Jaekel@DNB.DE>"},"comment":{"url":"https://api.github.com/repos/lxc/lxc/issues/comments/379198974","html_url":"https://github.com/lxc/lxc/pull/2259#issuecomment-379198974","issue_url":"https://api.github.com/repos/lxc/lxc/issues/2259","id":379198974,"user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars0.githubusercontent.com/u/7353573?v=4","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"created_at":"2018-04-06T09:24:52Z","updated_at":"2018-04-06T09:24:52Z","author_association":"MEMBER","body":"Let me ask a few question on the patch. On the mailing list [1] you said:\r\n\r\n\r\n> Serge, reject the patch because it introduces a varying name for each use of the rootfs. I agree that one name will be enough. But the ugly NFS quirk with the visible file for a stale handle for each unlinked file will remain.\r\n\r\nWhat exactly is the problem with NFS silly rename? The file will be hidden, right, i.e. it will be `.nfsXXXXX` or something. Is it only the fact that this file is around that is bothering you or is this causing an actual issue?\r\n\r\n[1]: https://lists.linuxcontainers.org/pipermail/lxc-devel/2018-March/017544.html"}}
{"actor":{"display_login":"brauner"}}