{"action":"created","issue":{"url":"https://api.github.com/repos/wradlib/wradlib-docs/issues/6","repository_url":"https://api.github.com/repos/wradlib/wradlib-docs","labels_url":"https://api.github.com/repos/wradlib/wradlib-docs/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/wradlib/wradlib-docs/issues/6/comments","events_url":"https://api.github.com/repos/wradlib/wradlib-docs/issues/6/events","html_url":"https://github.com/wradlib/wradlib-docs/pull/6","id":362915988,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDk0MTk0","number":6,"title":"MIN: Fix conformance, correctness and consistency issues in docs","user":{"login":"CAM-Gerlach","id":17051931,"node_id":"MDQ6VXNlcjE3MDUxOTMx","avatar_url":"https://avatars0.githubusercontent.com/u/17051931?v=4","gravatar_id":"","url":"https://api.github.com/users/CAM-Gerlach","html_url":"https://github.com/CAM-Gerlach","followers_url":"https://api.github.com/users/CAM-Gerlach/followers","following_url":"https://api.github.com/users/CAM-Gerlach/following{/other_user}","gists_url":"https://api.github.com/users/CAM-Gerlach/gists{/gist_id}","starred_url":"https://api.github.com/users/CAM-Gerlach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CAM-Gerlach/subscriptions","organizations_url":"https://api.github.com/users/CAM-Gerlach/orgs","repos_url":"https://api.github.com/users/CAM-Gerlach/repos","events_url":"https://api.github.com/users/CAM-Gerlach/events{/privacy}","received_events_url":"https://api.github.com/users/CAM-Gerlach/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-23T05:46:08Z","updated_at":"2018-10-02T06:49:02Z","closed_at":"2018-10-02T06:48:19Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wradlib/wradlib-docs/pulls/6","html_url":"https://github.com/wradlib/wradlib-docs/pull/6","diff_url":"https://github.com/wradlib/wradlib-docs/pull/6.diff","patch_url":"https://github.com/wradlib/wradlib-docs/pull/6.patch"},"body":"While I was at it, I figured I'd fix some low-hanging fruit conformance and correctness issues I found in the repo. This is still [WiP], since I'm awaiting a merge on #5 to avoid a conflict and keep things clean. I committed the changes in rough order of likelihood of any potential disagreement/ease of reverting, so I can more easily drop any commits if any aren't desired by the project maintainers for a good reason.\r\n\r\nSpecifically this PR:\r\n* Adds a terminating EOL to files missing it, as it is officially required for properly formed text files particularly on Mac/Linux/Unix OSes, and a number of programs (particularly command-line and programming tools) will break or not operate correctly. It also avoids Git raising a warning every time ``git diff`` is run on the files.\r\n* Converts date representation(s) to the international, unambiguous ISO 8601 format, which avoids issues with locale-specific dates (as was currently used) and is a standard convention in programming/science/engineering\r\n* Strips unneeded trailing whitespace from the files that have it, to avoid future merge conflicts and other inconsistencies as many editors do this by default, as well as a moderate savings in file size\r\n* Converts a few instances of tabs instead of spaces for consistency (as most code is in spaces, not tabs), to conform to PEP 8 and the reST specification (which strongly recommends spaces instead of tabs and converts to spaces on input), and avoid twice the width being inserted in the final document as intended and apparent in most editors (as reST/docutils assumes a tab width of 8 spaces by default).\r\n* Upgrades several missed links to HTTPS (after first confirming no difference in functionality vs. the HTTP version), and updates a few broken/redirected links\r\n* Conforms all files to consistent EOLs (LF), which avoids the current mix of EOLs (most LF but some CRLF), reduces file size, avoids Git constantly adding spurious <kbd>M</kbd> indications to every changed line, ensures consistency across all platforms, avoids any problem with command-line tools, and conforms to general best practices.\r\n* Adds a ``.gitattributes`` file, which enforces EOL consistency and sensible default behavior across platforms (will be commited after previous is unblocked)\r\n* Adds a basic ``.gitignore`` file, with common language-independent and reST/Sphinx/Python specific ignores  (will be commited after previous is unblocked)\r\n\r\nThanks, and let me know your feedback.\r\n\r\nLast steps:\r\n\r\n* [x] Rebase after #5 \r\n* [x] Convert GettingStarted to LF\r\n* [x] Add Gitattributes\r\n* [x] Add Gitignore"},"comment":{"url":"https://api.github.com/repos/wradlib/wradlib-docs/issues/comments/426167149","html_url":"https://github.com/wradlib/wradlib-docs/pull/6#issuecomment-426167149","issue_url":"https://api.github.com/repos/wradlib/wradlib-docs/issues/6","id":426167149,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjE2NzE0OQ==","user":{"login":"kmuehlbauer","id":5821660,"node_id":"MDQ6VXNlcjU4MjE2NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/5821660?v=4","gravatar_id":"","url":"https://api.github.com/users/kmuehlbauer","html_url":"https://github.com/kmuehlbauer","followers_url":"https://api.github.com/users/kmuehlbauer/followers","following_url":"https://api.github.com/users/kmuehlbauer/following{/other_user}","gists_url":"https://api.github.com/users/kmuehlbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/kmuehlbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmuehlbauer/subscriptions","organizations_url":"https://api.github.com/users/kmuehlbauer/orgs","repos_url":"https://api.github.com/users/kmuehlbauer/repos","events_url":"https://api.github.com/users/kmuehlbauer/events{/privacy}","received_events_url":"https://api.github.com/users/kmuehlbauer/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T06:49:02Z","updated_at":"2018-10-02T06:49:02Z","author_association":"MEMBER","body":"@CAM-Gerlach Thanks for your contribution!"}}
{"actor":{"display_login":"kmuehlbauer"}}