{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/191276474","pull_request_review_id":123815642,"id":191276474,"diff_hunk":"@@ -661,12 +662,12 @@ void BitcoinGUI::trayIconActivated(QSystemTrayIcon::ActivationReason reason)\n \n void BitcoinGUI::optionsClicked()\n {\n-    if(!clientModel || !clientModel->getOptionsModel())\n-        return;\n+    openOptionsDialogWithTabIndex(0);\n+}\n \n-    OptionsDialog dlg(this, enableWallet);\n-    dlg.setModel(clientModel->getOptionsModel());\n-    dlg.exec();\n+void BitcoinGUI::proxyIconClicked()\n+{\n+    openOptionsDialogWithTabIndex(2);","path":"src/qt/bitcoingui.cpp","position":31,"original_position":31,"commit_id":"a73098955f119690d270f8d4c872445873c41cc5","original_commit_id":"a73098955f119690d270f8d4c872445873c41cc5","user":{"login":"promag","id":3534524,"avatar_url":"https://avatars1.githubusercontent.com/u/3534524?v=4","gravatar_id":"","url":"https://api.github.com/users/promag","html_url":"https://github.com/promag","followers_url":"https://api.github.com/users/promag/followers","following_url":"https://api.github.com/users/promag/following{/other_user}","gists_url":"https://api.github.com/users/promag/gists{/gist_id}","starred_url":"https://api.github.com/users/promag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promag/subscriptions","organizations_url":"https://api.github.com/users/promag/orgs","repos_url":"https://api.github.com/users/promag/repos","events_url":"https://api.github.com/users/promag/events{/privacy}","received_events_url":"https://api.github.com/users/promag/received_events","type":"User","site_admin":false},"body":"Could create an enum for tab indexes? So it would be something like\r\n```cpp\r\nvoid BitcoinGUI::openOptionsDialogWithTab(OptionsDialog::Tab tab)\r\n```\r\n","created_at":"2018-05-28T22:10:18Z","updated_at":"2018-05-28T22:10:18Z","html_url":"https://github.com/bitcoin/bitcoin/pull/13248#discussion_r191276474","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13248","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/191276474"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/13248#discussion_r191276474"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13248"}},"in_reply_to_id":190829922},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13248","id":188569961,"html_url":"https://github.com/bitcoin/bitcoin/pull/13248","diff_url":"https://github.com/bitcoin/bitcoin/pull/13248.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/13248.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13248","number":13248,"state":"open","locked":false,"title":"[gui] Make proxy icon from statusbar clickable","user":{"login":"mess110","id":226170,"avatar_url":"https://avatars3.githubusercontent.com/u/226170?v=4","gravatar_id":"","url":"https://api.github.com/users/mess110","html_url":"https://github.com/mess110","followers_url":"https://api.github.com/users/mess110/followers","following_url":"https://api.github.com/users/mess110/following{/other_user}","gists_url":"https://api.github.com/users/mess110/gists{/gist_id}","starred_url":"https://api.github.com/users/mess110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mess110/subscriptions","organizations_url":"https://api.github.com/users/mess110/orgs","repos_url":"https://api.github.com/users/mess110/repos","events_url":"https://api.github.com/users/mess110/events{/privacy}","received_events_url":"https://api.github.com/users/mess110/received_events","type":"User","site_admin":false},"body":"Clicking on the proxy icon will open settings showing the network tab\r\n\r\nhttps://github.com/bitcoin/bitcoin/pull/11491#issuecomment-336685303","created_at":"2018-05-16T21:45:52Z","updated_at":"2018-05-28T22:10:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1796b5d57b6c94d88793f485f55786517e497047","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135946,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/GUI","name":"GUI","color":"02d7e1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13248/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13248/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13248/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/a73098955f119690d270f8d4c872445873c41cc5","head":{"label":"mess110:make_proxy_icon_clickable","ref":"make_proxy_icon_clickable","sha":"a73098955f119690d270f8d4c872445873c41cc5","user":{"login":"mess110","id":226170,"avatar_url":"https://avatars3.githubusercontent.com/u/226170?v=4","gravatar_id":"","url":"https://api.github.com/users/mess110","html_url":"https://github.com/mess110","followers_url":"https://api.github.com/users/mess110/followers","following_url":"https://api.github.com/users/mess110/following{/other_user}","gists_url":"https://api.github.com/users/mess110/gists{/gist_id}","starred_url":"https://api.github.com/users/mess110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mess110/subscriptions","organizations_url":"https://api.github.com/users/mess110/orgs","repos_url":"https://api.github.com/users/mess110/repos","events_url":"https://api.github.com/users/mess110/events{/privacy}","received_events_url":"https://api.github.com/users/mess110/received_events","type":"User","site_admin":false},"repo":{"id":101784766,"name":"bitcoin","full_name":"mess110/bitcoin","owner":{"login":"mess110","id":226170,"avatar_url":"https://avatars3.githubusercontent.com/u/226170?v=4","gravatar_id":"","url":"https://api.github.com/users/mess110","html_url":"https://github.com/mess110","followers_url":"https://api.github.com/users/mess110/followers","following_url":"https://api.github.com/users/mess110/following{/other_user}","gists_url":"https://api.github.com/users/mess110/gists{/gist_id}","starred_url":"https://api.github.com/users/mess110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mess110/subscriptions","organizations_url":"https://api.github.com/users/mess110/orgs","repos_url":"https://api.github.com/users/mess110/repos","events_url":"https://api.github.com/users/mess110/events{/privacy}","received_events_url":"https://api.github.com/users/mess110/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mess110/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/mess110/bitcoin","forks_url":"https://api.github.com/repos/mess110/bitcoin/forks","keys_url":"https://api.github.com/repos/mess110/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mess110/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mess110/bitcoin/teams","hooks_url":"https://api.github.com/repos/mess110/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/mess110/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/mess110/bitcoin/events","assignees_url":"https://api.github.com/repos/mess110/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/mess110/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/mess110/bitcoin/tags","blobs_url":"https://api.github.com/repos/mess110/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mess110/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mess110/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mess110/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mess110/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/mess110/bitcoin/languages","stargazers_url":"https://api.github.com/repos/mess110/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/mess110/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/mess110/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/mess110/bitcoin/subscription","commits_url":"https://api.github.com/repos/mess110/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mess110/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mess110/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mess110/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mess110/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/mess110/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mess110/bitcoin/merges","archive_url":"https://api.github.com/repos/mess110/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mess110/bitcoin/downloads","issues_url":"https://api.github.com/repos/mess110/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/mess110/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/mess110/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/mess110/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mess110/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/mess110/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/mess110/bitcoin/deployments","created_at":"2017-08-29T16:49:49Z","updated_at":"2018-05-20T09:23:56Z","pushed_at":"2018-05-20T09:23:54Z","git_url":"git://github.com/mess110/bitcoin.git","ssh_url":"git@github.com:mess110/bitcoin.git","clone_url":"https://github.com/mess110/bitcoin.git","svn_url":"https://github.com/mess110/bitcoin","homepage":"https://bitcoin.org/en/download","size":104395,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"4cfe17c3382ba750131cdc8703b2978132822070","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-05-28T22:02:15Z","pushed_at":"2018-05-28T18:23:48Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":106213,"stargazers_count":31889,"watchers_count":31889,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":19199,"mirror_url":null,"archived":false,"open_issues_count":796,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19199,"open_issues":796,"watchers":31889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13248"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/13248"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/13248"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/13248/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13248/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13248/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/a73098955f119690d270f8d4c872445873c41cc5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"promag"}}