{"action":"created","comment":{"url":"https://api.github.com/repos/clems4ever/authelia/pulls/comments/217000131","pull_request_review_id":154610053,"id":217000131,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzAwMDEzMQ==","diff_hunk":"@@ -85,10 +86,24 @@ export class LdapUsersDatabase implements IUsersDatabase {\n       }\n     )\n     .catch((err) =>\n-      Bluebird.reject(new Exceptions.LdapError(\"Failed during email retrieval: \" + err.message))\n+      Bluebird.reject(new Exceptions.LdapError(\"Failed during groups retrieval: \" + err.message))\n     );\n   }\n \n+  getUsersWithNetworkAddresses(): Bluebird<UsersWithNetworkAddresses[]> {\n+    const that = this;\n+    return that.withSession(\n+      that.configuration.user,\n+      that.configuration.password,\n+      (session) => {\n+        return session.searchWhitelist();","path":"server/src/lib/authentication/backends/ldap/LdapUsersDatabase.ts","position":23,"original_position":23,"commit_id":"1a3fc3894f260038f58f0871c5ce80668a23a9f0","original_commit_id":"638ea7ba0c524498b7ab1ea9e7b9a13bc0df4a27","user":{"login":"nightah","id":3339418,"node_id":"MDQ6VXNlcjMzMzk0MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3339418?v=4","gravatar_id":"","url":"https://api.github.com/users/nightah","html_url":"https://github.com/nightah","followers_url":"https://api.github.com/users/nightah/followers","following_url":"https://api.github.com/users/nightah/following{/other_user}","gists_url":"https://api.github.com/users/nightah/gists{/gist_id}","starred_url":"https://api.github.com/users/nightah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightah/subscriptions","organizations_url":"https://api.github.com/users/nightah/orgs","repos_url":"https://api.github.com/users/nightah/repos","events_url":"https://api.github.com/users/nightah/events{/privacy}","received_events_url":"https://api.github.com/users/nightah/received_events","type":"User","site_admin":false},"body":"Yeah this could potentially be somewhat taxing.\r\nIf/when attempting to do cache, I think it would be worthwhile to make how often it updates the cache a configurable parameter.","created_at":"2018-09-12T11:55:39Z","updated_at":"2018-09-12T11:55:40Z","html_url":"https://github.com/clems4ever/authelia/pull/273#discussion_r217000131","pull_request_url":"https://api.github.com/repos/clems4ever/authelia/pulls/273","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/clems4ever/authelia/pulls/comments/217000131"},"html":{"href":"https://github.com/clems4ever/authelia/pull/273#discussion_r217000131"},"pull_request":{"href":"https://api.github.com/repos/clems4ever/authelia/pulls/273"}},"in_reply_to_id":216450530},"pull_request":{"url":"https://api.github.com/repos/clems4ever/authelia/pulls/273","id":213629113,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjI5MTEz","html_url":"https://github.com/clems4ever/authelia/pull/273","diff_url":"https://github.com/clems4ever/authelia/pull/273.diff","patch_url":"https://github.com/clems4ever/authelia/pull/273.patch","issue_url":"https://api.github.com/repos/clems4ever/authelia/issues/273","number":273,"state":"open","locked":false,"title":"Network authentication whitelisting","user":{"login":"nightah","id":3339418,"node_id":"MDQ6VXNlcjMzMzk0MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3339418?v=4","gravatar_id":"","url":"https://api.github.com/users/nightah","html_url":"https://github.com/nightah","followers_url":"https://api.github.com/users/nightah/followers","following_url":"https://api.github.com/users/nightah/following{/other_user}","gists_url":"https://api.github.com/users/nightah/gists{/gist_id}","starred_url":"https://api.github.com/users/nightah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightah/subscriptions","organizations_url":"https://api.github.com/users/nightah/orgs","repos_url":"https://api.github.com/users/nightah/repos","events_url":"https://api.github.com/users/nightah/events{/privacy}","received_events_url":"https://api.github.com/users/nightah/received_events","type":"User","site_admin":false},"body":"This change provides the ability to whitelist networks, via IP addresses or CIDR notated ranges from authentication.\r\n\r\nThis can useful for example, if you want to provide authelia as an authentication mechanism, however, only want it to apply if you are on an external network.\r\n\r\nIf a request is made from a whitelisted IP address this will bypass authentication.\r\nHowever if that same request is made from a non-whitelisted IP address standard ACL rules will apply.\r\n\r\nThis is a reworked version of https://github.com/clems4ever/authelia/pull/264 now utilising the LDAP and File backends to determine a whitelisted user.","created_at":"2018-09-06T14:00:34Z","updated_at":"2018-09-12T11:55:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf64aabbf3523d5de83da5dee0d9fe3a371c0ef3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clems4ever/authelia/pulls/273/commits","review_comments_url":"https://api.github.com/repos/clems4ever/authelia/pulls/273/comments","review_comment_url":"https://api.github.com/repos/clems4ever/authelia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clems4ever/authelia/issues/273/comments","statuses_url":"https://api.github.com/repos/clems4ever/authelia/statuses/1a3fc3894f260038f58f0871c5ce80668a23a9f0","head":{"label":"antilax-3:network-whitelisting","ref":"network-whitelisting","sha":"1a3fc3894f260038f58f0871c5ce80668a23a9f0","user":{"login":"antilax-3","id":35715409,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzE1NDA5","avatar_url":"https://avatars2.githubusercontent.com/u/35715409?v=4","gravatar_id":"","url":"https://api.github.com/users/antilax-3","html_url":"https://github.com/antilax-3","followers_url":"https://api.github.com/users/antilax-3/followers","following_url":"https://api.github.com/users/antilax-3/following{/other_user}","gists_url":"https://api.github.com/users/antilax-3/gists{/gist_id}","starred_url":"https://api.github.com/users/antilax-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antilax-3/subscriptions","organizations_url":"https://api.github.com/users/antilax-3/orgs","repos_url":"https://api.github.com/users/antilax-3/repos","events_url":"https://api.github.com/users/antilax-3/events{/privacy}","received_events_url":"https://api.github.com/users/antilax-3/received_events","type":"Organization","site_admin":false},"repo":{"id":146182976,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYxODI5NzY=","name":"authelia","full_name":"antilax-3/authelia","owner":{"login":"antilax-3","id":35715409,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzE1NDA5","avatar_url":"https://avatars2.githubusercontent.com/u/35715409?v=4","gravatar_id":"","url":"https://api.github.com/users/antilax-3","html_url":"https://github.com/antilax-3","followers_url":"https://api.github.com/users/antilax-3/followers","following_url":"https://api.github.com/users/antilax-3/following{/other_user}","gists_url":"https://api.github.com/users/antilax-3/gists{/gist_id}","starred_url":"https://api.github.com/users/antilax-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antilax-3/subscriptions","organizations_url":"https://api.github.com/users/antilax-3/orgs","repos_url":"https://api.github.com/users/antilax-3/repos","events_url":"https://api.github.com/users/antilax-3/events{/privacy}","received_events_url":"https://api.github.com/users/antilax-3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/antilax-3/authelia","description":"Authentication server supporting single sign-on, 2-factor and authorizations","fork":true,"url":"https://api.github.com/repos/antilax-3/authelia","forks_url":"https://api.github.com/repos/antilax-3/authelia/forks","keys_url":"https://api.github.com/repos/antilax-3/authelia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antilax-3/authelia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antilax-3/authelia/teams","hooks_url":"https://api.github.com/repos/antilax-3/authelia/hooks","issue_events_url":"https://api.github.com/repos/antilax-3/authelia/issues/events{/number}","events_url":"https://api.github.com/repos/antilax-3/authelia/events","assignees_url":"https://api.github.com/repos/antilax-3/authelia/assignees{/user}","branches_url":"https://api.github.com/repos/antilax-3/authelia/branches{/branch}","tags_url":"https://api.github.com/repos/antilax-3/authelia/tags","blobs_url":"https://api.github.com/repos/antilax-3/authelia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antilax-3/authelia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antilax-3/authelia/git/refs{/sha}","trees_url":"https://api.github.com/repos/antilax-3/authelia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antilax-3/authelia/statuses/{sha}","languages_url":"https://api.github.com/repos/antilax-3/authelia/languages","stargazers_url":"https://api.github.com/repos/antilax-3/authelia/stargazers","contributors_url":"https://api.github.com/repos/antilax-3/authelia/contributors","subscribers_url":"https://api.github.com/repos/antilax-3/authelia/subscribers","subscription_url":"https://api.github.com/repos/antilax-3/authelia/subscription","commits_url":"https://api.github.com/repos/antilax-3/authelia/commits{/sha}","git_commits_url":"https://api.github.com/repos/antilax-3/authelia/git/commits{/sha}","comments_url":"https://api.github.com/repos/antilax-3/authelia/comments{/number}","issue_comment_url":"https://api.github.com/repos/antilax-3/authelia/issues/comments{/number}","contents_url":"https://api.github.com/repos/antilax-3/authelia/contents/{+path}","compare_url":"https://api.github.com/repos/antilax-3/authelia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antilax-3/authelia/merges","archive_url":"https://api.github.com/repos/antilax-3/authelia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antilax-3/authelia/downloads","issues_url":"https://api.github.com/repos/antilax-3/authelia/issues{/number}","pulls_url":"https://api.github.com/repos/antilax-3/authelia/pulls{/number}","milestones_url":"https://api.github.com/repos/antilax-3/authelia/milestones{/number}","notifications_url":"https://api.github.com/repos/antilax-3/authelia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antilax-3/authelia/labels{/name}","releases_url":"https://api.github.com/repos/antilax-3/authelia/releases{/id}","deployments_url":"https://api.github.com/repos/antilax-3/authelia/deployments","created_at":"2018-08-26T13:28:59Z","updated_at":"2018-08-26T13:29:01Z","pushed_at":"2018-09-12T10:50:01Z","git_url":"git://github.com/antilax-3/authelia.git","ssh_url":"git@github.com:antilax-3/authelia.git","clone_url":"https://github.com/antilax-3/authelia.git","svn_url":"https://github.com/antilax-3/authelia","homepage":"","size":2853,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clems4ever:master","ref":"master","sha":"e7ad831d4d162637bc0419d120db02defbdc02f1","user":{"login":"clems4ever","id":3193257,"node_id":"MDQ6VXNlcjMxOTMyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3193257?v=4","gravatar_id":"","url":"https://api.github.com/users/clems4ever","html_url":"https://github.com/clems4ever","followers_url":"https://api.github.com/users/clems4ever/followers","following_url":"https://api.github.com/users/clems4ever/following{/other_user}","gists_url":"https://api.github.com/users/clems4ever/gists{/gist_id}","starred_url":"https://api.github.com/users/clems4ever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clems4ever/subscriptions","organizations_url":"https://api.github.com/users/clems4ever/orgs","repos_url":"https://api.github.com/users/clems4ever/repos","events_url":"https://api.github.com/users/clems4ever/events{/privacy}","received_events_url":"https://api.github.com/users/clems4ever/received_events","type":"User","site_admin":false},"repo":{"id":75785240,"node_id":"MDEwOlJlcG9zaXRvcnk3NTc4NTI0MA==","name":"authelia","full_name":"clems4ever/authelia","owner":{"login":"clems4ever","id":3193257,"node_id":"MDQ6VXNlcjMxOTMyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3193257?v=4","gravatar_id":"","url":"https://api.github.com/users/clems4ever","html_url":"https://github.com/clems4ever","followers_url":"https://api.github.com/users/clems4ever/followers","following_url":"https://api.github.com/users/clems4ever/following{/other_user}","gists_url":"https://api.github.com/users/clems4ever/gists{/gist_id}","starred_url":"https://api.github.com/users/clems4ever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clems4ever/subscriptions","organizations_url":"https://api.github.com/users/clems4ever/orgs","repos_url":"https://api.github.com/users/clems4ever/repos","events_url":"https://api.github.com/users/clems4ever/events{/privacy}","received_events_url":"https://api.github.com/users/clems4ever/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clems4ever/authelia","description":"Authentication server providing SSO, 2FA and ACLs for web apps.","fork":false,"url":"https://api.github.com/repos/clems4ever/authelia","forks_url":"https://api.github.com/repos/clems4ever/authelia/forks","keys_url":"https://api.github.com/repos/clems4ever/authelia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clems4ever/authelia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clems4ever/authelia/teams","hooks_url":"https://api.github.com/repos/clems4ever/authelia/hooks","issue_events_url":"https://api.github.com/repos/clems4ever/authelia/issues/events{/number}","events_url":"https://api.github.com/repos/clems4ever/authelia/events","assignees_url":"https://api.github.com/repos/clems4ever/authelia/assignees{/user}","branches_url":"https://api.github.com/repos/clems4ever/authelia/branches{/branch}","tags_url":"https://api.github.com/repos/clems4ever/authelia/tags","blobs_url":"https://api.github.com/repos/clems4ever/authelia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clems4ever/authelia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clems4ever/authelia/git/refs{/sha}","trees_url":"https://api.github.com/repos/clems4ever/authelia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clems4ever/authelia/statuses/{sha}","languages_url":"https://api.github.com/repos/clems4ever/authelia/languages","stargazers_url":"https://api.github.com/repos/clems4ever/authelia/stargazers","contributors_url":"https://api.github.com/repos/clems4ever/authelia/contributors","subscribers_url":"https://api.github.com/repos/clems4ever/authelia/subscribers","subscription_url":"https://api.github.com/repos/clems4ever/authelia/subscription","commits_url":"https://api.github.com/repos/clems4ever/authelia/commits{/sha}","git_commits_url":"https://api.github.com/repos/clems4ever/authelia/git/commits{/sha}","comments_url":"https://api.github.com/repos/clems4ever/authelia/comments{/number}","issue_comment_url":"https://api.github.com/repos/clems4ever/authelia/issues/comments{/number}","contents_url":"https://api.github.com/repos/clems4ever/authelia/contents/{+path}","compare_url":"https://api.github.com/repos/clems4ever/authelia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clems4ever/authelia/merges","archive_url":"https://api.github.com/repos/clems4ever/authelia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clems4ever/authelia/downloads","issues_url":"https://api.github.com/repos/clems4ever/authelia/issues{/number}","pulls_url":"https://api.github.com/repos/clems4ever/authelia/pulls{/number}","milestones_url":"https://api.github.com/repos/clems4ever/authelia/milestones{/number}","notifications_url":"https://api.github.com/repos/clems4ever/authelia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clems4ever/authelia/labels{/name}","releases_url":"https://api.github.com/repos/clems4ever/authelia/releases{/id}","deployments_url":"https://api.github.com/repos/clems4ever/authelia/deployments","created_at":"2016-12-07T00:56:57Z","updated_at":"2018-09-11T02:38:20Z","pushed_at":"2018-09-12T10:50:03Z","git_url":"git://github.com/clems4ever/authelia.git","ssh_url":"git@github.com:clems4ever/authelia.git","clone_url":"https://github.com/clems4ever/authelia.git","svn_url":"https://github.com/clems4ever/authelia","homepage":"https://www.authelia.com","size":2874,"stargazers_count":235,"watchers_count":235,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":37,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clems4ever/authelia/pulls/273"},"html":{"href":"https://github.com/clems4ever/authelia/pull/273"},"issue":{"href":"https://api.github.com/repos/clems4ever/authelia/issues/273"},"comments":{"href":"https://api.github.com/repos/clems4ever/authelia/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/clems4ever/authelia/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/clems4ever/authelia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clems4ever/authelia/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/clems4ever/authelia/statuses/1a3fc3894f260038f58f0871c5ce80668a23a9f0"}},"author_association":"NONE"}}
{"actor":{"display_login":"nightah"}}