{"action":"created","comment":{"url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/comments/224015430","pull_request_review_id":163279063,"id":224015430,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDAxNTQzMA==","diff_hunk":"@@ -35,6 +36,12 @@ interface ILinelistState {\n @inject('sidebarStore', 'routeStore', 'searchStore')\n @observer\n class Sidebar extends React.Component<ISidebarProps, ILinelistState> {\n+\n+    private renderRoutesView = () => {\n+        const search = this.props.history.location.search;\n+        return search === '' ?  <Redirect to='/' /> : <RoutesView />;\n+    }","path":"src/components/sidebar/Sidebar.tsx","position":24,"original_position":24,"commit_id":"bd455ef668995c1e35a377cf541f0702fa2c757b","original_commit_id":"bd455ef668995c1e35a377cf541f0702fa2c757b","user":{"login":"kronken","id":5954449,"node_id":"MDQ6VXNlcjU5NTQ0NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5954449?v=4","gravatar_id":"","url":"https://api.github.com/users/kronken","html_url":"https://github.com/kronken","followers_url":"https://api.github.com/users/kronken/followers","following_url":"https://api.github.com/users/kronken/following{/other_user}","gists_url":"https://api.github.com/users/kronken/gists{/gist_id}","starred_url":"https://api.github.com/users/kronken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronken/subscriptions","organizations_url":"https://api.github.com/users/kronken/orgs","repos_url":"https://api.github.com/users/kronken/repos","events_url":"https://api.github.com/users/kronken/events{/privacy}","received_events_url":"https://api.github.com/users/kronken/received_events","type":"User","site_admin":false},"body":"The history things could be skipped if we utilize the navigator for this:\r\n```\r\nprivate renderRoutesView = () => {\r\n    return !navigator.getQueryParam(QueryParams.routes)\r\n        ? <Redirect to='/' /> : <RoutesView />;\r\n}\r\n```","created_at":"2018-10-10T10:08:17Z","updated_at":"2018-10-10T10:09:17Z","html_url":"https://github.com/HSLdevcom/jore-map-ui/pull/292#discussion_r224015430","pull_request_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/292","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/comments/224015430"},"html":{"href":"https://github.com/HSLdevcom/jore-map-ui/pull/292#discussion_r224015430"},"pull_request":{"href":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/292"}}},"pull_request":{"url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/292","id":221456681,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNDU2Njgx","html_url":"https://github.com/HSLdevcom/jore-map-ui/pull/292","diff_url":"https://github.com/HSLdevcom/jore-map-ui/pull/292.diff","patch_url":"https://github.com/HSLdevcom/jore-map-ui/pull/292.patch","issue_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/issues/292","number":292,"state":"open","locked":false,"title":"routes page without query params redirects to root","user":{"login":"Divinare","id":1419296,"node_id":"MDQ6VXNlcjE0MTkyOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1419296?v=4","gravatar_id":"","url":"https://api.github.com/users/Divinare","html_url":"https://github.com/Divinare","followers_url":"https://api.github.com/users/Divinare/followers","following_url":"https://api.github.com/users/Divinare/following{/other_user}","gists_url":"https://api.github.com/users/Divinare/gists{/gist_id}","starred_url":"https://api.github.com/users/Divinare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Divinare/subscriptions","organizations_url":"https://api.github.com/users/Divinare/orgs","repos_url":"https://api.github.com/users/Divinare/repos","events_url":"https://api.github.com/users/Divinare/events{/privacy}","received_events_url":"https://api.github.com/users/Divinare/received_events","type":"User","site_admin":false},"body":"Resolves: #210 ","created_at":"2018-10-09T14:15:17Z","updated_at":"2018-10-10T10:09:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80b7f1b8e677f5a6259c7b89c179171af2471bac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/292/commits","review_comments_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/292/comments","review_comment_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/issues/292/comments","statuses_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/statuses/bd455ef668995c1e35a377cf541f0702fa2c757b","head":{"label":"HSLdevcom:210-route-index-page","ref":"210-route-index-page","sha":"bd455ef668995c1e35a377cf541f0702fa2c757b","user":{"login":"HSLdevcom","id":2813507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTM1MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"repo":{"id":138861312,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4NjEzMTI=","name":"jore-map-ui","full_name":"HSLdevcom/jore-map-ui","private":false,"owner":{"login":"HSLdevcom","id":2813507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTM1MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HSLdevcom/jore-map-ui","description":null,"fork":false,"url":"https://api.github.com/repos/HSLdevcom/jore-map-ui","forks_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/forks","keys_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/teams","hooks_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/hooks","issue_events_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/issues/events{/number}","events_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/events","assignees_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/assignees{/user}","branches_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/branches{/branch}","tags_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/tags","blobs_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/languages","stargazers_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/stargazers","contributors_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/contributors","subscribers_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/subscribers","subscription_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/subscription","commits_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/contents/{+path}","compare_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/merges","archive_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/downloads","issues_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/issues{/number}","pulls_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/labels{/name}","releases_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/releases{/id}","deployments_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/deployments","created_at":"2018-06-27T09:39:42Z","updated_at":"2018-10-10T08:49:02Z","pushed_at":"2018-10-10T09:52:03Z","git_url":"git://github.com/HSLdevcom/jore-map-ui.git","ssh_url":"git@github.com:HSLdevcom/jore-map-ui.git","clone_url":"https://github.com/HSLdevcom/jore-map-ui.git","svn_url":"https://github.com/HSLdevcom/jore-map-ui","homepage":null,"size":1082,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":147,"license":null,"forks":1,"open_issues":147,"watchers":5,"default_branch":"master"}},"base":{"label":"HSLdevcom:master","ref":"master","sha":"5bff66019fd90eb157200187324c5e79f50b67ce","user":{"login":"HSLdevcom","id":2813507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTM1MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"repo":{"id":138861312,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4NjEzMTI=","name":"jore-map-ui","full_name":"HSLdevcom/jore-map-ui","private":false,"owner":{"login":"HSLdevcom","id":2813507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTM1MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HSLdevcom/jore-map-ui","description":null,"fork":false,"url":"https://api.github.com/repos/HSLdevcom/jore-map-ui","forks_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/forks","keys_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/teams","hooks_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/hooks","issue_events_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/issues/events{/number}","events_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/events","assignees_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/assignees{/user}","branches_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/branches{/branch}","tags_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/tags","blobs_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/languages","stargazers_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/stargazers","contributors_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/contributors","subscribers_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/subscribers","subscription_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/subscription","commits_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/contents/{+path}","compare_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/merges","archive_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/downloads","issues_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/issues{/number}","pulls_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/labels{/name}","releases_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/releases{/id}","deployments_url":"https://api.github.com/repos/HSLdevcom/jore-map-ui/deployments","created_at":"2018-06-27T09:39:42Z","updated_at":"2018-10-10T08:49:02Z","pushed_at":"2018-10-10T09:52:03Z","git_url":"git://github.com/HSLdevcom/jore-map-ui.git","ssh_url":"git@github.com:HSLdevcom/jore-map-ui.git","clone_url":"https://github.com/HSLdevcom/jore-map-ui.git","svn_url":"https://github.com/HSLdevcom/jore-map-ui","homepage":null,"size":1082,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":147,"license":null,"forks":1,"open_issues":147,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/292"},"html":{"href":"https://github.com/HSLdevcom/jore-map-ui/pull/292"},"issue":{"href":"https://api.github.com/repos/HSLdevcom/jore-map-ui/issues/292"},"comments":{"href":"https://api.github.com/repos/HSLdevcom/jore-map-ui/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HSLdevcom/jore-map-ui/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/HSLdevcom/jore-map-ui/statuses/bd455ef668995c1e35a377cf541f0702fa2c757b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kronken"}}