{"action":"opened","number":5947,"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/5947","id":194086912,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDg2OTEy","html_url":"https://github.com/pantsbuild/pants/pull/5947","diff_url":"https://github.com/pantsbuild/pants/pull/5947.diff","patch_url":"https://github.com/pantsbuild/pants/pull/5947.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/5947","number":5947,"state":"open","locked":false,"title":"Add extra_compile_args option to jvm targets so you can add additional compile arg per java library target","user":{"login":"cheister","id":399602,"node_id":"MDQ6VXNlcjM5OTYwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/399602?v=4","gravatar_id":"","url":"https://api.github.com/users/cheister","html_url":"https://github.com/cheister","followers_url":"https://api.github.com/users/cheister/followers","following_url":"https://api.github.com/users/cheister/following{/other_user}","gists_url":"https://api.github.com/users/cheister/gists{/gist_id}","starred_url":"https://api.github.com/users/cheister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheister/subscriptions","organizations_url":"https://api.github.com/users/cheister/orgs","repos_url":"https://api.github.com/users/cheister/repos","events_url":"https://api.github.com/users/cheister/events{/privacy}","received_events_url":"https://api.github.com/users/cheister/received_events","type":"User","site_admin":false},"body":"### Problem\r\n\r\nCurrently you can only specify compile args in pants.ini which means all java targets get the same list of javac options.  In java 9 and above they have added options to add modules for compilation such as `--add-modules module , module` from https://docs.oracle.com/javase/9/tools/javac.htm#JSWOR627\r\nIn general most developers probably won't want add this module for every java library in their system\r\n\r\nYou could also use this to add additional compiler warnings to a jvm target. \r\n\r\n### Solution\r\n\r\nAdd and extra_compile_args option to jvm targets that allow you specify extra javac options for that jvm target.\r\n\r\n### Result\r\n\r\nYou can now add per jvm library compile arguments. ","created_at":"2018-06-11T19:59:22Z","updated_at":"2018-06-11T19:59:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5947/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/5947/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/5947/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/33498e2af3153377d195c955d475b18ac33e4c15","head":{"label":"cheister:extra-compile-args","ref":"extra-compile-args","sha":"33498e2af3153377d195c955d475b18ac33e4c15","user":{"login":"cheister","id":399602,"node_id":"MDQ6VXNlcjM5OTYwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/399602?v=4","gravatar_id":"","url":"https://api.github.com/users/cheister","html_url":"https://github.com/cheister","followers_url":"https://api.github.com/users/cheister/followers","following_url":"https://api.github.com/users/cheister/following{/other_user}","gists_url":"https://api.github.com/users/cheister/gists{/gist_id}","starred_url":"https://api.github.com/users/cheister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheister/subscriptions","organizations_url":"https://api.github.com/users/cheister/orgs","repos_url":"https://api.github.com/users/cheister/repos","events_url":"https://api.github.com/users/cheister/events{/privacy}","received_events_url":"https://api.github.com/users/cheister/received_events","type":"User","site_admin":false},"repo":{"id":52313662,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMxMzY2Mg==","name":"pants","full_name":"cheister/pants","owner":{"login":"cheister","id":399602,"node_id":"MDQ6VXNlcjM5OTYwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/399602?v=4","gravatar_id":"","url":"https://api.github.com/users/cheister","html_url":"https://github.com/cheister","followers_url":"https://api.github.com/users/cheister/followers","following_url":"https://api.github.com/users/cheister/following{/other_user}","gists_url":"https://api.github.com/users/cheister/gists{/gist_id}","starred_url":"https://api.github.com/users/cheister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheister/subscriptions","organizations_url":"https://api.github.com/users/cheister/orgs","repos_url":"https://api.github.com/users/cheister/repos","events_url":"https://api.github.com/users/cheister/events{/privacy}","received_events_url":"https://api.github.com/users/cheister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cheister/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/cheister/pants","forks_url":"https://api.github.com/repos/cheister/pants/forks","keys_url":"https://api.github.com/repos/cheister/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cheister/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cheister/pants/teams","hooks_url":"https://api.github.com/repos/cheister/pants/hooks","issue_events_url":"https://api.github.com/repos/cheister/pants/issues/events{/number}","events_url":"https://api.github.com/repos/cheister/pants/events","assignees_url":"https://api.github.com/repos/cheister/pants/assignees{/user}","branches_url":"https://api.github.com/repos/cheister/pants/branches{/branch}","tags_url":"https://api.github.com/repos/cheister/pants/tags","blobs_url":"https://api.github.com/repos/cheister/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cheister/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cheister/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/cheister/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cheister/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/cheister/pants/languages","stargazers_url":"https://api.github.com/repos/cheister/pants/stargazers","contributors_url":"https://api.github.com/repos/cheister/pants/contributors","subscribers_url":"https://api.github.com/repos/cheister/pants/subscribers","subscription_url":"https://api.github.com/repos/cheister/pants/subscription","commits_url":"https://api.github.com/repos/cheister/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/cheister/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/cheister/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/cheister/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/cheister/pants/contents/{+path}","compare_url":"https://api.github.com/repos/cheister/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cheister/pants/merges","archive_url":"https://api.github.com/repos/cheister/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cheister/pants/downloads","issues_url":"https://api.github.com/repos/cheister/pants/issues{/number}","pulls_url":"https://api.github.com/repos/cheister/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/cheister/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/cheister/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cheister/pants/labels{/name}","releases_url":"https://api.github.com/repos/cheister/pants/releases{/id}","deployments_url":"https://api.github.com/repos/cheister/pants/deployments","created_at":"2016-02-22T23:22:27Z","updated_at":"2016-02-22T23:22:31Z","pushed_at":"2018-06-11T19:54:29Z","git_url":"git://github.com/cheister/pants.git","ssh_url":"git@github.com:cheister/pants.git","clone_url":"https://github.com/cheister/pants.git","svn_url":"https://github.com/cheister/pants","homepage":"http://pantsbuild.github.io/","size":83972,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"79d358a10723d9a1c9cef7aed16ccc5a693f3f6c","user":{"login":"pantsbuild","id":3065172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjUxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"node_id":"MDEwOlJlcG9zaXRvcnk3MjA5MDc1","name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjUxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"The Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","deployments_url":"https://api.github.com/repos/pantsbuild/pants/deployments","created_at":"2012-12-17T17:39:04Z","updated_at":"2018-06-11T18:33:25Z","pushed_at":"2018-06-11T18:38:34Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.org/","size":84431,"stargazers_count":967,"watchers_count":967,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":277,"mirror_url":null,"archived":false,"open_issues_count":628,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":277,"open_issues":628,"watchers":967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5947"},"html":{"href":"https://github.com/pantsbuild/pants/pull/5947"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/5947"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/5947/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5947/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/5947/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/33498e2af3153377d195c955d475b18ac33e4c15"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":46,"deletions":3,"changed_files":5}}
{"actor":{"display_login":"cheister"}}