{"action":"created","comment":{"url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/comments/232748879","pull_request_review_id":174008479,"id":232748879,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjc0ODg3OQ==","diff_hunk":"@@ -20,21 +21,19 @@ class DeployServerlessApplicationAction : AnAction(\n \n         val project = e?.getRequiredData(PlatformDataKeys.PROJECT)\n \n-        Messages.showWarningDialog(\n-                project,\n-                \"SAM Deployment is coming soon\",\n-                \"Not Implemented\"\n-        )\n+        val samTemplateFile = e?.getData(PlatformDataKeys.VIRTUAL_FILE_ARRAY)!![0]","path":"jetbrains-core/src/software/aws/toolkits/jetbrains/services/lambda/actions/DeployServerlessApplicationAction.kt","position":20,"original_position":20,"commit_id":"cad9b9f6243215eab3c05c0e74e23749523b7dce","original_commit_id":"cad9b9f6243215eab3c05c0e74e23749523b7dce","user":{"login":"abrooksv","id":8992246,"node_id":"MDQ6VXNlcjg5OTIyNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8992246?v=4","gravatar_id":"","url":"https://api.github.com/users/abrooksv","html_url":"https://github.com/abrooksv","followers_url":"https://api.github.com/users/abrooksv/followers","following_url":"https://api.github.com/users/abrooksv/following{/other_user}","gists_url":"https://api.github.com/users/abrooksv/gists{/gist_id}","starred_url":"https://api.github.com/users/abrooksv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrooksv/subscriptions","organizations_url":"https://api.github.com/users/abrooksv/orgs","repos_url":"https://api.github.com/users/abrooksv/repos","events_url":"https://api.github.com/users/abrooksv/events{/privacy}","received_events_url":"https://api.github.com/users/abrooksv/received_events","type":"User","site_admin":false},"body":"Dont use !! in production code","created_at":"2018-11-12T17:32:29Z","updated_at":"2018-11-12T17:38:33Z","html_url":"https://github.com/aws/aws-toolkit-jetbrains/pull/422#discussion_r232748879","pull_request_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/422","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/comments/232748879"},"html":{"href":"https://github.com/aws/aws-toolkit-jetbrains/pull/422#discussion_r232748879"},"pull_request":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/422"}}},"pull_request":{"url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/422","id":229861421,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODYxNDIx","html_url":"https://github.com/aws/aws-toolkit-jetbrains/pull/422","diff_url":"https://github.com/aws/aws-toolkit-jetbrains/pull/422.diff","patch_url":"https://github.com/aws/aws-toolkit-jetbrains/pull/422.patch","issue_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/422","number":422,"state":"open","locked":false,"title":"Deploy SAM Dialog","user":{"login":"awschristou","id":39839589,"node_id":"MDQ6VXNlcjM5ODM5NTg5","avatar_url":"https://avatars0.githubusercontent.com/u/39839589?v=4","gravatar_id":"","url":"https://api.github.com/users/awschristou","html_url":"https://github.com/awschristou","followers_url":"https://api.github.com/users/awschristou/followers","following_url":"https://api.github.com/users/awschristou/following{/other_user}","gists_url":"https://api.github.com/users/awschristou/gists{/gist_id}","starred_url":"https://api.github.com/users/awschristou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awschristou/subscriptions","organizations_url":"https://api.github.com/users/awschristou/orgs","repos_url":"https://api.github.com/users/awschristou/repos","events_url":"https://api.github.com/users/awschristou/events{/privacy}","received_events_url":"https://api.github.com/users/awschristou/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThis is the UI that will be used to deploy a Sam Application to AWS. The actual deploy is not implemented, and handled in another task\r\n\r\nAdditionally\r\n* CFN template gains Parameters definition\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n## Related Issue(s)\r\n<!--- What is the related issue you are trying to fix? -->\r\n#391 \r\n\r\n## Testing\r\n<!--- Please describe in detail how you tested your changes -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n* Added tests\r\n* Running the Toolkit, right clicking on a template.yaml file, and entering the dialog through 'Deploy Serverless Application'\r\n  * expect to see the template parameters in the UI\r\n  * expect the Region to influence the Stacks and S3 buckets available to select\r\n  * expect to get validation prompts when any of the input is missing or invalid\r\n\r\n## Screenshots (if appropriate)\r\n![image](https://user-images.githubusercontent.com/39839589/48295909-76189900-e445-11e8-96c6-371d92d8475b.png)\r\n\r\n## Checklist\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the **README** document\r\n- [x] I have read the **CONTRIBUTING** document\r\n- [ ] Local run of `gradlew check` succeeds\r\n- [x] My code follows the code style of this project\r\n- [x] I have added tests to cover my changes\r\n- [x] All new and existing tests passed\r\n- [ ] A short description of the change has been added to the **CHANGELOG**\r\n\r\n## License\r\nI confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-11-10T01:40:07Z","updated_at":"2018-11-12T17:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d51ef78d7b837ba1430784247595ddda3c7ee0e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/422/commits","review_comments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/422/comments","review_comment_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/422/comments","statuses_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/statuses/cad9b9f6243215eab3c05c0e74e23749523b7dce","head":{"label":"aws:awschristou/deploy-ui","ref":"awschristou/deploy-ui","sha":"cad9b9f6243215eab3c05c0e74e23749523b7dce","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":91485909,"node_id":"MDEwOlJlcG9zaXRvcnk5MTQ4NTkwOQ==","name":"aws-toolkit-jetbrains","full_name":"aws/aws-toolkit-jetbrains","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/aws-toolkit-jetbrains","description":"AWS Toolkit for JetBrains - a plugin for interacting with AWS from JetBrains IDEs","fork":false,"url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains","forks_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/forks","keys_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/teams","hooks_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/events","assignees_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/tags","blobs_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/languages","stargazers_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/subscription","commits_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/merges","archive_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/downloads","issues_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/deployments","created_at":"2017-05-16T17:28:34Z","updated_at":"2018-11-11T12:48:09Z","pushed_at":"2018-11-11T06:42:39Z","git_url":"git://github.com/aws/aws-toolkit-jetbrains.git","ssh_url":"git@github.com:aws/aws-toolkit-jetbrains.git","clone_url":"https://github.com/aws/aws-toolkit-jetbrains.git","svn_url":"https://github.com/aws/aws-toolkit-jetbrains","homepage":"","size":1217,"stargazers_count":58,"watchers_count":58,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":62,"watchers":58,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"9b82c089ce38cbaf080dbb410fa8033dbc5f41b9","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":91485909,"node_id":"MDEwOlJlcG9zaXRvcnk5MTQ4NTkwOQ==","name":"aws-toolkit-jetbrains","full_name":"aws/aws-toolkit-jetbrains","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/aws-toolkit-jetbrains","description":"AWS Toolkit for JetBrains - a plugin for interacting with AWS from JetBrains IDEs","fork":false,"url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains","forks_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/forks","keys_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/teams","hooks_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/events","assignees_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/tags","blobs_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/languages","stargazers_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/subscription","commits_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/merges","archive_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/downloads","issues_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/deployments","created_at":"2017-05-16T17:28:34Z","updated_at":"2018-11-11T12:48:09Z","pushed_at":"2018-11-11T06:42:39Z","git_url":"git://github.com/aws/aws-toolkit-jetbrains.git","ssh_url":"git@github.com:aws/aws-toolkit-jetbrains.git","clone_url":"https://github.com/aws/aws-toolkit-jetbrains.git","svn_url":"https://github.com/aws/aws-toolkit-jetbrains","homepage":"","size":1217,"stargazers_count":58,"watchers_count":58,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":62,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/422"},"html":{"href":"https://github.com/aws/aws-toolkit-jetbrains/pull/422"},"issue":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/422"},"comments":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-toolkit-jetbrains/statuses/cad9b9f6243215eab3c05c0e74e23749523b7dce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"abrooksv"}}