{"action":"created","comment":{"url":"https://api.github.com/repos/google/shaka-player/pulls/comments/171382530","pull_request_review_id":100225531,"id":171382530,"diff_hunk":"@@ -1718,6 +1720,8 @@ shaka.media.StreamingEngine.prototype.parseEMSG_ = function(\n       messageData: messageData\n     };\n \n+    this.playerInterface_.onTimelineRegionAdded(emsg);","path":"lib/media/streaming_engine.js","position":13,"original_position":13,"commit_id":"6e8a6c5c76169c8fef3ef45cde4126aed89e11c1","original_commit_id":"08252e03377e0d77b90aae9e9432f514a36a739e","user":{"login":"joeyparrish","id":6843156,"avatar_url":"https://avatars0.githubusercontent.com/u/6843156?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyparrish","html_url":"https://github.com/joeyparrish","followers_url":"https://api.github.com/users/joeyparrish/followers","following_url":"https://api.github.com/users/joeyparrish/following{/other_user}","gists_url":"https://api.github.com/users/joeyparrish/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyparrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyparrish/subscriptions","organizations_url":"https://api.github.com/users/joeyparrish/orgs","repos_url":"https://api.github.com/users/joeyparrish/repos","events_url":"https://api.github.com/users/joeyparrish/events{/privacy}","received_events_url":"https://api.github.com/users/joeyparrish/received_events","type":"User","site_admin":false},"body":"We have an 'emsg' event already, which is dispatched currently by StreamingEngine through playerInterface_.onEvent.  Perhaps you should move the responsibility for that event to somewhere else.  Timeline events are dispatched from PlayheadObserver today.","created_at":"2018-02-28T20:56:22Z","updated_at":"2018-02-28T20:56:22Z","html_url":"https://github.com/google/shaka-player/pull/1279#discussion_r171382530","pull_request_url":"https://api.github.com/repos/google/shaka-player/pulls/1279","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/shaka-player/pulls/comments/171382530"},"html":{"href":"https://github.com/google/shaka-player/pull/1279#discussion_r171382530"},"pull_request":{"href":"https://api.github.com/repos/google/shaka-player/pulls/1279"}},"in_reply_to_id":170697771},"pull_request":{"url":"https://api.github.com/repos/google/shaka-player/pulls/1279","id":167479490,"html_url":"https://github.com/google/shaka-player/pull/1279","diff_url":"https://github.com/google/shaka-player/pull/1279.diff","patch_url":"https://github.com/google/shaka-player/pull/1279.patch","issue_url":"https://api.github.com/repos/google/shaka-player/issues/1279","number":1279,"state":"open","locked":false,"title":"Add emsg data to timeline regions.","user":{"login":"chrisfillmore","id":7190265,"avatar_url":"https://avatars1.githubusercontent.com/u/7190265?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisfillmore","html_url":"https://github.com/chrisfillmore","followers_url":"https://api.github.com/users/chrisfillmore/followers","following_url":"https://api.github.com/users/chrisfillmore/following{/other_user}","gists_url":"https://api.github.com/users/chrisfillmore/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisfillmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisfillmore/subscriptions","organizations_url":"https://api.github.com/users/chrisfillmore/orgs","repos_url":"https://api.github.com/users/chrisfillmore/repos","events_url":"https://api.github.com/users/chrisfillmore/events{/privacy}","received_events_url":"https://api.github.com/users/chrisfillmore/received_events","type":"User","site_admin":false},"body":"Closes #1268","created_at":"2018-02-06T17:28:13Z","updated_at":"2018-02-28T20:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fb5fe79ab7b96a695f2cd6fe38cc3492032eff6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":573938103,"url":"https://api.github.com/repos/google/shaka-player/labels/needs%20triage","name":"needs triage","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/shaka-player/pulls/1279/commits","review_comments_url":"https://api.github.com/repos/google/shaka-player/pulls/1279/comments","review_comment_url":"https://api.github.com/repos/google/shaka-player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/shaka-player/issues/1279/comments","statuses_url":"https://api.github.com/repos/google/shaka-player/statuses/6e8a6c5c76169c8fef3ef45cde4126aed89e11c1","head":{"label":"chrisfillmore:feature/pollForEmsgRegions_1268","ref":"feature/pollForEmsgRegions_1268","sha":"6e8a6c5c76169c8fef3ef45cde4126aed89e11c1","user":{"login":"chrisfillmore","id":7190265,"avatar_url":"https://avatars1.githubusercontent.com/u/7190265?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisfillmore","html_url":"https://github.com/chrisfillmore","followers_url":"https://api.github.com/users/chrisfillmore/followers","following_url":"https://api.github.com/users/chrisfillmore/following{/other_user}","gists_url":"https://api.github.com/users/chrisfillmore/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisfillmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisfillmore/subscriptions","organizations_url":"https://api.github.com/users/chrisfillmore/orgs","repos_url":"https://api.github.com/users/chrisfillmore/repos","events_url":"https://api.github.com/users/chrisfillmore/events{/privacy}","received_events_url":"https://api.github.com/users/chrisfillmore/received_events","type":"User","site_admin":false},"repo":{"id":75112392,"name":"shaka-player","full_name":"chrisfillmore/shaka-player","owner":{"login":"chrisfillmore","id":7190265,"avatar_url":"https://avatars1.githubusercontent.com/u/7190265?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisfillmore","html_url":"https://github.com/chrisfillmore","followers_url":"https://api.github.com/users/chrisfillmore/followers","following_url":"https://api.github.com/users/chrisfillmore/following{/other_user}","gists_url":"https://api.github.com/users/chrisfillmore/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisfillmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisfillmore/subscriptions","organizations_url":"https://api.github.com/users/chrisfillmore/orgs","repos_url":"https://api.github.com/users/chrisfillmore/repos","events_url":"https://api.github.com/users/chrisfillmore/events{/privacy}","received_events_url":"https://api.github.com/users/chrisfillmore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisfillmore/shaka-player","description":"JavaScript player library / DASH client / MSE-EME player","fork":true,"url":"https://api.github.com/repos/chrisfillmore/shaka-player","forks_url":"https://api.github.com/repos/chrisfillmore/shaka-player/forks","keys_url":"https://api.github.com/repos/chrisfillmore/shaka-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisfillmore/shaka-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisfillmore/shaka-player/teams","hooks_url":"https://api.github.com/repos/chrisfillmore/shaka-player/hooks","issue_events_url":"https://api.github.com/repos/chrisfillmore/shaka-player/issues/events{/number}","events_url":"https://api.github.com/repos/chrisfillmore/shaka-player/events","assignees_url":"https://api.github.com/repos/chrisfillmore/shaka-player/assignees{/user}","branches_url":"https://api.github.com/repos/chrisfillmore/shaka-player/branches{/branch}","tags_url":"https://api.github.com/repos/chrisfillmore/shaka-player/tags","blobs_url":"https://api.github.com/repos/chrisfillmore/shaka-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisfillmore/shaka-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisfillmore/shaka-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisfillmore/shaka-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisfillmore/shaka-player/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisfillmore/shaka-player/languages","stargazers_url":"https://api.github.com/repos/chrisfillmore/shaka-player/stargazers","contributors_url":"https://api.github.com/repos/chrisfillmore/shaka-player/contributors","subscribers_url":"https://api.github.com/repos/chrisfillmore/shaka-player/subscribers","subscription_url":"https://api.github.com/repos/chrisfillmore/shaka-player/subscription","commits_url":"https://api.github.com/repos/chrisfillmore/shaka-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisfillmore/shaka-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisfillmore/shaka-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisfillmore/shaka-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisfillmore/shaka-player/contents/{+path}","compare_url":"https://api.github.com/repos/chrisfillmore/shaka-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisfillmore/shaka-player/merges","archive_url":"https://api.github.com/repos/chrisfillmore/shaka-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisfillmore/shaka-player/downloads","issues_url":"https://api.github.com/repos/chrisfillmore/shaka-player/issues{/number}","pulls_url":"https://api.github.com/repos/chrisfillmore/shaka-player/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisfillmore/shaka-player/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisfillmore/shaka-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisfillmore/shaka-player/labels{/name}","releases_url":"https://api.github.com/repos/chrisfillmore/shaka-player/releases{/id}","deployments_url":"https://api.github.com/repos/chrisfillmore/shaka-player/deployments","created_at":"2016-11-29T19:00:38Z","updated_at":"2016-11-29T19:00:41Z","pushed_at":"2018-02-27T21:39:11Z","git_url":"git://github.com/chrisfillmore/shaka-player.git","ssh_url":"git@github.com:chrisfillmore/shaka-player.git","clone_url":"https://github.com/chrisfillmore/shaka-player.git","svn_url":"https://github.com/chrisfillmore/shaka-player","homepage":"","size":76667,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"61f73bbee9b51d3034f3109b7dec764bad6dc364","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":28246472,"name":"shaka-player","full_name":"google/shaka-player","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/shaka-player","description":"JavaScript player library / DASH client / MSE-EME player","fork":false,"url":"https://api.github.com/repos/google/shaka-player","forks_url":"https://api.github.com/repos/google/shaka-player/forks","keys_url":"https://api.github.com/repos/google/shaka-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/shaka-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/shaka-player/teams","hooks_url":"https://api.github.com/repos/google/shaka-player/hooks","issue_events_url":"https://api.github.com/repos/google/shaka-player/issues/events{/number}","events_url":"https://api.github.com/repos/google/shaka-player/events","assignees_url":"https://api.github.com/repos/google/shaka-player/assignees{/user}","branches_url":"https://api.github.com/repos/google/shaka-player/branches{/branch}","tags_url":"https://api.github.com/repos/google/shaka-player/tags","blobs_url":"https://api.github.com/repos/google/shaka-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/shaka-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/shaka-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/shaka-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/shaka-player/statuses/{sha}","languages_url":"https://api.github.com/repos/google/shaka-player/languages","stargazers_url":"https://api.github.com/repos/google/shaka-player/stargazers","contributors_url":"https://api.github.com/repos/google/shaka-player/contributors","subscribers_url":"https://api.github.com/repos/google/shaka-player/subscribers","subscription_url":"https://api.github.com/repos/google/shaka-player/subscription","commits_url":"https://api.github.com/repos/google/shaka-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/shaka-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/shaka-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/shaka-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/shaka-player/contents/{+path}","compare_url":"https://api.github.com/repos/google/shaka-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/shaka-player/merges","archive_url":"https://api.github.com/repos/google/shaka-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/shaka-player/downloads","issues_url":"https://api.github.com/repos/google/shaka-player/issues{/number}","pulls_url":"https://api.github.com/repos/google/shaka-player/pulls{/number}","milestones_url":"https://api.github.com/repos/google/shaka-player/milestones{/number}","notifications_url":"https://api.github.com/repos/google/shaka-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/shaka-player/labels{/name}","releases_url":"https://api.github.com/repos/google/shaka-player/releases{/id}","deployments_url":"https://api.github.com/repos/google/shaka-player/deployments","created_at":"2014-12-19T21:12:18Z","updated_at":"2018-02-28T14:54:55Z","pushed_at":"2018-02-28T20:08:15Z","git_url":"git://github.com/google/shaka-player.git","ssh_url":"git@github.com:google/shaka-player.git","clone_url":"https://github.com/google/shaka-player.git","svn_url":"https://github.com/google/shaka-player","homepage":"","size":77300,"stargazers_count":1948,"watchers_count":1948,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":405,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":405,"open_issues":136,"watchers":1948,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/shaka-player/pulls/1279"},"html":{"href":"https://github.com/google/shaka-player/pull/1279"},"issue":{"href":"https://api.github.com/repos/google/shaka-player/issues/1279"},"comments":{"href":"https://api.github.com/repos/google/shaka-player/issues/1279/comments"},"review_comments":{"href":"https://api.github.com/repos/google/shaka-player/pulls/1279/comments"},"review_comment":{"href":"https://api.github.com/repos/google/shaka-player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/shaka-player/pulls/1279/commits"},"statuses":{"href":"https://api.github.com/repos/google/shaka-player/statuses/6e8a6c5c76169c8fef3ef45cde4126aed89e11c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joeyparrish"}}