{"action":"created","comment":{"url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/comments/172649196","pull_request_review_id":101702854,"id":172649196,"diff_hunk":"@@ -74,6 +74,21 @@ module.exports = [{\n       name: 'invalidName',\n       message: 'Invalid Name'\n     }]\n+  }, {\n+    name: 'Trigger',\n+    message: 'Internal Error on Proposal {0}',\n+    errors: [{\n+      name: 'invalidAddress',\n+      message: 'Invalid Address'\n+    },\n+    {\n+      name: 'invalidP2SHAddress',\n+      message: 'Invalid P2SHAddress'\n+    },\n+    {\n+      name: 'invalidPayment',","path":"lib/errors/spec.js","position":16,"original_position":16,"commit_id":"8203d379d31be10669b3dc173a0d735e435cf94b","original_commit_id":"8203d379d31be10669b3dc173a0d735e435cf94b","user":{"login":"nmarley","id":1735354,"avatar_url":"https://avatars1.githubusercontent.com/u/1735354?v=4","gravatar_id":"","url":"https://api.github.com/users/nmarley","html_url":"https://github.com/nmarley","followers_url":"https://api.github.com/users/nmarley/followers","following_url":"https://api.github.com/users/nmarley/following{/other_user}","gists_url":"https://api.github.com/users/nmarley/gists{/gist_id}","starred_url":"https://api.github.com/users/nmarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmarley/subscriptions","organizations_url":"https://api.github.com/users/nmarley/orgs","repos_url":"https://api.github.com/users/nmarley/repos","events_url":"https://api.github.com/users/nmarley/events{/privacy}","received_events_url":"https://api.github.com/users/nmarley/received_events","type":"User","site_admin":false},"body":"Same note on plural vs singular, since Trigger objects only have a list of amounts which is a pipe-delimited string.","created_at":"2018-03-06T20:28:16Z","updated_at":"2018-03-06T20:39:59Z","html_url":"https://github.com/dashevo/bitcore-lib-dash/pull/23#discussion_r172649196","pull_request_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/23","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/comments/172649196"},"html":{"href":"https://github.com/dashevo/bitcore-lib-dash/pull/23#discussion_r172649196"},"pull_request":{"href":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/23","id":172807392,"html_url":"https://github.com/dashevo/bitcore-lib-dash/pull/23","diff_url":"https://github.com/dashevo/bitcore-lib-dash/pull/23.diff","patch_url":"https://github.com/dashevo/bitcore-lib-dash/pull/23.patch","issue_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/issues/23","number":23,"state":"open","locked":false,"title":"Feat : Trigger Object","user":{"login":"Alex-Werner","id":5849920,"avatar_url":"https://avatars2.githubusercontent.com/u/5849920?v=4","gravatar_id":"","url":"https://api.github.com/users/Alex-Werner","html_url":"https://github.com/Alex-Werner","followers_url":"https://api.github.com/users/Alex-Werner/followers","following_url":"https://api.github.com/users/Alex-Werner/following{/other_user}","gists_url":"https://api.github.com/users/Alex-Werner/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex-Werner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex-Werner/subscriptions","organizations_url":"https://api.github.com/users/Alex-Werner/orgs","repos_url":"https://api.github.com/users/Alex-Werner/repos","events_url":"https://api.github.com/users/Alex-Werner/events{/privacy}","received_events_url":"https://api.github.com/users/Alex-Werner/received_events","type":"User","site_admin":false},"body":"This implement trigger governance object, until then we only had support for Proposal.","created_at":"2018-03-05T09:01:45Z","updated_at":"2018-03-06T20:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a7852288493d1ac8fc28fc919717c16afd991b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/23/commits","review_comments_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/23/comments","review_comment_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/issues/23/comments","statuses_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/statuses/8203d379d31be10669b3dc173a0d735e435cf94b","head":{"label":"dashevo:gobject/trigger","ref":"gobject/trigger","sha":"8203d379d31be10669b3dc173a0d735e435cf94b","user":{"login":"dashevo","id":27746179,"avatar_url":"https://avatars3.githubusercontent.com/u/27746179?v=4","gravatar_id":"","url":"https://api.github.com/users/dashevo","html_url":"https://github.com/dashevo","followers_url":"https://api.github.com/users/dashevo/followers","following_url":"https://api.github.com/users/dashevo/following{/other_user}","gists_url":"https://api.github.com/users/dashevo/gists{/gist_id}","starred_url":"https://api.github.com/users/dashevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashevo/subscriptions","organizations_url":"https://api.github.com/users/dashevo/orgs","repos_url":"https://api.github.com/users/dashevo/repos","events_url":"https://api.github.com/users/dashevo/events{/privacy}","received_events_url":"https://api.github.com/users/dashevo/received_events","type":"Organization","site_admin":false},"repo":{"id":90099422,"name":"bitcore-lib-dash","full_name":"dashevo/bitcore-lib-dash","owner":{"login":"dashevo","id":27746179,"avatar_url":"https://avatars3.githubusercontent.com/u/27746179?v=4","gravatar_id":"","url":"https://api.github.com/users/dashevo","html_url":"https://github.com/dashevo","followers_url":"https://api.github.com/users/dashevo/followers","following_url":"https://api.github.com/users/dashevo/following{/other_user}","gists_url":"https://api.github.com/users/dashevo/gists{/gist_id}","starred_url":"https://api.github.com/users/dashevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashevo/subscriptions","organizations_url":"https://api.github.com/users/dashevo/orgs","repos_url":"https://api.github.com/users/dashevo/repos","events_url":"https://api.github.com/users/dashevo/events{/privacy}","received_events_url":"https://api.github.com/users/dashevo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dashevo/bitcore-lib-dash","description":"A pure and powerful JavaScript Bitcoin library","fork":true,"url":"https://api.github.com/repos/dashevo/bitcore-lib-dash","forks_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/forks","keys_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/teams","hooks_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/hooks","issue_events_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/issues/events{/number}","events_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/events","assignees_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/assignees{/user}","branches_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/branches{/branch}","tags_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/tags","blobs_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/statuses/{sha}","languages_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/languages","stargazers_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/stargazers","contributors_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/contributors","subscribers_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/subscribers","subscription_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/subscription","commits_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/contents/{+path}","compare_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/merges","archive_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/downloads","issues_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/issues{/number}","pulls_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls{/number}","milestones_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/milestones{/number}","notifications_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/labels{/name}","releases_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/releases{/id}","deployments_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/deployments","created_at":"2017-05-03T02:28:25Z","updated_at":"2018-02-11T20:33:28Z","pushed_at":"2018-03-05T09:11:08Z","git_url":"git://github.com/dashevo/bitcore-lib-dash.git","ssh_url":"git@github.com:dashevo/bitcore-lib-dash.git","clone_url":"https://github.com/dashevo/bitcore-lib-dash.git","svn_url":"https://github.com/dashevo/bitcore-lib-dash","homepage":null,"size":11849,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":4,"watchers":8,"default_branch":"master"}},"base":{"label":"dashevo:develop","ref":"develop","sha":"f07ace8987af490ab07d145cc88ff2c68b14ae67","user":{"login":"dashevo","id":27746179,"avatar_url":"https://avatars3.githubusercontent.com/u/27746179?v=4","gravatar_id":"","url":"https://api.github.com/users/dashevo","html_url":"https://github.com/dashevo","followers_url":"https://api.github.com/users/dashevo/followers","following_url":"https://api.github.com/users/dashevo/following{/other_user}","gists_url":"https://api.github.com/users/dashevo/gists{/gist_id}","starred_url":"https://api.github.com/users/dashevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashevo/subscriptions","organizations_url":"https://api.github.com/users/dashevo/orgs","repos_url":"https://api.github.com/users/dashevo/repos","events_url":"https://api.github.com/users/dashevo/events{/privacy}","received_events_url":"https://api.github.com/users/dashevo/received_events","type":"Organization","site_admin":false},"repo":{"id":90099422,"name":"bitcore-lib-dash","full_name":"dashevo/bitcore-lib-dash","owner":{"login":"dashevo","id":27746179,"avatar_url":"https://avatars3.githubusercontent.com/u/27746179?v=4","gravatar_id":"","url":"https://api.github.com/users/dashevo","html_url":"https://github.com/dashevo","followers_url":"https://api.github.com/users/dashevo/followers","following_url":"https://api.github.com/users/dashevo/following{/other_user}","gists_url":"https://api.github.com/users/dashevo/gists{/gist_id}","starred_url":"https://api.github.com/users/dashevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashevo/subscriptions","organizations_url":"https://api.github.com/users/dashevo/orgs","repos_url":"https://api.github.com/users/dashevo/repos","events_url":"https://api.github.com/users/dashevo/events{/privacy}","received_events_url":"https://api.github.com/users/dashevo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dashevo/bitcore-lib-dash","description":"A pure and powerful JavaScript Bitcoin library","fork":true,"url":"https://api.github.com/repos/dashevo/bitcore-lib-dash","forks_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/forks","keys_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/teams","hooks_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/hooks","issue_events_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/issues/events{/number}","events_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/events","assignees_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/assignees{/user}","branches_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/branches{/branch}","tags_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/tags","blobs_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/statuses/{sha}","languages_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/languages","stargazers_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/stargazers","contributors_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/contributors","subscribers_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/subscribers","subscription_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/subscription","commits_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/contents/{+path}","compare_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/merges","archive_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/downloads","issues_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/issues{/number}","pulls_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls{/number}","milestones_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/milestones{/number}","notifications_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/labels{/name}","releases_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/releases{/id}","deployments_url":"https://api.github.com/repos/dashevo/bitcore-lib-dash/deployments","created_at":"2017-05-03T02:28:25Z","updated_at":"2018-02-11T20:33:28Z","pushed_at":"2018-03-05T09:11:08Z","git_url":"git://github.com/dashevo/bitcore-lib-dash.git","ssh_url":"git@github.com:dashevo/bitcore-lib-dash.git","clone_url":"https://github.com/dashevo/bitcore-lib-dash.git","svn_url":"https://github.com/dashevo/bitcore-lib-dash","homepage":null,"size":11849,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/23"},"html":{"href":"https://github.com/dashevo/bitcore-lib-dash/pull/23"},"issue":{"href":"https://api.github.com/repos/dashevo/bitcore-lib-dash/issues/23"},"comments":{"href":"https://api.github.com/repos/dashevo/bitcore-lib-dash/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dashevo/bitcore-lib-dash/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/dashevo/bitcore-lib-dash/statuses/8203d379d31be10669b3dc173a0d735e435cf94b"}},"author_association":"NONE"}}
{"actor":{"display_login":"nmarley"}}