{"action":"created","issue":{"url":"https://api.github.com/repos/jfrog/charts/issues/76","repository_url":"https://api.github.com/repos/jfrog/charts","labels_url":"https://api.github.com/repos/jfrog/charts/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/jfrog/charts/issues/76/comments","events_url":"https://api.github.com/repos/jfrog/charts/issues/76/events","html_url":"https://github.com/jfrog/charts/pull/76","id":369107247,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTI2ODY2","number":76,"title":"artifactory (non-ha) master-key support and ingress default backend toggle support","user":{"login":"zendril","id":460246,"node_id":"MDQ6VXNlcjQ2MDI0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/460246?v=4","gravatar_id":"","url":"https://api.github.com/users/zendril","html_url":"https://github.com/zendril","followers_url":"https://api.github.com/users/zendril/followers","following_url":"https://api.github.com/users/zendril/following{/other_user}","gists_url":"https://api.github.com/users/zendril/gists{/gist_id}","starred_url":"https://api.github.com/users/zendril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendril/subscriptions","organizations_url":"https://api.github.com/users/zendril/orgs","repos_url":"https://api.github.com/users/zendril/repos","events_url":"https://api.github.com/users/zendril/events{/privacy}","received_events_url":"https://api.github.com/users/zendril/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-11T12:54:09Z","updated_at":"2018-10-12T19:00:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jfrog/charts/pulls/76","html_url":"https://github.com/jfrog/charts/pull/76","diff_url":"https://github.com/jfrog/charts/pull/76.diff","patch_url":"https://github.com/jfrog/charts/pull/76.patch"},"body":"<!--\r\nThank you for contributing to jfrog/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a TravisCI\r\nwill run across your changes, do linting and then install the chart.\r\nPlease check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n@jainishshah17 , @eldada , @rimusz \r\n\r\n**What this PR does / why we need it**:\r\n\r\n- The non-ha version of artifactory does not start up without a master-key. This adds the ability to specify master key in the values. It defaults to the same key that is used for the artifactory-ha version: FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF\r\n- Also, on some clusters, the ability to run the default `backend` ingress is disabled. This PR adds the ability to toggle it on off via the values. It defaults to the current behavior of enabled.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\nDiscussed some of these challenges with David Xu (our support rep from JFrog). Please feel free to reach out thru him to setup a call with me to discuss if that helps."},"comment":{"url":"https://api.github.com/repos/jfrog/charts/issues/comments/429427449","html_url":"https://github.com/jfrog/charts/pull/76#issuecomment-429427449","issue_url":"https://api.github.com/repos/jfrog/charts/issues/76","id":429427449,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQyNzQ0OQ==","user":{"login":"jainishshah17","id":7799465,"node_id":"MDQ6VXNlcjc3OTk0NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7799465?v=4","gravatar_id":"","url":"https://api.github.com/users/jainishshah17","html_url":"https://github.com/jainishshah17","followers_url":"https://api.github.com/users/jainishshah17/followers","following_url":"https://api.github.com/users/jainishshah17/following{/other_user}","gists_url":"https://api.github.com/users/jainishshah17/gists{/gist_id}","starred_url":"https://api.github.com/users/jainishshah17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainishshah17/subscriptions","organizations_url":"https://api.github.com/users/jainishshah17/orgs","repos_url":"https://api.github.com/users/jainishshah17/repos","events_url":"https://api.github.com/users/jainishshah17/events{/privacy}","received_events_url":"https://api.github.com/users/jainishshah17/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T19:00:09Z","updated_at":"2018-10-12T19:00:09Z","author_association":"COLLABORATOR","body":"@zendril Awesome! Now it's passing linting. I will merge after a small manual test."}}
{"actor":{"display_login":"jainishshah17"}}