{"action":"created","comment":{"url":"https://api.github.com/repos/google/santa/pulls/comments/191899758","pull_request_review_id":124564707,"id":191899758,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MTg5OTc1OA==","diff_hunk":"@@ -29,9 +29,9 @@ bool SantaDecisionManager::init() {\n   decision_dataqueue_lock_ = lck_mtx_alloc_init(sdm_lock_grp_, sdm_lock_attr_);\n   log_dataqueue_lock_ = lck_mtx_alloc_init(sdm_lock_grp_, sdm_lock_attr_);\n \n-  root_decision_cache_ = new SantaCache<uint64_t>(5000, 2);\n-  non_root_decision_cache_ = new SantaCache<uint64_t>(500, 2);\n-  vnode_pid_map_ = new SantaCache<uint64_t>(2000, 5);\n+  root_decision_cache_ = new SantaCache<uint64_t, uint64_t>(5000, 2);\n+  non_root_decision_cache_ = new SantaCache<uint64_t, uint64_t>(500, 2);","path":"Source/santa-driver/SantaDecisionManager.cc","position":8,"original_position":8,"commit_id":"93fb1eda4ff00f8d59d46d14024e30325577c792","original_commit_id":"93fb1eda4ff00f8d59d46d14024e30325577c792","user":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"body":"I have a follow up PR that gets rid of the split caches","created_at":"2018-05-30T19:47:32Z","updated_at":"2018-05-30T19:47:32Z","html_url":"https://github.com/google/santa/pull/271#discussion_r191899758","pull_request_url":"https://api.github.com/repos/google/santa/pulls/271","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/santa/pulls/comments/191899758"},"html":{"href":"https://github.com/google/santa/pull/271#discussion_r191899758"},"pull_request":{"href":"https://api.github.com/repos/google/santa/pulls/271"}},"in_reply_to_id":191895331},"pull_request":{"url":"https://api.github.com/repos/google/santa/pulls/271","id":191553091,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTUzMDkx","html_url":"https://github.com/google/santa/pull/271","diff_url":"https://github.com/google/santa/pull/271.diff","patch_url":"https://github.com/google/santa/pull/271.patch","issue_url":"https://api.github.com/repos/google/santa/issues/271","number":271,"state":"open","locked":false,"title":"SantaCache: Templatize key types","user":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-30T19:14:11Z","updated_at":"2018-05-30T19:47:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b84bd5664965676a1928c79708bae9e762a4979","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nguyen-phillip","id":30534889,"node_id":"MDQ6VXNlcjMwNTM0ODg5","avatar_url":"https://avatars0.githubusercontent.com/u/30534889?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyen-phillip","html_url":"https://github.com/nguyen-phillip","followers_url":"https://api.github.com/users/nguyen-phillip/followers","following_url":"https://api.github.com/users/nguyen-phillip/following{/other_user}","gists_url":"https://api.github.com/users/nguyen-phillip/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyen-phillip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyen-phillip/subscriptions","organizations_url":"https://api.github.com/users/nguyen-phillip/orgs","repos_url":"https://api.github.com/users/nguyen-phillip/repos","events_url":"https://api.github.com/users/nguyen-phillip/events{/privacy}","received_events_url":"https://api.github.com/users/nguyen-phillip/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":136341304,"node_id":"MDU6TGFiZWwxMzYzNDEzMDQ=","url":"https://api.github.com/repos/google/santa/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/google/santa/pulls/271/commits","review_comments_url":"https://api.github.com/repos/google/santa/pulls/271/comments","review_comment_url":"https://api.github.com/repos/google/santa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/santa/issues/271/comments","statuses_url":"https://api.github.com/repos/google/santa/statuses/93fb1eda4ff00f8d59d46d14024e30325577c792","head":{"label":"russellhancox:santacache-template-keys","ref":"santacache-template-keys","sha":"93fb1eda4ff00f8d59d46d14024e30325577c792","user":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"repo":{"id":39463898,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ2Mzg5OA==","name":"santa","full_name":"russellhancox/santa","owner":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/russellhancox/santa","description":"A binary whitelisting/blacklisting system for Mac OS X","fork":true,"url":"https://api.github.com/repos/russellhancox/santa","forks_url":"https://api.github.com/repos/russellhancox/santa/forks","keys_url":"https://api.github.com/repos/russellhancox/santa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/russellhancox/santa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/russellhancox/santa/teams","hooks_url":"https://api.github.com/repos/russellhancox/santa/hooks","issue_events_url":"https://api.github.com/repos/russellhancox/santa/issues/events{/number}","events_url":"https://api.github.com/repos/russellhancox/santa/events","assignees_url":"https://api.github.com/repos/russellhancox/santa/assignees{/user}","branches_url":"https://api.github.com/repos/russellhancox/santa/branches{/branch}","tags_url":"https://api.github.com/repos/russellhancox/santa/tags","blobs_url":"https://api.github.com/repos/russellhancox/santa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/russellhancox/santa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/russellhancox/santa/git/refs{/sha}","trees_url":"https://api.github.com/repos/russellhancox/santa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/russellhancox/santa/statuses/{sha}","languages_url":"https://api.github.com/repos/russellhancox/santa/languages","stargazers_url":"https://api.github.com/repos/russellhancox/santa/stargazers","contributors_url":"https://api.github.com/repos/russellhancox/santa/contributors","subscribers_url":"https://api.github.com/repos/russellhancox/santa/subscribers","subscription_url":"https://api.github.com/repos/russellhancox/santa/subscription","commits_url":"https://api.github.com/repos/russellhancox/santa/commits{/sha}","git_commits_url":"https://api.github.com/repos/russellhancox/santa/git/commits{/sha}","comments_url":"https://api.github.com/repos/russellhancox/santa/comments{/number}","issue_comment_url":"https://api.github.com/repos/russellhancox/santa/issues/comments{/number}","contents_url":"https://api.github.com/repos/russellhancox/santa/contents/{+path}","compare_url":"https://api.github.com/repos/russellhancox/santa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/russellhancox/santa/merges","archive_url":"https://api.github.com/repos/russellhancox/santa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/russellhancox/santa/downloads","issues_url":"https://api.github.com/repos/russellhancox/santa/issues{/number}","pulls_url":"https://api.github.com/repos/russellhancox/santa/pulls{/number}","milestones_url":"https://api.github.com/repos/russellhancox/santa/milestones{/number}","notifications_url":"https://api.github.com/repos/russellhancox/santa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/russellhancox/santa/labels{/name}","releases_url":"https://api.github.com/repos/russellhancox/santa/releases{/id}","deployments_url":"https://api.github.com/repos/russellhancox/santa/deployments","created_at":"2015-07-21T18:53:19Z","updated_at":"2018-04-27T16:57:24Z","pushed_at":"2018-05-30T19:12:40Z","git_url":"git://github.com/russellhancox/santa.git","ssh_url":"git@github.com:russellhancox/santa.git","clone_url":"https://github.com/russellhancox/santa.git","svn_url":"https://github.com/russellhancox/santa","homepage":"","size":2020,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"c3ce4f718bad6cbc542337d00e4a853aff0fc87f","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":25009012,"node_id":"MDEwOlJlcG9zaXRvcnkyNTAwOTAxMg==","name":"santa","full_name":"google/santa","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/santa","description":"A binary whitelisting/blacklisting system for Mac OS X","fork":false,"url":"https://api.github.com/repos/google/santa","forks_url":"https://api.github.com/repos/google/santa/forks","keys_url":"https://api.github.com/repos/google/santa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/santa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/santa/teams","hooks_url":"https://api.github.com/repos/google/santa/hooks","issue_events_url":"https://api.github.com/repos/google/santa/issues/events{/number}","events_url":"https://api.github.com/repos/google/santa/events","assignees_url":"https://api.github.com/repos/google/santa/assignees{/user}","branches_url":"https://api.github.com/repos/google/santa/branches{/branch}","tags_url":"https://api.github.com/repos/google/santa/tags","blobs_url":"https://api.github.com/repos/google/santa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/santa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/santa/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/santa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/santa/statuses/{sha}","languages_url":"https://api.github.com/repos/google/santa/languages","stargazers_url":"https://api.github.com/repos/google/santa/stargazers","contributors_url":"https://api.github.com/repos/google/santa/contributors","subscribers_url":"https://api.github.com/repos/google/santa/subscribers","subscription_url":"https://api.github.com/repos/google/santa/subscription","commits_url":"https://api.github.com/repos/google/santa/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/santa/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/santa/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/santa/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/santa/contents/{+path}","compare_url":"https://api.github.com/repos/google/santa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/santa/merges","archive_url":"https://api.github.com/repos/google/santa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/santa/downloads","issues_url":"https://api.github.com/repos/google/santa/issues{/number}","pulls_url":"https://api.github.com/repos/google/santa/pulls{/number}","milestones_url":"https://api.github.com/repos/google/santa/milestones{/number}","notifications_url":"https://api.github.com/repos/google/santa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/santa/labels{/name}","releases_url":"https://api.github.com/repos/google/santa/releases{/id}","deployments_url":"https://api.github.com/repos/google/santa/deployments","created_at":"2014-10-09T21:18:31Z","updated_at":"2018-05-30T19:41:57Z","pushed_at":"2018-05-30T19:14:12Z","git_url":"git://github.com/google/santa.git","ssh_url":"git@github.com:google/santa.git","clone_url":"https://github.com/google/santa.git","svn_url":"https://github.com/google/santa","homepage":"","size":2090,"stargazers_count":2294,"watchers_count":2294,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":155,"open_issues":19,"watchers":2294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/santa/pulls/271"},"html":{"href":"https://github.com/google/santa/pull/271"},"issue":{"href":"https://api.github.com/repos/google/santa/issues/271"},"comments":{"href":"https://api.github.com/repos/google/santa/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/google/santa/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/google/santa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/santa/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/google/santa/statuses/93fb1eda4ff00f8d59d46d14024e30325577c792"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"russellhancox"}}