{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/docs/issues/8466","repository_url":"https://api.github.com/repos/dotnet/docs","labels_url":"https://api.github.com/repos/dotnet/docs/issues/8466/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/docs/issues/8466/comments","events_url":"https://api.github.com/repos/dotnet/docs/issues/8466/events","html_url":"https://github.com/dotnet/docs/pull/8466","id":371492747,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTI2NzM2","number":8466,"title":"AssemblyInformationalVersion does not produce a build warning","user":{"login":"joaopgrassi","id":5938087,"node_id":"MDQ6VXNlcjU5MzgwODc=","avatar_url":"https://avatars2.githubusercontent.com/u/5938087?v=4","gravatar_id":"","url":"https://api.github.com/users/joaopgrassi","html_url":"https://github.com/joaopgrassi","followers_url":"https://api.github.com/users/joaopgrassi/followers","following_url":"https://api.github.com/users/joaopgrassi/following{/other_user}","gists_url":"https://api.github.com/users/joaopgrassi/gists{/gist_id}","starred_url":"https://api.github.com/users/joaopgrassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaopgrassi/subscriptions","organizations_url":"https://api.github.com/users/joaopgrassi/orgs","repos_url":"https://api.github.com/users/joaopgrassi/repos","events_url":"https://api.github.com/users/joaopgrassi/events{/privacy}","received_events_url":"https://api.github.com/users/joaopgrassi/received_events","type":"User","site_admin":false},"labels":[{"id":697062683,"node_id":"MDU6TGFiZWw2OTcwNjI2ODM=","url":"https://api.github.com/repos/dotnet/docs/labels/:sparkles:%201st-time%20docs%20contributor!","name":":sparkles: 1st-time docs contributor!","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":{"login":"joaopgrassi","id":5938087,"node_id":"MDQ6VXNlcjU5MzgwODc=","avatar_url":"https://avatars2.githubusercontent.com/u/5938087?v=4","gravatar_id":"","url":"https://api.github.com/users/joaopgrassi","html_url":"https://github.com/joaopgrassi","followers_url":"https://api.github.com/users/joaopgrassi/followers","following_url":"https://api.github.com/users/joaopgrassi/following{/other_user}","gists_url":"https://api.github.com/users/joaopgrassi/gists{/gist_id}","starred_url":"https://api.github.com/users/joaopgrassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaopgrassi/subscriptions","organizations_url":"https://api.github.com/users/joaopgrassi/orgs","repos_url":"https://api.github.com/users/joaopgrassi/repos","events_url":"https://api.github.com/users/joaopgrassi/events{/privacy}","received_events_url":"https://api.github.com/users/joaopgrassi/received_events","type":"User","site_admin":false},"assignees":[{"login":"joaopgrassi","id":5938087,"node_id":"MDQ6VXNlcjU5MzgwODc=","avatar_url":"https://avatars2.githubusercontent.com/u/5938087?v=4","gravatar_id":"","url":"https://api.github.com/users/joaopgrassi","html_url":"https://github.com/joaopgrassi","followers_url":"https://api.github.com/users/joaopgrassi/followers","following_url":"https://api.github.com/users/joaopgrassi/following{/other_user}","gists_url":"https://api.github.com/users/joaopgrassi/gists{/gist_id}","starred_url":"https://api.github.com/users/joaopgrassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaopgrassi/subscriptions","organizations_url":"https://api.github.com/users/joaopgrassi/orgs","repos_url":"https://api.github.com/users/joaopgrassi/repos","events_url":"https://api.github.com/users/joaopgrassi/events{/privacy}","received_events_url":"https://api.github.com/users/joaopgrassi/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/docs/milestones/49","html_url":"https://github.com/dotnet/docs/milestone/49","labels_url":"https://api.github.com/repos/dotnet/docs/milestones/49/labels","id":3604930,"node_id":"MDk6TWlsZXN0b25lMzYwNDkzMA==","number":49,"title":"Sprint 143 (10/15/2018 - 11/2/2018)","description":"","creator":{"login":"rpetrusha","id":10886961,"node_id":"MDQ6VXNlcjEwODg2OTYx","avatar_url":"https://avatars2.githubusercontent.com/u/10886961?v=4","gravatar_id":"","url":"https://api.github.com/users/rpetrusha","html_url":"https://github.com/rpetrusha","followers_url":"https://api.github.com/users/rpetrusha/followers","following_url":"https://api.github.com/users/rpetrusha/following{/other_user}","gists_url":"https://api.github.com/users/rpetrusha/gists{/gist_id}","starred_url":"https://api.github.com/users/rpetrusha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpetrusha/subscriptions","organizations_url":"https://api.github.com/users/rpetrusha/orgs","repos_url":"https://api.github.com/users/rpetrusha/repos","events_url":"https://api.github.com/users/rpetrusha/events{/privacy}","received_events_url":"https://api.github.com/users/rpetrusha/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":74,"state":"open","created_at":"2018-08-28T19:10:36Z","updated_at":"2018-10-22T17:29:58Z","due_on":"2018-11-02T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-10-18T11:51:36Z","updated_at":"2018-10-22T17:51:56Z","closed_at":"2018-10-18T15:49:45Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dotnet/docs/pulls/8466","html_url":"https://github.com/dotnet/docs/pull/8466","diff_url":"https://github.com/dotnet/docs/pull/8466.diff","patch_url":"https://github.com/dotnet/docs/pull/8466.patch"},"body":"## Summary\r\nThe documentation says that if you use a version for `<AssemblyInformationalVersion>` which does not follow the format `Major.Minor.Build.Revision` a build warning is produced, but this is not correct.\r\n\r\nThe build warning is produced for the `<FileVersion>`. If its version does not follow the format above then we see the following warning:\r\n`The specified version string does not conform to the recommended format - major.minor.build.revision`\r\n\r\nThis PR moves the \"Note\" about the build warning under the \"Assembly file version\" section.  See the demo project I created to exemplify this: https://github.com/joaopgrassi/fileversion-buildwarning\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/docs/issues/comments/431913981","html_url":"https://github.com/dotnet/docs/pull/8466#issuecomment-431913981","issue_url":"https://api.github.com/repos/dotnet/docs/issues/8466","id":431913981,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTkxMzk4MQ==","user":{"login":"joaopgrassi","id":5938087,"node_id":"MDQ6VXNlcjU5MzgwODc=","avatar_url":"https://avatars2.githubusercontent.com/u/5938087?v=4","gravatar_id":"","url":"https://api.github.com/users/joaopgrassi","html_url":"https://github.com/joaopgrassi","followers_url":"https://api.github.com/users/joaopgrassi/followers","following_url":"https://api.github.com/users/joaopgrassi/following{/other_user}","gists_url":"https://api.github.com/users/joaopgrassi/gists{/gist_id}","starred_url":"https://api.github.com/users/joaopgrassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaopgrassi/subscriptions","organizations_url":"https://api.github.com/users/joaopgrassi/orgs","repos_url":"https://api.github.com/users/joaopgrassi/repos","events_url":"https://api.github.com/users/joaopgrassi/events{/privacy}","received_events_url":"https://api.github.com/users/joaopgrassi/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T17:51:56Z","updated_at":"2018-10-22T17:51:56Z","author_association":"CONTRIBUTOR","body":"Awesome! Super excited that it got merged/accepted that fast! Thanks for the good work you all put up for us at docs.microsoft.com!"}}
{"actor":{"display_login":"joaopgrassi"}}