{"action":"created","issue":{"url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/963","repository_url":"https://api.github.com/repos/fluentassertions/fluentassertions","labels_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/963/labels{/name}","comments_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/963/comments","events_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/963/events","html_url":"https://github.com/fluentassertions/fluentassertions/pull/963","id":379937231,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjU2Njg2","number":963,"title":"[WIP] Add support for IReadOnlyDictionary assertions","user":{"login":"krajek","id":3998666,"node_id":"MDQ6VXNlcjM5OTg2NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3998666?v=4","gravatar_id":"","url":"https://api.github.com/users/krajek","html_url":"https://github.com/krajek","followers_url":"https://api.github.com/users/krajek/followers","following_url":"https://api.github.com/users/krajek/following{/other_user}","gists_url":"https://api.github.com/users/krajek/gists{/gist_id}","starred_url":"https://api.github.com/users/krajek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krajek/subscriptions","organizations_url":"https://api.github.com/users/krajek/orgs","repos_url":"https://api.github.com/users/krajek/repos","events_url":"https://api.github.com/users/krajek/events{/privacy}","received_events_url":"https://api.github.com/users/krajek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-12T20:20:17Z","updated_at":"2018-11-30T08:59:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fluentassertions/fluentassertions/pulls/963","html_url":"https://github.com/fluentassertions/fluentassertions/pull/963","diff_url":"https://github.com/fluentassertions/fluentassertions/pull/963.diff","patch_url":"https://github.com/fluentassertions/fluentassertions/pull/963.patch"},"body":"Closes #568.\r\n\r\nThe main idea is that due to limitations of method overload resolution we cannot have `[...]Should(IReadOnlyDictionary<TKey,TValue>[...]`. It will always conflict with overload accepting `IDictionary`. \r\n\r\nTherefore I propose using `ShouldReadOnlyDictionary` name. It seems that it would be beneficial to cut this Gordian knot.\r\n\r\nPlease let me know what you think. Upon acceptance, I will complete documentation etc."},"comment":{"url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/comments/443136520","html_url":"https://github.com/fluentassertions/fluentassertions/pull/963#issuecomment-443136520","issue_url":"https://api.github.com/repos/fluentassertions/fluentassertions/issues/963","id":443136520,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzEzNjUyMA==","user":{"login":"jnyrup","id":919634,"node_id":"MDQ6VXNlcjkxOTYzNA==","avatar_url":"https://avatars1.githubusercontent.com/u/919634?v=4","gravatar_id":"","url":"https://api.github.com/users/jnyrup","html_url":"https://github.com/jnyrup","followers_url":"https://api.github.com/users/jnyrup/followers","following_url":"https://api.github.com/users/jnyrup/following{/other_user}","gists_url":"https://api.github.com/users/jnyrup/gists{/gist_id}","starred_url":"https://api.github.com/users/jnyrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnyrup/subscriptions","organizations_url":"https://api.github.com/users/jnyrup/orgs","repos_url":"https://api.github.com/users/jnyrup/repos","events_url":"https://api.github.com/users/jnyrup/events{/privacy}","received_events_url":"https://api.github.com/users/jnyrup/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T08:59:41Z","updated_at":"2018-11-30T08:59:41Z","author_association":"COLLABORATOR","body":"@dennisdoomen the compiler does support having both overloads.\r\n`IDictionary` doesn't inherit from `IReadOnlyDictionary`, but `Dictionary` implements both interfaces, so the conflict is that `Dictionary.Shoul()` is ambiguous between `Should(this IDictionary)` and `Should(this IReadOnlyDictionary)`."}}
{"actor":{"display_login":"jnyrup"}}