{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/comments/243468933","pull_request_review_id":187247943,"id":243468933,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQ2ODkzMw==","diff_hunk":"@@ -40,60 +38,58 @@ describe('Compute', function() {\n   // deleted. This will also pick up any previously-created objects that were\n   // unable to be removed if a prior test run had unexpectedly quit.\n \n-  const TESTS_PREFIX = 'gcloud-tests-';\n+  const TESTS_PREFIX = 'gcloud';\n+  const TEST_ID = uuid.v4().split('-')[0];\n+  const FULL_PREFIX = `${TESTS_PREFIX}-${TEST_ID}`;\n   const REGION_NAME = 'us-central1';\n   const ZONE_NAME = 'us-central1-a';\n \n   const compute = new Compute();\n   const region = compute.region(REGION_NAME);\n   const zone = compute.zone(ZONE_NAME);\n \n-  before(deleteAllTestObjects);\n-  after(deleteAllTestObjects);\n+  const computeRequest = promisify(compute.request).bind(compute);\n+  const zoneRequest = promisify(zone.request).bind(zone);\n \n-  describe('addresses', function() {\n+  before(() => deleteAllTestObjects({expiredOnly: true}));\n+  after(() => deleteAllTestObjects({expiredOnly: false}));\n+\n+  describe('addresses', async () => {\n     const ADDRESS_NAME = generateName('address');\n     const address = region.address(ADDRESS_NAME);\n \n-    before(create(address));","path":"system-test/compute.js","position":46,"original_position":46,"commit_id":"c9d72490d32cddc2221782722484b296b20853fe","original_commit_id":"c9d72490d32cddc2221782722484b296b20853fe","user":{"login":"stephenplusplus","id":723048,"node_id":"MDQ6VXNlcjcyMzA0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/723048?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"body":"This works (or at least it used to) :) It returns a function that execurew when the before hook fires. ","created_at":"2018-12-21T01:41:24Z","updated_at":"2018-12-21T01:41:24Z","html_url":"https://github.com/googleapis/nodejs-compute/pull/203#discussion_r243468933","pull_request_url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/203","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/comments/243468933"},"html":{"href":"https://github.com/googleapis/nodejs-compute/pull/203#discussion_r243468933"},"pull_request":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/203"}},"in_reply_to_id":243453082},"pull_request":{"url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/203","id":229870163,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODcwMTYz","html_url":"https://github.com/googleapis/nodejs-compute/pull/203","diff_url":"https://github.com/googleapis/nodejs-compute/pull/203.diff","patch_url":"https://github.com/googleapis/nodejs-compute/pull/203.patch","issue_url":"https://api.github.com/repos/googleapis/nodejs-compute/issues/203","number":203,"state":"closed","locked":false,"title":"fix: asyncify and fix the system tests","user":{"login":"JustinBeckwith","id":534619,"node_id":"MDQ6VXNlcjUzNDYxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-10T04:44:26Z","updated_at":"2018-12-21T01:41:24Z","closed_at":"2018-12-21T00:06:29Z","merged_at":"2018-12-21T00:06:29Z","merge_commit_sha":"c54e6e90a5cdfafeac4dec70459b10ca0a7007b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":738762758,"node_id":"MDU6TGFiZWw3Mzg3NjI3NTg=","url":"https://api.github.com/repos/googleapis/nodejs-compute/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/203/commits","review_comments_url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/203/comments","review_comment_url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/nodejs-compute/issues/203/comments","statuses_url":"https://api.github.com/repos/googleapis/nodejs-compute/statuses/c9d72490d32cddc2221782722484b296b20853fe","head":{"label":"JustinBeckwith:stf","ref":"stf","sha":"c9d72490d32cddc2221782722484b296b20853fe","user":{"login":"JustinBeckwith","id":534619,"node_id":"MDQ6VXNlcjUzNDYxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"repo":{"id":129284737,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyODQ3Mzc=","name":"nodejs-compute","full_name":"JustinBeckwith/nodejs-compute","private":false,"owner":{"login":"JustinBeckwith","id":534619,"node_id":"MDQ6VXNlcjUzNDYxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JustinBeckwith/nodejs-compute","description":"Node.js client for Google Compute Engine: Scalable, High-Performance Virtual Machines","fork":true,"url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute","forks_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/forks","keys_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/teams","hooks_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/hooks","issue_events_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/issues/events{/number}","events_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/events","assignees_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/assignees{/user}","branches_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/branches{/branch}","tags_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/tags","blobs_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/git/refs{/sha}","trees_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/statuses/{sha}","languages_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/languages","stargazers_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/stargazers","contributors_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/contributors","subscribers_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/subscribers","subscription_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/subscription","commits_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/commits{/sha}","git_commits_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/git/commits{/sha}","comments_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/comments{/number}","issue_comment_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/issues/comments{/number}","contents_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/contents/{+path}","compare_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/merges","archive_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/downloads","issues_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/issues{/number}","pulls_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/pulls{/number}","milestones_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/milestones{/number}","notifications_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/labels{/name}","releases_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/releases{/id}","deployments_url":"https://api.github.com/repos/JustinBeckwith/nodejs-compute/deployments","created_at":"2018-04-12T17:00:41Z","updated_at":"2018-12-21T00:17:52Z","pushed_at":"2018-12-21T00:29:51Z","git_url":"git://github.com/JustinBeckwith/nodejs-compute.git","ssh_url":"git@github.com:JustinBeckwith/nodejs-compute.git","clone_url":"https://github.com/JustinBeckwith/nodejs-compute.git","svn_url":"https://github.com/JustinBeckwith/nodejs-compute","homepage":"https://cloud.google.com/compute/","size":1419,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"6a225702815ff1e78a4a246ea4dac12c2c96b5db","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":98463458,"node_id":"MDEwOlJlcG9zaXRvcnk5ODQ2MzQ1OA==","name":"nodejs-compute","full_name":"googleapis/nodejs-compute","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/nodejs-compute","description":"Node.js client for Google Compute Engine: Scalable, High-Performance Virtual Machines","fork":false,"url":"https://api.github.com/repos/googleapis/nodejs-compute","forks_url":"https://api.github.com/repos/googleapis/nodejs-compute/forks","keys_url":"https://api.github.com/repos/googleapis/nodejs-compute/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/nodejs-compute/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/nodejs-compute/teams","hooks_url":"https://api.github.com/repos/googleapis/nodejs-compute/hooks","issue_events_url":"https://api.github.com/repos/googleapis/nodejs-compute/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/nodejs-compute/events","assignees_url":"https://api.github.com/repos/googleapis/nodejs-compute/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/nodejs-compute/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/nodejs-compute/tags","blobs_url":"https://api.github.com/repos/googleapis/nodejs-compute/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/nodejs-compute/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/nodejs-compute/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/nodejs-compute/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/nodejs-compute/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/nodejs-compute/languages","stargazers_url":"https://api.github.com/repos/googleapis/nodejs-compute/stargazers","contributors_url":"https://api.github.com/repos/googleapis/nodejs-compute/contributors","subscribers_url":"https://api.github.com/repos/googleapis/nodejs-compute/subscribers","subscription_url":"https://api.github.com/repos/googleapis/nodejs-compute/subscription","commits_url":"https://api.github.com/repos/googleapis/nodejs-compute/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/nodejs-compute/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/nodejs-compute/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/nodejs-compute/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/nodejs-compute/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/nodejs-compute/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/nodejs-compute/merges","archive_url":"https://api.github.com/repos/googleapis/nodejs-compute/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/nodejs-compute/downloads","issues_url":"https://api.github.com/repos/googleapis/nodejs-compute/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/nodejs-compute/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/nodejs-compute/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/nodejs-compute/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/nodejs-compute/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/nodejs-compute/deployments","created_at":"2017-07-26T20:31:42Z","updated_at":"2018-12-21T00:06:32Z","pushed_at":"2018-12-21T00:29:52Z","git_url":"git://github.com/googleapis/nodejs-compute.git","ssh_url":"git@github.com:googleapis/nodejs-compute.git","clone_url":"https://github.com/googleapis/nodejs-compute.git","svn_url":"https://github.com/googleapis/nodejs-compute","homepage":"https://cloud.google.com/compute/","size":1300,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":20,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/203"},"html":{"href":"https://github.com/googleapis/nodejs-compute/pull/203"},"issue":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/issues/203"},"comments":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/statuses/c9d72490d32cddc2221782722484b296b20853fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stephenplusplus"}}