{"action":"closed","number":39115,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/39115","id":183212897,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgzMjEyODk3","html_url":"https://github.com/ansible/ansible/pull/39115","diff_url":"https://github.com/ansible/ansible/pull/39115.diff","patch_url":"https://github.com/ansible/ansible/pull/39115.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/39115","number":39115,"state":"closed","locked":false,"title":"Return correct version on installed VyOS","user":{"login":"maugli13","id":14159694,"node_id":"MDQ6VXNlcjE0MTU5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/14159694?v=4","gravatar_id":"","url":"https://api.github.com/users/maugli13","html_url":"https://github.com/maugli13","followers_url":"https://api.github.com/users/maugli13/followers","following_url":"https://api.github.com/users/maugli13/following{/other_user}","gists_url":"https://api.github.com/users/maugli13/gists{/gist_id}","starred_url":"https://api.github.com/users/maugli13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maugli13/subscriptions","organizations_url":"https://api.github.com/users/maugli13/orgs","repos_url":"https://api.github.com/users/maugli13/repos","events_url":"https://api.github.com/users/maugli13/events{/privacy}","received_events_url":"https://api.github.com/users/maugli13/received_events","type":"User","site_admin":false},"body":"Previously existing regexp will shows only \"VyOS\" without numeric output of router version.\r\nFor example: from  \"Version:      VyOS 1.1.6\" only VyOS will be written in ansible_net_version variable\r\nFor more informative output numeric value should be returned as well\r\n\r\n##### SUMMARY\r\nPreviously existing regexp will shows only \"VyOS\" without numeric output of router version.\r\nFor example: from  \"Version:      VyOS 1.1.6\" only VyOS will be written in ansible_net_version variable\r\nFor more informative output numeric value should be returned as well\r\n\r\n##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\nvyos_facts\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.5.1\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = [u'/home/murmanov/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /usr/lib/python2.7/dist-packages/ansible\r\n  executable location = /usr/bin/ansible\r\n  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\nBelow you can see before and after outputs\r\n\r\n```\r\nok: [nn-vpn.int] => {\r\n    \"ansible_facts\": {\r\n        \"ansible_net_gather_subset\": [\r\n            \"neighbors\", \r\n            \"default\"\r\n        ], \r\n        \"ansible_net_hostname\": \"nn-vpn\", \r\n        \"ansible_net_model\": \"VMware\", \r\n        \"ansible_net_serialnum\": \"VMware-56\", \r\n        \"ansible_net_version\": \"VyOS\"\r\n    }, \r\n    \"changed\": false, \r\n    \"invocation\": {\r\n        \"module_args\": {\r\n            \"gather_subset\": [\r\n                \"!config\"\r\n            ], \r\n            \"host\": null, \r\n            \"password\": null, \r\n            \"port\": null, \r\n            \"provider\": null, \r\n            \"ssh_keyfile\": null, \r\n            \"timeout\": null, \r\n            \"username\": null\r\n        }\r\n    }\r\n}\r\n\r\n################# After ####################\r\n\r\nok: [nn-vpn.int] => {\r\n    \"ansible_facts\": {\r\n        \"ansible_net_gather_subset\": [\r\n            \"neighbors\", \r\n            \"default\"\r\n        ], \r\n        \"ansible_net_hostname\": \"nn-vpn\", \r\n        \"ansible_net_model\": \"VMware\", \r\n        \"ansible_net_serialnum\": \"VMware-56\", \r\n        \"ansible_net_version\": \"VyOS 1.1.6\"\r\n    }, \r\n    \"changed\": false, \r\n    \"invocation\": {\r\n        \"module_args\": {\r\n            \"gather_subset\": [\r\n                \"!config\"\r\n            ], \r\n            \"host\": null, \r\n            \"password\": null, \r\n            \"port\": null, \r\n            \"provider\": null, \r\n            \"ssh_keyfile\": null, \r\n            \"timeout\": null, \r\n            \"username\": null\r\n        }\r\n    }\r\n}\r\n\r\n```\r\n","created_at":"2018-04-21T08:28:41Z","updated_at":"2018-09-14T16:52:29Z","closed_at":"2018-09-14T16:52:29Z","merged_at":null,"merge_commit_sha":"a48c7d78e539c2dc5b4a0adaf3f39635869a749e","assignee":{"login":"NilashishC","id":15523883,"node_id":"MDQ6VXNlcjE1NTIzODgz","avatar_url":"https://avatars2.githubusercontent.com/u/15523883?v=4","gravatar_id":"","url":"https://api.github.com/users/NilashishC","html_url":"https://github.com/NilashishC","followers_url":"https://api.github.com/users/NilashishC/followers","following_url":"https://api.github.com/users/NilashishC/following{/other_user}","gists_url":"https://api.github.com/users/NilashishC/gists{/gist_id}","starred_url":"https://api.github.com/users/NilashishC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilashishC/subscriptions","organizations_url":"https://api.github.com/users/NilashishC/orgs","repos_url":"https://api.github.com/users/NilashishC/repos","events_url":"https://api.github.com/users/NilashishC/events{/privacy}","received_events_url":"https://api.github.com/users/NilashishC/received_events","type":"User","site_admin":false},"assignees":[{"login":"NilashishC","id":15523883,"node_id":"MDQ6VXNlcjE1NTIzODgz","avatar_url":"https://avatars2.githubusercontent.com/u/15523883?v=4","gravatar_id":"","url":"https://api.github.com/users/NilashishC","html_url":"https://github.com/NilashishC","followers_url":"https://api.github.com/users/NilashishC/followers","following_url":"https://api.github.com/users/NilashishC/following{/other_user}","gists_url":"https://api.github.com/users/NilashishC/gists{/gist_id}","starred_url":"https://api.github.com/users/NilashishC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilashishC/subscriptions","organizations_url":"https://api.github.com/users/NilashishC/orgs","repos_url":"https://api.github.com/users/NilashishC/repos","events_url":"https://api.github.com/users/NilashishC/events{/privacy}","received_events_url":"https://api.github.com/users/NilashishC/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":835286067,"node_id":"MDU6TGFiZWw4MzUyODYwNjc=","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.6","name":"affects_2.6","color":"ededed","default":false},{"id":852590921,"node_id":"MDU6TGFiZWw4NTI1OTA5MjE=","url":"https://api.github.com/repos/ansible/ansible/labels/feature","name":"feature","color":"006b75","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"node_id":"MDU6TGFiZWw2MTQzNjI4MQ==","url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":339653091,"node_id":"MDU6TGFiZWwzMzk2NTMwOTE=","url":"https://api.github.com/repos/ansible/ansible/labels/networking","name":"networking","color":"c7def8","default":false},{"id":723150340,"node_id":"MDU6TGFiZWw3MjMxNTAzNDA=","url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"c2e0c6","default":false},{"id":970086458,"node_id":"MDU6TGFiZWw5NzAwODY0NTg=","url":"https://api.github.com/repos/ansible/ansible/labels/small_patch","name":"small_patch","color":"ededed","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false},{"id":468273802,"node_id":"MDU6TGFiZWw0NjgyNzM4MDI=","url":"https://api.github.com/repos/ansible/ansible/labels/test","name":"test","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/39115/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/39115/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/39115/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/387c4b60b3491485b5dcf0a18e30e09e392c298d","head":{"label":"maugli13:patch-1","ref":"patch-1","sha":"387c4b60b3491485b5dcf0a18e30e09e392c298d","user":{"login":"maugli13","id":14159694,"node_id":"MDQ6VXNlcjE0MTU5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/14159694?v=4","gravatar_id":"","url":"https://api.github.com/users/maugli13","html_url":"https://github.com/maugli13","followers_url":"https://api.github.com/users/maugli13/followers","following_url":"https://api.github.com/users/maugli13/following{/other_user}","gists_url":"https://api.github.com/users/maugli13/gists{/gist_id}","starred_url":"https://api.github.com/users/maugli13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maugli13/subscriptions","organizations_url":"https://api.github.com/users/maugli13/orgs","repos_url":"https://api.github.com/users/maugli13/repos","events_url":"https://api.github.com/users/maugli13/events{/privacy}","received_events_url":"https://api.github.com/users/maugli13/received_events","type":"User","site_admin":false},"repo":{"id":130454184,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA0NTQxODQ=","name":"ansible","full_name":"maugli13/ansible","owner":{"login":"maugli13","id":14159694,"node_id":"MDQ6VXNlcjE0MTU5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/14159694?v=4","gravatar_id":"","url":"https://api.github.com/users/maugli13","html_url":"https://github.com/maugli13","followers_url":"https://api.github.com/users/maugli13/followers","following_url":"https://api.github.com/users/maugli13/following{/other_user}","gists_url":"https://api.github.com/users/maugli13/gists{/gist_id}","starred_url":"https://api.github.com/users/maugli13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maugli13/subscriptions","organizations_url":"https://api.github.com/users/maugli13/orgs","repos_url":"https://api.github.com/users/maugli13/repos","events_url":"https://api.github.com/users/maugli13/events{/privacy}","received_events_url":"https://api.github.com/users/maugli13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maugli13/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":true,"url":"https://api.github.com/repos/maugli13/ansible","forks_url":"https://api.github.com/repos/maugli13/ansible/forks","keys_url":"https://api.github.com/repos/maugli13/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maugli13/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maugli13/ansible/teams","hooks_url":"https://api.github.com/repos/maugli13/ansible/hooks","issue_events_url":"https://api.github.com/repos/maugli13/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/maugli13/ansible/events","assignees_url":"https://api.github.com/repos/maugli13/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/maugli13/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/maugli13/ansible/tags","blobs_url":"https://api.github.com/repos/maugli13/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maugli13/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maugli13/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/maugli13/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maugli13/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/maugli13/ansible/languages","stargazers_url":"https://api.github.com/repos/maugli13/ansible/stargazers","contributors_url":"https://api.github.com/repos/maugli13/ansible/contributors","subscribers_url":"https://api.github.com/repos/maugli13/ansible/subscribers","subscription_url":"https://api.github.com/repos/maugli13/ansible/subscription","commits_url":"https://api.github.com/repos/maugli13/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/maugli13/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/maugli13/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/maugli13/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/maugli13/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/maugli13/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maugli13/ansible/merges","archive_url":"https://api.github.com/repos/maugli13/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maugli13/ansible/downloads","issues_url":"https://api.github.com/repos/maugli13/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/maugli13/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/maugli13/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/maugli13/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maugli13/ansible/labels{/name}","releases_url":"https://api.github.com/repos/maugli13/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/maugli13/ansible/deployments","created_at":"2018-04-21T08:18:28Z","updated_at":"2018-04-21T08:19:05Z","pushed_at":"2018-09-14T11:56:14Z","git_url":"git://github.com/maugli13/ansible.git","ssh_url":"git@github.com:maugli13/ansible.git","clone_url":"https://github.com/maugli13/ansible.git","svn_url":"https://github.com/maugli13/ansible","homepage":"https://www.ansible.com/","size":130660,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"56967497d57abbf6ea62515b1776f1180072d274","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-09-14T16:27:17Z","pushed_at":"2018-09-14T16:22:56Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":140895,"stargazers_count":32524,"watchers_count":32524,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12794,"mirror_url":null,"archived":false,"open_issues_count":5397,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":12794,"open_issues":5397,"watchers":32524,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/39115"},"html":{"href":"https://github.com/ansible/ansible/pull/39115"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/39115"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/39115/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/39115/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/39115/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/387c4b60b3491485b5dcf0a18e30e09e392c298d"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":4,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"mattclay"}}