{"push_id":2657690877,"size":3,"distinct_size":1,"ref":"refs/heads/wchargin-use-edgeToParts","head":"27511db045f21800d259c1658adb4bf543d35e12","before":"321aa742301449993e487c26760da30e59c19c4c","commits":[{"sha":"ea74955a66a91301d6b26d0748c3a63f02565733","author":{"name":"William Chargin","email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com"},"message":"Fix GitHub node `fromRaw` error-path test cases (#397)\n\nSummary:\r\nIn #394, we uppercased the constants for GitHub node types. However, we\r\nwere using string literals instead of constants in the test cases. These\r\ntest cases were supposed to cover every error path, but instead ended up\r\njust covering the “bad type” error path many times.\r\n\r\nAny one of the following would have prevented this regression:\r\n\r\n 1. using string constants instead of literals in the test case;\r\n 2. throwing and checking more precise error messages; or\r\n 3. being alerted that coverage decreased as a result of the change.\r\n\r\nIn this commit, we enact the first of these options. I’m open to adding\r\na coverage bot, but don’t feel strongly about it at this time.\r\n\r\nTest Plan:\r\nRunning `yarn coverage` now shows 100% coverage for the `nodes.js`\r\nmodule, whereas previously almost all `throw fail();` lines were\r\nuncovered (and the branch coverage was just 76%).\r\n\r\nwchargin-branch: fix-github-node-error-tests","distinct":false,"url":"https://api.github.com/repos/sourcecred/sourcecred/commits/ea74955a66a91301d6b26d0748c3a63f02565733"},{"sha":"aac2fc6792f4530929e58f812a1d262b85f6f7d9","author":{"name":"William Chargin","email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com"},"message":"Add `edgeToParts` convenience export from `Graph` (#398)\n\nSummary:\r\nWe have `edgeToString`, which formats edges as nicely human-readable\r\nstrings. However, these strings have some quotes in them, and so when\r\nthey are themselves stringified (e.g., as part of a Jest snapshot), they\r\nbecome much harder to read. We thus introduce `edgeToParts` to make our\r\nsnapshots more readable.\r\n\r\nTest Plan:\r\nUnit tests added; run `yarn travis`.\r\n\r\nwchargin-branch: add-edgeToParts","distinct":false,"url":"https://api.github.com/repos/sourcecred/sourcecred/commits/aac2fc6792f4530929e58f812a1d262b85f6f7d9"},{"sha":"27511db045f21800d259c1658adb4bf543d35e12","author":{"name":"William Chargin","email":"366634280b879ce3c6c984f83d5675d046b04925@gmail.com"},"message":"Use `edgeToParts` in the GitHub edge tests\n\nTest Plan:\nObserve that the new snapshots are easier to read. Might as well make\nsure that they encode the same data as the old snapshots, too. Note that\nthe backslash character no longer appears in this snapshot file. :-)\n\nwchargin-branch: use-edgeToParts","distinct":true,"url":"https://api.github.com/repos/sourcecred/sourcecred/commits/27511db045f21800d259c1658adb4bf543d35e12"}]}
{"actor":{"display_login":"wchargin"}}