{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/228305760","pull_request_review_id":168523124,"id":228305760,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODMwNTc2MA==","diff_hunk":"@@ -120,6 +157,28 @@ func (s *Storage) ApplyConfig(conf *config.Config) error {\n \treturn nil\n }\n \n+// TODO: callum, should this always be called via a go routine or...?\n+func (s *Storage) SetWALDir(dir string) {\n+\ts.walDir = dir\n+\ts.dirChan <- s.walDir\n+\t// Wait for the WAL watcher to read to the end of the current WAL segment when\n+\t// we start Prometheus from an existing WAL.\n+\t<-s.dirChan\n+}\n+\n+func (s *Storage) SetDB(db *tsdb.DB) {\n+\ts.db = db\n+}\n+\n+func (s *Storage) SetLabels() {\n+\t// Head exists after TSDB.Open().\n+\tlabels := s.db.GetAllLabels()\n+\tfor q := range s.queues {\n+\t\tq.db = s.db\n+\t\tq.StoreSeriesLabels(labels)\n+\t}\n+}","path":"storage/remote/storage.go","position":144,"original_position":144,"commit_id":"2de4cab8d7c9091545f053b6afcbbba7d03f7b28","original_commit_id":"2de4cab8d7c9091545f053b6afcbbba7d03f7b28","user":{"login":"tomwilkie","id":444037,"node_id":"MDQ6VXNlcjQ0NDAzNw==","avatar_url":"https://avatars1.githubusercontent.com/u/444037?v=4","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"body":"This is going to go, right?","created_at":"2018-10-25T19:30:57Z","updated_at":"2018-10-25T19:44:26Z","html_url":"https://github.com/prometheus/prometheus/pull/4588#discussion_r228305760","pull_request_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4588","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/228305760"},"html":{"href":"https://github.com/prometheus/prometheus/pull/4588#discussion_r228305760"},"pull_request":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4588"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/4588","id":214047095,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDQ3MDk1","html_url":"https://github.com/prometheus/prometheus/pull/4588","diff_url":"https://github.com/prometheus/prometheus/pull/4588.diff","patch_url":"https://github.com/prometheus/prometheus/pull/4588.patch","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/4588","number":4588,"state":"open","locked":false,"title":"WIP: use WAL to gather samples for remote write","user":{"login":"cstyan","id":3246492,"node_id":"MDQ6VXNlcjMyNDY0OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3246492?v=4","gravatar_id":"","url":"https://api.github.com/users/cstyan","html_url":"https://github.com/cstyan","followers_url":"https://api.github.com/users/cstyan/followers","following_url":"https://api.github.com/users/cstyan/following{/other_user}","gists_url":"https://api.github.com/users/cstyan/gists{/gist_id}","starred_url":"https://api.github.com/users/cstyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstyan/subscriptions","organizations_url":"https://api.github.com/users/cstyan/orgs","repos_url":"https://api.github.com/users/cstyan/repos","events_url":"https://api.github.com/users/cstyan/events{/privacy}","received_events_url":"https://api.github.com/users/cstyan/received_events","type":"User","site_admin":false},"body":"Example of WAL tailing. Still need to do something with what we read out of the WAL.\r\n\r\ncc @csmarchbanks @tomwilkie ","created_at":"2018-09-07T21:46:11Z","updated_at":"2018-10-25T19:44:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1454f8cf6fedb2cf47082086aaa27da1746ba8b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4588/commits","review_comments_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4588/comments","review_comment_url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/4588/comments","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/2de4cab8d7c9091545f053b6afcbbba7d03f7b28","head":{"label":"cstyan:callum-tail-wal","ref":"callum-tail-wal","sha":"2de4cab8d7c9091545f053b6afcbbba7d03f7b28","user":{"login":"cstyan","id":3246492,"node_id":"MDQ6VXNlcjMyNDY0OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3246492?v=4","gravatar_id":"","url":"https://api.github.com/users/cstyan","html_url":"https://github.com/cstyan","followers_url":"https://api.github.com/users/cstyan/followers","following_url":"https://api.github.com/users/cstyan/following{/other_user}","gists_url":"https://api.github.com/users/cstyan/gists{/gist_id}","starred_url":"https://api.github.com/users/cstyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstyan/subscriptions","organizations_url":"https://api.github.com/users/cstyan/orgs","repos_url":"https://api.github.com/users/cstyan/repos","events_url":"https://api.github.com/users/cstyan/events{/privacy}","received_events_url":"https://api.github.com/users/cstyan/received_events","type":"User","site_admin":false},"repo":{"id":98469226,"node_id":"MDEwOlJlcG9zaXRvcnk5ODQ2OTIyNg==","name":"prometheus","full_name":"cstyan/prometheus","private":false,"owner":{"login":"cstyan","id":3246492,"node_id":"MDQ6VXNlcjMyNDY0OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3246492?v=4","gravatar_id":"","url":"https://api.github.com/users/cstyan","html_url":"https://github.com/cstyan","followers_url":"https://api.github.com/users/cstyan/followers","following_url":"https://api.github.com/users/cstyan/following{/other_user}","gists_url":"https://api.github.com/users/cstyan/gists{/gist_id}","starred_url":"https://api.github.com/users/cstyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstyan/subscriptions","organizations_url":"https://api.github.com/users/cstyan/orgs","repos_url":"https://api.github.com/users/cstyan/repos","events_url":"https://api.github.com/users/cstyan/events{/privacy}","received_events_url":"https://api.github.com/users/cstyan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cstyan/prometheus","description":"The Prometheus monitoring system and time series database.","fork":true,"url":"https://api.github.com/repos/cstyan/prometheus","forks_url":"https://api.github.com/repos/cstyan/prometheus/forks","keys_url":"https://api.github.com/repos/cstyan/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cstyan/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cstyan/prometheus/teams","hooks_url":"https://api.github.com/repos/cstyan/prometheus/hooks","issue_events_url":"https://api.github.com/repos/cstyan/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/cstyan/prometheus/events","assignees_url":"https://api.github.com/repos/cstyan/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/cstyan/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/cstyan/prometheus/tags","blobs_url":"https://api.github.com/repos/cstyan/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cstyan/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cstyan/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/cstyan/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cstyan/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/cstyan/prometheus/languages","stargazers_url":"https://api.github.com/repos/cstyan/prometheus/stargazers","contributors_url":"https://api.github.com/repos/cstyan/prometheus/contributors","subscribers_url":"https://api.github.com/repos/cstyan/prometheus/subscribers","subscription_url":"https://api.github.com/repos/cstyan/prometheus/subscription","commits_url":"https://api.github.com/repos/cstyan/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/cstyan/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/cstyan/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/cstyan/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/cstyan/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/cstyan/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cstyan/prometheus/merges","archive_url":"https://api.github.com/repos/cstyan/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cstyan/prometheus/downloads","issues_url":"https://api.github.com/repos/cstyan/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/cstyan/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/cstyan/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/cstyan/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cstyan/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/cstyan/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/cstyan/prometheus/deployments","created_at":"2017-07-26T22:00:14Z","updated_at":"2017-07-26T22:00:18Z","pushed_at":"2018-10-25T17:59:15Z","git_url":"git://github.com/cstyan/prometheus.git","ssh_url":"git@github.com:cstyan/prometheus.git","clone_url":"https://github.com/cstyan/prometheus.git","svn_url":"https://github.com/cstyan/prometheus","homepage":"https://prometheus.io/","size":47351,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"ab3cdb950020f21b0fabb0ce8aa4ebfe4ee06637","user":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":6838921,"node_id":"MDEwOlJlcG9zaXRvcnk2ODM4OTIx","name":"prometheus","full_name":"prometheus/prometheus","private":false,"owner":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prometheus/prometheus","description":"The Prometheus monitoring system and time series database.","fork":false,"url":"https://api.github.com/repos/prometheus/prometheus","forks_url":"https://api.github.com/repos/prometheus/prometheus/forks","keys_url":"https://api.github.com/repos/prometheus/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/prometheus/teams","hooks_url":"https://api.github.com/repos/prometheus/prometheus/hooks","issue_events_url":"https://api.github.com/repos/prometheus/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/prometheus/events","assignees_url":"https://api.github.com/repos/prometheus/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/prometheus/tags","blobs_url":"https://api.github.com/repos/prometheus/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/prometheus/languages","stargazers_url":"https://api.github.com/repos/prometheus/prometheus/stargazers","contributors_url":"https://api.github.com/repos/prometheus/prometheus/contributors","subscribers_url":"https://api.github.com/repos/prometheus/prometheus/subscribers","subscription_url":"https://api.github.com/repos/prometheus/prometheus/subscription","commits_url":"https://api.github.com/repos/prometheus/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/prometheus/merges","archive_url":"https://api.github.com/repos/prometheus/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/prometheus/downloads","issues_url":"https://api.github.com/repos/prometheus/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/prometheus/deployments","created_at":"2012-11-24T11:14:12Z","updated_at":"2018-10-25T19:11:37Z","pushed_at":"2018-10-25T17:59:21Z","git_url":"git://github.com/prometheus/prometheus.git","ssh_url":"git@github.com:prometheus/prometheus.git","clone_url":"https://github.com/prometheus/prometheus.git","svn_url":"https://github.com/prometheus/prometheus","homepage":"https://prometheus.io/","size":43701,"stargazers_count":19719,"watchers_count":19719,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2654,"mirror_url":null,"archived":false,"open_issues_count":319,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2654,"open_issues":319,"watchers":19719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4588"},"html":{"href":"https://github.com/prometheus/prometheus/pull/4588"},"issue":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/4588"},"comments":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/4588/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4588/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4588/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/prometheus/statuses/2de4cab8d7c9091545f053b6afcbbba7d03f7b28"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tomwilkie"}}