{"action":"created","comment":{"url":"https://api.github.com/repos/WroMaciej/DP/pulls/comments/182196512","pull_request_review_id":112953417,"id":182196512,"diff_hunk":"@@ -6,28 +6,34 @@\n \n public class IdealProcess {\n \n-    public static Fluid isoThermal(Fluid fluid, Parameter endParameter){\n-        if (fluid.getFluidType() == FluidType.AIR) return FluidFactory.createAir(fluid.getTemperature(), endParameter, fluid.getAbsolutePressure());\n-        return FluidFactory.createFluid(fluid.getFluidName(), fluid.getTemperature(), endParameter);\n+    private FluidFactory fluidFactory;\n+\n+    public IdealProcess(FluidFactory fluidFactory) {\n+        this.fluidFactory = fluidFactory;\n+    }\n+\n+    public Fluid isothermal(Fluid fluid, Parameter endParameter){\n+        if (fluid.getFluidType() == FluidType.AIR) return fluidFactory.createAir(fluid.getTemperature(), endParameter, fluid.getAbsolutePressure());\n+        return fluidFactory.createFluid(fluid.getFluidName(), fluid.getTemperature(), endParameter);\n     }\n \n-    public static Fluid isoBaric(Fluid fluid, Parameter endParameter){\n-        if (fluid.getFluidType() == FluidType.AIR) return FluidFactory.createAir(fluid.getAbsolutePressure(), endParameter, fluid.getAbsolutePressure());\n-        return FluidFactory.createFluid(fluid.getFluidName(), fluid.getAbsolutePressure(), endParameter);\n+    public Fluid isobaric(Fluid fluid, Parameter endParameter){\n+        if (fluid.getFluidType() == FluidType.AIR) return fluidFactory.createAir(fluid.getAbsolutePressure(), endParameter, fluid.getAbsolutePressure());\n+        return fluidFactory.createFluid(fluid.getFluidName(), fluid.getAbsolutePressure(), endParameter);\n     }\n \n-    public static Fluid isoChoric(Fluid fluid, Parameter endParameter){\n-        if (fluid.getFluidType() == FluidType.AIR) return FluidFactory.createAir(fluid.getSpecificVolume(), endParameter, fluid.getAbsolutePressure());\n-        return FluidFactory.createFluid(fluid.getFluidName(), fluid.getSpecificVolume(), endParameter);\n+    public Fluid isochoric(Fluid fluid, Parameter endParameter){\n+        if (fluid.getFluidType() == FluidType.AIR) return fluidFactory.createAir(fluid.getSpecificVolume(), endParameter, fluid.getAbsolutePressure());\n+        return fluidFactory.createFluid(fluid.getFluidName(), fluid.getSpecificVolume(), endParameter);","path":"src/main/java/wromaciej/hvac_sim/thermo/matter/fluids/service/IdealProcess.java","position":null,"original_position":31,"commit_id":"44fe231008f81e8b312acf0314976b86b62bea1c","original_commit_id":"44fe231008f81e8b312acf0314976b86b62bea1c","user":{"login":"matwojcik","id":5006875,"avatar_url":"https://avatars1.githubusercontent.com/u/5006875?v=4","gravatar_id":"","url":"https://api.github.com/users/matwojcik","html_url":"https://github.com/matwojcik","followers_url":"https://api.github.com/users/matwojcik/followers","following_url":"https://api.github.com/users/matwojcik/following{/other_user}","gists_url":"https://api.github.com/users/matwojcik/gists{/gist_id}","starred_url":"https://api.github.com/users/matwojcik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matwojcik/subscriptions","organizations_url":"https://api.github.com/users/matwojcik/orgs","repos_url":"https://api.github.com/users/matwojcik/repos","events_url":"https://api.github.com/users/matwojcik/events{/privacy}","received_events_url":"https://api.github.com/users/matwojcik/received_events","type":"User","site_admin":false},"body":"else","created_at":"2018-04-17T19:18:58Z","updated_at":"2018-04-17T19:35:20Z","html_url":"https://github.com/WroMaciej/DP/pull/1#discussion_r182196512","pull_request_url":"https://api.github.com/repos/WroMaciej/DP/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/WroMaciej/DP/pulls/comments/182196512"},"html":{"href":"https://github.com/WroMaciej/DP/pull/1#discussion_r182196512"},"pull_request":{"href":"https://api.github.com/repos/WroMaciej/DP/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/WroMaciej/DP/pulls/1","id":181005560,"html_url":"https://github.com/WroMaciej/DP/pull/1","diff_url":"https://github.com/WroMaciej/DP/pull/1.diff","patch_url":"https://github.com/WroMaciej/DP/pull/1.patch","issue_url":"https://api.github.com/repos/WroMaciej/DP/issues/1","number":1,"state":"open","locked":false,"title":"Adding j science to handle unit systems","user":{"login":"WroMaciej","id":34899098,"avatar_url":"https://avatars3.githubusercontent.com/u/34899098?v=4","gravatar_id":"","url":"https://api.github.com/users/WroMaciej","html_url":"https://github.com/WroMaciej","followers_url":"https://api.github.com/users/WroMaciej/followers","following_url":"https://api.github.com/users/WroMaciej/following{/other_user}","gists_url":"https://api.github.com/users/WroMaciej/gists{/gist_id}","starred_url":"https://api.github.com/users/WroMaciej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WroMaciej/subscriptions","organizations_url":"https://api.github.com/users/WroMaciej/orgs","repos_url":"https://api.github.com/users/WroMaciej/repos","events_url":"https://api.github.com/users/WroMaciej/events{/privacy}","received_events_url":"https://api.github.com/users/WroMaciej/received_events","type":"User","site_admin":false},"body":"JScience added to a project with few solutions","created_at":"2018-04-11T19:33:35Z","updated_at":"2018-04-17T19:35:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da06416f3696b5b852a22cb819d2fc3e39f675d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WroMaciej/DP/pulls/1/commits","review_comments_url":"https://api.github.com/repos/WroMaciej/DP/pulls/1/comments","review_comment_url":"https://api.github.com/repos/WroMaciej/DP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WroMaciej/DP/issues/1/comments","statuses_url":"https://api.github.com/repos/WroMaciej/DP/statuses/44fe231008f81e8b312acf0314976b86b62bea1c","head":{"label":"WroMaciej:Adding_JScience_to_handle_unit_systems","ref":"Adding_JScience_to_handle_unit_systems","sha":"44fe231008f81e8b312acf0314976b86b62bea1c","user":{"login":"WroMaciej","id":34899098,"avatar_url":"https://avatars3.githubusercontent.com/u/34899098?v=4","gravatar_id":"","url":"https://api.github.com/users/WroMaciej","html_url":"https://github.com/WroMaciej","followers_url":"https://api.github.com/users/WroMaciej/followers","following_url":"https://api.github.com/users/WroMaciej/following{/other_user}","gists_url":"https://api.github.com/users/WroMaciej/gists{/gist_id}","starred_url":"https://api.github.com/users/WroMaciej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WroMaciej/subscriptions","organizations_url":"https://api.github.com/users/WroMaciej/orgs","repos_url":"https://api.github.com/users/WroMaciej/repos","events_url":"https://api.github.com/users/WroMaciej/events{/privacy}","received_events_url":"https://api.github.com/users/WroMaciej/received_events","type":"User","site_admin":false},"repo":{"id":116297317,"name":"DP","full_name":"WroMaciej/DP","owner":{"login":"WroMaciej","id":34899098,"avatar_url":"https://avatars3.githubusercontent.com/u/34899098?v=4","gravatar_id":"","url":"https://api.github.com/users/WroMaciej","html_url":"https://github.com/WroMaciej","followers_url":"https://api.github.com/users/WroMaciej/followers","following_url":"https://api.github.com/users/WroMaciej/following{/other_user}","gists_url":"https://api.github.com/users/WroMaciej/gists{/gist_id}","starred_url":"https://api.github.com/users/WroMaciej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WroMaciej/subscriptions","organizations_url":"https://api.github.com/users/WroMaciej/orgs","repos_url":"https://api.github.com/users/WroMaciej/repos","events_url":"https://api.github.com/users/WroMaciej/events{/privacy}","received_events_url":"https://api.github.com/users/WroMaciej/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WroMaciej/DP","description":"Project of some ideas","fork":false,"url":"https://api.github.com/repos/WroMaciej/DP","forks_url":"https://api.github.com/repos/WroMaciej/DP/forks","keys_url":"https://api.github.com/repos/WroMaciej/DP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WroMaciej/DP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WroMaciej/DP/teams","hooks_url":"https://api.github.com/repos/WroMaciej/DP/hooks","issue_events_url":"https://api.github.com/repos/WroMaciej/DP/issues/events{/number}","events_url":"https://api.github.com/repos/WroMaciej/DP/events","assignees_url":"https://api.github.com/repos/WroMaciej/DP/assignees{/user}","branches_url":"https://api.github.com/repos/WroMaciej/DP/branches{/branch}","tags_url":"https://api.github.com/repos/WroMaciej/DP/tags","blobs_url":"https://api.github.com/repos/WroMaciej/DP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WroMaciej/DP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WroMaciej/DP/git/refs{/sha}","trees_url":"https://api.github.com/repos/WroMaciej/DP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WroMaciej/DP/statuses/{sha}","languages_url":"https://api.github.com/repos/WroMaciej/DP/languages","stargazers_url":"https://api.github.com/repos/WroMaciej/DP/stargazers","contributors_url":"https://api.github.com/repos/WroMaciej/DP/contributors","subscribers_url":"https://api.github.com/repos/WroMaciej/DP/subscribers","subscription_url":"https://api.github.com/repos/WroMaciej/DP/subscription","commits_url":"https://api.github.com/repos/WroMaciej/DP/commits{/sha}","git_commits_url":"https://api.github.com/repos/WroMaciej/DP/git/commits{/sha}","comments_url":"https://api.github.com/repos/WroMaciej/DP/comments{/number}","issue_comment_url":"https://api.github.com/repos/WroMaciej/DP/issues/comments{/number}","contents_url":"https://api.github.com/repos/WroMaciej/DP/contents/{+path}","compare_url":"https://api.github.com/repos/WroMaciej/DP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WroMaciej/DP/merges","archive_url":"https://api.github.com/repos/WroMaciej/DP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WroMaciej/DP/downloads","issues_url":"https://api.github.com/repos/WroMaciej/DP/issues{/number}","pulls_url":"https://api.github.com/repos/WroMaciej/DP/pulls{/number}","milestones_url":"https://api.github.com/repos/WroMaciej/DP/milestones{/number}","notifications_url":"https://api.github.com/repos/WroMaciej/DP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WroMaciej/DP/labels{/name}","releases_url":"https://api.github.com/repos/WroMaciej/DP/releases{/id}","deployments_url":"https://api.github.com/repos/WroMaciej/DP/deployments","created_at":"2018-01-04T19:09:05Z","updated_at":"2018-01-04T19:27:53Z","pushed_at":"2018-04-17T17:17:40Z","git_url":"git://github.com/WroMaciej/DP.git","ssh_url":"git@github.com:WroMaciej/DP.git","clone_url":"https://github.com/WroMaciej/DP.git","svn_url":"https://github.com/WroMaciej/DP","homepage":null,"size":8541,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"WroMaciej:master","ref":"master","sha":"5941f7770cb2a815c248d6f81db536f91bcbfb82","user":{"login":"WroMaciej","id":34899098,"avatar_url":"https://avatars3.githubusercontent.com/u/34899098?v=4","gravatar_id":"","url":"https://api.github.com/users/WroMaciej","html_url":"https://github.com/WroMaciej","followers_url":"https://api.github.com/users/WroMaciej/followers","following_url":"https://api.github.com/users/WroMaciej/following{/other_user}","gists_url":"https://api.github.com/users/WroMaciej/gists{/gist_id}","starred_url":"https://api.github.com/users/WroMaciej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WroMaciej/subscriptions","organizations_url":"https://api.github.com/users/WroMaciej/orgs","repos_url":"https://api.github.com/users/WroMaciej/repos","events_url":"https://api.github.com/users/WroMaciej/events{/privacy}","received_events_url":"https://api.github.com/users/WroMaciej/received_events","type":"User","site_admin":false},"repo":{"id":116297317,"name":"DP","full_name":"WroMaciej/DP","owner":{"login":"WroMaciej","id":34899098,"avatar_url":"https://avatars3.githubusercontent.com/u/34899098?v=4","gravatar_id":"","url":"https://api.github.com/users/WroMaciej","html_url":"https://github.com/WroMaciej","followers_url":"https://api.github.com/users/WroMaciej/followers","following_url":"https://api.github.com/users/WroMaciej/following{/other_user}","gists_url":"https://api.github.com/users/WroMaciej/gists{/gist_id}","starred_url":"https://api.github.com/users/WroMaciej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WroMaciej/subscriptions","organizations_url":"https://api.github.com/users/WroMaciej/orgs","repos_url":"https://api.github.com/users/WroMaciej/repos","events_url":"https://api.github.com/users/WroMaciej/events{/privacy}","received_events_url":"https://api.github.com/users/WroMaciej/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WroMaciej/DP","description":"Project of some ideas","fork":false,"url":"https://api.github.com/repos/WroMaciej/DP","forks_url":"https://api.github.com/repos/WroMaciej/DP/forks","keys_url":"https://api.github.com/repos/WroMaciej/DP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WroMaciej/DP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WroMaciej/DP/teams","hooks_url":"https://api.github.com/repos/WroMaciej/DP/hooks","issue_events_url":"https://api.github.com/repos/WroMaciej/DP/issues/events{/number}","events_url":"https://api.github.com/repos/WroMaciej/DP/events","assignees_url":"https://api.github.com/repos/WroMaciej/DP/assignees{/user}","branches_url":"https://api.github.com/repos/WroMaciej/DP/branches{/branch}","tags_url":"https://api.github.com/repos/WroMaciej/DP/tags","blobs_url":"https://api.github.com/repos/WroMaciej/DP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WroMaciej/DP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WroMaciej/DP/git/refs{/sha}","trees_url":"https://api.github.com/repos/WroMaciej/DP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WroMaciej/DP/statuses/{sha}","languages_url":"https://api.github.com/repos/WroMaciej/DP/languages","stargazers_url":"https://api.github.com/repos/WroMaciej/DP/stargazers","contributors_url":"https://api.github.com/repos/WroMaciej/DP/contributors","subscribers_url":"https://api.github.com/repos/WroMaciej/DP/subscribers","subscription_url":"https://api.github.com/repos/WroMaciej/DP/subscription","commits_url":"https://api.github.com/repos/WroMaciej/DP/commits{/sha}","git_commits_url":"https://api.github.com/repos/WroMaciej/DP/git/commits{/sha}","comments_url":"https://api.github.com/repos/WroMaciej/DP/comments{/number}","issue_comment_url":"https://api.github.com/repos/WroMaciej/DP/issues/comments{/number}","contents_url":"https://api.github.com/repos/WroMaciej/DP/contents/{+path}","compare_url":"https://api.github.com/repos/WroMaciej/DP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WroMaciej/DP/merges","archive_url":"https://api.github.com/repos/WroMaciej/DP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WroMaciej/DP/downloads","issues_url":"https://api.github.com/repos/WroMaciej/DP/issues{/number}","pulls_url":"https://api.github.com/repos/WroMaciej/DP/pulls{/number}","milestones_url":"https://api.github.com/repos/WroMaciej/DP/milestones{/number}","notifications_url":"https://api.github.com/repos/WroMaciej/DP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WroMaciej/DP/labels{/name}","releases_url":"https://api.github.com/repos/WroMaciej/DP/releases{/id}","deployments_url":"https://api.github.com/repos/WroMaciej/DP/deployments","created_at":"2018-01-04T19:09:05Z","updated_at":"2018-01-04T19:27:53Z","pushed_at":"2018-04-17T17:17:40Z","git_url":"git://github.com/WroMaciej/DP.git","ssh_url":"git@github.com:WroMaciej/DP.git","clone_url":"https://github.com/WroMaciej/DP.git","svn_url":"https://github.com/WroMaciej/DP","homepage":null,"size":8541,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WroMaciej/DP/pulls/1"},"html":{"href":"https://github.com/WroMaciej/DP/pull/1"},"issue":{"href":"https://api.github.com/repos/WroMaciej/DP/issues/1"},"comments":{"href":"https://api.github.com/repos/WroMaciej/DP/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/WroMaciej/DP/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/WroMaciej/DP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WroMaciej/DP/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/WroMaciej/DP/statuses/44fe231008f81e8b312acf0314976b86b62bea1c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"matwojcik"}}