{"action":"opened","issue":{"url":"https://api.github.com/repos/calagator/calagator/issues/553","repository_url":"https://api.github.com/repos/calagator/calagator","labels_url":"https://api.github.com/repos/calagator/calagator/issues/553/labels{/name}","comments_url":"https://api.github.com/repos/calagator/calagator/issues/553/comments","events_url":"https://api.github.com/repos/calagator/calagator/issues/553/events","html_url":"https://github.com/calagator/calagator/issues/553","id":375759165,"node_id":"MDU6SXNzdWUzNzU3NTkxNjU=","number":553,"title":"Update Capybara javascript driver","user":{"login":"aeschright","id":16411,"node_id":"MDQ6VXNlcjE2NDEx","avatar_url":"https://avatars0.githubusercontent.com/u/16411?v=4","gravatar_id":"","url":"https://api.github.com/users/aeschright","html_url":"https://github.com/aeschright","followers_url":"https://api.github.com/users/aeschright/followers","following_url":"https://api.github.com/users/aeschright/following{/other_user}","gists_url":"https://api.github.com/users/aeschright/gists{/gist_id}","starred_url":"https://api.github.com/users/aeschright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeschright/subscriptions","organizations_url":"https://api.github.com/users/aeschright/orgs","repos_url":"https://api.github.com/users/aeschright/repos","events_url":"https://api.github.com/users/aeschright/events{/privacy}","received_events_url":"https://api.github.com/users/aeschright/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-31T01:19:37Z","updated_at":"2018-10-31T01:19:37Z","closed_at":null,"author_association":"MEMBER","body":"On running the tests locally I found I was getting a number of errors:\r\n``` \r\n1) JSONP API results User requests events.json with a JSONP callback specified\r\n     Got 0 failures and 2 other errors:`\r\n\r\n     1.1) Failure/Error: visit \"/events.json?callback=myFunction\"`\r\n          \r\n          Cliver::Dependency::NotFound:\r\n            Could not find an executable [\"phantomjs\"] on your path.\r\n          # ./spec/features/jsonp_output_spec.rb:6:in `block (2 levels) in <top (required)>'\r\n          # ./spec/spec_helper.rb:135:in `block (2 levels) in <top (required)>'\r\n```\r\nHere's spec_helper.rb:\r\n\r\n```\r\n  require 'capybara/poltergeist'\r\n  Capybara.register_driver :poltergeist do |app|\r\n    Capybara::Poltergeist::Driver.new(app, timeout: 90)\r\n  end\r\n  Capybara.javascript_driver = :poltergeist\r\n```\r\n\r\nSo I went to find out what I should be installing, since it's been a while. According to this, PhantomJS is severely deprecated: https://github.com/teamcapybara/capybara#poltergeist\r\n\r\nI'm going to switch it over to Selenium unless someone has a strong preference otherwise.\r\n@reidab @shawnacscott @jc00ke \r\n"}}
{"actor":{"display_login":"aeschright"}}