{"action":"created","issue":{"url":"https://api.github.com/repos/reactor/reactor-core/issues/1390","repository_url":"https://api.github.com/repos/reactor/reactor-core","labels_url":"https://api.github.com/repos/reactor/reactor-core/issues/1390/labels{/name}","comments_url":"https://api.github.com/repos/reactor/reactor-core/issues/1390/comments","events_url":"https://api.github.com/repos/reactor/reactor-core/issues/1390/events","html_url":"https://github.com/reactor/reactor-core/pull/1390","id":371605958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDE1OTky","number":1390,"title":"Convert Marbles to SVG and rework diagrams","user":{"login":"simonbasle","id":6986166,"node_id":"MDQ6VXNlcjY5ODYxNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/6986166?v=4","gravatar_id":"","url":"https://api.github.com/users/simonbasle","html_url":"https://github.com/simonbasle","followers_url":"https://api.github.com/users/simonbasle/followers","following_url":"https://api.github.com/users/simonbasle/following{/other_user}","gists_url":"https://api.github.com/users/simonbasle/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbasle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbasle/subscriptions","organizations_url":"https://api.github.com/users/simonbasle/orgs","repos_url":"https://api.github.com/users/simonbasle/repos","events_url":"https://api.github.com/users/simonbasle/events{/privacy}","received_events_url":"https://api.github.com/users/simonbasle/received_events","type":"User","site_admin":false},"labels":[{"id":488686374,"node_id":"MDU6TGFiZWw0ODg2ODYzNzQ=","url":"https://api.github.com/repos/reactor/reactor-core/labels/documentation","name":"documentation","color":"d4c5f9","default":false},{"id":611246508,"node_id":"MDU6TGFiZWw2MTEyNDY1MDg=","url":"https://api.github.com/repos/reactor/reactor-core/labels/need-investigation","name":"need-investigation","color":"ffc844","default":false},{"id":613870295,"node_id":"MDU6TGFiZWw2MTM4NzAyOTU=","url":"https://api.github.com/repos/reactor/reactor-core/labels/wide-change","name":"wide-change","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/reactor/reactor-core/milestones/41","html_url":"https://github.com/reactor/reactor-core/milestone/41","labels_url":"https://api.github.com/repos/reactor/reactor-core/milestones/41/labels","id":3731931,"node_id":"MDk6TWlsZXN0b25lMzczMTkzMQ==","number":41,"title":"3.2.2.RELEASE","description":"","creator":{"login":"smaldini","id":76718,"node_id":"MDQ6VXNlcjc2NzE4","avatar_url":"https://avatars2.githubusercontent.com/u/76718?v=4","gravatar_id":"","url":"https://api.github.com/users/smaldini","html_url":"https://github.com/smaldini","followers_url":"https://api.github.com/users/smaldini/followers","following_url":"https://api.github.com/users/smaldini/following{/other_user}","gists_url":"https://api.github.com/users/smaldini/gists{/gist_id}","starred_url":"https://api.github.com/users/smaldini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaldini/subscriptions","organizations_url":"https://api.github.com/users/smaldini/orgs","repos_url":"https://api.github.com/users/smaldini/repos","events_url":"https://api.github.com/users/smaldini/events{/privacy}","received_events_url":"https://api.github.com/users/smaldini/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2018-10-11T23:30:46Z","updated_at":"2018-10-19T21:04:35Z","due_on":"2018-10-26T07:00:00Z","closed_at":null},"comments":4,"created_at":"2018-10-18T16:11:45Z","updated_at":"2018-10-22T15:20:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/reactor/reactor-core/pulls/1390","html_url":"https://github.com/reactor/reactor-core/pull/1390","diff_url":"https://github.com/reactor/reactor-core/pull/1390.diff","patch_url":"https://github.com/reactor/reactor-core/pull/1390.patch"},"body":"Source for choice of fonts: http://www.ars-informatica.ca/article.php?article=59\n\nChanges:\n\n[doc] Rework marble diagrams into SVG\nThis commit is a large rework of the marble diagrams:\n  - started from the omnigraffle original exported to SVG\n  - large rework of diagrams with clearer and more consistent semantics\n  - large naming rework to be more consistent with operator names\n  - creation of missing marble diagrams\n  - javadoc modifications to point to new diagram names\n  - main javadocs no longer point to URLs but expect an embedded\n  doc-files set up\n  - SVG use Tahoma/Nimbus and Lucida Console/Courier New font families\n\n[doc] Add \"Contributing to SVG\" README and task to copy SVG to doc-files\n\nSaid task is run as part of processResources, which gives a chance that new\nusers checking out the repo will see the quick documentation with diagrams\nafter first building the project."},"comment":{"url":"https://api.github.com/repos/reactor/reactor-core/issues/comments/431866677","html_url":"https://github.com/reactor/reactor-core/pull/1390#issuecomment-431866677","issue_url":"https://api.github.com/repos/reactor/reactor-core/issues/1390","id":431866677,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTg2NjY3Nw==","user":{"login":"thekalinga","id":452518,"node_id":"MDQ6VXNlcjQ1MjUxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/452518?v=4","gravatar_id":"","url":"https://api.github.com/users/thekalinga","html_url":"https://github.com/thekalinga","followers_url":"https://api.github.com/users/thekalinga/followers","following_url":"https://api.github.com/users/thekalinga/following{/other_user}","gists_url":"https://api.github.com/users/thekalinga/gists{/gist_id}","starred_url":"https://api.github.com/users/thekalinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thekalinga/subscriptions","organizations_url":"https://api.github.com/users/thekalinga/orgs","repos_url":"https://api.github.com/users/thekalinga/repos","events_url":"https://api.github.com/users/thekalinga/events{/privacy}","received_events_url":"https://api.github.com/users/thekalinga/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T15:20:59Z","updated_at":"2018-10-22T15:20:59Z","author_association":"NONE","body":"@simonbasle This is not an issue per se. But thought it would help if you too know this. In some marble diagrams (`create` & `push` as far as I remember), svgs have java code that uses [Fira Code](https://github.com/tonsky/FiraCode) font that makes the code look much readable\r\n\r\nThis is the only place where I used font other than `IBM Plex Sans`. So incase you have not updated there aswell, please do so"}}
{"actor":{"display_login":"thekalinga"}}