{"action":"created","comment":{"url":"https://api.github.com/repos/openebs/node-disk-manager/pulls/comments/203763122","pull_request_review_id":138716963,"id":203763122,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzc2MzEyMg==","diff_hunk":"@@ -143,9 +146,23 @@ func (device *UdevDevice) GetDevLinks() map[string][]string {\n \tbyIdLink := make([]string, 0)\n \tbyPathLink := make([]string, 0)\n \tfor _, link := range strings.Split(device.GetPropertyValue(UDEV_DEVLINKS), \" \") {\n+\t\t/*\n+\t\t\tdevlink is like - /dev/disk/by-id/scsi-0Google_PersistentDisk_demo-disk\n+\t\t\tparts = [\"\", \"dev\", \"disk\", \"by-id\", \"scsi-0Google_PersistentDisk_demo-disk\"]\n+\t\t\tparts[4] containis link index like model or wwn or sysPath (wwn-0x5000c5009e3a8d2b) (ata-ST500LM021-1KJ152_W6HFGR)","path":"pkg/udev/common.go","position":null,"original_position":28,"commit_id":"f35e5d1420887abb8245b0e675eaf3e3fc172b6a","original_commit_id":"12a279079bdffa838a185349cd8a8ca0fda77583","user":{"login":"shovanmaity","id":14263515,"node_id":"MDQ6VXNlcjE0MjYzNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/14263515?v=4","gravatar_id":"","url":"https://api.github.com/users/shovanmaity","html_url":"https://github.com/shovanmaity","followers_url":"https://api.github.com/users/shovanmaity/followers","following_url":"https://api.github.com/users/shovanmaity/following{/other_user}","gists_url":"https://api.github.com/users/shovanmaity/gists{/gist_id}","starred_url":"https://api.github.com/users/shovanmaity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shovanmaity/subscriptions","organizations_url":"https://api.github.com/users/shovanmaity/orgs","repos_url":"https://api.github.com/users/shovanmaity/repos","events_url":"https://api.github.com/users/shovanmaity/events{/privacy}","received_events_url":"https://api.github.com/users/shovanmaity/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2018-07-19T15:05:34Z","updated_at":"2018-07-19T15:05:35Z","html_url":"https://github.com/openebs/node-disk-manager/pull/63#discussion_r203763122","pull_request_url":"https://api.github.com/repos/openebs/node-disk-manager/pulls/63","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openebs/node-disk-manager/pulls/comments/203763122"},"html":{"href":"https://github.com/openebs/node-disk-manager/pull/63#discussion_r203763122"},"pull_request":{"href":"https://api.github.com/repos/openebs/node-disk-manager/pulls/63"}},"in_reply_to_id":203762181},"pull_request":{"url":"https://api.github.com/repos/openebs/node-disk-manager/pulls/63","id":202300273,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzAwMjcz","html_url":"https://github.com/openebs/node-disk-manager/pull/63","diff_url":"https://github.com/openebs/node-disk-manager/pull/63.diff","patch_url":"https://github.com/openebs/node-disk-manager/pull/63.patch","issue_url":"https://api.github.com/repos/openebs/node-disk-manager/issues/63","number":63,"state":"open","locked":false,"title":"Order by-id links in disk cr","user":{"login":"shovanmaity","id":14263515,"node_id":"MDQ6VXNlcjE0MjYzNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/14263515?v=4","gravatar_id":"","url":"https://api.github.com/users/shovanmaity","html_url":"https://github.com/shovanmaity","followers_url":"https://api.github.com/users/shovanmaity/followers","following_url":"https://api.github.com/users/shovanmaity/following{/other_user}","gists_url":"https://api.github.com/users/shovanmaity/gists{/gist_id}","starred_url":"https://api.github.com/users/shovanmaity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shovanmaity/subscriptions","organizations_url":"https://api.github.com/users/shovanmaity/orgs","repos_url":"https://api.github.com/users/shovanmaity/repos","events_url":"https://api.github.com/users/shovanmaity/events{/privacy}","received_events_url":"https://api.github.com/users/shovanmaity/received_events","type":"User","site_admin":false},"body":"by-id links were not in order in disk cr\r\nThis PR arrange them below order-\r\n```\r\n1. by-id link which contains serial no and bus\r\n2. others links(if present)\r\n```\r\nDevLinks section of Disk CR\r\n```\r\n  Devlinks:\r\n    Kind:  by-id\r\n    Links:\r\n      /dev/disk/by-id/scsi-0Google_PersistentDisk_ganesh-disk4\r\n      /dev/disk/by-id/google-ganesh-disk4\r\n    Kind:  by-path\r\n    Links:\r\n      /dev/disk/by-path/virtio-pci-0000:00:03.0-scsi-0:0:6:0\r\n```","created_at":"2018-07-18T15:51:33Z","updated_at":"2018-07-19T15:05:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"615352db1d1720246c0e439ac46c09635a346590","assignee":{"login":"shovanmaity","id":14263515,"node_id":"MDQ6VXNlcjE0MjYzNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/14263515?v=4","gravatar_id":"","url":"https://api.github.com/users/shovanmaity","html_url":"https://github.com/shovanmaity","followers_url":"https://api.github.com/users/shovanmaity/followers","following_url":"https://api.github.com/users/shovanmaity/following{/other_user}","gists_url":"https://api.github.com/users/shovanmaity/gists{/gist_id}","starred_url":"https://api.github.com/users/shovanmaity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shovanmaity/subscriptions","organizations_url":"https://api.github.com/users/shovanmaity/orgs","repos_url":"https://api.github.com/users/shovanmaity/repos","events_url":"https://api.github.com/users/shovanmaity/events{/privacy}","received_events_url":"https://api.github.com/users/shovanmaity/received_events","type":"User","site_admin":false},"assignees":[{"login":"shovanmaity","id":14263515,"node_id":"MDQ6VXNlcjE0MjYzNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/14263515?v=4","gravatar_id":"","url":"https://api.github.com/users/shovanmaity","html_url":"https://github.com/shovanmaity","followers_url":"https://api.github.com/users/shovanmaity/followers","following_url":"https://api.github.com/users/shovanmaity/following{/other_user}","gists_url":"https://api.github.com/users/shovanmaity/gists{/gist_id}","starred_url":"https://api.github.com/users/shovanmaity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shovanmaity/subscriptions","organizations_url":"https://api.github.com/users/shovanmaity/orgs","repos_url":"https://api.github.com/users/shovanmaity/repos","events_url":"https://api.github.com/users/shovanmaity/events{/privacy}","received_events_url":"https://api.github.com/users/shovanmaity/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kmova","id":12488783,"node_id":"MDQ6VXNlcjEyNDg4Nzgz","avatar_url":"https://avatars2.githubusercontent.com/u/12488783?v=4","gravatar_id":"","url":"https://api.github.com/users/kmova","html_url":"https://github.com/kmova","followers_url":"https://api.github.com/users/kmova/followers","following_url":"https://api.github.com/users/kmova/following{/other_user}","gists_url":"https://api.github.com/users/kmova/gists{/gist_id}","starred_url":"https://api.github.com/users/kmova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmova/subscriptions","organizations_url":"https://api.github.com/users/kmova/orgs","repos_url":"https://api.github.com/users/kmova/repos","events_url":"https://api.github.com/users/kmova/events{/privacy}","received_events_url":"https://api.github.com/users/kmova/received_events","type":"User","site_admin":false},{"login":"sonasingh46","id":24835120,"node_id":"MDQ6VXNlcjI0ODM1MTIw","avatar_url":"https://avatars3.githubusercontent.com/u/24835120?v=4","gravatar_id":"","url":"https://api.github.com/users/sonasingh46","html_url":"https://github.com/sonasingh46","followers_url":"https://api.github.com/users/sonasingh46/followers","following_url":"https://api.github.com/users/sonasingh46/following{/other_user}","gists_url":"https://api.github.com/users/sonasingh46/gists{/gist_id}","starred_url":"https://api.github.com/users/sonasingh46/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonasingh46/subscriptions","organizations_url":"https://api.github.com/users/sonasingh46/orgs","repos_url":"https://api.github.com/users/sonasingh46/repos","events_url":"https://api.github.com/users/sonasingh46/events{/privacy}","received_events_url":"https://api.github.com/users/sonasingh46/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openebs/node-disk-manager/pulls/63/commits","review_comments_url":"https://api.github.com/repos/openebs/node-disk-manager/pulls/63/comments","review_comment_url":"https://api.github.com/repos/openebs/node-disk-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openebs/node-disk-manager/issues/63/comments","statuses_url":"https://api.github.com/repos/openebs/node-disk-manager/statuses/f35e5d1420887abb8245b0e675eaf3e3fc172b6a","head":{"label":"shovanmaity:re-order-by-id-link","ref":"re-order-by-id-link","sha":"f35e5d1420887abb8245b0e675eaf3e3fc172b6a","user":{"login":"shovanmaity","id":14263515,"node_id":"MDQ6VXNlcjE0MjYzNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/14263515?v=4","gravatar_id":"","url":"https://api.github.com/users/shovanmaity","html_url":"https://github.com/shovanmaity","followers_url":"https://api.github.com/users/shovanmaity/followers","following_url":"https://api.github.com/users/shovanmaity/following{/other_user}","gists_url":"https://api.github.com/users/shovanmaity/gists{/gist_id}","starred_url":"https://api.github.com/users/shovanmaity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shovanmaity/subscriptions","organizations_url":"https://api.github.com/users/shovanmaity/orgs","repos_url":"https://api.github.com/users/shovanmaity/repos","events_url":"https://api.github.com/users/shovanmaity/events{/privacy}","received_events_url":"https://api.github.com/users/shovanmaity/received_events","type":"User","site_admin":false},"repo":{"id":125358154,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzNTgxNTQ=","name":"node-disk-manager","full_name":"shovanmaity/node-disk-manager","owner":{"login":"shovanmaity","id":14263515,"node_id":"MDQ6VXNlcjE0MjYzNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/14263515?v=4","gravatar_id":"","url":"https://api.github.com/users/shovanmaity","html_url":"https://github.com/shovanmaity","followers_url":"https://api.github.com/users/shovanmaity/followers","following_url":"https://api.github.com/users/shovanmaity/following{/other_user}","gists_url":"https://api.github.com/users/shovanmaity/gists{/gist_id}","starred_url":"https://api.github.com/users/shovanmaity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shovanmaity/subscriptions","organizations_url":"https://api.github.com/users/shovanmaity/orgs","repos_url":"https://api.github.com/users/shovanmaity/repos","events_url":"https://api.github.com/users/shovanmaity/events{/privacy}","received_events_url":"https://api.github.com/users/shovanmaity/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shovanmaity/node-disk-manager","description":null,"fork":true,"url":"https://api.github.com/repos/shovanmaity/node-disk-manager","forks_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/forks","keys_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/teams","hooks_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/hooks","issue_events_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/issues/events{/number}","events_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/events","assignees_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/assignees{/user}","branches_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/branches{/branch}","tags_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/tags","blobs_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/languages","stargazers_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/stargazers","contributors_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/contributors","subscribers_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/subscribers","subscription_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/subscription","commits_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/contents/{+path}","compare_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/merges","archive_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/downloads","issues_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/issues{/number}","pulls_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/labels{/name}","releases_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/releases{/id}","deployments_url":"https://api.github.com/repos/shovanmaity/node-disk-manager/deployments","created_at":"2018-03-15T11:36:35Z","updated_at":"2018-07-19T11:40:19Z","pushed_at":"2018-07-19T15:05:21Z","git_url":"git://github.com/shovanmaity/node-disk-manager.git","ssh_url":"git@github.com:shovanmaity/node-disk-manager.git","clone_url":"https://github.com/shovanmaity/node-disk-manager.git","svn_url":"https://github.com/shovanmaity/node-disk-manager","homepage":null,"size":50319,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openebs:master","ref":"master","sha":"ece7f5d7f5f56346a47b4c8189e2174854f5bf61","user":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"repo":{"id":124062056,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwNjIwNTY=","name":"node-disk-manager","full_name":"openebs/node-disk-manager","owner":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openebs/node-disk-manager","description":"node-disk-manager(ndm) runs as a DaemonSet in Kubernetes and helps with Disk Inventory Management","fork":false,"url":"https://api.github.com/repos/openebs/node-disk-manager","forks_url":"https://api.github.com/repos/openebs/node-disk-manager/forks","keys_url":"https://api.github.com/repos/openebs/node-disk-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openebs/node-disk-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openebs/node-disk-manager/teams","hooks_url":"https://api.github.com/repos/openebs/node-disk-manager/hooks","issue_events_url":"https://api.github.com/repos/openebs/node-disk-manager/issues/events{/number}","events_url":"https://api.github.com/repos/openebs/node-disk-manager/events","assignees_url":"https://api.github.com/repos/openebs/node-disk-manager/assignees{/user}","branches_url":"https://api.github.com/repos/openebs/node-disk-manager/branches{/branch}","tags_url":"https://api.github.com/repos/openebs/node-disk-manager/tags","blobs_url":"https://api.github.com/repos/openebs/node-disk-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openebs/node-disk-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openebs/node-disk-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/openebs/node-disk-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openebs/node-disk-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/openebs/node-disk-manager/languages","stargazers_url":"https://api.github.com/repos/openebs/node-disk-manager/stargazers","contributors_url":"https://api.github.com/repos/openebs/node-disk-manager/contributors","subscribers_url":"https://api.github.com/repos/openebs/node-disk-manager/subscribers","subscription_url":"https://api.github.com/repos/openebs/node-disk-manager/subscription","commits_url":"https://api.github.com/repos/openebs/node-disk-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/openebs/node-disk-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/openebs/node-disk-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/openebs/node-disk-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/openebs/node-disk-manager/contents/{+path}","compare_url":"https://api.github.com/repos/openebs/node-disk-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openebs/node-disk-manager/merges","archive_url":"https://api.github.com/repos/openebs/node-disk-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openebs/node-disk-manager/downloads","issues_url":"https://api.github.com/repos/openebs/node-disk-manager/issues{/number}","pulls_url":"https://api.github.com/repos/openebs/node-disk-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/openebs/node-disk-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/openebs/node-disk-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openebs/node-disk-manager/labels{/name}","releases_url":"https://api.github.com/repos/openebs/node-disk-manager/releases{/id}","deployments_url":"https://api.github.com/repos/openebs/node-disk-manager/deployments","created_at":"2018-03-06T10:31:19Z","updated_at":"2018-07-16T12:58:32Z","pushed_at":"2018-07-19T15:05:23Z","git_url":"git://github.com/openebs/node-disk-manager.git","ssh_url":"git@github.com:openebs/node-disk-manager.git","clone_url":"https://github.com/openebs/node-disk-manager.git","svn_url":"https://github.com/openebs/node-disk-manager","homepage":"","size":27110,"stargazers_count":37,"watchers_count":37,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":21,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openebs/node-disk-manager/pulls/63"},"html":{"href":"https://github.com/openebs/node-disk-manager/pull/63"},"issue":{"href":"https://api.github.com/repos/openebs/node-disk-manager/issues/63"},"comments":{"href":"https://api.github.com/repos/openebs/node-disk-manager/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/openebs/node-disk-manager/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/openebs/node-disk-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openebs/node-disk-manager/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/openebs/node-disk-manager/statuses/f35e5d1420887abb8245b0e675eaf3e3fc172b6a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"shovanmaity"}}