{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-CIDA/stig/pulls/comments/184674044","pull_request_review_id":115920457,"id":184674044,"diff_hunk":"@@ -13,6 +13,15 @@ sysctl cookbook version >= 1.0.0\n -- [isuftin@usgs.gov] - Added boolean flag to sysctl parameters to ignore errors (defaults to true)\n -- [isuftin@usgs.gov] - Switched Changelog format\n -- [isuftin@usgs.gov] - Fixed styling for Rubocop 0.55.0\n+### Fixed\n+-- [cpoma@mitre.org] - Bugfix in stig/recipes/mail_transfer_agent.rb to use platform_family versus platform\n+-- [cpoma@mitre.org] - Bugfix in stig/attributes/default.rb - Errors out and sshd dies (bricking machine) on RH 7 \n+when FIPS Mode is enabled. Non-FIPS compliant MACs were specified. FIPS MODE is required to be enabled - RHEL-07-021350 - CCI-002476\n+Old Line: default['stig']['sshd_config']['macs'] = 'hmac-md5,hmac-sha1,hmac-ripemd160,hmac-sha1-96,hmac-md5-96'\n+Replaced with: default['stig']['sshd_config']['macs'] = 'hmac-sha2-512,hmac-sha2-256'","path":"CHANGELOG.md","position":9,"original_position":9,"commit_id":"e74c22bf6e426290a2f1711597e510050102dda5","original_commit_id":"e74c22bf6e426290a2f1711597e510050102dda5","user":{"login":"cpoma","id":34897373,"avatar_url":"https://avatars1.githubusercontent.com/u/34897373?v=4","gravatar_id":"","url":"https://api.github.com/users/cpoma","html_url":"https://github.com/cpoma","followers_url":"https://api.github.com/users/cpoma/followers","following_url":"https://api.github.com/users/cpoma/following{/other_user}","gists_url":"https://api.github.com/users/cpoma/gists{/gist_id}","starred_url":"https://api.github.com/users/cpoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpoma/subscriptions","organizations_url":"https://api.github.com/users/cpoma/orgs","repos_url":"https://api.github.com/users/cpoma/repos","events_url":"https://api.github.com/users/cpoma/events{/privacy}","received_events_url":"https://api.github.com/users/cpoma/received_events","type":"User","site_admin":false},"body":"@isuftin Yes, not a problem. I'll take care of the amended commit shortly\r\n","created_at":"2018-04-27T12:35:20Z","updated_at":"2018-04-27T12:35:20Z","html_url":"https://github.com/USGS-CIDA/stig/pull/118#discussion_r184674044","pull_request_url":"https://api.github.com/repos/USGS-CIDA/stig/pulls/118","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/USGS-CIDA/stig/pulls/comments/184674044"},"html":{"href":"https://github.com/USGS-CIDA/stig/pull/118#discussion_r184674044"},"pull_request":{"href":"https://api.github.com/repos/USGS-CIDA/stig/pulls/118"}},"in_reply_to_id":184507664},"pull_request":{"url":"https://api.github.com/repos/USGS-CIDA/stig/pulls/118","id":184422473,"html_url":"https://github.com/USGS-CIDA/stig/pull/118","diff_url":"https://github.com/USGS-CIDA/stig/pull/118.diff","patch_url":"https://github.com/USGS-CIDA/stig/pull/118.patch","issue_url":"https://api.github.com/repos/USGS-CIDA/stig/issues/118","number":118,"state":"open","locked":false,"title":"SSHD FIPS Mode MACs Fix","user":{"login":"cpoma","id":34897373,"avatar_url":"https://avatars1.githubusercontent.com/u/34897373?v=4","gravatar_id":"","url":"https://api.github.com/users/cpoma","html_url":"https://github.com/cpoma","followers_url":"https://api.github.com/users/cpoma/followers","following_url":"https://api.github.com/users/cpoma/following{/other_user}","gists_url":"https://api.github.com/users/cpoma/gists{/gist_id}","starred_url":"https://api.github.com/users/cpoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpoma/subscriptions","organizations_url":"https://api.github.com/users/cpoma/orgs","repos_url":"https://api.github.com/users/cpoma/repos","events_url":"https://api.github.com/users/cpoma/events{/privacy}","received_events_url":"https://api.github.com/users/cpoma/received_events","type":"User","site_admin":false},"body":"Bugfix in stig/attributes/default.rb - Errors out and sshd dies (bricking machine) on RH 7 when FIPS Mode is enabled. Non-FIPS compliant MACs were specified. FIPS MODE is required to be enabled - RHEL-07-021350 - CCI-002476\r\nOld Line: default['stig']['sshd_config']['macs'] = 'hmac-md5,hmac-sha1,hmac-ripemd160,hmac-sha1-96,hmac-md5-96'\r\nReplaced with: default['stig']['sshd_config']['macs'] = 'hmac-sha2-512,hmac-sha2-256'\r\nSee https://people.redhat.com/swells/scap-security-guide/tables/table-rhel7-stig.html\r\nSee http://csrc.nist.gov/groups/STM/cmvp/documents/140-1/140sp/140sp2630.pdf","created_at":"2018-04-26T18:13:46Z","updated_at":"2018-04-27T12:35:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1533fc901bcaf2ef336e5f7d967d50e9e644c9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/USGS-CIDA/stig/pulls/118/commits","review_comments_url":"https://api.github.com/repos/USGS-CIDA/stig/pulls/118/comments","review_comment_url":"https://api.github.com/repos/USGS-CIDA/stig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-CIDA/stig/issues/118/comments","statuses_url":"https://api.github.com/repos/USGS-CIDA/stig/statuses/e74c22bf6e426290a2f1711597e510050102dda5","head":{"label":"cpoma:sshd_fix_FIPS_MACs_Compliance","ref":"sshd_fix_FIPS_MACs_Compliance","sha":"e74c22bf6e426290a2f1711597e510050102dda5","user":{"login":"cpoma","id":34897373,"avatar_url":"https://avatars1.githubusercontent.com/u/34897373?v=4","gravatar_id":"","url":"https://api.github.com/users/cpoma","html_url":"https://github.com/cpoma","followers_url":"https://api.github.com/users/cpoma/followers","following_url":"https://api.github.com/users/cpoma/following{/other_user}","gists_url":"https://api.github.com/users/cpoma/gists{/gist_id}","starred_url":"https://api.github.com/users/cpoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpoma/subscriptions","organizations_url":"https://api.github.com/users/cpoma/orgs","repos_url":"https://api.github.com/users/cpoma/repos","events_url":"https://api.github.com/users/cpoma/events{/privacy}","received_events_url":"https://api.github.com/users/cpoma/received_events","type":"User","site_admin":false},"repo":{"id":131167383,"name":"stig","full_name":"cpoma/stig","owner":{"login":"cpoma","id":34897373,"avatar_url":"https://avatars1.githubusercontent.com/u/34897373?v=4","gravatar_id":"","url":"https://api.github.com/users/cpoma","html_url":"https://github.com/cpoma","followers_url":"https://api.github.com/users/cpoma/followers","following_url":"https://api.github.com/users/cpoma/following{/other_user}","gists_url":"https://api.github.com/users/cpoma/gists{/gist_id}","starred_url":"https://api.github.com/users/cpoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpoma/subscriptions","organizations_url":"https://api.github.com/users/cpoma/orgs","repos_url":"https://api.github.com/users/cpoma/repos","events_url":"https://api.github.com/users/cpoma/events{/privacy}","received_events_url":"https://api.github.com/users/cpoma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpoma/stig","description":"Chef cookbook implementation of the CIS CentOS and Ubuntu Linux 6 Benchmark","fork":true,"url":"https://api.github.com/repos/cpoma/stig","forks_url":"https://api.github.com/repos/cpoma/stig/forks","keys_url":"https://api.github.com/repos/cpoma/stig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpoma/stig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpoma/stig/teams","hooks_url":"https://api.github.com/repos/cpoma/stig/hooks","issue_events_url":"https://api.github.com/repos/cpoma/stig/issues/events{/number}","events_url":"https://api.github.com/repos/cpoma/stig/events","assignees_url":"https://api.github.com/repos/cpoma/stig/assignees{/user}","branches_url":"https://api.github.com/repos/cpoma/stig/branches{/branch}","tags_url":"https://api.github.com/repos/cpoma/stig/tags","blobs_url":"https://api.github.com/repos/cpoma/stig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpoma/stig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpoma/stig/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpoma/stig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpoma/stig/statuses/{sha}","languages_url":"https://api.github.com/repos/cpoma/stig/languages","stargazers_url":"https://api.github.com/repos/cpoma/stig/stargazers","contributors_url":"https://api.github.com/repos/cpoma/stig/contributors","subscribers_url":"https://api.github.com/repos/cpoma/stig/subscribers","subscription_url":"https://api.github.com/repos/cpoma/stig/subscription","commits_url":"https://api.github.com/repos/cpoma/stig/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpoma/stig/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpoma/stig/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpoma/stig/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpoma/stig/contents/{+path}","compare_url":"https://api.github.com/repos/cpoma/stig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpoma/stig/merges","archive_url":"https://api.github.com/repos/cpoma/stig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpoma/stig/downloads","issues_url":"https://api.github.com/repos/cpoma/stig/issues{/number}","pulls_url":"https://api.github.com/repos/cpoma/stig/pulls{/number}","milestones_url":"https://api.github.com/repos/cpoma/stig/milestones{/number}","notifications_url":"https://api.github.com/repos/cpoma/stig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpoma/stig/labels{/name}","releases_url":"https://api.github.com/repos/cpoma/stig/releases{/id}","deployments_url":"https://api.github.com/repos/cpoma/stig/deployments","created_at":"2018-04-26T14:24:52Z","updated_at":"2018-04-27T11:32:08Z","pushed_at":"2018-04-27T11:32:05Z","git_url":"git://github.com/cpoma/stig.git","ssh_url":"git@github.com:cpoma/stig.git","clone_url":"https://github.com/cpoma/stig.git","svn_url":"https://github.com/cpoma/stig","homepage":"","size":523,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-CIDA:master","ref":"master","sha":"07d4212f057433e61904c28637436244f893486c","user":{"login":"USGS-CIDA","id":918179,"avatar_url":"https://avatars2.githubusercontent.com/u/918179?v=4","gravatar_id":"","url":"https://api.github.com/users/USGS-CIDA","html_url":"https://github.com/USGS-CIDA","followers_url":"https://api.github.com/users/USGS-CIDA/followers","following_url":"https://api.github.com/users/USGS-CIDA/following{/other_user}","gists_url":"https://api.github.com/users/USGS-CIDA/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-CIDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-CIDA/subscriptions","organizations_url":"https://api.github.com/users/USGS-CIDA/orgs","repos_url":"https://api.github.com/users/USGS-CIDA/repos","events_url":"https://api.github.com/users/USGS-CIDA/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-CIDA/received_events","type":"Organization","site_admin":false},"repo":{"id":28145880,"name":"stig","full_name":"USGS-CIDA/stig","owner":{"login":"USGS-CIDA","id":918179,"avatar_url":"https://avatars2.githubusercontent.com/u/918179?v=4","gravatar_id":"","url":"https://api.github.com/users/USGS-CIDA","html_url":"https://github.com/USGS-CIDA","followers_url":"https://api.github.com/users/USGS-CIDA/followers","following_url":"https://api.github.com/users/USGS-CIDA/following{/other_user}","gists_url":"https://api.github.com/users/USGS-CIDA/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-CIDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-CIDA/subscriptions","organizations_url":"https://api.github.com/users/USGS-CIDA/orgs","repos_url":"https://api.github.com/users/USGS-CIDA/repos","events_url":"https://api.github.com/users/USGS-CIDA/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-CIDA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-CIDA/stig","description":"Chef cookbook implementation of the CIS CentOS and Ubuntu Linux 6 Benchmark","fork":false,"url":"https://api.github.com/repos/USGS-CIDA/stig","forks_url":"https://api.github.com/repos/USGS-CIDA/stig/forks","keys_url":"https://api.github.com/repos/USGS-CIDA/stig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-CIDA/stig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-CIDA/stig/teams","hooks_url":"https://api.github.com/repos/USGS-CIDA/stig/hooks","issue_events_url":"https://api.github.com/repos/USGS-CIDA/stig/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-CIDA/stig/events","assignees_url":"https://api.github.com/repos/USGS-CIDA/stig/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-CIDA/stig/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-CIDA/stig/tags","blobs_url":"https://api.github.com/repos/USGS-CIDA/stig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-CIDA/stig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-CIDA/stig/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-CIDA/stig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-CIDA/stig/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-CIDA/stig/languages","stargazers_url":"https://api.github.com/repos/USGS-CIDA/stig/stargazers","contributors_url":"https://api.github.com/repos/USGS-CIDA/stig/contributors","subscribers_url":"https://api.github.com/repos/USGS-CIDA/stig/subscribers","subscription_url":"https://api.github.com/repos/USGS-CIDA/stig/subscription","commits_url":"https://api.github.com/repos/USGS-CIDA/stig/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-CIDA/stig/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-CIDA/stig/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-CIDA/stig/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-CIDA/stig/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-CIDA/stig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-CIDA/stig/merges","archive_url":"https://api.github.com/repos/USGS-CIDA/stig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-CIDA/stig/downloads","issues_url":"https://api.github.com/repos/USGS-CIDA/stig/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-CIDA/stig/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-CIDA/stig/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-CIDA/stig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-CIDA/stig/labels{/name}","releases_url":"https://api.github.com/repos/USGS-CIDA/stig/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-CIDA/stig/deployments","created_at":"2014-12-17T16:40:22Z","updated_at":"2018-04-26T21:55:32Z","pushed_at":"2018-04-26T23:04:03Z","git_url":"git://github.com/USGS-CIDA/stig.git","ssh_url":"git@github.com:USGS-CIDA/stig.git","clone_url":"https://github.com/USGS-CIDA/stig.git","svn_url":"https://github.com/USGS-CIDA/stig","homepage":"","size":520,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":28,"open_issues":6,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-CIDA/stig/pulls/118"},"html":{"href":"https://github.com/USGS-CIDA/stig/pull/118"},"issue":{"href":"https://api.github.com/repos/USGS-CIDA/stig/issues/118"},"comments":{"href":"https://api.github.com/repos/USGS-CIDA/stig/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-CIDA/stig/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-CIDA/stig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-CIDA/stig/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-CIDA/stig/statuses/e74c22bf6e426290a2f1711597e510050102dda5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cpoma"}}