{"action":"created","comment":{"url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/comments/191409637","pull_request_review_id":123975029,"id":191409637,"diff_hunk":"@@ -83,20 +84,22 @@ pub fn run_wasm_pack(command: Command) -> result::Result<(), Error> {\n             scope,\n             disable_dts,\n             target,\n-        } => init(path, scope, disable_dts, target),\n-        Command::Pack { path } => pack(path),\n-        Command::Publish { path } => publish(path),\n+        } => init(path, scope, disable_dts, target, &log),\n+        Command::Pack { path } => pack(path, &log),\n+        Command::Publish { path } => publish(path, &log),\n         Command::Login {\n             registry,\n             scope,\n             always_auth,\n             auth_type,\n-        } => login(registry, scope, always_auth, auth_type),\n+        } => login(registry, scope, always_auth, auth_type, &log),\n     };\n \n+    info!(&log, \"The commands ran\");","path":"src/command.rs","position":36,"original_position":36,"commit_id":"2de3bbf555a471be34286771d1309354913f6b00","original_commit_id":"2de3bbf555a471be34286771d1309354913f6b00","user":{"login":"ashleygwilliams","id":1163554,"avatar_url":"https://avatars0.githubusercontent.com/u/1163554?v=4","gravatar_id":"","url":"https://api.github.com/users/ashleygwilliams","html_url":"https://github.com/ashleygwilliams","followers_url":"https://api.github.com/users/ashleygwilliams/followers","following_url":"https://api.github.com/users/ashleygwilliams/following{/other_user}","gists_url":"https://api.github.com/users/ashleygwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/ashleygwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashleygwilliams/subscriptions","organizations_url":"https://api.github.com/users/ashleygwilliams/orgs","repos_url":"https://api.github.com/users/ashleygwilliams/repos","events_url":"https://api.github.com/users/ashleygwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/ashleygwilliams/received_events","type":"User","site_admin":false},"body":"this might be confusing","created_at":"2018-05-29T12:48:54Z","updated_at":"2018-05-29T12:52:55Z","html_url":"https://github.com/ashleygwilliams/wasm-pack/pull/134#discussion_r191409637","pull_request_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/134","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/comments/191409637"},"html":{"href":"https://github.com/ashleygwilliams/wasm-pack/pull/134#discussion_r191409637"},"pull_request":{"href":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/134","id":191096994,"html_url":"https://github.com/ashleygwilliams/wasm-pack/pull/134","diff_url":"https://github.com/ashleygwilliams/wasm-pack/pull/134.diff","patch_url":"https://github.com/ashleygwilliams/wasm-pack/pull/134.patch","issue_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/134","number":134,"state":"open","locked":false,"title":"Logging","user":{"login":"mgattozzi","id":3514399,"avatar_url":"https://avatars3.githubusercontent.com/u/3514399?v=4","gravatar_id":"","url":"https://api.github.com/users/mgattozzi","html_url":"https://github.com/mgattozzi","followers_url":"https://api.github.com/users/mgattozzi/followers","following_url":"https://api.github.com/users/mgattozzi/following{/other_user}","gists_url":"https://api.github.com/users/mgattozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mgattozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgattozzi/subscriptions","organizations_url":"https://api.github.com/users/mgattozzi/orgs","repos_url":"https://api.github.com/users/mgattozzi/repos","events_url":"https://api.github.com/users/mgattozzi/events{/privacy}","received_events_url":"https://api.github.com/users/mgattozzi/received_events","type":"User","site_admin":false},"body":"This PR does two things:\r\n\r\n- Remove some issues with lockfiles in our test fixtures, as well as dealing with wasm-bindgen versioning\r\n- Add logging to wasm-pack\r\n\r\nSpecifics are available for each one in the commits themselves.\r\n\r\nCloses #50 \r\nand we can open a new one to make it even better\r\n\r\nMake sure these boxes are checked! 📦✅\r\n\r\n- [x] You have the latest version of `rustfmt` installed and have your \r\n      cloned directory set to nightly\r\n```bash\r\n$ rustup override set nightly\r\n$ rustup component add rustfmt-preview --toolchain nightly\r\n```\r\n- [x] You ran `rustfmt` on the code base before submitting\r\n- [x] You reference which issue is being closed in the PR text\r\n\r\n✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨\r\n","created_at":"2018-05-29T10:16:19Z","updated_at":"2018-05-29T12:52:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"805c671467f870766ccfa73ba869b5cdda45de74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/134/commits","review_comments_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/134/comments","review_comment_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/134/comments","statuses_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/statuses/2de3bbf555a471be34286771d1309354913f6b00","head":{"label":"mgattozzi:logging","ref":"logging","sha":"2de3bbf555a471be34286771d1309354913f6b00","user":{"login":"mgattozzi","id":3514399,"avatar_url":"https://avatars3.githubusercontent.com/u/3514399?v=4","gravatar_id":"","url":"https://api.github.com/users/mgattozzi","html_url":"https://github.com/mgattozzi","followers_url":"https://api.github.com/users/mgattozzi/followers","following_url":"https://api.github.com/users/mgattozzi/following{/other_user}","gists_url":"https://api.github.com/users/mgattozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mgattozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgattozzi/subscriptions","organizations_url":"https://api.github.com/users/mgattozzi/orgs","repos_url":"https://api.github.com/users/mgattozzi/repos","events_url":"https://api.github.com/users/mgattozzi/events{/privacy}","received_events_url":"https://api.github.com/users/mgattozzi/received_events","type":"User","site_admin":false},"repo":{"id":124553487,"name":"wasm-pack","full_name":"mgattozzi/wasm-pack","owner":{"login":"mgattozzi","id":3514399,"avatar_url":"https://avatars3.githubusercontent.com/u/3514399?v=4","gravatar_id":"","url":"https://api.github.com/users/mgattozzi","html_url":"https://github.com/mgattozzi","followers_url":"https://api.github.com/users/mgattozzi/followers","following_url":"https://api.github.com/users/mgattozzi/following{/other_user}","gists_url":"https://api.github.com/users/mgattozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mgattozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgattozzi/subscriptions","organizations_url":"https://api.github.com/users/mgattozzi/orgs","repos_url":"https://api.github.com/users/mgattozzi/repos","events_url":"https://api.github.com/users/mgattozzi/events{/privacy}","received_events_url":"https://api.github.com/users/mgattozzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgattozzi/wasm-pack","description":"📦✨ pack up the wasm and publish it to npm!","fork":true,"url":"https://api.github.com/repos/mgattozzi/wasm-pack","forks_url":"https://api.github.com/repos/mgattozzi/wasm-pack/forks","keys_url":"https://api.github.com/repos/mgattozzi/wasm-pack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgattozzi/wasm-pack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgattozzi/wasm-pack/teams","hooks_url":"https://api.github.com/repos/mgattozzi/wasm-pack/hooks","issue_events_url":"https://api.github.com/repos/mgattozzi/wasm-pack/issues/events{/number}","events_url":"https://api.github.com/repos/mgattozzi/wasm-pack/events","assignees_url":"https://api.github.com/repos/mgattozzi/wasm-pack/assignees{/user}","branches_url":"https://api.github.com/repos/mgattozzi/wasm-pack/branches{/branch}","tags_url":"https://api.github.com/repos/mgattozzi/wasm-pack/tags","blobs_url":"https://api.github.com/repos/mgattozzi/wasm-pack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgattozzi/wasm-pack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgattozzi/wasm-pack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgattozzi/wasm-pack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgattozzi/wasm-pack/statuses/{sha}","languages_url":"https://api.github.com/repos/mgattozzi/wasm-pack/languages","stargazers_url":"https://api.github.com/repos/mgattozzi/wasm-pack/stargazers","contributors_url":"https://api.github.com/repos/mgattozzi/wasm-pack/contributors","subscribers_url":"https://api.github.com/repos/mgattozzi/wasm-pack/subscribers","subscription_url":"https://api.github.com/repos/mgattozzi/wasm-pack/subscription","commits_url":"https://api.github.com/repos/mgattozzi/wasm-pack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgattozzi/wasm-pack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgattozzi/wasm-pack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgattozzi/wasm-pack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgattozzi/wasm-pack/contents/{+path}","compare_url":"https://api.github.com/repos/mgattozzi/wasm-pack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgattozzi/wasm-pack/merges","archive_url":"https://api.github.com/repos/mgattozzi/wasm-pack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgattozzi/wasm-pack/downloads","issues_url":"https://api.github.com/repos/mgattozzi/wasm-pack/issues{/number}","pulls_url":"https://api.github.com/repos/mgattozzi/wasm-pack/pulls{/number}","milestones_url":"https://api.github.com/repos/mgattozzi/wasm-pack/milestones{/number}","notifications_url":"https://api.github.com/repos/mgattozzi/wasm-pack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgattozzi/wasm-pack/labels{/name}","releases_url":"https://api.github.com/repos/mgattozzi/wasm-pack/releases{/id}","deployments_url":"https://api.github.com/repos/mgattozzi/wasm-pack/deployments","created_at":"2018-03-09T14:50:53Z","updated_at":"2018-05-16T18:58:42Z","pushed_at":"2018-05-29T12:47:21Z","git_url":"git://github.com/mgattozzi/wasm-pack.git","ssh_url":"git@github.com:mgattozzi/wasm-pack.git","clone_url":"https://github.com/mgattozzi/wasm-pack.git","svn_url":"https://github.com/mgattozzi/wasm-pack","homepage":"","size":817,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ashleygwilliams:master","ref":"master","sha":"28c95363fc62b8087e3e260505849787228ccc95","user":{"login":"ashleygwilliams","id":1163554,"avatar_url":"https://avatars0.githubusercontent.com/u/1163554?v=4","gravatar_id":"","url":"https://api.github.com/users/ashleygwilliams","html_url":"https://github.com/ashleygwilliams","followers_url":"https://api.github.com/users/ashleygwilliams/followers","following_url":"https://api.github.com/users/ashleygwilliams/following{/other_user}","gists_url":"https://api.github.com/users/ashleygwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/ashleygwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashleygwilliams/subscriptions","organizations_url":"https://api.github.com/users/ashleygwilliams/orgs","repos_url":"https://api.github.com/users/ashleygwilliams/repos","events_url":"https://api.github.com/users/ashleygwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/ashleygwilliams/received_events","type":"User","site_admin":false},"repo":{"id":121253762,"name":"wasm-pack","full_name":"ashleygwilliams/wasm-pack","owner":{"login":"ashleygwilliams","id":1163554,"avatar_url":"https://avatars0.githubusercontent.com/u/1163554?v=4","gravatar_id":"","url":"https://api.github.com/users/ashleygwilliams","html_url":"https://github.com/ashleygwilliams","followers_url":"https://api.github.com/users/ashleygwilliams/followers","following_url":"https://api.github.com/users/ashleygwilliams/following{/other_user}","gists_url":"https://api.github.com/users/ashleygwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/ashleygwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashleygwilliams/subscriptions","organizations_url":"https://api.github.com/users/ashleygwilliams/orgs","repos_url":"https://api.github.com/users/ashleygwilliams/repos","events_url":"https://api.github.com/users/ashleygwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/ashleygwilliams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashleygwilliams/wasm-pack","description":"📦✨ pack up the wasm and publish it to npm!","fork":false,"url":"https://api.github.com/repos/ashleygwilliams/wasm-pack","forks_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/forks","keys_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/teams","hooks_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/hooks","issue_events_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/events{/number}","events_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/events","assignees_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/assignees{/user}","branches_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/branches{/branch}","tags_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/tags","blobs_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/statuses/{sha}","languages_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/languages","stargazers_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/stargazers","contributors_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/contributors","subscribers_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/subscribers","subscription_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/subscription","commits_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/contents/{+path}","compare_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/merges","archive_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/downloads","issues_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues{/number}","pulls_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls{/number}","milestones_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/milestones{/number}","notifications_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/labels{/name}","releases_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/releases{/id}","deployments_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/deployments","created_at":"2018-02-12T14:04:34Z","updated_at":"2018-05-29T12:04:40Z","pushed_at":"2018-05-29T12:47:23Z","git_url":"git://github.com/ashleygwilliams/wasm-pack.git","ssh_url":"git@github.com:ashleygwilliams/wasm-pack.git","clone_url":"https://github.com/ashleygwilliams/wasm-pack.git","svn_url":"https://github.com/ashleygwilliams/wasm-pack","homepage":"","size":793,"stargazers_count":632,"watchers_count":632,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":22,"open_issues":14,"watchers":632,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/134"},"html":{"href":"https://github.com/ashleygwilliams/wasm-pack/pull/134"},"issue":{"href":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/134"},"comments":{"href":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/ashleygwilliams/wasm-pack/statuses/2de3bbf555a471be34286771d1309354913f6b00"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ashleygwilliams"}}