{"action":"closed","number":26809,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/26809","id":166938303,"html_url":"https://github.com/dotnet/corefx/pull/26809","diff_url":"https://github.com/dotnet/corefx/pull/26809.diff","patch_url":"https://github.com/dotnet/corefx/pull/26809.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/26809","number":26809,"state":"closed","locked":false,"title":"Fix issues with test tables in SqlClient tests","user":{"login":"corivera","id":12820011,"avatar_url":"https://avatars1.githubusercontent.com/u/12820011?v=4","gravatar_id":"","url":"https://api.github.com/users/corivera","html_url":"https://github.com/corivera","followers_url":"https://api.github.com/users/corivera/followers","following_url":"https://api.github.com/users/corivera/following{/other_user}","gists_url":"https://api.github.com/users/corivera/gists{/gist_id}","starred_url":"https://api.github.com/users/corivera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corivera/subscriptions","organizations_url":"https://api.github.com/users/corivera/orgs","repos_url":"https://api.github.com/users/corivera/repos","events_url":"https://api.github.com/users/corivera/events{/privacy}","received_events_url":"https://api.github.com/users/corivera/received_events","type":"User","site_admin":false},"body":"2 major changes here:\r\n- Changes WarningBeforeRowsTest so that it checks for a fulltext index before using queries with the contains() function.\r\n- Change temp table creation in AdapterTest so that the new table won't have identity columns. This is achieved with a dummy union in the SELECT INTO query.\r\n\r\nI also changed some try-finally scoping in AdapterTest so that tests won't try to drop a temp table if the table creation itself threw an exception.","created_at":"2018-02-03T01:31:33Z","updated_at":"2018-02-03T05:31:22Z","closed_at":"2018-02-03T05:31:22Z","merged_at":"2018-02-03T05:31:22Z","merge_commit_sha":"3952fdd5072ea38705df9e86cdc5dc4a4c47cc41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/26809/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/26809/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/26809/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/dca4a53befdb959110eeb6fce70567cbe8333dc1","head":{"label":"corivera:CheckForFullTextInTest","ref":"CheckForFullTextInTest","sha":"dca4a53befdb959110eeb6fce70567cbe8333dc1","user":{"login":"corivera","id":12820011,"avatar_url":"https://avatars1.githubusercontent.com/u/12820011?v=4","gravatar_id":"","url":"https://api.github.com/users/corivera","html_url":"https://github.com/corivera","followers_url":"https://api.github.com/users/corivera/followers","following_url":"https://api.github.com/users/corivera/following{/other_user}","gists_url":"https://api.github.com/users/corivera/gists{/gist_id}","starred_url":"https://api.github.com/users/corivera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corivera/subscriptions","organizations_url":"https://api.github.com/users/corivera/orgs","repos_url":"https://api.github.com/users/corivera/repos","events_url":"https://api.github.com/users/corivera/events{/privacy}","received_events_url":"https://api.github.com/users/corivera/received_events","type":"User","site_admin":false},"repo":{"id":60809254,"name":"corefx","full_name":"corivera/corefx","owner":{"login":"corivera","id":12820011,"avatar_url":"https://avatars1.githubusercontent.com/u/12820011?v=4","gravatar_id":"","url":"https://api.github.com/users/corivera","html_url":"https://github.com/corivera","followers_url":"https://api.github.com/users/corivera/followers","following_url":"https://api.github.com/users/corivera/following{/other_user}","gists_url":"https://api.github.com/users/corivera/gists{/gist_id}","starred_url":"https://api.github.com/users/corivera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corivera/subscriptions","organizations_url":"https://api.github.com/users/corivera/orgs","repos_url":"https://api.github.com/users/corivera/repos","events_url":"https://api.github.com/users/corivera/events{/privacy}","received_events_url":"https://api.github.com/users/corivera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/corivera/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/corivera/corefx","forks_url":"https://api.github.com/repos/corivera/corefx/forks","keys_url":"https://api.github.com/repos/corivera/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corivera/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corivera/corefx/teams","hooks_url":"https://api.github.com/repos/corivera/corefx/hooks","issue_events_url":"https://api.github.com/repos/corivera/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/corivera/corefx/events","assignees_url":"https://api.github.com/repos/corivera/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/corivera/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/corivera/corefx/tags","blobs_url":"https://api.github.com/repos/corivera/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corivera/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corivera/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/corivera/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corivera/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/corivera/corefx/languages","stargazers_url":"https://api.github.com/repos/corivera/corefx/stargazers","contributors_url":"https://api.github.com/repos/corivera/corefx/contributors","subscribers_url":"https://api.github.com/repos/corivera/corefx/subscribers","subscription_url":"https://api.github.com/repos/corivera/corefx/subscription","commits_url":"https://api.github.com/repos/corivera/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/corivera/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/corivera/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/corivera/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/corivera/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/corivera/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corivera/corefx/merges","archive_url":"https://api.github.com/repos/corivera/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corivera/corefx/downloads","issues_url":"https://api.github.com/repos/corivera/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/corivera/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/corivera/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/corivera/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corivera/corefx/labels{/name}","releases_url":"https://api.github.com/repos/corivera/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/corivera/corefx/deployments","created_at":"2016-06-09T21:47:48Z","updated_at":"2016-06-09T21:48:14Z","pushed_at":"2018-02-03T01:28:24Z","git_url":"git://github.com/corivera/corefx.git","ssh_url":"git@github.com:corivera/corefx.git","clone_url":"https://github.com/corivera/corefx.git","svn_url":"https://github.com/corivera/corefx","homepage":"http://dotnet.github.io/","size":163751,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0e67638b1505c7ee19c36ac8df7c988eef8af02b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-02-02T12:40:32Z","pushed_at":"2018-02-03T05:31:22Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":168120,"stargazers_count":13308,"watchers_count":13308,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3760,"mirror_url":null,"archived":false,"open_issues_count":2167,"license":null,"forks":3760,"open_issues":2167,"watchers":13308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26809"},"html":{"href":"https://github.com/dotnet/corefx/pull/26809"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/26809"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/26809/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26809/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/26809/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/dca4a53befdb959110eeb6fce70567cbe8333dc1"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"saurabh500","id":1623701,"avatar_url":"https://avatars3.githubusercontent.com/u/1623701?v=4","gravatar_id":"","url":"https://api.github.com/users/saurabh500","html_url":"https://github.com/saurabh500","followers_url":"https://api.github.com/users/saurabh500/followers","following_url":"https://api.github.com/users/saurabh500/following{/other_user}","gists_url":"https://api.github.com/users/saurabh500/gists{/gist_id}","starred_url":"https://api.github.com/users/saurabh500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurabh500/subscriptions","organizations_url":"https://api.github.com/users/saurabh500/orgs","repos_url":"https://api.github.com/users/saurabh500/repos","events_url":"https://api.github.com/users/saurabh500/events{/privacy}","received_events_url":"https://api.github.com/users/saurabh500/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":77,"deletions":62,"changed_files":2}}
{"actor":{"display_login":"saurabh500"}}