{"action":"created","comment":{"url":"https://api.github.com/repos/kitodo/kitodo-production/pulls/comments/196743687","pull_request_review_id":130353594,"id":196743687,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Njc0MzY4Nw==","diff_hunk":"@@ -88,6 +88,12 @@\n         <!--<param-value>none</param-value>-->\n     <!--</context-param>-->\n \n+    <listener>","path":"Kitodo/src/main/webapp/WEB-INF/web.xml","position":4,"original_position":4,"commit_id":"c67c2c7dfa17648ae990567619522a977108b8e2","original_commit_id":"c67c2c7dfa17648ae990567619522a977108b8e2","user":{"login":"henning-gerhardt","id":2129672,"node_id":"MDQ6VXNlcjIxMjk2NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2129672?v=4","gravatar_id":"","url":"https://api.github.com/users/henning-gerhardt","html_url":"https://github.com/henning-gerhardt","followers_url":"https://api.github.com/users/henning-gerhardt/followers","following_url":"https://api.github.com/users/henning-gerhardt/following{/other_user}","gists_url":"https://api.github.com/users/henning-gerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/henning-gerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henning-gerhardt/subscriptions","organizations_url":"https://api.github.com/users/henning-gerhardt/orgs","repos_url":"https://api.github.com/users/henning-gerhardt/repos","events_url":"https://api.github.com/users/henning-gerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/henning-gerhardt/received_events","type":"User","site_admin":false},"body":"As the application build as a servlet 3.0+ application, then this is not needed any more, according to the [readme of the project](https://github.com/mjiderhamn/classloader-leak-prevention). Maybe you must adjust the pom entry too.","created_at":"2018-06-20T11:46:24Z","updated_at":"2018-06-20T11:46:33Z","html_url":"https://github.com/kitodo/kitodo-production/pull/1588#discussion_r196743687","pull_request_url":"https://api.github.com/repos/kitodo/kitodo-production/pulls/1588","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kitodo/kitodo-production/pulls/comments/196743687"},"html":{"href":"https://github.com/kitodo/kitodo-production/pull/1588#discussion_r196743687"},"pull_request":{"href":"https://api.github.com/repos/kitodo/kitodo-production/pulls/1588"}}},"pull_request":{"url":"https://api.github.com/repos/kitodo/kitodo-production/pulls/1588","id":195732474,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NzMyNDc0","html_url":"https://github.com/kitodo/kitodo-production/pull/1588","diff_url":"https://github.com/kitodo/kitodo-production/pull/1588.diff","patch_url":"https://github.com/kitodo/kitodo-production/pull/1588.patch","issue_url":"https://api.github.com/repos/kitodo/kitodo-production/issues/1588","number":1588,"state":"open","locked":false,"title":"Add ClassLoaderLeakPreventor","user":{"login":"Beacze","id":9614459,"node_id":"MDQ6VXNlcjk2MTQ0NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9614459?v=4","gravatar_id":"","url":"https://api.github.com/users/Beacze","html_url":"https://github.com/Beacze","followers_url":"https://api.github.com/users/Beacze/followers","following_url":"https://api.github.com/users/Beacze/following{/other_user}","gists_url":"https://api.github.com/users/Beacze/gists{/gist_id}","starred_url":"https://api.github.com/users/Beacze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beacze/subscriptions","organizations_url":"https://api.github.com/users/Beacze/orgs","repos_url":"https://api.github.com/users/Beacze/repos","events_url":"https://api.github.com/users/Beacze/events{/privacy}","received_events_url":"https://api.github.com/users/Beacze/received_events","type":"User","site_admin":false},"body":"Depends on #1571 \r\n\r\nhttps://stackoverflow.com/questions/7788280/memory-leak-when-redeploying-application-in-tomcat\r\nhttp://java.jiderhamn.se/2012/03/04/classloader-leaks-vi-this-means-war-leak-prevention-library/","created_at":"2018-06-19T07:19:32Z","updated_at":"2018-06-20T11:46:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79ac2297623423d175d161f23a4af933d79783e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kitodo/kitodo-production/pulls/1588/commits","review_comments_url":"https://api.github.com/repos/kitodo/kitodo-production/pulls/1588/comments","review_comment_url":"https://api.github.com/repos/kitodo/kitodo-production/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kitodo/kitodo-production/issues/1588/comments","statuses_url":"https://api.github.com/repos/kitodo/kitodo-production/statuses/c67c2c7dfa17648ae990567619522a977108b8e2","head":{"label":"Beacze:fix-thread-close","ref":"fix-thread-close","sha":"c67c2c7dfa17648ae990567619522a977108b8e2","user":{"login":"Beacze","id":9614459,"node_id":"MDQ6VXNlcjk2MTQ0NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9614459?v=4","gravatar_id":"","url":"https://api.github.com/users/Beacze","html_url":"https://github.com/Beacze","followers_url":"https://api.github.com/users/Beacze/followers","following_url":"https://api.github.com/users/Beacze/following{/other_user}","gists_url":"https://api.github.com/users/Beacze/gists{/gist_id}","starred_url":"https://api.github.com/users/Beacze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beacze/subscriptions","organizations_url":"https://api.github.com/users/Beacze/orgs","repos_url":"https://api.github.com/users/Beacze/repos","events_url":"https://api.github.com/users/Beacze/events{/privacy}","received_events_url":"https://api.github.com/users/Beacze/received_events","type":"User","site_admin":false},"repo":{"id":74025578,"node_id":"MDEwOlJlcG9zaXRvcnk3NDAyNTU3OA==","name":"kitodo-production","full_name":"Beacze/kitodo-production","owner":{"login":"Beacze","id":9614459,"node_id":"MDQ6VXNlcjk2MTQ0NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9614459?v=4","gravatar_id":"","url":"https://api.github.com/users/Beacze","html_url":"https://github.com/Beacze","followers_url":"https://api.github.com/users/Beacze/followers","following_url":"https://api.github.com/users/Beacze/following{/other_user}","gists_url":"https://api.github.com/users/Beacze/gists{/gist_id}","starred_url":"https://api.github.com/users/Beacze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beacze/subscriptions","organizations_url":"https://api.github.com/users/Beacze/orgs","repos_url":"https://api.github.com/users/Beacze/repos","events_url":"https://api.github.com/users/Beacze/events{/privacy}","received_events_url":"https://api.github.com/users/Beacze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Beacze/kitodo-production","description":"Kitodo.Production","fork":true,"url":"https://api.github.com/repos/Beacze/kitodo-production","forks_url":"https://api.github.com/repos/Beacze/kitodo-production/forks","keys_url":"https://api.github.com/repos/Beacze/kitodo-production/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Beacze/kitodo-production/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Beacze/kitodo-production/teams","hooks_url":"https://api.github.com/repos/Beacze/kitodo-production/hooks","issue_events_url":"https://api.github.com/repos/Beacze/kitodo-production/issues/events{/number}","events_url":"https://api.github.com/repos/Beacze/kitodo-production/events","assignees_url":"https://api.github.com/repos/Beacze/kitodo-production/assignees{/user}","branches_url":"https://api.github.com/repos/Beacze/kitodo-production/branches{/branch}","tags_url":"https://api.github.com/repos/Beacze/kitodo-production/tags","blobs_url":"https://api.github.com/repos/Beacze/kitodo-production/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Beacze/kitodo-production/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Beacze/kitodo-production/git/refs{/sha}","trees_url":"https://api.github.com/repos/Beacze/kitodo-production/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Beacze/kitodo-production/statuses/{sha}","languages_url":"https://api.github.com/repos/Beacze/kitodo-production/languages","stargazers_url":"https://api.github.com/repos/Beacze/kitodo-production/stargazers","contributors_url":"https://api.github.com/repos/Beacze/kitodo-production/contributors","subscribers_url":"https://api.github.com/repos/Beacze/kitodo-production/subscribers","subscription_url":"https://api.github.com/repos/Beacze/kitodo-production/subscription","commits_url":"https://api.github.com/repos/Beacze/kitodo-production/commits{/sha}","git_commits_url":"https://api.github.com/repos/Beacze/kitodo-production/git/commits{/sha}","comments_url":"https://api.github.com/repos/Beacze/kitodo-production/comments{/number}","issue_comment_url":"https://api.github.com/repos/Beacze/kitodo-production/issues/comments{/number}","contents_url":"https://api.github.com/repos/Beacze/kitodo-production/contents/{+path}","compare_url":"https://api.github.com/repos/Beacze/kitodo-production/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Beacze/kitodo-production/merges","archive_url":"https://api.github.com/repos/Beacze/kitodo-production/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Beacze/kitodo-production/downloads","issues_url":"https://api.github.com/repos/Beacze/kitodo-production/issues{/number}","pulls_url":"https://api.github.com/repos/Beacze/kitodo-production/pulls{/number}","milestones_url":"https://api.github.com/repos/Beacze/kitodo-production/milestones{/number}","notifications_url":"https://api.github.com/repos/Beacze/kitodo-production/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Beacze/kitodo-production/labels{/name}","releases_url":"https://api.github.com/repos/Beacze/kitodo-production/releases{/id}","deployments_url":"https://api.github.com/repos/Beacze/kitodo-production/deployments","created_at":"2016-11-17T12:37:15Z","updated_at":"2018-06-20T07:10:13Z","pushed_at":"2018-06-20T11:39:18Z","git_url":"git://github.com/Beacze/kitodo-production.git","ssh_url":"git@github.com:Beacze/kitodo-production.git","clone_url":"https://github.com/Beacze/kitodo-production.git","svn_url":"https://github.com/Beacze/kitodo-production","homepage":"","size":145863,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kitodo:master","ref":"master","sha":"6b4c0b3b0c8efb8dd029164e83f694e26767a8bb","user":{"login":"kitodo","id":18034325,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MDM0MzI1","avatar_url":"https://avatars3.githubusercontent.com/u/18034325?v=4","gravatar_id":"","url":"https://api.github.com/users/kitodo","html_url":"https://github.com/kitodo","followers_url":"https://api.github.com/users/kitodo/followers","following_url":"https://api.github.com/users/kitodo/following{/other_user}","gists_url":"https://api.github.com/users/kitodo/gists{/gist_id}","starred_url":"https://api.github.com/users/kitodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitodo/subscriptions","organizations_url":"https://api.github.com/users/kitodo/orgs","repos_url":"https://api.github.com/users/kitodo/repos","events_url":"https://api.github.com/users/kitodo/events{/privacy}","received_events_url":"https://api.github.com/users/kitodo/received_events","type":"Organization","site_admin":false},"repo":{"id":4506938,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTM4","name":"kitodo-production","full_name":"kitodo/kitodo-production","owner":{"login":"kitodo","id":18034325,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MDM0MzI1","avatar_url":"https://avatars3.githubusercontent.com/u/18034325?v=4","gravatar_id":"","url":"https://api.github.com/users/kitodo","html_url":"https://github.com/kitodo","followers_url":"https://api.github.com/users/kitodo/followers","following_url":"https://api.github.com/users/kitodo/following{/other_user}","gists_url":"https://api.github.com/users/kitodo/gists{/gist_id}","starred_url":"https://api.github.com/users/kitodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitodo/subscriptions","organizations_url":"https://api.github.com/users/kitodo/orgs","repos_url":"https://api.github.com/users/kitodo/repos","events_url":"https://api.github.com/users/kitodo/events{/privacy}","received_events_url":"https://api.github.com/users/kitodo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kitodo/kitodo-production","description":"Kitodo.Production","fork":false,"url":"https://api.github.com/repos/kitodo/kitodo-production","forks_url":"https://api.github.com/repos/kitodo/kitodo-production/forks","keys_url":"https://api.github.com/repos/kitodo/kitodo-production/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kitodo/kitodo-production/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kitodo/kitodo-production/teams","hooks_url":"https://api.github.com/repos/kitodo/kitodo-production/hooks","issue_events_url":"https://api.github.com/repos/kitodo/kitodo-production/issues/events{/number}","events_url":"https://api.github.com/repos/kitodo/kitodo-production/events","assignees_url":"https://api.github.com/repos/kitodo/kitodo-production/assignees{/user}","branches_url":"https://api.github.com/repos/kitodo/kitodo-production/branches{/branch}","tags_url":"https://api.github.com/repos/kitodo/kitodo-production/tags","blobs_url":"https://api.github.com/repos/kitodo/kitodo-production/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kitodo/kitodo-production/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kitodo/kitodo-production/git/refs{/sha}","trees_url":"https://api.github.com/repos/kitodo/kitodo-production/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kitodo/kitodo-production/statuses/{sha}","languages_url":"https://api.github.com/repos/kitodo/kitodo-production/languages","stargazers_url":"https://api.github.com/repos/kitodo/kitodo-production/stargazers","contributors_url":"https://api.github.com/repos/kitodo/kitodo-production/contributors","subscribers_url":"https://api.github.com/repos/kitodo/kitodo-production/subscribers","subscription_url":"https://api.github.com/repos/kitodo/kitodo-production/subscription","commits_url":"https://api.github.com/repos/kitodo/kitodo-production/commits{/sha}","git_commits_url":"https://api.github.com/repos/kitodo/kitodo-production/git/commits{/sha}","comments_url":"https://api.github.com/repos/kitodo/kitodo-production/comments{/number}","issue_comment_url":"https://api.github.com/repos/kitodo/kitodo-production/issues/comments{/number}","contents_url":"https://api.github.com/repos/kitodo/kitodo-production/contents/{+path}","compare_url":"https://api.github.com/repos/kitodo/kitodo-production/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kitodo/kitodo-production/merges","archive_url":"https://api.github.com/repos/kitodo/kitodo-production/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kitodo/kitodo-production/downloads","issues_url":"https://api.github.com/repos/kitodo/kitodo-production/issues{/number}","pulls_url":"https://api.github.com/repos/kitodo/kitodo-production/pulls{/number}","milestones_url":"https://api.github.com/repos/kitodo/kitodo-production/milestones{/number}","notifications_url":"https://api.github.com/repos/kitodo/kitodo-production/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kitodo/kitodo-production/labels{/name}","releases_url":"https://api.github.com/repos/kitodo/kitodo-production/releases{/id}","deployments_url":"https://api.github.com/repos/kitodo/kitodo-production/deployments","created_at":"2012-05-31T11:36:27Z","updated_at":"2018-06-20T06:58:01Z","pushed_at":"2018-06-20T11:34:34Z","git_url":"git://github.com/kitodo/kitodo-production.git","ssh_url":"git@github.com:kitodo/kitodo-production.git","clone_url":"https://github.com/kitodo/kitodo-production.git","svn_url":"https://github.com/kitodo/kitodo-production","homepage":"http://www.kitodo.org/software/kitodoproduction/","size":146376,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":68,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kitodo/kitodo-production/pulls/1588"},"html":{"href":"https://github.com/kitodo/kitodo-production/pull/1588"},"issue":{"href":"https://api.github.com/repos/kitodo/kitodo-production/issues/1588"},"comments":{"href":"https://api.github.com/repos/kitodo/kitodo-production/issues/1588/comments"},"review_comments":{"href":"https://api.github.com/repos/kitodo/kitodo-production/pulls/1588/comments"},"review_comment":{"href":"https://api.github.com/repos/kitodo/kitodo-production/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kitodo/kitodo-production/pulls/1588/commits"},"statuses":{"href":"https://api.github.com/repos/kitodo/kitodo-production/statuses/c67c2c7dfa17648ae990567619522a977108b8e2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"henning-gerhardt"}}