{"action":"created","comment":{"url":"https://api.github.com/repos/ShifuML/shifu/pulls/comments/244444042","pull_request_review_id":188391762,"id":244444042,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQ0NDA0Mg==","diff_hunk":"@@ -912,16 +932,32 @@ public static BasicNetwork getBasicNetwork(BasicML model) {\n             }\n             loadGenericModels(modelConfig, genericModelConfigs, sourceType, models);\n             log.debug(\"return generic model {}\", models.size());\n+\n             return models;\n         }\n \n         List<FileStatus> modelFileStats = locateBasicModels(modelConfig, evalConfig, sourceType);\n         if(CollectionUtils.isNotEmpty(modelFileStats)) {\n-            for(FileStatus fst: modelFileStats) {\n-                models.add(loadModel(modelConfig, fst.getPath(), fs, gbtConvertToProb, gbtScoreConvertStrategy));\n+            for(FileStatus f: modelFileStats) {\n+                tmpModels.add(loadModel(modelConfig, f.getPath(), fs, gbtConvertToProb, gbtScoreConvertStrategy));","path":"src/main/java/ml/shifu/shifu/util/CommonUtils.java","position":69,"original_position":69,"commit_id":"16d9b4843c4a2433b958e5192b53d31828749c04","original_commit_id":"16d9b4843c4a2433b958e5192b53d31828749c04","user":{"login":"zhangpengshan","id":7368102,"node_id":"MDQ6VXNlcjczNjgxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/7368102?v=4","gravatar_id":"","url":"https://api.github.com/users/zhangpengshan","html_url":"https://github.com/zhangpengshan","followers_url":"https://api.github.com/users/zhangpengshan/followers","following_url":"https://api.github.com/users/zhangpengshan/following{/other_user}","gists_url":"https://api.github.com/users/zhangpengshan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangpengshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangpengshan/subscriptions","organizations_url":"https://api.github.com/users/zhangpengshan/orgs","repos_url":"https://api.github.com/users/zhangpengshan/repos","events_url":"https://api.github.com/users/zhangpengshan/events{/privacy}","received_events_url":"https://api.github.com/users/zhangpengshan/received_events","type":"User","site_admin":false},"body":"better not use variable name like 'f'","created_at":"2018-12-29T02:42:15Z","updated_at":"2018-12-29T02:44:10Z","html_url":"https://github.com/ShifuML/shifu/pull/545#discussion_r244444042","pull_request_url":"https://api.github.com/repos/ShifuML/shifu/pulls/545","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/comments/244444042"},"html":{"href":"https://github.com/ShifuML/shifu/pull/545#discussion_r244444042"},"pull_request":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/545"}}},"pull_request":{"url":"https://api.github.com/repos/ShifuML/shifu/pulls/545","id":234175521,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MTc1NTIx","html_url":"https://github.com/ShifuML/shifu/pull/545","diff_url":"https://github.com/ShifuML/shifu/pull/545.diff","patch_url":"https://github.com/ShifuML/shifu/pull/545.patch","issue_url":"https://api.github.com/repos/ShifuML/shifu/issues/545","number":545,"state":"open","locked":false,"title":"add gbdt transfer learning","user":{"login":"WenkaiBai","id":9369212,"node_id":"MDQ6VXNlcjkzNjkyMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/9369212?v=4","gravatar_id":"","url":"https://api.github.com/users/WenkaiBai","html_url":"https://github.com/WenkaiBai","followers_url":"https://api.github.com/users/WenkaiBai/followers","following_url":"https://api.github.com/users/WenkaiBai/following{/other_user}","gists_url":"https://api.github.com/users/WenkaiBai/gists{/gist_id}","starred_url":"https://api.github.com/users/WenkaiBai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WenkaiBai/subscriptions","organizations_url":"https://api.github.com/users/WenkaiBai/orgs","repos_url":"https://api.github.com/users/WenkaiBai/repos","events_url":"https://api.github.com/users/WenkaiBai/events{/privacy}","received_events_url":"https://api.github.com/users/WenkaiBai/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-28T07:36:22Z","updated_at":"2018-12-29T02:44:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e6a047f7e80b2525b2a44d0184aaa14255dd3ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ShifuML/shifu/pulls/545/commits","review_comments_url":"https://api.github.com/repos/ShifuML/shifu/pulls/545/comments","review_comment_url":"https://api.github.com/repos/ShifuML/shifu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ShifuML/shifu/issues/545/comments","statuses_url":"https://api.github.com/repos/ShifuML/shifu/statuses/16d9b4843c4a2433b958e5192b53d31828749c04","head":{"label":"WenkaiBai:transferlearning_gbdt","ref":"transferlearning_gbdt","sha":"16d9b4843c4a2433b958e5192b53d31828749c04","user":{"login":"WenkaiBai","id":9369212,"node_id":"MDQ6VXNlcjkzNjkyMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/9369212?v=4","gravatar_id":"","url":"https://api.github.com/users/WenkaiBai","html_url":"https://github.com/WenkaiBai","followers_url":"https://api.github.com/users/WenkaiBai/followers","following_url":"https://api.github.com/users/WenkaiBai/following{/other_user}","gists_url":"https://api.github.com/users/WenkaiBai/gists{/gist_id}","starred_url":"https://api.github.com/users/WenkaiBai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WenkaiBai/subscriptions","organizations_url":"https://api.github.com/users/WenkaiBai/orgs","repos_url":"https://api.github.com/users/WenkaiBai/repos","events_url":"https://api.github.com/users/WenkaiBai/events{/privacy}","received_events_url":"https://api.github.com/users/WenkaiBai/received_events","type":"User","site_admin":false},"repo":{"id":125950538,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU5NTA1Mzg=","name":"shifu","full_name":"WenkaiBai/shifu","private":false,"owner":{"login":"WenkaiBai","id":9369212,"node_id":"MDQ6VXNlcjkzNjkyMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/9369212?v=4","gravatar_id":"","url":"https://api.github.com/users/WenkaiBai","html_url":"https://github.com/WenkaiBai","followers_url":"https://api.github.com/users/WenkaiBai/followers","following_url":"https://api.github.com/users/WenkaiBai/following{/other_user}","gists_url":"https://api.github.com/users/WenkaiBai/gists{/gist_id}","starred_url":"https://api.github.com/users/WenkaiBai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WenkaiBai/subscriptions","organizations_url":"https://api.github.com/users/WenkaiBai/orgs","repos_url":"https://api.github.com/users/WenkaiBai/repos","events_url":"https://api.github.com/users/WenkaiBai/events{/privacy}","received_events_url":"https://api.github.com/users/WenkaiBai/received_events","type":"User","site_admin":false},"html_url":"https://github.com/WenkaiBai/shifu","description":"An end-to-end machine learning and data mining framework on Hadoop","fork":true,"url":"https://api.github.com/repos/WenkaiBai/shifu","forks_url":"https://api.github.com/repos/WenkaiBai/shifu/forks","keys_url":"https://api.github.com/repos/WenkaiBai/shifu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WenkaiBai/shifu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WenkaiBai/shifu/teams","hooks_url":"https://api.github.com/repos/WenkaiBai/shifu/hooks","issue_events_url":"https://api.github.com/repos/WenkaiBai/shifu/issues/events{/number}","events_url":"https://api.github.com/repos/WenkaiBai/shifu/events","assignees_url":"https://api.github.com/repos/WenkaiBai/shifu/assignees{/user}","branches_url":"https://api.github.com/repos/WenkaiBai/shifu/branches{/branch}","tags_url":"https://api.github.com/repos/WenkaiBai/shifu/tags","blobs_url":"https://api.github.com/repos/WenkaiBai/shifu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WenkaiBai/shifu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WenkaiBai/shifu/git/refs{/sha}","trees_url":"https://api.github.com/repos/WenkaiBai/shifu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WenkaiBai/shifu/statuses/{sha}","languages_url":"https://api.github.com/repos/WenkaiBai/shifu/languages","stargazers_url":"https://api.github.com/repos/WenkaiBai/shifu/stargazers","contributors_url":"https://api.github.com/repos/WenkaiBai/shifu/contributors","subscribers_url":"https://api.github.com/repos/WenkaiBai/shifu/subscribers","subscription_url":"https://api.github.com/repos/WenkaiBai/shifu/subscription","commits_url":"https://api.github.com/repos/WenkaiBai/shifu/commits{/sha}","git_commits_url":"https://api.github.com/repos/WenkaiBai/shifu/git/commits{/sha}","comments_url":"https://api.github.com/repos/WenkaiBai/shifu/comments{/number}","issue_comment_url":"https://api.github.com/repos/WenkaiBai/shifu/issues/comments{/number}","contents_url":"https://api.github.com/repos/WenkaiBai/shifu/contents/{+path}","compare_url":"https://api.github.com/repos/WenkaiBai/shifu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WenkaiBai/shifu/merges","archive_url":"https://api.github.com/repos/WenkaiBai/shifu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WenkaiBai/shifu/downloads","issues_url":"https://api.github.com/repos/WenkaiBai/shifu/issues{/number}","pulls_url":"https://api.github.com/repos/WenkaiBai/shifu/pulls{/number}","milestones_url":"https://api.github.com/repos/WenkaiBai/shifu/milestones{/number}","notifications_url":"https://api.github.com/repos/WenkaiBai/shifu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WenkaiBai/shifu/labels{/name}","releases_url":"https://api.github.com/repos/WenkaiBai/shifu/releases{/id}","deployments_url":"https://api.github.com/repos/WenkaiBai/shifu/deployments","created_at":"2018-03-20T02:41:49Z","updated_at":"2018-03-20T02:41:54Z","pushed_at":"2018-12-20T06:48:35Z","git_url":"git://github.com/WenkaiBai/shifu.git","ssh_url":"git@github.com:WenkaiBai/shifu.git","clone_url":"https://github.com/WenkaiBai/shifu.git","svn_url":"https://github.com/WenkaiBai/shifu","homepage":"https://github.com/ShifuML/shifu/wiki","size":73859,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ShifuML:develop","ref":"develop","sha":"7fc37ad03264bf13c20fe6c094052e315ad82db3","user":{"login":"ShifuML","id":7340945,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNDA5NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7340945?v=4","gravatar_id":"","url":"https://api.github.com/users/ShifuML","html_url":"https://github.com/ShifuML","followers_url":"https://api.github.com/users/ShifuML/followers","following_url":"https://api.github.com/users/ShifuML/following{/other_user}","gists_url":"https://api.github.com/users/ShifuML/gists{/gist_id}","starred_url":"https://api.github.com/users/ShifuML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShifuML/subscriptions","organizations_url":"https://api.github.com/users/ShifuML/orgs","repos_url":"https://api.github.com/users/ShifuML/repos","events_url":"https://api.github.com/users/ShifuML/events{/privacy}","received_events_url":"https://api.github.com/users/ShifuML/received_events","type":"Organization","site_admin":false},"repo":{"id":19008910,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAwODkxMA==","name":"shifu","full_name":"ShifuML/shifu","private":false,"owner":{"login":"ShifuML","id":7340945,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNDA5NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7340945?v=4","gravatar_id":"","url":"https://api.github.com/users/ShifuML","html_url":"https://github.com/ShifuML","followers_url":"https://api.github.com/users/ShifuML/followers","following_url":"https://api.github.com/users/ShifuML/following{/other_user}","gists_url":"https://api.github.com/users/ShifuML/gists{/gist_id}","starred_url":"https://api.github.com/users/ShifuML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShifuML/subscriptions","organizations_url":"https://api.github.com/users/ShifuML/orgs","repos_url":"https://api.github.com/users/ShifuML/repos","events_url":"https://api.github.com/users/ShifuML/events{/privacy}","received_events_url":"https://api.github.com/users/ShifuML/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ShifuML/shifu","description":"An end-to-end machine learning and data mining framework on Hadoop","fork":false,"url":"https://api.github.com/repos/ShifuML/shifu","forks_url":"https://api.github.com/repos/ShifuML/shifu/forks","keys_url":"https://api.github.com/repos/ShifuML/shifu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShifuML/shifu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShifuML/shifu/teams","hooks_url":"https://api.github.com/repos/ShifuML/shifu/hooks","issue_events_url":"https://api.github.com/repos/ShifuML/shifu/issues/events{/number}","events_url":"https://api.github.com/repos/ShifuML/shifu/events","assignees_url":"https://api.github.com/repos/ShifuML/shifu/assignees{/user}","branches_url":"https://api.github.com/repos/ShifuML/shifu/branches{/branch}","tags_url":"https://api.github.com/repos/ShifuML/shifu/tags","blobs_url":"https://api.github.com/repos/ShifuML/shifu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShifuML/shifu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShifuML/shifu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShifuML/shifu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShifuML/shifu/statuses/{sha}","languages_url":"https://api.github.com/repos/ShifuML/shifu/languages","stargazers_url":"https://api.github.com/repos/ShifuML/shifu/stargazers","contributors_url":"https://api.github.com/repos/ShifuML/shifu/contributors","subscribers_url":"https://api.github.com/repos/ShifuML/shifu/subscribers","subscription_url":"https://api.github.com/repos/ShifuML/shifu/subscription","commits_url":"https://api.github.com/repos/ShifuML/shifu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShifuML/shifu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShifuML/shifu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShifuML/shifu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShifuML/shifu/contents/{+path}","compare_url":"https://api.github.com/repos/ShifuML/shifu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShifuML/shifu/merges","archive_url":"https://api.github.com/repos/ShifuML/shifu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShifuML/shifu/downloads","issues_url":"https://api.github.com/repos/ShifuML/shifu/issues{/number}","pulls_url":"https://api.github.com/repos/ShifuML/shifu/pulls{/number}","milestones_url":"https://api.github.com/repos/ShifuML/shifu/milestones{/number}","notifications_url":"https://api.github.com/repos/ShifuML/shifu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShifuML/shifu/labels{/name}","releases_url":"https://api.github.com/repos/ShifuML/shifu/releases{/id}","deployments_url":"https://api.github.com/repos/ShifuML/shifu/deployments","created_at":"2014-04-21T22:21:09Z","updated_at":"2018-12-13T13:52:19Z","pushed_at":"2018-12-29T02:25:48Z","git_url":"git://github.com/ShifuML/shifu.git","ssh_url":"git@github.com:ShifuML/shifu.git","clone_url":"https://github.com/ShifuML/shifu.git","svn_url":"https://github.com/ShifuML/shifu","homepage":"https://github.com/ShifuML/shifu/wiki","size":12925,"stargazers_count":146,"watchers_count":146,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":79,"open_issues":154,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/545"},"html":{"href":"https://github.com/ShifuML/shifu/pull/545"},"issue":{"href":"https://api.github.com/repos/ShifuML/shifu/issues/545"},"comments":{"href":"https://api.github.com/repos/ShifuML/shifu/issues/545/comments"},"review_comments":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/545/comments"},"review_comment":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ShifuML/shifu/pulls/545/commits"},"statuses":{"href":"https://api.github.com/repos/ShifuML/shifu/statuses/16d9b4843c4a2433b958e5192b53d31828749c04"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"zhangpengshan"}}