{"action":"opened","number":4742,"pull_request":{"url":"https://api.github.com/repos/dotnet/docs/pulls/4742","id":176805106,"html_url":"https://github.com/dotnet/docs/pull/4742","diff_url":"https://github.com/dotnet/docs/pull/4742.diff","patch_url":"https://github.com/dotnet/docs/pull/4742.patch","issue_url":"https://api.github.com/repos/dotnet/docs/issues/4742","number":4742,"state":"open","locked":false,"title":"Make Address value object truly immutable. Update implement-value-objects.md","user":{"login":"Alexbits","id":3949302,"avatar_url":"https://avatars2.githubusercontent.com/u/3949302?v=4","gravatar_id":"","url":"https://api.github.com/users/Alexbits","html_url":"https://github.com/Alexbits","followers_url":"https://api.github.com/users/Alexbits/followers","following_url":"https://api.github.com/users/Alexbits/following{/other_user}","gists_url":"https://api.github.com/users/Alexbits/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexbits/subscriptions","organizations_url":"https://api.github.com/users/Alexbits/orgs","repos_url":"https://api.github.com/users/Alexbits/repos","events_url":"https://api.github.com/users/Alexbits/events{/privacy}","received_events_url":"https://api.github.com/users/Alexbits/received_events","type":"User","site_admin":false},"body":"It's better to remove private property setters to make Address value object truly immutable. Otherwise, it's possible to change the object by setting properties inside its methods for example.\r\n\r\n protected override IEnumerable<object> GetAtomicValues()\r\n    {\r\n      Street = \"Blah blah blah\";\r\n      City = \"Blah blah blah\";\r\n\r\n        // Using a yield return statement to return each element one at a time\r\n        yield return Street;\r\n        yield return City;\r\n        yield return State;\r\n        yield return Country;\r\n        yield return ZipCode;\r\n    }\r\n\r\n## Summary\r\n\r\nDescribe your changes here.\r\n\r\nFixes #Issue_Number (if available)\r\n","created_at":"2018-03-22T14:54:55Z","updated_at":"2018-03-22T14:54:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/docs/pulls/4742/commits","review_comments_url":"https://api.github.com/repos/dotnet/docs/pulls/4742/comments","review_comment_url":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/docs/issues/4742/comments","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/c500ca6fbbc1f4483e8940f01580b79890545d46","head":{"label":"Alexbits:patch-1","ref":"patch-1","sha":"c500ca6fbbc1f4483e8940f01580b79890545d46","user":{"login":"Alexbits","id":3949302,"avatar_url":"https://avatars2.githubusercontent.com/u/3949302?v=4","gravatar_id":"","url":"https://api.github.com/users/Alexbits","html_url":"https://github.com/Alexbits","followers_url":"https://api.github.com/users/Alexbits/followers","following_url":"https://api.github.com/users/Alexbits/following{/other_user}","gists_url":"https://api.github.com/users/Alexbits/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexbits/subscriptions","organizations_url":"https://api.github.com/users/Alexbits/orgs","repos_url":"https://api.github.com/users/Alexbits/repos","events_url":"https://api.github.com/users/Alexbits/events{/privacy}","received_events_url":"https://api.github.com/users/Alexbits/received_events","type":"User","site_admin":false},"repo":{"id":126349929,"name":"docs","full_name":"Alexbits/docs","owner":{"login":"Alexbits","id":3949302,"avatar_url":"https://avatars2.githubusercontent.com/u/3949302?v=4","gravatar_id":"","url":"https://api.github.com/users/Alexbits","html_url":"https://github.com/Alexbits","followers_url":"https://api.github.com/users/Alexbits/followers","following_url":"https://api.github.com/users/Alexbits/following{/other_user}","gists_url":"https://api.github.com/users/Alexbits/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexbits/subscriptions","organizations_url":"https://api.github.com/users/Alexbits/orgs","repos_url":"https://api.github.com/users/Alexbits/repos","events_url":"https://api.github.com/users/Alexbits/events{/privacy}","received_events_url":"https://api.github.com/users/Alexbits/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Alexbits/docs","description":"This repository contains .NET Documentation.","fork":true,"url":"https://api.github.com/repos/Alexbits/docs","forks_url":"https://api.github.com/repos/Alexbits/docs/forks","keys_url":"https://api.github.com/repos/Alexbits/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alexbits/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alexbits/docs/teams","hooks_url":"https://api.github.com/repos/Alexbits/docs/hooks","issue_events_url":"https://api.github.com/repos/Alexbits/docs/issues/events{/number}","events_url":"https://api.github.com/repos/Alexbits/docs/events","assignees_url":"https://api.github.com/repos/Alexbits/docs/assignees{/user}","branches_url":"https://api.github.com/repos/Alexbits/docs/branches{/branch}","tags_url":"https://api.github.com/repos/Alexbits/docs/tags","blobs_url":"https://api.github.com/repos/Alexbits/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alexbits/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alexbits/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alexbits/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alexbits/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/Alexbits/docs/languages","stargazers_url":"https://api.github.com/repos/Alexbits/docs/stargazers","contributors_url":"https://api.github.com/repos/Alexbits/docs/contributors","subscribers_url":"https://api.github.com/repos/Alexbits/docs/subscribers","subscription_url":"https://api.github.com/repos/Alexbits/docs/subscription","commits_url":"https://api.github.com/repos/Alexbits/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alexbits/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alexbits/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alexbits/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alexbits/docs/contents/{+path}","compare_url":"https://api.github.com/repos/Alexbits/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alexbits/docs/merges","archive_url":"https://api.github.com/repos/Alexbits/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alexbits/docs/downloads","issues_url":"https://api.github.com/repos/Alexbits/docs/issues{/number}","pulls_url":"https://api.github.com/repos/Alexbits/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/Alexbits/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/Alexbits/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alexbits/docs/labels{/name}","releases_url":"https://api.github.com/repos/Alexbits/docs/releases{/id}","deployments_url":"https://api.github.com/repos/Alexbits/docs/deployments","created_at":"2018-03-22T14:44:15Z","updated_at":"2018-03-22T14:44:19Z","pushed_at":"2018-03-22T14:53:18Z","git_url":"git://github.com/Alexbits/docs.git","ssh_url":"git@github.com:Alexbits/docs.git","clone_url":"https://github.com/Alexbits/docs.git","svn_url":"https://github.com/Alexbits/docs","homepage":"https://docs.microsoft.com/dotnet","size":492529,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"3c17cc1aab6bfe55fe346c64f636df9bec7db7c4","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35890081,"name":"docs","full_name":"dotnet/docs","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/docs","description":"This repository contains .NET Documentation.","fork":false,"url":"https://api.github.com/repos/dotnet/docs","forks_url":"https://api.github.com/repos/dotnet/docs/forks","keys_url":"https://api.github.com/repos/dotnet/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/docs/teams","hooks_url":"https://api.github.com/repos/dotnet/docs/hooks","issue_events_url":"https://api.github.com/repos/dotnet/docs/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/docs/events","assignees_url":"https://api.github.com/repos/dotnet/docs/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/docs/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/docs/tags","blobs_url":"https://api.github.com/repos/dotnet/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/docs/languages","stargazers_url":"https://api.github.com/repos/dotnet/docs/stargazers","contributors_url":"https://api.github.com/repos/dotnet/docs/contributors","subscribers_url":"https://api.github.com/repos/dotnet/docs/subscribers","subscription_url":"https://api.github.com/repos/dotnet/docs/subscription","commits_url":"https://api.github.com/repos/dotnet/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/docs/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/docs/merges","archive_url":"https://api.github.com/repos/dotnet/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/docs/downloads","issues_url":"https://api.github.com/repos/dotnet/docs/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/docs/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/docs/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/docs/deployments","created_at":"2015-05-19T15:13:32Z","updated_at":"2018-03-22T14:27:39Z","pushed_at":"2018-03-22T14:27:31Z","git_url":"git://github.com/dotnet/docs.git","ssh_url":"git@github.com:dotnet/docs.git","clone_url":"https://github.com/dotnet/docs.git","svn_url":"https://github.com/dotnet/docs","homepage":"https://docs.microsoft.com/dotnet","size":492529,"stargazers_count":946,"watchers_count":946,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2197,"mirror_url":null,"archived":false,"open_issues_count":385,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2197,"open_issues":385,"watchers":946,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/4742"},"html":{"href":"https://github.com/dotnet/docs/pull/4742"},"issue":{"href":"https://api.github.com/repos/dotnet/docs/issues/4742"},"comments":{"href":"https://api.github.com/repos/dotnet/docs/issues/4742/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/docs/pulls/4742/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/docs/pulls/4742/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/docs/statuses/c500ca6fbbc1f4483e8940f01580b79890545d46"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":5,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"Alexbits"}}