{"action":"created","comment":{"url":"https://api.github.com/repos/dashpay/dips/pulls/comments/232176779","pull_request_review_id":173316425,"id":232176779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjE3Njc3OQ==","diff_hunk":"@@ -110,23 +110,26 @@ We chose to enforce distinct messages when signing with a secret key. Dash’s i\n \n ## BLS Curves used\n \n-The BLS signature scheme requires pairing-friendly curves to be used. Multiple curves with different security, performance and space characteristics have been proposed by different parties. At the time this document was written, no decision had been made as to which curve would be used.\n-\n-However, the choice of the specific curve should have no influence on the scheme itself, how BLS is used or what is possible.\n-\n-This document will be updated when a decision has been made on which curve to use.\n+The BLS signature scheme requires pairing-friendly curves to be used, of which only a few suitable exist. Dash is\n+using the BLS12-381 with reversed G1 and G2 groups. A specification can be found in the Chia [bls-signatures](https://github.com/Chia-Network/bls-signatures/blob/master/SPEC.md)\n+repository.\n \n ## Serialization format of BLS primitives\n \n-It is necessary to serialize BLS primitives into a byte representation so that they can be used inside other serialized data structures. How this is performed depends on the curves and libraries used. This has not been defined yet and this document will be updated later.\n+It is necessary to serialize BLS primitives into a byte representation so that they can be used inside other serialized data structures.\n+The serialization format is described in the Chia [bls-signatures](https://github.com/Chia-Network/bls-signatures/blob/master/SPEC.md)\n+repository.\n \n-Until then, all DIPs will use placeholders types for the BLS primitives and assume a fixed size. These placeholder type are:\n+The size of individual BLS primitives is fixed:\n \n | Type | Size | Description |\n | -- | -- | -- |\n | BLSSecKey | 32 | BLS secret key\n-| BLSPubKey |64 | BLS public key\n-| BLSSig |32 | BLS signature\n+| BLSPubKey | 48 | BLS public key\n+| BLSSig | 96 | BLS signature\n+\n+Please note that there is no length field before the primitives serialized data. This is different from ECDSA signatures\n+where a compact size integere is prepended.","path":"dip-0006/bls_signature_scheme.md","position":null,"original_position":32,"commit_id":"ba96b791ff816d8d223ebe40f81c65279882ddbc","original_commit_id":"8636fd328800c2fbfbe747bbd8fa8ae10462a4d5","user":{"login":"codablock","id":1884269,"node_id":"MDQ6VXNlcjE4ODQyNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1884269?v=4","gravatar_id":"","url":"https://api.github.com/users/codablock","html_url":"https://github.com/codablock","followers_url":"https://api.github.com/users/codablock/followers","following_url":"https://api.github.com/users/codablock/following{/other_user}","gists_url":"https://api.github.com/users/codablock/gists{/gist_id}","starred_url":"https://api.github.com/users/codablock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codablock/subscriptions","organizations_url":"https://api.github.com/users/codablock/orgs","repos_url":"https://api.github.com/users/codablock/repos","events_url":"https://api.github.com/users/codablock/events{/privacy}","received_events_url":"https://api.github.com/users/codablock/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-11-09T08:46:24Z","updated_at":"2018-11-09T08:46:24Z","html_url":"https://github.com/dashpay/dips/pull/25#discussion_r232176779","pull_request_url":"https://api.github.com/repos/dashpay/dips/pulls/25","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dashpay/dips/pulls/comments/232176779"},"html":{"href":"https://github.com/dashpay/dips/pull/25#discussion_r232176779"},"pull_request":{"href":"https://api.github.com/repos/dashpay/dips/pulls/25"}},"in_reply_to_id":228581039},"pull_request":{"url":"https://api.github.com/repos/dashpay/dips/pulls/25","id":225982032,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTgyMDMy","html_url":"https://github.com/dashpay/dips/pull/25","diff_url":"https://github.com/dashpay/dips/pull/25.diff","patch_url":"https://github.com/dashpay/dips/pull/25.patch","issue_url":"https://api.github.com/repos/dashpay/dips/issues/25","number":25,"state":"open","locked":false,"title":"Update DIPs regarding use of BLS12-381-reversed","user":{"login":"codablock","id":1884269,"node_id":"MDQ6VXNlcjE4ODQyNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1884269?v=4","gravatar_id":"","url":"https://api.github.com/users/codablock","html_url":"https://github.com/codablock","followers_url":"https://api.github.com/users/codablock/followers","following_url":"https://api.github.com/users/codablock/following{/other_user}","gists_url":"https://api.github.com/users/codablock/gists{/gist_id}","starred_url":"https://api.github.com/users/codablock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codablock/subscriptions","organizations_url":"https://api.github.com/users/codablock/orgs","repos_url":"https://api.github.com/users/codablock/repos","events_url":"https://api.github.com/users/codablock/events{/privacy}","received_events_url":"https://api.github.com/users/codablock/received_events","type":"User","site_admin":false},"body":"See individual commits.\r\n\r\nCloses #23 ","created_at":"2018-10-26T05:41:53Z","updated_at":"2018-11-09T08:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2081dd72d983b6226eee1f93d34732194a9cfcea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dashpay/dips/pulls/25/commits","review_comments_url":"https://api.github.com/repos/dashpay/dips/pulls/25/comments","review_comment_url":"https://api.github.com/repos/dashpay/dips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dashpay/dips/issues/25/comments","statuses_url":"https://api.github.com/repos/dashpay/dips/statuses/ba96b791ff816d8d223ebe40f81c65279882ddbc","head":{"label":"dashpay:codablock-bls-patch","ref":"codablock-bls-patch","sha":"ba96b791ff816d8d223ebe40f81c65279882ddbc","user":{"login":"dashpay","id":11511719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTExNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/11511719?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"repo":{"id":96351649,"node_id":"MDEwOlJlcG9zaXRvcnk5NjM1MTY0OQ==","name":"dips","full_name":"dashpay/dips","private":false,"owner":{"login":"dashpay","id":11511719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTExNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/11511719?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dashpay/dips","description":"Dash Improvement Proposals","fork":false,"url":"https://api.github.com/repos/dashpay/dips","forks_url":"https://api.github.com/repos/dashpay/dips/forks","keys_url":"https://api.github.com/repos/dashpay/dips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dashpay/dips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dashpay/dips/teams","hooks_url":"https://api.github.com/repos/dashpay/dips/hooks","issue_events_url":"https://api.github.com/repos/dashpay/dips/issues/events{/number}","events_url":"https://api.github.com/repos/dashpay/dips/events","assignees_url":"https://api.github.com/repos/dashpay/dips/assignees{/user}","branches_url":"https://api.github.com/repos/dashpay/dips/branches{/branch}","tags_url":"https://api.github.com/repos/dashpay/dips/tags","blobs_url":"https://api.github.com/repos/dashpay/dips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dashpay/dips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dashpay/dips/git/refs{/sha}","trees_url":"https://api.github.com/repos/dashpay/dips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dashpay/dips/statuses/{sha}","languages_url":"https://api.github.com/repos/dashpay/dips/languages","stargazers_url":"https://api.github.com/repos/dashpay/dips/stargazers","contributors_url":"https://api.github.com/repos/dashpay/dips/contributors","subscribers_url":"https://api.github.com/repos/dashpay/dips/subscribers","subscription_url":"https://api.github.com/repos/dashpay/dips/subscription","commits_url":"https://api.github.com/repos/dashpay/dips/commits{/sha}","git_commits_url":"https://api.github.com/repos/dashpay/dips/git/commits{/sha}","comments_url":"https://api.github.com/repos/dashpay/dips/comments{/number}","issue_comment_url":"https://api.github.com/repos/dashpay/dips/issues/comments{/number}","contents_url":"https://api.github.com/repos/dashpay/dips/contents/{+path}","compare_url":"https://api.github.com/repos/dashpay/dips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dashpay/dips/merges","archive_url":"https://api.github.com/repos/dashpay/dips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dashpay/dips/downloads","issues_url":"https://api.github.com/repos/dashpay/dips/issues{/number}","pulls_url":"https://api.github.com/repos/dashpay/dips/pulls{/number}","milestones_url":"https://api.github.com/repos/dashpay/dips/milestones{/number}","notifications_url":"https://api.github.com/repos/dashpay/dips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dashpay/dips/labels{/name}","releases_url":"https://api.github.com/repos/dashpay/dips/releases{/id}","deployments_url":"https://api.github.com/repos/dashpay/dips/deployments","created_at":"2017-07-05T18:56:24Z","updated_at":"2018-10-26T20:17:17Z","pushed_at":"2018-10-29T08:41:24Z","git_url":"git://github.com/dashpay/dips.git","ssh_url":"git@github.com:dashpay/dips.git","clone_url":"https://github.com/dashpay/dips.git","svn_url":"https://github.com/dashpay/dips","homepage":"","size":318,"stargazers_count":13,"watchers_count":13,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":5,"watchers":13,"default_branch":"master"}},"base":{"label":"dashpay:master","ref":"master","sha":"e19f4a5c4e2e61b416ec51270f481d1554dfc70d","user":{"login":"dashpay","id":11511719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTExNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/11511719?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"repo":{"id":96351649,"node_id":"MDEwOlJlcG9zaXRvcnk5NjM1MTY0OQ==","name":"dips","full_name":"dashpay/dips","private":false,"owner":{"login":"dashpay","id":11511719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTExNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/11511719?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dashpay/dips","description":"Dash Improvement Proposals","fork":false,"url":"https://api.github.com/repos/dashpay/dips","forks_url":"https://api.github.com/repos/dashpay/dips/forks","keys_url":"https://api.github.com/repos/dashpay/dips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dashpay/dips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dashpay/dips/teams","hooks_url":"https://api.github.com/repos/dashpay/dips/hooks","issue_events_url":"https://api.github.com/repos/dashpay/dips/issues/events{/number}","events_url":"https://api.github.com/repos/dashpay/dips/events","assignees_url":"https://api.github.com/repos/dashpay/dips/assignees{/user}","branches_url":"https://api.github.com/repos/dashpay/dips/branches{/branch}","tags_url":"https://api.github.com/repos/dashpay/dips/tags","blobs_url":"https://api.github.com/repos/dashpay/dips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dashpay/dips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dashpay/dips/git/refs{/sha}","trees_url":"https://api.github.com/repos/dashpay/dips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dashpay/dips/statuses/{sha}","languages_url":"https://api.github.com/repos/dashpay/dips/languages","stargazers_url":"https://api.github.com/repos/dashpay/dips/stargazers","contributors_url":"https://api.github.com/repos/dashpay/dips/contributors","subscribers_url":"https://api.github.com/repos/dashpay/dips/subscribers","subscription_url":"https://api.github.com/repos/dashpay/dips/subscription","commits_url":"https://api.github.com/repos/dashpay/dips/commits{/sha}","git_commits_url":"https://api.github.com/repos/dashpay/dips/git/commits{/sha}","comments_url":"https://api.github.com/repos/dashpay/dips/comments{/number}","issue_comment_url":"https://api.github.com/repos/dashpay/dips/issues/comments{/number}","contents_url":"https://api.github.com/repos/dashpay/dips/contents/{+path}","compare_url":"https://api.github.com/repos/dashpay/dips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dashpay/dips/merges","archive_url":"https://api.github.com/repos/dashpay/dips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dashpay/dips/downloads","issues_url":"https://api.github.com/repos/dashpay/dips/issues{/number}","pulls_url":"https://api.github.com/repos/dashpay/dips/pulls{/number}","milestones_url":"https://api.github.com/repos/dashpay/dips/milestones{/number}","notifications_url":"https://api.github.com/repos/dashpay/dips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dashpay/dips/labels{/name}","releases_url":"https://api.github.com/repos/dashpay/dips/releases{/id}","deployments_url":"https://api.github.com/repos/dashpay/dips/deployments","created_at":"2017-07-05T18:56:24Z","updated_at":"2018-10-26T20:17:17Z","pushed_at":"2018-10-29T08:41:24Z","git_url":"git://github.com/dashpay/dips.git","ssh_url":"git@github.com:dashpay/dips.git","clone_url":"https://github.com/dashpay/dips.git","svn_url":"https://github.com/dashpay/dips","homepage":"","size":318,"stargazers_count":13,"watchers_count":13,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":5,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dashpay/dips/pulls/25"},"html":{"href":"https://github.com/dashpay/dips/pull/25"},"issue":{"href":"https://api.github.com/repos/dashpay/dips/issues/25"},"comments":{"href":"https://api.github.com/repos/dashpay/dips/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/dashpay/dips/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/dashpay/dips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dashpay/dips/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/dashpay/dips/statuses/ba96b791ff816d8d223ebe40f81c65279882ddbc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"codablock"}}