{"action":"closed","issue":{"url":"https://api.github.com/repos/envoyproxy/java-control-plane/issues/67","repository_url":"https://api.github.com/repos/envoyproxy/java-control-plane","labels_url":"https://api.github.com/repos/envoyproxy/java-control-plane/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/envoyproxy/java-control-plane/issues/67/comments","events_url":"https://api.github.com/repos/envoyproxy/java-control-plane/issues/67/events","html_url":"https://github.com/envoyproxy/java-control-plane/issues/67","id":355835630,"node_id":"MDU6SXNzdWUzNTU4MzU2MzA=","number":67,"title":"TCP Proxy's route not implementes yet ?","user":{"login":"leader-us","id":5953348,"node_id":"MDQ6VXNlcjU5NTMzNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/5953348?v=4","gravatar_id":"","url":"https://api.github.com/users/leader-us","html_url":"https://github.com/leader-us","followers_url":"https://api.github.com/users/leader-us/followers","following_url":"https://api.github.com/users/leader-us/following{/other_user}","gists_url":"https://api.github.com/users/leader-us/gists{/gist_id}","starred_url":"https://api.github.com/users/leader-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leader-us/subscriptions","organizations_url":"https://api.github.com/users/leader-us/orgs","repos_url":"https://api.github.com/users/leader-us/repos","events_url":"https://api.github.com/users/leader-us/events{/privacy}","received_events_url":"https://api.github.com/users/leader-us/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-31T04:26:57Z","updated_at":"2018-12-10T17:47:14Z","closed_at":"2018-12-10T17:47:14Z","author_association":"NONE","body":" * <pre>\r\n     * TCP Proxy filter configuration using deprecated V1 format. This is required for complex\r\n     * routing until filter chain matching in the listener is implemented.\r\n     * .. attention::\r\n     *   Using this field will lead to `problems loading the configuration\r\n     *   &lt;https://github.com/envoyproxy/envoy/issues/2441&gt;`_. If you want to configure the filter\r\n     *   using v1 config structure, please make this field a boolean with value ``true`` and configure\r\n     *   via the opaque ``value`` field like is suggested in :api:`envoy/config/filter/README.md`.\r\n     * </pre>\r\n     *\r\n     * <code>.envoy.config.filter.network.tcp_proxy.v2.TcpProxy.DeprecatedV1 deprecated_v1 = 6 [deprecated = true];</code>\r\n     */\r\n    @java.lang.Deprecated public envoy.config.filter.network.tcp_proxy.v2.TcpProxyOuterClass.TcpProxy.DeprecatedV1OrBuilder getDeprecatedV1OrBuilder() {\r\n      return getDeprecatedV1();\r\n    }\r\n\r\nso the following code can't work ?\r\n\r\nenvoy.config.filter.network.tcp_proxy.v2.TcpProxyOuterClass.TcpProxy.Builder tcpProxyBuilder=envoy.config.filter.network.tcp_proxy.v2.TcpProxyOuterClass.TcpProxy.newBuilder();\r\n\t\tenvoy.config.filter.network.tcp_proxy.v2.TcpProxyOuterClass.TcpProxy.DeprecatedV1.Builder routeBuiler=tcpProxyBuilder.setStatPrefix(\"ingress_tcp\").getDeprecatedV1Builder();\r\n\t\trouteBuiler.addRoutes(value)\r\n"}}
{"actor":{"display_login":"joeyb"}}