{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments/191133785","pull_request_review_id":123637750,"id":191133785,"diff_hunk":"@@ -75,7 +76,9 @@ def add_prefix_nodes_and_verify(state, prefix, keys_suffices=None):\n     for k, v in key_vals.items():\n         state.set(k, v)\n \n-    prefix_prf = state.generate_state_proof_for_key_prfx(prefix.encode())\n+    prefix_prf, val = state.generate_state_proof_for_keys_with_prefix(prefix.encode(), get_value=True)","path":"state/test/test_state_proof_verification.py","position":13,"original_position":13,"commit_id":"9ff1b8f32e5f509a488571f8fbcecf86fa8379f4","original_commit_id":"9ff1b8f32e5f509a488571f8fbcecf86fa8379f4","user":{"login":"ashcherbakov","id":21102430,"avatar_url":"https://avatars1.githubusercontent.com/u/21102430?v=4","gravatar_id":"","url":"https://api.github.com/users/ashcherbakov","html_url":"https://github.com/ashcherbakov","followers_url":"https://api.github.com/users/ashcherbakov/followers","following_url":"https://api.github.com/users/ashcherbakov/following{/other_user}","gists_url":"https://api.github.com/users/ashcherbakov/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcherbakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcherbakov/subscriptions","organizations_url":"https://api.github.com/users/ashcherbakov/orgs","repos_url":"https://api.github.com/users/ashcherbakov/repos","events_url":"https://api.github.com/users/ashcherbakov/events{/privacy}","received_events_url":"https://api.github.com/users/ashcherbakov/received_events","type":"User","site_admin":false},"body":"Do we have a test where `get_value=False`?","created_at":"2018-05-28T07:43:43Z","updated_at":"2018-05-28T07:58:28Z","html_url":"https://github.com/hyperledger/indy-plenum/pull/700#discussion_r191133785","pull_request_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/700","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments/191133785"},"html":{"href":"https://github.com/hyperledger/indy-plenum/pull/700#discussion_r191133785"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/700"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/700","id":190115994,"html_url":"https://github.com/hyperledger/indy-plenum/pull/700","diff_url":"https://github.com/hyperledger/indy-plenum/pull/700.diff","patch_url":"https://github.com/hyperledger/indy-plenum/pull/700.patch","issue_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/700","number":700,"state":"open","locked":false,"title":"State proof optimisation","user":{"login":"lovesh","id":3115401,"avatar_url":"https://avatars0.githubusercontent.com/u/3115401?v=4","gravatar_id":"","url":"https://api.github.com/users/lovesh","html_url":"https://github.com/lovesh","followers_url":"https://api.github.com/users/lovesh/followers","following_url":"https://api.github.com/users/lovesh/following{/other_user}","gists_url":"https://api.github.com/users/lovesh/gists{/gist_id}","starred_url":"https://api.github.com/users/lovesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovesh/subscriptions","organizations_url":"https://api.github.com/users/lovesh/orgs","repos_url":"https://api.github.com/users/lovesh/repos","events_url":"https://api.github.com/users/lovesh/events{/privacy}","received_events_url":"https://api.github.com/users/lovesh/received_events","type":"User","site_admin":false},"body":"Lot of Indy node queries like for GET_SCHEMA, GET_ATTR, GET_CLAIM_DEF, GET_REVOC_DEF, GET_REVOC_REG_ENTRY call a method named [lookup](https://github.com/hyperledger/indy-node/blob/master/indy_node/server/domain_req_handler.py#L675) which calls a `get` on the trie and then a proof creation (`make_proof`) on the trie. This is redundant as the proof creation again traverses the path like `get` did. This change enables returning a poof with a value so that the path is traversed only once.  \r\nA better way would be to have that trie's `get` method have an option to return proof too with the value but that will cause a lot of changes so avoiding it for now","created_at":"2018-05-23T21:54:42Z","updated_at":"2018-05-28T07:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7ff7d5e632ff6b17bd5939a49825a731ff12f83","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/700/commits","review_comments_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/700/comments","review_comment_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/700/comments","statuses_url":"https://api.github.com/repos/hyperledger/indy-plenum/statuses/9ff1b8f32e5f509a488571f8fbcecf86fa8379f4","head":{"label":"evernym:state-proof-optmz","ref":"state-proof-optmz","sha":"9ff1b8f32e5f509a488571f8fbcecf86fa8379f4","user":{"login":"evernym","id":10112210,"avatar_url":"https://avatars3.githubusercontent.com/u/10112210?v=4","gravatar_id":"","url":"https://api.github.com/users/evernym","html_url":"https://github.com/evernym","followers_url":"https://api.github.com/users/evernym/followers","following_url":"https://api.github.com/users/evernym/following{/other_user}","gists_url":"https://api.github.com/users/evernym/gists{/gist_id}","starred_url":"https://api.github.com/users/evernym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evernym/subscriptions","organizations_url":"https://api.github.com/users/evernym/orgs","repos_url":"https://api.github.com/users/evernym/repos","events_url":"https://api.github.com/users/evernym/events{/privacy}","received_events_url":"https://api.github.com/users/evernym/received_events","type":"Organization","site_admin":false},"repo":{"id":96820649,"name":"indy-plenum","full_name":"evernym/indy-plenum","owner":{"login":"evernym","id":10112210,"avatar_url":"https://avatars3.githubusercontent.com/u/10112210?v=4","gravatar_id":"","url":"https://api.github.com/users/evernym","html_url":"https://github.com/evernym","followers_url":"https://api.github.com/users/evernym/followers","following_url":"https://api.github.com/users/evernym/following{/other_user}","gists_url":"https://api.github.com/users/evernym/gists{/gist_id}","starred_url":"https://api.github.com/users/evernym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evernym/subscriptions","organizations_url":"https://api.github.com/users/evernym/orgs","repos_url":"https://api.github.com/users/evernym/repos","events_url":"https://api.github.com/users/evernym/events{/privacy}","received_events_url":"https://api.github.com/users/evernym/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/evernym/indy-plenum","description":"Plenum Byzantine Fault Tolerant Protocol","fork":true,"url":"https://api.github.com/repos/evernym/indy-plenum","forks_url":"https://api.github.com/repos/evernym/indy-plenum/forks","keys_url":"https://api.github.com/repos/evernym/indy-plenum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evernym/indy-plenum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evernym/indy-plenum/teams","hooks_url":"https://api.github.com/repos/evernym/indy-plenum/hooks","issue_events_url":"https://api.github.com/repos/evernym/indy-plenum/issues/events{/number}","events_url":"https://api.github.com/repos/evernym/indy-plenum/events","assignees_url":"https://api.github.com/repos/evernym/indy-plenum/assignees{/user}","branches_url":"https://api.github.com/repos/evernym/indy-plenum/branches{/branch}","tags_url":"https://api.github.com/repos/evernym/indy-plenum/tags","blobs_url":"https://api.github.com/repos/evernym/indy-plenum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evernym/indy-plenum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evernym/indy-plenum/git/refs{/sha}","trees_url":"https://api.github.com/repos/evernym/indy-plenum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evernym/indy-plenum/statuses/{sha}","languages_url":"https://api.github.com/repos/evernym/indy-plenum/languages","stargazers_url":"https://api.github.com/repos/evernym/indy-plenum/stargazers","contributors_url":"https://api.github.com/repos/evernym/indy-plenum/contributors","subscribers_url":"https://api.github.com/repos/evernym/indy-plenum/subscribers","subscription_url":"https://api.github.com/repos/evernym/indy-plenum/subscription","commits_url":"https://api.github.com/repos/evernym/indy-plenum/commits{/sha}","git_commits_url":"https://api.github.com/repos/evernym/indy-plenum/git/commits{/sha}","comments_url":"https://api.github.com/repos/evernym/indy-plenum/comments{/number}","issue_comment_url":"https://api.github.com/repos/evernym/indy-plenum/issues/comments{/number}","contents_url":"https://api.github.com/repos/evernym/indy-plenum/contents/{+path}","compare_url":"https://api.github.com/repos/evernym/indy-plenum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evernym/indy-plenum/merges","archive_url":"https://api.github.com/repos/evernym/indy-plenum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evernym/indy-plenum/downloads","issues_url":"https://api.github.com/repos/evernym/indy-plenum/issues{/number}","pulls_url":"https://api.github.com/repos/evernym/indy-plenum/pulls{/number}","milestones_url":"https://api.github.com/repos/evernym/indy-plenum/milestones{/number}","notifications_url":"https://api.github.com/repos/evernym/indy-plenum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evernym/indy-plenum/labels{/name}","releases_url":"https://api.github.com/repos/evernym/indy-plenum/releases{/id}","deployments_url":"https://api.github.com/repos/evernym/indy-plenum/deployments","created_at":"2017-07-10T20:57:19Z","updated_at":"2018-05-25T14:13:48Z","pushed_at":"2018-05-28T02:39:11Z","git_url":"git://github.com/evernym/indy-plenum.git","ssh_url":"git@github.com:evernym/indy-plenum.git","clone_url":"https://github.com/evernym/indy-plenum.git","svn_url":"https://github.com/evernym/indy-plenum","homepage":"","size":9199,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"8d3340f4e8de63413687bdc1fc1ed0a082bbbf0b","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":51585028,"name":"indy-plenum","full_name":"hyperledger/indy-plenum","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/indy-plenum","description":"Plenum Byzantine Fault Tolerant Protocol","fork":false,"url":"https://api.github.com/repos/hyperledger/indy-plenum","forks_url":"https://api.github.com/repos/hyperledger/indy-plenum/forks","keys_url":"https://api.github.com/repos/hyperledger/indy-plenum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/indy-plenum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/indy-plenum/teams","hooks_url":"https://api.github.com/repos/hyperledger/indy-plenum/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/indy-plenum/events","assignees_url":"https://api.github.com/repos/hyperledger/indy-plenum/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/indy-plenum/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/indy-plenum/tags","blobs_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/indy-plenum/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/indy-plenum/languages","stargazers_url":"https://api.github.com/repos/hyperledger/indy-plenum/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/indy-plenum/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/indy-plenum/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/indy-plenum/subscription","commits_url":"https://api.github.com/repos/hyperledger/indy-plenum/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/indy-plenum/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/indy-plenum/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/indy-plenum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/indy-plenum/merges","archive_url":"https://api.github.com/repos/hyperledger/indy-plenum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/indy-plenum/downloads","issues_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/indy-plenum/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/indy-plenum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/indy-plenum/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/indy-plenum/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/indy-plenum/deployments","created_at":"2016-02-12T12:03:16Z","updated_at":"2018-05-28T06:32:29Z","pushed_at":"2018-05-28T06:58:37Z","git_url":"git://github.com/hyperledger/indy-plenum.git","ssh_url":"git@github.com:hyperledger/indy-plenum.git","clone_url":"https://github.com/hyperledger/indy-plenum.git","svn_url":"https://github.com/hyperledger/indy-plenum","homepage":"","size":8982,"stargazers_count":111,"watchers_count":111,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":134,"open_issues":8,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/700"},"html":{"href":"https://github.com/hyperledger/indy-plenum/pull/700"},"issue":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/issues/700"},"comments":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/issues/700/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/700/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/700/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/statuses/9ff1b8f32e5f509a488571f8fbcecf86fa8379f4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ashcherbakov"}}