{"action":"created","issue":{"url":"https://api.github.com/repos/pxscene/pxCore/issues/1428","repository_url":"https://api.github.com/repos/pxscene/pxCore","labels_url":"https://api.github.com/repos/pxscene/pxCore/issues/1428/labels{/name}","comments_url":"https://api.github.com/repos/pxscene/pxCore/issues/1428/comments","events_url":"https://api.github.com/repos/pxscene/pxCore/issues/1428/events","html_url":"https://github.com/pxscene/pxCore/pull/1428","id":357147579,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjMwMzY4","number":1428,"title":"fix error: unused variable ‘v’ and parameter 'result'","user":{"login":"dwrobel","id":228873,"node_id":"MDQ6VXNlcjIyODg3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/228873?v=4","gravatar_id":"","url":"https://api.github.com/users/dwrobel","html_url":"https://github.com/dwrobel","followers_url":"https://api.github.com/users/dwrobel/followers","following_url":"https://api.github.com/users/dwrobel/following{/other_user}","gists_url":"https://api.github.com/users/dwrobel/gists{/gist_id}","starred_url":"https://api.github.com/users/dwrobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwrobel/subscriptions","organizations_url":"https://api.github.com/users/dwrobel/orgs","repos_url":"https://api.github.com/users/dwrobel/repos","events_url":"https://api.github.com/users/dwrobel/events{/privacy}","received_events_url":"https://api.github.com/users/dwrobel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-05T09:41:09Z","updated_at":"2018-09-05T11:11:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pxscene/pxCore/pulls/1428","html_url":"https://github.com/pxscene/pxCore/pull/1428","diff_url":"https://github.com/pxscene/pxCore/pull/1428.diff","patch_url":"https://github.com/pxscene/pxCore/pull/1428.patch"},"body":"    Fixes the following errors:\r\n    \r\n    pxCore/examples/pxScene2d/src/pxScene2d.cpp: In static member function ‘static rtError pxScriptView::printFunc(int, const rtValue*, rtValue*, void*)’:\r\n    pxscene/pxCore/examples/pxScene2d/src/pxScene2d.cpp:3941:19: error: unused variable ‘v’ [-Werror=unused-variable]\r\n         pxScriptView* v = (pxScriptView*)ctx;\r\n                       ^\r\n    cc1plus: all warnings being treated as errors\r\n    \r\n    and\r\n    \r\n    pxCore/examples/pxScene2d/src/pxScene2d.cpp:3935:76: error: unused parameter 'result' [-Werror,-Wunused-parameter]\r\n    rtError pxScriptView::printFunc(int numArgs, const rtValue* args, rtValue* result, void* ctx)\r\n                                                                               ^\r\n    1 error generated."},"comment":{"url":"https://api.github.com/repos/pxscene/pxCore/issues/comments/418692651","html_url":"https://github.com/pxscene/pxCore/pull/1428#issuecomment-418692651","issue_url":"https://api.github.com/repos/pxscene/pxCore/issues/1428","id":418692651,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODY5MjY1MQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-05T11:11:12Z","updated_at":"2018-09-05T11:11:12Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/pxscene/pxCore/pull/1428?src=pr&el=h1) Report\n> Merging [#1428](https://codecov.io/gh/pxscene/pxCore/pull/1428?src=pr&el=desc) into [master](https://codecov.io/gh/pxscene/pxCore/commit/8d46165ca4911d9152c0ca3889fa16f18e2e9c12?src=pr&el=desc) will **decrease** coverage by `1.03%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/pxscene/pxCore/pull/1428/graphs/tree.svg?width=650&token=2LynLkOnRy&height=150&src=pr)](https://codecov.io/gh/pxscene/pxCore/pull/1428?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1428      +/-   ##\n==========================================\n- Coverage   75.51%   74.47%   -1.04%     \n==========================================\n  Files         113      122       +9     \n  Lines       14663    16726    +2063     \n==========================================\n+ Hits        11073    12457    +1384     \n- Misses       3590     4269     +679\n```\n\n\n| [Impacted Files](https://codecov.io/gh/pxscene/pxCore/pull/1428?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [examples/pxScene2d/src/pxScene2d.cpp](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvcHhTY2VuZTJkL3NyYy9weFNjZW5lMmQuY3Bw) | `67.2% <ø> (-0.05%)` | :arrow_down: |\n| [src/rtScriptV8/rtFunctionWrapper.h](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree#diff-c3JjL3J0U2NyaXB0VjgvcnRGdW5jdGlvbldyYXBwZXIuaA==) | `56.52% <0%> (-10.15%)` | :arrow_down: |\n| [src/rtThreadTask.cpp](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree#diff-c3JjL3J0VGhyZWFkVGFzay5jcHA=) | `87.5% <0%> (-4.17%)` | :arrow_down: |\n| [examples/pxScene2d/src/pxText.h](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvcHhTY2VuZTJkL3NyYy9weFRleHQuaA==) | `91.42% <0%> (-2.12%)` | :arrow_down: |\n| [src/rtObject.h](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree#diff-c3JjL3J0T2JqZWN0Lmg=) | `88.7% <0%> (-1.9%)` | :arrow_down: |\n| [src/rtScript.cpp](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree#diff-c3JjL3J0U2NyaXB0LmNwcA==) | `85.71% <0%> (-1.47%)` | :arrow_down: |\n| [examples/pxScene2d/src/pxImage.cpp](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvcHhTY2VuZTJkL3NyYy9weEltYWdlLmNwcA==) | `82.88% <0%> (-1.26%)` | :arrow_down: |\n| [examples/pxScene2d/src/pxScene2d.h](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvcHhTY2VuZTJkL3NyYy9weFNjZW5lMmQuaA==) | `71.86% <0%> (-1.04%)` | :arrow_down: |\n| [examples/pxScene2d/src/pxImageA.cpp](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvcHhTY2VuZTJkL3NyYy9weEltYWdlQS5jcHA=) | `91.75% <0%> (-1.02%)` | :arrow_down: |\n| [examples/pxScene2d/src/Spark.cpp](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvcHhTY2VuZTJkL3NyYy9TcGFyay5jcHA=) | `65.41% <0%> (-0.63%)` | :arrow_down: |\n| ... and [84 more](https://codecov.io/gh/pxscene/pxCore/pull/1428/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/pxscene/pxCore/pull/1428?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/pxscene/pxCore/pull/1428?src=pr&el=footer). Last update [8d46165...04f2659](https://codecov.io/gh/pxscene/pxCore/pull/1428?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}