{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/167406872","pull_request_review_id":95629405,"id":167406872,"diff_hunk":"@@ -83,6 +71,15 @@ def setup_platform(hass, config, add_devices, discovery_info=None):\n \n     api_key = config.get(CONF_API_KEY)\n     symbols = config.get(CONF_SYMBOLS)\n+    conversions = config.get(CONF_FOREIGN_EXCHANGE)\n+\n+    if (symbols is None or len(symbols) == 0) and \\","path":"homeassistant/components/sensor/alpha_vantage.py","position":null,"original_position":45,"commit_id":"e40bd37d275798358979d54a78b6e979b5ef452d","original_commit_id":"154883097e6eea299e93335613c811357db26507","user":{"login":"ChristianKuehnel","id":19961352,"avatar_url":"https://avatars2.githubusercontent.com/u/19961352?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianKuehnel","html_url":"https://github.com/ChristianKuehnel","followers_url":"https://api.github.com/users/ChristianKuehnel/followers","following_url":"https://api.github.com/users/ChristianKuehnel/following{/other_user}","gists_url":"https://api.github.com/users/ChristianKuehnel/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianKuehnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianKuehnel/subscriptions","organizations_url":"https://api.github.com/users/ChristianKuehnel/orgs","repos_url":"https://api.github.com/users/ChristianKuehnel/repos","events_url":"https://api.github.com/users/ChristianKuehnel/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianKuehnel/received_events","type":"User","site_admin":false},"body":"fixed\r\n","created_at":"2018-02-10T18:22:10Z","updated_at":"2018-02-10T18:22:10Z","html_url":"https://github.com/home-assistant/home-assistant/pull/12252#discussion_r167406872","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12252","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/167406872"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12252#discussion_r167406872"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12252"}},"in_reply_to_id":167406487},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12252","id":168085895,"html_url":"https://github.com/home-assistant/home-assistant/pull/12252","diff_url":"https://github.com/home-assistant/home-assistant/pull/12252.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/12252.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12252","number":12252,"state":"open","locked":false,"title":"sensor.alpha_vantage - fixed bug: removed default sensor configuration","user":{"login":"ChristianKuehnel","id":19961352,"avatar_url":"https://avatars2.githubusercontent.com/u/19961352?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianKuehnel","html_url":"https://github.com/ChristianKuehnel","followers_url":"https://api.github.com/users/ChristianKuehnel/followers","following_url":"https://api.github.com/users/ChristianKuehnel/following{/other_user}","gists_url":"https://api.github.com/users/ChristianKuehnel/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianKuehnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianKuehnel/subscriptions","organizations_url":"https://api.github.com/users/ChristianKuehnel/orgs","repos_url":"https://api.github.com/users/ChristianKuehnel/repos","events_url":"https://api.github.com/users/ChristianKuehnel/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianKuehnel/received_events","type":"User","site_admin":false},"body":"## Description:\r\nAs described in #12165, the sensor alpha vantage by default configures some smybols. This is removed now, instead a persistent_notification is shown if not symbols and no currencies are configured.\r\n\r\n**Related issue (if applicable):** fixes #12165\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** N/A\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nsensor:\r\n  - platform: alpha_vantage\r\n    api_key: <your API key>\r\n    # do not configure anything here to see the new persistent_notification\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-02-08T21:01:36Z","updated_at":"2018-02-10T18:22:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19437127681804a59a88e60b95a761d95c69b6db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":457646398,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/breaking%20change","name":"breaking change","color":"d93f0b","default":false},{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":805697812,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/docs-missing","name":"docs-missing","color":"83f26f","default":false},{"id":765474017,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.alpha_vantage","name":"platform: sensor.alpha_vantage","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12252/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12252/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12252/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/e40bd37d275798358979d54a78b6e979b5ef452d","head":{"label":"ChristianKuehnel:alpha_vantage_default_config","ref":"alpha_vantage_default_config","sha":"e40bd37d275798358979d54a78b6e979b5ef452d","user":{"login":"ChristianKuehnel","id":19961352,"avatar_url":"https://avatars2.githubusercontent.com/u/19961352?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianKuehnel","html_url":"https://github.com/ChristianKuehnel","followers_url":"https://api.github.com/users/ChristianKuehnel/followers","following_url":"https://api.github.com/users/ChristianKuehnel/following{/other_user}","gists_url":"https://api.github.com/users/ChristianKuehnel/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianKuehnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianKuehnel/subscriptions","organizations_url":"https://api.github.com/users/ChristianKuehnel/orgs","repos_url":"https://api.github.com/users/ChristianKuehnel/repos","events_url":"https://api.github.com/users/ChristianKuehnel/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianKuehnel/received_events","type":"User","site_admin":false},"repo":{"id":82385957,"name":"home-assistant","full_name":"ChristianKuehnel/home-assistant","owner":{"login":"ChristianKuehnel","id":19961352,"avatar_url":"https://avatars2.githubusercontent.com/u/19961352?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianKuehnel","html_url":"https://github.com/ChristianKuehnel","followers_url":"https://api.github.com/users/ChristianKuehnel/followers","following_url":"https://api.github.com/users/ChristianKuehnel/following{/other_user}","gists_url":"https://api.github.com/users/ChristianKuehnel/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianKuehnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianKuehnel/subscriptions","organizations_url":"https://api.github.com/users/ChristianKuehnel/orgs","repos_url":"https://api.github.com/users/ChristianKuehnel/repos","events_url":"https://api.github.com/users/ChristianKuehnel/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianKuehnel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChristianKuehnel/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/ChristianKuehnel/home-assistant","forks_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/forks","keys_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/teams","hooks_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/events","assignees_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/tags","blobs_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/languages","stargazers_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/subscription","commits_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/merges","archive_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/downloads","issues_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/deployments","created_at":"2017-02-18T12:41:31Z","updated_at":"2017-02-18T12:41:37Z","pushed_at":"2018-02-10T18:16:23Z","git_url":"git://github.com/ChristianKuehnel/home-assistant.git","ssh_url":"git@github.com:ChristianKuehnel/home-assistant.git","clone_url":"https://github.com/ChristianKuehnel/home-assistant.git","svn_url":"https://github.com/ChristianKuehnel/home-assistant","homepage":"https://home-assistant.io","size":78198,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"2ae0c5653ed32c8b7309686d9b897f7d7c6fc0fb","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-02-10T17:12:52Z","pushed_at":"2018-02-10T18:16:24Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":78599,"stargazers_count":12441,"watchers_count":12441,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3585,"mirror_url":null,"archived":false,"open_issues_count":814,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3585,"open_issues":814,"watchers":12441,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12252"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12252"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12252"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12252/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12252/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12252/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/e40bd37d275798358979d54a78b6e979b5ef452d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChristianKuehnel"}}