{"action":"closed","number":13179,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13179","id":188291470,"html_url":"https://github.com/highfidelity/hifi/pull/13179","diff_url":"https://github.com/highfidelity/hifi/pull/13179.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13179.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13179","number":13179,"state":"closed","locked":false,"title":"Server-Managed Cloneables + Cloneable Properties","user":{"login":"dback2","id":31390055,"avatar_url":"https://avatars3.githubusercontent.com/u/31390055?v=4","gravatar_id":"","url":"https://api.github.com/users/dback2","html_url":"https://github.com/dback2","followers_url":"https://api.github.com/users/dback2/followers","following_url":"https://api.github.com/users/dback2/following{/other_user}","gists_url":"https://api.github.com/users/dback2/gists{/gist_id}","starred_url":"https://api.github.com/users/dback2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dback2/subscriptions","organizations_url":"https://api.github.com/users/dback2/orgs","repos_url":"https://api.github.com/users/dback2/repos","events_url":"https://api.github.com/users/dback2/events{/privacy}","received_events_url":"https://api.github.com/users/dback2/received_events","type":"User","site_admin":false},"body":"Using new cloneEntity function in Entities API and new EntityClone packet, cloneEntityUtils will now request a clone via the server. A local copy is initially created with the properties converted as if it was a clone, and that entity's ID is passed to the server along with the entity ID to clone. Server maintains cloneOriginIDs and cloneIDs lists on each EntityItem, and using those will now enforce cloneable limits via EntityTree::processEditPacketData and deny the clone accordingly. As well, it will also ensure the entity is in fact cloneable and does not have a certificate ID.\r\n\r\nAs well, all cloneable-related properties that were previously in user data have been converted to Entity properties.","created_at":"2018-05-16T00:39:22Z","updated_at":"2018-05-23T19:40:28Z","closed_at":"2018-05-23T19:40:27Z","merged_at":"2018-05-23T19:40:27Z","merge_commit_sha":"3e665fb6168e39295cdc8eb4a7032996af26421b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":743411186,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Client","name":"Client","color":"2872fc","default":false},{"id":751510477,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Content/Create","name":"Content/Create","color":"e288db","default":false},{"id":374042454,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Packet%20Version%20Change","name":"Packet Version Change","color":"1d76db","default":false},{"id":314155316,"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Approved%20:tada:","name":"QA Approved :tada:","color":"009800","default":false},{"id":376041472,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Release%20Blocker","name":"Release Blocker","color":"5319e7","default":false},{"id":794364211,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Server%20&%20Network","name":"Server & Network","color":"f2bf8a","default":false}],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/24","html_url":"https://github.com/highfidelity/hifi/milestone/24","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/24/labels","id":3163238,"number":24,"title":"RC68","description":"","creator":{"login":"conklin94122","id":12115653,"avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":131,"state":"open","created_at":"2018-03-05T19:58:08Z","updated_at":"2018-05-23T19:40:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13179/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13179/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13179/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/56493346c1e2e1c8068e63cfddf18ea2142b6c11","head":{"label":"dback2:cloneables","ref":"cloneables","sha":"56493346c1e2e1c8068e63cfddf18ea2142b6c11","user":{"login":"dback2","id":31390055,"avatar_url":"https://avatars3.githubusercontent.com/u/31390055?v=4","gravatar_id":"","url":"https://api.github.com/users/dback2","html_url":"https://github.com/dback2","followers_url":"https://api.github.com/users/dback2/followers","following_url":"https://api.github.com/users/dback2/following{/other_user}","gists_url":"https://api.github.com/users/dback2/gists{/gist_id}","starred_url":"https://api.github.com/users/dback2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dback2/subscriptions","organizations_url":"https://api.github.com/users/dback2/orgs","repos_url":"https://api.github.com/users/dback2/repos","events_url":"https://api.github.com/users/dback2/events{/privacy}","received_events_url":"https://api.github.com/users/dback2/received_events","type":"User","site_admin":false},"repo":{"id":101569298,"name":"hifi","full_name":"dback2/hifi","owner":{"login":"dback2","id":31390055,"avatar_url":"https://avatars3.githubusercontent.com/u/31390055?v=4","gravatar_id":"","url":"https://api.github.com/users/dback2","html_url":"https://github.com/dback2","followers_url":"https://api.github.com/users/dback2/followers","following_url":"https://api.github.com/users/dback2/following{/other_user}","gists_url":"https://api.github.com/users/dback2/gists{/gist_id}","starred_url":"https://api.github.com/users/dback2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dback2/subscriptions","organizations_url":"https://api.github.com/users/dback2/orgs","repos_url":"https://api.github.com/users/dback2/repos","events_url":"https://api.github.com/users/dback2/events{/privacy}","received_events_url":"https://api.github.com/users/dback2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dback2/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://wiki.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":true,"url":"https://api.github.com/repos/dback2/hifi","forks_url":"https://api.github.com/repos/dback2/hifi/forks","keys_url":"https://api.github.com/repos/dback2/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dback2/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dback2/hifi/teams","hooks_url":"https://api.github.com/repos/dback2/hifi/hooks","issue_events_url":"https://api.github.com/repos/dback2/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/dback2/hifi/events","assignees_url":"https://api.github.com/repos/dback2/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/dback2/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/dback2/hifi/tags","blobs_url":"https://api.github.com/repos/dback2/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dback2/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dback2/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/dback2/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dback2/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/dback2/hifi/languages","stargazers_url":"https://api.github.com/repos/dback2/hifi/stargazers","contributors_url":"https://api.github.com/repos/dback2/hifi/contributors","subscribers_url":"https://api.github.com/repos/dback2/hifi/subscribers","subscription_url":"https://api.github.com/repos/dback2/hifi/subscription","commits_url":"https://api.github.com/repos/dback2/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/dback2/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/dback2/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/dback2/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/dback2/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/dback2/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dback2/hifi/merges","archive_url":"https://api.github.com/repos/dback2/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dback2/hifi/downloads","issues_url":"https://api.github.com/repos/dback2/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/dback2/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/dback2/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/dback2/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dback2/hifi/labels{/name}","releases_url":"https://api.github.com/repos/dback2/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/dback2/hifi/deployments","created_at":"2017-08-27T17:39:27Z","updated_at":"2018-04-24T00:11:12Z","pushed_at":"2018-05-22T22:42:17Z","git_url":"git://github.com/dback2/hifi.git","ssh_url":"git@github.com:dback2/hifi.git","clone_url":"https://github.com/dback2/hifi.git","svn_url":"https://github.com/dback2/hifi","homepage":"","size":528575,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"efca568dbee8fe83ab38f650e86f4143ebeab6ef","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2018-05-23T18:58:47Z","pushed_at":"2018-05-23T19:40:27Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":528999,"stargazers_count":623,"watchers_count":623,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":403,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":403,"open_issues":172,"watchers":623,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13179"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13179"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13179"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13179/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13179/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13179/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/56493346c1e2e1c8068e63cfddf18ea2142b6c11"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"conklin94122","id":12115653,"avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"comments":69,"review_comments":23,"maintainer_can_modify":false,"commits":47,"additions":575,"deletions":163,"changed_files":22}}
{"actor":{"display_login":"conklin94122"}}