{"action":"created","issue":{"url":"https://api.github.com/repos/thorrak/fermentrack/issues/280","repository_url":"https://api.github.com/repos/thorrak/fermentrack","labels_url":"https://api.github.com/repos/thorrak/fermentrack/issues/280/labels{/name}","comments_url":"https://api.github.com/repos/thorrak/fermentrack/issues/280/comments","events_url":"https://api.github.com/repos/thorrak/fermentrack/issues/280/events","html_url":"https://github.com/thorrak/fermentrack/pull/280","id":324945007,"number":280,"title":"Map \"Log1Temp\" to \"RoomTemp\" value","user":{"login":"NamelessCoder","id":2228052,"avatar_url":"https://avatars3.githubusercontent.com/u/2228052?v=4","gravatar_id":"","url":"https://api.github.com/users/NamelessCoder","html_url":"https://github.com/NamelessCoder","followers_url":"https://api.github.com/users/NamelessCoder/followers","following_url":"https://api.github.com/users/NamelessCoder/following{/other_user}","gists_url":"https://api.github.com/users/NamelessCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/NamelessCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NamelessCoder/subscriptions","organizations_url":"https://api.github.com/users/NamelessCoder/orgs","repos_url":"https://api.github.com/users/NamelessCoder/repos","events_url":"https://api.github.com/users/NamelessCoder/events{/privacy}","received_events_url":"https://api.github.com/users/NamelessCoder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-21T14:50:50Z","updated_at":"2018-05-27T02:12:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/thorrak/fermentrack/pulls/280","html_url":"https://github.com/thorrak/fermentrack/pull/280","diff_url":"https://github.com/thorrak/fermentrack/pull/280.diff","patch_url":"https://github.com/thorrak/fermentrack/pull/280.patch"},"body":"This PR is opened not really expecting it to be merged, but to open a discussion about handling additional temperature inputs which the official BrewPi hardware can send. It might be a good time to figure out a solution that allows adding additional temperature targets, which can be selected in the \"Assign\" dialog when mapping pins.\r\n\r\nIn brewpi-www there are three additional temperature sensors but no dedicated room temperature sensor. These additional targets are named `Log1Temp` through `Log3Temp`. I'm guessing `Log1Temp` is the most obvious choice for a room temperature sensor, but it would be great to support additional sensors. For example, I would like to monitor:\r\n\r\n* Compressor motor's temperature\r\n* Temperature of back plate of fridge (possibly to some day prevent icing up when crashing beers?)\r\n\r\nI'm not sure how to go about this, though. Obviously these have relation to the firmware - perhaps this is possible by making \"temperature probes\" an entity you create for a Device, and giving each \"temperature probe\" a \"role\" property that corresponds to the current `BeerTemp` etc. namings that you can then select?"},"comment":{"url":"https://api.github.com/repos/thorrak/fermentrack/issues/comments/392300191","html_url":"https://github.com/thorrak/fermentrack/pull/280#issuecomment-392300191","issue_url":"https://api.github.com/repos/thorrak/fermentrack/issues/280","id":392300191,"user":{"login":"NamelessCoder","id":2228052,"avatar_url":"https://avatars3.githubusercontent.com/u/2228052?v=4","gravatar_id":"","url":"https://api.github.com/users/NamelessCoder","html_url":"https://github.com/NamelessCoder","followers_url":"https://api.github.com/users/NamelessCoder/followers","following_url":"https://api.github.com/users/NamelessCoder/following{/other_user}","gists_url":"https://api.github.com/users/NamelessCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/NamelessCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NamelessCoder/subscriptions","organizations_url":"https://api.github.com/users/NamelessCoder/orgs","repos_url":"https://api.github.com/users/NamelessCoder/repos","events_url":"https://api.github.com/users/NamelessCoder/events{/privacy}","received_events_url":"https://api.github.com/users/NamelessCoder/received_events","type":"User","site_admin":false},"created_at":"2018-05-27T02:12:25Z","updated_at":"2018-05-27T02:12:25Z","author_association":"NONE","body":"> I would actually recommend adding all three of the sensors, similar to what was done in the official script repo:\r\n\r\nSounds like the right choice. Logging them is of course step one - then we can perhaps figure out a solution for metadata that would allow defining which of these should act as \"room temp\" since that has a special place in the UI.\r\n\r\nI've been thinking that RRD might work here for logging the sensor values, states and such. I first came across it a long time ago via https://oss.oetiker.ch/rrdtool/ - a single file could be used to keep a permanent and always running collection of all sensor values without ever growing in size. It could then be made possible to export a CSV or other format log file based on one or more columns from the RRD. Point would be that sensor collection could happen constantly regardless of logging being enabled, so we would see graphed values as soon as things are set up - and would preserve graph history when switching to a different beer (because beer start/stop would just be annotations that tag a time stamp). Just a thought, and ever so slightly off topic but not really..."}}
{"actor":{"display_login":"NamelessCoder"}}