{"action":"created","comment":{"url":"https://api.github.com/repos/radare/radare2/pulls/comments/217992787","pull_request_review_id":155831557,"id":217992787,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzk5Mjc4Nw==","diff_hunk":"@@ -727,13 +729,19 @@ R_API void r_cons_flush(void) {\n \t\tCTX (lastMode) = false;\n \t}\n \tr_cons_filter ();\n-\n \tif (I.is_interactive && I.fdout == 1) {\n \t\t/* Use a pager if the output doesn't fit on the terminal window. */\n-\t\tif (I.pager && *I.pager && I.context->buffer_len > 0 && r_str_char_count (I.context->buffer, '\\n') >= I.rows) {\n+\t\tif (CTX (pageable) && I.pager && *I.pager && I.context->buffer_len > 0 && r_str_char_count (I.context->buffer, '\\n') >= I.rows) {\n \t\t\tI.context->buffer[I.context->buffer_len - 1] = 0;\n-\t\t\tr_sys_cmd_str_full (I.pager, I.context->buffer, NULL, NULL, NULL);\n-\t\t\tr_cons_reset ();\n+\t\t\tif (!strcmp (I.pager, \"..\")) {\n+\t\t\t\tchar *str = r_str_ndup (CTX (buffer), CTX (buffer_len));\n+\t\t\t\tCTX (pageable) = false;\n+\t\t\t\tr_cons_less_str (str, NULL);","path":"libr/cons/cons.c","position":64,"original_position":64,"commit_id":"c9cb3aa4a2be116a5d65087f2875cd971447d29e","original_commit_id":"c9cb3aa4a2be116a5d65087f2875cd971447d29e","user":{"login":"ret2libc","id":562321,"node_id":"MDQ6VXNlcjU2MjMyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/562321?v=4","gravatar_id":"","url":"https://api.github.com/users/ret2libc","html_url":"https://github.com/ret2libc","followers_url":"https://api.github.com/users/ret2libc/followers","following_url":"https://api.github.com/users/ret2libc/following{/other_user}","gists_url":"https://api.github.com/users/ret2libc/gists{/gist_id}","starred_url":"https://api.github.com/users/ret2libc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ret2libc/subscriptions","organizations_url":"https://api.github.com/users/ret2libc/orgs","repos_url":"https://api.github.com/users/ret2libc/repos","events_url":"https://api.github.com/users/ret2libc/events{/privacy}","received_events_url":"https://api.github.com/users/ret2libc/received_events","type":"User","site_admin":false},"body":"where do you set `CTX (pageable)` back to true?","created_at":"2018-09-17T09:03:17Z","updated_at":"2018-09-17T09:03:17Z","html_url":"https://github.com/radare/radare2/pull/11548#discussion_r217992787","pull_request_url":"https://api.github.com/repos/radare/radare2/pulls/11548","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments/217992787"},"html":{"href":"https://github.com/radare/radare2/pull/11548#discussion_r217992787"},"pull_request":{"href":"https://api.github.com/repos/radare/radare2/pulls/11548"}}},"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/11548","id":215852446,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODUyNDQ2","html_url":"https://github.com/radare/radare2/pull/11548","diff_url":"https://github.com/radare/radare2/pull/11548.diff","patch_url":"https://github.com/radare/radare2/pull/11548.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/11548","number":11548,"state":"open","locked":false,"title":"Fix #11455 - Implement internal less pager with scr.pager=.","user":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-16T23:43:56Z","updated_at":"2018-09-17T09:03:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7bf40d9ad5bf9f7d330aeb603e16ae4c5a5e47b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/radare/radare2/milestones/32","html_url":"https://github.com/radare/radare2/milestone/32","labels_url":"https://api.github.com/repos/radare/radare2/milestones/32/labels","id":3484549,"node_id":"MDk6TWlsZXN0b25lMzQ4NDU0OQ==","number":32,"title":"3.0","description":"","creator":{"login":"XVilka","id":203261,"node_id":"MDQ6VXNlcjIwMzI2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/203261?v=4","gravatar_id":"","url":"https://api.github.com/users/XVilka","html_url":"https://github.com/XVilka","followers_url":"https://api.github.com/users/XVilka/followers","following_url":"https://api.github.com/users/XVilka/following{/other_user}","gists_url":"https://api.github.com/users/XVilka/gists{/gist_id}","starred_url":"https://api.github.com/users/XVilka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XVilka/subscriptions","organizations_url":"https://api.github.com/users/XVilka/orgs","repos_url":"https://api.github.com/users/XVilka/repos","events_url":"https://api.github.com/users/XVilka/events{/privacy}","received_events_url":"https://api.github.com/users/XVilka/received_events","type":"User","site_admin":false},"open_issues":161,"closed_issues":33,"state":"open","created_at":"2018-07-10T03:42:21Z","updated_at":"2018-09-17T07:50:37Z","due_on":"2018-10-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/radare/radare2/pulls/11548/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/11548/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/11548/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/c9cb3aa4a2be116a5d65087f2875cd971447d29e","head":{"label":"radare:internal-pager","ref":"internal-pager","sha":"c9cb3aa4a2be116a5d65087f2875cd971447d29e","user":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"node_id":"MDEwOlJlcG9zaXRvcnk0ODY5Mjk0","name":"radare2","full_name":"radare/radare2","private":false,"owner":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools security","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2018-09-17T09:00:13Z","pushed_at":"2018-09-17T08:53:41Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":90007,"stargazers_count":8222,"watchers_count":8222,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1615,"mirror_url":null,"archived":false,"open_issues_count":997,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1615,"open_issues":997,"watchers":8222,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"5c6b97634318145aab12a3455760a90264c2beb0","user":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"node_id":"MDEwOlJlcG9zaXRvcnk0ODY5Mjk0","name":"radare2","full_name":"radare/radare2","private":false,"owner":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools security","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2018-09-17T09:00:13Z","pushed_at":"2018-09-17T08:53:41Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":90007,"stargazers_count":8222,"watchers_count":8222,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1615,"mirror_url":null,"archived":false,"open_issues_count":997,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1615,"open_issues":997,"watchers":8222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/11548"},"html":{"href":"https://github.com/radare/radare2/pull/11548"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/11548"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/11548/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/11548/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/11548/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/c9cb3aa4a2be116a5d65087f2875cd971447d29e"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ret2libc"}}