{"action":"closed","number":1215,"pull_request":{"url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1215","id":217935725,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3OTM1NzI1","html_url":"https://github.com/fabric8io/kubernetes-client/pull/1215","diff_url":"https://github.com/fabric8io/kubernetes-client/pull/1215.diff","patch_url":"https://github.com/fabric8io/kubernetes-client/pull/1215.patch","issue_url":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/1215","number":1215,"state":"closed","locked":false,"title":"Fix tracking of watched resource versions","user":{"login":"JonathanO","id":1206546,"node_id":"MDQ6VXNlcjEyMDY1NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1206546?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanO","html_url":"https://github.com/JonathanO","followers_url":"https://api.github.com/users/JonathanO/followers","following_url":"https://api.github.com/users/JonathanO/following{/other_user}","gists_url":"https://api.github.com/users/JonathanO/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanO/subscriptions","organizations_url":"https://api.github.com/users/JonathanO/orgs","repos_url":"https://api.github.com/users/JonathanO/repos","events_url":"https://api.github.com/users/JonathanO/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanO/received_events","type":"User","site_admin":false},"body":"Fixes #1214\r\n\r\nresourceVersions are Strings, so comparing them with compareTo leads to\r\nunexpected results (\"9\".compareTo(\"10\") is > 0.) Also since the versions\r\nare supposed to be opaque we should not be trying to read any meaning\r\nor ordering into them.\r\n\r\nSince messages are processed in order we should just always store the\r\nlast processed resourceVersion.\r\n\r\nI'm not sure this even needs to use an Atomic* type, but it seems safer\r\nto just leave that in place.","created_at":"2018-09-25T10:51:17Z","updated_at":"2018-09-28T11:12:39Z","closed_at":"2018-09-28T11:12:39Z","merged_at":"2018-09-28T11:12:39Z","merge_commit_sha":"c78d41ae59ea8988dd8ec95d1de7ec685b5474c7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"iocanel","id":402008,"node_id":"MDQ6VXNlcjQwMjAwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/402008?v=4","gravatar_id":"","url":"https://api.github.com/users/iocanel","html_url":"https://github.com/iocanel","followers_url":"https://api.github.com/users/iocanel/followers","following_url":"https://api.github.com/users/iocanel/following{/other_user}","gists_url":"https://api.github.com/users/iocanel/gists{/gist_id}","starred_url":"https://api.github.com/users/iocanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocanel/subscriptions","organizations_url":"https://api.github.com/users/iocanel/orgs","repos_url":"https://api.github.com/users/iocanel/repos","events_url":"https://api.github.com/users/iocanel/events{/privacy}","received_events_url":"https://api.github.com/users/iocanel/received_events","type":"User","site_admin":false},{"login":"oscerd","id":5106647,"node_id":"MDQ6VXNlcjUxMDY2NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5106647?v=4","gravatar_id":"","url":"https://api.github.com/users/oscerd","html_url":"https://github.com/oscerd","followers_url":"https://api.github.com/users/oscerd/followers","following_url":"https://api.github.com/users/oscerd/following{/other_user}","gists_url":"https://api.github.com/users/oscerd/gists{/gist_id}","starred_url":"https://api.github.com/users/oscerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscerd/subscriptions","organizations_url":"https://api.github.com/users/oscerd/orgs","repos_url":"https://api.github.com/users/oscerd/repos","events_url":"https://api.github.com/users/oscerd/events{/privacy}","received_events_url":"https://api.github.com/users/oscerd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1215/commits","review_comments_url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1215/comments","review_comment_url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/1215/comments","statuses_url":"https://api.github.com/repos/fabric8io/kubernetes-client/statuses/d51e841c4c39b22bda5a1b49f5ca2f768fd614d7","head":{"label":"JonathanO:fix-updating-resource-version","ref":"fix-updating-resource-version","sha":"d51e841c4c39b22bda5a1b49f5ca2f768fd614d7","user":{"login":"JonathanO","id":1206546,"node_id":"MDQ6VXNlcjEyMDY1NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1206546?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanO","html_url":"https://github.com/JonathanO","followers_url":"https://api.github.com/users/JonathanO/followers","following_url":"https://api.github.com/users/JonathanO/following{/other_user}","gists_url":"https://api.github.com/users/JonathanO/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanO/subscriptions","organizations_url":"https://api.github.com/users/JonathanO/orgs","repos_url":"https://api.github.com/users/JonathanO/repos","events_url":"https://api.github.com/users/JonathanO/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanO/received_events","type":"User","site_admin":false},"repo":{"id":150248930,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAyNDg5MzA=","name":"kubernetes-client","full_name":"JonathanO/kubernetes-client","private":false,"owner":{"login":"JonathanO","id":1206546,"node_id":"MDQ6VXNlcjEyMDY1NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1206546?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanO","html_url":"https://github.com/JonathanO","followers_url":"https://api.github.com/users/JonathanO/followers","following_url":"https://api.github.com/users/JonathanO/following{/other_user}","gists_url":"https://api.github.com/users/JonathanO/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanO/subscriptions","organizations_url":"https://api.github.com/users/JonathanO/orgs","repos_url":"https://api.github.com/users/JonathanO/repos","events_url":"https://api.github.com/users/JonathanO/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanO/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JonathanO/kubernetes-client","description":"Java client for Kubernetes & OpenShift 3","fork":true,"url":"https://api.github.com/repos/JonathanO/kubernetes-client","forks_url":"https://api.github.com/repos/JonathanO/kubernetes-client/forks","keys_url":"https://api.github.com/repos/JonathanO/kubernetes-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonathanO/kubernetes-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonathanO/kubernetes-client/teams","hooks_url":"https://api.github.com/repos/JonathanO/kubernetes-client/hooks","issue_events_url":"https://api.github.com/repos/JonathanO/kubernetes-client/issues/events{/number}","events_url":"https://api.github.com/repos/JonathanO/kubernetes-client/events","assignees_url":"https://api.github.com/repos/JonathanO/kubernetes-client/assignees{/user}","branches_url":"https://api.github.com/repos/JonathanO/kubernetes-client/branches{/branch}","tags_url":"https://api.github.com/repos/JonathanO/kubernetes-client/tags","blobs_url":"https://api.github.com/repos/JonathanO/kubernetes-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonathanO/kubernetes-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonathanO/kubernetes-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonathanO/kubernetes-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonathanO/kubernetes-client/statuses/{sha}","languages_url":"https://api.github.com/repos/JonathanO/kubernetes-client/languages","stargazers_url":"https://api.github.com/repos/JonathanO/kubernetes-client/stargazers","contributors_url":"https://api.github.com/repos/JonathanO/kubernetes-client/contributors","subscribers_url":"https://api.github.com/repos/JonathanO/kubernetes-client/subscribers","subscription_url":"https://api.github.com/repos/JonathanO/kubernetes-client/subscription","commits_url":"https://api.github.com/repos/JonathanO/kubernetes-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonathanO/kubernetes-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonathanO/kubernetes-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonathanO/kubernetes-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonathanO/kubernetes-client/contents/{+path}","compare_url":"https://api.github.com/repos/JonathanO/kubernetes-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonathanO/kubernetes-client/merges","archive_url":"https://api.github.com/repos/JonathanO/kubernetes-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonathanO/kubernetes-client/downloads","issues_url":"https://api.github.com/repos/JonathanO/kubernetes-client/issues{/number}","pulls_url":"https://api.github.com/repos/JonathanO/kubernetes-client/pulls{/number}","milestones_url":"https://api.github.com/repos/JonathanO/kubernetes-client/milestones{/number}","notifications_url":"https://api.github.com/repos/JonathanO/kubernetes-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonathanO/kubernetes-client/labels{/name}","releases_url":"https://api.github.com/repos/JonathanO/kubernetes-client/releases{/id}","deployments_url":"https://api.github.com/repos/JonathanO/kubernetes-client/deployments","created_at":"2018-09-25T10:39:54Z","updated_at":"2018-09-25T10:40:01Z","pushed_at":"2018-09-25T14:47:33Z","git_url":"git://github.com/JonathanO/kubernetes-client.git","ssh_url":"git@github.com:JonathanO/kubernetes-client.git","clone_url":"https://github.com/JonathanO/kubernetes-client.git","svn_url":"https://github.com/JonathanO/kubernetes-client","homepage":"http://fabric8.io","size":53562,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8io:master","ref":"master","sha":"7442817aaa9ece4cf2ea01c526a0f6513e7667cf","user":{"login":"fabric8io","id":6074349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzQzNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6074349?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"repo":{"id":38829639,"node_id":"MDEwOlJlcG9zaXRvcnkzODgyOTYzOQ==","name":"kubernetes-client","full_name":"fabric8io/kubernetes-client","private":false,"owner":{"login":"fabric8io","id":6074349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzQzNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6074349?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fabric8io/kubernetes-client","description":"Java client for Kubernetes & OpenShift 3","fork":false,"url":"https://api.github.com/repos/fabric8io/kubernetes-client","forks_url":"https://api.github.com/repos/fabric8io/kubernetes-client/forks","keys_url":"https://api.github.com/repos/fabric8io/kubernetes-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io/kubernetes-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io/kubernetes-client/teams","hooks_url":"https://api.github.com/repos/fabric8io/kubernetes-client/hooks","issue_events_url":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io/kubernetes-client/events","assignees_url":"https://api.github.com/repos/fabric8io/kubernetes-client/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io/kubernetes-client/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io/kubernetes-client/tags","blobs_url":"https://api.github.com/repos/fabric8io/kubernetes-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io/kubernetes-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io/kubernetes-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io/kubernetes-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io/kubernetes-client/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io/kubernetes-client/languages","stargazers_url":"https://api.github.com/repos/fabric8io/kubernetes-client/stargazers","contributors_url":"https://api.github.com/repos/fabric8io/kubernetes-client/contributors","subscribers_url":"https://api.github.com/repos/fabric8io/kubernetes-client/subscribers","subscription_url":"https://api.github.com/repos/fabric8io/kubernetes-client/subscription","commits_url":"https://api.github.com/repos/fabric8io/kubernetes-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io/kubernetes-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io/kubernetes-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io/kubernetes-client/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io/kubernetes-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io/kubernetes-client/merges","archive_url":"https://api.github.com/repos/fabric8io/kubernetes-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io/kubernetes-client/downloads","issues_url":"https://api.github.com/repos/fabric8io/kubernetes-client/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io/kubernetes-client/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io/kubernetes-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io/kubernetes-client/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io/kubernetes-client/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io/kubernetes-client/deployments","created_at":"2015-07-09T15:43:13Z","updated_at":"2018-09-28T06:59:20Z","pushed_at":"2018-09-28T11:12:39Z","git_url":"git://github.com/fabric8io/kubernetes-client.git","ssh_url":"git@github.com:fabric8io/kubernetes-client.git","clone_url":"https://github.com/fabric8io/kubernetes-client.git","svn_url":"https://github.com/fabric8io/kubernetes-client","homepage":"http://fabric8.io","size":53569,"stargazers_count":530,"watchers_count":530,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":215,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":323,"open_issues":215,"watchers":530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1215"},"html":{"href":"https://github.com/fabric8io/kubernetes-client/pull/1215"},"issue":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/1215"},"comments":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/issues/1215/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1215/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/pulls/1215/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io/kubernetes-client/statuses/d51e841c4c39b22bda5a1b49f5ca2f768fd614d7"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rohanKanojia","id":13834498,"node_id":"MDQ6VXNlcjEzODM0NDk4","avatar_url":"https://avatars3.githubusercontent.com/u/13834498?v=4","gravatar_id":"","url":"https://api.github.com/users/rohanKanojia","html_url":"https://github.com/rohanKanojia","followers_url":"https://api.github.com/users/rohanKanojia/followers","following_url":"https://api.github.com/users/rohanKanojia/following{/other_user}","gists_url":"https://api.github.com/users/rohanKanojia/gists{/gist_id}","starred_url":"https://api.github.com/users/rohanKanojia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohanKanojia/subscriptions","organizations_url":"https://api.github.com/users/rohanKanojia/orgs","repos_url":"https://api.github.com/users/rohanKanojia/repos","events_url":"https://api.github.com/users/rohanKanojia/events{/privacy}","received_events_url":"https://api.github.com/users/rohanKanojia/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":51,"deletions":16,"changed_files":4}}
{"actor":{"display_login":"rohanKanojia"}}