{"action":"created","issue":{"url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/482","repository_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web","labels_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/482/labels{/name}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/482/comments","events_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/482/events","html_url":"https://github.com/CenterForOpenScience/ember-osf-web/pull/482","id":383253042,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzY3OTMy","number":482,"title":"[EMB-509][Collections] Change to using ember-on-beforeunload for submission/edit","user":{"login":"adlius","id":1566880,"node_id":"MDQ6VXNlcjE1NjY4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1566880?v=4","gravatar_id":"","url":"https://api.github.com/users/adlius","html_url":"https://github.com/adlius","followers_url":"https://api.github.com/users/adlius/followers","following_url":"https://api.github.com/users/adlius/following{/other_user}","gists_url":"https://api.github.com/users/adlius/gists{/gist_id}","starred_url":"https://api.github.com/users/adlius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlius/subscriptions","organizations_url":"https://api.github.com/users/adlius/orgs","repos_url":"https://api.github.com/users/adlius/repos","events_url":"https://api.github.com/users/adlius/events{/privacy}","received_events_url":"https://api.github.com/users/adlius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-21T18:54:26Z","updated_at":"2018-11-21T19:17:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/pulls/482","html_url":"https://github.com/CenterForOpenScience/ember-osf-web/pull/482","diff_url":"https://github.com/CenterForOpenScience/ember-osf-web/pull/482.diff","patch_url":"https://github.com/CenterForOpenScience/ember-osf-web/pull/482.patch"},"body":"## Purpose\r\n\r\nGet rid of modal in favor of `ember-onbeforeunload`.\r\n\r\n## Summary of Changes\r\n\r\nRemove modals. Initialize `showCancelDialog` in the controller. Also added an action to be passed to `collection-submission` component in order to set `showCancelDialog`.\r\n\r\n## QA Notes\r\n\r\nInstead of a modal, a browser dialog would appear when user tries to navigate to another page when the page is dirty.\r\n\r\n## Ticket\r\n\r\nhttps://openscience.atlassian.net/browse/EMB-509\r\n\r\n# Reviewer Checklist\r\n\r\n- [ ] meets requirements\r\n- [ ] easy to understand\r\n- [ ] DRY\r\n- [ ] testable and includes test(s)\r\n- [ ] changes described in `CHANGELOG.md`\r\n\r\n<!-- Please strike through any checks that you think are not relevant for this PR and indicate why, e.g.\r\n\r\n     - [ ] ~~easy to understand~~ *(necessarily complex)*\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/comments/440780322","html_url":"https://github.com/CenterForOpenScience/ember-osf-web/pull/482#issuecomment-440780322","issue_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf-web/issues/482","id":440780322,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDc4MDMyMg==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T19:17:05Z","updated_at":"2018-11-21T19:17:05Z","author_association":"NONE","body":"## Pull Request Test Coverage Report for [Build 1943](https://coveralls.io/builds/20231071)\n\n* **13** of **23**   **(56.52%)**  changed or added relevant lines in **5** files are covered.\n* **11** unchanged lines in **4** files lost coverage.\n* Overall coverage increased (+**0.03%**) to **68.963%**\n\n---\n\n|  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |\n| :-----|--------------|--------|---: |\n| [lib/collections/addon/components/collections-submission/component.ts](https://coveralls.io/builds/20231071/source?filename=lib%2Fcollections%2Faddon%2Fcomponents%2Fcollections-submission%2Fcomponent.ts#L121) | 1 | 2 | 50.0%\n| [lib/collections/addon/guid/edit/controller.ts](https://coveralls.io/builds/20231071/source?filename=lib%2Fcollections%2Faddon%2Fguid%2Fedit%2Fcontroller.ts#L16) | 2 | 3 | 66.67%\n| [lib/collections/addon/submit/controller.ts](https://coveralls.io/builds/20231071/source?filename=lib%2Fcollections%2Faddon%2Fsubmit%2Fcontroller.ts#L12) | 1 | 4 | 25.0%\n| [lib/collections/addon/guid/edit/route.ts](https://coveralls.io/builds/20231071/source?filename=lib%2Fcollections%2Faddon%2Fguid%2Fedit%2Froute.ts#L14) | 5 | 10 | 50.0%\n<!-- | **Total:** | **13** | **23** | **56.52%** | -->\n\n|  Files with Coverage Reduction | New Missed Lines | % |\n| :-----|--------------|--: |\n| [lib/collections/addon/guid/edit/route.ts](https://coveralls.io/builds/20231071/source?filename=lib%2Fcollections%2Faddon%2Fguid%2Fedit%2Froute.ts#L16) | 1 | 70.27% |\n| [lib/collections/addon/guid/edit/controller.ts](https://coveralls.io/builds/20231071/source?filename=lib%2Fcollections%2Faddon%2Fguid%2Fedit%2Fcontroller.ts#L12) | 2 | 71.43% |\n| [lib/collections/addon/components/collections-submission/component.ts](https://coveralls.io/builds/20231071/source?filename=lib%2Fcollections%2Faddon%2Fcomponents%2Fcollections-submission%2Fcomponent.ts#L104) | 4 | 40.74% |\n| [lib/collections/addon/submit/route.ts](https://coveralls.io/builds/20231071/source?filename=lib%2Fcollections%2Faddon%2Fsubmit%2Froute.ts#L33) | 4 | 71.11% |\n<!-- | **Total:** | **11** |  | -->\n\n|  Totals | [![Coverage Status](https://coveralls.io/builds/20231071/badge)](https://coveralls.io/builds/20231071) |\n| :-- | --: |\n| Change from base [Build 1939](https://coveralls.io/builds/20206296): |  0.03% |\n| Covered Lines: | 4580 |\n| Relevant Lines: | 6104 |\n\n---\n##### 💛  - [Coveralls](https://coveralls.io)\n"}}
{"actor":{"display_login":"coveralls"}}