{"action":"created","comment":{"url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/comments/173537994","pull_request_review_id":102753066,"id":173537994,"diff_hunk":"@@ -156,7 +156,7 @@ public void run() {\n       }\n       duration = stopwatch;\n \n-      if (DrillTestDefaults.JDBC_DRIVER.equals(DrillTestDefaults.Driver.APACHE)) {\n+      if (DrillTestDefaults.JDBC_DRIVER.equals(\"org.apache.drill.jdbc.Driver\")) {","path":"framework/src/main/java/org/apache/drill/test/framework/DrillTestJdbc.java","position":5,"original_position":5,"commit_id":"c21274f74776bb91b2cbedcd8b17717a4a3e48db","original_commit_id":"c21274f74776bb91b2cbedcd8b17717a4a3e48db","user":{"login":"Agirish","id":2224090,"avatar_url":"https://avatars3.githubusercontent.com/u/2224090?v=4","gravatar_id":"","url":"https://api.github.com/users/Agirish","html_url":"https://github.com/Agirish","followers_url":"https://api.github.com/users/Agirish/followers","following_url":"https://api.github.com/users/Agirish/following{/other_user}","gists_url":"https://api.github.com/users/Agirish/gists{/gist_id}","starred_url":"https://api.github.com/users/Agirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Agirish/subscriptions","organizations_url":"https://api.github.com/users/Agirish/orgs","repos_url":"https://api.github.com/users/Agirish/repos","events_url":"https://api.github.com/users/Agirish/events{/privacy}","received_events_url":"https://api.github.com/users/Agirish/received_events","type":"User","site_admin":false},"body":"How about we create a constant called APACHE_DRIVER in DrillTestDefaults.java and use that in all comparisons?","created_at":"2018-03-09T19:01:11Z","updated_at":"2018-03-09T19:01:11Z","html_url":"https://github.com/mapr/drill-test-framework/pull/437#discussion_r173537994","pull_request_url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/437","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/comments/173537994"},"html":{"href":"https://github.com/mapr/drill-test-framework/pull/437#discussion_r173537994"},"pull_request":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/437"}}},"pull_request":{"url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/437","id":173947532,"html_url":"https://github.com/mapr/drill-test-framework/pull/437","diff_url":"https://github.com/mapr/drill-test-framework/pull/437.diff","patch_url":"https://github.com/mapr/drill-test-framework/pull/437.patch","issue_url":"https://api.github.com/repos/mapr/drill-test-framework/issues/437","number":437,"state":"open","locked":false,"title":"MD-3770: Added SSL unit test","user":{"login":"prasadns14","id":4907022,"avatar_url":"https://avatars1.githubusercontent.com/u/4907022?v=4","gravatar_id":"","url":"https://api.github.com/users/prasadns14","html_url":"https://github.com/prasadns14","followers_url":"https://api.github.com/users/prasadns14/followers","following_url":"https://api.github.com/users/prasadns14/following{/other_user}","gists_url":"https://api.github.com/users/prasadns14/gists{/gist_id}","starred_url":"https://api.github.com/users/prasadns14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasadns14/subscriptions","organizations_url":"https://api.github.com/users/prasadns14/orgs","repos_url":"https://api.github.com/users/prasadns14/repos","events_url":"https://api.github.com/users/prasadns14/events{/privacy}","received_events_url":"https://api.github.com/users/prasadns14/received_events","type":"User","site_admin":false},"body":"@Agirish, please review","created_at":"2018-03-09T08:38:49Z","updated_at":"2018-03-09T19:01:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcb113098497d962ef34616fc3a4c2c318d82226","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/437/commits","review_comments_url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/437/comments","review_comment_url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapr/drill-test-framework/issues/437/comments","statuses_url":"https://api.github.com/repos/mapr/drill-test-framework/statuses/c21274f74776bb91b2cbedcd8b17717a4a3e48db","head":{"label":"prasadns14:MD-3770","ref":"MD-3770","sha":"c21274f74776bb91b2cbedcd8b17717a4a3e48db","user":{"login":"prasadns14","id":4907022,"avatar_url":"https://avatars1.githubusercontent.com/u/4907022?v=4","gravatar_id":"","url":"https://api.github.com/users/prasadns14","html_url":"https://github.com/prasadns14","followers_url":"https://api.github.com/users/prasadns14/followers","following_url":"https://api.github.com/users/prasadns14/following{/other_user}","gists_url":"https://api.github.com/users/prasadns14/gists{/gist_id}","starred_url":"https://api.github.com/users/prasadns14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasadns14/subscriptions","organizations_url":"https://api.github.com/users/prasadns14/orgs","repos_url":"https://api.github.com/users/prasadns14/repos","events_url":"https://api.github.com/users/prasadns14/events{/privacy}","received_events_url":"https://api.github.com/users/prasadns14/received_events","type":"User","site_admin":false},"repo":{"id":98936576,"name":"drill-test-framework","full_name":"prasadns14/drill-test-framework","owner":{"login":"prasadns14","id":4907022,"avatar_url":"https://avatars1.githubusercontent.com/u/4907022?v=4","gravatar_id":"","url":"https://api.github.com/users/prasadns14","html_url":"https://github.com/prasadns14","followers_url":"https://api.github.com/users/prasadns14/followers","following_url":"https://api.github.com/users/prasadns14/following{/other_user}","gists_url":"https://api.github.com/users/prasadns14/gists{/gist_id}","starred_url":"https://api.github.com/users/prasadns14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasadns14/subscriptions","organizations_url":"https://api.github.com/users/prasadns14/orgs","repos_url":"https://api.github.com/users/prasadns14/repos","events_url":"https://api.github.com/users/prasadns14/events{/privacy}","received_events_url":"https://api.github.com/users/prasadns14/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prasadns14/drill-test-framework","description":"Test Framework for Apache Drill","fork":true,"url":"https://api.github.com/repos/prasadns14/drill-test-framework","forks_url":"https://api.github.com/repos/prasadns14/drill-test-framework/forks","keys_url":"https://api.github.com/repos/prasadns14/drill-test-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prasadns14/drill-test-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prasadns14/drill-test-framework/teams","hooks_url":"https://api.github.com/repos/prasadns14/drill-test-framework/hooks","issue_events_url":"https://api.github.com/repos/prasadns14/drill-test-framework/issues/events{/number}","events_url":"https://api.github.com/repos/prasadns14/drill-test-framework/events","assignees_url":"https://api.github.com/repos/prasadns14/drill-test-framework/assignees{/user}","branches_url":"https://api.github.com/repos/prasadns14/drill-test-framework/branches{/branch}","tags_url":"https://api.github.com/repos/prasadns14/drill-test-framework/tags","blobs_url":"https://api.github.com/repos/prasadns14/drill-test-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prasadns14/drill-test-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prasadns14/drill-test-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/prasadns14/drill-test-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prasadns14/drill-test-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/prasadns14/drill-test-framework/languages","stargazers_url":"https://api.github.com/repos/prasadns14/drill-test-framework/stargazers","contributors_url":"https://api.github.com/repos/prasadns14/drill-test-framework/contributors","subscribers_url":"https://api.github.com/repos/prasadns14/drill-test-framework/subscribers","subscription_url":"https://api.github.com/repos/prasadns14/drill-test-framework/subscription","commits_url":"https://api.github.com/repos/prasadns14/drill-test-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/prasadns14/drill-test-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/prasadns14/drill-test-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/prasadns14/drill-test-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/prasadns14/drill-test-framework/contents/{+path}","compare_url":"https://api.github.com/repos/prasadns14/drill-test-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prasadns14/drill-test-framework/merges","archive_url":"https://api.github.com/repos/prasadns14/drill-test-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prasadns14/drill-test-framework/downloads","issues_url":"https://api.github.com/repos/prasadns14/drill-test-framework/issues{/number}","pulls_url":"https://api.github.com/repos/prasadns14/drill-test-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/prasadns14/drill-test-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/prasadns14/drill-test-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prasadns14/drill-test-framework/labels{/name}","releases_url":"https://api.github.com/repos/prasadns14/drill-test-framework/releases{/id}","deployments_url":"https://api.github.com/repos/prasadns14/drill-test-framework/deployments","created_at":"2017-07-31T22:50:42Z","updated_at":"2017-07-31T22:51:54Z","pushed_at":"2018-03-09T16:49:43Z","git_url":"git://github.com/prasadns14/drill-test-framework.git","ssh_url":"git@github.com:prasadns14/drill-test-framework.git","clone_url":"https://github.com/prasadns14/drill-test-framework.git","svn_url":"https://github.com/prasadns14/drill-test-framework","homepage":"","size":991386,"stargazers_count":0,"watchers_count":0,"language":"Eiffel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapr:master","ref":"master","sha":"7b6a77234be3b374637e9dc74b94eb9abfd5c8f2","user":{"login":"mapr","id":1226517,"avatar_url":"https://avatars1.githubusercontent.com/u/1226517?v=4","gravatar_id":"","url":"https://api.github.com/users/mapr","html_url":"https://github.com/mapr","followers_url":"https://api.github.com/users/mapr/followers","following_url":"https://api.github.com/users/mapr/following{/other_user}","gists_url":"https://api.github.com/users/mapr/gists{/gist_id}","starred_url":"https://api.github.com/users/mapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapr/subscriptions","organizations_url":"https://api.github.com/users/mapr/orgs","repos_url":"https://api.github.com/users/mapr/repos","events_url":"https://api.github.com/users/mapr/events{/privacy}","received_events_url":"https://api.github.com/users/mapr/received_events","type":"Organization","site_admin":false},"repo":{"id":41067950,"name":"drill-test-framework","full_name":"mapr/drill-test-framework","owner":{"login":"mapr","id":1226517,"avatar_url":"https://avatars1.githubusercontent.com/u/1226517?v=4","gravatar_id":"","url":"https://api.github.com/users/mapr","html_url":"https://github.com/mapr","followers_url":"https://api.github.com/users/mapr/followers","following_url":"https://api.github.com/users/mapr/following{/other_user}","gists_url":"https://api.github.com/users/mapr/gists{/gist_id}","starred_url":"https://api.github.com/users/mapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapr/subscriptions","organizations_url":"https://api.github.com/users/mapr/orgs","repos_url":"https://api.github.com/users/mapr/repos","events_url":"https://api.github.com/users/mapr/events{/privacy}","received_events_url":"https://api.github.com/users/mapr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapr/drill-test-framework","description":"Test Framework for Apache Drill","fork":false,"url":"https://api.github.com/repos/mapr/drill-test-framework","forks_url":"https://api.github.com/repos/mapr/drill-test-framework/forks","keys_url":"https://api.github.com/repos/mapr/drill-test-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapr/drill-test-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapr/drill-test-framework/teams","hooks_url":"https://api.github.com/repos/mapr/drill-test-framework/hooks","issue_events_url":"https://api.github.com/repos/mapr/drill-test-framework/issues/events{/number}","events_url":"https://api.github.com/repos/mapr/drill-test-framework/events","assignees_url":"https://api.github.com/repos/mapr/drill-test-framework/assignees{/user}","branches_url":"https://api.github.com/repos/mapr/drill-test-framework/branches{/branch}","tags_url":"https://api.github.com/repos/mapr/drill-test-framework/tags","blobs_url":"https://api.github.com/repos/mapr/drill-test-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapr/drill-test-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapr/drill-test-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapr/drill-test-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapr/drill-test-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/mapr/drill-test-framework/languages","stargazers_url":"https://api.github.com/repos/mapr/drill-test-framework/stargazers","contributors_url":"https://api.github.com/repos/mapr/drill-test-framework/contributors","subscribers_url":"https://api.github.com/repos/mapr/drill-test-framework/subscribers","subscription_url":"https://api.github.com/repos/mapr/drill-test-framework/subscription","commits_url":"https://api.github.com/repos/mapr/drill-test-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapr/drill-test-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapr/drill-test-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapr/drill-test-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapr/drill-test-framework/contents/{+path}","compare_url":"https://api.github.com/repos/mapr/drill-test-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapr/drill-test-framework/merges","archive_url":"https://api.github.com/repos/mapr/drill-test-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapr/drill-test-framework/downloads","issues_url":"https://api.github.com/repos/mapr/drill-test-framework/issues{/number}","pulls_url":"https://api.github.com/repos/mapr/drill-test-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/mapr/drill-test-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/mapr/drill-test-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapr/drill-test-framework/labels{/name}","releases_url":"https://api.github.com/repos/mapr/drill-test-framework/releases{/id}","deployments_url":"https://api.github.com/repos/mapr/drill-test-framework/deployments","created_at":"2015-08-20T01:12:00Z","updated_at":"2017-11-19T07:52:14Z","pushed_at":"2018-03-09T16:49:44Z","git_url":"git://github.com/mapr/drill-test-framework.git","ssh_url":"git@github.com:mapr/drill-test-framework.git","clone_url":"https://github.com/mapr/drill-test-framework.git","svn_url":"https://github.com/mapr/drill-test-framework","homepage":"","size":991165,"stargazers_count":5,"watchers_count":5,"language":"Eiffel","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":30,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/437"},"html":{"href":"https://github.com/mapr/drill-test-framework/pull/437"},"issue":{"href":"https://api.github.com/repos/mapr/drill-test-framework/issues/437"},"comments":{"href":"https://api.github.com/repos/mapr/drill-test-framework/issues/437/comments"},"review_comments":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/437/comments"},"review_comment":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/437/commits"},"statuses":{"href":"https://api.github.com/repos/mapr/drill-test-framework/statuses/c21274f74776bb91b2cbedcd8b17717a4a3e48db"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Agirish"}}