{"action":"created","comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments/221674574","pull_request_review_id":160381196,"id":221674574,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTY3NDU3NA==","diff_hunk":"@@ -198,6 +198,11 @@ namespace OpenMS\n     sequence_ = sequence;\n   }\n \n+  void PeptideHit::setSequence(AASequence&& sequence)\n+  {\n+    sequence_ = std::move(sequence);","path":"src/openms/source/METADATA/PeptideHit.cpp","position":6,"original_position":6,"commit_id":"ba4b8c90cbd19bb2e1dacca773b97e6ef3b6a285","original_commit_id":"8b25b47d0c2536aea1753c07d039c1d495a58b51","user":{"login":"hroest","id":464014,"node_id":"MDQ6VXNlcjQ2NDAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/464014?v=4","gravatar_id":"","url":"https://api.github.com/users/hroest","html_url":"https://github.com/hroest","followers_url":"https://api.github.com/users/hroest/followers","following_url":"https://api.github.com/users/hroest/following{/other_user}","gists_url":"https://api.github.com/users/hroest/gists{/gist_id}","starred_url":"https://api.github.com/users/hroest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hroest/subscriptions","organizations_url":"https://api.github.com/users/hroest/orgs","repos_url":"https://api.github.com/users/hroest/repos","events_url":"https://api.github.com/users/hroest/events{/privacy}","received_events_url":"https://api.github.com/users/hroest/received_events","type":"User","site_admin":false},"body":"still not sure I understand what this has to do with throwing, the only thing this will do is to call\r\n\r\n```\r\nAASequence& operator=(AASequence&&);\r\n```\r\n\r\nwhich is default constructed (e.g. `AASequence& operator=(AASequence&&); = default`) and most likely will do the following (this seems most likely):\r\n\r\n```    \r\npeptide_ == std::move(rhs.peptide_);\r\nn_term_mod_ == std::move(rhs.n_term_mod_);\r\nc_term_mod_ == std::move(rhs.n_term_mod_);\r\n``` \r\n\r\nwhich then will call the implementation of `std::vector<const Residue*>& operator=(std::vector<const Residue*>&&);` which is the one from `std::vector` - again it does not matter whether its noexcept or not, this will be called. Now there is an interesting question of whether it should be \r\n\r\n```\r\nstd::vector<T>& operator=(std::vector<T>&&);\r\n--- or\r\nstd::vector<T>& operator=(std::vector<T>&&) noexcept;\r\n```\r\n\r\nsee here, https://stackoverflow.com/questions/12332772/why-arent-container-move-assignment-operators-noexcept -- but again irrelevant for our case here. So what will  `std::vector<const Residue*>& operator=(std::vector<const Residue*>&&);` probably do? (Again its not `noexcept` so it does not even guarantee anything) From my understanding, it will simply swap the ptrs to memory of `*this` and `rhs`.\r\n\r\nI think you may be confusing the move assignment and move constructors of the `std::vector` and their `noexcept`ness with the question of whether the elements of `std::vector<T>` have noexcept move assignment and move constructors (e.g. `T` has noexcept move assignment and move constructors ). This is relevant when the vector resizes.","created_at":"2018-10-01T16:32:56Z","updated_at":"2018-10-01T16:32:57Z","html_url":"https://github.com/OpenMS/OpenMS/pull/3758#discussion_r221674574","pull_request_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/3758","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments/221674574"},"html":{"href":"https://github.com/OpenMS/OpenMS/pull/3758#discussion_r221674574"},"pull_request":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/3758"}},"in_reply_to_id":221530150},"pull_request":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/3758","id":219023745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDIzNzQ1","html_url":"https://github.com/OpenMS/OpenMS/pull/3758","diff_url":"https://github.com/OpenMS/OpenMS/pull/3758.diff","patch_url":"https://github.com/OpenMS/OpenMS/pull/3758.patch","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3758","number":3758,"state":"open","locked":false,"title":"Feature/move semantics","user":{"login":"hroest","id":464014,"node_id":"MDQ6VXNlcjQ2NDAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/464014?v=4","gravatar_id":"","url":"https://api.github.com/users/hroest","html_url":"https://github.com/hroest","followers_url":"https://api.github.com/users/hroest/followers","following_url":"https://api.github.com/users/hroest/following{/other_user}","gists_url":"https://api.github.com/users/hroest/gists{/gist_id}","starred_url":"https://api.github.com/users/hroest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hroest/subscriptions","organizations_url":"https://api.github.com/users/hroest/orgs","repos_url":"https://api.github.com/users/hroest/repos","events_url":"https://api.github.com/users/hroest/events{/privacy}","received_events_url":"https://api.github.com/users/hroest/received_events","type":"User","site_admin":false},"body":"for MSSpectrum","created_at":"2018-09-28T16:35:49Z","updated_at":"2018-10-01T16:32:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a658ff0677ea21e1a1cabd74f3387147db2db37b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/3758/commits","review_comments_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/3758/comments","review_comment_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3758/comments","statuses_url":"https://api.github.com/repos/OpenMS/OpenMS/statuses/ba4b8c90cbd19bb2e1dacca773b97e6ef3b6a285","head":{"label":"OpenMS:feature/move_semantics","ref":"feature/move_semantics","sha":"ba4b8c90cbd19bb2e1dacca773b97e6ef3b6a285","user":{"login":"OpenMS","id":5994841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTQ4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/5994841?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMS","html_url":"https://github.com/OpenMS","followers_url":"https://api.github.com/users/OpenMS/followers","following_url":"https://api.github.com/users/OpenMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMS/subscriptions","organizations_url":"https://api.github.com/users/OpenMS/orgs","repos_url":"https://api.github.com/users/OpenMS/repos","events_url":"https://api.github.com/users/OpenMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15763403,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc2MzQwMw==","name":"OpenMS","full_name":"OpenMS/OpenMS","private":false,"owner":{"login":"OpenMS","id":5994841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTQ4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/5994841?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMS","html_url":"https://github.com/OpenMS","followers_url":"https://api.github.com/users/OpenMS/followers","following_url":"https://api.github.com/users/OpenMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMS/subscriptions","organizations_url":"https://api.github.com/users/OpenMS/orgs","repos_url":"https://api.github.com/users/OpenMS/repos","events_url":"https://api.github.com/users/OpenMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenMS/OpenMS","description":"The codebase of the OpenMS project","fork":false,"url":"https://api.github.com/repos/OpenMS/OpenMS","forks_url":"https://api.github.com/repos/OpenMS/OpenMS/forks","keys_url":"https://api.github.com/repos/OpenMS/OpenMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMS/OpenMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMS/OpenMS/teams","hooks_url":"https://api.github.com/repos/OpenMS/OpenMS/hooks","issue_events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMS/OpenMS/events","assignees_url":"https://api.github.com/repos/OpenMS/OpenMS/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMS/OpenMS/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMS/OpenMS/tags","blobs_url":"https://api.github.com/repos/OpenMS/OpenMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMS/OpenMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMS/OpenMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMS/OpenMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMS/OpenMS/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMS/OpenMS/languages","stargazers_url":"https://api.github.com/repos/OpenMS/OpenMS/stargazers","contributors_url":"https://api.github.com/repos/OpenMS/OpenMS/contributors","subscribers_url":"https://api.github.com/repos/OpenMS/OpenMS/subscribers","subscription_url":"https://api.github.com/repos/OpenMS/OpenMS/subscription","commits_url":"https://api.github.com/repos/OpenMS/OpenMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMS/OpenMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMS/OpenMS/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMS/OpenMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMS/OpenMS/merges","archive_url":"https://api.github.com/repos/OpenMS/OpenMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMS/OpenMS/downloads","issues_url":"https://api.github.com/repos/OpenMS/OpenMS/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMS/OpenMS/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMS/OpenMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/labels{/name}","releases_url":"https://api.github.com/repos/OpenMS/OpenMS/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMS/OpenMS/deployments","created_at":"2014-01-09T10:15:13Z","updated_at":"2018-09-29T16:49:10Z","pushed_at":"2018-10-01T16:03:55Z","git_url":"git://github.com/OpenMS/OpenMS.git","ssh_url":"git@github.com:OpenMS/OpenMS.git","clone_url":"https://github.com/OpenMS/OpenMS.git","svn_url":"https://github.com/OpenMS/OpenMS","homepage":"https://www.openms.de","size":319339,"stargazers_count":133,"watchers_count":133,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":570,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":129,"open_issues":570,"watchers":133,"default_branch":"develop"}},"base":{"label":"OpenMS:develop","ref":"develop","sha":"2e951a6e45bbe2674db0316e7757d62235dee652","user":{"login":"OpenMS","id":5994841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTQ4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/5994841?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMS","html_url":"https://github.com/OpenMS","followers_url":"https://api.github.com/users/OpenMS/followers","following_url":"https://api.github.com/users/OpenMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMS/subscriptions","organizations_url":"https://api.github.com/users/OpenMS/orgs","repos_url":"https://api.github.com/users/OpenMS/repos","events_url":"https://api.github.com/users/OpenMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15763403,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc2MzQwMw==","name":"OpenMS","full_name":"OpenMS/OpenMS","private":false,"owner":{"login":"OpenMS","id":5994841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTQ4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/5994841?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMS","html_url":"https://github.com/OpenMS","followers_url":"https://api.github.com/users/OpenMS/followers","following_url":"https://api.github.com/users/OpenMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMS/subscriptions","organizations_url":"https://api.github.com/users/OpenMS/orgs","repos_url":"https://api.github.com/users/OpenMS/repos","events_url":"https://api.github.com/users/OpenMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenMS/OpenMS","description":"The codebase of the OpenMS project","fork":false,"url":"https://api.github.com/repos/OpenMS/OpenMS","forks_url":"https://api.github.com/repos/OpenMS/OpenMS/forks","keys_url":"https://api.github.com/repos/OpenMS/OpenMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMS/OpenMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMS/OpenMS/teams","hooks_url":"https://api.github.com/repos/OpenMS/OpenMS/hooks","issue_events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMS/OpenMS/events","assignees_url":"https://api.github.com/repos/OpenMS/OpenMS/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMS/OpenMS/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMS/OpenMS/tags","blobs_url":"https://api.github.com/repos/OpenMS/OpenMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMS/OpenMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMS/OpenMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMS/OpenMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMS/OpenMS/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMS/OpenMS/languages","stargazers_url":"https://api.github.com/repos/OpenMS/OpenMS/stargazers","contributors_url":"https://api.github.com/repos/OpenMS/OpenMS/contributors","subscribers_url":"https://api.github.com/repos/OpenMS/OpenMS/subscribers","subscription_url":"https://api.github.com/repos/OpenMS/OpenMS/subscription","commits_url":"https://api.github.com/repos/OpenMS/OpenMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMS/OpenMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMS/OpenMS/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMS/OpenMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMS/OpenMS/merges","archive_url":"https://api.github.com/repos/OpenMS/OpenMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMS/OpenMS/downloads","issues_url":"https://api.github.com/repos/OpenMS/OpenMS/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMS/OpenMS/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMS/OpenMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/labels{/name}","releases_url":"https://api.github.com/repos/OpenMS/OpenMS/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMS/OpenMS/deployments","created_at":"2014-01-09T10:15:13Z","updated_at":"2018-09-29T16:49:10Z","pushed_at":"2018-10-01T16:03:55Z","git_url":"git://github.com/OpenMS/OpenMS.git","ssh_url":"git@github.com:OpenMS/OpenMS.git","clone_url":"https://github.com/OpenMS/OpenMS.git","svn_url":"https://github.com/OpenMS/OpenMS","homepage":"https://www.openms.de","size":319339,"stargazers_count":133,"watchers_count":133,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":570,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":129,"open_issues":570,"watchers":133,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/3758"},"html":{"href":"https://github.com/OpenMS/OpenMS/pull/3758"},"issue":{"href":"https://api.github.com/repos/OpenMS/OpenMS/issues/3758"},"comments":{"href":"https://api.github.com/repos/OpenMS/OpenMS/issues/3758/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/3758/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/3758/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMS/OpenMS/statuses/ba4b8c90cbd19bb2e1dacca773b97e6ef3b6a285"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hroest"}}