{"action":"created","comment":{"url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/comments/210989616","pull_request_review_id":147323976,"id":210989616,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDk4OTYxNg==","diff_hunk":"@@ -160,6 +171,10 @@ server\n         document: Document,\n       })","path":"web/src/server.js","position":27,"original_position":27,"commit_id":"ede4ed507eb85e1aaac67b11008c052870a62b91","original_commit_id":"ede4ed507eb85e1aaac67b11008c052870a62b91","user":{"login":"pcraig3","id":2454380,"node_id":"MDQ6VXNlcjI0NTQzODA=","avatar_url":"https://avatars1.githubusercontent.com/u/2454380?v=4","gravatar_id":"","url":"https://api.github.com/users/pcraig3","html_url":"https://github.com/pcraig3","followers_url":"https://api.github.com/users/pcraig3/followers","following_url":"https://api.github.com/users/pcraig3/following{/other_user}","gists_url":"https://api.github.com/users/pcraig3/gists{/gist_id}","starred_url":"https://api.github.com/users/pcraig3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcraig3/subscriptions","organizations_url":"https://api.github.com/users/pcraig3/orgs","repos_url":"https://api.github.com/users/pcraig3/repos","events_url":"https://api.github.com/users/pcraig3/events{/privacy}","received_events_url":"https://api.github.com/users/pcraig3/received_events","type":"User","site_admin":false},"body":"This isn't a bug with this code at this point, but setting the language cookie happens in the `render` method.\r\n\r\nSo, if you were planning to cache URLs even when they include query parameters, you want to be careful.\r\n\r\nSpecifically,\r\n- if you get the language cookie at the top of the request\r\n- then the cookie changes after running the `render` method\r\n- then you save `cache.put(`index_${language}`, html)`, then you're actually saving the wrong language\r\n\r\n(Again, not because your code does this -- only because I was playing around with the code and I got it into this state.)","created_at":"2018-08-17T18:06:53Z","updated_at":"2018-08-17T18:08:40Z","html_url":"https://github.com/cds-snc/ircc-rescheduler/pull/358#discussion_r210989616","pull_request_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/358","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/comments/210989616"},"html":{"href":"https://github.com/cds-snc/ircc-rescheduler/pull/358#discussion_r210989616"},"pull_request":{"href":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/358"}}},"pull_request":{"url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/358","id":208060902,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDYwOTAy","html_url":"https://github.com/cds-snc/ircc-rescheduler/pull/358","diff_url":"https://github.com/cds-snc/ircc-rescheduler/pull/358.diff","patch_url":"https://github.com/cds-snc/ircc-rescheduler/pull/358.patch","issue_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/issues/358","number":358,"state":"open","locked":false,"title":"Boost homepage load time using cache","user":{"login":"timarney","id":62242,"node_id":"MDQ6VXNlcjYyMjQy","avatar_url":"https://avatars2.githubusercontent.com/u/62242?v=4","gravatar_id":"","url":"https://api.github.com/users/timarney","html_url":"https://github.com/timarney","followers_url":"https://api.github.com/users/timarney/followers","following_url":"https://api.github.com/users/timarney/following{/other_user}","gists_url":"https://api.github.com/users/timarney/gists{/gist_id}","starred_url":"https://api.github.com/users/timarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timarney/subscriptions","organizations_url":"https://api.github.com/users/timarney/orgs","repos_url":"https://api.github.com/users/timarney/repos","events_url":"https://api.github.com/users/timarney/events{/privacy}","received_events_url":"https://api.github.com/users/timarney/received_events","type":"User","site_admin":false},"body":"The loading times for slow 3G connections has been quite slow 30+secs.  This in part is due to the bundle size and parse time for the bundle.\r\n\r\nGiven the the interactivity level and content for the initial landing page we can boost load time but serving up a cached version of the landing page and skip loading the client bundle for the initial page.\r\n\r\n# Lighthouse Audit \r\n\r\n**Before:**\r\n<img width=\"788\" alt=\"before\" src=\"https://user-images.githubusercontent.com/62242/44095796-b25baeda-9fa7-11e8-81fa-66975fb5adf1.png\">\r\n\r\n**After**\r\n<img width=\"743\" alt=\"after\" src=\"https://user-images.githubusercontent.com/62242/44095820-bf8071cc-9fa7-11e8-8577-33ea31f2f6ba.png\">\r\n\r\n","created_at":"2018-08-13T18:18:00Z","updated_at":"2018-08-17T18:08:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d4ae30c3f154e501e3bff6ae7d1b32bb3275bee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/358/commits","review_comments_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/358/comments","review_comment_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/issues/358/comments","statuses_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/statuses/ede4ed507eb85e1aaac67b11008c052870a62b91","head":{"label":"cds-snc:cache","ref":"cache","sha":"ede4ed507eb85e1aaac67b11008c052870a62b91","user":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"repo":{"id":127961062,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc5NjEwNjI=","name":"ircc-rescheduler","full_name":"cds-snc/ircc-rescheduler","owner":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cds-snc/ircc-rescheduler","description":"🙅🗓","fork":false,"url":"https://api.github.com/repos/cds-snc/ircc-rescheduler","forks_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/forks","keys_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/teams","hooks_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/hooks","issue_events_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/issues/events{/number}","events_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/events","assignees_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/assignees{/user}","branches_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/branches{/branch}","tags_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/tags","blobs_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/git/refs{/sha}","trees_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/statuses/{sha}","languages_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/languages","stargazers_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/stargazers","contributors_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/contributors","subscribers_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/subscribers","subscription_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/subscription","commits_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/commits{/sha}","git_commits_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/git/commits{/sha}","comments_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/comments{/number}","issue_comment_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/issues/comments{/number}","contents_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/contents/{+path}","compare_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/merges","archive_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/downloads","issues_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/issues{/number}","pulls_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls{/number}","milestones_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/milestones{/number}","notifications_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/labels{/name}","releases_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/releases{/id}","deployments_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/deployments","created_at":"2018-04-03T19:52:25Z","updated_at":"2018-08-17T17:51:30Z","pushed_at":"2018-08-17T17:51:32Z","git_url":"git://github.com/cds-snc/ircc-rescheduler.git","ssh_url":"git@github.com:cds-snc/ircc-rescheduler.git","clone_url":"https://github.com/cds-snc/ircc-rescheduler.git","svn_url":"https://github.com/cds-snc/ircc-rescheduler","homepage":"https://rescheduler-dev.cds-snc.ca/","size":3662,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":8,"watchers":18,"default_branch":"master"}},"base":{"label":"cds-snc:master","ref":"master","sha":"d945eb967d5be690a2198b211949a59aeadcf018","user":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"repo":{"id":127961062,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc5NjEwNjI=","name":"ircc-rescheduler","full_name":"cds-snc/ircc-rescheduler","owner":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cds-snc/ircc-rescheduler","description":"🙅🗓","fork":false,"url":"https://api.github.com/repos/cds-snc/ircc-rescheduler","forks_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/forks","keys_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/teams","hooks_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/hooks","issue_events_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/issues/events{/number}","events_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/events","assignees_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/assignees{/user}","branches_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/branches{/branch}","tags_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/tags","blobs_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/git/refs{/sha}","trees_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/statuses/{sha}","languages_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/languages","stargazers_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/stargazers","contributors_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/contributors","subscribers_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/subscribers","subscription_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/subscription","commits_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/commits{/sha}","git_commits_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/git/commits{/sha}","comments_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/comments{/number}","issue_comment_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/issues/comments{/number}","contents_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/contents/{+path}","compare_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/merges","archive_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/downloads","issues_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/issues{/number}","pulls_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls{/number}","milestones_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/milestones{/number}","notifications_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/labels{/name}","releases_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/releases{/id}","deployments_url":"https://api.github.com/repos/cds-snc/ircc-rescheduler/deployments","created_at":"2018-04-03T19:52:25Z","updated_at":"2018-08-17T17:51:30Z","pushed_at":"2018-08-17T17:51:32Z","git_url":"git://github.com/cds-snc/ircc-rescheduler.git","ssh_url":"git@github.com:cds-snc/ircc-rescheduler.git","clone_url":"https://github.com/cds-snc/ircc-rescheduler.git","svn_url":"https://github.com/cds-snc/ircc-rescheduler","homepage":"https://rescheduler-dev.cds-snc.ca/","size":3662,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":8,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/358"},"html":{"href":"https://github.com/cds-snc/ircc-rescheduler/pull/358"},"issue":{"href":"https://api.github.com/repos/cds-snc/ircc-rescheduler/issues/358"},"comments":{"href":"https://api.github.com/repos/cds-snc/ircc-rescheduler/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cds-snc/ircc-rescheduler/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/cds-snc/ircc-rescheduler/statuses/ede4ed507eb85e1aaac67b11008c052870a62b91"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pcraig3"}}