{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1108","repository_url":"https://api.github.com/repos/tensorflow/tfjs-core","labels_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1108/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1108/comments","events_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1108/events","html_url":"https://github.com/tensorflow/tfjs-core/pull/1108","id":332852416,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjM1Mzg4","number":1108,"title":"update raw byte calculation to use byteLength","user":{"login":"kumarde","id":3020845,"node_id":"MDQ6VXNlcjMwMjA4NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/3020845?v=4","gravatar_id":"","url":"https://api.github.com/users/kumarde","html_url":"https://github.com/kumarde","followers_url":"https://api.github.com/users/kumarde/followers","following_url":"https://api.github.com/users/kumarde/following{/other_user}","gists_url":"https://api.github.com/users/kumarde/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarde/subscriptions","organizations_url":"https://api.github.com/users/kumarde/orgs","repos_url":"https://api.github.com/users/kumarde/repos","events_url":"https://api.github.com/users/kumarde/events{/privacy}","received_events_url":"https://api.github.com/users/kumarde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-15T17:11:48Z","updated_at":"2018-06-18T16:28:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/1108","html_url":"https://github.com/tensorflow/tfjs-core/pull/1108","diff_url":"https://github.com/tensorflow/tfjs-core/pull/1108.diff","patch_url":"https://github.com/tensorflow/tfjs-core/pull/1108.patch"},"body":"#### Description\r\nThis fixes https://github.com/tensorflow/tfjs/issues/432.\r\n\r\nInstead of computing byte length by magic number, use `buffer.byteLength`.\r\n---\r\n<!-- Please do not delete this section -->\r\n##### For repository owners only:\r\n\r\nPlease remember to apply all applicable tags to your pull request.\r\nTags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY\r\n\r\nFor more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/tensorflow/tfjs-core/1108)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/comments/398114102","html_url":"https://github.com/tensorflow/tfjs-core/pull/1108#issuecomment-398114102","issue_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1108","id":398114102,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODExNDEwMg==","user":{"login":"kumarde","id":3020845,"node_id":"MDQ6VXNlcjMwMjA4NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/3020845?v=4","gravatar_id":"","url":"https://api.github.com/users/kumarde","html_url":"https://github.com/kumarde","followers_url":"https://api.github.com/users/kumarde/followers","following_url":"https://api.github.com/users/kumarde/following{/other_user}","gists_url":"https://api.github.com/users/kumarde/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarde/subscriptions","organizations_url":"https://api.github.com/users/kumarde/orgs","repos_url":"https://api.github.com/users/kumarde/repos","events_url":"https://api.github.com/users/kumarde/events{/privacy}","received_events_url":"https://api.github.com/users/kumarde/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T16:28:26Z","updated_at":"2018-06-18T16:28:26Z","author_association":"NONE","body":"@caisq I think in theory, this should never happen. However, there's a workflow (that I mentioned offline) and a model specifically  where the `.buffer` didn't seem to match the higher level representation of the `TypedArray`."}}
{"actor":{"display_login":"kumarde"}}