{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/comments/177434622","pull_request_review_id":107301817,"id":177434622,"diff_hunk":"@@ -0,0 +1,58 @@\n+module ManageIQ\n+  module Automate\n+    module Service\n+      module Retirement\n+        module StateMachines\n+          module ServiceRetirement\n+            class UpdateServiceRetirementStatus\n+\n+              def initialize(handle = $evm)\n+                @handle = handle\n+              end\n+\n+              def main\n+                task = @handle.root['service_retire_task']\n+\n+                if task.nil?","path":"content/automate/ManageIQ/Service/Retirement/StateMachines/ServiceRetirement.class/__methods__/update_serviceretirement_status.rb","position":16,"original_position":16,"commit_id":"46709a9dcaa7b7e1832c86528b0c448bc14fb6f2","original_commit_id":"46709a9dcaa7b7e1832c86528b0c448bc14fb6f2","user":{"login":"tinaafitz","id":109132,"avatar_url":"https://avatars0.githubusercontent.com/u/109132?v=4","gravatar_id":"","url":"https://api.github.com/users/tinaafitz","html_url":"https://github.com/tinaafitz","followers_url":"https://api.github.com/users/tinaafitz/followers","following_url":"https://api.github.com/users/tinaafitz/following{/other_user}","gists_url":"https://api.github.com/users/tinaafitz/gists{/gist_id}","starred_url":"https://api.github.com/users/tinaafitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinaafitz/subscriptions","organizations_url":"https://api.github.com/users/tinaafitz/orgs","repos_url":"https://api.github.com/users/tinaafitz/repos","events_url":"https://api.github.com/users/tinaafitz/events{/privacy}","received_events_url":"https://api.github.com/users/tinaafitz/received_events","type":"User","site_admin":false},"body":"@d-m-u Normally, this would be correct in that we would raise if an object we expected to be present was missing. In this case though, we want to be backward compatible, so you can remove the the if task.nil? code block.","created_at":"2018-03-27T13:59:54Z","updated_at":"2018-03-27T14:01:11Z","html_url":"https://github.com/ManageIQ/manageiq-content/pull/262#discussion_r177434622","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/262","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/comments/177434622"},"html":{"href":"https://github.com/ManageIQ/manageiq-content/pull/262#discussion_r177434622"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/262"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/262","id":174768053,"html_url":"https://github.com/ManageIQ/manageiq-content/pull/262","diff_url":"https://github.com/ManageIQ/manageiq-content/pull/262.diff","patch_url":"https://github.com/ManageIQ/manageiq-content/pull/262.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/262","number":262,"state":"open","locked":false,"title":"Add task status update to retirement status","user":{"login":"d-m-u","id":16326669,"avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"body":"The service retirement status should have the status included in the message since retirement is morphing into a request. \r\n\r\n\r\n\r\n## Related to: \r\nclassic-ui pr here: https://github.com/ManageIQ/manageiq-ui-classic/pull/3409\r\nhttps://github.com/ManageIQ/manageiq-automation_engine/pull/157\r\n\r\n## Depends on:\r\nhttps://github.com/ManageIQ/manageiq/pull/16933","created_at":"2018-03-13T19:37:43Z","updated_at":"2018-03-27T14:01:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f40c1f7067cd01848bc0e78bc11aa71d9caddd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/262/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/262/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/262/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-content/statuses/46709a9dcaa7b7e1832c86528b0c448bc14fb6f2","head":{"label":"d-m-u:adding_task_status_update_to_retirement","ref":"adding_task_status_update_to_retirement","sha":"46709a9dcaa7b7e1832c86528b0c448bc14fb6f2","user":{"login":"d-m-u","id":16326669,"avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"repo":{"id":117011883,"name":"manageiq-content","full_name":"d-m-u/manageiq-content","owner":{"login":"d-m-u","id":16326669,"avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-m-u/manageiq-content","description":"Default ManageIQ content","fork":true,"url":"https://api.github.com/repos/d-m-u/manageiq-content","forks_url":"https://api.github.com/repos/d-m-u/manageiq-content/forks","keys_url":"https://api.github.com/repos/d-m-u/manageiq-content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-m-u/manageiq-content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-m-u/manageiq-content/teams","hooks_url":"https://api.github.com/repos/d-m-u/manageiq-content/hooks","issue_events_url":"https://api.github.com/repos/d-m-u/manageiq-content/issues/events{/number}","events_url":"https://api.github.com/repos/d-m-u/manageiq-content/events","assignees_url":"https://api.github.com/repos/d-m-u/manageiq-content/assignees{/user}","branches_url":"https://api.github.com/repos/d-m-u/manageiq-content/branches{/branch}","tags_url":"https://api.github.com/repos/d-m-u/manageiq-content/tags","blobs_url":"https://api.github.com/repos/d-m-u/manageiq-content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-m-u/manageiq-content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-m-u/manageiq-content/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-m-u/manageiq-content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-m-u/manageiq-content/statuses/{sha}","languages_url":"https://api.github.com/repos/d-m-u/manageiq-content/languages","stargazers_url":"https://api.github.com/repos/d-m-u/manageiq-content/stargazers","contributors_url":"https://api.github.com/repos/d-m-u/manageiq-content/contributors","subscribers_url":"https://api.github.com/repos/d-m-u/manageiq-content/subscribers","subscription_url":"https://api.github.com/repos/d-m-u/manageiq-content/subscription","commits_url":"https://api.github.com/repos/d-m-u/manageiq-content/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-m-u/manageiq-content/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-m-u/manageiq-content/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-m-u/manageiq-content/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-m-u/manageiq-content/contents/{+path}","compare_url":"https://api.github.com/repos/d-m-u/manageiq-content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-m-u/manageiq-content/merges","archive_url":"https://api.github.com/repos/d-m-u/manageiq-content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-m-u/manageiq-content/downloads","issues_url":"https://api.github.com/repos/d-m-u/manageiq-content/issues{/number}","pulls_url":"https://api.github.com/repos/d-m-u/manageiq-content/pulls{/number}","milestones_url":"https://api.github.com/repos/d-m-u/manageiq-content/milestones{/number}","notifications_url":"https://api.github.com/repos/d-m-u/manageiq-content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-m-u/manageiq-content/labels{/name}","releases_url":"https://api.github.com/repos/d-m-u/manageiq-content/releases{/id}","deployments_url":"https://api.github.com/repos/d-m-u/manageiq-content/deployments","created_at":"2018-01-10T21:17:51Z","updated_at":"2018-01-10T21:17:54Z","pushed_at":"2018-03-26T18:59:45Z","git_url":"git://github.com/d-m-u/manageiq-content.git","ssh_url":"git@github.com:d-m-u/manageiq-content.git","clone_url":"https://github.com/d-m-u/manageiq-content.git","svn_url":"https://github.com/d-m-u/manageiq-content","homepage":"","size":1494,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"f3e198ca42a8407e064388264476f039bda240c1","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":76481218,"name":"manageiq-content","full_name":"ManageIQ/manageiq-content","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-content","description":"Default ManageIQ content","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-content","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-content/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-content/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-content/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-content/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-content/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-content/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-content/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-content/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-content/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-content/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-content/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-content/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-content/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-content/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-content/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-content/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-content/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-content/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-content/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-content/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-content/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-content/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-content/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-content/deployments","created_at":"2016-12-14T17:20:12Z","updated_at":"2018-03-22T14:31:18Z","pushed_at":"2018-03-26T18:59:46Z","git_url":"git://github.com/ManageIQ/manageiq-content.git","ssh_url":"git@github.com:ManageIQ/manageiq-content.git","clone_url":"https://github.com/ManageIQ/manageiq-content.git","svn_url":"https://github.com/ManageIQ/manageiq-content","homepage":"","size":1518,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":70,"open_issues":14,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/262"},"html":{"href":"https://github.com/ManageIQ/manageiq-content/pull/262"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/262"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-content/statuses/46709a9dcaa7b7e1832c86528b0c448bc14fb6f2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tinaafitz"}}