{"action":"created","comment":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/comments/243633993","pull_request_review_id":187463727,"id":243633993,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzYzMzk5Mw==","diff_hunk":"@@ -431,10 +431,10 @@ func (c *Container) createContainersDirs() error {\n \treturn nil\n }\n \n-func (c *Container) shareFiles(m Mount, idx int, hostSharedDir, guestSharedDir string) (string, error) {\n+func (c *Container) shareFiles(m Mount, idx int, hostSharedDir, guestSharedDir string) (string, bool, error) {","path":"virtcontainers/container.go","position":5,"original_position":5,"commit_id":"83e38c959ab7315e47ddf65e375540dad7319c8b","original_commit_id":"83e38c959ab7315e47ddf65e375540dad7319c8b","user":{"login":"mcastelino","id":7387737,"node_id":"MDQ6VXNlcjczODc3Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/7387737?v=4","gravatar_id":"","url":"https://api.github.com/users/mcastelino","html_url":"https://github.com/mcastelino","followers_url":"https://api.github.com/users/mcastelino/followers","following_url":"https://api.github.com/users/mcastelino/following{/other_user}","gists_url":"https://api.github.com/users/mcastelino/gists{/gist_id}","starred_url":"https://api.github.com/users/mcastelino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcastelino/subscriptions","organizations_url":"https://api.github.com/users/mcastelino/orgs","repos_url":"https://api.github.com/users/mcastelino/repos","events_url":"https://api.github.com/users/mcastelino/events{/privacy}","received_events_url":"https://api.github.com/users/mcastelino/received_events","type":"User","site_admin":false},"body":"@sboeuf it would be good to document what the return values actually mean or give them expressive names.","created_at":"2018-12-21T16:46:01Z","updated_at":"2018-12-21T16:57:15Z","html_url":"https://github.com/kata-containers/runtime/pull/1069#discussion_r243633993","pull_request_url":"https://api.github.com/repos/kata-containers/runtime/pulls/1069","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/comments/243633993"},"html":{"href":"https://github.com/kata-containers/runtime/pull/1069#discussion_r243633993"},"pull_request":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/1069"}}},"pull_request":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/1069","id":240390353,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMzkwMzUz","html_url":"https://github.com/kata-containers/runtime/pull/1069","diff_url":"https://github.com/kata-containers/runtime/pull/1069.diff","patch_url":"https://github.com/kata-containers/runtime/pull/1069.patch","issue_url":"https://api.github.com/repos/kata-containers/runtime/issues/1069","number":1069,"state":"open","locked":false,"title":"mounts: Ignore existing mounts if they cannot be honored","user":{"login":"sboeuf","id":22890413,"node_id":"MDQ6VXNlcjIyODkwNDEz","avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"body":"In case we use an hypervisor that cannot support filesystem sharing,\r\nwe copy files over to the VM rootfs through the gRPC protocol. This\r\nis a nice workaround, but it only works with regular files, which\r\nmeans no device file, no socket file, no directory, etc... can be\r\nsent this way.\r\n\r\nThis is a limitation that we accept here, by simply ignoring those\r\nnon-regular files.\r\n\r\nFixes #1068\r\n\r\nSigned-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>","created_at":"2018-12-21T07:12:44Z","updated_at":"2018-12-21T16:57:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba883d1de285c9faf07209893770b469b1c0e6b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kata-containers/runtime/pulls/1069/commits","review_comments_url":"https://api.github.com/repos/kata-containers/runtime/pulls/1069/comments","review_comment_url":"https://api.github.com/repos/kata-containers/runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kata-containers/runtime/issues/1069/comments","statuses_url":"https://api.github.com/repos/kata-containers/runtime/statuses/83e38c959ab7315e47ddf65e375540dad7319c8b","head":{"label":"sboeuf:fix_fc_k8s","ref":"fix_fc_k8s","sha":"83e38c959ab7315e47ddf65e375540dad7319c8b","user":{"login":"sboeuf","id":22890413,"node_id":"MDQ6VXNlcjIyODkwNDEz","avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"repo":{"id":125155717,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUxNTU3MTc=","name":"runtime-1","full_name":"sboeuf/runtime-1","private":false,"owner":{"login":"sboeuf","id":22890413,"node_id":"MDQ6VXNlcjIyODkwNDEz","avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sboeuf/runtime-1","description":"Kata Containers runtimes","fork":true,"url":"https://api.github.com/repos/sboeuf/runtime-1","forks_url":"https://api.github.com/repos/sboeuf/runtime-1/forks","keys_url":"https://api.github.com/repos/sboeuf/runtime-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sboeuf/runtime-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sboeuf/runtime-1/teams","hooks_url":"https://api.github.com/repos/sboeuf/runtime-1/hooks","issue_events_url":"https://api.github.com/repos/sboeuf/runtime-1/issues/events{/number}","events_url":"https://api.github.com/repos/sboeuf/runtime-1/events","assignees_url":"https://api.github.com/repos/sboeuf/runtime-1/assignees{/user}","branches_url":"https://api.github.com/repos/sboeuf/runtime-1/branches{/branch}","tags_url":"https://api.github.com/repos/sboeuf/runtime-1/tags","blobs_url":"https://api.github.com/repos/sboeuf/runtime-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sboeuf/runtime-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sboeuf/runtime-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/sboeuf/runtime-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sboeuf/runtime-1/statuses/{sha}","languages_url":"https://api.github.com/repos/sboeuf/runtime-1/languages","stargazers_url":"https://api.github.com/repos/sboeuf/runtime-1/stargazers","contributors_url":"https://api.github.com/repos/sboeuf/runtime-1/contributors","subscribers_url":"https://api.github.com/repos/sboeuf/runtime-1/subscribers","subscription_url":"https://api.github.com/repos/sboeuf/runtime-1/subscription","commits_url":"https://api.github.com/repos/sboeuf/runtime-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/sboeuf/runtime-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/sboeuf/runtime-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/sboeuf/runtime-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/sboeuf/runtime-1/contents/{+path}","compare_url":"https://api.github.com/repos/sboeuf/runtime-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sboeuf/runtime-1/merges","archive_url":"https://api.github.com/repos/sboeuf/runtime-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sboeuf/runtime-1/downloads","issues_url":"https://api.github.com/repos/sboeuf/runtime-1/issues{/number}","pulls_url":"https://api.github.com/repos/sboeuf/runtime-1/pulls{/number}","milestones_url":"https://api.github.com/repos/sboeuf/runtime-1/milestones{/number}","notifications_url":"https://api.github.com/repos/sboeuf/runtime-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sboeuf/runtime-1/labels{/name}","releases_url":"https://api.github.com/repos/sboeuf/runtime-1/releases{/id}","deployments_url":"https://api.github.com/repos/sboeuf/runtime-1/deployments","created_at":"2018-03-14T04:36:55Z","updated_at":"2018-03-14T04:36:57Z","pushed_at":"2018-12-21T15:38:17Z","git_url":"git://github.com/sboeuf/runtime-1.git","ssh_url":"git@github.com:sboeuf/runtime-1.git","clone_url":"https://github.com/sboeuf/runtime-1.git","svn_url":"https://github.com/sboeuf/runtime-1","homepage":"","size":13000,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kata-containers:master","ref":"master","sha":"0f6fb5439aee0b35cf783b5637f777fa54d28baa","user":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"repo":{"id":110539997,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1Mzk5OTc=","name":"runtime","full_name":"kata-containers/runtime","private":false,"owner":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kata-containers/runtime","description":"Kata Containers runtime","fork":false,"url":"https://api.github.com/repos/kata-containers/runtime","forks_url":"https://api.github.com/repos/kata-containers/runtime/forks","keys_url":"https://api.github.com/repos/kata-containers/runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kata-containers/runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kata-containers/runtime/teams","hooks_url":"https://api.github.com/repos/kata-containers/runtime/hooks","issue_events_url":"https://api.github.com/repos/kata-containers/runtime/issues/events{/number}","events_url":"https://api.github.com/repos/kata-containers/runtime/events","assignees_url":"https://api.github.com/repos/kata-containers/runtime/assignees{/user}","branches_url":"https://api.github.com/repos/kata-containers/runtime/branches{/branch}","tags_url":"https://api.github.com/repos/kata-containers/runtime/tags","blobs_url":"https://api.github.com/repos/kata-containers/runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kata-containers/runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kata-containers/runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/kata-containers/runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kata-containers/runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/kata-containers/runtime/languages","stargazers_url":"https://api.github.com/repos/kata-containers/runtime/stargazers","contributors_url":"https://api.github.com/repos/kata-containers/runtime/contributors","subscribers_url":"https://api.github.com/repos/kata-containers/runtime/subscribers","subscription_url":"https://api.github.com/repos/kata-containers/runtime/subscription","commits_url":"https://api.github.com/repos/kata-containers/runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/kata-containers/runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/kata-containers/runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/kata-containers/runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/kata-containers/runtime/contents/{+path}","compare_url":"https://api.github.com/repos/kata-containers/runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kata-containers/runtime/merges","archive_url":"https://api.github.com/repos/kata-containers/runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kata-containers/runtime/downloads","issues_url":"https://api.github.com/repos/kata-containers/runtime/issues{/number}","pulls_url":"https://api.github.com/repos/kata-containers/runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/kata-containers/runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/kata-containers/runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kata-containers/runtime/labels{/name}","releases_url":"https://api.github.com/repos/kata-containers/runtime/releases{/id}","deployments_url":"https://api.github.com/repos/kata-containers/runtime/deployments","created_at":"2017-11-13T11:29:03Z","updated_at":"2018-12-21T11:29:09Z","pushed_at":"2018-12-21T15:38:19Z","git_url":"git://github.com/kata-containers/runtime.git","ssh_url":"git@github.com:kata-containers/runtime.git","clone_url":"https://github.com/kata-containers/runtime.git","svn_url":"https://github.com/kata-containers/runtime","homepage":"","size":6860,"stargazers_count":693,"watchers_count":693,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"archived":false,"open_issues_count":233,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":143,"open_issues":233,"watchers":693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/1069"},"html":{"href":"https://github.com/kata-containers/runtime/pull/1069"},"issue":{"href":"https://api.github.com/repos/kata-containers/runtime/issues/1069"},"comments":{"href":"https://api.github.com/repos/kata-containers/runtime/issues/1069/comments"},"review_comments":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/1069/comments"},"review_comment":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/1069/commits"},"statuses":{"href":"https://api.github.com/repos/kata-containers/runtime/statuses/83e38c959ab7315e47ddf65e375540dad7319c8b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mcastelino"}}