{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/190492991","pull_request_review_id":122878044,"id":190492991,"diff_hunk":"@@ -190,6 +190,21 @@ update-config: get-cluster-credentials\n Presubmits and postsubmits are triggered by the `trigger` plugin. Be sure to\n enable that plugin by adding it to the list you created in the last section.\n \n+By default, services are not granted permission to run these jobs. Run the\n+following to grant permission to all services to create and run Prow Jobs (NOTE: This\n+command grants a permissive policy to _all_ services in the cluster. We do this\n+because the only services running in the prow starter are ones that we have\n+written and trust. This is not the recommended policy for most clusters.\n+See [RBAC documentation](https://kubernetes.io/docs/admin/authorization/rbac/) for more details):","path":"prow/getting_started.md","position":9,"original_position":9,"commit_id":"d790e742f80fcac1ed4c5877a01887784273f2cc","original_commit_id":"d790e742f80fcac1ed4c5877a01887784273f2cc","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"> Opened openshift/release#877\r\n\r\nMerged","created_at":"2018-05-24T07:49:02Z","updated_at":"2018-05-24T07:49:02Z","html_url":"https://github.com/kubernetes/test-infra/pull/8088#discussion_r190492991","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8088","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/190492991"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/8088#discussion_r190492991"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8088"}},"in_reply_to_id":189419998},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8088","id":189155510,"html_url":"https://github.com/kubernetes/test-infra/pull/8088","diff_url":"https://github.com/kubernetes/test-infra/pull/8088.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/8088.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8088","number":8088,"state":"closed","locked":false,"title":"Change prow starter to allow services to start Prow Jobs","user":{"login":"paulangton","id":7799565,"avatar_url":"https://avatars3.githubusercontent.com/u/7799565?v=4","gravatar_id":"","url":"https://api.github.com/users/paulangton","html_url":"https://github.com/paulangton","followers_url":"https://api.github.com/users/paulangton/followers","following_url":"https://api.github.com/users/paulangton/following{/other_user}","gists_url":"https://api.github.com/users/paulangton/gists{/gist_id}","starred_url":"https://api.github.com/users/paulangton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulangton/subscriptions","organizations_url":"https://api.github.com/users/paulangton/orgs","repos_url":"https://api.github.com/users/paulangton/repos","events_url":"https://api.github.com/users/paulangton/events{/privacy}","received_events_url":"https://api.github.com/users/paulangton/received_events","type":"User","site_admin":false},"body":"Small change to the Getting Started guide for Prow. It originally did not give permissions to services to create Prow Jobs. Changed to grant permissions to all services to manage Prow Jobs.","created_at":"2018-05-18T23:25:42Z","updated_at":"2018-05-24T07:49:02Z","closed_at":"2018-05-21T18:40:51Z","merged_at":"2018-05-21T18:40:51Z","merge_commit_sha":"018510445225df904f1beaefb808845b7c1017e6","assignee":{"login":"cjwagner","id":5334145,"avatar_url":"https://avatars3.githubusercontent.com/u/5334145?v=4","gravatar_id":"","url":"https://api.github.com/users/cjwagner","html_url":"https://github.com/cjwagner","followers_url":"https://api.github.com/users/cjwagner/followers","following_url":"https://api.github.com/users/cjwagner/following{/other_user}","gists_url":"https://api.github.com/users/cjwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwagner/subscriptions","organizations_url":"https://api.github.com/users/cjwagner/orgs","repos_url":"https://api.github.com/users/cjwagner/repos","events_url":"https://api.github.com/users/cjwagner/events{/privacy}","received_events_url":"https://api.github.com/users/cjwagner/received_events","type":"User","site_admin":false},"assignees":[{"login":"cjwagner","id":5334145,"avatar_url":"https://avatars3.githubusercontent.com/u/5334145?v=4","gravatar_id":"","url":"https://api.github.com/users/cjwagner","html_url":"https://github.com/cjwagner","followers_url":"https://api.github.com/users/cjwagner/followers","following_url":"https://api.github.com/users/cjwagner/following{/other_user}","gists_url":"https://api.github.com/users/cjwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwagner/subscriptions","organizations_url":"https://api.github.com/users/cjwagner/orgs","repos_url":"https://api.github.com/users/cjwagner/repos","events_url":"https://api.github.com/users/cjwagner/events{/privacy}","received_events_url":"https://api.github.com/users/cjwagner/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":705940018,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":484580953,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":366393439,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":671132825,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8088/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8088/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8088/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/d790e742f80fcac1ed4c5877a01887784273f2cc","head":{"label":"paulangton:rbac-getting-started","ref":"rbac-getting-started","sha":"d790e742f80fcac1ed4c5877a01887784273f2cc","user":{"login":"paulangton","id":7799565,"avatar_url":"https://avatars3.githubusercontent.com/u/7799565?v=4","gravatar_id":"","url":"https://api.github.com/users/paulangton","html_url":"https://github.com/paulangton","followers_url":"https://api.github.com/users/paulangton/followers","following_url":"https://api.github.com/users/paulangton/following{/other_user}","gists_url":"https://api.github.com/users/paulangton/gists{/gist_id}","starred_url":"https://api.github.com/users/paulangton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulangton/subscriptions","organizations_url":"https://api.github.com/users/paulangton/orgs","repos_url":"https://api.github.com/users/paulangton/repos","events_url":"https://api.github.com/users/paulangton/events{/privacy}","received_events_url":"https://api.github.com/users/paulangton/received_events","type":"User","site_admin":false},"repo":{"id":133848284,"name":"test-infra","full_name":"paulangton/test-infra","owner":{"login":"paulangton","id":7799565,"avatar_url":"https://avatars3.githubusercontent.com/u/7799565?v=4","gravatar_id":"","url":"https://api.github.com/users/paulangton","html_url":"https://github.com/paulangton","followers_url":"https://api.github.com/users/paulangton/followers","following_url":"https://api.github.com/users/paulangton/following{/other_user}","gists_url":"https://api.github.com/users/paulangton/gists{/gist_id}","starred_url":"https://api.github.com/users/paulangton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulangton/subscriptions","organizations_url":"https://api.github.com/users/paulangton/orgs","repos_url":"https://api.github.com/users/paulangton/repos","events_url":"https://api.github.com/users/paulangton/events{/privacy}","received_events_url":"https://api.github.com/users/paulangton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulangton/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/paulangton/test-infra","forks_url":"https://api.github.com/repos/paulangton/test-infra/forks","keys_url":"https://api.github.com/repos/paulangton/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulangton/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulangton/test-infra/teams","hooks_url":"https://api.github.com/repos/paulangton/test-infra/hooks","issue_events_url":"https://api.github.com/repos/paulangton/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/paulangton/test-infra/events","assignees_url":"https://api.github.com/repos/paulangton/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/paulangton/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/paulangton/test-infra/tags","blobs_url":"https://api.github.com/repos/paulangton/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulangton/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulangton/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulangton/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulangton/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/paulangton/test-infra/languages","stargazers_url":"https://api.github.com/repos/paulangton/test-infra/stargazers","contributors_url":"https://api.github.com/repos/paulangton/test-infra/contributors","subscribers_url":"https://api.github.com/repos/paulangton/test-infra/subscribers","subscription_url":"https://api.github.com/repos/paulangton/test-infra/subscription","commits_url":"https://api.github.com/repos/paulangton/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulangton/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulangton/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulangton/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulangton/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/paulangton/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulangton/test-infra/merges","archive_url":"https://api.github.com/repos/paulangton/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulangton/test-infra/downloads","issues_url":"https://api.github.com/repos/paulangton/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/paulangton/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/paulangton/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/paulangton/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulangton/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/paulangton/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/paulangton/test-infra/deployments","created_at":"2018-05-17T17:40:39Z","updated_at":"2018-05-22T22:01:15Z","pushed_at":"2018-05-22T22:39:12Z","git_url":"git://github.com/paulangton/test-infra.git","ssh_url":"git@github.com:paulangton/test-infra.git","clone_url":"https://github.com/paulangton/test-infra.git","svn_url":"https://github.com/paulangton/test-infra","homepage":null,"size":52674,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a234377e4c160b85267ca34d995e3b79f0569f40","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2018-05-23T23:50:44Z","pushed_at":"2018-05-24T05:29:26Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":53514,"stargazers_count":383,"watchers_count":383,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":445,"mirror_url":null,"archived":false,"open_issues_count":322,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":445,"open_issues":322,"watchers":383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8088"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/8088"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/8088"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/8088/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8088/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8088/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/d790e742f80fcac1ed4c5877a01887784273f2cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kargakis"}}