{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/172011961","pull_request_review_id":100970270,"id":172011961,"diff_hunk":"@@ -1006,6 +1006,32 @@ int ModApiMapgen::l_get_gen_notify(lua_State *L)\n }\n \n \n+// get_deco_id(deconame)\n+// returns the deco id as used in gennotify\n+int ModApiMapgen::l_get_deco_id(lua_State *L)\n+{\n+\tNO_MAP_LOCK_REQUIRED;\n+\n+\tconst char *deco_str = lua_tostring(L, 1);","path":"src/script/lua_api/l_mapgen.cpp","position":10,"original_position":10,"commit_id":"a318ba5e2d25baf8f5a874d7d588424e48f4d6be","original_commit_id":"a318ba5e2d25baf8f5a874d7d588424e48f4d6be","user":{"login":"SmallJoker","id":1497498,"avatar_url":"https://avatars1.githubusercontent.com/u/1497498?v=4","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"body":"`luaL_checkstring` is more appropriate here as it throws an error for a wrong use of this function or `nil` values","created_at":"2018-03-03T09:40:44Z","updated_at":"2018-03-03T09:40:44Z","html_url":"https://github.com/minetest/minetest/pull/7092#discussion_r172011961","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/7092","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/172011961"},"html":{"href":"https://github.com/minetest/minetest/pull/7092#discussion_r172011961"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7092"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/7092","id":172609619,"html_url":"https://github.com/minetest/minetest/pull/7092","diff_url":"https://github.com/minetest/minetest/pull/7092.diff","patch_url":"https://github.com/minetest/minetest/pull/7092.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7092","number":7092,"state":"open","locked":false,"title":"Decorations: Add API for decoration ID from decoration name","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"body":"Needed for use with gennotify, as the deco ID depends on mods present and mod load order.\r\nHowever to use this the decoration must be given a name, currently MTG does not name its decorations (TODO): `name = \"apple_tree\",`\r\nCode is edited copypaste from\r\nhttps://github.com/minetest/minetest/blob/e7f16119913f7b2c98059398085d410684c9d8c0/src/script/lua_api/l_mapgen.cpp#L467\r\nTested.","created_at":"2018-03-02T21:31:09Z","updated_at":"2018-03-03T09:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc2b38fee53ca2bc9147cf82299e7ddf52bb4019","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":73368996,"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Mapgen","name":"@ Mapgen","color":"009800","default":false},{"id":73368983,"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Script%20API","name":"@ Script API","color":"009800","default":false},{"id":780713225,"url":"https://api.github.com/repos/minetest/minetest/labels/Documentation%20needed","name":"Documentation needed","color":"f9d0c4","default":false},{"id":471238548,"url":"https://api.github.com/repos/minetest/minetest/labels/Feature","name":"Feature","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/7092/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/7092/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7092/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/a318ba5e2d25baf8f5a874d7d588424e48f4d6be","head":{"label":"paramat:decoid","ref":"decoid","sha":"a318ba5e2d25baf8f5a874d7d588424e48f4d6be","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"repo":{"id":25287736,"name":"minetest","full_name":"paramat/minetest","owner":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paramat/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/paramat/minetest","forks_url":"https://api.github.com/repos/paramat/minetest/forks","keys_url":"https://api.github.com/repos/paramat/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paramat/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paramat/minetest/teams","hooks_url":"https://api.github.com/repos/paramat/minetest/hooks","issue_events_url":"https://api.github.com/repos/paramat/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/paramat/minetest/events","assignees_url":"https://api.github.com/repos/paramat/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/paramat/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/paramat/minetest/tags","blobs_url":"https://api.github.com/repos/paramat/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paramat/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paramat/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/paramat/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paramat/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/paramat/minetest/languages","stargazers_url":"https://api.github.com/repos/paramat/minetest/stargazers","contributors_url":"https://api.github.com/repos/paramat/minetest/contributors","subscribers_url":"https://api.github.com/repos/paramat/minetest/subscribers","subscription_url":"https://api.github.com/repos/paramat/minetest/subscription","commits_url":"https://api.github.com/repos/paramat/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/paramat/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/paramat/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/paramat/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/paramat/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/paramat/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paramat/minetest/merges","archive_url":"https://api.github.com/repos/paramat/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paramat/minetest/downloads","issues_url":"https://api.github.com/repos/paramat/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/paramat/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/paramat/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/paramat/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paramat/minetest/labels{/name}","releases_url":"https://api.github.com/repos/paramat/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/paramat/minetest/deployments","created_at":"2014-10-16T05:25:29Z","updated_at":"2016-10-24T04:29:17Z","pushed_at":"2018-03-02T21:28:26Z","git_url":"git://github.com/paramat/minetest.git","ssh_url":"git@github.com:paramat/minetest.git","clone_url":"https://github.com/paramat/minetest.git","svn_url":"https://github.com/paramat/minetest","homepage":"http://minetest.net/","size":55265,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"e7f16119913f7b2c98059398085d410684c9d8c0","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game engine and game with survival and crafting. Also see https://github.com/minetest/minetest_game","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2018-03-02T21:30:06Z","pushed_at":"2018-03-02T21:31:10Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":55655,"stargazers_count":3171,"watchers_count":3171,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":884,"mirror_url":null,"archived":false,"open_issues_count":919,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":884,"open_issues":919,"watchers":3171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7092"},"html":{"href":"https://github.com/minetest/minetest/pull/7092"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/7092"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/7092/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7092/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7092/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/a318ba5e2d25baf8f5a874d7d588424e48f4d6be"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"SmallJoker"}}