{"action":"created","issue":{"url":"https://api.github.com/repos/librenms/librenms/issues/8989","repository_url":"https://api.github.com/repos/librenms/librenms","labels_url":"https://api.github.com/repos/librenms/librenms/issues/8989/labels{/name}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/8989/comments","events_url":"https://api.github.com/repos/librenms/librenms/issues/8989/events","html_url":"https://github.com/librenms/librenms/pull/8989","id":347998736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDU2MDUx","number":8989,"title":"Option to filter availability map widget by device groups","user":{"login":"shaheen69","id":22576887,"node_id":"MDQ6VXNlcjIyNTc2ODg3","avatar_url":"https://avatars2.githubusercontent.com/u/22576887?v=4","gravatar_id":"","url":"https://api.github.com/users/shaheen69","html_url":"https://github.com/shaheen69","followers_url":"https://api.github.com/users/shaheen69/followers","following_url":"https://api.github.com/users/shaheen69/following{/other_user}","gists_url":"https://api.github.com/users/shaheen69/gists{/gist_id}","starred_url":"https://api.github.com/users/shaheen69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaheen69/subscriptions","organizations_url":"https://api.github.com/users/shaheen69/orgs","repos_url":"https://api.github.com/users/shaheen69/repos","events_url":"https://api.github.com/users/shaheen69/events{/privacy}","received_events_url":"https://api.github.com/users/shaheen69/received_events","type":"User","site_admin":false},"labels":[{"id":1033624530,"node_id":"MDU6TGFiZWwxMDMzNjI0NTMw","url":"https://api.github.com/repos/librenms/librenms/labels/User-Pending","name":"User-Pending","color":"f9d0c4","default":false},{"id":211051786,"node_id":"MDU6TGFiZWwyMTEwNTE3ODY=","url":"https://api.github.com/repos/librenms/librenms/labels/WebUI","name":"WebUI","color":"99CCFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/librenms/librenms/milestones/18","html_url":"https://github.com/librenms/librenms/milestone/18","labels_url":"https://api.github.com/repos/librenms/librenms/milestones/18/labels","id":3346605,"node_id":"MDk6TWlsZXN0b25lMzM0NjYwNQ==","number":18,"title":"1.44","description":"","creator":{"login":"laf","id":3941142,"node_id":"MDQ6VXNlcjM5NDExNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3941142?v=4","gravatar_id":"","url":"https://api.github.com/users/laf","html_url":"https://github.com/laf","followers_url":"https://api.github.com/users/laf/followers","following_url":"https://api.github.com/users/laf/following{/other_user}","gists_url":"https://api.github.com/users/laf/gists{/gist_id}","starred_url":"https://api.github.com/users/laf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laf/subscriptions","organizations_url":"https://api.github.com/users/laf/orgs","repos_url":"https://api.github.com/users/laf/repos","events_url":"https://api.github.com/users/laf/events{/privacy}","received_events_url":"https://api.github.com/users/laf/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":0,"state":"open","created_at":"2018-05-14T20:25:56Z","updated_at":"2018-08-30T20:01:14Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"comments":8,"created_at":"2018-08-06T16:43:15Z","updated_at":"2018-08-31T14:19:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/8989","html_url":"https://github.com/librenms/librenms/pull/8989","diff_url":"https://github.com/librenms/librenms/pull/8989.diff","patch_url":"https://github.com/librenms/librenms/pull/8989.patch"},"body":"Added an option for device groups to filter devices/services displayed on the availability map to based on the selected device group.\r\n\r\nDO NOT DELETE THIS TEXT\r\n\r\n#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n#### Testers\r\n\r\nIf you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`\r\n"},"comment":{"url":"https://api.github.com/repos/librenms/librenms/issues/comments/417678809","html_url":"https://github.com/librenms/librenms/pull/8989#issuecomment-417678809","issue_url":"https://api.github.com/repos/librenms/librenms/issues/8989","id":417678809,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzY3ODgwOQ==","user":{"login":"shaheen69","id":22576887,"node_id":"MDQ6VXNlcjIyNTc2ODg3","avatar_url":"https://avatars2.githubusercontent.com/u/22576887?v=4","gravatar_id":"","url":"https://api.github.com/users/shaheen69","html_url":"https://github.com/shaheen69","followers_url":"https://api.github.com/users/shaheen69/followers","following_url":"https://api.github.com/users/shaheen69/following{/other_user}","gists_url":"https://api.github.com/users/shaheen69/gists{/gist_id}","starred_url":"https://api.github.com/users/shaheen69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaheen69/subscriptions","organizations_url":"https://api.github.com/users/shaheen69/orgs","repos_url":"https://api.github.com/users/shaheen69/repos","events_url":"https://api.github.com/users/shaheen69/events{/privacy}","received_events_url":"https://api.github.com/users/shaheen69/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T14:19:10Z","updated_at":"2018-08-31T14:19:10Z","author_association":"NONE","body":"> What's the issue you came across as that config isn't used in the menu system itself.\r\n\r\nSorry, I wasn't clear, what I meant is...\r\nIf you go the full screen Availability Map in the located at 'Overview->Maps->Availability', it's uses the same file as the **availability-map widget** that is used on the dashboard. If I remove the `$config['webui']['availability_map_use_device_groups']` checks in the file `html/includes/common/availability-map.inc.php`, the 'device groups' filter on the full screen Availability Map no longer functions. Hence I think I should leave those checks in place on the widget, even though it doesn't affect the widget when removed.\r\n\r\n> Got a patch for what you tried?\r\n\r\nNot sure how to do this yet (send a patch), this is my first experience in contributing to an open source  project as well as using Git. Would that be something you could guide me on?\r\n\r\nI also see that the widget has recently been updated, I'll resolve the conflicts for my changes and push an update shortly."}}
{"actor":{"display_login":"shaheen69"}}