{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/59984","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/59984/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/59984/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/59984/events","html_url":"https://github.com/Microsoft/vscode/issues/59984","id":366880211,"node_id":"MDU6SXNzdWUzNjY4ODAyMTE=","number":59984,"title":"Breakpoint line numbers don't update in UI when sending a `changed` BreakpointEvent","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"labels":[{"id":256129993,"node_id":"MDU6TGFiZWwyNTYxMjk5OTM=","url":"https://api.github.com/repos/Microsoft/vscode/labels/bug","name":"bug","color":"8D6673","default":true},{"id":291054922,"node_id":"MDU6TGFiZWwyOTEwNTQ5MjI=","url":"https://api.github.com/repos/Microsoft/vscode/labels/debug","name":"debug","color":"1d76db","default":false}],"state":"closed","locked":false,"assignee":{"login":"isidorn","id":1926584,"node_id":"MDQ6VXNlcjE5MjY1ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1926584?v=4","gravatar_id":"","url":"https://api.github.com/users/isidorn","html_url":"https://github.com/isidorn","followers_url":"https://api.github.com/users/isidorn/followers","following_url":"https://api.github.com/users/isidorn/following{/other_user}","gists_url":"https://api.github.com/users/isidorn/gists{/gist_id}","starred_url":"https://api.github.com/users/isidorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidorn/subscriptions","organizations_url":"https://api.github.com/users/isidorn/orgs","repos_url":"https://api.github.com/users/isidorn/repos","events_url":"https://api.github.com/users/isidorn/events{/privacy}","received_events_url":"https://api.github.com/users/isidorn/received_events","type":"User","site_admin":false},"assignees":[{"login":"isidorn","id":1926584,"node_id":"MDQ6VXNlcjE5MjY1ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1926584?v=4","gravatar_id":"","url":"https://api.github.com/users/isidorn","html_url":"https://github.com/isidorn","followers_url":"https://api.github.com/users/isidorn/followers","following_url":"https://api.github.com/users/isidorn/following{/other_user}","gists_url":"https://api.github.com/users/isidorn/gists{/gist_id}","starred_url":"https://api.github.com/users/isidorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidorn/subscriptions","organizations_url":"https://api.github.com/users/isidorn/orgs","repos_url":"https://api.github.com/users/isidorn/repos","events_url":"https://api.github.com/users/isidorn/events{/privacy}","received_events_url":"https://api.github.com/users/isidorn/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/78","html_url":"https://github.com/Microsoft/vscode/milestone/78","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/78/labels","id":3639536,"node_id":"MDk6TWlsZXN0b25lMzYzOTUzNg==","number":78,"title":"October 2018","description":"","creator":{"login":"Tyriar","id":2193314,"node_id":"MDQ6VXNlcjIxOTMzMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2193314?v=4","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"open_issues":162,"closed_issues":366,"state":"open","created_at":"2018-09-10T14:15:00Z","updated_at":"2018-10-24T13:26:05Z","due_on":null,"closed_at":null},"comments":20,"created_at":"2018-10-04T16:51:03Z","updated_at":"2018-10-24T13:37:15Z","closed_at":"2018-10-23T13:54:49Z","author_association":"NONE","body":"I'm working on the debugger for Dart. I'm trying to fix a long-standing issue where we never properly \"resolved\" breakpoints which could result in breaking on a different line to the one the user picked. However, I've found that when trying to resolve breakpoints and sending Code a BreakpointEvent, it doesn't update the line number in the UI.\r\n\r\nBefore the debug session, my code/breakpoints looks like this:\r\n\r\n![screen shot 2018-10-04 at 5 46 04 pm](https://user-images.githubusercontent.com/1078012/46489485-6af69b80-c7fd-11e8-9823-ff92e858c655.png)\r\n\r\nWhen I run this, my DA returns an empty array for breakpoints from the `setBreakpointsRequest` call and then shortly after I sent BreakpointEvents to add the breakpoints (first at their original location) then to change them (fix the locations and mark as resolved):\r\n\r\n```ts\r\n} else if (kind === \"BreakpointAdded\") {\r\n\tthis.sendBreakPointToCode(this.knownBreakpoints[event.breakpoint.id] ? \"changed\" : \"new\", event.isolate, event.breakpoint);\r\n} else if (kind === \"BreakpointResolved\") {\r\n\tthis.sendBreakPointToCode(\"changed\", event.isolate, event.breakpoint);\r\n} else if (kind === \"BreakpointRemoved\") {\r\n\tthis.sendBreakPointToCode(\"removed\", event.isolate, event.breakpoint);\r\n}\r\n\r\n// ...\r\n\r\nprivate async sendBreakPointToCode(action: string, isolate: VMIsolateRef, breakpoint: VMBreakpoint): Promise<void> {\r\n\tconst bp = await this.vmBpToCodeBp(isolate, breakpoint);\r\n\tconsole.log(`Sending ${action} BP to Code (ID: ${bp.id}) line: ${bp.line} col: ${bp.column} in ${bp.source.path}`);\r\n\tthis.sendEvent(new BreakpointEvent(action, bp));\r\n}\r\n```\r\n\r\nMy logging outputs:\r\n\r\n```text\r\nSending BP to VM for thread isolates/1019045726 file:///Users/dantup/Desktop/Dart%20Sample/bin/donotformat/test.dart 2:undefined\r\nSending BP to VM for thread isolates/1019045726 file:///Users/dantup/Desktop/Dart%20Sample/bin/donotformat/test.dart 9:undefined\r\nSending new BP to Code (ID: 1) line: 2 col: undefined in /Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart\r\nSending new BP to Code (ID: 2) line: 9 col: undefined in /Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart\r\nSending changed BP to Code (ID: 2) line: 10 col: 5 in /Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart\r\nSending changed BP to Code (ID: 1) line: 2 col: 13 in /Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart\r\n```\r\n\r\nHowever, VS Code never updates the breakpoint from line 9 to line 10:\r\n\r\n![screen shot 2018-10-04 at 5 50 02 pm](https://user-images.githubusercontent.com/1078012/46489677-f53eff80-c7fd-11e8-8ae4-e3e5e41eedd8.png)\r\n\r\n![screen shot 2018-10-04 at 5 50 06 pm](https://user-images.githubusercontent.com/1078012/46489685-f8d28680-c7fd-11e8-844d-0c8c4a0943bf.png)\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/432658980","html_url":"https://github.com/Microsoft/vscode/issues/59984#issuecomment-432658980","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/59984","id":432658980,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjY1ODk4MA==","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T13:37:15Z","updated_at":"2018-10-24T13:37:15Z","author_association":"NONE","body":"`breakpoint.lineNumber` is undefined:\r\n\r\n![screen shot 2018-10-24 at 2 36 30 pm](https://user-images.githubusercontent.com/1078012/47434343-49ecef00-d79a-11e8-934c-ac73cfb93d85.png)\r\n![screen shot 2018-10-24 at 2 36 45 pm](https://user-images.githubusercontent.com/1078012/47434345-49ecef00-d79a-11e8-8cfd-9aebfd42d104.png)\r\n"}}
{"actor":{"display_login":"DanTup"}}