{"push_id":3108922503,"size":16,"distinct_size":16,"ref":"refs/heads/master","head":"50e754cd579933ba887927f4ff05754ad926eb30","before":"320085a04d6db82421cf6c2870071ab2cb54d22b","commits":[{"sha":"6e167029478e29d24ff75d259123e7f7e093b6ff","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Add ability to retrieve runtime configuration from DB\n\nWhen we create a Libpod database, we store a number of runtime\nconfiguration fields in it. If we can retrieve those, we can use\nthem to configure the runtime to match the DB instead of inbuilt\ndefaults, helping to ensure that we don't error in cases where\nour compiled-in defaults changed.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/6e167029478e29d24ff75d259123e7f7e093b6ff"},{"sha":"b0f79ff4df58c12fdfaff5c4a7c6e029cb566459","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Move DB configuration up in runtime setup\n\nWhen we configure a runtime, we now will need to hit the DB early\non, so we can verify the paths we're going to use for c/storage are correct.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/b0f79ff4df58c12fdfaff5c4a7c6e029cb566459"},{"sha":"137e0948aed96c3fe6412512e0d138eedf71d499","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Make DB config validation an explicit step\n\nPreviously, we implicitly validated runtime configuration against\nwhat was stored in the database as part of database init. Make\nthis an explicit step, so we can call it after the database has\nbeen initialized. This will allow us to retrieve paths from the\ndatabase and use them to overwrite our defaults if they differ.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/137e0948aed96c3fe6412512e0d138eedf71d499"},{"sha":"aa7ce33b7a7698d220f258bf9b29068be6fdb531","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Add a struct indicating if some Runtime fields were set\n\nTo configure runtime fields from the database, we need to know\nwhether they were explicitly overwritten by the user (we don't\nwant to overwrite anything that was explicitly set). Store a\nstruct containing whether the variables we'll grab from the DB\nwere explicitly set by the user so we know what we can and can't\noverwrite.\n\nThis determines whether libpod runtime and static dirs were set\nvia config file in a horribly hackish way (double TOML decode),\nbut I can't think of a better way, and it shouldn't be that\nexpensive as the libpod config is tiny.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/aa7ce33b7a7698d220f258bf9b29068be6fdb531"},{"sha":"92ff83f5b9dd00ff91dc8c3d6b48f1e0b5c5f3e2","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Set default paths from DB if not explicitly overridden\n\nIf the DB contains default paths, and the user has not explicitly\noverridden them, use the paths in the DB over our own defaults.\n\nThe DB validates these paths, so it would error and prevent\noperation if they did not match. As such, instead of erroring, we\ncan use the DB's paths instead of our own.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/92ff83f5b9dd00ff91dc8c3d6b48f1e0b5c5f3e2"},{"sha":"562fa57dc9f497db772baa03bfa052082db68646","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Move rootless storage config into libpod\n\nPrevious commits ensured that we would use database-configured\npaths if not explicitly overridden.\n\nHowever, our runtime generation did unconditionally override\nstorage config, which made this useless.\n\nMove rootless storage configuration setup to libpod, and change\nstorage setup so we only override if a setting is explicitly\nset, so we can still override what we want.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/562fa57dc9f497db772baa03bfa052082db68646"},{"sha":"03229239b018b611b5f0307dc0d11bb0fb15c1ae","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Do not initialize locks dir in BoltDB\n\nWe already create the locks directory as part of the libpod\nruntime's init - no need to do it again as part of BoltDB's init.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/03229239b018b611b5f0307dc0d11bb0fb15c1ae"},{"sha":"69ed2ccc54f48b8fff30e28644ad96d56d093dd1","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Make locks dir in unit tests\n\nEnsure we don't break the unit tests by creating a locks\ndirectory (which, prior to the last commit, would be created by\nBoltDB state init).\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/69ed2ccc54f48b8fff30e28644ad96d56d093dd1"},{"sha":"b104a45f35a437593774f851b0a3b45fd692b263","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Fix gofmt and lint\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/b104a45f35a437593774f851b0a3b45fd692b263"},{"sha":"32fc865b6d0b530b74b1429775d3f1f5f24f288a","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Add better descriptions for validation errors in DB\n\nWhen validating fields against the DB, report more verbosely the\nname of the field being validated if it fails. Specifically, add\nthe name used in config files, so people will actually know what\nto change it errors happen.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/32fc865b6d0b530b74b1429775d3f1f5f24f288a"},{"sha":"ea13264958f3382fe8fe6a9709a7eae00f753acc","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Fix typo\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/ea13264958f3382fe8fe6a9709a7eae00f753acc"},{"sha":"677c44446375680c5a69a9612f7df42b25de783f","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Ensure directory where we will make database exists\n\nEnsure that the directory where we will create the Podman db\nexists prior to creating the database - otherwise creating the DB\nwill fail.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/677c44446375680c5a69a9612f7df42b25de783f"},{"sha":"7c575bdce26b0cc5560bb5a8fe5ac680c2843903","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Fix libpod static dir selection when graphroot changed\n\nWhen graphroot is set by the user, we should set libpod's static\ndirectory to a subdirectory of that by default, to duplicate\nprevious behavior.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/7c575bdce26b0cc5560bb5a8fe5ac680c2843903"},{"sha":"795fbba7695b03736acaf9abe75922404f5eea44","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Revert changes to GetDefaultStoreOptions\n\nWe don't need this for anything more than rootless work in Libpod\nnow, but Buildah still uses it as it was originally written, so\nleave it intact as part of our API.\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/795fbba7695b03736acaf9abe75922404f5eea44"},{"sha":"e3882cfa2d1329d44c8a580418ea1d56804b331d","author":{"name":"Matthew Heon","email":"b9ec3270cf4e91ac388bb1d81bcc7fb682087ac3@redhat.com"},"message":"Use runtime lockDir in BoltDB state\n\nInstead of storing the runtime's file lock dir in the BoltDB\nstate, refer to the runtime inside the Bolt state instead, and\nuse the path stored in the runtime.\n\nThis is necessary since we moved DB initialization very far up in\nruntime init, before the locks dir is properly initialized (and\nit must happen before the locks dir can be created, as we use the\nDB to retrieve the proper path for the locks dir now).\n\nSigned-off-by: Matthew Heon <mheon@redhat.com>","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/e3882cfa2d1329d44c8a580418ea1d56804b331d"},{"sha":"50e754cd579933ba887927f4ff05754ad926eb30","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #1918 from mheon/use_db_paths\n\nUse paths written in DB instead if they differ from our defaults","distinct":true,"url":"https://api.github.com/repos/containers/libpod/commits/50e754cd579933ba887927f4ff05754ad926eb30"}]}
{"actor":{"display_login":"openshift-merge-robot"}}