{"action":"created","issue":{"url":"https://api.github.com/repos/LSSTDESC/sims_GCRCatSimInterface/issues/19","repository_url":"https://api.github.com/repos/LSSTDESC/sims_GCRCatSimInterface","labels_url":"https://api.github.com/repos/LSSTDESC/sims_GCRCatSimInterface/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/LSSTDESC/sims_GCRCatSimInterface/issues/19/comments","events_url":"https://api.github.com/repos/LSSTDESC/sims_GCRCatSimInterface/issues/19/events","html_url":"https://github.com/LSSTDESC/sims_GCRCatSimInterface/pull/19","id":293128809,"number":19,"title":"Issue phosim catalog sn","user":{"login":"rbiswas4","id":2281358,"avatar_url":"https://avatars2.githubusercontent.com/u/2281358?v=4","gravatar_id":"","url":"https://api.github.com/users/rbiswas4","html_url":"https://github.com/rbiswas4","followers_url":"https://api.github.com/users/rbiswas4/followers","following_url":"https://api.github.com/users/rbiswas4/following{/other_user}","gists_url":"https://api.github.com/users/rbiswas4/gists{/gist_id}","starred_url":"https://api.github.com/users/rbiswas4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbiswas4/subscriptions","organizations_url":"https://api.github.com/users/rbiswas4/orgs","repos_url":"https://api.github.com/users/rbiswas4/repos","events_url":"https://api.github.com/users/rbiswas4/events{/privacy}","received_events_url":"https://api.github.com/users/rbiswas4/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2018-01-31T11:46:53Z","updated_at":"2018-02-01T20:20:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/LSSTDESC/sims_GCRCatSimInterface/pulls/19","html_url":"https://github.com/LSSTDESC/sims_GCRCatSimInterface/pull/19","diff_url":"https://github.com/LSSTDESC/sims_GCRCatSimInterface/pull/19.diff","patch_url":"https://github.com/LSSTDESC/sims_GCRCatSimInterface/pull/19.patch"},"body":"Committed changes for writing out phosim catalogs of SN populations. \r\n\r\n## Inputs\r\n\r\nTh\u0010\u0010\u0010ere are data files in `data/` that represent SN in protoDC2 hosts in the Main Survey Region and the uDDF region separately. There are also three files that include SN that in hostless in the uDDF region and those in the  Main Survey at z < 1.0 and those in the Main Survey at z > 1.0 . These files are:\r\n- MainSurveyHostedSNPositions_trimmed.csv \r\n- MainSurvey_hostlessSN_trimmed.csv       \r\n- MainSurvey_hostlessSN_highz_trimmed.csv \r\n- uDDFHostedSNPositions_trimmed.csv\r\n- uDDF_hostlessSN_trimmed.csv\r\n\r\nThey include the position and properties of the SN using which catsim can create images.\r\n\r\n## The catalog classes\r\nThese are two new classes in `python/desc/sims/GCRCatSimInterface/CatalogClasses.py`\r\n- `SNFileDBObject` : which uses catsim functionality to read from the csv files rather than fatboy which we did in Twinkles.\r\n- `DC2PhosimCatalogSN` : Class to modify phosim catalogs for SN for the DC2 Run 1.1 .  A lot of this was mostly in Twinkles, but that seems hard to work with. So, there is some re-implementation.\r\n## convenience functions \r\nThere is a convenience function in `python/desc/sims/GCRCatSimInterface/InstanceCatalogWriter.py`\r\n- `snphosimcat` : uses the catalog classes to give a phosim instance catalog which can be written out.\r\n\r\n## Demo : \r\nThere is an example of how to use the phosim catalog in `\r\n`Notebooks/demo_phosimcatalogs.ipynb`\r\n\r\n## Storage:\r\nThe way the current method works is that it writes out a filename of the phosim spectrum to the instance catalog, but the spectra are written out to `spectra_files/Dynamic`. We can change this to point to the path we like, and we can also make sure that we don't have to put the entire path on the phosim instance catalog row."},"comment":{"url":"https://api.github.com/repos/LSSTDESC/sims_GCRCatSimInterface/issues/comments/362389787","html_url":"https://github.com/LSSTDESC/sims_GCRCatSimInterface/pull/19#issuecomment-362389787","issue_url":"https://api.github.com/repos/LSSTDESC/sims_GCRCatSimInterface/issues/19","id":362389787,"user":{"login":"jchiang87","id":1994473,"avatar_url":"https://avatars3.githubusercontent.com/u/1994473?v=4","gravatar_id":"","url":"https://api.github.com/users/jchiang87","html_url":"https://github.com/jchiang87","followers_url":"https://api.github.com/users/jchiang87/followers","following_url":"https://api.github.com/users/jchiang87/following{/other_user}","gists_url":"https://api.github.com/users/jchiang87/gists{/gist_id}","starred_url":"https://api.github.com/users/jchiang87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchiang87/subscriptions","organizations_url":"https://api.github.com/users/jchiang87/orgs","repos_url":"https://api.github.com/users/jchiang87/repos","events_url":"https://api.github.com/users/jchiang87/events{/privacy}","received_events_url":"https://api.github.com/users/jchiang87/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T20:20:26Z","updated_at":"2018-02-01T20:20:26Z","author_association":"COLLABORATOR","body":"So after doing the git pull, I tried to rerun that command line and the code is failing with sqlalchemy errors.  I don't see how the last two commits could possibly cause an issue, but I think we need to get this working before merging.\r\n"}}
{"actor":{"display_login":"jchiang87"}}