{"action":"created","comment":{"url":"https://api.github.com/repos/consul/consul/pulls/comments/220090346","pull_request_review_id":158415651,"id":220090346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDA5MDM0Ng==","diff_hunk":"@@ -3,7 +3,7 @@\n <ul class=\"features\">\n   <li><%= link_to t(\"pages.help.other.how_to_use\", org_name: setting['org_name']), how_to_use_path %></li>\n \n-  <% SiteCustomization::Page.with_more_info_flag.with_same_locale.each do |custom_page| %>\n+  <% SiteCustomization::Page.with_more_info_flag.each do |custom_page| %>","path":"app/views/pages/help/_other.html.erb","position":5,"original_position":5,"commit_id":"786a9f24baa25321d847942634062085534da558","original_commit_id":"786a9f24baa25321d847942634062085534da558","user":{"login":"papayalabs","id":5271149,"node_id":"MDQ6VXNlcjUyNzExNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5271149?v=4","gravatar_id":"","url":"https://api.github.com/users/papayalabs","html_url":"https://github.com/papayalabs","followers_url":"https://api.github.com/users/papayalabs/followers","following_url":"https://api.github.com/users/papayalabs/following{/other_user}","gists_url":"https://api.github.com/users/papayalabs/gists{/gist_id}","starred_url":"https://api.github.com/users/papayalabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papayalabs/subscriptions","organizations_url":"https://api.github.com/users/papayalabs/orgs","repos_url":"https://api.github.com/users/papayalabs/repos","events_url":"https://api.github.com/users/papayalabs/events{/privacy}","received_events_url":"https://api.github.com/users/papayalabs/received_events","type":"User","site_admin":false},"body":"I am agree. Will add again with_same_local scope and check to simplify the condition.","created_at":"2018-09-25T07:54:05Z","updated_at":"2018-09-25T07:54:05Z","html_url":"https://github.com/consul/consul/pull/2913#discussion_r220090346","pull_request_url":"https://api.github.com/repos/consul/consul/pulls/2913","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/consul/consul/pulls/comments/220090346"},"html":{"href":"https://github.com/consul/consul/pull/2913#discussion_r220090346"},"pull_request":{"href":"https://api.github.com/repos/consul/consul/pulls/2913"}},"in_reply_to_id":219867316},"pull_request":{"url":"https://api.github.com/repos/consul/consul/pulls/2913","id":216968869,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTY4ODY5","html_url":"https://github.com/consul/consul/pull/2913","diff_url":"https://github.com/consul/consul/pull/2913.diff","patch_url":"https://github.com/consul/consul/pull/2913.patch","issue_url":"https://api.github.com/repos/consul/consul/issues/2913","number":2913,"state":"open","locked":false,"title":"Updates translatable custom pages","user":{"login":"papayalabs","id":5271149,"node_id":"MDQ6VXNlcjUyNzExNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5271149?v=4","gravatar_id":"","url":"https://api.github.com/users/papayalabs","html_url":"https://github.com/papayalabs","followers_url":"https://api.github.com/users/papayalabs/followers","following_url":"https://api.github.com/users/papayalabs/following{/other_user}","gists_url":"https://api.github.com/users/papayalabs/gists{/gist_id}","starred_url":"https://api.github.com/users/papayalabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papayalabs/subscriptions","organizations_url":"https://api.github.com/users/papayalabs/orgs","repos_url":"https://api.github.com/users/papayalabs/repos","events_url":"https://api.github.com/users/papayalabs/events{/privacy}","received_events_url":"https://api.github.com/users/papayalabs/received_events","type":"User","site_admin":false},"body":"References\r\n===================\r\nIssue [#2741](https://github.com/consul/consul/issues/2741)\r\n\r\nVisual Changes\r\n===================\r\n> In custom page index we replace 'title' with 'slug' because title could be in many languages. We drop 'locale' from table because does not make sense now.\r\n![screen shot 2018-08-06 at 3 51 03 pm](https://user-images.githubusercontent.com/5271149/43740798-ef4a590c-9991-11e8-8c3d-a66755ed0c77.jpg)\r\nEditing with many languages\r\n![screen shot 2018-08-06 at 3 51 16 pm](https://user-images.githubusercontent.com/5271149/43740831-09e0693c-9992-11e8-8b05-07054630d6f8.jpg)\r\n\r\n\r\nNotes\r\n===================\r\nIn custom page index we replace 'title' with 'slug' because title could be in many languages. We drop 'locale' from table because does not make sense now.\r\n\r\nIn the migration of translation tables of custom pages ( 20180802221830_add_translate_pages.rb ) we add a change_column to allow null in title. Title is not used anymore as index in table and now is used in many languages title_en,title_es,title_fr, etc. Give NullConstraint from database if do not make this change.\r\n\r\n    class AddTranslatePages < ActiveRecord::Migration\r\n      def self.up\r\n        SiteCustomization::Page.create_translation_table!({\r\n          title: :string,\r\n          subtitle: :string,\r\n          content: :text\r\n        })\r\n        change_column :site_customization_pages, :title, :string, :null => true\r\n      end\r\n\r\n      def self.down\r\n        SiteCustomization::Page.drop_translation_table!\r\n        change_column :site_customization_pages, :title, :string, :null => false\r\n      end\r\n    end\r\n","created_at":"2018-09-20T13:19:05Z","updated_at":"2018-09-25T07:54:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffe094016c64376c2a966eeaeda23b4d060845d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/consul/consul/pulls/2913/commits","review_comments_url":"https://api.github.com/repos/consul/consul/pulls/2913/comments","review_comment_url":"https://api.github.com/repos/consul/consul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/consul/consul/issues/2913/comments","statuses_url":"https://api.github.com/repos/consul/consul/statuses/786a9f24baa25321d847942634062085534da558","head":{"label":"papayalabs:2741-updates-translatable-custom-pages-reloaded","ref":"2741-updates-translatable-custom-pages-reloaded","sha":"786a9f24baa25321d847942634062085534da558","user":{"login":"papayalabs","id":5271149,"node_id":"MDQ6VXNlcjUyNzExNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5271149?v=4","gravatar_id":"","url":"https://api.github.com/users/papayalabs","html_url":"https://github.com/papayalabs","followers_url":"https://api.github.com/users/papayalabs/followers","following_url":"https://api.github.com/users/papayalabs/following{/other_user}","gists_url":"https://api.github.com/users/papayalabs/gists{/gist_id}","starred_url":"https://api.github.com/users/papayalabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papayalabs/subscriptions","organizations_url":"https://api.github.com/users/papayalabs/orgs","repos_url":"https://api.github.com/users/papayalabs/repos","events_url":"https://api.github.com/users/papayalabs/events{/privacy}","received_events_url":"https://api.github.com/users/papayalabs/received_events","type":"User","site_admin":false},"repo":{"id":143572624,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1NzI2MjQ=","name":"consul","full_name":"papayalabs/consul","private":false,"owner":{"login":"papayalabs","id":5271149,"node_id":"MDQ6VXNlcjUyNzExNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5271149?v=4","gravatar_id":"","url":"https://api.github.com/users/papayalabs","html_url":"https://github.com/papayalabs","followers_url":"https://api.github.com/users/papayalabs/followers","following_url":"https://api.github.com/users/papayalabs/following{/other_user}","gists_url":"https://api.github.com/users/papayalabs/gists{/gist_id}","starred_url":"https://api.github.com/users/papayalabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papayalabs/subscriptions","organizations_url":"https://api.github.com/users/papayalabs/orgs","repos_url":"https://api.github.com/users/papayalabs/repos","events_url":"https://api.github.com/users/papayalabs/events{/privacy}","received_events_url":"https://api.github.com/users/papayalabs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/papayalabs/consul","description":"Consul - Open Government and E-Participation Web Software","fork":true,"url":"https://api.github.com/repos/papayalabs/consul","forks_url":"https://api.github.com/repos/papayalabs/consul/forks","keys_url":"https://api.github.com/repos/papayalabs/consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/papayalabs/consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/papayalabs/consul/teams","hooks_url":"https://api.github.com/repos/papayalabs/consul/hooks","issue_events_url":"https://api.github.com/repos/papayalabs/consul/issues/events{/number}","events_url":"https://api.github.com/repos/papayalabs/consul/events","assignees_url":"https://api.github.com/repos/papayalabs/consul/assignees{/user}","branches_url":"https://api.github.com/repos/papayalabs/consul/branches{/branch}","tags_url":"https://api.github.com/repos/papayalabs/consul/tags","blobs_url":"https://api.github.com/repos/papayalabs/consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/papayalabs/consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/papayalabs/consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/papayalabs/consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/papayalabs/consul/statuses/{sha}","languages_url":"https://api.github.com/repos/papayalabs/consul/languages","stargazers_url":"https://api.github.com/repos/papayalabs/consul/stargazers","contributors_url":"https://api.github.com/repos/papayalabs/consul/contributors","subscribers_url":"https://api.github.com/repos/papayalabs/consul/subscribers","subscription_url":"https://api.github.com/repos/papayalabs/consul/subscription","commits_url":"https://api.github.com/repos/papayalabs/consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/papayalabs/consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/papayalabs/consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/papayalabs/consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/papayalabs/consul/contents/{+path}","compare_url":"https://api.github.com/repos/papayalabs/consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/papayalabs/consul/merges","archive_url":"https://api.github.com/repos/papayalabs/consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/papayalabs/consul/downloads","issues_url":"https://api.github.com/repos/papayalabs/consul/issues{/number}","pulls_url":"https://api.github.com/repos/papayalabs/consul/pulls{/number}","milestones_url":"https://api.github.com/repos/papayalabs/consul/milestones{/number}","notifications_url":"https://api.github.com/repos/papayalabs/consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/papayalabs/consul/labels{/name}","releases_url":"https://api.github.com/repos/papayalabs/consul/releases{/id}","deployments_url":"https://api.github.com/repos/papayalabs/consul/deployments","created_at":"2018-08-05T00:37:42Z","updated_at":"2018-09-19T14:38:34Z","pushed_at":"2018-09-24T18:38:49Z","git_url":"git://github.com/papayalabs/consul.git","ssh_url":"git@github.com:papayalabs/consul.git","clone_url":"https://github.com/papayalabs/consul.git","svn_url":"https://github.com/papayalabs/consul","homepage":"","size":36215,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"consul:master","ref":"master","sha":"e0d08a32ddd282ce53ebcc598d70e7399c906b59","user":{"login":"consul","id":14167322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY3MzIy","avatar_url":"https://avatars2.githubusercontent.com/u/14167322?v=4","gravatar_id":"","url":"https://api.github.com/users/consul","html_url":"https://github.com/consul","followers_url":"https://api.github.com/users/consul/followers","following_url":"https://api.github.com/users/consul/following{/other_user}","gists_url":"https://api.github.com/users/consul/gists{/gist_id}","starred_url":"https://api.github.com/users/consul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/consul/subscriptions","organizations_url":"https://api.github.com/users/consul/orgs","repos_url":"https://api.github.com/users/consul/repos","events_url":"https://api.github.com/users/consul/events{/privacy}","received_events_url":"https://api.github.com/users/consul/received_events","type":"Organization","site_admin":false},"repo":{"id":39152554,"node_id":"MDEwOlJlcG9zaXRvcnkzOTE1MjU1NA==","name":"consul","full_name":"consul/consul","private":false,"owner":{"login":"consul","id":14167322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY3MzIy","avatar_url":"https://avatars2.githubusercontent.com/u/14167322?v=4","gravatar_id":"","url":"https://api.github.com/users/consul","html_url":"https://github.com/consul","followers_url":"https://api.github.com/users/consul/followers","following_url":"https://api.github.com/users/consul/following{/other_user}","gists_url":"https://api.github.com/users/consul/gists{/gist_id}","starred_url":"https://api.github.com/users/consul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/consul/subscriptions","organizations_url":"https://api.github.com/users/consul/orgs","repos_url":"https://api.github.com/users/consul/repos","events_url":"https://api.github.com/users/consul/events{/privacy}","received_events_url":"https://api.github.com/users/consul/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/consul/consul","description":"Consul - Open Government and E-Participation Web Software","fork":false,"url":"https://api.github.com/repos/consul/consul","forks_url":"https://api.github.com/repos/consul/consul/forks","keys_url":"https://api.github.com/repos/consul/consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/consul/consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/consul/consul/teams","hooks_url":"https://api.github.com/repos/consul/consul/hooks","issue_events_url":"https://api.github.com/repos/consul/consul/issues/events{/number}","events_url":"https://api.github.com/repos/consul/consul/events","assignees_url":"https://api.github.com/repos/consul/consul/assignees{/user}","branches_url":"https://api.github.com/repos/consul/consul/branches{/branch}","tags_url":"https://api.github.com/repos/consul/consul/tags","blobs_url":"https://api.github.com/repos/consul/consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/consul/consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/consul/consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/consul/consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/consul/consul/statuses/{sha}","languages_url":"https://api.github.com/repos/consul/consul/languages","stargazers_url":"https://api.github.com/repos/consul/consul/stargazers","contributors_url":"https://api.github.com/repos/consul/consul/contributors","subscribers_url":"https://api.github.com/repos/consul/consul/subscribers","subscription_url":"https://api.github.com/repos/consul/consul/subscription","commits_url":"https://api.github.com/repos/consul/consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/consul/consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/consul/consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/consul/consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/consul/consul/contents/{+path}","compare_url":"https://api.github.com/repos/consul/consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/consul/consul/merges","archive_url":"https://api.github.com/repos/consul/consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/consul/consul/downloads","issues_url":"https://api.github.com/repos/consul/consul/issues{/number}","pulls_url":"https://api.github.com/repos/consul/consul/pulls{/number}","milestones_url":"https://api.github.com/repos/consul/consul/milestones{/number}","notifications_url":"https://api.github.com/repos/consul/consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/consul/consul/labels{/name}","releases_url":"https://api.github.com/repos/consul/consul/releases{/id}","deployments_url":"https://api.github.com/repos/consul/consul/deployments","created_at":"2015-07-15T18:04:16Z","updated_at":"2018-09-24T19:11:38Z","pushed_at":"2018-09-25T03:44:10Z","git_url":"git://github.com/consul/consul.git","ssh_url":"git@github.com:consul/consul.git","clone_url":"https://github.com/consul/consul.git","svn_url":"https://github.com/consul/consul","homepage":"","size":37560,"stargazers_count":661,"watchers_count":661,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":423,"mirror_url":null,"archived":false,"open_issues_count":298,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":423,"open_issues":298,"watchers":661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/consul/consul/pulls/2913"},"html":{"href":"https://github.com/consul/consul/pull/2913"},"issue":{"href":"https://api.github.com/repos/consul/consul/issues/2913"},"comments":{"href":"https://api.github.com/repos/consul/consul/issues/2913/comments"},"review_comments":{"href":"https://api.github.com/repos/consul/consul/pulls/2913/comments"},"review_comment":{"href":"https://api.github.com/repos/consul/consul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/consul/consul/pulls/2913/commits"},"statuses":{"href":"https://api.github.com/repos/consul/consul/statuses/786a9f24baa25321d847942634062085534da558"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"papayalabs"}}