{"action":"created","issue":{"url":"https://api.github.com/repos/JetBrains/intellij-community/issues/898","repository_url":"https://api.github.com/repos/JetBrains/intellij-community","labels_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/898/labels{/name}","comments_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/898/comments","events_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/898/events","html_url":"https://github.com/JetBrains/intellij-community/pull/898","id":373801108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjQ0NTEz","number":898,"title":"Fixed an issue related to accessibility of changes tree","user":{"login":"molaachir","id":5676957,"node_id":"MDQ6VXNlcjU2NzY5NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/5676957?v=4","gravatar_id":"","url":"https://api.github.com/users/molaachir","html_url":"https://github.com/molaachir","followers_url":"https://api.github.com/users/molaachir/followers","following_url":"https://api.github.com/users/molaachir/following{/other_user}","gists_url":"https://api.github.com/users/molaachir/gists{/gist_id}","starred_url":"https://api.github.com/users/molaachir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molaachir/subscriptions","organizations_url":"https://api.github.com/users/molaachir/orgs","repos_url":"https://api.github.com/users/molaachir/repos","events_url":"https://api.github.com/users/molaachir/events{/privacy}","received_events_url":"https://api.github.com/users/molaachir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"forantar","id":17044068,"node_id":"MDQ6VXNlcjE3MDQ0MDY4","avatar_url":"https://avatars2.githubusercontent.com/u/17044068?v=4","gravatar_id":"","url":"https://api.github.com/users/forantar","html_url":"https://github.com/forantar","followers_url":"https://api.github.com/users/forantar/followers","following_url":"https://api.github.com/users/forantar/following{/other_user}","gists_url":"https://api.github.com/users/forantar/gists{/gist_id}","starred_url":"https://api.github.com/users/forantar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forantar/subscriptions","organizations_url":"https://api.github.com/users/forantar/orgs","repos_url":"https://api.github.com/users/forantar/repos","events_url":"https://api.github.com/users/forantar/events{/privacy}","received_events_url":"https://api.github.com/users/forantar/received_events","type":"User","site_admin":false},"assignees":[{"login":"forantar","id":17044068,"node_id":"MDQ6VXNlcjE3MDQ0MDY4","avatar_url":"https://avatars2.githubusercontent.com/u/17044068?v=4","gravatar_id":"","url":"https://api.github.com/users/forantar","html_url":"https://github.com/forantar","followers_url":"https://api.github.com/users/forantar/followers","following_url":"https://api.github.com/users/forantar/following{/other_user}","gists_url":"https://api.github.com/users/forantar/gists{/gist_id}","starred_url":"https://api.github.com/users/forantar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forantar/subscriptions","organizations_url":"https://api.github.com/users/forantar/orgs","repos_url":"https://api.github.com/users/forantar/repos","events_url":"https://api.github.com/users/forantar/events{/privacy}","received_events_url":"https://api.github.com/users/forantar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-10-25T07:02:30Z","updated_at":"2018-10-29T16:40:07Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/JetBrains/intellij-community/pulls/898","html_url":"https://github.com/JetBrains/intellij-community/pull/898","diff_url":"https://github.com/JetBrains/intellij-community/pull/898.diff","patch_url":"https://github.com/JetBrains/intellij-community/pull/898.patch"},"body":"Changes tree that shows up when reverting issues and commiting was not accessible to screen readers. File names where not read out, and checked/unchecked states of the files (signaling inclusion of files) where not announced. Fix tested with NVDA and Jaws. NVDA announces a bit too much information for my taste, but that is probably due to settings. Related YouTrack issue: https://youtrack.jetbrains.com/issue/IDEA-201167*"},"comment":{"url":"https://api.github.com/repos/JetBrains/intellij-community/issues/comments/433983587","html_url":"https://github.com/JetBrains/intellij-community/pull/898#issuecomment-433983587","issue_url":"https://api.github.com/repos/JetBrains/intellij-community/issues/898","id":433983587,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzk4MzU4Nw==","user":{"login":"forantar","id":17044068,"node_id":"MDQ6VXNlcjE3MDQ0MDY4","avatar_url":"https://avatars2.githubusercontent.com/u/17044068?v=4","gravatar_id":"","url":"https://api.github.com/users/forantar","html_url":"https://github.com/forantar","followers_url":"https://api.github.com/users/forantar/followers","following_url":"https://api.github.com/users/forantar/following{/other_user}","gists_url":"https://api.github.com/users/forantar/gists{/gist_id}","starred_url":"https://api.github.com/users/forantar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forantar/subscriptions","organizations_url":"https://api.github.com/users/forantar/orgs","repos_url":"https://api.github.com/users/forantar/repos","events_url":"https://api.github.com/users/forantar/events{/privacy}","received_events_url":"https://api.github.com/users/forantar/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T16:40:07Z","updated_at":"2018-10-29T16:40:07Z","author_association":"CONTRIBUTOR","body":"@molaachir I've got your point. Yes, you're right the checkbox state should be included. However, with NVDA I observe some odd behavior. When I select an item in the tree NVDA reads all the path of the item starting from the root. Jaws doesn't do that. As I could quickly identify, this is specific to AccessibleRole.TOGGLE_BUTTON role the ThreeStateCheckBox reports. Same is for AccessibleRole.CHECK_BOX, but when I for experiment change it to, say, AccessibleRole.LABEL then NVDA reads only the selected item. So, my question: is the default NVDA behavior ok from your point of view? If not, should we wrap AccessibleContext here with something more reasonable?"}}
{"actor":{"display_login":"forantar"}}