{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/242858350","pull_request_review_id":186470461,"id":242858350,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjg1ODM1MA==","diff_hunk":"@@ -34,3 +46,74 @@ def commit_user_and_role(user):\n       # if no user in cache, then it was created before but has no role.\n       log_event(db.session, db_role, user.id, flush=False)\n     db.session.commit()\n+\n+\n+def check_appengine_appid(request):","path":"src/ggrc/login/common.py","position":30,"original_position":30,"commit_id":"32ee45840d4b22b6533243591ebd63da21571296","original_commit_id":"32ee45840d4b22b6533243591ebd63da21571296","user":{"login":"olegnatsevsky","id":3587775,"node_id":"MDQ6VXNlcjM1ODc3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3587775?v=4","gravatar_id":"","url":"https://api.github.com/users/olegnatsevsky","html_url":"https://github.com/olegnatsevsky","followers_url":"https://api.github.com/users/olegnatsevsky/followers","following_url":"https://api.github.com/users/olegnatsevsky/following{/other_user}","gists_url":"https://api.github.com/users/olegnatsevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/olegnatsevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegnatsevsky/subscriptions","organizations_url":"https://api.github.com/users/olegnatsevsky/orgs","repos_url":"https://api.github.com/users/olegnatsevsky/repos","events_url":"https://api.github.com/users/olegnatsevsky/events{/privacy}","received_events_url":"https://api.github.com/users/olegnatsevsky/received_events","type":"User","site_admin":false},"body":"We need to add test for this functionality.","created_at":"2018-12-19T10:10:40Z","updated_at":"2018-12-19T10:10:40Z","html_url":"https://github.com/google/ggrc-core/pull/8850#discussion_r242858350","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/8850","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/242858350"},"html":{"href":"https://github.com/google/ggrc-core/pull/8850#discussion_r242858350"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/8850"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/8850","id":239760009,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NzYwMDA5","html_url":"https://github.com/google/ggrc-core/pull/8850","diff_url":"https://github.com/google/ggrc-core/pull/8850.diff","patch_url":"https://github.com/google/ggrc-core/pull/8850.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/8850","number":8850,"state":"open","locked":false,"title":"Feature/ggrc 6444 disable attr generation sync service integration","user":{"login":"Abildin","id":6023919,"node_id":"MDQ6VXNlcjYwMjM5MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6023919?v=4","gravatar_id":"","url":"https://api.github.com/users/Abildin","html_url":"https://github.com/Abildin","followers_url":"https://api.github.com/users/Abildin/followers","following_url":"https://api.github.com/users/Abildin/following{/other_user}","gists_url":"https://api.github.com/users/Abildin/gists{/gist_id}","starred_url":"https://api.github.com/users/Abildin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abildin/subscriptions","organizations_url":"https://api.github.com/users/Abildin/orgs","repos_url":"https://api.github.com/users/Abildin/repos","events_url":"https://api.github.com/users/Abildin/events{/privacy}","received_events_url":"https://api.github.com/users/Abildin/received_events","type":"User","site_admin":false},"body":"<!-- If your PR depends on other tickets or PRs, you can list them here\r\n# Dependencies\r\n\r\nThis PR is `on hold` until the dependencies are merged:\r\n\r\n- [ ] GGRC-1234\r\n- [ ] #1234\r\n-->\r\n\r\n# Issue description\r\n\r\nPrevent generation of attributes (`id`, `created_at`, `updated_at`, `modified_by`) for Control.\r\n\r\n# Steps to test the changes\r\nMake POST request to `/api/controls` with custom attributes (`id`, `created_at`, `updated_at`, `modified_by`).\r\n\r\n# Solution description\r\nCreated Synchronizable mixin that extends `_api_attrs` field.\r\n\r\n# Sanity checklist\r\n\r\n- [x] I have clicked through the app to make sure my changes work and not break the app.\r\n- [x] I have applied the correct milestone and labels.\r\n- [x] My changes fix the issue described in the description (and do nothing else). 🤞\r\n- [x] My changes are covered by tests.\r\n- [x] My changes follow our [performance guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/performance.rst).\r\n- [x] My changes follow our [js](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/javascript.rst) and/or [python](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/python.rst) guidelines.\r\n- [x] My commits follow our [commit guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/how_to_write_a_commit_message.rst).\r\n\r\n<!-- If your PR includes a migration include the additional checklist items\r\n# Migration checklist\r\n- [ ] Migration passes all checks from our [PR review guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/reviewing_pull_requests.rst#reviewing-a-pr-containing-database-migration-scripts)\r\n- [ ] Upon merging, add 'check migration chain' and 'kokoro:run' labels to all open PRs with a label 'migration'\r\n-->\r\n\r\n# PR Review checklist\r\n\r\n- [ ] The changes fix the issue and don't cause any apparent regressions.\r\n- [ ] Labels and milestone are correctly set.\r\n- [ ] The solution description matches the changes in the code.\r\n- [ ] There is no apparent way to improve the performance & design of the new code.\r\n- [ ] The pull request is opened against the correct base branch.\r\n- [ ] Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to \"QA - In Progress\".\r\n\r\n<!-- If your code is not finished yet can include a TODO check list\r\n# TODO\r\n\r\n- [ ] First item on the TODO\r\n-->\r\n","created_at":"2018-12-19T09:09:51Z","updated_at":"2018-12-19T10:10:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6823ea39565dabd9561186c33c6a3d71cd8153f5","assignee":{"login":"olegnatsevsky","id":3587775,"node_id":"MDQ6VXNlcjM1ODc3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3587775?v=4","gravatar_id":"","url":"https://api.github.com/users/olegnatsevsky","html_url":"https://github.com/olegnatsevsky","followers_url":"https://api.github.com/users/olegnatsevsky/followers","following_url":"https://api.github.com/users/olegnatsevsky/following{/other_user}","gists_url":"https://api.github.com/users/olegnatsevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/olegnatsevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegnatsevsky/subscriptions","organizations_url":"https://api.github.com/users/olegnatsevsky/orgs","repos_url":"https://api.github.com/users/olegnatsevsky/repos","events_url":"https://api.github.com/users/olegnatsevsky/events{/privacy}","received_events_url":"https://api.github.com/users/olegnatsevsky/received_events","type":"User","site_admin":false},"assignees":[{"login":"olegnatsevsky","id":3587775,"node_id":"MDQ6VXNlcjM1ODc3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3587775?v=4","gravatar_id":"","url":"https://api.github.com/users/olegnatsevsky","html_url":"https://github.com/olegnatsevsky","followers_url":"https://api.github.com/users/olegnatsevsky/followers","following_url":"https://api.github.com/users/olegnatsevsky/following{/other_user}","gists_url":"https://api.github.com/users/olegnatsevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/olegnatsevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegnatsevsky/subscriptions","organizations_url":"https://api.github.com/users/olegnatsevsky/orgs","repos_url":"https://api.github.com/users/olegnatsevsky/repos","events_url":"https://api.github.com/users/olegnatsevsky/events{/privacy}","received_events_url":"https://api.github.com/users/olegnatsevsky/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":653911749,"node_id":"MDU6TGFiZWw2NTM5MTE3NDk=","url":"https://api.github.com/repos/google/ggrc-core/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/8850/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/8850/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/8850/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/32ee45840d4b22b6533243591ebd63da21571296","head":{"label":"Abildin:feature/GGRC-6444_disable_attr_generation_sync_service_integration","ref":"feature/GGRC-6444_disable_attr_generation_sync_service_integration","sha":"32ee45840d4b22b6533243591ebd63da21571296","user":{"login":"Abildin","id":6023919,"node_id":"MDQ6VXNlcjYwMjM5MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6023919?v=4","gravatar_id":"","url":"https://api.github.com/users/Abildin","html_url":"https://github.com/Abildin","followers_url":"https://api.github.com/users/Abildin/followers","following_url":"https://api.github.com/users/Abildin/following{/other_user}","gists_url":"https://api.github.com/users/Abildin/gists{/gist_id}","starred_url":"https://api.github.com/users/Abildin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abildin/subscriptions","organizations_url":"https://api.github.com/users/Abildin/orgs","repos_url":"https://api.github.com/users/Abildin/repos","events_url":"https://api.github.com/users/Abildin/events{/privacy}","received_events_url":"https://api.github.com/users/Abildin/received_events","type":"User","site_admin":false},"repo":{"id":154136833,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQxMzY4MzM=","name":"ggrc-core","full_name":"Abildin/ggrc-core","private":false,"owner":{"login":"Abildin","id":6023919,"node_id":"MDQ6VXNlcjYwMjM5MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6023919?v=4","gravatar_id":"","url":"https://api.github.com/users/Abildin","html_url":"https://github.com/Abildin","followers_url":"https://api.github.com/users/Abildin/followers","following_url":"https://api.github.com/users/Abildin/following{/other_user}","gists_url":"https://api.github.com/users/Abildin/gists{/gist_id}","starred_url":"https://api.github.com/users/Abildin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abildin/subscriptions","organizations_url":"https://api.github.com/users/Abildin/orgs","repos_url":"https://api.github.com/users/Abildin/repos","events_url":"https://api.github.com/users/Abildin/events{/privacy}","received_events_url":"https://api.github.com/users/Abildin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Abildin/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/Abildin/ggrc-core","forks_url":"https://api.github.com/repos/Abildin/ggrc-core/forks","keys_url":"https://api.github.com/repos/Abildin/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Abildin/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Abildin/ggrc-core/teams","hooks_url":"https://api.github.com/repos/Abildin/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/Abildin/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/Abildin/ggrc-core/events","assignees_url":"https://api.github.com/repos/Abildin/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/Abildin/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/Abildin/ggrc-core/tags","blobs_url":"https://api.github.com/repos/Abildin/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Abildin/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Abildin/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Abildin/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Abildin/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Abildin/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/Abildin/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/Abildin/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/Abildin/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/Abildin/ggrc-core/subscription","commits_url":"https://api.github.com/repos/Abildin/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Abildin/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Abildin/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Abildin/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Abildin/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/Abildin/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Abildin/ggrc-core/merges","archive_url":"https://api.github.com/repos/Abildin/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Abildin/ggrc-core/downloads","issues_url":"https://api.github.com/repos/Abildin/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/Abildin/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Abildin/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Abildin/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Abildin/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/Abildin/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/Abildin/ggrc-core/deployments","created_at":"2018-10-22T12:07:13Z","updated_at":"2018-12-10T09:47:12Z","pushed_at":"2018-12-19T09:09:37Z","git_url":"git://github.com/Abildin/ggrc-core.git","ssh_url":"git@github.com:Abildin/ggrc-core.git","clone_url":"https://github.com/Abildin/ggrc-core.git","svn_url":"https://github.com/Abildin/ggrc-core","homepage":null,"size":81273,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"google:GGRC-6187/ggrc_ggrcq_integration","ref":"GGRC-6187/ggrc_ggrcq_integration","sha":"36a4310384e59aaf3e58716b39cfac31a6336907","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA0NjM3","name":"ggrc-core","full_name":"google/ggrc-core","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2018-12-19T09:46:09Z","pushed_at":"2018-12-19T09:50:42Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":84147,"stargazers_count":396,"watchers_count":396,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":255,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":255,"open_issues":47,"watchers":396,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/8850"},"html":{"href":"https://github.com/google/ggrc-core/pull/8850"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/8850"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/8850/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/8850/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/8850/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/32ee45840d4b22b6533243591ebd63da21571296"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"olegnatsevsky"}}