{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/CGNS/CGNS/pulls/49","id":160185251,"html_url":"https://github.com/CGNS/CGNS/pull/49","diff_url":"https://github.com/CGNS/CGNS/pull/49.diff","patch_url":"https://github.com/CGNS/CGNS/pull/49.patch","issue_url":"https://api.github.com/repos/CGNS/CGNS/issues/49","number":49,"state":"closed","locked":false,"title":"Shared lib (dll) can be built on windows. Fixes CGNS-129.","user":{"login":"matmel","id":6333189,"avatar_url":"https://avatars1.githubusercontent.com/u/6333189?v=4","gravatar_id":"","url":"https://api.github.com/users/matmel","html_url":"https://github.com/matmel","followers_url":"https://api.github.com/users/matmel/followers","following_url":"https://api.github.com/users/matmel/following{/other_user}","gists_url":"https://api.github.com/users/matmel/gists{/gist_id}","starred_url":"https://api.github.com/users/matmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matmel/subscriptions","organizations_url":"https://api.github.com/users/matmel/orgs","repos_url":"https://api.github.com/users/matmel/repos","events_url":"https://api.github.com/users/matmel/events{/privacy}","received_events_url":"https://api.github.com/users/matmel/received_events","type":"User","site_admin":false},"body":"The main change is in root CMakeList.txt. I had to change a the location of the if block that adds the HDF5 definitions `-DH5_BUILT_AS_DYNAMIC_LIB` and `-DH5_BUILT_AS_STATIC_LIB`. They are required to properly define HDF5 headers on windows, especially to export/import symbols correctly.\r\n\r\nI found this [blog post](http://blog.omega-prime.co.uk/2011/07/04/everything-you-never-wanted-to-know-about-dlls/) useful to understand correctly the dll symbol export mechanism.\r\n\r\nAlso, I changed the appveyor script to build the shared version of CGNSlib.\r\n\r\n## A couple of question\r\n\r\n### Question 1\r\nIn ADFH.h the line \r\n```\r\n#if defined(WIN32)\r\n```\r\nShould probably be replaced with \r\n```\r\n#if defined(_MSC_VER)\r\n```\r\nas it is done in HDF5 library (see `H5api_adpt.h` for instance) because the `__declspec(dllexport)` decorator thing is only relevant for MSVC as far as I know. `gcc` on windows does not have this requirement.\r\n\r\n### Question 2\r\n\r\nShould we update the version of HDF5 (1.10.*) and AppVeyor image to use the latest visual studio?","created_at":"2017-12-27T02:31:26Z","updated_at":"2018-02-09T19:16:30Z","closed_at":"2018-02-09T19:16:30Z","merged_at":"2018-02-09T19:16:30Z","merge_commit_sha":"5505511e3c2feeff4e0d263a6f613b897c932325","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CGNS/CGNS/pulls/49/commits","review_comments_url":"https://api.github.com/repos/CGNS/CGNS/pulls/49/comments","review_comment_url":"https://api.github.com/repos/CGNS/CGNS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CGNS/CGNS/issues/49/comments","statuses_url":"https://api.github.com/repos/CGNS/CGNS/statuses/e94f183ff9ae204cf2a23a1e95d331489e58aaa6","head":{"label":"matmel:develop","ref":"develop","sha":"e94f183ff9ae204cf2a23a1e95d331489e58aaa6","user":{"login":"matmel","id":6333189,"avatar_url":"https://avatars1.githubusercontent.com/u/6333189?v=4","gravatar_id":"","url":"https://api.github.com/users/matmel","html_url":"https://github.com/matmel","followers_url":"https://api.github.com/users/matmel/followers","following_url":"https://api.github.com/users/matmel/following{/other_user}","gists_url":"https://api.github.com/users/matmel/gists{/gist_id}","starred_url":"https://api.github.com/users/matmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matmel/subscriptions","organizations_url":"https://api.github.com/users/matmel/orgs","repos_url":"https://api.github.com/users/matmel/repos","events_url":"https://api.github.com/users/matmel/events{/privacy}","received_events_url":"https://api.github.com/users/matmel/received_events","type":"User","site_admin":false},"repo":{"id":115071336,"name":"CGNS","full_name":"matmel/CGNS","owner":{"login":"matmel","id":6333189,"avatar_url":"https://avatars1.githubusercontent.com/u/6333189?v=4","gravatar_id":"","url":"https://api.github.com/users/matmel","html_url":"https://github.com/matmel","followers_url":"https://api.github.com/users/matmel/followers","following_url":"https://api.github.com/users/matmel/following{/other_user}","gists_url":"https://api.github.com/users/matmel/gists{/gist_id}","starred_url":"https://api.github.com/users/matmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matmel/subscriptions","organizations_url":"https://api.github.com/users/matmel/orgs","repos_url":"https://api.github.com/users/matmel/repos","events_url":"https://api.github.com/users/matmel/events{/privacy}","received_events_url":"https://api.github.com/users/matmel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matmel/CGNS","description":"The CFD General Notation System (CGNS) provides a standard for recording and recovering computer data associated with the numerical solution of fluid dynamics equations. All developement work and bug fixes should be based off the 'develop' branch, CGNS uses the branching model Gitflow. Issue Tracking is at: https://cgnsorg.atlassian.net","fork":true,"url":"https://api.github.com/repos/matmel/CGNS","forks_url":"https://api.github.com/repos/matmel/CGNS/forks","keys_url":"https://api.github.com/repos/matmel/CGNS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matmel/CGNS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matmel/CGNS/teams","hooks_url":"https://api.github.com/repos/matmel/CGNS/hooks","issue_events_url":"https://api.github.com/repos/matmel/CGNS/issues/events{/number}","events_url":"https://api.github.com/repos/matmel/CGNS/events","assignees_url":"https://api.github.com/repos/matmel/CGNS/assignees{/user}","branches_url":"https://api.github.com/repos/matmel/CGNS/branches{/branch}","tags_url":"https://api.github.com/repos/matmel/CGNS/tags","blobs_url":"https://api.github.com/repos/matmel/CGNS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matmel/CGNS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matmel/CGNS/git/refs{/sha}","trees_url":"https://api.github.com/repos/matmel/CGNS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matmel/CGNS/statuses/{sha}","languages_url":"https://api.github.com/repos/matmel/CGNS/languages","stargazers_url":"https://api.github.com/repos/matmel/CGNS/stargazers","contributors_url":"https://api.github.com/repos/matmel/CGNS/contributors","subscribers_url":"https://api.github.com/repos/matmel/CGNS/subscribers","subscription_url":"https://api.github.com/repos/matmel/CGNS/subscription","commits_url":"https://api.github.com/repos/matmel/CGNS/commits{/sha}","git_commits_url":"https://api.github.com/repos/matmel/CGNS/git/commits{/sha}","comments_url":"https://api.github.com/repos/matmel/CGNS/comments{/number}","issue_comment_url":"https://api.github.com/repos/matmel/CGNS/issues/comments{/number}","contents_url":"https://api.github.com/repos/matmel/CGNS/contents/{+path}","compare_url":"https://api.github.com/repos/matmel/CGNS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matmel/CGNS/merges","archive_url":"https://api.github.com/repos/matmel/CGNS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matmel/CGNS/downloads","issues_url":"https://api.github.com/repos/matmel/CGNS/issues{/number}","pulls_url":"https://api.github.com/repos/matmel/CGNS/pulls{/number}","milestones_url":"https://api.github.com/repos/matmel/CGNS/milestones{/number}","notifications_url":"https://api.github.com/repos/matmel/CGNS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matmel/CGNS/labels{/name}","releases_url":"https://api.github.com/repos/matmel/CGNS/releases{/id}","deployments_url":"https://api.github.com/repos/matmel/CGNS/deployments","created_at":"2017-12-22T03:13:55Z","updated_at":"2017-12-22T03:13:58Z","pushed_at":"2017-12-27T13:33:26Z","git_url":"git://github.com/matmel/CGNS.git","ssh_url":"git@github.com:matmel/CGNS.git","clone_url":"https://github.com/matmel/CGNS.git","svn_url":"https://github.com/matmel/CGNS","homepage":"","size":17269,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CGNS:develop","ref":"develop","sha":"0419cb99aeb0ac57b25a644cf2eaa9518e8fd44e","user":{"login":"CGNS","id":10050606,"avatar_url":"https://avatars2.githubusercontent.com/u/10050606?v=4","gravatar_id":"","url":"https://api.github.com/users/CGNS","html_url":"https://github.com/CGNS","followers_url":"https://api.github.com/users/CGNS/followers","following_url":"https://api.github.com/users/CGNS/following{/other_user}","gists_url":"https://api.github.com/users/CGNS/gists{/gist_id}","starred_url":"https://api.github.com/users/CGNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGNS/subscriptions","organizations_url":"https://api.github.com/users/CGNS/orgs","repos_url":"https://api.github.com/users/CGNS/repos","events_url":"https://api.github.com/users/CGNS/events{/privacy}","received_events_url":"https://api.github.com/users/CGNS/received_events","type":"Organization","site_admin":false},"repo":{"id":31683211,"name":"CGNS","full_name":"CGNS/CGNS","owner":{"login":"CGNS","id":10050606,"avatar_url":"https://avatars2.githubusercontent.com/u/10050606?v=4","gravatar_id":"","url":"https://api.github.com/users/CGNS","html_url":"https://github.com/CGNS","followers_url":"https://api.github.com/users/CGNS/followers","following_url":"https://api.github.com/users/CGNS/following{/other_user}","gists_url":"https://api.github.com/users/CGNS/gists{/gist_id}","starred_url":"https://api.github.com/users/CGNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGNS/subscriptions","organizations_url":"https://api.github.com/users/CGNS/orgs","repos_url":"https://api.github.com/users/CGNS/repos","events_url":"https://api.github.com/users/CGNS/events{/privacy}","received_events_url":"https://api.github.com/users/CGNS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CGNS/CGNS","description":"The CFD General Notation System (CGNS) provides a standard for recording and recovering computer data associated with the numerical solution of fluid dynamics equations. All developement work and bug fixes should be based off the 'develop' branch, CGNS uses the branching model Gitflow. Issue Tracking is at: https://cgnsorg.atlassian.net","fork":false,"url":"https://api.github.com/repos/CGNS/CGNS","forks_url":"https://api.github.com/repos/CGNS/CGNS/forks","keys_url":"https://api.github.com/repos/CGNS/CGNS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CGNS/CGNS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CGNS/CGNS/teams","hooks_url":"https://api.github.com/repos/CGNS/CGNS/hooks","issue_events_url":"https://api.github.com/repos/CGNS/CGNS/issues/events{/number}","events_url":"https://api.github.com/repos/CGNS/CGNS/events","assignees_url":"https://api.github.com/repos/CGNS/CGNS/assignees{/user}","branches_url":"https://api.github.com/repos/CGNS/CGNS/branches{/branch}","tags_url":"https://api.github.com/repos/CGNS/CGNS/tags","blobs_url":"https://api.github.com/repos/CGNS/CGNS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CGNS/CGNS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CGNS/CGNS/git/refs{/sha}","trees_url":"https://api.github.com/repos/CGNS/CGNS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CGNS/CGNS/statuses/{sha}","languages_url":"https://api.github.com/repos/CGNS/CGNS/languages","stargazers_url":"https://api.github.com/repos/CGNS/CGNS/stargazers","contributors_url":"https://api.github.com/repos/CGNS/CGNS/contributors","subscribers_url":"https://api.github.com/repos/CGNS/CGNS/subscribers","subscription_url":"https://api.github.com/repos/CGNS/CGNS/subscription","commits_url":"https://api.github.com/repos/CGNS/CGNS/commits{/sha}","git_commits_url":"https://api.github.com/repos/CGNS/CGNS/git/commits{/sha}","comments_url":"https://api.github.com/repos/CGNS/CGNS/comments{/number}","issue_comment_url":"https://api.github.com/repos/CGNS/CGNS/issues/comments{/number}","contents_url":"https://api.github.com/repos/CGNS/CGNS/contents/{+path}","compare_url":"https://api.github.com/repos/CGNS/CGNS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CGNS/CGNS/merges","archive_url":"https://api.github.com/repos/CGNS/CGNS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CGNS/CGNS/downloads","issues_url":"https://api.github.com/repos/CGNS/CGNS/issues{/number}","pulls_url":"https://api.github.com/repos/CGNS/CGNS/pulls{/number}","milestones_url":"https://api.github.com/repos/CGNS/CGNS/milestones{/number}","notifications_url":"https://api.github.com/repos/CGNS/CGNS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CGNS/CGNS/labels{/name}","releases_url":"https://api.github.com/repos/CGNS/CGNS/releases{/id}","deployments_url":"https://api.github.com/repos/CGNS/CGNS/deployments","created_at":"2015-03-04T22:25:08Z","updated_at":"2018-02-09T11:50:46Z","pushed_at":"2018-02-09T19:16:30Z","git_url":"git://github.com/CGNS/CGNS.git","ssh_url":"git@github.com:CGNS/CGNS.git","clone_url":"https://github.com/CGNS/CGNS.git","svn_url":"https://github.com/CGNS/CGNS","homepage":"","size":17236,"stargazers_count":56,"watchers_count":56,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":29,"open_issues":10,"watchers":56,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CGNS/CGNS/pulls/49"},"html":{"href":"https://github.com/CGNS/CGNS/pull/49"},"issue":{"href":"https://api.github.com/repos/CGNS/CGNS/issues/49"},"comments":{"href":"https://api.github.com/repos/CGNS/CGNS/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/CGNS/CGNS/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/CGNS/CGNS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CGNS/CGNS/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/CGNS/CGNS/statuses/e94f183ff9ae204cf2a23a1e95d331489e58aaa6"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"brtnfld","id":8631687,"avatar_url":"https://avatars1.githubusercontent.com/u/8631687?v=4","gravatar_id":"","url":"https://api.github.com/users/brtnfld","html_url":"https://github.com/brtnfld","followers_url":"https://api.github.com/users/brtnfld/followers","following_url":"https://api.github.com/users/brtnfld/following{/other_user}","gists_url":"https://api.github.com/users/brtnfld/gists{/gist_id}","starred_url":"https://api.github.com/users/brtnfld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brtnfld/subscriptions","organizations_url":"https://api.github.com/users/brtnfld/orgs","repos_url":"https://api.github.com/users/brtnfld/repos","events_url":"https://api.github.com/users/brtnfld/events{/privacy}","received_events_url":"https://api.github.com/users/brtnfld/received_events","type":"User","site_admin":false},"comments":7,"review_comments":3,"maintainer_can_modify":false,"commits":3,"additions":29,"deletions":23,"changed_files":4}}
{"actor":{"display_login":"brtnfld"}}