{"push_id":2322830135,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"2ad995068aa4473e6a870a53bfbeb33e19e5ca80","before":"cc0ab3fcf3c94169afdb905f02597cd9dead30ff","commits":[{"sha":"2ad995068aa4473e6a870a53bfbeb33e19e5ca80","author":{"name":"Kuba Mracek","email":"e664d100b6e9c3eee05e6e2c2ffbf6f0e82a65ab@apple.com"},"message":"[compiler-rt] Replace forkpty with posix_spawn\n\nOn Darwin, we currently use forkpty to communicate with the \"atos\" symbolizer. There are several problems that fork or forkpty has, e.g. that after fork, interceptors are still active and this sometimes causes crashes or hangs. This is especially problematic for TSan, which uses interceptors for OS-provided locks and mutexes, and even Libc functions use those.\n\nThis patch replaces forkpty with posix_spawn. Since posix_spawn doesn't fork (at least on Darwin), the interceptors are not a problem. Additionally, this also fixes a latent threading problem with ptsname (it's unsafe to use this function in multithreaded programs). Yet another benefit is that we'll handle post-fork failures (e.g. sandbox disallows \"exec\") gracefully now.\n\nDifferential Revision: https://reviews.llvm.org/D40032\n\n\n\ngit-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@324846 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":true,"url":"https://api.github.com/repos/llvm-project/compiler-rt/commits/2ad995068aa4473e6a870a53bfbeb33e19e5ca80"}]}
{"actor":{"display_login":"chapuni"}}