{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2343","repository_url":"https://api.github.com/repos/kubernetes/ingress-nginx","labels_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2343/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2343/comments","events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2343/events","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2343","id":314120339,"number":2343,"title":"Add annotations for proxy_pass customization","user":{"login":"Capitrium","id":5111534,"avatar_url":"https://avatars3.githubusercontent.com/u/5111534?v=4","gravatar_id":"","url":"https://api.github.com/users/Capitrium","html_url":"https://github.com/Capitrium","followers_url":"https://api.github.com/users/Capitrium/followers","following_url":"https://api.github.com/users/Capitrium/following{/other_user}","gists_url":"https://api.github.com/users/Capitrium/gists{/gist_id}","starred_url":"https://api.github.com/users/Capitrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Capitrium/subscriptions","organizations_url":"https://api.github.com/users/Capitrium/orgs","repos_url":"https://api.github.com/users/Capitrium/repos","events_url":"https://api.github.com/users/Capitrium/events{/privacy}","received_events_url":"https://api.github.com/users/Capitrium/received_events","type":"User","site_admin":false},"labels":[{"id":486873161,"url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676097629,"url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"aledbf","id":161571,"avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"assignees":[{"login":"aledbf","id":161571,"avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false}],"milestone":null,"comments":32,"created_at":"2018-04-13T14:05:02Z","updated_at":"2018-05-02T15:01:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2343","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2343","diff_url":"https://github.com/kubernetes/ingress-nginx/pull/2343.diff","patch_url":"https://github.com/kubernetes/ingress-nginx/pull/2343.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nIntegration with the [linkerd service mesh](https://github.com/linkerd/linkerd/blob/master/README.md) requires customization of the `proxy_pass` address in the nginx template. This PR adds the following annotations to allow users to customize the `proxy_pass` address:\r\n\r\n```\r\nnginx.ingress.kubernetes.io/proxy-pass-address: string\r\nnginx.ingress.kubernetes.io/proxy-pass-port: string\r\nnginx.ingress.kubernetes.io/proxy-to-local-node: bool\r\n```\r\n\r\nThe `proxy-pass-address` and `proxy-pass-port` annotations allow users to set `proxy_pass` to a linkerd address, so that traffic is passed to the service mesh as in the [basic nginx-linkerd example](https://github.com/linkerd/linkerd-examples/blob/master/k8s-daemonset/k8s/nginx.yml).\r\n\r\nIf `proxy-to-local-node` is `true`, the `proxy_pass` address will be set to the value parsed by `os.Getenv(\"NODE_NAME\")`, which can be set to the name of the node using the downward API. This is useful when running linkerd as a daemonset, ensuring that traffic reaching an nginx ingress controller pod will be forwarded to the linkerd pod running on the same node; when using linkerd in a linker-to-linker configuration with TLS enabled, this ensures traffic does not leave the node unencrypted."},"comment":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/comments/386009073","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2343#issuecomment-386009073","issue_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2343","id":386009073,"user":{"login":"Capitrium","id":5111534,"avatar_url":"https://avatars3.githubusercontent.com/u/5111534?v=4","gravatar_id":"","url":"https://api.github.com/users/Capitrium","html_url":"https://github.com/Capitrium","followers_url":"https://api.github.com/users/Capitrium/followers","following_url":"https://api.github.com/users/Capitrium/following{/other_user}","gists_url":"https://api.github.com/users/Capitrium/gists{/gist_id}","starred_url":"https://api.github.com/users/Capitrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Capitrium/subscriptions","organizations_url":"https://api.github.com/users/Capitrium/orgs","repos_url":"https://api.github.com/users/Capitrium/repos","events_url":"https://api.github.com/users/Capitrium/events{/privacy}","received_events_url":"https://api.github.com/users/Capitrium/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T15:01:49Z","updated_at":"2018-05-02T15:01:49Z","author_association":"NONE","body":"@aledbf e2e tests have been added and the build is passing, I think the only thing left is to determine whether this change is actually needed - I believe that it is, given the issues that I've previously mentioned when using rewrites with the `service-upstream/upstream-vhost` annotations, and when using `upstream-vhost` with the `auth-signin/auth-url` annotations."}}
{"actor":{"display_login":"Capitrium"}}