{"action":"created","comment":{"url":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/comments/168053373","pull_request_review_id":96359166,"id":168053373,"diff_hunk":"@@ -36,11 +69,22 @@ export default class MenuDropDown extends Component<Props> {\n   }\n \n   render () {\n+    const deviceHeight = PLATFORM.deviceHeight\n+    const verticalBuffer = ((this.state.pageY + this.state.height - 8) > PLATFORM.deviceHeight) ? 12 : 0\n+    const lowerLimitOfMenu = this.state.pageY + this.state.height\n+    const offset = lowerLimitOfMenu - deviceHeight\n+    const newPageY = this.state.pageY - offset - verticalBuffer\n     let optionsStyle = {}\n     if (this.props.rightSide) {","path":"src/modules/UI/components/MenuDropDown/MenuDropDown.ui.js","position":67,"original_position":67,"commit_id":"2de970c9e2302a88c02734709474dce6781de9bb","original_commit_id":"2de970c9e2302a88c02734709474dce6781de9bb","user":{"login":"thehobbit85","id":4012041,"avatar_url":"https://avatars1.githubusercontent.com/u/4012041?v=4","gravatar_id":"","url":"https://api.github.com/users/thehobbit85","html_url":"https://github.com/thehobbit85","followers_url":"https://api.github.com/users/thehobbit85/followers","following_url":"https://api.github.com/users/thehobbit85/following{/other_user}","gists_url":"https://api.github.com/users/thehobbit85/gists{/gist_id}","starred_url":"https://api.github.com/users/thehobbit85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehobbit85/subscriptions","organizations_url":"https://api.github.com/users/thehobbit85/orgs","repos_url":"https://api.github.com/users/thehobbit85/repos","events_url":"https://api.github.com/users/thehobbit85/events{/privacy}","received_events_url":"https://api.github.com/users/thehobbit85/received_events","type":"User","site_admin":false},"body":"That's not my concern, the problem I see is that the \"if\" condition will never be true and therefore this would never happen:\r\noptionsStyle = {\r\n   left: '1%',\r\n   top: this.state.pageY  \r\n }\r\nIf that's ok then go ahead and delete it","created_at":"2018-02-14T01:11:36Z","updated_at":"2018-02-14T01:11:36Z","html_url":"https://github.com/Airbitz/edge-react-gui/pull/482#discussion_r168053373","pull_request_url":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/482","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/comments/168053373"},"html":{"href":"https://github.com/Airbitz/edge-react-gui/pull/482#discussion_r168053373"},"pull_request":{"href":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/482"}},"in_reply_to_id":167985270},"pull_request":{"url":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/482","id":168768069,"html_url":"https://github.com/Airbitz/edge-react-gui/pull/482","diff_url":"https://github.com/Airbitz/edge-react-gui/pull/482.diff","patch_url":"https://github.com/Airbitz/edge-react-gui/pull/482.patch","issue_url":"https://api.github.com/repos/Airbitz/edge-react-gui/issues/482","number":482,"state":"open","locked":false,"title":"Re-adjust WalletListOptions dropdown vertical position to prevent cutoff","user":{"login":"kylanhurt","id":6249205,"avatar_url":"https://avatars3.githubusercontent.com/u/6249205?v=4","gravatar_id":"","url":"https://api.github.com/users/kylanhurt","html_url":"https://github.com/kylanhurt","followers_url":"https://api.github.com/users/kylanhurt/followers","following_url":"https://api.github.com/users/kylanhurt/following{/other_user}","gists_url":"https://api.github.com/users/kylanhurt/gists{/gist_id}","starred_url":"https://api.github.com/users/kylanhurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylanhurt/subscriptions","organizations_url":"https://api.github.com/users/kylanhurt/orgs","repos_url":"https://api.github.com/users/kylanhurt/repos","events_url":"https://api.github.com/users/kylanhurt/events{/privacy}","received_events_url":"https://api.github.com/users/kylanhurt/received_events","type":"User","site_admin":false},"body":"The purpose of this task is to prevent the WalletListOptions dropdown menu from going off the screen when the wallet item is toward the bottom of the screen.\r\n\r\nAsana Task: https://app.asana.com/0/361770107085503/553039148202323/f","created_at":"2018-02-13T07:01:24Z","updated_at":"2018-02-14T01:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ce65a05b9ba0e5e4246e0e5413be73510c0c448","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ahujsak","id":502595,"avatar_url":"https://avatars1.githubusercontent.com/u/502595?v=4","gravatar_id":"","url":"https://api.github.com/users/ahujsak","html_url":"https://github.com/ahujsak","followers_url":"https://api.github.com/users/ahujsak/followers","following_url":"https://api.github.com/users/ahujsak/following{/other_user}","gists_url":"https://api.github.com/users/ahujsak/gists{/gist_id}","starred_url":"https://api.github.com/users/ahujsak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahujsak/subscriptions","organizations_url":"https://api.github.com/users/ahujsak/orgs","repos_url":"https://api.github.com/users/ahujsak/repos","events_url":"https://api.github.com/users/ahujsak/events{/privacy}","received_events_url":"https://api.github.com/users/ahujsak/received_events","type":"User","site_admin":false},{"login":"vsashyn","id":4557935,"avatar_url":"https://avatars2.githubusercontent.com/u/4557935?v=4","gravatar_id":"","url":"https://api.github.com/users/vsashyn","html_url":"https://github.com/vsashyn","followers_url":"https://api.github.com/users/vsashyn/followers","following_url":"https://api.github.com/users/vsashyn/following{/other_user}","gists_url":"https://api.github.com/users/vsashyn/gists{/gist_id}","starred_url":"https://api.github.com/users/vsashyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsashyn/subscriptions","organizations_url":"https://api.github.com/users/vsashyn/orgs","repos_url":"https://api.github.com/users/vsashyn/repos","events_url":"https://api.github.com/users/vsashyn/events{/privacy}","received_events_url":"https://api.github.com/users/vsashyn/received_events","type":"User","site_admin":false},{"login":"wolverineks","id":8462274,"avatar_url":"https://avatars2.githubusercontent.com/u/8462274?v=4","gravatar_id":"","url":"https://api.github.com/users/wolverineks","html_url":"https://github.com/wolverineks","followers_url":"https://api.github.com/users/wolverineks/followers","following_url":"https://api.github.com/users/wolverineks/following{/other_user}","gists_url":"https://api.github.com/users/wolverineks/gists{/gist_id}","starred_url":"https://api.github.com/users/wolverineks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolverineks/subscriptions","organizations_url":"https://api.github.com/users/wolverineks/orgs","repos_url":"https://api.github.com/users/wolverineks/repos","events_url":"https://api.github.com/users/wolverineks/events{/privacy}","received_events_url":"https://api.github.com/users/wolverineks/received_events","type":"User","site_admin":false},{"login":"amanalili","id":17136567,"avatar_url":"https://avatars2.githubusercontent.com/u/17136567?v=4","gravatar_id":"","url":"https://api.github.com/users/amanalili","html_url":"https://github.com/amanalili","followers_url":"https://api.github.com/users/amanalili/followers","following_url":"https://api.github.com/users/amanalili/following{/other_user}","gists_url":"https://api.github.com/users/amanalili/gists{/gist_id}","starred_url":"https://api.github.com/users/amanalili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amanalili/subscriptions","organizations_url":"https://api.github.com/users/amanalili/orgs","repos_url":"https://api.github.com/users/amanalili/repos","events_url":"https://api.github.com/users/amanalili/events{/privacy}","received_events_url":"https://api.github.com/users/amanalili/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":486520943,"url":"https://api.github.com/repos/Airbitz/edge-react-gui/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/482/commits","review_comments_url":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/482/comments","review_comment_url":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Airbitz/edge-react-gui/issues/482/comments","statuses_url":"https://api.github.com/repos/Airbitz/edge-react-gui/statuses/2de970c9e2302a88c02734709474dce6781de9bb","head":{"label":"Airbitz:kylan/walletListDropdownCutoff","ref":"kylan/walletListDropdownCutoff","sha":"2de970c9e2302a88c02734709474dce6781de9bb","user":{"login":"Airbitz","id":6613230,"avatar_url":"https://avatars0.githubusercontent.com/u/6613230?v=4","gravatar_id":"","url":"https://api.github.com/users/Airbitz","html_url":"https://github.com/Airbitz","followers_url":"https://api.github.com/users/Airbitz/followers","following_url":"https://api.github.com/users/Airbitz/following{/other_user}","gists_url":"https://api.github.com/users/Airbitz/gists{/gist_id}","starred_url":"https://api.github.com/users/Airbitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airbitz/subscriptions","organizations_url":"https://api.github.com/users/Airbitz/orgs","repos_url":"https://api.github.com/users/Airbitz/repos","events_url":"https://api.github.com/users/Airbitz/events{/privacy}","received_events_url":"https://api.github.com/users/Airbitz/received_events","type":"Organization","site_admin":false},"repo":{"id":74451355,"name":"edge-react-gui","full_name":"Airbitz/edge-react-gui","owner":{"login":"Airbitz","id":6613230,"avatar_url":"https://avatars0.githubusercontent.com/u/6613230?v=4","gravatar_id":"","url":"https://api.github.com/users/Airbitz","html_url":"https://github.com/Airbitz","followers_url":"https://api.github.com/users/Airbitz/followers","following_url":"https://api.github.com/users/Airbitz/following{/other_user}","gists_url":"https://api.github.com/users/Airbitz/gists{/gist_id}","starred_url":"https://api.github.com/users/Airbitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airbitz/subscriptions","organizations_url":"https://api.github.com/users/Airbitz/orgs","repos_url":"https://api.github.com/users/Airbitz/repos","events_url":"https://api.github.com/users/Airbitz/events{/privacy}","received_events_url":"https://api.github.com/users/Airbitz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Airbitz/edge-react-gui","description":"Edge Wallet React Native GUI for iOS and Android","fork":false,"url":"https://api.github.com/repos/Airbitz/edge-react-gui","forks_url":"https://api.github.com/repos/Airbitz/edge-react-gui/forks","keys_url":"https://api.github.com/repos/Airbitz/edge-react-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Airbitz/edge-react-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Airbitz/edge-react-gui/teams","hooks_url":"https://api.github.com/repos/Airbitz/edge-react-gui/hooks","issue_events_url":"https://api.github.com/repos/Airbitz/edge-react-gui/issues/events{/number}","events_url":"https://api.github.com/repos/Airbitz/edge-react-gui/events","assignees_url":"https://api.github.com/repos/Airbitz/edge-react-gui/assignees{/user}","branches_url":"https://api.github.com/repos/Airbitz/edge-react-gui/branches{/branch}","tags_url":"https://api.github.com/repos/Airbitz/edge-react-gui/tags","blobs_url":"https://api.github.com/repos/Airbitz/edge-react-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Airbitz/edge-react-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Airbitz/edge-react-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Airbitz/edge-react-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Airbitz/edge-react-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/Airbitz/edge-react-gui/languages","stargazers_url":"https://api.github.com/repos/Airbitz/edge-react-gui/stargazers","contributors_url":"https://api.github.com/repos/Airbitz/edge-react-gui/contributors","subscribers_url":"https://api.github.com/repos/Airbitz/edge-react-gui/subscribers","subscription_url":"https://api.github.com/repos/Airbitz/edge-react-gui/subscription","commits_url":"https://api.github.com/repos/Airbitz/edge-react-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Airbitz/edge-react-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Airbitz/edge-react-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Airbitz/edge-react-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Airbitz/edge-react-gui/contents/{+path}","compare_url":"https://api.github.com/repos/Airbitz/edge-react-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Airbitz/edge-react-gui/merges","archive_url":"https://api.github.com/repos/Airbitz/edge-react-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Airbitz/edge-react-gui/downloads","issues_url":"https://api.github.com/repos/Airbitz/edge-react-gui/issues{/number}","pulls_url":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/Airbitz/edge-react-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/Airbitz/edge-react-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Airbitz/edge-react-gui/labels{/name}","releases_url":"https://api.github.com/repos/Airbitz/edge-react-gui/releases{/id}","deployments_url":"https://api.github.com/repos/Airbitz/edge-react-gui/deployments","created_at":"2016-11-22T08:34:36Z","updated_at":"2018-02-07T14:38:14Z","pushed_at":"2018-02-14T01:05:59Z","git_url":"git://github.com/Airbitz/edge-react-gui.git","ssh_url":"git@github.com:Airbitz/edge-react-gui.git","clone_url":"https://github.com/Airbitz/edge-react-gui.git","svn_url":"https://github.com/Airbitz/edge-react-gui","homepage":"https://edgesecure.co","size":97663,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":21,"open_issues":4,"watchers":31,"default_branch":"develop"}},"base":{"label":"Airbitz:develop","ref":"develop","sha":"b814817023972c4f43155ab2fd7b2992af146dc8","user":{"login":"Airbitz","id":6613230,"avatar_url":"https://avatars0.githubusercontent.com/u/6613230?v=4","gravatar_id":"","url":"https://api.github.com/users/Airbitz","html_url":"https://github.com/Airbitz","followers_url":"https://api.github.com/users/Airbitz/followers","following_url":"https://api.github.com/users/Airbitz/following{/other_user}","gists_url":"https://api.github.com/users/Airbitz/gists{/gist_id}","starred_url":"https://api.github.com/users/Airbitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airbitz/subscriptions","organizations_url":"https://api.github.com/users/Airbitz/orgs","repos_url":"https://api.github.com/users/Airbitz/repos","events_url":"https://api.github.com/users/Airbitz/events{/privacy}","received_events_url":"https://api.github.com/users/Airbitz/received_events","type":"Organization","site_admin":false},"repo":{"id":74451355,"name":"edge-react-gui","full_name":"Airbitz/edge-react-gui","owner":{"login":"Airbitz","id":6613230,"avatar_url":"https://avatars0.githubusercontent.com/u/6613230?v=4","gravatar_id":"","url":"https://api.github.com/users/Airbitz","html_url":"https://github.com/Airbitz","followers_url":"https://api.github.com/users/Airbitz/followers","following_url":"https://api.github.com/users/Airbitz/following{/other_user}","gists_url":"https://api.github.com/users/Airbitz/gists{/gist_id}","starred_url":"https://api.github.com/users/Airbitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airbitz/subscriptions","organizations_url":"https://api.github.com/users/Airbitz/orgs","repos_url":"https://api.github.com/users/Airbitz/repos","events_url":"https://api.github.com/users/Airbitz/events{/privacy}","received_events_url":"https://api.github.com/users/Airbitz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Airbitz/edge-react-gui","description":"Edge Wallet React Native GUI for iOS and Android","fork":false,"url":"https://api.github.com/repos/Airbitz/edge-react-gui","forks_url":"https://api.github.com/repos/Airbitz/edge-react-gui/forks","keys_url":"https://api.github.com/repos/Airbitz/edge-react-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Airbitz/edge-react-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Airbitz/edge-react-gui/teams","hooks_url":"https://api.github.com/repos/Airbitz/edge-react-gui/hooks","issue_events_url":"https://api.github.com/repos/Airbitz/edge-react-gui/issues/events{/number}","events_url":"https://api.github.com/repos/Airbitz/edge-react-gui/events","assignees_url":"https://api.github.com/repos/Airbitz/edge-react-gui/assignees{/user}","branches_url":"https://api.github.com/repos/Airbitz/edge-react-gui/branches{/branch}","tags_url":"https://api.github.com/repos/Airbitz/edge-react-gui/tags","blobs_url":"https://api.github.com/repos/Airbitz/edge-react-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Airbitz/edge-react-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Airbitz/edge-react-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Airbitz/edge-react-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Airbitz/edge-react-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/Airbitz/edge-react-gui/languages","stargazers_url":"https://api.github.com/repos/Airbitz/edge-react-gui/stargazers","contributors_url":"https://api.github.com/repos/Airbitz/edge-react-gui/contributors","subscribers_url":"https://api.github.com/repos/Airbitz/edge-react-gui/subscribers","subscription_url":"https://api.github.com/repos/Airbitz/edge-react-gui/subscription","commits_url":"https://api.github.com/repos/Airbitz/edge-react-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Airbitz/edge-react-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Airbitz/edge-react-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Airbitz/edge-react-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Airbitz/edge-react-gui/contents/{+path}","compare_url":"https://api.github.com/repos/Airbitz/edge-react-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Airbitz/edge-react-gui/merges","archive_url":"https://api.github.com/repos/Airbitz/edge-react-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Airbitz/edge-react-gui/downloads","issues_url":"https://api.github.com/repos/Airbitz/edge-react-gui/issues{/number}","pulls_url":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/Airbitz/edge-react-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/Airbitz/edge-react-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Airbitz/edge-react-gui/labels{/name}","releases_url":"https://api.github.com/repos/Airbitz/edge-react-gui/releases{/id}","deployments_url":"https://api.github.com/repos/Airbitz/edge-react-gui/deployments","created_at":"2016-11-22T08:34:36Z","updated_at":"2018-02-07T14:38:14Z","pushed_at":"2018-02-14T01:05:59Z","git_url":"git://github.com/Airbitz/edge-react-gui.git","ssh_url":"git@github.com:Airbitz/edge-react-gui.git","clone_url":"https://github.com/Airbitz/edge-react-gui.git","svn_url":"https://github.com/Airbitz/edge-react-gui","homepage":"https://edgesecure.co","size":97663,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":21,"open_issues":4,"watchers":31,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/482"},"html":{"href":"https://github.com/Airbitz/edge-react-gui/pull/482"},"issue":{"href":"https://api.github.com/repos/Airbitz/edge-react-gui/issues/482"},"comments":{"href":"https://api.github.com/repos/Airbitz/edge-react-gui/issues/482/comments"},"review_comments":{"href":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/482/comments"},"review_comment":{"href":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Airbitz/edge-react-gui/pulls/482/commits"},"statuses":{"href":"https://api.github.com/repos/Airbitz/edge-react-gui/statuses/2de970c9e2302a88c02734709474dce6781de9bb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thehobbit85"}}