{"action":"created","issue":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1379","repository_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy","labels_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1379/labels{/name}","comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1379/comments","events_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1379/events","html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1379","id":335806101,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDEyNDY1","number":1379,"title":"drop VS finding","user":{"login":"adamralph","id":677704,"node_id":"MDQ6VXNlcjY3NzcwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/677704?v=4","gravatar_id":"","url":"https://api.github.com/users/adamralph","html_url":"https://github.com/adamralph","followers_url":"https://api.github.com/users/adamralph/followers","following_url":"https://api.github.com/users/adamralph/following{/other_user}","gists_url":"https://api.github.com/users/adamralph/gists{/gist_id}","starred_url":"https://api.github.com/users/adamralph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamralph/subscriptions","organizations_url":"https://api.github.com/users/adamralph/orgs","repos_url":"https://api.github.com/users/adamralph/repos","events_url":"https://api.github.com/users/adamralph/events{/privacy}","received_events_url":"https://api.github.com/users/adamralph/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-06-26T12:55:40Z","updated_at":"2018-06-26T14:50:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/1379","html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1379","diff_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1379.diff","patch_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1379.patch"},"body":"Replaces #1378"},"comment":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/comments/400337744","html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1379#issuecomment-400337744","issue_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1379","id":400337744,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDMzNzc0NA==","user":{"login":"adamralph","id":677704,"node_id":"MDQ6VXNlcjY3NzcwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/677704?v=4","gravatar_id":"","url":"https://api.github.com/users/adamralph","html_url":"https://github.com/adamralph","followers_url":"https://api.github.com/users/adamralph/followers","following_url":"https://api.github.com/users/adamralph/following{/other_user}","gists_url":"https://api.github.com/users/adamralph/gists{/gist_id}","starred_url":"https://api.github.com/users/adamralph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamralph/subscriptions","organizations_url":"https://api.github.com/users/adamralph/orgs","repos_url":"https://api.github.com/users/adamralph/repos","events_url":"https://api.github.com/users/adamralph/events{/privacy}","received_events_url":"https://api.github.com/users/adamralph/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T14:50:13Z","updated_at":"2018-06-26T14:50:13Z","author_association":"MEMBER","body":"@thomaslevesque if you use `dotnet msbuild` then yes, you can pass the usual MSBuild params (with the exception of `nodeReuse` as above). The problem with that is that is that the lack of support for `nodeReuse` could mean that phantom msbuild.exe processes are left over after running the build locally (not a concern in Appveyor since the machines are destroyed after use). If you want to keep using msbuild explicitly then I suggest waiting until https://github.com/Microsoft/msbuild/issues/1135 has been released.\r\n\r\nSo I discovered the problem in Bullseye. I originally wrote it for use in regular .NET projects, as I'm doing in SimpleExec, LiteGuard, xBehave.net, etc. To that end, I made it return an exit code from `Run()` which can be propagated to the exit code of `Program.Main`. However, in the context of a script, that doesn't work, since the returned value from a script is just a returned value, not an exit code. I'm going to change Bullseye to throw an exception in RC4. I had a feeling that switching from exceptions to error codes was going to bit me eventually, and hey presto. Lesson learned. Even when you think \"yeah, but in this case...\" libraries should _always_ respect the exception model, and not attempt to switch over to error codes. I'll send another PR to fix that problem as soon as I release Bullseye RC4.\r\n\r\nI agree that we should drop this PR and go back to https://github.com/FakeItEasy/FakeItEasy/pull/1378. When https://github.com/Microsoft/msbuild/issues/1135 is released, the intent of this PR can be revisited."}}
{"actor":{"display_login":"adamralph"}}