{"action":"created","issue":{"url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/886","repository_url":"https://api.github.com/repos/harfbuzz/harfbuzz","labels_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/886/labels{/name}","comments_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/886/comments","events_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/886/events","html_url":"https://github.com/harfbuzz/harfbuzz/pull/886","id":304986216,"number":886,"title":"CMake: hide symbols by default on non-MSVC, define export attribute","user":{"login":"madig","id":380829,"avatar_url":"https://avatars1.githubusercontent.com/u/380829?v=4","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-14T00:52:27Z","updated_at":"2018-03-14T07:47:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/harfbuzz/harfbuzz/pulls/886","html_url":"https://github.com/harfbuzz/harfbuzz/pull/886","diff_url":"https://github.com/harfbuzz/harfbuzz/pull/886.diff","patch_url":"https://github.com/harfbuzz/harfbuzz/pull/886.patch"},"body":"This change makes sure that non-MSVC builds using CMake properly hide\r\nnon-exported functions.\r\n\r\nWe haven't reached symbol-parity yet though:\r\nAutotools symbol list on my machine: https://paste.fedoraproject.org/paste/VndugIDtEGsXj~UDZJitzw\r\nCMake build symbol list: https://paste.fedoraproject.org/paste/LmK7tRcdWAYAg-Y~BGq1Rw"},"comment":{"url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/comments/372932263","html_url":"https://github.com/harfbuzz/harfbuzz/pull/886#issuecomment-372932263","issue_url":"https://api.github.com/repos/harfbuzz/harfbuzz/issues/886","id":372932263,"user":{"login":"ebraminio","id":833473,"avatar_url":"https://avatars2.githubusercontent.com/u/833473?v=4","gravatar_id":"","url":"https://api.github.com/users/ebraminio","html_url":"https://github.com/ebraminio","followers_url":"https://api.github.com/users/ebraminio/followers","following_url":"https://api.github.com/users/ebraminio/following{/other_user}","gists_url":"https://api.github.com/users/ebraminio/gists{/gist_id}","starred_url":"https://api.github.com/users/ebraminio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebraminio/subscriptions","organizations_url":"https://api.github.com/users/ebraminio/orgs","repos_url":"https://api.github.com/users/ebraminio/repos","events_url":"https://api.github.com/users/ebraminio/events{/privacy}","received_events_url":"https://api.github.com/users/ebraminio/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T07:47:02Z","updated_at":"2018-03-14T07:47:02Z","author_association":"OWNER","body":"Hi there. Thanks for the effort! It seems CMake's exported symbols test (which is common with autotools) is not happy about the change."}}
{"actor":{"display_login":"ebraminio"}}