{"action":"created","comment":{"url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/comments/236235395","pull_request_review_id":178264947,"id":236235395,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjIzNTM5NQ==","diff_hunk":"@@ -1,54 +1,40 @@\n # Alfresco Search Deployment\n \n-This Helm chart will deploy Search Services.\n-\n-It offers you the posibility of setting affinity and tolerations for the search pod:\n-\n-```bash\n-# Define Affinity and Tolerations used for scheduling SOLR on Pod and PV level\n-\n-affinity: |\n-  nodeAffinity:\n-    requiredDuringSchedulingIgnoredDuringExecution:\n-      nodeSelectorTerms:\n-        - matchExpressions:\n-          - key: \"SolrMasterOnly\"\n-            operator: In\n-            values:\n-            - \"true\"\n-\n-tolerations:\n-- key: \"SolrMasterOnly\"\n-  operator: \"Equal\"\n-  value: \"true\"\n-  effect: \"NoSchedule\"\n-```\n-\n-It creates its own PVC to store indexes if no other existingPVC is given with persistence.existingClaim\n-\n-```bash\n-persistence:\n-  existingClaim: #Only define if you have a pvc already defined\n-```\n-\n-It offers the posibility of attaching a specific AWS EBS\n-\n-```bash\n-persistence:\n-  EbsPvConfiguration:\n-    fsType: ext4\n-    volumeID: volumeEC2\n-```\n-\n-And also gives you the option of setting affinity for the persistent volume.\n-\n-```bash\n-PvNodeAffinity:\n-  required:    \n-    nodeSelectorTerms:\n-    - matchExpressions:\n-      - key: \"SolrMasterOnly\"\n-        operator: In\n-        values:\n-        - \"true\"\n-```\n+## Contents of this repository\n+a) Alfresco Content Services deployed via [docker-compose](docker-compose/docker-compose.yml)\n+1. Alfresco Repository\n+2. Alfresco Share\n+3. A Postgres DB  \n+4. Alfresco Insight Engine (Quay.io access is required. Please [contact support](http://support.alfresco.com/) if you don’t yet have it)\n+5. Alfresco Insight Zeppelin (Quay.io access is required. Please [contact support](http://support.alfresco.com/) if you don’t yet have it)\n+\n+b) Alfresco Search ([alfresco-search](./helm/alfresco-search)) helm charts used as a requirement under [acs-deployment/helm/alfresco-content-services](https://github.com/Alfresco/acs-deployment/tree/master/helm/alfresco-content-services) Chart\n+\n+>:exclamation: Search Services will be deployed as part of ACS and it is defined as a requirement in [ACS helm chart](https://github.com/Alfresco/acs-deployment/tree/master/helm/alfresco-content-services).\n+\n+## Alfresco Search - Helm Chart\n+\n+### Deployment options\n+* [Deploying with Helm charts on AWS using Kops](https://github.com/Alfresco/acs-deployment/tree/master/docs/helm-deployment-aws_kops.md)\n+* [Deploying with Helm charts on AWS using EKS](https://github.com/Alfresco/acs-deployment/tree/master/docs/helm-deployment-aws_eks.md)\n+\n+### Configurations\n+\n+The following table lists the configurable parameters of the [Alfresco Search](./helm/alfresco-search) chart and their default values. \n+\n+>For Alfresco Content Service chart please consult [this table](https://github.com/Alfresco/acs-deployment/blob/master/helm/alfresco-content-services/README.md#configuration).\n+\n+Parameter | Description | Default\n+--- | --- | ---\n+`alfresco-search.type` | Define the type of Alfresco Search to use. Available options: `insight-engine` or `search-services` | `search-services`\n+`alfresco-search.registryPullSecrets` | As the Docker Image for Insight Engine is not publicly available the registryPullSecrets has to be set. More details on [SECRETS.md](https://github.com/Alfresco/alfresco-anaxes-shipyard/blob/master/SECRETS.md). (_By default, you don't need to set this property if your are using only the SearchServices image from [DockerHub](https://hub.docker.com/r/alfresco/alfresco-search-services/tags/) - this is public available._) | NONE  ","path":"README.md","position":null,"original_position":82,"commit_id":"e33a137e80ace06921d1a29e59e297cd14a2ecbe","original_commit_id":"d6c01456b80fce9b925ecc02632c96ce260d0a8d","user":{"login":"paulbrodner","id":946884,"node_id":"MDQ6VXNlcjk0Njg4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/946884?v=4","gravatar_id":"","url":"https://api.github.com/users/paulbrodner","html_url":"https://github.com/paulbrodner","followers_url":"https://api.github.com/users/paulbrodner/followers","following_url":"https://api.github.com/users/paulbrodner/following{/other_user}","gists_url":"https://api.github.com/users/paulbrodner/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbrodner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbrodner/subscriptions","organizations_url":"https://api.github.com/users/paulbrodner/orgs","repos_url":"https://api.github.com/users/paulbrodner/repos","events_url":"https://api.github.com/users/paulbrodner/events{/privacy}","received_events_url":"https://api.github.com/users/paulbrodner/received_events","type":"User","site_admin":false},"body":"done in  e33a137","created_at":"2018-11-26T12:31:15Z","updated_at":"2018-11-26T12:31:15Z","html_url":"https://github.com/Alfresco/alfresco-search-deployment/pull/7#discussion_r236235395","pull_request_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/7","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/comments/236235395"},"html":{"href":"https://github.com/Alfresco/alfresco-search-deployment/pull/7#discussion_r236235395"},"pull_request":{"href":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/7"}},"in_reply_to_id":235325004},"pull_request":{"url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/7","id":231141478,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTQxNDc4","html_url":"https://github.com/Alfresco/alfresco-search-deployment/pull/7","diff_url":"https://github.com/Alfresco/alfresco-search-deployment/pull/7.diff","patch_url":"https://github.com/Alfresco/alfresco-search-deployment/pull/7.patch","issue_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/issues/7","number":7,"state":"open","locked":false,"title":"SEARCH-1138: update README for alfresco-search-deployment","user":{"login":"paulbrodner","id":946884,"node_id":"MDQ6VXNlcjk0Njg4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/946884?v=4","gravatar_id":"","url":"https://api.github.com/users/paulbrodner","html_url":"https://github.com/paulbrodner","followers_url":"https://api.github.com/users/paulbrodner/followers","following_url":"https://api.github.com/users/paulbrodner/following{/other_user}","gists_url":"https://api.github.com/users/paulbrodner/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbrodner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbrodner/subscriptions","organizations_url":"https://api.github.com/users/paulbrodner/orgs","repos_url":"https://api.github.com/users/paulbrodner/repos","events_url":"https://api.github.com/users/paulbrodner/events{/privacy}","received_events_url":"https://api.github.com/users/paulbrodner/received_events","type":"User","site_admin":false},"body":"Updating README.md file","created_at":"2018-11-15T10:25:14Z","updated_at":"2018-11-26T12:31:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b8ed0548f456c786ad901a933ffce218df6989c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/issues/7/comments","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/statuses/e33a137e80ace06921d1a29e59e297cd14a2ecbe","head":{"label":"Alfresco:features/SEARCH-1138","ref":"features/SEARCH-1138","sha":"e33a137e80ace06921d1a29e59e297cd14a2ecbe","user":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":130326631,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzMjY2MzE=","name":"alfresco-search-deployment","full_name":"Alfresco/alfresco-search-deployment","private":false,"owner":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Alfresco/alfresco-search-deployment","description":null,"fork":false,"url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment","forks_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/forks","keys_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/teams","hooks_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/events","assignees_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/tags","blobs_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/languages","stargazers_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/subscription","commits_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/merges","archive_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/downloads","issues_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/deployments","created_at":"2018-04-20T07:34:07Z","updated_at":"2018-11-20T14:59:44Z","pushed_at":"2018-11-26T12:31:02Z","git_url":"git://github.com/Alfresco/alfresco-search-deployment.git","ssh_url":"git@github.com:Alfresco/alfresco-search-deployment.git","clone_url":"https://github.com/Alfresco/alfresco-search-deployment.git","svn_url":"https://github.com/Alfresco/alfresco-search-deployment","homepage":null,"size":59,"stargazers_count":1,"watchers_count":1,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"Alfresco:master","ref":"master","sha":"aedb21e5539bccd6be449ce4c5d1b966efba02d6","user":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":130326631,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzMjY2MzE=","name":"alfresco-search-deployment","full_name":"Alfresco/alfresco-search-deployment","private":false,"owner":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Alfresco/alfresco-search-deployment","description":null,"fork":false,"url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment","forks_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/forks","keys_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/teams","hooks_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/events","assignees_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/tags","blobs_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/languages","stargazers_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/subscription","commits_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/merges","archive_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/downloads","issues_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/deployments","created_at":"2018-04-20T07:34:07Z","updated_at":"2018-11-20T14:59:44Z","pushed_at":"2018-11-26T12:31:02Z","git_url":"git://github.com/Alfresco/alfresco-search-deployment.git","ssh_url":"git@github.com:Alfresco/alfresco-search-deployment.git","clone_url":"https://github.com/Alfresco/alfresco-search-deployment.git","svn_url":"https://github.com/Alfresco/alfresco-search-deployment","homepage":null,"size":59,"stargazers_count":1,"watchers_count":1,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/7"},"html":{"href":"https://github.com/Alfresco/alfresco-search-deployment/pull/7"},"issue":{"href":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/issues/7"},"comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Alfresco/alfresco-search-deployment/statuses/e33a137e80ace06921d1a29e59e297cd14a2ecbe"}},"author_association":"NONE"}}
{"actor":{"display_login":"paulbrodner"}}