{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/169663405","pull_request_review_id":98225449,"id":169663405,"diff_hunk":"@@ -0,0 +1,63 @@\n+package main\n+\n+import \"time\"\n+\n+// SyslogMessage keeps an index reference to the orignal slices of bytes.\n+// and will lazy convert the byte values to concrete usable type.\n+type SyslogMessage struct {\n+\tMessage  []byte\n+\tHostname []byte\n+\tPriority []byte\n+\tProgram  []byte\n+\tPid      []byte //int\n+\n+\tmonth  []byte\n+\tday    []byte\n+\thour   []byte\n+\tminute []byte\n+\tsecond []byte\n+}\n+\n+func newSyslogMessage() *SyslogMessage {\n+\treturn &SyslogMessage{}\n+}\n+\n+func (s *SyslogMessage) Month(m []byte) {\n+\ts.month = m\n+}\n+\n+func (s *SyslogMessage) GetMonth() int {\n+\treturn 0\n+}\n+\n+func (s *SyslogMessage) Day(d []byte) {","path":"filebeat/input/syslog/syslog.go","position":33,"original_position":33,"commit_id":"37af13d0af85ac84598db0578ffe17b0dfb3df1a","original_commit_id":"37af13d0af85ac84598db0578ffe17b0dfb3df1a","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"exported method SyslogMessage.Day should have comment or be unexported","created_at":"2018-02-21T14:59:34Z","updated_at":"2018-02-21T14:59:34Z","html_url":"https://github.com/elastic/beats/pull/6433#discussion_r169663405","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/6433","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/169663405"},"html":{"href":"https://github.com/elastic/beats/pull/6433#discussion_r169663405"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/6433"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/6433","id":170494131,"html_url":"https://github.com/elastic/beats/pull/6433","diff_url":"https://github.com/elastic/beats/pull/6433.diff","patch_url":"https://github.com/elastic/beats/pull/6433.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/6433","number":6433,"state":"open","locked":false,"title":"[WIP] Add a Syslog input listening to UDP and TCP connection","user":{"login":"ph","id":640,"avatar_url":"https://avatars0.githubusercontent.com/u/640?v=4","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"body":"This commit add a new input named Syslog which can receive syslog\r\nformated events from either UDP or TCP, currently without any SSL.\r\nThe events are locally parsed and send downstream.\r\n\r\nThe parser will support RFC3164 formatted events, the parser uses\r\nstate machines to parses the messages really fast instead of regular\r\nexpression.\r\n\r\nThe state machine are written using Ragel and that generate compact and\r\noptimized go code, using state machine is a trade off of speed vs size\r\nof the binary. This generated file add 32K to the final binary which is\r\nan OK trade of.\r\n\r\nLimitation:\r\n\r\nDue to the nature of syslog, it's possible that some messages are not\r\ncorrectly parsed, the parser is a work in progress and will benefit from\r\nany bug report.\r\n\r\nThe best solution for them is to tag them and keep the `message` as the\r\nraw message.","created_at":"2018-02-21T14:59:26Z","updated_at":"2018-02-21T14:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15f9e71577d086d91205a9abe17d2fcf7fee3b13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":294278645,"url":"https://api.github.com/repos/elastic/beats/labels/Filebeat","name":"Filebeat","color":"008000","default":false},{"id":216798909,"url":"https://api.github.com/repos/elastic/beats/labels/in%20progress","name":"in progress","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/6433/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/6433/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/6433/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/37af13d0af85ac84598db0578ffe17b0dfb3df1a","head":{"label":"ph:feature/syslog-parser","ref":"feature/syslog-parser","sha":"37af13d0af85ac84598db0578ffe17b0dfb3df1a","user":{"login":"ph","id":640,"avatar_url":"https://avatars0.githubusercontent.com/u/640?v=4","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"repo":{"id":106414357,"name":"beats","full_name":"ph/beats","owner":{"login":"ph","id":640,"avatar_url":"https://avatars0.githubusercontent.com/u/640?v=4","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ph/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":true,"url":"https://api.github.com/repos/ph/beats","forks_url":"https://api.github.com/repos/ph/beats/forks","keys_url":"https://api.github.com/repos/ph/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ph/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ph/beats/teams","hooks_url":"https://api.github.com/repos/ph/beats/hooks","issue_events_url":"https://api.github.com/repos/ph/beats/issues/events{/number}","events_url":"https://api.github.com/repos/ph/beats/events","assignees_url":"https://api.github.com/repos/ph/beats/assignees{/user}","branches_url":"https://api.github.com/repos/ph/beats/branches{/branch}","tags_url":"https://api.github.com/repos/ph/beats/tags","blobs_url":"https://api.github.com/repos/ph/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ph/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ph/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/ph/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ph/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/ph/beats/languages","stargazers_url":"https://api.github.com/repos/ph/beats/stargazers","contributors_url":"https://api.github.com/repos/ph/beats/contributors","subscribers_url":"https://api.github.com/repos/ph/beats/subscribers","subscription_url":"https://api.github.com/repos/ph/beats/subscription","commits_url":"https://api.github.com/repos/ph/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/ph/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/ph/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/ph/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/ph/beats/contents/{+path}","compare_url":"https://api.github.com/repos/ph/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ph/beats/merges","archive_url":"https://api.github.com/repos/ph/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ph/beats/downloads","issues_url":"https://api.github.com/repos/ph/beats/issues{/number}","pulls_url":"https://api.github.com/repos/ph/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/ph/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/ph/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ph/beats/labels{/name}","releases_url":"https://api.github.com/repos/ph/beats/releases{/id}","deployments_url":"https://api.github.com/repos/ph/beats/deployments","created_at":"2017-10-10T12:29:57Z","updated_at":"2017-10-10T12:31:11Z","pushed_at":"2018-02-21T14:58:58Z","git_url":"git://github.com/ph/beats.git","ssh_url":"git@github.com:ph/beats.git","clone_url":"https://github.com/ph/beats.git","svn_url":"https://github.com/ph/beats","homepage":"https://www.elastic.co/products/beats","size":74031,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"5bdfd9b38ab10bd43ffccd8e0ce7d7a92a6dd085","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"name":"beats","full_name":"elastic/beats","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2018-02-21T14:05:04Z","pushed_at":"2018-02-21T14:59:27Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":74036,"stargazers_count":5227,"watchers_count":5227,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1472,"mirror_url":null,"archived":false,"open_issues_count":731,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1472,"open_issues":731,"watchers":5227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/6433"},"html":{"href":"https://github.com/elastic/beats/pull/6433"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/6433"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/6433/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/6433/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/6433/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/37af13d0af85ac84598db0578ffe17b0dfb3df1a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}