{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/238229262","pull_request_review_id":180716984,"id":238229262,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODIyOTI2Mg==","diff_hunk":"@@ -19,10 +19,11 @@ use utils 'zypper_call';\n use power_action_utils 'power_action';\n use kdump_utils;\n use testapi;\n+use ipmi_backend_utils 'use_ssh_serial_console';\n \n sub run {\n     my $self = shift;\n-    select_console('root-console');\n+    check_var('BACKEND', 'ipmi') ? use_ssh_serial_console : select_console 'root-console';","path":"tests/xfstests/enable_kdump.pm","position":9,"original_position":9,"commit_id":"981f3ef56d8691fe85b778db5dde898b171de221","original_commit_id":"ceb06b22402be672504e0e12d40bbeaea400a5d0","user":{"login":"rwx788","id":28305643,"node_id":"MDQ6VXNlcjI4MzA1NjQz","avatar_url":"https://avatars1.githubusercontent.com/u/28305643?v=4","gravatar_id":"","url":"https://api.github.com/users/rwx788","html_url":"https://github.com/rwx788","followers_url":"https://api.github.com/users/rwx788/followers","following_url":"https://api.github.com/users/rwx788/following{/other_user}","gists_url":"https://api.github.com/users/rwx788/gists{/gist_id}","starred_url":"https://api.github.com/users/rwx788/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwx788/subscriptions","organizations_url":"https://api.github.com/users/rwx788/orgs","repos_url":"https://api.github.com/users/rwx788/repos","events_url":"https://api.github.com/users/rwx788/events{/privacy}","received_events_url":"https://api.github.com/users/rwx788/received_events","type":"User","site_admin":false},"body":"Absolutely, but I would try to prevent this in general as it increases efforts of the refactoring later. I will create a ticket for that, let's see if we will be able to deliver.","created_at":"2018-12-03T11:17:26Z","updated_at":"2018-12-03T11:17:26Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6308#discussion_r238229262","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6308","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/238229262"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6308#discussion_r238229262"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6308"}},"in_reply_to_id":237414925},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6308","id":234309447,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzA5NDQ3","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6308","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6308.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6308.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6308","number":6308,"state":"open","locked":false,"title":"xfstests on another device","user":{"login":"ricardobranco777","id":10237751,"node_id":"MDQ6VXNlcjEwMjM3NzUx","avatar_url":"https://avatars3.githubusercontent.com/u/10237751?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardobranco777","html_url":"https://github.com/ricardobranco777","followers_url":"https://api.github.com/users/ricardobranco777/followers","following_url":"https://api.github.com/users/ricardobranco777/following{/other_user}","gists_url":"https://api.github.com/users/ricardobranco777/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardobranco777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardobranco777/subscriptions","organizations_url":"https://api.github.com/users/ricardobranco777/orgs","repos_url":"https://api.github.com/users/ricardobranco777/repos","events_url":"https://api.github.com/users/ricardobranco777/events{/privacy}","received_events_url":"https://api.github.com/users/ricardobranco777/received_events","type":"User","site_admin":false},"body":"Currently, xfstests only run on /dev/vda. This PR adds a XFSTESTS_DEVICE variable to run the tests on another device.\r\n\r\nIt is needed to run the tests on NVDIMM setting XFSTESTS_DEVICE=/dev/pmem0\r\n\r\nAlso, support was added to run over IPMI.","created_at":"2018-11-28T15:03:35Z","updated_at":"2018-12-03T11:17:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22a25f5d9ee91824f4605bd703d28b5f0f2ac68e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6308/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6308/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6308/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/981f3ef56d8691fe85b778db5dde898b171de221","head":{"label":"ricardobranco777:xfstests_on_nvdimm","ref":"xfstests_on_nvdimm","sha":"981f3ef56d8691fe85b778db5dde898b171de221","user":{"login":"ricardobranco777","id":10237751,"node_id":"MDQ6VXNlcjEwMjM3NzUx","avatar_url":"https://avatars3.githubusercontent.com/u/10237751?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardobranco777","html_url":"https://github.com/ricardobranco777","followers_url":"https://api.github.com/users/ricardobranco777/followers","following_url":"https://api.github.com/users/ricardobranco777/following{/other_user}","gists_url":"https://api.github.com/users/ricardobranco777/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardobranco777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardobranco777/subscriptions","organizations_url":"https://api.github.com/users/ricardobranco777/orgs","repos_url":"https://api.github.com/users/ricardobranco777/repos","events_url":"https://api.github.com/users/ricardobranco777/events{/privacy}","received_events_url":"https://api.github.com/users/ricardobranco777/received_events","type":"User","site_admin":false},"repo":{"id":148761442,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3NjE0NDI=","name":"os-autoinst-distri-opensuse","full_name":"ricardobranco777/os-autoinst-distri-opensuse","private":false,"owner":{"login":"ricardobranco777","id":10237751,"node_id":"MDQ6VXNlcjEwMjM3NzUx","avatar_url":"https://avatars3.githubusercontent.com/u/10237751?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardobranco777","html_url":"https://github.com/ricardobranco777","followers_url":"https://api.github.com/users/ricardobranco777/followers","following_url":"https://api.github.com/users/ricardobranco777/following{/other_user}","gists_url":"https://api.github.com/users/ricardobranco777/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardobranco777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardobranco777/subscriptions","organizations_url":"https://api.github.com/users/ricardobranco777/orgs","repos_url":"https://api.github.com/users/ricardobranco777/repos","events_url":"https://api.github.com/users/ricardobranco777/events{/privacy}","received_events_url":"https://api.github.com/users/ricardobranco777/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ricardobranco777/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/ricardobranco777/os-autoinst-distri-opensuse/deployments","created_at":"2018-09-14T08:45:07Z","updated_at":"2018-11-30T10:15:58Z","pushed_at":"2018-12-03T10:38:59Z","git_url":"git://github.com/ricardobranco777/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:ricardobranco777/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/ricardobranco777/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/ricardobranco777/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":98912,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"9795a846b7fa8f80f5781a96be4c2b4c83efc421","user":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzMDI4OA==","name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","private":false,"owner":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/deployments","created_at":"2014-03-11T12:54:42Z","updated_at":"2018-12-03T09:08:04Z","pushed_at":"2018-12-03T10:39:01Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":98963,"stargazers_count":34,"watchers_count":34,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":66,"license":null,"forks":155,"open_issues":66,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6308"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6308"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6308"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6308/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6308/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6308/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/981f3ef56d8691fe85b778db5dde898b171de221"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rwx788"}}