{"action":"created","comment":{"url":"https://api.github.com/repos/exonum/exonum/pulls/comments/208319609","pull_request_review_id":144104826,"id":208319609,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODMxOTYwOQ==","diff_hunk":"@@ -483,8 +483,10 @@ impl Blockchain {\n                 schema.consensus_messages_cache_mut().clear();\n                 let txs_in_block = schema.last_block().tx_count();\n                 let txs_count = schema.transactions_pool_len_index().get().unwrap_or(0);\n-                debug_assert!(txs_count >= txs_in_block as u64);\n-                schema.transactions_pool_len_index_mut().set(txs_count - txs_in_block as u64);\n+                debug_assert!(txs_count >= u64::from(txs_in_block));","path":"exonum/src/blockchain/mod.rs","position":null,"original_position":6,"commit_id":"41e797b1ab263baffd410df2bc292e673bf4a0dc","original_commit_id":"41e797b1ab263baffd410df2bc292e673bf4a0dc","user":{"login":"ilammy","id":1256587,"node_id":"MDQ6VXNlcjEyNTY1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1256587?v=4","gravatar_id":"","url":"https://api.github.com/users/ilammy","html_url":"https://github.com/ilammy","followers_url":"https://api.github.com/users/ilammy/followers","following_url":"https://api.github.com/users/ilammy/following{/other_user}","gists_url":"https://api.github.com/users/ilammy/gists{/gist_id}","starred_url":"https://api.github.com/users/ilammy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilammy/subscriptions","organizations_url":"https://api.github.com/users/ilammy/orgs","repos_url":"https://api.github.com/users/ilammy/repos","events_url":"https://api.github.com/users/ilammy/events{/privacy}","received_events_url":"https://api.github.com/users/ilammy/received_events","type":"User","site_admin":false},"body":"I'd say clippy is unreasonable at times. Maybe we should review `u32`, `u64`, `usize` usage for various 'lengths' to avoid such casts where possible.","created_at":"2018-08-07T17:33:45Z","updated_at":"2018-08-07T17:33:45Z","html_url":"https://github.com/exonum/exonum/pull/853#discussion_r208319609","pull_request_url":"https://api.github.com/repos/exonum/exonum/pulls/853","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum/pulls/comments/208319609"},"html":{"href":"https://github.com/exonum/exonum/pull/853#discussion_r208319609"},"pull_request":{"href":"https://api.github.com/repos/exonum/exonum/pulls/853"}}},"pull_request":{"url":"https://api.github.com/repos/exonum/exonum/pulls/853","id":206418696,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDE4Njk2","html_url":"https://github.com/exonum/exonum/pull/853","diff_url":"https://github.com/exonum/exonum/pull/853.diff","patch_url":"https://github.com/exonum/exonum/pull/853.patch","issue_url":"https://api.github.com/repos/exonum/exonum/issues/853","number":853,"state":"open","locked":false,"title":"Fix pool overflow","user":{"login":"vldm","id":8759725,"node_id":"MDQ6VXNlcjg3NTk3MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/8759725?v=4","gravatar_id":"","url":"https://api.github.com/users/vldm","html_url":"https://github.com/vldm","followers_url":"https://api.github.com/users/vldm/followers","following_url":"https://api.github.com/users/vldm/following{/other_user}","gists_url":"https://api.github.com/users/vldm/gists{/gist_id}","starred_url":"https://api.github.com/users/vldm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vldm/subscriptions","organizations_url":"https://api.github.com/users/vldm/orgs","repos_url":"https://api.github.com/users/vldm/repos","events_url":"https://api.github.com/users/vldm/events{/privacy}","received_events_url":"https://api.github.com/users/vldm/received_events","type":"User","site_admin":false},"body":"This pull request should fix overflow during persistent pool manipulation.\r\n\r\n\r\n\r\nTODO:\r\n- [x] Add more docs","created_at":"2018-08-06T14:33:58Z","updated_at":"2018-08-07T17:33:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba5c7c1f7d23c32649c50b405bbb1d31b169816e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alekseysidorov","id":83360,"node_id":"MDQ6VXNlcjgzMzYw","avatar_url":"https://avatars1.githubusercontent.com/u/83360?v=4","gravatar_id":"","url":"https://api.github.com/users/alekseysidorov","html_url":"https://github.com/alekseysidorov","followers_url":"https://api.github.com/users/alekseysidorov/followers","following_url":"https://api.github.com/users/alekseysidorov/following{/other_user}","gists_url":"https://api.github.com/users/alekseysidorov/gists{/gist_id}","starred_url":"https://api.github.com/users/alekseysidorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alekseysidorov/subscriptions","organizations_url":"https://api.github.com/users/alekseysidorov/orgs","repos_url":"https://api.github.com/users/alekseysidorov/repos","events_url":"https://api.github.com/users/alekseysidorov/events{/privacy}","received_events_url":"https://api.github.com/users/alekseysidorov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exonum/exonum/pulls/853/commits","review_comments_url":"https://api.github.com/repos/exonum/exonum/pulls/853/comments","review_comment_url":"https://api.github.com/repos/exonum/exonum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exonum/exonum/issues/853/comments","statuses_url":"https://api.github.com/repos/exonum/exonum/statuses/41e797b1ab263baffd410df2bc292e673bf4a0dc","head":{"label":"vldm:fix_pool_overflow","ref":"fix_pool_overflow","sha":"41e797b1ab263baffd410df2bc292e673bf4a0dc","user":{"login":"vldm","id":8759725,"node_id":"MDQ6VXNlcjg3NTk3MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/8759725?v=4","gravatar_id":"","url":"https://api.github.com/users/vldm","html_url":"https://github.com/vldm","followers_url":"https://api.github.com/users/vldm/followers","following_url":"https://api.github.com/users/vldm/following{/other_user}","gists_url":"https://api.github.com/users/vldm/gists{/gist_id}","starred_url":"https://api.github.com/users/vldm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vldm/subscriptions","organizations_url":"https://api.github.com/users/vldm/orgs","repos_url":"https://api.github.com/users/vldm/repos","events_url":"https://api.github.com/users/vldm/events{/privacy}","received_events_url":"https://api.github.com/users/vldm/received_events","type":"User","site_admin":false},"repo":{"id":97441812,"node_id":"MDEwOlJlcG9zaXRvcnk5NzQ0MTgxMg==","name":"exonum","full_name":"vldm/exonum","owner":{"login":"vldm","id":8759725,"node_id":"MDQ6VXNlcjg3NTk3MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/8759725?v=4","gravatar_id":"","url":"https://api.github.com/users/vldm","html_url":"https://github.com/vldm","followers_url":"https://api.github.com/users/vldm/followers","following_url":"https://api.github.com/users/vldm/following{/other_user}","gists_url":"https://api.github.com/users/vldm/gists{/gist_id}","starred_url":"https://api.github.com/users/vldm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vldm/subscriptions","organizations_url":"https://api.github.com/users/vldm/orgs","repos_url":"https://api.github.com/users/vldm/repos","events_url":"https://api.github.com/users/vldm/events{/privacy}","received_events_url":"https://api.github.com/users/vldm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vldm/exonum","description":"Exonum core repository","fork":true,"url":"https://api.github.com/repos/vldm/exonum","forks_url":"https://api.github.com/repos/vldm/exonum/forks","keys_url":"https://api.github.com/repos/vldm/exonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vldm/exonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vldm/exonum/teams","hooks_url":"https://api.github.com/repos/vldm/exonum/hooks","issue_events_url":"https://api.github.com/repos/vldm/exonum/issues/events{/number}","events_url":"https://api.github.com/repos/vldm/exonum/events","assignees_url":"https://api.github.com/repos/vldm/exonum/assignees{/user}","branches_url":"https://api.github.com/repos/vldm/exonum/branches{/branch}","tags_url":"https://api.github.com/repos/vldm/exonum/tags","blobs_url":"https://api.github.com/repos/vldm/exonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vldm/exonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vldm/exonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/vldm/exonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vldm/exonum/statuses/{sha}","languages_url":"https://api.github.com/repos/vldm/exonum/languages","stargazers_url":"https://api.github.com/repos/vldm/exonum/stargazers","contributors_url":"https://api.github.com/repos/vldm/exonum/contributors","subscribers_url":"https://api.github.com/repos/vldm/exonum/subscribers","subscription_url":"https://api.github.com/repos/vldm/exonum/subscription","commits_url":"https://api.github.com/repos/vldm/exonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/vldm/exonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/vldm/exonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/vldm/exonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/vldm/exonum/contents/{+path}","compare_url":"https://api.github.com/repos/vldm/exonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vldm/exonum/merges","archive_url":"https://api.github.com/repos/vldm/exonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vldm/exonum/downloads","issues_url":"https://api.github.com/repos/vldm/exonum/issues{/number}","pulls_url":"https://api.github.com/repos/vldm/exonum/pulls{/number}","milestones_url":"https://api.github.com/repos/vldm/exonum/milestones{/number}","notifications_url":"https://api.github.com/repos/vldm/exonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vldm/exonum/labels{/name}","releases_url":"https://api.github.com/repos/vldm/exonum/releases{/id}","deployments_url":"https://api.github.com/repos/vldm/exonum/deployments","created_at":"2017-07-17T06:21:05Z","updated_at":"2018-05-30T11:00:08Z","pushed_at":"2018-08-07T08:28:49Z","git_url":"git://github.com/vldm/exonum.git","ssh_url":"git@github.com:vldm/exonum.git","clone_url":"https://github.com/vldm/exonum.git","svn_url":"https://github.com/vldm/exonum","homepage":"http://exonum.com","size":25122,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exonum:master","ref":"master","sha":"93d206bb492bd55b1ff92a0b8a63976290ed4244","user":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"repo":{"id":80729805,"node_id":"MDEwOlJlcG9zaXRvcnk4MDcyOTgwNQ==","name":"exonum","full_name":"exonum/exonum","owner":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exonum/exonum","description":"An extensible open-source framework for creating private/permissioned blockchain applications","fork":false,"url":"https://api.github.com/repos/exonum/exonum","forks_url":"https://api.github.com/repos/exonum/exonum/forks","keys_url":"https://api.github.com/repos/exonum/exonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exonum/exonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exonum/exonum/teams","hooks_url":"https://api.github.com/repos/exonum/exonum/hooks","issue_events_url":"https://api.github.com/repos/exonum/exonum/issues/events{/number}","events_url":"https://api.github.com/repos/exonum/exonum/events","assignees_url":"https://api.github.com/repos/exonum/exonum/assignees{/user}","branches_url":"https://api.github.com/repos/exonum/exonum/branches{/branch}","tags_url":"https://api.github.com/repos/exonum/exonum/tags","blobs_url":"https://api.github.com/repos/exonum/exonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exonum/exonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exonum/exonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/exonum/exonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exonum/exonum/statuses/{sha}","languages_url":"https://api.github.com/repos/exonum/exonum/languages","stargazers_url":"https://api.github.com/repos/exonum/exonum/stargazers","contributors_url":"https://api.github.com/repos/exonum/exonum/contributors","subscribers_url":"https://api.github.com/repos/exonum/exonum/subscribers","subscription_url":"https://api.github.com/repos/exonum/exonum/subscription","commits_url":"https://api.github.com/repos/exonum/exonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/exonum/exonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/exonum/exonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/exonum/exonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/exonum/exonum/contents/{+path}","compare_url":"https://api.github.com/repos/exonum/exonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exonum/exonum/merges","archive_url":"https://api.github.com/repos/exonum/exonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exonum/exonum/downloads","issues_url":"https://api.github.com/repos/exonum/exonum/issues{/number}","pulls_url":"https://api.github.com/repos/exonum/exonum/pulls{/number}","milestones_url":"https://api.github.com/repos/exonum/exonum/milestones{/number}","notifications_url":"https://api.github.com/repos/exonum/exonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exonum/exonum/labels{/name}","releases_url":"https://api.github.com/repos/exonum/exonum/releases{/id}","deployments_url":"https://api.github.com/repos/exonum/exonum/deployments","created_at":"2017-02-02T13:56:57Z","updated_at":"2018-08-07T13:28:17Z","pushed_at":"2018-08-07T16:48:16Z","git_url":"git://github.com/exonum/exonum.git","ssh_url":"git@github.com:exonum/exonum.git","clone_url":"https://github.com/exonum/exonum.git","svn_url":"https://github.com/exonum/exonum","homepage":"https://exonum.com","size":24896,"stargazers_count":679,"watchers_count":679,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":138,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":138,"open_issues":74,"watchers":679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum/pulls/853"},"html":{"href":"https://github.com/exonum/exonum/pull/853"},"issue":{"href":"https://api.github.com/repos/exonum/exonum/issues/853"},"comments":{"href":"https://api.github.com/repos/exonum/exonum/issues/853/comments"},"review_comments":{"href":"https://api.github.com/repos/exonum/exonum/pulls/853/comments"},"review_comment":{"href":"https://api.github.com/repos/exonum/exonum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exonum/exonum/pulls/853/commits"},"statuses":{"href":"https://api.github.com/repos/exonum/exonum/statuses/41e797b1ab263baffd410df2bc292e673bf4a0dc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ilammy"}}