{"push_id":3032687709,"size":26,"distinct_size":26,"ref":"refs/heads/master","head":"2c4231b3769a99af36fdd68d03c1b24468f3f5b2","before":"c044f59726136730178fce742cdb035f137e6664","commits":[{"sha":"88ffdc0ae2011692814026928e918a098652a7a2","author":{"name":"Colin Walters","email":"694ce38231ed622bd1593ce4ec9aa85c9ddb0a78@verbum.org"},"message":"Add `compose rojig` command\n\nThis currently requires a `--i-know-this-is-experimental` flag;\nI know it'd be a bit more consistent to have it under `ex`, but\nwhat feels weird about that is *most* of the `ex` commands people\nuse are client side.  This is where we want it to ultimately end\nup.\n\nWe've landed a lot of prep patches, but I know there's still\na notable amount of code duplication with `compose tree`.  What's\nleft is about ~700 lines but it's mostly not hard/complex code\nanymore.\n\nIn the future, I'd like to extract more of the compose code\nto a `rust/src/compose.rs` or so, but I think this is sustainable\nfow now.\n\nMy high level goal is to get this into coreos-assembler and stand\nup a Silverblue build that uses it.\n\nCloses: #1512\nApproved by: jlebon","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/88ffdc0ae2011692814026928e918a098652a7a2"},{"sha":"ff962491a399f1cbb69fd13d66c03d68f4b15a3a","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"man: Fix references to automatic timer and service\n\nThere is no `rpm-ostreed-automatic` man page, only\n`rpm-ostreed-automatic.service` and `rpm-ostreed-automatic.timer`. Fix\nreferences from the conf man page to those pages.\n\nCloses: #1651\n\nCloses: #1652\nApproved by: miabbott","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/ff962491a399f1cbb69fd13d66c03d68f4b15a3a"},{"sha":"79d4e52d993c9ebd97286191800b6b75c942f4df","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"app: Wrap `Version` in `--version` in quotes\n\nWrap the `Version` key in the YAML-compatible output of\n`rpm-ostree --version` with quotes so that it's parsed as a string. The\nissues with the previous approach in a nutshell:\n\n```\nIn [5]: yaml.load(\"asdf: 2018.10\")\nOut[5]: {'asdf': 2018.1}\n```\n\nIt's treating the version number as a floating-point. Now, this is\ntechnically a backwards incompatible change, but given that the previous\napproach is inherently broken for our needs, I don't see a way around\nbreaking it now.\n\nSee also: https://github.com/ostreedev/ostree/commit/759b099861a3065f01384d4d1121a7726771e5fe\n\nCloses: #1654\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/79d4e52d993c9ebd97286191800b6b75c942f4df"},{"sha":"6d39cfa78fd8c48cfa996374e4d70fa5d9e915af","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"compose: Don't require SELinux policy in legacy path\n\nIn #1630, we lowered SELinux policy loading into the core. However, this\nalso enabled SELinux policy loading from the host system even in the\nlegacy (non-unified) compose path. This meant that compose systems now\nneeded to have the policy installed even though we didn't need it at\nall. This caused regressions in pungi:\n\nhttps://pagure.io/dusty/failed-composes/issue/956\n\nJust make the binding of the \"selinux\" member conditional on whether or\nnot we're in unified mode (which is really when we even care about\nhaving it loaded from the start for pkgcache purposes).\n\nCloses: #1656\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/6d39cfa78fd8c48cfa996374e4d70fa5d9e915af"},{"sha":"46edef001767ded0a93a0d8680f78d0a05b900cc","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"app/compose: Drop helper cachedir_dfd() function\n\nWe don't actually need this helper here since we always initialize\n`self->cachedir_dfd` nowadays. I took a closer look at this initially\nbecause it was confusing ctags due to the function being named the same\nas the struct member it returns.\n\nCloses: #1658\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/46edef001767ded0a93a0d8680f78d0a05b900cc"},{"sha":"37932cf19a14a29ecde124d870b69681bf162625","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"app/compose: Check conflicting opts earlier\n\nNo reason to do this sanity check so late. Let's bring it up to near the\ntop of `impl_install_tree()` so we avoid useless work if possible.\n\nCloses: #1658\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/37932cf19a14a29ecde124d870b69681bf162625"},{"sha":"868bdf167ad67cc983e12905394aab693357f378","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"app/compose: Use g_printerr for note\n\nFor consistency with the other note we print lower down.\n\nCloses: #1658\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/868bdf167ad67cc983e12905394aab693357f378"},{"sha":"38c2ab3397cc2b3c014665ee4c1231f3860aec7e","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"app/compose: Minor comment tweak\n\nThis is slight bikeshed, though this comment took me a second to parse\nbecause it says \"not do it\" right before we do it. Let's just move it up\nto right outside where the condition is actually tested.\n\nCloses: #1658\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/38c2ab3397cc2b3c014665ee4c1231f3860aec7e"},{"sha":"5c4e88da9ccde6ceb29d9fff9e2f857ba6c17153","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"core: use DEVINO_CANONICAL regardless of repo type\n\nIf the policy didn't change, then it's safe to use the devino cache\nregardless of the repo type. This dates from #1123; I think the\nrationale there was so that it only affects the pkglayering path, where\nthe system repo is bare. But really, it should be fine to generalize\nthis since we don't have any xattr callbacks.\n\nCloses: #1658\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/5c4e88da9ccde6ceb29d9fff9e2f857ba6c17153"},{"sha":"8adeb970e3369e012d277d8c5c136f65b2c2fc84","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"postprocess: Rename xattr callback\n\nJust a minor readability tweak. Wasn't clear what `read_xattrs_cb`\nmeant. Also inline an indexing var into the loop.\n\nCloses: #1658\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/8adeb970e3369e012d277d8c5c136f65b2c2fc84"},{"sha":"82ceef78ce20b6333f7d01c923e011a331fd9ec5","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"passwd-util: Drop unnecessary OstreeRepo arg\n\nWe don't actually need the repo in `rpmostree_passwd_compose_prep()`\nsince we're already passed the OstreeRepoFile root of the previous\ncommit as a separate arg.\n\nCloses: #1658\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/82ceef78ce20b6333f7d01c923e011a331fd9ec5"},{"sha":"a2d67f658a908bb2b36601d594a6406b7551675c","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"app/tree: Check upfront if repo is writable\n\nDidn't hit this but this will be useful for a following commit which\ndelays committing to the final repo until the end.\n\nCloses: #1658\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/a2d67f658a908bb2b36601d594a6406b7551675c"},{"sha":"c3be38af7289324a249e26a6fd4397a0828e032c","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"postprocess: Minor glnx_console interaction fixes\n\nMake sure we always pass an integer and not a float to\n`glnx_console_progress_text_percent`. And also make sure we clamp the\nvalue we pass to 100. Not sure how I hit this, somehow the byte counting\nwe do upfront before committing is *less* than the addition of all the\n`g_file_info_get_size()`s?\n\nCloses: #1658\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/c3be38af7289324a249e26a6fd4397a0828e032c"},{"sha":"74db30872bcb2f89fdb879f6a757b1c629e97f47","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"compose: Check for error when opening policy\n\nCloses: #1658\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/74db30872bcb2f89fdb879f6a757b1c629e97f47"},{"sha":"50b255a8a9d6d875178b889bf72638f8cdacd036","author":{"name":"Colin Walters","email":"694ce38231ed622bd1593ce4ec9aa85c9ddb0a78@verbum.org"},"message":"Move varsubst code into Rust, use it in treefile parsing\n\nExternal tools often want to parse the ref; for example coreos-assembler\ncurrently does so.  Let's ensure `${basearch}` is expanded with\n`--print-only` so they can parse that JSON to get the expanded version\nreliably.\n\nImplementation note: this is the first Rust code which exposes a\n\"GLib-like\" C API, notably with GHashTable, so we're making more use\nof the glib-rs bindings.\n\nCloses: #1653\n\nCloses: #1655\nApproved by: jlebon","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/50b255a8a9d6d875178b889bf72638f8cdacd036"},{"sha":"0abfcecd3854ce218857bf1071d365dbd351cd4d","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"compose: Print devino cache hits on commit\n\nRequires: https://github.com/ostreedev/ostree/pull/1772\n\nCloses: #1660\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/0abfcecd3854ce218857bf1071d365dbd351cd4d"},{"sha":"ef587b5c5b3db9b929dfe97872070856aee3c71b","author":{"name":"Colin Walters","email":"694ce38231ed622bd1593ce4ec9aa85c9ddb0a78@verbum.org"},"message":"build-sys: Turn Rust LTO off by default, add --enable-lto flag\n\nFor us, this is primarily right now a size issue.  See:\nhttps://internals.rust-lang.org/t/rust-staticlibs-and-optimizing-for-size/5746\n\nFor more information, there are these two issues:\nhttps://github.com/rust-lang/cargo/issues/4349\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1386371\n\nThe basic issue here is that a build with LTO off (and a trivial\nchange to add a `println!` takes 14s here, and with it on takes 38s.\nHowever, with LTO off the stripped size of `librpmostree_rust.a` is\n`6M`, with LTO on it's `1.1M`.\n\nI named this `--enable-lto` as I'd like to investigate doing this\nfor the C code too.\n\nCloses: #1664\nApproved by: jlebon","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/ef587b5c5b3db9b929dfe97872070856aee3c71b"},{"sha":"55696824df5908cfe95ad9c7d291f38f9ae84fda","author":{"name":"Jonathan Lebon","email":"3692bfa45759a67d83aedf0045f6cb635a966abf@jlebon.com"},"message":"compose: Use previous sepolicy if available\n\nRather than defaulting to the host system's SELinux policy, we can be\nmuch more efficient here if we instead use the policy of the last commit\nif available. Likely, the pkgcache is currently labeled with that\npolicy, which means we skip the relabeling phase before checkout. But\nalso, if the policy didn't change at all in the new rootfs, we also skip\nthe second relabeling phase after assembly.\n\nCloses: #1659\nApproved by: cgwalters","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/55696824df5908cfe95ad9c7d291f38f9ae84fda"},{"sha":"bd4d0d8e0ad90435eca3283eb5153422146f0af4","author":{"name":"Colin Walters","email":"694ce38231ed622bd1593ce4ec9aa85c9ddb0a78@verbum.org"},"message":"build-sys: With external cbindgen, drop Rust lib dependency\n\nPerhaps an unexpected side benefit of slow compilation processes\nis that one has an opportunity to reflect and ponder.\n\nI realized during exactly such a moment that since we moved\n`cbindgen` out of our library build, there's no need to wait\nfor the library to be built before we can start building the C\ncode.\n\nThis is a notable local quality-of-life development improvement.\n\nCloses: #1665\nApproved by: jlebon","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/bd4d0d8e0ad90435eca3283eb5153422146f0af4"},{"sha":"5d9e25653ce4d28e77c01187643cc56eb4b3265c","author":{"name":"Colin Walters","email":"694ce38231ed622bd1593ce4ec9aa85c9ddb0a78@verbum.org"},"message":"libvm: Don't sync rust target/\n\nSince it gets enormous, mine is 1.5GB right now.\n\nCloses: #1665\nApproved by: jlebon","distinct":true,"url":"https://api.github.com/repos/rfairley/rpm-ostree/commits/5d9e25653ce4d28e77c01187643cc56eb4b3265c"}]}
{"actor":{"display_login":"rfairley"}}