{"action":"closed","number":3132,"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3132","id":180496754,"html_url":"https://github.com/codice/ddf/pull/3132","diff_url":"https://github.com/codice/ddf/pull/3132.diff","patch_url":"https://github.com/codice/ddf/pull/3132.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/3132","number":3132,"state":"closed","locked":false,"title":"DDF-3743 Updates dev server to handle ws","user":{"login":"andrewkfiedler","id":11984853,"avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n - The websockets were failing in certain browsers (Firefox, Edge, not Chrome though) when auth wasn't passed.\r\n\r\n#### Who is reviewing it? \r\n@brendan-hofmann\r\n@djblue \r\n@mackncheesiest \r\n@Variadicism \r\n\r\n#### How should this be tested? (List steps with links to updated documentation)\r\nRun the dev server and verify it defaults to admin:admin for the basic auth.  Verify you can also pass your own auth through the auth variable.\r\n\r\n#### Any background context you want to provide?\r\nLooks like this issue was introduced when we upgraded to the latest webpack, so it's possible it's a bug in one of the newer versions of the webpack dev server or the http-proxy-middleware, etc.  Or they've simply updated how they expect it to be used.\r\n\r\n#### What are the relevant tickets?\r\n[DDF-3743](https://codice.atlassian.net/browse/DDF-3743)","created_at":"2018-04-10T05:55:46Z","updated_at":"2018-04-17T16:12:19Z","closed_at":"2018-04-17T16:12:19Z","merged_at":"2018-04-17T16:12:19Z","merge_commit_sha":"057053c889003ccf839afd2d530100d3c4530e4e","assignee":{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars0.githubusercontent.com/u/8660335?v=4","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false},"assignees":[{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars0.githubusercontent.com/u/8660335?v=4","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/3132/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/3132/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3132/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/f90c7adc342c2bad6fa4ff060526f2f3c0c3f55c","head":{"label":"andrewkfiedler:DDF-3743","ref":"DDF-3743","sha":"f90c7adc342c2bad6fa4ff060526f2f3c0c3f55c","user":{"login":"andrewkfiedler","id":11984853,"avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false},"repo":{"id":42733666,"name":"ddf","full_name":"andrewkfiedler/ddf","owner":{"login":"andrewkfiedler","id":11984853,"avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewkfiedler/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/andrewkfiedler/ddf","forks_url":"https://api.github.com/repos/andrewkfiedler/ddf/forks","keys_url":"https://api.github.com/repos/andrewkfiedler/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewkfiedler/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewkfiedler/ddf/teams","hooks_url":"https://api.github.com/repos/andrewkfiedler/ddf/hooks","issue_events_url":"https://api.github.com/repos/andrewkfiedler/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/andrewkfiedler/ddf/events","assignees_url":"https://api.github.com/repos/andrewkfiedler/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/andrewkfiedler/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/andrewkfiedler/ddf/tags","blobs_url":"https://api.github.com/repos/andrewkfiedler/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewkfiedler/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewkfiedler/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewkfiedler/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewkfiedler/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewkfiedler/ddf/languages","stargazers_url":"https://api.github.com/repos/andrewkfiedler/ddf/stargazers","contributors_url":"https://api.github.com/repos/andrewkfiedler/ddf/contributors","subscribers_url":"https://api.github.com/repos/andrewkfiedler/ddf/subscribers","subscription_url":"https://api.github.com/repos/andrewkfiedler/ddf/subscription","commits_url":"https://api.github.com/repos/andrewkfiedler/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewkfiedler/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewkfiedler/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewkfiedler/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewkfiedler/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/andrewkfiedler/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewkfiedler/ddf/merges","archive_url":"https://api.github.com/repos/andrewkfiedler/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewkfiedler/ddf/downloads","issues_url":"https://api.github.com/repos/andrewkfiedler/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/andrewkfiedler/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewkfiedler/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewkfiedler/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewkfiedler/ddf/labels{/name}","releases_url":"https://api.github.com/repos/andrewkfiedler/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/andrewkfiedler/ddf/deployments","created_at":"2015-09-18T16:26:26Z","updated_at":"2016-01-28T22:55:37Z","pushed_at":"2018-04-12T00:29:22Z","git_url":"git://github.com/andrewkfiedler/ddf.git","ssh_url":"git@github.com:andrewkfiedler/ddf.git","clone_url":"https://github.com/andrewkfiedler/ddf.git","svn_url":"https://github.com/andrewkfiedler/ddf","homepage":"","size":200333,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"8f9c2f77a78143292008f136cafd41e6678cc7f7","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-04-17T13:57:14Z","pushed_at":"2018-04-17T16:12:19Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":389311,"stargazers_count":79,"watchers_count":79,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":135,"open_issues":41,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/3132"},"html":{"href":"https://github.com/codice/ddf/pull/3132"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/3132"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/3132/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/3132/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/3132/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/f90c7adc342c2bad6fa4ff060526f2f3c0c3f55c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars0.githubusercontent.com/u/8660335?v=4","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false},"comments":7,"review_comments":10,"maintainer_can_modify":false,"commits":1,"additions":18,"deletions":11,"changed_files":5}}
{"actor":{"display_login":"brendan-hofmann"}}