{"action":"opened","number":3864,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/3864","id":235411785,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDExNzg1","html_url":"https://github.com/dcos/dcos/pull/3864","diff_url":"https://github.com/dcos/dcos/pull/3864.diff","patch_url":"https://github.com/dcos/dcos/pull/3864.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/3864","number":3864,"state":"open","locked":false,"title":"packages/cockroach: fix minor issues in iam-database-restore","user":{"login":"mhrabovcin","id":81354,"node_id":"MDQ6VXNlcjgxMzU0","avatar_url":"https://avatars2.githubusercontent.com/u/81354?v=4","gravatar_id":"","url":"https://api.github.com/users/mhrabovcin","html_url":"https://github.com/mhrabovcin","followers_url":"https://api.github.com/users/mhrabovcin/followers","following_url":"https://api.github.com/users/mhrabovcin/following{/other_user}","gists_url":"https://api.github.com/users/mhrabovcin/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrabovcin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrabovcin/subscriptions","organizations_url":"https://api.github.com/users/mhrabovcin/orgs","repos_url":"https://api.github.com/users/mhrabovcin/repos","events_url":"https://api.github.com/users/mhrabovcin/events{/privacy}","received_events_url":"https://api.github.com/users/mhrabovcin/received_events","type":"User","site_admin":false},"body":"## High-level description\r\n\r\nThe `iam-database-restore` script was not deleting old database after the restore.\r\n\r\n## Corresponding DC/OS tickets (obligatory)\r\n\r\nThese DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:\r\n\r\n  - [DCOS-42407](https://jira.mesosphere.com/browse/DCOS-42407) test-e2e: TestIAMBackupRestore.test_backup_restore failed\r\n\r\n\r\n## Checklist for all PRs\r\n\r\n  - [x] Added a comprehensible changelog entry to `CHANGES.md` or explain why this is not a user-facing change:\r\n  - [ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n  - [ ] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n  - [ ] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)","created_at":"2018-12-03T11:23:00Z","updated_at":"2018-12-03T11:23:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/3864/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/3864/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/3864/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/74f3972d59ec310a65583d426408ef78d61dfd50","head":{"label":"mhrabovcin:mh/iam-restore-fixes","ref":"mh/iam-restore-fixes","sha":"74f3972d59ec310a65583d426408ef78d61dfd50","user":{"login":"mhrabovcin","id":81354,"node_id":"MDQ6VXNlcjgxMzU0","avatar_url":"https://avatars2.githubusercontent.com/u/81354?v=4","gravatar_id":"","url":"https://api.github.com/users/mhrabovcin","html_url":"https://github.com/mhrabovcin","followers_url":"https://api.github.com/users/mhrabovcin/followers","following_url":"https://api.github.com/users/mhrabovcin/following{/other_user}","gists_url":"https://api.github.com/users/mhrabovcin/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrabovcin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrabovcin/subscriptions","organizations_url":"https://api.github.com/users/mhrabovcin/orgs","repos_url":"https://api.github.com/users/mhrabovcin/repos","events_url":"https://api.github.com/users/mhrabovcin/events{/privacy}","received_events_url":"https://api.github.com/users/mhrabovcin/received_events","type":"User","site_admin":false},"repo":{"id":80647635,"node_id":"MDEwOlJlcG9zaXRvcnk4MDY0NzYzNQ==","name":"dcos","full_name":"mhrabovcin/dcos","private":false,"owner":{"login":"mhrabovcin","id":81354,"node_id":"MDQ6VXNlcjgxMzU0","avatar_url":"https://avatars2.githubusercontent.com/u/81354?v=4","gravatar_id":"","url":"https://api.github.com/users/mhrabovcin","html_url":"https://github.com/mhrabovcin","followers_url":"https://api.github.com/users/mhrabovcin/followers","following_url":"https://api.github.com/users/mhrabovcin/following{/other_user}","gists_url":"https://api.github.com/users/mhrabovcin/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrabovcin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrabovcin/subscriptions","organizations_url":"https://api.github.com/users/mhrabovcin/orgs","repos_url":"https://api.github.com/users/mhrabovcin/repos","events_url":"https://api.github.com/users/mhrabovcin/events{/privacy}","received_events_url":"https://api.github.com/users/mhrabovcin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mhrabovcin/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/mhrabovcin/dcos","forks_url":"https://api.github.com/repos/mhrabovcin/dcos/forks","keys_url":"https://api.github.com/repos/mhrabovcin/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhrabovcin/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhrabovcin/dcos/teams","hooks_url":"https://api.github.com/repos/mhrabovcin/dcos/hooks","issue_events_url":"https://api.github.com/repos/mhrabovcin/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/mhrabovcin/dcos/events","assignees_url":"https://api.github.com/repos/mhrabovcin/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/mhrabovcin/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/mhrabovcin/dcos/tags","blobs_url":"https://api.github.com/repos/mhrabovcin/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhrabovcin/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhrabovcin/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhrabovcin/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhrabovcin/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/mhrabovcin/dcos/languages","stargazers_url":"https://api.github.com/repos/mhrabovcin/dcos/stargazers","contributors_url":"https://api.github.com/repos/mhrabovcin/dcos/contributors","subscribers_url":"https://api.github.com/repos/mhrabovcin/dcos/subscribers","subscription_url":"https://api.github.com/repos/mhrabovcin/dcos/subscription","commits_url":"https://api.github.com/repos/mhrabovcin/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhrabovcin/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhrabovcin/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhrabovcin/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhrabovcin/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/mhrabovcin/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhrabovcin/dcos/merges","archive_url":"https://api.github.com/repos/mhrabovcin/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhrabovcin/dcos/downloads","issues_url":"https://api.github.com/repos/mhrabovcin/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/mhrabovcin/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/mhrabovcin/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/mhrabovcin/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhrabovcin/dcos/labels{/name}","releases_url":"https://api.github.com/repos/mhrabovcin/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/mhrabovcin/dcos/deployments","created_at":"2017-02-01T17:59:30Z","updated_at":"2017-02-01T17:59:33Z","pushed_at":"2018-12-03T11:21:35Z","git_url":"git://github.com/mhrabovcin/dcos.git","ssh_url":"git@github.com:mhrabovcin/dcos.git","clone_url":"https://github.com/mhrabovcin/dcos.git","svn_url":"https://github.com/mhrabovcin/dcos","homepage":"https://dcos.io","size":6559,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"c955b0cb9e40b2355c23832814adadf2cc25c6d1","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"node_id":"MDEwOlJlcG9zaXRvcnk1NjE4NDA1MA==","name":"dcos","full_name":"dcos/dcos","private":false,"owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dcos/dcos","description":"DC/OS - The Datacenter Operating System ","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2018-12-03T01:58:34Z","pushed_at":"2018-12-03T11:21:52Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":7748,"stargazers_count":2077,"watchers_count":2077,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":435,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":435,"open_issues":125,"watchers":2077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3864"},"html":{"href":"https://github.com/dcos/dcos/pull/3864"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/3864"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/3864/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3864/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3864/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/74f3972d59ec310a65583d426408ef78d61dfd50"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":10,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"mhrabovcin"}}