{"action":"created","comment":{"url":"https://api.github.com/repos/libp2p/specs/pulls/comments/244560459","pull_request_review_id":188467988,"id":244560459,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU2MDQ1OQ==","diff_hunk":"@@ -92,14 +90,23 @@ the peer won't be able to send identical messages (e.g. keepalives) within the\n timecache interval, as they will get rejected as duplicates.\"\n \n The `topicIDs` field specifies a set of topics that this message is being\n-published to. To prevent the size of this field from growing indefinitely,\n-it is suggested that that the application using an implementation of this\n-library spec should have some kind of storage economics (see e.g.\n-[here](https://ethresear.ch/t/draft-position-paper-on-resource-pricing/2838).\n+published to.\n \n Note that messages are currently *not* signed. This will come in the near\n future.\n \n+The size of the `Message` should be limited, say to 1 MiB, but could also\n+be configurable, for more information see \n+[issue 118](https://github.com/libp2p/specs/issues/118), while messages should be\n+rejected if they are over this size (this isn't done as of Dec 2018).","path":"pubsub/README.md","position":7,"original_position":27,"commit_id":"b3c1ced124c89fb2245f6d0e6bccef88f01fa914","original_commit_id":"b3c1ced124c89fb2245f6d0e6bccef88f01fa914","user":{"login":"vyzo","id":36426,"node_id":"MDQ6VXNlcjM2NDI2","avatar_url":"https://avatars0.githubusercontent.com/u/36426?v=4","gravatar_id":"","url":"https://api.github.com/users/vyzo","html_url":"https://github.com/vyzo","followers_url":"https://api.github.com/users/vyzo/followers","following_url":"https://api.github.com/users/vyzo/following{/other_user}","gists_url":"https://api.github.com/users/vyzo/gists{/gist_id}","starred_url":"https://api.github.com/users/vyzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vyzo/subscriptions","organizations_url":"https://api.github.com/users/vyzo/orgs","repos_url":"https://api.github.com/users/vyzo/repos","events_url":"https://api.github.com/users/vyzo/events{/privacy}","received_events_url":"https://api.github.com/users/vyzo/received_events","type":"User","site_admin":false},"body":"this is incorrect, messages over 1MB _are_ rejected, by virtue of a read error and closing the stream.","created_at":"2018-12-31T07:47:42Z","updated_at":"2018-12-31T07:47:55Z","html_url":"https://github.com/libp2p/specs/pull/119#discussion_r244560459","pull_request_url":"https://api.github.com/repos/libp2p/specs/pulls/119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/libp2p/specs/pulls/comments/244560459"},"html":{"href":"https://github.com/libp2p/specs/pull/119#discussion_r244560459"},"pull_request":{"href":"https://api.github.com/repos/libp2p/specs/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/libp2p/specs/pulls/119","id":241396380,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzk2Mzgw","html_url":"https://github.com/libp2p/specs/pull/119","diff_url":"https://github.com/libp2p/specs/pull/119.diff","patch_url":"https://github.com/libp2p/specs/pull/119.patch","issue_url":"https://api.github.com/repos/libp2p/specs/issues/119","number":119,"state":"open","locked":false,"title":"Add info about limiting the size of the data and topicIDs fields.","user":{"login":"jamesray1","id":16969914,"node_id":"MDQ6VXNlcjE2OTY5OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/16969914?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesray1","html_url":"https://github.com/jamesray1","followers_url":"https://api.github.com/users/jamesray1/followers","following_url":"https://api.github.com/users/jamesray1/following{/other_user}","gists_url":"https://api.github.com/users/jamesray1/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesray1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesray1/subscriptions","organizations_url":"https://api.github.com/users/jamesray1/orgs","repos_url":"https://api.github.com/users/jamesray1/repos","events_url":"https://api.github.com/users/jamesray1/events{/privacy}","received_events_url":"https://api.github.com/users/jamesray1/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-28T21:07:40Z","updated_at":"2018-12-31T07:47:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9be6818e7377070f2c9d2e0ba8ade3b398328e8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libp2p/specs/pulls/119/commits","review_comments_url":"https://api.github.com/repos/libp2p/specs/pulls/119/comments","review_comment_url":"https://api.github.com/repos/libp2p/specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libp2p/specs/issues/119/comments","statuses_url":"https://api.github.com/repos/libp2p/specs/statuses/b3c1ced124c89fb2245f6d0e6bccef88f01fa914","head":{"label":"jamesray1:patch-30","ref":"patch-30","sha":"b3c1ced124c89fb2245f6d0e6bccef88f01fa914","user":{"login":"jamesray1","id":16969914,"node_id":"MDQ6VXNlcjE2OTY5OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/16969914?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesray1","html_url":"https://github.com/jamesray1","followers_url":"https://api.github.com/users/jamesray1/followers","following_url":"https://api.github.com/users/jamesray1/following{/other_user}","gists_url":"https://api.github.com/users/jamesray1/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesray1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesray1/subscriptions","organizations_url":"https://api.github.com/users/jamesray1/orgs","repos_url":"https://api.github.com/users/jamesray1/repos","events_url":"https://api.github.com/users/jamesray1/events{/privacy}","received_events_url":"https://api.github.com/users/jamesray1/received_events","type":"User","site_admin":false},"repo":{"id":132847806,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI4NDc4MDY=","name":"specs","full_name":"jamesray1/specs","private":false,"owner":{"login":"jamesray1","id":16969914,"node_id":"MDQ6VXNlcjE2OTY5OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/16969914?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesray1","html_url":"https://github.com/jamesray1","followers_url":"https://api.github.com/users/jamesray1/followers","following_url":"https://api.github.com/users/jamesray1/following{/other_user}","gists_url":"https://api.github.com/users/jamesray1/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesray1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesray1/subscriptions","organizations_url":"https://api.github.com/users/jamesray1/orgs","repos_url":"https://api.github.com/users/jamesray1/repos","events_url":"https://api.github.com/users/jamesray1/events{/privacy}","received_events_url":"https://api.github.com/users/jamesray1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jamesray1/specs","description":"Technical specifications for the libp2p networking stack","fork":true,"url":"https://api.github.com/repos/jamesray1/specs","forks_url":"https://api.github.com/repos/jamesray1/specs/forks","keys_url":"https://api.github.com/repos/jamesray1/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamesray1/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamesray1/specs/teams","hooks_url":"https://api.github.com/repos/jamesray1/specs/hooks","issue_events_url":"https://api.github.com/repos/jamesray1/specs/issues/events{/number}","events_url":"https://api.github.com/repos/jamesray1/specs/events","assignees_url":"https://api.github.com/repos/jamesray1/specs/assignees{/user}","branches_url":"https://api.github.com/repos/jamesray1/specs/branches{/branch}","tags_url":"https://api.github.com/repos/jamesray1/specs/tags","blobs_url":"https://api.github.com/repos/jamesray1/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamesray1/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamesray1/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamesray1/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamesray1/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/jamesray1/specs/languages","stargazers_url":"https://api.github.com/repos/jamesray1/specs/stargazers","contributors_url":"https://api.github.com/repos/jamesray1/specs/contributors","subscribers_url":"https://api.github.com/repos/jamesray1/specs/subscribers","subscription_url":"https://api.github.com/repos/jamesray1/specs/subscription","commits_url":"https://api.github.com/repos/jamesray1/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamesray1/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamesray1/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamesray1/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamesray1/specs/contents/{+path}","compare_url":"https://api.github.com/repos/jamesray1/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamesray1/specs/merges","archive_url":"https://api.github.com/repos/jamesray1/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamesray1/specs/downloads","issues_url":"https://api.github.com/repos/jamesray1/specs/issues{/number}","pulls_url":"https://api.github.com/repos/jamesray1/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/jamesray1/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/jamesray1/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamesray1/specs/labels{/name}","releases_url":"https://api.github.com/repos/jamesray1/specs/releases{/id}","deployments_url":"https://api.github.com/repos/jamesray1/specs/deployments","created_at":"2018-05-10T04:18:17Z","updated_at":"2018-05-10T04:18:19Z","pushed_at":"2018-12-31T02:47:13Z","git_url":"git://github.com/jamesray1/specs.git","ssh_url":"git@github.com:jamesray1/specs.git","clone_url":"https://github.com/jamesray1/specs.git","svn_url":"https://github.com/jamesray1/specs","homepage":"https://libp2p.io","size":274,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libp2p:master","ref":"master","sha":"6222a9ef9a3ff74bbc2935db7ef6c2cb7ac362ae","user":{"login":"libp2p","id":14838238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM4MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/14838238?v=4","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":68122771,"node_id":"MDEwOlJlcG9zaXRvcnk2ODEyMjc3MQ==","name":"specs","full_name":"libp2p/specs","private":false,"owner":{"login":"libp2p","id":14838238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM4MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/14838238?v=4","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libp2p/specs","description":"Technical specifications for the libp2p networking stack","fork":false,"url":"https://api.github.com/repos/libp2p/specs","forks_url":"https://api.github.com/repos/libp2p/specs/forks","keys_url":"https://api.github.com/repos/libp2p/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/specs/teams","hooks_url":"https://api.github.com/repos/libp2p/specs/hooks","issue_events_url":"https://api.github.com/repos/libp2p/specs/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/specs/events","assignees_url":"https://api.github.com/repos/libp2p/specs/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/specs/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/specs/tags","blobs_url":"https://api.github.com/repos/libp2p/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/specs/languages","stargazers_url":"https://api.github.com/repos/libp2p/specs/stargazers","contributors_url":"https://api.github.com/repos/libp2p/specs/contributors","subscribers_url":"https://api.github.com/repos/libp2p/specs/subscribers","subscription_url":"https://api.github.com/repos/libp2p/specs/subscription","commits_url":"https://api.github.com/repos/libp2p/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/specs/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/specs/merges","archive_url":"https://api.github.com/repos/libp2p/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/specs/downloads","issues_url":"https://api.github.com/repos/libp2p/specs/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/specs/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/specs/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/specs/deployments","created_at":"2016-09-13T15:45:30Z","updated_at":"2018-12-29T16:08:50Z","pushed_at":"2018-12-31T02:47:14Z","git_url":"git://github.com/libp2p/specs.git","ssh_url":"git@github.com:libp2p/specs.git","clone_url":"https://github.com/libp2p/specs.git","svn_url":"https://github.com/libp2p/specs","homepage":"https://libp2p.io","size":287,"stargazers_count":496,"watchers_count":496,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":41,"license":null,"forks":81,"open_issues":41,"watchers":496,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libp2p/specs/pulls/119"},"html":{"href":"https://github.com/libp2p/specs/pull/119"},"issue":{"href":"https://api.github.com/repos/libp2p/specs/issues/119"},"comments":{"href":"https://api.github.com/repos/libp2p/specs/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/libp2p/specs/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/libp2p/specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libp2p/specs/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/libp2p/specs/statuses/b3c1ced124c89fb2245f6d0e6bccef88f01fa914"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vyzo"}}