{"action":"created","issue":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/2558","repository_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode","labels_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/2558/labels{/name}","comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/2558/comments","events_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/2558/events","html_url":"https://github.com/OmniSharp/omnisharp-vscode/pull/2558","id":364388176,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NTg2NjQx","number":2558,"title":"If the config looks functional return it, otherwise force VSCode to open config file","user":{"login":"isidorn","id":1926584,"node_id":"MDQ6VXNlcjE5MjY1ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1926584?v=4","gravatar_id":"","url":"https://api.github.com/users/isidorn","html_url":"https://github.com/isidorn","followers_url":"https://api.github.com/users/isidorn/followers","following_url":"https://api.github.com/users/isidorn/following{/other_user}","gists_url":"https://api.github.com/users/isidorn/gists{/gist_id}","starred_url":"https://api.github.com/users/isidorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidorn/subscriptions","organizations_url":"https://api.github.com/users/isidorn/orgs","repos_url":"https://api.github.com/users/isidorn/repos","events_url":"https://api.github.com/users/isidorn/events{/privacy}","received_events_url":"https://api.github.com/users/isidorn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-27T09:39:57Z","updated_at":"2018-09-27T09:44:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/pulls/2558","html_url":"https://github.com/OmniSharp/omnisharp-vscode/pull/2558","diff_url":"https://github.com/OmniSharp/omnisharp-vscode/pull/2558.diff","patch_url":"https://github.com/OmniSharp/omnisharp-vscode/pull/2558.patch"},"body":"Hi VSCode dev here,\r\n\r\nVSCode changed the functionality when to automatically open a launch.json file.\r\nPreviosuly if the return configuraiton would not have a `.type` field we would automatically open it, however we decided that the extensions must explictly request this by returning `null`. More details about the change and the motivation behind it can be found here\r\nhttps://github.com/Microsoft/vscode/issues/54213\r\n\r\nIt would be great if we could merge this as soon as possible since it creates a regression, more details about it here https://github.com/Microsoft/vscode/issues/59487\r\n\r\nfyi @gregg-miskelly @DustinCampbell @akshita31 \r\nsorry for pinging everyone"},"comment":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/comments/425028191","html_url":"https://github.com/OmniSharp/omnisharp-vscode/pull/2558#issuecomment-425028191","issue_url":"https://api.github.com/repos/OmniSharp/omnisharp-vscode/issues/2558","id":425028191,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTAyODE5MQ==","user":{"login":"isidorn","id":1926584,"node_id":"MDQ6VXNlcjE5MjY1ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1926584?v=4","gravatar_id":"","url":"https://api.github.com/users/isidorn","html_url":"https://github.com/isidorn","followers_url":"https://api.github.com/users/isidorn/followers","following_url":"https://api.github.com/users/isidorn/following{/other_user}","gists_url":"https://api.github.com/users/isidorn/gists{/gist_id}","starred_url":"https://api.github.com/users/isidorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidorn/subscriptions","organizations_url":"https://api.github.com/users/isidorn/orgs","repos_url":"https://api.github.com/users/isidorn/repos","events_url":"https://api.github.com/users/isidorn/events{/privacy}","received_events_url":"https://api.github.com/users/isidorn/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T09:44:02Z","updated_at":"2018-09-27T09:44:02Z","author_association":"NONE","body":"Also this PR will not break the existing vscode stable. \r\nThe next vscode stable will be released in a week and ideally we could merge this before than. If that is not an option please let me know."}}
{"actor":{"display_login":"isidorn"}}