{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/ecliptic/bucklescript-tools/pulls/2","id":162870533,"html_url":"https://github.com/ecliptic/bucklescript-tools/pull/2","diff_url":"https://github.com/ecliptic/bucklescript-tools/pull/2.diff","patch_url":"https://github.com/ecliptic/bucklescript-tools/pull/2.patch","issue_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/issues/2","number":2,"state":"closed","locked":false,"title":"Correct type of connection for makeStringConnection","user":{"login":"joefiorini","id":3648,"avatar_url":"https://avatars3.githubusercontent.com/u/3648?v=4","gravatar_id":"","url":"https://api.github.com/users/joefiorini","html_url":"https://github.com/joefiorini","followers_url":"https://api.github.com/users/joefiorini/followers","following_url":"https://api.github.com/users/joefiorini/following{/other_user}","gists_url":"https://api.github.com/users/joefiorini/gists{/gist_id}","starred_url":"https://api.github.com/users/joefiorini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joefiorini/subscriptions","organizations_url":"https://api.github.com/users/joefiorini/orgs","repos_url":"https://api.github.com/users/joefiorini/repos","events_url":"https://api.github.com/users/joefiorini/events{/privacy}","received_events_url":"https://api.github.com/users/joefiorini/received_events","type":"User","site_admin":false},"body":"I was looking for a way to pass `Sys.getenv(\"DATABASE_URL\")` for `connection` like you can in the node knex. It appears that is not currently possible. However, based on the name `makeStringConnection`, I'm assuming `~connection` is supposed to be a string not a `Connection`? The way it's currently written there doesn't appear to be a difference between `make` and `makeStringConnection`. Is this correct? Also, n.b. I didn't test this or anything, just made the change and opened the PR. Not sure what I'd test against anyway ;).","created_at":"2018-01-15T05:14:47Z","updated_at":"2018-05-19T16:00:04Z","closed_at":"2018-05-19T16:00:03Z","merged_at":"2018-05-19T16:00:03Z","merge_commit_sha":"cf8798c6c43d113f4ab6859089f435d7e011c93d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/issues/2/comments","statuses_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/statuses/2b7a408c4ad2b6dd78dc75538a03e249c0ccad50","head":{"label":"joefiorini:patch-1","ref":"patch-1","sha":"2b7a408c4ad2b6dd78dc75538a03e249c0ccad50","user":{"login":"joefiorini","id":3648,"avatar_url":"https://avatars3.githubusercontent.com/u/3648?v=4","gravatar_id":"","url":"https://api.github.com/users/joefiorini","html_url":"https://github.com/joefiorini","followers_url":"https://api.github.com/users/joefiorini/followers","following_url":"https://api.github.com/users/joefiorini/following{/other_user}","gists_url":"https://api.github.com/users/joefiorini/gists{/gist_id}","starred_url":"https://api.github.com/users/joefiorini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joefiorini/subscriptions","organizations_url":"https://api.github.com/users/joefiorini/orgs","repos_url":"https://api.github.com/users/joefiorini/repos","events_url":"https://api.github.com/users/joefiorini/events{/privacy}","received_events_url":"https://api.github.com/users/joefiorini/received_events","type":"User","site_admin":false},"repo":{"id":117499956,"name":"bucklescript-tools","full_name":"joefiorini/bucklescript-tools","owner":{"login":"joefiorini","id":3648,"avatar_url":"https://avatars3.githubusercontent.com/u/3648?v=4","gravatar_id":"","url":"https://api.github.com/users/joefiorini","html_url":"https://github.com/joefiorini","followers_url":"https://api.github.com/users/joefiorini/followers","following_url":"https://api.github.com/users/joefiorini/following{/other_user}","gists_url":"https://api.github.com/users/joefiorini/gists{/gist_id}","starred_url":"https://api.github.com/users/joefiorini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joefiorini/subscriptions","organizations_url":"https://api.github.com/users/joefiorini/orgs","repos_url":"https://api.github.com/users/joefiorini/repos","events_url":"https://api.github.com/users/joefiorini/events{/privacy}","received_events_url":"https://api.github.com/users/joefiorini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joefiorini/bucklescript-tools","description":"Various tools for working within the BuckleScript ecosystem","fork":true,"url":"https://api.github.com/repos/joefiorini/bucklescript-tools","forks_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/forks","keys_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/teams","hooks_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/hooks","issue_events_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/issues/events{/number}","events_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/events","assignees_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/assignees{/user}","branches_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/branches{/branch}","tags_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/tags","blobs_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/languages","stargazers_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/stargazers","contributors_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/contributors","subscribers_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/subscribers","subscription_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/subscription","commits_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/contents/{+path}","compare_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/merges","archive_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/downloads","issues_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/issues{/number}","pulls_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/labels{/name}","releases_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/releases{/id}","deployments_url":"https://api.github.com/repos/joefiorini/bucklescript-tools/deployments","created_at":"2018-01-15T05:12:08Z","updated_at":"2018-01-15T05:12:11Z","pushed_at":"2018-01-15T05:12:37Z","git_url":"git://github.com/joefiorini/bucklescript-tools.git","ssh_url":"git@github.com:joefiorini/bucklescript-tools.git","clone_url":"https://github.com/joefiorini/bucklescript-tools.git","svn_url":"https://github.com/joefiorini/bucklescript-tools","homepage":null,"size":203,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ecliptic:develop","ref":"develop","sha":"001be6dc66130bdb66ac5b4eb1e5b305f9dfc34d","user":{"login":"ecliptic","id":14880228,"avatar_url":"https://avatars2.githubusercontent.com/u/14880228?v=4","gravatar_id":"","url":"https://api.github.com/users/ecliptic","html_url":"https://github.com/ecliptic","followers_url":"https://api.github.com/users/ecliptic/followers","following_url":"https://api.github.com/users/ecliptic/following{/other_user}","gists_url":"https://api.github.com/users/ecliptic/gists{/gist_id}","starred_url":"https://api.github.com/users/ecliptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecliptic/subscriptions","organizations_url":"https://api.github.com/users/ecliptic/orgs","repos_url":"https://api.github.com/users/ecliptic/repos","events_url":"https://api.github.com/users/ecliptic/events{/privacy}","received_events_url":"https://api.github.com/users/ecliptic/received_events","type":"Organization","site_admin":false},"repo":{"id":114570712,"name":"bucklescript-tools","full_name":"ecliptic/bucklescript-tools","owner":{"login":"ecliptic","id":14880228,"avatar_url":"https://avatars2.githubusercontent.com/u/14880228?v=4","gravatar_id":"","url":"https://api.github.com/users/ecliptic","html_url":"https://github.com/ecliptic","followers_url":"https://api.github.com/users/ecliptic/followers","following_url":"https://api.github.com/users/ecliptic/following{/other_user}","gists_url":"https://api.github.com/users/ecliptic/gists{/gist_id}","starred_url":"https://api.github.com/users/ecliptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecliptic/subscriptions","organizations_url":"https://api.github.com/users/ecliptic/orgs","repos_url":"https://api.github.com/users/ecliptic/repos","events_url":"https://api.github.com/users/ecliptic/events{/privacy}","received_events_url":"https://api.github.com/users/ecliptic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ecliptic/bucklescript-tools","description":"Various tools for working within the BuckleScript ecosystem","fork":false,"url":"https://api.github.com/repos/ecliptic/bucklescript-tools","forks_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/forks","keys_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/teams","hooks_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/hooks","issue_events_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/issues/events{/number}","events_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/events","assignees_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/assignees{/user}","branches_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/branches{/branch}","tags_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/tags","blobs_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/languages","stargazers_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/stargazers","contributors_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/contributors","subscribers_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/subscribers","subscription_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/subscription","commits_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/contents/{+path}","compare_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/merges","archive_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/downloads","issues_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/issues{/number}","pulls_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/labels{/name}","releases_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/releases{/id}","deployments_url":"https://api.github.com/repos/ecliptic/bucklescript-tools/deployments","created_at":"2017-12-17T21:41:24Z","updated_at":"2018-03-22T20:19:28Z","pushed_at":"2018-05-19T16:00:03Z","git_url":"git://github.com/ecliptic/bucklescript-tools.git","ssh_url":"git@github.com:ecliptic/bucklescript-tools.git","clone_url":"https://github.com/ecliptic/bucklescript-tools.git","svn_url":"https://github.com/ecliptic/bucklescript-tools","homepage":null,"size":117,"stargazers_count":14,"watchers_count":14,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":5,"open_issues":4,"watchers":14,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ecliptic/bucklescript-tools/pulls/2"},"html":{"href":"https://github.com/ecliptic/bucklescript-tools/pull/2"},"issue":{"href":"https://api.github.com/repos/ecliptic/bucklescript-tools/issues/2"},"comments":{"href":"https://api.github.com/repos/ecliptic/bucklescript-tools/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ecliptic/bucklescript-tools/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ecliptic/bucklescript-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ecliptic/bucklescript-tools/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ecliptic/bucklescript-tools/statuses/2b7a408c4ad2b6dd78dc75538a03e249c0ccad50"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bkonkle","id":30199,"avatar_url":"https://avatars2.githubusercontent.com/u/30199?v=4","gravatar_id":"","url":"https://api.github.com/users/bkonkle","html_url":"https://github.com/bkonkle","followers_url":"https://api.github.com/users/bkonkle/followers","following_url":"https://api.github.com/users/bkonkle/following{/other_user}","gists_url":"https://api.github.com/users/bkonkle/gists{/gist_id}","starred_url":"https://api.github.com/users/bkonkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkonkle/subscriptions","organizations_url":"https://api.github.com/users/bkonkle/orgs","repos_url":"https://api.github.com/users/bkonkle/repos","events_url":"https://api.github.com/users/bkonkle/events{/privacy}","received_events_url":"https://api.github.com/users/bkonkle/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"bkonkle"}}