{"action":"opened","number":2770,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/2770","id":230640859,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjQwODU5","html_url":"https://github.com/ripple/rippled/pull/2770","diff_url":"https://github.com/ripple/rippled/pull/2770.diff","patch_url":"https://github.com/ripple/rippled/pull/2770.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/2770","number":2770,"state":"open","locked":false,"title":" Use Json::StaticString for field names and Refactor SField construction","user":{"login":"ximinez","id":6757714,"node_id":"MDQ6VXNlcjY3NTc3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6757714?v=4","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"The first commit from @JoelKatz was causing problems in some environments due to the `SField` move constructor. With help from @seelabs, @jwbusch, @nbougalis, and @mellery451, I was able to refactor the `SField` construction to completely remove the move constructor.","created_at":"2018-11-13T22:03:35Z","updated_at":"2018-11-13T22:03:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"nbougalis","id":5085415,"node_id":"MDQ6VXNlcjUwODU0MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5085415?v=4","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nbougalis","id":5085415,"node_id":"MDQ6VXNlcjUwODU0MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5085415?v=4","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},{"login":"HowardHinnant","id":6708789,"node_id":"MDQ6VXNlcjY3MDg3ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6708789?v=4","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/2770/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/2770/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/2770/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/467ba67d0236a587288ee41586fb0fc07c6873f5","head":{"label":"ximinez:make-sfield","ref":"make-sfield","sha":"467ba67d0236a587288ee41586fb0fc07c6873f5","user":{"login":"ximinez","id":6757714,"node_id":"MDQ6VXNlcjY3NTc3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6757714?v=4","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"repo":{"id":17236735,"node_id":"MDEwOlJlcG9zaXRvcnkxNzIzNjczNQ==","name":"rippled","full_name":"ximinez/rippled","private":false,"owner":{"login":"ximinez","id":6757714,"node_id":"MDQ6VXNlcjY3NTc3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6757714?v=4","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ximinez/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/ximinez/rippled","forks_url":"https://api.github.com/repos/ximinez/rippled/forks","keys_url":"https://api.github.com/repos/ximinez/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ximinez/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ximinez/rippled/teams","hooks_url":"https://api.github.com/repos/ximinez/rippled/hooks","issue_events_url":"https://api.github.com/repos/ximinez/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ximinez/rippled/events","assignees_url":"https://api.github.com/repos/ximinez/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ximinez/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ximinez/rippled/tags","blobs_url":"https://api.github.com/repos/ximinez/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ximinez/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ximinez/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ximinez/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ximinez/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ximinez/rippled/languages","stargazers_url":"https://api.github.com/repos/ximinez/rippled/stargazers","contributors_url":"https://api.github.com/repos/ximinez/rippled/contributors","subscribers_url":"https://api.github.com/repos/ximinez/rippled/subscribers","subscription_url":"https://api.github.com/repos/ximinez/rippled/subscription","commits_url":"https://api.github.com/repos/ximinez/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ximinez/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ximinez/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ximinez/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ximinez/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ximinez/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ximinez/rippled/merges","archive_url":"https://api.github.com/repos/ximinez/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ximinez/rippled/downloads","issues_url":"https://api.github.com/repos/ximinez/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ximinez/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ximinez/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ximinez/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ximinez/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ximinez/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ximinez/rippled/deployments","created_at":"2014-02-27T04:33:56Z","updated_at":"2018-11-12T14:50:24Z","pushed_at":"2018-11-13T21:28:03Z","git_url":"git://github.com/ximinez/rippled.git","ssh_url":"git@github.com:ximinez/rippled.git","clone_url":"https://github.com/ximinez/rippled.git","svn_url":"https://github.com/ximinez/rippled","homepage":"https://ripple.com","size":95044,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"cc824685e7e13ba857374d96e29e2abafbef36da","user":{"login":"ripple","id":3165523,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjU1MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"node_id":"MDEwOlJlcG9zaXRvcnkyNzI0MTY3","name":"rippled","full_name":"ripple/rippled","private":false,"owner":{"login":"ripple","id":3165523,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjU1MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ripple/rippled","description":"Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger in C++","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2018-11-13T18:45:30Z","pushed_at":"2018-11-13T17:08:02Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com/xrp","size":94965,"stargazers_count":3029,"watchers_count":3029,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":913,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":913,"open_issues":81,"watchers":3029,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2770"},"html":{"href":"https://github.com/ripple/rippled/pull/2770"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/2770"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/2770/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2770/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2770/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/467ba67d0236a587288ee41586fb0fc07c6873f5"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":218,"deletions":239,"changed_files":4}}
{"actor":{"display_login":"ximinez"}}