{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3616","repository_url":"https://api.github.com/repos/apache/incubator-openwhisk","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3616/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3616/comments","events_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3616/events","html_url":"https://github.com/apache/incubator-openwhisk/pull/3616","id":320545578,"number":3616,"title":"Use ‘docker.host’ java property as a way to set Docker access for Runtime unit tests","user":{"login":"jonpspri","id":2462804,"avatar_url":"https://avatars0.githubusercontent.com/u/2462804?v=4","gravatar_id":"","url":"https://api.github.com/users/jonpspri","html_url":"https://github.com/jonpspri","followers_url":"https://api.github.com/users/jonpspri/followers","following_url":"https://api.github.com/users/jonpspri/following{/other_user}","gists_url":"https://api.github.com/users/jonpspri/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpspri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpspri/subscriptions","organizations_url":"https://api.github.com/users/jonpspri/orgs","repos_url":"https://api.github.com/users/jonpspri/repos","events_url":"https://api.github.com/users/jonpspri/events{/privacy}","received_events_url":"https://api.github.com/users/jonpspri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"csantanapr","id":1094878,"avatar_url":"https://avatars0.githubusercontent.com/u/1094878?v=4","gravatar_id":"","url":"https://api.github.com/users/csantanapr","html_url":"https://github.com/csantanapr","followers_url":"https://api.github.com/users/csantanapr/followers","following_url":"https://api.github.com/users/csantanapr/following{/other_user}","gists_url":"https://api.github.com/users/csantanapr/gists{/gist_id}","starred_url":"https://api.github.com/users/csantanapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csantanapr/subscriptions","organizations_url":"https://api.github.com/users/csantanapr/orgs","repos_url":"https://api.github.com/users/csantanapr/repos","events_url":"https://api.github.com/users/csantanapr/events{/privacy}","received_events_url":"https://api.github.com/users/csantanapr/received_events","type":"User","site_admin":false},"assignees":[{"login":"csantanapr","id":1094878,"avatar_url":"https://avatars0.githubusercontent.com/u/1094878?v=4","gravatar_id":"","url":"https://api.github.com/users/csantanapr","html_url":"https://github.com/csantanapr","followers_url":"https://api.github.com/users/csantanapr/followers","following_url":"https://api.github.com/users/csantanapr/following{/other_user}","gists_url":"https://api.github.com/users/csantanapr/gists{/gist_id}","starred_url":"https://api.github.com/users/csantanapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csantanapr/subscriptions","organizations_url":"https://api.github.com/users/csantanapr/orgs","repos_url":"https://api.github.com/users/csantanapr/repos","events_url":"https://api.github.com/users/csantanapr/events{/privacy}","received_events_url":"https://api.github.com/users/csantanapr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-05-05T22:17:53Z","updated_at":"2018-05-06T00:43:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3616","html_url":"https://github.com/apache/incubator-openwhisk/pull/3616","diff_url":"https://github.com/apache/incubator-openwhisk/pull/3616.diff","patch_url":"https://github.com/apache/incubator-openwhisk/pull/3616.patch"},"body":"<!--- Provide a concise summary of your changes in the Title -->\r\n\r\n## Description\r\nThese changes allow new scripts using docker-gradle-plugin to use Java properties to pass Docker URL information to the test, rather than inferring it based on whisk. properties.  If the ‘docker.host’ java property is not set, the original ‘whisk.properties’ logic is used as a fallback.\r\n\r\n## Related issue and scope\r\n<!--- Please include a link to a related issue if there is one. -->\r\n- [ ] I opened an issue to propose and discuss this change (#????)\r\n\r\n## My changes affect the following components\r\n<!--- Select below all system components are affected by your change. -->\r\n<!--- Enter an `x` in all applicable boxes. -->\r\n- [ ] API\r\n- [ ] Controller\r\n- [ ] Message Bus (e.g., Kafka)\r\n- [ ] Loadbalancer\r\n- [ ] Invoker\r\n- [ ] Intrinsic actions (e.g., sequences, conductors)\r\n- [ ] Data stores (e.g., CouchDB)\r\n- [X] Tests\r\n- [ ] Deployment\r\n- [ ] CLI\r\n- [ ] General tooling\r\n- [ ] Documentation\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (generally a non-breaking change which closes an issue).\r\n- [X] Enhancement or new feature (adds new functionality).\r\n- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).\r\n\r\n## Checklist:\r\n<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->\r\n\r\n- [X] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).\r\n- [X] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).\r\n- [ ] I added tests to cover my changes.\r\n- [ ] My changes require further changes to the documentation.\r\n- [ ] I updated the documentation where necessary.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/comments/386845240","html_url":"https://github.com/apache/incubator-openwhisk/pull/3616#issuecomment-386845240","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3616","id":386845240,"user":{"login":"csantanapr","id":1094878,"avatar_url":"https://avatars0.githubusercontent.com/u/1094878?v=4","gravatar_id":"","url":"https://api.github.com/users/csantanapr","html_url":"https://github.com/csantanapr","followers_url":"https://api.github.com/users/csantanapr/followers","following_url":"https://api.github.com/users/csantanapr/following{/other_user}","gists_url":"https://api.github.com/users/csantanapr/gists{/gist_id}","starred_url":"https://api.github.com/users/csantanapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csantanapr/subscriptions","organizations_url":"https://api.github.com/users/csantanapr/orgs","repos_url":"https://api.github.com/users/csantanapr/repos","events_url":"https://api.github.com/users/csantanapr/events{/privacy}","received_events_url":"https://api.github.com/users/csantanapr/received_events","type":"User","site_admin":false},"created_at":"2018-05-06T00:43:31Z","updated_at":"2018-05-06T00:43:31Z","author_association":"CONTRIBUTOR","body":"@jonpspri check this PR, travis is has errors.\r\n\r\nIn addition I tried this PR locally, in docker for Mac, where it's fine to run `docker run` with no host `--host specified`\r\n\r\nI deleted the whisk.properties and try to run the test for the runtime-nodejs runtime\r\n```\r\n😄  $ rm $OPENWHISK_HOME/whisk.properties\r\n~/dev/whisk/git/apache/incubator-openwhisk-runtime-nodejs (master)\r\n🔥  $ cat OPENWHISK_HOME/whisk.properties\r\ncat: $OPENWHISK_HOMEwhisk.properties: No such file or directory\r\n~/dev/whisk/git/apache/incubator-openwhisk-runtime-nodejs (master)\r\n🍰  $ ./gradlew tests:test\r\n\r\n> Task :tests:compileTestScala\r\nPruning sources from previous analysis, due to incompatible CompileSetup.\r\n\r\n> Task :tests:test\r\n\r\nruntime.actionContainers.NodeJs6ActionContainerTests STANDARD_OUT\r\n    [2018-05-05T20:36:50.788Z] [INFO] Slf4jLogger started\r\n\r\nruntime.actionContainers.NodeJs6ActionContainerTests > nodejs6action should run and report an error for script not returning a json object FAILED\r\n    java.lang.AssertionError: '/Users/csantana23/dev/whisk/git/apache/incubator-openwhisk/whisk.properties' does not exists but required\r\n\r\nruntime.actionContainers.NodeJs6ActionContainerTests > nodejs6action should run a node script FAILED\r\n    java.lang.NoClassDefFoundError: Could not initialize class common.WhiskProperties\r\n\r\nruntime.actionContainers.NodeJs8ActionContainerTests STANDARD_OUT\r\n    [2018-05-05T20:36:51.069Z] [INFO] Slf4jLogger started\r\n\r\nruntime.actionContainers.NodeJs8ActionContainerTests > action-nodejs-v8 should run and report an error for script not returning a json object FAILED\r\n    java.lang.NoClassDefFoundError: Could not initialize class common.WhiskProperties\r\n\r\n3 tests completed, 3 failed\r\n```\r\nIt looks like something still depends on whisk.properties"}}
{"actor":{"display_login":"csantanapr"}}