{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-aws/issues/242","repository_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-aws","labels_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-aws/issues/242/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-aws/issues/242/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-aws/issues/242/events","html_url":"https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/242","id":369725183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTk3Njcz","number":242,"title":"linting: Switch to using golang-ci's metalinter","user":{"login":"randomvariable","id":1441070,"node_id":"MDQ6VXNlcjE0NDEwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1441070?v=4","gravatar_id":"","url":"https://api.github.com/users/randomvariable","html_url":"https://github.com/randomvariable","followers_url":"https://api.github.com/users/randomvariable/followers","following_url":"https://api.github.com/users/randomvariable/following{/other_user}","gists_url":"https://api.github.com/users/randomvariable/gists{/gist_id}","starred_url":"https://api.github.com/users/randomvariable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randomvariable/subscriptions","organizations_url":"https://api.github.com/users/randomvariable/orgs","repos_url":"https://api.github.com/users/randomvariable/repos","events_url":"https://api.github.com/users/randomvariable/events{/privacy}","received_events_url":"https://api.github.com/users/randomvariable/received_events","type":"User","site_admin":false},"labels":[{"id":999231566,"node_id":"MDU6TGFiZWw5OTkyMzE1NjY=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-aws/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":999229099,"node_id":"MDU6TGFiZWw5OTkyMjkwOTk=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-aws/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-12T22:04:03Z","updated_at":"2018-10-15T15:11:23Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-aws/pulls/242","html_url":"https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/242","diff_url":"https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/242.diff","patch_url":"https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/242.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n5. If this PR changes image versions, please title this PR \"Bump <image name> from x.x.x to y.y.y.\"\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nSwitch to using golang-ci's metalinter\r\n\r\ngofmt gives different results on Go 1.11 vs 1.10, whereas this will give consistent\r\nresults.\r\n\r\nAdditionally, stops make from silently erroring.\r\n\r\nLinting is also restricted to tests as far as Make goes\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #239 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n_Please confirm that if this PR changes any image versions, then that's the sole change this PR makes._\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-aws/issues/comments/429893528","html_url":"https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/242#issuecomment-429893528","issue_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-aws/issues/242","id":429893528,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTg5MzUyOA==","user":{"login":"randomvariable","id":1441070,"node_id":"MDQ6VXNlcjE0NDEwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1441070?v=4","gravatar_id":"","url":"https://api.github.com/users/randomvariable","html_url":"https://github.com/randomvariable","followers_url":"https://api.github.com/users/randomvariable/followers","following_url":"https://api.github.com/users/randomvariable/following{/other_user}","gists_url":"https://api.github.com/users/randomvariable/gists{/gist_id}","starred_url":"https://api.github.com/users/randomvariable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randomvariable/subscriptions","organizations_url":"https://api.github.com/users/randomvariable/orgs","repos_url":"https://api.github.com/users/randomvariable/repos","events_url":"https://api.github.com/users/randomvariable/events{/privacy}","received_events_url":"https://api.github.com/users/randomvariable/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T15:11:23Z","updated_at":"2018-10-15T15:11:23Z","author_association":"MEMBER","body":"Fixed GOPATH, and set up vendor as .PHONY unless FASTBUILD=true as previously.\r\n\r\nNot changing where the lint tool is installed because we haven't yet defined a bindir, \r\nand that should be a different PR I think.\r\n\r\nThe current destination is taken from https://github.com/GoogleContainerTools/skaffold/blob/master/hack/linter.sh#L23 which is used in Travis builds"}}
{"actor":{"display_login":"randomvariable"}}