{"action":"closed","number":117,"pull_request":{"url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/pulls/117","id":213968745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTY4NzQ1","html_url":"https://github.com/Jropp/jason-ropp-js-iobp/pull/117","diff_url":"https://github.com/Jropp/jason-ropp-js-iobp/pull/117.diff","patch_url":"https://github.com/Jropp/jason-ropp-js-iobp/pull/117.patch","issue_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/issues/117","number":117,"state":"closed","locked":false,"title":"Sort Name Mini Project: Sorting Display Styles","user":{"login":"Jropp","id":23724997,"node_id":"MDQ6VXNlcjIzNzI0OTk3","avatar_url":"https://avatars0.githubusercontent.com/u/23724997?v=4","gravatar_id":"","url":"https://api.github.com/users/Jropp","html_url":"https://github.com/Jropp","followers_url":"https://api.github.com/users/Jropp/followers","following_url":"https://api.github.com/users/Jropp/following{/other_user}","gists_url":"https://api.github.com/users/Jropp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jropp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jropp/subscriptions","organizations_url":"https://api.github.com/users/Jropp/orgs","repos_url":"https://api.github.com/users/Jropp/repos","events_url":"https://api.github.com/users/Jropp/events{/privacy}","received_events_url":"https://api.github.com/users/Jropp/received_events","type":"User","site_admin":false},"body":"## What It Does\r\n\r\nAdds visual alphabetization for sorted categories. When sorting departments, it actually displays the departments as well.\r\n\r\nThe problem with sorting departments or first names is that it takes a hot second to adjust to the new sort. First names are visible, but the first name sort is not immediately intuitive because of the Last, First display order. Departments are not even shown in the collapsed state of cards. \r\n\r\nI added a dom-if template to each dom-repeated user card that is only displayed if it is the first card in a new sorted category. So if the users name is Bob and the previous user was Annie, then the header will be displayed there.\r\n\r\nThe letter displayed is set dynamically by grabbing the first letter of the sorted category. So if you are sorting first names, and Bob is the first B, then it grabs the B off the front of the name to use to display the category.\r\n\r\nIn the case of Departments, it figures out when to display the category header in the same way, but instead of grabbing the first letter, it grabs the entire department name.\r\n\r\n#114 \r\n\r\n## How To Test\r\n\r\nCreate various users with various first and last names and departments. Having some users with overlapping First, Last, or Department names will more effectively test the filters.\r\n\r\n## Checklist\r\n\r\nUnder penalty of public shaming, I avow that I:\r\n\r\n- [ ] Reviewed the diff to look for typos, whitespace errors, and console.log() statements\r\n- [ ] Verified that there are no compiler or linter errors or warnings\r\n- [ ] Verified the build in production(optimized) mode\r\n- [ ] Updated the docs, if necessary\r\n- [x] Included the appropriate labels\r\n- [ ] Referenced applicable issues (i.e. Closes #XXXX, Fixes #XXXX)\r\n\r\nBrowsers tested:\r\n- [x] Chrome\r\n- [ ] Firefox\r\n- [ ] Safari\r\n- [ ] Edge\r\n- [ ] Internet Explorer\r\n\r\n## Dependencies\r\n\r\n- [ ] #115 \r\n","created_at":"2018-09-07T15:45:52Z","updated_at":"2018-09-08T13:45:59Z","closed_at":"2018-09-08T13:45:59Z","merged_at":"2018-09-08T13:45:59Z","merge_commit_sha":"f987992e9d801f6c68a175a5b98f6aaa3146659b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":899870637,"node_id":"MDU6TGFiZWw4OTk4NzA2Mzc=","url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/labels/needs%20review","name":"needs review","color":"fbca04","default":false},{"id":1002606841,"node_id":"MDU6TGFiZWwxMDAyNjA2ODQx","url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/labels/styling","name":"styling","color":"5adda2","default":false}],"milestone":{"url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/milestones/4","html_url":"https://github.com/Jropp/jason-ropp-js-iobp/milestone/4","labels_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/milestones/4/labels","id":3263732,"node_id":"MDk6TWlsZXN0b25lMzI2MzczMg==","number":4,"title":"Unit 6: Javascript II","description":"[old unit 6](https://docs.banno.com/ux/intern-onboarding-project/6-angular/)","creator":{"login":"kddrake","id":9660443,"node_id":"MDQ6VXNlcjk2NjA0NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/9660443?v=4","gravatar_id":"","url":"https://api.github.com/users/kddrake","html_url":"https://github.com/kddrake","followers_url":"https://api.github.com/users/kddrake/followers","following_url":"https://api.github.com/users/kddrake/following{/other_user}","gists_url":"https://api.github.com/users/kddrake/gists{/gist_id}","starred_url":"https://api.github.com/users/kddrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kddrake/subscriptions","organizations_url":"https://api.github.com/users/kddrake/orgs","repos_url":"https://api.github.com/users/kddrake/repos","events_url":"https://api.github.com/users/kddrake/events{/privacy}","received_events_url":"https://api.github.com/users/kddrake/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":25,"state":"open","created_at":"2018-04-12T19:32:31Z","updated_at":"2018-09-08T13:45:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/pulls/117/commits","review_comments_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/pulls/117/comments","review_comment_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/issues/117/comments","statuses_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/statuses/2bc0e3f9cd765f5a9f9ff2dbc05c6fb0485d0ff5","head":{"label":"Jropp:mini-sort-styles","ref":"mini-sort-styles","sha":"2bc0e3f9cd765f5a9f9ff2dbc05c6fb0485d0ff5","user":{"login":"Jropp","id":23724997,"node_id":"MDQ6VXNlcjIzNzI0OTk3","avatar_url":"https://avatars0.githubusercontent.com/u/23724997?v=4","gravatar_id":"","url":"https://api.github.com/users/Jropp","html_url":"https://github.com/Jropp","followers_url":"https://api.github.com/users/Jropp/followers","following_url":"https://api.github.com/users/Jropp/following{/other_user}","gists_url":"https://api.github.com/users/Jropp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jropp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jropp/subscriptions","organizations_url":"https://api.github.com/users/Jropp/orgs","repos_url":"https://api.github.com/users/Jropp/repos","events_url":"https://api.github.com/users/Jropp/events{/privacy}","received_events_url":"https://api.github.com/users/Jropp/received_events","type":"User","site_admin":false},"repo":{"id":129130946,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxMzA5NDY=","name":"jason-ropp-js-iobp","full_name":"Jropp/jason-ropp-js-iobp","owner":{"login":"Jropp","id":23724997,"node_id":"MDQ6VXNlcjIzNzI0OTk3","avatar_url":"https://avatars0.githubusercontent.com/u/23724997?v=4","gravatar_id":"","url":"https://api.github.com/users/Jropp","html_url":"https://github.com/Jropp","followers_url":"https://api.github.com/users/Jropp/followers","following_url":"https://api.github.com/users/Jropp/following{/other_user}","gists_url":"https://api.github.com/users/Jropp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jropp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jropp/subscriptions","organizations_url":"https://api.github.com/users/Jropp/orgs","repos_url":"https://api.github.com/users/Jropp/repos","events_url":"https://api.github.com/users/Jropp/events{/privacy}","received_events_url":"https://api.github.com/users/Jropp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jropp/jason-ropp-js-iobp","description":null,"fork":false,"url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp","forks_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/forks","keys_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/teams","hooks_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/hooks","issue_events_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/issues/events{/number}","events_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/events","assignees_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/assignees{/user}","branches_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/branches{/branch}","tags_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/tags","blobs_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/statuses/{sha}","languages_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/languages","stargazers_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/stargazers","contributors_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/contributors","subscribers_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/subscribers","subscription_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/subscription","commits_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/contents/{+path}","compare_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/merges","archive_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/downloads","issues_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/issues{/number}","pulls_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/pulls{/number}","milestones_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/milestones{/number}","notifications_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/labels{/name}","releases_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/releases{/id}","deployments_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/deployments","created_at":"2018-04-11T17:34:54Z","updated_at":"2018-09-05T19:14:55Z","pushed_at":"2018-09-08T13:45:59Z","git_url":"git://github.com/Jropp/jason-ropp-js-iobp.git","ssh_url":"git@github.com:Jropp/jason-ropp-js-iobp.git","clone_url":"https://github.com/Jropp/jason-ropp-js-iobp.git","svn_url":"https://github.com/Jropp/jason-ropp-js-iobp","homepage":null,"size":3889,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"Jropp:mini-project","ref":"mini-project","sha":"8378028aa9e037b7723fba6de65d1ffde9809ddb","user":{"login":"Jropp","id":23724997,"node_id":"MDQ6VXNlcjIzNzI0OTk3","avatar_url":"https://avatars0.githubusercontent.com/u/23724997?v=4","gravatar_id":"","url":"https://api.github.com/users/Jropp","html_url":"https://github.com/Jropp","followers_url":"https://api.github.com/users/Jropp/followers","following_url":"https://api.github.com/users/Jropp/following{/other_user}","gists_url":"https://api.github.com/users/Jropp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jropp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jropp/subscriptions","organizations_url":"https://api.github.com/users/Jropp/orgs","repos_url":"https://api.github.com/users/Jropp/repos","events_url":"https://api.github.com/users/Jropp/events{/privacy}","received_events_url":"https://api.github.com/users/Jropp/received_events","type":"User","site_admin":false},"repo":{"id":129130946,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxMzA5NDY=","name":"jason-ropp-js-iobp","full_name":"Jropp/jason-ropp-js-iobp","owner":{"login":"Jropp","id":23724997,"node_id":"MDQ6VXNlcjIzNzI0OTk3","avatar_url":"https://avatars0.githubusercontent.com/u/23724997?v=4","gravatar_id":"","url":"https://api.github.com/users/Jropp","html_url":"https://github.com/Jropp","followers_url":"https://api.github.com/users/Jropp/followers","following_url":"https://api.github.com/users/Jropp/following{/other_user}","gists_url":"https://api.github.com/users/Jropp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jropp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jropp/subscriptions","organizations_url":"https://api.github.com/users/Jropp/orgs","repos_url":"https://api.github.com/users/Jropp/repos","events_url":"https://api.github.com/users/Jropp/events{/privacy}","received_events_url":"https://api.github.com/users/Jropp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jropp/jason-ropp-js-iobp","description":null,"fork":false,"url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp","forks_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/forks","keys_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/teams","hooks_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/hooks","issue_events_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/issues/events{/number}","events_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/events","assignees_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/assignees{/user}","branches_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/branches{/branch}","tags_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/tags","blobs_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/statuses/{sha}","languages_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/languages","stargazers_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/stargazers","contributors_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/contributors","subscribers_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/subscribers","subscription_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/subscription","commits_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/contents/{+path}","compare_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/merges","archive_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/downloads","issues_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/issues{/number}","pulls_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/pulls{/number}","milestones_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/milestones{/number}","notifications_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/labels{/name}","releases_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/releases{/id}","deployments_url":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/deployments","created_at":"2018-04-11T17:34:54Z","updated_at":"2018-09-05T19:14:55Z","pushed_at":"2018-09-08T13:45:59Z","git_url":"git://github.com/Jropp/jason-ropp-js-iobp.git","ssh_url":"git@github.com:Jropp/jason-ropp-js-iobp.git","clone_url":"https://github.com/Jropp/jason-ropp-js-iobp.git","svn_url":"https://github.com/Jropp/jason-ropp-js-iobp","homepage":null,"size":3889,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/pulls/117"},"html":{"href":"https://github.com/Jropp/jason-ropp-js-iobp/pull/117"},"issue":{"href":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/issues/117"},"comments":{"href":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/Jropp/jason-ropp-js-iobp/statuses/2bc0e3f9cd765f5a9f9ff2dbc05c6fb0485d0ff5"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Jropp","id":23724997,"node_id":"MDQ6VXNlcjIzNzI0OTk3","avatar_url":"https://avatars0.githubusercontent.com/u/23724997?v=4","gravatar_id":"","url":"https://api.github.com/users/Jropp","html_url":"https://github.com/Jropp","followers_url":"https://api.github.com/users/Jropp/followers","following_url":"https://api.github.com/users/Jropp/following{/other_user}","gists_url":"https://api.github.com/users/Jropp/gists{/gist_id}","starred_url":"https://api.github.com/users/Jropp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jropp/subscriptions","organizations_url":"https://api.github.com/users/Jropp/orgs","repos_url":"https://api.github.com/users/Jropp/repos","events_url":"https://api.github.com/users/Jropp/events{/privacy}","received_events_url":"https://api.github.com/users/Jropp/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":72,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"Jropp"}}