{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/comments/181074182","pull_request_review_id":111604754,"id":181074182,"diff_hunk":"@@ -5,24 +5,76 @@\n import Foundation\n import RxSwift\n import RxCocoa\n+import CoreGraphics\n+import LocalAuthentication\n \n protocol WelcomeViewProtocol: class {\n     var loginButtonPressed: ControlEvent<Void> { get }\n+    var firstTimeLoginMessageHidden: AnyObserver<Bool> { get }\n+    var biometricAuthenticationPromptHidden: AnyObserver<Bool> { get }\n+    var biometricSignInText: AnyObserver<String?> { get }\n+    var biometricImageName: AnyObserver<String> { get }\n+    var fxAButtonTopSpace: AnyObserver<CGFloat> { get }\n+}\n+\n+struct LockedEnabled {\n+    let locked: Bool\n+    let enabled: Bool\n+}","path":"lockbox-ios/Presenter/WelcomePresenter.swift","position":19,"original_position":19,"commit_id":"f086d4f5ef95d1b54ee409ad6b1b4013d4fb6342","original_commit_id":"f086d4f5ef95d1b54ee409ad6b1b4013d4fb6342","user":{"login":"jhugman","id":99338,"avatar_url":"https://avatars0.githubusercontent.com/u/99338?v=4","gravatar_id":"","url":"https://api.github.com/users/jhugman","html_url":"https://github.com/jhugman","followers_url":"https://api.github.com/users/jhugman/followers","following_url":"https://api.github.com/users/jhugman/following{/other_user}","gists_url":"https://api.github.com/users/jhugman/gists{/gist_id}","starred_url":"https://api.github.com/users/jhugman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhugman/subscriptions","organizations_url":"https://api.github.com/users/jhugman/orgs","repos_url":"https://api.github.com/users/jhugman/repos","events_url":"https://api.github.com/users/jhugman/events{/privacy}","received_events_url":"https://api.github.com/users/jhugman/received_events","type":"User","site_admin":false},"body":"Nit: document what Locked and Enabled mean.","created_at":"2018-04-12T13:09:06Z","updated_at":"2018-04-12T13:12:45Z","html_url":"https://github.com/mozilla-lockbox/lockbox-ios/pull/210#discussion_r181074182","pull_request_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/210","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/comments/181074182"},"html":{"href":"https://github.com/mozilla-lockbox/lockbox-ios/pull/210#discussion_r181074182"},"pull_request":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/210","id":179537760,"html_url":"https://github.com/mozilla-lockbox/lockbox-ios/pull/210","diff_url":"https://github.com/mozilla-lockbox/lockbox-ios/pull/210.diff","patch_url":"https://github.com/mozilla-lockbox/lockbox-ios/pull/210.patch","issue_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/210","number":210,"state":"open","locked":false,"title":"Sign out and lock functionality","user":{"login":"sashei","id":3207666,"avatar_url":"https://avatars1.githubusercontent.com/u/3207666?v=4","gravatar_id":"","url":"https://api.github.com/users/sashei","html_url":"https://github.com/sashei","followers_url":"https://api.github.com/users/sashei/followers","following_url":"https://api.github.com/users/sashei/following{/other_user}","gists_url":"https://api.github.com/users/sashei/gists{/gist_id}","starred_url":"https://api.github.com/users/sashei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sashei/subscriptions","organizations_url":"https://api.github.com/users/sashei/orgs","repos_url":"https://api.github.com/users/sashei/repos","events_url":"https://api.github.com/users/sashei/events{/privacy}","received_events_url":"https://api.github.com/users/sashei/received_events","type":"User","site_admin":false},"body":"resolves #171 \r\nresolves #81 ","created_at":"2018-04-04T23:22:58Z","updated_at":"2018-04-12T13:12:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f182f7404f1f563374a3ab3f9126cc943b2d871","assignee":{"login":"sashei","id":3207666,"avatar_url":"https://avatars1.githubusercontent.com/u/3207666?v=4","gravatar_id":"","url":"https://api.github.com/users/sashei","html_url":"https://github.com/sashei","followers_url":"https://api.github.com/users/sashei/followers","following_url":"https://api.github.com/users/sashei/following{/other_user}","gists_url":"https://api.github.com/users/sashei/gists{/gist_id}","starred_url":"https://api.github.com/users/sashei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sashei/subscriptions","organizations_url":"https://api.github.com/users/sashei/orgs","repos_url":"https://api.github.com/users/sashei/repos","events_url":"https://api.github.com/users/sashei/events{/privacy}","received_events_url":"https://api.github.com/users/sashei/received_events","type":"User","site_admin":false},"assignees":[{"login":"sashei","id":3207666,"avatar_url":"https://avatars1.githubusercontent.com/u/3207666?v=4","gravatar_id":"","url":"https://api.github.com/users/sashei","html_url":"https://github.com/sashei","followers_url":"https://api.github.com/users/sashei/followers","following_url":"https://api.github.com/users/sashei/following{/other_user}","gists_url":"https://api.github.com/users/sashei/gists{/gist_id}","starred_url":"https://api.github.com/users/sashei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sashei/subscriptions","organizations_url":"https://api.github.com/users/sashei/orgs","repos_url":"https://api.github.com/users/sashei/repos","events_url":"https://api.github.com/users/sashei/events{/privacy}","received_events_url":"https://api.github.com/users/sashei/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":724138380,"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/labels/in%20progress","name":"in progress","color":"e6e6e6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/210/commits","review_comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/210/comments","review_comment_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/210/comments","statuses_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/statuses/f086d4f5ef95d1b54ee409ad6b1b4013d4fb6342","head":{"label":"mozilla-lockbox:171-sign-out-to-lock-settings","ref":"171-sign-out-to-lock-settings","sha":"f086d4f5ef95d1b54ee409ad6b1b4013d4fb6342","user":{"login":"mozilla-lockbox","id":29802027,"avatar_url":"https://avatars0.githubusercontent.com/u/29802027?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-lockbox","html_url":"https://github.com/mozilla-lockbox","followers_url":"https://api.github.com/users/mozilla-lockbox/followers","following_url":"https://api.github.com/users/mozilla-lockbox/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-lockbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-lockbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-lockbox/subscriptions","organizations_url":"https://api.github.com/users/mozilla-lockbox/orgs","repos_url":"https://api.github.com/users/mozilla-lockbox/repos","events_url":"https://api.github.com/users/mozilla-lockbox/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-lockbox/received_events","type":"Organization","site_admin":false},"repo":{"id":107460673,"name":"lockbox-ios","full_name":"mozilla-lockbox/lockbox-ios","owner":{"login":"mozilla-lockbox","id":29802027,"avatar_url":"https://avatars0.githubusercontent.com/u/29802027?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-lockbox","html_url":"https://github.com/mozilla-lockbox","followers_url":"https://api.github.com/users/mozilla-lockbox/followers","following_url":"https://api.github.com/users/mozilla-lockbox/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-lockbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-lockbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-lockbox/subscriptions","organizations_url":"https://api.github.com/users/mozilla-lockbox/orgs","repos_url":"https://api.github.com/users/mozilla-lockbox/repos","events_url":"https://api.github.com/users/mozilla-lockbox/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-lockbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-lockbox/lockbox-ios","description":"Lockbox app for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios","forks_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/deployments","created_at":"2017-10-18T20:42:07Z","updated_at":"2018-04-11T22:33:47Z","pushed_at":"2018-04-11T22:53:26Z","git_url":"git://github.com/mozilla-lockbox/lockbox-ios.git","ssh_url":"git@github.com:mozilla-lockbox/lockbox-ios.git","clone_url":"https://github.com/mozilla-lockbox/lockbox-ios.git","svn_url":"https://github.com/mozilla-lockbox/lockbox-ios","homepage":"https://mozilla-lockbox.github.io/lockbox-ios/","size":48852,"stargazers_count":24,"watchers_count":24,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":5,"open_issues":67,"watchers":24,"default_branch":"master"}},"base":{"label":"mozilla-lockbox:master","ref":"master","sha":"dd64cdae4308b9a437f4be2625c775924ed825a2","user":{"login":"mozilla-lockbox","id":29802027,"avatar_url":"https://avatars0.githubusercontent.com/u/29802027?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-lockbox","html_url":"https://github.com/mozilla-lockbox","followers_url":"https://api.github.com/users/mozilla-lockbox/followers","following_url":"https://api.github.com/users/mozilla-lockbox/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-lockbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-lockbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-lockbox/subscriptions","organizations_url":"https://api.github.com/users/mozilla-lockbox/orgs","repos_url":"https://api.github.com/users/mozilla-lockbox/repos","events_url":"https://api.github.com/users/mozilla-lockbox/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-lockbox/received_events","type":"Organization","site_admin":false},"repo":{"id":107460673,"name":"lockbox-ios","full_name":"mozilla-lockbox/lockbox-ios","owner":{"login":"mozilla-lockbox","id":29802027,"avatar_url":"https://avatars0.githubusercontent.com/u/29802027?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-lockbox","html_url":"https://github.com/mozilla-lockbox","followers_url":"https://api.github.com/users/mozilla-lockbox/followers","following_url":"https://api.github.com/users/mozilla-lockbox/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-lockbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-lockbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-lockbox/subscriptions","organizations_url":"https://api.github.com/users/mozilla-lockbox/orgs","repos_url":"https://api.github.com/users/mozilla-lockbox/repos","events_url":"https://api.github.com/users/mozilla-lockbox/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-lockbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-lockbox/lockbox-ios","description":"Lockbox app for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios","forks_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/deployments","created_at":"2017-10-18T20:42:07Z","updated_at":"2018-04-11T22:33:47Z","pushed_at":"2018-04-11T22:53:26Z","git_url":"git://github.com/mozilla-lockbox/lockbox-ios.git","ssh_url":"git@github.com:mozilla-lockbox/lockbox-ios.git","clone_url":"https://github.com/mozilla-lockbox/lockbox-ios.git","svn_url":"https://github.com/mozilla-lockbox/lockbox-ios","homepage":"https://mozilla-lockbox.github.io/lockbox-ios/","size":48852,"stargazers_count":24,"watchers_count":24,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":5,"open_issues":67,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/210"},"html":{"href":"https://github.com/mozilla-lockbox/lockbox-ios/pull/210"},"issue":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/210"},"comments":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/statuses/f086d4f5ef95d1b54ee409ad6b1b4013d4fb6342"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jhugman"}}