{"action":"opened","issue":{"url":"https://api.github.com/repos/datajoint/datajoint-python/issues/543","repository_url":"https://api.github.com/repos/datajoint/datajoint-python","labels_url":"https://api.github.com/repos/datajoint/datajoint-python/issues/543/labels{/name}","comments_url":"https://api.github.com/repos/datajoint/datajoint-python/issues/543/comments","events_url":"https://api.github.com/repos/datajoint/datajoint-python/issues/543/events","html_url":"https://github.com/datajoint/datajoint-python/issues/543","id":388950919,"node_id":"MDU6SXNzdWUzODg5NTA5MTk=","number":543,"title":"Add back support for `bool` datatype alias during declaration.","user":{"login":"eywalker","id":3084661,"node_id":"MDQ6VXNlcjMwODQ2NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3084661?v=4","gravatar_id":"","url":"https://api.github.com/users/eywalker","html_url":"https://github.com/eywalker","followers_url":"https://api.github.com/users/eywalker/followers","following_url":"https://api.github.com/users/eywalker/following{/other_user}","gists_url":"https://api.github.com/users/eywalker/gists{/gist_id}","starred_url":"https://api.github.com/users/eywalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eywalker/subscriptions","organizations_url":"https://api.github.com/users/eywalker/orgs","repos_url":"https://api.github.com/users/eywalker/repos","events_url":"https://api.github.com/users/eywalker/events{/privacy}","received_events_url":"https://api.github.com/users/eywalker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dimitri-yatsenko","id":1096169,"node_id":"MDQ6VXNlcjEwOTYxNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1096169?v=4","gravatar_id":"","url":"https://api.github.com/users/dimitri-yatsenko","html_url":"https://github.com/dimitri-yatsenko","followers_url":"https://api.github.com/users/dimitri-yatsenko/followers","following_url":"https://api.github.com/users/dimitri-yatsenko/following{/other_user}","gists_url":"https://api.github.com/users/dimitri-yatsenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitri-yatsenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitri-yatsenko/subscriptions","organizations_url":"https://api.github.com/users/dimitri-yatsenko/orgs","repos_url":"https://api.github.com/users/dimitri-yatsenko/repos","events_url":"https://api.github.com/users/dimitri-yatsenko/events{/privacy}","received_events_url":"https://api.github.com/users/dimitri-yatsenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"dimitri-yatsenko","id":1096169,"node_id":"MDQ6VXNlcjEwOTYxNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1096169?v=4","gravatar_id":"","url":"https://api.github.com/users/dimitri-yatsenko","html_url":"https://github.com/dimitri-yatsenko","followers_url":"https://api.github.com/users/dimitri-yatsenko/followers","following_url":"https://api.github.com/users/dimitri-yatsenko/following{/other_user}","gists_url":"https://api.github.com/users/dimitri-yatsenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitri-yatsenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitri-yatsenko/subscriptions","organizations_url":"https://api.github.com/users/dimitri-yatsenko/orgs","repos_url":"https://api.github.com/users/dimitri-yatsenko/repos","events_url":"https://api.github.com/users/dimitri-yatsenko/events{/privacy}","received_events_url":"https://api.github.com/users/dimitri-yatsenko/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-12-08T19:18:34Z","updated_at":"2018-12-08T19:18:34Z","closed_at":null,"author_association":"MEMBER","body":"While it was not officially supported, `bool` type used to work as a data type in table declaration. @dimitri-yatsenko pointed out that in MySQL this was simply an alias for `tinyint` which is actually 1 byte, and therefore when table definition is reversed engineered (e.g. via `describe`), the datatype actually shows up as `tinyint` instead of `bool`. While this behavior is rather undesirable, I still find benefit in being able to use `bool` during declaration (and thus be present in the `definition` string), also because this has been a rather common practice among DataJoint users. \r\n\r\nIn a recent PR #528 we now explicitly check datatypes of attributes during declaration and reject unsupported data types (unlike in the past where we let this silently pass through to MySQL). When this was done, `bool` was **not** added to the supported list, so I suggest that we now add **bool** into the list of officially supported datatypes during table definition."}}
{"actor":{"display_login":"eywalker"}}