{"action":"created","issue":{"url":"https://api.github.com/repos/hlissner/doom-emacs/issues/394","repository_url":"https://api.github.com/repos/hlissner/doom-emacs","labels_url":"https://api.github.com/repos/hlissner/doom-emacs/issues/394/labels{/name}","comments_url":"https://api.github.com/repos/hlissner/doom-emacs/issues/394/comments","events_url":"https://api.github.com/repos/hlissner/doom-emacs/issues/394/events","html_url":"https://github.com/hlissner/doom-emacs/issues/394","id":293440471,"number":394,"title":"Popup windows cannot be ignored if it can be matched by fallback rule","user":{"login":"dsdshcym","id":4723751,"avatar_url":"https://avatars0.githubusercontent.com/u/4723751?v=4","gravatar_id":"","url":"https://api.github.com/users/dsdshcym","html_url":"https://github.com/dsdshcym","followers_url":"https://api.github.com/users/dsdshcym/followers","following_url":"https://api.github.com/users/dsdshcym/following{/other_user}","gists_url":"https://api.github.com/users/dsdshcym/gists{/gist_id}","starred_url":"https://api.github.com/users/dsdshcym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsdshcym/subscriptions","organizations_url":"https://api.github.com/users/dsdshcym/orgs","repos_url":"https://api.github.com/users/dsdshcym/repos","events_url":"https://api.github.com/users/dsdshcym/events{/privacy}","received_events_url":"https://api.github.com/users/dsdshcym/received_events","type":"User","site_admin":false},"labels":[{"id":113470147,"url":"https://api.github.com/repos/hlissner/doom-emacs/labels/bug","name":"bug","color":"fc2929","default":true},{"id":707348531,"url":"https://api.github.com/repos/hlissner/doom-emacs/labels/fixed%20in%20develop","name":"fixed in develop","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hlissner/doom-emacs/milestones/3","html_url":"https://github.com/hlissner/doom-emacs/milestone/3","labels_url":"https://api.github.com/repos/hlissner/doom-emacs/milestones/3/labels","id":2820413,"number":3,"title":"2.1","description":"","creator":{"login":"hlissner","id":510883,"avatar_url":"https://avatars2.githubusercontent.com/u/510883?v=4","gravatar_id":"","url":"https://api.github.com/users/hlissner","html_url":"https://github.com/hlissner","followers_url":"https://api.github.com/users/hlissner/followers","following_url":"https://api.github.com/users/hlissner/following{/other_user}","gists_url":"https://api.github.com/users/hlissner/gists{/gist_id}","starred_url":"https://api.github.com/users/hlissner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlissner/subscriptions","organizations_url":"https://api.github.com/users/hlissner/orgs","repos_url":"https://api.github.com/users/hlissner/repos","events_url":"https://api.github.com/users/hlissner/events{/privacy}","received_events_url":"https://api.github.com/users/hlissner/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":6,"state":"open","created_at":"2017-10-06T16:46:37Z","updated_at":"2018-02-02T04:20:27Z","due_on":"2018-01-31T08:00:00Z","closed_at":null},"comments":6,"created_at":"2018-02-01T08:19:10Z","updated_at":"2018-02-02T04:24:37Z","closed_at":null,"author_association":"NONE","body":"### Observed behavior\r\n\r\nIgnored popup windows (like magit) are still affected by the fallback rule introduced\r\n(magit status popup appears at bottom and it's quite small)\r\n\r\nSet `+popup-enable-fallback-rules` to nil can fix this issue, but the popup\r\nbehavior was correct before, So I think this issue was caused by\r\nhttps://github.com/hlissner/doom-emacs/commit/1ab7301a1d28113a92859bd4523d83e86bf78af4\r\n\r\n### Expected behavior\r\n\r\nmagit windows are ignored by popup module as before\r\nhttps://github.com/hlissner/doom-emacs/commit/1ab7301a1d28113a92859bd4523d83e86bf78af4\r\n\r\n### Steps to reproduce\r\n\r\n1. call magit-status\r\n"},"comment":{"url":"https://api.github.com/repos/hlissner/doom-emacs/issues/comments/362482690","html_url":"https://github.com/hlissner/doom-emacs/issues/394#issuecomment-362482690","issue_url":"https://api.github.com/repos/hlissner/doom-emacs/issues/394","id":362482690,"user":{"login":"dsdshcym","id":4723751,"avatar_url":"https://avatars0.githubusercontent.com/u/4723751?v=4","gravatar_id":"","url":"https://api.github.com/users/dsdshcym","html_url":"https://github.com/dsdshcym","followers_url":"https://api.github.com/users/dsdshcym/followers","following_url":"https://api.github.com/users/dsdshcym/following{/other_user}","gists_url":"https://api.github.com/users/dsdshcym/gists{/gist_id}","starred_url":"https://api.github.com/users/dsdshcym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsdshcym/subscriptions","organizations_url":"https://api.github.com/users/dsdshcym/orgs","repos_url":"https://api.github.com/users/dsdshcym/repos","events_url":"https://api.github.com/users/dsdshcym/events{/privacy}","received_events_url":"https://api.github.com/users/dsdshcym/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T04:24:37Z","updated_at":"2018-02-02T04:24:37Z","author_association":"NONE","body":"And e0fd1b9 fixes this problem, thanks a lot for the quick updates!"}}
{"actor":{"display_login":"dsdshcym"}}