{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/comments/203145130","pull_request_review_id":137977504,"id":203145130,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzE0NTEzMA==","diff_hunk":"@@ -3,41 +3,54 @@\n <Project>\n \n   <!--\n+    Specification: https://github.com/dotnet/arcade/blob/master/Documentation/Versioning.md\n+ \n     Properties:\n-      OfficialBuildId             Contains the build id if this is an official build, otherwise must be empty.\n-      SourceRevisionId            Contains the SHA of the repo being built.\n-      CIBuild                     \"true\" if this is a CI build\n-      UseShippingAssemblyVersion  \"true\" to set assembly version in a dev build to a shipping one instead of 42.42.42.42\n-      UseShippingFileVersion      \"true\" to set file version in a dev build to a shipping one instead of 42.42.42.42\n-      DotNetSemanticVersioningV1  \"true\" if the Version needs to respect SemVer 1.0. Default is false, which means format following SemVer 2.0.\n+      SemanticVersioningV1        \"true\" if the Version needs to respect SemVer 1.0. Default is false, which means format following SemVer 2.0.\n   -->\n \n   <PropertyGroup>\n     <MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>\n   </PropertyGroup>\n \n   <Target Name=\"_InitializeAssemblyVersion\" BeforeTargets=\"GetAssemblyVersion\">\n-    <PropertyGroup Condition=\"'$(OfficialBuildId)' != ''\">\n-      <FileVersion>$(VersionPrefix).$(_BuildNumberFiveDigitDateStamp)</FileVersion>\n-      <InformationalVersion>$(Version)</InformationalVersion>\n+    <Error Text=\"Invalid format of OfficialBuildId: '$(OfficialBuildId)'\" \n+           Condition=\"$(VersionSuffixDateStamp) != '' and ($(VersionSuffixDateStamp.Length) != 5 or $(VersionSuffixBuildOfTheDayPadded.Length) != 2)\"/>\n+   \n+    <PropertyGroup Condition=\"'$(VersionSuffixDateStamp)' != ''\">\n+      <FileVersion>$(VersionPrefix).$(VersionSuffixDateStamp)</FileVersion>","path":"src/Microsoft.DotNet.Arcade.Sdk/tools/Version.targets","position":28,"original_position":28,"commit_id":"7f3f93b082367ae2391c9340bff1d01cb5f04079","original_commit_id":"02eec92b7fb50c2fc4e26642db1dbaa62dffe185","user":{"login":"tmat","id":41759,"node_id":"MDQ6VXNlcjQxNzU5","avatar_url":"https://avatars0.githubusercontent.com/u/41759?v=4","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":"Yes, it is committed. Yes, please file an issue. The question is how to reconcile versioning that fits VS and .NET Core.","created_at":"2018-07-17T19:10:45Z","updated_at":"2018-07-17T19:10:46Z","html_url":"https://github.com/dotnet/arcade/pull/332#discussion_r203145130","pull_request_url":"https://api.github.com/repos/dotnet/arcade/pulls/332","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments/203145130"},"html":{"href":"https://github.com/dotnet/arcade/pull/332#discussion_r203145130"},"pull_request":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/332"}},"in_reply_to_id":202861690},"pull_request":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/332","id":201777274,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzc3Mjc0","html_url":"https://github.com/dotnet/arcade/pull/332","diff_url":"https://github.com/dotnet/arcade/pull/332.diff","patch_url":"https://github.com/dotnet/arcade/pull/332.patch","issue_url":"https://api.github.com/repos/dotnet/arcade/issues/332","number":332,"state":"open","locked":false,"title":"Versioning","user":{"login":"tmat","id":41759,"node_id":"MDQ6VXNlcjQxNzU5","avatar_url":"https://avatars0.githubusercontent.com/u/41759?v=4","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":"Finishes versioning. \r\n\r\nFixes https://github.com/dotnet/arcade/issues/316, item 2 in https://github.com/dotnet/arcade/issues/309.\r\n\r\n- Keeps `OfficialBuild` boolean and sets it based on the value of `OfficialBuildId`. Previously I proposed replacing it with `OfficialBuildId != ''` but it turns out using the boolean is more readable.\r\n\r\n- Rename `DotNetSemanticVersioningV1` to `SemanticVersioningV1` since we expect this value to be set by the project (or in the repo props files) not as a `/p:` parameter to the build\r\n\r\n**DotNetFinalVersionKind**\r\n\r\nOverrides the format of `PackageVersion`\r\n\r\n| DotNetFinalVersionKind | PackageVersion |\r\n|--------------------------|------------------|\r\n|“”\t| “1.2.3-beta.12345.67+sha”|\r\n|“prerelease”\t| “1.2.3-beta+sha”|\r\n| “release”| \t“1.2.3”|\r\n\r\n\r\n**DotNetUseShippingVersions**\r\n\r\n-\tWe define a bool variable `DotNetUseShippingVersions` that will determine whether versions should be shipping or fixed to a high version number (42.42.42.42).\r\n-\t`DotNetUseShippingVersions = false` by default, can be passed to the build /p:DotNetBuildShippingVersions=… \r\n-\tIf `DotNetUseShippingVersions == true`\r\n    - If `OfficialBuildId != \"\"` then the build number in version suffix gets initialized from `OfficialBuildId`\r\n    - If `OfficialBuildId == \"\"` then the build number in version suffix gets initialized from the current date.\r\n-\tIf `DotNetUseShippingVersions == false`\r\n   - Build number will not be included in package version, assembly and file versions will be fixed \r\n-\tA builds target that produces MSI will require `DotNetBuildShippingVersions == true`, and fail otherwise\r\n-\tOfficial build will set `DotNetUseShippingVersions = true`\r\n-\tPR validation build that does not need to install MSI will use the default DotNetUseShippingVersions = false\r\n-\tPR validation build that runs integration tests that need to install MSI will pass `/DotNetUseShippingVersions=true`.\r\n  - The same can be done by a dev who wants to build MSI locally.\r\n  - We can have a helper batch file for convenience in repos that this is a common practice: BuildSetup.cmd \r\n-\tDev build will use the default `DotNetUseShippingVersions = false`\r\n","created_at":"2018-07-16T22:27:30Z","updated_at":"2018-07-17T19:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"842ff1a039e5a43af2977ae5cf6c47dbe2a96b14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/arcade/pulls/332/commits","review_comments_url":"https://api.github.com/repos/dotnet/arcade/pulls/332/comments","review_comment_url":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/arcade/issues/332/comments","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/7f3f93b082367ae2391c9340bff1d01cb5f04079","head":{"label":"tmat:Versioning","ref":"Versioning","sha":"7f3f93b082367ae2391c9340bff1d01cb5f04079","user":{"login":"tmat","id":41759,"node_id":"MDQ6VXNlcjQxNzU5","avatar_url":"https://avatars0.githubusercontent.com/u/41759?v=4","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"repo":{"id":127478333,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc0NzgzMzM=","name":"arcade","full_name":"tmat/arcade","owner":{"login":"tmat","id":41759,"node_id":"MDQ6VXNlcjQxNzU5","avatar_url":"https://avatars0.githubusercontent.com/u/41759?v=4","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmat/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":true,"url":"https://api.github.com/repos/tmat/arcade","forks_url":"https://api.github.com/repos/tmat/arcade/forks","keys_url":"https://api.github.com/repos/tmat/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmat/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmat/arcade/teams","hooks_url":"https://api.github.com/repos/tmat/arcade/hooks","issue_events_url":"https://api.github.com/repos/tmat/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/tmat/arcade/events","assignees_url":"https://api.github.com/repos/tmat/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/tmat/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/tmat/arcade/tags","blobs_url":"https://api.github.com/repos/tmat/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmat/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmat/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmat/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmat/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/tmat/arcade/languages","stargazers_url":"https://api.github.com/repos/tmat/arcade/stargazers","contributors_url":"https://api.github.com/repos/tmat/arcade/contributors","subscribers_url":"https://api.github.com/repos/tmat/arcade/subscribers","subscription_url":"https://api.github.com/repos/tmat/arcade/subscription","commits_url":"https://api.github.com/repos/tmat/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmat/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmat/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmat/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmat/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/tmat/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmat/arcade/merges","archive_url":"https://api.github.com/repos/tmat/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmat/arcade/downloads","issues_url":"https://api.github.com/repos/tmat/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/tmat/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/tmat/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/tmat/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmat/arcade/labels{/name}","releases_url":"https://api.github.com/repos/tmat/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/tmat/arcade/deployments","created_at":"2018-03-30T22:24:55Z","updated_at":"2018-03-30T22:24:57Z","pushed_at":"2018-07-17T18:56:07Z","git_url":"git://github.com/tmat/arcade.git","ssh_url":"git@github.com:tmat/arcade.git","clone_url":"https://github.com/tmat/arcade.git","svn_url":"https://github.com/tmat/arcade","homepage":"","size":1427,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"87fbbcddb7eae5e4ad4c47c8769bf9ddfe73857e","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":121444325,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NDQzMjU=","name":"arcade","full_name":"dotnet/arcade","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":false,"url":"https://api.github.com/repos/dotnet/arcade","forks_url":"https://api.github.com/repos/dotnet/arcade/forks","keys_url":"https://api.github.com/repos/dotnet/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/arcade/teams","hooks_url":"https://api.github.com/repos/dotnet/arcade/hooks","issue_events_url":"https://api.github.com/repos/dotnet/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/arcade/events","assignees_url":"https://api.github.com/repos/dotnet/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/arcade/tags","blobs_url":"https://api.github.com/repos/dotnet/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/arcade/languages","stargazers_url":"https://api.github.com/repos/dotnet/arcade/stargazers","contributors_url":"https://api.github.com/repos/dotnet/arcade/contributors","subscribers_url":"https://api.github.com/repos/dotnet/arcade/subscribers","subscription_url":"https://api.github.com/repos/dotnet/arcade/subscription","commits_url":"https://api.github.com/repos/dotnet/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/arcade/merges","archive_url":"https://api.github.com/repos/dotnet/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/arcade/downloads","issues_url":"https://api.github.com/repos/dotnet/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/arcade/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/arcade/deployments","created_at":"2018-02-13T22:29:54Z","updated_at":"2018-07-17T17:51:40Z","pushed_at":"2018-07-17T19:00:19Z","git_url":"git://github.com/dotnet/arcade.git","ssh_url":"git@github.com:dotnet/arcade.git","clone_url":"https://github.com/dotnet/arcade.git","svn_url":"https://github.com/dotnet/arcade","homepage":"","size":1510,"stargazers_count":10,"watchers_count":10,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":131,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":131,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/332"},"html":{"href":"https://github.com/dotnet/arcade/pull/332"},"issue":{"href":"https://api.github.com/repos/dotnet/arcade/issues/332"},"comments":{"href":"https://api.github.com/repos/dotnet/arcade/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/arcade/statuses/7f3f93b082367ae2391c9340bff1d01cb5f04079"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tmat"}}