{"action":"created","comment":{"url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/comments/174219943","pull_request_review_id":103536109,"id":174219943,"diff_hunk":"@@ -389,6 +422,7 @@ def __init__(self, appId, servicePort, healthCheck):\n         self.iappOptions = {}\n         self.mode = 'tcp'\n         self.balance = 'round-robin'\n+        self.source_addr_translation = {'type': 'automap'}","path":"marathon-bigip-ctlr.py","position":65,"original_position":65,"commit_id":"16c7d1ddc04c16f7257a34d6a4a9f5227817e293","original_commit_id":"16c7d1ddc04c16f7257a34d6a4a9f5227817e293","user":{"login":"russokj","id":14057999,"avatar_url":"https://avatars1.githubusercontent.com/u/14057999?v=4","gravatar_id":"","url":"https://api.github.com/users/russokj","html_url":"https://github.com/russokj","followers_url":"https://api.github.com/users/russokj/followers","following_url":"https://api.github.com/users/russokj/following{/other_user}","gists_url":"https://api.github.com/users/russokj/gists{/gist_id}","starred_url":"https://api.github.com/users/russokj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russokj/subscriptions","organizations_url":"https://api.github.com/users/russokj/orgs","repos_url":"https://api.github.com/users/russokj/repos","events_url":"https://api.github.com/users/russokj/events{/privacy}","received_events_url":"https://api.github.com/users/russokj/received_events","type":"User","site_admin":false},"body":"If you change this to a json string then the get_source_addr_translation() can be simplified without the special if statement.","created_at":"2018-03-13T17:32:24Z","updated_at":"2018-03-13T17:32:25Z","html_url":"https://github.com/F5Networks/marathon-bigip-ctlr/pull/305#discussion_r174219943","pull_request_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/305","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/comments/174219943"},"html":{"href":"https://github.com/F5Networks/marathon-bigip-ctlr/pull/305#discussion_r174219943"},"pull_request":{"href":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/305"}}},"pull_request":{"url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/305","id":174513627,"html_url":"https://github.com/F5Networks/marathon-bigip-ctlr/pull/305","diff_url":"https://github.com/F5Networks/marathon-bigip-ctlr/pull/305.diff","patch_url":"https://github.com/F5Networks/marathon-bigip-ctlr/pull/305.patch","issue_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/issues/305","number":305,"state":"open","locked":false,"title":"Added source address translation configuration.","user":{"login":"ryan-talley","id":11490326,"avatar_url":"https://avatars0.githubusercontent.com/u/11490326?v=4","gravatar_id":"","url":"https://api.github.com/users/ryan-talley","html_url":"https://github.com/ryan-talley","followers_url":"https://api.github.com/users/ryan-talley/followers","following_url":"https://api.github.com/users/ryan-talley/following{/other_user}","gists_url":"https://api.github.com/users/ryan-talley/gists{/gist_id}","starred_url":"https://api.github.com/users/ryan-talley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryan-talley/subscriptions","organizations_url":"https://api.github.com/users/ryan-talley/orgs","repos_url":"https://api.github.com/users/ryan-talley/repos","events_url":"https://api.github.com/users/ryan-talley/events{/privacy}","received_events_url":"https://api.github.com/users/ryan-talley/received_events","type":"User","site_admin":false},"body":"Problem:\r\n Current controller does not allow configuration of virtual server\r\n source address translation on a per vs basis.\r\n\r\nSolution:\r\n Add configurable source address translation fields for virtual servers\r\n based on app labels that default to automap if the label is not set.","created_at":"2018-03-12T22:36:34Z","updated_at":"2018-03-13T17:32:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac0245894773c9754baa3b0aa62d4368e685e8a5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jputrino","id":12143793,"avatar_url":"https://avatars1.githubusercontent.com/u/12143793?v=4","gravatar_id":"","url":"https://api.github.com/users/jputrino","html_url":"https://github.com/jputrino","followers_url":"https://api.github.com/users/jputrino/followers","following_url":"https://api.github.com/users/jputrino/following{/other_user}","gists_url":"https://api.github.com/users/jputrino/gists{/gist_id}","starred_url":"https://api.github.com/users/jputrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jputrino/subscriptions","organizations_url":"https://api.github.com/users/jputrino/orgs","repos_url":"https://api.github.com/users/jputrino/repos","events_url":"https://api.github.com/users/jputrino/events{/privacy}","received_events_url":"https://api.github.com/users/jputrino/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/305/commits","review_comments_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/305/comments","review_comment_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/issues/305/comments","statuses_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/statuses/16c7d1ddc04c16f7257a34d6a4a9f5227817e293","head":{"label":"ryan-talley:snat-pool-config","ref":"snat-pool-config","sha":"16c7d1ddc04c16f7257a34d6a4a9f5227817e293","user":{"login":"ryan-talley","id":11490326,"avatar_url":"https://avatars0.githubusercontent.com/u/11490326?v=4","gravatar_id":"","url":"https://api.github.com/users/ryan-talley","html_url":"https://github.com/ryan-talley","followers_url":"https://api.github.com/users/ryan-talley/followers","following_url":"https://api.github.com/users/ryan-talley/following{/other_user}","gists_url":"https://api.github.com/users/ryan-talley/gists{/gist_id}","starred_url":"https://api.github.com/users/ryan-talley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryan-talley/subscriptions","organizations_url":"https://api.github.com/users/ryan-talley/orgs","repos_url":"https://api.github.com/users/ryan-talley/repos","events_url":"https://api.github.com/users/ryan-talley/events{/privacy}","received_events_url":"https://api.github.com/users/ryan-talley/received_events","type":"User","site_admin":false},"repo":{"id":113477757,"name":"marathon-bigip-ctlr","full_name":"ryan-talley/marathon-bigip-ctlr","owner":{"login":"ryan-talley","id":11490326,"avatar_url":"https://avatars0.githubusercontent.com/u/11490326?v=4","gravatar_id":"","url":"https://api.github.com/users/ryan-talley","html_url":"https://github.com/ryan-talley","followers_url":"https://api.github.com/users/ryan-talley/followers","following_url":"https://api.github.com/users/ryan-talley/following{/other_user}","gists_url":"https://api.github.com/users/ryan-talley/gists{/gist_id}","starred_url":"https://api.github.com/users/ryan-talley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryan-talley/subscriptions","organizations_url":"https://api.github.com/users/ryan-talley/orgs","repos_url":"https://api.github.com/users/ryan-talley/repos","events_url":"https://api.github.com/users/ryan-talley/events{/privacy}","received_events_url":"https://api.github.com/users/ryan-talley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryan-talley/marathon-bigip-ctlr","description":"Repository for F5 BIG-IP Controller for Marathon.","fork":true,"url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr","forks_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/forks","keys_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/teams","hooks_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/hooks","issue_events_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/issues/events{/number}","events_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/events","assignees_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/assignees{/user}","branches_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/branches{/branch}","tags_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/tags","blobs_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/statuses/{sha}","languages_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/languages","stargazers_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/stargazers","contributors_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/contributors","subscribers_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/subscribers","subscription_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/subscription","commits_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/contents/{+path}","compare_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/merges","archive_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/downloads","issues_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/issues{/number}","pulls_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/pulls{/number}","milestones_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/milestones{/number}","notifications_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/labels{/name}","releases_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/releases{/id}","deployments_url":"https://api.github.com/repos/ryan-talley/marathon-bigip-ctlr/deployments","created_at":"2017-12-07T17:05:53Z","updated_at":"2017-12-07T17:05:55Z","pushed_at":"2018-03-13T16:32:48Z","git_url":"git://github.com/ryan-talley/marathon-bigip-ctlr.git","ssh_url":"git@github.com:ryan-talley/marathon-bigip-ctlr.git","clone_url":"https://github.com/ryan-talley/marathon-bigip-ctlr.git","svn_url":"https://github.com/ryan-talley/marathon-bigip-ctlr","homepage":"","size":974,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"F5Networks:master","ref":"master","sha":"71638c435903ebac31bc6a9349d608e53811cf5c","user":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars2.githubusercontent.com/u/8935905?v=4","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":84463388,"name":"marathon-bigip-ctlr","full_name":"F5Networks/marathon-bigip-ctlr","owner":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars2.githubusercontent.com/u/8935905?v=4","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F5Networks/marathon-bigip-ctlr","description":"Repository for F5 BIG-IP Controller for Marathon.","fork":false,"url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr","forks_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/forks","keys_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/teams","hooks_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/hooks","issue_events_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/issues/events{/number}","events_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/events","assignees_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/assignees{/user}","branches_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/branches{/branch}","tags_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/tags","blobs_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/statuses/{sha}","languages_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/languages","stargazers_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/stargazers","contributors_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/contributors","subscribers_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/subscribers","subscription_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/subscription","commits_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/contents/{+path}","compare_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/merges","archive_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/downloads","issues_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/issues{/number}","pulls_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls{/number}","milestones_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/milestones{/number}","notifications_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/labels{/name}","releases_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/releases{/id}","deployments_url":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/deployments","created_at":"2017-03-09T16:17:31Z","updated_at":"2018-03-12T22:55:04Z","pushed_at":"2018-03-13T16:32:50Z","git_url":"git://github.com/F5Networks/marathon-bigip-ctlr.git","ssh_url":"git@github.com:F5Networks/marathon-bigip-ctlr.git","clone_url":"https://github.com/F5Networks/marathon-bigip-ctlr.git","svn_url":"https://github.com/F5Networks/marathon-bigip-ctlr","homepage":"","size":958,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/305"},"html":{"href":"https://github.com/F5Networks/marathon-bigip-ctlr/pull/305"},"issue":{"href":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/issues/305"},"comments":{"href":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/F5Networks/marathon-bigip-ctlr/statuses/16c7d1ddc04c16f7257a34d6a4a9f5227817e293"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"russokj"}}