{"action":"created","issue":{"url":"https://api.github.com/repos/SUSE/DeepSea/issues/955","repository_url":"https://api.github.com/repos/SUSE/DeepSea","labels_url":"https://api.github.com/repos/SUSE/DeepSea/issues/955/labels{/name}","comments_url":"https://api.github.com/repos/SUSE/DeepSea/issues/955/comments","events_url":"https://api.github.com/repos/SUSE/DeepSea/issues/955/events","html_url":"https://github.com/SUSE/DeepSea/issues/955","id":298958171,"number":955,"title":"Adding multiple storage profiles in policy.cfg adds the storage role multiple times to minons","user":{"login":"Martin-Weiss","id":13362573,"avatar_url":"https://avatars1.githubusercontent.com/u/13362573?v=4","gravatar_id":"","url":"https://api.github.com/users/Martin-Weiss","html_url":"https://github.com/Martin-Weiss","followers_url":"https://api.github.com/users/Martin-Weiss/followers","following_url":"https://api.github.com/users/Martin-Weiss/following{/other_user}","gists_url":"https://api.github.com/users/Martin-Weiss/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin-Weiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin-Weiss/subscriptions","organizations_url":"https://api.github.com/users/Martin-Weiss/orgs","repos_url":"https://api.github.com/users/Martin-Weiss/repos","events_url":"https://api.github.com/users/Martin-Weiss/events{/privacy}","received_events_url":"https://api.github.com/users/Martin-Weiss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jan--f","id":458501,"avatar_url":"https://avatars0.githubusercontent.com/u/458501?v=4","gravatar_id":"","url":"https://api.github.com/users/jan--f","html_url":"https://github.com/jan--f","followers_url":"https://api.github.com/users/jan--f/followers","following_url":"https://api.github.com/users/jan--f/following{/other_user}","gists_url":"https://api.github.com/users/jan--f/gists{/gist_id}","starred_url":"https://api.github.com/users/jan--f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan--f/subscriptions","organizations_url":"https://api.github.com/users/jan--f/orgs","repos_url":"https://api.github.com/users/jan--f/repos","events_url":"https://api.github.com/users/jan--f/events{/privacy}","received_events_url":"https://api.github.com/users/jan--f/received_events","type":"User","site_admin":false},"assignees":[{"login":"jan--f","id":458501,"avatar_url":"https://avatars0.githubusercontent.com/u/458501?v=4","gravatar_id":"","url":"https://api.github.com/users/jan--f","html_url":"https://github.com/jan--f","followers_url":"https://api.github.com/users/jan--f/followers","following_url":"https://api.github.com/users/jan--f/following{/other_user}","gists_url":"https://api.github.com/users/jan--f/gists{/gist_id}","starred_url":"https://api.github.com/users/jan--f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan--f/subscriptions","organizations_url":"https://api.github.com/users/jan--f/orgs","repos_url":"https://api.github.com/users/jan--f/repos","events_url":"https://api.github.com/users/jan--f/events{/privacy}","received_events_url":"https://api.github.com/users/jan--f/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-21T12:51:13Z","updated_at":"2018-03-01T21:57:52Z","closed_at":null,"author_association":"NONE","body":"We have this in the policy.cfg:\r\n\r\nprofile-spinner/cluster/osd*.sls\r\nprofile-spinner/stack/default/ceph/minions/osd*.yml\r\nprofile-ssd/cluster/osd*.sls\r\nprofile-ssd/stack/default/ceph/minions/osd*.yml\r\n\r\nAnd when we check for roles on the minions we see this:\r\n\r\nsalt 'osd01-p*' pillar.get roles\r\nosd01-p.ses.intern.thomas-krenn.com:\r\n    - mon\r\n    - mgr\r\n    - mds\r\n    - igw\r\n    - storage\r\n    - storage\r\n\r\nExpectation would have been that the role \"storage\" is there only a single time..\r\n\r\nCould this be fixed by ensuring we only add the role storage if it is not already there?\r\nI am also not sure what will happen during removal processes - are both roles removed properly?"},"comment":{"url":"https://api.github.com/repos/SUSE/DeepSea/issues/comments/369745112","html_url":"https://github.com/SUSE/DeepSea/issues/955#issuecomment-369745112","issue_url":"https://api.github.com/repos/SUSE/DeepSea/issues/955","id":369745112,"user":{"login":"swiftgist","id":4697887,"avatar_url":"https://avatars2.githubusercontent.com/u/4697887?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftgist","html_url":"https://github.com/swiftgist","followers_url":"https://api.github.com/users/swiftgist/followers","following_url":"https://api.github.com/users/swiftgist/following{/other_user}","gists_url":"https://api.github.com/users/swiftgist/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftgist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftgist/subscriptions","organizations_url":"https://api.github.com/users/swiftgist/orgs","repos_url":"https://api.github.com/users/swiftgist/repos","events_url":"https://api.github.com/users/swiftgist/events{/privacy}","received_events_url":"https://api.github.com/users/swiftgist/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T21:57:52Z","updated_at":"2018-03-01T21:57:52Z","author_association":"CONTRIBUTOR","body":"I suspect that this will behave okay, but some loops may run an extra time.  \r\n\r\nJan and I already talked that we need to change something from a list to a set somewhere. :)"}}
{"actor":{"display_login":"swiftgist"}}