{"action":"created","comment":{"url":"https://api.github.com/repos/GPflow/GPflow/pulls/comments/201050027","pull_request_review_id":135475622,"id":201050027,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTA1MDAyNw==","diff_hunk":"@@ -629,18 +732,21 @@ class BaseTensorBoardTask(MonitorTask):\n     If the summary object contains one or more placeholders it may also override the `run`\n     method where it can calculate the correspondent values. It will then call the _eval_summary\n     providing these values as the input values dictionary.\n+\n+    A TensorBoard task requests access to the Tensorflow summary FileWrite object providing the\n+    location of the event file. The FileWriter object will be created if it doesn't exist. When\n+    the task is no longer needed the `close` method should be called. This will release the\n+    FileWriter object.\n     \"\"\"\n \n-    def __init__(self, event_path: str, model: Optional[Model]=None) -> None:\n+    def __init__(self, file_writer: LogdirWriter, model: Optional[Model]=None) -> None:\n         \"\"\"\n-        :param event_path: Path of the event file where the summary protocol buffers will\n-        be written to.\n+        :param file_writer: Event file writer object.\n         :param model: Model object\n         \"\"\"\n         super().__init__()\n+        self._file_writer = file_writer","path":"gpflow/training/monitor.py","position":286,"original_position":286,"commit_id":"c533bb1dba5cd58d7753f592949726d0427847aa","original_commit_id":"c533bb1dba5cd58d7753f592949726d0427847aa","user":{"login":"ahsimb","id":21054992,"node_id":"MDQ6VXNlcjIxMDU0OTky","avatar_url":"https://avatars1.githubusercontent.com/u/21054992?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsimb","html_url":"https://github.com/ahsimb","followers_url":"https://api.github.com/users/ahsimb/followers","following_url":"https://api.github.com/users/ahsimb/following{/other_user}","gists_url":"https://api.github.com/users/ahsimb/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsimb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsimb/subscriptions","organizations_url":"https://api.github.com/users/ahsimb/orgs","repos_url":"https://api.github.com/users/ahsimb/repos","events_url":"https://api.github.com/users/ahsimb/events{/privacy}","received_events_url":"https://api.github.com/users/ahsimb/received_events","type":"User","site_admin":false},"body":"OK, will do","created_at":"2018-07-09T15:41:09Z","updated_at":"2018-07-09T15:41:09Z","html_url":"https://github.com/GPflow/GPflow/pull/807#discussion_r201050027","pull_request_url":"https://api.github.com/repos/GPflow/GPflow/pulls/807","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GPflow/GPflow/pulls/comments/201050027"},"html":{"href":"https://github.com/GPflow/GPflow/pull/807#discussion_r201050027"},"pull_request":{"href":"https://api.github.com/repos/GPflow/GPflow/pulls/807"}},"in_reply_to_id":201039842},"pull_request":{"url":"https://api.github.com/repos/GPflow/GPflow/pulls/807","id":198303374,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MzAzMzc0","html_url":"https://github.com/GPflow/GPflow/pull/807","diff_url":"https://github.com/GPflow/GPflow/pull/807.diff","patch_url":"https://github.com/GPflow/GPflow/pull/807.patch","issue_url":"https://api.github.com/repos/GPflow/GPflow/issues/807","number":807,"state":"open","locked":false,"title":"Fixed discovered problem with the monitor, in particular with TensorBoard tasks","user":{"login":"ahsimb","id":21054992,"node_id":"MDQ6VXNlcjIxMDU0OTky","avatar_url":"https://avatars1.githubusercontent.com/u/21054992?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsimb","html_url":"https://github.com/ahsimb","followers_url":"https://api.github.com/users/ahsimb/followers","following_url":"https://api.github.com/users/ahsimb/following{/other_user}","gists_url":"https://api.github.com/users/ahsimb/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsimb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsimb/subscriptions","organizations_url":"https://api.github.com/users/ahsimb/orgs","repos_url":"https://api.github.com/users/ahsimb/repos","events_url":"https://api.github.com/users/ahsimb/events{/privacy}","received_events_url":"https://api.github.com/users/ahsimb/received_events","type":"User","site_admin":false},"body":"## Fixed issues with the monitor, in particular with TensorBoard tasks.\r\n\r\n### Description\r\n\r\nAddressed remaining comments in the initial PR\r\n\r\nFixed the problem with the TensorBoard tasks writing to the same location. Since the tf.summary.FileWriter doesn't allow shared access only one task was able to write events into the location. Made the tasks sharing the FileWriter in case they use the same location.\r\n\r\nFixed a bug with ImageToTensorBoardTask. It's now closing the Figure objects. \r\n\r\n### Minimal working example\r\n\r\nSee monitor-tensorboard notebook. Now TensorBoard should have all created elements.\r\n","created_at":"2018-06-29T12:30:26Z","updated_at":"2018-07-09T15:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55a45718e3fc4e32e223934d00d97b8536417cba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":439536903,"node_id":"MDU6TGFiZWw0Mzk1MzY5MDM=","url":"https://api.github.com/repos/GPflow/GPflow/labels/discussion","name":"discussion","color":"0e8a16","default":false},{"id":894489160,"node_id":"MDU6TGFiZWw4OTQ0ODkxNjA=","url":"https://api.github.com/repos/GPflow/GPflow/labels/in%20review","name":"in review","color":"e280e5","default":false},{"id":663741448,"node_id":"MDU6TGFiZWw2NjM3NDE0NDg=","url":"https://api.github.com/repos/GPflow/GPflow/labels/not%20ready%20for%20merge","name":"not ready for merge","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GPflow/GPflow/pulls/807/commits","review_comments_url":"https://api.github.com/repos/GPflow/GPflow/pulls/807/comments","review_comment_url":"https://api.github.com/repos/GPflow/GPflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GPflow/GPflow/issues/807/comments","statuses_url":"https://api.github.com/repos/GPflow/GPflow/statuses/c533bb1dba5cd58d7753f592949726d0427847aa","head":{"label":"ahsimb:master","ref":"master","sha":"c533bb1dba5cd58d7753f592949726d0427847aa","user":{"login":"ahsimb","id":21054992,"node_id":"MDQ6VXNlcjIxMDU0OTky","avatar_url":"https://avatars1.githubusercontent.com/u/21054992?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsimb","html_url":"https://github.com/ahsimb","followers_url":"https://api.github.com/users/ahsimb/followers","following_url":"https://api.github.com/users/ahsimb/following{/other_user}","gists_url":"https://api.github.com/users/ahsimb/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsimb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsimb/subscriptions","organizations_url":"https://api.github.com/users/ahsimb/orgs","repos_url":"https://api.github.com/users/ahsimb/repos","events_url":"https://api.github.com/users/ahsimb/events{/privacy}","received_events_url":"https://api.github.com/users/ahsimb/received_events","type":"User","site_admin":false},"repo":{"id":137475408,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0NzU0MDg=","name":"GPflow","full_name":"ahsimb/GPflow","owner":{"login":"ahsimb","id":21054992,"node_id":"MDQ6VXNlcjIxMDU0OTky","avatar_url":"https://avatars1.githubusercontent.com/u/21054992?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsimb","html_url":"https://github.com/ahsimb","followers_url":"https://api.github.com/users/ahsimb/followers","following_url":"https://api.github.com/users/ahsimb/following{/other_user}","gists_url":"https://api.github.com/users/ahsimb/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsimb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsimb/subscriptions","organizations_url":"https://api.github.com/users/ahsimb/orgs","repos_url":"https://api.github.com/users/ahsimb/repos","events_url":"https://api.github.com/users/ahsimb/events{/privacy}","received_events_url":"https://api.github.com/users/ahsimb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahsimb/GPflow","description":"Gaussian processes in TensorFlow","fork":true,"url":"https://api.github.com/repos/ahsimb/GPflow","forks_url":"https://api.github.com/repos/ahsimb/GPflow/forks","keys_url":"https://api.github.com/repos/ahsimb/GPflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahsimb/GPflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahsimb/GPflow/teams","hooks_url":"https://api.github.com/repos/ahsimb/GPflow/hooks","issue_events_url":"https://api.github.com/repos/ahsimb/GPflow/issues/events{/number}","events_url":"https://api.github.com/repos/ahsimb/GPflow/events","assignees_url":"https://api.github.com/repos/ahsimb/GPflow/assignees{/user}","branches_url":"https://api.github.com/repos/ahsimb/GPflow/branches{/branch}","tags_url":"https://api.github.com/repos/ahsimb/GPflow/tags","blobs_url":"https://api.github.com/repos/ahsimb/GPflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahsimb/GPflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahsimb/GPflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahsimb/GPflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahsimb/GPflow/statuses/{sha}","languages_url":"https://api.github.com/repos/ahsimb/GPflow/languages","stargazers_url":"https://api.github.com/repos/ahsimb/GPflow/stargazers","contributors_url":"https://api.github.com/repos/ahsimb/GPflow/contributors","subscribers_url":"https://api.github.com/repos/ahsimb/GPflow/subscribers","subscription_url":"https://api.github.com/repos/ahsimb/GPflow/subscription","commits_url":"https://api.github.com/repos/ahsimb/GPflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahsimb/GPflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahsimb/GPflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahsimb/GPflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahsimb/GPflow/contents/{+path}","compare_url":"https://api.github.com/repos/ahsimb/GPflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahsimb/GPflow/merges","archive_url":"https://api.github.com/repos/ahsimb/GPflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahsimb/GPflow/downloads","issues_url":"https://api.github.com/repos/ahsimb/GPflow/issues{/number}","pulls_url":"https://api.github.com/repos/ahsimb/GPflow/pulls{/number}","milestones_url":"https://api.github.com/repos/ahsimb/GPflow/milestones{/number}","notifications_url":"https://api.github.com/repos/ahsimb/GPflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahsimb/GPflow/labels{/name}","releases_url":"https://api.github.com/repos/ahsimb/GPflow/releases{/id}","deployments_url":"https://api.github.com/repos/ahsimb/GPflow/deployments","created_at":"2018-06-15T10:36:30Z","updated_at":"2018-07-09T14:26:26Z","pushed_at":"2018-07-09T14:26:23Z","git_url":"git://github.com/ahsimb/GPflow.git","ssh_url":"git@github.com:ahsimb/GPflow.git","clone_url":"https://github.com/ahsimb/GPflow.git","svn_url":"https://github.com/ahsimb/GPflow","homepage":"","size":31966,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GPflow:master","ref":"master","sha":"495b6ebef93406048e7234155550d084a37f67c9","user":{"login":"GPflow","id":16667412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjY3NDEy","avatar_url":"https://avatars2.githubusercontent.com/u/16667412?v=4","gravatar_id":"","url":"https://api.github.com/users/GPflow","html_url":"https://github.com/GPflow","followers_url":"https://api.github.com/users/GPflow/followers","following_url":"https://api.github.com/users/GPflow/following{/other_user}","gists_url":"https://api.github.com/users/GPflow/gists{/gist_id}","starred_url":"https://api.github.com/users/GPflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPflow/subscriptions","organizations_url":"https://api.github.com/users/GPflow/orgs","repos_url":"https://api.github.com/users/GPflow/repos","events_url":"https://api.github.com/users/GPflow/events{/privacy}","received_events_url":"https://api.github.com/users/GPflow/received_events","type":"Organization","site_admin":false},"repo":{"id":49643229,"node_id":"MDEwOlJlcG9zaXRvcnk0OTY0MzIyOQ==","name":"GPflow","full_name":"GPflow/GPflow","owner":{"login":"GPflow","id":16667412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjY3NDEy","avatar_url":"https://avatars2.githubusercontent.com/u/16667412?v=4","gravatar_id":"","url":"https://api.github.com/users/GPflow","html_url":"https://github.com/GPflow","followers_url":"https://api.github.com/users/GPflow/followers","following_url":"https://api.github.com/users/GPflow/following{/other_user}","gists_url":"https://api.github.com/users/GPflow/gists{/gist_id}","starred_url":"https://api.github.com/users/GPflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPflow/subscriptions","organizations_url":"https://api.github.com/users/GPflow/orgs","repos_url":"https://api.github.com/users/GPflow/repos","events_url":"https://api.github.com/users/GPflow/events{/privacy}","received_events_url":"https://api.github.com/users/GPflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GPflow/GPflow","description":"Gaussian processes in TensorFlow","fork":false,"url":"https://api.github.com/repos/GPflow/GPflow","forks_url":"https://api.github.com/repos/GPflow/GPflow/forks","keys_url":"https://api.github.com/repos/GPflow/GPflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GPflow/GPflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GPflow/GPflow/teams","hooks_url":"https://api.github.com/repos/GPflow/GPflow/hooks","issue_events_url":"https://api.github.com/repos/GPflow/GPflow/issues/events{/number}","events_url":"https://api.github.com/repos/GPflow/GPflow/events","assignees_url":"https://api.github.com/repos/GPflow/GPflow/assignees{/user}","branches_url":"https://api.github.com/repos/GPflow/GPflow/branches{/branch}","tags_url":"https://api.github.com/repos/GPflow/GPflow/tags","blobs_url":"https://api.github.com/repos/GPflow/GPflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GPflow/GPflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GPflow/GPflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/GPflow/GPflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GPflow/GPflow/statuses/{sha}","languages_url":"https://api.github.com/repos/GPflow/GPflow/languages","stargazers_url":"https://api.github.com/repos/GPflow/GPflow/stargazers","contributors_url":"https://api.github.com/repos/GPflow/GPflow/contributors","subscribers_url":"https://api.github.com/repos/GPflow/GPflow/subscribers","subscription_url":"https://api.github.com/repos/GPflow/GPflow/subscription","commits_url":"https://api.github.com/repos/GPflow/GPflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/GPflow/GPflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/GPflow/GPflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/GPflow/GPflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/GPflow/GPflow/contents/{+path}","compare_url":"https://api.github.com/repos/GPflow/GPflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GPflow/GPflow/merges","archive_url":"https://api.github.com/repos/GPflow/GPflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GPflow/GPflow/downloads","issues_url":"https://api.github.com/repos/GPflow/GPflow/issues{/number}","pulls_url":"https://api.github.com/repos/GPflow/GPflow/pulls{/number}","milestones_url":"https://api.github.com/repos/GPflow/GPflow/milestones{/number}","notifications_url":"https://api.github.com/repos/GPflow/GPflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GPflow/GPflow/labels{/name}","releases_url":"https://api.github.com/repos/GPflow/GPflow/releases{/id}","deployments_url":"https://api.github.com/repos/GPflow/GPflow/deployments","created_at":"2016-01-14T11:29:24Z","updated_at":"2018-07-09T13:54:41Z","pushed_at":"2018-07-09T14:58:20Z","git_url":"git://github.com/GPflow/GPflow.git","ssh_url":"git@github.com:GPflow/GPflow.git","clone_url":"https://github.com/GPflow/GPflow.git","svn_url":"https://github.com/GPflow/GPflow","homepage":"","size":30317,"stargazers_count":700,"watchers_count":700,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":205,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":205,"open_issues":49,"watchers":700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GPflow/GPflow/pulls/807"},"html":{"href":"https://github.com/GPflow/GPflow/pull/807"},"issue":{"href":"https://api.github.com/repos/GPflow/GPflow/issues/807"},"comments":{"href":"https://api.github.com/repos/GPflow/GPflow/issues/807/comments"},"review_comments":{"href":"https://api.github.com/repos/GPflow/GPflow/pulls/807/comments"},"review_comment":{"href":"https://api.github.com/repos/GPflow/GPflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GPflow/GPflow/pulls/807/commits"},"statuses":{"href":"https://api.github.com/repos/GPflow/GPflow/statuses/c533bb1dba5cd58d7753f592949726d0427847aa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ahsimb"}}