{"action":"closed","number":2559,"pull_request":{"url":"https://api.github.com/repos/scalableminds/webknossos/pulls/2559","id":185756682,"html_url":"https://github.com/scalableminds/webknossos/pull/2559","diff_url":"https://github.com/scalableminds/webknossos/pull/2559.diff","patch_url":"https://github.com/scalableminds/webknossos/pull/2559.patch","issue_url":"https://api.github.com/repos/scalableminds/webknossos/issues/2559","number":2559,"state":"closed","locked":false,"title":"Add more E2E tests","user":{"login":"hotzenklotz","id":1105056,"avatar_url":"https://avatars2.githubusercontent.com/u/1105056?v=4","gravatar_id":"","url":"https://api.github.com/users/hotzenklotz","html_url":"https://github.com/hotzenklotz","followers_url":"https://api.github.com/users/hotzenklotz/followers","following_url":"https://api.github.com/users/hotzenklotz/following{/other_user}","gists_url":"https://api.github.com/users/hotzenklotz/gists{/gist_id}","starred_url":"https://api.github.com/users/hotzenklotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hotzenklotz/subscriptions","organizations_url":"https://api.github.com/users/hotzenklotz/orgs","repos_url":"https://api.github.com/users/hotzenklotz/repos","events_url":"https://api.github.com/users/hotzenklotz/events{/privacy}","received_events_url":"https://api.github.com/users/hotzenklotz/received_events","type":"User","site_admin":false},"body":"I looked through the àdmin_rest_api.js` file to find my functions uncovered by E2E tests. I added tests for: \r\n\r\n- Script Administration\r\n  - Listing\r\n  - CRUD\r\n- Dataset Administration\r\n  - assigning teams\r\n  - sharing token\r\n- Projects Administration\r\n  - increasing the number of instances\r\n- User Administration\r\n  - retrieving / ~~revoking~~ auth tokens\r\n- wk Feature Selection\r\n\r\nI also renamed some tests in a similar fashion to the rest of the test suit.\r\n\r\n### Mailable description of changes:\r\n - Add more automatic tests to ensure reliable builds\r\n\r\n### Steps to test:\r\n- `docker-compose run --rm e2e-tests`\r\n- CI Build\r\n\r\n### Issues:\r\n- related to #2190\r\n\r\n------\r\n- [ ] Ready for review\r\n","created_at":"2018-05-03T15:36:35Z","updated_at":"2018-05-07T16:45:33Z","closed_at":"2018-05-07T16:45:33Z","merged_at":"2018-05-07T16:45:33Z","merge_commit_sha":"f1219d160e7821592c5cd520f7e0ea9c5143c5d2","assignee":{"login":"hotzenklotz","id":1105056,"avatar_url":"https://avatars2.githubusercontent.com/u/1105056?v=4","gravatar_id":"","url":"https://api.github.com/users/hotzenklotz","html_url":"https://github.com/hotzenklotz","followers_url":"https://api.github.com/users/hotzenklotz/followers","following_url":"https://api.github.com/users/hotzenklotz/following{/other_user}","gists_url":"https://api.github.com/users/hotzenklotz/gists{/gist_id}","starred_url":"https://api.github.com/users/hotzenklotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hotzenklotz/subscriptions","organizations_url":"https://api.github.com/users/hotzenklotz/orgs","repos_url":"https://api.github.com/users/hotzenklotz/repos","events_url":"https://api.github.com/users/hotzenklotz/events{/privacy}","received_events_url":"https://api.github.com/users/hotzenklotz/received_events","type":"User","site_admin":false},"assignees":[{"login":"hotzenklotz","id":1105056,"avatar_url":"https://avatars2.githubusercontent.com/u/1105056?v=4","gravatar_id":"","url":"https://api.github.com/users/hotzenklotz","html_url":"https://github.com/hotzenklotz","followers_url":"https://api.github.com/users/hotzenklotz/followers","following_url":"https://api.github.com/users/hotzenklotz/following{/other_user}","gists_url":"https://api.github.com/users/hotzenklotz/gists{/gist_id}","starred_url":"https://api.github.com/users/hotzenklotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hotzenklotz/subscriptions","organizations_url":"https://api.github.com/users/hotzenklotz/orgs","repos_url":"https://api.github.com/users/hotzenklotz/repos","events_url":"https://api.github.com/users/hotzenklotz/events{/privacy}","received_events_url":"https://api.github.com/users/hotzenklotz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":60646770,"url":"https://api.github.com/repos/scalableminds/webknossos/labels/frontend","name":"frontend","color":"207de5","default":false},{"id":318524318,"url":"https://api.github.com/repos/scalableminds/webknossos/labels/testing","name":"testing","color":"eb6420","default":false}],"milestone":{"url":"https://api.github.com/repos/scalableminds/webknossos/milestones/37","html_url":"https://github.com/scalableminds/webknossos/milestone/37","labels_url":"https://api.github.com/repos/scalableminds/webknossos/milestones/37/labels","id":3308812,"number":37,"title":"Sprint 21","description":"","creator":{"login":"fm3","id":1390035,"avatar_url":"https://avatars1.githubusercontent.com/u/1390035?v=4","gravatar_id":"","url":"https://api.github.com/users/fm3","html_url":"https://github.com/fm3","followers_url":"https://api.github.com/users/fm3/followers","following_url":"https://api.github.com/users/fm3/following{/other_user}","gists_url":"https://api.github.com/users/fm3/gists{/gist_id}","starred_url":"https://api.github.com/users/fm3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fm3/subscriptions","organizations_url":"https://api.github.com/users/fm3/orgs","repos_url":"https://api.github.com/users/fm3/repos","events_url":"https://api.github.com/users/fm3/events{/privacy}","received_events_url":"https://api.github.com/users/fm3/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":6,"state":"open","created_at":"2018-04-30T13:37:36Z","updated_at":"2018-05-07T16:45:33Z","due_on":"2018-05-18T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scalableminds/webknossos/pulls/2559/commits","review_comments_url":"https://api.github.com/repos/scalableminds/webknossos/pulls/2559/comments","review_comment_url":"https://api.github.com/repos/scalableminds/webknossos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalableminds/webknossos/issues/2559/comments","statuses_url":"https://api.github.com/repos/scalableminds/webknossos/statuses/8253a02c0fe8544a1eaf310f99ce0db491f1db57","head":{"label":"scalableminds:e2e-tests","ref":"e2e-tests","sha":"8253a02c0fe8544a1eaf310f99ce0db491f1db57","user":{"login":"scalableminds","id":1648557,"avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"repo":{"id":4326197,"name":"webknossos","full_name":"scalableminds/webknossos","owner":{"login":"scalableminds","id":1648557,"avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalableminds/webknossos","description":"A fully cloud- and browser-based 3D annotation tool for distributed large-scale data analysis in light- and electron-microscopy based Connectomics","fork":false,"url":"https://api.github.com/repos/scalableminds/webknossos","forks_url":"https://api.github.com/repos/scalableminds/webknossos/forks","keys_url":"https://api.github.com/repos/scalableminds/webknossos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalableminds/webknossos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalableminds/webknossos/teams","hooks_url":"https://api.github.com/repos/scalableminds/webknossos/hooks","issue_events_url":"https://api.github.com/repos/scalableminds/webknossos/issues/events{/number}","events_url":"https://api.github.com/repos/scalableminds/webknossos/events","assignees_url":"https://api.github.com/repos/scalableminds/webknossos/assignees{/user}","branches_url":"https://api.github.com/repos/scalableminds/webknossos/branches{/branch}","tags_url":"https://api.github.com/repos/scalableminds/webknossos/tags","blobs_url":"https://api.github.com/repos/scalableminds/webknossos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalableminds/webknossos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalableminds/webknossos/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalableminds/webknossos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalableminds/webknossos/statuses/{sha}","languages_url":"https://api.github.com/repos/scalableminds/webknossos/languages","stargazers_url":"https://api.github.com/repos/scalableminds/webknossos/stargazers","contributors_url":"https://api.github.com/repos/scalableminds/webknossos/contributors","subscribers_url":"https://api.github.com/repos/scalableminds/webknossos/subscribers","subscription_url":"https://api.github.com/repos/scalableminds/webknossos/subscription","commits_url":"https://api.github.com/repos/scalableminds/webknossos/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalableminds/webknossos/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalableminds/webknossos/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalableminds/webknossos/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalableminds/webknossos/contents/{+path}","compare_url":"https://api.github.com/repos/scalableminds/webknossos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalableminds/webknossos/merges","archive_url":"https://api.github.com/repos/scalableminds/webknossos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalableminds/webknossos/downloads","issues_url":"https://api.github.com/repos/scalableminds/webknossos/issues{/number}","pulls_url":"https://api.github.com/repos/scalableminds/webknossos/pulls{/number}","milestones_url":"https://api.github.com/repos/scalableminds/webknossos/milestones{/number}","notifications_url":"https://api.github.com/repos/scalableminds/webknossos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalableminds/webknossos/labels{/name}","releases_url":"https://api.github.com/repos/scalableminds/webknossos/releases{/id}","deployments_url":"https://api.github.com/repos/scalableminds/webknossos/deployments","created_at":"2012-05-14T16:26:17Z","updated_at":"2018-05-07T12:29:39Z","pushed_at":"2018-05-07T16:45:33Z","git_url":"git://github.com/scalableminds/webknossos.git","ssh_url":"git@github.com:scalableminds/webknossos.git","clone_url":"https://github.com/scalableminds/webknossos.git","svn_url":"https://github.com/scalableminds/webknossos","homepage":"https://webknossos.org/","size":91550,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":3,"open_issues":89,"watchers":19,"default_branch":"master"}},"base":{"label":"scalableminds:master","ref":"master","sha":"fbcacfe288b8138c87cf488434feeeb570406e23","user":{"login":"scalableminds","id":1648557,"avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"repo":{"id":4326197,"name":"webknossos","full_name":"scalableminds/webknossos","owner":{"login":"scalableminds","id":1648557,"avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalableminds/webknossos","description":"A fully cloud- and browser-based 3D annotation tool for distributed large-scale data analysis in light- and electron-microscopy based Connectomics","fork":false,"url":"https://api.github.com/repos/scalableminds/webknossos","forks_url":"https://api.github.com/repos/scalableminds/webknossos/forks","keys_url":"https://api.github.com/repos/scalableminds/webknossos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalableminds/webknossos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalableminds/webknossos/teams","hooks_url":"https://api.github.com/repos/scalableminds/webknossos/hooks","issue_events_url":"https://api.github.com/repos/scalableminds/webknossos/issues/events{/number}","events_url":"https://api.github.com/repos/scalableminds/webknossos/events","assignees_url":"https://api.github.com/repos/scalableminds/webknossos/assignees{/user}","branches_url":"https://api.github.com/repos/scalableminds/webknossos/branches{/branch}","tags_url":"https://api.github.com/repos/scalableminds/webknossos/tags","blobs_url":"https://api.github.com/repos/scalableminds/webknossos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalableminds/webknossos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalableminds/webknossos/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalableminds/webknossos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalableminds/webknossos/statuses/{sha}","languages_url":"https://api.github.com/repos/scalableminds/webknossos/languages","stargazers_url":"https://api.github.com/repos/scalableminds/webknossos/stargazers","contributors_url":"https://api.github.com/repos/scalableminds/webknossos/contributors","subscribers_url":"https://api.github.com/repos/scalableminds/webknossos/subscribers","subscription_url":"https://api.github.com/repos/scalableminds/webknossos/subscription","commits_url":"https://api.github.com/repos/scalableminds/webknossos/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalableminds/webknossos/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalableminds/webknossos/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalableminds/webknossos/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalableminds/webknossos/contents/{+path}","compare_url":"https://api.github.com/repos/scalableminds/webknossos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalableminds/webknossos/merges","archive_url":"https://api.github.com/repos/scalableminds/webknossos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalableminds/webknossos/downloads","issues_url":"https://api.github.com/repos/scalableminds/webknossos/issues{/number}","pulls_url":"https://api.github.com/repos/scalableminds/webknossos/pulls{/number}","milestones_url":"https://api.github.com/repos/scalableminds/webknossos/milestones{/number}","notifications_url":"https://api.github.com/repos/scalableminds/webknossos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalableminds/webknossos/labels{/name}","releases_url":"https://api.github.com/repos/scalableminds/webknossos/releases{/id}","deployments_url":"https://api.github.com/repos/scalableminds/webknossos/deployments","created_at":"2012-05-14T16:26:17Z","updated_at":"2018-05-07T12:29:39Z","pushed_at":"2018-05-07T16:45:33Z","git_url":"git://github.com/scalableminds/webknossos.git","ssh_url":"git@github.com:scalableminds/webknossos.git","clone_url":"https://github.com/scalableminds/webknossos.git","svn_url":"https://github.com/scalableminds/webknossos","homepage":"https://webknossos.org/","size":91550,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":3,"open_issues":89,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/2559"},"html":{"href":"https://github.com/scalableminds/webknossos/pull/2559"},"issue":{"href":"https://api.github.com/repos/scalableminds/webknossos/issues/2559"},"comments":{"href":"https://api.github.com/repos/scalableminds/webknossos/issues/2559/comments"},"review_comments":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/2559/comments"},"review_comment":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/2559/commits"},"statuses":{"href":"https://api.github.com/repos/scalableminds/webknossos/statuses/8253a02c0fe8544a1eaf310f99ce0db491f1db57"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hotzenklotz","id":1105056,"avatar_url":"https://avatars2.githubusercontent.com/u/1105056?v=4","gravatar_id":"","url":"https://api.github.com/users/hotzenklotz","html_url":"https://github.com/hotzenklotz","followers_url":"https://api.github.com/users/hotzenklotz/followers","following_url":"https://api.github.com/users/hotzenklotz/following{/other_user}","gists_url":"https://api.github.com/users/hotzenklotz/gists{/gist_id}","starred_url":"https://api.github.com/users/hotzenklotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hotzenklotz/subscriptions","organizations_url":"https://api.github.com/users/hotzenklotz/orgs","repos_url":"https://api.github.com/users/hotzenklotz/repos","events_url":"https://api.github.com/users/hotzenklotz/events{/privacy}","received_events_url":"https://api.github.com/users/hotzenklotz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":5,"maintainer_can_modify":false,"commits":12,"additions":347,"deletions":23,"changed_files":18}}
{"actor":{"display_login":"hotzenklotz"}}