{"action":"created","issue":{"url":"https://api.github.com/repos/niqdev/ipcam-view/issues/27","repository_url":"https://api.github.com/repos/niqdev/ipcam-view","labels_url":"https://api.github.com/repos/niqdev/ipcam-view/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/niqdev/ipcam-view/issues/27/comments","events_url":"https://api.github.com/repos/niqdev/ipcam-view/issues/27/events","html_url":"https://github.com/niqdev/ipcam-view/pull/27","id":211961722,"node_id":"MDExOlB1bGxSZXF1ZXN0MTA5MTUzMTk5","number":27,"title":"Changed MjpegInputStreamDefault to handle IllegalArgumentException in parseContentLength","user":{"login":"lorenzos","id":245615,"node_id":"MDQ6VXNlcjI0NTYxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/245615?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzos","html_url":"https://github.com/lorenzos","followers_url":"https://api.github.com/users/lorenzos/followers","following_url":"https://api.github.com/users/lorenzos/following{/other_user}","gists_url":"https://api.github.com/users/lorenzos/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzos/subscriptions","organizations_url":"https://api.github.com/users/lorenzos/orgs","repos_url":"https://api.github.com/users/lorenzos/repos","events_url":"https://api.github.com/users/lorenzos/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-03-05T15:49:45Z","updated_at":"2018-12-03T07:55:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/niqdev/ipcam-view/pulls/27","html_url":"https://github.com/niqdev/ipcam-view/pull/27","diff_url":"https://github.com/niqdev/ipcam-view/pull/27.diff","patch_url":"https://github.com/niqdev/ipcam-view/pull/27.patch"},"body":"I copied some code from the original SimpleMjpegView's [`MjpegInputStream`](https://bitbucket.org/neuralassembly/simplemjpegview/src/6a5cf5bd8f648f05cff6f4dffdcadb422f99fad5/app/src/main/java/com/camera/simplemjpeg/MjpegInputStream.java?at=master&fileviewer=file-view-default) into your `MjpegInputStreamDefault` implementation.\r\n\r\nThe reason for this is because I got many `IllegalArgumentException` when parsing frames' content length using your library. When I tested the original SimpleMjpegView these errors went gone, and I noticed it is because the exception is caught and content length is retrieved using a different approach (searching for the end of the frame instead). \r\n\r\nThe reason I'm not just using SimpleMjpegView is because I have some trouble in decoding JPEG frames using its native code, often I got glitched images from my D-Link security camera. Instead, your default implementation, that uses `BitmapFactory.decodeStream`, always works well.\r\n\r\nOne last note. I don't know why your input stream implementation was different from the original library. I didn't manage to understand if you purposely changed it (in that case I somehow reverted it), and if yes, why you did it. Or if you copied it and later the original library was modified to handle errors similar to mine (in that case I ported those changes here). Please let me know!"},"comment":{"url":"https://api.github.com/repos/niqdev/ipcam-view/issues/comments/443619704","html_url":"https://github.com/niqdev/ipcam-view/pull/27#issuecomment-443619704","issue_url":"https://api.github.com/repos/niqdev/ipcam-view/issues/27","id":443619704,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzYxOTcwNA==","user":{"login":"lorenzos","id":245615,"node_id":"MDQ6VXNlcjI0NTYxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/245615?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzos","html_url":"https://github.com/lorenzos","followers_url":"https://api.github.com/users/lorenzos/followers","following_url":"https://api.github.com/users/lorenzos/following{/other_user}","gists_url":"https://api.github.com/users/lorenzos/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzos/subscriptions","organizations_url":"https://api.github.com/users/lorenzos/orgs","repos_url":"https://api.github.com/users/lorenzos/repos","events_url":"https://api.github.com/users/lorenzos/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzos/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T07:55:30Z","updated_at":"2018-12-03T07:55:30Z","author_association":"CONTRIBUTOR","body":"Nope. To be honest, I don't remember if I made the tests we were talking about. I'm still using my fix in my app, but I don't feel I can tell if you should merge or not. Fell free to close the issue."}}
{"actor":{"display_login":"lorenzos"}}