{"action":"created","comment":{"url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/comments/231138557","pull_request_review_id":172038174,"id":231138557,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTEzODU1Nw==","diff_hunk":"@@ -0,0 +1,34 @@\n+import * as React from \"react\";\n+\n+import * as css from \"./window-shade.sass\";\n+\n+import ContentConfigurations from \"../config/content-configurations\";\n+\n+interface IProps {\n+  type: string;\n+  onClick: () => void;\n+}\n+\n+interface IState { }\n+\n+export default class WindowShade extends React.Component<IProps, IState> {\n+\n+  public render() {\n+    const { onClick, type } = this.props;\n+    const { icon, label, styleClassName } = ContentConfigurations[type];\n+    const cssClassNames = [ css.windowShadeToggle, css[styleClassName] ];\n+    const iconProps = {\n+      width: \"50px\",\n+      fill: \"red\"\n+    };","path":"src/components/window-shade-button.tsx","position":23,"original_position":23,"commit_id":"9ced4940b9515d35231a9d616e75362fb7999ea6","original_commit_id":"9ced4940b9515d35231a9d616e75362fb7999ea6","user":{"login":"DALove1025","id":1869066,"node_id":"MDQ6VXNlcjE4NjkwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1869066?v=4","gravatar_id":"","url":"https://api.github.com/users/DALove1025","html_url":"https://github.com/DALove1025","followers_url":"https://api.github.com/users/DALove1025/followers","following_url":"https://api.github.com/users/DALove1025/following{/other_user}","gists_url":"https://api.github.com/users/DALove1025/gists{/gist_id}","starred_url":"https://api.github.com/users/DALove1025/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DALove1025/subscriptions","organizations_url":"https://api.github.com/users/DALove1025/orgs","repos_url":"https://api.github.com/users/DALove1025/repos","events_url":"https://api.github.com/users/DALove1025/events{/privacy}","received_events_url":"https://api.github.com/users/DALove1025/received_events","type":"User","site_admin":false},"body":"That was the intent, here, too -- to move to it to CSS. At this point I just wanted to make sure props were being respected all they way into the SVG react object.\r\n","created_at":"2018-11-06T14:19:56Z","updated_at":"2018-11-06T14:19:56Z","html_url":"https://github.com/concord-consortium/teacher-edition-tips-plugin/pull/1#discussion_r231138557","pull_request_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/comments/231138557"},"html":{"href":"https://github.com/concord-consortium/teacher-edition-tips-plugin/pull/1#discussion_r231138557"},"pull_request":{"href":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/1"}},"in_reply_to_id":231085215},"pull_request":{"url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/1","id":228405211,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDA1MjEx","html_url":"https://github.com/concord-consortium/teacher-edition-tips-plugin/pull/1","diff_url":"https://github.com/concord-consortium/teacher-edition-tips-plugin/pull/1.diff","patch_url":"https://github.com/concord-consortium/teacher-edition-tips-plugin/pull/1.patch","issue_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/issues/1","number":1,"state":"open","locked":false,"title":"Svg icon support","user":{"login":"DALove1025","id":1869066,"node_id":"MDQ6VXNlcjE4NjkwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1869066?v=4","gravatar_id":"","url":"https://api.github.com/users/DALove1025","html_url":"https://github.com/DALove1025","followers_url":"https://api.github.com/users/DALove1025/followers","following_url":"https://api.github.com/users/DALove1025/following{/other_user}","gists_url":"https://api.github.com/users/DALove1025/gists{/gist_id}","starred_url":"https://api.github.com/users/DALove1025/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DALove1025/subscriptions","organizations_url":"https://api.github.com/users/DALove1025/orgs","repos_url":"https://api.github.com/users/DALove1025/repos","events_url":"https://api.github.com/users/DALove1025/events{/privacy}","received_events_url":"https://api.github.com/users/DALove1025/received_events","type":"User","site_admin":false},"body":"[NP/DL] Two PT user stories are addressed in this PR: [Add svg icons to teacher-edition](https://www.pivotaltracker.com/story/show/161723767) and [Spike - teacher-edition markdown support](https://www.pivotaltracker.com/story/show/161659160)\r\n\r\nThis PR is, somewhat, a work in progress but it also seems a good point to capture a couple of modifications that may prove helpful to have in place for continuing downstream development. This includes the two PT stories, above, for importing and wrapping SVG files as a React component, and integration of a very a simple Markdown processor for rendering text within the plugin.\r\n\r\nFor demonstration purposes, the window-shade configuration now supports the React/svg icon and renders two different icons in the demo page. They currently have an ugly red stroke color to demonstrate the props passed to the component.\r\n\r\nMany of the svg icon files have been added to the project, in preparation for their use in later work.\r\n\r\nRelated PT User Stories:\r\n\r\n[Add svg icons to teacher-edition](https://www.pivotaltracker.com/story/show/161723767)  \r\n[Spike - teacher-edition markdown support](https://www.pivotaltracker.com/story/show/161659160)   \r\n","created_at":"2018-11-05T16:09:42Z","updated_at":"2018-11-06T14:19:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4653c7bb25123f5a30faf1553dac53443780cd99","assignee":null,"assignees":[],"requested_reviewers":[{"login":"knowuh","id":22908,"node_id":"MDQ6VXNlcjIyOTA4","avatar_url":"https://avatars3.githubusercontent.com/u/22908?v=4","gravatar_id":"","url":"https://api.github.com/users/knowuh","html_url":"https://github.com/knowuh","followers_url":"https://api.github.com/users/knowuh/followers","following_url":"https://api.github.com/users/knowuh/following{/other_user}","gists_url":"https://api.github.com/users/knowuh/gists{/gist_id}","starred_url":"https://api.github.com/users/knowuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knowuh/subscriptions","organizations_url":"https://api.github.com/users/knowuh/orgs","repos_url":"https://api.github.com/users/knowuh/repos","events_url":"https://api.github.com/users/knowuh/events{/privacy}","received_events_url":"https://api.github.com/users/knowuh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/1/commits","review_comments_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/1/comments","review_comment_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/issues/1/comments","statuses_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/statuses/9ced4940b9515d35231a9d616e75362fb7999ea6","head":{"label":"concord-consortium:SVG-Icon-Support","ref":"SVG-Icon-Support","sha":"9ced4940b9515d35231a9d616e75362fb7999ea6","user":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":155357872,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUzNTc4NzI=","name":"teacher-edition-tips-plugin","full_name":"concord-consortium/teacher-edition-tips-plugin","private":false,"owner":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/concord-consortium/teacher-edition-tips-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin","forks_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/forks","keys_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/teams","hooks_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/events","assignees_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/tags","blobs_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/subscription","commits_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/merges","archive_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/downloads","issues_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/deployments","created_at":"2018-10-30T09:25:57Z","updated_at":"2018-10-31T01:57:26Z","pushed_at":"2018-11-06T14:19:06Z","git_url":"git://github.com/concord-consortium/teacher-edition-tips-plugin.git","ssh_url":"git@github.com:concord-consortium/teacher-edition-tips-plugin.git","clone_url":"https://github.com/concord-consortium/teacher-edition-tips-plugin.git","svn_url":"https://github.com/concord-consortium/teacher-edition-tips-plugin","homepage":null,"size":184,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"concord-consortium:master","ref":"master","sha":"fd82cbc48e535febc51a199f6740591d4698ceec","user":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":155357872,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUzNTc4NzI=","name":"teacher-edition-tips-plugin","full_name":"concord-consortium/teacher-edition-tips-plugin","private":false,"owner":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/concord-consortium/teacher-edition-tips-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin","forks_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/forks","keys_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/teams","hooks_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/events","assignees_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/tags","blobs_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/subscription","commits_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/merges","archive_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/downloads","issues_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/deployments","created_at":"2018-10-30T09:25:57Z","updated_at":"2018-10-31T01:57:26Z","pushed_at":"2018-11-06T14:19:06Z","git_url":"git://github.com/concord-consortium/teacher-edition-tips-plugin.git","ssh_url":"git@github.com:concord-consortium/teacher-edition-tips-plugin.git","clone_url":"https://github.com/concord-consortium/teacher-edition-tips-plugin.git","svn_url":"https://github.com/concord-consortium/teacher-edition-tips-plugin","homepage":null,"size":184,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/1"},"html":{"href":"https://github.com/concord-consortium/teacher-edition-tips-plugin/pull/1"},"issue":{"href":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/issues/1"},"comments":{"href":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/concord-consortium/teacher-edition-tips-plugin/statuses/9ced4940b9515d35231a9d616e75362fb7999ea6"}},"author_association":"NONE"}}
{"actor":{"display_login":"DALove1025"}}