{"action":"opened","number":390,"pull_request":{"url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/390","id":188312660,"html_url":"https://github.com/dhall-lang/dhall-haskell/pull/390","diff_url":"https://github.com/dhall-lang/dhall-haskell/pull/390.diff","patch_url":"https://github.com/dhall-lang/dhall-haskell/pull/390.patch","issue_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/390","number":390,"state":"open","locked":false,"title":"Update import logic to more closely match standard","user":{"login":"Gabriel439","id":1313787,"avatar_url":"https://avatars3.githubusercontent.com/u/1313787?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabriel439","html_url":"https://github.com/Gabriel439","followers_url":"https://api.github.com/users/Gabriel439/followers","following_url":"https://api.github.com/users/Gabriel439/following{/other_user}","gists_url":"https://api.github.com/users/Gabriel439/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabriel439/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabriel439/subscriptions","organizations_url":"https://api.github.com/users/Gabriel439/orgs","repos_url":"https://api.github.com/users/Gabriel439/repos","events_url":"https://api.github.com/users/Gabriel439/events{/privacy}","received_events_url":"https://api.github.com/users/Gabriel439/received_events","type":"User","site_admin":false},"body":"This is one step in a series of commits to update the Haskell\r\nimplementation to match the import semantics standardized in:\r\n\r\nhttps://github.com/dhall-lang/dhall-lang/pull/127\r\n\r\nThis is a BREAKING CHANGE mostly due to restricting the grammar for\r\nvalid file paths and URLs.  However, in practice most existing code\r\nshould still work after these changes.\r\n\r\nSpecifically, this change:\r\n\r\n* Updates the grammar for file paths and URLs\r\n* Simplifies and cleans up the semantics for canonicalizing paths (and\r\n  chains of paths)\r\n\r\nThe main difference in the grammar is that file paths and URL paths are\r\nunified to have the same syntax and they are both more restricted than\r\nbefore.\r\n\r\nFor example, the following URLs are no longer valid:\r\n\r\n* `http://example.com` (missing a path to a file)\r\n* `http://example.com/()` (invalid path characters)\r\n\r\n... and the following paths are no longer valid:\r\n\r\n* `/?#` (invalid path characters)\r\n\r\nNote that this actually deviates from the standard in one way: file\r\npaths no longer permit `?` and `#` characters (whereas the standard\r\nallows them).  However, in the course of testing these changes I\r\nrealized that if file paths permit `?` and `#` characters and you unify\r\nURLs to also permit them then you get an ambiguous grammar where a `?`\r\nor `#` in a URL could be interpreted as either part of a path component\r\nor part of a query parameter or fragment.\r\n\r\nThe semantics for canonicalizing paths is a straightforward translation\r\nof the standard to Haskell code.","created_at":"2018-05-16T03:54:58Z","updated_at":"2018-05-16T03:54:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/390/commits","review_comments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/390/comments","review_comment_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/390/comments","statuses_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/statuses/b499c9707e8c5d6909bb8e9bc27751e89711cabd","head":{"label":"dhall-lang:gabriel/simplify_imports_2","ref":"gabriel/simplify_imports_2","sha":"b499c9707e8c5d6909bb8e9bc27751e89711cabd","user":{"login":"dhall-lang","id":31601797,"avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":67623822,"name":"dhall-haskell","full_name":"dhall-lang/dhall-haskell","owner":{"login":"dhall-lang","id":31601797,"avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dhall-lang/dhall-haskell","description":"A configuration language guaranteed to terminate","fork":false,"url":"https://api.github.com/repos/dhall-lang/dhall-haskell","forks_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/forks","keys_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/teams","hooks_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/hooks","issue_events_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/events{/number}","events_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/events","assignees_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/assignees{/user}","branches_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/branches{/branch}","tags_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/tags","blobs_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/statuses/{sha}","languages_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/languages","stargazers_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/stargazers","contributors_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/contributors","subscribers_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/subscribers","subscription_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/subscription","commits_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/contents/{+path}","compare_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/merges","archive_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/downloads","issues_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues{/number}","pulls_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls{/number}","milestones_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/milestones{/number}","notifications_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/labels{/name}","releases_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/releases{/id}","deployments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/deployments","created_at":"2016-09-07T16:18:15Z","updated_at":"2018-05-16T01:22:58Z","pushed_at":"2018-05-16T03:53:39Z","git_url":"git://github.com/dhall-lang/dhall-haskell.git","ssh_url":"git@github.com:dhall-lang/dhall-haskell.git","clone_url":"https://github.com/dhall-lang/dhall-haskell.git","svn_url":"https://github.com/dhall-lang/dhall-haskell","homepage":null,"size":1343,"stargazers_count":309,"watchers_count":309,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":49,"open_issues":26,"watchers":309,"default_branch":"master"}},"base":{"label":"dhall-lang:master","ref":"master","sha":"5da4544ad8b07d90f9db7127d0caec9d05d6e844","user":{"login":"dhall-lang","id":31601797,"avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":67623822,"name":"dhall-haskell","full_name":"dhall-lang/dhall-haskell","owner":{"login":"dhall-lang","id":31601797,"avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dhall-lang/dhall-haskell","description":"A configuration language guaranteed to terminate","fork":false,"url":"https://api.github.com/repos/dhall-lang/dhall-haskell","forks_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/forks","keys_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/teams","hooks_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/hooks","issue_events_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/events{/number}","events_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/events","assignees_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/assignees{/user}","branches_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/branches{/branch}","tags_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/tags","blobs_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/statuses/{sha}","languages_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/languages","stargazers_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/stargazers","contributors_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/contributors","subscribers_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/subscribers","subscription_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/subscription","commits_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/contents/{+path}","compare_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/merges","archive_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/downloads","issues_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues{/number}","pulls_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls{/number}","milestones_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/milestones{/number}","notifications_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/labels{/name}","releases_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/releases{/id}","deployments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/deployments","created_at":"2016-09-07T16:18:15Z","updated_at":"2018-05-16T01:22:58Z","pushed_at":"2018-05-16T03:53:39Z","git_url":"git://github.com/dhall-lang/dhall-haskell.git","ssh_url":"git@github.com:dhall-lang/dhall-haskell.git","clone_url":"https://github.com/dhall-lang/dhall-haskell.git","svn_url":"https://github.com/dhall-lang/dhall-haskell","homepage":null,"size":1343,"stargazers_count":309,"watchers_count":309,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":49,"open_issues":26,"watchers":309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/390"},"html":{"href":"https://github.com/dhall-lang/dhall-haskell/pull/390"},"issue":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/390"},"comments":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/statuses/b499c9707e8c5d6909bb8e9bc27751e89711cabd"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":337,"deletions":268,"changed_files":4}}
{"actor":{"display_login":"Gabriel439"}}