{"action":"closed","number":65,"pull_request":{"url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/pulls/65","id":171785225,"html_url":"https://github.com/joshuabaird/puppet-ipaclient/pull/65","diff_url":"https://github.com/joshuabaird/puppet-ipaclient/pull/65.diff","patch_url":"https://github.com/joshuabaird/puppet-ipaclient/pull/65.patch","issue_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/issues/65","number":65,"state":"closed","locked":false,"title":"Using Sensitive data type for password","user":{"login":"danzilio","id":5214637,"avatar_url":"https://avatars1.githubusercontent.com/u/5214637?v=4","gravatar_id":"","url":"https://api.github.com/users/danzilio","html_url":"https://github.com/danzilio","followers_url":"https://api.github.com/users/danzilio/followers","following_url":"https://api.github.com/users/danzilio/following{/other_user}","gists_url":"https://api.github.com/users/danzilio/gists{/gist_id}","starred_url":"https://api.github.com/users/danzilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danzilio/subscriptions","organizations_url":"https://api.github.com/users/danzilio/orgs","repos_url":"https://api.github.com/users/danzilio/repos","events_url":"https://api.github.com/users/danzilio/events{/privacy}","received_events_url":"https://api.github.com/users/danzilio/received_events","type":"User","site_admin":false},"body":"This PR wraps the $password parameter in the Sensitive data type. We're\r\nwaiting on functionality in rspec-puppet to properly inspect Sensitive\r\nvalues but since we're not doing much more than passing the value to the\r\ncommand parameter, I think this is a safe workaround.","created_at":"2018-02-27T21:10:44Z","updated_at":"2018-02-27T21:26:59Z","closed_at":"2018-02-27T21:26:59Z","merged_at":null,"merge_commit_sha":"8f8e91b082404443bc76f0408b8d01ca6eb30d69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/pulls/65/commits","review_comments_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/pulls/65/comments","review_comment_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/issues/65/comments","statuses_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/statuses/5d5e0aedff2275299aa711e65e6b382c3acb1b74","head":{"label":"danzilio:GH-58","ref":"GH-58","sha":"5d5e0aedff2275299aa711e65e6b382c3acb1b74","user":{"login":"danzilio","id":5214637,"avatar_url":"https://avatars1.githubusercontent.com/u/5214637?v=4","gravatar_id":"","url":"https://api.github.com/users/danzilio","html_url":"https://github.com/danzilio","followers_url":"https://api.github.com/users/danzilio/followers","following_url":"https://api.github.com/users/danzilio/following{/other_user}","gists_url":"https://api.github.com/users/danzilio/gists{/gist_id}","starred_url":"https://api.github.com/users/danzilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danzilio/subscriptions","organizations_url":"https://api.github.com/users/danzilio/orgs","repos_url":"https://api.github.com/users/danzilio/repos","events_url":"https://api.github.com/users/danzilio/events{/privacy}","received_events_url":"https://api.github.com/users/danzilio/received_events","type":"User","site_admin":false},"repo":{"id":123178783,"name":"puppet-ipaclient","full_name":"danzilio/puppet-ipaclient","owner":{"login":"danzilio","id":5214637,"avatar_url":"https://avatars1.githubusercontent.com/u/5214637?v=4","gravatar_id":"","url":"https://api.github.com/users/danzilio","html_url":"https://github.com/danzilio","followers_url":"https://api.github.com/users/danzilio/followers","following_url":"https://api.github.com/users/danzilio/following{/other_user}","gists_url":"https://api.github.com/users/danzilio/gists{/gist_id}","starred_url":"https://api.github.com/users/danzilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danzilio/subscriptions","organizations_url":"https://api.github.com/users/danzilio/orgs","repos_url":"https://api.github.com/users/danzilio/repos","events_url":"https://api.github.com/users/danzilio/events{/privacy}","received_events_url":"https://api.github.com/users/danzilio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danzilio/puppet-ipaclient","description":"Puppet module to manage IPA client installation.  Please fork and contribute!","fork":true,"url":"https://api.github.com/repos/danzilio/puppet-ipaclient","forks_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/forks","keys_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/teams","hooks_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/hooks","issue_events_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/issues/events{/number}","events_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/events","assignees_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/assignees{/user}","branches_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/branches{/branch}","tags_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/tags","blobs_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/statuses/{sha}","languages_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/languages","stargazers_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/stargazers","contributors_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/contributors","subscribers_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/subscribers","subscription_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/subscription","commits_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/contents/{+path}","compare_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/merges","archive_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/downloads","issues_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/issues{/number}","pulls_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/pulls{/number}","milestones_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/milestones{/number}","notifications_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/labels{/name}","releases_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/releases{/id}","deployments_url":"https://api.github.com/repos/danzilio/puppet-ipaclient/deployments","created_at":"2018-02-27T19:40:23Z","updated_at":"2018-02-27T19:40:24Z","pushed_at":"2018-02-27T21:10:25Z","git_url":"git://github.com/danzilio/puppet-ipaclient.git","ssh_url":"git@github.com:danzilio/puppet-ipaclient.git","clone_url":"https://github.com/danzilio/puppet-ipaclient.git","svn_url":"https://github.com/danzilio/puppet-ipaclient","homepage":"https://forge.puppetlabs.com/joshuabaird/ipaclient","size":92,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joshuabaird:master","ref":"master","sha":"b086731d5f1c0129db3cd8e3ebdc1acd649ebfce","user":{"login":"joshuabaird","id":6271918,"avatar_url":"https://avatars1.githubusercontent.com/u/6271918?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuabaird","html_url":"https://github.com/joshuabaird","followers_url":"https://api.github.com/users/joshuabaird/followers","following_url":"https://api.github.com/users/joshuabaird/following{/other_user}","gists_url":"https://api.github.com/users/joshuabaird/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuabaird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuabaird/subscriptions","organizations_url":"https://api.github.com/users/joshuabaird/orgs","repos_url":"https://api.github.com/users/joshuabaird/repos","events_url":"https://api.github.com/users/joshuabaird/events{/privacy}","received_events_url":"https://api.github.com/users/joshuabaird/received_events","type":"User","site_admin":false},"repo":{"id":8749861,"name":"puppet-ipaclient","full_name":"joshuabaird/puppet-ipaclient","owner":{"login":"joshuabaird","id":6271918,"avatar_url":"https://avatars1.githubusercontent.com/u/6271918?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuabaird","html_url":"https://github.com/joshuabaird","followers_url":"https://api.github.com/users/joshuabaird/followers","following_url":"https://api.github.com/users/joshuabaird/following{/other_user}","gists_url":"https://api.github.com/users/joshuabaird/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuabaird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuabaird/subscriptions","organizations_url":"https://api.github.com/users/joshuabaird/orgs","repos_url":"https://api.github.com/users/joshuabaird/repos","events_url":"https://api.github.com/users/joshuabaird/events{/privacy}","received_events_url":"https://api.github.com/users/joshuabaird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshuabaird/puppet-ipaclient","description":"Puppet module to manage IPA client installation.  Please fork and contribute!","fork":false,"url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient","forks_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/forks","keys_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/teams","hooks_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/hooks","issue_events_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/issues/events{/number}","events_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/events","assignees_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/assignees{/user}","branches_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/branches{/branch}","tags_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/tags","blobs_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/statuses/{sha}","languages_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/languages","stargazers_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/stargazers","contributors_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/contributors","subscribers_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/subscribers","subscription_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/subscription","commits_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/contents/{+path}","compare_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/merges","archive_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/downloads","issues_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/issues{/number}","pulls_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/pulls{/number}","milestones_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/milestones{/number}","notifications_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/labels{/name}","releases_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/releases{/id}","deployments_url":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/deployments","created_at":"2013-03-13T10:28:35Z","updated_at":"2017-11-15T16:15:34Z","pushed_at":"2018-02-27T21:10:45Z","git_url":"git://github.com/joshuabaird/puppet-ipaclient.git","ssh_url":"git@github.com:joshuabaird/puppet-ipaclient.git","clone_url":"https://github.com/joshuabaird/puppet-ipaclient.git","svn_url":"https://github.com/joshuabaird/puppet-ipaclient","homepage":"https://forge.puppetlabs.com/joshuabaird/ipaclient","size":92,"stargazers_count":13,"watchers_count":13,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":15,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/pulls/65"},"html":{"href":"https://github.com/joshuabaird/puppet-ipaclient/pull/65"},"issue":{"href":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/issues/65"},"comments":{"href":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/joshuabaird/puppet-ipaclient/statuses/5d5e0aedff2275299aa711e65e6b382c3acb1b74"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":99,"deletions":109,"changed_files":4}}
{"actor":{"display_login":"danzilio"}}