{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/comments/168149509","pull_request_review_id":96467727,"id":168149509,"diff_hunk":"@@ -0,0 +1,47 @@\n+# Sharing assets\n+\n+## Summary\n+\n+We need to share assets to make sure users only have to download a thing once. To do this, we'll upload each application's assets to the same location.\n+\n+## Problem\n+\n+In [RFC84 we proposed replacing Static with a gem](https://github.com/alphagov/govuk-rfcs/pull/84). One of the architectural challenges with this approach is that by moving assets (like CSS, JS and images) into the gem, the assets won't be shared for users. This means that users visiting GOV.UK would have to download assets multiple times, depending on what app renders the page.\n+\n+## Proposal\n+\n+We upload the assets to a central location. For example, if both `collections` and `government-frontend` have a file named `foo.css`, they will upload the file to `assets.publishing.service.gov.uk/shared/foo.css`.","path":"rfc-091-sharing-assets.md","position":13,"original_position":13,"commit_id":"08361735e8a59c64471f7bddc7753739e1878f6f","original_commit_id":"08361735e8a59c64471f7bddc7753739e1878f6f","user":{"login":"nickcolley","id":2445413,"avatar_url":"https://avatars2.githubusercontent.com/u/2445413?v=4","gravatar_id":"","url":"https://api.github.com/users/nickcolley","html_url":"https://github.com/nickcolley","followers_url":"https://api.github.com/users/nickcolley/followers","following_url":"https://api.github.com/users/nickcolley/following{/other_user}","gists_url":"https://api.github.com/users/nickcolley/gists{/gist_id}","starred_url":"https://api.github.com/users/nickcolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickcolley/subscriptions","organizations_url":"https://api.github.com/users/nickcolley/orgs","repos_url":"https://api.github.com/users/nickcolley/repos","events_url":"https://api.github.com/users/nickcolley/events{/privacy}","received_events_url":"https://api.github.com/users/nickcolley/received_events","type":"User","site_admin":false},"body":"For application level styles I'd expect them to always be unique and therefore wouldn't need to be hoisted up to a shared layer?\r\n\r\nThis RFC only needs to apply to shared styles between applications.","created_at":"2018-02-14T11:42:08Z","updated_at":"2018-02-14T11:42:08Z","html_url":"https://github.com/alphagov/govuk-rfcs/pull/91#discussion_r168149509","pull_request_url":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/91","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/comments/168149509"},"html":{"href":"https://github.com/alphagov/govuk-rfcs/pull/91#discussion_r168149509"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/91"}},"in_reply_to_id":168145727},"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/91","id":167957267,"html_url":"https://github.com/alphagov/govuk-rfcs/pull/91","diff_url":"https://github.com/alphagov/govuk-rfcs/pull/91.diff","patch_url":"https://github.com/alphagov/govuk-rfcs/pull/91.patch","issue_url":"https://api.github.com/repos/alphagov/govuk-rfcs/issues/91","number":91,"state":"open","locked":false,"title":"RFC91: Sharing assets","user":{"login":"tijmenb","id":233676,"avatar_url":"https://avatars2.githubusercontent.com/u/233676?v=4","gravatar_id":"","url":"https://api.github.com/users/tijmenb","html_url":"https://github.com/tijmenb","followers_url":"https://api.github.com/users/tijmenb/followers","following_url":"https://api.github.com/users/tijmenb/following{/other_user}","gists_url":"https://api.github.com/users/tijmenb/gists{/gist_id}","starred_url":"https://api.github.com/users/tijmenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijmenb/subscriptions","organizations_url":"https://api.github.com/users/tijmenb/orgs","repos_url":"https://api.github.com/users/tijmenb/repos","events_url":"https://api.github.com/users/tijmenb/events{/privacy}","received_events_url":"https://api.github.com/users/tijmenb/received_events","type":"User","site_admin":false},"body":"👉 [Rendered version](https://github.com/alphagov/govuk-rfcs/blob/sharing-assets/rfc-091-sharing-assets.md)\r\n\r\nClosing Friday 16 February.\r\n\r\nhttps://trello.com/c/dCXLbdBH","created_at":"2018-02-08T12:23:11Z","updated_at":"2018-02-14T11:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6a83d6415012f9f167a28df237695e5a3b56c33","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/91/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/91/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk-rfcs/issues/91/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk-rfcs/statuses/08361735e8a59c64471f7bddc7753739e1878f6f","head":{"label":"alphagov:sharing-assets","ref":"sharing-assets","sha":"08361735e8a59c64471f7bddc7753739e1878f6f","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":91582818,"name":"govuk-rfcs","full_name":"alphagov/govuk-rfcs","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-rfcs","description":" GOV.UK staff use this repository as a forum to discuss and make technical decisions","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-rfcs","forks_url":"https://api.github.com/repos/alphagov/govuk-rfcs/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-rfcs/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-rfcs/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-rfcs/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-rfcs/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-rfcs/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-rfcs/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-rfcs/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-rfcs/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-rfcs/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-rfcs/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-rfcs/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-rfcs/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-rfcs/deployments","created_at":"2017-05-17T14:00:56Z","updated_at":"2017-07-26T15:40:18Z","pushed_at":"2018-02-08T13:17:26Z","git_url":"git://github.com/alphagov/govuk-rfcs.git","ssh_url":"git@github.com:alphagov/govuk-rfcs.git","clone_url":"https://github.com/alphagov/govuk-rfcs.git","svn_url":"https://github.com/alphagov/govuk-rfcs","homepage":"","size":236,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"f218b6d6e8bca0c09ae659725d030501e2e9ec78","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":91582818,"name":"govuk-rfcs","full_name":"alphagov/govuk-rfcs","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-rfcs","description":" GOV.UK staff use this repository as a forum to discuss and make technical decisions","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-rfcs","forks_url":"https://api.github.com/repos/alphagov/govuk-rfcs/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-rfcs/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-rfcs/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-rfcs/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-rfcs/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-rfcs/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-rfcs/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-rfcs/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-rfcs/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-rfcs/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-rfcs/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-rfcs/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-rfcs/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-rfcs/deployments","created_at":"2017-05-17T14:00:56Z","updated_at":"2017-07-26T15:40:18Z","pushed_at":"2018-02-08T13:17:26Z","git_url":"git://github.com/alphagov/govuk-rfcs.git","ssh_url":"git@github.com:alphagov/govuk-rfcs.git","clone_url":"https://github.com/alphagov/govuk-rfcs.git","svn_url":"https://github.com/alphagov/govuk-rfcs","homepage":"","size":236,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/91"},"html":{"href":"https://github.com/alphagov/govuk-rfcs/pull/91"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk-rfcs/issues/91"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk-rfcs/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk-rfcs/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk-rfcs/statuses/08361735e8a59c64471f7bddc7753739e1878f6f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"nickcolley"}}