{"action":"created","comment":{"url":"https://api.github.com/repos/jovyan/pythreejs/pulls/comments/175755016","pull_request_review_id":105334686,"id":175755016,"diff_hunk":"@@ -154,15 +157,25 @@ class WebGLDataUnion(DataUnion):\n     Also constrains the use of 64-bit arrays, as this is not supported by WebGL.\n     \"\"\"\n     def validate(self, obj, value):\n+        was_original_array = isinstance(value, np.ndarray)\n+        print(value, was_original_array)\n         value = super(WebGLDataUnion, self).validate(obj, value)\n         array = value.array if isinstance(value, NDArrayWidget) else value\n \n-        if array is not Undefined and str(array.dtype) == 'float64':\n+        dtype_str = str(array.dtype) if array is not Undefined else ''\n+        if dtype_str == 'float64' or dtype_str.endswith('int64'):","path":"pythreejs/traits.py","position":27,"original_position":28,"commit_id":"40f4dd458ab494b479cfa06c3a76e1fa605b9d80","original_commit_id":"f02da199efb438c1f575ca9b787ed3a35f2af3f0","user":{"login":"vidartf","id":510760,"avatar_url":"https://avatars3.githubusercontent.com/u/510760?v=4","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"body":"I mean the opposite 😅 ","created_at":"2018-03-20T13:00:21Z","updated_at":"2018-03-20T13:00:22Z","html_url":"https://github.com/jovyan/pythreejs/pull/170#discussion_r175755016","pull_request_url":"https://api.github.com/repos/jovyan/pythreejs/pulls/170","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jovyan/pythreejs/pulls/comments/175755016"},"html":{"href":"https://github.com/jovyan/pythreejs/pull/170#discussion_r175755016"},"pull_request":{"href":"https://api.github.com/repos/jovyan/pythreejs/pulls/170"}},"in_reply_to_id":175752822},"pull_request":{"url":"https://api.github.com/repos/jovyan/pythreejs/pulls/170","id":176179512,"html_url":"https://github.com/jovyan/pythreejs/pull/170","diff_url":"https://github.com/jovyan/pythreejs/pull/170.diff","patch_url":"https://github.com/jovyan/pythreejs/pull/170.patch","issue_url":"https://api.github.com/repos/jovyan/pythreejs/issues/170","number":170,"state":"open","locked":false,"title":"Coerce 64-bit ints as well as floats","user":{"login":"vidartf","id":510760,"avatar_url":"https://avatars3.githubusercontent.com/u/510760?v=4","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"body":"The base class warns about 64-bit ints in the serializer, which is mostly a source of noice. Here, we try to be smarter about it by casting on validation, and only giving a warning if the original source was another ndarray.\r\n\r\nCloses #164.","created_at":"2018-03-20T12:49:23Z","updated_at":"2018-03-20T13:00:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b642df7019a2bf2f363f73a528eff28d8b48ab4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jovyan/pythreejs/pulls/170/commits","review_comments_url":"https://api.github.com/repos/jovyan/pythreejs/pulls/170/comments","review_comment_url":"https://api.github.com/repos/jovyan/pythreejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jovyan/pythreejs/issues/170/comments","statuses_url":"https://api.github.com/repos/jovyan/pythreejs/statuses/40f4dd458ab494b479cfa06c3a76e1fa605b9d80","head":{"label":"vidartf:coerce_int64","ref":"coerce_int64","sha":"40f4dd458ab494b479cfa06c3a76e1fa605b9d80","user":{"login":"vidartf","id":510760,"avatar_url":"https://avatars3.githubusercontent.com/u/510760?v=4","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"repo":{"id":87162375,"name":"pythreejs","full_name":"vidartf/pythreejs","owner":{"login":"vidartf","id":510760,"avatar_url":"https://avatars3.githubusercontent.com/u/510760?v=4","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vidartf/pythreejs","description":"A Jupyter - ThreeJS bridge","fork":true,"url":"https://api.github.com/repos/vidartf/pythreejs","forks_url":"https://api.github.com/repos/vidartf/pythreejs/forks","keys_url":"https://api.github.com/repos/vidartf/pythreejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vidartf/pythreejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vidartf/pythreejs/teams","hooks_url":"https://api.github.com/repos/vidartf/pythreejs/hooks","issue_events_url":"https://api.github.com/repos/vidartf/pythreejs/issues/events{/number}","events_url":"https://api.github.com/repos/vidartf/pythreejs/events","assignees_url":"https://api.github.com/repos/vidartf/pythreejs/assignees{/user}","branches_url":"https://api.github.com/repos/vidartf/pythreejs/branches{/branch}","tags_url":"https://api.github.com/repos/vidartf/pythreejs/tags","blobs_url":"https://api.github.com/repos/vidartf/pythreejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vidartf/pythreejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vidartf/pythreejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/vidartf/pythreejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vidartf/pythreejs/statuses/{sha}","languages_url":"https://api.github.com/repos/vidartf/pythreejs/languages","stargazers_url":"https://api.github.com/repos/vidartf/pythreejs/stargazers","contributors_url":"https://api.github.com/repos/vidartf/pythreejs/contributors","subscribers_url":"https://api.github.com/repos/vidartf/pythreejs/subscribers","subscription_url":"https://api.github.com/repos/vidartf/pythreejs/subscription","commits_url":"https://api.github.com/repos/vidartf/pythreejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/vidartf/pythreejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/vidartf/pythreejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/vidartf/pythreejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/vidartf/pythreejs/contents/{+path}","compare_url":"https://api.github.com/repos/vidartf/pythreejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vidartf/pythreejs/merges","archive_url":"https://api.github.com/repos/vidartf/pythreejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vidartf/pythreejs/downloads","issues_url":"https://api.github.com/repos/vidartf/pythreejs/issues{/number}","pulls_url":"https://api.github.com/repos/vidartf/pythreejs/pulls{/number}","milestones_url":"https://api.github.com/repos/vidartf/pythreejs/milestones{/number}","notifications_url":"https://api.github.com/repos/vidartf/pythreejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vidartf/pythreejs/labels{/name}","releases_url":"https://api.github.com/repos/vidartf/pythreejs/releases{/id}","deployments_url":"https://api.github.com/repos/vidartf/pythreejs/deployments","created_at":"2017-04-04T08:10:25Z","updated_at":"2017-04-04T08:10:26Z","pushed_at":"2018-03-20T12:59:27Z","git_url":"git://github.com/vidartf/pythreejs.git","ssh_url":"git@github.com:vidartf/pythreejs.git","clone_url":"https://github.com/vidartf/pythreejs.git","svn_url":"https://github.com/vidartf/pythreejs","homepage":"","size":4509,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jovyan:master","ref":"master","sha":"7fba16b16ce7da0fe76de47beb47fc338b354f6d","user":{"login":"jovyan","id":13257282,"avatar_url":"https://avatars1.githubusercontent.com/u/13257282?v=4","gravatar_id":"","url":"https://api.github.com/users/jovyan","html_url":"https://github.com/jovyan","followers_url":"https://api.github.com/users/jovyan/followers","following_url":"https://api.github.com/users/jovyan/following{/other_user}","gists_url":"https://api.github.com/users/jovyan/gists{/gist_id}","starred_url":"https://api.github.com/users/jovyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jovyan/subscriptions","organizations_url":"https://api.github.com/users/jovyan/orgs","repos_url":"https://api.github.com/users/jovyan/repos","events_url":"https://api.github.com/users/jovyan/events{/privacy}","received_events_url":"https://api.github.com/users/jovyan/received_events","type":"Organization","site_admin":false},"repo":{"id":15400194,"name":"pythreejs","full_name":"jovyan/pythreejs","owner":{"login":"jovyan","id":13257282,"avatar_url":"https://avatars1.githubusercontent.com/u/13257282?v=4","gravatar_id":"","url":"https://api.github.com/users/jovyan","html_url":"https://github.com/jovyan","followers_url":"https://api.github.com/users/jovyan/followers","following_url":"https://api.github.com/users/jovyan/following{/other_user}","gists_url":"https://api.github.com/users/jovyan/gists{/gist_id}","starred_url":"https://api.github.com/users/jovyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jovyan/subscriptions","organizations_url":"https://api.github.com/users/jovyan/orgs","repos_url":"https://api.github.com/users/jovyan/repos","events_url":"https://api.github.com/users/jovyan/events{/privacy}","received_events_url":"https://api.github.com/users/jovyan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jovyan/pythreejs","description":"A Jupyter - ThreeJS bridge","fork":false,"url":"https://api.github.com/repos/jovyan/pythreejs","forks_url":"https://api.github.com/repos/jovyan/pythreejs/forks","keys_url":"https://api.github.com/repos/jovyan/pythreejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jovyan/pythreejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jovyan/pythreejs/teams","hooks_url":"https://api.github.com/repos/jovyan/pythreejs/hooks","issue_events_url":"https://api.github.com/repos/jovyan/pythreejs/issues/events{/number}","events_url":"https://api.github.com/repos/jovyan/pythreejs/events","assignees_url":"https://api.github.com/repos/jovyan/pythreejs/assignees{/user}","branches_url":"https://api.github.com/repos/jovyan/pythreejs/branches{/branch}","tags_url":"https://api.github.com/repos/jovyan/pythreejs/tags","blobs_url":"https://api.github.com/repos/jovyan/pythreejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jovyan/pythreejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jovyan/pythreejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jovyan/pythreejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jovyan/pythreejs/statuses/{sha}","languages_url":"https://api.github.com/repos/jovyan/pythreejs/languages","stargazers_url":"https://api.github.com/repos/jovyan/pythreejs/stargazers","contributors_url":"https://api.github.com/repos/jovyan/pythreejs/contributors","subscribers_url":"https://api.github.com/repos/jovyan/pythreejs/subscribers","subscription_url":"https://api.github.com/repos/jovyan/pythreejs/subscription","commits_url":"https://api.github.com/repos/jovyan/pythreejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jovyan/pythreejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jovyan/pythreejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jovyan/pythreejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jovyan/pythreejs/contents/{+path}","compare_url":"https://api.github.com/repos/jovyan/pythreejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jovyan/pythreejs/merges","archive_url":"https://api.github.com/repos/jovyan/pythreejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jovyan/pythreejs/downloads","issues_url":"https://api.github.com/repos/jovyan/pythreejs/issues{/number}","pulls_url":"https://api.github.com/repos/jovyan/pythreejs/pulls{/number}","milestones_url":"https://api.github.com/repos/jovyan/pythreejs/milestones{/number}","notifications_url":"https://api.github.com/repos/jovyan/pythreejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jovyan/pythreejs/labels{/name}","releases_url":"https://api.github.com/repos/jovyan/pythreejs/releases{/id}","deployments_url":"https://api.github.com/repos/jovyan/pythreejs/deployments","created_at":"2013-12-23T17:02:11Z","updated_at":"2018-03-20T12:09:07Z","pushed_at":"2018-03-20T12:59:28Z","git_url":"git://github.com/jovyan/pythreejs.git","ssh_url":"git@github.com:jovyan/pythreejs.git","clone_url":"https://github.com/jovyan/pythreejs.git","svn_url":"https://github.com/jovyan/pythreejs","homepage":"","size":4535,"stargazers_count":346,"watchers_count":346,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":69,"open_issues":17,"watchers":346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jovyan/pythreejs/pulls/170"},"html":{"href":"https://github.com/jovyan/pythreejs/pull/170"},"issue":{"href":"https://api.github.com/repos/jovyan/pythreejs/issues/170"},"comments":{"href":"https://api.github.com/repos/jovyan/pythreejs/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/jovyan/pythreejs/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/jovyan/pythreejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jovyan/pythreejs/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/jovyan/pythreejs/statuses/40f4dd458ab494b479cfa06c3a76e1fa605b9d80"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vidartf"}}