{"action":"created","comment":{"url":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/comments/237882297","pull_request_review_id":180293928,"id":237882297,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzg4MjI5Nw==","diff_hunk":"@@ -239,16 +239,34 @@ Cart.prototype.emptyList = function() {\n     $table.html('<tr><td colspan=\"4\">The cart is empty.</td></tr>');\n }\n \n-/* Get the currency symbol from an existing amount and use it with the new amount*/\n+/* Get the currency symbol from an existing amount and use it with the new amount */","path":"BTCPayServer/wwwroot/cart/js/cart.js","position":27,"original_position":27,"commit_id":"f2a43ad1f3126cf0ecba5b25df9c2621893ae7c3","original_commit_id":"cbbe5cfb252941fd03d90aeb67f61ed570ece18f","user":{"login":"mariodian","id":3636406,"node_id":"MDQ6VXNlcjM2MzY0MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3636406?v=4","gravatar_id":"","url":"https://api.github.com/users/mariodian","html_url":"https://github.com/mariodian","followers_url":"https://api.github.com/users/mariodian/followers","following_url":"https://api.github.com/users/mariodian/following{/other_user}","gists_url":"https://api.github.com/users/mariodian/gists{/gist_id}","starred_url":"https://api.github.com/users/mariodian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariodian/subscriptions","organizations_url":"https://api.github.com/users/mariodian/orgs","repos_url":"https://api.github.com/users/mariodian/repos","events_url":"https://api.github.com/users/mariodian/events{/privacy}","received_events_url":"https://api.github.com/users/mariodian/received_events","type":"User","site_admin":false},"body":"@NicolasDorier I realized separators are indeed missing in srvModel and I can't figure out how to add it there. I can only retrieve number of decimals, code, name and symbol. Seems like I will need that commit you mentioned. Thanks!","created_at":"2018-11-30T14:42:34Z","updated_at":"2018-11-30T14:42:35Z","html_url":"https://github.com/btcpayserver/btcpayserver/pull/428#discussion_r237882297","pull_request_url":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/428","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/comments/237882297"},"html":{"href":"https://github.com/btcpayserver/btcpayserver/pull/428#discussion_r237882297"},"pull_request":{"href":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/428"}},"in_reply_to_id":237850485},"pull_request":{"url":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/428","id":234965992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTY1OTky","html_url":"https://github.com/btcpayserver/btcpayserver/pull/428","diff_url":"https://github.com/btcpayserver/btcpayserver/pull/428.diff","patch_url":"https://github.com/btcpayserver/btcpayserver/pull/428.patch","issue_url":"https://api.github.com/repos/btcpayserver/btcpayserver/issues/428","number":428,"state":"open","locked":false,"title":"Fix currency format for total amount","user":{"login":"mariodian","id":3636406,"node_id":"MDQ6VXNlcjM2MzY0MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3636406?v=4","gravatar_id":"","url":"https://api.github.com/users/mariodian","html_url":"https://github.com/mariodian","followers_url":"https://api.github.com/users/mariodian/followers","following_url":"https://api.github.com/users/mariodian/following{/other_user}","gists_url":"https://api.github.com/users/mariodian/gists{/gist_id}","starred_url":"https://api.github.com/users/mariodian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariodian/subscriptions","organizations_url":"https://api.github.com/users/mariodian/orgs","repos_url":"https://api.github.com/users/mariodian/repos","events_url":"https://api.github.com/users/mariodian/events{/privacy}","received_events_url":"https://api.github.com/users/mariodian/received_events","type":"User","site_admin":false},"body":"Fixed a bug where the total amount would be displayed in a weird way when using non-USD currencies (the bug had no impact on the functionality, just the UI) because they use `<space>`  instead of `,` for thousands, and `,` instead of `.` for decimals.\r\n\r\nSince I don't have any useful information from the server about the currency format other than a currency sign ($, € etc.. and sometimes the srvModel returns no sign at all, for example for a currency like INR), and javascript can't natively work with currencies either, I have to hack it a bit.\r\n\r\nIt should display the correct total amount now for both type of currency formats.","created_at":"2018-11-30T12:03:53Z","updated_at":"2018-11-30T14:42:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c243fa628eb8f8ec2dfff01776343d75e152c59","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/428/commits","review_comments_url":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/428/comments","review_comment_url":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/btcpayserver/btcpayserver/issues/428/comments","statuses_url":"https://api.github.com/repos/btcpayserver/btcpayserver/statuses/f2a43ad1f3126cf0ecba5b25df9c2621893ae7c3","head":{"label":"mariodian:fix-pos-cart-currency","ref":"fix-pos-cart-currency","sha":"f2a43ad1f3126cf0ecba5b25df9c2621893ae7c3","user":{"login":"mariodian","id":3636406,"node_id":"MDQ6VXNlcjM2MzY0MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3636406?v=4","gravatar_id":"","url":"https://api.github.com/users/mariodian","html_url":"https://github.com/mariodian","followers_url":"https://api.github.com/users/mariodian/followers","following_url":"https://api.github.com/users/mariodian/following{/other_user}","gists_url":"https://api.github.com/users/mariodian/gists{/gist_id}","starred_url":"https://api.github.com/users/mariodian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariodian/subscriptions","organizations_url":"https://api.github.com/users/mariodian/orgs","repos_url":"https://api.github.com/users/mariodian/repos","events_url":"https://api.github.com/users/mariodian/events{/privacy}","received_events_url":"https://api.github.com/users/mariodian/received_events","type":"User","site_admin":false},"repo":{"id":159816612,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk4MTY2MTI=","name":"btcpayserver","full_name":"mariodian/btcpayserver","private":false,"owner":{"login":"mariodian","id":3636406,"node_id":"MDQ6VXNlcjM2MzY0MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3636406?v=4","gravatar_id":"","url":"https://api.github.com/users/mariodian","html_url":"https://github.com/mariodian","followers_url":"https://api.github.com/users/mariodian/followers","following_url":"https://api.github.com/users/mariodian/following{/other_user}","gists_url":"https://api.github.com/users/mariodian/gists{/gist_id}","starred_url":"https://api.github.com/users/mariodian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariodian/subscriptions","organizations_url":"https://api.github.com/users/mariodian/orgs","repos_url":"https://api.github.com/users/mariodian/repos","events_url":"https://api.github.com/users/mariodian/events{/privacy}","received_events_url":"https://api.github.com/users/mariodian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mariodian/btcpayserver","description":"A cross platform, self-hosted server compatible with Bitpay API ","fork":true,"url":"https://api.github.com/repos/mariodian/btcpayserver","forks_url":"https://api.github.com/repos/mariodian/btcpayserver/forks","keys_url":"https://api.github.com/repos/mariodian/btcpayserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariodian/btcpayserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariodian/btcpayserver/teams","hooks_url":"https://api.github.com/repos/mariodian/btcpayserver/hooks","issue_events_url":"https://api.github.com/repos/mariodian/btcpayserver/issues/events{/number}","events_url":"https://api.github.com/repos/mariodian/btcpayserver/events","assignees_url":"https://api.github.com/repos/mariodian/btcpayserver/assignees{/user}","branches_url":"https://api.github.com/repos/mariodian/btcpayserver/branches{/branch}","tags_url":"https://api.github.com/repos/mariodian/btcpayserver/tags","blobs_url":"https://api.github.com/repos/mariodian/btcpayserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariodian/btcpayserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariodian/btcpayserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariodian/btcpayserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariodian/btcpayserver/statuses/{sha}","languages_url":"https://api.github.com/repos/mariodian/btcpayserver/languages","stargazers_url":"https://api.github.com/repos/mariodian/btcpayserver/stargazers","contributors_url":"https://api.github.com/repos/mariodian/btcpayserver/contributors","subscribers_url":"https://api.github.com/repos/mariodian/btcpayserver/subscribers","subscription_url":"https://api.github.com/repos/mariodian/btcpayserver/subscription","commits_url":"https://api.github.com/repos/mariodian/btcpayserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariodian/btcpayserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariodian/btcpayserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariodian/btcpayserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariodian/btcpayserver/contents/{+path}","compare_url":"https://api.github.com/repos/mariodian/btcpayserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariodian/btcpayserver/merges","archive_url":"https://api.github.com/repos/mariodian/btcpayserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariodian/btcpayserver/downloads","issues_url":"https://api.github.com/repos/mariodian/btcpayserver/issues{/number}","pulls_url":"https://api.github.com/repos/mariodian/btcpayserver/pulls{/number}","milestones_url":"https://api.github.com/repos/mariodian/btcpayserver/milestones{/number}","notifications_url":"https://api.github.com/repos/mariodian/btcpayserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariodian/btcpayserver/labels{/name}","releases_url":"https://api.github.com/repos/mariodian/btcpayserver/releases{/id}","deployments_url":"https://api.github.com/repos/mariodian/btcpayserver/deployments","created_at":"2018-11-30T11:52:01Z","updated_at":"2018-11-30T11:52:04Z","pushed_at":"2018-11-30T13:14:13Z","git_url":"git://github.com/mariodian/btcpayserver.git","ssh_url":"git@github.com:mariodian/btcpayserver.git","clone_url":"https://github.com/mariodian/btcpayserver.git","svn_url":"https://github.com/mariodian/btcpayserver","homepage":"","size":7495,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"btcpayserver:master","ref":"master","sha":"0eccc6085b82b478194543d183bf8befe7fdadb7","user":{"login":"btcpayserver","id":31132886,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTMyODg2","avatar_url":"https://avatars0.githubusercontent.com/u/31132886?v=4","gravatar_id":"","url":"https://api.github.com/users/btcpayserver","html_url":"https://github.com/btcpayserver","followers_url":"https://api.github.com/users/btcpayserver/followers","following_url":"https://api.github.com/users/btcpayserver/following{/other_user}","gists_url":"https://api.github.com/users/btcpayserver/gists{/gist_id}","starred_url":"https://api.github.com/users/btcpayserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcpayserver/subscriptions","organizations_url":"https://api.github.com/users/btcpayserver/orgs","repos_url":"https://api.github.com/users/btcpayserver/repos","events_url":"https://api.github.com/users/btcpayserver/events{/privacy}","received_events_url":"https://api.github.com/users/btcpayserver/received_events","type":"Organization","site_admin":false},"repo":{"id":100711978,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA3MTE5Nzg=","name":"btcpayserver","full_name":"btcpayserver/btcpayserver","private":false,"owner":{"login":"btcpayserver","id":31132886,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTMyODg2","avatar_url":"https://avatars0.githubusercontent.com/u/31132886?v=4","gravatar_id":"","url":"https://api.github.com/users/btcpayserver","html_url":"https://github.com/btcpayserver","followers_url":"https://api.github.com/users/btcpayserver/followers","following_url":"https://api.github.com/users/btcpayserver/following{/other_user}","gists_url":"https://api.github.com/users/btcpayserver/gists{/gist_id}","starred_url":"https://api.github.com/users/btcpayserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcpayserver/subscriptions","organizations_url":"https://api.github.com/users/btcpayserver/orgs","repos_url":"https://api.github.com/users/btcpayserver/repos","events_url":"https://api.github.com/users/btcpayserver/events{/privacy}","received_events_url":"https://api.github.com/users/btcpayserver/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/btcpayserver/btcpayserver","description":"A cross platform, self-hosted server compatible with Bitpay API ","fork":false,"url":"https://api.github.com/repos/btcpayserver/btcpayserver","forks_url":"https://api.github.com/repos/btcpayserver/btcpayserver/forks","keys_url":"https://api.github.com/repos/btcpayserver/btcpayserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btcpayserver/btcpayserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btcpayserver/btcpayserver/teams","hooks_url":"https://api.github.com/repos/btcpayserver/btcpayserver/hooks","issue_events_url":"https://api.github.com/repos/btcpayserver/btcpayserver/issues/events{/number}","events_url":"https://api.github.com/repos/btcpayserver/btcpayserver/events","assignees_url":"https://api.github.com/repos/btcpayserver/btcpayserver/assignees{/user}","branches_url":"https://api.github.com/repos/btcpayserver/btcpayserver/branches{/branch}","tags_url":"https://api.github.com/repos/btcpayserver/btcpayserver/tags","blobs_url":"https://api.github.com/repos/btcpayserver/btcpayserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btcpayserver/btcpayserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btcpayserver/btcpayserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/btcpayserver/btcpayserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btcpayserver/btcpayserver/statuses/{sha}","languages_url":"https://api.github.com/repos/btcpayserver/btcpayserver/languages","stargazers_url":"https://api.github.com/repos/btcpayserver/btcpayserver/stargazers","contributors_url":"https://api.github.com/repos/btcpayserver/btcpayserver/contributors","subscribers_url":"https://api.github.com/repos/btcpayserver/btcpayserver/subscribers","subscription_url":"https://api.github.com/repos/btcpayserver/btcpayserver/subscription","commits_url":"https://api.github.com/repos/btcpayserver/btcpayserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/btcpayserver/btcpayserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/btcpayserver/btcpayserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/btcpayserver/btcpayserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/btcpayserver/btcpayserver/contents/{+path}","compare_url":"https://api.github.com/repos/btcpayserver/btcpayserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btcpayserver/btcpayserver/merges","archive_url":"https://api.github.com/repos/btcpayserver/btcpayserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btcpayserver/btcpayserver/downloads","issues_url":"https://api.github.com/repos/btcpayserver/btcpayserver/issues{/number}","pulls_url":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls{/number}","milestones_url":"https://api.github.com/repos/btcpayserver/btcpayserver/milestones{/number}","notifications_url":"https://api.github.com/repos/btcpayserver/btcpayserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btcpayserver/btcpayserver/labels{/name}","releases_url":"https://api.github.com/repos/btcpayserver/btcpayserver/releases{/id}","deployments_url":"https://api.github.com/repos/btcpayserver/btcpayserver/deployments","created_at":"2017-08-18T12:57:05Z","updated_at":"2018-11-30T10:37:21Z","pushed_at":"2018-11-30T14:36:26Z","git_url":"git://github.com/btcpayserver/btcpayserver.git","ssh_url":"git@github.com:btcpayserver/btcpayserver.git","clone_url":"https://github.com/btcpayserver/btcpayserver.git","svn_url":"https://github.com/btcpayserver/btcpayserver","homepage":"","size":7488,"stargazers_count":616,"watchers_count":616,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":157,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":157,"open_issues":71,"watchers":616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/428"},"html":{"href":"https://github.com/btcpayserver/btcpayserver/pull/428"},"issue":{"href":"https://api.github.com/repos/btcpayserver/btcpayserver/issues/428"},"comments":{"href":"https://api.github.com/repos/btcpayserver/btcpayserver/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/btcpayserver/btcpayserver/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/btcpayserver/btcpayserver/statuses/f2a43ad1f3126cf0ecba5b25df9c2621893ae7c3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mariodian"}}