{"action":"created","comment":{"url":"https://api.github.com/repos/project8/psyllid/pulls/comments/190735033","pull_request_review_id":123177673,"id":190735033,"diff_hunk":"@@ -102,15 +109,26 @@ namespace psyllid\n             void set_threshold_ampl_snr( double a_ampl_snr );\n             void set_threshold_power_snr( double a_power_snr );\n             void set_threshold_power_snr_high( double a_power_snr);\n+            void set_threshold_power_sigma( double a_power_sigma );\n+            void set_threshold_power_sigma_high( double a_power_sigma);\n             void set_threshold_dB( double a_dB );\n             void set_trigger_mode( const std::string& trigger_mode );\n+            void set_threshold_type( const std::string& threshold_type );\n             std::string get_trigger_mode_str() const;\n-            void set_mask_and_data_vectors( const scarab::param_node* a_mask_and_data_values );\n+            std::string get_threshold_type_str() const;\n+\n+            void calulcate_snr_mask_spline_points(std::vector< double >& t_x_vals, std::vector< double >& t_y_vals, const double& threshold);","path":"source/daq/frequency_mask_trigger.hh","position":null,"original_position":34,"commit_id":"eb52ae2edec2215a8173968ea4029734a6e6d267","original_commit_id":"bfe9f9d7a3eadd9a5fc643799efafbba31f79151","user":{"login":"laroque","id":830135,"avatar_url":"https://avatars0.githubusercontent.com/u/830135?v=4","gravatar_id":"","url":"https://api.github.com/users/laroque","html_url":"https://github.com/laroque","followers_url":"https://api.github.com/users/laroque/followers","following_url":"https://api.github.com/users/laroque/following{/other_user}","gists_url":"https://api.github.com/users/laroque/gists{/gist_id}","starred_url":"https://api.github.com/users/laroque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laroque/subscriptions","organizations_url":"https://api.github.com/users/laroque/orgs","repos_url":"https://api.github.com/users/laroque/repos","events_url":"https://api.github.com/users/laroque/events{/privacy}","received_events_url":"https://api.github.com/users/laroque/received_events","type":"User","site_admin":false},"body":"not sure, now it is a value","created_at":"2018-05-24T21:22:55Z","updated_at":"2018-05-24T21:22:55Z","html_url":"https://github.com/project8/psyllid/pull/74#discussion_r190735033","pull_request_url":"https://api.github.com/repos/project8/psyllid/pulls/74","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/project8/psyllid/pulls/comments/190735033"},"html":{"href":"https://github.com/project8/psyllid/pull/74#discussion_r190735033"},"pull_request":{"href":"https://api.github.com/repos/project8/psyllid/pulls/74"}},"in_reply_to_id":190433076},"pull_request":{"url":"https://api.github.com/repos/project8/psyllid/pulls/74","id":189151646,"html_url":"https://github.com/project8/psyllid/pull/74","diff_url":"https://github.com/project8/psyllid/pull/74.diff","patch_url":"https://github.com/project8/psyllid/pull/74.patch","issue_url":"https://api.github.com/repos/project8/psyllid/issues/74","number":74,"state":"open","locked":false,"title":"Feature/sigma mask","user":{"login":"cclaessens","id":16554883,"avatar_url":"https://avatars3.githubusercontent.com/u/16554883?v=4","gravatar_id":"","url":"https://api.github.com/users/cclaessens","html_url":"https://github.com/cclaessens","followers_url":"https://api.github.com/users/cclaessens/followers","following_url":"https://api.github.com/users/cclaessens/following{/other_user}","gists_url":"https://api.github.com/users/cclaessens/gists{/gist_id}","starred_url":"https://api.github.com/users/cclaessens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclaessens/subscriptions","organizations_url":"https://api.github.com/users/cclaessens/orgs","repos_url":"https://api.github.com/users/cclaessens/repos","events_url":"https://api.github.com/users/cclaessens/events{/privacy}","received_events_url":"https://api.github.com/users/cclaessens/received_events","type":"User","site_admin":false},"body":"Option to use sigma mask instead of snr mask.\r\n2-level-trigger has 2 masks instead of calculating thresholds from one single mask.\r\nwrite-mask writes mean, variance and both masks if present.","created_at":"2018-05-18T22:54:22Z","updated_at":"2018-05-24T21:22:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff7f465eb5ab6ca53d5d6c3ecb3d52570a37a4cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/project8/psyllid/pulls/74/commits","review_comments_url":"https://api.github.com/repos/project8/psyllid/pulls/74/comments","review_comment_url":"https://api.github.com/repos/project8/psyllid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/project8/psyllid/issues/74/comments","statuses_url":"https://api.github.com/repos/project8/psyllid/statuses/eb52ae2edec2215a8173968ea4029734a6e6d267","head":{"label":"project8:feature/sigma_mask","ref":"feature/sigma_mask","sha":"eb52ae2edec2215a8173968ea4029734a6e6d267","user":{"login":"project8","id":664678,"avatar_url":"https://avatars3.githubusercontent.com/u/664678?v=4","gravatar_id":"","url":"https://api.github.com/users/project8","html_url":"https://github.com/project8","followers_url":"https://api.github.com/users/project8/followers","following_url":"https://api.github.com/users/project8/following{/other_user}","gists_url":"https://api.github.com/users/project8/gists{/gist_id}","starred_url":"https://api.github.com/users/project8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project8/subscriptions","organizations_url":"https://api.github.com/users/project8/orgs","repos_url":"https://api.github.com/users/project8/repos","events_url":"https://api.github.com/users/project8/events{/privacy}","received_events_url":"https://api.github.com/users/project8/received_events","type":"Organization","site_admin":false},"repo":{"id":48388086,"name":"psyllid","full_name":"project8/psyllid","owner":{"login":"project8","id":664678,"avatar_url":"https://avatars3.githubusercontent.com/u/664678?v=4","gravatar_id":"","url":"https://api.github.com/users/project8","html_url":"https://github.com/project8","followers_url":"https://api.github.com/users/project8/followers","following_url":"https://api.github.com/users/project8/following{/other_user}","gists_url":"https://api.github.com/users/project8/gists{/gist_id}","starred_url":"https://api.github.com/users/project8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project8/subscriptions","organizations_url":"https://api.github.com/users/project8/orgs","repos_url":"https://api.github.com/users/project8/repos","events_url":"https://api.github.com/users/project8/events{/privacy}","received_events_url":"https://api.github.com/users/project8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/project8/psyllid","description":"Data acquisition package for the ROACH2 system","fork":false,"url":"https://api.github.com/repos/project8/psyllid","forks_url":"https://api.github.com/repos/project8/psyllid/forks","keys_url":"https://api.github.com/repos/project8/psyllid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/project8/psyllid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/project8/psyllid/teams","hooks_url":"https://api.github.com/repos/project8/psyllid/hooks","issue_events_url":"https://api.github.com/repos/project8/psyllid/issues/events{/number}","events_url":"https://api.github.com/repos/project8/psyllid/events","assignees_url":"https://api.github.com/repos/project8/psyllid/assignees{/user}","branches_url":"https://api.github.com/repos/project8/psyllid/branches{/branch}","tags_url":"https://api.github.com/repos/project8/psyllid/tags","blobs_url":"https://api.github.com/repos/project8/psyllid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/project8/psyllid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/project8/psyllid/git/refs{/sha}","trees_url":"https://api.github.com/repos/project8/psyllid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/project8/psyllid/statuses/{sha}","languages_url":"https://api.github.com/repos/project8/psyllid/languages","stargazers_url":"https://api.github.com/repos/project8/psyllid/stargazers","contributors_url":"https://api.github.com/repos/project8/psyllid/contributors","subscribers_url":"https://api.github.com/repos/project8/psyllid/subscribers","subscription_url":"https://api.github.com/repos/project8/psyllid/subscription","commits_url":"https://api.github.com/repos/project8/psyllid/commits{/sha}","git_commits_url":"https://api.github.com/repos/project8/psyllid/git/commits{/sha}","comments_url":"https://api.github.com/repos/project8/psyllid/comments{/number}","issue_comment_url":"https://api.github.com/repos/project8/psyllid/issues/comments{/number}","contents_url":"https://api.github.com/repos/project8/psyllid/contents/{+path}","compare_url":"https://api.github.com/repos/project8/psyllid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/project8/psyllid/merges","archive_url":"https://api.github.com/repos/project8/psyllid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/project8/psyllid/downloads","issues_url":"https://api.github.com/repos/project8/psyllid/issues{/number}","pulls_url":"https://api.github.com/repos/project8/psyllid/pulls{/number}","milestones_url":"https://api.github.com/repos/project8/psyllid/milestones{/number}","notifications_url":"https://api.github.com/repos/project8/psyllid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/project8/psyllid/labels{/name}","releases_url":"https://api.github.com/repos/project8/psyllid/releases{/id}","deployments_url":"https://api.github.com/repos/project8/psyllid/deployments","created_at":"2015-12-21T18:41:52Z","updated_at":"2018-05-22T22:12:30Z","pushed_at":"2018-05-24T21:16:22Z","git_url":"git://github.com/project8/psyllid.git","ssh_url":"git@github.com:project8/psyllid.git","clone_url":"https://github.com/project8/psyllid.git","svn_url":"https://github.com/project8/psyllid","homepage":null,"size":887,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":20,"watchers":0,"default_branch":"develop"}},"base":{"label":"project8:develop","ref":"develop","sha":"e3d1df977feb1b94e34c3e4f579e77462a7a2f73","user":{"login":"project8","id":664678,"avatar_url":"https://avatars3.githubusercontent.com/u/664678?v=4","gravatar_id":"","url":"https://api.github.com/users/project8","html_url":"https://github.com/project8","followers_url":"https://api.github.com/users/project8/followers","following_url":"https://api.github.com/users/project8/following{/other_user}","gists_url":"https://api.github.com/users/project8/gists{/gist_id}","starred_url":"https://api.github.com/users/project8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project8/subscriptions","organizations_url":"https://api.github.com/users/project8/orgs","repos_url":"https://api.github.com/users/project8/repos","events_url":"https://api.github.com/users/project8/events{/privacy}","received_events_url":"https://api.github.com/users/project8/received_events","type":"Organization","site_admin":false},"repo":{"id":48388086,"name":"psyllid","full_name":"project8/psyllid","owner":{"login":"project8","id":664678,"avatar_url":"https://avatars3.githubusercontent.com/u/664678?v=4","gravatar_id":"","url":"https://api.github.com/users/project8","html_url":"https://github.com/project8","followers_url":"https://api.github.com/users/project8/followers","following_url":"https://api.github.com/users/project8/following{/other_user}","gists_url":"https://api.github.com/users/project8/gists{/gist_id}","starred_url":"https://api.github.com/users/project8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project8/subscriptions","organizations_url":"https://api.github.com/users/project8/orgs","repos_url":"https://api.github.com/users/project8/repos","events_url":"https://api.github.com/users/project8/events{/privacy}","received_events_url":"https://api.github.com/users/project8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/project8/psyllid","description":"Data acquisition package for the ROACH2 system","fork":false,"url":"https://api.github.com/repos/project8/psyllid","forks_url":"https://api.github.com/repos/project8/psyllid/forks","keys_url":"https://api.github.com/repos/project8/psyllid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/project8/psyllid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/project8/psyllid/teams","hooks_url":"https://api.github.com/repos/project8/psyllid/hooks","issue_events_url":"https://api.github.com/repos/project8/psyllid/issues/events{/number}","events_url":"https://api.github.com/repos/project8/psyllid/events","assignees_url":"https://api.github.com/repos/project8/psyllid/assignees{/user}","branches_url":"https://api.github.com/repos/project8/psyllid/branches{/branch}","tags_url":"https://api.github.com/repos/project8/psyllid/tags","blobs_url":"https://api.github.com/repos/project8/psyllid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/project8/psyllid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/project8/psyllid/git/refs{/sha}","trees_url":"https://api.github.com/repos/project8/psyllid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/project8/psyllid/statuses/{sha}","languages_url":"https://api.github.com/repos/project8/psyllid/languages","stargazers_url":"https://api.github.com/repos/project8/psyllid/stargazers","contributors_url":"https://api.github.com/repos/project8/psyllid/contributors","subscribers_url":"https://api.github.com/repos/project8/psyllid/subscribers","subscription_url":"https://api.github.com/repos/project8/psyllid/subscription","commits_url":"https://api.github.com/repos/project8/psyllid/commits{/sha}","git_commits_url":"https://api.github.com/repos/project8/psyllid/git/commits{/sha}","comments_url":"https://api.github.com/repos/project8/psyllid/comments{/number}","issue_comment_url":"https://api.github.com/repos/project8/psyllid/issues/comments{/number}","contents_url":"https://api.github.com/repos/project8/psyllid/contents/{+path}","compare_url":"https://api.github.com/repos/project8/psyllid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/project8/psyllid/merges","archive_url":"https://api.github.com/repos/project8/psyllid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/project8/psyllid/downloads","issues_url":"https://api.github.com/repos/project8/psyllid/issues{/number}","pulls_url":"https://api.github.com/repos/project8/psyllid/pulls{/number}","milestones_url":"https://api.github.com/repos/project8/psyllid/milestones{/number}","notifications_url":"https://api.github.com/repos/project8/psyllid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/project8/psyllid/labels{/name}","releases_url":"https://api.github.com/repos/project8/psyllid/releases{/id}","deployments_url":"https://api.github.com/repos/project8/psyllid/deployments","created_at":"2015-12-21T18:41:52Z","updated_at":"2018-05-22T22:12:30Z","pushed_at":"2018-05-24T21:16:22Z","git_url":"git://github.com/project8/psyllid.git","ssh_url":"git@github.com:project8/psyllid.git","clone_url":"https://github.com/project8/psyllid.git","svn_url":"https://github.com/project8/psyllid","homepage":null,"size":887,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":20,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/project8/psyllid/pulls/74"},"html":{"href":"https://github.com/project8/psyllid/pull/74"},"issue":{"href":"https://api.github.com/repos/project8/psyllid/issues/74"},"comments":{"href":"https://api.github.com/repos/project8/psyllid/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/project8/psyllid/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/project8/psyllid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/project8/psyllid/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/project8/psyllid/statuses/eb52ae2edec2215a8173968ea4029734a6e6d267"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"laroque"}}