{"action":"reopened","number":13341,"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/13341","id":214620603,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NjIwNjAz","html_url":"https://github.com/fastlane/fastlane/pull/13341","diff_url":"https://github.com/fastlane/fastlane/pull/13341.diff","patch_url":"https://github.com/fastlane/fastlane/pull/13341.patch","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/13341","number":13341,"state":"open","locked":false,"title":"downloads_dsyms: Checking also \"displayVersionNumber\"","user":{"login":"bguidolim","id":987360,"node_id":"MDQ6VXNlcjk4NzM2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/987360?v=4","gravatar_id":"","url":"https://api.github.com/users/bguidolim","html_url":"https://github.com/bguidolim","followers_url":"https://api.github.com/users/bguidolim/followers","following_url":"https://api.github.com/users/bguidolim/following{/other_user}","gists_url":"https://api.github.com/users/bguidolim/gists{/gist_id}","starred_url":"https://api.github.com/users/bguidolim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bguidolim/subscriptions","organizations_url":"https://api.github.com/users/bguidolim/orgs","repos_url":"https://api.github.com/users/bguidolim/repos","events_url":"https://api.github.com/users/bguidolim/events{/privacy}","received_events_url":"https://api.github.com/users/bguidolim/received_events","type":"User","site_admin":false},"body":"### Checklist\r\n- [x] I've run `bundle exec rspec` from the root directory to see all new and existing tests pass\r\n- [x] I've followed the _fastlane_ code style and run `bundle exec rubocop -a` to ensure the code style is valid\r\n- [x] I've read the [Contribution Guidelines](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n- [x] I've updated the documentation if necessary.\r\n\r\n### Motivation and Context\r\nI was facing a problem with `download_dsyms` action, it was caused firstly for a misconfiguration on App Store Connect. Below the steps to reproduce:\r\n\r\n1. Register a new app with version 1.0\r\n1. Set your app version (Xcode) to 1.0.0\r\n1. Upload the app to TestFlight\r\n\r\nI know that's not a common path, but could happen. The JSON provided by App Store Connect API will return a train with `versionString: \"1.0\"` (currently in use to check) and `displayVersionString: \"1.0.0\"`.\r\n\r\nFor some reason, Apple is using the app store version (1.0) as a key to get the builds but displaying (1.0.0) to the list.\r\n\r\nI've tried to change the app store number from 1.0 to 1.0.0, but the JSON still using 1.0 as the identifier.\r\n\r\n### Description\r\n\r\nIn order to fix that, I've added a new check to the action as a rescue check before return the error.\r\n","created_at":"2018-09-11T12:48:07Z","updated_at":"2018-09-20T19:45:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e29a2e28890520ea270118d51ad5a45c0df4725","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":560540952,"node_id":"MDU6TGFiZWw1NjA1NDA5NTI=","url":"https://api.github.com/repos/fastlane/fastlane/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/fastlane/pulls/13341/commits","review_comments_url":"https://api.github.com/repos/fastlane/fastlane/pulls/13341/comments","review_comment_url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/13341/comments","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/43574e10d57ea6396f54d507e6b4aa681977f2dd","head":{"label":"bguidolim:fix-download-dsyms-version","ref":"fix-download-dsyms-version","sha":"43574e10d57ea6396f54d507e6b4aa681977f2dd","user":{"login":"bguidolim","id":987360,"node_id":"MDQ6VXNlcjk4NzM2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/987360?v=4","gravatar_id":"","url":"https://api.github.com/users/bguidolim","html_url":"https://github.com/bguidolim","followers_url":"https://api.github.com/users/bguidolim/followers","following_url":"https://api.github.com/users/bguidolim/following{/other_user}","gists_url":"https://api.github.com/users/bguidolim/gists{/gist_id}","starred_url":"https://api.github.com/users/bguidolim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bguidolim/subscriptions","organizations_url":"https://api.github.com/users/bguidolim/orgs","repos_url":"https://api.github.com/users/bguidolim/repos","events_url":"https://api.github.com/users/bguidolim/events{/privacy}","received_events_url":"https://api.github.com/users/bguidolim/received_events","type":"User","site_admin":false},"repo":{"id":121507466,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1MDc0NjY=","name":"fastlane","full_name":"bguidolim/fastlane","private":false,"owner":{"login":"bguidolim","id":987360,"node_id":"MDQ6VXNlcjk4NzM2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/987360?v=4","gravatar_id":"","url":"https://api.github.com/users/bguidolim","html_url":"https://github.com/bguidolim","followers_url":"https://api.github.com/users/bguidolim/followers","following_url":"https://api.github.com/users/bguidolim/following{/other_user}","gists_url":"https://api.github.com/users/bguidolim/gists{/gist_id}","starred_url":"https://api.github.com/users/bguidolim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bguidolim/subscriptions","organizations_url":"https://api.github.com/users/bguidolim/orgs","repos_url":"https://api.github.com/users/bguidolim/repos","events_url":"https://api.github.com/users/bguidolim/events{/privacy}","received_events_url":"https://api.github.com/users/bguidolim/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bguidolim/fastlane","description":"🚀 The easiest way to automate building and releasing your iOS and Android apps","fork":true,"url":"https://api.github.com/repos/bguidolim/fastlane","forks_url":"https://api.github.com/repos/bguidolim/fastlane/forks","keys_url":"https://api.github.com/repos/bguidolim/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bguidolim/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bguidolim/fastlane/teams","hooks_url":"https://api.github.com/repos/bguidolim/fastlane/hooks","issue_events_url":"https://api.github.com/repos/bguidolim/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/bguidolim/fastlane/events","assignees_url":"https://api.github.com/repos/bguidolim/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/bguidolim/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/bguidolim/fastlane/tags","blobs_url":"https://api.github.com/repos/bguidolim/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bguidolim/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bguidolim/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/bguidolim/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bguidolim/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/bguidolim/fastlane/languages","stargazers_url":"https://api.github.com/repos/bguidolim/fastlane/stargazers","contributors_url":"https://api.github.com/repos/bguidolim/fastlane/contributors","subscribers_url":"https://api.github.com/repos/bguidolim/fastlane/subscribers","subscription_url":"https://api.github.com/repos/bguidolim/fastlane/subscription","commits_url":"https://api.github.com/repos/bguidolim/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/bguidolim/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/bguidolim/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/bguidolim/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/bguidolim/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/bguidolim/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bguidolim/fastlane/merges","archive_url":"https://api.github.com/repos/bguidolim/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bguidolim/fastlane/downloads","issues_url":"https://api.github.com/repos/bguidolim/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/bguidolim/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/bguidolim/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/bguidolim/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bguidolim/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/bguidolim/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/bguidolim/fastlane/deployments","created_at":"2018-02-14T12:18:34Z","updated_at":"2018-09-19T12:58:39Z","pushed_at":"2018-09-19T12:58:54Z","git_url":"git://github.com/bguidolim/fastlane.git","ssh_url":"git@github.com:bguidolim/fastlane.git","clone_url":"https://github.com/bguidolim/fastlane.git","svn_url":"https://github.com/bguidolim/fastlane","homepage":"https://fastlane.tools","size":63522,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"70c309070ce63c92f827afa6a0da89e032a9296d","user":{"login":"fastlane","id":11098337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDk4MzM3","avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"node_id":"MDEwOlJlcG9zaXRvcnkyNzQ0Mjk2Nw==","name":"fastlane","full_name":"fastlane/fastlane","private":false,"owner":{"login":"fastlane","id":11098337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDk4MzM3","avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fastlane/fastlane","description":"🚀 The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2018-09-20T18:34:57Z","pushed_at":"2018-09-20T18:19:30Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":63777,"stargazers_count":23165,"watchers_count":23165,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3530,"mirror_url":null,"archived":false,"open_issues_count":240,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3530,"open_issues":240,"watchers":23165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/13341"},"html":{"href":"https://github.com/fastlane/fastlane/pull/13341"},"issue":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/13341"},"comments":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/13341/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/13341/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/13341/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/fastlane/statuses/43574e10d57ea6396f54d507e6b4aa681977f2dd"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":5,"maintainer_can_modify":true,"commits":3,"additions":30,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"bguidolim"}}