{"action":"created","issue":{"url":"https://api.github.com/repos/luca-scr/GA/issues/11","repository_url":"https://api.github.com/repos/luca-scr/GA","labels_url":"https://api.github.com/repos/luca-scr/GA/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/luca-scr/GA/issues/11/comments","events_url":"https://api.github.com/repos/luca-scr/GA/issues/11/events","html_url":"https://github.com/luca-scr/GA/pull/11","id":294100632,"number":11,"title":"Fix compile errors on Windows (and Linux?)","user":{"login":"yutannihilation","id":1978793,"avatar_url":"https://avatars3.githubusercontent.com/u/1978793?v=4","gravatar_id":"","url":"https://api.github.com/users/yutannihilation","html_url":"https://github.com/yutannihilation","followers_url":"https://api.github.com/users/yutannihilation/followers","following_url":"https://api.github.com/users/yutannihilation/following{/other_user}","gists_url":"https://api.github.com/users/yutannihilation/gists{/gist_id}","starred_url":"https://api.github.com/users/yutannihilation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yutannihilation/subscriptions","organizations_url":"https://api.github.com/users/yutannihilation/orgs","repos_url":"https://api.github.com/users/yutannihilation/repos","events_url":"https://api.github.com/users/yutannihilation/events{/privacy}","received_events_url":"https://api.github.com/users/yutannihilation/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-03T10:22:31Z","updated_at":"2018-02-03T15:11:14Z","closed_at":"2018-02-03T15:11:14Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/luca-scr/GA/pulls/11","html_url":"https://github.com/luca-scr/GA/pull/11","diff_url":"https://github.com/luca-scr/GA/pull/11.diff","patch_url":"https://github.com/luca-scr/GA/pull/11.patch"},"body":"Hi, I heard some people can't install this via `install_github()` currently. When I tried by myself, I got two types of errors:\r\n\r\n1. `error: ‘round’ is not a member of ‘std’`\r\n2. `error: 'isnan' was not declared in this scope`\r\n\r\nIIUC, 1. indicates you are trying to use C++11, where `round` is the member of `std` and 2. is just a lack of `std::`, right? This PR is an attempt to fix the problem.\r\n"},"comment":{"url":"https://api.github.com/repos/luca-scr/GA/issues/comments/362820022","html_url":"https://github.com/luca-scr/GA/pull/11#issuecomment-362820022","issue_url":"https://api.github.com/repos/luca-scr/GA/issues/11","id":362820022,"user":{"login":"luca-scr","id":11585946,"avatar_url":"https://avatars2.githubusercontent.com/u/11585946?v=4","gravatar_id":"","url":"https://api.github.com/users/luca-scr","html_url":"https://github.com/luca-scr","followers_url":"https://api.github.com/users/luca-scr/followers","following_url":"https://api.github.com/users/luca-scr/following{/other_user}","gists_url":"https://api.github.com/users/luca-scr/gists{/gist_id}","starred_url":"https://api.github.com/users/luca-scr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luca-scr/subscriptions","organizations_url":"https://api.github.com/users/luca-scr/orgs","repos_url":"https://api.github.com/users/luca-scr/repos","events_url":"https://api.github.com/users/luca-scr/events{/privacy}","received_events_url":"https://api.github.com/users/luca-scr/received_events","type":"User","site_admin":false},"created_at":"2018-02-03T15:11:14Z","updated_at":"2018-02-03T15:11:14Z","author_association":"OWNER","body":"Thanks for reporting the issues. I have included your std::isnan suggestion but not using round function from C++11 since I would like to avoid the further dependency on on C++11. Note also that for vector Rcpp sugar has a round function. Thus for double I wrote my own round function called round_double. Checked the package on windows with rhub package and compile with no errors.\r\n"}}
{"actor":{"display_login":"luca-scr"}}