{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/236069409","pull_request_review_id":178077916,"id":236069409,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA2OTQwOQ==","diff_hunk":"@@ -0,0 +1,17 @@\n+'use strict';\n+const common = require('../common');\n+const fs = require('fs');\n+\n+const tmpdir = require('../common/tmpdir');\n+tmpdir.refresh();\n+\n+test(fs.createReadStream(__filename));\n+test(fs.createWriteStream(`${tmpdir.path}/dummy`));\n+\n+function test(stream) {\n+  const err = new Error('DESTROYED');\n+  stream.destroy(err);\n+  stream.on('open', common.mustNotCall());\n+  stream.on('ready', common.mustNotCall());\n+  stream.on('close', common.mustCall());","path":"test/parallel/test-fs-stream-no-events-after-destroy.js","position":16,"original_position":16,"commit_id":"025534055ff5016af27f0c8658571246fb259930","original_commit_id":"025534055ff5016af27f0c8658571246fb259930","user":{"login":"mcollina","id":52195,"node_id":"MDQ6VXNlcjUyMTk1","avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"body":"There is something off here, `'error'` should be emitted.","created_at":"2018-11-25T11:17:57Z","updated_at":"2018-11-25T11:19:10Z","html_url":"https://github.com/nodejs/node/pull/24055#discussion_r236069409","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/24055","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/236069409"},"html":{"href":"https://github.com/nodejs/node/pull/24055#discussion_r236069409"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/24055"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24055","id":228109331,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTA5MzMx","html_url":"https://github.com/nodejs/node/pull/24055","diff_url":"https://github.com/nodejs/node/pull/24055.diff","patch_url":"https://github.com/nodejs/node/pull/24055.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/24055","number":24055,"state":"open","locked":false,"title":"fs: do not emit open and read if stream destroyed","user":{"login":"dexterleng","id":34204380,"node_id":"MDQ6VXNlcjM0MjA0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/34204380?v=4","gravatar_id":"","url":"https://api.github.com/users/dexterleng","html_url":"https://github.com/dexterleng","followers_url":"https://api.github.com/users/dexterleng/followers","following_url":"https://api.github.com/users/dexterleng/following{/other_user}","gists_url":"https://api.github.com/users/dexterleng/gists{/gist_id}","starred_url":"https://api.github.com/users/dexterleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexterleng/subscriptions","organizations_url":"https://api.github.com/users/dexterleng/orgs","repos_url":"https://api.github.com/users/dexterleng/repos","events_url":"https://api.github.com/users/dexterleng/events{/privacy}","received_events_url":"https://api.github.com/users/dexterleng/received_events","type":"User","site_admin":false},"body":"WIP, will write tests ASAP.\r\n\r\nReferences: #23133\r\n\r\nAddresses this:\r\n\r\n`@mcollina I don’t understand… I’m not talking about changing emit() to be a noop function or so, I’m talking about the individual call sites in our own net, tls, fs, etc. code?`\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)","created_at":"2018-11-03T09:36:17Z","updated_at":"2018-11-25T11:19:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e628a0a4e9630ca196cb349eb5625d290456fd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155435785,"node_id":"MDU6TGFiZWwxNTU0MzU3ODU=","url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc","default":false},{"id":154312478,"node_id":"MDU6TGFiZWwxNTQzMTI0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/work%20in%20progress%20(WIP)","name":"work in progress (WIP)","color":"ffff00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/24055/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/24055/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24055/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/025534055ff5016af27f0c8658571246fb259930","head":{"label":"dexterleng:noop-after-destroy","ref":"noop-after-destroy","sha":"025534055ff5016af27f0c8658571246fb259930","user":{"login":"dexterleng","id":34204380,"node_id":"MDQ6VXNlcjM0MjA0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/34204380?v=4","gravatar_id":"","url":"https://api.github.com/users/dexterleng","html_url":"https://github.com/dexterleng","followers_url":"https://api.github.com/users/dexterleng/followers","following_url":"https://api.github.com/users/dexterleng/following{/other_user}","gists_url":"https://api.github.com/users/dexterleng/gists{/gist_id}","starred_url":"https://api.github.com/users/dexterleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexterleng/subscriptions","organizations_url":"https://api.github.com/users/dexterleng/orgs","repos_url":"https://api.github.com/users/dexterleng/repos","events_url":"https://api.github.com/users/dexterleng/events{/privacy}","received_events_url":"https://api.github.com/users/dexterleng/received_events","type":"User","site_admin":false},"repo":{"id":153874734,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM4NzQ3MzQ=","name":"node","full_name":"dexterleng/node","private":false,"owner":{"login":"dexterleng","id":34204380,"node_id":"MDQ6VXNlcjM0MjA0Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/34204380?v=4","gravatar_id":"","url":"https://api.github.com/users/dexterleng","html_url":"https://github.com/dexterleng","followers_url":"https://api.github.com/users/dexterleng/followers","following_url":"https://api.github.com/users/dexterleng/following{/other_user}","gists_url":"https://api.github.com/users/dexterleng/gists{/gist_id}","starred_url":"https://api.github.com/users/dexterleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexterleng/subscriptions","organizations_url":"https://api.github.com/users/dexterleng/orgs","repos_url":"https://api.github.com/users/dexterleng/repos","events_url":"https://api.github.com/users/dexterleng/events{/privacy}","received_events_url":"https://api.github.com/users/dexterleng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dexterleng/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/dexterleng/node","forks_url":"https://api.github.com/repos/dexterleng/node/forks","keys_url":"https://api.github.com/repos/dexterleng/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dexterleng/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dexterleng/node/teams","hooks_url":"https://api.github.com/repos/dexterleng/node/hooks","issue_events_url":"https://api.github.com/repos/dexterleng/node/issues/events{/number}","events_url":"https://api.github.com/repos/dexterleng/node/events","assignees_url":"https://api.github.com/repos/dexterleng/node/assignees{/user}","branches_url":"https://api.github.com/repos/dexterleng/node/branches{/branch}","tags_url":"https://api.github.com/repos/dexterleng/node/tags","blobs_url":"https://api.github.com/repos/dexterleng/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dexterleng/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dexterleng/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/dexterleng/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dexterleng/node/statuses/{sha}","languages_url":"https://api.github.com/repos/dexterleng/node/languages","stargazers_url":"https://api.github.com/repos/dexterleng/node/stargazers","contributors_url":"https://api.github.com/repos/dexterleng/node/contributors","subscribers_url":"https://api.github.com/repos/dexterleng/node/subscribers","subscription_url":"https://api.github.com/repos/dexterleng/node/subscription","commits_url":"https://api.github.com/repos/dexterleng/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/dexterleng/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/dexterleng/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/dexterleng/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/dexterleng/node/contents/{+path}","compare_url":"https://api.github.com/repos/dexterleng/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dexterleng/node/merges","archive_url":"https://api.github.com/repos/dexterleng/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dexterleng/node/downloads","issues_url":"https://api.github.com/repos/dexterleng/node/issues{/number}","pulls_url":"https://api.github.com/repos/dexterleng/node/pulls{/number}","milestones_url":"https://api.github.com/repos/dexterleng/node/milestones{/number}","notifications_url":"https://api.github.com/repos/dexterleng/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dexterleng/node/labels{/name}","releases_url":"https://api.github.com/repos/dexterleng/node/releases{/id}","deployments_url":"https://api.github.com/repos/dexterleng/node/deployments","created_at":"2018-10-20T06:01:45Z","updated_at":"2018-10-27T10:07:35Z","pushed_at":"2018-11-25T10:53:11Z","git_url":"git://github.com/dexterleng/node.git","ssh_url":"git@github.com:dexterleng/node.git","clone_url":"https://github.com/dexterleng/node.git","svn_url":"https://github.com/dexterleng/node","homepage":"https://nodejs.org","size":426498,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"35b996d6e89fa9851e163a305bc298ace9f219a2","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-11-25T10:31:14Z","pushed_at":"2018-11-25T10:53:25Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":434452,"stargazers_count":55710,"watchers_count":55710,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12271,"mirror_url":null,"archived":false,"open_issues_count":809,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12271,"open_issues":809,"watchers":55710,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/24055"},"html":{"href":"https://github.com/nodejs/node/pull/24055"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/24055"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/24055/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/24055/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/24055/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/025534055ff5016af27f0c8658571246fb259930"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mcollina"}}