{"action":"opened","number":107,"pull_request":{"url":"https://api.github.com/repos/MisterTea/EternalTerminal/pulls/107","id":182019895,"html_url":"https://github.com/MisterTea/EternalTerminal/pull/107","diff_url":"https://github.com/MisterTea/EternalTerminal/pull/107.diff","patch_url":"https://github.com/MisterTea/EternalTerminal/pull/107.patch","issue_url":"https://api.github.com/repos/MisterTea/EternalTerminal/issues/107","number":107,"state":"open","locked":false,"title":"Increase keepaliveTime when get message from dst terminal to router","user":{"login":"ailzhang","id":5248122,"avatar_url":"https://avatars2.githubusercontent.com/u/5248122?v=4","gravatar_id":"","url":"https://api.github.com/users/ailzhang","html_url":"https://github.com/ailzhang","followers_url":"https://api.github.com/users/ailzhang/followers","following_url":"https://api.github.com/users/ailzhang/following{/other_user}","gists_url":"https://api.github.com/users/ailzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/ailzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ailzhang/subscriptions","organizations_url":"https://api.github.com/users/ailzhang/orgs","repos_url":"https://api.github.com/users/ailzhang/repos","events_url":"https://api.github.com/users/ailzhang/events{/privacy}","received_events_url":"https://api.github.com/users/ailzhang/received_events","type":"User","site_admin":false},"body":"Originally I thought it makes more sense to keep the connection alive only if there's something from client to server direction. However, it's possible that writing from server to client(on jumphost that's from dst terminal to local router) takes too long and use up all the keepalivetime(7s) since last sync with client, which finally result in a fake disconnection from jumphost's perspective. Referring to https://github.com/MisterTea/EternalTerminal/blob/master/terminal/TerminalClient.cpp#L440, we also increase keepaliveTime when something is sent from server to client direction, which turns out to make the jumphost connection more stable in the experiments. \r\n\r\nAlso add some VLOG messages for debugging purpose. ","created_at":"2018-04-17T00:09:37Z","updated_at":"2018-04-17T00:09:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MisterTea/EternalTerminal/pulls/107/commits","review_comments_url":"https://api.github.com/repos/MisterTea/EternalTerminal/pulls/107/comments","review_comment_url":"https://api.github.com/repos/MisterTea/EternalTerminal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MisterTea/EternalTerminal/issues/107/comments","statuses_url":"https://api.github.com/repos/MisterTea/EternalTerminal/statuses/39ba74021f17b49109fb30b4331d75306bd44775","head":{"label":"MisterTea:jumphost_keepalive","ref":"jumphost_keepalive","sha":"39ba74021f17b49109fb30b4331d75306bd44775","user":{"login":"MisterTea","id":306879,"avatar_url":"https://avatars1.githubusercontent.com/u/306879?v=4","gravatar_id":"","url":"https://api.github.com/users/MisterTea","html_url":"https://github.com/MisterTea","followers_url":"https://api.github.com/users/MisterTea/followers","following_url":"https://api.github.com/users/MisterTea/following{/other_user}","gists_url":"https://api.github.com/users/MisterTea/gists{/gist_id}","starred_url":"https://api.github.com/users/MisterTea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MisterTea/subscriptions","organizations_url":"https://api.github.com/users/MisterTea/orgs","repos_url":"https://api.github.com/users/MisterTea/repos","events_url":"https://api.github.com/users/MisterTea/events{/privacy}","received_events_url":"https://api.github.com/users/MisterTea/received_events","type":"User","site_admin":false},"repo":{"id":74223162,"name":"EternalTerminal","full_name":"MisterTea/EternalTerminal","owner":{"login":"MisterTea","id":306879,"avatar_url":"https://avatars1.githubusercontent.com/u/306879?v=4","gravatar_id":"","url":"https://api.github.com/users/MisterTea","html_url":"https://github.com/MisterTea","followers_url":"https://api.github.com/users/MisterTea/followers","following_url":"https://api.github.com/users/MisterTea/following{/other_user}","gists_url":"https://api.github.com/users/MisterTea/gists{/gist_id}","starred_url":"https://api.github.com/users/MisterTea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MisterTea/subscriptions","organizations_url":"https://api.github.com/users/MisterTea/orgs","repos_url":"https://api.github.com/users/MisterTea/repos","events_url":"https://api.github.com/users/MisterTea/events{/privacy}","received_events_url":"https://api.github.com/users/MisterTea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MisterTea/EternalTerminal","description":"Re-Connectable secure remote shell","fork":false,"url":"https://api.github.com/repos/MisterTea/EternalTerminal","forks_url":"https://api.github.com/repos/MisterTea/EternalTerminal/forks","keys_url":"https://api.github.com/repos/MisterTea/EternalTerminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MisterTea/EternalTerminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MisterTea/EternalTerminal/teams","hooks_url":"https://api.github.com/repos/MisterTea/EternalTerminal/hooks","issue_events_url":"https://api.github.com/repos/MisterTea/EternalTerminal/issues/events{/number}","events_url":"https://api.github.com/repos/MisterTea/EternalTerminal/events","assignees_url":"https://api.github.com/repos/MisterTea/EternalTerminal/assignees{/user}","branches_url":"https://api.github.com/repos/MisterTea/EternalTerminal/branches{/branch}","tags_url":"https://api.github.com/repos/MisterTea/EternalTerminal/tags","blobs_url":"https://api.github.com/repos/MisterTea/EternalTerminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MisterTea/EternalTerminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MisterTea/EternalTerminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/MisterTea/EternalTerminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MisterTea/EternalTerminal/statuses/{sha}","languages_url":"https://api.github.com/repos/MisterTea/EternalTerminal/languages","stargazers_url":"https://api.github.com/repos/MisterTea/EternalTerminal/stargazers","contributors_url":"https://api.github.com/repos/MisterTea/EternalTerminal/contributors","subscribers_url":"https://api.github.com/repos/MisterTea/EternalTerminal/subscribers","subscription_url":"https://api.github.com/repos/MisterTea/EternalTerminal/subscription","commits_url":"https://api.github.com/repos/MisterTea/EternalTerminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/MisterTea/EternalTerminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/MisterTea/EternalTerminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/MisterTea/EternalTerminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/MisterTea/EternalTerminal/contents/{+path}","compare_url":"https://api.github.com/repos/MisterTea/EternalTerminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MisterTea/EternalTerminal/merges","archive_url":"https://api.github.com/repos/MisterTea/EternalTerminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MisterTea/EternalTerminal/downloads","issues_url":"https://api.github.com/repos/MisterTea/EternalTerminal/issues{/number}","pulls_url":"https://api.github.com/repos/MisterTea/EternalTerminal/pulls{/number}","milestones_url":"https://api.github.com/repos/MisterTea/EternalTerminal/milestones{/number}","notifications_url":"https://api.github.com/repos/MisterTea/EternalTerminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MisterTea/EternalTerminal/labels{/name}","releases_url":"https://api.github.com/repos/MisterTea/EternalTerminal/releases{/id}","deployments_url":"https://api.github.com/repos/MisterTea/EternalTerminal/deployments","created_at":"2016-11-19T17:15:18Z","updated_at":"2018-04-15T11:10:27Z","pushed_at":"2018-04-17T00:05:29Z","git_url":"git://github.com/MisterTea/EternalTerminal.git","ssh_url":"git@github.com:MisterTea/EternalTerminal.git","clone_url":"https://github.com/MisterTea/EternalTerminal.git","svn_url":"https://github.com/MisterTea/EternalTerminal","homepage":"https://mistertea.github.io/EternalTerminal/","size":2083,"stargazers_count":582,"watchers_count":582,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":30,"open_issues":12,"watchers":582,"default_branch":"master"}},"base":{"label":"MisterTea:master","ref":"master","sha":"74329881299132f0b84e4e11c32259b605165fa0","user":{"login":"MisterTea","id":306879,"avatar_url":"https://avatars1.githubusercontent.com/u/306879?v=4","gravatar_id":"","url":"https://api.github.com/users/MisterTea","html_url":"https://github.com/MisterTea","followers_url":"https://api.github.com/users/MisterTea/followers","following_url":"https://api.github.com/users/MisterTea/following{/other_user}","gists_url":"https://api.github.com/users/MisterTea/gists{/gist_id}","starred_url":"https://api.github.com/users/MisterTea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MisterTea/subscriptions","organizations_url":"https://api.github.com/users/MisterTea/orgs","repos_url":"https://api.github.com/users/MisterTea/repos","events_url":"https://api.github.com/users/MisterTea/events{/privacy}","received_events_url":"https://api.github.com/users/MisterTea/received_events","type":"User","site_admin":false},"repo":{"id":74223162,"name":"EternalTerminal","full_name":"MisterTea/EternalTerminal","owner":{"login":"MisterTea","id":306879,"avatar_url":"https://avatars1.githubusercontent.com/u/306879?v=4","gravatar_id":"","url":"https://api.github.com/users/MisterTea","html_url":"https://github.com/MisterTea","followers_url":"https://api.github.com/users/MisterTea/followers","following_url":"https://api.github.com/users/MisterTea/following{/other_user}","gists_url":"https://api.github.com/users/MisterTea/gists{/gist_id}","starred_url":"https://api.github.com/users/MisterTea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MisterTea/subscriptions","organizations_url":"https://api.github.com/users/MisterTea/orgs","repos_url":"https://api.github.com/users/MisterTea/repos","events_url":"https://api.github.com/users/MisterTea/events{/privacy}","received_events_url":"https://api.github.com/users/MisterTea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MisterTea/EternalTerminal","description":"Re-Connectable secure remote shell","fork":false,"url":"https://api.github.com/repos/MisterTea/EternalTerminal","forks_url":"https://api.github.com/repos/MisterTea/EternalTerminal/forks","keys_url":"https://api.github.com/repos/MisterTea/EternalTerminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MisterTea/EternalTerminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MisterTea/EternalTerminal/teams","hooks_url":"https://api.github.com/repos/MisterTea/EternalTerminal/hooks","issue_events_url":"https://api.github.com/repos/MisterTea/EternalTerminal/issues/events{/number}","events_url":"https://api.github.com/repos/MisterTea/EternalTerminal/events","assignees_url":"https://api.github.com/repos/MisterTea/EternalTerminal/assignees{/user}","branches_url":"https://api.github.com/repos/MisterTea/EternalTerminal/branches{/branch}","tags_url":"https://api.github.com/repos/MisterTea/EternalTerminal/tags","blobs_url":"https://api.github.com/repos/MisterTea/EternalTerminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MisterTea/EternalTerminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MisterTea/EternalTerminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/MisterTea/EternalTerminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MisterTea/EternalTerminal/statuses/{sha}","languages_url":"https://api.github.com/repos/MisterTea/EternalTerminal/languages","stargazers_url":"https://api.github.com/repos/MisterTea/EternalTerminal/stargazers","contributors_url":"https://api.github.com/repos/MisterTea/EternalTerminal/contributors","subscribers_url":"https://api.github.com/repos/MisterTea/EternalTerminal/subscribers","subscription_url":"https://api.github.com/repos/MisterTea/EternalTerminal/subscription","commits_url":"https://api.github.com/repos/MisterTea/EternalTerminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/MisterTea/EternalTerminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/MisterTea/EternalTerminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/MisterTea/EternalTerminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/MisterTea/EternalTerminal/contents/{+path}","compare_url":"https://api.github.com/repos/MisterTea/EternalTerminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MisterTea/EternalTerminal/merges","archive_url":"https://api.github.com/repos/MisterTea/EternalTerminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MisterTea/EternalTerminal/downloads","issues_url":"https://api.github.com/repos/MisterTea/EternalTerminal/issues{/number}","pulls_url":"https://api.github.com/repos/MisterTea/EternalTerminal/pulls{/number}","milestones_url":"https://api.github.com/repos/MisterTea/EternalTerminal/milestones{/number}","notifications_url":"https://api.github.com/repos/MisterTea/EternalTerminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MisterTea/EternalTerminal/labels{/name}","releases_url":"https://api.github.com/repos/MisterTea/EternalTerminal/releases{/id}","deployments_url":"https://api.github.com/repos/MisterTea/EternalTerminal/deployments","created_at":"2016-11-19T17:15:18Z","updated_at":"2018-04-15T11:10:27Z","pushed_at":"2018-04-17T00:05:29Z","git_url":"git://github.com/MisterTea/EternalTerminal.git","ssh_url":"git@github.com:MisterTea/EternalTerminal.git","clone_url":"https://github.com/MisterTea/EternalTerminal.git","svn_url":"https://github.com/MisterTea/EternalTerminal","homepage":"https://mistertea.github.io/EternalTerminal/","size":2083,"stargazers_count":582,"watchers_count":582,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":30,"open_issues":12,"watchers":582,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MisterTea/EternalTerminal/pulls/107"},"html":{"href":"https://github.com/MisterTea/EternalTerminal/pull/107"},"issue":{"href":"https://api.github.com/repos/MisterTea/EternalTerminal/issues/107"},"comments":{"href":"https://api.github.com/repos/MisterTea/EternalTerminal/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/MisterTea/EternalTerminal/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/MisterTea/EternalTerminal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MisterTea/EternalTerminal/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/MisterTea/EternalTerminal/statuses/39ba74021f17b49109fb30b4331d75306bd44775"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"ailzhang"}}