{"action":"closed","number":113,"pull_request":{"url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/113","id":220739112,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzM5MTEy","html_url":"https://github.com/openshift/machine-config-operator/pull/113","diff_url":"https://github.com/openshift/machine-config-operator/pull/113.diff","patch_url":"https://github.com/openshift/machine-config-operator/pull/113.patch","issue_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/113","number":113,"state":"closed","locked":false,"title":"remove SCC from machine-config-operator","user":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"The machine-config-operator should not rely on openshift.  The operator is already a cluster-admin so it has rights and its namespace is already excluded from openshift admission. This change simply removes the unnecessary binding and related code.\r\n\r\n@abhinavdahiya Feel free to close if you had a pull in progress.  You pointed it out, figured I'd fix it.","created_at":"2018-10-05T15:24:28Z","updated_at":"2018-10-05T15:40:36Z","closed_at":"2018-10-05T15:40:36Z","merged_at":"2018-10-05T15:40:36Z","merge_commit_sha":"7281d1680b1b24ead022c47225e7dd3668a9592e","assignee":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"assignees":[{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ashcrow","id":22706,"node_id":"MDQ6VXNlcjIyNzA2","avatar_url":"https://avatars3.githubusercontent.com/u/22706?v=4","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},{"login":"yifan-gu","id":3278588,"node_id":"MDQ6VXNlcjMyNzg1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3278588?v=4","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1005850192,"node_id":"MDU6TGFiZWwxMDA1ODUwMTky","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1005849393,"node_id":"MDU6TGFiZWwxMDA1ODQ5Mzkz","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1005853548,"node_id":"MDU6TGFiZWwxMDA1ODUzNTQ4","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/113/commits","review_comments_url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/113/comments","review_comment_url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/113/comments","statuses_url":"https://api.github.com/repos/openshift/machine-config-operator/statuses/38a87c907ae9934716aeef8d3424fc455e4a60c5","head":{"label":"deads2k:remove-scc","ref":"remove-scc","sha":"38a87c907ae9934716aeef8d3424fc455e4a60c5","user":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"repo":{"id":151474773,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE0NzQ3NzM=","name":"machine-config-operator","full_name":"deads2k/machine-config-operator","private":false,"owner":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"html_url":"https://github.com/deads2k/machine-config-operator","description":null,"fork":true,"url":"https://api.github.com/repos/deads2k/machine-config-operator","forks_url":"https://api.github.com/repos/deads2k/machine-config-operator/forks","keys_url":"https://api.github.com/repos/deads2k/machine-config-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deads2k/machine-config-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deads2k/machine-config-operator/teams","hooks_url":"https://api.github.com/repos/deads2k/machine-config-operator/hooks","issue_events_url":"https://api.github.com/repos/deads2k/machine-config-operator/issues/events{/number}","events_url":"https://api.github.com/repos/deads2k/machine-config-operator/events","assignees_url":"https://api.github.com/repos/deads2k/machine-config-operator/assignees{/user}","branches_url":"https://api.github.com/repos/deads2k/machine-config-operator/branches{/branch}","tags_url":"https://api.github.com/repos/deads2k/machine-config-operator/tags","blobs_url":"https://api.github.com/repos/deads2k/machine-config-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deads2k/machine-config-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deads2k/machine-config-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/deads2k/machine-config-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deads2k/machine-config-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/deads2k/machine-config-operator/languages","stargazers_url":"https://api.github.com/repos/deads2k/machine-config-operator/stargazers","contributors_url":"https://api.github.com/repos/deads2k/machine-config-operator/contributors","subscribers_url":"https://api.github.com/repos/deads2k/machine-config-operator/subscribers","subscription_url":"https://api.github.com/repos/deads2k/machine-config-operator/subscription","commits_url":"https://api.github.com/repos/deads2k/machine-config-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/deads2k/machine-config-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/deads2k/machine-config-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/deads2k/machine-config-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/deads2k/machine-config-operator/contents/{+path}","compare_url":"https://api.github.com/repos/deads2k/machine-config-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deads2k/machine-config-operator/merges","archive_url":"https://api.github.com/repos/deads2k/machine-config-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deads2k/machine-config-operator/downloads","issues_url":"https://api.github.com/repos/deads2k/machine-config-operator/issues{/number}","pulls_url":"https://api.github.com/repos/deads2k/machine-config-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/deads2k/machine-config-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/deads2k/machine-config-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deads2k/machine-config-operator/labels{/name}","releases_url":"https://api.github.com/repos/deads2k/machine-config-operator/releases{/id}","deployments_url":"https://api.github.com/repos/deads2k/machine-config-operator/deployments","created_at":"2018-10-03T20:16:20Z","updated_at":"2018-10-05T15:15:39Z","pushed_at":"2018-10-05T15:22:12Z","git_url":"git://github.com/deads2k/machine-config-operator.git","ssh_url":"git@github.com:deads2k/machine-config-operator.git","clone_url":"https://github.com/deads2k/machine-config-operator.git","svn_url":"https://github.com/deads2k/machine-config-operator","homepage":null,"size":5288,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"fc86bc69780c9983caee3d624906e0e5c146184d","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":142336347,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMzYzNDc=","name":"machine-config-operator","full_name":"openshift/machine-config-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/machine-config-operator","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/machine-config-operator","forks_url":"https://api.github.com/repos/openshift/machine-config-operator/forks","keys_url":"https://api.github.com/repos/openshift/machine-config-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/machine-config-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/machine-config-operator/teams","hooks_url":"https://api.github.com/repos/openshift/machine-config-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/machine-config-operator/events","assignees_url":"https://api.github.com/repos/openshift/machine-config-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/machine-config-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/machine-config-operator/tags","blobs_url":"https://api.github.com/repos/openshift/machine-config-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/machine-config-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/machine-config-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/machine-config-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/machine-config-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/machine-config-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/machine-config-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/machine-config-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/machine-config-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/machine-config-operator/subscription","commits_url":"https://api.github.com/repos/openshift/machine-config-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/machine-config-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/machine-config-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/machine-config-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/machine-config-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/machine-config-operator/merges","archive_url":"https://api.github.com/repos/openshift/machine-config-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/machine-config-operator/downloads","issues_url":"https://api.github.com/repos/openshift/machine-config-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/machine-config-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/machine-config-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/machine-config-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/machine-config-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/machine-config-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/machine-config-operator/deployments","created_at":"2018-07-25T18:04:26Z","updated_at":"2018-10-05T02:15:40Z","pushed_at":"2018-10-05T15:40:36Z","git_url":"git://github.com/openshift/machine-config-operator.git","ssh_url":"git@github.com:openshift/machine-config-operator.git","clone_url":"https://github.com/openshift/machine-config-operator.git","svn_url":"https://github.com/openshift/machine-config-operator","homepage":null,"size":5289,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":18,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/machine-config-operator/pulls/113"},"html":{"href":"https://github.com/openshift/machine-config-operator/pull/113"},"issue":{"href":"https://api.github.com/repos/openshift/machine-config-operator/issues/113"},"comments":{"href":"https://api.github.com/repos/openshift/machine-config-operator/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/machine-config-operator/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/machine-config-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/machine-config-operator/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/machine-config-operator/statuses/38a87c907ae9934716aeef8d3424fc455e4a60c5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"openshift-merge-robot","id":30189218,"node_id":"MDQ6VXNlcjMwMTg5MjE4","avatar_url":"https://avatars0.githubusercontent.com/u/30189218?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-merge-robot","html_url":"https://github.com/openshift-merge-robot","followers_url":"https://api.github.com/users/openshift-merge-robot/followers","following_url":"https://api.github.com/users/openshift-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-merge-robot/orgs","repos_url":"https://api.github.com/users/openshift-merge-robot/repos","events_url":"https://api.github.com/users/openshift-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-merge-robot/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":24,"deletions":259,"changed_files":8}}
{"actor":{"display_login":"openshift-merge-robot"}}