{"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit4/pulls/comments/169269468","pull_request_review_id":97766066,"id":169269468,"diff_hunk":"@@ -132,26 +132,41 @@ public String methodA() {\n         @Test\n         public int methodB() {\n             return 0;\n-    \t}\n+        }\n+\n+        public int notAnnotatedMethod() {\n+            return 0;\n+        }\n     }\n \n     @Test\n     public void providesAnnotatedMethodsSortedByName() {\n-    \tTestClass tc = new TestClass(MethodsAnnotated.class);\n-    \tList<FrameworkMethod> annotatedMethods = tc.getAnnotatedMethods();\n-    \tassertThat(\"Wrong number of annotated methods.\",\n-    \t    annotatedMethods.size(), is(3));\n-    \tassertThat(\"First annotated method is wrong.\", annotatedMethods\n-    \t    .iterator().next().getName(), is(\"methodA\"));\n+        TestClass tc = new TestClass(MethodsAnnotated.class);\n+        List<FrameworkMethod> annotatedMethods = tc.getAnnotatedMethods();\n+        assertThat(extractNames(annotatedMethods), anyOf(\n+            //Java < 9:\n+            equalTo(asList(\"methodA\", \"methodB\", \"methodC\")),\n+            //Java >= 9 has annotations on methods of java.lang.Object:\n+            equalTo(asList(\"clone\", \"finalize\", \"getClass\", \"hashCode\",","path":"src/test/java/org/junit/runners/model/TestClassTest.java","position":44,"original_position":44,"commit_id":"7f666297aa55454b461dfea27b1d31ee9a72667d","original_commit_id":"7f666297aa55454b461dfea27b1d31ee9a72667d","user":{"login":"stefanbirkner","id":711349,"avatar_url":"https://avatars1.githubusercontent.com/u/711349?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanbirkner","html_url":"https://github.com/stefanbirkner","followers_url":"https://api.github.com/users/stefanbirkner/followers","following_url":"https://api.github.com/users/stefanbirkner/following{/other_user}","gists_url":"https://api.github.com/users/stefanbirkner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbirkner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbirkner/subscriptions","organizations_url":"https://api.github.com/users/stefanbirkner/orgs","repos_url":"https://api.github.com/users/stefanbirkner/repos","events_url":"https://api.github.com/users/stefanbirkner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbirkner/received_events","type":"User","site_admin":false},"body":"Although I understand your motivation I would like to keep it like it is. Just for simplicity because it works fine and there is no need for an additional filtering. IMHO the problem here is that the test is not good enough. I think about a better test.","created_at":"2018-02-20T10:07:47Z","updated_at":"2018-02-20T10:07:48Z","html_url":"https://github.com/junit-team/junit4/pull/1507#discussion_r169269468","pull_request_url":"https://api.github.com/repos/junit-team/junit4/pulls/1507","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/comments/169269468"},"html":{"href":"https://github.com/junit-team/junit4/pull/1507#discussion_r169269468"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1507"}},"in_reply_to_id":169197509},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit4/pulls/1507","id":169964414,"html_url":"https://github.com/junit-team/junit4/pull/1507","diff_url":"https://github.com/junit-team/junit4/pull/1507.diff","patch_url":"https://github.com/junit-team/junit4/pull/1507.patch","issue_url":"https://api.github.com/repos/junit-team/junit4/issues/1507","number":1507,"state":"open","locked":false,"title":"Fix bug on JDK 9","user":{"login":"stefanbirkner","id":711349,"avatar_url":"https://avatars1.githubusercontent.com/u/711349?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanbirkner","html_url":"https://github.com/stefanbirkner","followers_url":"https://api.github.com/users/stefanbirkner/followers","following_url":"https://api.github.com/users/stefanbirkner/following{/other_user}","gists_url":"https://api.github.com/users/stefanbirkner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbirkner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbirkner/subscriptions","organizations_url":"https://api.github.com/users/stefanbirkner/orgs","repos_url":"https://api.github.com/users/stefanbirkner/repos","events_url":"https://api.github.com/users/stefanbirkner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbirkner/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-19T13:46:18Z","updated_at":"2018-02-20T10:07:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c0f9bcce863f0fe44ab173f737e7c14890e0ac1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":14312,"url":"https://api.github.com/repos/junit-team/junit4/labels/bug","name":"bug","color":"ff0000","default":true}],"milestone":{"url":"https://api.github.com/repos/junit-team/junit4/milestones/3","html_url":"https://github.com/junit-team/junit4/milestone/3","labels_url":"https://api.github.com/repos/junit-team/junit4/milestones/3/labels","id":546227,"number":3,"title":"4.13","description":"","creator":{"login":"kcooney","id":478190,"avatar_url":"https://avatars1.githubusercontent.com/u/478190?v=4","gravatar_id":"","url":"https://api.github.com/users/kcooney","html_url":"https://github.com/kcooney","followers_url":"https://api.github.com/users/kcooney/followers","following_url":"https://api.github.com/users/kcooney/following{/other_user}","gists_url":"https://api.github.com/users/kcooney/gists{/gist_id}","starred_url":"https://api.github.com/users/kcooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcooney/subscriptions","organizations_url":"https://api.github.com/users/kcooney/orgs","repos_url":"https://api.github.com/users/kcooney/repos","events_url":"https://api.github.com/users/kcooney/events{/privacy}","received_events_url":"https://api.github.com/users/kcooney/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":80,"state":"open","created_at":"2014-01-24T07:41:04Z","updated_at":"2018-02-19T13:46:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/junit-team/junit4/pulls/1507/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit4/pulls/1507/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/junit-team/junit4/issues/1507/comments","statuses_url":"https://api.github.com/repos/junit-team/junit4/statuses/7f666297aa55454b461dfea27b1d31ee9a72667d","head":{"label":"stefanbirkner:jdk9","ref":"jdk9","sha":"7f666297aa55454b461dfea27b1d31ee9a72667d","user":{"login":"stefanbirkner","id":711349,"avatar_url":"https://avatars1.githubusercontent.com/u/711349?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanbirkner","html_url":"https://github.com/stefanbirkner","followers_url":"https://api.github.com/users/stefanbirkner/followers","following_url":"https://api.github.com/users/stefanbirkner/following{/other_user}","gists_url":"https://api.github.com/users/stefanbirkner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbirkner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbirkner/subscriptions","organizations_url":"https://api.github.com/users/stefanbirkner/orgs","repos_url":"https://api.github.com/users/stefanbirkner/repos","events_url":"https://api.github.com/users/stefanbirkner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbirkner/received_events","type":"User","site_admin":false},"repo":{"id":2008470,"name":"junit","full_name":"stefanbirkner/junit","owner":{"login":"stefanbirkner","id":711349,"avatar_url":"https://avatars1.githubusercontent.com/u/711349?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanbirkner","html_url":"https://github.com/stefanbirkner","followers_url":"https://api.github.com/users/stefanbirkner/followers","following_url":"https://api.github.com/users/stefanbirkner/following{/other_user}","gists_url":"https://api.github.com/users/stefanbirkner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbirkner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbirkner/subscriptions","organizations_url":"https://api.github.com/users/stefanbirkner/orgs","repos_url":"https://api.github.com/users/stefanbirkner/repos","events_url":"https://api.github.com/users/stefanbirkner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbirkner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanbirkner/junit","description":"A programmer-oriented testing framework for Java.","fork":true,"url":"https://api.github.com/repos/stefanbirkner/junit","forks_url":"https://api.github.com/repos/stefanbirkner/junit/forks","keys_url":"https://api.github.com/repos/stefanbirkner/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanbirkner/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanbirkner/junit/teams","hooks_url":"https://api.github.com/repos/stefanbirkner/junit/hooks","issue_events_url":"https://api.github.com/repos/stefanbirkner/junit/issues/events{/number}","events_url":"https://api.github.com/repos/stefanbirkner/junit/events","assignees_url":"https://api.github.com/repos/stefanbirkner/junit/assignees{/user}","branches_url":"https://api.github.com/repos/stefanbirkner/junit/branches{/branch}","tags_url":"https://api.github.com/repos/stefanbirkner/junit/tags","blobs_url":"https://api.github.com/repos/stefanbirkner/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanbirkner/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanbirkner/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanbirkner/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanbirkner/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanbirkner/junit/languages","stargazers_url":"https://api.github.com/repos/stefanbirkner/junit/stargazers","contributors_url":"https://api.github.com/repos/stefanbirkner/junit/contributors","subscribers_url":"https://api.github.com/repos/stefanbirkner/junit/subscribers","subscription_url":"https://api.github.com/repos/stefanbirkner/junit/subscription","commits_url":"https://api.github.com/repos/stefanbirkner/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanbirkner/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanbirkner/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanbirkner/junit/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanbirkner/junit/contents/{+path}","compare_url":"https://api.github.com/repos/stefanbirkner/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanbirkner/junit/merges","archive_url":"https://api.github.com/repos/stefanbirkner/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanbirkner/junit/downloads","issues_url":"https://api.github.com/repos/stefanbirkner/junit/issues{/number}","pulls_url":"https://api.github.com/repos/stefanbirkner/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanbirkner/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanbirkner/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanbirkner/junit/labels{/name}","releases_url":"https://api.github.com/repos/stefanbirkner/junit/releases{/id}","deployments_url":"https://api.github.com/repos/stefanbirkner/junit/deployments","created_at":"2011-07-06T19:40:54Z","updated_at":"2016-11-09T21:48:15Z","pushed_at":"2018-02-19T14:42:46Z","git_url":"git://github.com/stefanbirkner/junit.git","ssh_url":"git@github.com:stefanbirkner/junit.git","clone_url":"https://github.com/stefanbirkner/junit.git","svn_url":"https://github.com/stefanbirkner/junit","homepage":"www.junit.org","size":12718,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"junit-team:master","ref":"master","sha":"aa02545ce04232dc9806663e5729d12c7de992d5","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars1.githubusercontent.com/u/874086?v=4","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":106310,"name":"junit4","full_name":"junit-team/junit4","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars1.githubusercontent.com/u/874086?v=4","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit4","description":"A programmer-oriented testing framework for Java.","fork":false,"url":"https://api.github.com/repos/junit-team/junit4","forks_url":"https://api.github.com/repos/junit-team/junit4/forks","keys_url":"https://api.github.com/repos/junit-team/junit4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit4/teams","hooks_url":"https://api.github.com/repos/junit-team/junit4/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit4/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit4/events","assignees_url":"https://api.github.com/repos/junit-team/junit4/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit4/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit4/tags","blobs_url":"https://api.github.com/repos/junit-team/junit4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit4/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit4/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit4/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit4/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit4/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit4/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit4/subscription","commits_url":"https://api.github.com/repos/junit-team/junit4/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit4/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit4/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit4/issues/comments{/number}","contents_url":"https://api.github.com/repos/junit-team/junit4/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit4/merges","archive_url":"https://api.github.com/repos/junit-team/junit4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit4/downloads","issues_url":"https://api.github.com/repos/junit-team/junit4/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit4/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit4/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit4/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit4/releases{/id}","deployments_url":"https://api.github.com/repos/junit-team/junit4/deployments","created_at":"2009-01-13T03:41:26Z","updated_at":"2018-02-19T20:46:45Z","pushed_at":"2018-02-19T14:42:48Z","git_url":"git://github.com/junit-team/junit4.git","ssh_url":"git@github.com:junit-team/junit4.git","clone_url":"https://github.com/junit-team/junit4.git","svn_url":"https://github.com/junit-team/junit4","homepage":"https://junit.org/junit4/","size":22432,"stargazers_count":6707,"watchers_count":6707,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2579,"mirror_url":null,"archived":false,"open_issues_count":119,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":2579,"open_issues":119,"watchers":6707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1507"},"html":{"href":"https://github.com/junit-team/junit4/pull/1507"},"issue":{"href":"https://api.github.com/repos/junit-team/junit4/issues/1507"},"comments":{"href":"https://api.github.com/repos/junit-team/junit4/issues/1507/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1507/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1507/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit4/statuses/7f666297aa55454b461dfea27b1d31ee9a72667d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stefanbirkner"}}