{"action":"created","issue":{"url":"https://api.github.com/repos/knative/serving/issues/2477","repository_url":"https://api.github.com/repos/knative/serving","labels_url":"https://api.github.com/repos/knative/serving/issues/2477/labels{/name}","comments_url":"https://api.github.com/repos/knative/serving/issues/2477/comments","events_url":"https://api.github.com/repos/knative/serving/issues/2477/events","html_url":"https://github.com/knative/serving/pull/2477","id":380388519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTk4ODk5","number":2477,"title":"Filter ClusterIngress by controller class","user":{"login":"greghaynes","id":42657,"node_id":"MDQ6VXNlcjQyNjU3","avatar_url":"https://avatars2.githubusercontent.com/u/42657?v=4","gravatar_id":"","url":"https://api.github.com/users/greghaynes","html_url":"https://github.com/greghaynes","followers_url":"https://api.github.com/users/greghaynes/followers","following_url":"https://api.github.com/users/greghaynes/following{/other_user}","gists_url":"https://api.github.com/users/greghaynes/gists{/gist_id}","starred_url":"https://api.github.com/users/greghaynes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greghaynes/subscriptions","organizations_url":"https://api.github.com/users/greghaynes/orgs","repos_url":"https://api.github.com/users/greghaynes/repos","events_url":"https://api.github.com/users/greghaynes/events{/privacy}","received_events_url":"https://api.github.com/users/greghaynes/received_events","type":"User","site_admin":false},"labels":[{"id":864751607,"node_id":"MDU6TGFiZWw4NjQ3NTE2MDc=","url":"https://api.github.com/repos/knative/serving/labels/lgtm","name":"lgtm","color":"ededed","default":false},{"id":859767870,"node_id":"MDU6TGFiZWw4NTk3Njc4NzA=","url":"https://api.github.com/repos/knative/serving/labels/size/M","name":"size/M","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-11-13T19:34:13Z","updated_at":"2018-11-16T02:38:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2477","html_url":"https://github.com/knative/serving/pull/2477","diff_url":"https://github.com/knative/serving/pull/2477.diff","patch_url":"https://github.com/knative/serving/pull/2477.patch"},"body":"In order to support pluggable ClusterIngress controllers we need to\r\nfilter which of these resources we reconcile based on our class\r\nannotation key.\r\n\r\nFixes: #2322\r\n\r\n<!--\r\nRequest Prow to automatically lint any go code in this PR:\r\n\r\n/lint\r\n-->\r\n\r\n**Release Note**\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n```release-note\r\nClusterIngress resource reconcilers are user selectable using the class annotation key.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/knative/serving/issues/comments/439262349","html_url":"https://github.com/knative/serving/pull/2477#issuecomment-439262349","issue_url":"https://api.github.com/repos/knative/serving/issues/2477","id":439262349,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTI2MjM0OQ==","user":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T02:38:33Z","updated_at":"2018-11-16T02:38:33Z","author_association":"NONE","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/knative/serving/pull/2477#\" title=\"Author self-approved\">greghaynes</a>*, *<a href=\"https://github.com/knative/serving/pull/2477#pullrequestreview-175639746\" title=\"Approved\">mattmoor</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/reconciler/OWNERS](https://github.com/knative/serving/blob/master/pkg/reconciler/OWNERS)~~ [mattmoor]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"knative-prow-robot"}}