{"action":"created","issue":{"url":"https://api.github.com/repos/GeekyAnts/NativeBase/issues/2387","repository_url":"https://api.github.com/repos/GeekyAnts/NativeBase","labels_url":"https://api.github.com/repos/GeekyAnts/NativeBase/issues/2387/labels{/name}","comments_url":"https://api.github.com/repos/GeekyAnts/NativeBase/issues/2387/comments","events_url":"https://api.github.com/repos/GeekyAnts/NativeBase/issues/2387/events","html_url":"https://github.com/GeekyAnts/NativeBase/pull/2387","id":372759350,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0ODU5NjU2","number":2387,"title":"Fix floatingLabel animation","user":{"login":"elyalvarado","id":545352,"node_id":"MDQ6VXNlcjU0NTM1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/545352?v=4","gravatar_id":"","url":"https://api.github.com/users/elyalvarado","html_url":"https://github.com/elyalvarado","followers_url":"https://api.github.com/users/elyalvarado/followers","following_url":"https://api.github.com/users/elyalvarado/following{/other_user}","gists_url":"https://api.github.com/users/elyalvarado/gists{/gist_id}","starred_url":"https://api.github.com/users/elyalvarado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyalvarado/subscriptions","organizations_url":"https://api.github.com/users/elyalvarado/orgs","repos_url":"https://api.github.com/users/elyalvarado/repos","events_url":"https://api.github.com/users/elyalvarado/events{/privacy}","received_events_url":"https://api.github.com/users/elyalvarado/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-23T01:00:07Z","updated_at":"2018-12-19T11:43:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/GeekyAnts/NativeBase/pulls/2387","html_url":"https://github.com/GeekyAnts/NativeBase/pull/2387","diff_url":"https://github.com/GeekyAnts/NativeBase/pull/2387.diff","patch_url":"https://github.com/GeekyAnts/NativeBase/pull/2387.patch"},"body":"This is commit fixes the expected animation for the floating label,\r\nwhich should change the fontSize and line height when the field is\r\nfocused.\r\n\r\nThis is basically reverting commit [3e3ba4e](https://github.com/GeekyAnts/NativeBase/commit/3e3ba4e1a273da9b3236e0f6696e3873152d4a8f#diff-f1939c40e767531823521e714e4db9c0), which was theoretically fixing #2248, but the true is that the root cause of that issue was not in that line, and instead it caused a regression were the floatingLabel is not resizing to an smaller size on focusing the input.\r\n\r\nThe current behaviour without this fix is:\r\n\r\n![current](https://user-images.githubusercontent.com/545352/47327883-81da2200-d634-11e8-8a53-4d54f1cf8a82.gif)\r\n\r\nThe expected behaviour is (making the label smaller when focusing):\r\n\r\n![expected](https://user-images.githubusercontent.com/545352/47327907-8f8fa780-d634-11e8-9308-d8a05e9be020.gif)\r\n\r\nWith this fix you're still able to change the color of the label by applying style directly to it (which I understand was what initially was reported as an issue in #2248):\r\n\r\n![expectedcolor](https://user-images.githubusercontent.com/545352/47328035-06c53b80-d635-11e8-8968-98f7e8764ad1.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/GeekyAnts/NativeBase/issues/comments/448565897","html_url":"https://github.com/GeekyAnts/NativeBase/pull/2387#issuecomment-448565897","issue_url":"https://api.github.com/repos/GeekyAnts/NativeBase/issues/2387","id":448565897,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODU2NTg5Nw==","user":{"login":"SupriyaKalghatgi","id":13464885,"node_id":"MDQ6VXNlcjEzNDY0ODg1","avatar_url":"https://avatars2.githubusercontent.com/u/13464885?v=4","gravatar_id":"","url":"https://api.github.com/users/SupriyaKalghatgi","html_url":"https://github.com/SupriyaKalghatgi","followers_url":"https://api.github.com/users/SupriyaKalghatgi/followers","following_url":"https://api.github.com/users/SupriyaKalghatgi/following{/other_user}","gists_url":"https://api.github.com/users/SupriyaKalghatgi/gists{/gist_id}","starred_url":"https://api.github.com/users/SupriyaKalghatgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SupriyaKalghatgi/subscriptions","organizations_url":"https://api.github.com/users/SupriyaKalghatgi/orgs","repos_url":"https://api.github.com/users/SupriyaKalghatgi/repos","events_url":"https://api.github.com/users/SupriyaKalghatgi/events{/privacy}","received_events_url":"https://api.github.com/users/SupriyaKalghatgi/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T11:43:04Z","updated_at":"2018-12-19T11:43:04Z","author_association":"COLLABORATOR","body":"@elyalvarado I will take a look on this"}}
{"actor":{"display_login":"SupriyaKalghatgi"}}