{"action":"created","issue":{"url":"https://api.github.com/repos/jpetazzo/container.training/issues/310","repository_url":"https://api.github.com/repos/jpetazzo/container.training","labels_url":"https://api.github.com/repos/jpetazzo/container.training/issues/310/labels{/name}","comments_url":"https://api.github.com/repos/jpetazzo/container.training/issues/310/comments","events_url":"https://api.github.com/repos/jpetazzo/container.training/issues/310/events","html_url":"https://github.com/jpetazzo/container.training/pull/310","id":341692116,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzcwNzM1","number":310,"title":"Rollout changes in 1.11","user":{"login":"bridgetkromhout","id":2104453,"node_id":"MDQ6VXNlcjIxMDQ0NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2104453?v=4","gravatar_id":"","url":"https://api.github.com/users/bridgetkromhout","html_url":"https://github.com/bridgetkromhout","followers_url":"https://api.github.com/users/bridgetkromhout/followers","following_url":"https://api.github.com/users/bridgetkromhout/following{/other_user}","gists_url":"https://api.github.com/users/bridgetkromhout/gists{/gist_id}","starred_url":"https://api.github.com/users/bridgetkromhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridgetkromhout/subscriptions","organizations_url":"https://api.github.com/users/bridgetkromhout/orgs","repos_url":"https://api.github.com/users/bridgetkromhout/repos","events_url":"https://api.github.com/users/bridgetkromhout/events{/privacy}","received_events_url":"https://api.github.com/users/bridgetkromhout/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-16T21:53:33Z","updated_at":"2018-07-16T23:22:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/jpetazzo/container.training/pulls/310","html_url":"https://github.com/jpetazzo/container.training/pull/310","diff_url":"https://github.com/jpetazzo/container.training/pull/310.diff","patch_url":"https://github.com/jpetazzo/container.training/pull/310.patch"},"body":"Looks like defaults have changed from numbers to percentages.\r\n\r\nAlso, that means that this isn't valid now: https://oscon2018.container.training/#307\r\n\r\n```\r\n$ kubectl patch deployment worker -p \"\r\n> spec:\r\n>   template:\r\n>     spec:\r\n>       containers:\r\n>       - name: worker\r\n>         image: $REGISTRY/worker:v0.1\r\n>   strategy:\r\n>     rollingUpdate:\r\n>       maxUnavailable: 0\r\n>       maxSurge: 3\r\n>   minReadySeconds: 10\r\n> \"\r\ndeployment.extensions/worker patched\r\n[70.37.55.196] (local) docker@node1 ~\r\n$ kubectl rollout status deployment worker\r\nWaiting for deployment \"worker\" rollout to finish: 3 out of 10 new replicas have been updated...\r\nWaiting for deployment \"worker\" rollout to finish: 3 out of 10 new replicas have been updated...\r\n\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/jpetazzo/container.training/issues/comments/405410747","html_url":"https://github.com/jpetazzo/container.training/pull/310#issuecomment-405410747","issue_url":"https://api.github.com/repos/jpetazzo/container.training/issues/310","id":405410747,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTQxMDc0Nw==","user":{"login":"jpetazzo","id":171481,"node_id":"MDQ6VXNlcjE3MTQ4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/171481?v=4","gravatar_id":"","url":"https://api.github.com/users/jpetazzo","html_url":"https://github.com/jpetazzo","followers_url":"https://api.github.com/users/jpetazzo/followers","following_url":"https://api.github.com/users/jpetazzo/following{/other_user}","gists_url":"https://api.github.com/users/jpetazzo/gists{/gist_id}","starred_url":"https://api.github.com/users/jpetazzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpetazzo/subscriptions","organizations_url":"https://api.github.com/users/jpetazzo/orgs","repos_url":"https://api.github.com/users/jpetazzo/repos","events_url":"https://api.github.com/users/jpetazzo/events{/privacy}","received_events_url":"https://api.github.com/users/jpetazzo/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T23:22:12Z","updated_at":"2018-07-16T23:22:12Z","author_association":"OWNER","body":"Old situation: MaxUnavailable and MaxSurge were both =1, which means a slow, careful pace of change (especially for \"bigger\" services with 10+ replicas). Therefore, it made sense to show how to switch to a faster pace.\r\n\r\nNew situation: MaxUnavailable and MaxSurge are both =25%, which means a significantly faster pace of change, and on bigger deploys, that means a bunch of containers flying around. Suggestion: it could make sense to show how to switch to a slow, very careful pace, i.e. MaxUnavailable=0 and MaxSurge=1.\r\n\r\nWDYT?"}}
{"actor":{"display_login":"jpetazzo"}}