{"action":"created","issue":{"url":"https://api.github.com/repos/Proxmark/proxmark3/issues/565","repository_url":"https://api.github.com/repos/Proxmark/proxmark3","labels_url":"https://api.github.com/repos/Proxmark/proxmark3/issues/565/labels{/name}","comments_url":"https://api.github.com/repos/Proxmark/proxmark3/issues/565/comments","events_url":"https://api.github.com/repos/Proxmark/proxmark3/issues/565/events","html_url":"https://github.com/Proxmark/proxmark3/pull/565","id":294837553,"number":565,"title":"Allow non-root access on Android devices","user":{"login":"Proxcloud","id":33690436,"avatar_url":"https://avatars0.githubusercontent.com/u/33690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Proxcloud","html_url":"https://github.com/Proxcloud","followers_url":"https://api.github.com/users/Proxcloud/followers","following_url":"https://api.github.com/users/Proxcloud/following{/other_user}","gists_url":"https://api.github.com/users/Proxcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Proxcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Proxcloud/subscriptions","organizations_url":"https://api.github.com/users/Proxcloud/orgs","repos_url":"https://api.github.com/users/Proxcloud/repos","events_url":"https://api.github.com/users/Proxcloud/events{/privacy}","received_events_url":"https://api.github.com/users/Proxcloud/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2018-02-06T17:04:05Z","updated_at":"2018-02-16T23:13:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Proxmark/proxmark3/pulls/565","html_url":"https://github.com/Proxmark/proxmark3/pull/565","diff_url":"https://github.com/Proxmark/proxmark3/pull/565.diff","patch_url":"https://github.com/Proxmark/proxmark3/pull/565.patch"},"body":"Add the BOS USB descriptor. This tells the OS the device supports extended commands, on Android this means the OS allows apps to interact with the device using the Android USB Host API. i.e. apps can communicate with the PM3 without needing root."},"comment":{"url":"https://api.github.com/repos/Proxmark/proxmark3/issues/comments/366385621","html_url":"https://github.com/Proxmark/proxmark3/pull/565#issuecomment-366385621","issue_url":"https://api.github.com/repos/Proxmark/proxmark3/issues/565","id":366385621,"user":{"login":"micolous","id":246847,"avatar_url":"https://avatars0.githubusercontent.com/u/246847?v=4","gravatar_id":"","url":"https://api.github.com/users/micolous","html_url":"https://github.com/micolous","followers_url":"https://api.github.com/users/micolous/followers","following_url":"https://api.github.com/users/micolous/following{/other_user}","gists_url":"https://api.github.com/users/micolous/gists{/gist_id}","starred_url":"https://api.github.com/users/micolous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micolous/subscriptions","organizations_url":"https://api.github.com/users/micolous/orgs","repos_url":"https://api.github.com/users/micolous/repos","events_url":"https://api.github.com/users/micolous/events{/privacy}","received_events_url":"https://api.github.com/users/micolous/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T23:13:02Z","updated_at":"2018-02-16T23:13:02Z","author_association":"CONTRIBUTOR","body":"**Per the comments in the file you were editing, you should not change the manufacturer string, ever**.  This is because [ModemManager (Linux) scans for PM3 based on the manuafacturer string](https://lists.freedesktop.org/archives/modemmanager-devel/2016-February/002705.html).  This is because the PM3 device ID at the time was not registered, and this rule matches both \"old\" and \"new\" device IDs.\r\n\r\nGetting changes into ModemManager takes around 2-3 years to actually land in users' Linux distributions.  This allows them to use the hardware without adding extra blacklisting rules or uninstalling ModemManager.\r\n\r\nThe product string is **not** matched in the ModemManager rules, so it is \"safe\" to change this.\r\n\r\nBut as is, the changes you have proposed should have no impact on \"native\" Android usage, and I've tested this on a Galaxy Nexus, Nexus 5X, Pixel 1, and ODroid U3.  I'm able to successfully communicate with it in [AndProx](https://github.com/andprox/andprox), **without root, and without flashing different firmware.**\r\n\r\nSide note: please consider working with me on AndProx rather than making \"yet another Android port\", [we currently have three](https://github.com/Proxmark/proxmark3/wiki/android).  I already have native, non-root communication with the PM3 on Android with JNI wrappers for the communications libraries.\r\n\r\nI _am_ interested in getting WebUSB support going at some point with the stock firmware, I'm just having troubles with the BOS on Windows 10 so that it doesn't impact \"native\" usage."}}
{"actor":{"display_login":"micolous"}}