{"action":"created","issue":{"url":"https://api.github.com/repos/haikuports/haikuports/issues/2647","repository_url":"https://api.github.com/repos/haikuports/haikuports","labels_url":"https://api.github.com/repos/haikuports/haikuports/issues/2647/labels{/name}","comments_url":"https://api.github.com/repos/haikuports/haikuports/issues/2647/comments","events_url":"https://api.github.com/repos/haikuports/haikuports/issues/2647/events","html_url":"https://github.com/haikuports/haikuports/pull/2647","id":329486942,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzMwNjE0","number":2647,"title":"Rust: Add recipe for 1.21.0","user":{"login":"nielx","id":324054,"node_id":"MDQ6VXNlcjMyNDA1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/324054?v=4","gravatar_id":"","url":"https://api.github.com/users/nielx","html_url":"https://github.com/nielx","followers_url":"https://api.github.com/users/nielx/followers","following_url":"https://api.github.com/users/nielx/following{/other_user}","gists_url":"https://api.github.com/users/nielx/gists{/gist_id}","starred_url":"https://api.github.com/users/nielx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nielx/subscriptions","organizations_url":"https://api.github.com/users/nielx/orgs","repos_url":"https://api.github.com/users/nielx/repos","events_url":"https://api.github.com/users/nielx/events{/privacy}","received_events_url":"https://api.github.com/users/nielx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-06-05T14:37:28Z","updated_at":"2018-07-01T09:54:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/haikuports/haikuports/pulls/2647","html_url":"https://github.com/haikuports/haikuports/pull/2647","diff_url":"https://github.com/haikuports/haikuports/pull/2647.diff","patch_url":"https://github.com/haikuports/haikuports/pull/2647.patch"},"body":"This recipe is built of binary artifacts. The main reason is that the 32\r\nbit version can no longer be built on Haiku, because it crosses a hard\r\nmemory limit. Perhaps this changes later on. In any case, an added\r\nadvantage is that his makes the package buildable by the buildbots.\r\n\r\nThe line for SOURCES_3 is commented out. In here the sources that the\r\nbuilt is based on would be downloaded, mainly for the completeness of\r\nthe source packages. This gives an ascii encoding error in haikuporter."},"comment":{"url":"https://api.github.com/repos/haikuports/haikuports/issues/comments/401596356","html_url":"https://github.com/haikuports/haikuports/pull/2647#issuecomment-401596356","issue_url":"https://api.github.com/repos/haikuports/haikuports/issues/2647","id":401596356,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTU5NjM1Ng==","user":{"login":"fbrosson","id":8014660,"node_id":"MDQ6VXNlcjgwMTQ2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8014660?v=4","gravatar_id":"","url":"https://api.github.com/users/fbrosson","html_url":"https://github.com/fbrosson","followers_url":"https://api.github.com/users/fbrosson/followers","following_url":"https://api.github.com/users/fbrosson/following{/other_user}","gists_url":"https://api.github.com/users/fbrosson/gists{/gist_id}","starred_url":"https://api.github.com/users/fbrosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbrosson/subscriptions","organizations_url":"https://api.github.com/users/fbrosson/orgs","repos_url":"https://api.github.com/users/fbrosson/repos","events_url":"https://api.github.com/users/fbrosson/events{/privacy}","received_events_url":"https://api.github.com/users/fbrosson/received_events","type":"User","site_admin":false},"created_at":"2018-07-01T09:54:30Z","updated_at":"2018-07-01T09:54:30Z","author_association":"MEMBER","body":"There's something that is not as nice as I think it could be. It's the beginning of `INSTALL()`:\r\n```\r\n\t# we will manually invoke the install scripts\r\n\tif [ $effectiveTargetArchitecture = x86 ]; then\r\n\t\tcd $sourceDir\r\n\tfi\r\n\tif [ $effectiveTargetArchitecture = x86_64 ]; then\r\n\t\tcd $sourceDir2/rust-1.21.0-x86_64-unknown-haiku\r\n\tfi\r\n```\r\nI think we could avoid this by using conditional definitions for `SOURCE_URI`, as suggested in [my first comment](https://github.com/haikuports/haikuports/pull/2647#issuecomment-399678783).\r\n\r\nThat said, I'm OK with the merge. It's just that I haven't tested the recipe myself and that I'm not very fond of the above bloc, so I'd rather let someone else do the merge :)"}}
{"actor":{"display_login":"fbrosson"}}