{"action":"closed","number":907,"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/mono/pulls/907","id":180250755,"html_url":"https://github.com/Unity-Technologies/mono/pull/907","diff_url":"https://github.com/Unity-Technologies/mono/pull/907.diff","patch_url":"https://github.com/Unity-Technologies/mono/pull/907.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/mono/issues/907","number":907,"state":"closed","locked":false,"title":"Unity master expose mono type attrs","user":{"login":"enekoosia","id":35225448,"avatar_url":"https://avatars1.githubusercontent.com/u/35225448?v=4","gravatar_id":"","url":"https://api.github.com/users/enekoosia","html_url":"https://github.com/enekoosia","followers_url":"https://api.github.com/users/enekoosia/followers","following_url":"https://api.github.com/users/enekoosia/following{/other_user}","gists_url":"https://api.github.com/users/enekoosia/gists{/gist_id}","starred_url":"https://api.github.com/users/enekoosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enekoosia/subscriptions","organizations_url":"https://api.github.com/users/enekoosia/orgs","repos_url":"https://api.github.com/users/enekoosia/repos","events_url":"https://api.github.com/users/enekoosia/events{/privacy}","received_events_url":"https://api.github.com/users/enekoosia/received_events","type":"User","site_admin":false},"body":"*Purpose of this PR*:\r\n\r\nCurrently Unity crashes when a Unity supported message has parameters with ref or out keyword on the C# script [case: 968454].\r\n\r\nTo be able to fix the problem we need to be able to do some checks on the mono type attrs, so I am exposing that data so we could query it from Unity code.\r\n\r\n*Katana build*:\r\n\r\nhttps://katana.bf.unity3d.com/projects/Mono%20Runtime%20and%20Classlibs/builders?boo_branch=unity-trunk&cecil_branch=unity-master&il2cpp_branch=master&krait-signal-handler_branch=master&mono_branch=unity-master-expose-mono-type-attrs&mono-build-deps_branch=default&unityscript_branch=unity-trunk","created_at":"2018-04-09T09:07:19Z","updated_at":"2018-04-09T12:09:35Z","closed_at":"2018-04-09T12:09:35Z","merged_at":null,"merge_commit_sha":"4eb26c76f8a757770ab511005194ef96908fbaae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/mono/pulls/907/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/mono/pulls/907/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/mono/issues/907/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/mono/statuses/73fae33c2750da10ee89cb8b199a98e1f3861796","head":{"label":"Unity-Technologies:unity-master-expose-mono-type-attrs","ref":"unity-master-expose-mono-type-attrs","sha":"73fae33c2750da10ee89cb8b199a98e1f3861796","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":989769,"name":"mono","full_name":"Unity-Technologies/mono","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/Unity-Technologies/mono","forks_url":"https://api.github.com/repos/Unity-Technologies/mono/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/mono/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/mono/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/mono/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/mono/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/mono/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/mono/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/mono/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/mono/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/mono/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/mono/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/mono/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/mono/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/mono/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/mono/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/mono/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/mono/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/mono/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/mono/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/mono/deployments","created_at":"2010-10-15T12:13:44Z","updated_at":"2018-04-09T07:25:08Z","pushed_at":"2018-04-09T09:07:19Z","git_url":"git://github.com/Unity-Technologies/mono.git","ssh_url":"git@github.com:Unity-Technologies/mono.git","clone_url":"https://github.com/Unity-Technologies/mono.git","svn_url":"https://github.com/Unity-Technologies/mono","homepage":"http://www.mono-project.com/","size":485576,"stargazers_count":632,"watchers_count":632,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":323,"open_issues":8,"watchers":632,"default_branch":"unity-master"}},"base":{"label":"Unity-Technologies:unity-master","ref":"unity-master","sha":"13e97610b4774f408eaedbce7e1d12b30193f735","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":989769,"name":"mono","full_name":"Unity-Technologies/mono","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/Unity-Technologies/mono","forks_url":"https://api.github.com/repos/Unity-Technologies/mono/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/mono/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/mono/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/mono/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/mono/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/mono/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/mono/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/mono/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/mono/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/mono/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/mono/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/mono/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/mono/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/mono/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/mono/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/mono/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/mono/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/mono/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/mono/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/mono/deployments","created_at":"2010-10-15T12:13:44Z","updated_at":"2018-04-09T07:25:08Z","pushed_at":"2018-04-09T09:07:19Z","git_url":"git://github.com/Unity-Technologies/mono.git","ssh_url":"git@github.com:Unity-Technologies/mono.git","clone_url":"https://github.com/Unity-Technologies/mono.git","svn_url":"https://github.com/Unity-Technologies/mono","homepage":"http://www.mono-project.com/","size":485576,"stargazers_count":632,"watchers_count":632,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":323,"open_issues":8,"watchers":632,"default_branch":"unity-master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/mono/pulls/907"},"html":{"href":"https://github.com/Unity-Technologies/mono/pull/907"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/mono/issues/907"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/mono/issues/907/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/mono/pulls/907/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/mono/pulls/907/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/mono/statuses/73fae33c2750da10ee89cb8b199a98e1f3861796"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":16,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"enekoosia"}}