{"action":"created","issue":{"url":"https://api.github.com/repos/sipwise/rtpengine/issues/658","repository_url":"https://api.github.com/repos/sipwise/rtpengine","labels_url":"https://api.github.com/repos/sipwise/rtpengine/issues/658/labels{/name}","comments_url":"https://api.github.com/repos/sipwise/rtpengine/issues/658/comments","events_url":"https://api.github.com/repos/sipwise/rtpengine/issues/658/events","html_url":"https://github.com/sipwise/rtpengine/pull/658","id":381554674,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDk0ODgw","number":658,"title":"Bria softphone using SRTP call with AES_CM_256_HMAC_SHA1_80 requires padding to append","user":{"login":"adil-mafzool","id":36664780,"node_id":"MDQ6VXNlcjM2NjY0Nzgw","avatar_url":"https://avatars3.githubusercontent.com/u/36664780?v=4","gravatar_id":"","url":"https://api.github.com/users/adil-mafzool","html_url":"https://github.com/adil-mafzool","followers_url":"https://api.github.com/users/adil-mafzool/followers","following_url":"https://api.github.com/users/adil-mafzool/following{/other_user}","gists_url":"https://api.github.com/users/adil-mafzool/gists{/gist_id}","starred_url":"https://api.github.com/users/adil-mafzool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adil-mafzool/subscriptions","organizations_url":"https://api.github.com/users/adil-mafzool/orgs","repos_url":"https://api.github.com/users/adil-mafzool/repos","events_url":"https://api.github.com/users/adil-mafzool/events{/privacy}","received_events_url":"https://api.github.com/users/adil-mafzool/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-16T11:10:13Z","updated_at":"2018-11-16T23:01:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sipwise/rtpengine/pulls/658","html_url":"https://github.com/sipwise/rtpengine/pull/658","diff_url":"https://github.com/sipwise/rtpengine/pull/658.diff","patch_url":"https://github.com/sipwise/rtpengine/pull/658.patch"},"body":"crypto containing padding should be sent within sdp for pass through"},"comment":{"url":"https://api.github.com/repos/sipwise/rtpengine/issues/comments/439555176","html_url":"https://github.com/sipwise/rtpengine/pull/658#issuecomment-439555176","issue_url":"https://api.github.com/repos/sipwise/rtpengine/issues/658","id":439555176,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTU1NTE3Ng==","user":{"login":"adil-mafzool","id":36664780,"node_id":"MDQ6VXNlcjM2NjY0Nzgw","avatar_url":"https://avatars3.githubusercontent.com/u/36664780?v=4","gravatar_id":"","url":"https://api.github.com/users/adil-mafzool","html_url":"https://github.com/adil-mafzool","followers_url":"https://api.github.com/users/adil-mafzool/followers","following_url":"https://api.github.com/users/adil-mafzool/following{/other_user}","gists_url":"https://api.github.com/users/adil-mafzool/gists{/gist_id}","starred_url":"https://api.github.com/users/adil-mafzool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adil-mafzool/subscriptions","organizations_url":"https://api.github.com/users/adil-mafzool/orgs","repos_url":"https://api.github.com/users/adil-mafzool/repos","events_url":"https://api.github.com/users/adil-mafzool/events{/privacy}","received_events_url":"https://api.github.com/users/adil-mafzool/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T23:01:49Z","updated_at":"2018-11-16T23:01:49Z","author_association":"NONE","body":"@rfuchs digging Rfc4648 states section 3.2 : -\r\n\r\n`Implementations MUST include appropriate pad characters at the end of encoded data unless the specification referring to this document explicitly states otherwise.\r\n\r\nThe base64 and base32 alphabets use padding, as described below in sections 4 and 6, but the base16 alphabet does not need it; see section 8.`\r\n\r\nBase64 section 4 relating with padding : -\r\n\r\n`Padding at the end of the data is performed using the '=' character.  Since all base 64 input is an integral number of octets, only the following cases can arise:\r\n\r\n(1) The final quantum of encoding input is an integral multiple of 24 bits; here, the final unit of encoded output will be an integral  multiple of 4 characters with no \"=\" padding.\r\n\r\n(2) The final quantum of encoding input is exactly 8 bits; here, the final unit of encoded output will be two characters followed by two \"=\" padding characters.\r\n\r\n (3) The final quantum of encoding input is exactly 16 bits; here, the final unit of encoded output will be three characters followed by one \"=\" padding character.`"}}
{"actor":{"display_login":"adil-mafzool"}}