{"action":"created","comment":{"url":"https://api.github.com/repos/nasa/cumulus/pulls/comments/221574763","pull_request_review_id":160251383,"id":221574763,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTU3NDc2Mw==","diff_hunk":"@@ -68,6 +68,8 @@ exports.syncGranule = function syncGranule(event) {\n     duplicateHandling = collection.duplicateHandling;\n   }\n \n+  log.info(`duplicateHandling: ${duplicateHandling}`);","path":"tasks/sync-granule/index.js","position":4,"original_position":4,"commit_id":"77496c62107d815f14b74999c68f676bde9065fb","original_commit_id":"77496c62107d815f14b74999c68f676bde9065fb","user":{"login":"laurenfrederick","id":25331898,"node_id":"MDQ6VXNlcjI1MzMxODk4","avatar_url":"https://avatars3.githubusercontent.com/u/25331898?v=4","gravatar_id":"","url":"https://api.github.com/users/laurenfrederick","html_url":"https://github.com/laurenfrederick","followers_url":"https://api.github.com/users/laurenfrederick/followers","following_url":"https://api.github.com/users/laurenfrederick/following{/other_user}","gists_url":"https://api.github.com/users/laurenfrederick/gists{/gist_id}","starred_url":"https://api.github.com/users/laurenfrederick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurenfrederick/subscriptions","organizations_url":"https://api.github.com/users/laurenfrederick/orgs","repos_url":"https://api.github.com/users/laurenfrederick/repos","events_url":"https://api.github.com/users/laurenfrederick/events{/privacy}","received_events_url":"https://api.github.com/users/laurenfrederick/received_events","type":"User","site_admin":false},"body":"This should either come out or be a `log.debug` with something a bit more descriptive","created_at":"2018-10-01T11:25:55Z","updated_at":"2018-10-01T11:27:37Z","html_url":"https://github.com/nasa/cumulus/pull/579#discussion_r221574763","pull_request_url":"https://api.github.com/repos/nasa/cumulus/pulls/579","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nasa/cumulus/pulls/comments/221574763"},"html":{"href":"https://github.com/nasa/cumulus/pull/579#discussion_r221574763"},"pull_request":{"href":"https://api.github.com/repos/nasa/cumulus/pulls/579"}}},"pull_request":{"url":"https://api.github.com/repos/nasa/cumulus/pulls/579","id":219086307,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDg2MzA3","html_url":"https://github.com/nasa/cumulus/pull/579","diff_url":"https://github.com/nasa/cumulus/pull/579.diff","patch_url":"https://github.com/nasa/cumulus/pull/579.patch","issue_url":"https://api.github.com/repos/nasa/cumulus/issues/579","number":579,"state":"open","locked":false,"title":"CUMULUS-780: Duplicate handling should default to \"error\" if not specified","user":{"login":"markdboyd","id":1001694,"node_id":"MDQ6VXNlcjEwMDE2OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1001694?v=4","gravatar_id":"","url":"https://api.github.com/users/markdboyd","html_url":"https://github.com/markdboyd","followers_url":"https://api.github.com/users/markdboyd/followers","following_url":"https://api.github.com/users/markdboyd/following{/other_user}","gists_url":"https://api.github.com/users/markdboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/markdboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdboyd/subscriptions","organizations_url":"https://api.github.com/users/markdboyd/orgs","repos_url":"https://api.github.com/users/markdboyd/repos","events_url":"https://api.github.com/users/markdboyd/events{/privacy}","received_events_url":"https://api.github.com/users/markdboyd/received_events","type":"User","site_admin":false},"body":"**Summary:** Summary of changes\r\n\r\nAddresses [CUMULUS-780: As a DAAC operator, I want the sync granule task to raise a catchable error by default when it finds files at its target location, so its need for configuration can be detected if duplication occurs](https://bugs.earthdata.nasa.gov/browse/CUMULUS-780)\r\n\r\n## Changes\r\n\r\n* Update default value for `duplicateHandling` on new collections on creation to be `error`\r\n* Update `Granule.ingest` to default `duplicateHandling` to `error` \r\n* Added test for `syncGranule` task to verify `duplicateHandling` of `error` is used when it is not specified\r\n* Added integration test for `@cumulus/syncGranule` to verify that the workflow/task raises an error on duplicate filenames when no `collection` or `duplicateHandling` is specified on the task config \r\n  * I decided create a new workflow for this test, `SyncGranuleNoDuplicateHandling`, rather than re-use one from 779 because I wanted to have a syncGranule task with no configuration for `collection` or `duplicateHandling`, thus ensuring that the task is falling back to the default which should be `error`\r\n\r\n## Test Plan\r\nThings that should succeed before merging.\r\n\r\n- [ ] Unit tests\r\n- [ ] Adhoc testing\r\n- [x] Update CHANGELOG\r\n- [ ] Run `./bin/eslint-ratchet` and verify that eslint errors have not increased\r\n  - [ ] Commit `.eslint-ratchet-high-water-mark` if the score has improved\r\n","created_at":"2018-09-28T21:08:23Z","updated_at":"2018-10-01T11:27:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71fa5b1db70f8f0fcc6cb210f079f793e15057fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nasa/cumulus/pulls/579/commits","review_comments_url":"https://api.github.com/repos/nasa/cumulus/pulls/579/comments","review_comment_url":"https://api.github.com/repos/nasa/cumulus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nasa/cumulus/issues/579/comments","statuses_url":"https://api.github.com/repos/nasa/cumulus/statuses/77496c62107d815f14b74999c68f676bde9065fb","head":{"label":"nasa:markdboyd/CUMULUS-780","ref":"markdboyd/CUMULUS-780","sha":"77496c62107d815f14b74999c68f676bde9065fb","user":{"login":"nasa","id":848102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0ODEwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":95879196,"node_id":"MDEwOlJlcG9zaXRvcnk5NTg3OTE5Ng==","name":"cumulus","full_name":"nasa/cumulus","private":false,"owner":{"login":"nasa","id":848102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0ODEwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nasa/cumulus","description":"Cumulus Framework + Cumulus API","fork":false,"url":"https://api.github.com/repos/nasa/cumulus","forks_url":"https://api.github.com/repos/nasa/cumulus/forks","keys_url":"https://api.github.com/repos/nasa/cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nasa/cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nasa/cumulus/teams","hooks_url":"https://api.github.com/repos/nasa/cumulus/hooks","issue_events_url":"https://api.github.com/repos/nasa/cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/nasa/cumulus/events","assignees_url":"https://api.github.com/repos/nasa/cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/nasa/cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/nasa/cumulus/tags","blobs_url":"https://api.github.com/repos/nasa/cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nasa/cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nasa/cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/nasa/cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nasa/cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/nasa/cumulus/languages","stargazers_url":"https://api.github.com/repos/nasa/cumulus/stargazers","contributors_url":"https://api.github.com/repos/nasa/cumulus/contributors","subscribers_url":"https://api.github.com/repos/nasa/cumulus/subscribers","subscription_url":"https://api.github.com/repos/nasa/cumulus/subscription","commits_url":"https://api.github.com/repos/nasa/cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/nasa/cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/nasa/cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/nasa/cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/nasa/cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/nasa/cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nasa/cumulus/merges","archive_url":"https://api.github.com/repos/nasa/cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nasa/cumulus/downloads","issues_url":"https://api.github.com/repos/nasa/cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/nasa/cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/nasa/cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/nasa/cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nasa/cumulus/labels{/name}","releases_url":"https://api.github.com/repos/nasa/cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/nasa/cumulus/deployments","created_at":"2017-06-30T10:52:28Z","updated_at":"2018-10-01T03:47:48Z","pushed_at":"2018-10-01T00:22:00Z","git_url":"git://github.com/nasa/cumulus.git","ssh_url":"git@github.com:nasa/cumulus.git","clone_url":"https://github.com/nasa/cumulus.git","svn_url":"https://github.com/nasa/cumulus","homepage":"","size":61262,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12,"open_issues":17,"watchers":19,"default_branch":"master"}},"base":{"label":"nasa:master","ref":"master","sha":"71373bb74a0db1f0f69d4a5d4573871238cb6dea","user":{"login":"nasa","id":848102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0ODEwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":95879196,"node_id":"MDEwOlJlcG9zaXRvcnk5NTg3OTE5Ng==","name":"cumulus","full_name":"nasa/cumulus","private":false,"owner":{"login":"nasa","id":848102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0ODEwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nasa/cumulus","description":"Cumulus Framework + Cumulus API","fork":false,"url":"https://api.github.com/repos/nasa/cumulus","forks_url":"https://api.github.com/repos/nasa/cumulus/forks","keys_url":"https://api.github.com/repos/nasa/cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nasa/cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nasa/cumulus/teams","hooks_url":"https://api.github.com/repos/nasa/cumulus/hooks","issue_events_url":"https://api.github.com/repos/nasa/cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/nasa/cumulus/events","assignees_url":"https://api.github.com/repos/nasa/cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/nasa/cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/nasa/cumulus/tags","blobs_url":"https://api.github.com/repos/nasa/cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nasa/cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nasa/cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/nasa/cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nasa/cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/nasa/cumulus/languages","stargazers_url":"https://api.github.com/repos/nasa/cumulus/stargazers","contributors_url":"https://api.github.com/repos/nasa/cumulus/contributors","subscribers_url":"https://api.github.com/repos/nasa/cumulus/subscribers","subscription_url":"https://api.github.com/repos/nasa/cumulus/subscription","commits_url":"https://api.github.com/repos/nasa/cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/nasa/cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/nasa/cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/nasa/cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/nasa/cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/nasa/cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nasa/cumulus/merges","archive_url":"https://api.github.com/repos/nasa/cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nasa/cumulus/downloads","issues_url":"https://api.github.com/repos/nasa/cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/nasa/cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/nasa/cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/nasa/cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nasa/cumulus/labels{/name}","releases_url":"https://api.github.com/repos/nasa/cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/nasa/cumulus/deployments","created_at":"2017-06-30T10:52:28Z","updated_at":"2018-10-01T03:47:48Z","pushed_at":"2018-10-01T00:22:00Z","git_url":"git://github.com/nasa/cumulus.git","ssh_url":"git@github.com:nasa/cumulus.git","clone_url":"https://github.com/nasa/cumulus.git","svn_url":"https://github.com/nasa/cumulus","homepage":"","size":61262,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12,"open_issues":17,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nasa/cumulus/pulls/579"},"html":{"href":"https://github.com/nasa/cumulus/pull/579"},"issue":{"href":"https://api.github.com/repos/nasa/cumulus/issues/579"},"comments":{"href":"https://api.github.com/repos/nasa/cumulus/issues/579/comments"},"review_comments":{"href":"https://api.github.com/repos/nasa/cumulus/pulls/579/comments"},"review_comment":{"href":"https://api.github.com/repos/nasa/cumulus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nasa/cumulus/pulls/579/commits"},"statuses":{"href":"https://api.github.com/repos/nasa/cumulus/statuses/77496c62107d815f14b74999c68f676bde9065fb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"laurenfrederick"}}