{"action":"created","issue":{"url":"https://api.github.com/repos/improbable-eng/thanos/issues/574","repository_url":"https://api.github.com/repos/improbable-eng/thanos","labels_url":"https://api.github.com/repos/improbable-eng/thanos/issues/574/labels{/name}","comments_url":"https://api.github.com/repos/improbable-eng/thanos/issues/574/comments","events_url":"https://api.github.com/repos/improbable-eng/thanos/issues/574/events","html_url":"https://github.com/improbable-eng/thanos/pull/574","id":369511980,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDM2MDUy","number":574,"title":"Add /-/healthy endpoint to Querier","user":{"login":"adrien-f","id":781688,"node_id":"MDQ6VXNlcjc4MTY4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/781688?v=4","gravatar_id":"","url":"https://api.github.com/users/adrien-f","html_url":"https://github.com/adrien-f","followers_url":"https://api.github.com/users/adrien-f/followers","following_url":"https://api.github.com/users/adrien-f/following{/other_user}","gists_url":"https://api.github.com/users/adrien-f/gists{/gist_id}","starred_url":"https://api.github.com/users/adrien-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrien-f/subscriptions","organizations_url":"https://api.github.com/users/adrien-f/orgs","repos_url":"https://api.github.com/users/adrien-f/repos","events_url":"https://api.github.com/users/adrien-f/events{/privacy}","received_events_url":"https://api.github.com/users/adrien-f/received_events","type":"User","site_admin":false},"labels":[{"id":737763641,"node_id":"MDU6TGFiZWw3Mzc3NjM2NDE=","url":"https://api.github.com/repos/improbable-eng/thanos/labels/difficulty:%20easy","name":"difficulty: easy","color":"33aa3f","default":false},{"id":737763640,"node_id":"MDU6TGFiZWw3Mzc3NjM2NDA=","url":"https://api.github.com/repos/improbable-eng/thanos/labels/feature%20request%20/%20improvement","name":"feature request / improvement","color":"84b6eb","default":false},{"id":1088711317,"node_id":"MDU6TGFiZWwxMDg4NzExMzE3","url":"https://api.github.com/repos/improbable-eng/thanos/labels/help%20wanted","name":"help wanted","color":"f9c7ae","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-12T11:29:17Z","updated_at":"2018-10-14T13:07:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/improbable-eng/thanos/pulls/574","html_url":"https://github.com/improbable-eng/thanos/pull/574","diff_url":"https://github.com/improbable-eng/thanos/pull/574.diff","patch_url":"https://github.com/improbable-eng/thanos/pull/574.patch"},"body":"<!--\r\n    Keep PR title verbose enough and add prefix telling\r\n    about what components it touches e.g \"query:\" or \".*:\"\r\n-->\r\n\r\n## Changes\r\n\r\nAdd `/-/healthy` endpoint to Querier.\r\n\r\nFor a related discussion on this change, you can find [a similar discussion](https://github.com/prometheus/pushgateway/issues/105) on the Prometheus Push Gateway repository.\r\n\r\nThis endpoint implementation is naive and in the future, we could maybe add verification of gRPC peers or anything else.\r\n\r\n## Verification\r\n\r\n<!-- How you tested it? How do you know it works? -->\r\n\r\n```curl http://127.0.0.1:10902/-/healthy -v\r\n*   Trying 127.0.0.1...\r\n* TCP_NODELAY set\r\n* Connected to 127.0.0.1 (127.0.0.1) port 10902 (#0)\r\n> GET /-/healthy HTTP/1.1\r\n> Host: 127.0.0.1:10902\r\n> User-Agent: curl/7.58.0\r\n> Accept: */*\r\n> \r\n< HTTP/1.1 200 OK\r\n< Date: Fri, 12 Oct 2018 11:26:48 GMT\r\n< Content-Length: 19\r\n< Content-Type: text/plain; charset=utf-8\r\n< \r\nThanos is Healthy.\r\n* Connection #0 to host 127.0.0.1 left intact\r\n```"},"comment":{"url":"https://api.github.com/repos/improbable-eng/thanos/issues/comments/429625106","html_url":"https://github.com/improbable-eng/thanos/pull/574#issuecomment-429625106","issue_url":"https://api.github.com/repos/improbable-eng/thanos/issues/574","id":429625106,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTYyNTEwNg==","user":{"login":"GiedriusS","id":2377233,"node_id":"MDQ6VXNlcjIzNzcyMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/2377233?v=4","gravatar_id":"","url":"https://api.github.com/users/GiedriusS","html_url":"https://github.com/GiedriusS","followers_url":"https://api.github.com/users/GiedriusS/followers","following_url":"https://api.github.com/users/GiedriusS/following{/other_user}","gists_url":"https://api.github.com/users/GiedriusS/gists{/gist_id}","starred_url":"https://api.github.com/users/GiedriusS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiedriusS/subscriptions","organizations_url":"https://api.github.com/users/GiedriusS/orgs","repos_url":"https://api.github.com/users/GiedriusS/repos","events_url":"https://api.github.com/users/GiedriusS/events{/privacy}","received_events_url":"https://api.github.com/users/GiedriusS/received_events","type":"User","site_admin":false},"created_at":"2018-10-14T13:07:51Z","updated_at":"2018-10-14T13:07:51Z","author_association":"NONE","body":"Perhaps with this the example Kubernetes deployment in `kube/manifests/*` should also be updated to include this new liveness probe: https://github.com/improbable-eng/thanos/blob/master/kube/manifests/thanos-query.yaml ?"}}
{"actor":{"display_login":"GiedriusS"}}