{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/19014","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/19014/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/19014/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/19014/events","html_url":"https://github.com/elastic/kibana/pull/19014","id":322423695,"number":19014,"title":"Fix moment.js license expiration parsing","user":{"login":"archanid","id":13165182,"avatar_url":"https://avatars3.githubusercontent.com/u/13165182?v=4","gravatar_id":"","url":"https://api.github.com/users/archanid","html_url":"https://github.com/archanid","followers_url":"https://api.github.com/users/archanid/followers","following_url":"https://api.github.com/users/archanid/following{/other_user}","gists_url":"https://api.github.com/users/archanid/gists{/gist_id}","starred_url":"https://api.github.com/users/archanid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archanid/subscriptions","organizations_url":"https://api.github.com/users/archanid/orgs","repos_url":"https://api.github.com/users/archanid/repos","events_url":"https://api.github.com/users/archanid/events{/privacy}","received_events_url":"https://api.github.com/users/archanid/received_events","type":"User","site_admin":false},"labels":[{"id":470241278,"url":"https://api.github.com/repos/elastic/kibana/labels/:Platform","name":":Platform","color":"fef2c0","default":false},{"id":26198234,"url":"https://api.github.com/repos/elastic/kibana/labels/bug","name":"bug","color":"9e2c2c","default":true},{"id":135307740,"url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"archanid","id":13165182,"avatar_url":"https://avatars3.githubusercontent.com/u/13165182?v=4","gravatar_id":"","url":"https://api.github.com/users/archanid","html_url":"https://github.com/archanid","followers_url":"https://api.github.com/users/archanid/followers","following_url":"https://api.github.com/users/archanid/following{/other_user}","gists_url":"https://api.github.com/users/archanid/gists{/gist_id}","starred_url":"https://api.github.com/users/archanid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archanid/subscriptions","organizations_url":"https://api.github.com/users/archanid/orgs","repos_url":"https://api.github.com/users/archanid/repos","events_url":"https://api.github.com/users/archanid/events{/privacy}","received_events_url":"https://api.github.com/users/archanid/received_events","type":"User","site_admin":false},"assignees":[{"login":"archanid","id":13165182,"avatar_url":"https://avatars3.githubusercontent.com/u/13165182?v=4","gravatar_id":"","url":"https://api.github.com/users/archanid","html_url":"https://github.com/archanid","followers_url":"https://api.github.com/users/archanid/followers","following_url":"https://api.github.com/users/archanid/following{/other_user}","gists_url":"https://api.github.com/users/archanid/gists{/gist_id}","starred_url":"https://api.github.com/users/archanid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archanid/subscriptions","organizations_url":"https://api.github.com/users/archanid/orgs","repos_url":"https://api.github.com/users/archanid/repos","events_url":"https://api.github.com/users/archanid/events{/privacy}","received_events_url":"https://api.github.com/users/archanid/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-05-11T20:25:35Z","updated_at":"2018-05-24T19:43:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/19014","html_url":"https://github.com/elastic/kibana/pull/19014","diff_url":"https://github.com/elastic/kibana/pull/19014.diff","patch_url":"https://github.com/elastic/kibana/pull/19014.patch"},"body":"Attempting to fix https://github.com/elastic/kibana/issues/18388\r\n\r\nI think this is actually in nanoseconds (see [comments](https://github.com/elastic/kibana/issues/18388#issuecomment-388467654))."},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/391835626","html_url":"https://github.com/elastic/kibana/pull/19014#issuecomment-391835626","issue_url":"https://api.github.com/repos/elastic/kibana/issues/19014","id":391835626,"user":{"login":"tbrooks8","id":862472,"avatar_url":"https://avatars3.githubusercontent.com/u/862472?v=4","gravatar_id":"","url":"https://api.github.com/users/tbrooks8","html_url":"https://github.com/tbrooks8","followers_url":"https://api.github.com/users/tbrooks8/followers","following_url":"https://api.github.com/users/tbrooks8/following{/other_user}","gists_url":"https://api.github.com/users/tbrooks8/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrooks8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrooks8/subscriptions","organizations_url":"https://api.github.com/users/tbrooks8/orgs","repos_url":"https://api.github.com/users/tbrooks8/repos","events_url":"https://api.github.com/users/tbrooks8/events{/privacy}","received_events_url":"https://api.github.com/users/tbrooks8/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T19:43:03Z","updated_at":"2018-05-24T19:43:03Z","author_association":"NONE","body":"> We need to confirm that it is indeed nanoseconds.\r\n\r\nIt is milliseconds.\r\n\r\n> Ideally Elasticsearch wouldn't be returning any timestamp at all. It may have been convenient from an engineering perspective to just throw in some super far into the future date, but we're telling everyone that basic licenses never expire, which doesn't seem to be accurate.\r\n\r\nThe binary signature of licenses have a expiration date in milliseconds. There is not really a way around that decision that was made a long time ago. Generated basic licenses have a hardcoded expiration milliseconds of 9223372005318775807 (1 year before 2^63). The current logic is remove that from the rest response if that is the expiration milliseconds to prevent a confusing rest response. \r\n\r\nIf elasticsearch is returning 9223372005318776000 for something that seems to be a bug. We could use the steps from kibana that can reproduce this issue."}}
{"actor":{"display_login":"tbrooks8"}}