{"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/195904028","pull_request_review_id":129364331,"id":195904028,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTkwNDAyOA==","diff_hunk":"@@ -3,6 +3,7 @@\n  * LICENSE:     GPL-2.0+ (https://spdx.org/licenses/GPL-2.0+)\n  * PURPOSE:     Tests for DsRoleGetPrimaryDomainInformation\n  * COPYRIGHT:   Copyright 2017 Colin Finck (colin@reactos.org)\n+ *              Copyright 2018 Serge Gautherie <reactos-git_serge_171003@gautherie.fr>","path":"modules/rostests/apitests/netapi32/DsRoleGetPrimaryDomainInformation.c","position":4,"original_position":4,"commit_id":"b7033fe1a8e9ffb9a20514ae5bb4285f9d741602","original_commit_id":"b7033fe1a8e9ffb9a20514ae5bb4285f9d741602","user":{"login":"HBelusca","id":1969829,"node_id":"MDQ6VXNlcjE5Njk4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1969829?v=4","gravatar_id":"","url":"https://api.github.com/users/HBelusca","html_url":"https://github.com/HBelusca","followers_url":"https://api.github.com/users/HBelusca/followers","following_url":"https://api.github.com/users/HBelusca/following{/other_user}","gists_url":"https://api.github.com/users/HBelusca/gists{/gist_id}","starred_url":"https://api.github.com/users/HBelusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBelusca/subscriptions","organizations_url":"https://api.github.com/users/HBelusca/orgs","repos_url":"https://api.github.com/users/HBelusca/repos","events_url":"https://api.github.com/users/HBelusca/events{/privacy}","received_events_url":"https://api.github.com/users/HBelusca/received_events","type":"User","site_admin":false},"body":"Is it needed?","created_at":"2018-06-16T14:17:07Z","updated_at":"2018-06-16T14:17:07Z","html_url":"https://github.com/reactos/reactos/pull/617#discussion_r195904028","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/617","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/195904028"},"html":{"href":"https://github.com/reactos/reactos/pull/617#discussion_r195904028"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/617"}}},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/617","id":194626835,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjI2ODM1","html_url":"https://github.com/reactos/reactos/pull/617","diff_url":"https://github.com/reactos/reactos/pull/617.diff","patch_url":"https://github.com/reactos/reactos/pull/617.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/617","number":617,"state":"open","locked":false,"title":"[NETAPI32_APITEST] Fix a NULL dereference of pInfo","user":{"login":"SergeGautherie","id":32623169,"node_id":"MDQ6VXNlcjMyNjIzMTY5","avatar_url":"https://avatars3.githubusercontent.com/u/32623169?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeGautherie","html_url":"https://github.com/SergeGautherie","followers_url":"https://api.github.com/users/SergeGautherie/followers","following_url":"https://api.github.com/users/SergeGautherie/following{/other_user}","gists_url":"https://api.github.com/users/SergeGautherie/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeGautherie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeGautherie/subscriptions","organizations_url":"https://api.github.com/users/SergeGautherie/orgs","repos_url":"https://api.github.com/users/SergeGautherie/repos","events_url":"https://api.github.com/users/SergeGautherie/events{/privacy}","received_events_url":"https://api.github.com/users/SergeGautherie/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n\r\nAdded as is on [r75208](https://svn.reactos.org/svn/reactos?view=revision&revision=75208).\r\n\r\n@ColinFinck\r\n\r\nNB:\r\nThis PR is not aimed at fixing the main DPH issue.\r\n\r\n## Proposed changes\r\n\r\n- Fix a NULL dereference of pInfo\r\n\r\nWith DPH enabled,\r\n{{\r\nUnhandled exception\r\nExceptionCode:    c0000005\r\nFaulting Address:        0\r\n...\r\nmodules/rostests/apitests/netapi32/DsRoleGetPrimaryDomainInformation.c:23 (func_DsRoleGetPrimaryDomainInformation)\r\n...\r\n}}\r\n","created_at":"2018-06-13T15:27:51Z","updated_at":"2018-06-16T14:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3fb0d2191fece303d906ecb0076356b4c990898","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":893634353,"node_id":"MDU6TGFiZWw4OTM2MzQzNTM=","url":"https://api.github.com/repos/reactos/reactos/labels/ROSTESTS","name":"ROSTESTS","color":"b2d4ff","default":false},{"id":863650462,"node_id":"MDU6TGFiZWw4NjM2NTA0NjI=","url":"https://api.github.com/repos/reactos/reactos/labels/bugfix","name":"bugfix","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/617/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/617/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/617/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/b7033fe1a8e9ffb9a20514ae5bb4285f9d741602","head":{"label":"SergeGautherie:SergeGautherie/PRonly_NETAPI32_APITEST_DsRoleGetPrimaryDomainInformation-pInfo","ref":"SergeGautherie/PRonly_NETAPI32_APITEST_DsRoleGetPrimaryDomainInformation-pInfo","sha":"b7033fe1a8e9ffb9a20514ae5bb4285f9d741602","user":{"login":"SergeGautherie","id":32623169,"node_id":"MDQ6VXNlcjMyNjIzMTY5","avatar_url":"https://avatars3.githubusercontent.com/u/32623169?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeGautherie","html_url":"https://github.com/SergeGautherie","followers_url":"https://api.github.com/users/SergeGautherie/followers","following_url":"https://api.github.com/users/SergeGautherie/following{/other_user}","gists_url":"https://api.github.com/users/SergeGautherie/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeGautherie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeGautherie/subscriptions","organizations_url":"https://api.github.com/users/SergeGautherie/orgs","repos_url":"https://api.github.com/users/SergeGautherie/repos","events_url":"https://api.github.com/users/SergeGautherie/events{/privacy}","received_events_url":"https://api.github.com/users/SergeGautherie/received_events","type":"User","site_admin":false},"repo":{"id":106214785,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYyMTQ3ODU=","name":"reactos","full_name":"SergeGautherie/reactos","owner":{"login":"SergeGautherie","id":32623169,"node_id":"MDQ6VXNlcjMyNjIzMTY5","avatar_url":"https://avatars3.githubusercontent.com/u/32623169?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeGautherie","html_url":"https://github.com/SergeGautherie","followers_url":"https://api.github.com/users/SergeGautherie/followers","following_url":"https://api.github.com/users/SergeGautherie/following{/other_user}","gists_url":"https://api.github.com/users/SergeGautherie/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeGautherie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeGautherie/subscriptions","organizations_url":"https://api.github.com/users/SergeGautherie/orgs","repos_url":"https://api.github.com/users/SergeGautherie/repos","events_url":"https://api.github.com/users/SergeGautherie/events{/privacy}","received_events_url":"https://api.github.com/users/SergeGautherie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SergeGautherie/reactos","description":"A free Windows-compatible Operating System","fork":true,"url":"https://api.github.com/repos/SergeGautherie/reactos","forks_url":"https://api.github.com/repos/SergeGautherie/reactos/forks","keys_url":"https://api.github.com/repos/SergeGautherie/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SergeGautherie/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SergeGautherie/reactos/teams","hooks_url":"https://api.github.com/repos/SergeGautherie/reactos/hooks","issue_events_url":"https://api.github.com/repos/SergeGautherie/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/SergeGautherie/reactos/events","assignees_url":"https://api.github.com/repos/SergeGautherie/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/SergeGautherie/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/SergeGautherie/reactos/tags","blobs_url":"https://api.github.com/repos/SergeGautherie/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SergeGautherie/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SergeGautherie/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/SergeGautherie/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SergeGautherie/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/SergeGautherie/reactos/languages","stargazers_url":"https://api.github.com/repos/SergeGautherie/reactos/stargazers","contributors_url":"https://api.github.com/repos/SergeGautherie/reactos/contributors","subscribers_url":"https://api.github.com/repos/SergeGautherie/reactos/subscribers","subscription_url":"https://api.github.com/repos/SergeGautherie/reactos/subscription","commits_url":"https://api.github.com/repos/SergeGautherie/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/SergeGautherie/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/SergeGautherie/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/SergeGautherie/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/SergeGautherie/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/SergeGautherie/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SergeGautherie/reactos/merges","archive_url":"https://api.github.com/repos/SergeGautherie/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SergeGautherie/reactos/downloads","issues_url":"https://api.github.com/repos/SergeGautherie/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/SergeGautherie/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/SergeGautherie/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/SergeGautherie/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SergeGautherie/reactos/labels{/name}","releases_url":"https://api.github.com/repos/SergeGautherie/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/SergeGautherie/reactos/deployments","created_at":"2017-10-08T22:37:01Z","updated_at":"2018-06-15T14:02:22Z","pushed_at":"2018-06-15T16:08:06Z","git_url":"git://github.com/SergeGautherie/reactos.git","ssh_url":"git@github.com:SergeGautherie/reactos.git","clone_url":"https://github.com/SergeGautherie/reactos.git","svn_url":"https://github.com/SergeGautherie/reactos","homepage":null,"size":457312,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"e4f067068c818ea916b648c15563d3891604df72","user":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2Mjc4NDY=","name":"reactos","full_name":"reactos/reactos","owner":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-06-16T13:26:38Z","pushed_at":"2018-06-16T13:33:26Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":456947,"stargazers_count":4393,"watchers_count":4393,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":336,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":336,"open_issues":77,"watchers":4393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/617"},"html":{"href":"https://github.com/reactos/reactos/pull/617"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/617"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/617/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/617/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/617/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/b7033fe1a8e9ffb9a20514ae5bb4285f9d741602"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"HBelusca"}}