{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/171098459","pull_request_review_id":99892497,"id":171098459,"diff_hunk":"@@ -3,6 +3,7 @@\n   <PropertyGroup>\n     <PackageConfigurations>\n       netstandard;\n+      netstandard-Windows_NT;","path":"src/Microsoft.Win32.Registry/src/Configurations.props","position":4,"original_position":4,"commit_id":"8c885baa2fdd94240e44568e91006b9830d28efb","original_commit_id":"8c885baa2fdd94240e44568e91006b9830d28efb","user":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"Because since we harvest a Windows specific netstandard1.3, then package validation will complain given that the compile asset resolved for UAP6.0 (the netstandard2.0 ref) will have a higher assembly version than the resolved implementation for UAP6.0 (the windows specific netstandard1.3 implementation) because the runtime specific assets will be prefered over the non rid specific (lib/netstandard2.0) . This is required in order to pass package validation and in order to be consumed on UAP.","created_at":"2018-02-27T23:12:22Z","updated_at":"2018-02-27T23:12:22Z","html_url":"https://github.com/dotnet/corefx/pull/27385#discussion_r171098459","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/27385","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/171098459"},"html":{"href":"https://github.com/dotnet/corefx/pull/27385#discussion_r171098459"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/27385"}},"in_reply_to_id":171079578},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/27385","id":170878107,"html_url":"https://github.com/dotnet/corefx/pull/27385","diff_url":"https://github.com/dotnet/corefx/pull/27385.diff","patch_url":"https://github.com/dotnet/corefx/pull/27385.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/27385","number":27385,"state":"open","locked":false,"title":"Adding to PackageIndex all of the information about our release from 6.0 and fixing packages that needed placeholders","user":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"Fixes #27100\r\n\r\nAfter shipping UAP 6.0 we didn't update the package index with this data so package validation has not been testing for breaks on packages that we will soon release. These changes include updating said index and reacting to the validation errors.\r\n\r\ncc: @weshaggard @ericstj @joshfree ","created_at":"2018-02-22T22:00:44Z","updated_at":"2018-02-27T23:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8366c4b7d341c251bc08ec7681d9c4ac2217908c","assignee":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"assignees":[{"login":"joperezr","id":13854455,"avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":277448776,"url":"https://api.github.com/repos/dotnet/corefx/labels/packaging","name":"packaging","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/27385/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/27385/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/27385/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/8c885baa2fdd94240e44568e91006b9830d28efb","head":{"label":"joperezr:FixPackageIndex","ref":"FixPackageIndex","sha":"8c885baa2fdd94240e44568e91006b9830d28efb","user":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"repo":{"id":41888057,"name":"corefx","full_name":"joperezr/corefx","owner":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joperezr/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/joperezr/corefx","forks_url":"https://api.github.com/repos/joperezr/corefx/forks","keys_url":"https://api.github.com/repos/joperezr/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joperezr/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joperezr/corefx/teams","hooks_url":"https://api.github.com/repos/joperezr/corefx/hooks","issue_events_url":"https://api.github.com/repos/joperezr/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/joperezr/corefx/events","assignees_url":"https://api.github.com/repos/joperezr/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/joperezr/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/joperezr/corefx/tags","blobs_url":"https://api.github.com/repos/joperezr/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joperezr/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joperezr/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/joperezr/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joperezr/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/joperezr/corefx/languages","stargazers_url":"https://api.github.com/repos/joperezr/corefx/stargazers","contributors_url":"https://api.github.com/repos/joperezr/corefx/contributors","subscribers_url":"https://api.github.com/repos/joperezr/corefx/subscribers","subscription_url":"https://api.github.com/repos/joperezr/corefx/subscription","commits_url":"https://api.github.com/repos/joperezr/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/joperezr/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/joperezr/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/joperezr/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/joperezr/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/joperezr/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joperezr/corefx/merges","archive_url":"https://api.github.com/repos/joperezr/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joperezr/corefx/downloads","issues_url":"https://api.github.com/repos/joperezr/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/joperezr/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/joperezr/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/joperezr/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joperezr/corefx/labels{/name}","releases_url":"https://api.github.com/repos/joperezr/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/joperezr/corefx/deployments","created_at":"2015-09-03T23:06:38Z","updated_at":"2016-01-12T19:38:17Z","pushed_at":"2018-02-27T19:19:49Z","git_url":"git://github.com/joperezr/corefx.git","ssh_url":"git@github.com:joperezr/corefx.git","clone_url":"https://github.com/joperezr/corefx.git","svn_url":"https://github.com/joperezr/corefx","homepage":"http://dotnet.github.io/core/","size":164026,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:release/2.1","ref":"release/2.1","sha":"8de529d8d6f4d4871ff469f985fcd236d3592834","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-02-27T12:00:11Z","pushed_at":"2018-02-27T23:07:14Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":171073,"stargazers_count":13444,"watchers_count":13444,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3817,"mirror_url":null,"archived":false,"open_issues_count":2230,"license":null,"forks":3817,"open_issues":2230,"watchers":13444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/27385"},"html":{"href":"https://github.com/dotnet/corefx/pull/27385"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/27385"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/27385/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/27385/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/27385/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/8c885baa2fdd94240e44568e91006b9830d28efb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joperezr"}}