{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/comments/173986000","pull_request_review_id":103252627,"id":173986000,"diff_hunk":"@@ -0,0 +1,159 @@\n+import Foundation\n+\n+@objc(MBMatchingOptions)\n+open class MatchingOptions: DirectionsOptions {","path":"MapboxDirections/Match/MBMatchingOptions.swift","position":4,"original_position":4,"commit_id":"42c4069d93b0857a218b95c0423abc425faa2cc7","original_commit_id":"42c4069d93b0857a218b95c0423abc425faa2cc7","user":{"login":"1ec5","id":1231218,"avatar_url":"https://avatars0.githubusercontent.com/u/1231218?v=4","gravatar_id":"","url":"https://api.github.com/users/1ec5","html_url":"https://github.com/1ec5","followers_url":"https://api.github.com/users/1ec5/followers","following_url":"https://api.github.com/users/1ec5/following{/other_user}","gists_url":"https://api.github.com/users/1ec5/gists{/gist_id}","starred_url":"https://api.github.com/users/1ec5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ec5/subscriptions","organizations_url":"https://api.github.com/users/1ec5/orgs","repos_url":"https://api.github.com/users/1ec5/repos","events_url":"https://api.github.com/users/1ec5/events{/privacy}","received_events_url":"https://api.github.com/users/1ec5/received_events","type":"User","site_admin":false},"body":"Per chat, did you want to rename this class back to MatchOptions, for consistency with RouteOptions?\r\n\r\n/ref https://github.com/mapbox/MapboxDirections.swift/pull/236#discussion_r163955397","created_at":"2018-03-13T00:22:19Z","updated_at":"2018-03-13T00:40:51Z","html_url":"https://github.com/mapbox/MapboxDirections.swift/pull/236#discussion_r173986000","pull_request_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/236","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/comments/173986000"},"html":{"href":"https://github.com/mapbox/MapboxDirections.swift/pull/236#discussion_r173986000"},"pull_request":{"href":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/236"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/236","id":164999562,"html_url":"https://github.com/mapbox/MapboxDirections.swift/pull/236","diff_url":"https://github.com/mapbox/MapboxDirections.swift/pull/236.diff","patch_url":"https://github.com/mapbox/MapboxDirections.swift/pull/236.patch","issue_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/issues/236","number":236,"state":"open","locked":false,"title":"Add map matching","user":{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars0.githubusercontent.com/u/1058624?v=4","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false},"body":"closes: https://github.com/mapbox/MapboxDirections.swift/issues/158\r\n\r\nThis PR adds support for the Mapbox [Map Matching API](https://www.mapbox.com/api-documentation/#map-matching). \r\n\r\ntodo:\r\n- [ ] document\r\n- [x] test\r\n- [x] make demo app work with both matching and directions.\r\n\r\n/cc @mapbox/navigation-ios ","created_at":"2018-01-25T00:21:46Z","updated_at":"2018-03-13T00:40:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"258da27bd07dd21484e307bdffa958f65750b985","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/236/commits","review_comments_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/236/comments","review_comment_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/issues/236/comments","statuses_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/statuses/42c4069d93b0857a218b95c0423abc425faa2cc7","head":{"label":"mapbox:mapmatching","ref":"mapmatching","sha":"42c4069d93b0857a218b95c0423abc425faa2cc7","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":27559880,"name":"MapboxDirections.swift","full_name":"mapbox/MapboxDirections.swift","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/MapboxDirections.swift","description":"Traffic-aware directions in Swift or Objective-C on iOS, macOS, tvOS, and watchOS","fork":false,"url":"https://api.github.com/repos/mapbox/MapboxDirections.swift","forks_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/forks","keys_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/teams","hooks_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/hooks","issue_events_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/events","assignees_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/tags","blobs_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/languages","stargazers_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/stargazers","contributors_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/contributors","subscribers_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/subscribers","subscription_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/subscription","commits_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/merges","archive_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/downloads","issues_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/deployments","created_at":"2014-12-04T21:01:09Z","updated_at":"2018-03-12T19:10:31Z","pushed_at":"2018-03-12T22:41:53Z","git_url":"git://github.com/mapbox/MapboxDirections.swift.git","ssh_url":"git@github.com:mapbox/MapboxDirections.swift.git","clone_url":"https://github.com/mapbox/MapboxDirections.swift.git","svn_url":"https://github.com/mapbox/MapboxDirections.swift","homepage":"https://www.mapbox.com/directions/","size":5069,"stargazers_count":68,"watchers_count":68,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":34,"open_issues":20,"watchers":68,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"35f01a2f1816b659060a7b5c04318cc85e53172f","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":27559880,"name":"MapboxDirections.swift","full_name":"mapbox/MapboxDirections.swift","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/MapboxDirections.swift","description":"Traffic-aware directions in Swift or Objective-C on iOS, macOS, tvOS, and watchOS","fork":false,"url":"https://api.github.com/repos/mapbox/MapboxDirections.swift","forks_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/forks","keys_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/teams","hooks_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/hooks","issue_events_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/events","assignees_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/tags","blobs_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/languages","stargazers_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/stargazers","contributors_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/contributors","subscribers_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/subscribers","subscription_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/subscription","commits_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/merges","archive_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/downloads","issues_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/MapboxDirections.swift/deployments","created_at":"2014-12-04T21:01:09Z","updated_at":"2018-03-12T19:10:31Z","pushed_at":"2018-03-12T22:41:53Z","git_url":"git://github.com/mapbox/MapboxDirections.swift.git","ssh_url":"git@github.com:mapbox/MapboxDirections.swift.git","clone_url":"https://github.com/mapbox/MapboxDirections.swift.git","svn_url":"https://github.com/mapbox/MapboxDirections.swift","homepage":"https://www.mapbox.com/directions/","size":5069,"stargazers_count":68,"watchers_count":68,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":34,"open_issues":20,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/236"},"html":{"href":"https://github.com/mapbox/MapboxDirections.swift/pull/236"},"issue":{"href":"https://api.github.com/repos/mapbox/MapboxDirections.swift/issues/236"},"comments":{"href":"https://api.github.com/repos/mapbox/MapboxDirections.swift/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/MapboxDirections.swift/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/MapboxDirections.swift/statuses/42c4069d93b0857a218b95c0423abc425faa2cc7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"1ec5"}}