{"action":"created","comment":{"url":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments/220639907","pull_request_review_id":159091884,"id":220639907,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDYzOTkwNw==","diff_hunk":"@@ -9,3 +9,21 @@ Example of this to include here:\n   $headerBackgroundColor: #571963;\n   $headerColor: white;\n */\n+\n+// Shared","path":"app/assets/stylesheets/nucore-overrides.scss","position":5,"original_position":5,"commit_id":"e6643e709c9c4ebea887f1a5224753b9c4e18dcb","original_commit_id":"e6643e709c9c4ebea887f1a5224753b9c4e18dcb","user":{"login":"jhanggi","id":1099111,"node_id":"MDQ6VXNlcjEwOTkxMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1099111?v=4","gravatar_id":"","url":"https://api.github.com/users/jhanggi","html_url":"https://github.com/jhanggi","followers_url":"https://api.github.com/users/jhanggi/followers","following_url":"https://api.github.com/users/jhanggi/following{/other_user}","gists_url":"https://api.github.com/users/jhanggi/gists{/gist_id}","starred_url":"https://api.github.com/users/jhanggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhanggi/subscriptions","organizations_url":"https://api.github.com/users/jhanggi/orgs","repos_url":"https://api.github.com/users/jhanggi/repos","events_url":"https://api.github.com/users/jhanggi/events{/privacy}","received_events_url":"https://api.github.com/users/jhanggi/received_events","type":"User","site_admin":false},"body":"I feel like these variables could probably move to `nucore-variables.scss`. All of these seem like more generic variables for colors, so there's no harm in keeping them around. Usually, we like to reserve this file for changes in the fork and leave this empty in `nucore-open`.\r\n\r\nOne thing to think about while use/manage mode is if there's a way to define and use variables like `$manageColor`, `$manageLightColor` (or ideally better names). Then you would have something like `$manageColor: $orange`, but other schools could use a different color scheme but still be able to use the use/manage feature.","created_at":"2018-09-26T16:43:23Z","updated_at":"2018-09-26T16:56:19Z","html_url":"https://github.com/tablexi/nucore-open/pull/1643#discussion_r220639907","pull_request_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1643","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments/220639907"},"html":{"href":"https://github.com/tablexi/nucore-open/pull/1643#discussion_r220639907"},"pull_request":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1643"}}},"pull_request":{"url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1643","id":206137347,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTM3MzQ3","html_url":"https://github.com/tablexi/nucore-open/pull/1643","diff_url":"https://github.com/tablexi/nucore-open/pull/1643.diff","patch_url":"https://github.com/tablexi/nucore-open/pull/1643.patch","issue_url":"https://api.github.com/repos/tablexi/nucore-open/issues/1643","number":1643,"state":"open","locked":false,"title":"Changes to typography","user":{"login":"robstolarz","id":3682844,"node_id":"MDQ6VXNlcjM2ODI4NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3682844?v=4","gravatar_id":"","url":"https://api.github.com/users/robstolarz","html_url":"https://github.com/robstolarz","followers_url":"https://api.github.com/users/robstolarz/followers","following_url":"https://api.github.com/users/robstolarz/following{/other_user}","gists_url":"https://api.github.com/users/robstolarz/gists{/gist_id}","starred_url":"https://api.github.com/users/robstolarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstolarz/subscriptions","organizations_url":"https://api.github.com/users/robstolarz/orgs","repos_url":"https://api.github.com/users/robstolarz/repos","events_url":"https://api.github.com/users/robstolarz/events{/privacy}","received_events_url":"https://api.github.com/users/robstolarz/received_events","type":"User","site_admin":false},"body":"# Release Notes\r\nAs we discussed earlier, we'll start to make some changes to spacing and typography. I'm reluctant to start making massive changes to spacing until some of the UI elements begin to change, except where improper spacing makes the site unusable.\r\n\r\nThis pull request modifies the typography of the site to fit the specification we shared.\r\n\r\n# Screenshots\r\n\r\n## Facilities listing\r\n### Before\r\n![facilities-nucore-upstream](https://user-images.githubusercontent.com/3682844/43665418-09a723e4-973e-11e8-8732-a4ccd19a934a.png)\r\n### After\r\n![facilities-design-rework-typography](https://user-images.githubusercontent.com/3682844/43665416-099d1cc8-973e-11e8-873d-5a01a63892f2.png)\r\n\r\n## Example Facility\r\n### Before\r\n![facilities_example-nucore-upstream](https://user-images.githubusercontent.com/3682844/43665415-098f8ad6-973e-11e8-9132-7bc5298be688.png)\r\n### After\r\n![facilities_example-design-rework-typography](https://user-images.githubusercontent.com/3682844/43665414-0985b45c-973e-11e8-90df-55cbb2f95e7c.png)\r\n\r\n# Additional Context\r\nIf any spacing looks egregiously incorrect, let me know and I will fix it. I'm just reluctant to make every change in a single PR.","created_at":"2018-08-03T20:58:26Z","updated_at":"2018-09-26T16:56:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7060e259ad0253adb6dc261c9e631843c58460e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":864713861,"node_id":"MDU6TGFiZWw4NjQ3MTM4NjE=","url":"https://api.github.com/repos/tablexi/nucore-open/labels/UConn","name":"UConn","color":"000E2F","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1643/commits","review_comments_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1643/comments","review_comment_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/issues/1643/comments","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/e6643e709c9c4ebea887f1a5224753b9c4e18dcb","head":{"label":"SquaredLabs:design-rework-typography","ref":"design-rework-typography","sha":"e6643e709c9c4ebea887f1a5224753b9c4e18dcb","user":{"login":"SquaredLabs","id":29649622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjQ5NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/29649622?v=4","gravatar_id":"","url":"https://api.github.com/users/SquaredLabs","html_url":"https://github.com/SquaredLabs","followers_url":"https://api.github.com/users/SquaredLabs/followers","following_url":"https://api.github.com/users/SquaredLabs/following{/other_user}","gists_url":"https://api.github.com/users/SquaredLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/SquaredLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SquaredLabs/subscriptions","organizations_url":"https://api.github.com/users/SquaredLabs/orgs","repos_url":"https://api.github.com/users/SquaredLabs/repos","events_url":"https://api.github.com/users/SquaredLabs/events{/privacy}","received_events_url":"https://api.github.com/users/SquaredLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":119782035,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3ODIwMzU=","name":"nucore-uconn","full_name":"SquaredLabs/nucore-uconn","private":false,"owner":{"login":"SquaredLabs","id":29649622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjQ5NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/29649622?v=4","gravatar_id":"","url":"https://api.github.com/users/SquaredLabs","html_url":"https://github.com/SquaredLabs","followers_url":"https://api.github.com/users/SquaredLabs/followers","following_url":"https://api.github.com/users/SquaredLabs/following{/other_user}","gists_url":"https://api.github.com/users/SquaredLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/SquaredLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SquaredLabs/subscriptions","organizations_url":"https://api.github.com/users/SquaredLabs/orgs","repos_url":"https://api.github.com/users/SquaredLabs/repos","events_url":"https://api.github.com/users/SquaredLabs/events{/privacy}","received_events_url":"https://api.github.com/users/SquaredLabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SquaredLabs/nucore-uconn","description":"Northwestern University Core Facility Management Software (NUCore)","fork":true,"url":"https://api.github.com/repos/SquaredLabs/nucore-uconn","forks_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/forks","keys_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/teams","hooks_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/hooks","issue_events_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/issues/events{/number}","events_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/events","assignees_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/assignees{/user}","branches_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/branches{/branch}","tags_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/tags","blobs_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/git/refs{/sha}","trees_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/statuses/{sha}","languages_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/languages","stargazers_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/stargazers","contributors_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/contributors","subscribers_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/subscribers","subscription_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/subscription","commits_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/commits{/sha}","git_commits_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/git/commits{/sha}","comments_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/comments{/number}","issue_comment_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/issues/comments{/number}","contents_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/contents/{+path}","compare_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/merges","archive_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/downloads","issues_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/issues{/number}","pulls_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/pulls{/number}","milestones_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/milestones{/number}","notifications_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/labels{/name}","releases_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/releases{/id}","deployments_url":"https://api.github.com/repos/SquaredLabs/nucore-uconn/deployments","created_at":"2018-02-01T04:18:59Z","updated_at":"2018-08-09T19:20:11Z","pushed_at":"2018-09-26T13:22:52Z","git_url":"git://github.com/SquaredLabs/nucore-uconn.git","ssh_url":"git@github.com:SquaredLabs/nucore-uconn.git","clone_url":"https://github.com/SquaredLabs/nucore-uconn.git","svn_url":"https://github.com/SquaredLabs/nucore-uconn","homepage":"","size":114074,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":23,"watchers":0,"default_branch":"master"}},"base":{"label":"tablexi:uconn-design-updates","ref":"uconn-design-updates","sha":"fc2c5705b2044ebd133c4e269084e9d941f03d7a","user":{"login":"tablexi","id":229702,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTcwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/229702?v=4","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"repo":{"id":1439473,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5NDcz","name":"nucore-open","full_name":"tablexi/nucore-open","private":false,"owner":{"login":"tablexi","id":229702,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTcwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/229702?v=4","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tablexi/nucore-open","description":"Northwestern University Core Facility Management Software (NUCore)","fork":false,"url":"https://api.github.com/repos/tablexi/nucore-open","forks_url":"https://api.github.com/repos/tablexi/nucore-open/forks","keys_url":"https://api.github.com/repos/tablexi/nucore-open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tablexi/nucore-open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tablexi/nucore-open/teams","hooks_url":"https://api.github.com/repos/tablexi/nucore-open/hooks","issue_events_url":"https://api.github.com/repos/tablexi/nucore-open/issues/events{/number}","events_url":"https://api.github.com/repos/tablexi/nucore-open/events","assignees_url":"https://api.github.com/repos/tablexi/nucore-open/assignees{/user}","branches_url":"https://api.github.com/repos/tablexi/nucore-open/branches{/branch}","tags_url":"https://api.github.com/repos/tablexi/nucore-open/tags","blobs_url":"https://api.github.com/repos/tablexi/nucore-open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tablexi/nucore-open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tablexi/nucore-open/git/refs{/sha}","trees_url":"https://api.github.com/repos/tablexi/nucore-open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/{sha}","languages_url":"https://api.github.com/repos/tablexi/nucore-open/languages","stargazers_url":"https://api.github.com/repos/tablexi/nucore-open/stargazers","contributors_url":"https://api.github.com/repos/tablexi/nucore-open/contributors","subscribers_url":"https://api.github.com/repos/tablexi/nucore-open/subscribers","subscription_url":"https://api.github.com/repos/tablexi/nucore-open/subscription","commits_url":"https://api.github.com/repos/tablexi/nucore-open/commits{/sha}","git_commits_url":"https://api.github.com/repos/tablexi/nucore-open/git/commits{/sha}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/comments{/number}","issue_comment_url":"https://api.github.com/repos/tablexi/nucore-open/issues/comments{/number}","contents_url":"https://api.github.com/repos/tablexi/nucore-open/contents/{+path}","compare_url":"https://api.github.com/repos/tablexi/nucore-open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tablexi/nucore-open/merges","archive_url":"https://api.github.com/repos/tablexi/nucore-open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tablexi/nucore-open/downloads","issues_url":"https://api.github.com/repos/tablexi/nucore-open/issues{/number}","pulls_url":"https://api.github.com/repos/tablexi/nucore-open/pulls{/number}","milestones_url":"https://api.github.com/repos/tablexi/nucore-open/milestones{/number}","notifications_url":"https://api.github.com/repos/tablexi/nucore-open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tablexi/nucore-open/labels{/name}","releases_url":"https://api.github.com/repos/tablexi/nucore-open/releases{/id}","deployments_url":"https://api.github.com/repos/tablexi/nucore-open/deployments","created_at":"2011-03-04T13:45:37Z","updated_at":"2018-09-25T22:27:10Z","pushed_at":"2018-09-26T13:22:54Z","git_url":"git://github.com/tablexi/nucore-open.git","ssh_url":"git@github.com:tablexi/nucore-open.git","clone_url":"https://github.com/tablexi/nucore-open.git","svn_url":"https://github.com/tablexi/nucore-open","homepage":"","size":72729,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":5,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1643"},"html":{"href":"https://github.com/tablexi/nucore-open/pull/1643"},"issue":{"href":"https://api.github.com/repos/tablexi/nucore-open/issues/1643"},"comments":{"href":"https://api.github.com/repos/tablexi/nucore-open/issues/1643/comments"},"review_comments":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1643/comments"},"review_comment":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1643/commits"},"statuses":{"href":"https://api.github.com/repos/tablexi/nucore-open/statuses/e6643e709c9c4ebea887f1a5224753b9c4e18dcb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jhanggi"}}