{"action":"created","comment":{"url":"https://api.github.com/repos/NLog/NLog/pulls/comments/209740924","pull_request_review_id":145814172,"id":209740924,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTc0MDkyNA==","diff_hunk":"@@ -107,5 +107,81 @@ public static Assembly LoadFromName(string assemblyName)\n #endif\n         }\n \n+#if !SILVERLIGHT && !NETSTANDARD1_3\n+        public static string GetAssemblyFileLocation(Assembly assembly)","path":"src/NLog/Internal/AssemblyHelpers.cs","position":5,"original_position":5,"commit_id":"3b2db4c7d3c6b1061a5d4a031b5b033aef8697cf","original_commit_id":"c524fac57711e1b401a595cc806fc9bfabc30ae3","user":{"login":"304NotModified","id":5808377,"node_id":"MDQ6VXNlcjU4MDgzNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5808377?v=4","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"body":"is this just a move or are there some changes here?","created_at":"2018-08-13T20:06:55Z","updated_at":"2018-08-13T20:12:29Z","html_url":"https://github.com/NLog/NLog/pull/2846#discussion_r209740924","pull_request_url":"https://api.github.com/repos/NLog/NLog/pulls/2846","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments/209740924"},"html":{"href":"https://github.com/NLog/NLog/pull/2846#discussion_r209740924"},"pull_request":{"href":"https://api.github.com/repos/NLog/NLog/pulls/2846"}}},"pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/2846","id":207829716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODI5NzE2","html_url":"https://github.com/NLog/NLog/pull/2846","diff_url":"https://github.com/NLog/NLog/pull/2846.diff","patch_url":"https://github.com/NLog/NLog/pull/2846.patch","issue_url":"https://api.github.com/repos/NLog/NLog/issues/2846","number":2846,"state":"open","locked":false,"title":"Include Entry Assembly File Location when loading candidate NLog.config","user":{"login":"snakefoot","id":11509660,"node_id":"MDQ6VXNlcjExNTA5NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/11509660?v=4","gravatar_id":"","url":"https://api.github.com/users/snakefoot","html_url":"https://github.com/snakefoot","followers_url":"https://api.github.com/users/snakefoot/followers","following_url":"https://api.github.com/users/snakefoot/following{/other_user}","gists_url":"https://api.github.com/users/snakefoot/gists{/gist_id}","starred_url":"https://api.github.com/users/snakefoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snakefoot/subscriptions","organizations_url":"https://api.github.com/users/snakefoot/orgs","repos_url":"https://api.github.com/users/snakefoot/repos","events_url":"https://api.github.com/users/snakefoot/events{/privacy}","received_events_url":"https://api.github.com/users/snakefoot/received_events","type":"User","site_admin":false},"body":"Improve the NetCore experience where the BaseDirectory is often different from the bin-location (But the Bin-location is where nlog.config is copied to by default)\r\n\r\nAlso improve the logic for recognizing identical paths (with or without ending directory-separator)\r\n\r\nThink this will resolve #1342","created_at":"2018-08-12T16:43:02Z","updated_at":"2018-08-13T20:12:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0772ac73acf170eaeb4fb02046762f745582681","assignee":{"login":"304NotModified","id":5808377,"node_id":"MDQ6VXNlcjU4MDgzNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5808377?v=4","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"assignees":[{"login":"304NotModified","id":5808377,"node_id":"MDQ6VXNlcjU4MDgzNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5808377?v=4","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NLog/NLog/pulls/2846/commits","review_comments_url":"https://api.github.com/repos/NLog/NLog/pulls/2846/comments","review_comment_url":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/2846/comments","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/3b2db4c7d3c6b1061a5d4a031b5b033aef8697cf","head":{"label":"snakefoot:ConfigurationItemFactoryAutoLoad","ref":"ConfigurationItemFactoryAutoLoad","sha":"3b2db4c7d3c6b1061a5d4a031b5b033aef8697cf","user":{"login":"snakefoot","id":11509660,"node_id":"MDQ6VXNlcjExNTA5NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/11509660?v=4","gravatar_id":"","url":"https://api.github.com/users/snakefoot","html_url":"https://github.com/snakefoot","followers_url":"https://api.github.com/users/snakefoot/followers","following_url":"https://api.github.com/users/snakefoot/following{/other_user}","gists_url":"https://api.github.com/users/snakefoot/gists{/gist_id}","starred_url":"https://api.github.com/users/snakefoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snakefoot/subscriptions","organizations_url":"https://api.github.com/users/snakefoot/orgs","repos_url":"https://api.github.com/users/snakefoot/repos","events_url":"https://api.github.com/users/snakefoot/events{/privacy}","received_events_url":"https://api.github.com/users/snakefoot/received_events","type":"User","site_admin":false},"repo":{"id":69390228,"node_id":"MDEwOlJlcG9zaXRvcnk2OTM5MDIyOA==","name":"NLog","full_name":"snakefoot/NLog","owner":{"login":"snakefoot","id":11509660,"node_id":"MDQ6VXNlcjExNTA5NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/11509660?v=4","gravatar_id":"","url":"https://api.github.com/users/snakefoot","html_url":"https://github.com/snakefoot","followers_url":"https://api.github.com/users/snakefoot/followers","following_url":"https://api.github.com/users/snakefoot/following{/other_user}","gists_url":"https://api.github.com/users/snakefoot/gists{/gist_id}","starred_url":"https://api.github.com/users/snakefoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snakefoot/subscriptions","organizations_url":"https://api.github.com/users/snakefoot/orgs","repos_url":"https://api.github.com/users/snakefoot/repos","events_url":"https://api.github.com/users/snakefoot/events{/privacy}","received_events_url":"https://api.github.com/users/snakefoot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snakefoot/NLog","description":"NLog - Advanced .NET, Silverlight and Xamarin Logging","fork":true,"url":"https://api.github.com/repos/snakefoot/NLog","forks_url":"https://api.github.com/repos/snakefoot/NLog/forks","keys_url":"https://api.github.com/repos/snakefoot/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snakefoot/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snakefoot/NLog/teams","hooks_url":"https://api.github.com/repos/snakefoot/NLog/hooks","issue_events_url":"https://api.github.com/repos/snakefoot/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/snakefoot/NLog/events","assignees_url":"https://api.github.com/repos/snakefoot/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/snakefoot/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/snakefoot/NLog/tags","blobs_url":"https://api.github.com/repos/snakefoot/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snakefoot/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snakefoot/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/snakefoot/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snakefoot/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/snakefoot/NLog/languages","stargazers_url":"https://api.github.com/repos/snakefoot/NLog/stargazers","contributors_url":"https://api.github.com/repos/snakefoot/NLog/contributors","subscribers_url":"https://api.github.com/repos/snakefoot/NLog/subscribers","subscription_url":"https://api.github.com/repos/snakefoot/NLog/subscription","commits_url":"https://api.github.com/repos/snakefoot/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/snakefoot/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/snakefoot/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/snakefoot/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/snakefoot/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/snakefoot/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snakefoot/NLog/merges","archive_url":"https://api.github.com/repos/snakefoot/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snakefoot/NLog/downloads","issues_url":"https://api.github.com/repos/snakefoot/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/snakefoot/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/snakefoot/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/snakefoot/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snakefoot/NLog/labels{/name}","releases_url":"https://api.github.com/repos/snakefoot/NLog/releases{/id}","deployments_url":"https://api.github.com/repos/snakefoot/NLog/deployments","created_at":"2016-09-27T19:15:49Z","updated_at":"2018-08-03T08:46:04Z","pushed_at":"2018-08-13T20:08:19Z","git_url":"git://github.com/snakefoot/NLog.git","ssh_url":"git@github.com:snakefoot/NLog.git","clone_url":"https://github.com/snakefoot/NLog.git","svn_url":"https://github.com/snakefoot/NLog","homepage":"http://nlog-project.org","size":95098,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NLog:dev","ref":"dev","sha":"f65cc2ace0ebbe60cc5839b2a0f5e9417d04797e","user":{"login":"NLog","id":2331628,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzE2Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/2331628?v=4","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"repo":{"id":5780416,"node_id":"MDEwOlJlcG9zaXRvcnk1NzgwNDE2","name":"NLog","full_name":"NLog/NLog","owner":{"login":"NLog","id":2331628,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzE2Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/2331628?v=4","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NLog/NLog","description":"NLog - Advanced and Structured Logging for Various .NET Platforms","fork":false,"url":"https://api.github.com/repos/NLog/NLog","forks_url":"https://api.github.com/repos/NLog/NLog/forks","keys_url":"https://api.github.com/repos/NLog/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NLog/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NLog/NLog/teams","hooks_url":"https://api.github.com/repos/NLog/NLog/hooks","issue_events_url":"https://api.github.com/repos/NLog/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/NLog/NLog/events","assignees_url":"https://api.github.com/repos/NLog/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/NLog/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/NLog/NLog/tags","blobs_url":"https://api.github.com/repos/NLog/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NLog/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NLog/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/NLog/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/NLog/NLog/languages","stargazers_url":"https://api.github.com/repos/NLog/NLog/stargazers","contributors_url":"https://api.github.com/repos/NLog/NLog/contributors","subscribers_url":"https://api.github.com/repos/NLog/NLog/subscribers","subscription_url":"https://api.github.com/repos/NLog/NLog/subscription","commits_url":"https://api.github.com/repos/NLog/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/NLog/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/NLog/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/NLog/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/NLog/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/NLog/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NLog/NLog/merges","archive_url":"https://api.github.com/repos/NLog/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NLog/NLog/downloads","issues_url":"https://api.github.com/repos/NLog/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/NLog/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/NLog/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/NLog/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NLog/NLog/labels{/name}","releases_url":"https://api.github.com/repos/NLog/NLog/releases{/id}","deployments_url":"https://api.github.com/repos/NLog/NLog/deployments","created_at":"2012-09-12T13:49:29Z","updated_at":"2018-08-13T10:09:13Z","pushed_at":"2018-08-13T20:08:20Z","git_url":"git://github.com/NLog/NLog.git","ssh_url":"git@github.com:NLog/NLog.git","clone_url":"https://github.com/NLog/NLog.git","svn_url":"https://github.com/NLog/NLog","homepage":"http://nlog-project.org","size":109271,"stargazers_count":3224,"watchers_count":3224,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":959,"mirror_url":null,"archived":false,"open_issues_count":212,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":959,"open_issues":212,"watchers":3224,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/2846"},"html":{"href":"https://github.com/NLog/NLog/pull/2846"},"issue":{"href":"https://api.github.com/repos/NLog/NLog/issues/2846"},"comments":{"href":"https://api.github.com/repos/NLog/NLog/issues/2846/comments"},"review_comments":{"href":"https://api.github.com/repos/NLog/NLog/pulls/2846/comments"},"review_comment":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NLog/NLog/pulls/2846/commits"},"statuses":{"href":"https://api.github.com/repos/NLog/NLog/statuses/3b2db4c7d3c6b1061a5d4a031b5b033aef8697cf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"304NotModified"}}