{"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/238972406","pull_request_review_id":181640772,"id":238972406,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODk3MjQwNg==","diff_hunk":"@@ -249,4 +250,22 @@ Status RecordBatch::Validate() const {\n \n RecordBatchReader::~RecordBatchReader() {}\n \n+Status RecordBatchReader::ReadAll(std::vector<std::shared_ptr<RecordBatch>>* batches) {\n+  while (true) {\n+    std::shared_ptr<RecordBatch> batch;\n+    RETURN_NOT_OK(ReadNext(&batch));\n+    if (!batch) {\n+      break;\n+    }\n+    batches->emplace_back(std::move(batch));\n+  }\n+  return Status::OK();\n+}\n+\n+Status RecordBatchReader::ReadAll(std::shared_ptr<Table>* table) {\n+  std::vector<std::shared_ptr<RecordBatch>> batches;\n+  RETURN_NOT_OK(ReadAll(&batches));\n+  return Table::FromRecordBatches(this->schema(), batches, table);","path":"cpp/src/arrow/record_batch.cc","position":27,"original_position":27,"commit_id":"03216b352f3ee44c90bc7c429c64c5c4be2c6047","original_commit_id":"03216b352f3ee44c90bc7c429c64c5c4be2c6047","user":{"login":"kou","id":27350,"node_id":"MDQ6VXNlcjI3MzUw","avatar_url":"https://avatars3.githubusercontent.com/u/27350?v=4","gravatar_id":"","url":"https://api.github.com/users/kou","html_url":"https://github.com/kou","followers_url":"https://api.github.com/users/kou/followers","following_url":"https://api.github.com/users/kou/following{/other_user}","gists_url":"https://api.github.com/users/kou/gists{/gist_id}","starred_url":"https://api.github.com/users/kou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kou/subscriptions","organizations_url":"https://api.github.com/users/kou/orgs","repos_url":"https://api.github.com/users/kou/repos","events_url":"https://api.github.com/users/kou/events{/privacy}","received_events_url":"https://api.github.com/users/kou/received_events","type":"User","site_admin":false},"body":"Should we use `this->` here?","created_at":"2018-12-05T08:42:35Z","updated_at":"2018-12-05T08:44:43Z","html_url":"https://github.com/apache/arrow/pull/3097#discussion_r238972406","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/3097","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/238972406"},"html":{"href":"https://github.com/apache/arrow/pull/3097#discussion_r238972406"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/3097"}}},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/3097","id":236040695,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDQwNjk1","html_url":"https://github.com/apache/arrow/pull/3097","diff_url":"https://github.com/apache/arrow/pull/3097.diff","patch_url":"https://github.com/apache/arrow/pull/3097.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/3097","number":3097,"state":"open","locked":false,"title":"ARROW-3318: [C++] Push down read-all-batches operation on RecordBatchReader into C++","user":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-05T04:12:20Z","updated_at":"2018-12-05T08:44:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"154375925dcc04f58cd7dd4b890e06911375ebf1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/3097/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/3097/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/3097/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/03216b352f3ee44c90bc7c429c64c5c4be2c6047","head":{"label":"wesm:ARROW-3318","ref":"ARROW-3318","sha":"03216b352f3ee44c90bc7c429c64c5c4be2c6047","user":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"repo":{"id":52022289,"node_id":"MDEwOlJlcG9zaXRvcnk1MjAyMjI4OQ==","name":"arrow","full_name":"wesm/arrow","private":false,"owner":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wesm/arrow","description":"Mirror of Apache Arrow","fork":true,"url":"https://api.github.com/repos/wesm/arrow","forks_url":"https://api.github.com/repos/wesm/arrow/forks","keys_url":"https://api.github.com/repos/wesm/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesm/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesm/arrow/teams","hooks_url":"https://api.github.com/repos/wesm/arrow/hooks","issue_events_url":"https://api.github.com/repos/wesm/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/wesm/arrow/events","assignees_url":"https://api.github.com/repos/wesm/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/wesm/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/wesm/arrow/tags","blobs_url":"https://api.github.com/repos/wesm/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesm/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesm/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesm/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesm/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/wesm/arrow/languages","stargazers_url":"https://api.github.com/repos/wesm/arrow/stargazers","contributors_url":"https://api.github.com/repos/wesm/arrow/contributors","subscribers_url":"https://api.github.com/repos/wesm/arrow/subscribers","subscription_url":"https://api.github.com/repos/wesm/arrow/subscription","commits_url":"https://api.github.com/repos/wesm/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesm/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesm/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesm/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesm/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/wesm/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesm/arrow/merges","archive_url":"https://api.github.com/repos/wesm/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesm/arrow/downloads","issues_url":"https://api.github.com/repos/wesm/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/wesm/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/wesm/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/wesm/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesm/arrow/labels{/name}","releases_url":"https://api.github.com/repos/wesm/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/wesm/arrow/deployments","created_at":"2016-02-18T16:41:50Z","updated_at":"2018-12-05T00:19:21Z","pushed_at":"2018-12-05T04:08:21Z","git_url":"git://github.com/wesm/arrow.git","ssh_url":"git@github.com:wesm/arrow.git","clone_url":"https://github.com/wesm/arrow.git","svn_url":"https://github.com/wesm/arrow","homepage":null,"size":22118,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a06624e634af72c9b7b24a548311785d99a4d4e7","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"node_id":"MDEwOlJlcG9zaXRvcnk1MTkwNTM1Mw==","name":"arrow","full_name":"apache/arrow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2018-12-05T08:37:58Z","pushed_at":"2018-12-05T08:37:45Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":21650,"stargazers_count":2800,"watchers_count":2800,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":739,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":739,"open_issues":77,"watchers":2800,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/3097"},"html":{"href":"https://github.com/apache/arrow/pull/3097"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/3097"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/3097/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/3097/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/3097/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/03216b352f3ee44c90bc7c429c64c5c4be2c6047"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kou"}}