{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/6341","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/6341/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/6341/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/6341/events","html_url":"https://github.com/openssl/openssl/pull/6341","id":325665579,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5OTQ0MjAy","number":6341,"title":"WIP: OSSL_STORE 'file' loader: Try several pass phrase variants for PKCS#12","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"labels":[{"id":872237503,"node_id":"MDU6TGFiZWw4NzIyMzc1MDM=","url":"https://api.github.com/repos/openssl/openssl/labels/1.1.1","name":"1.1.1","color":"bfdadc","default":false},{"id":441165144,"node_id":"MDU6TGFiZWw0NDExNjUxNDQ=","url":"https://api.github.com/repos/openssl/openssl/labels/master","name":"master","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":71,"created_at":"2018-05-23T11:35:39Z","updated_at":"2018-05-31T15:45:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/6341","html_url":"https://github.com/openssl/openssl/pull/6341","diff_url":"https://github.com/openssl/openssl/pull/6341.diff","patch_url":"https://github.com/openssl/openssl/pull/6341.patch"},"body":"Pass phrases for PKCS#12 objects are problematic, as our conversion to\r\nBMPString was very naïve in OpenSSL <1.1.0, and while being less so in\r\nOpenSSL >=1.1.0, it still doesn't account for the application locale.\r\n\r\nOSSL_STORE, on the other hand, is supposed to be fairly agnostic to\r\nthe types of objects it loads, and thereby all internal intricaties\r\nconcerning pass phrases.  Therefore, we need to create a few variants\r\nof the given pass phrase when trying to open a PKCS#12 object, with\r\nthe hope that this will work on PKCS#12 objects generated by OpenSSL\r\n<1.1.0 as well as OpenSSL >=1.1.0 as well as other software.\r\n\r\nWhile doing this, we need to make sure the locale is set correctly.\r\nFortunately, that's a simple setlocale(LC_ALL, \"\").\r\n\r\nIdeas largely inspired by @dwmw2"},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/393575815","html_url":"https://github.com/openssl/openssl/pull/6341#issuecomment-393575815","issue_url":"https://api.github.com/repos/openssl/openssl/issues/6341","id":393575815,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzU3NTgxNQ==","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T15:45:39Z","updated_at":"2018-05-31T15:45:39Z","author_association":"MEMBER","body":"So yeah, if `openssl pkcs12` is going to do something to detect non-compliant pass phrase encodings, I think it *should* suggest to the user to switch to a UTF-8 input method."}}
{"actor":{"display_login":"levitte"}}