{"action":"created","comment":{"url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/comments/199316109","pull_request_review_id":133417535,"id":199316109,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMxNjEwOQ==","diff_hunk":"@@ -22,57 +23,58 @@ UnlitRenderingPass::UnlitRenderingPass()\n void UnlitRenderingPass::OnRun(World* world, const CameraComponent* camera, const AARect& /*rect*/, ePassType passType = ePassType::GLOBAL)\n {\n \tGetProgram().BindProgram();\n-\tconst Matrix& ScreenFromWorld = camera->GetScreenFromWorld();\n+\tconst Matrix& ScreenFromWorld = camera->GetClipFromWorld();\n \t\n \t// Render meshes\n \tfor (auto componentsTuple : world->IterateComponents<MeshRenderingComponent>())\n \t{\n \t\tconst MeshRenderingComponent* meshCmp = std::get<MeshRenderingComponent*>(componentsTuple);\n \n-\t\tif (passType == ePassType::BY_MATERIAL &&\n-\t\t\t(meshCmp->IsTransparent() || meshCmp->GetShadingModel() != eShadingModel::UNLIT))\n-\t\t{\n-\t\t\tcontinue;\n-\t\t}\n+\t\t// if (passType == ePassType::BY_MATERIAL &&\n+\t\t// \t(meshCmp->IsTransparent() || meshCmp->GetShadingModel() != eShadingModel::UNLIT))\n+\t\t// {\n+\t\t// \tcontinue;\n+\t\t// }\n \n \t\tconst EntityTransform& transform = meshCmp->GetTransform();\n \t\tconst Matrix& WorldFromModel = transform.GetWorldFromModel();\n \t\tMatrix ScreenFromModel = ScreenFromWorld * WorldFromModel;\n \t\tGetProgram().SetUniform(\"uTransform\", WorldFromModel);\n \t\tGetProgram().SetUniform(\"uMVPTransform\", ScreenFromModel);\n \t\t\n-\t\tif (passType == ePassType::BY_MATERIAL)\n-\t\t{\n-\t\t\tglPolygonMode(GL_FRONT_AND_BACK, meshCmp->GetIsWireframe() ? GL_LINE : GL_FILL);\n-\t\t}\n+\t\t// if (passType == ePassType::BY_MATERIAL)\n+\t\t// {\n+\t\t// \tglPolygonMode(GL_FRONT_AND_BACK, meshCmp->GetIsWireframe() ? GL_LINE : GL_FILL);\n+\t\t// }\n \n \t\tint i = 0;\n \t\tfor (const MeshResource::SubMesh* subMesh : meshCmp->GetMesh()->GetSubMeshes())\n \t\t{\n-\t\t\tPhongMaterial material = meshCmp->GetMaterial(i);\n-\t\t\tGetProgram().SetUniform(\"uColor\", material.DiffuseColor);\n+\t\t\tMaterial material = meshCmp->GetMaterial(i);\n+\t\t\tGetProgram().SetUniform(\"uColor\", material.Albedo);\n \n \t\t\tconst GLMeshDeviceProxy* meshProxy = static_cast<const GLMeshDeviceProxy*>(subMesh->GetMeshProxy());\n \t\t\tglBindVertexArray(meshProxy->GetVAO());\n \n-\t\t\tconst Poly::TextureResource* DiffuseTexture = subMesh->GetMeshData().GetDiffTexture();\n+\t\t\tconst Poly::TextureResource* DiffuseTexture = subMesh->GetMeshData().GetAlbedoMap();\n \t\t\tGLuint TextureID = DiffuseTexture == nullptr\n-\t\t\t\t? FallbackWhiteTexture\n+\t\t\t\t? RDI->FallbackWhiteTexture\n \t\t\t\t: static_cast<const GLTextureDeviceProxy*>(DiffuseTexture->GetTextureProxy())->GetTextureID();\n \n \t\t\tglActiveTexture(GL_TEXTURE0);\n \t\t\tglBindTexture(GL_TEXTURE_2D, TextureID);\n \n \t\t\tglDrawElements(GL_TRIANGLES, (GLsizei)subMesh->GetMeshData().GetTriangleCount() * 3, GL_UNSIGNED_INT, NULL);\n+\t\t\t\n \t\t\tglBindTexture(GL_TEXTURE_2D, 0);\n \t\t\tglBindVertexArray(0);\n \n \t\t\t++i;\n \t\t}\n \t\t\n-\t\tif (passType == ePassType::BY_MATERIAL)\n-\t\t{\n-\t\t\tglPolygonMode(GL_FRONT_AND_BACK, GL_FILL);\n-\t\t}\n+\t\t// if (passType == ePassType::BY_MATERIAL)\n+\t\t// {\n+\t\t// \tglPolygonMode(GL_FRONT_AND_BACK, GL_FILL);\n+\t\t// }","path":"PolyEngine/RenderingDevice/OpenGL/Src/Pipeline/UnlitRenderingPass.cpp","position":93,"original_position":93,"commit_id":"df73c8ff79120b4572398e7e8a2a8164cb61adf4","original_commit_id":"df73c8ff79120b4572398e7e8a2a8164cb61adf4","user":{"login":"MuniuDev","id":8275106,"node_id":"MDQ6VXNlcjgyNzUxMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/8275106?v=4","gravatar_id":"","url":"https://api.github.com/users/MuniuDev","html_url":"https://github.com/MuniuDev","followers_url":"https://api.github.com/users/MuniuDev/followers","following_url":"https://api.github.com/users/MuniuDev/following{/other_user}","gists_url":"https://api.github.com/users/MuniuDev/gists{/gist_id}","starred_url":"https://api.github.com/users/MuniuDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MuniuDev/subscriptions","organizations_url":"https://api.github.com/users/MuniuDev/orgs","repos_url":"https://api.github.com/users/MuniuDev/repos","events_url":"https://api.github.com/users/MuniuDev/events{/privacy}","received_events_url":"https://api.github.com/users/MuniuDev/received_events","type":"User","site_admin":false},"body":"Remove commented code.","created_at":"2018-06-30T07:38:30Z","updated_at":"2018-06-30T07:49:04Z","html_url":"https://github.com/KNTGPolygon/PolyEngine/pull/137#discussion_r199316109","pull_request_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/137","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/comments/199316109"},"html":{"href":"https://github.com/KNTGPolygon/PolyEngine/pull/137#discussion_r199316109"},"pull_request":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/137","id":194588478,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTg4NDc4","html_url":"https://github.com/KNTGPolygon/PolyEngine/pull/137","diff_url":"https://github.com/KNTGPolygon/PolyEngine/pull/137.diff","patch_url":"https://github.com/KNTGPolygon/PolyEngine/pull/137.patch","issue_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/137","number":137,"state":"open","locked":false,"title":"Rendering: Tiled Forward, PBR, IBL","user":{"login":"sp0lsh","id":5374481,"node_id":"MDQ6VXNlcjUzNzQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5374481?v=4","gravatar_id":"","url":"https://api.github.com/users/sp0lsh","html_url":"https://github.com/sp0lsh","followers_url":"https://api.github.com/users/sp0lsh/followers","following_url":"https://api.github.com/users/sp0lsh/following{/other_user}","gists_url":"https://api.github.com/users/sp0lsh/gists{/gist_id}","starred_url":"https://api.github.com/users/sp0lsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sp0lsh/subscriptions","organizations_url":"https://api.github.com/users/sp0lsh/orgs","repos_url":"https://api.github.com/users/sp0lsh/repos","events_url":"https://api.github.com/users/sp0lsh/events{/privacy}","received_events_url":"https://api.github.com/users/sp0lsh/received_events","type":"User","site_admin":false},"body":"TODO:\r\n- [x] Move stb_image to 3rd parties\r\n- [x] Refactor loading HDR to skybox\r\n- [ ] Code review","created_at":"2018-06-13T13:35:11Z","updated_at":"2018-06-30T07:49:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2489ff3bda8a9dd64d6a85d362536eaa0dd2f3ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/137/commits","review_comments_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/137/comments","review_comment_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/137/comments","statuses_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/statuses/df73c8ff79120b4572398e7e8a2a8164cb61adf4","head":{"label":"sp0lsh:rendering/tiled-forward","ref":"rendering/tiled-forward","sha":"df73c8ff79120b4572398e7e8a2a8164cb61adf4","user":{"login":"sp0lsh","id":5374481,"node_id":"MDQ6VXNlcjUzNzQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5374481?v=4","gravatar_id":"","url":"https://api.github.com/users/sp0lsh","html_url":"https://github.com/sp0lsh","followers_url":"https://api.github.com/users/sp0lsh/followers","following_url":"https://api.github.com/users/sp0lsh/following{/other_user}","gists_url":"https://api.github.com/users/sp0lsh/gists{/gist_id}","starred_url":"https://api.github.com/users/sp0lsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sp0lsh/subscriptions","organizations_url":"https://api.github.com/users/sp0lsh/orgs","repos_url":"https://api.github.com/users/sp0lsh/repos","events_url":"https://api.github.com/users/sp0lsh/events{/privacy}","received_events_url":"https://api.github.com/users/sp0lsh/received_events","type":"User","site_admin":false},"repo":{"id":97148002,"node_id":"MDEwOlJlcG9zaXRvcnk5NzE0ODAwMg==","name":"PolyEngine","full_name":"sp0lsh/PolyEngine","owner":{"login":"sp0lsh","id":5374481,"node_id":"MDQ6VXNlcjUzNzQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5374481?v=4","gravatar_id":"","url":"https://api.github.com/users/sp0lsh","html_url":"https://github.com/sp0lsh","followers_url":"https://api.github.com/users/sp0lsh/followers","following_url":"https://api.github.com/users/sp0lsh/following{/other_user}","gists_url":"https://api.github.com/users/sp0lsh/gists{/gist_id}","starred_url":"https://api.github.com/users/sp0lsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sp0lsh/subscriptions","organizations_url":"https://api.github.com/users/sp0lsh/orgs","repos_url":"https://api.github.com/users/sp0lsh/repos","events_url":"https://api.github.com/users/sp0lsh/events{/privacy}","received_events_url":"https://api.github.com/users/sp0lsh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sp0lsh/PolyEngine","description":"PolyEngine project repository","fork":true,"url":"https://api.github.com/repos/sp0lsh/PolyEngine","forks_url":"https://api.github.com/repos/sp0lsh/PolyEngine/forks","keys_url":"https://api.github.com/repos/sp0lsh/PolyEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sp0lsh/PolyEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sp0lsh/PolyEngine/teams","hooks_url":"https://api.github.com/repos/sp0lsh/PolyEngine/hooks","issue_events_url":"https://api.github.com/repos/sp0lsh/PolyEngine/issues/events{/number}","events_url":"https://api.github.com/repos/sp0lsh/PolyEngine/events","assignees_url":"https://api.github.com/repos/sp0lsh/PolyEngine/assignees{/user}","branches_url":"https://api.github.com/repos/sp0lsh/PolyEngine/branches{/branch}","tags_url":"https://api.github.com/repos/sp0lsh/PolyEngine/tags","blobs_url":"https://api.github.com/repos/sp0lsh/PolyEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sp0lsh/PolyEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sp0lsh/PolyEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/sp0lsh/PolyEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sp0lsh/PolyEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/sp0lsh/PolyEngine/languages","stargazers_url":"https://api.github.com/repos/sp0lsh/PolyEngine/stargazers","contributors_url":"https://api.github.com/repos/sp0lsh/PolyEngine/contributors","subscribers_url":"https://api.github.com/repos/sp0lsh/PolyEngine/subscribers","subscription_url":"https://api.github.com/repos/sp0lsh/PolyEngine/subscription","commits_url":"https://api.github.com/repos/sp0lsh/PolyEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/sp0lsh/PolyEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/sp0lsh/PolyEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/sp0lsh/PolyEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/sp0lsh/PolyEngine/contents/{+path}","compare_url":"https://api.github.com/repos/sp0lsh/PolyEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sp0lsh/PolyEngine/merges","archive_url":"https://api.github.com/repos/sp0lsh/PolyEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sp0lsh/PolyEngine/downloads","issues_url":"https://api.github.com/repos/sp0lsh/PolyEngine/issues{/number}","pulls_url":"https://api.github.com/repos/sp0lsh/PolyEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/sp0lsh/PolyEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/sp0lsh/PolyEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sp0lsh/PolyEngine/labels{/name}","releases_url":"https://api.github.com/repos/sp0lsh/PolyEngine/releases{/id}","deployments_url":"https://api.github.com/repos/sp0lsh/PolyEngine/deployments","created_at":"2017-07-13T17:17:54Z","updated_at":"2017-07-13T17:17:57Z","pushed_at":"2018-06-29T19:37:11Z","git_url":"git://github.com/sp0lsh/PolyEngine.git","ssh_url":"git@github.com:sp0lsh/PolyEngine.git","clone_url":"https://github.com/sp0lsh/PolyEngine.git","svn_url":"https://github.com/sp0lsh/PolyEngine","homepage":null,"size":104807,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KNTGPolygon:dev","ref":"dev","sha":"2a274d7a8e7be328c62d7a0dbc9b9a1ed050f86c","user":{"login":"KNTGPolygon","id":2945433,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDU0MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/2945433?v=4","gravatar_id":"","url":"https://api.github.com/users/KNTGPolygon","html_url":"https://github.com/KNTGPolygon","followers_url":"https://api.github.com/users/KNTGPolygon/followers","following_url":"https://api.github.com/users/KNTGPolygon/following{/other_user}","gists_url":"https://api.github.com/users/KNTGPolygon/gists{/gist_id}","starred_url":"https://api.github.com/users/KNTGPolygon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KNTGPolygon/subscriptions","organizations_url":"https://api.github.com/users/KNTGPolygon/orgs","repos_url":"https://api.github.com/users/KNTGPolygon/repos","events_url":"https://api.github.com/users/KNTGPolygon/events{/privacy}","received_events_url":"https://api.github.com/users/KNTGPolygon/received_events","type":"Organization","site_admin":false},"repo":{"id":87123282,"node_id":"MDEwOlJlcG9zaXRvcnk4NzEyMzI4Mg==","name":"PolyEngine","full_name":"KNTGPolygon/PolyEngine","owner":{"login":"KNTGPolygon","id":2945433,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDU0MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/2945433?v=4","gravatar_id":"","url":"https://api.github.com/users/KNTGPolygon","html_url":"https://github.com/KNTGPolygon","followers_url":"https://api.github.com/users/KNTGPolygon/followers","following_url":"https://api.github.com/users/KNTGPolygon/following{/other_user}","gists_url":"https://api.github.com/users/KNTGPolygon/gists{/gist_id}","starred_url":"https://api.github.com/users/KNTGPolygon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KNTGPolygon/subscriptions","organizations_url":"https://api.github.com/users/KNTGPolygon/orgs","repos_url":"https://api.github.com/users/KNTGPolygon/repos","events_url":"https://api.github.com/users/KNTGPolygon/events{/privacy}","received_events_url":"https://api.github.com/users/KNTGPolygon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KNTGPolygon/PolyEngine","description":"PolyEngine project repository","fork":false,"url":"https://api.github.com/repos/KNTGPolygon/PolyEngine","forks_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/forks","keys_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/teams","hooks_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/hooks","issue_events_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/events{/number}","events_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/events","assignees_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/assignees{/user}","branches_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/branches{/branch}","tags_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/tags","blobs_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/languages","stargazers_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/stargazers","contributors_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/contributors","subscribers_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/subscribers","subscription_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/subscription","commits_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/contents/{+path}","compare_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/merges","archive_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/downloads","issues_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues{/number}","pulls_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/labels{/name}","releases_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/releases{/id}","deployments_url":"https://api.github.com/repos/KNTGPolygon/PolyEngine/deployments","created_at":"2017-04-03T21:37:53Z","updated_at":"2018-06-15T16:23:09Z","pushed_at":"2018-06-29T19:37:13Z","git_url":"git://github.com/KNTGPolygon/PolyEngine.git","ssh_url":"git@github.com:KNTGPolygon/PolyEngine.git","clone_url":"https://github.com/KNTGPolygon/PolyEngine.git","svn_url":"https://github.com/KNTGPolygon/PolyEngine","homepage":null,"size":99456,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":12,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/137"},"html":{"href":"https://github.com/KNTGPolygon/PolyEngine/pull/137"},"issue":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/137"},"comments":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/KNTGPolygon/PolyEngine/statuses/df73c8ff79120b4572398e7e8a2a8164cb61adf4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MuniuDev"}}