{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/168958771","pull_request_review_id":97409860,"id":168958771,"diff_hunk":"@@ -18,10 +18,10 @@\n #\n \n # Zookeeper quorum connection string (comma-separated)\n-zookeeperServers=\n+zookeeperServers=localhost:2181","path":"conf/proxy.conf","position":5,"original_position":5,"commit_id":"0e0070cc5ba61c21765d5425dce474c0f565e761","original_commit_id":"0e0070cc5ba61c21765d5425dce474c0f565e761","user":{"login":"merlimat","id":62500,"avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"body":"Leave empty so that we get an error if not filled out instead of having the zk client trying and retrying to connect","created_at":"2018-02-18T17:21:21Z","updated_at":"2018-02-18T17:24:08Z","html_url":"https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168958771","pull_request_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1248","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/168958771"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168958771"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1248"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1248","id":169823562,"html_url":"https://github.com/apache/incubator-pulsar/pull/1248","diff_url":"https://github.com/apache/incubator-pulsar/pull/1248.diff","patch_url":"https://github.com/apache/incubator-pulsar/pull/1248.patch","issue_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/1248","number":1248,"state":"open","locked":false,"title":"Start Proxy in TLS only mode.","user":{"login":"jai1","id":8659452,"avatar_url":"https://avatars1.githubusercontent.com/u/8659452?v=4","gravatar_id":"","url":"https://api.github.com/users/jai1","html_url":"https://github.com/jai1","followers_url":"https://api.github.com/users/jai1/followers","following_url":"https://api.github.com/users/jai1/following{/other_user}","gists_url":"https://api.github.com/users/jai1/gists{/gist_id}","starred_url":"https://api.github.com/users/jai1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jai1/subscriptions","organizations_url":"https://api.github.com/users/jai1/orgs","repos_url":"https://api.github.com/users/jai1/repos","events_url":"https://api.github.com/users/jai1/events{/privacy}","received_events_url":"https://api.github.com/users/jai1/received_events","type":"User","site_admin":false},"body":"Disable listening on non TLS ports.\r\n\r\nI was thinking of using the same approach in TLS port and getting of tlsEnabledFlag - let me know if you are ok with the approach.\r\n","created_at":"2018-02-18T10:13:10Z","updated_at":"2018-02-18T17:24:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5b2ce89c27dd212ed5f7b4104c0df08f76a98cb","assignee":{"login":"jai1","id":8659452,"avatar_url":"https://avatars1.githubusercontent.com/u/8659452?v=4","gravatar_id":"","url":"https://api.github.com/users/jai1","html_url":"https://github.com/jai1","followers_url":"https://api.github.com/users/jai1/followers","following_url":"https://api.github.com/users/jai1/following{/other_user}","gists_url":"https://api.github.com/users/jai1/gists{/gist_id}","starred_url":"https://api.github.com/users/jai1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jai1/subscriptions","organizations_url":"https://api.github.com/users/jai1/orgs","repos_url":"https://api.github.com/users/jai1/repos","events_url":"https://api.github.com/users/jai1/events{/privacy}","received_events_url":"https://api.github.com/users/jai1/received_events","type":"User","site_admin":false},"assignees":[{"login":"jai1","id":8659452,"avatar_url":"https://avatars1.githubusercontent.com/u/8659452?v=4","gravatar_id":"","url":"https://api.github.com/users/jai1","html_url":"https://github.com/jai1","followers_url":"https://api.github.com/users/jai1/followers","following_url":"https://api.github.com/users/jai1/following{/other_user}","gists_url":"https://api.github.com/users/jai1/gists{/gist_id}","starred_url":"https://api.github.com/users/jai1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jai1/subscriptions","organizations_url":"https://api.github.com/users/jai1/orgs","repos_url":"https://api.github.com/users/jai1/repos","events_url":"https://api.github.com/users/jai1/events{/privacy}","received_events_url":"https://api.github.com/users/jai1/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/12","html_url":"https://github.com/apache/incubator-pulsar/milestone/12","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/12/labels","id":2870587,"number":12,"title":"2.0.0-incubating","description":"","creator":{"login":"merlimat","id":62500,"avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"open_issues":74,"closed_issues":20,"state":"open","created_at":"2017-10-27T18:58:50Z","updated_at":"2018-02-18T17:07:13Z","due_on":"2018-02-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1248/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1248/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/1248/comments","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/0e0070cc5ba61c21765d5425dce474c0f565e761","head":{"label":"jai1:servicePortDisables","ref":"servicePortDisables","sha":"0e0070cc5ba61c21765d5425dce474c0f565e761","user":{"login":"jai1","id":8659452,"avatar_url":"https://avatars1.githubusercontent.com/u/8659452?v=4","gravatar_id":"","url":"https://api.github.com/users/jai1","html_url":"https://github.com/jai1","followers_url":"https://api.github.com/users/jai1/followers","following_url":"https://api.github.com/users/jai1/following{/other_user}","gists_url":"https://api.github.com/users/jai1/gists{/gist_id}","starred_url":"https://api.github.com/users/jai1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jai1/subscriptions","organizations_url":"https://api.github.com/users/jai1/orgs","repos_url":"https://api.github.com/users/jai1/repos","events_url":"https://api.github.com/users/jai1/events{/privacy}","received_events_url":"https://api.github.com/users/jai1/received_events","type":"User","site_admin":false},"repo":{"id":80573639,"name":"pulsar","full_name":"jai1/pulsar","owner":{"login":"jai1","id":8659452,"avatar_url":"https://avatars1.githubusercontent.com/u/8659452?v=4","gravatar_id":"","url":"https://api.github.com/users/jai1","html_url":"https://github.com/jai1","followers_url":"https://api.github.com/users/jai1/followers","following_url":"https://api.github.com/users/jai1/following{/other_user}","gists_url":"https://api.github.com/users/jai1/gists{/gist_id}","starred_url":"https://api.github.com/users/jai1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jai1/subscriptions","organizations_url":"https://api.github.com/users/jai1/orgs","repos_url":"https://api.github.com/users/jai1/repos","events_url":"https://api.github.com/users/jai1/events{/privacy}","received_events_url":"https://api.github.com/users/jai1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jai1/pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":true,"url":"https://api.github.com/repos/jai1/pulsar","forks_url":"https://api.github.com/repos/jai1/pulsar/forks","keys_url":"https://api.github.com/repos/jai1/pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jai1/pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jai1/pulsar/teams","hooks_url":"https://api.github.com/repos/jai1/pulsar/hooks","issue_events_url":"https://api.github.com/repos/jai1/pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/jai1/pulsar/events","assignees_url":"https://api.github.com/repos/jai1/pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/jai1/pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/jai1/pulsar/tags","blobs_url":"https://api.github.com/repos/jai1/pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jai1/pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jai1/pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/jai1/pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jai1/pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/jai1/pulsar/languages","stargazers_url":"https://api.github.com/repos/jai1/pulsar/stargazers","contributors_url":"https://api.github.com/repos/jai1/pulsar/contributors","subscribers_url":"https://api.github.com/repos/jai1/pulsar/subscribers","subscription_url":"https://api.github.com/repos/jai1/pulsar/subscription","commits_url":"https://api.github.com/repos/jai1/pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/jai1/pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/jai1/pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/jai1/pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/jai1/pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/jai1/pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jai1/pulsar/merges","archive_url":"https://api.github.com/repos/jai1/pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jai1/pulsar/downloads","issues_url":"https://api.github.com/repos/jai1/pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/jai1/pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/jai1/pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/jai1/pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jai1/pulsar/labels{/name}","releases_url":"https://api.github.com/repos/jai1/pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/jai1/pulsar/deployments","created_at":"2017-01-31T23:39:31Z","updated_at":"2017-01-31T23:39:35Z","pushed_at":"2018-02-18T10:10:15Z","git_url":"git://github.com/jai1/pulsar.git","ssh_url":"git@github.com:jai1/pulsar.git","clone_url":"https://github.com/jai1/pulsar.git","svn_url":"https://github.com/jai1/pulsar","homepage":"","size":17221,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cb5eb5b671316bf200202b5b410b1438f2cde98b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117812,"name":"incubator-pulsar","full_name":"apache/incubator-pulsar","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":false,"url":"https://api.github.com/repos/apache/incubator-pulsar","forks_url":"https://api.github.com/repos/apache/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/apache/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/apache/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/apache/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/apache/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/apache/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/apache/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-pulsar/deployments","created_at":"2016-06-28T07:00:03Z","updated_at":"2018-02-18T14:38:53Z","pushed_at":"2018-02-18T17:07:14Z","git_url":"git://github.com/apache/incubator-pulsar.git","ssh_url":"git@github.com:apache/incubator-pulsar.git","clone_url":"https://github.com/apache/incubator-pulsar.git","svn_url":"https://github.com/apache/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":20738,"stargazers_count":1577,"watchers_count":1577,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":327,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":327,"open_issues":167,"watchers":1577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1248"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/1248"},"issue":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/1248"},"comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/1248/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1248/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1248/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-pulsar/statuses/0e0070cc5ba61c21765d5425dce474c0f565e761"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"merlimat"}}