{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-gsoc2018-3d/issues/8","repository_url":"https://api.github.com/repos/mne-tools/mne-gsoc2018-3d","labels_url":"https://api.github.com/repos/mne-tools/mne-gsoc2018-3d/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-gsoc2018-3d/issues/8/comments","events_url":"https://api.github.com/repos/mne-tools/mne-gsoc2018-3d/issues/8/events","html_url":"https://github.com/mne-tools/mne-gsoc2018-3d/pull/8","id":322998575,"number":8,"title":"Fixes #1. Simple brain mesh.","user":{"login":"OlehKSS","id":16047980,"avatar_url":"https://avatars3.githubusercontent.com/u/16047980?v=4","gravatar_id":"","url":"https://api.github.com/users/OlehKSS","html_url":"https://github.com/OlehKSS","followers_url":"https://api.github.com/users/OlehKSS/followers","following_url":"https://api.github.com/users/OlehKSS/following{/other_user}","gists_url":"https://api.github.com/users/OlehKSS/gists{/gist_id}","starred_url":"https://api.github.com/users/OlehKSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlehKSS/subscriptions","organizations_url":"https://api.github.com/users/OlehKSS/orgs","repos_url":"https://api.github.com/users/OlehKSS/repos","events_url":"https://api.github.com/users/OlehKSS/events{/privacy}","received_events_url":"https://api.github.com/users/OlehKSS/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-14T22:05:39Z","updated_at":"2018-05-17T01:37:41Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-gsoc2018-3d/pulls/8","html_url":"https://github.com/mne-tools/mne-gsoc2018-3d/pull/8","diff_url":"https://github.com/mne-tools/mne-gsoc2018-3d/pull/8.diff","patch_url":"https://github.com/mne-tools/mne-gsoc2018-3d/pull/8.patch"},"body":"I have several questions regarding this task:\r\n\r\n* is there any patterns in the way MNE or other EEG/MEG data typically stored? So I can implement the `viz.read_brain_mesh` function\r\n* should I create a BrainMesh/Surface class for storing mesh data (e. g. vertices and faces)? Will it be useful later?\r\n\r\nAnother general, what do you think about adding a GitHub project to this repository, and me as collaborator, so I will be able to assign issues I am working on and moving them from according to their status (for example, 'To Do', 'In Progress', 'Done')?\r\n\r\nI will add unit testing the later."},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-gsoc2018-3d/issues/comments/389717139","html_url":"https://github.com/mne-tools/mne-gsoc2018-3d/pull/8#issuecomment-389717139","issue_url":"https://api.github.com/repos/mne-tools/mne-gsoc2018-3d/issues/8","id":389717139,"user":{"login":"larsoner","id":2365790,"avatar_url":"https://avatars1.githubusercontent.com/u/2365790?v=4","gravatar_id":"","url":"https://api.github.com/users/larsoner","html_url":"https://github.com/larsoner","followers_url":"https://api.github.com/users/larsoner/followers","following_url":"https://api.github.com/users/larsoner/following{/other_user}","gists_url":"https://api.github.com/users/larsoner/gists{/gist_id}","starred_url":"https://api.github.com/users/larsoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsoner/subscriptions","organizations_url":"https://api.github.com/users/larsoner/orgs","repos_url":"https://api.github.com/users/larsoner/repos","events_url":"https://api.github.com/users/larsoner/events{/privacy}","received_events_url":"https://api.github.com/users/larsoner/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T01:37:41Z","updated_at":"2018-05-17T01:37:41Z","author_association":"MEMBER","body":"> Well, there are no options available in ipyvolume for camera scaling factor, light direction and color and shading.\r\n\r\nThat's okay, we will probably need to add these later. For now we can just live with the defaults, whatever they are.\r\n\r\n> Azimuth can be changed for the whole scene (or figure), but not for a separate meshes.\r\n\r\nThat's okay I think we want them to move together. Eventually we will want e.g. left and right hemi plots separately, but for now plotting just left, just right, or left and right together (that move together) is a good start.\r\n\r\n> I haven't found something that can be put into the read_brain_mesh function from viz.py module.\r\nAs far as I understand, curvature data correspond to the color of the mesh, thus it will be used in #2.\r\n\r\nWhat is the plan for the `read_brain_mesh` function? What are the inputs and outputs supposed to be? It seems like everything you need to read the mesh components is already in the `gist` ready to be translated to a script / function."}}
{"actor":{"display_login":"larsoner"}}