{"action":"created","comment":{"url":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/comments/188527817","pull_request_review_id":120522165,"id":188527817,"diff_hunk":"@@ -215,13 +215,22 @@ public function __construct($options, $values, $filter_logic)\n \n         $this->values = $values;\n         $this->options = $options;\n-        $this->view = 'crud::filters.'.$this->type;\n+        $this->setView();\n \n         if (\\Request::has($this->name)) {\n             $this->currentValue = \\Request::input($this->name);\n         }\n     }\n \n+    public function setView()\n+    {\n+        if (isset($this->options['view'])) {\n+            $this->view = $this->options['view'] . '.' . $this->type;","path":"src/PanelTraits/Filters.php","position":15,"original_position":15,"commit_id":"ab8be22dbde1a89bf2cc263660161bf7df076918","original_commit_id":"ab8be22dbde1a89bf2cc263660161bf7df076918","user":{"login":"OliverZiegler","id":7778510,"avatar_url":"https://avatars3.githubusercontent.com/u/7778510?v=4","gravatar_id":"","url":"https://api.github.com/users/OliverZiegler","html_url":"https://github.com/OliverZiegler","followers_url":"https://api.github.com/users/OliverZiegler/followers","following_url":"https://api.github.com/users/OliverZiegler/following{/other_user}","gists_url":"https://api.github.com/users/OliverZiegler/gists{/gist_id}","starred_url":"https://api.github.com/users/OliverZiegler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OliverZiegler/subscriptions","organizations_url":"https://api.github.com/users/OliverZiegler/orgs","repos_url":"https://api.github.com/users/OliverZiegler/repos","events_url":"https://api.github.com/users/OliverZiegler/events{/privacy}","received_events_url":"https://api.github.com/users/OliverZiegler/received_events","type":"User","site_admin":false},"body":"Should this not be the exact view without `$this->type` suffix?\r\nSeems like bad naming in the current case... 🤔 ","created_at":"2018-05-16T07:35:20Z","updated_at":"2018-05-16T07:36:22Z","html_url":"https://github.com/Laravel-Backpack/CRUD/pull/1389#discussion_r188527817","pull_request_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/1389","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/comments/188527817"},"html":{"href":"https://github.com/Laravel-Backpack/CRUD/pull/1389#discussion_r188527817"},"pull_request":{"href":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/1389"}}},"pull_request":{"url":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/1389","id":186999128,"html_url":"https://github.com/Laravel-Backpack/CRUD/pull/1389","diff_url":"https://github.com/Laravel-Backpack/CRUD/pull/1389.diff","patch_url":"https://github.com/Laravel-Backpack/CRUD/pull/1389.patch","issue_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/issues/1389","number":1389,"state":"open","locked":false,"title":"[EH] add possibility to use custom filters","user":{"login":"tswonke","id":6401044,"avatar_url":"https://avatars2.githubusercontent.com/u/6401044?v=4","gravatar_id":"","url":"https://api.github.com/users/tswonke","html_url":"https://github.com/tswonke","followers_url":"https://api.github.com/users/tswonke/followers","following_url":"https://api.github.com/users/tswonke/following{/other_user}","gists_url":"https://api.github.com/users/tswonke/gists{/gist_id}","starred_url":"https://api.github.com/users/tswonke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tswonke/subscriptions","organizations_url":"https://api.github.com/users/tswonke/orgs","repos_url":"https://api.github.com/users/tswonke/repos","events_url":"https://api.github.com/users/tswonke/events{/privacy}","received_events_url":"https://api.github.com/users/tswonke/received_events","type":"User","site_admin":false},"body":"see [https://github.com/Laravel-Backpack/CRUD/issues/1385](https://github.com/Laravel-Backpack/CRUD/issues/1385)","created_at":"2018-05-09T18:13:12Z","updated_at":"2018-05-16T07:36:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c39afa07543e317b89fda0bb521a770b60e01a29","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/1389/commits","review_comments_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/1389/comments","review_comment_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/issues/1389/comments","statuses_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/statuses/ab8be22dbde1a89bf2cc263660161bf7df076918","head":{"label":"tswonke:customFilters","ref":"customFilters","sha":"ab8be22dbde1a89bf2cc263660161bf7df076918","user":{"login":"tswonke","id":6401044,"avatar_url":"https://avatars2.githubusercontent.com/u/6401044?v=4","gravatar_id":"","url":"https://api.github.com/users/tswonke","html_url":"https://github.com/tswonke","followers_url":"https://api.github.com/users/tswonke/followers","following_url":"https://api.github.com/users/tswonke/following{/other_user}","gists_url":"https://api.github.com/users/tswonke/gists{/gist_id}","starred_url":"https://api.github.com/users/tswonke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tswonke/subscriptions","organizations_url":"https://api.github.com/users/tswonke/orgs","repos_url":"https://api.github.com/users/tswonke/repos","events_url":"https://api.github.com/users/tswonke/events{/privacy}","received_events_url":"https://api.github.com/users/tswonke/received_events","type":"User","site_admin":false},"repo":{"id":132764924,"name":"CRUD","full_name":"tswonke/CRUD","owner":{"login":"tswonke","id":6401044,"avatar_url":"https://avatars2.githubusercontent.com/u/6401044?v=4","gravatar_id":"","url":"https://api.github.com/users/tswonke","html_url":"https://github.com/tswonke","followers_url":"https://api.github.com/users/tswonke/followers","following_url":"https://api.github.com/users/tswonke/following{/other_user}","gists_url":"https://api.github.com/users/tswonke/gists{/gist_id}","starred_url":"https://api.github.com/users/tswonke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tswonke/subscriptions","organizations_url":"https://api.github.com/users/tswonke/orgs","repos_url":"https://api.github.com/users/tswonke/repos","events_url":"https://api.github.com/users/tswonke/events{/privacy}","received_events_url":"https://api.github.com/users/tswonke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tswonke/CRUD","description":"Build a custom admin interface for your Eloquent models, using Laravel 5.2 to 5.6","fork":true,"url":"https://api.github.com/repos/tswonke/CRUD","forks_url":"https://api.github.com/repos/tswonke/CRUD/forks","keys_url":"https://api.github.com/repos/tswonke/CRUD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tswonke/CRUD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tswonke/CRUD/teams","hooks_url":"https://api.github.com/repos/tswonke/CRUD/hooks","issue_events_url":"https://api.github.com/repos/tswonke/CRUD/issues/events{/number}","events_url":"https://api.github.com/repos/tswonke/CRUD/events","assignees_url":"https://api.github.com/repos/tswonke/CRUD/assignees{/user}","branches_url":"https://api.github.com/repos/tswonke/CRUD/branches{/branch}","tags_url":"https://api.github.com/repos/tswonke/CRUD/tags","blobs_url":"https://api.github.com/repos/tswonke/CRUD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tswonke/CRUD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tswonke/CRUD/git/refs{/sha}","trees_url":"https://api.github.com/repos/tswonke/CRUD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tswonke/CRUD/statuses/{sha}","languages_url":"https://api.github.com/repos/tswonke/CRUD/languages","stargazers_url":"https://api.github.com/repos/tswonke/CRUD/stargazers","contributors_url":"https://api.github.com/repos/tswonke/CRUD/contributors","subscribers_url":"https://api.github.com/repos/tswonke/CRUD/subscribers","subscription_url":"https://api.github.com/repos/tswonke/CRUD/subscription","commits_url":"https://api.github.com/repos/tswonke/CRUD/commits{/sha}","git_commits_url":"https://api.github.com/repos/tswonke/CRUD/git/commits{/sha}","comments_url":"https://api.github.com/repos/tswonke/CRUD/comments{/number}","issue_comment_url":"https://api.github.com/repos/tswonke/CRUD/issues/comments{/number}","contents_url":"https://api.github.com/repos/tswonke/CRUD/contents/{+path}","compare_url":"https://api.github.com/repos/tswonke/CRUD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tswonke/CRUD/merges","archive_url":"https://api.github.com/repos/tswonke/CRUD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tswonke/CRUD/downloads","issues_url":"https://api.github.com/repos/tswonke/CRUD/issues{/number}","pulls_url":"https://api.github.com/repos/tswonke/CRUD/pulls{/number}","milestones_url":"https://api.github.com/repos/tswonke/CRUD/milestones{/number}","notifications_url":"https://api.github.com/repos/tswonke/CRUD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tswonke/CRUD/labels{/name}","releases_url":"https://api.github.com/repos/tswonke/CRUD/releases{/id}","deployments_url":"https://api.github.com/repos/tswonke/CRUD/deployments","created_at":"2018-05-09T13:58:37Z","updated_at":"2018-05-09T13:58:41Z","pushed_at":"2018-05-09T18:12:09Z","git_url":"git://github.com/tswonke/CRUD.git","ssh_url":"git@github.com:tswonke/CRUD.git","clone_url":"https://github.com/tswonke/CRUD.git","svn_url":"https://github.com/tswonke/CRUD","homepage":"http://backpackforlaravel.com","size":6997,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Laravel-Backpack:master","ref":"master","sha":"0dd5f6277bad3ff3b83d880e07b4ec92836d39fb","user":{"login":"Laravel-Backpack","id":15017015,"avatar_url":"https://avatars2.githubusercontent.com/u/15017015?v=4","gravatar_id":"","url":"https://api.github.com/users/Laravel-Backpack","html_url":"https://github.com/Laravel-Backpack","followers_url":"https://api.github.com/users/Laravel-Backpack/followers","following_url":"https://api.github.com/users/Laravel-Backpack/following{/other_user}","gists_url":"https://api.github.com/users/Laravel-Backpack/gists{/gist_id}","starred_url":"https://api.github.com/users/Laravel-Backpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laravel-Backpack/subscriptions","organizations_url":"https://api.github.com/users/Laravel-Backpack/orgs","repos_url":"https://api.github.com/users/Laravel-Backpack/repos","events_url":"https://api.github.com/users/Laravel-Backpack/events{/privacy}","received_events_url":"https://api.github.com/users/Laravel-Backpack/received_events","type":"Organization","site_admin":false},"repo":{"id":53581270,"name":"CRUD","full_name":"Laravel-Backpack/CRUD","owner":{"login":"Laravel-Backpack","id":15017015,"avatar_url":"https://avatars2.githubusercontent.com/u/15017015?v=4","gravatar_id":"","url":"https://api.github.com/users/Laravel-Backpack","html_url":"https://github.com/Laravel-Backpack","followers_url":"https://api.github.com/users/Laravel-Backpack/followers","following_url":"https://api.github.com/users/Laravel-Backpack/following{/other_user}","gists_url":"https://api.github.com/users/Laravel-Backpack/gists{/gist_id}","starred_url":"https://api.github.com/users/Laravel-Backpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laravel-Backpack/subscriptions","organizations_url":"https://api.github.com/users/Laravel-Backpack/orgs","repos_url":"https://api.github.com/users/Laravel-Backpack/repos","events_url":"https://api.github.com/users/Laravel-Backpack/events{/privacy}","received_events_url":"https://api.github.com/users/Laravel-Backpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Laravel-Backpack/CRUD","description":"Build a custom admin interface for your Eloquent models, using Laravel 5.2 to 5.6","fork":false,"url":"https://api.github.com/repos/Laravel-Backpack/CRUD","forks_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/forks","keys_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/teams","hooks_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/hooks","issue_events_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/issues/events{/number}","events_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/events","assignees_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/assignees{/user}","branches_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/branches{/branch}","tags_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/tags","blobs_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/git/refs{/sha}","trees_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/statuses/{sha}","languages_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/languages","stargazers_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/stargazers","contributors_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/contributors","subscribers_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/subscribers","subscription_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/subscription","commits_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/commits{/sha}","git_commits_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/git/commits{/sha}","comments_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/comments{/number}","issue_comment_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/issues/comments{/number}","contents_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/contents/{+path}","compare_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/merges","archive_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/downloads","issues_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/issues{/number}","pulls_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls{/number}","milestones_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/milestones{/number}","notifications_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/labels{/name}","releases_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/releases{/id}","deployments_url":"https://api.github.com/repos/Laravel-Backpack/CRUD/deployments","created_at":"2016-03-10T12:03:46Z","updated_at":"2018-05-16T04:01:30Z","pushed_at":"2018-05-15T08:42:45Z","git_url":"git://github.com/Laravel-Backpack/CRUD.git","ssh_url":"git@github.com:Laravel-Backpack/CRUD.git","clone_url":"https://github.com/Laravel-Backpack/CRUD.git","svn_url":"https://github.com/Laravel-Backpack/CRUD","homepage":"http://backpackforlaravel.com","size":8366,"stargazers_count":979,"watchers_count":979,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":355,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":355,"open_issues":94,"watchers":979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/1389"},"html":{"href":"https://github.com/Laravel-Backpack/CRUD/pull/1389"},"issue":{"href":"https://api.github.com/repos/Laravel-Backpack/CRUD/issues/1389"},"comments":{"href":"https://api.github.com/repos/Laravel-Backpack/CRUD/issues/1389/comments"},"review_comments":{"href":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/1389/comments"},"review_comment":{"href":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Laravel-Backpack/CRUD/pulls/1389/commits"},"statuses":{"href":"https://api.github.com/repos/Laravel-Backpack/CRUD/statuses/ab8be22dbde1a89bf2cc263660161bf7df076918"}},"author_association":"NONE"}}
{"actor":{"display_login":"OliverZiegler"}}