{"action":"created","issue":{"url":"https://api.github.com/repos/CCPPETMR/SIRF/issues/163","repository_url":"https://api.github.com/repos/CCPPETMR/SIRF","labels_url":"https://api.github.com/repos/CCPPETMR/SIRF/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/CCPPETMR/SIRF/issues/163/comments","events_url":"https://api.github.com/repos/CCPPETMR/SIRF/issues/163/events","html_url":"https://github.com/CCPPETMR/SIRF/pull/163","id":318445754,"number":163,"title":"sirf python packaging","user":{"login":"casperdcl","id":10780059,"avatar_url":"https://avatars0.githubusercontent.com/u/10780059?v=4","gravatar_id":"","url":"https://api.github.com/users/casperdcl","html_url":"https://github.com/casperdcl","followers_url":"https://api.github.com/users/casperdcl/followers","following_url":"https://api.github.com/users/casperdcl/following{/other_user}","gists_url":"https://api.github.com/users/casperdcl/gists{/gist_id}","starred_url":"https://api.github.com/users/casperdcl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casperdcl/subscriptions","organizations_url":"https://api.github.com/users/casperdcl/orgs","repos_url":"https://api.github.com/users/casperdcl/repos","events_url":"https://api.github.com/users/casperdcl/events{/privacy}","received_events_url":"https://api.github.com/users/casperdcl/received_events","type":"User","site_admin":false},"labels":[{"id":489187006,"url":"https://api.github.com/repos/CCPPETMR/SIRF/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"casperdcl","id":10780059,"avatar_url":"https://avatars0.githubusercontent.com/u/10780059?v=4","gravatar_id":"","url":"https://api.github.com/users/casperdcl","html_url":"https://github.com/casperdcl","followers_url":"https://api.github.com/users/casperdcl/followers","following_url":"https://api.github.com/users/casperdcl/following{/other_user}","gists_url":"https://api.github.com/users/casperdcl/gists{/gist_id}","starred_url":"https://api.github.com/users/casperdcl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casperdcl/subscriptions","organizations_url":"https://api.github.com/users/casperdcl/orgs","repos_url":"https://api.github.com/users/casperdcl/repos","events_url":"https://api.github.com/users/casperdcl/events{/privacy}","received_events_url":"https://api.github.com/users/casperdcl/received_events","type":"User","site_admin":false},"assignees":[{"login":"casperdcl","id":10780059,"avatar_url":"https://avatars0.githubusercontent.com/u/10780059?v=4","gravatar_id":"","url":"https://api.github.com/users/casperdcl","html_url":"https://github.com/casperdcl","followers_url":"https://api.github.com/users/casperdcl/followers","following_url":"https://api.github.com/users/casperdcl/following{/other_user}","gists_url":"https://api.github.com/users/casperdcl/gists{/gist_id}","starred_url":"https://api.github.com/users/casperdcl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casperdcl/subscriptions","organizations_url":"https://api.github.com/users/casperdcl/orgs","repos_url":"https://api.github.com/users/casperdcl/repos","events_url":"https://api.github.com/users/casperdcl/events{/privacy}","received_events_url":"https://api.github.com/users/casperdcl/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-04-27T15:08:41Z","updated_at":"2018-04-30T11:14:28Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/CCPPETMR/SIRF/pulls/163","html_url":"https://github.com/CCPPETMR/SIRF/pull/163","diff_url":"https://github.com/CCPPETMR/SIRF/pull/163.diff","patch_url":"https://github.com/CCPPETMR/SIRF/pull/163.patch"},"body":"migrated from https://github.com/CCPPETMR/SIRF-SuperBuild/pull/109\r\n\r\n- [x] provides `setup.py`\r\n    + [x] provides `sirf`\r\n    + [x] alias for backward-compatibility\r\n        * [x] `p(Gadgetron|STIR|Utilities)` to `sirf.p(Gadgetron|STIR|Utilities)`\r\n        * [x] `py(gadgetron|stir|iutilities)` to `sirf.py(gadgetron|stir|iutilities)`\r\n        + [ ] remove `p` (`sirf.`~~`p`~~`(Gadgetron|STIR|Utilities)`)\r\n        + [ ] remove `py` (`sirf.`~~`py`~~`(gadgetron|stir|iutilities)`)?\r\n- [x] cmake -> ~~pip install ->~~ setup.py\r\n    + [x] expose `PYTHON_STRATEGY` (`CONDA|SETUP_PY|PYTHONPATH`)\r\n- ~~depends on #160 (for now uses #161)~~\r\n    + no longer depends because installation based on `PYTHON_STRATEGY` is migrated here\r\n- [x] register `sirf` on `PyPI` before anyone else does (https://pypi.org/project/sirf/)\r\n\r\n## old\r\n\r\n- `${PYTHON_DEST}/`\r\n    + `*.(py|so)`\r\n\r\n## new\r\n\r\n- `${PYTHON_DEST}/`\r\n    + `setup.py`\r\n    + `sirf/`\r\n        * `__init__.py`\r\n        * `*.(py|so)`\r\n    + `p*/__init__.py`\r\n\r\n## future\r\n\r\n- [ ] (ana)conda @paskino\r\n- [ ] register `sirf` on `conda-forge`\r\n- [ ] `setup.py:build_ext` to call `cmake` @casperdcl\r\n    + https://stackoverflow.com/a/48015772/3896283\r\n    + won't need to re-implement `cmake` call in `conda`\r\n    + will need to pass `cmake` build args to `setup.py` (pretty easy)\r\n"},"comment":{"url":"https://api.github.com/repos/CCPPETMR/SIRF/issues/comments/385369753","html_url":"https://github.com/CCPPETMR/SIRF/pull/163#issuecomment-385369753","issue_url":"https://api.github.com/repos/CCPPETMR/SIRF/issues/163","id":385369753,"user":{"login":"KrisThielemans","id":6362141,"avatar_url":"https://avatars2.githubusercontent.com/u/6362141?v=4","gravatar_id":"","url":"https://api.github.com/users/KrisThielemans","html_url":"https://github.com/KrisThielemans","followers_url":"https://api.github.com/users/KrisThielemans/followers","following_url":"https://api.github.com/users/KrisThielemans/following{/other_user}","gists_url":"https://api.github.com/users/KrisThielemans/gists{/gist_id}","starred_url":"https://api.github.com/users/KrisThielemans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrisThielemans/subscriptions","organizations_url":"https://api.github.com/users/KrisThielemans/orgs","repos_url":"https://api.github.com/users/KrisThielemans/repos","events_url":"https://api.github.com/users/KrisThielemans/events{/privacy}","received_events_url":"https://api.github.com/users/KrisThielemans/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T11:14:28Z","updated_at":"2018-04-30T11:14:28Z","author_association":"OWNER","body":"yes. that looks fine. I believe the `py*` are \"internal\".  In principle they could even be hidden from the user I think. @evgueni-ovtchinnikov, correct?"}}
{"actor":{"display_login":"KrisThielemans"}}