{"action":"created","comment":{"url":"https://api.github.com/repos/kubeapps/kubeapps/pulls/comments/239531715","pull_request_review_id":182343119,"id":239531715,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTUzMTcxNQ==","diff_hunk":"@@ -4,29 +4,33 @@ import { IResource } from \"../../shared/types\";\n import DeploymentItem from \"./DeploymentItem\";\n \n interface IDeploymentTableProps {\n-  deployments: { [d: string]: IResource };\n+  deployments: IResource[];","path":"dashboard/src/components/AppView/DeploymentTable.tsx","position":null,"original_position":5,"commit_id":"97e71fd93f17380346e548494b0a364a43781088","original_commit_id":"8a5e5a21e891ce91ce3a8c025619b0d1b0f98a86","user":{"login":"migmartri","id":24523,"node_id":"MDQ6VXNlcjI0NTIz","avatar_url":"https://avatars2.githubusercontent.com/u/24523?v=4","gravatar_id":"","url":"https://api.github.com/users/migmartri","html_url":"https://github.com/migmartri","followers_url":"https://api.github.com/users/migmartri/followers","following_url":"https://api.github.com/users/migmartri/following{/other_user}","gists_url":"https://api.github.com/users/migmartri/gists{/gist_id}","starred_url":"https://api.github.com/users/migmartri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migmartri/subscriptions","organizations_url":"https://api.github.com/users/migmartri/orgs","repos_url":"https://api.github.com/users/migmartri/repos","events_url":"https://api.github.com/users/migmartri/events{/privacy}","received_events_url":"https://api.github.com/users/migmartri/received_events","type":"User","site_admin":false},"body":"Sorry, I think that I do not understand this comment.","created_at":"2018-12-06T16:56:50Z","updated_at":"2018-12-06T16:56:50Z","html_url":"https://github.com/kubeapps/kubeapps/pull/855#discussion_r239531715","pull_request_url":"https://api.github.com/repos/kubeapps/kubeapps/pulls/855","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeapps/kubeapps/pulls/comments/239531715"},"html":{"href":"https://github.com/kubeapps/kubeapps/pull/855#discussion_r239531715"},"pull_request":{"href":"https://api.github.com/repos/kubeapps/kubeapps/pulls/855"}},"in_reply_to_id":238123007},"pull_request":{"url":"https://api.github.com/repos/kubeapps/kubeapps/pulls/855","id":233982289,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTgyMjg5","html_url":"https://github.com/kubeapps/kubeapps/pull/855","diff_url":"https://github.com/kubeapps/kubeapps/pull/855.diff","patch_url":"https://github.com/kubeapps/kubeapps/pull/855.patch","issue_url":"https://api.github.com/repos/kubeapps/kubeapps/issues/855","number":855,"state":"open","locked":false,"title":"Improve AppView loading behavior","user":{"login":"andresmgot","id":4025665,"node_id":"MDQ6VXNlcjQwMjU2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/4025665?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmgot","html_url":"https://github.com/andresmgot","followers_url":"https://api.github.com/users/andresmgot/followers","following_url":"https://api.github.com/users/andresmgot/following{/other_user}","gists_url":"https://api.github.com/users/andresmgot/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmgot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmgot/subscriptions","organizations_url":"https://api.github.com/users/andresmgot/orgs","repos_url":"https://api.github.com/users/andresmgot/repos","events_url":"https://api.github.com/users/andresmgot/events{/privacy}","received_events_url":"https://api.github.com/users/andresmgot/received_events","type":"User","site_admin":false},"body":"Fixes #748\r\nRequires #847\r\n\r\nThe goal of #748 is to provide feedback to the user when the URLs table is loading. In this PR I have added the LoadingWrapper to all the tables in the AppView page (not only to the URLs one):\r\n\r\nSummary of the changes:\r\n\r\n - The URLs table now have a title: \"Access URLs\"\r\n - All the tables shows the loading icon if the content is not ready.\r\n - In case there are no elements for a table a message like \"No resources found\" is shown.\r\n - I have removed the component AppDetails to directly use `DeploymentTable`, `ServiceTable` and `OtherResourcesTable`.\r\n - I have removed the title \"Details\" since it was splitting the Secrets and the rest of resources.\r\n\r\nTodo:\r\n\r\n - [x] Unit tests to check that each table behaves as a loading component and to check the 0 resources scenario.\r\n\r\n![gif_](https://user-images.githubusercontent.com/4025665/49296053-87d6e480-f4b7-11e8-9a7c-521a1b389545.gif)\r\n\r\n","created_at":"2018-11-27T16:42:19Z","updated_at":"2018-12-06T16:56:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cfc120c748a824518d3eefdc01631bd4dae4750","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubeapps/kubeapps/pulls/855/commits","review_comments_url":"https://api.github.com/repos/kubeapps/kubeapps/pulls/855/comments","review_comment_url":"https://api.github.com/repos/kubeapps/kubeapps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeapps/kubeapps/issues/855/comments","statuses_url":"https://api.github.com/repos/kubeapps/kubeapps/statuses/97e71fd93f17380346e548494b0a364a43781088","head":{"label":"andresmgot:appViewLoading","ref":"appViewLoading","sha":"97e71fd93f17380346e548494b0a364a43781088","user":{"login":"andresmgot","id":4025665,"node_id":"MDQ6VXNlcjQwMjU2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/4025665?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmgot","html_url":"https://github.com/andresmgot","followers_url":"https://api.github.com/users/andresmgot/followers","following_url":"https://api.github.com/users/andresmgot/following{/other_user}","gists_url":"https://api.github.com/users/andresmgot/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmgot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmgot/subscriptions","organizations_url":"https://api.github.com/users/andresmgot/orgs","repos_url":"https://api.github.com/users/andresmgot/repos","events_url":"https://api.github.com/users/andresmgot/events{/privacy}","received_events_url":"https://api.github.com/users/andresmgot/received_events","type":"User","site_admin":false},"repo":{"id":111571118,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE1NzExMTg=","name":"installer","full_name":"andresmgot/installer","private":false,"owner":{"login":"andresmgot","id":4025665,"node_id":"MDQ6VXNlcjQwMjU2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/4025665?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmgot","html_url":"https://github.com/andresmgot","followers_url":"https://api.github.com/users/andresmgot/followers","following_url":"https://api.github.com/users/andresmgot/following{/other_user}","gists_url":"https://api.github.com/users/andresmgot/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmgot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmgot/subscriptions","organizations_url":"https://api.github.com/users/andresmgot/orgs","repos_url":"https://api.github.com/users/andresmgot/repos","events_url":"https://api.github.com/users/andresmgot/events{/privacy}","received_events_url":"https://api.github.com/users/andresmgot/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andresmgot/installer","description":null,"fork":true,"url":"https://api.github.com/repos/andresmgot/installer","forks_url":"https://api.github.com/repos/andresmgot/installer/forks","keys_url":"https://api.github.com/repos/andresmgot/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresmgot/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresmgot/installer/teams","hooks_url":"https://api.github.com/repos/andresmgot/installer/hooks","issue_events_url":"https://api.github.com/repos/andresmgot/installer/issues/events{/number}","events_url":"https://api.github.com/repos/andresmgot/installer/events","assignees_url":"https://api.github.com/repos/andresmgot/installer/assignees{/user}","branches_url":"https://api.github.com/repos/andresmgot/installer/branches{/branch}","tags_url":"https://api.github.com/repos/andresmgot/installer/tags","blobs_url":"https://api.github.com/repos/andresmgot/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresmgot/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresmgot/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresmgot/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresmgot/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/andresmgot/installer/languages","stargazers_url":"https://api.github.com/repos/andresmgot/installer/stargazers","contributors_url":"https://api.github.com/repos/andresmgot/installer/contributors","subscribers_url":"https://api.github.com/repos/andresmgot/installer/subscribers","subscription_url":"https://api.github.com/repos/andresmgot/installer/subscription","commits_url":"https://api.github.com/repos/andresmgot/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresmgot/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresmgot/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresmgot/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresmgot/installer/contents/{+path}","compare_url":"https://api.github.com/repos/andresmgot/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresmgot/installer/merges","archive_url":"https://api.github.com/repos/andresmgot/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresmgot/installer/downloads","issues_url":"https://api.github.com/repos/andresmgot/installer/issues{/number}","pulls_url":"https://api.github.com/repos/andresmgot/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/andresmgot/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/andresmgot/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresmgot/installer/labels{/name}","releases_url":"https://api.github.com/repos/andresmgot/installer/releases{/id}","deployments_url":"https://api.github.com/repos/andresmgot/installer/deployments","created_at":"2017-11-21T16:04:30Z","updated_at":"2017-11-21T16:04:32Z","pushed_at":"2018-12-06T16:02:14Z","git_url":"git://github.com/andresmgot/installer.git","ssh_url":"git@github.com:andresmgot/installer.git","clone_url":"https://github.com/andresmgot/installer.git","svn_url":"https://github.com/andresmgot/installer","homepage":null,"size":50250,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeapps:master","ref":"master","sha":"4f6f94c256e4dc2d1eb63ae259deb221f258a761","user":{"login":"kubeapps","id":32396354,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMzk2MzU0","avatar_url":"https://avatars0.githubusercontent.com/u/32396354?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeapps","html_url":"https://github.com/kubeapps","followers_url":"https://api.github.com/users/kubeapps/followers","following_url":"https://api.github.com/users/kubeapps/following{/other_user}","gists_url":"https://api.github.com/users/kubeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeapps/subscriptions","organizations_url":"https://api.github.com/users/kubeapps/orgs","repos_url":"https://api.github.com/users/kubeapps/repos","events_url":"https://api.github.com/users/kubeapps/events{/privacy}","received_events_url":"https://api.github.com/users/kubeapps/received_events","type":"Organization","site_admin":false},"repo":{"id":107555654,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1NTU2NTQ=","name":"kubeapps","full_name":"kubeapps/kubeapps","private":false,"owner":{"login":"kubeapps","id":32396354,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMzk2MzU0","avatar_url":"https://avatars0.githubusercontent.com/u/32396354?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeapps","html_url":"https://github.com/kubeapps","followers_url":"https://api.github.com/users/kubeapps/followers","following_url":"https://api.github.com/users/kubeapps/following{/other_user}","gists_url":"https://api.github.com/users/kubeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeapps/subscriptions","organizations_url":"https://api.github.com/users/kubeapps/orgs","repos_url":"https://api.github.com/users/kubeapps/repos","events_url":"https://api.github.com/users/kubeapps/events{/privacy}","received_events_url":"https://api.github.com/users/kubeapps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubeapps/kubeapps","description":"A web-based UI for deploying and managing applications in Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/kubeapps/kubeapps","forks_url":"https://api.github.com/repos/kubeapps/kubeapps/forks","keys_url":"https://api.github.com/repos/kubeapps/kubeapps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeapps/kubeapps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeapps/kubeapps/teams","hooks_url":"https://api.github.com/repos/kubeapps/kubeapps/hooks","issue_events_url":"https://api.github.com/repos/kubeapps/kubeapps/issues/events{/number}","events_url":"https://api.github.com/repos/kubeapps/kubeapps/events","assignees_url":"https://api.github.com/repos/kubeapps/kubeapps/assignees{/user}","branches_url":"https://api.github.com/repos/kubeapps/kubeapps/branches{/branch}","tags_url":"https://api.github.com/repos/kubeapps/kubeapps/tags","blobs_url":"https://api.github.com/repos/kubeapps/kubeapps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeapps/kubeapps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeapps/kubeapps/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeapps/kubeapps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeapps/kubeapps/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeapps/kubeapps/languages","stargazers_url":"https://api.github.com/repos/kubeapps/kubeapps/stargazers","contributors_url":"https://api.github.com/repos/kubeapps/kubeapps/contributors","subscribers_url":"https://api.github.com/repos/kubeapps/kubeapps/subscribers","subscription_url":"https://api.github.com/repos/kubeapps/kubeapps/subscription","commits_url":"https://api.github.com/repos/kubeapps/kubeapps/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeapps/kubeapps/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeapps/kubeapps/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeapps/kubeapps/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeapps/kubeapps/contents/{+path}","compare_url":"https://api.github.com/repos/kubeapps/kubeapps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeapps/kubeapps/merges","archive_url":"https://api.github.com/repos/kubeapps/kubeapps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeapps/kubeapps/downloads","issues_url":"https://api.github.com/repos/kubeapps/kubeapps/issues{/number}","pulls_url":"https://api.github.com/repos/kubeapps/kubeapps/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeapps/kubeapps/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeapps/kubeapps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeapps/kubeapps/labels{/name}","releases_url":"https://api.github.com/repos/kubeapps/kubeapps/releases{/id}","deployments_url":"https://api.github.com/repos/kubeapps/kubeapps/deployments","created_at":"2017-10-19T14:14:34Z","updated_at":"2018-12-06T14:12:37Z","pushed_at":"2018-12-06T16:05:30Z","git_url":"git://github.com/kubeapps/kubeapps.git","ssh_url":"git@github.com:kubeapps/kubeapps.git","clone_url":"https://github.com/kubeapps/kubeapps.git","svn_url":"https://github.com/kubeapps/kubeapps","homepage":"https://kubeapps.com","size":49894,"stargazers_count":713,"watchers_count":713,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":122,"open_issues":92,"watchers":713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeapps/kubeapps/pulls/855"},"html":{"href":"https://github.com/kubeapps/kubeapps/pull/855"},"issue":{"href":"https://api.github.com/repos/kubeapps/kubeapps/issues/855"},"comments":{"href":"https://api.github.com/repos/kubeapps/kubeapps/issues/855/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeapps/kubeapps/pulls/855/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeapps/kubeapps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeapps/kubeapps/pulls/855/commits"},"statuses":{"href":"https://api.github.com/repos/kubeapps/kubeapps/statuses/97e71fd93f17380346e548494b0a364a43781088"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"migmartri"}}