{"action":"closed","issue":{"url":"https://api.github.com/repos/MrYsLab/PyMata/issues/39","repository_url":"https://api.github.com/repos/MrYsLab/PyMata","labels_url":"https://api.github.com/repos/MrYsLab/PyMata/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/MrYsLab/PyMata/issues/39/comments","events_url":"https://api.github.com/repos/MrYsLab/PyMata/issues/39/events","html_url":"https://github.com/MrYsLab/PyMata/issues/39","id":369929595,"node_id":"MDU6SXNzdWUzNjk5Mjk1OTU=","number":39,"title":"Two errant calls to exit() (rather than sys.exit()) in pymata_core.py","user":{"login":"ericwertz","id":187637,"node_id":"MDQ6VXNlcjE4NzYzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/187637?v=4","gravatar_id":"","url":"https://api.github.com/users/ericwertz","html_url":"https://github.com/ericwertz","followers_url":"https://api.github.com/users/ericwertz/followers","following_url":"https://api.github.com/users/ericwertz/following{/other_user}","gists_url":"https://api.github.com/users/ericwertz/gists{/gist_id}","starred_url":"https://api.github.com/users/ericwertz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericwertz/subscriptions","organizations_url":"https://api.github.com/users/ericwertz/orgs","repos_url":"https://api.github.com/users/ericwertz/repos","events_url":"https://api.github.com/users/ericwertz/events{/privacy}","received_events_url":"https://api.github.com/users/ericwertz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-14T18:27:53Z","updated_at":"2018-10-14T18:30:29Z","closed_at":"2018-10-14T18:30:29Z","author_association":"NONE","body":"During the course of some hitting some of my Windows-specific problems, I've hit runtime errors where exit() is being called, rather than what should be sys.exit() in pymata_core.  A quick search finds that there are two such calls currently in pymata_core.py at lines 990 and 1869.\r\n\r\nSince we're talking about calls to sys.exit(), there are numerous places where sys.exit(0) is called in non-happy paths that seem to be runtime errors, but for which no diagnostic messages are issued.  Any of these that are hit would result in silent deaths, making them hard to track down if they're hit.  At least a print() would help, and a full-on runtime error w/stack trace might even be more helpful in some of these contexts."}}
{"actor":{"display_login":"ericwertz"}}