{"action":"created","comment":{"url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/comments/175276592","pull_request_review_id":104784806,"id":175276592,"diff_hunk":"@@ -1580,6 +1580,31 @@ accountForRefactor() {\n }\n \n updatePihole() {\n+  # Create the pihole user\n+  create_pihole_user\n+\n+  # If the user wants to install the Web interface,\n+  if [[ \"${INSTALL_WEB}\" == true ]]; then\n+    if [[ ! -d \"/var/www/html\" ]]; then\n+      # make the Web directory if necessary\n+      mkdir -p /var/www/html\n+    fi\n+    # Set the owner and permissions\n+    chown ${LIGHTTPD_USER}:${LIGHTTPD_GROUP} /var/www/html\n+    chmod 775 /var/www/html\n+    # Give pihole access to the Web server group\n+    usermod -a -G ${LIGHTTPD_USER} pihole\n+    # If the lighttpd command is executable,\n+    if [[ -x \"$(command -v lighty-enable-mod)\" ]]; then\n+      # enable fastcgi and fastcgi-php\n+      lighty-enable-mod fastcgi fastcgi-php > /dev/null || true\n+    else\n+      # Otherwise, show info about installing them\n+      echo -e  \"  ${INFO} Warning: 'lighty-enable-mod' utility not found\n+      Please ensure fastcgi is enabled if you experience issues\\\\n\"\n+    fi\n+  fi","path":"automated install/basic-install.sh","position":70,"original_position":70,"commit_id":"17ce8d8e13fa079e7fc38bb37862449c4425b183","original_commit_id":"17ce8d8e13fa079e7fc38bb37862449c4425b183","user":{"login":"Fauxsys","id":13059681,"avatar_url":"https://avatars1.githubusercontent.com/u/13059681?v=4","gravatar_id":"","url":"https://api.github.com/users/Fauxsys","html_url":"https://github.com/Fauxsys","followers_url":"https://api.github.com/users/Fauxsys/followers","following_url":"https://api.github.com/users/Fauxsys/following{/other_user}","gists_url":"https://api.github.com/users/Fauxsys/gists{/gist_id}","starred_url":"https://api.github.com/users/Fauxsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fauxsys/subscriptions","organizations_url":"https://api.github.com/users/Fauxsys/orgs","repos_url":"https://api.github.com/users/Fauxsys/repos","events_url":"https://api.github.com/users/Fauxsys/events{/privacy}","received_events_url":"https://api.github.com/users/Fauxsys/received_events","type":"User","site_admin":false},"body":"Sure thing.","created_at":"2018-03-18T03:56:48Z","updated_at":"2018-03-18T03:56:48Z","html_url":"https://github.com/pi-hole/pi-hole/pull/1835#discussion_r175276592","pull_request_url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1835","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pi-hole/pi-hole/pulls/comments/175276592"},"html":{"href":"https://github.com/pi-hole/pi-hole/pull/1835#discussion_r175276592"},"pull_request":{"href":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1835"}},"in_reply_to_id":157330950},"pull_request":{"url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1835","id":157478861,"html_url":"https://github.com/pi-hole/pi-hole/pull/1835","diff_url":"https://github.com/pi-hole/pi-hole/pull/1835.diff","patch_url":"https://github.com/pi-hole/pi-hole/pull/1835.patch","issue_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1835","number":1835,"state":"open","locked":false,"title":"Fix for unattended installations #1767 #1768 #1834","user":{"login":"Fauxsys","id":13059681,"avatar_url":"https://avatars1.githubusercontent.com/u/13059681?v=4","gravatar_id":"","url":"https://api.github.com/users/Fauxsys","html_url":"https://github.com/Fauxsys","followers_url":"https://api.github.com/users/Fauxsys/followers","following_url":"https://api.github.com/users/Fauxsys/following{/other_user}","gists_url":"https://api.github.com/users/Fauxsys/gists{/gist_id}","starred_url":"https://api.github.com/users/Fauxsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fauxsys/subscriptions","organizations_url":"https://api.github.com/users/Fauxsys/orgs","repos_url":"https://api.github.com/users/Fauxsys/repos","events_url":"https://api.github.com/users/Fauxsys/events{/privacy}","received_events_url":"https://api.github.com/users/Fauxsys/received_events","type":"User","site_admin":false},"body":"**By submitting this pull request, I confirm the following:**\r\n\r\n- [X] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.\r\n- [X] I have made only one major change in my proposed changes.\r\n- [X] I have commented my proposed changes within the code.\r\n- [X] I have tested my proposed changes, and have included unit tests where possible.\r\n- [X] I am willing to help maintain this change if there are issues with it later.\r\n- [X] I give this submission freely and claim no ownership.\r\n- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)\r\n- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))\r\n- [X] I have Signed Off all commits. ([`git commit --signoff`](https://git-scm.com/docs/git-commit#git-commit---signoff))\r\n\r\n---\r\n\r\n**What does this PR aim to accomplish?:**\r\nUsing the --unattended flag didn't perform a full installation of pihole. #1768 is open to fix #1767 as well, but as a result of that PR the pihole user is still not created and instead the `$USER` variable will equal `root` for unattended installs.\r\n\r\nIn comparison, this PR will create pihole user, add folder permissions to /var/www/html, and correct minor typos. `Othweise` and variants changed to `Otherwise`. `usermod -a -G ${LIGHTTPD_GROUP} pihole` changed to `usermod -a -G ${LIGHTTPD_USER} pihole`.\r\n\r\n**How does this PR accomplish the above?:**\r\n\r\nLink to diff can be found [here](https://github.com/Fauxsys/pi-hole/commit/17ce8d8e13fa079e7fc38bb37862449c4425b183#diff-689793e68cde6270d074695b71c969af).\r\n\r\n**What documentation changes (if any) are needed to support this PR?:**\r\n\r\nN/A","created_at":"2017-12-11T05:04:12Z","updated_at":"2018-03-18T03:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0c3a18ed8a8289de58f99b4d86bd1b0561110dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/pi-hole/pi-hole/milestones/25","html_url":"https://github.com/pi-hole/pi-hole/milestone/25","labels_url":"https://api.github.com/repos/pi-hole/pi-hole/milestones/25/labels","id":2650887,"number":25,"title":"v3.3","description":null,"creator":{"login":"PromoFaux","id":1998970,"avatar_url":"https://avatars0.githubusercontent.com/u/1998970?v=4","gravatar_id":"","url":"https://api.github.com/users/PromoFaux","html_url":"https://github.com/PromoFaux","followers_url":"https://api.github.com/users/PromoFaux/followers","following_url":"https://api.github.com/users/PromoFaux/following{/other_user}","gists_url":"https://api.github.com/users/PromoFaux/gists{/gist_id}","starred_url":"https://api.github.com/users/PromoFaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PromoFaux/subscriptions","organizations_url":"https://api.github.com/users/PromoFaux/orgs","repos_url":"https://api.github.com/users/PromoFaux/repos","events_url":"https://api.github.com/users/PromoFaux/events{/privacy}","received_events_url":"https://api.github.com/users/PromoFaux/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":15,"state":"open","created_at":"2017-07-19T19:34:33Z","updated_at":"2018-02-18T04:06:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1835/commits","review_comments_url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1835/comments","review_comment_url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1835/comments","statuses_url":"https://api.github.com/repos/pi-hole/pi-hole/statuses/17ce8d8e13fa079e7fc38bb37862449c4425b183","head":{"label":"Fauxsys:development","ref":"development","sha":"17ce8d8e13fa079e7fc38bb37862449c4425b183","user":{"login":"Fauxsys","id":13059681,"avatar_url":"https://avatars1.githubusercontent.com/u/13059681?v=4","gravatar_id":"","url":"https://api.github.com/users/Fauxsys","html_url":"https://github.com/Fauxsys","followers_url":"https://api.github.com/users/Fauxsys/followers","following_url":"https://api.github.com/users/Fauxsys/following{/other_user}","gists_url":"https://api.github.com/users/Fauxsys/gists{/gist_id}","starred_url":"https://api.github.com/users/Fauxsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fauxsys/subscriptions","organizations_url":"https://api.github.com/users/Fauxsys/orgs","repos_url":"https://api.github.com/users/Fauxsys/repos","events_url":"https://api.github.com/users/Fauxsys/events{/privacy}","received_events_url":"https://api.github.com/users/Fauxsys/received_events","type":"User","site_admin":false},"repo":{"id":113812947,"name":"pi-hole","full_name":"Fauxsys/pi-hole","owner":{"login":"Fauxsys","id":13059681,"avatar_url":"https://avatars1.githubusercontent.com/u/13059681?v=4","gravatar_id":"","url":"https://api.github.com/users/Fauxsys","html_url":"https://github.com/Fauxsys","followers_url":"https://api.github.com/users/Fauxsys/followers","following_url":"https://api.github.com/users/Fauxsys/following{/other_user}","gists_url":"https://api.github.com/users/Fauxsys/gists{/gist_id}","starred_url":"https://api.github.com/users/Fauxsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fauxsys/subscriptions","organizations_url":"https://api.github.com/users/Fauxsys/orgs","repos_url":"https://api.github.com/users/Fauxsys/repos","events_url":"https://api.github.com/users/Fauxsys/events{/privacy}","received_events_url":"https://api.github.com/users/Fauxsys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fauxsys/pi-hole","description":"A black hole for Internet advertisements","fork":true,"url":"https://api.github.com/repos/Fauxsys/pi-hole","forks_url":"https://api.github.com/repos/Fauxsys/pi-hole/forks","keys_url":"https://api.github.com/repos/Fauxsys/pi-hole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fauxsys/pi-hole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fauxsys/pi-hole/teams","hooks_url":"https://api.github.com/repos/Fauxsys/pi-hole/hooks","issue_events_url":"https://api.github.com/repos/Fauxsys/pi-hole/issues/events{/number}","events_url":"https://api.github.com/repos/Fauxsys/pi-hole/events","assignees_url":"https://api.github.com/repos/Fauxsys/pi-hole/assignees{/user}","branches_url":"https://api.github.com/repos/Fauxsys/pi-hole/branches{/branch}","tags_url":"https://api.github.com/repos/Fauxsys/pi-hole/tags","blobs_url":"https://api.github.com/repos/Fauxsys/pi-hole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fauxsys/pi-hole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fauxsys/pi-hole/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fauxsys/pi-hole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fauxsys/pi-hole/statuses/{sha}","languages_url":"https://api.github.com/repos/Fauxsys/pi-hole/languages","stargazers_url":"https://api.github.com/repos/Fauxsys/pi-hole/stargazers","contributors_url":"https://api.github.com/repos/Fauxsys/pi-hole/contributors","subscribers_url":"https://api.github.com/repos/Fauxsys/pi-hole/subscribers","subscription_url":"https://api.github.com/repos/Fauxsys/pi-hole/subscription","commits_url":"https://api.github.com/repos/Fauxsys/pi-hole/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fauxsys/pi-hole/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fauxsys/pi-hole/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fauxsys/pi-hole/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fauxsys/pi-hole/contents/{+path}","compare_url":"https://api.github.com/repos/Fauxsys/pi-hole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fauxsys/pi-hole/merges","archive_url":"https://api.github.com/repos/Fauxsys/pi-hole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fauxsys/pi-hole/downloads","issues_url":"https://api.github.com/repos/Fauxsys/pi-hole/issues{/number}","pulls_url":"https://api.github.com/repos/Fauxsys/pi-hole/pulls{/number}","milestones_url":"https://api.github.com/repos/Fauxsys/pi-hole/milestones{/number}","notifications_url":"https://api.github.com/repos/Fauxsys/pi-hole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fauxsys/pi-hole/labels{/name}","releases_url":"https://api.github.com/repos/Fauxsys/pi-hole/releases{/id}","deployments_url":"https://api.github.com/repos/Fauxsys/pi-hole/deployments","created_at":"2017-12-11T04:41:20Z","updated_at":"2017-12-11T04:41:22Z","pushed_at":"2017-12-11T04:52:44Z","git_url":"git://github.com/Fauxsys/pi-hole.git","ssh_url":"git@github.com:Fauxsys/pi-hole.git","clone_url":"https://github.com/Fauxsys/pi-hole.git","svn_url":"https://github.com/Fauxsys/pi-hole","homepage":"https://pi-hole.net","size":3442,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pi-hole:development","ref":"development","sha":"47ed0b7627f35fc8fe76ab0550863a717cfd9fb0","user":{"login":"pi-hole","id":16827203,"avatar_url":"https://avatars2.githubusercontent.com/u/16827203?v=4","gravatar_id":"","url":"https://api.github.com/users/pi-hole","html_url":"https://github.com/pi-hole","followers_url":"https://api.github.com/users/pi-hole/followers","following_url":"https://api.github.com/users/pi-hole/following{/other_user}","gists_url":"https://api.github.com/users/pi-hole/gists{/gist_id}","starred_url":"https://api.github.com/users/pi-hole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pi-hole/subscriptions","organizations_url":"https://api.github.com/users/pi-hole/orgs","repos_url":"https://api.github.com/users/pi-hole/repos","events_url":"https://api.github.com/users/pi-hole/events{/privacy}","received_events_url":"https://api.github.com/users/pi-hole/received_events","type":"Organization","site_admin":false},"repo":{"id":20619036,"name":"pi-hole","full_name":"pi-hole/pi-hole","owner":{"login":"pi-hole","id":16827203,"avatar_url":"https://avatars2.githubusercontent.com/u/16827203?v=4","gravatar_id":"","url":"https://api.github.com/users/pi-hole","html_url":"https://github.com/pi-hole","followers_url":"https://api.github.com/users/pi-hole/followers","following_url":"https://api.github.com/users/pi-hole/following{/other_user}","gists_url":"https://api.github.com/users/pi-hole/gists{/gist_id}","starred_url":"https://api.github.com/users/pi-hole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pi-hole/subscriptions","organizations_url":"https://api.github.com/users/pi-hole/orgs","repos_url":"https://api.github.com/users/pi-hole/repos","events_url":"https://api.github.com/users/pi-hole/events{/privacy}","received_events_url":"https://api.github.com/users/pi-hole/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pi-hole/pi-hole","description":"A black hole for Internet advertisements","fork":false,"url":"https://api.github.com/repos/pi-hole/pi-hole","forks_url":"https://api.github.com/repos/pi-hole/pi-hole/forks","keys_url":"https://api.github.com/repos/pi-hole/pi-hole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pi-hole/pi-hole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pi-hole/pi-hole/teams","hooks_url":"https://api.github.com/repos/pi-hole/pi-hole/hooks","issue_events_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/events{/number}","events_url":"https://api.github.com/repos/pi-hole/pi-hole/events","assignees_url":"https://api.github.com/repos/pi-hole/pi-hole/assignees{/user}","branches_url":"https://api.github.com/repos/pi-hole/pi-hole/branches{/branch}","tags_url":"https://api.github.com/repos/pi-hole/pi-hole/tags","blobs_url":"https://api.github.com/repos/pi-hole/pi-hole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pi-hole/pi-hole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pi-hole/pi-hole/git/refs{/sha}","trees_url":"https://api.github.com/repos/pi-hole/pi-hole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pi-hole/pi-hole/statuses/{sha}","languages_url":"https://api.github.com/repos/pi-hole/pi-hole/languages","stargazers_url":"https://api.github.com/repos/pi-hole/pi-hole/stargazers","contributors_url":"https://api.github.com/repos/pi-hole/pi-hole/contributors","subscribers_url":"https://api.github.com/repos/pi-hole/pi-hole/subscribers","subscription_url":"https://api.github.com/repos/pi-hole/pi-hole/subscription","commits_url":"https://api.github.com/repos/pi-hole/pi-hole/commits{/sha}","git_commits_url":"https://api.github.com/repos/pi-hole/pi-hole/git/commits{/sha}","comments_url":"https://api.github.com/repos/pi-hole/pi-hole/comments{/number}","issue_comment_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/comments{/number}","contents_url":"https://api.github.com/repos/pi-hole/pi-hole/contents/{+path}","compare_url":"https://api.github.com/repos/pi-hole/pi-hole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pi-hole/pi-hole/merges","archive_url":"https://api.github.com/repos/pi-hole/pi-hole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pi-hole/pi-hole/downloads","issues_url":"https://api.github.com/repos/pi-hole/pi-hole/issues{/number}","pulls_url":"https://api.github.com/repos/pi-hole/pi-hole/pulls{/number}","milestones_url":"https://api.github.com/repos/pi-hole/pi-hole/milestones{/number}","notifications_url":"https://api.github.com/repos/pi-hole/pi-hole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pi-hole/pi-hole/labels{/name}","releases_url":"https://api.github.com/repos/pi-hole/pi-hole/releases{/id}","deployments_url":"https://api.github.com/repos/pi-hole/pi-hole/deployments","created_at":"2014-06-08T15:02:55Z","updated_at":"2018-03-18T00:47:35Z","pushed_at":"2018-03-18T00:38:51Z","git_url":"git://github.com/pi-hole/pi-hole.git","ssh_url":"git@github.com:pi-hole/pi-hole.git","clone_url":"https://github.com/pi-hole/pi-hole.git","svn_url":"https://github.com/pi-hole/pi-hole","homepage":"https://pi-hole.net","size":3536,"stargazers_count":7491,"watchers_count":7491,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":652,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":652,"open_issues":93,"watchers":7491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1835"},"html":{"href":"https://github.com/pi-hole/pi-hole/pull/1835"},"issue":{"href":"https://api.github.com/repos/pi-hole/pi-hole/issues/1835"},"comments":{"href":"https://api.github.com/repos/pi-hole/pi-hole/issues/1835/comments"},"review_comments":{"href":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1835/comments"},"review_comment":{"href":"https://api.github.com/repos/pi-hole/pi-hole/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1835/commits"},"statuses":{"href":"https://api.github.com/repos/pi-hole/pi-hole/statuses/17ce8d8e13fa079e7fc38bb37862449c4425b183"}},"author_association":"NONE"}}
{"actor":{"display_login":"Fauxsys"}}