{"action":"created","issue":{"url":"https://api.github.com/repos/Islandora/islandora_xml_forms/issues/253","repository_url":"https://api.github.com/repos/Islandora/islandora_xml_forms","labels_url":"https://api.github.com/repos/Islandora/islandora_xml_forms/issues/253/labels{/name}","comments_url":"https://api.github.com/repos/Islandora/islandora_xml_forms/issues/253/comments","events_url":"https://api.github.com/repos/Islandora/islandora_xml_forms/issues/253/events","html_url":"https://github.com/Islandora/islandora_xml_forms/pull/253","id":318657367,"number":253,"title":"ISLANDORA-2205: Re-design `creative_commons` element","user":{"login":"d-r-p","id":22350048,"avatar_url":"https://avatars1.githubusercontent.com/u/22350048?v=4","gravatar_id":"","url":"https://api.github.com/users/d-r-p","html_url":"https://github.com/d-r-p","followers_url":"https://api.github.com/users/d-r-p/followers","following_url":"https://api.github.com/users/d-r-p/following{/other_user}","gists_url":"https://api.github.com/users/d-r-p/gists{/gist_id}","starred_url":"https://api.github.com/users/d-r-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-r-p/subscriptions","organizations_url":"https://api.github.com/users/d-r-p/orgs","repos_url":"https://api.github.com/users/d-r-p/repos","events_url":"https://api.github.com/users/d-r-p/events{/privacy}","received_events_url":"https://api.github.com/users/d-r-p/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2018-04-28T18:11:06Z","updated_at":"2018-05-08T16:56:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_xml_forms/pulls/253","html_url":"https://github.com/Islandora/islandora_xml_forms/pull/253","diff_url":"https://github.com/Islandora/islandora_xml_forms/pull/253.diff","patch_url":"https://github.com/Islandora/islandora_xml_forms/pull/253.patch"},"body":"Also, implement ISLANDORA-2208 and solve issues in #251\r\n\r\n**JIRA Ticket**: https://jira.duraspace.org/browse/ISLANDORA-2205\r\n\r\n* https://jira.duraspace.org/browse/ISLANDORA-2208\r\n* #251\r\n\r\n# What does this Pull Request do?\r\n\r\nRe-design `creative_commons` element to solve bugs and implement new features. In particular, users can set default license in form builder, choose Public Domain licenses, override license versions and work without JS.\r\n\r\n# What's new?\r\n\r\n* Honour '#default_value'\r\n* Allow CC0 & Public Domain Mark licenses\r\n* Graceful non-JS degradation\r\n* Allow overriding license version\r\n* Allow setting license URI manually\r\n* Validate versions, resp. license URIs\r\n* Cache last query to API for speed-up\r\n* Fix `<html>` wrapper of API response\r\n* Renounce to value callback; populate values in element creation function\r\n* Remove '#tree' logic in favour of manipulating `$form_state` directly\r\n\r\n# How should this be tested?\r\n\r\n* On a test VM, try to reproduce all the issues listed in the JIRA tickets and the above-mentioned PR.\r\n* Pull this PR\r\n* Verify that issues have disappeared (and no new ones arose).\r\n\r\n# Additional Notes:\r\n\r\nSince this PR basically re-designs the `creative_commons` element (in particular dropping the '#tree' manipulation), it could well be that\r\n1. This code is more buggy than the previous one\r\n2. There are neater ways of doing what is done here\r\n\r\nA thorough code review is, therefore, indispensable.\r\n\r\nExample:\r\n* Does this change require documentation to be updated? **perhaps?**\r\n* Does this change add any new dependencies?  **no**\r\n* Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? **probably not, as functions only got extended by optional arguments**\r\n* Could this change impact execution of existing code? **hopefully not**\r\n\r\n# Interested parties\r\n@adam-vessey @bondjimbond @rosiel @whikloj @DiegoPino @Islandora/7-x-1-x-committers\r\n"},"comment":{"url":"https://api.github.com/repos/Islandora/islandora_xml_forms/issues/comments/387470208","html_url":"https://github.com/Islandora/islandora_xml_forms/pull/253#issuecomment-387470208","issue_url":"https://api.github.com/repos/Islandora/islandora_xml_forms/issues/253","id":387470208,"user":{"login":"DiegoPino","id":6946023,"avatar_url":"https://avatars2.githubusercontent.com/u/6946023?v=4","gravatar_id":"","url":"https://api.github.com/users/DiegoPino","html_url":"https://github.com/DiegoPino","followers_url":"https://api.github.com/users/DiegoPino/followers","following_url":"https://api.github.com/users/DiegoPino/following{/other_user}","gists_url":"https://api.github.com/users/DiegoPino/gists{/gist_id}","starred_url":"https://api.github.com/users/DiegoPino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DiegoPino/subscriptions","organizations_url":"https://api.github.com/users/DiegoPino/orgs","repos_url":"https://api.github.com/users/DiegoPino/repos","events_url":"https://api.github.com/users/DiegoPino/events{/privacy}","received_events_url":"https://api.github.com/users/DiegoPino/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T16:56:22Z","updated_at":"2018-05-08T16:56:22Z","author_association":"CONTRIBUTOR","body":"@d-r-p before making more changes let me debug this ajax thing. I had my fair share of ajax while coding for islandora webform module and I remember I dealt with it in some way different... but as said lets test this as it is and then we can go from there. I would prefer to avoid moving things around until fully tested. Thanks a lot"}}
{"actor":{"display_login":"DiegoPino"}}