{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/180506255","pull_request_review_id":110926526,"id":180506255,"diff_hunk":"@@ -282,7 +391,75 @@ void L1TStage2uGT::analyze(const edm::Event& evt, const edm::EventSetup& evtSetu\n            } // end of uGtAlgs\n         } // end of BX\n      } // selecting LastCollisionInTrain\n-  } // end of uGTAlgs = 1\n+\n+\n+   if(algoBitFirstBxInTrain_ != -1 && itr->getAlgoDecisionInitial(algoBitFirstBxInTrain_)) {\n+     for(int ibx = uGtAlgs->getFirstBX(); ibx <= uGtAlgs->getLastBX(); ++ibx) {\n+       for(auto itr2 = uGtAlgs->begin(ibx); itr2 != uGtAlgs->end(ibx); ++itr2) {\n+         for(unsigned int algo=0; algo<prescaledAlgoBitName_.size(); algo++) { \n+           if(itr2->getAlgoDecisionInitial(prescaledAlgoBitName_.at(algo).second)) { \n+             prescaled_first_collision_run_->Fill(ibx, prescaledAlgoBitName_.at(algo).second);\n+             for(int ibx2 = uGtAlgs->getFirstBX(); ibx2 <= uGtAlgs->getLastBX(); ++ibx2) {\n+               den_prescaled_first_collision_run_->Fill(ibx2,prescaledAlgoBitName_.at(algo).second);\n+             }\n+           }\n+         }\n+         for(unsigned int algo=0; algo<unprescaledAlgoBitName_.size(); algo++) {\n+           if(itr2->getAlgoDecisionInitial(unprescaledAlgoBitName_.at(algo).second)) {\n+             unprescaled_first_collision_run_->Fill(ibx,unprescaledAlgoBitName_.at(algo).second);","path":"DQM/L1TMonitor/src/L1TStage2uGT.cc","position":187,"original_position":187,"commit_id":"5f99d244ea6a875721ffaf65b86364defd8be5a3","original_commit_id":"5f99d244ea6a875721ffaf65b86364defd8be5a3","user":{"login":"thomreis","id":4661965,"avatar_url":"https://avatars0.githubusercontent.com/u/4661965?v=4","gravatar_id":"","url":"https://api.github.com/users/thomreis","html_url":"https://github.com/thomreis","followers_url":"https://api.github.com/users/thomreis/followers","following_url":"https://api.github.com/users/thomreis/following{/other_user}","gists_url":"https://api.github.com/users/thomreis/gists{/gist_id}","starred_url":"https://api.github.com/users/thomreis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomreis/subscriptions","organizations_url":"https://api.github.com/users/thomreis/orgs","repos_url":"https://api.github.com/users/thomreis/repos","events_url":"https://api.github.com/users/thomreis/events{/privacy}","received_events_url":"https://api.github.com/users/thomreis/received_events","type":"User","site_admin":false},"body":"The filling of the y axis value is wrong. You have to fill the bin number not the algo bit.\r\n`unprescaled_first_collision_run_->Fill(ibx, algo+1);`","created_at":"2018-04-10T17:32:23Z","updated_at":"2018-04-10T17:40:06Z","html_url":"https://github.com/cms-sw/cmssw/pull/22524#discussion_r180506255","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22524","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/180506255"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/22524#discussion_r180506255"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22524"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22524","id":173686394,"html_url":"https://github.com/cms-sw/cmssw/pull/22524","diff_url":"https://github.com/cms-sw/cmssw/pull/22524.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22524.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22524","number":22524,"state":"open","locked":false,"title":"L1TObjects Ratio Timing Plots - L1T & Online DQM - CMSSW - 102X","user":{"login":"dtsitson","id":22170473,"avatar_url":"https://avatars2.githubusercontent.com/u/22170473?v=4","gravatar_id":"","url":"https://api.github.com/users/dtsitson","html_url":"https://github.com/dtsitson","followers_url":"https://api.github.com/users/dtsitson/followers","following_url":"https://api.github.com/users/dtsitson/following{/other_user}","gists_url":"https://api.github.com/users/dtsitson/gists{/gist_id}","starred_url":"https://api.github.com/users/dtsitson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtsitson/subscriptions","organizations_url":"https://api.github.com/users/dtsitson/orgs","repos_url":"https://api.github.com/users/dtsitson/repos","events_url":"https://api.github.com/users/dtsitson/events{/privacy}","received_events_url":"https://api.github.com/users/dtsitson/received_events","type":"User","site_admin":false},"body":"My task in JIRA is : [Timing Plot Improvements](https://its.cern.ch/jira/browse/CMSLITDPG-465)\r\n\r\nThe whole work is to produce ratio timing plots for any L1T Objects for each BX for first,isolated and last bunch. After I added numerators and denominators to L1TObjectsTiming module, I made a new module for inserting ratio plots in the DQM/L1TMonitorClient directory L1TObjectsTimingClient_cff and I modified the L1TStage2MonitorClient_cff module in order to produce ratio plots.","created_at":"2018-03-08T09:36:16Z","updated_at":"2018-04-10T17:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e4a2033e41e14d7f85ee87baa2b6032d590c8b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":52882241,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-approved","name":"dqm-approved","color":"2cbe4e","default":false},{"id":53149121,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fully-signed","name":"fully-signed","color":"2cbe4e","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":112,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-04-10T16:49:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22524/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22524/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22524/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/5f99d244ea6a875721ffaf65b86364defd8be5a3","head":{"label":"dtsitson:DQM-101X","ref":"DQM-101X","sha":"5f99d244ea6a875721ffaf65b86364defd8be5a3","user":{"login":"dtsitson","id":22170473,"avatar_url":"https://avatars2.githubusercontent.com/u/22170473?v=4","gravatar_id":"","url":"https://api.github.com/users/dtsitson","html_url":"https://github.com/dtsitson","followers_url":"https://api.github.com/users/dtsitson/followers","following_url":"https://api.github.com/users/dtsitson/following{/other_user}","gists_url":"https://api.github.com/users/dtsitson/gists{/gist_id}","starred_url":"https://api.github.com/users/dtsitson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtsitson/subscriptions","organizations_url":"https://api.github.com/users/dtsitson/orgs","repos_url":"https://api.github.com/users/dtsitson/repos","events_url":"https://api.github.com/users/dtsitson/events{/privacy}","received_events_url":"https://api.github.com/users/dtsitson/received_events","type":"User","site_admin":false},"repo":{"id":107387048,"name":"cmssw","full_name":"dtsitson/cmssw","owner":{"login":"dtsitson","id":22170473,"avatar_url":"https://avatars2.githubusercontent.com/u/22170473?v=4","gravatar_id":"","url":"https://api.github.com/users/dtsitson","html_url":"https://github.com/dtsitson","followers_url":"https://api.github.com/users/dtsitson/followers","following_url":"https://api.github.com/users/dtsitson/following{/other_user}","gists_url":"https://api.github.com/users/dtsitson/gists{/gist_id}","starred_url":"https://api.github.com/users/dtsitson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtsitson/subscriptions","organizations_url":"https://api.github.com/users/dtsitson/orgs","repos_url":"https://api.github.com/users/dtsitson/repos","events_url":"https://api.github.com/users/dtsitson/events{/privacy}","received_events_url":"https://api.github.com/users/dtsitson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtsitson/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/dtsitson/cmssw","forks_url":"https://api.github.com/repos/dtsitson/cmssw/forks","keys_url":"https://api.github.com/repos/dtsitson/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtsitson/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtsitson/cmssw/teams","hooks_url":"https://api.github.com/repos/dtsitson/cmssw/hooks","issue_events_url":"https://api.github.com/repos/dtsitson/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/dtsitson/cmssw/events","assignees_url":"https://api.github.com/repos/dtsitson/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/dtsitson/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/dtsitson/cmssw/tags","blobs_url":"https://api.github.com/repos/dtsitson/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtsitson/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtsitson/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtsitson/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtsitson/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/dtsitson/cmssw/languages","stargazers_url":"https://api.github.com/repos/dtsitson/cmssw/stargazers","contributors_url":"https://api.github.com/repos/dtsitson/cmssw/contributors","subscribers_url":"https://api.github.com/repos/dtsitson/cmssw/subscribers","subscription_url":"https://api.github.com/repos/dtsitson/cmssw/subscription","commits_url":"https://api.github.com/repos/dtsitson/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtsitson/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtsitson/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtsitson/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtsitson/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/dtsitson/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtsitson/cmssw/merges","archive_url":"https://api.github.com/repos/dtsitson/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtsitson/cmssw/downloads","issues_url":"https://api.github.com/repos/dtsitson/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/dtsitson/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/dtsitson/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/dtsitson/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtsitson/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/dtsitson/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/dtsitson/cmssw/deployments","created_at":"2017-10-18T09:31:21Z","updated_at":"2017-10-18T09:34:29Z","pushed_at":"2018-04-08T13:26:24Z","git_url":"git://github.com/dtsitson/cmssw.git","ssh_url":"git@github.com:dtsitson/cmssw.git","clone_url":"https://github.com/dtsitson/cmssw.git","svn_url":"https://github.com/dtsitson/cmssw","homepage":"http://cms-sw.github.io/","size":994823,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"d76e3038624c3f0a41747adbab5ae6101e4aa095","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-04-10T09:49:30Z","pushed_at":"2018-04-10T17:03:04Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":998127,"stargazers_count":537,"watchers_count":537,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2527,"mirror_url":null,"archived":false,"open_issues_count":467,"license":null,"forks":2527,"open_issues":467,"watchers":537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22524"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/22524"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/22524"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/22524/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22524/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22524/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/5f99d244ea6a875721ffaf65b86364defd8be5a3"}},"author_association":"NONE"}}
{"actor":{"display_login":"thomreis"}}