{"action":"created","comment":{"url":"https://api.github.com/repos/derekparker/delve/pulls/comments/169425434","pull_request_review_id":97949918,"id":169425434,"diff_hunk":"@@ -60,8 +60,11 @@ func LoadConfig() *Config {\n \n \tf, err := os.Open(fullConfigFile)\n \tif err != nil {\n-\t\tcreateDefaultConfig(fullConfigFile)\n-\t\treturn nil\n+\t\tf, err = createDefaultConfig(fullConfigFile)","path":"pkg/config/config.go","position":6,"original_position":6,"commit_id":"6e61a09187a3c1aabaa8e7675eb4e8203cae59d1","original_commit_id":"6e61a09187a3c1aabaa8e7675eb4e8203cae59d1","user":{"login":"aarzilli","id":303620,"avatar_url":"https://avatars2.githubusercontent.com/u/303620?v=4","gravatar_id":"","url":"https://api.github.com/users/aarzilli","html_url":"https://github.com/aarzilli","followers_url":"https://api.github.com/users/aarzilli/followers","following_url":"https://api.github.com/users/aarzilli/following{/other_user}","gists_url":"https://api.github.com/users/aarzilli/gists{/gist_id}","starred_url":"https://api.github.com/users/aarzilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarzilli/subscriptions","organizations_url":"https://api.github.com/users/aarzilli/orgs","repos_url":"https://api.github.com/users/aarzilli/repos","events_url":"https://api.github.com/users/aarzilli/events{/privacy}","received_events_url":"https://api.github.com/users/aarzilli/received_events","type":"User","site_admin":false},"body":"the handle returned by createDefaultConfig is open for writing, but here we'll try to read it, how does this work?","created_at":"2018-02-20T19:05:11Z","updated_at":"2018-02-20T19:06:50Z","html_url":"https://github.com/derekparker/delve/pull/1130#discussion_r169425434","pull_request_url":"https://api.github.com/repos/derekparker/delve/pulls/1130","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/derekparker/delve/pulls/comments/169425434"},"html":{"href":"https://github.com/derekparker/delve/pull/1130#discussion_r169425434"},"pull_request":{"href":"https://api.github.com/repos/derekparker/delve/pulls/1130"}}},"pull_request":{"url":"https://api.github.com/repos/derekparker/delve/pulls/1130","id":170263767,"html_url":"https://github.com/derekparker/delve/pull/1130","diff_url":"https://github.com/derekparker/delve/pull/1130.diff","patch_url":"https://github.com/derekparker/delve/pull/1130.patch","issue_url":"https://api.github.com/repos/derekparker/delve/issues/1130","number":1130,"state":"open","locked":false,"title":"config: Return handle for created default config","user":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars0.githubusercontent.com/u/1314079?v=4","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"body":"Previously the file handle for the newly created default config was\r\nbeing closed and thrown away as opposed to returned to the caller to\r\nfinish setting up config for the rest of the process. This patch changes\r\nto return a handle to the newly created config so setup can happen as\r\nnormal. This fixes a bug where Delve can crash on first run when a\r\nconfig is not present on the system.\r\n\r\nFixes #1129","created_at":"2018-02-20T17:50:37Z","updated_at":"2018-02-20T19:06:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"817d9b44b0d6ec78557864100fc77bddbdeea93a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/derekparker/delve/pulls/1130/commits","review_comments_url":"https://api.github.com/repos/derekparker/delve/pulls/1130/comments","review_comment_url":"https://api.github.com/repos/derekparker/delve/pulls/comments{/number}","comments_url":"https://api.github.com/repos/derekparker/delve/issues/1130/comments","statuses_url":"https://api.github.com/repos/derekparker/delve/statuses/6e61a09187a3c1aabaa8e7675eb4e8203cae59d1","head":{"label":"derekparker:fix-default-config-creation","ref":"fix-default-config-creation","sha":"6e61a09187a3c1aabaa8e7675eb4e8203cae59d1","user":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars0.githubusercontent.com/u/1314079?v=4","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"repo":{"id":19994257,"name":"delve","full_name":"derekparker/delve","owner":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars0.githubusercontent.com/u/1314079?v=4","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derekparker/delve","description":"Delve is a debugger for the Go programming language.","fork":false,"url":"https://api.github.com/repos/derekparker/delve","forks_url":"https://api.github.com/repos/derekparker/delve/forks","keys_url":"https://api.github.com/repos/derekparker/delve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekparker/delve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekparker/delve/teams","hooks_url":"https://api.github.com/repos/derekparker/delve/hooks","issue_events_url":"https://api.github.com/repos/derekparker/delve/issues/events{/number}","events_url":"https://api.github.com/repos/derekparker/delve/events","assignees_url":"https://api.github.com/repos/derekparker/delve/assignees{/user}","branches_url":"https://api.github.com/repos/derekparker/delve/branches{/branch}","tags_url":"https://api.github.com/repos/derekparker/delve/tags","blobs_url":"https://api.github.com/repos/derekparker/delve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekparker/delve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekparker/delve/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekparker/delve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekparker/delve/statuses/{sha}","languages_url":"https://api.github.com/repos/derekparker/delve/languages","stargazers_url":"https://api.github.com/repos/derekparker/delve/stargazers","contributors_url":"https://api.github.com/repos/derekparker/delve/contributors","subscribers_url":"https://api.github.com/repos/derekparker/delve/subscribers","subscription_url":"https://api.github.com/repos/derekparker/delve/subscription","commits_url":"https://api.github.com/repos/derekparker/delve/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekparker/delve/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekparker/delve/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekparker/delve/issues/comments{/number}","contents_url":"https://api.github.com/repos/derekparker/delve/contents/{+path}","compare_url":"https://api.github.com/repos/derekparker/delve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekparker/delve/merges","archive_url":"https://api.github.com/repos/derekparker/delve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekparker/delve/downloads","issues_url":"https://api.github.com/repos/derekparker/delve/issues{/number}","pulls_url":"https://api.github.com/repos/derekparker/delve/pulls{/number}","milestones_url":"https://api.github.com/repos/derekparker/delve/milestones{/number}","notifications_url":"https://api.github.com/repos/derekparker/delve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekparker/delve/labels{/name}","releases_url":"https://api.github.com/repos/derekparker/delve/releases{/id}","deployments_url":"https://api.github.com/repos/derekparker/delve/deployments","created_at":"2014-05-20T19:24:43Z","updated_at":"2018-02-20T17:08:25Z","pushed_at":"2018-02-20T18:35:32Z","git_url":"git://github.com/derekparker/delve.git","ssh_url":"git@github.com:derekparker/delve.git","clone_url":"https://github.com/derekparker/delve.git","svn_url":"https://github.com/derekparker/delve","homepage":"","size":13072,"stargazers_count":7415,"watchers_count":7415,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":565,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":565,"open_issues":109,"watchers":7415,"default_branch":"master"}},"base":{"label":"derekparker:master","ref":"master","sha":"279a8a792e2748ba07be9ca15688d1871c0f1a5f","user":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars0.githubusercontent.com/u/1314079?v=4","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"repo":{"id":19994257,"name":"delve","full_name":"derekparker/delve","owner":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars0.githubusercontent.com/u/1314079?v=4","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derekparker/delve","description":"Delve is a debugger for the Go programming language.","fork":false,"url":"https://api.github.com/repos/derekparker/delve","forks_url":"https://api.github.com/repos/derekparker/delve/forks","keys_url":"https://api.github.com/repos/derekparker/delve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekparker/delve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekparker/delve/teams","hooks_url":"https://api.github.com/repos/derekparker/delve/hooks","issue_events_url":"https://api.github.com/repos/derekparker/delve/issues/events{/number}","events_url":"https://api.github.com/repos/derekparker/delve/events","assignees_url":"https://api.github.com/repos/derekparker/delve/assignees{/user}","branches_url":"https://api.github.com/repos/derekparker/delve/branches{/branch}","tags_url":"https://api.github.com/repos/derekparker/delve/tags","blobs_url":"https://api.github.com/repos/derekparker/delve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekparker/delve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekparker/delve/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekparker/delve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekparker/delve/statuses/{sha}","languages_url":"https://api.github.com/repos/derekparker/delve/languages","stargazers_url":"https://api.github.com/repos/derekparker/delve/stargazers","contributors_url":"https://api.github.com/repos/derekparker/delve/contributors","subscribers_url":"https://api.github.com/repos/derekparker/delve/subscribers","subscription_url":"https://api.github.com/repos/derekparker/delve/subscription","commits_url":"https://api.github.com/repos/derekparker/delve/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekparker/delve/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekparker/delve/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekparker/delve/issues/comments{/number}","contents_url":"https://api.github.com/repos/derekparker/delve/contents/{+path}","compare_url":"https://api.github.com/repos/derekparker/delve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekparker/delve/merges","archive_url":"https://api.github.com/repos/derekparker/delve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekparker/delve/downloads","issues_url":"https://api.github.com/repos/derekparker/delve/issues{/number}","pulls_url":"https://api.github.com/repos/derekparker/delve/pulls{/number}","milestones_url":"https://api.github.com/repos/derekparker/delve/milestones{/number}","notifications_url":"https://api.github.com/repos/derekparker/delve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekparker/delve/labels{/name}","releases_url":"https://api.github.com/repos/derekparker/delve/releases{/id}","deployments_url":"https://api.github.com/repos/derekparker/delve/deployments","created_at":"2014-05-20T19:24:43Z","updated_at":"2018-02-20T17:08:25Z","pushed_at":"2018-02-20T18:35:32Z","git_url":"git://github.com/derekparker/delve.git","ssh_url":"git@github.com:derekparker/delve.git","clone_url":"https://github.com/derekparker/delve.git","svn_url":"https://github.com/derekparker/delve","homepage":"","size":13072,"stargazers_count":7415,"watchers_count":7415,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":565,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":565,"open_issues":109,"watchers":7415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/derekparker/delve/pulls/1130"},"html":{"href":"https://github.com/derekparker/delve/pull/1130"},"issue":{"href":"https://api.github.com/repos/derekparker/delve/issues/1130"},"comments":{"href":"https://api.github.com/repos/derekparker/delve/issues/1130/comments"},"review_comments":{"href":"https://api.github.com/repos/derekparker/delve/pulls/1130/comments"},"review_comment":{"href":"https://api.github.com/repos/derekparker/delve/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/derekparker/delve/pulls/1130/commits"},"statuses":{"href":"https://api.github.com/repos/derekparker/delve/statuses/6e61a09187a3c1aabaa8e7675eb4e8203cae59d1"}},"author_association":"OWNER"}}
{"actor":{"display_login":"aarzilli"}}