{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/196233266","pull_request_review_id":129746520,"id":196233266,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjIzMzI2Ng==","diff_hunk":"@@ -0,0 +1,156 @@\n+# Install CNI-Genie plugin on each slave node.\n+kind: DaemonSet\n+apiVersion: extensions/v1beta1\n+metadata:\n+  name: genie-plugin\n+  namespace: kube-system\n+  labels:\n+    k8s-app: genie\n+spec:\n+  selector:\n+    matchLabels:\n+      k8s-app: genie\n+  template:\n+    metadata:\n+      labels:\n+        k8s-app: genie\n+      annotations:\n+        scheduler.alpha.kubernetes.io/critical-pod: ''\n+        scheduler.alpha.kubernetes.io/tolerations: |\n+          [\n+            {\n+              \"key\": \"dedicated\",\n+              \"value\": \"master\",\n+              \"effect\": \"NoSchedule\"\n+            },\n+            {\n+              \"key\": \"CriticalAddonsOnly\",\n+              \"operator\": \"Exists\"\n+            }\n+          ]\n+    spec:\n+      hostNetwork: true\n+      hostPID: true\n+      serviceAccountName: genie-plugin\n+      containers:\n+        # Create a container with install.sh that\n+        # Installs required 00-genie.conf and genie binary\n+        # on slave node.\n+        - name: install-cni\n+          image: quay.io/huawei-cni-genie/genie-plugin:latest\n+          imagePullPolicy: {{.Values.imagePullPolicy }}\n+          command: [\"/launch.sh\"]\n+          env:\n+            - name: CNI_NETWORK_CONFIG\n+              valueFrom:\n+                configMapKeyRef:\n+                  name: genie-config\n+                  key: cni_genie_network_config\n+            - name: KUBERNETES_NODE_NAME\n+              valueFrom:\n+                fieldRef:\n+                  fieldPath: spec.nodeName\n+          volumeMounts:\n+            - mountPath: /host/opt/cni/bin\n+              name: cni-bin-dir\n+            - mountPath: /host/etc/cni/net.d\n+              name: cni-net-dir\n+      volumes:\n+        - name: cni-bin-dir\n+          hostPath:\n+            path: /opt/cni/bin\n+        - name: cni-net-dir\n+          hostPath:\n+            path: /etc/cni/net.d\n+---\n+# Genie network admission controller daemonset configuration\n+# Genie network admission controller pods will run only in master nodes\n+apiVersion: extensions/v1beta1\n+kind: DaemonSet\n+metadata:\n+  name: genie-network-admission-controller\n+  namespace: kube-system\n+spec:\n+  template:\n+    metadata:\n+      labels:\n+        role: genie-network-admission-controller\n+      annotations:\n+        scheduler.alpha.kubernetes.io/critical-pod: ''\n+    spec:\n+      tolerations:\n+        - key: node-role.kubernetes.io/master\n+          effect: NoSchedule\n+        - key: CriticalAddonsOnly\n+          operator: Exists\n+      nodeSelector:\n+        node-role.kubernetes.io/master: \"\"\n+      hostNetwork: true\n+      serviceAccountName: genie-plugin\n+      containers:\n+        - name: genie-network-admission-controller\n+          image: quay.io/huawei-cni-genie/genie-admission-controller:latest\n+          imagePullPolicy: {{.Values.imagePullPolicy }}\n+          ports:\n+            - containerPort: 8000","path":"stable/cni-genie/templates/daemonSet.yaml","position":95,"original_position":95,"commit_id":"847a3cc974136aba8f0c2f0916533c617f237cf5","original_commit_id":"847a3cc974136aba8f0c2f0916533c617f237cf5","user":{"login":"dhilipkumars","id":10920260,"node_id":"MDQ6VXNlcjEwOTIwMjYw","avatar_url":"https://avatars3.githubusercontent.com/u/10920260?v=4","gravatar_id":"","url":"https://api.github.com/users/dhilipkumars","html_url":"https://github.com/dhilipkumars","followers_url":"https://api.github.com/users/dhilipkumars/followers","following_url":"https://api.github.com/users/dhilipkumars/following{/other_user}","gists_url":"https://api.github.com/users/dhilipkumars/gists{/gist_id}","starred_url":"https://api.github.com/users/dhilipkumars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhilipkumars/subscriptions","organizations_url":"https://api.github.com/users/dhilipkumars/orgs","repos_url":"https://api.github.com/users/dhilipkumars/repos","events_url":"https://api.github.com/users/dhilipkumars/events{/privacy}","received_events_url":"https://api.github.com/users/dhilipkumars/received_events","type":"User","site_admin":false},"body":"could we make this configurable? ","created_at":"2018-06-18T21:34:57Z","updated_at":"2018-06-18T21:49:50Z","html_url":"https://github.com/kubernetes/charts/pull/5968#discussion_r196233266","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/5968","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/196233266"},"html":{"href":"https://github.com/kubernetes/charts/pull/5968#discussion_r196233266"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5968"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/5968","id":193028142,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDI4MTQy","html_url":"https://github.com/kubernetes/charts/pull/5968","diff_url":"https://github.com/kubernetes/charts/pull/5968.diff","patch_url":"https://github.com/kubernetes/charts/pull/5968.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/5968","number":5968,"state":"open","locked":false,"title":"[WIP] Addition of chart for cni genie deployment","user":{"login":"sushanthakumar","id":30930862,"node_id":"MDQ6VXNlcjMwOTMwODYy","avatar_url":"https://avatars1.githubusercontent.com/u/30930862?v=4","gravatar_id":"","url":"https://api.github.com/users/sushanthakumar","html_url":"https://github.com/sushanthakumar","followers_url":"https://api.github.com/users/sushanthakumar/followers","following_url":"https://api.github.com/users/sushanthakumar/following{/other_user}","gists_url":"https://api.github.com/users/sushanthakumar/gists{/gist_id}","starred_url":"https://api.github.com/users/sushanthakumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushanthakumar/subscriptions","organizations_url":"https://api.github.com/users/sushanthakumar/orgs","repos_url":"https://api.github.com/users/sushanthakumar/repos","events_url":"https://api.github.com/users/sushanthakumar/events{/privacy}","received_events_url":"https://api.github.com/users/sushanthakumar/received_events","type":"User","site_admin":false},"body":"\r\n**What this PR does / why we need it**: This PR includes the chart for CNI Genie deployment on kubernetes. It is plugin which does multi-networking provisioning for pods\r\n\r\n**Which issue this PR fixes** : NA\r\n\r\n**Special notes for your reviewer**: NA\r\n","created_at":"2018-06-06T14:14:14Z","updated_at":"2018-06-18T21:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2860d64e00523203f25cfde6e3563924494ef01","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":705929182,"node_id":"MDU6TGFiZWw3MDU5MjkxODI=","url":"https://api.github.com/repos/kubernetes/charts/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":582594847,"node_id":"MDU6TGFiZWw1ODI1OTQ4NDc=","url":"https://api.github.com/repos/kubernetes/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":676596499,"node_id":"MDU6TGFiZWw2NzY1OTY0OTk=","url":"https://api.github.com/repos/kubernetes/charts/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/5968/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/5968/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/5968/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/847a3cc974136aba8f0c2f0916533c617f237cf5","head":{"label":"sushanthakumar:cni-genie-chart","ref":"cni-genie-chart","sha":"847a3cc974136aba8f0c2f0916533c617f237cf5","user":{"login":"sushanthakumar","id":30930862,"node_id":"MDQ6VXNlcjMwOTMwODYy","avatar_url":"https://avatars1.githubusercontent.com/u/30930862?v=4","gravatar_id":"","url":"https://api.github.com/users/sushanthakumar","html_url":"https://github.com/sushanthakumar","followers_url":"https://api.github.com/users/sushanthakumar/followers","following_url":"https://api.github.com/users/sushanthakumar/following{/other_user}","gists_url":"https://api.github.com/users/sushanthakumar/gists{/gist_id}","starred_url":"https://api.github.com/users/sushanthakumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushanthakumar/subscriptions","organizations_url":"https://api.github.com/users/sushanthakumar/orgs","repos_url":"https://api.github.com/users/sushanthakumar/repos","events_url":"https://api.github.com/users/sushanthakumar/events{/privacy}","received_events_url":"https://api.github.com/users/sushanthakumar/received_events","type":"User","site_admin":false},"repo":{"id":136335362,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzMzUzNjI=","name":"charts","full_name":"sushanthakumar/charts","owner":{"login":"sushanthakumar","id":30930862,"node_id":"MDQ6VXNlcjMwOTMwODYy","avatar_url":"https://avatars1.githubusercontent.com/u/30930862?v=4","gravatar_id":"","url":"https://api.github.com/users/sushanthakumar","html_url":"https://github.com/sushanthakumar","followers_url":"https://api.github.com/users/sushanthakumar/followers","following_url":"https://api.github.com/users/sushanthakumar/following{/other_user}","gists_url":"https://api.github.com/users/sushanthakumar/gists{/gist_id}","starred_url":"https://api.github.com/users/sushanthakumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushanthakumar/subscriptions","organizations_url":"https://api.github.com/users/sushanthakumar/orgs","repos_url":"https://api.github.com/users/sushanthakumar/repos","events_url":"https://api.github.com/users/sushanthakumar/events{/privacy}","received_events_url":"https://api.github.com/users/sushanthakumar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sushanthakumar/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/sushanthakumar/charts","forks_url":"https://api.github.com/repos/sushanthakumar/charts/forks","keys_url":"https://api.github.com/repos/sushanthakumar/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sushanthakumar/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sushanthakumar/charts/teams","hooks_url":"https://api.github.com/repos/sushanthakumar/charts/hooks","issue_events_url":"https://api.github.com/repos/sushanthakumar/charts/issues/events{/number}","events_url":"https://api.github.com/repos/sushanthakumar/charts/events","assignees_url":"https://api.github.com/repos/sushanthakumar/charts/assignees{/user}","branches_url":"https://api.github.com/repos/sushanthakumar/charts/branches{/branch}","tags_url":"https://api.github.com/repos/sushanthakumar/charts/tags","blobs_url":"https://api.github.com/repos/sushanthakumar/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sushanthakumar/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sushanthakumar/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/sushanthakumar/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sushanthakumar/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/sushanthakumar/charts/languages","stargazers_url":"https://api.github.com/repos/sushanthakumar/charts/stargazers","contributors_url":"https://api.github.com/repos/sushanthakumar/charts/contributors","subscribers_url":"https://api.github.com/repos/sushanthakumar/charts/subscribers","subscription_url":"https://api.github.com/repos/sushanthakumar/charts/subscription","commits_url":"https://api.github.com/repos/sushanthakumar/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/sushanthakumar/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/sushanthakumar/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/sushanthakumar/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/sushanthakumar/charts/contents/{+path}","compare_url":"https://api.github.com/repos/sushanthakumar/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sushanthakumar/charts/merges","archive_url":"https://api.github.com/repos/sushanthakumar/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sushanthakumar/charts/downloads","issues_url":"https://api.github.com/repos/sushanthakumar/charts/issues{/number}","pulls_url":"https://api.github.com/repos/sushanthakumar/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/sushanthakumar/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/sushanthakumar/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sushanthakumar/charts/labels{/name}","releases_url":"https://api.github.com/repos/sushanthakumar/charts/releases{/id}","deployments_url":"https://api.github.com/repos/sushanthakumar/charts/deployments","created_at":"2018-06-06T13:49:20Z","updated_at":"2018-06-06T13:49:25Z","pushed_at":"2018-06-07T10:26:46Z","git_url":"git://github.com/sushanthakumar/charts.git","ssh_url":"git@github.com:sushanthakumar/charts.git","clone_url":"https://github.com/sushanthakumar/charts.git","svn_url":"https://github.com/sushanthakumar/charts","homepage":"","size":7901,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"20e3f9d6d4637d7ac96d616bd89281838fcb7e92","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-06-18T21:02:19Z","pushed_at":"2018-06-18T21:23:12Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":8514,"stargazers_count":3518,"watchers_count":3518,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3024,"mirror_url":null,"archived":false,"open_issues_count":686,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3024,"open_issues":686,"watchers":3518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5968"},"html":{"href":"https://github.com/kubernetes/charts/pull/5968"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/5968"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/5968/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5968/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5968/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/847a3cc974136aba8f0c2f0916533c617f237cf5"}},"author_association":"NONE"}}
{"actor":{"display_login":"dhilipkumars"}}