{"action":"created","comment":{"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/comments/178855148","pull_request_review_id":108985917,"id":178855148,"diff_hunk":"@@ -156,15 +156,21 @@ if (WITH_CUDA)\n     cuda/cuda_compilation_cache.cc\n     cuda/cuda_rtc.cc\n     cuda/cuda_tc_executor.cc\n+    cuda/cuda_profile.cc\n   )\n   target_include_directories(tc_cuda PUBLIC ${PROJECT_SOURCE_DIR}/include ${LLVM_INCLUDE_DIRS})\n+  target_include_directories(tc_cuda PUBLIC \n+      ${PROJECT_SOURCE_DIR}/include\n+      ${LLVM_INCLUDE_DIRS} \n+      ${CUDA_TOOLKIT_ROOT_DIR}/extras/CUPTI/include)\n   target_link_libraries(\n     tc_cuda\n \n     ${CUDA_CUDA_LIBRARIES}\n     ${CUDA_curand_LIBRARY}\n     ${CUDA_LIBRARIES}\n     ${CUDA_NVRTC_LIBRARIES}\n+    ${CUDA_cupti_LIBRARY}","path":"src/core/CMakeLists.txt","position":18,"original_position":18,"commit_id":"cf16bf2422ccd336dc98cc832dc6ac5598a21782","original_commit_id":"4c97aed95427af5c079f3cdb153944e1cbb3d737","user":{"login":"skimo-openhub","id":17313619,"avatar_url":"https://avatars1.githubusercontent.com/u/17313619?v=4","gravatar_id":"","url":"https://api.github.com/users/skimo-openhub","html_url":"https://github.com/skimo-openhub","followers_url":"https://api.github.com/users/skimo-openhub/followers","following_url":"https://api.github.com/users/skimo-openhub/following{/other_user}","gists_url":"https://api.github.com/users/skimo-openhub/gists{/gist_id}","starred_url":"https://api.github.com/users/skimo-openhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skimo-openhub/subscriptions","organizations_url":"https://api.github.com/users/skimo-openhub/orgs","repos_url":"https://api.github.com/users/skimo-openhub/repos","events_url":"https://api.github.com/users/skimo-openhub/events{/privacy}","received_events_url":"https://api.github.com/users/skimo-openhub/received_events","type":"User","site_admin":false},"body":"`CUDA_cupti_LIBRARY` doesn't seem to be defined anywhere.\r\n\r\nI get\r\n```\r\nCMake Error: The following variables are used in this project, but they are set to NOTFOUND.\r\nPlease set them or make sure they are set and tested correctly in the CMake files:\r\nCUDA_cupti_LIBRARY (ADVANCED)\r\n    linked by target \"tc_cuda\" in directory /home/skimo/git/c2isl/src/core\r\n```","created_at":"2018-04-03T14:59:57Z","updated_at":"2018-04-03T14:59:58Z","html_url":"https://github.com/facebookresearch/TensorComprehensions/pull/198#discussion_r178855148","pull_request_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/198","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/comments/178855148"},"html":{"href":"https://github.com/facebookresearch/TensorComprehensions/pull/198#discussion_r178855148"},"pull_request":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/198","id":177086592,"html_url":"https://github.com/facebookresearch/TensorComprehensions/pull/198","diff_url":"https://github.com/facebookresearch/TensorComprehensions/pull/198.diff","patch_url":"https://github.com/facebookresearch/TensorComprehensions/pull/198.patch","issue_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/198","number":198,"state":"open","locked":false,"title":"Cuda Performance Metrics/Profiling","user":{"login":"ttheodor","id":2536003,"avatar_url":"https://avatars0.githubusercontent.com/u/2536003?v=4","gravatar_id":"","url":"https://api.github.com/users/ttheodor","html_url":"https://github.com/ttheodor","followers_url":"https://api.github.com/users/ttheodor/followers","following_url":"https://api.github.com/users/ttheodor/following{/other_user}","gists_url":"https://api.github.com/users/ttheodor/gists{/gist_id}","starred_url":"https://api.github.com/users/ttheodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttheodor/subscriptions","organizations_url":"https://api.github.com/users/ttheodor/orgs","repos_url":"https://api.github.com/users/ttheodor/repos","events_url":"https://api.github.com/users/ttheodor/events{/privacy}","received_events_url":"https://api.github.com/users/ttheodor/received_events","type":"User","site_admin":false},"body":"Add CUPTI-based profiling functionality in `CudaRTCFun`. \r\n\r\nThere are several performance metrics (listed [here](http://docs.nvidia.com/cuda/cupti/r_main.html#metrics-reference). Each metric requires measuring (possibly multiple types of) hardware events. Since not all events can be measured at the same time, a kernel must be launched multiple times (it's 12 times with the current list of hardcoded metrics). ","created_at":"2018-03-23T14:30:19Z","updated_at":"2018-04-03T14:59:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c17a2185d8baa5f5ce4ac40aff05961fc9f215c4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ftynse","id":1512299,"avatar_url":"https://avatars1.githubusercontent.com/u/1512299?v=4","gravatar_id":"","url":"https://api.github.com/users/ftynse","html_url":"https://github.com/ftynse","followers_url":"https://api.github.com/users/ftynse/followers","following_url":"https://api.github.com/users/ftynse/following{/other_user}","gists_url":"https://api.github.com/users/ftynse/gists{/gist_id}","starred_url":"https://api.github.com/users/ftynse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftynse/subscriptions","organizations_url":"https://api.github.com/users/ftynse/orgs","repos_url":"https://api.github.com/users/ftynse/repos","events_url":"https://api.github.com/users/ftynse/events{/privacy}","received_events_url":"https://api.github.com/users/ftynse/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":829008246,"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/labels/CLA%20Signed","name":"CLA Signed","color":"c2f4fc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/198/commits","review_comments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/198/comments","review_comment_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/198/comments","statuses_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/statuses/cf16bf2422ccd336dc98cc832dc6ac5598a21782","head":{"label":"facebookresearch:cupti","ref":"cupti","sha":"cf16bf2422ccd336dc98cc832dc6ac5598a21782","user":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":120494252,"name":"TensorComprehensions","full_name":"facebookresearch/TensorComprehensions","owner":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/TensorComprehensions","description":"A domain specific language to express machine learning workloads.","fork":false,"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions","forks_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/forks","keys_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/teams","hooks_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/events","assignees_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/tags","blobs_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/subscription","commits_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/merges","archive_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/downloads","issues_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/deployments","created_at":"2018-02-06T17:11:07Z","updated_at":"2018-04-03T13:55:16Z","pushed_at":"2018-04-03T14:55:38Z","git_url":"git://github.com/facebookresearch/TensorComprehensions.git","ssh_url":"git@github.com:facebookresearch/TensorComprehensions.git","clone_url":"https://github.com/facebookresearch/TensorComprehensions.git","svn_url":"https://github.com/facebookresearch/TensorComprehensions","homepage":"https://facebookresearch.github.io/TensorComprehensions/","size":31071,"stargazers_count":1035,"watchers_count":1035,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":79,"open_issues":61,"watchers":1035,"default_branch":"master"}},"base":{"label":"facebookresearch:master","ref":"master","sha":"f418bfa55cdf5d08b58854881e5bd0cdb03d4f34","user":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":120494252,"name":"TensorComprehensions","full_name":"facebookresearch/TensorComprehensions","owner":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/TensorComprehensions","description":"A domain specific language to express machine learning workloads.","fork":false,"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions","forks_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/forks","keys_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/teams","hooks_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/events","assignees_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/tags","blobs_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/subscription","commits_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/merges","archive_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/downloads","issues_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/deployments","created_at":"2018-02-06T17:11:07Z","updated_at":"2018-04-03T13:55:16Z","pushed_at":"2018-04-03T14:55:38Z","git_url":"git://github.com/facebookresearch/TensorComprehensions.git","ssh_url":"git@github.com:facebookresearch/TensorComprehensions.git","clone_url":"https://github.com/facebookresearch/TensorComprehensions.git","svn_url":"https://github.com/facebookresearch/TensorComprehensions","homepage":"https://facebookresearch.github.io/TensorComprehensions/","size":31071,"stargazers_count":1035,"watchers_count":1035,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":79,"open_issues":61,"watchers":1035,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/198"},"html":{"href":"https://github.com/facebookresearch/TensorComprehensions/pull/198"},"issue":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/198"},"comments":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/statuses/cf16bf2422ccd336dc98cc832dc6ac5598a21782"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"skimo-openhub"}}