{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/comments/222732411","pull_request_review_id":161687840,"id":222732411,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjczMjQxMQ==","diff_hunk":"@@ -503,8 +504,9 @@ fn serve<M: jsonrpc::Metadata, S: jsonrpc::Middleware<M>>(\n \n \t\t\tlet mut http = server::conn::Http::new();\n \t\t\thttp.keep_alive(keep_alive);\n+\t\t\tlet tcp_stream = SuspendableStream::new(listener.incoming(), Duration::from_secs(2));","path":"http/src/lib.rs","position":17,"original_position":17,"commit_id":"a786cb0340978f9b1a6bb18978045fe38b9c87e7","original_commit_id":"a786cb0340978f9b1a6bb18978045fe38b9c87e7","user":{"login":"tomusdrw","id":581548,"node_id":"MDQ6VXNlcjU4MTU0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/581548?v=4","gravatar_id":"","url":"https://api.github.com/users/tomusdrw","html_url":"https://github.com/tomusdrw","followers_url":"https://api.github.com/users/tomusdrw/followers","following_url":"https://api.github.com/users/tomusdrw/following{/other_user}","gists_url":"https://api.github.com/users/tomusdrw/gists{/gist_id}","starred_url":"https://api.github.com/users/tomusdrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomusdrw/subscriptions","organizations_url":"https://api.github.com/users/tomusdrw/orgs","repos_url":"https://api.github.com/users/tomusdrw/repos","events_url":"https://api.github.com/users/tomusdrw/events{/privacy}","received_events_url":"https://api.github.com/users/tomusdrw/received_events","type":"User","site_admin":false},"body":"2 seconds might be a bit too much. What do you think about making the delay exponential? I.e. with every delay followed by another failed attempt we multiply the delay by 2. Thanks to this we could start with some really low values (like 5-10ms and increase dynamically if there are no open files available).","created_at":"2018-10-04T16:06:47Z","updated_at":"2018-10-04T16:07:13Z","html_url":"https://github.com/paritytech/jsonrpc/pull/321#discussion_r222732411","pull_request_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/321","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/comments/222732411"},"html":{"href":"https://github.com/paritytech/jsonrpc/pull/321#discussion_r222732411"},"pull_request":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/321","id":220417625,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDE3NjI1","html_url":"https://github.com/paritytech/jsonrpc/pull/321","diff_url":"https://github.com/paritytech/jsonrpc/pull/321.diff","patch_url":"https://github.com/paritytech/jsonrpc/pull/321.patch","issue_url":"https://api.github.com/repos/paritytech/jsonrpc/issues/321","number":321,"state":"open","locked":false,"title":"Augmented tokio::net::Incoming with Suspendable stream","user":{"login":"seunlanlege","id":16494314,"node_id":"MDQ6VXNlcjE2NDk0MzE0","avatar_url":"https://avatars3.githubusercontent.com/u/16494314?v=4","gravatar_id":"","url":"https://api.github.com/users/seunlanlege","html_url":"https://github.com/seunlanlege","followers_url":"https://api.github.com/users/seunlanlege/followers","following_url":"https://api.github.com/users/seunlanlege/following{/other_user}","gists_url":"https://api.github.com/users/seunlanlege/gists{/gist_id}","starred_url":"https://api.github.com/users/seunlanlege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seunlanlege/subscriptions","organizations_url":"https://api.github.com/users/seunlanlege/orgs","repos_url":"https://api.github.com/users/seunlanlege/repos","events_url":"https://api.github.com/users/seunlanlege/events{/privacy}","received_events_url":"https://api.github.com/users/seunlanlege/received_events","type":"User","site_admin":false},"body":"fixes paritytech/parity-ethereum#9102","created_at":"2018-10-04T15:18:31Z","updated_at":"2018-10-04T16:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da55e424ecce25e994bc3a6d0ba8df4d3d391b3d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"NikVolf","id":3186518,"node_id":"MDQ6VXNlcjMxODY1MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3186518?v=4","gravatar_id":"","url":"https://api.github.com/users/NikVolf","html_url":"https://github.com/NikVolf","followers_url":"https://api.github.com/users/NikVolf/followers","following_url":"https://api.github.com/users/NikVolf/following{/other_user}","gists_url":"https://api.github.com/users/NikVolf/gists{/gist_id}","starred_url":"https://api.github.com/users/NikVolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikVolf/subscriptions","organizations_url":"https://api.github.com/users/NikVolf/orgs","repos_url":"https://api.github.com/users/NikVolf/repos","events_url":"https://api.github.com/users/NikVolf/events{/privacy}","received_events_url":"https://api.github.com/users/NikVolf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/321/commits","review_comments_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/321/comments","review_comment_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/jsonrpc/issues/321/comments","statuses_url":"https://api.github.com/repos/paritytech/jsonrpc/statuses/a786cb0340978f9b1a6bb18978045fe38b9c87e7","head":{"label":"paritytech:suspendable-stream","ref":"suspendable-stream","sha":"a786cb0340978f9b1a6bb18978045fe38b9c87e7","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":74377848,"node_id":"MDEwOlJlcG9zaXRvcnk3NDM3Nzg0OA==","name":"jsonrpc","full_name":"paritytech/jsonrpc","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/jsonrpc","description":"Rust JSON-RPC implementation","fork":false,"url":"https://api.github.com/repos/paritytech/jsonrpc","forks_url":"https://api.github.com/repos/paritytech/jsonrpc/forks","keys_url":"https://api.github.com/repos/paritytech/jsonrpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/jsonrpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/jsonrpc/teams","hooks_url":"https://api.github.com/repos/paritytech/jsonrpc/hooks","issue_events_url":"https://api.github.com/repos/paritytech/jsonrpc/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/jsonrpc/events","assignees_url":"https://api.github.com/repos/paritytech/jsonrpc/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/jsonrpc/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/jsonrpc/tags","blobs_url":"https://api.github.com/repos/paritytech/jsonrpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/jsonrpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/jsonrpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/jsonrpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/jsonrpc/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/jsonrpc/languages","stargazers_url":"https://api.github.com/repos/paritytech/jsonrpc/stargazers","contributors_url":"https://api.github.com/repos/paritytech/jsonrpc/contributors","subscribers_url":"https://api.github.com/repos/paritytech/jsonrpc/subscribers","subscription_url":"https://api.github.com/repos/paritytech/jsonrpc/subscription","commits_url":"https://api.github.com/repos/paritytech/jsonrpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/jsonrpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/jsonrpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/jsonrpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/jsonrpc/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/jsonrpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/jsonrpc/merges","archive_url":"https://api.github.com/repos/paritytech/jsonrpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/jsonrpc/downloads","issues_url":"https://api.github.com/repos/paritytech/jsonrpc/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/jsonrpc/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/jsonrpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/jsonrpc/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/jsonrpc/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/jsonrpc/deployments","created_at":"2016-11-21T15:32:15Z","updated_at":"2018-09-28T16:26:09Z","pushed_at":"2018-10-04T15:18:31Z","git_url":"git://github.com/paritytech/jsonrpc.git","ssh_url":"git@github.com:paritytech/jsonrpc.git","clone_url":"https://github.com/paritytech/jsonrpc.git","svn_url":"https://github.com/paritytech/jsonrpc","homepage":"","size":6039,"stargazers_count":150,"watchers_count":150,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":48,"open_issues":38,"watchers":150,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"867a8abde942ce7dc635b17d3b7b2f475c334a7f","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":74377848,"node_id":"MDEwOlJlcG9zaXRvcnk3NDM3Nzg0OA==","name":"jsonrpc","full_name":"paritytech/jsonrpc","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/jsonrpc","description":"Rust JSON-RPC implementation","fork":false,"url":"https://api.github.com/repos/paritytech/jsonrpc","forks_url":"https://api.github.com/repos/paritytech/jsonrpc/forks","keys_url":"https://api.github.com/repos/paritytech/jsonrpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/jsonrpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/jsonrpc/teams","hooks_url":"https://api.github.com/repos/paritytech/jsonrpc/hooks","issue_events_url":"https://api.github.com/repos/paritytech/jsonrpc/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/jsonrpc/events","assignees_url":"https://api.github.com/repos/paritytech/jsonrpc/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/jsonrpc/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/jsonrpc/tags","blobs_url":"https://api.github.com/repos/paritytech/jsonrpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/jsonrpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/jsonrpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/jsonrpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/jsonrpc/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/jsonrpc/languages","stargazers_url":"https://api.github.com/repos/paritytech/jsonrpc/stargazers","contributors_url":"https://api.github.com/repos/paritytech/jsonrpc/contributors","subscribers_url":"https://api.github.com/repos/paritytech/jsonrpc/subscribers","subscription_url":"https://api.github.com/repos/paritytech/jsonrpc/subscription","commits_url":"https://api.github.com/repos/paritytech/jsonrpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/jsonrpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/jsonrpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/jsonrpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/jsonrpc/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/jsonrpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/jsonrpc/merges","archive_url":"https://api.github.com/repos/paritytech/jsonrpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/jsonrpc/downloads","issues_url":"https://api.github.com/repos/paritytech/jsonrpc/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/jsonrpc/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/jsonrpc/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/jsonrpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/jsonrpc/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/jsonrpc/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/jsonrpc/deployments","created_at":"2016-11-21T15:32:15Z","updated_at":"2018-09-28T16:26:09Z","pushed_at":"2018-10-04T15:18:31Z","git_url":"git://github.com/paritytech/jsonrpc.git","ssh_url":"git@github.com:paritytech/jsonrpc.git","clone_url":"https://github.com/paritytech/jsonrpc.git","svn_url":"https://github.com/paritytech/jsonrpc","homepage":"","size":6039,"stargazers_count":150,"watchers_count":150,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":48,"open_issues":38,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/321"},"html":{"href":"https://github.com/paritytech/jsonrpc/pull/321"},"issue":{"href":"https://api.github.com/repos/paritytech/jsonrpc/issues/321"},"comments":{"href":"https://api.github.com/repos/paritytech/jsonrpc/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/jsonrpc/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/jsonrpc/statuses/a786cb0340978f9b1a6bb18978045fe38b9c87e7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tomusdrw"}}