{"action":"created","issue":{"url":"https://api.github.com/repos/knative/eventing/issues/563","repository_url":"https://api.github.com/repos/knative/eventing","labels_url":"https://api.github.com/repos/knative/eventing/issues/563/labels{/name}","comments_url":"https://api.github.com/repos/knative/eventing/issues/563/comments","events_url":"https://api.github.com/repos/knative/eventing/issues/563/events","html_url":"https://github.com/knative/eventing/pull/563","id":374543563,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjIyOTY1","number":563,"title":"Subscription names","user":{"login":"scothis","id":302992,"node_id":"MDQ6VXNlcjMwMjk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/302992?v=4","gravatar_id":"","url":"https://api.github.com/users/scothis","html_url":"https://github.com/scothis","followers_url":"https://api.github.com/users/scothis/followers","following_url":"https://api.github.com/users/scothis/following{/other_user}","gists_url":"https://api.github.com/users/scothis/gists{/gist_id}","starred_url":"https://api.github.com/users/scothis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scothis/subscriptions","organizations_url":"https://api.github.com/users/scothis/orgs","repos_url":"https://api.github.com/users/scothis/repos","events_url":"https://api.github.com/users/scothis/events{/privacy}","received_events_url":"https://api.github.com/users/scothis/received_events","type":"User","site_admin":false},"labels":[{"id":897406231,"node_id":"MDU6TGFiZWw4OTc0MDYyMzE=","url":"https://api.github.com/repos/knative/eventing/labels/approved","name":"approved","color":"ededed","default":false},{"id":1096308746,"node_id":"MDU6TGFiZWwxMDk2MzA4NzQ2","url":"https://api.github.com/repos/knative/eventing/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":904029784,"node_id":"MDU6TGFiZWw5MDQwMjk3ODQ=","url":"https://api.github.com/repos/knative/eventing/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"markfisher","id":140784,"node_id":"MDQ6VXNlcjE0MDc4NA==","avatar_url":"https://avatars2.githubusercontent.com/u/140784?v=4","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"assignees":[{"login":"markfisher","id":140784,"node_id":"MDQ6VXNlcjE0MDc4NA==","avatar_url":"https://avatars2.githubusercontent.com/u/140784?v=4","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},{"login":"evankanderson","id":7959095,"node_id":"MDQ6VXNlcjc5NTkwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7959095?v=4","gravatar_id":"","url":"https://api.github.com/users/evankanderson","html_url":"https://github.com/evankanderson","followers_url":"https://api.github.com/users/evankanderson/followers","following_url":"https://api.github.com/users/evankanderson/following{/other_user}","gists_url":"https://api.github.com/users/evankanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/evankanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evankanderson/subscriptions","organizations_url":"https://api.github.com/users/evankanderson/orgs","repos_url":"https://api.github.com/users/evankanderson/repos","events_url":"https://api.github.com/users/evankanderson/events{/privacy}","received_events_url":"https://api.github.com/users/evankanderson/received_events","type":"User","site_admin":false},{"login":"adamharwayne","id":11277581,"node_id":"MDQ6VXNlcjExMjc3NTgx","avatar_url":"https://avatars0.githubusercontent.com/u/11277581?v=4","gravatar_id":"","url":"https://api.github.com/users/adamharwayne","html_url":"https://github.com/adamharwayne","followers_url":"https://api.github.com/users/adamharwayne/followers","following_url":"https://api.github.com/users/adamharwayne/following{/other_user}","gists_url":"https://api.github.com/users/adamharwayne/gists{/gist_id}","starred_url":"https://api.github.com/users/adamharwayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamharwayne/subscriptions","organizations_url":"https://api.github.com/users/adamharwayne/orgs","repos_url":"https://api.github.com/users/adamharwayne/repos","events_url":"https://api.github.com/users/adamharwayne/events{/privacy}","received_events_url":"https://api.github.com/users/adamharwayne/received_events","type":"User","site_admin":false},{"login":"vaikas-google","id":11279988,"node_id":"MDQ6VXNlcjExMjc5OTg4","avatar_url":"https://avatars3.githubusercontent.com/u/11279988?v=4","gravatar_id":"","url":"https://api.github.com/users/vaikas-google","html_url":"https://github.com/vaikas-google","followers_url":"https://api.github.com/users/vaikas-google/followers","following_url":"https://api.github.com/users/vaikas-google/following{/other_user}","gists_url":"https://api.github.com/users/vaikas-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vaikas-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaikas-google/subscriptions","organizations_url":"https://api.github.com/users/vaikas-google/orgs","repos_url":"https://api.github.com/users/vaikas-google/repos","events_url":"https://api.github.com/users/vaikas-google/events{/privacy}","received_events_url":"https://api.github.com/users/vaikas-google/received_events","type":"User","site_admin":false}],"milestone":null,"comments":21,"created_at":"2018-10-26T20:52:29Z","updated_at":"2018-11-01T21:30:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/knative/eventing/pulls/563","html_url":"https://github.com/knative/eventing/pull/563","diff_url":"https://github.com/knative/eventing/pull/563.diff","patch_url":"https://github.com/knative/eventing/pull/563.patch"},"body":"Updates Subscription names to match the proposal names in \r\nhttps://docs.google.com/document/d/1xu18lprM8EFknqrsyZeNgYX2sLE13hfT2UKlYfdxv1g/edit#bookmark=id.111io8ayo6ei\r\n\r\nThese names should not be considered final at this point, but I'm opening this PR to move the ball forward.\r\n\r\n## Proposed Changes\r\n\r\nRenamed:\r\n- SubscriptionSpec.{From -> Channel}\r\n- SubscriptionSpec.{Call -> Subscriber}\r\n- SubscriptionSpec.{Result -> ReplyTo}\r\n- EndpointSpec -> SubscriberSpec\r\n   - SubscriberSpec.{TargetRef -> Ref}\r\n- ResultStrategy -> ReplyStrategy\r\n   - ReplyStrategy.{Target -> Channel}\r\n- ChannelSubscriberSpec.{CallableURI -> SubscriberURI}\r\n- ChannelSubscriberSpec.{SinkableURI -> ReplyToURI}\r\n- SubscriptionStatusPhysicalSubscription.{CallURI -> SubscriberURI}\r\n- SubscriptionStatusPhysicalSubscription.{ResultURI -> ReplyToURI}\r\n\r\n\r\n**Release Note**\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n```release-note\r\nAll existing eventing/v1alpha1 Subscription will need to be recreated with the new names\r\n```\r\n\r\n/assign @vaikas-google \r\n/assign @adamharwayne \r\n/assign @markfisher "},"comment":{"url":"https://api.github.com/repos/knative/eventing/issues/comments/435193958","html_url":"https://github.com/knative/eventing/pull/563#issuecomment-435193958","issue_url":"https://api.github.com/repos/knative/eventing/issues/563","id":435193958,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTE5Mzk1OA==","user":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T21:30:00Z","updated_at":"2018-11-01T21:30:00Z","author_association":"NONE","body":"New changes are detected. LGTM label has been removed."}}
{"actor":{"display_login":"knative-prow-robot"}}