{"action":"opened","issue":{"url":"https://api.github.com/repos/honza/anosql/issues/29","repository_url":"https://api.github.com/repos/honza/anosql","labels_url":"https://api.github.com/repos/honza/anosql/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/honza/anosql/issues/29/comments","events_url":"https://api.github.com/repos/honza/anosql/issues/29/events","html_url":"https://github.com/honza/anosql/issues/29","id":382313998,"node_id":"MDU6SXNzdWUzODIzMTM5OTg=","number":29,"title":"I made a derived work based on anosql.","user":{"login":"nackjicholson","id":365247,"node_id":"MDQ6VXNlcjM2NTI0Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/365247?v=4","gravatar_id":"","url":"https://api.github.com/users/nackjicholson","html_url":"https://github.com/nackjicholson","followers_url":"https://api.github.com/users/nackjicholson/followers","following_url":"https://api.github.com/users/nackjicholson/following{/other_user}","gists_url":"https://api.github.com/users/nackjicholson/gists{/gist_id}","starred_url":"https://api.github.com/users/nackjicholson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nackjicholson/subscriptions","organizations_url":"https://api.github.com/users/nackjicholson/orgs","repos_url":"https://api.github.com/users/nackjicholson/repos","events_url":"https://api.github.com/users/nackjicholson/events{/privacy}","received_events_url":"https://api.github.com/users/nackjicholson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-19T17:14:05Z","updated_at":"2018-11-19T17:14:05Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hey all,\r\n\r\n@honza @alecbrooks @steveYeah (you are people I've seen active in the repo lately)\r\n\r\nI worked this weekend on POC of a library based on anosql which handleds some things I thought might be useful. Here is the link if you'd like to look through it https://gitlab.com/willvaughn/aiosql\r\n\r\n@honza I copied the License, and as it truly is a derived work based on your library you are the top line on the copyright.\r\n\r\nChiefly, here are the things I had in mind while working on it:\r\n\r\n 1. Out of the box support for [`asyncio`](https://docs.python.org/3/library/asyncio.html) based database drivers like [aiosqlite](https://github.com/jreese/aiosqlite) and [asyncpg](https://github.com/MagicStack/asyncpg). Without losing support for sync drivers like sqlite and postgresql. I tried to accomplish this by isolating the code specific to each driver into \"QueryLoader\" strategies.\r\n 2. Ability to load a hierarchy of file from nested directories. To namespace the queries object as a tree, i.e. `queries.contacts.get_all()`.\r\n 3. Easy extension to accommodate custom database drivers. I wanted the ability to extend the library to `mysql` or `mssql` without necessarily having to add code to the mainline codebase.\r\n\r\nI didn't feel like it was correct to do all of these things in mainline anosql because of compatibility. The `asyncio` stuff limits my library to supporting python3.6+ because of `f-strings` and `async def` functions. Time willing, please look through the library and feel free to ask me any questions you have.\r\n\r\nThings to talk about:\r\n\r\n- Is it possible / desirable to merge some or all of this work back to `anosql` as a major version bump?\r\n- How interested are people in maintaining or extending `anosql` at this time?\r\n- Maintaining both projects for separate needs, or breaking out reusable part they can share.\r\n\r\nCheers!\r\n\r\n"}}
{"actor":{"display_login":"nackjicholson"}}