{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/pulls/2","id":193047589,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDQ3NTg5","html_url":"https://github.com/bjsmasth/php-salesforce-rest-api/pull/2","diff_url":"https://github.com/bjsmasth/php-salesforce-rest-api/pull/2.diff","patch_url":"https://github.com/bjsmasth/php-salesforce-rest-api/pull/2.patch","issue_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/issues/2","number":2,"state":"closed","locked":false,"title":"Remove die() calls and clean up a bit","user":{"login":"laszlof","id":1486486,"node_id":"MDQ6VXNlcjE0ODY0ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1486486?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlof","html_url":"https://github.com/laszlof","followers_url":"https://api.github.com/users/laszlof/followers","following_url":"https://api.github.com/users/laszlof/following{/other_user}","gists_url":"https://api.github.com/users/laszlof/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlof/subscriptions","organizations_url":"https://api.github.com/users/laszlof/orgs","repos_url":"https://api.github.com/users/laszlof/repos","events_url":"https://api.github.com/users/laszlof/events{/privacy}","received_events_url":"https://api.github.com/users/laszlof/received_events","type":"User","site_admin":false},"body":"Just a bit of cleanup and replacing the `die()` calls with exceptions. die() should generally not be used (particularly in libraries) as there is no way to properly handle the error.","created_at":"2018-06-06T15:11:40Z","updated_at":"2018-06-08T11:46:00Z","closed_at":"2018-06-08T11:46:00Z","merged_at":"2018-06-08T11:46:00Z","merge_commit_sha":"57e34c6b02683591c1a08ab59eb07d776feb3efd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/pulls/2/commits","review_comments_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/pulls/2/comments","review_comment_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/issues/2/comments","statuses_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/statuses/c886f8c3d295215eb14dad08abfd41c95533f06b","head":{"label":"laszlof:dont-die","ref":"dont-die","sha":"c886f8c3d295215eb14dad08abfd41c95533f06b","user":{"login":"laszlof","id":1486486,"node_id":"MDQ6VXNlcjE0ODY0ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1486486?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlof","html_url":"https://github.com/laszlof","followers_url":"https://api.github.com/users/laszlof/followers","following_url":"https://api.github.com/users/laszlof/following{/other_user}","gists_url":"https://api.github.com/users/laszlof/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlof/subscriptions","organizations_url":"https://api.github.com/users/laszlof/orgs","repos_url":"https://api.github.com/users/laszlof/repos","events_url":"https://api.github.com/users/laszlof/events{/privacy}","received_events_url":"https://api.github.com/users/laszlof/received_events","type":"User","site_admin":false},"repo":{"id":136344850,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzNDQ4NTA=","name":"php-salesforce-rest-api","full_name":"laszlof/php-salesforce-rest-api","owner":{"login":"laszlof","id":1486486,"node_id":"MDQ6VXNlcjE0ODY0ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1486486?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlof","html_url":"https://github.com/laszlof","followers_url":"https://api.github.com/users/laszlof/followers","following_url":"https://api.github.com/users/laszlof/following{/other_user}","gists_url":"https://api.github.com/users/laszlof/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlof/subscriptions","organizations_url":"https://api.github.com/users/laszlof/orgs","repos_url":"https://api.github.com/users/laszlof/repos","events_url":"https://api.github.com/users/laszlof/events{/privacy}","received_events_url":"https://api.github.com/users/laszlof/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laszlof/php-salesforce-rest-api","description":null,"fork":true,"url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api","forks_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/forks","keys_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/teams","hooks_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/hooks","issue_events_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/issues/events{/number}","events_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/events","assignees_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/assignees{/user}","branches_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/branches{/branch}","tags_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/tags","blobs_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/statuses/{sha}","languages_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/languages","stargazers_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/stargazers","contributors_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/contributors","subscribers_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/subscribers","subscription_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/subscription","commits_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/contents/{+path}","compare_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/merges","archive_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/downloads","issues_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/issues{/number}","pulls_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/pulls{/number}","milestones_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/milestones{/number}","notifications_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/labels{/name}","releases_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/releases{/id}","deployments_url":"https://api.github.com/repos/laszlof/php-salesforce-rest-api/deployments","created_at":"2018-06-06T14:59:17Z","updated_at":"2018-06-07T18:03:37Z","pushed_at":"2018-06-07T18:03:55Z","git_url":"git://github.com/laszlof/php-salesforce-rest-api.git","ssh_url":"git@github.com:laszlof/php-salesforce-rest-api.git","clone_url":"https://github.com/laszlof/php-salesforce-rest-api.git","svn_url":"https://github.com/laszlof/php-salesforce-rest-api","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bjsmasth:master","ref":"master","sha":"fb997842738015a098f73f838a0215c2e2d0b5a5","user":{"login":"bjsmasth","id":5401401,"node_id":"MDQ6VXNlcjU0MDE0MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5401401?v=4","gravatar_id":"","url":"https://api.github.com/users/bjsmasth","html_url":"https://github.com/bjsmasth","followers_url":"https://api.github.com/users/bjsmasth/followers","following_url":"https://api.github.com/users/bjsmasth/following{/other_user}","gists_url":"https://api.github.com/users/bjsmasth/gists{/gist_id}","starred_url":"https://api.github.com/users/bjsmasth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjsmasth/subscriptions","organizations_url":"https://api.github.com/users/bjsmasth/orgs","repos_url":"https://api.github.com/users/bjsmasth/repos","events_url":"https://api.github.com/users/bjsmasth/events{/privacy}","received_events_url":"https://api.github.com/users/bjsmasth/received_events","type":"User","site_admin":false},"repo":{"id":92647452,"node_id":"MDEwOlJlcG9zaXRvcnk5MjY0NzQ1Mg==","name":"php-salesforce-rest-api","full_name":"bjsmasth/php-salesforce-rest-api","owner":{"login":"bjsmasth","id":5401401,"node_id":"MDQ6VXNlcjU0MDE0MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5401401?v=4","gravatar_id":"","url":"https://api.github.com/users/bjsmasth","html_url":"https://github.com/bjsmasth","followers_url":"https://api.github.com/users/bjsmasth/followers","following_url":"https://api.github.com/users/bjsmasth/following{/other_user}","gists_url":"https://api.github.com/users/bjsmasth/gists{/gist_id}","starred_url":"https://api.github.com/users/bjsmasth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjsmasth/subscriptions","organizations_url":"https://api.github.com/users/bjsmasth/orgs","repos_url":"https://api.github.com/users/bjsmasth/repos","events_url":"https://api.github.com/users/bjsmasth/events{/privacy}","received_events_url":"https://api.github.com/users/bjsmasth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjsmasth/php-salesforce-rest-api","description":null,"fork":false,"url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api","forks_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/forks","keys_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/teams","hooks_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/hooks","issue_events_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/issues/events{/number}","events_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/events","assignees_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/assignees{/user}","branches_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/branches{/branch}","tags_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/tags","blobs_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/statuses/{sha}","languages_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/languages","stargazers_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/stargazers","contributors_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/contributors","subscribers_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/subscribers","subscription_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/subscription","commits_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/contents/{+path}","compare_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/merges","archive_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/downloads","issues_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/issues{/number}","pulls_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/pulls{/number}","milestones_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/milestones{/number}","notifications_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/labels{/name}","releases_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/releases{/id}","deployments_url":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/deployments","created_at":"2017-05-28T07:49:43Z","updated_at":"2018-06-01T18:16:53Z","pushed_at":"2018-06-08T11:46:00Z","git_url":"git://github.com/bjsmasth/php-salesforce-rest-api.git","ssh_url":"git@github.com:bjsmasth/php-salesforce-rest-api.git","clone_url":"https://github.com/bjsmasth/php-salesforce-rest-api.git","svn_url":"https://github.com/bjsmasth/php-salesforce-rest-api","homepage":null,"size":13,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":4,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/pulls/2"},"html":{"href":"https://github.com/bjsmasth/php-salesforce-rest-api/pull/2"},"issue":{"href":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/issues/2"},"comments":{"href":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/bjsmasth/php-salesforce-rest-api/statuses/c886f8c3d295215eb14dad08abfd41c95533f06b"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bjsmasth","id":5401401,"node_id":"MDQ6VXNlcjU0MDE0MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5401401?v=4","gravatar_id":"","url":"https://api.github.com/users/bjsmasth","html_url":"https://github.com/bjsmasth","followers_url":"https://api.github.com/users/bjsmasth/followers","following_url":"https://api.github.com/users/bjsmasth/following{/other_user}","gists_url":"https://api.github.com/users/bjsmasth/gists{/gist_id}","starred_url":"https://api.github.com/users/bjsmasth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjsmasth/subscriptions","organizations_url":"https://api.github.com/users/bjsmasth/orgs","repos_url":"https://api.github.com/users/bjsmasth/repos","events_url":"https://api.github.com/users/bjsmasth/events{/privacy}","received_events_url":"https://api.github.com/users/bjsmasth/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":17,"changed_files":2}}
{"actor":{"display_login":"bjsmasth"}}