{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/209228184","pull_request_review_id":145200508,"id":209228184,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTIyODE4NA==","diff_hunk":"@@ -623,23 +639,11 @@ Maybe<URL> ResolveModule(Environment* env,\n   return Nothing<URL>();\n }\n \n-Maybe<URL> ResolveDirectory(Environment* env,\n-                            const URL& search,\n-                            PackageMainCheck check_pjson_main) {\n-  if (check_pjson_main) {\n-    Maybe<URL> main = ResolveMain(env, search);","path":"src/module_wrap.cc","position":54,"original_position":54,"commit_id":"3e16cf5c12ed74850fc33dc77c39d7a9bb08757a","original_commit_id":"3e16cf5c12ed74850fc33dc77c39d7a9bb08757a","user":{"login":"guybedford","id":598730,"node_id":"MDQ6VXNlcjU5ODczMA==","avatar_url":"https://avatars1.githubusercontent.com/u/598730?v=4","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"body":"It seems this is never called now.\r\n\r\nThis is likely my fault - rushed the refactoring a bit last time. Will take another look.","created_at":"2018-08-10T11:27:27Z","updated_at":"2018-08-10T11:29:23Z","html_url":"https://github.com/nodejs/node/pull/21729#discussion_r209228184","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/21729","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/209228184"},"html":{"href":"https://github.com/nodejs/node/pull/21729#discussion_r209228184"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/21729"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21729","id":200231269,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjMxMjY5","html_url":"https://github.com/nodejs/node/pull/21729","diff_url":"https://github.com/nodejs/node/pull/21729.diff","patch_url":"https://github.com/nodejs/node/pull/21729.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/21729","number":21729,"state":"open","locked":false,"title":"modules: remove file extension and directory resolving for esm","user":{"login":"MylesBorins","id":498775,"node_id":"MDQ6VXNlcjQ5ODc3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/498775?v=4","gravatar_id":"","url":"https://api.github.com/users/MylesBorins","html_url":"https://github.com/MylesBorins","followers_url":"https://api.github.com/users/MylesBorins/followers","following_url":"https://api.github.com/users/MylesBorins/following{/other_user}","gists_url":"https://api.github.com/users/MylesBorins/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesBorins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesBorins/subscriptions","organizations_url":"https://api.github.com/users/MylesBorins/orgs","repos_url":"https://api.github.com/users/MylesBorins/repos","events_url":"https://api.github.com/users/MylesBorins/events{/privacy}","received_events_url":"https://api.github.com/users/MylesBorins/received_events","type":"User","site_admin":false},"body":"this build on top of the limitations of the package name map proposal.\r\nIt removes file extensions and directory resolution in the resolver.\r\n\r\nThis is only currently limited for local development. When resolving\r\ndependencies file extension and directory resolution will still work.\r\n\r\nRefs: https://github.com/domenic/package-name-maps\r\n\r\nAlternative to https://github.com/nodejs/node/pull/21572","created_at":"2018-07-09T21:58:29Z","updated_at":"2018-08-10T11:29:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b495e5b71ceec12d79cb7b44374e1bc758d5a4a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":690799345,"node_id":"MDU6TGFiZWw2OTA3OTkzNDU=","url":"https://api.github.com/repos/nodejs/node/labels/ES%20Modules","name":"ES Modules","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/21729/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/21729/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21729/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/3e16cf5c12ed74850fc33dc77c39d7a9bb08757a","head":{"label":"MylesBorins:simplified-esm-resolver","ref":"simplified-esm-resolver","sha":"3e16cf5c12ed74850fc33dc77c39d7a9bb08757a","user":{"login":"MylesBorins","id":498775,"node_id":"MDQ6VXNlcjQ5ODc3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/498775?v=4","gravatar_id":"","url":"https://api.github.com/users/MylesBorins","html_url":"https://github.com/MylesBorins","followers_url":"https://api.github.com/users/MylesBorins/followers","following_url":"https://api.github.com/users/MylesBorins/following{/other_user}","gists_url":"https://api.github.com/users/MylesBorins/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesBorins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesBorins/subscriptions","organizations_url":"https://api.github.com/users/MylesBorins/orgs","repos_url":"https://api.github.com/users/MylesBorins/repos","events_url":"https://api.github.com/users/MylesBorins/events{/privacy}","received_events_url":"https://api.github.com/users/MylesBorins/received_events","type":"User","site_admin":false},"repo":{"id":47707890,"node_id":"MDEwOlJlcG9zaXRvcnk0NzcwNzg5MA==","name":"node","full_name":"MylesBorins/node","owner":{"login":"MylesBorins","id":498775,"node_id":"MDQ6VXNlcjQ5ODc3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/498775?v=4","gravatar_id":"","url":"https://api.github.com/users/MylesBorins","html_url":"https://github.com/MylesBorins","followers_url":"https://api.github.com/users/MylesBorins/followers","following_url":"https://api.github.com/users/MylesBorins/following{/other_user}","gists_url":"https://api.github.com/users/MylesBorins/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesBorins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesBorins/subscriptions","organizations_url":"https://api.github.com/users/MylesBorins/orgs","repos_url":"https://api.github.com/users/MylesBorins/repos","events_url":"https://api.github.com/users/MylesBorins/events{/privacy}","received_events_url":"https://api.github.com/users/MylesBorins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MylesBorins/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/MylesBorins/node","forks_url":"https://api.github.com/repos/MylesBorins/node/forks","keys_url":"https://api.github.com/repos/MylesBorins/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MylesBorins/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MylesBorins/node/teams","hooks_url":"https://api.github.com/repos/MylesBorins/node/hooks","issue_events_url":"https://api.github.com/repos/MylesBorins/node/issues/events{/number}","events_url":"https://api.github.com/repos/MylesBorins/node/events","assignees_url":"https://api.github.com/repos/MylesBorins/node/assignees{/user}","branches_url":"https://api.github.com/repos/MylesBorins/node/branches{/branch}","tags_url":"https://api.github.com/repos/MylesBorins/node/tags","blobs_url":"https://api.github.com/repos/MylesBorins/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MylesBorins/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MylesBorins/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/MylesBorins/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MylesBorins/node/statuses/{sha}","languages_url":"https://api.github.com/repos/MylesBorins/node/languages","stargazers_url":"https://api.github.com/repos/MylesBorins/node/stargazers","contributors_url":"https://api.github.com/repos/MylesBorins/node/contributors","subscribers_url":"https://api.github.com/repos/MylesBorins/node/subscribers","subscription_url":"https://api.github.com/repos/MylesBorins/node/subscription","commits_url":"https://api.github.com/repos/MylesBorins/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/MylesBorins/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/MylesBorins/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/MylesBorins/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/MylesBorins/node/contents/{+path}","compare_url":"https://api.github.com/repos/MylesBorins/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MylesBorins/node/merges","archive_url":"https://api.github.com/repos/MylesBorins/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MylesBorins/node/downloads","issues_url":"https://api.github.com/repos/MylesBorins/node/issues{/number}","pulls_url":"https://api.github.com/repos/MylesBorins/node/pulls{/number}","milestones_url":"https://api.github.com/repos/MylesBorins/node/milestones{/number}","notifications_url":"https://api.github.com/repos/MylesBorins/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MylesBorins/node/labels{/name}","releases_url":"https://api.github.com/repos/MylesBorins/node/releases{/id}","deployments_url":"https://api.github.com/repos/MylesBorins/node/deployments","created_at":"2015-12-09T17:36:26Z","updated_at":"2018-04-02T05:44:29Z","pushed_at":"2018-08-09T20:30:36Z","git_url":"git://github.com/MylesBorins/node.git","ssh_url":"git@github.com:MylesBorins/node.git","clone_url":"https://github.com/MylesBorins/node.git","svn_url":"https://github.com/MylesBorins/node","homepage":"https://nodejs.org","size":391855,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"2fd71f92381010724e24cd07d505f76e63b16394","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-08-10T10:42:43Z","pushed_at":"2018-08-10T10:56:53Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":399825,"stargazers_count":52149,"watchers_count":52149,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11003,"mirror_url":null,"archived":false,"open_issues_count":854,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11003,"open_issues":854,"watchers":52149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/21729"},"html":{"href":"https://github.com/nodejs/node/pull/21729"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/21729"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/21729/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/21729/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/21729/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/3e16cf5c12ed74850fc33dc77c39d7a9bb08757a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"guybedford"}}