{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/166192744","pull_request_review_id":94226720,"id":166192744,"diff_hunk":"@@ -0,0 +1,132 @@\n+From 3714c5be3212d2af61545439eeb432e5d84a8d39 Mon Sep 17 00:00:00 2001","path":"pkgs/servers/monitoring/net-snmp/CVE-2015-5621.patch","position":1,"original_position":1,"commit_id":"c206887865acc2d5a21a52c6ccc4417aa97dee06","original_commit_id":"c206887865acc2d5a21a52c6ccc4417aa97dee06","user":{"login":"Ericson2314","id":1055245,"avatar_url":"https://avatars3.githubusercontent.com/u/1055245?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericson2314","html_url":"https://github.com/Ericson2314","followers_url":"https://api.github.com/users/Ericson2314/followers","following_url":"https://api.github.com/users/Ericson2314/following{/other_user}","gists_url":"https://api.github.com/users/Ericson2314/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericson2314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericson2314/subscriptions","organizations_url":"https://api.github.com/users/Ericson2314/orgs","repos_url":"https://api.github.com/users/Ericson2314/repos","events_url":"https://api.github.com/users/Ericson2314/events{/privacy}","received_events_url":"https://api.github.com/users/Ericson2314/received_events","type":"User","site_admin":false},"body":"Can we not `fetchPatch` this?","created_at":"2018-02-06T05:50:47Z","updated_at":"2018-02-06T05:57:48Z","html_url":"https://github.com/NixOS/nixpkgs/pull/34645#discussion_r166192744","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34645","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/166192744"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/34645#discussion_r166192744"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34645"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34645","id":167304995,"html_url":"https://github.com/NixOS/nixpkgs/pull/34645","diff_url":"https://github.com/NixOS/nixpkgs/pull/34645.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/34645.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34645","number":34645,"state":"open","locked":false,"title":"[WIP] musl-cross, native-musl, cross fixes, oh my!","user":{"login":"dtzWill","id":817330,"avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"body":"## Motivation for this change\r\n\r\nSupport cross-compiling for musl, support musl-native, generalize a bit beyond glibc, many cross fixes.\r\n\r\nA few fixes are \"borrowed\" from @bgamari's big PR (#30882).\r\n\r\n### Quickstart with Binary Cache\r\n\r\nTo enjoy musl goodness right away, consider taking advantage of the ALLVM project's binary cache!\r\n\r\nTo do so, add the following to your configuration.nix:\r\n\r\n```nix\r\n{\r\n    nix.binaryCaches = [\r\n      \"https://cache.nixos.org/\"\r\n      \"https://cache.allvm.org/\"\r\n    ];\r\n\r\n    nix.binaryCachePublicKeys = [\r\n      \"gravity.cs.illinois.edu-1:yymmNS/WMf0iTj2NnD0nrVV8cBOXM9ivAkEdO1Lro3U=\"\r\n    ];\r\n}\r\n```\r\n\r\n(Please add it after the nixos one O:))\r\n\r\nEquivalent of \"small\" jobset is evaluated and cached for a few build configurations,\r\nbut certainly not everything works yet.  This is just a (hopefully solid) start!\r\n\r\n----------------\r\n\r\n### Credits and Teasers: ALLVM\r\n\r\nThis PR (and many of the related fixes submitted recently) are based on work done as part of the [ALLVM project](http://allvm.org), many thanks to our funding :+1:.\r\n\r\nWe look forward to sharing more with everyone soon! Stay tuned :).\r\n","created_at":"2018-02-06T02:22:33Z","updated_at":"2018-02-06T05:57:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0c15a43d9cf506ef51941fb81de938cbd0ab25c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zimbatm","id":3248,"avatar_url":"https://avatars0.githubusercontent.com/u/3248?v=4","gravatar_id":"","url":"https://api.github.com/users/zimbatm","html_url":"https://github.com/zimbatm","followers_url":"https://api.github.com/users/zimbatm/followers","following_url":"https://api.github.com/users/zimbatm/following{/other_user}","gists_url":"https://api.github.com/users/zimbatm/gists{/gist_id}","starred_url":"https://api.github.com/users/zimbatm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimbatm/subscriptions","organizations_url":"https://api.github.com/users/zimbatm/orgs","repos_url":"https://api.github.com/users/zimbatm/repos","events_url":"https://api.github.com/users/zimbatm/events{/privacy}","received_events_url":"https://api.github.com/users/zimbatm/received_events","type":"User","site_admin":false},{"login":"orivej","id":101514,"avatar_url":"https://avatars1.githubusercontent.com/u/101514?v=4","gravatar_id":"","url":"https://api.github.com/users/orivej","html_url":"https://github.com/orivej","followers_url":"https://api.github.com/users/orivej/followers","following_url":"https://api.github.com/users/orivej/following{/other_user}","gists_url":"https://api.github.com/users/orivej/gists{/gist_id}","starred_url":"https://api.github.com/users/orivej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orivej/subscriptions","organizations_url":"https://api.github.com/users/orivej/orgs","repos_url":"https://api.github.com/users/orivej/repos","events_url":"https://api.github.com/users/orivej/events{/privacy}","received_events_url":"https://api.github.com/users/orivej/received_events","type":"User","site_admin":false},{"login":"nbp","id":1179566,"avatar_url":"https://avatars1.githubusercontent.com/u/1179566?v=4","gravatar_id":"","url":"https://api.github.com/users/nbp","html_url":"https://github.com/nbp","followers_url":"https://api.github.com/users/nbp/followers","following_url":"https://api.github.com/users/nbp/following{/other_user}","gists_url":"https://api.github.com/users/nbp/gists{/gist_id}","starred_url":"https://api.github.com/users/nbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbp/subscriptions","organizations_url":"https://api.github.com/users/nbp/orgs","repos_url":"https://api.github.com/users/nbp/repos","events_url":"https://api.github.com/users/nbp/events{/privacy}","received_events_url":"https://api.github.com/users/nbp/received_events","type":"User","site_admin":false},{"login":"FRidh","id":2129135,"avatar_url":"https://avatars3.githubusercontent.com/u/2129135?v=4","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34645/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34645/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34645/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/c206887865acc2d5a21a52c6ccc4417aa97dee06","head":{"label":"dtzWill:feature/musl","ref":"feature/musl","sha":"c206887865acc2d5a21a52c6ccc4417aa97dee06","user":{"login":"dtzWill","id":817330,"avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"repo":{"id":60178915,"name":"nixpkgs","full_name":"dtzWill/nixpkgs","owner":{"login":"dtzWill","id":817330,"avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtzWill/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/dtzWill/nixpkgs","forks_url":"https://api.github.com/repos/dtzWill/nixpkgs/forks","keys_url":"https://api.github.com/repos/dtzWill/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtzWill/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtzWill/nixpkgs/teams","hooks_url":"https://api.github.com/repos/dtzWill/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/dtzWill/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/dtzWill/nixpkgs/events","assignees_url":"https://api.github.com/repos/dtzWill/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/dtzWill/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/dtzWill/nixpkgs/tags","blobs_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtzWill/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/dtzWill/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/dtzWill/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/dtzWill/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/dtzWill/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/dtzWill/nixpkgs/subscription","commits_url":"https://api.github.com/repos/dtzWill/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtzWill/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtzWill/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtzWill/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/dtzWill/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtzWill/nixpkgs/merges","archive_url":"https://api.github.com/repos/dtzWill/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtzWill/nixpkgs/downloads","issues_url":"https://api.github.com/repos/dtzWill/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/dtzWill/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/dtzWill/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/dtzWill/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtzWill/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/dtzWill/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/dtzWill/nixpkgs/deployments","created_at":"2016-06-01T13:23:48Z","updated_at":"2016-06-01T13:24:12Z","pushed_at":"2018-02-06T01:19:52Z","git_url":"git://github.com/dtzWill/nixpkgs.git","ssh_url":"git@github.com:dtzWill/nixpkgs.git","clone_url":"https://github.com/dtzWill/nixpkgs.git","svn_url":"https://github.com/dtzWill/nixpkgs","homepage":null,"size":654282,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:staging","ref":"staging","sha":"9548028a22f3fbc44a450d5ccedaa722479a23ec","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-02-06T04:49:31Z","pushed_at":"2018-02-06T05:43:11Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":722590,"stargazers_count":2194,"watchers_count":2194,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2535,"mirror_url":null,"archived":false,"open_issues_count":2871,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2535,"open_issues":2871,"watchers":2194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34645"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/34645"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/34645"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/34645/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34645/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34645/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/c206887865acc2d5a21a52c6ccc4417aa97dee06"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Ericson2314"}}