{"action":"created","comment":{"url":"https://api.github.com/repos/decred/dcrd/pulls/comments/212130662","pull_request_review_id":148697871,"id":212130662,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjEzMDY2Mg==","diff_hunk":"@@ -1865,7 +1858,7 @@ mempoolLoop:\n \t// Calculate the required difficulty for the block.  The timestamp\n \t// is potentially adjusted to ensure it comes after the median time of\n \t// the last several blocks per the chain consensus rules.\n-\tts, err := medianAdjustedTime(chainState, timeSource)\n+\tts, err := medianAdjustedTime(blockManager.chain.BestSnapshot(), timeSource)","path":"mining.go","position":90,"original_position":90,"commit_id":"04d1791f17b57af2ad86ea6c2fb11e189661bb29","original_commit_id":"04d1791f17b57af2ad86ea6c2fb11e189661bb29","user":{"login":"davecgh","id":2115102,"node_id":"MDQ6VXNlcjIxMTUxMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/2115102?v=4","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"body":"This is in a loop.  Please store a local to the best state before starting the loop and use the local.","created_at":"2018-08-22T22:29:11Z","updated_at":"2018-08-22T22:35:07Z","html_url":"https://github.com/decred/dcrd/pull/1417#discussion_r212130662","pull_request_url":"https://api.github.com/repos/decred/dcrd/pulls/1417","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/decred/dcrd/pulls/comments/212130662"},"html":{"href":"https://github.com/decred/dcrd/pull/1417#discussion_r212130662"},"pull_request":{"href":"https://api.github.com/repos/decred/dcrd/pulls/1417"}}},"pull_request":{"url":"https://api.github.com/repos/decred/dcrd/pulls/1417","id":210254843,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjU0ODQz","html_url":"https://github.com/decred/dcrd/pull/1417","diff_url":"https://github.com/decred/dcrd/pull/1417.diff","patch_url":"https://github.com/decred/dcrd/pull/1417.patch","issue_url":"https://api.github.com/repos/decred/dcrd/issues/1417","number":1417,"state":"open","locked":false,"title":"multi: remove chainState dependency in rpcserver.","user":{"login":"dnldd","id":1281030,"node_id":"MDQ6VXNlcjEyODEwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1281030?v=4","gravatar_id":"","url":"https://api.github.com/users/dnldd","html_url":"https://github.com/dnldd","followers_url":"https://api.github.com/users/dnldd/followers","following_url":"https://api.github.com/users/dnldd/following{/other_user}","gists_url":"https://api.github.com/users/dnldd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnldd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnldd/subscriptions","organizations_url":"https://api.github.com/users/dnldd/orgs","repos_url":"https://api.github.com/users/dnldd/repos","events_url":"https://api.github.com/users/dnldd/events{/privacy}","received_events_url":"https://api.github.com/users/dnldd/received_events","type":"User","site_admin":false},"body":"this updates the function signatures of `minimumMedianTime` and `medianAdjustedTime` and removes all `chainState` usage in `rpcserver.go` in favour of using `BestState`. \r\n\r\nPort of upstream commit 2274d36 (subset). In preparation of the removal of `chainState`.","created_at":"2018-08-22T20:29:08Z","updated_at":"2018-08-22T22:35:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd8ceaa1dd208f55ed6f1054a850862dc2093bc7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/decred/dcrd/pulls/1417/commits","review_comments_url":"https://api.github.com/repos/decred/dcrd/pulls/1417/comments","review_comment_url":"https://api.github.com/repos/decred/dcrd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decred/dcrd/issues/1417/comments","statuses_url":"https://api.github.com/repos/decred/dcrd/statuses/04d1791f17b57af2ad86ea6c2fb11e189661bb29","head":{"label":"dnldd:rm_rpc_chainstate_dep","ref":"rm_rpc_chainstate_dep","sha":"04d1791f17b57af2ad86ea6c2fb11e189661bb29","user":{"login":"dnldd","id":1281030,"node_id":"MDQ6VXNlcjEyODEwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1281030?v=4","gravatar_id":"","url":"https://api.github.com/users/dnldd","html_url":"https://github.com/dnldd","followers_url":"https://api.github.com/users/dnldd/followers","following_url":"https://api.github.com/users/dnldd/following{/other_user}","gists_url":"https://api.github.com/users/dnldd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnldd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnldd/subscriptions","organizations_url":"https://api.github.com/users/dnldd/orgs","repos_url":"https://api.github.com/users/dnldd/repos","events_url":"https://api.github.com/users/dnldd/events{/privacy}","received_events_url":"https://api.github.com/users/dnldd/received_events","type":"User","site_admin":false},"repo":{"id":97525416,"node_id":"MDEwOlJlcG9zaXRvcnk5NzUyNTQxNg==","name":"dcrd","full_name":"dnldd/dcrd","owner":{"login":"dnldd","id":1281030,"node_id":"MDQ6VXNlcjEyODEwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1281030?v=4","gravatar_id":"","url":"https://api.github.com/users/dnldd","html_url":"https://github.com/dnldd","followers_url":"https://api.github.com/users/dnldd/followers","following_url":"https://api.github.com/users/dnldd/following{/other_user}","gists_url":"https://api.github.com/users/dnldd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnldd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnldd/subscriptions","organizations_url":"https://api.github.com/users/dnldd/orgs","repos_url":"https://api.github.com/users/dnldd/repos","events_url":"https://api.github.com/users/dnldd/events{/privacy}","received_events_url":"https://api.github.com/users/dnldd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnldd/dcrd","description":"Decred daemon in Go (golang).","fork":true,"url":"https://api.github.com/repos/dnldd/dcrd","forks_url":"https://api.github.com/repos/dnldd/dcrd/forks","keys_url":"https://api.github.com/repos/dnldd/dcrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnldd/dcrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnldd/dcrd/teams","hooks_url":"https://api.github.com/repos/dnldd/dcrd/hooks","issue_events_url":"https://api.github.com/repos/dnldd/dcrd/issues/events{/number}","events_url":"https://api.github.com/repos/dnldd/dcrd/events","assignees_url":"https://api.github.com/repos/dnldd/dcrd/assignees{/user}","branches_url":"https://api.github.com/repos/dnldd/dcrd/branches{/branch}","tags_url":"https://api.github.com/repos/dnldd/dcrd/tags","blobs_url":"https://api.github.com/repos/dnldd/dcrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnldd/dcrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnldd/dcrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnldd/dcrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnldd/dcrd/statuses/{sha}","languages_url":"https://api.github.com/repos/dnldd/dcrd/languages","stargazers_url":"https://api.github.com/repos/dnldd/dcrd/stargazers","contributors_url":"https://api.github.com/repos/dnldd/dcrd/contributors","subscribers_url":"https://api.github.com/repos/dnldd/dcrd/subscribers","subscription_url":"https://api.github.com/repos/dnldd/dcrd/subscription","commits_url":"https://api.github.com/repos/dnldd/dcrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnldd/dcrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnldd/dcrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnldd/dcrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnldd/dcrd/contents/{+path}","compare_url":"https://api.github.com/repos/dnldd/dcrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnldd/dcrd/merges","archive_url":"https://api.github.com/repos/dnldd/dcrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnldd/dcrd/downloads","issues_url":"https://api.github.com/repos/dnldd/dcrd/issues{/number}","pulls_url":"https://api.github.com/repos/dnldd/dcrd/pulls{/number}","milestones_url":"https://api.github.com/repos/dnldd/dcrd/milestones{/number}","notifications_url":"https://api.github.com/repos/dnldd/dcrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnldd/dcrd/labels{/name}","releases_url":"https://api.github.com/repos/dnldd/dcrd/releases{/id}","deployments_url":"https://api.github.com/repos/dnldd/dcrd/deployments","created_at":"2017-07-17T21:50:43Z","updated_at":"2017-07-17T21:50:46Z","pushed_at":"2018-08-22T22:28:18Z","git_url":"git://github.com/dnldd/dcrd.git","ssh_url":"git@github.com:dnldd/dcrd.git","clone_url":"https://github.com/dnldd/dcrd.git","svn_url":"https://github.com/dnldd/dcrd","homepage":"https://decred.org","size":25396,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"decred:master","ref":"master","sha":"a1985a4b3af502b1ec4979356240a78af6772462","user":{"login":"decred","id":16297194,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3MTk0","avatar_url":"https://avatars3.githubusercontent.com/u/16297194?v=4","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"repo":{"id":50457080,"node_id":"MDEwOlJlcG9zaXRvcnk1MDQ1NzA4MA==","name":"dcrd","full_name":"decred/dcrd","owner":{"login":"decred","id":16297194,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3MTk0","avatar_url":"https://avatars3.githubusercontent.com/u/16297194?v=4","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decred/dcrd","description":"Decred daemon in Go (golang).","fork":true,"url":"https://api.github.com/repos/decred/dcrd","forks_url":"https://api.github.com/repos/decred/dcrd/forks","keys_url":"https://api.github.com/repos/decred/dcrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decred/dcrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decred/dcrd/teams","hooks_url":"https://api.github.com/repos/decred/dcrd/hooks","issue_events_url":"https://api.github.com/repos/decred/dcrd/issues/events{/number}","events_url":"https://api.github.com/repos/decred/dcrd/events","assignees_url":"https://api.github.com/repos/decred/dcrd/assignees{/user}","branches_url":"https://api.github.com/repos/decred/dcrd/branches{/branch}","tags_url":"https://api.github.com/repos/decred/dcrd/tags","blobs_url":"https://api.github.com/repos/decred/dcrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decred/dcrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decred/dcrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/decred/dcrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decred/dcrd/statuses/{sha}","languages_url":"https://api.github.com/repos/decred/dcrd/languages","stargazers_url":"https://api.github.com/repos/decred/dcrd/stargazers","contributors_url":"https://api.github.com/repos/decred/dcrd/contributors","subscribers_url":"https://api.github.com/repos/decred/dcrd/subscribers","subscription_url":"https://api.github.com/repos/decred/dcrd/subscription","commits_url":"https://api.github.com/repos/decred/dcrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/decred/dcrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/decred/dcrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/decred/dcrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/decred/dcrd/contents/{+path}","compare_url":"https://api.github.com/repos/decred/dcrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decred/dcrd/merges","archive_url":"https://api.github.com/repos/decred/dcrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decred/dcrd/downloads","issues_url":"https://api.github.com/repos/decred/dcrd/issues{/number}","pulls_url":"https://api.github.com/repos/decred/dcrd/pulls{/number}","milestones_url":"https://api.github.com/repos/decred/dcrd/milestones{/number}","notifications_url":"https://api.github.com/repos/decred/dcrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decred/dcrd/labels{/name}","releases_url":"https://api.github.com/repos/decred/dcrd/releases{/id}","deployments_url":"https://api.github.com/repos/decred/dcrd/deployments","created_at":"2016-01-26T20:28:42Z","updated_at":"2018-08-21T19:07:04Z","pushed_at":"2018-08-22T22:28:19Z","git_url":"git://github.com/decred/dcrd.git","ssh_url":"git@github.com:decred/dcrd.git","clone_url":"https://github.com/decred/dcrd.git","svn_url":"https://github.com/decred/dcrd","homepage":"https://decred.org","size":25335,"stargazers_count":411,"watchers_count":411,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":152,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":152,"open_issues":57,"watchers":411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decred/dcrd/pulls/1417"},"html":{"href":"https://github.com/decred/dcrd/pull/1417"},"issue":{"href":"https://api.github.com/repos/decred/dcrd/issues/1417"},"comments":{"href":"https://api.github.com/repos/decred/dcrd/issues/1417/comments"},"review_comments":{"href":"https://api.github.com/repos/decred/dcrd/pulls/1417/comments"},"review_comment":{"href":"https://api.github.com/repos/decred/dcrd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decred/dcrd/pulls/1417/commits"},"statuses":{"href":"https://api.github.com/repos/decred/dcrd/statuses/04d1791f17b57af2ad86ea6c2fb11e189661bb29"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"davecgh"}}