{"action":"created","comment":{"url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/comments/165825115","pull_request_review_id":93826941,"id":165825115,"diff_hunk":"@@ -4,24 +4,25 @@ import UIKit\n \n class SplashCoordinator: Coordinator {\n     var coordinators: [Coordinator] = []\n-    private var splashViewIsActive = false\n     private let window: UIWindow\n-    private lazy var splashViewController: SplashViewController = {\n-        return SplashViewController()\n-    }()\n+    private var splashView: SplashView\n     init(window: UIWindow) {\n         self.window = window\n+        self.splashView = SplashView()\n     }\n     func start() {\n-        guard !splashViewIsActive else {\n-            return\n-        }\n-        splashViewIsActive = true\n-        window.rootViewController = splashViewController\n-        window.makeKeyAndVisible()\n+        window.isHidden = false\n+        window.addSubview(splashView)\n+        window.bringSubview(toFront: splashView)\n+        splashView.translatesAutoresizingMaskIntoConstraints = false\n+        NSLayoutConstraint.activate([\n+            splashView.topAnchor.constraint(equalTo: window.topAnchor),\n+            splashView.leadingAnchor.constraint(equalTo: window.leadingAnchor),\n+            splashView.bottomAnchor.constraint(equalTo: window.bottomAnchor),\n+            splashView.trailingAnchor.constraint(equalTo: window.trailingAnchor),\n+        ])\n     }\n-    func dismiss() {\n-        splashViewIsActive = false\n-        window.isHidden = true\n+    func stop() {\n+        splashView.removeFromSuperview()","path":"Trust/Protection/Coordinators/SplashCoordinator.swift","position":36,"original_position":36,"commit_id":"0416e5b25cd7ea4344fb2a05a532ba26aad0a5f2","original_commit_id":"0416e5b25cd7ea4344fb2a05a532ba26aad0a5f2","user":{"login":"michaelScoff","id":32179653,"avatar_url":"https://avatars0.githubusercontent.com/u/32179653?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelScoff","html_url":"https://github.com/michaelScoff","followers_url":"https://api.github.com/users/michaelScoff/followers","following_url":"https://api.github.com/users/michaelScoff/following{/other_user}","gists_url":"https://api.github.com/users/michaelScoff/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelScoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelScoff/subscriptions","organizations_url":"https://api.github.com/users/michaelScoff/orgs","repos_url":"https://api.github.com/users/michaelScoff/repos","events_url":"https://api.github.com/users/michaelScoff/events{/privacy}","received_events_url":"https://api.github.com/users/michaelScoff/received_events","type":"User","site_admin":false},"body":"Do you need to hide window as well?","created_at":"2018-02-03T20:48:49Z","updated_at":"2018-02-03T20:48:50Z","html_url":"https://github.com/TrustWallet/trust-wallet-ios/pull/271#discussion_r165825115","pull_request_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/271","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/comments/165825115"},"html":{"href":"https://github.com/TrustWallet/trust-wallet-ios/pull/271#discussion_r165825115"},"pull_request":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/271","id":166979224,"html_url":"https://github.com/TrustWallet/trust-wallet-ios/pull/271","diff_url":"https://github.com/TrustWallet/trust-wallet-ios/pull/271.diff","patch_url":"https://github.com/TrustWallet/trust-wallet-ios/pull/271.patch","issue_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/271","number":271,"state":"open","locked":false,"title":"Bug/402","user":{"login":"OlegGordiichuk","id":3758731,"avatar_url":"https://avatars1.githubusercontent.com/u/3758731?v=4","gravatar_id":"","url":"https://api.github.com/users/OlegGordiichuk","html_url":"https://github.com/OlegGordiichuk","followers_url":"https://api.github.com/users/OlegGordiichuk/followers","following_url":"https://api.github.com/users/OlegGordiichuk/following{/other_user}","gists_url":"https://api.github.com/users/OlegGordiichuk/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegGordiichuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegGordiichuk/subscriptions","organizations_url":"https://api.github.com/users/OlegGordiichuk/orgs","repos_url":"https://api.github.com/users/OlegGordiichuk/repos","events_url":"https://api.github.com/users/OlegGordiichuk/events{/privacy}","received_events_url":"https://api.github.com/users/OlegGordiichuk/received_events","type":"User","site_admin":false},"body":"Rewrite logic for showing of the passcode. I take a look at apps that are in GitHub and use their approach. Add unit tests. Test on iPhone (10.3) and iPad (11).","created_at":"2018-02-03T20:35:24Z","updated_at":"2018-02-03T20:48:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afba8cab6890b3799b12e73e460cb44b575e8288","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/271/commits","review_comments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/271/comments","review_comment_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/271/comments","statuses_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/statuses/0416e5b25cd7ea4344fb2a05a532ba26aad0a5f2","head":{"label":"TrustWallet:bug/402","ref":"bug/402","sha":"0416e5b25cd7ea4344fb2a05a532ba26aad0a5f2","user":{"login":"TrustWallet","id":32179889,"avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"repo":{"id":104401601,"name":"trust-wallet-ios","full_name":"TrustWallet/trust-wallet-ios","owner":{"login":"TrustWallet","id":32179889,"avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrustWallet/trust-wallet-ios","description":":iphone: Trust - Ethereum Wallet for iOS","fork":false,"url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios","forks_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/forks","keys_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/teams","hooks_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/hooks","issue_events_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/events{/number}","events_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/events","assignees_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/assignees{/user}","branches_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/branches{/branch}","tags_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/tags","blobs_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/languages","stargazers_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/stargazers","contributors_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/contributors","subscribers_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/subscribers","subscription_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/subscription","commits_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/contents/{+path}","compare_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/merges","archive_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/downloads","issues_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues{/number}","pulls_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/labels{/name}","releases_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/releases{/id}","deployments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/deployments","created_at":"2017-09-21T21:40:02Z","updated_at":"2018-02-03T14:35:48Z","pushed_at":"2018-02-03T20:35:25Z","git_url":"git://github.com/TrustWallet/trust-wallet-ios.git","ssh_url":"git@github.com:TrustWallet/trust-wallet-ios.git","clone_url":"https://github.com/TrustWallet/trust-wallet-ios.git","svn_url":"https://github.com/TrustWallet/trust-wallet-ios","homepage":"https://trustwalletapp.com","size":8667,"stargazers_count":272,"watchers_count":272,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":48,"open_issues":20,"watchers":272,"default_branch":"master"}},"base":{"label":"TrustWallet:master","ref":"master","sha":"e4cf8e380a1ced08fc5328f166f94b8e22c55e07","user":{"login":"TrustWallet","id":32179889,"avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"repo":{"id":104401601,"name":"trust-wallet-ios","full_name":"TrustWallet/trust-wallet-ios","owner":{"login":"TrustWallet","id":32179889,"avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrustWallet/trust-wallet-ios","description":":iphone: Trust - Ethereum Wallet for iOS","fork":false,"url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios","forks_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/forks","keys_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/teams","hooks_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/hooks","issue_events_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/events{/number}","events_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/events","assignees_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/assignees{/user}","branches_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/branches{/branch}","tags_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/tags","blobs_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/languages","stargazers_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/stargazers","contributors_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/contributors","subscribers_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/subscribers","subscription_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/subscription","commits_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/contents/{+path}","compare_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/merges","archive_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/downloads","issues_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues{/number}","pulls_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/labels{/name}","releases_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/releases{/id}","deployments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/deployments","created_at":"2017-09-21T21:40:02Z","updated_at":"2018-02-03T14:35:48Z","pushed_at":"2018-02-03T20:35:25Z","git_url":"git://github.com/TrustWallet/trust-wallet-ios.git","ssh_url":"git@github.com:TrustWallet/trust-wallet-ios.git","clone_url":"https://github.com/TrustWallet/trust-wallet-ios.git","svn_url":"https://github.com/TrustWallet/trust-wallet-ios","homepage":"https://trustwalletapp.com","size":8667,"stargazers_count":272,"watchers_count":272,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":48,"open_issues":20,"watchers":272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/271"},"html":{"href":"https://github.com/TrustWallet/trust-wallet-ios/pull/271"},"issue":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/271"},"comments":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/statuses/0416e5b25cd7ea4344fb2a05a532ba26aad0a5f2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"michaelScoff"}}