{"action":"opened","issue":{"url":"https://api.github.com/repos/python/typeshed/issues/2612","repository_url":"https://api.github.com/repos/python/typeshed","labels_url":"https://api.github.com/repos/python/typeshed/issues/2612/labels{/name}","comments_url":"https://api.github.com/repos/python/typeshed/issues/2612/comments","events_url":"https://api.github.com/repos/python/typeshed/issues/2612/events","html_url":"https://github.com/python/typeshed/issues/2612","id":382727563,"node_id":"MDU6SXNzdWUzODI3Mjc1NjM=","number":2612,"title":"Overhaul some of the stubs for requests/urllib3","user":{"login":"mgilson-argo","id":30414146,"node_id":"MDQ6VXNlcjMwNDE0MTQ2","avatar_url":"https://avatars1.githubusercontent.com/u/30414146?v=4","gravatar_id":"","url":"https://api.github.com/users/mgilson-argo","html_url":"https://github.com/mgilson-argo","followers_url":"https://api.github.com/users/mgilson-argo/followers","following_url":"https://api.github.com/users/mgilson-argo/following{/other_user}","gists_url":"https://api.github.com/users/mgilson-argo/gists{/gist_id}","starred_url":"https://api.github.com/users/mgilson-argo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgilson-argo/subscriptions","organizations_url":"https://api.github.com/users/mgilson-argo/orgs","repos_url":"https://api.github.com/users/mgilson-argo/repos","events_url":"https://api.github.com/users/mgilson-argo/events{/privacy}","received_events_url":"https://api.github.com/users/mgilson-argo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-20T15:52:05Z","updated_at":"2018-11-20T15:52:05Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Specifically, it looks like the stubs for `requests` date back to a time when `urllib3` was vendored with requests.  These days, it looks like requests doesn't vendor it anymore and instead uses `urllib3` from pypi.\r\n\r\nI think that `urllib3` should become it's own top-level stubs (not part of `requests`) and some of the requests stubs should probably be revisited.  In order to limit scope, the particular stubs that I've been fighting with in `requests.adapters` -- `BaseAdaptor.send` doesn't accept `proxies` (even though it should), `HTTPAdaptor.send` has virtually no type annotations when `BaseAdaptor.send` does -- I think they should be basically the same...\r\n\r\nWhat do you think?"}}
{"actor":{"display_login":"mgilson-argo"}}