{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/216569626","pull_request_review_id":154077518,"id":216569626,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjU2OTYyNg==","diff_hunk":"@@ -1,27 +1,140 @@\n describe InfraNetworkingController do\n-  let(:zone) { FactoryGirl.build(:zone) }\n-  let!(:server) { EvmSpecHelper.local_miq_server(:zone => zone) }\n-\n+  let(:switch) { FactoryGirl.create(:switch, :name => 'test_switch1', :shared => 'true') }\n+  let(:host) { FactoryGirl.create(:host, :name => 'test_host1') }\n+  let(:ems_vmware) { FactoryGirl.create(:ems_vmware, :name => 'test_vmware') }\n+  let(:cluster) { FactoryGirl.create(:cluster, :name => 'test_cluster') }\n+  let(:user) { FactoryGirl.create(:user) }\n   before { stub_user(:features => :all) }\n \n-  describe '#tree_select' do\n+  context 'render_views' do\n     render_views\n \n-    context 'switch' do\n-      let(:ems) { FactoryGirl.create(:ems_vmware) }\n-      let(:cluster) { FactoryGirl.create(:ems_cluster, :ems_id => ems.id) }\n-      let(:host) { FactoryGirl.create(:host_vmware, :ems_id => ems.id, :ems_cluster => cluster) }\n-      let(:switch) do\n-        sw = FactoryGirl.create(:switch_vmware, :ems_id => ems.id)\n-        FactoryGirl.create(:host_switch, :host => host, :switch => sw)\n-        sw\n+    context '#explorer' do\n+      before do\n+        session[:settings] = {:views => {}, :perpage => {:list => 5}}\n+        EvmSpecHelper.create_guid_miq_server_zone\n+      end\n+\n+      it 'can render the explorer' do\n+        session[:sb] = {:active_accord => :infra_networking_accord}\n+        seed_session_trees('switch', :infra_networking_tree, 'root')\n+        get :explorer\n+        expect(response.status).to eq(200)\n+        expect(response.body).to_not be_empty\n+      end\n+\n+      it 'shows a switch in the list' do\n+        switch\n+        session[:sb] = {:active_accord => :infra_networking_accord}\n+        seed_session_trees('switch', :infra_networking_tree, 'root')\n+\n+        get :explorer\n+        expect(response.body).to include(\"modelName: 'Switch'\")\n+        expect(response.body).to include(\"activeTree: 'infra_networking_tree'\")\n+        expect(response.body).to include(\"gtlType: 'list'\")\n+        expect(response.body).to include(\"isExplorer: 'true' === 'true' ? true : false\")\n+        expect(response.body).to include(\"showUrl: '/infra_networking/x_show/'\")\n+      end\n+    end\n+\n+    context \"#tree_select\" do\n+      before do\n+        switch\n+      end\n+\n+      [\n+        ['All Distributed Switches', 'infra_networking_tree'],\n+      ].each do |elements, tree|\n+        it \"renders list of #{elements} for #{tree} root node\" do\n+          session[:settings] = {}\n+          seed_session_trees('infra_networking', tree.to_sym)\n+\n+          post :tree_select, :params => { :id => 'root', :format => :js }\n+          expect(response.status).to eq(200)\n+        end\n+      end\n+\n+      it \"renders textual summary for an infrastructure switch\" do\n+        user\n+        allow(switch).to receive(:tagged_with).with(:cat => user.userid).and_return(\"my tags\")\n+        classification = FactoryGirl.create(:classification, :name => \"department\", :description => \"Department\")\n+        tag1 = FactoryGirl.create(:classification_tag,\n+                                  :name   => \"tag1\",\n+                                  :parent => classification)\n+        tag2 = FactoryGirl.create(:classification_tag,\n+                                  :name   => \"tag2\",\n+                                  :parent => classification)","path":"spec/controllers/infra_networking_controller_spec.rb","position":78,"original_position":78,"commit_id":"7dbca8673503603c9769f3ae8f95ea1f24392570","original_commit_id":"7dbca8673503603c9769f3ae8f95ea1f24392570","user":{"login":"skateman","id":649130,"node_id":"MDQ6VXNlcjY0OTEzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/649130?v=4","gravatar_id":"","url":"https://api.github.com/users/skateman","html_url":"https://github.com/skateman","followers_url":"https://api.github.com/users/skateman/followers","following_url":"https://api.github.com/users/skateman/following{/other_user}","gists_url":"https://api.github.com/users/skateman/gists{/gist_id}","starred_url":"https://api.github.com/users/skateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skateman/subscriptions","organizations_url":"https://api.github.com/users/skateman/orgs","repos_url":"https://api.github.com/users/skateman/repos","events_url":"https://api.github.com/users/skateman/events{/privacy}","received_events_url":"https://api.github.com/users/skateman/received_events","type":"User","site_admin":false},"body":"You generate the same things as below, just in an example. Share as much as you can if possible.","created_at":"2018-09-11T07:28:32Z","updated_at":"2018-09-11T07:29:39Z","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4634#discussion_r216569626","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4634","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/216569626"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4634#discussion_r216569626"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4634"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4634","id":214336746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzM2NzQ2","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4634","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4634.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4634.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4634","number":4634,"state":"open","locked":false,"title":"Fix duplicate infra_networking_spec files and merge them together","user":{"login":"rvsia","id":32869456,"node_id":"MDQ6VXNlcjMyODY5NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/32869456?v=4","gravatar_id":"","url":"https://api.github.com/users/rvsia","html_url":"https://github.com/rvsia","followers_url":"https://api.github.com/users/rvsia/followers","following_url":"https://api.github.com/users/rvsia/following{/other_user}","gists_url":"https://api.github.com/users/rvsia/gists{/gist_id}","starred_url":"https://api.github.com/users/rvsia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvsia/subscriptions","organizations_url":"https://api.github.com/users/rvsia/orgs","repos_url":"https://api.github.com/users/rvsia/repos","events_url":"https://api.github.com/users/rvsia/events{/privacy}","received_events_url":"https://api.github.com/users/rvsia/received_events","type":"User","site_admin":false},"body":"**Description**\r\nThere are two spec files for infra_networking_controller. I merged them together and removed the one with a wrong name.","created_at":"2018-09-10T14:36:32Z","updated_at":"2018-09-11T07:29:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67db389e573f9122e2b731cc0cb2f20f11d313e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":736077188,"node_id":"MDU6TGFiZWw3MzYwNzcxODg=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/gaprindashvili/no","name":"gaprindashvili/no","color":"000000","default":false},{"id":512311643,"node_id":"MDU6TGFiZWw1MTIzMTE2NDM=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/refactoring","name":"refactoring","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4634/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4634/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4634/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/7dbca8673503603c9769f3ae8f95ea1f24392570","head":{"label":"rvsia:duplicate_infra_networking_spec","ref":"duplicate_infra_networking_spec","sha":"7dbca8673503603c9769f3ae8f95ea1f24392570","user":{"login":"rvsia","id":32869456,"node_id":"MDQ6VXNlcjMyODY5NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/32869456?v=4","gravatar_id":"","url":"https://api.github.com/users/rvsia","html_url":"https://github.com/rvsia","followers_url":"https://api.github.com/users/rvsia/followers","following_url":"https://api.github.com/users/rvsia/following{/other_user}","gists_url":"https://api.github.com/users/rvsia/gists{/gist_id}","starred_url":"https://api.github.com/users/rvsia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvsia/subscriptions","organizations_url":"https://api.github.com/users/rvsia/orgs","repos_url":"https://api.github.com/users/rvsia/repos","events_url":"https://api.github.com/users/rvsia/events{/privacy}","received_events_url":"https://api.github.com/users/rvsia/received_events","type":"User","site_admin":false},"repo":{"id":113985728,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5ODU3Mjg=","name":"manageiq-ui-classic","full_name":"rvsia/manageiq-ui-classic","owner":{"login":"rvsia","id":32869456,"node_id":"MDQ6VXNlcjMyODY5NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/32869456?v=4","gravatar_id":"","url":"https://api.github.com/users/rvsia","html_url":"https://github.com/rvsia","followers_url":"https://api.github.com/users/rvsia/followers","following_url":"https://api.github.com/users/rvsia/following{/other_user}","gists_url":"https://api.github.com/users/rvsia/gists{/gist_id}","starred_url":"https://api.github.com/users/rvsia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvsia/subscriptions","organizations_url":"https://api.github.com/users/rvsia/orgs","repos_url":"https://api.github.com/users/rvsia/repos","events_url":"https://api.github.com/users/rvsia/events{/privacy}","received_events_url":"https://api.github.com/users/rvsia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rvsia/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":true,"url":"https://api.github.com/repos/rvsia/manageiq-ui-classic","forks_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/rvsia/manageiq-ui-classic/deployments","created_at":"2017-12-12T12:07:57Z","updated_at":"2018-08-14T07:59:19Z","pushed_at":"2018-09-10T14:52:04Z","git_url":"git://github.com/rvsia/manageiq-ui-classic.git","ssh_url":"git@github.com:rvsia/manageiq-ui-classic.git","clone_url":"https://github.com/rvsia/manageiq-ui-classic.git","svn_url":"https://github.com/rvsia/manageiq-ui-classic","homepage":null,"size":63782,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"0343abdcd4288533c9ad08210ee5b985a305cf66","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":77085298,"node_id":"MDEwOlJlcG9zaXRvcnk3NzA4NTI5OA==","name":"manageiq-ui-classic","full_name":"ManageIQ/manageiq-ui-classic","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/deployments","created_at":"2016-12-21T20:53:08Z","updated_at":"2018-09-10T21:00:51Z","pushed_at":"2018-09-10T22:58:44Z","git_url":"git://github.com/ManageIQ/manageiq-ui-classic.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-classic.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-classic.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-classic","homepage":null,"size":67152,"stargazers_count":30,"watchers_count":30,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":253,"mirror_url":null,"archived":false,"open_issues_count":266,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":253,"open_issues":266,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4634"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4634"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4634"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4634/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4634/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4634/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/7dbca8673503603c9769f3ae8f95ea1f24392570"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"skateman"}}