{"action":"created","issue":{"url":"https://api.github.com/repos/jaypipes/ghw/issues/64","repository_url":"https://api.github.com/repos/jaypipes/ghw","labels_url":"https://api.github.com/repos/jaypipes/ghw/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/jaypipes/ghw/issues/64/comments","events_url":"https://api.github.com/repos/jaypipes/ghw/issues/64/events","html_url":"https://github.com/jaypipes/ghw/pull/64","id":365005934,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDU4Nzk0","number":64,"title":"Collect more disk information","user":{"login":"jpo-joyent","id":42818489,"node_id":"MDQ6VXNlcjQyODE4NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/42818489?v=4","gravatar_id":"","url":"https://api.github.com/users/jpo-joyent","html_url":"https://github.com/jpo-joyent","followers_url":"https://api.github.com/users/jpo-joyent/followers","following_url":"https://api.github.com/users/jpo-joyent/following{/other_user}","gists_url":"https://api.github.com/users/jpo-joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/jpo-joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpo-joyent/subscriptions","organizations_url":"https://api.github.com/users/jpo-joyent/orgs","repos_url":"https://api.github.com/users/jpo-joyent/repos","events_url":"https://api.github.com/users/jpo-joyent/events{/privacy}","received_events_url":"https://api.github.com/users/jpo-joyent/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-28T19:05:01Z","updated_at":"2018-10-02T13:42:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jaypipes/ghw/pulls/64","html_url":"https://github.com/jaypipes/ghw/pull/64","diff_url":"https://github.com/jaypipes/ghw/pull/64.diff","patch_url":"https://github.com/jaypipes/ghw/pull/64.patch"},"body":"This PR adds code to also collect:\r\n- which NUMA node a disk is local to (useful when trying to balance IO)\r\n- the disk's bus path (useful when trying to know where to unplug the thing from)\r\n- the disk's model (useful in conjunction with the serial number)\r\n\r\nAlso fixes a bug where serial numbers would be listed as #unknown instead of being omitted\r\n\r\nOne downside is we re-read and re-parse the udev db (a small flat file) for each property lookup. I could cache it, but it would make the code uglier. Let me know if you'd like me to.\r\n\r\nIf you need me to break these out into separate PRs, just let me know."},"comment":{"url":"https://api.github.com/repos/jaypipes/ghw/issues/comments/426278366","html_url":"https://github.com/jaypipes/ghw/pull/64#issuecomment-426278366","issue_url":"https://api.github.com/repos/jaypipes/ghw/issues/64","id":426278366,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjI3ODM2Ng==","user":{"login":"jaypipes","id":265023,"node_id":"MDQ6VXNlcjI2NTAyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/265023?v=4","gravatar_id":"","url":"https://api.github.com/users/jaypipes","html_url":"https://github.com/jaypipes","followers_url":"https://api.github.com/users/jaypipes/followers","following_url":"https://api.github.com/users/jaypipes/following{/other_user}","gists_url":"https://api.github.com/users/jaypipes/gists{/gist_id}","starred_url":"https://api.github.com/users/jaypipes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaypipes/subscriptions","organizations_url":"https://api.github.com/users/jaypipes/orgs","repos_url":"https://api.github.com/users/jaypipes/repos","events_url":"https://api.github.com/users/jaypipes/events{/privacy}","received_events_url":"https://api.github.com/users/jaypipes/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T13:42:38Z","updated_at":"2018-10-02T13:42:38Z","author_association":"OWNER","body":"@jpo-joyent Hi! I've already merged #63 so would you mind rebasing to master and re-pushing to this PR? That would remove the udevInfo() code that is contained in here."}}
{"actor":{"display_login":"jaypipes"}}