{"action":"closed","number":18989,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18989","id":208439864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDM5ODY0","html_url":"https://github.com/cocos2d/cocos2d-x/pull/18989","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/18989.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/18989.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18989","number":18989,"state":"closed","locked":false,"title":"Add missing <functional> header to use std::function","user":{"login":"BillyONeal","id":1544943,"node_id":"MDQ6VXNlcjE1NDQ5NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1544943?v=4","gravatar_id":"","url":"https://api.github.com/users/BillyONeal","html_url":"https://github.com/BillyONeal","followers_url":"https://api.github.com/users/BillyONeal/followers","following_url":"https://api.github.com/users/BillyONeal/following{/other_user}","gists_url":"https://api.github.com/users/BillyONeal/gists{/gist_id}","starred_url":"https://api.github.com/users/BillyONeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillyONeal/subscriptions","organizations_url":"https://api.github.com/users/BillyONeal/orgs","repos_url":"https://api.github.com/users/BillyONeal/repos","events_url":"https://api.github.com/users/BillyONeal/events{/privacy}","received_events_url":"https://api.github.com/users/BillyONeal/received_events","type":"User","site_admin":false},"body":"This will be necessary to use std::function in VS2019; note that the standard requires including <functional> for std::function. (I cleaned up <mutex> and <thread> to not include <functional> which is causing builds of cocos2d-x to fail).","created_at":"2018-08-14T23:44:38Z","updated_at":"2018-08-15T19:19:06Z","closed_at":"2018-08-15T19:19:06Z","merged_at":null,"merge_commit_sha":"7d01cc9cf45a909339cde549f1ba7e6663e105f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18989/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18989/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18989/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/5ee6b89385f110f4ac101b721327de4eb6ce973b","head":{"label":"BillyONeal:v3","ref":"v3","sha":"5ee6b89385f110f4ac101b721327de4eb6ce973b","user":{"login":"BillyONeal","id":1544943,"node_id":"MDQ6VXNlcjE1NDQ5NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1544943?v=4","gravatar_id":"","url":"https://api.github.com/users/BillyONeal","html_url":"https://github.com/BillyONeal","followers_url":"https://api.github.com/users/BillyONeal/followers","following_url":"https://api.github.com/users/BillyONeal/following{/other_user}","gists_url":"https://api.github.com/users/BillyONeal/gists{/gist_id}","starred_url":"https://api.github.com/users/BillyONeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillyONeal/subscriptions","organizations_url":"https://api.github.com/users/BillyONeal/orgs","repos_url":"https://api.github.com/users/BillyONeal/repos","events_url":"https://api.github.com/users/BillyONeal/events{/privacy}","received_events_url":"https://api.github.com/users/BillyONeal/received_events","type":"User","site_admin":false},"repo":{"id":144782448,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3ODI0NDg=","name":"cocos2d-x","full_name":"BillyONeal/cocos2d-x","owner":{"login":"BillyONeal","id":1544943,"node_id":"MDQ6VXNlcjE1NDQ5NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1544943?v=4","gravatar_id":"","url":"https://api.github.com/users/BillyONeal","html_url":"https://github.com/BillyONeal","followers_url":"https://api.github.com/users/BillyONeal/followers","following_url":"https://api.github.com/users/BillyONeal/following{/other_user}","gists_url":"https://api.github.com/users/BillyONeal/gists{/gist_id}","starred_url":"https://api.github.com/users/BillyONeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillyONeal/subscriptions","organizations_url":"https://api.github.com/users/BillyONeal/orgs","repos_url":"https://api.github.com/users/BillyONeal/repos","events_url":"https://api.github.com/users/BillyONeal/events{/privacy}","received_events_url":"https://api.github.com/users/BillyONeal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BillyONeal/cocos2d-x","description":"Cocos2d-x is a suite of open-source, cross-platform, game-development tools used by millions of developers all over the world.","fork":true,"url":"https://api.github.com/repos/BillyONeal/cocos2d-x","forks_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/forks","keys_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/events","assignees_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/merges","archive_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/BillyONeal/cocos2d-x/deployments","created_at":"2018-08-14T23:33:45Z","updated_at":"2018-08-14T23:43:09Z","pushed_at":"2018-08-14T23:42:59Z","git_url":"git://github.com/BillyONeal/cocos2d-x.git","ssh_url":"git@github.com:BillyONeal/cocos2d-x.git","clone_url":"https://github.com/BillyONeal/cocos2d-x.git","svn_url":"https://github.com/BillyONeal/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":935607,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"e946c11eb38037b9fcbf11c495bcfd023a3873fb","user":{"login":"cocos2d","id":234324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDMyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/234324?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkzMjI4","name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDMyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/234324?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"Cocos2d-x is a suite of open-source, cross-platform, game-development tools used by millions of developers all over the world.","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/deployments","created_at":"2010-11-18T23:17:00Z","updated_at":"2018-08-15T15:10:39Z","pushed_at":"2018-08-14T23:44:39Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":935607,"stargazers_count":12240,"watchers_count":12240,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6573,"mirror_url":null,"archived":false,"open_issues_count":1238,"license":null,"forks":6573,"open_issues":1238,"watchers":12240,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18989"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/18989"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18989"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18989/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18989/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18989/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/5ee6b89385f110f4ac101b721327de4eb6ce973b"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"BillyONeal"}}