{"action":"opened","number":4063,"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/4063","id":226040114,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDQwMTE0","html_url":"https://github.com/musescore/MuseScore/pull/4063","diff_url":"https://github.com/musescore/MuseScore/pull/4063.diff","patch_url":"https://github.com/musescore/MuseScore/pull/4063.patch","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/4063","number":4063,"state":"open","locked":false,"title":"fix #266205: do not deselect elements in Score::selectAdd","user":{"login":"dmitrio95","id":6000747,"node_id":"MDQ6VXNlcjYwMDA3NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/6000747?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrio95","html_url":"https://github.com/dmitrio95","followers_url":"https://api.github.com/users/dmitrio95/followers","following_url":"https://api.github.com/users/dmitrio95/following{/other_user}","gists_url":"https://api.github.com/users/dmitrio95/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrio95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrio95/subscriptions","organizations_url":"https://api.github.com/users/dmitrio95/orgs","repos_url":"https://api.github.com/users/dmitrio95/repos","events_url":"https://api.github.com/users/dmitrio95/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrio95/received_events","type":"User","site_admin":false},"body":"This patch fixes [the issue](https://musescore.org/en/node/266205) with \"select similar elements\" feature not working in some circumstances (at least when applied to ties). The proposed solution is to remove deselection of elements from `Score::selectAdd` since it is not an expected behavior of this function and all of those chunks of code that use this function do not rely on such a behavior. Deselecting selected elements on Ctrl+click is already handled [in ScoreView](https://github.com/musescore/MuseScore/blob/cc84a61fc989383ecc85f877f90126da4dde67d0/mscore/events.cpp#L307) so this functionality is not broken by this patch.\r\n\r\nThe fact that `Score::scanElements` can scan some elements more than one time can also be considered an issue but I believe that it is much more important for it to touch all elements rather than  aim for doing it one time only. So this issue can be postponed I guess.\r\n\r\nThere is also a suspicious usage of `Score::select` in [ChangeElement::flip](https://github.com/musescore/MuseScore/blob/cc84a61fc989383ecc85f877f90126da4dde67d0/libmscore/undo.cpp#L999) but there is probably some typo there. The question is what kind of typo is there exactly.","created_at":"2018-10-26T09:54:54Z","updated_at":"2018-10-26T09:54:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/musescore/MuseScore/pulls/4063/commits","review_comments_url":"https://api.github.com/repos/musescore/MuseScore/pulls/4063/comments","review_comment_url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/4063/comments","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/11dfe3f42f265f12a579c58db859fb7b0bab9425","head":{"label":"dmitrio95:266205-fix-select-similar","ref":"266205-fix-select-similar","sha":"11dfe3f42f265f12a579c58db859fb7b0bab9425","user":{"login":"dmitrio95","id":6000747,"node_id":"MDQ6VXNlcjYwMDA3NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/6000747?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrio95","html_url":"https://github.com/dmitrio95","followers_url":"https://api.github.com/users/dmitrio95/followers","following_url":"https://api.github.com/users/dmitrio95/following{/other_user}","gists_url":"https://api.github.com/users/dmitrio95/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrio95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrio95/subscriptions","organizations_url":"https://api.github.com/users/dmitrio95/orgs","repos_url":"https://api.github.com/users/dmitrio95/repos","events_url":"https://api.github.com/users/dmitrio95/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrio95/received_events","type":"User","site_admin":false},"repo":{"id":125291726,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyOTE3MjY=","name":"MuseScore","full_name":"dmitrio95/MuseScore","private":false,"owner":{"login":"dmitrio95","id":6000747,"node_id":"MDQ6VXNlcjYwMDA3NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/6000747?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrio95","html_url":"https://github.com/dmitrio95","followers_url":"https://api.github.com/users/dmitrio95/followers","following_url":"https://api.github.com/users/dmitrio95/following{/other_user}","gists_url":"https://api.github.com/users/dmitrio95/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrio95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrio95/subscriptions","organizations_url":"https://api.github.com/users/dmitrio95/orgs","repos_url":"https://api.github.com/users/dmitrio95/repos","events_url":"https://api.github.com/users/dmitrio95/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrio95/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmitrio95/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":true,"url":"https://api.github.com/repos/dmitrio95/MuseScore","forks_url":"https://api.github.com/repos/dmitrio95/MuseScore/forks","keys_url":"https://api.github.com/repos/dmitrio95/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmitrio95/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmitrio95/MuseScore/teams","hooks_url":"https://api.github.com/repos/dmitrio95/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/dmitrio95/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/dmitrio95/MuseScore/events","assignees_url":"https://api.github.com/repos/dmitrio95/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/dmitrio95/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/dmitrio95/MuseScore/tags","blobs_url":"https://api.github.com/repos/dmitrio95/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmitrio95/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmitrio95/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmitrio95/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmitrio95/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/dmitrio95/MuseScore/languages","stargazers_url":"https://api.github.com/repos/dmitrio95/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/dmitrio95/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/dmitrio95/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/dmitrio95/MuseScore/subscription","commits_url":"https://api.github.com/repos/dmitrio95/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmitrio95/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmitrio95/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmitrio95/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmitrio95/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/dmitrio95/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmitrio95/MuseScore/merges","archive_url":"https://api.github.com/repos/dmitrio95/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmitrio95/MuseScore/downloads","issues_url":"https://api.github.com/repos/dmitrio95/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/dmitrio95/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/dmitrio95/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/dmitrio95/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmitrio95/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/dmitrio95/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/dmitrio95/MuseScore/deployments","created_at":"2018-03-15T00:42:05Z","updated_at":"2018-10-26T08:53:46Z","pushed_at":"2018-10-26T09:42:55Z","git_url":"git://github.com/dmitrio95/MuseScore.git","ssh_url":"git@github.com:dmitrio95/MuseScore.git","clone_url":"https://github.com/dmitrio95/MuseScore.git","svn_url":"https://github.com/dmitrio95/MuseScore","homepage":"https://musescore.org","size":314236,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"musescore:master","ref":"master","sha":"6dbff17ca7af21ff3eaaf8825cd9f065ae1d897a","user":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"repo":{"id":4454793,"node_id":"MDEwOlJlcG9zaXRvcnk0NDU0Nzkz","name":"MuseScore","full_name":"musescore/MuseScore","private":false,"owner":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/musescore/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":false,"url":"https://api.github.com/repos/musescore/MuseScore","forks_url":"https://api.github.com/repos/musescore/MuseScore/forks","keys_url":"https://api.github.com/repos/musescore/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musescore/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musescore/MuseScore/teams","hooks_url":"https://api.github.com/repos/musescore/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/musescore/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/musescore/MuseScore/events","assignees_url":"https://api.github.com/repos/musescore/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/musescore/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/musescore/MuseScore/tags","blobs_url":"https://api.github.com/repos/musescore/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musescore/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musescore/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/musescore/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/musescore/MuseScore/languages","stargazers_url":"https://api.github.com/repos/musescore/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/musescore/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/musescore/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/musescore/MuseScore/subscription","commits_url":"https://api.github.com/repos/musescore/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/musescore/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/musescore/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/musescore/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/musescore/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/musescore/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musescore/MuseScore/merges","archive_url":"https://api.github.com/repos/musescore/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musescore/MuseScore/downloads","issues_url":"https://api.github.com/repos/musescore/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/musescore/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/musescore/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/musescore/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musescore/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/musescore/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/musescore/MuseScore/deployments","created_at":"2012-05-26T12:46:33Z","updated_at":"2018-10-26T08:42:14Z","pushed_at":"2018-10-26T09:12:45Z","git_url":"git://github.com/musescore/MuseScore.git","ssh_url":"git@github.com:musescore/MuseScore.git","clone_url":"https://github.com/musescore/MuseScore.git","svn_url":"https://github.com/musescore/MuseScore","homepage":"https://musescore.org","size":316815,"stargazers_count":3079,"watchers_count":3079,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1059,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1059,"open_issues":123,"watchers":3079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/4063"},"html":{"href":"https://github.com/musescore/MuseScore/pull/4063"},"issue":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/4063"},"comments":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/4063/comments"},"review_comments":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/4063/comments"},"review_comment":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/4063/commits"},"statuses":{"href":"https://api.github.com/repos/musescore/MuseScore/statuses/11dfe3f42f265f12a579c58db859fb7b0bab9425"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"dmitrio95"}}