{"action":"created","issue":{"url":"https://api.github.com/repos/KatharaFramework/Kathara/issues/36","repository_url":"https://api.github.com/repos/KatharaFramework/Kathara","labels_url":"https://api.github.com/repos/KatharaFramework/Kathara/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/KatharaFramework/Kathara/issues/36/comments","events_url":"https://api.github.com/repos/KatharaFramework/Kathara/issues/36/events","html_url":"https://github.com/KatharaFramework/Kathara/issues/36","id":396165723,"node_id":"MDU6SXNzdWUzOTYxNjU3MjM=","number":36,"title":"DockerFiles","user":{"login":"jrobert2","id":22345479,"node_id":"MDQ6VXNlcjIyMzQ1NDc5","avatar_url":"https://avatars3.githubusercontent.com/u/22345479?v=4","gravatar_id":"","url":"https://api.github.com/users/jrobert2","html_url":"https://github.com/jrobert2","followers_url":"https://api.github.com/users/jrobert2/followers","following_url":"https://api.github.com/users/jrobert2/following{/other_user}","gists_url":"https://api.github.com/users/jrobert2/gists{/gist_id}","starred_url":"https://api.github.com/users/jrobert2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrobert2/subscriptions","organizations_url":"https://api.github.com/users/jrobert2/orgs","repos_url":"https://api.github.com/users/jrobert2/repos","events_url":"https://api.github.com/users/jrobert2/events{/privacy}","received_events_url":"https://api.github.com/users/jrobert2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-05T13:31:06Z","updated_at":"2019-01-05T14:11:31Z","closed_at":null,"author_association":"NONE","body":"I've played with creating my own docker images, starting from a ubuntu image instead of kathara/netkit_base. It looks like it works perfectly, but i'm wondering if i'm wrong or not, especially since i didn't find the dockerfile of kathara/netkit_base. Could you provide it ? \r\n\r\n\r\nBy the way, for my usage (teaching), i would find it great to have a way to specify a dockerfile inside the lab configuration (extending machine.startup for example).\r\nHere is a use-case. I have different labs with different packages installed inside the containers. \r\nI could pre-create the corresponding images. It is fine, but quite complicated in terms of administration, and hardly reproducible by my students at home.\r\nI could also have \"apt install\" in the startup files. But it would make the container slow to restart after crashing, while with docker images, it is cached.\r\n\r\nBest,\r\n\r\nJulien\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/KatharaFramework/Kathara/issues/comments/451658926","html_url":"https://github.com/KatharaFramework/Kathara/issues/36#issuecomment-451658926","issue_url":"https://api.github.com/repos/KatharaFramework/Kathara/issues/36","id":451658926,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTY1ODkyNg==","user":{"login":"Kidel","id":3390842,"node_id":"MDQ6VXNlcjMzOTA4NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/3390842?v=4","gravatar_id":"","url":"https://api.github.com/users/Kidel","html_url":"https://github.com/Kidel","followers_url":"https://api.github.com/users/Kidel/followers","following_url":"https://api.github.com/users/Kidel/following{/other_user}","gists_url":"https://api.github.com/users/Kidel/gists{/gist_id}","starred_url":"https://api.github.com/users/Kidel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kidel/subscriptions","organizations_url":"https://api.github.com/users/Kidel/orgs","repos_url":"https://api.github.com/users/Kidel/repos","events_url":"https://api.github.com/users/Kidel/events{/privacy}","received_events_url":"https://api.github.com/users/Kidel/received_events","type":"User","site_admin":false},"created_at":"2019-01-05T14:11:31Z","updated_at":"2019-01-05T14:11:31Z","author_association":"MEMBER","body":"Hi, thanks for writing us. \r\n\r\n\r\nWould it be okay if we allowed to specify the root of a DockerHub image?\r\nAt the moment if you use the `image` parameter in lab.conf, Docker will look for `kathara/imagename` on your machine or on DockerHub. We can allow a configuration entry to specify the root repository on the hub (that can also be an empty string).\r\n\r\nThis way you can simply build your dockerfiles and send them to DockerHub, making the lab deployment way faster (since you don't have to build the images from scratch). \r\n\r\nA workaround that can work for now is basically to send your pre-built images to your DockerHub repository and have a script that downloads them locally and tags them as `kathara/something`. This way if you use `pc[image]=something` in your lab.conf, Docker will recognise the local tag.\r\n\r\nAbout our dockerfile for netkit_base, I'm afraid it doesn't exist anymore. We had an issue with a package that wasn't available on a stable repository, so we switched to a pre-built version of our previous dockerfile during the development. It's not an issue since DockerHub provides a decent versioning system and we can commit changes and update the image just fine. It's actually useful since we don't have issue related to build problems. \r\n\r\nHope it helps. Please tell us if the suggested solution can be sufficient for you. "}}
{"actor":{"display_login":"Kidel"}}