{"action":"created","comment":{"url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/comments/244928085","pull_request_review_id":188920226,"id":244928085,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDkyODA4NQ==","diff_hunk":"@@ -61,24 +61,27 @@ func getEnvTemplate(cr *v1.KieApp) v1.EnvTemplate {\n \tif cr.Spec.KieDeployments == 0 {\n \t\tcr.Spec.KieDeployments = 1\n \t}\n-\tif len(cr.Spec.Objects.Console.Env) == 0 {\n-\t\tcr.Spec.Objects.Console.Env = []corev1.EnvVar{{Name: \"empty\"}}\n-\t}\n-\tif len(cr.Spec.Objects.Server.Env) == 0 {\n-\t\tcr.Spec.Objects.Server.Env = []corev1.EnvVar{{Name: \"empty\"}}\n-\t}\n \tif cr.Spec.RhpamRegistry == (v1.KieAppRegistry{}) {\n \t\tcr.Spec.RhpamRegistry.Registry = logs.GetEnv(\"REGISTRY\", constants.RhpamRegistry) // default to red hat registry\n \t\tcr.Spec.RhpamRegistry.Insecure = logs.GetBoolEnv(\"INSECURE\")\n \t}\n \n+\tconsoleName := constants.RhpamcentrServicePrefix\n+\tconsoleImage := constants.RhpamcentrImageName\n+\tif _, isMonitoring := constants.MonitoringEnvs[cr.Spec.Environment]; isMonitoring {","path":"pkg/controller/kieapp/defaults/defaults.go","position":17,"original_position":17,"commit_id":"212d30ae28b7ffe29c3c7ce0775c0054facfe9c8","original_commit_id":"212d30ae28b7ffe29c3c7ce0775c0054facfe9c8","user":{"login":"ruromero","id":637557,"node_id":"MDQ6VXNlcjYzNzU1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/637557?v=4","gravatar_id":"","url":"https://api.github.com/users/ruromero","html_url":"https://github.com/ruromero","followers_url":"https://api.github.com/users/ruromero/followers","following_url":"https://api.github.com/users/ruromero/following{/other_user}","gists_url":"https://api.github.com/users/ruromero/gists{/gist_id}","starred_url":"https://api.github.com/users/ruromero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruromero/subscriptions","organizations_url":"https://api.github.com/users/ruromero/orgs","repos_url":"https://api.github.com/users/ruromero/repos","events_url":"https://api.github.com/users/ruromero/events{/privacy}","received_events_url":"https://api.github.com/users/ruromero/received_events","type":"User","site_admin":false},"body":"that looks simpler, yes","created_at":"2019-01-03T07:58:57Z","updated_at":"2019-01-03T07:58:58Z","html_url":"https://github.com/kiegroup/kie-cloud-operator/pull/36#discussion_r244928085","pull_request_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/36","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/comments/244928085"},"html":{"href":"https://github.com/kiegroup/kie-cloud-operator/pull/36#discussion_r244928085"},"pull_request":{"href":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/36"}},"in_reply_to_id":244836208},"pull_request":{"url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/36","id":241788044,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNzg4MDQ0","html_url":"https://github.com/kiegroup/kie-cloud-operator/pull/36","diff_url":"https://github.com/kiegroup/kie-cloud-operator/pull/36.diff","patch_url":"https://github.com/kiegroup/kie-cloud-operator/pull/36.patch","issue_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/issues/36","number":36,"state":"open","locked":false,"title":"[WIP] Add immutable environments","user":{"login":"ruromero","id":637557,"node_id":"MDQ6VXNlcjYzNzU1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/637557?v=4","gravatar_id":"","url":"https://api.github.com/users/ruromero","html_url":"https://github.com/ruromero","followers_url":"https://api.github.com/users/ruromero/followers","following_url":"https://api.github.com/users/ruromero/following{/other_user}","gists_url":"https://api.github.com/users/ruromero/gists{/gist_id}","starred_url":"https://api.github.com/users/ruromero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruromero/subscriptions","organizations_url":"https://api.github.com/users/ruromero/orgs","repos_url":"https://api.github.com/users/ruromero/repos","events_url":"https://api.github.com/users/ruromero/events{/privacy}","received_events_url":"https://api.github.com/users/ruromero/received_events","type":"User","site_admin":false},"body":"Fix https://issues.jboss.org/browse/KIECLOUD-51\r\n\r\nAdded Smartrouter as standalone object\r\nAdded omit flag to skip deploying certain resources (e.g. kieservers)\r\nRefactored ConstructObject method\r\nAdded immutable-monitor environment\r\n\r\n**[WIP]**\r\nAdd immutable-kieserver\r\nAdd build configuration for s2i and required data model/functionality","created_at":"2019-01-02T16:23:13Z","updated_at":"2019-01-03T07:58:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3efee2e9b1c5db8be188fbda3f1773567d09988b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/36/commits","review_comments_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/36/comments","review_comment_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/issues/36/comments","statuses_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/statuses/212d30ae28b7ffe29c3c7ce0775c0054facfe9c8","head":{"label":"ruromero:immutablemon","ref":"immutablemon","sha":"212d30ae28b7ffe29c3c7ce0775c0054facfe9c8","user":{"login":"ruromero","id":637557,"node_id":"MDQ6VXNlcjYzNzU1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/637557?v=4","gravatar_id":"","url":"https://api.github.com/users/ruromero","html_url":"https://github.com/ruromero","followers_url":"https://api.github.com/users/ruromero/followers","following_url":"https://api.github.com/users/ruromero/following{/other_user}","gists_url":"https://api.github.com/users/ruromero/gists{/gist_id}","starred_url":"https://api.github.com/users/ruromero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruromero/subscriptions","organizations_url":"https://api.github.com/users/ruromero/orgs","repos_url":"https://api.github.com/users/ruromero/repos","events_url":"https://api.github.com/users/ruromero/events{/privacy}","received_events_url":"https://api.github.com/users/ruromero/received_events","type":"User","site_admin":false},"repo":{"id":159568338,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk1NjgzMzg=","name":"kie-cloud-operator","full_name":"ruromero/kie-cloud-operator","private":false,"owner":{"login":"ruromero","id":637557,"node_id":"MDQ6VXNlcjYzNzU1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/637557?v=4","gravatar_id":"","url":"https://api.github.com/users/ruromero","html_url":"https://github.com/ruromero","followers_url":"https://api.github.com/users/ruromero/followers","following_url":"https://api.github.com/users/ruromero/following{/other_user}","gists_url":"https://api.github.com/users/ruromero/gists{/gist_id}","starred_url":"https://api.github.com/users/ruromero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruromero/subscriptions","organizations_url":"https://api.github.com/users/ruromero/orgs","repos_url":"https://api.github.com/users/ruromero/repos","events_url":"https://api.github.com/users/ruromero/events{/privacy}","received_events_url":"https://api.github.com/users/ruromero/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ruromero/kie-cloud-operator","description":"OCP Operator for KIE","fork":true,"url":"https://api.github.com/repos/ruromero/kie-cloud-operator","forks_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/forks","keys_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/teams","hooks_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/hooks","issue_events_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/issues/events{/number}","events_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/events","assignees_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/assignees{/user}","branches_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/branches{/branch}","tags_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/tags","blobs_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/languages","stargazers_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/stargazers","contributors_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/contributors","subscribers_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/subscribers","subscription_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/subscription","commits_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/contents/{+path}","compare_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/merges","archive_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/downloads","issues_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/issues{/number}","pulls_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/labels{/name}","releases_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/releases{/id}","deployments_url":"https://api.github.com/repos/ruromero/kie-cloud-operator/deployments","created_at":"2018-11-28T21:36:04Z","updated_at":"2018-12-20T22:22:39Z","pushed_at":"2019-01-02T16:19:04Z","git_url":"git://github.com/ruromero/kie-cloud-operator.git","ssh_url":"git@github.com:ruromero/kie-cloud-operator.git","clone_url":"https://github.com/ruromero/kie-cloud-operator.git","svn_url":"https://github.com/ruromero/kie-cloud-operator","homepage":null,"size":36751,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiegroup:master","ref":"master","sha":"090f09823e8046cad0bf867c4380bfefd1903d5f","user":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":148551039,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1NTEwMzk=","name":"kie-cloud-operator","full_name":"kiegroup/kie-cloud-operator","private":false,"owner":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiegroup/kie-cloud-operator","description":"OCP Operator for KIE","fork":false,"url":"https://api.github.com/repos/kiegroup/kie-cloud-operator","forks_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/forks","keys_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/teams","hooks_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/hooks","issue_events_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/issues/events{/number}","events_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/events","assignees_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/assignees{/user}","branches_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/branches{/branch}","tags_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/tags","blobs_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/languages","stargazers_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/stargazers","contributors_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/contributors","subscribers_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/subscribers","subscription_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/subscription","commits_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/contents/{+path}","compare_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/merges","archive_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/downloads","issues_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/issues{/number}","pulls_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/labels{/name}","releases_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/releases{/id}","deployments_url":"https://api.github.com/repos/kiegroup/kie-cloud-operator/deployments","created_at":"2018-09-12T22:44:04Z","updated_at":"2018-12-20T02:35:22Z","pushed_at":"2019-01-02T16:23:14Z","git_url":"git://github.com/kiegroup/kie-cloud-operator.git","ssh_url":"git@github.com:kiegroup/kie-cloud-operator.git","clone_url":"https://github.com/kiegroup/kie-cloud-operator.git","svn_url":"https://github.com/kiegroup/kie-cloud-operator","homepage":null,"size":36712,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":4,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/36"},"html":{"href":"https://github.com/kiegroup/kie-cloud-operator/pull/36"},"issue":{"href":"https://api.github.com/repos/kiegroup/kie-cloud-operator/issues/36"},"comments":{"href":"https://api.github.com/repos/kiegroup/kie-cloud-operator/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiegroup/kie-cloud-operator/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/kiegroup/kie-cloud-operator/statuses/212d30ae28b7ffe29c3c7ce0775c0054facfe9c8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ruromero"}}