{"action":"created","comment":{"url":"https://api.github.com/repos/rs/SDWebImage/pulls/comments/202594585","pull_request_review_id":137323334,"id":202594585,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjU5NDU4NQ==","diff_hunk":"@@ -118,25 +118,6 @@ - (void)testUIButtonSetBackgroundImageWithURLNormalState {\n     [self waitForExpectationsWithCommonTimeout];\n }\n \n-- (void)testFLAnimatedImageViewSetImageWithURL {\n-    XCTestExpectation *expectation = [self expectationWithDescription:@\"FLAnimatedImageView setImageWithURL\"];\n-    \n-    FLAnimatedImageView *imageView = [[FLAnimatedImageView alloc] init];\n-    NSURL *originalImageURL = [NSURL URLWithString:@\"https://www.interntheory.com/img/loading-small.gif\"];\n-    \n-    [imageView sd_setImageWithURL:originalImageURL\n-                        completed:^(UIImage * _Nullable image, NSError * _Nullable error, SDImageCacheType cacheType, NSURL * _Nullable imageURL) {\n-                            expect(image).toNot.beNil();\n-                            expect(error).to.beNil();\n-                            expect(originalImageURL).to.equal(imageURL);\n-                            \n-                            expect(imageView.animatedImage).toNot.beNil();\n-                            [expectation fulfill];\n-                                }];\n-    [self waitForExpectationsWithCommonTimeout];\n-}\n-#endif","path":"Tests/Tests/SDWebCacheCategoriesTests.m","position":null,"original_position":21,"commit_id":"c797279e70282ae2ee33b8fab934018e9996f731","original_commit_id":"982ade8824adbd5a2ea39bd5f27cd4809400b612","user":{"login":"bpoplauschi","id":154913,"node_id":"MDQ6VXNlcjE1NDkxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/154913?v=4","gravatar_id":"","url":"https://api.github.com/users/bpoplauschi","html_url":"https://github.com/bpoplauschi","followers_url":"https://api.github.com/users/bpoplauschi/followers","following_url":"https://api.github.com/users/bpoplauschi/following{/other_user}","gists_url":"https://api.github.com/users/bpoplauschi/gists{/gist_id}","starred_url":"https://api.github.com/users/bpoplauschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpoplauschi/subscriptions","organizations_url":"https://api.github.com/users/bpoplauschi/orgs","repos_url":"https://api.github.com/users/bpoplauschi/repos","events_url":"https://api.github.com/users/bpoplauschi/events{/privacy}","received_events_url":"https://api.github.com/users/bpoplauschi/received_events","type":"User","site_admin":false},"body":"Fixed with c797279 commit on the `project_move_FLAnimatedImage` branch","created_at":"2018-07-16T07:45:23Z","updated_at":"2018-07-16T07:45:23Z","html_url":"https://github.com/rs/SDWebImage/pull/2385#discussion_r202594585","pull_request_url":"https://api.github.com/repos/rs/SDWebImage/pulls/2385","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/comments/202594585"},"html":{"href":"https://github.com/rs/SDWebImage/pull/2385#discussion_r202594585"},"pull_request":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/2385"}},"in_reply_to_id":202593393},"pull_request":{"url":"https://api.github.com/repos/rs/SDWebImage/pulls/2385","id":201306181,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzA2MTgx","html_url":"https://github.com/rs/SDWebImage/pull/2385","diff_url":"https://github.com/rs/SDWebImage/pull/2385.diff","patch_url":"https://github.com/rs/SDWebImage/pull/2385.patch","issue_url":"https://api.github.com/repos/rs/SDWebImage/issues/2385","number":2385,"state":"open","locked":false,"title":"Remove all FLAnimatedImage from the Core SDWebImage repo. Move the code to SDWebImageFLPlugin repo","user":{"login":"dreampiggy","id":6919743,"node_id":"MDQ6VXNlcjY5MTk3NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/6919743?v=4","gravatar_id":"","url":"https://api.github.com/users/dreampiggy","html_url":"https://github.com/dreampiggy","followers_url":"https://api.github.com/users/dreampiggy/followers","following_url":"https://api.github.com/users/dreampiggy/following{/other_user}","gists_url":"https://api.github.com/users/dreampiggy/gists{/gist_id}","starred_url":"https://api.github.com/users/dreampiggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreampiggy/subscriptions","organizations_url":"https://api.github.com/users/dreampiggy/orgs","repos_url":"https://api.github.com/users/dreampiggy/repos","events_url":"https://api.github.com/users/dreampiggy/events{/privacy}","received_events_url":"https://api.github.com/users/dreampiggy/received_events","type":"User","site_admin":false},"body":"### New Pull Request Checklist\r\n\r\n* [x] I have read and understood the [CONTRIBUTING guide](https://github.com/rs/SDWebImage/blob/master/.github/CONTRIBUTING.md)\r\n* [x] I have read the [Documentation](http://cocoadocs.org/docsets/SDWebImage/)\r\n* [x] I have searched for a similar pull request in the [project](https://github.com/rs/SDWebImage/pulls) and found none\r\n\r\n* [x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)\r\n* [x] I have added the required tests to prove the fix/feature I am adding\r\n* [x] I have updated the documentation (if necessary)\r\n* [x] I have run the tests and they pass\r\n* [x] I have run the lint and it passes (`pod lib lint`)\r\n\r\nThis merge request fixes / reffers to the following issues: #2275 \r\n\r\n### Pull Request Description\r\n\r\nThis PR, move all the `FLAnimatedImage` module integrate code from our SDWebImage main repo, to another standalone repo [SDWebImageFLPlugin](https://github.com/SDWebImage/SDWebImageFLPlugin) instead.\r\n\r\nIn SDWebImage 5.x, we does not need to rely on FLAnimatedImageView to support better GIF animation. We have our [Animated Image Solution](https://github.com/rs/SDWebImage/wiki/Advanced-Usage#animated-image-50), which provide a better performance, support all animated image format, easy to integrate for our framework and allow customization.\r\n\r\nHowever, we should keep a way for our 4.x user who already use FLAnimatedImage deeply. So we provide a plugin for SDWebImage 5.x. The code which contribute to the master branch or the issue will also be transfered there. Let's start doing it.","created_at":"2018-07-13T14:22:56Z","updated_at":"2018-07-16T07:45:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1c5dc7641ab0d509bed7e4c0be7e3bbb5d3bf8b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"skyline75489","id":4710575,"node_id":"MDQ6VXNlcjQ3MTA1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/4710575?v=4","gravatar_id":"","url":"https://api.github.com/users/skyline75489","html_url":"https://github.com/skyline75489","followers_url":"https://api.github.com/users/skyline75489/followers","following_url":"https://api.github.com/users/skyline75489/following{/other_user}","gists_url":"https://api.github.com/users/skyline75489/gists{/gist_id}","starred_url":"https://api.github.com/users/skyline75489/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyline75489/subscriptions","organizations_url":"https://api.github.com/users/skyline75489/orgs","repos_url":"https://api.github.com/users/skyline75489/repos","events_url":"https://api.github.com/users/skyline75489/events{/privacy}","received_events_url":"https://api.github.com/users/skyline75489/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":792650184,"node_id":"MDU6TGFiZWw3OTI2NTAxODQ=","url":"https://api.github.com/repos/rs/SDWebImage/labels/project","name":"project","color":"5d86bf","default":false}],"milestone":{"url":"https://api.github.com/repos/rs/SDWebImage/milestones/15","html_url":"https://github.com/rs/SDWebImage/milestone/15","labels_url":"https://api.github.com/repos/rs/SDWebImage/milestones/15/labels","id":2676459,"node_id":"MDk6TWlsZXN0b25lMjY3NjQ1OQ==","number":15,"title":"5.0.0","description":"5.0.0 beta release","creator":{"login":"bpoplauschi","id":154913,"node_id":"MDQ6VXNlcjE1NDkxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/154913?v=4","gravatar_id":"","url":"https://api.github.com/users/bpoplauschi","html_url":"https://github.com/bpoplauschi","followers_url":"https://api.github.com/users/bpoplauschi/followers","following_url":"https://api.github.com/users/bpoplauschi/following{/other_user}","gists_url":"https://api.github.com/users/bpoplauschi/gists{/gist_id}","starred_url":"https://api.github.com/users/bpoplauschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpoplauschi/subscriptions","organizations_url":"https://api.github.com/users/bpoplauschi/orgs","repos_url":"https://api.github.com/users/bpoplauschi/repos","events_url":"https://api.github.com/users/bpoplauschi/events{/privacy}","received_events_url":"https://api.github.com/users/bpoplauschi/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":57,"state":"open","created_at":"2017-08-02T12:24:08Z","updated_at":"2018-07-13T14:23:32Z","due_on":"2018-08-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/rs/SDWebImage/pulls/2385/commits","review_comments_url":"https://api.github.com/repos/rs/SDWebImage/pulls/2385/comments","review_comment_url":"https://api.github.com/repos/rs/SDWebImage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rs/SDWebImage/issues/2385/comments","statuses_url":"https://api.github.com/repos/rs/SDWebImage/statuses/c797279e70282ae2ee33b8fab934018e9996f731","head":{"label":"dreampiggy:project_move_FLAnimatedImage","ref":"project_move_FLAnimatedImage","sha":"c797279e70282ae2ee33b8fab934018e9996f731","user":{"login":"dreampiggy","id":6919743,"node_id":"MDQ6VXNlcjY5MTk3NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/6919743?v=4","gravatar_id":"","url":"https://api.github.com/users/dreampiggy","html_url":"https://github.com/dreampiggy","followers_url":"https://api.github.com/users/dreampiggy/followers","following_url":"https://api.github.com/users/dreampiggy/following{/other_user}","gists_url":"https://api.github.com/users/dreampiggy/gists{/gist_id}","starred_url":"https://api.github.com/users/dreampiggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreampiggy/subscriptions","organizations_url":"https://api.github.com/users/dreampiggy/orgs","repos_url":"https://api.github.com/users/dreampiggy/repos","events_url":"https://api.github.com/users/dreampiggy/events{/privacy}","received_events_url":"https://api.github.com/users/dreampiggy/received_events","type":"User","site_admin":false},"repo":{"id":95782415,"node_id":"MDEwOlJlcG9zaXRvcnk5NTc4MjQxNQ==","name":"SDWebImage","full_name":"dreampiggy/SDWebImage","owner":{"login":"dreampiggy","id":6919743,"node_id":"MDQ6VXNlcjY5MTk3NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/6919743?v=4","gravatar_id":"","url":"https://api.github.com/users/dreampiggy","html_url":"https://github.com/dreampiggy","followers_url":"https://api.github.com/users/dreampiggy/followers","following_url":"https://api.github.com/users/dreampiggy/following{/other_user}","gists_url":"https://api.github.com/users/dreampiggy/gists{/gist_id}","starred_url":"https://api.github.com/users/dreampiggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreampiggy/subscriptions","organizations_url":"https://api.github.com/users/dreampiggy/orgs","repos_url":"https://api.github.com/users/dreampiggy/repos","events_url":"https://api.github.com/users/dreampiggy/events{/privacy}","received_events_url":"https://api.github.com/users/dreampiggy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dreampiggy/SDWebImage","description":"Asynchronous image downloader with cache support as a UIImageView category","fork":true,"url":"https://api.github.com/repos/dreampiggy/SDWebImage","forks_url":"https://api.github.com/repos/dreampiggy/SDWebImage/forks","keys_url":"https://api.github.com/repos/dreampiggy/SDWebImage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dreampiggy/SDWebImage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dreampiggy/SDWebImage/teams","hooks_url":"https://api.github.com/repos/dreampiggy/SDWebImage/hooks","issue_events_url":"https://api.github.com/repos/dreampiggy/SDWebImage/issues/events{/number}","events_url":"https://api.github.com/repos/dreampiggy/SDWebImage/events","assignees_url":"https://api.github.com/repos/dreampiggy/SDWebImage/assignees{/user}","branches_url":"https://api.github.com/repos/dreampiggy/SDWebImage/branches{/branch}","tags_url":"https://api.github.com/repos/dreampiggy/SDWebImage/tags","blobs_url":"https://api.github.com/repos/dreampiggy/SDWebImage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dreampiggy/SDWebImage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dreampiggy/SDWebImage/git/refs{/sha}","trees_url":"https://api.github.com/repos/dreampiggy/SDWebImage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dreampiggy/SDWebImage/statuses/{sha}","languages_url":"https://api.github.com/repos/dreampiggy/SDWebImage/languages","stargazers_url":"https://api.github.com/repos/dreampiggy/SDWebImage/stargazers","contributors_url":"https://api.github.com/repos/dreampiggy/SDWebImage/contributors","subscribers_url":"https://api.github.com/repos/dreampiggy/SDWebImage/subscribers","subscription_url":"https://api.github.com/repos/dreampiggy/SDWebImage/subscription","commits_url":"https://api.github.com/repos/dreampiggy/SDWebImage/commits{/sha}","git_commits_url":"https://api.github.com/repos/dreampiggy/SDWebImage/git/commits{/sha}","comments_url":"https://api.github.com/repos/dreampiggy/SDWebImage/comments{/number}","issue_comment_url":"https://api.github.com/repos/dreampiggy/SDWebImage/issues/comments{/number}","contents_url":"https://api.github.com/repos/dreampiggy/SDWebImage/contents/{+path}","compare_url":"https://api.github.com/repos/dreampiggy/SDWebImage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dreampiggy/SDWebImage/merges","archive_url":"https://api.github.com/repos/dreampiggy/SDWebImage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dreampiggy/SDWebImage/downloads","issues_url":"https://api.github.com/repos/dreampiggy/SDWebImage/issues{/number}","pulls_url":"https://api.github.com/repos/dreampiggy/SDWebImage/pulls{/number}","milestones_url":"https://api.github.com/repos/dreampiggy/SDWebImage/milestones{/number}","notifications_url":"https://api.github.com/repos/dreampiggy/SDWebImage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dreampiggy/SDWebImage/labels{/name}","releases_url":"https://api.github.com/repos/dreampiggy/SDWebImage/releases{/id}","deployments_url":"https://api.github.com/repos/dreampiggy/SDWebImage/deployments","created_at":"2017-06-29T13:48:41Z","updated_at":"2018-07-12T11:23:11Z","pushed_at":"2018-07-16T07:44:46Z","git_url":"git://github.com/dreampiggy/SDWebImage.git","ssh_url":"git@github.com:dreampiggy/SDWebImage.git","clone_url":"https://github.com/dreampiggy/SDWebImage.git","svn_url":"https://github.com/dreampiggy/SDWebImage","homepage":"http://cocoadocs.org/docsets/SDWebImage","size":8131,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rs:5.x","ref":"5.x","sha":"f8fe88633495f9a95560ed9160d0634f04c071ae","user":{"login":"rs","id":68232,"node_id":"MDQ6VXNlcjY4MjMy","avatar_url":"https://avatars2.githubusercontent.com/u/68232?v=4","gravatar_id":"","url":"https://api.github.com/users/rs","html_url":"https://github.com/rs","followers_url":"https://api.github.com/users/rs/followers","following_url":"https://api.github.com/users/rs/following{/other_user}","gists_url":"https://api.github.com/users/rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs/subscriptions","organizations_url":"https://api.github.com/users/rs/orgs","repos_url":"https://api.github.com/users/rs/repos","events_url":"https://api.github.com/users/rs/events{/privacy}","received_events_url":"https://api.github.com/users/rs/received_events","type":"User","site_admin":false},"repo":{"id":313419,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM0MTk=","name":"SDWebImage","full_name":"rs/SDWebImage","owner":{"login":"rs","id":68232,"node_id":"MDQ6VXNlcjY4MjMy","avatar_url":"https://avatars2.githubusercontent.com/u/68232?v=4","gravatar_id":"","url":"https://api.github.com/users/rs","html_url":"https://github.com/rs","followers_url":"https://api.github.com/users/rs/followers","following_url":"https://api.github.com/users/rs/following{/other_user}","gists_url":"https://api.github.com/users/rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rs/subscriptions","organizations_url":"https://api.github.com/users/rs/orgs","repos_url":"https://api.github.com/users/rs/repos","events_url":"https://api.github.com/users/rs/events{/privacy}","received_events_url":"https://api.github.com/users/rs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rs/SDWebImage","description":"Asynchronous image downloader with cache support as a UIImageView category","fork":false,"url":"https://api.github.com/repos/rs/SDWebImage","forks_url":"https://api.github.com/repos/rs/SDWebImage/forks","keys_url":"https://api.github.com/repos/rs/SDWebImage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rs/SDWebImage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rs/SDWebImage/teams","hooks_url":"https://api.github.com/repos/rs/SDWebImage/hooks","issue_events_url":"https://api.github.com/repos/rs/SDWebImage/issues/events{/number}","events_url":"https://api.github.com/repos/rs/SDWebImage/events","assignees_url":"https://api.github.com/repos/rs/SDWebImage/assignees{/user}","branches_url":"https://api.github.com/repos/rs/SDWebImage/branches{/branch}","tags_url":"https://api.github.com/repos/rs/SDWebImage/tags","blobs_url":"https://api.github.com/repos/rs/SDWebImage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rs/SDWebImage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rs/SDWebImage/git/refs{/sha}","trees_url":"https://api.github.com/repos/rs/SDWebImage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rs/SDWebImage/statuses/{sha}","languages_url":"https://api.github.com/repos/rs/SDWebImage/languages","stargazers_url":"https://api.github.com/repos/rs/SDWebImage/stargazers","contributors_url":"https://api.github.com/repos/rs/SDWebImage/contributors","subscribers_url":"https://api.github.com/repos/rs/SDWebImage/subscribers","subscription_url":"https://api.github.com/repos/rs/SDWebImage/subscription","commits_url":"https://api.github.com/repos/rs/SDWebImage/commits{/sha}","git_commits_url":"https://api.github.com/repos/rs/SDWebImage/git/commits{/sha}","comments_url":"https://api.github.com/repos/rs/SDWebImage/comments{/number}","issue_comment_url":"https://api.github.com/repos/rs/SDWebImage/issues/comments{/number}","contents_url":"https://api.github.com/repos/rs/SDWebImage/contents/{+path}","compare_url":"https://api.github.com/repos/rs/SDWebImage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rs/SDWebImage/merges","archive_url":"https://api.github.com/repos/rs/SDWebImage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rs/SDWebImage/downloads","issues_url":"https://api.github.com/repos/rs/SDWebImage/issues{/number}","pulls_url":"https://api.github.com/repos/rs/SDWebImage/pulls{/number}","milestones_url":"https://api.github.com/repos/rs/SDWebImage/milestones{/number}","notifications_url":"https://api.github.com/repos/rs/SDWebImage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rs/SDWebImage/labels{/name}","releases_url":"https://api.github.com/repos/rs/SDWebImage/releases{/id}","deployments_url":"https://api.github.com/repos/rs/SDWebImage/deployments","created_at":"2009-09-21T17:39:19Z","updated_at":"2018-07-16T03:50:44Z","pushed_at":"2018-07-16T07:44:49Z","git_url":"git://github.com/rs/SDWebImage.git","ssh_url":"git@github.com:rs/SDWebImage.git","clone_url":"https://github.com/rs/SDWebImage.git","svn_url":"https://github.com/rs/SDWebImage","homepage":"http://cocoadocs.org/docsets/SDWebImage","size":8099,"stargazers_count":20173,"watchers_count":20173,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5217,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5217,"open_issues":48,"watchers":20173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/2385"},"html":{"href":"https://github.com/rs/SDWebImage/pull/2385"},"issue":{"href":"https://api.github.com/repos/rs/SDWebImage/issues/2385"},"comments":{"href":"https://api.github.com/repos/rs/SDWebImage/issues/2385/comments"},"review_comments":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/2385/comments"},"review_comment":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rs/SDWebImage/pulls/2385/commits"},"statuses":{"href":"https://api.github.com/repos/rs/SDWebImage/statuses/c797279e70282ae2ee33b8fab934018e9996f731"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bpoplauschi"}}