{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/166998718","pull_request_review_id":95143257,"id":166998718,"diff_hunk":"@@ -98,14 +113,8 @@ public IndexReader newReader()\n         Map<CoordinateReferenceSystem,IndexReader> indexReaders = new HashMap<>();\n         for ( Map.Entry<CoordinateReferenceSystem,SpatialKnownIndex> index : indexMap.entrySet() )\n         {\n-            try\n-            {\n-                indexReaders.put( index.getKey(), index.getValue().getOnlineAccessor(descriptor, samplingConfig).newReader() );\n-            }\n-            catch ( IOException e )\n-            {\n-                e.printStackTrace();\n-            }\n+            // TODO should this be populated here, or delegate to SpatialFusionIndexReader?\n+            indexReaders.put( index.getKey(), index.getValue().newReader( samplingConfig, descriptor ) );","path":"community/kernel/src/main/java/org/neo4j/kernel/impl/index/schema/fusion/SpatialFusionIndexAccessor.java","position":null,"original_position":78,"commit_id":"d8b8044df12d5a0d96e79613fd52249b45a6f278","original_commit_id":"4448de073eff41b12d94fe7be28874f1a895fd4b","user":{"login":"craigtaverner","id":114451,"avatar_url":"https://avatars0.githubusercontent.com/u/114451?v=4","gravatar_id":"","url":"https://api.github.com/users/craigtaverner","html_url":"https://github.com/craigtaverner","followers_url":"https://api.github.com/users/craigtaverner/followers","following_url":"https://api.github.com/users/craigtaverner/following{/other_user}","gists_url":"https://api.github.com/users/craigtaverner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigtaverner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigtaverner/subscriptions","organizations_url":"https://api.github.com/users/craigtaverner/orgs","repos_url":"https://api.github.com/users/craigtaverner/repos","events_url":"https://api.github.com/users/craigtaverner/events{/privacy}","received_events_url":"https://api.github.com/users/craigtaverner/received_events","type":"User","site_admin":false},"body":"Elsewhere we check the mode and complete initialization based on that. Why not here?","created_at":"2018-02-08T16:53:05Z","updated_at":"2018-02-08T17:02:10Z","html_url":"https://github.com/neo4j/neo4j/pull/10702#discussion_r166998718","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/10702","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/166998718"},"html":{"href":"https://github.com/neo4j/neo4j/pull/10702#discussion_r166998718"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/10702"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/10702","id":160504681,"html_url":"https://github.com/neo4j/neo4j/pull/10702","diff_url":"https://github.com/neo4j/neo4j/pull/10702.diff","patch_url":"https://github.com/neo4j/neo4j/pull/10702.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/10702","number":10702,"state":"open","locked":false,"title":"Spatial index functionality","user":{"login":"OliviaYtterbrink","id":979036,"avatar_url":"https://avatars1.githubusercontent.com/u/979036?v=4","gravatar_id":"","url":"https://api.github.com/users/OliviaYtterbrink","html_url":"https://github.com/OliviaYtterbrink","followers_url":"https://api.github.com/users/OliviaYtterbrink/followers","following_url":"https://api.github.com/users/OliviaYtterbrink/following{/other_user}","gists_url":"https://api.github.com/users/OliviaYtterbrink/gists{/gist_id}","starred_url":"https://api.github.com/users/OliviaYtterbrink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OliviaYtterbrink/subscriptions","organizations_url":"https://api.github.com/users/OliviaYtterbrink/orgs","repos_url":"https://api.github.com/users/OliviaYtterbrink/repos","events_url":"https://api.github.com/users/OliviaYtterbrink/events{/privacy}","received_events_url":"https://api.github.com/users/OliviaYtterbrink/received_events","type":"User","site_admin":false},"body":"Builds on #10766 and needs #10780 ","created_at":"2017-12-29T11:23:59Z","updated_at":"2018-02-08T17:02:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48d3f726b88add456f87579bfbb8ae74867cf407","assignee":{"login":"burqen","id":5220077,"avatar_url":"https://avatars2.githubusercontent.com/u/5220077?v=4","gravatar_id":"","url":"https://api.github.com/users/burqen","html_url":"https://github.com/burqen","followers_url":"https://api.github.com/users/burqen/followers","following_url":"https://api.github.com/users/burqen/following{/other_user}","gists_url":"https://api.github.com/users/burqen/gists{/gist_id}","starred_url":"https://api.github.com/users/burqen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burqen/subscriptions","organizations_url":"https://api.github.com/users/burqen/orgs","repos_url":"https://api.github.com/users/burqen/repos","events_url":"https://api.github.com/users/burqen/events{/privacy}","received_events_url":"https://api.github.com/users/burqen/received_events","type":"User","site_admin":false},"assignees":[{"login":"burqen","id":5220077,"avatar_url":"https://avatars2.githubusercontent.com/u/5220077?v=4","gravatar_id":"","url":"https://api.github.com/users/burqen","html_url":"https://github.com/burqen","followers_url":"https://api.github.com/users/burqen/followers","following_url":"https://api.github.com/users/burqen/following{/other_user}","gists_url":"https://api.github.com/users/burqen/gists{/gist_id}","starred_url":"https://api.github.com/users/burqen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burqen/subscriptions","organizations_url":"https://api.github.com/users/burqen/orgs","repos_url":"https://api.github.com/users/burqen/repos","events_url":"https://api.github.com/users/burqen/events{/privacy}","received_events_url":"https://api.github.com/users/burqen/received_events","type":"User","site_admin":false},{"login":"Lojjs","id":7222590,"avatar_url":"https://avatars1.githubusercontent.com/u/7222590?v=4","gravatar_id":"","url":"https://api.github.com/users/Lojjs","html_url":"https://github.com/Lojjs","followers_url":"https://api.github.com/users/Lojjs/followers","following_url":"https://api.github.com/users/Lojjs/following{/other_user}","gists_url":"https://api.github.com/users/Lojjs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lojjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lojjs/subscriptions","organizations_url":"https://api.github.com/users/Lojjs/orgs","repos_url":"https://api.github.com/users/Lojjs/repos","events_url":"https://api.github.com/users/Lojjs/events{/privacy}","received_events_url":"https://api.github.com/users/Lojjs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/10702/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/10702/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/10702/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/d8b8044df12d5a0d96e79613fd52249b45a6f278","head":{"label":"OliviaYtterbrink:3.4-spatial-index","ref":"3.4-spatial-index","sha":"d8b8044df12d5a0d96e79613fd52249b45a6f278","user":{"login":"OliviaYtterbrink","id":979036,"avatar_url":"https://avatars1.githubusercontent.com/u/979036?v=4","gravatar_id":"","url":"https://api.github.com/users/OliviaYtterbrink","html_url":"https://github.com/OliviaYtterbrink","followers_url":"https://api.github.com/users/OliviaYtterbrink/followers","following_url":"https://api.github.com/users/OliviaYtterbrink/following{/other_user}","gists_url":"https://api.github.com/users/OliviaYtterbrink/gists{/gist_id}","starred_url":"https://api.github.com/users/OliviaYtterbrink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OliviaYtterbrink/subscriptions","organizations_url":"https://api.github.com/users/OliviaYtterbrink/orgs","repos_url":"https://api.github.com/users/OliviaYtterbrink/repos","events_url":"https://api.github.com/users/OliviaYtterbrink/events{/privacy}","received_events_url":"https://api.github.com/users/OliviaYtterbrink/received_events","type":"User","site_admin":false},"repo":{"id":49431398,"name":"neo4j","full_name":"OliviaYtterbrink/neo4j","owner":{"login":"OliviaYtterbrink","id":979036,"avatar_url":"https://avatars1.githubusercontent.com/u/979036?v=4","gravatar_id":"","url":"https://api.github.com/users/OliviaYtterbrink","html_url":"https://github.com/OliviaYtterbrink","followers_url":"https://api.github.com/users/OliviaYtterbrink/followers","following_url":"https://api.github.com/users/OliviaYtterbrink/following{/other_user}","gists_url":"https://api.github.com/users/OliviaYtterbrink/gists{/gist_id}","starred_url":"https://api.github.com/users/OliviaYtterbrink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OliviaYtterbrink/subscriptions","organizations_url":"https://api.github.com/users/OliviaYtterbrink/orgs","repos_url":"https://api.github.com/users/OliviaYtterbrink/repos","events_url":"https://api.github.com/users/OliviaYtterbrink/events{/privacy}","received_events_url":"https://api.github.com/users/OliviaYtterbrink/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OliviaYtterbrink/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/OliviaYtterbrink/neo4j","forks_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/forks","keys_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/teams","hooks_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/hooks","issue_events_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/events","assignees_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/tags","blobs_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/languages","stargazers_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/stargazers","contributors_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/contributors","subscribers_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/subscribers","subscription_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/subscription","commits_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/merges","archive_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/downloads","issues_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/OliviaYtterbrink/neo4j/deployments","created_at":"2016-01-11T14:26:12Z","updated_at":"2016-01-11T14:26:35Z","pushed_at":"2018-02-08T14:56:46Z","git_url":"git://github.com/OliviaYtterbrink/neo4j.git","ssh_url":"git@github.com:OliviaYtterbrink/neo4j.git","clone_url":"https://github.com/OliviaYtterbrink/neo4j.git","svn_url":"https://github.com/OliviaYtterbrink/neo4j","homepage":"http://neo4j.com","size":388061,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.2"}},"base":{"label":"neo4j:3.4","ref":"3.4","sha":"1a4d0cba5da3f870d68bcff466f2e06d0be08d23","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2018-02-08T05:11:24Z","pushed_at":"2018-02-08T16:27:57Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":387279,"stargazers_count":4679,"watchers_count":4679,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1274,"mirror_url":null,"archived":false,"open_issues_count":359,"license":null,"forks":1274,"open_issues":359,"watchers":4679,"default_branch":"3.4"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/10702"},"html":{"href":"https://github.com/neo4j/neo4j/pull/10702"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/10702"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/10702/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/10702/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/10702/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/d8b8044df12d5a0d96e79613fd52249b45a6f278"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"craigtaverner"}}