{"action":"opened","number":827,"pull_request":{"url":"https://api.github.com/repos/datawire/ambassador/pulls/827","id":217379108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Mzc5MTA4","html_url":"https://github.com/datawire/ambassador/pull/827","diff_url":"https://github.com/datawire/ambassador/pull/827.diff","patch_url":"https://github.com/datawire/ambassador/pull/827.patch","issue_url":"https://api.github.com/repos/datawire/ambassador/issues/827","number":827,"state":"open","locked":false,"title":"Fix ambassador single namespace in helm chart.","user":{"login":"sarce","id":625175,"node_id":"MDQ6VXNlcjYyNTE3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/625175?v=4","gravatar_id":"","url":"https://api.github.com/users/sarce","html_url":"https://github.com/sarce","followers_url":"https://api.github.com/users/sarce/followers","following_url":"https://api.github.com/users/sarce/following{/other_user}","gists_url":"https://api.github.com/users/sarce/gists{/gist_id}","starred_url":"https://api.github.com/users/sarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarce/subscriptions","organizations_url":"https://api.github.com/users/sarce/orgs","repos_url":"https://api.github.com/users/sarce/repos","events_url":"https://api.github.com/users/sarce/events{/privacy}","received_events_url":"https://api.github.com/users/sarce/received_events","type":"User","site_admin":false},"body":"According to the official documentation (https://www.getambassador.io/reference/running):\r\n`If you only want Ambassador to only work within a single namespace, set AMBASSADOR_SINGLE_NAMESPACE as an environment variable.`\r\n\r\nThe current implementation of the helm chart (in `master`branch) always sets the `AMBASSADOR_SINGLE_NAMESPACE`, so ambassador is not able to watch services in any namespace.\r\n\r\nThis PR fixes the issue doing the `AMBASSADOR_SINGLE_NAMESPACE` variable as optional and also this change is backward-compatible.","created_at":"2018-09-21T19:26:57Z","updated_at":"2018-09-21T19:26:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/datawire/ambassador/pulls/827/commits","review_comments_url":"https://api.github.com/repos/datawire/ambassador/pulls/827/comments","review_comment_url":"https://api.github.com/repos/datawire/ambassador/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datawire/ambassador/issues/827/comments","statuses_url":"https://api.github.com/repos/datawire/ambassador/statuses/4935b148340e23c2df33c3944e1a8b61ad9bd7c8","head":{"label":"sarce:sarce/features/fix-single-namespace","ref":"sarce/features/fix-single-namespace","sha":"4935b148340e23c2df33c3944e1a8b61ad9bd7c8","user":{"login":"sarce","id":625175,"node_id":"MDQ6VXNlcjYyNTE3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/625175?v=4","gravatar_id":"","url":"https://api.github.com/users/sarce","html_url":"https://github.com/sarce","followers_url":"https://api.github.com/users/sarce/followers","following_url":"https://api.github.com/users/sarce/following{/other_user}","gists_url":"https://api.github.com/users/sarce/gists{/gist_id}","starred_url":"https://api.github.com/users/sarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarce/subscriptions","organizations_url":"https://api.github.com/users/sarce/orgs","repos_url":"https://api.github.com/users/sarce/repos","events_url":"https://api.github.com/users/sarce/events{/privacy}","received_events_url":"https://api.github.com/users/sarce/received_events","type":"User","site_admin":false},"repo":{"id":147100810,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxMDA4MTA=","name":"ambassador","full_name":"sarce/ambassador","private":false,"owner":{"login":"sarce","id":625175,"node_id":"MDQ6VXNlcjYyNTE3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/625175?v=4","gravatar_id":"","url":"https://api.github.com/users/sarce","html_url":"https://github.com/sarce","followers_url":"https://api.github.com/users/sarce/followers","following_url":"https://api.github.com/users/sarce/following{/other_user}","gists_url":"https://api.github.com/users/sarce/gists{/gist_id}","starred_url":"https://api.github.com/users/sarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarce/subscriptions","organizations_url":"https://api.github.com/users/sarce/orgs","repos_url":"https://api.github.com/users/sarce/repos","events_url":"https://api.github.com/users/sarce/events{/privacy}","received_events_url":"https://api.github.com/users/sarce/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sarce/ambassador","description":"open source Kubernetes-native API gateway for microservices built on the Envoy Proxy","fork":true,"url":"https://api.github.com/repos/sarce/ambassador","forks_url":"https://api.github.com/repos/sarce/ambassador/forks","keys_url":"https://api.github.com/repos/sarce/ambassador/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarce/ambassador/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarce/ambassador/teams","hooks_url":"https://api.github.com/repos/sarce/ambassador/hooks","issue_events_url":"https://api.github.com/repos/sarce/ambassador/issues/events{/number}","events_url":"https://api.github.com/repos/sarce/ambassador/events","assignees_url":"https://api.github.com/repos/sarce/ambassador/assignees{/user}","branches_url":"https://api.github.com/repos/sarce/ambassador/branches{/branch}","tags_url":"https://api.github.com/repos/sarce/ambassador/tags","blobs_url":"https://api.github.com/repos/sarce/ambassador/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarce/ambassador/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarce/ambassador/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarce/ambassador/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarce/ambassador/statuses/{sha}","languages_url":"https://api.github.com/repos/sarce/ambassador/languages","stargazers_url":"https://api.github.com/repos/sarce/ambassador/stargazers","contributors_url":"https://api.github.com/repos/sarce/ambassador/contributors","subscribers_url":"https://api.github.com/repos/sarce/ambassador/subscribers","subscription_url":"https://api.github.com/repos/sarce/ambassador/subscription","commits_url":"https://api.github.com/repos/sarce/ambassador/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarce/ambassador/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarce/ambassador/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarce/ambassador/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarce/ambassador/contents/{+path}","compare_url":"https://api.github.com/repos/sarce/ambassador/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarce/ambassador/merges","archive_url":"https://api.github.com/repos/sarce/ambassador/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarce/ambassador/downloads","issues_url":"https://api.github.com/repos/sarce/ambassador/issues{/number}","pulls_url":"https://api.github.com/repos/sarce/ambassador/pulls{/number}","milestones_url":"https://api.github.com/repos/sarce/ambassador/milestones{/number}","notifications_url":"https://api.github.com/repos/sarce/ambassador/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarce/ambassador/labels{/name}","releases_url":"https://api.github.com/repos/sarce/ambassador/releases{/id}","deployments_url":"https://api.github.com/repos/sarce/ambassador/deployments","created_at":"2018-09-02T16:06:16Z","updated_at":"2018-09-02T16:06:19Z","pushed_at":"2018-09-21T19:20:02Z","git_url":"git://github.com/sarce/ambassador.git","ssh_url":"git@github.com:sarce/ambassador.git","clone_url":"https://github.com/sarce/ambassador.git","svn_url":"https://github.com/sarce/ambassador","homepage":"https://www.getambassador.io","size":4845,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"datawire:master","ref":"master","sha":"9b6961ad359e3d64f7b25ff41785412f97fc96a3","user":{"login":"datawire","id":9270257,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzAyNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9270257?v=4","gravatar_id":"","url":"https://api.github.com/users/datawire","html_url":"https://github.com/datawire","followers_url":"https://api.github.com/users/datawire/followers","following_url":"https://api.github.com/users/datawire/following{/other_user}","gists_url":"https://api.github.com/users/datawire/gists{/gist_id}","starred_url":"https://api.github.com/users/datawire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datawire/subscriptions","organizations_url":"https://api.github.com/users/datawire/orgs","repos_url":"https://api.github.com/users/datawire/repos","events_url":"https://api.github.com/users/datawire/events{/privacy}","received_events_url":"https://api.github.com/users/datawire/received_events","type":"Organization","site_admin":false},"repo":{"id":86740149,"node_id":"MDEwOlJlcG9zaXRvcnk4Njc0MDE0OQ==","name":"ambassador","full_name":"datawire/ambassador","private":false,"owner":{"login":"datawire","id":9270257,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzAyNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9270257?v=4","gravatar_id":"","url":"https://api.github.com/users/datawire","html_url":"https://github.com/datawire","followers_url":"https://api.github.com/users/datawire/followers","following_url":"https://api.github.com/users/datawire/following{/other_user}","gists_url":"https://api.github.com/users/datawire/gists{/gist_id}","starred_url":"https://api.github.com/users/datawire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datawire/subscriptions","organizations_url":"https://api.github.com/users/datawire/orgs","repos_url":"https://api.github.com/users/datawire/repos","events_url":"https://api.github.com/users/datawire/events{/privacy}","received_events_url":"https://api.github.com/users/datawire/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/datawire/ambassador","description":"open source Kubernetes-native API gateway for microservices built on the Envoy Proxy","fork":false,"url":"https://api.github.com/repos/datawire/ambassador","forks_url":"https://api.github.com/repos/datawire/ambassador/forks","keys_url":"https://api.github.com/repos/datawire/ambassador/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datawire/ambassador/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datawire/ambassador/teams","hooks_url":"https://api.github.com/repos/datawire/ambassador/hooks","issue_events_url":"https://api.github.com/repos/datawire/ambassador/issues/events{/number}","events_url":"https://api.github.com/repos/datawire/ambassador/events","assignees_url":"https://api.github.com/repos/datawire/ambassador/assignees{/user}","branches_url":"https://api.github.com/repos/datawire/ambassador/branches{/branch}","tags_url":"https://api.github.com/repos/datawire/ambassador/tags","blobs_url":"https://api.github.com/repos/datawire/ambassador/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datawire/ambassador/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datawire/ambassador/git/refs{/sha}","trees_url":"https://api.github.com/repos/datawire/ambassador/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datawire/ambassador/statuses/{sha}","languages_url":"https://api.github.com/repos/datawire/ambassador/languages","stargazers_url":"https://api.github.com/repos/datawire/ambassador/stargazers","contributors_url":"https://api.github.com/repos/datawire/ambassador/contributors","subscribers_url":"https://api.github.com/repos/datawire/ambassador/subscribers","subscription_url":"https://api.github.com/repos/datawire/ambassador/subscription","commits_url":"https://api.github.com/repos/datawire/ambassador/commits{/sha}","git_commits_url":"https://api.github.com/repos/datawire/ambassador/git/commits{/sha}","comments_url":"https://api.github.com/repos/datawire/ambassador/comments{/number}","issue_comment_url":"https://api.github.com/repos/datawire/ambassador/issues/comments{/number}","contents_url":"https://api.github.com/repos/datawire/ambassador/contents/{+path}","compare_url":"https://api.github.com/repos/datawire/ambassador/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datawire/ambassador/merges","archive_url":"https://api.github.com/repos/datawire/ambassador/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datawire/ambassador/downloads","issues_url":"https://api.github.com/repos/datawire/ambassador/issues{/number}","pulls_url":"https://api.github.com/repos/datawire/ambassador/pulls{/number}","milestones_url":"https://api.github.com/repos/datawire/ambassador/milestones{/number}","notifications_url":"https://api.github.com/repos/datawire/ambassador/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datawire/ambassador/labels{/name}","releases_url":"https://api.github.com/repos/datawire/ambassador/releases{/id}","deployments_url":"https://api.github.com/repos/datawire/ambassador/deployments","created_at":"2017-03-30T19:22:52Z","updated_at":"2018-09-21T17:08:30Z","pushed_at":"2018-09-21T17:08:33Z","git_url":"git://github.com/datawire/ambassador.git","ssh_url":"git@github.com:datawire/ambassador.git","clone_url":"https://github.com/datawire/ambassador.git","svn_url":"https://github.com/datawire/ambassador","homepage":"https://www.getambassador.io","size":5288,"stargazers_count":1112,"watchers_count":1112,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":124,"open_issues":173,"watchers":1112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datawire/ambassador/pulls/827"},"html":{"href":"https://github.com/datawire/ambassador/pull/827"},"issue":{"href":"https://api.github.com/repos/datawire/ambassador/issues/827"},"comments":{"href":"https://api.github.com/repos/datawire/ambassador/issues/827/comments"},"review_comments":{"href":"https://api.github.com/repos/datawire/ambassador/pulls/827/comments"},"review_comment":{"href":"https://api.github.com/repos/datawire/ambassador/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datawire/ambassador/pulls/827/commits"},"statuses":{"href":"https://api.github.com/repos/datawire/ambassador/statuses/4935b148340e23c2df33c3944e1a8b61ad9bd7c8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"sarce"}}