{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/228338038","pull_request_review_id":168589760,"id":228338038,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODMzODAzOA==","diff_hunk":"@@ -305,13 +324,23 @@ export default class CodeGenerator {\n    *\n    * Since resolve() deep-resolves, we only need to do this once.\n    */\n-  private emitCloudFormationPropertiesOverride(propsType: genspec.CodeName) {\n+  private emitCloudFormationPropertiesOverride(propsType: genspec.CodeName, taggable: boolean) {\n     this.code.openBlock(`public get propertyOverrides(): ${propsType.className}`);\n     this.code.line(`return this.untypedPropertyOverrides;`);\n     this.code.closeBlock();\n+    this.code.line();\n \n     this.code.openBlock('protected renderProperties(properties: any): { [key: string]: any } ');\n-    this.code.line(`return ${genspec.cfnMapperName(propsType).fqn}(${CORE}.resolve(properties));`);\n+    this.code.line(`const resolvedProps = ${CORE}.resolve(properties);`);\n+    if (taggable) {\n+      this.code.line(`const rawTags: ${CORE}.Tag[] = resolvedProps.tags || [];`);","path":"tools/cfn2ts/lib/codegen.ts","position":83,"original_position":83,"commit_id":"a4251ad839c10bb9b16e4d7fdaa16b1cf948baf7","original_commit_id":"a4251ad839c10bb9b16e4d7fdaa16b1cf948baf7","user":{"login":"eladb","id":598796,"node_id":"MDQ6VXNlcjU5ODc5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/598796?v=4","gravatar_id":"","url":"https://api.github.com/users/eladb","html_url":"https://github.com/eladb","followers_url":"https://api.github.com/users/eladb/followers","following_url":"https://api.github.com/users/eladb/following{/other_user}","gists_url":"https://api.github.com/users/eladb/gists{/gist_id}","starred_url":"https://api.github.com/users/eladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladb/subscriptions","organizations_url":"https://api.github.com/users/eladb/orgs","repos_url":"https://api.github.com/users/eladb/repos","events_url":"https://api.github.com/users/eladb/events{/privacy}","received_events_url":"https://api.github.com/users/eladb/received_events","type":"User","site_admin":false},"body":"Can we somehow put this code in `cdk.Resource` instead of generate it?\r\nMaybe we can create a TaggableResource construct and basically just determine if the resource extends Resource or extends TaggableResource, instead of sprinkling generated code around","created_at":"2018-10-25T21:18:25Z","updated_at":"2018-10-25T21:18:34Z","html_url":"https://github.com/awslabs/aws-cdk/pull/1007#discussion_r228338038","pull_request_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1007","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/228338038"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/1007#discussion_r228338038"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1007"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1007","id":225486993,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDg2OTkz","html_url":"https://github.com/awslabs/aws-cdk/pull/1007","diff_url":"https://github.com/awslabs/aws-cdk/pull/1007.diff","patch_url":"https://github.com/awslabs/aws-cdk/pull/1007.patch","issue_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/1007","number":1007,"state":"open","locked":false,"title":"feat(cfn2ts) Add support for Tags on L1 constructs","user":{"login":"moofish32","id":664280,"node_id":"MDQ6VXNlcjY2NDI4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/664280?v=4","gravatar_id":"","url":"https://api.github.com/users/moofish32","html_url":"https://github.com/moofish32","followers_url":"https://api.github.com/users/moofish32/followers","following_url":"https://api.github.com/users/moofish32/following{/other_user}","gists_url":"https://api.github.com/users/moofish32/gists{/gist_id}","starred_url":"https://api.github.com/users/moofish32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moofish32/subscriptions","organizations_url":"https://api.github.com/users/moofish32/orgs","repos_url":"https://api.github.com/users/moofish32/repos","events_url":"https://api.github.com/users/moofish32/events{/privacy}","received_events_url":"https://api.github.com/users/moofish32/received_events","type":"User","site_admin":false},"body":"* If an L1 Resource has a property `Tags` then add support for a\n TagManager\n\n@eladb - This is an initial pass that is working for ec2 and asg. I did\nnot make this a generic aspect capability that others could later\nleverage. I think that is possible, but didn't know what the time line\non these needs were.\n\n- [x] Initial working codegen to support detecting L1s with Tags property\n- [ ] Add support to `Stack` and `App` for tagging\n\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.","created_at":"2018-10-24T17:25:20Z","updated_at":"2018-10-25T21:18:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a8138639562de3bbe495547a429804030f54d6e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1007/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1007/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/1007/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/a4251ad839c10bb9b16e4d7fdaa16b1cf948baf7","head":{"label":"moofish32:f-tags-for-L1s","ref":"f-tags-for-L1s","sha":"a4251ad839c10bb9b16e4d7fdaa16b1cf948baf7","user":{"login":"moofish32","id":664280,"node_id":"MDQ6VXNlcjY2NDI4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/664280?v=4","gravatar_id":"","url":"https://api.github.com/users/moofish32","html_url":"https://github.com/moofish32","followers_url":"https://api.github.com/users/moofish32/followers","following_url":"https://api.github.com/users/moofish32/following{/other_user}","gists_url":"https://api.github.com/users/moofish32/gists{/gist_id}","starred_url":"https://api.github.com/users/moofish32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moofish32/subscriptions","organizations_url":"https://api.github.com/users/moofish32/orgs","repos_url":"https://api.github.com/users/moofish32/repos","events_url":"https://api.github.com/users/moofish32/events{/privacy}","received_events_url":"https://api.github.com/users/moofish32/received_events","type":"User","site_admin":false},"repo":{"id":143065635,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNjU2MzU=","name":"aws-cdk","full_name":"moofish32/aws-cdk","private":false,"owner":{"login":"moofish32","id":664280,"node_id":"MDQ6VXNlcjY2NDI4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/664280?v=4","gravatar_id":"","url":"https://api.github.com/users/moofish32","html_url":"https://github.com/moofish32","followers_url":"https://api.github.com/users/moofish32/followers","following_url":"https://api.github.com/users/moofish32/following{/other_user}","gists_url":"https://api.github.com/users/moofish32/gists{/gist_id}","starred_url":"https://api.github.com/users/moofish32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moofish32/subscriptions","organizations_url":"https://api.github.com/users/moofish32/orgs","repos_url":"https://api.github.com/users/moofish32/repos","events_url":"https://api.github.com/users/moofish32/events{/privacy}","received_events_url":"https://api.github.com/users/moofish32/received_events","type":"User","site_admin":false},"html_url":"https://github.com/moofish32/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":true,"url":"https://api.github.com/repos/moofish32/aws-cdk","forks_url":"https://api.github.com/repos/moofish32/aws-cdk/forks","keys_url":"https://api.github.com/repos/moofish32/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moofish32/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moofish32/aws-cdk/teams","hooks_url":"https://api.github.com/repos/moofish32/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/moofish32/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/moofish32/aws-cdk/events","assignees_url":"https://api.github.com/repos/moofish32/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/moofish32/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/moofish32/aws-cdk/tags","blobs_url":"https://api.github.com/repos/moofish32/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moofish32/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moofish32/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/moofish32/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moofish32/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/moofish32/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/moofish32/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/moofish32/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/moofish32/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/moofish32/aws-cdk/subscription","commits_url":"https://api.github.com/repos/moofish32/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/moofish32/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/moofish32/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/moofish32/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/moofish32/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/moofish32/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moofish32/aws-cdk/merges","archive_url":"https://api.github.com/repos/moofish32/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moofish32/aws-cdk/downloads","issues_url":"https://api.github.com/repos/moofish32/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/moofish32/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/moofish32/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/moofish32/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moofish32/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/moofish32/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/moofish32/aws-cdk/deployments","created_at":"2018-07-31T20:39:17Z","updated_at":"2018-07-31T20:39:21Z","pushed_at":"2018-10-24T21:44:19Z","git_url":"git://github.com/moofish32/aws-cdk.git","ssh_url":"git@github.com:moofish32/aws-cdk.git","clone_url":"https://github.com/moofish32/aws-cdk.git","svn_url":"https://github.com/moofish32/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":55169,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"8c903503d8cbb934a1c2a911279b03b34b0327f7","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105808767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MDg3Njc=","name":"aws-cdk","full_name":"awslabs/aws-cdk","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":false,"url":"https://api.github.com/repos/awslabs/aws-cdk","forks_url":"https://api.github.com/repos/awslabs/aws-cdk/forks","keys_url":"https://api.github.com/repos/awslabs/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-cdk/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-cdk/events","assignees_url":"https://api.github.com/repos/awslabs/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-cdk/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-cdk/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-cdk/merges","archive_url":"https://api.github.com/repos/awslabs/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-cdk/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-cdk/deployments","created_at":"2017-10-04T19:22:36Z","updated_at":"2018-10-25T14:35:17Z","pushed_at":"2018-10-25T16:37:51Z","git_url":"git://github.com/awslabs/aws-cdk.git","ssh_url":"git@github.com:awslabs/aws-cdk.git","clone_url":"https://github.com/awslabs/aws-cdk.git","svn_url":"https://github.com/awslabs/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":127981,"stargazers_count":1027,"watchers_count":1027,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":262,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":79,"open_issues":262,"watchers":1027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1007"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/1007"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/1007"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/1007/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1007/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/1007/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-cdk/statuses/a4251ad839c10bb9b16e4d7fdaa16b1cf948baf7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"eladb"}}