{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70941","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70941/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70941/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70941/events","html_url":"https://github.com/kubernetes/kubernetes/pull/70941","id":379634421,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDI3NDA5","number":70941,"title":"CSI topology e2e tests","user":{"login":"verult","id":1689416,"node_id":"MDQ6VXNlcjE2ODk0MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1689416?v=4","gravatar_id":"","url":"https://api.github.com/users/verult","html_url":"https://github.com/verult","followers_url":"https://api.github.com/users/verult/followers","following_url":"https://api.github.com/users/verult/following{/other_user}","gists_url":"https://api.github.com/users/verult/gists{/gist_id}","starred_url":"https://api.github.com/users/verult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verult/subscriptions","organizations_url":"https://api.github.com/users/verult/orgs","repos_url":"https://api.github.com/users/verult/repos","events_url":"https://api.github.com/users/verult/events{/privacy}","received_events_url":"https://api.github.com/users/verult/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":114528068,"node_id":"MDU6TGFiZWwxMTQ1MjgwNjg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/critical-urgent","name":"priority/critical-urgent","color":"e11d21","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"davidz627","id":5459214,"node_id":"MDQ6VXNlcjU0NTkyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5459214?v=4","gravatar_id":"","url":"https://api.github.com/users/davidz627","html_url":"https://github.com/davidz627","followers_url":"https://api.github.com/users/davidz627/followers","following_url":"https://api.github.com/users/davidz627/following{/other_user}","gists_url":"https://api.github.com/users/davidz627/gists{/gist_id}","starred_url":"https://api.github.com/users/davidz627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidz627/subscriptions","organizations_url":"https://api.github.com/users/davidz627/orgs","repos_url":"https://api.github.com/users/davidz627/repos","events_url":"https://api.github.com/users/davidz627/events{/privacy}","received_events_url":"https://api.github.com/users/davidz627/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidz627","id":5459214,"node_id":"MDQ6VXNlcjU0NTkyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5459214?v=4","gravatar_id":"","url":"https://api.github.com/users/davidz627","html_url":"https://github.com/davidz627","followers_url":"https://api.github.com/users/davidz627/followers","following_url":"https://api.github.com/users/davidz627/following{/other_user}","gists_url":"https://api.github.com/users/davidz627/gists{/gist_id}","starred_url":"https://api.github.com/users/davidz627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidz627/subscriptions","organizations_url":"https://api.github.com/users/davidz627/orgs","repos_url":"https://api.github.com/users/davidz627/repos","events_url":"https://api.github.com/users/davidz627/events{/privacy}","received_events_url":"https://api.github.com/users/davidz627/received_events","type":"User","site_admin":false},{"login":"ddebroy","id":22652369,"node_id":"MDQ6VXNlcjIyNjUyMzY5","avatar_url":"https://avatars2.githubusercontent.com/u/22652369?v=4","gravatar_id":"","url":"https://api.github.com/users/ddebroy","html_url":"https://github.com/ddebroy","followers_url":"https://api.github.com/users/ddebroy/followers","following_url":"https://api.github.com/users/ddebroy/following{/other_user}","gists_url":"https://api.github.com/users/ddebroy/gists{/gist_id}","starred_url":"https://api.github.com/users/ddebroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddebroy/subscriptions","organizations_url":"https://api.github.com/users/ddebroy/orgs","repos_url":"https://api.github.com/users/ddebroy/repos","events_url":"https://api.github.com/users/ddebroy/events{/privacy}","received_events_url":"https://api.github.com/users/ddebroy/received_events","type":"User","site_admin":false},{"login":"msau42","id":24448061,"node_id":"MDQ6VXNlcjI0NDQ4MDYx","avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-11-12T06:08:53Z","updated_at":"2018-12-13T21:41:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70941","html_url":"https://github.com/kubernetes/kubernetes/pull/70941","diff_url":"https://github.com/kubernetes/kubernetes/pull/70941.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70941.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n/kind bug\r\n\r\n**What this PR does / why we need it**: Adds CSI e2e tests for topology, using the GCE PD driver.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #69703\r\n\r\n**Special notes for your reviewer**:\r\n* Since the `CSINodeInfo` object has a breaking change, these e2e tests now depend on external-provisioner and external-attacher versions 0.5.x and later. Version 0.4 uses the old CSINodeInfo object. As a result these tests will fail until 0.5 is released. Also, since external-provisioner 0.5 enables Topology by default, there's no need to explicitly set the Topology feature gate in these e2e tests.\r\n* Given time constraints I've deferred fully integrating with the storage e2e testing framework for now.\r\n* Currently these tests fail, but I verified the tests pass without the `CSINodeInfo` change and before rebasing with the new e2e framework. Currently working on verifying them with the e2e framework change.\r\n* Since Topology will be enabled on external-provisioner by default, in CSI provisioning tests it's no longer necessary if the GCE PD driver is multi-zone.\r\n\r\n**Does this PR introduce a user-facing change?**: No\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nNONE\r\n```\r\n\r\n/priority critical-urgent\r\n/sig storage\r\n/assign @msau42 @ddebroy @davidz627 \r\n/cc @mkimuram "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/447130868","html_url":"https://github.com/kubernetes/kubernetes/pull/70941#issuecomment-447130868","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70941","id":447130868,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzEzMDg2OA==","user":{"login":"verult","id":1689416,"node_id":"MDQ6VXNlcjE2ODk0MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1689416?v=4","gravatar_id":"","url":"https://api.github.com/users/verult","html_url":"https://github.com/verult","followers_url":"https://api.github.com/users/verult/followers","following_url":"https://api.github.com/users/verult/following{/other_user}","gists_url":"https://api.github.com/users/verult/gists{/gist_id}","starred_url":"https://api.github.com/users/verult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verult/subscriptions","organizations_url":"https://api.github.com/users/verult/orgs","repos_url":"https://api.github.com/users/verult/repos","events_url":"https://api.github.com/users/verult/events{/privacy}","received_events_url":"https://api.github.com/users/verult/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T21:41:42Z","updated_at":"2018-12-13T21:41:42Z","author_association":"CONTRIBUTOR","body":"/retest"}}
{"actor":{"display_login":"verult"}}