{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/comments/205684098","pull_request_review_id":141003762,"id":205684098,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTY4NDA5OA==","diff_hunk":"@@ -1,13 +1,21 @@\n+% RUNC-PS(8) runc-ps Man Pages\n+\n # NAME\n-   runc ps - ps displays the processes running inside a container\n+**runc** **ps** - ps displays the processes running inside a container\n \n # SYNOPSIS\n-   runc ps [command options] <container-id> [ps options]\n+**runc** **ps** [_command options_] <_container-id_> [_format descriptors_]","path":"man/runc-ps.8.md","position":9,"original_position":9,"commit_id":"eaf047dfc16418c8b9d2ab78e36dc9b4cd2b5156","original_commit_id":"eaf047dfc16418c8b9d2ab78e36dc9b4cd2b5156","user":{"login":"marcov","id":424592,"node_id":"MDQ6VXNlcjQyNDU5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/424592?v=4","gravatar_id":"","url":"https://api.github.com/users/marcov","html_url":"https://github.com/marcov","followers_url":"https://api.github.com/users/marcov/followers","following_url":"https://api.github.com/users/marcov/following{/other_user}","gists_url":"https://api.github.com/users/marcov/gists{/gist_id}","starred_url":"https://api.github.com/users/marcov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcov/subscriptions","organizations_url":"https://api.github.com/users/marcov/orgs","repos_url":"https://api.github.com/users/marcov/repos","events_url":"https://api.github.com/users/marcov/events{/privacy}","received_events_url":"https://api.github.com/users/marcov/received_events","type":"User","site_admin":false},"body":"That's correct, with the proposed change `runc ps` would not accept `[ps options]` anymore. This is because the `ps` command execution is replace with calls to the  psgo API, and psgo is not meant to be a clone of `ps`.\r\n","created_at":"2018-07-27T07:02:25Z","updated_at":"2018-07-27T07:02:26Z","html_url":"https://github.com/opencontainers/runc/pull/1852#discussion_r205684098","pull_request_url":"https://api.github.com/repos/opencontainers/runc/pulls/1852","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments/205684098"},"html":{"href":"https://github.com/opencontainers/runc/pull/1852#discussion_r205684098"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1852"}},"in_reply_to_id":205668933},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/1852","id":204193777,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTkzNzc3","html_url":"https://github.com/opencontainers/runc/pull/1852","diff_url":"https://github.com/opencontainers/runc/pull/1852.diff","patch_url":"https://github.com/opencontainers/runc/pull/1852.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/1852","number":1852,"state":"open","locked":false,"title":"Refactor ps.go to use psgo library","user":{"login":"marcov","id":424592,"node_id":"MDQ6VXNlcjQyNDU5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/424592?v=4","gravatar_id":"","url":"https://api.github.com/users/marcov","html_url":"https://github.com/marcov","followers_url":"https://api.github.com/users/marcov/followers","following_url":"https://api.github.com/users/marcov/following{/other_user}","gists_url":"https://api.github.com/users/marcov/gists{/gist_id}","starred_url":"https://api.github.com/users/marcov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcov/subscriptions","organizations_url":"https://api.github.com/users/marcov/orgs","repos_url":"https://api.github.com/users/marcov/repos","events_url":"https://api.github.com/users/marcov/events{/privacy}","received_events_url":"https://api.github.com/users/marcov/received_events","type":"User","site_admin":false},"body":" * Refactor `ps.go` to use the psgo APIs instead of `exec.Command(\"ps\", psArgs...)`\r\n * Add to runc ps the *--print-descriptors* boolean flag to retrieve all\r\n   available format descriptors supported by psgo\r\n * Update tests and documentation\r\n * Add psgo to the vendored libraries (required by tests)\r\n\r\nFixes: #1851\r\nSigned-off-by: Marco Vedovati <mvedovati@suse.com>","created_at":"2018-07-26T16:11:23Z","updated_at":"2018-07-27T07:02:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e574eedcbbc7fc18a776e63976457a744a197cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/1852/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/1852/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/1852/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/eaf047dfc16418c8b9d2ab78e36dc9b4cd2b5156","head":{"label":"marcov:1851-psgo","ref":"1851-psgo","sha":"eaf047dfc16418c8b9d2ab78e36dc9b4cd2b5156","user":{"login":"marcov","id":424592,"node_id":"MDQ6VXNlcjQyNDU5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/424592?v=4","gravatar_id":"","url":"https://api.github.com/users/marcov","html_url":"https://github.com/marcov","followers_url":"https://api.github.com/users/marcov/followers","following_url":"https://api.github.com/users/marcov/following{/other_user}","gists_url":"https://api.github.com/users/marcov/gists{/gist_id}","starred_url":"https://api.github.com/users/marcov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcov/subscriptions","organizations_url":"https://api.github.com/users/marcov/orgs","repos_url":"https://api.github.com/users/marcov/repos","events_url":"https://api.github.com/users/marcov/events{/privacy}","received_events_url":"https://api.github.com/users/marcov/received_events","type":"User","site_admin":false},"repo":{"id":142422607,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0MjI2MDc=","name":"runc","full_name":"marcov/runc","owner":{"login":"marcov","id":424592,"node_id":"MDQ6VXNlcjQyNDU5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/424592?v=4","gravatar_id":"","url":"https://api.github.com/users/marcov","html_url":"https://github.com/marcov","followers_url":"https://api.github.com/users/marcov/followers","following_url":"https://api.github.com/users/marcov/following{/other_user}","gists_url":"https://api.github.com/users/marcov/gists{/gist_id}","starred_url":"https://api.github.com/users/marcov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcov/subscriptions","organizations_url":"https://api.github.com/users/marcov/orgs","repos_url":"https://api.github.com/users/marcov/repos","events_url":"https://api.github.com/users/marcov/events{/privacy}","received_events_url":"https://api.github.com/users/marcov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcov/runc","description":"CLI tool for spawning and running containers according to the OCI specification","fork":true,"url":"https://api.github.com/repos/marcov/runc","forks_url":"https://api.github.com/repos/marcov/runc/forks","keys_url":"https://api.github.com/repos/marcov/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcov/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcov/runc/teams","hooks_url":"https://api.github.com/repos/marcov/runc/hooks","issue_events_url":"https://api.github.com/repos/marcov/runc/issues/events{/number}","events_url":"https://api.github.com/repos/marcov/runc/events","assignees_url":"https://api.github.com/repos/marcov/runc/assignees{/user}","branches_url":"https://api.github.com/repos/marcov/runc/branches{/branch}","tags_url":"https://api.github.com/repos/marcov/runc/tags","blobs_url":"https://api.github.com/repos/marcov/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcov/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcov/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcov/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcov/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/marcov/runc/languages","stargazers_url":"https://api.github.com/repos/marcov/runc/stargazers","contributors_url":"https://api.github.com/repos/marcov/runc/contributors","subscribers_url":"https://api.github.com/repos/marcov/runc/subscribers","subscription_url":"https://api.github.com/repos/marcov/runc/subscription","commits_url":"https://api.github.com/repos/marcov/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcov/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcov/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcov/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcov/runc/contents/{+path}","compare_url":"https://api.github.com/repos/marcov/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcov/runc/merges","archive_url":"https://api.github.com/repos/marcov/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcov/runc/downloads","issues_url":"https://api.github.com/repos/marcov/runc/issues{/number}","pulls_url":"https://api.github.com/repos/marcov/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/marcov/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/marcov/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcov/runc/labels{/name}","releases_url":"https://api.github.com/repos/marcov/runc/releases{/id}","deployments_url":"https://api.github.com/repos/marcov/runc/deployments","created_at":"2018-07-26T09:57:26Z","updated_at":"2018-07-26T09:57:29Z","pushed_at":"2018-07-26T16:09:12Z","git_url":"git://github.com/marcov/runc.git","ssh_url":"git@github.com:marcov/runc.git","clone_url":"https://github.com/marcov/runc.git","svn_url":"https://github.com/marcov/runc","homepage":"https://www.opencontainers.org/","size":6384,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"b4e2ecb452d9ee4381137cc0a7e6715b96bed6de","user":{"login":"opencontainers","id":12563465,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTYzNDY1","avatar_url":"https://avatars1.githubusercontent.com/u/12563465?v=4","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk2MDMyMQ==","name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTYzNDY1","avatar_url":"https://avatars1.githubusercontent.com/u/12563465?v=4","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"CLI tool for spawning and running containers according to the OCI specification","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/runc/deployments","created_at":"2015-06-05T23:30:45Z","updated_at":"2018-07-26T20:50:34Z","pushed_at":"2018-07-26T16:11:24Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"https://www.opencontainers.org/","size":6363,"stargazers_count":4894,"watchers_count":4894,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":882,"mirror_url":null,"archived":false,"open_issues_count":201,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":882,"open_issues":201,"watchers":4894,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1852"},"html":{"href":"https://github.com/opencontainers/runc/pull/1852"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/1852"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/1852/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1852/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1852/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/eaf047dfc16418c8b9d2ab78e36dc9b4cd2b5156"}},"author_association":"NONE"}}
{"actor":{"display_login":"marcov"}}