{"action":"closed","number":710,"pull_request":{"url":"https://api.github.com/repos/Netflix/conductor/pulls/710","id":207459844,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDU5ODQ0","html_url":"https://github.com/Netflix/conductor/pull/710","diff_url":"https://github.com/Netflix/conductor/pull/710.diff","patch_url":"https://github.com/Netflix/conductor/pull/710.patch","issue_url":"https://api.github.com/repos/Netflix/conductor/issues/710","number":710,"state":"closed","locked":false,"title":"Refactor/improve api error handling","user":{"login":"falu2010-netflix","id":40778896,"node_id":"MDQ6VXNlcjQwNzc4ODk2","avatar_url":"https://avatars1.githubusercontent.com/u/40778896?v=4","gravatar_id":"","url":"https://api.github.com/users/falu2010-netflix","html_url":"https://github.com/falu2010-netflix","followers_url":"https://api.github.com/users/falu2010-netflix/followers","following_url":"https://api.github.com/users/falu2010-netflix/following{/other_user}","gists_url":"https://api.github.com/users/falu2010-netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/falu2010-netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falu2010-netflix/subscriptions","organizations_url":"https://api.github.com/users/falu2010-netflix/orgs","repos_url":"https://api.github.com/users/falu2010-netflix/repos","events_url":"https://api.github.com/users/falu2010-netflix/events{/privacy}","received_events_url":"https://api.github.com/users/falu2010-netflix/received_events","type":"User","site_admin":false},"body":"Description:\r\n\r\n- Moved business logic form WorkflowResource to service layer in WorkflowResourceInfo class.\r\n\r\n- Added ConductorClientException in Conductor java client which consist of status code and error message.\r\n\r\n- Returns 404 instead of 204 when resource is not found\r\n\r\n- For null parameters 400 is sent instead of 500\r\n","created_at":"2018-08-09T22:19:46Z","updated_at":"2018-08-15T22:51:03Z","closed_at":"2018-08-15T22:51:03Z","merged_at":"2018-08-15T22:51:03Z","merge_commit_sha":"70bfd625f787a638bdcaa741908a1cc3ce206f80","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":912725386,"node_id":"MDU6TGFiZWw5MTI3MjUzODY=","url":"https://api.github.com/repos/Netflix/conductor/labels/work_in_progress","name":"work_in_progress","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/conductor/pulls/710/commits","review_comments_url":"https://api.github.com/repos/Netflix/conductor/pulls/710/comments","review_comment_url":"https://api.github.com/repos/Netflix/conductor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/conductor/issues/710/comments","statuses_url":"https://api.github.com/repos/Netflix/conductor/statuses/2d919aa89072091ccc0bd18d0b4d65a9bc3330b2","head":{"label":"Netflix:refactor/improve_api_error_handling","ref":"refactor/improve_api_error_handling","sha":"2d919aa89072091ccc0bd18d0b4d65a9bc3330b2","user":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":75882172,"node_id":"MDEwOlJlcG9zaXRvcnk3NTg4MjE3Mg==","name":"conductor","full_name":"Netflix/conductor","owner":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/conductor","description":"Conductor is a microservices orchestration engine - https://netflix.github.io/conductor/ ","fork":false,"url":"https://api.github.com/repos/Netflix/conductor","forks_url":"https://api.github.com/repos/Netflix/conductor/forks","keys_url":"https://api.github.com/repos/Netflix/conductor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/conductor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/conductor/teams","hooks_url":"https://api.github.com/repos/Netflix/conductor/hooks","issue_events_url":"https://api.github.com/repos/Netflix/conductor/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/conductor/events","assignees_url":"https://api.github.com/repos/Netflix/conductor/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/conductor/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/conductor/tags","blobs_url":"https://api.github.com/repos/Netflix/conductor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/conductor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/conductor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/conductor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/conductor/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/conductor/languages","stargazers_url":"https://api.github.com/repos/Netflix/conductor/stargazers","contributors_url":"https://api.github.com/repos/Netflix/conductor/contributors","subscribers_url":"https://api.github.com/repos/Netflix/conductor/subscribers","subscription_url":"https://api.github.com/repos/Netflix/conductor/subscription","commits_url":"https://api.github.com/repos/Netflix/conductor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/conductor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/conductor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/conductor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/conductor/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/conductor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/conductor/merges","archive_url":"https://api.github.com/repos/Netflix/conductor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/conductor/downloads","issues_url":"https://api.github.com/repos/Netflix/conductor/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/conductor/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/conductor/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/conductor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/conductor/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/conductor/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/conductor/deployments","created_at":"2016-12-07T22:48:42Z","updated_at":"2018-08-14T14:06:56Z","pushed_at":"2018-08-15T22:51:03Z","git_url":"git://github.com/Netflix/conductor.git","ssh_url":"git@github.com:Netflix/conductor.git","clone_url":"https://github.com/Netflix/conductor.git","svn_url":"https://github.com/Netflix/conductor","homepage":"","size":6260,"stargazers_count":1297,"watchers_count":1297,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":331,"mirror_url":null,"archived":false,"open_issues_count":178,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":331,"open_issues":178,"watchers":1297,"default_branch":"master"}},"base":{"label":"Netflix:dev","ref":"dev","sha":"c3900e98d55ccb0d4ee8b5e12792e99fa3e7be9b","user":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":75882172,"node_id":"MDEwOlJlcG9zaXRvcnk3NTg4MjE3Mg==","name":"conductor","full_name":"Netflix/conductor","owner":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/conductor","description":"Conductor is a microservices orchestration engine - https://netflix.github.io/conductor/ ","fork":false,"url":"https://api.github.com/repos/Netflix/conductor","forks_url":"https://api.github.com/repos/Netflix/conductor/forks","keys_url":"https://api.github.com/repos/Netflix/conductor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/conductor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/conductor/teams","hooks_url":"https://api.github.com/repos/Netflix/conductor/hooks","issue_events_url":"https://api.github.com/repos/Netflix/conductor/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/conductor/events","assignees_url":"https://api.github.com/repos/Netflix/conductor/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/conductor/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/conductor/tags","blobs_url":"https://api.github.com/repos/Netflix/conductor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/conductor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/conductor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/conductor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/conductor/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/conductor/languages","stargazers_url":"https://api.github.com/repos/Netflix/conductor/stargazers","contributors_url":"https://api.github.com/repos/Netflix/conductor/contributors","subscribers_url":"https://api.github.com/repos/Netflix/conductor/subscribers","subscription_url":"https://api.github.com/repos/Netflix/conductor/subscription","commits_url":"https://api.github.com/repos/Netflix/conductor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/conductor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/conductor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/conductor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/conductor/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/conductor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/conductor/merges","archive_url":"https://api.github.com/repos/Netflix/conductor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/conductor/downloads","issues_url":"https://api.github.com/repos/Netflix/conductor/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/conductor/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/conductor/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/conductor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/conductor/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/conductor/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/conductor/deployments","created_at":"2016-12-07T22:48:42Z","updated_at":"2018-08-14T14:06:56Z","pushed_at":"2018-08-15T22:51:03Z","git_url":"git://github.com/Netflix/conductor.git","ssh_url":"git@github.com:Netflix/conductor.git","clone_url":"https://github.com/Netflix/conductor.git","svn_url":"https://github.com/Netflix/conductor","homepage":"","size":6260,"stargazers_count":1297,"watchers_count":1297,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":331,"mirror_url":null,"archived":false,"open_issues_count":178,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":331,"open_issues":178,"watchers":1297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/conductor/pulls/710"},"html":{"href":"https://github.com/Netflix/conductor/pull/710"},"issue":{"href":"https://api.github.com/repos/Netflix/conductor/issues/710"},"comments":{"href":"https://api.github.com/repos/Netflix/conductor/issues/710/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/conductor/pulls/710/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/conductor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/conductor/pulls/710/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/conductor/statuses/2d919aa89072091ccc0bd18d0b4d65a9bc3330b2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"falu2010-netflix","id":40778896,"node_id":"MDQ6VXNlcjQwNzc4ODk2","avatar_url":"https://avatars1.githubusercontent.com/u/40778896?v=4","gravatar_id":"","url":"https://api.github.com/users/falu2010-netflix","html_url":"https://github.com/falu2010-netflix","followers_url":"https://api.github.com/users/falu2010-netflix/followers","following_url":"https://api.github.com/users/falu2010-netflix/following{/other_user}","gists_url":"https://api.github.com/users/falu2010-netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/falu2010-netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falu2010-netflix/subscriptions","organizations_url":"https://api.github.com/users/falu2010-netflix/orgs","repos_url":"https://api.github.com/users/falu2010-netflix/repos","events_url":"https://api.github.com/users/falu2010-netflix/events{/privacy}","received_events_url":"https://api.github.com/users/falu2010-netflix/received_events","type":"User","site_admin":false},"comments":0,"review_comments":63,"maintainer_can_modify":false,"commits":24,"additions":2830,"deletions":661,"changed_files":31}}
{"actor":{"display_login":"falu2010-netflix"}}