{"action":"created","comment":{"url":"https://api.github.com/repos/Keydonix/geth-clique/pulls/comments/195965068","pull_request_review_id":129427576,"id":195965068,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTk2NTA2OA==","diff_hunk":"@@ -1,65 +1,13 @@\n #!/bin/bash\n \n-RPCPORT=8545\n-WSPORT=8546\n-if [[ \"${ROOT}\" == \"\" ]] ; then ROOT=\"/geth\" ; fi\n-[[ \"${UNLOCK_ACCOUNT}\" != \"\" ]] || UNLOCK_ACCOUNT=\"0x913da4198e6be1d5f5e4a40d0667f70c0b5430eb\"\n-\n-ROOT=$(readlink -f $ROOT)\n-\n-source ./common_start.sh\n-\n-node_start() {\n-  # geth is dumb and won't let us run it in the background, and nohup redirects to file when run in a script\n-\n-  nohup geth \\\n-    --networkid \"$(cat \"$ROOT/networkid\")\" \\\n-    --datadir \"${ROOT}/chain\" \\\n-    --keystore \"${ROOT}/keys\" \\\n-    --password \"${ROOT}/password.txt\" \\\n-    --unlock \"${UNLOCK_ACCOUNT}\" \\\n-    --verbosity ${GETH_VERBOSITY:-2} --mine \\\n-    --ws --wsapi admin,db,debug,eth,miner,net,personal,shh,txpool,web3 --wsaddr 0.0.0.0 --wsport $WSPORT --wsorigins '*' \\\n-    --rpc --rpcapi admin,db,debug,eth,miner,net,personal,shh,txpool,web3 --rpcaddr 0.0.0.0 --rpcport $RPCPORT --rpccorsdomain '*' --rpcvhosts '*' \\\n-    --nodiscover \\\n-    --targetgaslimit 6500000 < /dev/null > $ROOT/geth.log 2>&1 &\n-  NODE_PID=$!\n-\n-  stdbuf -o0 tail -F $ROOT/geth.log 2>/dev/null &\n-  TAIL_PID=$!\n-}\n-\n-setup_chain_template() {\n-  if [ ! -d \"${ROOT}/chain-template\" ]; then\n-    echo \"Setting up Genesis with Network ID: ${NETWORK_ID:-12346}\"\n-    sed -i'' -r \"s/NETWORK_ID/${NETWORK_ID:-12346}/\" ${ROOT}/genesis.json\n-    geth --nodiscover --datadir \"${ROOT}/chain-template\" --keystore \"${ROOT}/keys\" init \"${ROOT}/genesis.json\"\n-\n-    echo ${NETWORK_ID:-12346} > \"${ROOT}/networkid\"\n-  fi\n-}\n-\n-setup_chain_dir() {\n-  # to enable volume mounts to persist data, we need to take some specific\n-  # actions, detecting when one is present and new, vs present and old\n-  # vs not present\n-  if [ ! -d ${ROOT}/chain ]; then\n-    setup_chain_template\n-    echo \"${ROOT}/chain not mounted, transactions will be ephemeral\"\n-    mv ${ROOT}/chain-template ${ROOT}/chain\n-  else\n-    # Chain dir exists\n-    if [ -d ${ROOT}/chain/geth/chaindata ]; then\n-      if [ ! -f \"${ROOT}/networkid\" ]; then\n-        echo ${NETWORK_ID:-12346} > \"${ROOT}/networkid\"\n-      fi\n-      echo \"${ROOT}/chain-template mounted and has prior blockchain state, restored\"\n-    else\n-      setup_chain_template\n-      echo \"${ROOT}/chain-template mounted, but uninitialized. Copying chaindata template\"\n-      mv ${ROOT}/chain-template/* ${ROOT}/chain\n-    fi\n-  fi\n-}\n-\n-start\n+geth \\","path":"start.sh","position":null,"original_position":66,"commit_id":"a326d8b091630aadbbee1ca04682d18237230dfd","original_commit_id":"5e206e12ef6745cce99feb37e39ba2becfbbdb81","user":{"login":"MicahZoltu","id":886059,"node_id":"MDQ6VXNlcjg4NjA1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/886059?v=4","gravatar_id":"","url":"https://api.github.com/users/MicahZoltu","html_url":"https://github.com/MicahZoltu","followers_url":"https://api.github.com/users/MicahZoltu/followers","following_url":"https://api.github.com/users/MicahZoltu/following{/other_user}","gists_url":"https://api.github.com/users/MicahZoltu/gists{/gist_id}","starred_url":"https://api.github.com/users/MicahZoltu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicahZoltu/subscriptions","organizations_url":"https://api.github.com/users/MicahZoltu/orgs","repos_url":"https://api.github.com/users/MicahZoltu/repos","events_url":"https://api.github.com/users/MicahZoltu/events{/privacy}","received_events_url":"https://api.github.com/users/MicahZoltu/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2018-06-18T04:58:50Z","updated_at":"2018-06-18T04:58:51Z","html_url":"https://github.com/Keydonix/geth-clique/pull/3#discussion_r195965068","pull_request_url":"https://api.github.com/repos/Keydonix/geth-clique/pulls/3","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Keydonix/geth-clique/pulls/comments/195965068"},"html":{"href":"https://github.com/Keydonix/geth-clique/pull/3#discussion_r195965068"},"pull_request":{"href":"https://api.github.com/repos/Keydonix/geth-clique/pulls/3"}},"in_reply_to_id":195964533},"pull_request":{"url":"https://api.github.com/repos/Keydonix/geth-clique/pulls/3","id":195418307,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDE4MzA3","html_url":"https://github.com/Keydonix/geth-clique/pull/3","diff_url":"https://github.com/Keydonix/geth-clique/pull/3.diff","patch_url":"https://github.com/Keydonix/geth-clique/pull/3.patch","issue_url":"https://api.github.com/repos/Keydonix/geth-clique/issues/3","number":3,"state":"open","locked":false,"title":"Greatly simplifies Docker image.","user":{"login":"MicahZoltu","id":886059,"node_id":"MDQ6VXNlcjg4NjA1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/886059?v=4","gravatar_id":"","url":"https://api.github.com/users/MicahZoltu","html_url":"https://github.com/MicahZoltu","followers_url":"https://api.github.com/users/MicahZoltu/followers","following_url":"https://api.github.com/users/MicahZoltu/following{/other_user}","gists_url":"https://api.github.com/users/MicahZoltu/gists{/gist_id}","starred_url":"https://api.github.com/users/MicahZoltu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicahZoltu/subscriptions","organizations_url":"https://api.github.com/users/MicahZoltu/orgs","repos_url":"https://api.github.com/users/MicahZoltu/repos","events_url":"https://api.github.com/users/MicahZoltu/events{/privacy}","received_events_url":"https://api.github.com/users/MicahZoltu/received_events","type":"User","site_admin":false},"body":"Inlines stuff where possible and gets rid of all of the complexity around the start script.\r\n\r\nAlso adds .editorconfig and applies it.  Open to discussion about specific choices.","created_at":"2018-06-18T04:14:30Z","updated_at":"2018-06-18T04:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aeb4edeabe9151b6f95db05bf3a0eff7d5a0489d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Keydonix/geth-clique/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Keydonix/geth-clique/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Keydonix/geth-clique/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Keydonix/geth-clique/issues/3/comments","statuses_url":"https://api.github.com/repos/Keydonix/geth-clique/statuses/a326d8b091630aadbbee1ca04682d18237230dfd","head":{"label":"Keydonix:micah","ref":"micah","sha":"a326d8b091630aadbbee1ca04682d18237230dfd","user":{"login":"Keydonix","id":38863864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODYzODY0","avatar_url":"https://avatars2.githubusercontent.com/u/38863864?v=4","gravatar_id":"","url":"https://api.github.com/users/Keydonix","html_url":"https://github.com/Keydonix","followers_url":"https://api.github.com/users/Keydonix/followers","following_url":"https://api.github.com/users/Keydonix/following{/other_user}","gists_url":"https://api.github.com/users/Keydonix/gists{/gist_id}","starred_url":"https://api.github.com/users/Keydonix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keydonix/subscriptions","organizations_url":"https://api.github.com/users/Keydonix/orgs","repos_url":"https://api.github.com/users/Keydonix/repos","events_url":"https://api.github.com/users/Keydonix/events{/privacy}","received_events_url":"https://api.github.com/users/Keydonix/received_events","type":"Organization","site_admin":false},"repo":{"id":136250030,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyNTAwMzA=","name":"geth-clique","full_name":"Keydonix/geth-clique","owner":{"login":"Keydonix","id":38863864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODYzODY0","avatar_url":"https://avatars2.githubusercontent.com/u/38863864?v=4","gravatar_id":"","url":"https://api.github.com/users/Keydonix","html_url":"https://github.com/Keydonix","followers_url":"https://api.github.com/users/Keydonix/followers","following_url":"https://api.github.com/users/Keydonix/following{/other_user}","gists_url":"https://api.github.com/users/Keydonix/gists{/gist_id}","starred_url":"https://api.github.com/users/Keydonix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keydonix/subscriptions","organizations_url":"https://api.github.com/users/Keydonix/orgs","repos_url":"https://api.github.com/users/Keydonix/repos","events_url":"https://api.github.com/users/Keydonix/events{/privacy}","received_events_url":"https://api.github.com/users/Keydonix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Keydonix/geth-clique","description":null,"fork":false,"url":"https://api.github.com/repos/Keydonix/geth-clique","forks_url":"https://api.github.com/repos/Keydonix/geth-clique/forks","keys_url":"https://api.github.com/repos/Keydonix/geth-clique/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Keydonix/geth-clique/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Keydonix/geth-clique/teams","hooks_url":"https://api.github.com/repos/Keydonix/geth-clique/hooks","issue_events_url":"https://api.github.com/repos/Keydonix/geth-clique/issues/events{/number}","events_url":"https://api.github.com/repos/Keydonix/geth-clique/events","assignees_url":"https://api.github.com/repos/Keydonix/geth-clique/assignees{/user}","branches_url":"https://api.github.com/repos/Keydonix/geth-clique/branches{/branch}","tags_url":"https://api.github.com/repos/Keydonix/geth-clique/tags","blobs_url":"https://api.github.com/repos/Keydonix/geth-clique/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Keydonix/geth-clique/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Keydonix/geth-clique/git/refs{/sha}","trees_url":"https://api.github.com/repos/Keydonix/geth-clique/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Keydonix/geth-clique/statuses/{sha}","languages_url":"https://api.github.com/repos/Keydonix/geth-clique/languages","stargazers_url":"https://api.github.com/repos/Keydonix/geth-clique/stargazers","contributors_url":"https://api.github.com/repos/Keydonix/geth-clique/contributors","subscribers_url":"https://api.github.com/repos/Keydonix/geth-clique/subscribers","subscription_url":"https://api.github.com/repos/Keydonix/geth-clique/subscription","commits_url":"https://api.github.com/repos/Keydonix/geth-clique/commits{/sha}","git_commits_url":"https://api.github.com/repos/Keydonix/geth-clique/git/commits{/sha}","comments_url":"https://api.github.com/repos/Keydonix/geth-clique/comments{/number}","issue_comment_url":"https://api.github.com/repos/Keydonix/geth-clique/issues/comments{/number}","contents_url":"https://api.github.com/repos/Keydonix/geth-clique/contents/{+path}","compare_url":"https://api.github.com/repos/Keydonix/geth-clique/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Keydonix/geth-clique/merges","archive_url":"https://api.github.com/repos/Keydonix/geth-clique/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Keydonix/geth-clique/downloads","issues_url":"https://api.github.com/repos/Keydonix/geth-clique/issues{/number}","pulls_url":"https://api.github.com/repos/Keydonix/geth-clique/pulls{/number}","milestones_url":"https://api.github.com/repos/Keydonix/geth-clique/milestones{/number}","notifications_url":"https://api.github.com/repos/Keydonix/geth-clique/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Keydonix/geth-clique/labels{/name}","releases_url":"https://api.github.com/repos/Keydonix/geth-clique/releases{/id}","deployments_url":"https://api.github.com/repos/Keydonix/geth-clique/deployments","created_at":"2018-06-06T00:30:51Z","updated_at":"2018-06-07T17:55:06Z","pushed_at":"2018-06-18T04:58:51Z","git_url":"git://github.com/Keydonix/geth-clique.git","ssh_url":"git@github.com:Keydonix/geth-clique.git","clone_url":"https://github.com/Keydonix/geth-clique.git","svn_url":"https://github.com/Keydonix/geth-clique","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Keydonix:master","ref":"master","sha":"99c9ee111c3ff771fb2065f03561ba22ce1d0c10","user":{"login":"Keydonix","id":38863864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODYzODY0","avatar_url":"https://avatars2.githubusercontent.com/u/38863864?v=4","gravatar_id":"","url":"https://api.github.com/users/Keydonix","html_url":"https://github.com/Keydonix","followers_url":"https://api.github.com/users/Keydonix/followers","following_url":"https://api.github.com/users/Keydonix/following{/other_user}","gists_url":"https://api.github.com/users/Keydonix/gists{/gist_id}","starred_url":"https://api.github.com/users/Keydonix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keydonix/subscriptions","organizations_url":"https://api.github.com/users/Keydonix/orgs","repos_url":"https://api.github.com/users/Keydonix/repos","events_url":"https://api.github.com/users/Keydonix/events{/privacy}","received_events_url":"https://api.github.com/users/Keydonix/received_events","type":"Organization","site_admin":false},"repo":{"id":136250030,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyNTAwMzA=","name":"geth-clique","full_name":"Keydonix/geth-clique","owner":{"login":"Keydonix","id":38863864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODYzODY0","avatar_url":"https://avatars2.githubusercontent.com/u/38863864?v=4","gravatar_id":"","url":"https://api.github.com/users/Keydonix","html_url":"https://github.com/Keydonix","followers_url":"https://api.github.com/users/Keydonix/followers","following_url":"https://api.github.com/users/Keydonix/following{/other_user}","gists_url":"https://api.github.com/users/Keydonix/gists{/gist_id}","starred_url":"https://api.github.com/users/Keydonix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keydonix/subscriptions","organizations_url":"https://api.github.com/users/Keydonix/orgs","repos_url":"https://api.github.com/users/Keydonix/repos","events_url":"https://api.github.com/users/Keydonix/events{/privacy}","received_events_url":"https://api.github.com/users/Keydonix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Keydonix/geth-clique","description":null,"fork":false,"url":"https://api.github.com/repos/Keydonix/geth-clique","forks_url":"https://api.github.com/repos/Keydonix/geth-clique/forks","keys_url":"https://api.github.com/repos/Keydonix/geth-clique/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Keydonix/geth-clique/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Keydonix/geth-clique/teams","hooks_url":"https://api.github.com/repos/Keydonix/geth-clique/hooks","issue_events_url":"https://api.github.com/repos/Keydonix/geth-clique/issues/events{/number}","events_url":"https://api.github.com/repos/Keydonix/geth-clique/events","assignees_url":"https://api.github.com/repos/Keydonix/geth-clique/assignees{/user}","branches_url":"https://api.github.com/repos/Keydonix/geth-clique/branches{/branch}","tags_url":"https://api.github.com/repos/Keydonix/geth-clique/tags","blobs_url":"https://api.github.com/repos/Keydonix/geth-clique/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Keydonix/geth-clique/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Keydonix/geth-clique/git/refs{/sha}","trees_url":"https://api.github.com/repos/Keydonix/geth-clique/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Keydonix/geth-clique/statuses/{sha}","languages_url":"https://api.github.com/repos/Keydonix/geth-clique/languages","stargazers_url":"https://api.github.com/repos/Keydonix/geth-clique/stargazers","contributors_url":"https://api.github.com/repos/Keydonix/geth-clique/contributors","subscribers_url":"https://api.github.com/repos/Keydonix/geth-clique/subscribers","subscription_url":"https://api.github.com/repos/Keydonix/geth-clique/subscription","commits_url":"https://api.github.com/repos/Keydonix/geth-clique/commits{/sha}","git_commits_url":"https://api.github.com/repos/Keydonix/geth-clique/git/commits{/sha}","comments_url":"https://api.github.com/repos/Keydonix/geth-clique/comments{/number}","issue_comment_url":"https://api.github.com/repos/Keydonix/geth-clique/issues/comments{/number}","contents_url":"https://api.github.com/repos/Keydonix/geth-clique/contents/{+path}","compare_url":"https://api.github.com/repos/Keydonix/geth-clique/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Keydonix/geth-clique/merges","archive_url":"https://api.github.com/repos/Keydonix/geth-clique/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Keydonix/geth-clique/downloads","issues_url":"https://api.github.com/repos/Keydonix/geth-clique/issues{/number}","pulls_url":"https://api.github.com/repos/Keydonix/geth-clique/pulls{/number}","milestones_url":"https://api.github.com/repos/Keydonix/geth-clique/milestones{/number}","notifications_url":"https://api.github.com/repos/Keydonix/geth-clique/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Keydonix/geth-clique/labels{/name}","releases_url":"https://api.github.com/repos/Keydonix/geth-clique/releases{/id}","deployments_url":"https://api.github.com/repos/Keydonix/geth-clique/deployments","created_at":"2018-06-06T00:30:51Z","updated_at":"2018-06-07T17:55:06Z","pushed_at":"2018-06-18T04:58:51Z","git_url":"git://github.com/Keydonix/geth-clique.git","ssh_url":"git@github.com:Keydonix/geth-clique.git","clone_url":"https://github.com/Keydonix/geth-clique.git","svn_url":"https://github.com/Keydonix/geth-clique","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Keydonix/geth-clique/pulls/3"},"html":{"href":"https://github.com/Keydonix/geth-clique/pull/3"},"issue":{"href":"https://api.github.com/repos/Keydonix/geth-clique/issues/3"},"comments":{"href":"https://api.github.com/repos/Keydonix/geth-clique/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Keydonix/geth-clique/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Keydonix/geth-clique/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Keydonix/geth-clique/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Keydonix/geth-clique/statuses/a326d8b091630aadbbee1ca04682d18237230dfd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MicahZoltu"}}