{"action":"created","comment":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments/191078736","pull_request_review_id":123586129,"id":191078736,"diff_hunk":"@@ -656,6 +669,33 @@ else if( o instanceof ItemStack )\n \t\t}\n \t}\n \n+\tpublic static String getFluidDisplayName( Object o )\n+\t{\n+\t\tif( o == null )\n+\t\t{\n+\t\t\treturn \"** Null\";\n+\t\t}\n+\t\tFluidStack fluidStack = null;\n+\t\tif( o instanceof AEFluidStack )\n+\t\t{\n+\t\t\tfluidStack = ( (AEFluidStack) o ).getFluidStack();\n+\t\t}\n+\t\telse if( o instanceof FluidStack )\n+\t\t{\n+\t\t\tfluidStack = (FluidStack) o;\n+\t\t}\n+\t\telse\n+\t\t{\n+\t\t\treturn \"**Invalid Object\";\n+\t\t}\n+\t\tString n = fluidStack.getLocalizedName();\n+\t\tif( n == null || n.equalsIgnoreCase( \"\" ) )","path":"src/main/java/appeng/util/Platform.java","position":67,"original_position":67,"commit_id":"6b9f670387794dec53f7000d5383d752ed81ce81","original_commit_id":"6b9f670387794dec53f7000d5383d752ed81ce81","user":{"login":"orod-org","id":14347709,"avatar_url":"https://avatars0.githubusercontent.com/u/14347709?v=4","gravatar_id":"","url":"https://api.github.com/users/orod-org","html_url":"https://github.com/orod-org","followers_url":"https://api.github.com/users/orod-org/followers","following_url":"https://api.github.com/users/orod-org/following{/other_user}","gists_url":"https://api.github.com/users/orod-org/gists{/gist_id}","starred_url":"https://api.github.com/users/orod-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orod-org/subscriptions","organizations_url":"https://api.github.com/users/orod-org/orgs","repos_url":"https://api.github.com/users/orod-org/repos","events_url":"https://api.github.com/users/orod-org/events{/privacy}","received_events_url":"https://api.github.com/users/orod-org/received_events","type":"User","site_admin":false},"body":"![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') Move the \"\" string literal on the left side of this string comparison. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.orod.org/coding_rules#rule_key=squid%3AS1132)\n","created_at":"2018-05-27T14:43:40Z","updated_at":"2018-05-27T14:43:40Z","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3510#discussion_r191078736","pull_request_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/3510","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments/191078736"},"html":{"href":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3510#discussion_r191078736"},"pull_request":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/3510"}}},"pull_request":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/3510","id":190295490,"html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3510","diff_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3510.diff","patch_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3510.patch","issue_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/3510","number":3510,"state":"open","locked":false,"title":"Finished Fluid Integration ","user":{"login":"BrockWS","id":2309747,"avatar_url":"https://avatars2.githubusercontent.com/u/2309747?v=4","gravatar_id":"","url":"https://api.github.com/users/BrockWS","html_url":"https://github.com/BrockWS","followers_url":"https://api.github.com/users/BrockWS/followers","following_url":"https://api.github.com/users/BrockWS/following{/other_user}","gists_url":"https://api.github.com/users/BrockWS/gists{/gist_id}","starred_url":"https://api.github.com/users/BrockWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrockWS/subscriptions","organizations_url":"https://api.github.com/users/BrockWS/orgs","repos_url":"https://api.github.com/users/BrockWS/repos","events_url":"https://api.github.com/users/BrockWS/events{/privacy}","received_events_url":"https://api.github.com/users/BrockWS/received_events","type":"User","site_admin":false},"body":"Finishes #3341 \r\n\r\nAdds Fluid Import/Export Bus\r\nAdds Fluid Storage Bus\r\nAdds Fluid Terminal\r\n\r\nAll Fluid Buses work like normal Item Buses, just use buckets to set the filters.\r\n\r\nFluid Terminal currently works as follows:\r\n- Left clicking while holding a bucket or tank to fill it up, unless its already full.\r\n- Right clicking while holding a bucket or tank to drain it.\r\n\r\nThis PR does NOT include custom textures.","created_at":"2018-05-24T13:45:37Z","updated_at":"2018-05-27T14:43:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c777aeddfc8ea1541a5c3f24bc15f8ac2a965ebb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/3510/commits","review_comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/3510/comments","review_comment_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/3510/comments","statuses_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/6b9f670387794dec53f7000d5383d752ed81ce81","head":{"label":"BrockWS:feature-fluids","ref":"feature-fluids","sha":"6b9f670387794dec53f7000d5383d752ed81ce81","user":{"login":"BrockWS","id":2309747,"avatar_url":"https://avatars2.githubusercontent.com/u/2309747?v=4","gravatar_id":"","url":"https://api.github.com/users/BrockWS","html_url":"https://github.com/BrockWS","followers_url":"https://api.github.com/users/BrockWS/followers","following_url":"https://api.github.com/users/BrockWS/following{/other_user}","gists_url":"https://api.github.com/users/BrockWS/gists{/gist_id}","starred_url":"https://api.github.com/users/BrockWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrockWS/subscriptions","organizations_url":"https://api.github.com/users/BrockWS/orgs","repos_url":"https://api.github.com/users/BrockWS/repos","events_url":"https://api.github.com/users/BrockWS/events{/privacy}","received_events_url":"https://api.github.com/users/BrockWS/received_events","type":"User","site_admin":false},"repo":{"id":131559624,"name":"Applied-Energistics-2","full_name":"BrockWS/Applied-Energistics-2","owner":{"login":"BrockWS","id":2309747,"avatar_url":"https://avatars2.githubusercontent.com/u/2309747?v=4","gravatar_id":"","url":"https://api.github.com/users/BrockWS","html_url":"https://github.com/BrockWS","followers_url":"https://api.github.com/users/BrockWS/followers","following_url":"https://api.github.com/users/BrockWS/following{/other_user}","gists_url":"https://api.github.com/users/BrockWS/gists{/gist_id}","starred_url":"https://api.github.com/users/BrockWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrockWS/subscriptions","organizations_url":"https://api.github.com/users/BrockWS/orgs","repos_url":"https://api.github.com/users/BrockWS/repos","events_url":"https://api.github.com/users/BrockWS/events{/privacy}","received_events_url":"https://api.github.com/users/BrockWS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrockWS/Applied-Energistics-2","description":"A Minecraft Mod about Matter, Energy and using them to conquer the world..","fork":true,"url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2","forks_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/forks","keys_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/teams","hooks_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/hooks","issue_events_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/issues/events{/number}","events_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/events","assignees_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/assignees{/user}","branches_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/branches{/branch}","tags_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/tags","blobs_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/statuses/{sha}","languages_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/languages","stargazers_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/stargazers","contributors_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/contributors","subscribers_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/subscribers","subscription_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/subscription","commits_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/contents/{+path}","compare_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/merges","archive_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/downloads","issues_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/issues{/number}","pulls_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/pulls{/number}","milestones_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/milestones{/number}","notifications_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/labels{/name}","releases_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/releases{/id}","deployments_url":"https://api.github.com/repos/BrockWS/Applied-Energistics-2/deployments","created_at":"2018-04-30T05:35:35Z","updated_at":"2018-05-27T12:19:32Z","pushed_at":"2018-05-27T12:19:29Z","git_url":"git://github.com/BrockWS/Applied-Energistics-2.git","ssh_url":"git@github.com:BrockWS/Applied-Energistics-2.git","clone_url":"https://github.com/BrockWS/Applied-Energistics-2.git","svn_url":"https://github.com/BrockWS/Applied-Energistics-2","homepage":"http://ae-mod.info/","size":15259,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":5,"watchers":0,"default_branch":"feature-fluids"}},"base":{"label":"AppliedEnergistics:rv6-1.12","ref":"rv6-1.12","sha":"9481c9a7d7b1f28e3241779072c134d47fed91f7","user":{"login":"AppliedEnergistics","id":8868712,"avatar_url":"https://avatars2.githubusercontent.com/u/8868712?v=4","gravatar_id":"","url":"https://api.github.com/users/AppliedEnergistics","html_url":"https://github.com/AppliedEnergistics","followers_url":"https://api.github.com/users/AppliedEnergistics/followers","following_url":"https://api.github.com/users/AppliedEnergistics/following{/other_user}","gists_url":"https://api.github.com/users/AppliedEnergistics/gists{/gist_id}","starred_url":"https://api.github.com/users/AppliedEnergistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppliedEnergistics/subscriptions","organizations_url":"https://api.github.com/users/AppliedEnergistics/orgs","repos_url":"https://api.github.com/users/AppliedEnergistics/repos","events_url":"https://api.github.com/users/AppliedEnergistics/events{/privacy}","received_events_url":"https://api.github.com/users/AppliedEnergistics/received_events","type":"Organization","site_admin":false},"repo":{"id":24395109,"name":"Applied-Energistics-2","full_name":"AppliedEnergistics/Applied-Energistics-2","owner":{"login":"AppliedEnergistics","id":8868712,"avatar_url":"https://avatars2.githubusercontent.com/u/8868712?v=4","gravatar_id":"","url":"https://api.github.com/users/AppliedEnergistics","html_url":"https://github.com/AppliedEnergistics","followers_url":"https://api.github.com/users/AppliedEnergistics/followers","following_url":"https://api.github.com/users/AppliedEnergistics/following{/other_user}","gists_url":"https://api.github.com/users/AppliedEnergistics/gists{/gist_id}","starred_url":"https://api.github.com/users/AppliedEnergistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppliedEnergistics/subscriptions","organizations_url":"https://api.github.com/users/AppliedEnergistics/orgs","repos_url":"https://api.github.com/users/AppliedEnergistics/repos","events_url":"https://api.github.com/users/AppliedEnergistics/events{/privacy}","received_events_url":"https://api.github.com/users/AppliedEnergistics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2","description":"A Minecraft Mod about Matter, Energy and using them to conquer the world..","fork":false,"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2","forks_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/forks","keys_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/teams","hooks_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/hooks","issue_events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/events{/number}","events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/events","assignees_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/assignees{/user}","branches_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/branches{/branch}","tags_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/tags","blobs_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/{sha}","languages_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/languages","stargazers_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/stargazers","contributors_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/contributors","subscribers_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/subscribers","subscription_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/subscription","commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/contents/{+path}","compare_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/merges","archive_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/downloads","issues_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues{/number}","pulls_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls{/number}","milestones_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/milestones{/number}","notifications_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/labels{/name}","releases_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/releases{/id}","deployments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/deployments","created_at":"2014-09-24T00:48:40Z","updated_at":"2018-05-23T11:20:17Z","pushed_at":"2018-05-27T12:19:30Z","git_url":"git://github.com/AppliedEnergistics/Applied-Energistics-2.git","ssh_url":"git@github.com:AppliedEnergistics/Applied-Energistics-2.git","clone_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2.git","svn_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2","homepage":"http://ae-mod.info/","size":15152,"stargazers_count":544,"watchers_count":544,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":241,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":288,"open_issues":241,"watchers":544,"default_branch":"rv5-1.12"}},"_links":{"self":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/3510"},"html":{"href":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/3510"},"issue":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/3510"},"comments":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/3510/comments"},"review_comments":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/3510/comments"},"review_comment":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/3510/commits"},"statuses":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/6b9f670387794dec53f7000d5383d752ed81ce81"}},"author_association":"NONE"}}
{"actor":{"display_login":"orod-org"}}