{"action":"created","comment":{"url":"https://api.github.com/repos/dpkp/kafka-python/pulls/comments/238059820","pull_request_review_id":180520320,"id":238059820,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA1OTgyMA==","diff_hunk":"@@ -357,6 +357,13 @@ def connect(self):\n                 ret = self._sock.connect_ex(self._sock_addr)\n             except socket.error as err:\n                 ret = err.errno\n+            except ValueError as err:\n+                # Python 3.7 and higher raises ValueError if a socket\n+                # is already connected\n+                if sys.version_info >= (3, 7):\n+                    ret = None\n+                else:\n+                    raise err","path":"kafka/conn.py","position":10,"original_position":10,"commit_id":"165ac85d1fbe74c4d37853e3a310f170735139ad","original_commit_id":"165ac85d1fbe74c4d37853e3a310f170735139ad","user":{"login":"jeffwidman","id":483314,"node_id":"MDQ6VXNlcjQ4MzMxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/483314?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffwidman","html_url":"https://github.com/jeffwidman","followers_url":"https://api.github.com/users/jeffwidman/followers","following_url":"https://api.github.com/users/jeffwidman/following{/other_user}","gists_url":"https://api.github.com/users/jeffwidman/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwidman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwidman/subscriptions","organizations_url":"https://api.github.com/users/jeffwidman/orgs","repos_url":"https://api.github.com/users/jeffwidman/repos","events_url":"https://api.github.com/users/jeffwidman/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwidman/received_events","type":"User","site_admin":false},"body":"IIRC, you only need this to be `raise` and it will re-raise the most recent one","created_at":"2018-12-01T10:51:11Z","updated_at":"2018-12-01T10:54:35Z","html_url":"https://github.com/dpkp/kafka-python/pull/1661#discussion_r238059820","pull_request_url":"https://api.github.com/repos/dpkp/kafka-python/pulls/1661","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/comments/238059820"},"html":{"href":"https://github.com/dpkp/kafka-python/pull/1661#discussion_r238059820"},"pull_request":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/1661"}}},"pull_request":{"url":"https://api.github.com/repos/dpkp/kafka-python/pulls/1661","id":234025449,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDI1NDQ5","html_url":"https://github.com/dpkp/kafka-python/pull/1661","diff_url":"https://github.com/dpkp/kafka-python/pull/1661.diff","patch_url":"https://github.com/dpkp/kafka-python/pull/1661.patch","issue_url":"https://api.github.com/repos/dpkp/kafka-python/issues/1661","number":1661,"state":"open","locked":false,"title":"Fix SSL connection testing in Python 3.7","user":{"login":"seanthegeek","id":44679,"node_id":"MDQ6VXNlcjQ0Njc5","avatar_url":"https://avatars3.githubusercontent.com/u/44679?v=4","gravatar_id":"","url":"https://api.github.com/users/seanthegeek","html_url":"https://github.com/seanthegeek","followers_url":"https://api.github.com/users/seanthegeek/followers","following_url":"https://api.github.com/users/seanthegeek/following{/other_user}","gists_url":"https://api.github.com/users/seanthegeek/gists{/gist_id}","starred_url":"https://api.github.com/users/seanthegeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanthegeek/subscriptions","organizations_url":"https://api.github.com/users/seanthegeek/orgs","repos_url":"https://api.github.com/users/seanthegeek/repos","events_url":"https://api.github.com/users/seanthegeek/events{/privacy}","received_events_url":"https://api.github.com/users/seanthegeek/received_events","type":"User","site_admin":false},"body":"Closes issue #1549\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dpkp/kafka-python/1661)\n<!-- Reviewable:end -->\n","created_at":"2018-11-27T19:03:01Z","updated_at":"2018-12-01T10:54:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52e14b5a03cce0dac9688369fb4ad58930fb037c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dpkp/kafka-python/pulls/1661/commits","review_comments_url":"https://api.github.com/repos/dpkp/kafka-python/pulls/1661/comments","review_comment_url":"https://api.github.com/repos/dpkp/kafka-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dpkp/kafka-python/issues/1661/comments","statuses_url":"https://api.github.com/repos/dpkp/kafka-python/statuses/165ac85d1fbe74c4d37853e3a310f170735139ad","head":{"label":"seanthegeek:master","ref":"master","sha":"165ac85d1fbe74c4d37853e3a310f170735139ad","user":{"login":"seanthegeek","id":44679,"node_id":"MDQ6VXNlcjQ0Njc5","avatar_url":"https://avatars3.githubusercontent.com/u/44679?v=4","gravatar_id":"","url":"https://api.github.com/users/seanthegeek","html_url":"https://github.com/seanthegeek","followers_url":"https://api.github.com/users/seanthegeek/followers","following_url":"https://api.github.com/users/seanthegeek/following{/other_user}","gists_url":"https://api.github.com/users/seanthegeek/gists{/gist_id}","starred_url":"https://api.github.com/users/seanthegeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanthegeek/subscriptions","organizations_url":"https://api.github.com/users/seanthegeek/orgs","repos_url":"https://api.github.com/users/seanthegeek/repos","events_url":"https://api.github.com/users/seanthegeek/events{/privacy}","received_events_url":"https://api.github.com/users/seanthegeek/received_events","type":"User","site_admin":false},"repo":{"id":159383717,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzODM3MTc=","name":"kafka-python","full_name":"seanthegeek/kafka-python","private":false,"owner":{"login":"seanthegeek","id":44679,"node_id":"MDQ6VXNlcjQ0Njc5","avatar_url":"https://avatars3.githubusercontent.com/u/44679?v=4","gravatar_id":"","url":"https://api.github.com/users/seanthegeek","html_url":"https://github.com/seanthegeek","followers_url":"https://api.github.com/users/seanthegeek/followers","following_url":"https://api.github.com/users/seanthegeek/following{/other_user}","gists_url":"https://api.github.com/users/seanthegeek/gists{/gist_id}","starred_url":"https://api.github.com/users/seanthegeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanthegeek/subscriptions","organizations_url":"https://api.github.com/users/seanthegeek/orgs","repos_url":"https://api.github.com/users/seanthegeek/repos","events_url":"https://api.github.com/users/seanthegeek/events{/privacy}","received_events_url":"https://api.github.com/users/seanthegeek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/seanthegeek/kafka-python","description":"Python client for Apache Kafka","fork":true,"url":"https://api.github.com/repos/seanthegeek/kafka-python","forks_url":"https://api.github.com/repos/seanthegeek/kafka-python/forks","keys_url":"https://api.github.com/repos/seanthegeek/kafka-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seanthegeek/kafka-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seanthegeek/kafka-python/teams","hooks_url":"https://api.github.com/repos/seanthegeek/kafka-python/hooks","issue_events_url":"https://api.github.com/repos/seanthegeek/kafka-python/issues/events{/number}","events_url":"https://api.github.com/repos/seanthegeek/kafka-python/events","assignees_url":"https://api.github.com/repos/seanthegeek/kafka-python/assignees{/user}","branches_url":"https://api.github.com/repos/seanthegeek/kafka-python/branches{/branch}","tags_url":"https://api.github.com/repos/seanthegeek/kafka-python/tags","blobs_url":"https://api.github.com/repos/seanthegeek/kafka-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seanthegeek/kafka-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seanthegeek/kafka-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/seanthegeek/kafka-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seanthegeek/kafka-python/statuses/{sha}","languages_url":"https://api.github.com/repos/seanthegeek/kafka-python/languages","stargazers_url":"https://api.github.com/repos/seanthegeek/kafka-python/stargazers","contributors_url":"https://api.github.com/repos/seanthegeek/kafka-python/contributors","subscribers_url":"https://api.github.com/repos/seanthegeek/kafka-python/subscribers","subscription_url":"https://api.github.com/repos/seanthegeek/kafka-python/subscription","commits_url":"https://api.github.com/repos/seanthegeek/kafka-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/seanthegeek/kafka-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/seanthegeek/kafka-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/seanthegeek/kafka-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/seanthegeek/kafka-python/contents/{+path}","compare_url":"https://api.github.com/repos/seanthegeek/kafka-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seanthegeek/kafka-python/merges","archive_url":"https://api.github.com/repos/seanthegeek/kafka-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seanthegeek/kafka-python/downloads","issues_url":"https://api.github.com/repos/seanthegeek/kafka-python/issues{/number}","pulls_url":"https://api.github.com/repos/seanthegeek/kafka-python/pulls{/number}","milestones_url":"https://api.github.com/repos/seanthegeek/kafka-python/milestones{/number}","notifications_url":"https://api.github.com/repos/seanthegeek/kafka-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seanthegeek/kafka-python/labels{/name}","releases_url":"https://api.github.com/repos/seanthegeek/kafka-python/releases{/id}","deployments_url":"https://api.github.com/repos/seanthegeek/kafka-python/deployments","created_at":"2018-11-27T18:51:38Z","updated_at":"2018-11-30T19:36:15Z","pushed_at":"2018-11-30T19:36:12Z","git_url":"git://github.com/seanthegeek/kafka-python.git","ssh_url":"git@github.com:seanthegeek/kafka-python.git","clone_url":"https://github.com/seanthegeek/kafka-python.git","svn_url":"https://github.com/seanthegeek/kafka-python","homepage":"http://kafka-python.readthedocs.io/","size":3739,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dpkp:master","ref":"master","sha":"c6d8a536eff6e5ce205badc38b841d3bc27f40f6","user":{"login":"dpkp","id":843444,"node_id":"MDQ6VXNlcjg0MzQ0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/843444?v=4","gravatar_id":"","url":"https://api.github.com/users/dpkp","html_url":"https://github.com/dpkp","followers_url":"https://api.github.com/users/dpkp/followers","following_url":"https://api.github.com/users/dpkp/following{/other_user}","gists_url":"https://api.github.com/users/dpkp/gists{/gist_id}","starred_url":"https://api.github.com/users/dpkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpkp/subscriptions","organizations_url":"https://api.github.com/users/dpkp/orgs","repos_url":"https://api.github.com/users/dpkp/repos","events_url":"https://api.github.com/users/dpkp/events{/privacy}","received_events_url":"https://api.github.com/users/dpkp/received_events","type":"User","site_admin":false},"repo":{"id":5934517,"node_id":"MDEwOlJlcG9zaXRvcnk1OTM0NTE3","name":"kafka-python","full_name":"dpkp/kafka-python","private":false,"owner":{"login":"dpkp","id":843444,"node_id":"MDQ6VXNlcjg0MzQ0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/843444?v=4","gravatar_id":"","url":"https://api.github.com/users/dpkp","html_url":"https://github.com/dpkp","followers_url":"https://api.github.com/users/dpkp/followers","following_url":"https://api.github.com/users/dpkp/following{/other_user}","gists_url":"https://api.github.com/users/dpkp/gists{/gist_id}","starred_url":"https://api.github.com/users/dpkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpkp/subscriptions","organizations_url":"https://api.github.com/users/dpkp/orgs","repos_url":"https://api.github.com/users/dpkp/repos","events_url":"https://api.github.com/users/dpkp/events{/privacy}","received_events_url":"https://api.github.com/users/dpkp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dpkp/kafka-python","description":"Python client for Apache Kafka","fork":false,"url":"https://api.github.com/repos/dpkp/kafka-python","forks_url":"https://api.github.com/repos/dpkp/kafka-python/forks","keys_url":"https://api.github.com/repos/dpkp/kafka-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpkp/kafka-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpkp/kafka-python/teams","hooks_url":"https://api.github.com/repos/dpkp/kafka-python/hooks","issue_events_url":"https://api.github.com/repos/dpkp/kafka-python/issues/events{/number}","events_url":"https://api.github.com/repos/dpkp/kafka-python/events","assignees_url":"https://api.github.com/repos/dpkp/kafka-python/assignees{/user}","branches_url":"https://api.github.com/repos/dpkp/kafka-python/branches{/branch}","tags_url":"https://api.github.com/repos/dpkp/kafka-python/tags","blobs_url":"https://api.github.com/repos/dpkp/kafka-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpkp/kafka-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpkp/kafka-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpkp/kafka-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpkp/kafka-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dpkp/kafka-python/languages","stargazers_url":"https://api.github.com/repos/dpkp/kafka-python/stargazers","contributors_url":"https://api.github.com/repos/dpkp/kafka-python/contributors","subscribers_url":"https://api.github.com/repos/dpkp/kafka-python/subscribers","subscription_url":"https://api.github.com/repos/dpkp/kafka-python/subscription","commits_url":"https://api.github.com/repos/dpkp/kafka-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpkp/kafka-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpkp/kafka-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpkp/kafka-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpkp/kafka-python/contents/{+path}","compare_url":"https://api.github.com/repos/dpkp/kafka-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpkp/kafka-python/merges","archive_url":"https://api.github.com/repos/dpkp/kafka-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpkp/kafka-python/downloads","issues_url":"https://api.github.com/repos/dpkp/kafka-python/issues{/number}","pulls_url":"https://api.github.com/repos/dpkp/kafka-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dpkp/kafka-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dpkp/kafka-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpkp/kafka-python/labels{/name}","releases_url":"https://api.github.com/repos/dpkp/kafka-python/releases{/id}","deployments_url":"https://api.github.com/repos/dpkp/kafka-python/deployments","created_at":"2012-09-24T13:00:26Z","updated_at":"2018-11-30T19:10:28Z","pushed_at":"2018-11-30T19:36:20Z","git_url":"git://github.com/dpkp/kafka-python.git","ssh_url":"git@github.com:dpkp/kafka-python.git","clone_url":"https://github.com/dpkp/kafka-python.git","svn_url":"https://github.com/dpkp/kafka-python","homepage":"http://kafka-python.readthedocs.io/","size":3887,"stargazers_count":2635,"watchers_count":2635,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":800,"mirror_url":null,"archived":false,"open_issues_count":138,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":800,"open_issues":138,"watchers":2635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/1661"},"html":{"href":"https://github.com/dpkp/kafka-python/pull/1661"},"issue":{"href":"https://api.github.com/repos/dpkp/kafka-python/issues/1661"},"comments":{"href":"https://api.github.com/repos/dpkp/kafka-python/issues/1661/comments"},"review_comments":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/1661/comments"},"review_comment":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/1661/commits"},"statuses":{"href":"https://api.github.com/repos/dpkp/kafka-python/statuses/165ac85d1fbe74c4d37853e3a310f170735139ad"}},"author_association":"NONE"}}
{"actor":{"display_login":"jeffwidman"}}