{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/478","repository_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet","labels_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/478/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/478/comments","events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/478/events","html_url":"https://github.com/Microsoft/botbuilder-dotnet/issues/478","id":316315022,"number":478,"title":"QnAMaker: Is using a hardcoded Region in the endpoint string a bug?","user":{"login":"JonathanFingold","id":35047199,"avatar_url":"https://avatars2.githubusercontent.com/u/35047199?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanFingold","html_url":"https://github.com/JonathanFingold","followers_url":"https://api.github.com/users/JonathanFingold/followers","following_url":"https://api.github.com/users/JonathanFingold/following{/other_user}","gists_url":"https://api.github.com/users/JonathanFingold/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanFingold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanFingold/subscriptions","organizations_url":"https://api.github.com/users/JonathanFingold/orgs","repos_url":"https://api.github.com/users/JonathanFingold/repos","events_url":"https://api.github.com/users/JonathanFingold/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanFingold/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-20T15:35:07Z","updated_at":"2018-04-20T21:11:35Z","closed_at":"2018-04-20T21:11:35Z","author_association":"CONTRIBUTOR","body":"Is it a problem for the Region to be hardcoded into the QnA Maker service endpoint?\r\n\r\nWe currently have\r\n\r\n[public const string qnaMakerServiceEndpoint = \"https://westus.api.cognitive.microsoft.com/qnamaker/v3.0/knowledgebases/\";](https://github.com/Microsoft/botbuilder-dotnet/blob/762f76b7188b53607ea55cd05c73781af0911cc4/libraries/Microsoft.Bot.Builder.Ai.QnA/QnAMaker.cs#L14)\r\n\r\nand then this in the constructor:\r\n```csharp\r\n_answerUrl = $\"{qnaMakerServiceEndpoint}{options.KnowledgeBaseId}/generateanswer\";\r\n```"},"comment":{"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/comments/383223681","html_url":"https://github.com/Microsoft/botbuilder-dotnet/issues/478#issuecomment-383223681","issue_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/478","id":383223681,"user":{"login":"cleemullins","id":1165321,"avatar_url":"https://avatars1.githubusercontent.com/u/1165321?v=4","gravatar_id":"","url":"https://api.github.com/users/cleemullins","html_url":"https://github.com/cleemullins","followers_url":"https://api.github.com/users/cleemullins/followers","following_url":"https://api.github.com/users/cleemullins/following{/other_user}","gists_url":"https://api.github.com/users/cleemullins/gists{/gist_id}","starred_url":"https://api.github.com/users/cleemullins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleemullins/subscriptions","organizations_url":"https://api.github.com/users/cleemullins/orgs","repos_url":"https://api.github.com/users/cleemullins/repos","events_url":"https://api.github.com/users/cleemullins/events{/privacy}","received_events_url":"https://api.github.com/users/cleemullins/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T21:11:35Z","updated_at":"2018-04-20T21:11:35Z","author_association":"MEMBER","body":"Every time I see this, I believe it's a bug. Then I reach out to the product team and ask, and they say \"That's correct\". \r\n\r\nSo at this point, it's right. As the product goes GA shortly, that may change. "}}
{"actor":{"display_login":"cleemullins"}}