{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/238395100","pull_request_review_id":180926439,"id":238395100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODM5NTEwMA==","diff_hunk":"@@ -135,89 +192,163 @@ protected override SyntaxList<MemberDeclarationSyntax> GetMemberDeclarationsInCo\n         }\n \n         /// <summary>\n-        /// Try to change the namespace declaration based on the refacoring rules:\n-        ///     - if neither declared and target namespace are \"\" (i.e. global namespace),\n+        /// Try to change the namespace declaration based on the following rules:\n+        ///     - if neither declared nor target namespace are \"\" (i.e. global namespace),\n         ///     then we try to change the name of the namespace.\n         ///     - if declared namespace is \"\", then we try to move all types declared \n         ///     in global namespace in the document into a new namespace declaration.\n         ///     - if target namespace is \"\", then we try to move all members in declared \n         ///     namespace to global namespace (i.e. remove the namespace declaration).    \n         /// </summary>\n         protected override CompilationUnitSyntax ChangeNamespaceDeclaration(\n-            CompilationUnitSyntax compilationUnit, \n+            CompilationUnitSyntax root, \n             ImmutableArray<string> declaredNamespaceParts, \n             ImmutableArray<string> targetNamespaceParts)\n         {\n             Debug.Assert(!declaredNamespaceParts.IsDefault && !targetNamespaceParts.IsDefault);\n+            var container = root.GetAnnotatedNodes(ContainerAnnotation[0]).Single();","path":"src/Features/CSharp/Portable/CodeRefactorings/SyncNamespace/CSharpChangeNamespaceService.cs","position":109,"original_position":109,"commit_id":"0f9a0009774af4132fda0568fa265d32424de786","original_commit_id":"0f9a0009774af4132fda0568fa265d32424de786","user":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"Also... it's indexable... but sounds singular...","created_at":"2018-12-03T18:59:14Z","updated_at":"2018-12-03T18:59:15Z","html_url":"https://github.com/dotnet/roslyn/pull/31447#discussion_r238395100","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/31447","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/238395100"},"html":{"href":"https://github.com/dotnet/roslyn/pull/31447#discussion_r238395100"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31447"}},"in_reply_to_id":238394158},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/31447","id":234783324,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzgzMzI0","html_url":"https://github.com/dotnet/roslyn/pull/31447","diff_url":"https://github.com/dotnet/roslyn/pull/31447.diff","patch_url":"https://github.com/dotnet/roslyn/pull/31447.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/31447","number":31447,"state":"open","locked":false,"title":"Refactor change namespace service","user":{"login":"genlu","id":788783,"node_id":"MDQ6VXNlcjc4ODc4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/788783?v=4","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"body":"This completed the separation of `ChangeNamespaceService` from `SyncNamespaceCodeRefactoringProvider`. \r\n\r\nMost of the logic for checking the availability of the refactoring now moved to `ChangeNamespaceService`, with only the bits related to sync namespace with folder remained. The service now also supports changing the name of a namespace declaration when there's multiple namespace declared in the same document, as long as the selected one is not nested.","created_at":"2018-11-29T20:56:32Z","updated_at":"2018-12-03T18:59:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cc3adeac136d286a39faf8f13926d45bac4a907","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"roslyn-ide","id":1781706,"node_id":"MDQ6VGVhbTE3ODE3MDY=","slug":"roslyn-ide","description":"Roslyn IDE Team","privacy":"closed","url":"https://api.github.com/teams/1781706","members_url":"https://api.github.com/teams/1781706/members{/member}","repositories_url":"https://api.github.com/teams/1781706/repos","permission":"pull"}],"labels":[{"id":166377917,"node_id":"MDU6TGFiZWwxNjYzNzc5MTc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/36","html_url":"https://github.com/dotnet/roslyn/milestone/36","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/36/labels","id":3663714,"node_id":"MDk6TWlsZXN0b25lMzY2MzcxNA==","number":36,"title":"16.0.P2","description":"","creator":{"login":"jinujoseph","id":12449387,"node_id":"MDQ6VXNlcjEyNDQ5Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/12449387?v=4","gravatar_id":"","url":"https://api.github.com/users/jinujoseph","html_url":"https://github.com/jinujoseph","followers_url":"https://api.github.com/users/jinujoseph/followers","following_url":"https://api.github.com/users/jinujoseph/following{/other_user}","gists_url":"https://api.github.com/users/jinujoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/jinujoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinujoseph/subscriptions","organizations_url":"https://api.github.com/users/jinujoseph/orgs","repos_url":"https://api.github.com/users/jinujoseph/repos","events_url":"https://api.github.com/users/jinujoseph/events{/privacy}","received_events_url":"https://api.github.com/users/jinujoseph/received_events","type":"User","site_admin":false},"open_issues":150,"closed_issues":182,"state":"open","created_at":"2018-09-18T00:39:12Z","updated_at":"2018-12-03T15:05:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/31447/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/31447/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/31447/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/0f9a0009774af4132fda0568fa265d32424de786","head":{"label":"genlu:refactoringService","ref":"refactoringService","sha":"0f9a0009774af4132fda0568fa265d32424de786","user":{"login":"genlu","id":788783,"node_id":"MDQ6VXNlcjc4ODc4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/788783?v=4","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"repo":{"id":38650594,"node_id":"MDEwOlJlcG9zaXRvcnkzODY1MDU5NA==","name":"roslyn","full_name":"genlu/roslyn","private":false,"owner":{"login":"genlu","id":788783,"node_id":"MDQ6VXNlcjc4ODc4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/788783?v=4","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/genlu/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/genlu/roslyn","forks_url":"https://api.github.com/repos/genlu/roslyn/forks","keys_url":"https://api.github.com/repos/genlu/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genlu/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genlu/roslyn/teams","hooks_url":"https://api.github.com/repos/genlu/roslyn/hooks","issue_events_url":"https://api.github.com/repos/genlu/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/genlu/roslyn/events","assignees_url":"https://api.github.com/repos/genlu/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/genlu/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/genlu/roslyn/tags","blobs_url":"https://api.github.com/repos/genlu/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genlu/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genlu/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/genlu/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genlu/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/genlu/roslyn/languages","stargazers_url":"https://api.github.com/repos/genlu/roslyn/stargazers","contributors_url":"https://api.github.com/repos/genlu/roslyn/contributors","subscribers_url":"https://api.github.com/repos/genlu/roslyn/subscribers","subscription_url":"https://api.github.com/repos/genlu/roslyn/subscription","commits_url":"https://api.github.com/repos/genlu/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/genlu/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/genlu/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/genlu/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/genlu/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/genlu/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genlu/roslyn/merges","archive_url":"https://api.github.com/repos/genlu/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genlu/roslyn/downloads","issues_url":"https://api.github.com/repos/genlu/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/genlu/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/genlu/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/genlu/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genlu/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/genlu/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/genlu/roslyn/deployments","created_at":"2015-07-06T22:48:49Z","updated_at":"2018-08-15T22:47:30Z","pushed_at":"2018-11-30T00:14:41Z","git_url":"git://github.com/genlu/roslyn.git","ssh_url":"git@github.com:genlu/roslyn.git","clone_url":"https://github.com/genlu/roslyn.git","svn_url":"https://github.com/genlu/roslyn","homepage":"","size":448245,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5574867382e155ed1e2ed1054ef44234d03d1619","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/roslyn","description":"The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-12-03T18:58:45Z","pushed_at":"2018-12-03T18:57:46Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/","size":493908,"stargazers_count":10424,"watchers_count":10424,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2477,"mirror_url":null,"archived":false,"open_issues_count":5448,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2477,"open_issues":5448,"watchers":10424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31447"},"html":{"href":"https://github.com/dotnet/roslyn/pull/31447"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/31447"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/31447/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31447/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/31447/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/0f9a0009774af4132fda0568fa265d32424de786"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"CyrusNajmabadi"}}