{"action":"created","issue":{"url":"https://api.github.com/repos/cssinjs/react-jss/issues/123","repository_url":"https://api.github.com/repos/cssinjs/react-jss","labels_url":"https://api.github.com/repos/cssinjs/react-jss/issues/123/labels{/name}","comments_url":"https://api.github.com/repos/cssinjs/react-jss/issues/123/comments","events_url":"https://api.github.com/repos/cssinjs/react-jss/issues/123/events","html_url":"https://github.com/cssinjs/react-jss/pull/123","id":244651790,"node_id":"MDExOlB1bGxSZXF1ZXN0MTMxNzYxMzM4","number":123,"title":"Fix hmr","user":{"login":"iamstarkov","id":559321,"node_id":"MDQ6VXNlcjU1OTMyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/559321?v=4","gravatar_id":"","url":"https://api.github.com/users/iamstarkov","html_url":"https://github.com/iamstarkov","followers_url":"https://api.github.com/users/iamstarkov/followers","following_url":"https://api.github.com/users/iamstarkov/following{/other_user}","gists_url":"https://api.github.com/users/iamstarkov/gists{/gist_id}","starred_url":"https://api.github.com/users/iamstarkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamstarkov/subscriptions","organizations_url":"https://api.github.com/users/iamstarkov/orgs","repos_url":"https://api.github.com/users/iamstarkov/repos","events_url":"https://api.github.com/users/iamstarkov/events{/privacy}","received_events_url":"https://api.github.com/users/iamstarkov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2017-07-21T12:16:39Z","updated_at":"2018-07-10T09:32:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cssinjs/react-jss/pulls/123","html_url":"https://github.com/cssinjs/react-jss/pull/123","diff_url":"https://github.com/cssinjs/react-jss/pull/123.diff","patch_url":"https://github.com/cssinjs/react-jss/pull/123.patch"},"body":"so, the problem is in `jss.SheetManager.unmanage()` it will throw if there is no sheet to unmanage.  HMR updates remounts the component and SheetManager is being resetted, so it will throw, but fix is easy, just dont throw if its HMR update"},"comment":{"url":"https://api.github.com/repos/cssinjs/react-jss/issues/comments/403761342","html_url":"https://github.com/cssinjs/react-jss/pull/123#issuecomment-403761342","issue_url":"https://api.github.com/repos/cssinjs/react-jss/issues/123","id":403761342,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzc2MTM0Mg==","user":{"login":"HenriBeck","id":8514706,"node_id":"MDQ6VXNlcjg1MTQ3MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8514706?v=4","gravatar_id":"","url":"https://api.github.com/users/HenriBeck","html_url":"https://github.com/HenriBeck","followers_url":"https://api.github.com/users/HenriBeck/followers","following_url":"https://api.github.com/users/HenriBeck/following{/other_user}","gists_url":"https://api.github.com/users/HenriBeck/gists{/gist_id}","starred_url":"https://api.github.com/users/HenriBeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenriBeck/subscriptions","organizations_url":"https://api.github.com/users/HenriBeck/orgs","repos_url":"https://api.github.com/users/HenriBeck/repos","events_url":"https://api.github.com/users/HenriBeck/events{/privacy}","received_events_url":"https://api.github.com/users/HenriBeck/received_events","type":"User","site_admin":false},"created_at":"2018-07-10T09:32:38Z","updated_at":"2018-07-10T09:32:38Z","author_association":"MEMBER","body":"Okay, then it makes sense to add the `react-jss-hmr` eventually to the monorepo.\r\n\r\nCan we move the repo just under the `cssinjs` org until we can merge it into the monorepo?"}}
{"actor":{"display_login":"HenriBeck"}}