{"action":"opened","number":4861,"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4861","id":225920466,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTIwNDY2","html_url":"https://github.com/envoyproxy/envoy/pull/4861","diff_url":"https://github.com/envoyproxy/envoy/pull/4861.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4861.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4861","number":4861,"state":"open","locked":false,"title":"docs: Remove references to \"other_hosts\" and \"other_priorities\"","user":{"login":"tonya11en","id":1109246,"node_id":"MDQ6VXNlcjExMDkyNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1109246?v=4","gravatar_id":"","url":"https://api.github.com/users/tonya11en","html_url":"https://github.com/tonya11en","followers_url":"https://api.github.com/users/tonya11en/followers","following_url":"https://api.github.com/users/tonya11en/following{/other_user}","gists_url":"https://api.github.com/users/tonya11en/gists{/gist_id}","starred_url":"https://api.github.com/users/tonya11en/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonya11en/subscriptions","organizations_url":"https://api.github.com/users/tonya11en/orgs","repos_url":"https://api.github.com/users/tonya11en/repos","events_url":"https://api.github.com/users/tonya11en/events{/privacy}","received_events_url":"https://api.github.com/users/tonya11en/received_events","type":"User","site_admin":false},"body":"*Description*:\r\nThe documentation makes references to `envoy.retry_host_predicates.other_hosts` and `envoy.retry_priority.other_priorities` which are nowhere to be found in the codebase outside of the one reference in the docs. I believe it should really refer to:\r\n\r\n```\r\n// Previous host predicate. Rejects hosts that have already been tried.\r\nconst std::string PreviousHostsPredicate = \"envoy.retry_host_predicates.previous_hosts\";\r\n```\r\n\r\nand\r\n\r\n```\r\n// Previous priority retry priority. Excludes previously attempted priorities during retries.\r\nconst std::string PreviousPrioritiesRetryPriority = \"envoy.retry_priorities.previous_priorities\";\r\n```\r\n\r\n*Risk Level*:\r\nDocs\r\n\r\n*Testing*:\r\ndoc build\r\n\r\n*Docs Changes*:\r\nyes\r\n\r\n","created_at":"2018-10-25T22:11:40Z","updated_at":"2018-10-25T22:11:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4861/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4861/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4861/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/f066c083ca1b8a63e07c563039311b196ae1499e","head":{"label":"tonya11en:other_priorities_doc_bug","ref":"other_priorities_doc_bug","sha":"f066c083ca1b8a63e07c563039311b196ae1499e","user":{"login":"tonya11en","id":1109246,"node_id":"MDQ6VXNlcjExMDkyNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1109246?v=4","gravatar_id":"","url":"https://api.github.com/users/tonya11en","html_url":"https://github.com/tonya11en","followers_url":"https://api.github.com/users/tonya11en/followers","following_url":"https://api.github.com/users/tonya11en/following{/other_user}","gists_url":"https://api.github.com/users/tonya11en/gists{/gist_id}","starred_url":"https://api.github.com/users/tonya11en/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonya11en/subscriptions","organizations_url":"https://api.github.com/users/tonya11en/orgs","repos_url":"https://api.github.com/users/tonya11en/repos","events_url":"https://api.github.com/users/tonya11en/events{/privacy}","received_events_url":"https://api.github.com/users/tonya11en/received_events","type":"User","site_admin":false},"repo":{"id":118288660,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgyODg2NjA=","name":"envoy","full_name":"tonya11en/envoy","private":false,"owner":{"login":"tonya11en","id":1109246,"node_id":"MDQ6VXNlcjExMDkyNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1109246?v=4","gravatar_id":"","url":"https://api.github.com/users/tonya11en","html_url":"https://github.com/tonya11en","followers_url":"https://api.github.com/users/tonya11en/followers","following_url":"https://api.github.com/users/tonya11en/following{/other_user}","gists_url":"https://api.github.com/users/tonya11en/gists{/gist_id}","starred_url":"https://api.github.com/users/tonya11en/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonya11en/subscriptions","organizations_url":"https://api.github.com/users/tonya11en/orgs","repos_url":"https://api.github.com/users/tonya11en/repos","events_url":"https://api.github.com/users/tonya11en/events{/privacy}","received_events_url":"https://api.github.com/users/tonya11en/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tonya11en/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/tonya11en/envoy","forks_url":"https://api.github.com/repos/tonya11en/envoy/forks","keys_url":"https://api.github.com/repos/tonya11en/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonya11en/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonya11en/envoy/teams","hooks_url":"https://api.github.com/repos/tonya11en/envoy/hooks","issue_events_url":"https://api.github.com/repos/tonya11en/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/tonya11en/envoy/events","assignees_url":"https://api.github.com/repos/tonya11en/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/tonya11en/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/tonya11en/envoy/tags","blobs_url":"https://api.github.com/repos/tonya11en/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonya11en/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonya11en/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonya11en/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonya11en/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/tonya11en/envoy/languages","stargazers_url":"https://api.github.com/repos/tonya11en/envoy/stargazers","contributors_url":"https://api.github.com/repos/tonya11en/envoy/contributors","subscribers_url":"https://api.github.com/repos/tonya11en/envoy/subscribers","subscription_url":"https://api.github.com/repos/tonya11en/envoy/subscription","commits_url":"https://api.github.com/repos/tonya11en/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonya11en/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonya11en/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonya11en/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonya11en/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/tonya11en/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonya11en/envoy/merges","archive_url":"https://api.github.com/repos/tonya11en/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonya11en/envoy/downloads","issues_url":"https://api.github.com/repos/tonya11en/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/tonya11en/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/tonya11en/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/tonya11en/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonya11en/envoy/labels{/name}","releases_url":"https://api.github.com/repos/tonya11en/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/tonya11en/envoy/deployments","created_at":"2018-01-20T23:17:21Z","updated_at":"2018-10-05T01:27:05Z","pushed_at":"2018-10-25T22:06:02Z","git_url":"git://github.com/tonya11en/envoy.git","ssh_url":"git@github.com:tonya11en/envoy.git","clone_url":"https://github.com/tonya11en/envoy.git","svn_url":"https://github.com/tonya11en/envoy","homepage":"https://envoyproxy.github.io/","size":63882,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"45d79259df7285432adbe104ba12e3e4bdc52475","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-10-25T22:02:45Z","pushed_at":"2018-10-25T22:11:08Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":22435,"stargazers_count":6928,"watchers_count":6928,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":953,"mirror_url":null,"archived":false,"open_issues_count":379,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":953,"open_issues":379,"watchers":6928,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4861"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4861"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4861"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4861/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4861/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4861/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/f066c083ca1b8a63e07c563039311b196ae1499e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"tonya11en"}}