{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/232813962","pull_request_review_id":174096032,"id":232813962,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjgxMzk2Mg==","diff_hunk":"@@ -329,9 +329,13 @@ void QgsMapRendererJob::drawLabeling( const QgsMapSettings &settings, QgsRenderC\n   // Reset the composition mode before rendering the labels\n   painter->setCompositionMode( QPainter::CompositionMode_SourceOver );\n \n+  const QgsFeatureFilterProvider *featureFilterProvider = renderContext.featureFilterProvider()->clone();","path":"src/core/qgsmaprenderercustompainterjob.cpp","position":4,"original_position":4,"commit_id":"f6154999c1debd1ccc5070a94ffce6169cadca88","original_commit_id":"f6154999c1debd1ccc5070a94ffce6169cadca88","user":{"login":"nyalldawson","id":1829991,"node_id":"MDQ6VXNlcjE4Mjk5OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1829991?v=4","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"body":"Unique_ptr here","created_at":"2018-11-12T21:15:01Z","updated_at":"2018-11-12T21:15:48Z","html_url":"https://github.com/qgis/QGIS/pull/8463#discussion_r232813962","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/8463","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/232813962"},"html":{"href":"https://github.com/qgis/QGIS/pull/8463#discussion_r232813962"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8463"}}},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/8463","id":230145770,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTQ1Nzcw","html_url":"https://github.com/qgis/QGIS/pull/8463","diff_url":"https://github.com/qgis/QGIS/pull/8463.diff","patch_url":"https://github.com/qgis/QGIS/pull/8463.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/8463","number":8463,"state":"open","locked":false,"title":"Apply featureFilterProvider in QgsVectorLayerDiagramProvider","user":{"login":"arnaud-morvan","id":6095494,"node_id":"MDQ6VXNlcjYwOTU0OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6095494?v=4","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"body":"## Description\r\nAs QgsVectorLayerDiagramProvider is created with it's \"ownFeatureLoop\", FILTER parameter was having no effect on diagrams.\r\n\r\nNote: It should be possible to create QgsVectorLayerDiagramProvider with `ownFeatureLoop = true` here: https://github.com/qgis/QGIS/blob/9b04a29116156dec48c32dd6a54aafa0ff05eaea/src/core/qgsvectorlayerrenderer.cpp#L540\r\nBut this might have side effects.\r\n\r\n## Checklist\r\n\r\n> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.\r\n\r\n- [ ] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and contain sufficient information in the commit message to be documented\r\n- [ ] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [ ] New unit tests have been added for core changes\r\n- [ ] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTING.md#contributing-to-qgis) before each commit\r\n","created_at":"2018-11-12T14:06:36Z","updated_at":"2018-11-12T21:15:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2134450ca6cb34d4350559ff65b51d366a26c96","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/8463/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/8463/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/8463/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/f6154999c1debd1ccc5070a94ffce6169cadca88","head":{"label":"arnaud-morvan:server_diagrams_filter","ref":"server_diagrams_filter","sha":"f6154999c1debd1ccc5070a94ffce6169cadca88","user":{"login":"arnaud-morvan","id":6095494,"node_id":"MDQ6VXNlcjYwOTU0OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6095494?v=4","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"repo":{"id":15884637,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg4NDYzNw==","name":"QGIS","full_name":"arnaud-morvan/QGIS","private":false,"owner":{"login":"arnaud-morvan","id":6095494,"node_id":"MDQ6VXNlcjYwOTU0OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6095494?v=4","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arnaud-morvan/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/arnaud-morvan/QGIS","forks_url":"https://api.github.com/repos/arnaud-morvan/QGIS/forks","keys_url":"https://api.github.com/repos/arnaud-morvan/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnaud-morvan/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnaud-morvan/QGIS/teams","hooks_url":"https://api.github.com/repos/arnaud-morvan/QGIS/hooks","issue_events_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/arnaud-morvan/QGIS/events","assignees_url":"https://api.github.com/repos/arnaud-morvan/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/arnaud-morvan/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/arnaud-morvan/QGIS/tags","blobs_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnaud-morvan/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/arnaud-morvan/QGIS/languages","stargazers_url":"https://api.github.com/repos/arnaud-morvan/QGIS/stargazers","contributors_url":"https://api.github.com/repos/arnaud-morvan/QGIS/contributors","subscribers_url":"https://api.github.com/repos/arnaud-morvan/QGIS/subscribers","subscription_url":"https://api.github.com/repos/arnaud-morvan/QGIS/subscription","commits_url":"https://api.github.com/repos/arnaud-morvan/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnaud-morvan/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/arnaud-morvan/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/arnaud-morvan/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnaud-morvan/QGIS/merges","archive_url":"https://api.github.com/repos/arnaud-morvan/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnaud-morvan/QGIS/downloads","issues_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/arnaud-morvan/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/arnaud-morvan/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/arnaud-morvan/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnaud-morvan/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/arnaud-morvan/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/arnaud-morvan/QGIS/deployments","created_at":"2014-01-13T22:47:33Z","updated_at":"2017-02-09T13:10:29Z","pushed_at":"2018-11-08T13:59:54Z","git_url":"git://github.com/arnaud-morvan/QGIS.git","ssh_url":"git@github.com:arnaud-morvan/QGIS.git","clone_url":"https://github.com/arnaud-morvan/QGIS.git","svn_url":"https://github.com/arnaud-morvan/QGIS","homepage":"http://qgis.org","size":1356131,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"9b04a29116156dec48c32dd6a54aafa0ff05eaea","user":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwNDgw","name":"QGIS","full_name":"qgis/QGIS","private":false,"owner":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2018-11-12T21:14:32Z","pushed_at":"2018-11-12T21:14:20Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1481350,"stargazers_count":2302,"watchers_count":2302,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1347,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1347,"open_issues":37,"watchers":2302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8463"},"html":{"href":"https://github.com/qgis/QGIS/pull/8463"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/8463"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/8463/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8463/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8463/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/f6154999c1debd1ccc5070a94ffce6169cadca88"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nyalldawson"}}