{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/218050674","pull_request_review_id":155900937,"id":218050674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODA1MDY3NA==","diff_hunk":"@@ -97,6 +94,16 @@ export function get(obj: object, keyName: string): any {\n     typeof keyName !== 'string' || keyName.lastIndexOf('this.', 0) !== 0\n   );\n   assert('Cannot call `get` with an empty string', keyName !== '');\n+  if (\n+    (obj as ExtendedObject).isDestroyed &&\n+    keyName !== 'isDestroyed' &&\n+    keyName !== 'isDestroying'\n+  ) {\n+    warn(`calling \\`get\\` on destroyed object: ${toString(obj)}.${keyName}`, false, {\n+      id: 'calling-get-on-destroyed',\n+    });\n+    return;","path":"packages/ember-metal/lib/property_get.ts","position":null,"original_position":36,"commit_id":"df5dff7445976fc5ddf24303e550d0eac511cf3e","original_commit_id":"7168e4da93dfae6a45158420d7ab0c84d9c72340","user":{"login":"bekzod","id":1131614,"node_id":"MDQ6VXNlcjExMzE2MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1131614?v=4","gravatar_id":"","url":"https://api.github.com/users/bekzod","html_url":"https://github.com/bekzod","followers_url":"https://api.github.com/users/bekzod/followers","following_url":"https://api.github.com/users/bekzod/following{/other_user}","gists_url":"https://api.github.com/users/bekzod/gists{/gist_id}","starred_url":"https://api.github.com/users/bekzod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bekzod/subscriptions","organizations_url":"https://api.github.com/users/bekzod/orgs","repos_url":"https://api.github.com/users/bekzod/repos","events_url":"https://api.github.com/users/bekzod/events{/privacy}","received_events_url":"https://api.github.com/users/bekzod/received_events","type":"User","site_admin":false},"body":"added PR to `babel-plugin-debug-macros` https://github.com/chadhietala/babel-plugin-debug-macros/pull/72 to support lazy evaluation of string part of warn","created_at":"2018-09-17T12:35:54Z","updated_at":"2018-09-17T12:35:54Z","html_url":"https://github.com/emberjs/ember.js/pull/16726#discussion_r218050674","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/16726","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/218050674"},"html":{"href":"https://github.com/emberjs/ember.js/pull/16726#discussion_r218050674"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16726"}},"in_reply_to_id":194057772},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/16726","id":193554988,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTU0OTg4","html_url":"https://github.com/emberjs/ember.js/pull/16726","diff_url":"https://github.com/emberjs/ember.js/pull/16726.diff","patch_url":"https://github.com/emberjs/ember.js/pull/16726.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/16726","number":16726,"state":"open","locked":false,"title":"move `isDestroyed` check from `getPath` to `get`","user":{"login":"bekzod","id":1131614,"node_id":"MDQ6VXNlcjExMzE2MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1131614?v=4","gravatar_id":"","url":"https://api.github.com/users/bekzod","html_url":"https://github.com/bekzod","followers_url":"https://api.github.com/users/bekzod/followers","following_url":"https://api.github.com/users/bekzod/following{/other_user}","gists_url":"https://api.github.com/users/bekzod/gists{/gist_id}","starred_url":"https://api.github.com/users/bekzod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bekzod/subscriptions","organizations_url":"https://api.github.com/users/bekzod/orgs","repos_url":"https://api.github.com/users/bekzod/repos","events_url":"https://api.github.com/users/bekzod/events{/privacy}","received_events_url":"https://api.github.com/users/bekzod/received_events","type":"User","site_admin":false},"body":"make consistent `get` with `set` so it warns (maybe make it `assert` later) when used on destroyed object, I think it will help to discover hidden bugs ","created_at":"2018-06-08T09:18:41Z","updated_at":"2018-09-17T12:35:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2fb2ca82de447ed657eadfbe3616bc427484a48","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/16726/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/16726/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/16726/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/df5dff7445976fc5ddf24303e550d0eac511cf3e","head":{"label":"bekzod:move-is-destroyed-check","ref":"move-is-destroyed-check","sha":"df5dff7445976fc5ddf24303e550d0eac511cf3e","user":{"login":"bekzod","id":1131614,"node_id":"MDQ6VXNlcjExMzE2MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1131614?v=4","gravatar_id":"","url":"https://api.github.com/users/bekzod","html_url":"https://github.com/bekzod","followers_url":"https://api.github.com/users/bekzod/followers","following_url":"https://api.github.com/users/bekzod/following{/other_user}","gists_url":"https://api.github.com/users/bekzod/gists{/gist_id}","starred_url":"https://api.github.com/users/bekzod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bekzod/subscriptions","organizations_url":"https://api.github.com/users/bekzod/orgs","repos_url":"https://api.github.com/users/bekzod/repos","events_url":"https://api.github.com/users/bekzod/events{/privacy}","received_events_url":"https://api.github.com/users/bekzod/received_events","type":"User","site_admin":false},"repo":{"id":47320895,"node_id":"MDEwOlJlcG9zaXRvcnk0NzMyMDg5NQ==","name":"ember.js","full_name":"bekzod/ember.js","private":false,"owner":{"login":"bekzod","id":1131614,"node_id":"MDQ6VXNlcjExMzE2MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1131614?v=4","gravatar_id":"","url":"https://api.github.com/users/bekzod","html_url":"https://github.com/bekzod","followers_url":"https://api.github.com/users/bekzod/followers","following_url":"https://api.github.com/users/bekzod/following{/other_user}","gists_url":"https://api.github.com/users/bekzod/gists{/gist_id}","starred_url":"https://api.github.com/users/bekzod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bekzod/subscriptions","organizations_url":"https://api.github.com/users/bekzod/orgs","repos_url":"https://api.github.com/users/bekzod/repos","events_url":"https://api.github.com/users/bekzod/events{/privacy}","received_events_url":"https://api.github.com/users/bekzod/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bekzod/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/bekzod/ember.js","forks_url":"https://api.github.com/repos/bekzod/ember.js/forks","keys_url":"https://api.github.com/repos/bekzod/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bekzod/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bekzod/ember.js/teams","hooks_url":"https://api.github.com/repos/bekzod/ember.js/hooks","issue_events_url":"https://api.github.com/repos/bekzod/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/bekzod/ember.js/events","assignees_url":"https://api.github.com/repos/bekzod/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/bekzod/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/bekzod/ember.js/tags","blobs_url":"https://api.github.com/repos/bekzod/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bekzod/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bekzod/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/bekzod/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bekzod/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/bekzod/ember.js/languages","stargazers_url":"https://api.github.com/repos/bekzod/ember.js/stargazers","contributors_url":"https://api.github.com/repos/bekzod/ember.js/contributors","subscribers_url":"https://api.github.com/repos/bekzod/ember.js/subscribers","subscription_url":"https://api.github.com/repos/bekzod/ember.js/subscription","commits_url":"https://api.github.com/repos/bekzod/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/bekzod/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/bekzod/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/bekzod/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/bekzod/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/bekzod/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bekzod/ember.js/merges","archive_url":"https://api.github.com/repos/bekzod/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bekzod/ember.js/downloads","issues_url":"https://api.github.com/repos/bekzod/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/bekzod/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/bekzod/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/bekzod/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bekzod/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/bekzod/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/bekzod/ember.js/deployments","created_at":"2015-12-03T09:12:19Z","updated_at":"2017-03-15T06:12:26Z","pushed_at":"2018-09-17T12:21:24Z","git_url":"git://github.com/bekzod/ember.js.git","ssh_url":"git@github.com:bekzod/ember.js.git","clone_url":"https://github.com/bekzod/ember.js.git","svn_url":"https://github.com/bekzod/ember.js","homepage":"http://www.emberjs.com","size":45198,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"93f4d26b2095876ecf2455298eabae86ce5028ab","user":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"node_id":"MDEwOlJlcG9zaXRvcnkxODAxODI5","name":"ember.js","full_name":"emberjs/ember.js","private":false,"owner":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2018-09-17T08:48:33Z","pushed_at":"2018-09-17T12:21:27Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":68978,"stargazers_count":20005,"watchers_count":20005,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4033,"mirror_url":null,"archived":false,"open_issues_count":383,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4033,"open_issues":383,"watchers":20005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16726"},"html":{"href":"https://github.com/emberjs/ember.js/pull/16726"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/16726"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/16726/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16726/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16726/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/df5dff7445976fc5ddf24303e550d0eac511cf3e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bekzod"}}