{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/comments/198180811","pull_request_review_id":132062708,"id":198180811,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODE4MDgxMQ==","diff_hunk":"@@ -55,35 +38,58 @@ static int nocodec_rtd_init(struct snd_soc_pcm_runtime *rtd)\n \treturn 0;\n }\n \n-/* we just set some BEs - FE provided by topology */\n-static struct snd_soc_dai_link sof_nocodec_dais[] = {\n-\t/* Back End DAI links */\n-\t{\n-\t\t/* SSP0 - Codec */\n-\t\t.name = \"NoCodec\",\n-\t\t.id = 0,\n-\t\t.init = nocodec_rtd_init,\n-\t\t.cpu_dai_name = \"sof-nocodec-dai\",\n-\t\t.platform_name = \"sof-audio\",\n-\t\t.no_pcm = 1,\n-\t\t.codec_dai_name = \"snd-soc-dummy-dai\",\n-\t\t.codec_name = \"snd-soc-dummy\",\n-\t\t.ops = &sof_nocodec_ops,\n-\t\t.dai_fmt = SND_SOC_DAIFMT_DSP_B | SND_SOC_DAIFMT_NB_NF |\n-\t\t\tSND_SOC_DAIFMT_CBS_CFS,\n-\t\t.ignore_suspend = 1,\n-\t\t.be_hw_params_fixup = sof_nocodec_codec_fixup,\n-\t\t.dpcm_playback = 1,\n-\t\t.dpcm_capture = 1,\n-\t},\n-};\n-\n static struct snd_soc_card sof_nocodec_card = {\n \t.name = \"sof-nocodec\",\n-\t.dai_link = sof_nocodec_dais,\n-\t.num_links = ARRAY_SIZE(sof_nocodec_dais),\n };\n \n+int sof_nocodec_setup(struct device *dev,\n+\t\t      struct snd_sof_pdata *sof_pdata,\n+\t\t      struct snd_soc_acpi_mach *mach,\n+\t\t      const struct sof_dev_desc *desc,\n+\t\t      struct snd_sof_dsp_ops *ops)\n+{\n+\tstruct snd_soc_dai_link *links;\n+\tchar name[32];\n+\tint i;\n+\n+\tif (!mach)\n+\t\treturn -EINVAL;\n+\n+\tsof_pdata->drv_name = \"sof-nocodec\";\n+\n+\tmach->drv_name = \"sof-nocodec\";\n+\tmach->sof_fw_filename = desc->nocodec_fw_filename;\n+\tmach->sof_tplg_filename = desc->nocodec_tplg_filename;\n+\n+\t/* create dummy BE dai_links */\n+\tlinks = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) *\n+\t\t\t     ops->num_drv, GFP_KERNEL);\n+\tif (!links)\n+\t\treturn -ENOMEM;\n+\n+\tfor (i = 0; i < ops->num_drv; i++) {\n+\t\tsnprintf(name, 32, \"NoCodec-%d\", i);\n+\t\tlinks[i].name = kmemdup(name, sizeof(name), GFP_KERNEL);\n+\t\tlinks[i].id = i;\n+\t\tlinks[i].init = nocodec_rtd_init;\n+\t\tlinks[i].no_pcm = 1;\n+\t\tlinks[i].cpu_dai_name = ops->drv[i].name;\n+\t\tlinks[i].platform_name = \"sof-audio\";\n+\t\tlinks[i].codec_dai_name = \"snd-soc-dummy-dai\";\n+\t\tlinks[i].codec_name = \"snd-soc-dummy\";\n+\t\tlinks[i].ops = &sof_nocodec_ops;","path":"sound/soc/sof/nocodec.c","position":94,"original_position":94,"commit_id":"1f959f7020bd252154f7b1fe4e7b52f7d262d633","original_commit_id":"01fc7200f82225b9a12f853877e073c0c46d2bbb","user":{"login":"lgirdwood","id":12020523,"node_id":"MDQ6VXNlcjEyMDIwNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/12020523?v=4","gravatar_id":"","url":"https://api.github.com/users/lgirdwood","html_url":"https://github.com/lgirdwood","followers_url":"https://api.github.com/users/lgirdwood/followers","following_url":"https://api.github.com/users/lgirdwood/following{/other_user}","gists_url":"https://api.github.com/users/lgirdwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lgirdwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgirdwood/subscriptions","organizations_url":"https://api.github.com/users/lgirdwood/orgs","repos_url":"https://api.github.com/users/lgirdwood/repos","events_url":"https://api.github.com/users/lgirdwood/events{/privacy}","received_events_url":"https://api.github.com/users/lgirdwood/received_events","type":"User","site_admin":false},"body":"rename nocodec_ -> sof_platform_","created_at":"2018-06-26T15:01:35Z","updated_at":"2018-06-26T15:03:22Z","html_url":"https://github.com/thesofproject/linux/pull/4#discussion_r198180811","pull_request_url":"https://api.github.com/repos/thesofproject/linux/pulls/4","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments/198180811"},"html":{"href":"https://github.com/thesofproject/linux/pull/4#discussion_r198180811"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/4","id":197028770,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDI4Nzcw","html_url":"https://github.com/thesofproject/linux/pull/4","diff_url":"https://github.com/thesofproject/linux/pull/4.diff","patch_url":"https://github.com/thesofproject/linux/pull/4.patch","issue_url":"https://api.github.com/repos/thesofproject/linux/issues/4","number":4,"state":"open","locked":false,"title":"multiple SSPs/BEs support for SOF--Kernel Part","user":{"login":"keyonjie","id":10458135,"node_id":"MDQ6VXNlcjEwNDU4MTM1","avatar_url":"https://avatars1.githubusercontent.com/u/10458135?v=4","gravatar_id":"","url":"https://api.github.com/users/keyonjie","html_url":"https://github.com/keyonjie","followers_url":"https://api.github.com/users/keyonjie/followers","following_url":"https://api.github.com/users/keyonjie/following{/other_user}","gists_url":"https://api.github.com/users/keyonjie/gists{/gist_id}","starred_url":"https://api.github.com/users/keyonjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyonjie/subscriptions","organizations_url":"https://api.github.com/users/keyonjie/orgs","repos_url":"https://api.github.com/users/keyonjie/repos","events_url":"https://api.github.com/users/keyonjie/events{/privacy}","received_events_url":"https://api.github.com/users/keyonjie/received_events","type":"User","site_admin":false},"body":"We need SOFT part merged together, that is stream_name rename for nocodec topology to make nocodec topology works.","created_at":"2018-06-25T07:51:45Z","updated_at":"2018-06-26T15:03:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25875ba0f82fb3ee0c952354de21aab57fa637d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/linux/pulls/4/commits","review_comments_url":"https://api.github.com/repos/thesofproject/linux/pulls/4/comments","review_comment_url":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/linux/issues/4/comments","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/1f959f7020bd252154f7b1fe4e7b52f7d262d633","head":{"label":"keyonjie:sof-pr","ref":"sof-pr","sha":"1f959f7020bd252154f7b1fe4e7b52f7d262d633","user":{"login":"keyonjie","id":10458135,"node_id":"MDQ6VXNlcjEwNDU4MTM1","avatar_url":"https://avatars1.githubusercontent.com/u/10458135?v=4","gravatar_id":"","url":"https://api.github.com/users/keyonjie","html_url":"https://github.com/keyonjie","followers_url":"https://api.github.com/users/keyonjie/followers","following_url":"https://api.github.com/users/keyonjie/following{/other_user}","gists_url":"https://api.github.com/users/keyonjie/gists{/gist_id}","starred_url":"https://api.github.com/users/keyonjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyonjie/subscriptions","organizations_url":"https://api.github.com/users/keyonjie/orgs","repos_url":"https://api.github.com/users/keyonjie/repos","events_url":"https://api.github.com/users/keyonjie/events{/privacy}","received_events_url":"https://api.github.com/users/keyonjie/received_events","type":"User","site_admin":false},"repo":{"id":28997864,"node_id":"MDEwOlJlcG9zaXRvcnkyODk5Nzg2NA==","name":"linux","full_name":"keyonjie/linux","owner":{"login":"keyonjie","id":10458135,"node_id":"MDQ6VXNlcjEwNDU4MTM1","avatar_url":"https://avatars1.githubusercontent.com/u/10458135?v=4","gravatar_id":"","url":"https://api.github.com/users/keyonjie","html_url":"https://github.com/keyonjie","followers_url":"https://api.github.com/users/keyonjie/followers","following_url":"https://api.github.com/users/keyonjie/following{/other_user}","gists_url":"https://api.github.com/users/keyonjie/gists{/gist_id}","starred_url":"https://api.github.com/users/keyonjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyonjie/subscriptions","organizations_url":"https://api.github.com/users/keyonjie/orgs","repos_url":"https://api.github.com/users/keyonjie/repos","events_url":"https://api.github.com/users/keyonjie/events{/privacy}","received_events_url":"https://api.github.com/users/keyonjie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keyonjie/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/keyonjie/linux","forks_url":"https://api.github.com/repos/keyonjie/linux/forks","keys_url":"https://api.github.com/repos/keyonjie/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keyonjie/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keyonjie/linux/teams","hooks_url":"https://api.github.com/repos/keyonjie/linux/hooks","issue_events_url":"https://api.github.com/repos/keyonjie/linux/issues/events{/number}","events_url":"https://api.github.com/repos/keyonjie/linux/events","assignees_url":"https://api.github.com/repos/keyonjie/linux/assignees{/user}","branches_url":"https://api.github.com/repos/keyonjie/linux/branches{/branch}","tags_url":"https://api.github.com/repos/keyonjie/linux/tags","blobs_url":"https://api.github.com/repos/keyonjie/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keyonjie/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keyonjie/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/keyonjie/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keyonjie/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/keyonjie/linux/languages","stargazers_url":"https://api.github.com/repos/keyonjie/linux/stargazers","contributors_url":"https://api.github.com/repos/keyonjie/linux/contributors","subscribers_url":"https://api.github.com/repos/keyonjie/linux/subscribers","subscription_url":"https://api.github.com/repos/keyonjie/linux/subscription","commits_url":"https://api.github.com/repos/keyonjie/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/keyonjie/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/keyonjie/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/keyonjie/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/keyonjie/linux/contents/{+path}","compare_url":"https://api.github.com/repos/keyonjie/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keyonjie/linux/merges","archive_url":"https://api.github.com/repos/keyonjie/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keyonjie/linux/downloads","issues_url":"https://api.github.com/repos/keyonjie/linux/issues{/number}","pulls_url":"https://api.github.com/repos/keyonjie/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/keyonjie/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/keyonjie/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keyonjie/linux/labels{/name}","releases_url":"https://api.github.com/repos/keyonjie/linux/releases{/id}","deployments_url":"https://api.github.com/repos/keyonjie/linux/deployments","created_at":"2015-01-09T03:01:34Z","updated_at":"2015-01-09T03:05:54Z","pushed_at":"2018-06-26T08:20:18Z","git_url":"git://github.com/keyonjie/linux.git","ssh_url":"git@github.com:keyonjie/linux.git","clone_url":"https://github.com/keyonjie/linux.git","svn_url":"https://github.com/keyonjie/linux","homepage":"","size":2170962,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thesofproject:topic/sof-dev","ref":"topic/sof-dev","sha":"9b843df48bbaea2a067df9d098cd700d3abd6155","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135611127,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MTExMjc=","name":"linux","full_name":"thesofproject/linux","owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thesofproject/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/thesofproject/linux","forks_url":"https://api.github.com/repos/thesofproject/linux/forks","keys_url":"https://api.github.com/repos/thesofproject/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/linux/teams","hooks_url":"https://api.github.com/repos/thesofproject/linux/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/linux/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/linux/events","assignees_url":"https://api.github.com/repos/thesofproject/linux/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/linux/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/linux/tags","blobs_url":"https://api.github.com/repos/thesofproject/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/linux/languages","stargazers_url":"https://api.github.com/repos/thesofproject/linux/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/linux/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/linux/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/linux/subscription","commits_url":"https://api.github.com/repos/thesofproject/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/linux/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/linux/merges","archive_url":"https://api.github.com/repos/thesofproject/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/linux/downloads","issues_url":"https://api.github.com/repos/thesofproject/linux/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/linux/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/linux/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/linux/deployments","created_at":"2018-05-31T16:47:45Z","updated_at":"2018-06-26T15:01:28Z","pushed_at":"2018-06-26T15:00:53Z","git_url":"git://github.com/thesofproject/linux.git","ssh_url":"git@github.com:thesofproject/linux.git","clone_url":"https://github.com/thesofproject/linux.git","svn_url":"https://github.com/thesofproject/linux","homepage":"","size":2179457,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":2,"watchers":0,"default_branch":"topic/sof-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/4"},"html":{"href":"https://github.com/thesofproject/linux/pull/4"},"issue":{"href":"https://api.github.com/repos/thesofproject/linux/issues/4"},"comments":{"href":"https://api.github.com/repos/thesofproject/linux/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/linux/statuses/1f959f7020bd252154f7b1fe4e7b52f7d262d633"}},"author_association":"NONE"}}
{"actor":{"display_login":"lgirdwood"}}