{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/installer/pulls/comments/238043873","pull_request_review_id":180501834,"id":238043873,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA0Mzg3Mw==","diff_hunk":"@@ -43,8 +43,8 @@ The installer accepts a number of environment variable that allow the interactiv\n ## Platform-Specific\n \n * `AWS_PROFILE`:\n-     The AWS profile that corresponds to value in `${HOME}/.aws/credentials`.  If not provided, the default is \"default\".\n-* `OPENSHIFT_INSTALL_AWS_REGION`:\n+    The AWS profile that corresponds to value in `${HOME}/.aws/credentials`.  If not provided, the default is \"default\".\n+* `AWS_DEFAULT_REGION`:","path":"docs/user/environment-variables.md","position":7,"original_position":7,"commit_id":"ca6f9316a520e8935b1c63a288ec7b61a154c013","original_commit_id":"ca6f9316a520e8935b1c63a288ec7b61a154c013","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"body":"And if we keep `AWS_DEFAULT_REGION` people who have setup this env will see no option to choose a separate  region. and will have to unset this default aws env. Which IMO is not great UX.\r\n\r\nUsing this to choose the default region in select is :+1: ","created_at":"2018-12-01T01:03:52Z","updated_at":"2018-12-01T01:03:52Z","html_url":"https://github.com/openshift/installer/pull/688#discussion_r238043873","pull_request_url":"https://api.github.com/repos/openshift/installer/pulls/688","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments/238043873"},"html":{"href":"https://github.com/openshift/installer/pull/688#discussion_r238043873"},"pull_request":{"href":"https://api.github.com/repos/openshift/installer/pulls/688"}},"in_reply_to_id":238043589},"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/688","id":231367776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzY3Nzc2","html_url":"https://github.com/openshift/installer/pull/688","diff_url":"https://github.com/openshift/installer/pull/688.diff","patch_url":"https://github.com/openshift/installer/pull/688.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/688","number":688,"state":"open","locked":false,"title":"pkg/asset/installconfig: OPENSHIFT_INSTALL_AWS_REGION -> AWS_DEFAULT_REGION","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"The `AWS_DEFAULT_REGION` environment variable is widely supported, e.g. by [the AWS command line][1], [the AWS Go library][2], and [Terraform][3].  By dropping our custom environment variable in favor of the common one, we make life easier on users who may already have `AWS_DEFAULT_REGION` configured for one of the non-installer consumers.\r\n\r\nThe usual AWS configuration also supplies other ways to declare a default region (e.g. `~/.aws/config` [here][4] and [here][5]).  With this commit, we check those locations instead of assuming `us-east-1`.  In most cases, we still prompt the user to confirm, but we treat the `AWS_DEFAULT_REGION` case as already-chosen and skip the prompt.\r\n\r\nIf we want this, we'll need to land openshift/release#2152 first.\r\n\r\nThis is related to, but not quite the same as, when we dropped the profile config in #466.\r\n\r\n[1]: https://docs.aws.amazon.com/cli/latest/userguide/cli-environment.html\r\n[2]: https://godoc.org/github.com/aws/aws-sdk-go/aws/session#hdr-Environment_Variables\r\n[3]: https://www.terraform.io/docs/providers/aws/#environment-variables\r\n[4]: https://docs.aws.amazon.com/cli/latest/userguide/cli-config-files.html\r\n[5]: https://godoc.org/github.com/aws/aws-sdk-go/aws/session#hdr-Creating_Sessions","created_at":"2018-11-15T23:22:15Z","updated_at":"2018-12-01T01:03:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b90dd0ead79d2506ed1cfefa74e948c268d1effb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hardys","id":1325867,"node_id":"MDQ6VXNlcjEzMjU4Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/1325867?v=4","gravatar_id":"","url":"https://api.github.com/users/hardys","html_url":"https://github.com/hardys","followers_url":"https://api.github.com/users/hardys/followers","following_url":"https://api.github.com/users/hardys/following{/other_user}","gists_url":"https://api.github.com/users/hardys/gists{/gist_id}","starred_url":"https://api.github.com/users/hardys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardys/subscriptions","organizations_url":"https://api.github.com/users/hardys/orgs","repos_url":"https://api.github.com/users/hardys/repos","events_url":"https://api.github.com/users/hardys/events{/privacy}","received_events_url":"https://api.github.com/users/hardys/received_events","type":"User","site_admin":false},{"login":"staebler","id":30120115,"node_id":"MDQ6VXNlcjMwMTIwMTE1","avatar_url":"https://avatars1.githubusercontent.com/u/30120115?v=4","gravatar_id":"","url":"https://api.github.com/users/staebler","html_url":"https://github.com/staebler","followers_url":"https://api.github.com/users/staebler/followers","following_url":"https://api.github.com/users/staebler/following{/other_user}","gists_url":"https://api.github.com/users/staebler/gists{/gist_id}","starred_url":"https://api.github.com/users/staebler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staebler/subscriptions","organizations_url":"https://api.github.com/users/staebler/orgs","repos_url":"https://api.github.com/users/staebler/repos","events_url":"https://api.github.com/users/staebler/events{/privacy}","received_events_url":"https://api.github.com/users/staebler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":959732229,"node_id":"MDU6TGFiZWw5NTk3MzIyMjk=","url":"https://api.github.com/repos/openshift/installer/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959018430,"node_id":"MDU6TGFiZWw5NTkwMTg0MzA=","url":"https://api.github.com/repos/openshift/installer/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/688/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/688/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/688/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/ca6f9316a520e8935b1c63a288ec7b61a154c013","head":{"label":"wking:aws-default-region","ref":"aws-default-region","sha":"ca6f9316a520e8935b1c63a288ec7b61a154c013","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"repo":{"id":140026813,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMjY4MTM=","name":"openshift-installer","full_name":"wking/openshift-installer","private":false,"owner":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wking/openshift-installer","description":"Install an OpenShift cluster","fork":true,"url":"https://api.github.com/repos/wking/openshift-installer","forks_url":"https://api.github.com/repos/wking/openshift-installer/forks","keys_url":"https://api.github.com/repos/wking/openshift-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wking/openshift-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wking/openshift-installer/teams","hooks_url":"https://api.github.com/repos/wking/openshift-installer/hooks","issue_events_url":"https://api.github.com/repos/wking/openshift-installer/issues/events{/number}","events_url":"https://api.github.com/repos/wking/openshift-installer/events","assignees_url":"https://api.github.com/repos/wking/openshift-installer/assignees{/user}","branches_url":"https://api.github.com/repos/wking/openshift-installer/branches{/branch}","tags_url":"https://api.github.com/repos/wking/openshift-installer/tags","blobs_url":"https://api.github.com/repos/wking/openshift-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wking/openshift-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wking/openshift-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/wking/openshift-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wking/openshift-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/wking/openshift-installer/languages","stargazers_url":"https://api.github.com/repos/wking/openshift-installer/stargazers","contributors_url":"https://api.github.com/repos/wking/openshift-installer/contributors","subscribers_url":"https://api.github.com/repos/wking/openshift-installer/subscribers","subscription_url":"https://api.github.com/repos/wking/openshift-installer/subscription","commits_url":"https://api.github.com/repos/wking/openshift-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/wking/openshift-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/wking/openshift-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/wking/openshift-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/wking/openshift-installer/contents/{+path}","compare_url":"https://api.github.com/repos/wking/openshift-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wking/openshift-installer/merges","archive_url":"https://api.github.com/repos/wking/openshift-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wking/openshift-installer/downloads","issues_url":"https://api.github.com/repos/wking/openshift-installer/issues{/number}","pulls_url":"https://api.github.com/repos/wking/openshift-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/wking/openshift-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/wking/openshift-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wking/openshift-installer/labels{/name}","releases_url":"https://api.github.com/repos/wking/openshift-installer/releases{/id}","deployments_url":"https://api.github.com/repos/wking/openshift-installer/deployments","created_at":"2018-07-06T20:26:48Z","updated_at":"2018-11-30T15:48:05Z","pushed_at":"2018-12-01T00:38:09Z","git_url":"git://github.com/wking/openshift-installer.git","ssh_url":"git@github.com:wking/openshift-installer.git","clone_url":"https://github.com/wking/openshift-installer.git","svn_url":"https://github.com/wking/openshift-installer","homepage":"","size":45429,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"c25196ad183764deb6a40738f22866f3fd207018","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-11-30T12:45:54Z","pushed_at":"2018-12-01T00:58:15Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":44032,"stargazers_count":97,"watchers_count":97,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":115,"open_issues":103,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/688"},"html":{"href":"https://github.com/openshift/installer/pull/688"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/688"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/688/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/688/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/688/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/ca6f9316a520e8935b1c63a288ec7b61a154c013"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"abhinavdahiya"}}