{"action":"created","comment":{"url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/comments/201685876","pull_request_review_id":136234581,"id":201685876,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTY4NTg3Ng==","diff_hunk":"@@ -264,19 +264,15 @@ impl TagListRef {\n     }\n \n     pub fn get_index<'a, T: Tag<'a>>(&'a self, idx: u32) -> Option<&'a TypedValue<T::TagType>> {\n-        unsafe {\n-            let value = ffi::gst_tag_list_get_value_index(\n-                self.as_ptr(),\n-                T::tag_name().to_glib_none().0,\n-                idx,\n-            );\n-\n-            if value.is_null() || (*value).g_type != T::TagType::static_type().to_glib() {\n-                return None;\n-            }\n-\n-            Some(&*(value as *const TypedValue<T::TagType>))\n-        }\n+        self.get_index_generic(T::tag_name(), idx)\n+            .and_then(|value| unsafe {\n+                let value = value.to_glib_none().0;\n+                if (*value).g_type != T::TagType::static_type().to_glib() {\n+                    return None;\n+                }\n+\n+                Some(&*(value as *const TypedValue<T::TagType>))","path":"gstreamer/src/tags.rs","position":582,"original_position":24,"commit_id":"598a2b6d17a047d2f75ffce610323619ea197481","original_commit_id":"598a2b6d17a047d2f75ffce610323619ea197481","user":{"login":"sdroege","id":301846,"node_id":"MDQ6VXNlcjMwMTg0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/301846?v=4","gravatar_id":"","url":"https://api.github.com/users/sdroege","html_url":"https://github.com/sdroege","followers_url":"https://api.github.com/users/sdroege/followers","following_url":"https://api.github.com/users/sdroege/following{/other_user}","gists_url":"https://api.github.com/users/sdroege/gists{/gist_id}","starred_url":"https://api.github.com/users/sdroege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdroege/subscriptions","organizations_url":"https://api.github.com/users/sdroege/orgs","repos_url":"https://api.github.com/users/sdroege/repos","events_url":"https://api.github.com/users/sdroege/events{/privacy}","received_events_url":"https://api.github.com/users/sdroege/received_events","type":"User","site_admin":false},"body":"Ok thanks, put your non-working code in a branch then and I'll take a look :)","created_at":"2018-07-11T13:21:00Z","updated_at":"2018-07-11T13:21:01Z","html_url":"https://github.com/sdroege/gstreamer-rs/pull/119#discussion_r201685876","pull_request_url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/119","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/comments/201685876"},"html":{"href":"https://github.com/sdroege/gstreamer-rs/pull/119#discussion_r201685876"},"pull_request":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/119"}},"in_reply_to_id":201627336},"pull_request":{"url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/119","id":199951009,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTUxMDA5","html_url":"https://github.com/sdroege/gstreamer-rs/pull/119","diff_url":"https://github.com/sdroege/gstreamer-rs/pull/119.diff","patch_url":"https://github.com/sdroege/gstreamer-rs/pull/119.patch","issue_url":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/119","number":119,"state":"open","locked":false,"title":"Tags: implement generic iterators","user":{"login":"fengalin","id":28687262,"node_id":"MDQ6VXNlcjI4Njg3MjYy","avatar_url":"https://avatars0.githubusercontent.com/u/28687262?v=4","gravatar_id":"","url":"https://api.github.com/users/fengalin","html_url":"https://github.com/fengalin","followers_url":"https://api.github.com/users/fengalin/followers","following_url":"https://api.github.com/users/fengalin/following{/other_user}","gists_url":"https://api.github.com/users/fengalin/gists{/gist_id}","starred_url":"https://api.github.com/users/fengalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengalin/subscriptions","organizations_url":"https://api.github.com/users/fengalin/orgs","repos_url":"https://api.github.com/users/fengalin/repos","events_url":"https://api.github.com/users/fengalin/events{/privacy}","received_events_url":"https://api.github.com/users/fengalin/received_events","type":"User","site_admin":false},"body":"This is the continuation of PR #107 by @ystreet","created_at":"2018-07-08T17:00:35Z","updated_at":"2018-07-11T13:21:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22ae1cab6136171d4061670989eb09d20c6d6599","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/119/commits","review_comments_url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/119/comments","review_comment_url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/119/comments","statuses_url":"https://api.github.com/repos/sdroege/gstreamer-rs/statuses/598a2b6d17a047d2f75ffce610323619ea197481","head":{"label":"fengalin:generic_tags_iter","ref":"generic_tags_iter","sha":"598a2b6d17a047d2f75ffce610323619ea197481","user":{"login":"fengalin","id":28687262,"node_id":"MDQ6VXNlcjI4Njg3MjYy","avatar_url":"https://avatars0.githubusercontent.com/u/28687262?v=4","gravatar_id":"","url":"https://api.github.com/users/fengalin","html_url":"https://github.com/fengalin","followers_url":"https://api.github.com/users/fengalin/followers","following_url":"https://api.github.com/users/fengalin/following{/other_user}","gists_url":"https://api.github.com/users/fengalin/gists{/gist_id}","starred_url":"https://api.github.com/users/fengalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengalin/subscriptions","organizations_url":"https://api.github.com/users/fengalin/orgs","repos_url":"https://api.github.com/users/fengalin/repos","events_url":"https://api.github.com/users/fengalin/events{/privacy}","received_events_url":"https://api.github.com/users/fengalin/received_events","type":"User","site_admin":false},"repo":{"id":98756696,"node_id":"MDEwOlJlcG9zaXRvcnk5ODc1NjY5Ng==","name":"gstreamer-rs","full_name":"fengalin/gstreamer-rs","owner":{"login":"fengalin","id":28687262,"node_id":"MDQ6VXNlcjI4Njg3MjYy","avatar_url":"https://avatars0.githubusercontent.com/u/28687262?v=4","gravatar_id":"","url":"https://api.github.com/users/fengalin","html_url":"https://github.com/fengalin","followers_url":"https://api.github.com/users/fengalin/followers","following_url":"https://api.github.com/users/fengalin/following{/other_user}","gists_url":"https://api.github.com/users/fengalin/gists{/gist_id}","starred_url":"https://api.github.com/users/fengalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengalin/subscriptions","organizations_url":"https://api.github.com/users/fengalin/orgs","repos_url":"https://api.github.com/users/fengalin/repos","events_url":"https://api.github.com/users/fengalin/events{/privacy}","received_events_url":"https://api.github.com/users/fengalin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fengalin/gstreamer-rs","description":"GStreamer bindings for Rust","fork":true,"url":"https://api.github.com/repos/fengalin/gstreamer-rs","forks_url":"https://api.github.com/repos/fengalin/gstreamer-rs/forks","keys_url":"https://api.github.com/repos/fengalin/gstreamer-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fengalin/gstreamer-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fengalin/gstreamer-rs/teams","hooks_url":"https://api.github.com/repos/fengalin/gstreamer-rs/hooks","issue_events_url":"https://api.github.com/repos/fengalin/gstreamer-rs/issues/events{/number}","events_url":"https://api.github.com/repos/fengalin/gstreamer-rs/events","assignees_url":"https://api.github.com/repos/fengalin/gstreamer-rs/assignees{/user}","branches_url":"https://api.github.com/repos/fengalin/gstreamer-rs/branches{/branch}","tags_url":"https://api.github.com/repos/fengalin/gstreamer-rs/tags","blobs_url":"https://api.github.com/repos/fengalin/gstreamer-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fengalin/gstreamer-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fengalin/gstreamer-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/fengalin/gstreamer-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fengalin/gstreamer-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/fengalin/gstreamer-rs/languages","stargazers_url":"https://api.github.com/repos/fengalin/gstreamer-rs/stargazers","contributors_url":"https://api.github.com/repos/fengalin/gstreamer-rs/contributors","subscribers_url":"https://api.github.com/repos/fengalin/gstreamer-rs/subscribers","subscription_url":"https://api.github.com/repos/fengalin/gstreamer-rs/subscription","commits_url":"https://api.github.com/repos/fengalin/gstreamer-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/fengalin/gstreamer-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/fengalin/gstreamer-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/fengalin/gstreamer-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/fengalin/gstreamer-rs/contents/{+path}","compare_url":"https://api.github.com/repos/fengalin/gstreamer-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fengalin/gstreamer-rs/merges","archive_url":"https://api.github.com/repos/fengalin/gstreamer-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fengalin/gstreamer-rs/downloads","issues_url":"https://api.github.com/repos/fengalin/gstreamer-rs/issues{/number}","pulls_url":"https://api.github.com/repos/fengalin/gstreamer-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/fengalin/gstreamer-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/fengalin/gstreamer-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fengalin/gstreamer-rs/labels{/name}","releases_url":"https://api.github.com/repos/fengalin/gstreamer-rs/releases{/id}","deployments_url":"https://api.github.com/repos/fengalin/gstreamer-rs/deployments","created_at":"2017-07-29T20:17:33Z","updated_at":"2018-07-08T07:53:24Z","pushed_at":"2018-07-09T20:04:47Z","git_url":"git://github.com/fengalin/gstreamer-rs.git","ssh_url":"git@github.com:fengalin/gstreamer-rs.git","clone_url":"https://github.com/fengalin/gstreamer-rs.git","svn_url":"https://github.com/fengalin/gstreamer-rs","homepage":"","size":4072,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sdroege:master","ref":"master","sha":"73a5b266386ad80005a38c7ac560171f32731553","user":{"login":"sdroege","id":301846,"node_id":"MDQ6VXNlcjMwMTg0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/301846?v=4","gravatar_id":"","url":"https://api.github.com/users/sdroege","html_url":"https://github.com/sdroege","followers_url":"https://api.github.com/users/sdroege/followers","following_url":"https://api.github.com/users/sdroege/following{/other_user}","gists_url":"https://api.github.com/users/sdroege/gists{/gist_id}","starred_url":"https://api.github.com/users/sdroege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdroege/subscriptions","organizations_url":"https://api.github.com/users/sdroege/orgs","repos_url":"https://api.github.com/users/sdroege/repos","events_url":"https://api.github.com/users/sdroege/events{/privacy}","received_events_url":"https://api.github.com/users/sdroege/received_events","type":"User","site_admin":false},"repo":{"id":91088829,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA4ODgyOQ==","name":"gstreamer-rs","full_name":"sdroege/gstreamer-rs","owner":{"login":"sdroege","id":301846,"node_id":"MDQ6VXNlcjMwMTg0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/301846?v=4","gravatar_id":"","url":"https://api.github.com/users/sdroege","html_url":"https://github.com/sdroege","followers_url":"https://api.github.com/users/sdroege/followers","following_url":"https://api.github.com/users/sdroege/following{/other_user}","gists_url":"https://api.github.com/users/sdroege/gists{/gist_id}","starred_url":"https://api.github.com/users/sdroege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdroege/subscriptions","organizations_url":"https://api.github.com/users/sdroege/orgs","repos_url":"https://api.github.com/users/sdroege/repos","events_url":"https://api.github.com/users/sdroege/events{/privacy}","received_events_url":"https://api.github.com/users/sdroege/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdroege/gstreamer-rs","description":"GStreamer bindings for Rust","fork":false,"url":"https://api.github.com/repos/sdroege/gstreamer-rs","forks_url":"https://api.github.com/repos/sdroege/gstreamer-rs/forks","keys_url":"https://api.github.com/repos/sdroege/gstreamer-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdroege/gstreamer-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdroege/gstreamer-rs/teams","hooks_url":"https://api.github.com/repos/sdroege/gstreamer-rs/hooks","issue_events_url":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/events{/number}","events_url":"https://api.github.com/repos/sdroege/gstreamer-rs/events","assignees_url":"https://api.github.com/repos/sdroege/gstreamer-rs/assignees{/user}","branches_url":"https://api.github.com/repos/sdroege/gstreamer-rs/branches{/branch}","tags_url":"https://api.github.com/repos/sdroege/gstreamer-rs/tags","blobs_url":"https://api.github.com/repos/sdroege/gstreamer-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdroege/gstreamer-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdroege/gstreamer-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdroege/gstreamer-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdroege/gstreamer-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/sdroege/gstreamer-rs/languages","stargazers_url":"https://api.github.com/repos/sdroege/gstreamer-rs/stargazers","contributors_url":"https://api.github.com/repos/sdroege/gstreamer-rs/contributors","subscribers_url":"https://api.github.com/repos/sdroege/gstreamer-rs/subscribers","subscription_url":"https://api.github.com/repos/sdroege/gstreamer-rs/subscription","commits_url":"https://api.github.com/repos/sdroege/gstreamer-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdroege/gstreamer-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdroege/gstreamer-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdroege/gstreamer-rs/contents/{+path}","compare_url":"https://api.github.com/repos/sdroege/gstreamer-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdroege/gstreamer-rs/merges","archive_url":"https://api.github.com/repos/sdroege/gstreamer-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdroege/gstreamer-rs/downloads","issues_url":"https://api.github.com/repos/sdroege/gstreamer-rs/issues{/number}","pulls_url":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/sdroege/gstreamer-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/sdroege/gstreamer-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdroege/gstreamer-rs/labels{/name}","releases_url":"https://api.github.com/repos/sdroege/gstreamer-rs/releases{/id}","deployments_url":"https://api.github.com/repos/sdroege/gstreamer-rs/deployments","created_at":"2017-05-12T12:22:18Z","updated_at":"2018-07-09T17:47:52Z","pushed_at":"2018-07-09T20:04:48Z","git_url":"git://github.com/sdroege/gstreamer-rs.git","ssh_url":"git@github.com:sdroege/gstreamer-rs.git","clone_url":"https://github.com/sdroege/gstreamer-rs.git","svn_url":"https://github.com/sdroege/gstreamer-rs","homepage":"","size":4094,"stargazers_count":118,"watchers_count":118,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":14,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/119"},"html":{"href":"https://github.com/sdroege/gstreamer-rs/pull/119"},"issue":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/119"},"comments":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/sdroege/gstreamer-rs/statuses/598a2b6d17a047d2f75ffce610323619ea197481"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sdroege"}}