{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/comments/168006491","pull_request_review_id":96306300,"id":168006491,"diff_hunk":"@@ -520,6 +486,8 @@ protected function getMediaManager()\n     /**\n      * Write a Gallery, this method is used by both POST and PUT action methods.\n      *\n+     * @View(serializerGroups={\"sonata_api_read\"}, serializerEnableMaxDepthChecks=true)","path":"src/Controller/Api/GalleryController.php","position":null,"original_position":85,"commit_id":"56e18063ce0305813893a71b2d509255beca7067","original_commit_id":"498a553888398cd6943472c8101416baae509795","user":{"login":"jordisala1991","id":1137485,"avatar_url":"https://avatars3.githubusercontent.com/u/1137485?v=4","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},"body":"I have decided to revert this, because it was used on a protected method, and will probably break BC that a method that returns a view, suddenly starts returning a media.\r\n\r\nLet's not create any issue with this change. wdyt?","created_at":"2018-02-13T21:27:32Z","updated_at":"2018-02-13T21:27:33Z","html_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1389#discussion_r168006491","pull_request_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1389","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/comments/168006491"},"html":{"href":"https://github.com/sonata-project/SonataMediaBundle/pull/1389#discussion_r168006491"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1389"}},"in_reply_to_id":168003440},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1389","id":168681350,"html_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1389","diff_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1389.diff","patch_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1389.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1389","number":1389,"state":"open","locked":false,"title":"Remove compatibility with FOSRest < 2.1","user":{"login":"jordisala1991","id":1137485,"avatar_url":"https://avatars3.githubusercontent.com/u/1137485?v=4","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT, MAKE SURE YOU READ AND EDIT IT! -->\r\n\r\n<!--\r\n    Show us you choose the right branch.\r\n    Different branches are used for different things :\r\n    - 3.x is for everything backwards compatible, like patches, features and deprecation notices\r\n    - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n    More details here: https://github.com/sonata-project/SonataMediaBundle/blob/3.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nI am targeting this branch, because this is BC.\r\n\r\n<!--\r\n    Specify which issues will be fixed/closed.\r\n    Remove it if this is not related.\r\n-->\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n### Removed\r\n- Removed compatibility with older versions of FOSRestBundle (<2.1)\r\n```\r\n\r\n## Subject\r\n\r\n<!-- Describe your Pull Request content here -->\r\nSince dropping a dependency is not a BC break, this is a good start, because we are doing a lot of code just to keep compat with FOSRest 1.\r\n\r\nThose are the PR adding this code, to check if I did correctly or not: https://github.com/sonata-project/SonataMediaBundle/pull/1071 https://github.com/sonata-project/SonataMediaBundle/pull/1155 https://github.com/sonata-project/SonataMediaBundle/pull/1339 ","created_at":"2018-02-12T20:35:22Z","updated_at":"2018-02-13T21:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"778dcd2f07110cc29b141e594bebd1c59d04cebc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":369793221,"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/labels/minor","name":"minor","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1389/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1389/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1389/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/statuses/56e18063ce0305813893a71b2d509255beca7067","head":{"label":"jordisala1991:hotfix/fosrest","ref":"hotfix/fosrest","sha":"56e18063ce0305813893a71b2d509255beca7067","user":{"login":"jordisala1991","id":1137485,"avatar_url":"https://avatars3.githubusercontent.com/u/1137485?v=4","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},"repo":{"id":59611311,"name":"SonataMediaBundle","full_name":"jordisala1991/SonataMediaBundle","owner":{"login":"jordisala1991","id":1137485,"avatar_url":"https://avatars3.githubusercontent.com/u/1137485?v=4","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jordisala1991/SonataMediaBundle","description":"Media management bundle on steroid for Symfony2","fork":true,"url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle","forks_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/forks","keys_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/teams","hooks_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/hooks","issue_events_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/issues/events{/number}","events_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/events","assignees_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/assignees{/user}","branches_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/branches{/branch}","tags_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/tags","blobs_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/languages","stargazers_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/stargazers","contributors_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/contributors","subscribers_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/subscribers","subscription_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/subscription","commits_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/contents/{+path}","compare_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/merges","archive_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/downloads","issues_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/issues{/number}","pulls_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/labels{/name}","releases_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/releases{/id}","deployments_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/deployments","created_at":"2016-05-24T21:54:29Z","updated_at":"2016-05-24T21:54:31Z","pushed_at":"2018-02-13T21:26:22Z","git_url":"git://github.com/jordisala1991/SonataMediaBundle.git","ssh_url":"git@github.com:jordisala1991/SonataMediaBundle.git","clone_url":"https://github.com/jordisala1991/SonataMediaBundle.git","svn_url":"https://github.com/jordisala1991/SonataMediaBundle","homepage":"http://sonata-project.org/bundles/media","size":3690,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"73e80e1c51a4d68e9f8488c183ff5892ad56b54b","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1059291,"name":"SonataMediaBundle","full_name":"sonata-project/SonataMediaBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataMediaBundle","description":"Media management bundle on steroid for Symfony2","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/deployments","created_at":"2010-11-07T14:41:46Z","updated_at":"2018-02-11T03:17:11Z","pushed_at":"2018-02-13T21:26:24Z","git_url":"git://github.com/sonata-project/SonataMediaBundle.git","ssh_url":"git@github.com:sonata-project/SonataMediaBundle.git","clone_url":"https://github.com/sonata-project/SonataMediaBundle.git","svn_url":"https://github.com/sonata-project/SonataMediaBundle","homepage":"https://sonata-project.org/","size":3768,"stargazers_count":347,"watchers_count":347,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":437,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":437,"open_issues":121,"watchers":347,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1389"},"html":{"href":"https://github.com/sonata-project/SonataMediaBundle/pull/1389"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1389"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1389/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1389/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1389/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/statuses/56e18063ce0305813893a71b2d509255beca7067"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jordisala1991"}}