{"action":"created","comment":{"url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/comments/197607936","pull_request_review_id":131390445,"id":197607936,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzYwNzkzNg==","diff_hunk":"@@ -27,24 +27,22 @@ using rotation_t = std::tuple<double, double, double>;\n using point3d_t = std::tuple<double, double, double>;\n using sensor_data_t = std::tuple<geo_t, rotation_t>;\n \n-void check_existence(const std::initializer_list<fs::path>& paths)\n-{\n+void check_existence(const std::initializer_list<fs::path>& paths) {","path":"experiments/cpp/geoconv2/apps/app-oxts2local.cpp","position":null,"original_position":6,"commit_id":"eb76155c1c74f68fc43a510d86ed8447e46153e8","original_commit_id":"eb76155c1c74f68fc43a510d86ed8447e46153e8","user":{"login":"paul-michalik","id":10583150,"node_id":"MDQ6VXNlcjEwNTgzMTUw","avatar_url":"https://avatars3.githubusercontent.com/u/10583150?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-michalik","html_url":"https://github.com/paul-michalik","followers_url":"https://api.github.com/users/paul-michalik/followers","following_url":"https://api.github.com/users/paul-michalik/following{/other_user}","gists_url":"https://api.github.com/users/paul-michalik/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-michalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-michalik/subscriptions","organizations_url":"https://api.github.com/users/paul-michalik/orgs","repos_url":"https://api.github.com/users/paul-michalik/repos","events_url":"https://api.github.com/users/paul-michalik/events{/privacy}","received_events_url":"https://api.github.com/users/paul-michalik/received_events","type":"User","site_admin":false},"body":"Just a side note: You'd rarely find usage explicit usage of `initializer_list` except of constructor. We prefer a generic implementation with a `template<class TRange> void foo(TRange&&);` or the traditional `template<class TIter> void foo(TIter b_, TIter e_);`","created_at":"2018-06-23T09:49:11Z","updated_at":"2018-06-23T09:52:09Z","html_url":"https://github.com/paul-michalik/ORB_SLAM2/pull/86#discussion_r197607936","pull_request_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/86","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/comments/197607936"},"html":{"href":"https://github.com/paul-michalik/ORB_SLAM2/pull/86#discussion_r197607936"},"pull_request":{"href":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/86","id":194634941,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjM0OTQx","html_url":"https://github.com/paul-michalik/ORB_SLAM2/pull/86","diff_url":"https://github.com/paul-michalik/ORB_SLAM2/pull/86.diff","patch_url":"https://github.com/paul-michalik/ORB_SLAM2/pull/86.patch","issue_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/issues/86","number":86,"state":"open","locked":false,"title":"feature/INTHAD-147-GPS-fusion","user":{"login":"shanmukhananda","id":6041150,"node_id":"MDQ6VXNlcjYwNDExNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6041150?v=4","gravatar_id":"","url":"https://api.github.com/users/shanmukhananda","html_url":"https://github.com/shanmukhananda","followers_url":"https://api.github.com/users/shanmukhananda/followers","following_url":"https://api.github.com/users/shanmukhananda/following{/other_user}","gists_url":"https://api.github.com/users/shanmukhananda/gists{/gist_id}","starred_url":"https://api.github.com/users/shanmukhananda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanmukhananda/subscriptions","organizations_url":"https://api.github.com/users/shanmukhananda/orgs","repos_url":"https://api.github.com/users/shanmukhananda/repos","events_url":"https://api.github.com/users/shanmukhananda/events{/privacy}","received_events_url":"https://api.github.com/users/shanmukhananda/received_events","type":"User","site_admin":false},"body":"PR from `feature/INTHAD-147-GPS-fusion` to `feature/use-out-of-source-g2o`\r\n\r\nContains changes for using position from external source as prior edges.\r\nDO-NOT REVIEW `ORB_SLAM2/experiments` its not part of slam app/lib.\r\n`data/` folder contain report from testing hence PR has lot of files. Its recommended to review using comparison tool.\r\n","created_at":"2018-06-13T15:53:07Z","updated_at":"2018-06-23T09:52:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9976614f38b81478dc8e037c389ee167a371d7b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/86/commits","review_comments_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/86/comments","review_comment_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/issues/86/comments","statuses_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/statuses/eb76155c1c74f68fc43a510d86ed8447e46153e8","head":{"label":"paul-michalik:feature/INTHAD-147-GPS-fusion","ref":"feature/INTHAD-147-GPS-fusion","sha":"eb76155c1c74f68fc43a510d86ed8447e46153e8","user":{"login":"paul-michalik","id":10583150,"node_id":"MDQ6VXNlcjEwNTgzMTUw","avatar_url":"https://avatars3.githubusercontent.com/u/10583150?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-michalik","html_url":"https://github.com/paul-michalik","followers_url":"https://api.github.com/users/paul-michalik/followers","following_url":"https://api.github.com/users/paul-michalik/following{/other_user}","gists_url":"https://api.github.com/users/paul-michalik/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-michalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-michalik/subscriptions","organizations_url":"https://api.github.com/users/paul-michalik/orgs","repos_url":"https://api.github.com/users/paul-michalik/repos","events_url":"https://api.github.com/users/paul-michalik/events{/privacy}","received_events_url":"https://api.github.com/users/paul-michalik/received_events","type":"User","site_admin":false},"repo":{"id":102357972,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzNTc5NzI=","name":"ORB_SLAM2","full_name":"paul-michalik/ORB_SLAM2","owner":{"login":"paul-michalik","id":10583150,"node_id":"MDQ6VXNlcjEwNTgzMTUw","avatar_url":"https://avatars3.githubusercontent.com/u/10583150?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-michalik","html_url":"https://github.com/paul-michalik","followers_url":"https://api.github.com/users/paul-michalik/followers","following_url":"https://api.github.com/users/paul-michalik/following{/other_user}","gists_url":"https://api.github.com/users/paul-michalik/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-michalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-michalik/subscriptions","organizations_url":"https://api.github.com/users/paul-michalik/orgs","repos_url":"https://api.github.com/users/paul-michalik/repos","events_url":"https://api.github.com/users/paul-michalik/events{/privacy}","received_events_url":"https://api.github.com/users/paul-michalik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paul-michalik/ORB_SLAM2","description":"Real-Time SLAM for Monocular, Stereo and RGB-D Cameras, with Loop Detection and Relocalization Capabilities","fork":true,"url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2","forks_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/forks","keys_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/teams","hooks_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/hooks","issue_events_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/issues/events{/number}","events_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/events","assignees_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/assignees{/user}","branches_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/branches{/branch}","tags_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/tags","blobs_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/git/refs{/sha}","trees_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/statuses/{sha}","languages_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/languages","stargazers_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/stargazers","contributors_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/contributors","subscribers_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/subscribers","subscription_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/subscription","commits_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/commits{/sha}","git_commits_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/git/commits{/sha}","comments_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/comments{/number}","issue_comment_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/issues/comments{/number}","contents_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/contents/{+path}","compare_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/merges","archive_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/downloads","issues_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/issues{/number}","pulls_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls{/number}","milestones_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/milestones{/number}","notifications_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/labels{/name}","releases_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/releases{/id}","deployments_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/deployments","created_at":"2017-09-04T12:16:18Z","updated_at":"2018-06-21T16:42:17Z","pushed_at":"2018-06-23T08:00:02Z","git_url":"git://github.com/paul-michalik/ORB_SLAM2.git","ssh_url":"git@github.com:paul-michalik/ORB_SLAM2.git","clone_url":"https://github.com/paul-michalik/ORB_SLAM2.git","svn_url":"https://github.com/paul-michalik/ORB_SLAM2","homepage":null,"size":83792,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":19,"watchers":4,"default_branch":"master"}},"base":{"label":"paul-michalik:master","ref":"master","sha":"5a09698d26160e68cce2069686627a7f5ef2076c","user":{"login":"paul-michalik","id":10583150,"node_id":"MDQ6VXNlcjEwNTgzMTUw","avatar_url":"https://avatars3.githubusercontent.com/u/10583150?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-michalik","html_url":"https://github.com/paul-michalik","followers_url":"https://api.github.com/users/paul-michalik/followers","following_url":"https://api.github.com/users/paul-michalik/following{/other_user}","gists_url":"https://api.github.com/users/paul-michalik/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-michalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-michalik/subscriptions","organizations_url":"https://api.github.com/users/paul-michalik/orgs","repos_url":"https://api.github.com/users/paul-michalik/repos","events_url":"https://api.github.com/users/paul-michalik/events{/privacy}","received_events_url":"https://api.github.com/users/paul-michalik/received_events","type":"User","site_admin":false},"repo":{"id":102357972,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzNTc5NzI=","name":"ORB_SLAM2","full_name":"paul-michalik/ORB_SLAM2","owner":{"login":"paul-michalik","id":10583150,"node_id":"MDQ6VXNlcjEwNTgzMTUw","avatar_url":"https://avatars3.githubusercontent.com/u/10583150?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-michalik","html_url":"https://github.com/paul-michalik","followers_url":"https://api.github.com/users/paul-michalik/followers","following_url":"https://api.github.com/users/paul-michalik/following{/other_user}","gists_url":"https://api.github.com/users/paul-michalik/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-michalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-michalik/subscriptions","organizations_url":"https://api.github.com/users/paul-michalik/orgs","repos_url":"https://api.github.com/users/paul-michalik/repos","events_url":"https://api.github.com/users/paul-michalik/events{/privacy}","received_events_url":"https://api.github.com/users/paul-michalik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paul-michalik/ORB_SLAM2","description":"Real-Time SLAM for Monocular, Stereo and RGB-D Cameras, with Loop Detection and Relocalization Capabilities","fork":true,"url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2","forks_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/forks","keys_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/teams","hooks_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/hooks","issue_events_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/issues/events{/number}","events_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/events","assignees_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/assignees{/user}","branches_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/branches{/branch}","tags_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/tags","blobs_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/git/refs{/sha}","trees_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/statuses/{sha}","languages_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/languages","stargazers_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/stargazers","contributors_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/contributors","subscribers_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/subscribers","subscription_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/subscription","commits_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/commits{/sha}","git_commits_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/git/commits{/sha}","comments_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/comments{/number}","issue_comment_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/issues/comments{/number}","contents_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/contents/{+path}","compare_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/merges","archive_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/downloads","issues_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/issues{/number}","pulls_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls{/number}","milestones_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/milestones{/number}","notifications_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/labels{/name}","releases_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/releases{/id}","deployments_url":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/deployments","created_at":"2017-09-04T12:16:18Z","updated_at":"2018-06-21T16:42:17Z","pushed_at":"2018-06-23T08:00:02Z","git_url":"git://github.com/paul-michalik/ORB_SLAM2.git","ssh_url":"git@github.com:paul-michalik/ORB_SLAM2.git","clone_url":"https://github.com/paul-michalik/ORB_SLAM2.git","svn_url":"https://github.com/paul-michalik/ORB_SLAM2","homepage":null,"size":83792,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":19,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/86"},"html":{"href":"https://github.com/paul-michalik/ORB_SLAM2/pull/86"},"issue":{"href":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/issues/86"},"comments":{"href":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/paul-michalik/ORB_SLAM2/statuses/eb76155c1c74f68fc43a510d86ed8447e46153e8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"paul-michalik"}}