{"action":"created","comment":{"url":"https://api.github.com/repos/SolutionGuidance/psm/pulls/comments/165416633","pull_request_review_id":93353089,"id":165416633,"diff_hunk":"@@ -44,7 +44,7 @@\n                 <div class=\"floatW\">\n                   <div class=\"leftCol\">\n                     <div class=\"row\">\n-                      <label>NPI/UMPI</label>\n+                      <label for=\"npiInput\">NPI/UMPI</label>","path":"psm-app/cms-web/WebContent/WEB-INF/pages/admin/service_agent_enrollments_quick.jsp","position":5,"original_position":5,"commit_id":"2a80aaa07ee700140195242b083356d22fc8629a","original_commit_id":"582ba96cdd9c00cf6cbef6f56b3923af9f7b7947","user":{"login":"cecilia-donnelly","id":1497818,"avatar_url":"https://avatars0.githubusercontent.com/u/1497818?v=4","gravatar_id":"","url":"https://api.github.com/users/cecilia-donnelly","html_url":"https://github.com/cecilia-donnelly","followers_url":"https://api.github.com/users/cecilia-donnelly/followers","following_url":"https://api.github.com/users/cecilia-donnelly/following{/other_user}","gists_url":"https://api.github.com/users/cecilia-donnelly/gists{/gist_id}","starred_url":"https://api.github.com/users/cecilia-donnelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cecilia-donnelly/subscriptions","organizations_url":"https://api.github.com/users/cecilia-donnelly/orgs","repos_url":"https://api.github.com/users/cecilia-donnelly/repos","events_url":"https://api.github.com/users/cecilia-donnelly/events{/privacy}","received_events_url":"https://api.github.com/users/cecilia-donnelly/received_events","type":"User","site_admin":false},"body":"Hey @jasonaowen, we're specifically not fixing the duplicate IDs on inputs in this PR.  We know that, for example, multiple forms have inputs with the id `npiInput`.  What I meant is that since this PR is about adding accessibility we are not fixing that existing problem.","created_at":"2018-02-01T16:47:48Z","updated_at":"2018-02-01T16:47:49Z","html_url":"https://github.com/SolutionGuidance/psm/pull/583#discussion_r165416633","pull_request_url":"https://api.github.com/repos/SolutionGuidance/psm/pulls/583","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SolutionGuidance/psm/pulls/comments/165416633"},"html":{"href":"https://github.com/SolutionGuidance/psm/pull/583#discussion_r165416633"},"pull_request":{"href":"https://api.github.com/repos/SolutionGuidance/psm/pulls/583"}},"in_reply_to_id":159111460},"pull_request":{"url":"https://api.github.com/repos/SolutionGuidance/psm/pulls/583","id":158828681,"html_url":"https://github.com/SolutionGuidance/psm/pull/583","diff_url":"https://github.com/SolutionGuidance/psm/pull/583.diff","patch_url":"https://github.com/SolutionGuidance/psm/pull/583.patch","issue_url":"https://api.github.com/repos/SolutionGuidance/psm/issues/583","number":583,"state":"open","locked":false,"title":"Associate labels and add titles","user":{"login":"slifty","id":208884,"avatar_url":"https://avatars1.githubusercontent.com/u/208884?v=4","gravatar_id":"","url":"https://api.github.com/users/slifty","html_url":"https://github.com/slifty","followers_url":"https://api.github.com/users/slifty/followers","following_url":"https://api.github.com/users/slifty/following{/other_user}","gists_url":"https://api.github.com/users/slifty/gists{/gist_id}","starred_url":"https://api.github.com/users/slifty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slifty/subscriptions","organizations_url":"https://api.github.com/users/slifty/orgs","repos_url":"https://api.github.com/users/slifty/repos","events_url":"https://api.github.com/users/slifty/events{/privacy}","received_events_url":"https://api.github.com/users/slifty/received_events","type":"User","site_admin":false},"body":"This is a HUGE commit, apologies, but it was the only scalable way to\r\nmake these changes.  This commit associates labels with form elements\r\nin all cases possible using `for` and `id` attributes on the related\r\nDOM elements.\r\n\r\nIn cases where no label exists (or when the label applies to multiple\r\nelements, such as in a table-based form with multiple rows) the `title`\r\nattribute is used instead.\r\n\r\nMany of the forms used a pattern of `formName` to name form elements.\r\nThis name was combined with a form level ID to attempt to ensure unique\r\nids.  However, there are absolutely id conflicts which need to be fixed\r\nin future commits.  Some of these conflicts existed in the previous code\r\nbut some of these conflicts are the result of mega-forms that break DRY.\r\n\r\nWe're not going to fix the mega-forms in this branch, but the id conflicts\r\nshould be evaluated and fixed as soon as possible, even if not in this\r\nparticular set of changes.","created_at":"2017-12-18T04:36:08Z","updated_at":"2018-02-01T16:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc64cadbf401d93df217942d86171062d03af4e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/SolutionGuidance/psm/pulls/583/commits","review_comments_url":"https://api.github.com/repos/SolutionGuidance/psm/pulls/583/comments","review_comment_url":"https://api.github.com/repos/SolutionGuidance/psm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SolutionGuidance/psm/issues/583/comments","statuses_url":"https://api.github.com/repos/SolutionGuidance/psm/statuses/2a80aaa07ee700140195242b083356d22fc8629a","head":{"label":"SolutionGuidance:554-input-accessibility","ref":"554-input-accessibility","sha":"2a80aaa07ee700140195242b083356d22fc8629a","user":{"login":"SolutionGuidance","id":28989268,"avatar_url":"https://avatars2.githubusercontent.com/u/28989268?v=4","gravatar_id":"","url":"https://api.github.com/users/SolutionGuidance","html_url":"https://github.com/SolutionGuidance","followers_url":"https://api.github.com/users/SolutionGuidance/followers","following_url":"https://api.github.com/users/SolutionGuidance/following{/other_user}","gists_url":"https://api.github.com/users/SolutionGuidance/gists{/gist_id}","starred_url":"https://api.github.com/users/SolutionGuidance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolutionGuidance/subscriptions","organizations_url":"https://api.github.com/users/SolutionGuidance/orgs","repos_url":"https://api.github.com/users/SolutionGuidance/repos","events_url":"https://api.github.com/users/SolutionGuidance/events{/privacy}","received_events_url":"https://api.github.com/users/SolutionGuidance/received_events","type":"Organization","site_admin":false},"repo":{"id":66302616,"name":"psm","full_name":"SolutionGuidance/psm","owner":{"login":"SolutionGuidance","id":28989268,"avatar_url":"https://avatars2.githubusercontent.com/u/28989268?v=4","gravatar_id":"","url":"https://api.github.com/users/SolutionGuidance","html_url":"https://github.com/SolutionGuidance","followers_url":"https://api.github.com/users/SolutionGuidance/followers","following_url":"https://api.github.com/users/SolutionGuidance/following{/other_user}","gists_url":"https://api.github.com/users/SolutionGuidance/gists{/gist_id}","starred_url":"https://api.github.com/users/SolutionGuidance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolutionGuidance/subscriptions","organizations_url":"https://api.github.com/users/SolutionGuidance/orgs","repos_url":"https://api.github.com/users/SolutionGuidance/repos","events_url":"https://api.github.com/users/SolutionGuidance/events{/privacy}","received_events_url":"https://api.github.com/users/SolutionGuidance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SolutionGuidance/psm","description":"Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal","fork":false,"url":"https://api.github.com/repos/SolutionGuidance/psm","forks_url":"https://api.github.com/repos/SolutionGuidance/psm/forks","keys_url":"https://api.github.com/repos/SolutionGuidance/psm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SolutionGuidance/psm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SolutionGuidance/psm/teams","hooks_url":"https://api.github.com/repos/SolutionGuidance/psm/hooks","issue_events_url":"https://api.github.com/repos/SolutionGuidance/psm/issues/events{/number}","events_url":"https://api.github.com/repos/SolutionGuidance/psm/events","assignees_url":"https://api.github.com/repos/SolutionGuidance/psm/assignees{/user}","branches_url":"https://api.github.com/repos/SolutionGuidance/psm/branches{/branch}","tags_url":"https://api.github.com/repos/SolutionGuidance/psm/tags","blobs_url":"https://api.github.com/repos/SolutionGuidance/psm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SolutionGuidance/psm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SolutionGuidance/psm/git/refs{/sha}","trees_url":"https://api.github.com/repos/SolutionGuidance/psm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SolutionGuidance/psm/statuses/{sha}","languages_url":"https://api.github.com/repos/SolutionGuidance/psm/languages","stargazers_url":"https://api.github.com/repos/SolutionGuidance/psm/stargazers","contributors_url":"https://api.github.com/repos/SolutionGuidance/psm/contributors","subscribers_url":"https://api.github.com/repos/SolutionGuidance/psm/subscribers","subscription_url":"https://api.github.com/repos/SolutionGuidance/psm/subscription","commits_url":"https://api.github.com/repos/SolutionGuidance/psm/commits{/sha}","git_commits_url":"https://api.github.com/repos/SolutionGuidance/psm/git/commits{/sha}","comments_url":"https://api.github.com/repos/SolutionGuidance/psm/comments{/number}","issue_comment_url":"https://api.github.com/repos/SolutionGuidance/psm/issues/comments{/number}","contents_url":"https://api.github.com/repos/SolutionGuidance/psm/contents/{+path}","compare_url":"https://api.github.com/repos/SolutionGuidance/psm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SolutionGuidance/psm/merges","archive_url":"https://api.github.com/repos/SolutionGuidance/psm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SolutionGuidance/psm/downloads","issues_url":"https://api.github.com/repos/SolutionGuidance/psm/issues{/number}","pulls_url":"https://api.github.com/repos/SolutionGuidance/psm/pulls{/number}","milestones_url":"https://api.github.com/repos/SolutionGuidance/psm/milestones{/number}","notifications_url":"https://api.github.com/repos/SolutionGuidance/psm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SolutionGuidance/psm/labels{/name}","releases_url":"https://api.github.com/repos/SolutionGuidance/psm/releases{/id}","deployments_url":"https://api.github.com/repos/SolutionGuidance/psm/deployments","created_at":"2016-08-22T19:40:02Z","updated_at":"2018-01-23T20:19:27Z","pushed_at":"2018-01-31T21:44:52Z","git_url":"git://github.com/SolutionGuidance/psm.git","ssh_url":"git@github.com:SolutionGuidance/psm.git","clone_url":"https://github.com/SolutionGuidance/psm.git","svn_url":"https://github.com/SolutionGuidance/psm","homepage":"","size":220030,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":8,"open_issues":182,"watchers":11,"default_branch":"master"}},"base":{"label":"SolutionGuidance:master","ref":"master","sha":"70a0ba6b201146fe8064bcb993203e45ebeb9e99","user":{"login":"SolutionGuidance","id":28989268,"avatar_url":"https://avatars2.githubusercontent.com/u/28989268?v=4","gravatar_id":"","url":"https://api.github.com/users/SolutionGuidance","html_url":"https://github.com/SolutionGuidance","followers_url":"https://api.github.com/users/SolutionGuidance/followers","following_url":"https://api.github.com/users/SolutionGuidance/following{/other_user}","gists_url":"https://api.github.com/users/SolutionGuidance/gists{/gist_id}","starred_url":"https://api.github.com/users/SolutionGuidance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolutionGuidance/subscriptions","organizations_url":"https://api.github.com/users/SolutionGuidance/orgs","repos_url":"https://api.github.com/users/SolutionGuidance/repos","events_url":"https://api.github.com/users/SolutionGuidance/events{/privacy}","received_events_url":"https://api.github.com/users/SolutionGuidance/received_events","type":"Organization","site_admin":false},"repo":{"id":66302616,"name":"psm","full_name":"SolutionGuidance/psm","owner":{"login":"SolutionGuidance","id":28989268,"avatar_url":"https://avatars2.githubusercontent.com/u/28989268?v=4","gravatar_id":"","url":"https://api.github.com/users/SolutionGuidance","html_url":"https://github.com/SolutionGuidance","followers_url":"https://api.github.com/users/SolutionGuidance/followers","following_url":"https://api.github.com/users/SolutionGuidance/following{/other_user}","gists_url":"https://api.github.com/users/SolutionGuidance/gists{/gist_id}","starred_url":"https://api.github.com/users/SolutionGuidance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolutionGuidance/subscriptions","organizations_url":"https://api.github.com/users/SolutionGuidance/orgs","repos_url":"https://api.github.com/users/SolutionGuidance/repos","events_url":"https://api.github.com/users/SolutionGuidance/events{/privacy}","received_events_url":"https://api.github.com/users/SolutionGuidance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SolutionGuidance/psm","description":"Welcome to the Medicare/Medicaid Provider Enrollment Screening Portal","fork":false,"url":"https://api.github.com/repos/SolutionGuidance/psm","forks_url":"https://api.github.com/repos/SolutionGuidance/psm/forks","keys_url":"https://api.github.com/repos/SolutionGuidance/psm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SolutionGuidance/psm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SolutionGuidance/psm/teams","hooks_url":"https://api.github.com/repos/SolutionGuidance/psm/hooks","issue_events_url":"https://api.github.com/repos/SolutionGuidance/psm/issues/events{/number}","events_url":"https://api.github.com/repos/SolutionGuidance/psm/events","assignees_url":"https://api.github.com/repos/SolutionGuidance/psm/assignees{/user}","branches_url":"https://api.github.com/repos/SolutionGuidance/psm/branches{/branch}","tags_url":"https://api.github.com/repos/SolutionGuidance/psm/tags","blobs_url":"https://api.github.com/repos/SolutionGuidance/psm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SolutionGuidance/psm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SolutionGuidance/psm/git/refs{/sha}","trees_url":"https://api.github.com/repos/SolutionGuidance/psm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SolutionGuidance/psm/statuses/{sha}","languages_url":"https://api.github.com/repos/SolutionGuidance/psm/languages","stargazers_url":"https://api.github.com/repos/SolutionGuidance/psm/stargazers","contributors_url":"https://api.github.com/repos/SolutionGuidance/psm/contributors","subscribers_url":"https://api.github.com/repos/SolutionGuidance/psm/subscribers","subscription_url":"https://api.github.com/repos/SolutionGuidance/psm/subscription","commits_url":"https://api.github.com/repos/SolutionGuidance/psm/commits{/sha}","git_commits_url":"https://api.github.com/repos/SolutionGuidance/psm/git/commits{/sha}","comments_url":"https://api.github.com/repos/SolutionGuidance/psm/comments{/number}","issue_comment_url":"https://api.github.com/repos/SolutionGuidance/psm/issues/comments{/number}","contents_url":"https://api.github.com/repos/SolutionGuidance/psm/contents/{+path}","compare_url":"https://api.github.com/repos/SolutionGuidance/psm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SolutionGuidance/psm/merges","archive_url":"https://api.github.com/repos/SolutionGuidance/psm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SolutionGuidance/psm/downloads","issues_url":"https://api.github.com/repos/SolutionGuidance/psm/issues{/number}","pulls_url":"https://api.github.com/repos/SolutionGuidance/psm/pulls{/number}","milestones_url":"https://api.github.com/repos/SolutionGuidance/psm/milestones{/number}","notifications_url":"https://api.github.com/repos/SolutionGuidance/psm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SolutionGuidance/psm/labels{/name}","releases_url":"https://api.github.com/repos/SolutionGuidance/psm/releases{/id}","deployments_url":"https://api.github.com/repos/SolutionGuidance/psm/deployments","created_at":"2016-08-22T19:40:02Z","updated_at":"2018-01-23T20:19:27Z","pushed_at":"2018-01-31T21:44:52Z","git_url":"git://github.com/SolutionGuidance/psm.git","ssh_url":"git@github.com:SolutionGuidance/psm.git","clone_url":"https://github.com/SolutionGuidance/psm.git","svn_url":"https://github.com/SolutionGuidance/psm","homepage":"","size":220030,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":8,"open_issues":182,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SolutionGuidance/psm/pulls/583"},"html":{"href":"https://github.com/SolutionGuidance/psm/pull/583"},"issue":{"href":"https://api.github.com/repos/SolutionGuidance/psm/issues/583"},"comments":{"href":"https://api.github.com/repos/SolutionGuidance/psm/issues/583/comments"},"review_comments":{"href":"https://api.github.com/repos/SolutionGuidance/psm/pulls/583/comments"},"review_comment":{"href":"https://api.github.com/repos/SolutionGuidance/psm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SolutionGuidance/psm/pulls/583/commits"},"statuses":{"href":"https://api.github.com/repos/SolutionGuidance/psm/statuses/2a80aaa07ee700140195242b083356d22fc8629a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cecilia-donnelly"}}