{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubeadm/issues/786","repository_url":"https://api.github.com/repos/kubernetes/kubeadm","labels_url":"https://api.github.com/repos/kubernetes/kubeadm/issues/786/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubeadm/issues/786/comments","events_url":"https://api.github.com/repos/kubernetes/kubeadm/issues/786/events","html_url":"https://github.com/kubernetes/kubeadm/issues/786","id":319804639,"number":786,"title":"Flag to add extra SAN for etcd server in kubeadm ","user":{"login":"gauravyadav01","id":12859625,"avatar_url":"https://avatars3.githubusercontent.com/u/12859625?v=4","gravatar_id":"","url":"https://api.github.com/users/gauravyadav01","html_url":"https://github.com/gauravyadav01","followers_url":"https://api.github.com/users/gauravyadav01/followers","following_url":"https://api.github.com/users/gauravyadav01/following{/other_user}","gists_url":"https://api.github.com/users/gauravyadav01/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravyadav01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravyadav01/subscriptions","organizations_url":"https://api.github.com/users/gauravyadav01/orgs","repos_url":"https://api.github.com/users/gauravyadav01/repos","events_url":"https://api.github.com/users/gauravyadav01/events{/privacy}","received_events_url":"https://api.github.com/users/gauravyadav01/received_events","type":"User","site_admin":false},"labels":[{"id":488818423,"url":"https://api.github.com/repos/kubernetes/kubeadm/labels/priority/important-longterm","name":"priority/important-longterm","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":{"login":"stealthybox","id":2754700,"avatar_url":"https://avatars0.githubusercontent.com/u/2754700?v=4","gravatar_id":"","url":"https://api.github.com/users/stealthybox","html_url":"https://github.com/stealthybox","followers_url":"https://api.github.com/users/stealthybox/followers","following_url":"https://api.github.com/users/stealthybox/following{/other_user}","gists_url":"https://api.github.com/users/stealthybox/gists{/gist_id}","starred_url":"https://api.github.com/users/stealthybox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stealthybox/subscriptions","organizations_url":"https://api.github.com/users/stealthybox/orgs","repos_url":"https://api.github.com/users/stealthybox/repos","events_url":"https://api.github.com/users/stealthybox/events{/privacy}","received_events_url":"https://api.github.com/users/stealthybox/received_events","type":"User","site_admin":false},"assignees":[{"login":"stealthybox","id":2754700,"avatar_url":"https://avatars0.githubusercontent.com/u/2754700?v=4","gravatar_id":"","url":"https://api.github.com/users/stealthybox","html_url":"https://github.com/stealthybox","followers_url":"https://api.github.com/users/stealthybox/followers","following_url":"https://api.github.com/users/stealthybox/following{/other_user}","gists_url":"https://api.github.com/users/stealthybox/gists{/gist_id}","starred_url":"https://api.github.com/users/stealthybox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stealthybox/subscriptions","organizations_url":"https://api.github.com/users/stealthybox/orgs","repos_url":"https://api.github.com/users/stealthybox/repos","events_url":"https://api.github.com/users/stealthybox/events{/privacy}","received_events_url":"https://api.github.com/users/stealthybox/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-05-03T06:49:51Z","updated_at":"2018-05-08T21:18:13Z","closed_at":null,"author_association":"NONE","body":"If this is a FEATURE REQUEST, please:\r\n   Flag to add extra SANs for etcd server in kubeadm \r\n\r\n  - Describe *in detail* the feature/behavior/change you'd like to see.\r\n     Flag to add extra SANs for etcd server very similar to Api server --apiserver-cert-extra-sans in \r\n     Kubeadm.\r\n\r\n     Right now it is default to localhost and 127.0.0.1. \r\n\r\n## Versions\r\nkubeadm version: &version.Info{Major:\"1\", Minor:\"10\", GitVersion:\"v1.10.2\", GitCommit:\"81753b10df112992bf51bbc2c2f85208aad78335\", GitTreeState:\"clean\", BuildDate:\"2018-04-27T09:10:24Z\", GoVersion:\"go1.9.3\", Compiler:\"gc\", Platform:\"linux/amd64\"}\r\n\r\n- **Kubernetes version** (use `kubectl version`):\r\nClient Version: version.Info{Major:\"1\", Minor:\"10\", GitVersion:\"v1.10.2\", GitCommit:\"81753b10df112992bf51bbc2c2f85208aad78335\", GitTreeState:\"clean\", BuildDate:\"2018-04-27T09:22:21Z\", GoVersion:\"go1.9.3\", Compiler:\"gc\", Platform:\"linux/amd64\"}\r\n\r\n- **Cloud provider or hardware configuration**:\r\n\r\nVagrant \r\n- **OS** (e.g. from /etc/os-release):\r\nCentos 7.4\r\n\r\n- **Kernel** (e.g. `uname -a`):\r\nLinux master1.example.com 3.10.0-693.21.1.el7.x86_64 #1 SMP Wed Mar 7 19:03:37 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubeadm/issues/comments/387545581","html_url":"https://github.com/kubernetes/kubeadm/issues/786#issuecomment-387545581","issue_url":"https://api.github.com/repos/kubernetes/kubeadm/issues/786","id":387545581,"user":{"login":"stealthybox","id":2754700,"avatar_url":"https://avatars0.githubusercontent.com/u/2754700?v=4","gravatar_id":"","url":"https://api.github.com/users/stealthybox","html_url":"https://github.com/stealthybox","followers_url":"https://api.github.com/users/stealthybox/followers","following_url":"https://api.github.com/users/stealthybox/following{/other_user}","gists_url":"https://api.github.com/users/stealthybox/gists{/gist_id}","starred_url":"https://api.github.com/users/stealthybox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stealthybox/subscriptions","organizations_url":"https://api.github.com/users/stealthybox/orgs","repos_url":"https://api.github.com/users/stealthybox/repos","events_url":"https://api.github.com/users/stealthybox/events{/privacy}","received_events_url":"https://api.github.com/users/stealthybox/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T21:18:13Z","updated_at":"2018-05-08T21:18:13Z","author_association":"CONTRIBUTOR","body":"Thanks for submitting this issue @gauravyadav01 \r\nWe won't be adding a flag for this, as we're not adding flags anymore.\r\n\r\nIt is supported by the config file:\r\n```yaml\r\netcd:\r\n  serverCertSANs:\r\n    - hostname1\r\n    - hostname2\r\n  peerCertSANs:\r\n    - hostname2\r\n    - hostname3\r\n```\r\nThe code that implements this option is here:\r\nhttps://github.com/kubernetes/kubernetes/blob/8abc54d2576037b92c0fcae7aa4c43128332801c/cmd/kubeadm/app/apis/kubeadm/types.go#L198-L203\r\n\r\nIt looks like we need to update the docs to demonstrate this:\r\nhttps://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-init/#config-file"}}
{"actor":{"display_login":"stealthybox"}}