{"action":"created","comment":{"url":"https://api.github.com/repos/decidim/decidim/pulls/comments/235974011","pull_request_review_id":177967020,"id":235974011,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTk3NDAxMQ==","diff_hunk":"@@ -42,13 +42,40 @@ def create\n       end\n     end\n \n-    private\n-\n     def reject; end\n \n-    def review; end\n+    def review\n+      emendation_fields_form = emendation.form.from_model(emendation)\n+      params = emendation.attributes\n+      params[:id] = emendation.amendment.id\n+\n+      @form = Decidim::Amendable::ReviewForm.from_params(","path":"decidim-core/app/controllers/concerns/decidim/amendments_controller.rb","position":14,"original_position":14,"commit_id":"88a57b63b1c7ec69322c030f5cf4ee9f6680bc76","original_commit_id":"88a57b63b1c7ec69322c030f5cf4ee9f6680bc76","user":{"login":"oriolgual","id":5254,"node_id":"MDQ6VXNlcjUyNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5254?v=4","gravatar_id":"","url":"https://api.github.com/users/oriolgual","html_url":"https://github.com/oriolgual","followers_url":"https://api.github.com/users/oriolgual/followers","following_url":"https://api.github.com/users/oriolgual/following{/other_user}","gists_url":"https://api.github.com/users/oriolgual/gists{/gist_id}","starred_url":"https://api.github.com/users/oriolgual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oriolgual/subscriptions","organizations_url":"https://api.github.com/users/oriolgual/orgs","repos_url":"https://api.github.com/users/oriolgual/repos","events_url":"https://api.github.com/users/oriolgual/events{/privacy}","received_events_url":"https://api.github.com/users/oriolgual/received_events","type":"User","site_admin":false},"body":"Maybe add `from_model` to `ReviewForm` and move the logic there is a better option.","created_at":"2018-11-23T15:34:27Z","updated_at":"2018-11-23T15:44:58Z","html_url":"https://github.com/decidim/decidim/pull/3985#discussion_r235974011","pull_request_url":"https://api.github.com/repos/decidim/decidim/pulls/3985","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/decidim/decidim/pulls/comments/235974011"},"html":{"href":"https://github.com/decidim/decidim/pull/3985#discussion_r235974011"},"pull_request":{"href":"https://api.github.com/repos/decidim/decidim/pulls/3985"}}},"pull_request":{"url":"https://api.github.com/repos/decidim/decidim/pulls/3985","id":207270978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjcwOTc4","html_url":"https://github.com/decidim/decidim/pull/3985","diff_url":"https://github.com/decidim/decidim/pull/3985.diff","patch_url":"https://github.com/decidim/decidim/pull/3985.patch","issue_url":"https://api.github.com/repos/decidim/decidim/issues/3985","number":3985,"state":"open","locked":false,"title":"Feature accept amendments proposals on proposals ","user":{"login":"agustibr","id":210216,"node_id":"MDQ6VXNlcjIxMDIxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/210216?v=4","gravatar_id":"","url":"https://api.github.com/users/agustibr","html_url":"https://github.com/agustibr","followers_url":"https://api.github.com/users/agustibr/followers","following_url":"https://api.github.com/users/agustibr/following{/other_user}","gists_url":"https://api.github.com/users/agustibr/gists{/gist_id}","starred_url":"https://api.github.com/users/agustibr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agustibr/subscriptions","organizations_url":"https://api.github.com/users/agustibr/orgs","repos_url":"https://api.github.com/users/agustibr/repos","events_url":"https://api.github.com/users/agustibr/events{/privacy}","received_events_url":"https://api.github.com/users/agustibr/received_events","type":"User","site_admin":false},"body":"#### :tophat: What? Why?\r\n\r\nAdds **Accept Amendment** Funcionality to Amendments proposals on proposals #3958\r\n\r\n#### :pushpin: Related Issues\r\n- Related to #2292\r\n\r\n#### :clipboard: Subtasks\r\n- [ ] Add `CHANGELOG` entry\r\n- [ ] Add documentation regarding the feature \r\n- [ ] Add/modify seeds\r\n- [ ] Add tests\r\n- [ ] Another subtask\r\n\r\n### :camera: Screenshots (optional)\r\n\r\n+ ![screenshot from 2018-08-09 12-25-46](https://user-images.githubusercontent.com/210216/43893649-fbe6a036-9bcf-11e8-9f1d-7cd2668d370f.png)\r\n+ ![screenshot from 2018-08-09 12-26-04](https://user-images.githubusercontent.com/210216/43893673-1434adea-9bd0-11e8-9fc1-55861fd88a3f.png)\r\n+ ![screenshot from 2018-08-09 12-27-57](https://user-images.githubusercontent.com/210216/43893698-2288edfc-9bd0-11e8-8004-a65114343399.png)\r\n+ ![screenshot from 2018-08-09 12-28-16](https://user-images.githubusercontent.com/210216/43893706-2aff2d52-9bd0-11e8-9be2-87c197dedd30.png)\r\n+ ![screenshot from 2018-08-09 12-28-42](https://user-images.githubusercontent.com/210216/43893715-31c04c16-9bd0-11e8-9e3b-5f55a628ce19.png)\r\n\r\n","created_at":"2018-08-09T10:31:57Z","updated_at":"2018-11-23T15:44:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0f29680722c4bb922f2976fece8e94b34837a5b","assignee":{"login":"agustibr","id":210216,"node_id":"MDQ6VXNlcjIxMDIxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/210216?v=4","gravatar_id":"","url":"https://api.github.com/users/agustibr","html_url":"https://github.com/agustibr","followers_url":"https://api.github.com/users/agustibr/followers","following_url":"https://api.github.com/users/agustibr/following{/other_user}","gists_url":"https://api.github.com/users/agustibr/gists{/gist_id}","starred_url":"https://api.github.com/users/agustibr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agustibr/subscriptions","organizations_url":"https://api.github.com/users/agustibr/orgs","repos_url":"https://api.github.com/users/agustibr/repos","events_url":"https://api.github.com/users/agustibr/events{/privacy}","received_events_url":"https://api.github.com/users/agustibr/received_events","type":"User","site_admin":false},"assignees":[{"login":"agustibr","id":210216,"node_id":"MDQ6VXNlcjIxMDIxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/210216?v=4","gravatar_id":"","url":"https://api.github.com/users/agustibr","html_url":"https://github.com/agustibr","followers_url":"https://api.github.com/users/agustibr/followers","following_url":"https://api.github.com/users/agustibr/following{/other_user}","gists_url":"https://api.github.com/users/agustibr/gists{/gist_id}","starred_url":"https://api.github.com/users/agustibr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agustibr/subscriptions","organizations_url":"https://api.github.com/users/agustibr/orgs","repos_url":"https://api.github.com/users/agustibr/repos","events_url":"https://api.github.com/users/agustibr/events{/privacy}","received_events_url":"https://api.github.com/users/agustibr/received_events","type":"User","site_admin":false},{"login":"ailobe","id":40306853,"node_id":"MDQ6VXNlcjQwMzA2ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/40306853?v=4","gravatar_id":"","url":"https://api.github.com/users/ailobe","html_url":"https://github.com/ailobe","followers_url":"https://api.github.com/users/ailobe/followers","following_url":"https://api.github.com/users/ailobe/following{/other_user}","gists_url":"https://api.github.com/users/ailobe/gists{/gist_id}","starred_url":"https://api.github.com/users/ailobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ailobe/subscriptions","organizations_url":"https://api.github.com/users/ailobe/orgs","repos_url":"https://api.github.com/users/ailobe/repos","events_url":"https://api.github.com/users/ailobe/events{/privacy}","received_events_url":"https://api.github.com/users/ailobe/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":828660256,"node_id":"MDU6TGFiZWw4Mjg2NjAyNTY=","url":"https://api.github.com/repos/decidim/decidim/labels/status:%20WIP","name":"status: WIP","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/decidim/decidim/pulls/3985/commits","review_comments_url":"https://api.github.com/repos/decidim/decidim/pulls/3985/comments","review_comment_url":"https://api.github.com/repos/decidim/decidim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decidim/decidim/issues/3985/comments","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/88a57b63b1c7ec69322c030f5cf4ee9f6680bc76","head":{"label":"decidim:feature/amendments-proposals-on-proposals-accept","ref":"feature/amendments-proposals-on-proposals-accept","sha":"88a57b63b1c7ec69322c030f5cf4ee9f6680bc76","user":{"login":"decidim","id":22474646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc0NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"repo":{"id":65914086,"node_id":"MDEwOlJlcG9zaXRvcnk2NTkxNDA4Ng==","name":"decidim","full_name":"decidim/decidim","private":false,"owner":{"login":"decidim","id":22474646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc0NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decidim/decidim","description":"The participatory democracy framework. A generator and multiple gems made with Ruby on Rails. ","fork":false,"url":"https://api.github.com/repos/decidim/decidim","forks_url":"https://api.github.com/repos/decidim/decidim/forks","keys_url":"https://api.github.com/repos/decidim/decidim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decidim/decidim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decidim/decidim/teams","hooks_url":"https://api.github.com/repos/decidim/decidim/hooks","issue_events_url":"https://api.github.com/repos/decidim/decidim/issues/events{/number}","events_url":"https://api.github.com/repos/decidim/decidim/events","assignees_url":"https://api.github.com/repos/decidim/decidim/assignees{/user}","branches_url":"https://api.github.com/repos/decidim/decidim/branches{/branch}","tags_url":"https://api.github.com/repos/decidim/decidim/tags","blobs_url":"https://api.github.com/repos/decidim/decidim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decidim/decidim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decidim/decidim/git/refs{/sha}","trees_url":"https://api.github.com/repos/decidim/decidim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/{sha}","languages_url":"https://api.github.com/repos/decidim/decidim/languages","stargazers_url":"https://api.github.com/repos/decidim/decidim/stargazers","contributors_url":"https://api.github.com/repos/decidim/decidim/contributors","subscribers_url":"https://api.github.com/repos/decidim/decidim/subscribers","subscription_url":"https://api.github.com/repos/decidim/decidim/subscription","commits_url":"https://api.github.com/repos/decidim/decidim/commits{/sha}","git_commits_url":"https://api.github.com/repos/decidim/decidim/git/commits{/sha}","comments_url":"https://api.github.com/repos/decidim/decidim/comments{/number}","issue_comment_url":"https://api.github.com/repos/decidim/decidim/issues/comments{/number}","contents_url":"https://api.github.com/repos/decidim/decidim/contents/{+path}","compare_url":"https://api.github.com/repos/decidim/decidim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decidim/decidim/merges","archive_url":"https://api.github.com/repos/decidim/decidim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decidim/decidim/downloads","issues_url":"https://api.github.com/repos/decidim/decidim/issues{/number}","pulls_url":"https://api.github.com/repos/decidim/decidim/pulls{/number}","milestones_url":"https://api.github.com/repos/decidim/decidim/milestones{/number}","notifications_url":"https://api.github.com/repos/decidim/decidim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decidim/decidim/labels{/name}","releases_url":"https://api.github.com/repos/decidim/decidim/releases{/id}","deployments_url":"https://api.github.com/repos/decidim/decidim/deployments","created_at":"2016-08-17T14:27:06Z","updated_at":"2018-11-23T14:25:17Z","pushed_at":"2018-11-23T15:37:24Z","git_url":"git://github.com/decidim/decidim.git","ssh_url":"git@github.com:decidim/decidim.git","clone_url":"https://github.com/decidim/decidim.git","svn_url":"https://github.com/decidim/decidim","homepage":"http://www.decidim.org","size":67945,"stargazers_count":276,"watchers_count":276,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":99,"open_issues":199,"watchers":276,"default_branch":"master"}},"base":{"label":"decidim:feature/amendments-proposals-on-proposals","ref":"feature/amendments-proposals-on-proposals","sha":"7bade96258059cc3ef4ed5c835b6b7f7bf2f8613","user":{"login":"decidim","id":22474646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc0NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"repo":{"id":65914086,"node_id":"MDEwOlJlcG9zaXRvcnk2NTkxNDA4Ng==","name":"decidim","full_name":"decidim/decidim","private":false,"owner":{"login":"decidim","id":22474646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc0NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decidim/decidim","description":"The participatory democracy framework. A generator and multiple gems made with Ruby on Rails. ","fork":false,"url":"https://api.github.com/repos/decidim/decidim","forks_url":"https://api.github.com/repos/decidim/decidim/forks","keys_url":"https://api.github.com/repos/decidim/decidim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decidim/decidim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decidim/decidim/teams","hooks_url":"https://api.github.com/repos/decidim/decidim/hooks","issue_events_url":"https://api.github.com/repos/decidim/decidim/issues/events{/number}","events_url":"https://api.github.com/repos/decidim/decidim/events","assignees_url":"https://api.github.com/repos/decidim/decidim/assignees{/user}","branches_url":"https://api.github.com/repos/decidim/decidim/branches{/branch}","tags_url":"https://api.github.com/repos/decidim/decidim/tags","blobs_url":"https://api.github.com/repos/decidim/decidim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decidim/decidim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decidim/decidim/git/refs{/sha}","trees_url":"https://api.github.com/repos/decidim/decidim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/{sha}","languages_url":"https://api.github.com/repos/decidim/decidim/languages","stargazers_url":"https://api.github.com/repos/decidim/decidim/stargazers","contributors_url":"https://api.github.com/repos/decidim/decidim/contributors","subscribers_url":"https://api.github.com/repos/decidim/decidim/subscribers","subscription_url":"https://api.github.com/repos/decidim/decidim/subscription","commits_url":"https://api.github.com/repos/decidim/decidim/commits{/sha}","git_commits_url":"https://api.github.com/repos/decidim/decidim/git/commits{/sha}","comments_url":"https://api.github.com/repos/decidim/decidim/comments{/number}","issue_comment_url":"https://api.github.com/repos/decidim/decidim/issues/comments{/number}","contents_url":"https://api.github.com/repos/decidim/decidim/contents/{+path}","compare_url":"https://api.github.com/repos/decidim/decidim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decidim/decidim/merges","archive_url":"https://api.github.com/repos/decidim/decidim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decidim/decidim/downloads","issues_url":"https://api.github.com/repos/decidim/decidim/issues{/number}","pulls_url":"https://api.github.com/repos/decidim/decidim/pulls{/number}","milestones_url":"https://api.github.com/repos/decidim/decidim/milestones{/number}","notifications_url":"https://api.github.com/repos/decidim/decidim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decidim/decidim/labels{/name}","releases_url":"https://api.github.com/repos/decidim/decidim/releases{/id}","deployments_url":"https://api.github.com/repos/decidim/decidim/deployments","created_at":"2016-08-17T14:27:06Z","updated_at":"2018-11-23T14:25:17Z","pushed_at":"2018-11-23T15:37:24Z","git_url":"git://github.com/decidim/decidim.git","ssh_url":"git@github.com:decidim/decidim.git","clone_url":"https://github.com/decidim/decidim.git","svn_url":"https://github.com/decidim/decidim","homepage":"http://www.decidim.org","size":67945,"stargazers_count":276,"watchers_count":276,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":99,"open_issues":199,"watchers":276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decidim/decidim/pulls/3985"},"html":{"href":"https://github.com/decidim/decidim/pull/3985"},"issue":{"href":"https://api.github.com/repos/decidim/decidim/issues/3985"},"comments":{"href":"https://api.github.com/repos/decidim/decidim/issues/3985/comments"},"review_comments":{"href":"https://api.github.com/repos/decidim/decidim/pulls/3985/comments"},"review_comment":{"href":"https://api.github.com/repos/decidim/decidim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decidim/decidim/pulls/3985/commits"},"statuses":{"href":"https://api.github.com/repos/decidim/decidim/statuses/88a57b63b1c7ec69322c030f5cf4ee9f6680bc76"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"oriolgual"}}