{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments/236320063","pull_request_review_id":178371428,"id":236320063,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjMyMDA2Mw==","diff_hunk":"@@ -145,13 +151,17 @@ class Elasticsearch53SpringTemplateTest extends AgentTestRunner {\n     template.queryForList(query, Doc) == [new Doc()]\n \n     and:\n+    // FIXME: it looks like proper approach is to provide TEST_WRITER with an API to filter traces as they are written\n+    TEST_WRITER.waitForTraces(7)\n+    filterIgnoredActions() == null","path":"dd-java-agent/instrumentation/elasticsearch-transport-5.3/src/test/groovy/springdata/Elasticsearch53SpringTemplateTest.groovy","position":26,"original_position":26,"commit_id":"23203fb6593e41a4ad654c8e62f15c6d4ea31051","original_commit_id":"23203fb6593e41a4ad654c8e62f15c6d4ea31051","user":{"login":"tylerbenson","id":734411,"node_id":"MDQ6VXNlcjczNDQxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/734411?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerbenson","html_url":"https://github.com/tylerbenson","followers_url":"https://api.github.com/users/tylerbenson/followers","following_url":"https://api.github.com/users/tylerbenson/following{/other_user}","gists_url":"https://api.github.com/users/tylerbenson/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerbenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerbenson/subscriptions","organizations_url":"https://api.github.com/users/tylerbenson/orgs","repos_url":"https://api.github.com/users/tylerbenson/repos","events_url":"https://api.github.com/users/tylerbenson/events{/privacy}","received_events_url":"https://api.github.com/users/tylerbenson/received_events","type":"User","site_admin":false},"body":"if you change the method to return `void`, you won't have to assert `== null`","created_at":"2018-11-26T16:14:55Z","updated_at":"2018-11-26T16:15:41Z","html_url":"https://github.com/DataDog/dd-trace-java/pull/594#discussion_r236320063","pull_request_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/594","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments/236320063"},"html":{"href":"https://github.com/DataDog/dd-trace-java/pull/594#discussion_r236320063"},"pull_request":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/594"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/594","id":233093719,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDkzNzE5","html_url":"https://github.com/DataDog/dd-trace-java/pull/594","diff_url":"https://github.com/DataDog/dd-trace-java/pull/594.diff","patch_url":"https://github.com/DataDog/dd-trace-java/pull/594.patch","issue_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/594","number":594,"state":"open","locked":false,"title":"Improve stability of ES tests by avoiding unpredictable spans","user":{"login":"mar-kolya","id":1003102,"node_id":"MDQ6VXNlcjEwMDMxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1003102?v=4","gravatar_id":"","url":"https://api.github.com/users/mar-kolya","html_url":"https://github.com/mar-kolya","followers_url":"https://api.github.com/users/mar-kolya/followers","following_url":"https://api.github.com/users/mar-kolya/following{/other_user}","gists_url":"https://api.github.com/users/mar-kolya/gists{/gist_id}","starred_url":"https://api.github.com/users/mar-kolya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mar-kolya/subscriptions","organizations_url":"https://api.github.com/users/mar-kolya/orgs","repos_url":"https://api.github.com/users/mar-kolya/repos","events_url":"https://api.github.com/users/mar-kolya/events{/privacy}","received_events_url":"https://api.github.com/users/mar-kolya/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-23T01:59:09Z","updated_at":"2018-11-26T16:15:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e140923904ea5f58fff5c0052dec43f5c6476c5f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/594/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/594/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/594/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/23203fb6593e41a4ad654c8e62f15c6d4ea31051","head":{"label":"DataDog:mar-kolya/es-tests-stability","ref":"mar-kolya/es-tests-stability","sha":"23203fb6593e41a4ad654c8e62f15c6d4ea31051","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":89221572,"node_id":"MDEwOlJlcG9zaXRvcnk4OTIyMTU3Mg==","name":"dd-trace-java","full_name":"DataDog/dd-trace-java","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/dd-trace-java","description":"Datadog APM client for Java","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-java","forks_url":"https://api.github.com/repos/DataDog/dd-trace-java/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-java/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-java/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-java/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-java/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-java/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-java/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-java/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-java/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-java/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-java/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-java/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-java/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-java/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-java/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-java/deployments","created_at":"2017-04-24T09:24:40Z","updated_at":"2018-11-21T21:56:42Z","pushed_at":"2018-11-24T04:22:24Z","git_url":"git://github.com/DataDog/dd-trace-java.git","ssh_url":"git@github.com:DataDog/dd-trace-java.git","clone_url":"https://github.com/DataDog/dd-trace-java.git","svn_url":"https://github.com/DataDog/dd-trace-java","homepage":"https://docs.datadoghq.com/tracing/languages/java","size":123359,"stargazers_count":60,"watchers_count":60,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":25,"watchers":60,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"e7f4385b0adf6bee8bb9b9aed33dd570fb8a997f","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":89221572,"node_id":"MDEwOlJlcG9zaXRvcnk4OTIyMTU3Mg==","name":"dd-trace-java","full_name":"DataDog/dd-trace-java","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/dd-trace-java","description":"Datadog APM client for Java","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-java","forks_url":"https://api.github.com/repos/DataDog/dd-trace-java/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-java/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-java/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-java/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-java/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-java/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-java/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-java/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-java/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-java/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-java/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-java/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-java/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-java/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-java/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-java/deployments","created_at":"2017-04-24T09:24:40Z","updated_at":"2018-11-21T21:56:42Z","pushed_at":"2018-11-24T04:22:24Z","git_url":"git://github.com/DataDog/dd-trace-java.git","ssh_url":"git@github.com:DataDog/dd-trace-java.git","clone_url":"https://github.com/DataDog/dd-trace-java.git","svn_url":"https://github.com/DataDog/dd-trace-java","homepage":"https://docs.datadoghq.com/tracing/languages/java","size":123359,"stargazers_count":60,"watchers_count":60,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":25,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/594"},"html":{"href":"https://github.com/DataDog/dd-trace-java/pull/594"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/issues/594"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/23203fb6593e41a4ad654c8e62f15c6d4ea31051"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tylerbenson"}}