{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/github/query-selector/pulls/3","id":219906833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTA2ODMz","html_url":"https://github.com/github/query-selector/pull/3","diff_url":"https://github.com/github/query-selector/pull/3.diff","patch_url":"https://github.com/github/query-selector/pull/3.patch","issue_url":"https://api.github.com/repos/github/query-selector/issues/3","number":3,"state":"open","locked":false,"title":"Add a typescript definition file","user":{"login":"xt0rted","id":831974,"node_id":"MDQ6VXNlcjgzMTk3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/831974?v=4","gravatar_id":"","url":"https://api.github.com/users/xt0rted","html_url":"https://github.com/xt0rted","followers_url":"https://api.github.com/users/xt0rted/followers","following_url":"https://api.github.com/users/xt0rted/following{/other_user}","gists_url":"https://api.github.com/users/xt0rted/gists{/gist_id}","starred_url":"https://api.github.com/users/xt0rted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xt0rted/subscriptions","organizations_url":"https://api.github.com/users/xt0rted/orgs","repos_url":"https://api.github.com/users/xt0rted/repos","events_url":"https://api.github.com/users/xt0rted/events{/privacy}","received_events_url":"https://api.github.com/users/xt0rted/received_events","type":"User","site_admin":false},"body":"There's a `test.ts`, though no runner, to verify the typings work as expected. Do you want me to setup a task and run this through Typescript for verification? I'm using VS Code which does this for me, but it'd probably be nice to have as a task so CI can run it too.\r\n\r\nThe `lib.dom.d.ts` provided with Typescript has `HTMLElement` and friends not defined as classes for some reason. This prevents us from using `T` as a parameter constraint on `klass` right now which is why it's set to `any` 😕\r\n\r\nThe npm scripts don't work on Windows, but I was able to get it working in bash on WSL thanks to https://gist.github.com/micahgodbolt/8b9a338c8bab7bc147975646ea20826c. The test script fails, but the build one works and produces the correct `/dist` folder.\r\n\r\nCloses #1 ","created_at":"2018-10-03T03:44:27Z","updated_at":"2018-10-03T03:44:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/github/query-selector/pulls/3/commits","review_comments_url":"https://api.github.com/repos/github/query-selector/pulls/3/comments","review_comment_url":"https://api.github.com/repos/github/query-selector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/github/query-selector/issues/3/comments","statuses_url":"https://api.github.com/repos/github/query-selector/statuses/1402f7048ecf6fcdee686a5b3961efed811b0978","head":{"label":"xt0rted:typescript-definition","ref":"typescript-definition","sha":"1402f7048ecf6fcdee686a5b3961efed811b0978","user":{"login":"xt0rted","id":831974,"node_id":"MDQ6VXNlcjgzMTk3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/831974?v=4","gravatar_id":"","url":"https://api.github.com/users/xt0rted","html_url":"https://github.com/xt0rted","followers_url":"https://api.github.com/users/xt0rted/followers","following_url":"https://api.github.com/users/xt0rted/following{/other_user}","gists_url":"https://api.github.com/users/xt0rted/gists{/gist_id}","starred_url":"https://api.github.com/users/xt0rted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xt0rted/subscriptions","organizations_url":"https://api.github.com/users/xt0rted/orgs","repos_url":"https://api.github.com/users/xt0rted/repos","events_url":"https://api.github.com/users/xt0rted/events{/privacy}","received_events_url":"https://api.github.com/users/xt0rted/received_events","type":"User","site_admin":false},"repo":{"id":151343922,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEzNDM5MjI=","name":"query-selector","full_name":"xt0rted/query-selector","private":false,"owner":{"login":"xt0rted","id":831974,"node_id":"MDQ6VXNlcjgzMTk3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/831974?v=4","gravatar_id":"","url":"https://api.github.com/users/xt0rted","html_url":"https://github.com/xt0rted","followers_url":"https://api.github.com/users/xt0rted/followers","following_url":"https://api.github.com/users/xt0rted/following{/other_user}","gists_url":"https://api.github.com/users/xt0rted/gists{/gist_id}","starred_url":"https://api.github.com/users/xt0rted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xt0rted/subscriptions","organizations_url":"https://api.github.com/users/xt0rted/orgs","repos_url":"https://api.github.com/users/xt0rted/repos","events_url":"https://api.github.com/users/xt0rted/events{/privacy}","received_events_url":"https://api.github.com/users/xt0rted/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xt0rted/query-selector","description":"Query the document tree by selector, filtering by element type.","fork":true,"url":"https://api.github.com/repos/xt0rted/query-selector","forks_url":"https://api.github.com/repos/xt0rted/query-selector/forks","keys_url":"https://api.github.com/repos/xt0rted/query-selector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xt0rted/query-selector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xt0rted/query-selector/teams","hooks_url":"https://api.github.com/repos/xt0rted/query-selector/hooks","issue_events_url":"https://api.github.com/repos/xt0rted/query-selector/issues/events{/number}","events_url":"https://api.github.com/repos/xt0rted/query-selector/events","assignees_url":"https://api.github.com/repos/xt0rted/query-selector/assignees{/user}","branches_url":"https://api.github.com/repos/xt0rted/query-selector/branches{/branch}","tags_url":"https://api.github.com/repos/xt0rted/query-selector/tags","blobs_url":"https://api.github.com/repos/xt0rted/query-selector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xt0rted/query-selector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xt0rted/query-selector/git/refs{/sha}","trees_url":"https://api.github.com/repos/xt0rted/query-selector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xt0rted/query-selector/statuses/{sha}","languages_url":"https://api.github.com/repos/xt0rted/query-selector/languages","stargazers_url":"https://api.github.com/repos/xt0rted/query-selector/stargazers","contributors_url":"https://api.github.com/repos/xt0rted/query-selector/contributors","subscribers_url":"https://api.github.com/repos/xt0rted/query-selector/subscribers","subscription_url":"https://api.github.com/repos/xt0rted/query-selector/subscription","commits_url":"https://api.github.com/repos/xt0rted/query-selector/commits{/sha}","git_commits_url":"https://api.github.com/repos/xt0rted/query-selector/git/commits{/sha}","comments_url":"https://api.github.com/repos/xt0rted/query-selector/comments{/number}","issue_comment_url":"https://api.github.com/repos/xt0rted/query-selector/issues/comments{/number}","contents_url":"https://api.github.com/repos/xt0rted/query-selector/contents/{+path}","compare_url":"https://api.github.com/repos/xt0rted/query-selector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xt0rted/query-selector/merges","archive_url":"https://api.github.com/repos/xt0rted/query-selector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xt0rted/query-selector/downloads","issues_url":"https://api.github.com/repos/xt0rted/query-selector/issues{/number}","pulls_url":"https://api.github.com/repos/xt0rted/query-selector/pulls{/number}","milestones_url":"https://api.github.com/repos/xt0rted/query-selector/milestones{/number}","notifications_url":"https://api.github.com/repos/xt0rted/query-selector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xt0rted/query-selector/labels{/name}","releases_url":"https://api.github.com/repos/xt0rted/query-selector/releases{/id}","deployments_url":"https://api.github.com/repos/xt0rted/query-selector/deployments","created_at":"2018-10-03T01:00:33Z","updated_at":"2018-10-03T01:00:35Z","pushed_at":"2018-10-03T03:00:33Z","git_url":"git://github.com/xt0rted/query-selector.git","ssh_url":"git@github.com:xt0rted/query-selector.git","clone_url":"https://github.com/xt0rted/query-selector.git","svn_url":"https://github.com/xt0rted/query-selector","homepage":"","size":122,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"1a304bd4f149ae597abe10e1af8e7770b15ec7d8","user":{"login":"github","id":9919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":148833346,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg4MzMzNDY=","name":"query-selector","full_name":"github/query-selector","private":false,"owner":{"login":"github","id":9919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/github/query-selector","description":"Query the document tree by selector, filtering by element type.","fork":false,"url":"https://api.github.com/repos/github/query-selector","forks_url":"https://api.github.com/repos/github/query-selector/forks","keys_url":"https://api.github.com/repos/github/query-selector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/query-selector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/query-selector/teams","hooks_url":"https://api.github.com/repos/github/query-selector/hooks","issue_events_url":"https://api.github.com/repos/github/query-selector/issues/events{/number}","events_url":"https://api.github.com/repos/github/query-selector/events","assignees_url":"https://api.github.com/repos/github/query-selector/assignees{/user}","branches_url":"https://api.github.com/repos/github/query-selector/branches{/branch}","tags_url":"https://api.github.com/repos/github/query-selector/tags","blobs_url":"https://api.github.com/repos/github/query-selector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/query-selector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/query-selector/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/query-selector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/query-selector/statuses/{sha}","languages_url":"https://api.github.com/repos/github/query-selector/languages","stargazers_url":"https://api.github.com/repos/github/query-selector/stargazers","contributors_url":"https://api.github.com/repos/github/query-selector/contributors","subscribers_url":"https://api.github.com/repos/github/query-selector/subscribers","subscription_url":"https://api.github.com/repos/github/query-selector/subscription","commits_url":"https://api.github.com/repos/github/query-selector/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/query-selector/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/query-selector/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/query-selector/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/query-selector/contents/{+path}","compare_url":"https://api.github.com/repos/github/query-selector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/query-selector/merges","archive_url":"https://api.github.com/repos/github/query-selector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/query-selector/downloads","issues_url":"https://api.github.com/repos/github/query-selector/issues{/number}","pulls_url":"https://api.github.com/repos/github/query-selector/pulls{/number}","milestones_url":"https://api.github.com/repos/github/query-selector/milestones{/number}","notifications_url":"https://api.github.com/repos/github/query-selector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/query-selector/labels{/name}","releases_url":"https://api.github.com/repos/github/query-selector/releases{/id}","deployments_url":"https://api.github.com/repos/github/query-selector/deployments","created_at":"2018-09-14T19:31:16Z","updated_at":"2018-10-02T23:43:00Z","pushed_at":"2018-10-02T23:43:03Z","git_url":"git://github.com/github/query-selector.git","ssh_url":"git@github.com:github/query-selector.git","clone_url":"https://github.com/github/query-selector.git","svn_url":"https://github.com/github/query-selector","homepage":"","size":120,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":2,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/query-selector/pulls/3"},"html":{"href":"https://github.com/github/query-selector/pull/3"},"issue":{"href":"https://api.github.com/repos/github/query-selector/issues/3"},"comments":{"href":"https://api.github.com/repos/github/query-selector/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/github/query-selector/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/github/query-selector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/github/query-selector/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/github/query-selector/statuses/1402f7048ecf6fcdee686a5b3961efed811b0978"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":39,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"xt0rted"}}