{"action":"created","comment":{"url":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/comments/182734480","pull_request_review_id":113590542,"id":182734480,"diff_hunk":"@@ -4,9 +4,33 @@ import (\n \t\"encoding/json\"\n \t\"errors\"\n \t\"github.com/qa-dev/jsonwire-grid/config\"\n+\t\"time\"\n+\t\"fmt\"\n )\n \n type strategyParams struct {\n+\tNamespace string\n+\tPodCreationTimeout time.Duration\n+}\n+\n+func (sp *strategyParams) UnmarshalJSON(b []byte) error {","path":"pool/strategy/kubernetes/config.go","position":13,"original_position":13,"commit_id":"82512d1f52daf962e84d3a596330d6b71a1502aa","original_commit_id":"82512d1f52daf962e84d3a596330d6b71a1502aa","user":{"login":"podtserkovskiy","id":12721466,"avatar_url":"https://avatars1.githubusercontent.com/u/12721466?v=4","gravatar_id":"","url":"https://api.github.com/users/podtserkovskiy","html_url":"https://github.com/podtserkovskiy","followers_url":"https://api.github.com/users/podtserkovskiy/followers","following_url":"https://api.github.com/users/podtserkovskiy/following{/other_user}","gists_url":"https://api.github.com/users/podtserkovskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/podtserkovskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/podtserkovskiy/subscriptions","organizations_url":"https://api.github.com/users/podtserkovskiy/orgs","repos_url":"https://api.github.com/users/podtserkovskiy/repos","events_url":"https://api.github.com/users/podtserkovskiy/events{/privacy}","received_events_url":"https://api.github.com/users/podtserkovskiy/received_events","type":"User","site_admin":false},"body":"нужно координально все связанное с конфигами переделать, пока предлагаю оставить так как временное решение и вернуться к этому позже","created_at":"2018-04-19T12:53:29Z","updated_at":"2018-04-19T12:53:29Z","html_url":"https://github.com/qa-dev/jsonwire-grid/pull/25#discussion_r182734480","pull_request_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/25","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/comments/182734480"},"html":{"href":"https://github.com/qa-dev/jsonwire-grid/pull/25#discussion_r182734480"},"pull_request":{"href":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/25"}},"in_reply_to_id":182476613},"pull_request":{"url":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/25","id":182505757,"html_url":"https://github.com/qa-dev/jsonwire-grid/pull/25","diff_url":"https://github.com/qa-dev/jsonwire-grid/pull/25.diff","patch_url":"https://github.com/qa-dev/jsonwire-grid/pull/25.patch","issue_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/issues/25","number":25,"state":"open","locked":false,"title":"Qa 7710","user":{"login":"podtserkovskiy","id":12721466,"avatar_url":"https://avatars1.githubusercontent.com/u/12721466?v=4","gravatar_id":"","url":"https://api.github.com/users/podtserkovskiy","html_url":"https://github.com/podtserkovskiy","followers_url":"https://api.github.com/users/podtserkovskiy/followers","following_url":"https://api.github.com/users/podtserkovskiy/following{/other_user}","gists_url":"https://api.github.com/users/podtserkovskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/podtserkovskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/podtserkovskiy/subscriptions","organizations_url":"https://api.github.com/users/podtserkovskiy/orgs","repos_url":"https://api.github.com/users/podtserkovskiy/repos","events_url":"https://api.github.com/users/podtserkovskiy/events{/privacy}","received_events_url":"https://api.github.com/users/podtserkovskiy/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-18T14:51:11Z","updated_at":"2018-04-19T12:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30ebef5b6eb80004f58e740574f88585b4c308b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/25/commits","review_comments_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/25/comments","review_comment_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/issues/25/comments","statuses_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/statuses/82512d1f52daf962e84d3a596330d6b71a1502aa","head":{"label":"qa-dev:QA-7710","ref":"QA-7710","sha":"82512d1f52daf962e84d3a596330d6b71a1502aa","user":{"login":"qa-dev","id":22196516,"avatar_url":"https://avatars2.githubusercontent.com/u/22196516?v=4","gravatar_id":"","url":"https://api.github.com/users/qa-dev","html_url":"https://github.com/qa-dev","followers_url":"https://api.github.com/users/qa-dev/followers","following_url":"https://api.github.com/users/qa-dev/following{/other_user}","gists_url":"https://api.github.com/users/qa-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/qa-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qa-dev/subscriptions","organizations_url":"https://api.github.com/users/qa-dev/orgs","repos_url":"https://api.github.com/users/qa-dev/repos","events_url":"https://api.github.com/users/qa-dev/events{/privacy}","received_events_url":"https://api.github.com/users/qa-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":93180674,"name":"jsonwire-grid","full_name":"qa-dev/jsonwire-grid","owner":{"login":"qa-dev","id":22196516,"avatar_url":"https://avatars2.githubusercontent.com/u/22196516?v=4","gravatar_id":"","url":"https://api.github.com/users/qa-dev","html_url":"https://github.com/qa-dev","followers_url":"https://api.github.com/users/qa-dev/followers","following_url":"https://api.github.com/users/qa-dev/following{/other_user}","gists_url":"https://api.github.com/users/qa-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/qa-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qa-dev/subscriptions","organizations_url":"https://api.github.com/users/qa-dev/orgs","repos_url":"https://api.github.com/users/qa-dev/repos","events_url":"https://api.github.com/users/qa-dev/events{/privacy}","received_events_url":"https://api.github.com/users/qa-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qa-dev/jsonwire-grid","description":"High-performance scalable implementation of Selenium Grid","fork":false,"url":"https://api.github.com/repos/qa-dev/jsonwire-grid","forks_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/forks","keys_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/teams","hooks_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/hooks","issue_events_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/issues/events{/number}","events_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/events","assignees_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/assignees{/user}","branches_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/branches{/branch}","tags_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/tags","blobs_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/languages","stargazers_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/stargazers","contributors_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/contributors","subscribers_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/subscribers","subscription_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/subscription","commits_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/contents/{+path}","compare_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/merges","archive_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/downloads","issues_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/issues{/number}","pulls_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/labels{/name}","releases_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/releases{/id}","deployments_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/deployments","created_at":"2017-06-02T15:44:57Z","updated_at":"2018-04-09T12:35:34Z","pushed_at":"2018-04-18T14:51:11Z","git_url":"git://github.com/qa-dev/jsonwire-grid.git","ssh_url":"git@github.com:qa-dev/jsonwire-grid.git","clone_url":"https://github.com/qa-dev/jsonwire-grid.git","svn_url":"https://github.com/qa-dev/jsonwire-grid","homepage":"","size":4487,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":3,"watchers":34,"default_branch":"master"}},"base":{"label":"qa-dev:master","ref":"master","sha":"9962a1084e5968624d01aecc054cfadc8d7f50eb","user":{"login":"qa-dev","id":22196516,"avatar_url":"https://avatars2.githubusercontent.com/u/22196516?v=4","gravatar_id":"","url":"https://api.github.com/users/qa-dev","html_url":"https://github.com/qa-dev","followers_url":"https://api.github.com/users/qa-dev/followers","following_url":"https://api.github.com/users/qa-dev/following{/other_user}","gists_url":"https://api.github.com/users/qa-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/qa-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qa-dev/subscriptions","organizations_url":"https://api.github.com/users/qa-dev/orgs","repos_url":"https://api.github.com/users/qa-dev/repos","events_url":"https://api.github.com/users/qa-dev/events{/privacy}","received_events_url":"https://api.github.com/users/qa-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":93180674,"name":"jsonwire-grid","full_name":"qa-dev/jsonwire-grid","owner":{"login":"qa-dev","id":22196516,"avatar_url":"https://avatars2.githubusercontent.com/u/22196516?v=4","gravatar_id":"","url":"https://api.github.com/users/qa-dev","html_url":"https://github.com/qa-dev","followers_url":"https://api.github.com/users/qa-dev/followers","following_url":"https://api.github.com/users/qa-dev/following{/other_user}","gists_url":"https://api.github.com/users/qa-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/qa-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qa-dev/subscriptions","organizations_url":"https://api.github.com/users/qa-dev/orgs","repos_url":"https://api.github.com/users/qa-dev/repos","events_url":"https://api.github.com/users/qa-dev/events{/privacy}","received_events_url":"https://api.github.com/users/qa-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qa-dev/jsonwire-grid","description":"High-performance scalable implementation of Selenium Grid","fork":false,"url":"https://api.github.com/repos/qa-dev/jsonwire-grid","forks_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/forks","keys_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/teams","hooks_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/hooks","issue_events_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/issues/events{/number}","events_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/events","assignees_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/assignees{/user}","branches_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/branches{/branch}","tags_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/tags","blobs_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/languages","stargazers_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/stargazers","contributors_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/contributors","subscribers_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/subscribers","subscription_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/subscription","commits_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/contents/{+path}","compare_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/merges","archive_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/downloads","issues_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/issues{/number}","pulls_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/labels{/name}","releases_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/releases{/id}","deployments_url":"https://api.github.com/repos/qa-dev/jsonwire-grid/deployments","created_at":"2017-06-02T15:44:57Z","updated_at":"2018-04-09T12:35:34Z","pushed_at":"2018-04-18T14:51:11Z","git_url":"git://github.com/qa-dev/jsonwire-grid.git","ssh_url":"git@github.com:qa-dev/jsonwire-grid.git","clone_url":"https://github.com/qa-dev/jsonwire-grid.git","svn_url":"https://github.com/qa-dev/jsonwire-grid","homepage":"","size":4487,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":3,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/25"},"html":{"href":"https://github.com/qa-dev/jsonwire-grid/pull/25"},"issue":{"href":"https://api.github.com/repos/qa-dev/jsonwire-grid/issues/25"},"comments":{"href":"https://api.github.com/repos/qa-dev/jsonwire-grid/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qa-dev/jsonwire-grid/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/qa-dev/jsonwire-grid/statuses/82512d1f52daf962e84d3a596330d6b71a1502aa"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"podtserkovskiy"}}