{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/buildroot/pulls/comments/216481486","pull_request_review_id":153973702,"id":216481486,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ4MTQ4Ng==","diff_hunk":"@@ -812,16 +813,23 @@ if (is_win) {\n \n # Default \"optimization on\" config. On Windows, this favors size over speed.\n config(\"optimize\") {\n+  lto_flags = []\n   if (is_win) {\n     # Favor size over speed, /O1 must be before the common flags. The GYP\n     # build also specifies /Os and /GF but these are implied by /O1.\n     cflags = [ \"/O1\" ] + common_optimize_on_cflags + [ \"/Oi\" ]\n-  } else if (is_android || is_ios) {\n+  } else if (is_ios) {\n     cflags = [ \"-Os\" ] + common_optimize_on_cflags  # Favor size over speed.","path":"build/config/compiler/BUILD.gn","position":28,"original_position":28,"commit_id":"af2db3b6434ee71aa974cdb486977839ad19d448","original_commit_id":"af2db3b6434ee71aa974cdb486977839ad19d448","user":{"login":"goderbauer","id":1227763,"node_id":"MDQ6VXNlcjEyMjc3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"body":"Thanks for the explanation!","created_at":"2018-09-10T21:37:48Z","updated_at":"2018-09-10T21:37:48Z","html_url":"https://github.com/flutter/buildroot/pull/165#discussion_r216481486","pull_request_url":"https://api.github.com/repos/flutter/buildroot/pulls/165","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/flutter/buildroot/pulls/comments/216481486"},"html":{"href":"https://github.com/flutter/buildroot/pull/165#discussion_r216481486"},"pull_request":{"href":"https://api.github.com/repos/flutter/buildroot/pulls/165"}},"in_reply_to_id":216283527},"pull_request":{"url":"https://api.github.com/repos/flutter/buildroot/pulls/165","id":214278524,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0Mjc4NTI0","html_url":"https://github.com/flutter/buildroot/pull/165","diff_url":"https://github.com/flutter/buildroot/pull/165.diff","patch_url":"https://github.com/flutter/buildroot/pull/165.patch","issue_url":"https://api.github.com/repos/flutter/buildroot/issues/165","number":165,"state":"open","locked":false,"title":"Enable LTO for Android","user":{"login":"goderbauer","id":1227763,"node_id":"MDQ6VXNlcjEyMjc3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"body":"Size reductions of libflutter.so:\r\n* uncompressed: -412KB (from 6MB to 5.6MB)\r\n* compressed: -243KB (from 3.3MB to 3MB)\r\n\r\nFixes https://github.com/flutter/flutter/issues/16538.","created_at":"2018-09-10T11:14:24Z","updated_at":"2018-09-10T21:37:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"769704d9ca2333a7e49f3e725a339d1aca69d6f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/buildroot/pulls/165/commits","review_comments_url":"https://api.github.com/repos/flutter/buildroot/pulls/165/comments","review_comment_url":"https://api.github.com/repos/flutter/buildroot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/buildroot/issues/165/comments","statuses_url":"https://api.github.com/repos/flutter/buildroot/statuses/af2db3b6434ee71aa974cdb486977839ad19d448","head":{"label":"goderbauer:lto-flags","ref":"lto-flags","sha":"af2db3b6434ee71aa974cdb486977839ad19d448","user":{"login":"goderbauer","id":1227763,"node_id":"MDQ6VXNlcjEyMjc3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"repo":{"id":79601659,"node_id":"MDEwOlJlcG9zaXRvcnk3OTYwMTY1OQ==","name":"buildroot","full_name":"goderbauer/buildroot","owner":{"login":"goderbauer","id":1227763,"node_id":"MDQ6VXNlcjEyMjc3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goderbauer/buildroot","description":"Build environment for the Flutter engine","fork":true,"url":"https://api.github.com/repos/goderbauer/buildroot","forks_url":"https://api.github.com/repos/goderbauer/buildroot/forks","keys_url":"https://api.github.com/repos/goderbauer/buildroot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goderbauer/buildroot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goderbauer/buildroot/teams","hooks_url":"https://api.github.com/repos/goderbauer/buildroot/hooks","issue_events_url":"https://api.github.com/repos/goderbauer/buildroot/issues/events{/number}","events_url":"https://api.github.com/repos/goderbauer/buildroot/events","assignees_url":"https://api.github.com/repos/goderbauer/buildroot/assignees{/user}","branches_url":"https://api.github.com/repos/goderbauer/buildroot/branches{/branch}","tags_url":"https://api.github.com/repos/goderbauer/buildroot/tags","blobs_url":"https://api.github.com/repos/goderbauer/buildroot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goderbauer/buildroot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goderbauer/buildroot/git/refs{/sha}","trees_url":"https://api.github.com/repos/goderbauer/buildroot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goderbauer/buildroot/statuses/{sha}","languages_url":"https://api.github.com/repos/goderbauer/buildroot/languages","stargazers_url":"https://api.github.com/repos/goderbauer/buildroot/stargazers","contributors_url":"https://api.github.com/repos/goderbauer/buildroot/contributors","subscribers_url":"https://api.github.com/repos/goderbauer/buildroot/subscribers","subscription_url":"https://api.github.com/repos/goderbauer/buildroot/subscription","commits_url":"https://api.github.com/repos/goderbauer/buildroot/commits{/sha}","git_commits_url":"https://api.github.com/repos/goderbauer/buildroot/git/commits{/sha}","comments_url":"https://api.github.com/repos/goderbauer/buildroot/comments{/number}","issue_comment_url":"https://api.github.com/repos/goderbauer/buildroot/issues/comments{/number}","contents_url":"https://api.github.com/repos/goderbauer/buildroot/contents/{+path}","compare_url":"https://api.github.com/repos/goderbauer/buildroot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goderbauer/buildroot/merges","archive_url":"https://api.github.com/repos/goderbauer/buildroot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goderbauer/buildroot/downloads","issues_url":"https://api.github.com/repos/goderbauer/buildroot/issues{/number}","pulls_url":"https://api.github.com/repos/goderbauer/buildroot/pulls{/number}","milestones_url":"https://api.github.com/repos/goderbauer/buildroot/milestones{/number}","notifications_url":"https://api.github.com/repos/goderbauer/buildroot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goderbauer/buildroot/labels{/name}","releases_url":"https://api.github.com/repos/goderbauer/buildroot/releases{/id}","deployments_url":"https://api.github.com/repos/goderbauer/buildroot/deployments","created_at":"2017-01-20T21:46:03Z","updated_at":"2017-01-20T21:46:08Z","pushed_at":"2018-09-10T11:05:23Z","git_url":"git://github.com/goderbauer/buildroot.git","ssh_url":"git@github.com:goderbauer/buildroot.git","clone_url":"https://github.com/goderbauer/buildroot.git","svn_url":"https://github.com/goderbauer/buildroot","homepage":null,"size":24146,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"be483cb1cd3a9c4313b2e534034d23a05c3d849e","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":65318350,"node_id":"MDEwOlJlcG9zaXRvcnk2NTMxODM1MA==","name":"buildroot","full_name":"flutter/buildroot","owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/buildroot","description":"Build environment for the Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/buildroot","forks_url":"https://api.github.com/repos/flutter/buildroot/forks","keys_url":"https://api.github.com/repos/flutter/buildroot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/buildroot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/buildroot/teams","hooks_url":"https://api.github.com/repos/flutter/buildroot/hooks","issue_events_url":"https://api.github.com/repos/flutter/buildroot/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/buildroot/events","assignees_url":"https://api.github.com/repos/flutter/buildroot/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/buildroot/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/buildroot/tags","blobs_url":"https://api.github.com/repos/flutter/buildroot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/buildroot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/buildroot/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/buildroot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/buildroot/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/buildroot/languages","stargazers_url":"https://api.github.com/repos/flutter/buildroot/stargazers","contributors_url":"https://api.github.com/repos/flutter/buildroot/contributors","subscribers_url":"https://api.github.com/repos/flutter/buildroot/subscribers","subscription_url":"https://api.github.com/repos/flutter/buildroot/subscription","commits_url":"https://api.github.com/repos/flutter/buildroot/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/buildroot/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/buildroot/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/buildroot/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/buildroot/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/buildroot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/buildroot/merges","archive_url":"https://api.github.com/repos/flutter/buildroot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/buildroot/downloads","issues_url":"https://api.github.com/repos/flutter/buildroot/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/buildroot/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/buildroot/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/buildroot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/buildroot/labels{/name}","releases_url":"https://api.github.com/repos/flutter/buildroot/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/buildroot/deployments","created_at":"2016-08-09T18:24:03Z","updated_at":"2018-09-06T22:09:04Z","pushed_at":"2018-09-10T11:14:25Z","git_url":"git://github.com/flutter/buildroot.git","ssh_url":"git@github.com:flutter/buildroot.git","clone_url":"https://github.com/flutter/buildroot.git","svn_url":"https://github.com/flutter/buildroot","homepage":null,"size":24141,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":36,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/buildroot/pulls/165"},"html":{"href":"https://github.com/flutter/buildroot/pull/165"},"issue":{"href":"https://api.github.com/repos/flutter/buildroot/issues/165"},"comments":{"href":"https://api.github.com/repos/flutter/buildroot/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/buildroot/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/buildroot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/buildroot/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/buildroot/statuses/af2db3b6434ee71aa974cdb486977839ad19d448"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"goderbauer"}}