{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12952","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12952/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12952/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12952/events","html_url":"https://github.com/bitcoin/bitcoin/issues/12952","id":313448027,"number":12952,"title":"Remove wallet 'account' API","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-11T19:00:28Z","updated_at":"2018-04-11T19:16:07Z","closed_at":null,"author_association":"MEMBER","body":"This issue tracks removing the wallet 'account' API. See issue #3816 for the reasons why this is a good idea. Rather than extend that very old and long issu, I'm opening this to track concrete actions to fully remove the 'account' API.\r\n\r\nActions are:\r\n\r\n- [x] Rename account to label where appropriate (#11536)\r\n- [x] Introduce 'label' API for wallet (~#7729~ #12892)\r\n- [ ] (V0.17) Mark 'account' API as deprecated. Wallet functional tests are updated to use `-deprecatedrpc=accounts` to maintain existing behaviour. (~#11497~ #12953)\r\n- [ ] Remove `getlabeladdress` RPC method. Keeping this method means we need to keep the `CAccount` internal accounting.\r\n- [ ] Migrate wallet functional tests to use the 'label' API.\r\n- [ ] (V0.18) Fully remove the 'account' API"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/380565167","html_url":"https://github.com/bitcoin/bitcoin/issues/12952#issuecomment-380565167","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12952","id":380565167,"user":{"login":"ryanofsky","id":7133040,"avatar_url":"https://avatars2.githubusercontent.com/u/7133040?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanofsky","html_url":"https://github.com/ryanofsky","followers_url":"https://api.github.com/users/ryanofsky/followers","following_url":"https://api.github.com/users/ryanofsky/following{/other_user}","gists_url":"https://api.github.com/users/ryanofsky/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanofsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanofsky/subscriptions","organizations_url":"https://api.github.com/users/ryanofsky/orgs","repos_url":"https://api.github.com/users/ryanofsky/repos","events_url":"https://api.github.com/users/ryanofsky/events{/privacy}","received_events_url":"https://api.github.com/users/ryanofsky/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T19:16:07Z","updated_at":"2018-04-11T19:16:07Z","author_association":"CONTRIBUTOR","body":"Sounds good, but `getlabeladdress` is a new method not included in any existing release (I added it in #11536), so I would suggest removing it before there is another release instead of adding and then deprecating it."}}
{"actor":{"display_login":"ryanofsky"}}