{"action":"created","comment":{"url":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/comments/195598237","pull_request_review_id":129001411,"id":195598237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTU5ODIzNw==","diff_hunk":"@@ -20,16 +20,14 @@\n     xmlns:tools=\"http://schemas.android.com/tools\">\n \n     <data>\n-\n         <variable\n-            name=\"vm\"\n-            type=\"com.google.samples.apps.sunflower.adapters.PlantAdapter.ItemViewModel\"/>\n+            name=\"plant\"\n+            type=\"com.google.samples.apps.sunflower.data.Plant\"/>","path":"app/src/main/res/layout/list_item_plant.xml","position":null,"original_position":9,"commit_id":"387a7b8ab4f4dc7655a6cf079bbac32343750b24","original_commit_id":"464bb90dcba01c794b7fc192040f597467556007","user":{"login":"tiembo","id":97128,"node_id":"MDQ6VXNlcjk3MTI4","avatar_url":"https://avatars2.githubusercontent.com/u/97128?v=4","gravatar_id":"","url":"https://api.github.com/users/tiembo","html_url":"https://github.com/tiembo","followers_url":"https://api.github.com/users/tiembo/followers","following_url":"https://api.github.com/users/tiembo/following{/other_user}","gists_url":"https://api.github.com/users/tiembo/gists{/gist_id}","starred_url":"https://api.github.com/users/tiembo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiembo/subscriptions","organizations_url":"https://api.github.com/users/tiembo/orgs","repos_url":"https://api.github.com/users/tiembo/repos","events_url":"https://api.github.com/users/tiembo/events{/privacy}","received_events_url":"https://api.github.com/users/tiembo/received_events","type":"User","site_admin":false},"body":"In the 2018 version of the Google I/O Android App we used this pattern for RecyclerView list items.  I think a ViewModel is a bit heavyweight for this use case.","created_at":"2018-06-14T23:15:08Z","updated_at":"2018-06-14T23:15:08Z","html_url":"https://github.com/googlesamples/android-sunflower/pull/45#discussion_r195598237","pull_request_url":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/45","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/comments/195598237"},"html":{"href":"https://github.com/googlesamples/android-sunflower/pull/45#discussion_r195598237"},"pull_request":{"href":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/45"}},"in_reply_to_id":195344207},"pull_request":{"url":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/45","id":194794191,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0Nzk0MTkx","html_url":"https://github.com/googlesamples/android-sunflower/pull/45","diff_url":"https://github.com/googlesamples/android-sunflower/pull/45.diff","patch_url":"https://github.com/googlesamples/android-sunflower/pull/45.patch","issue_url":"https://api.github.com/repos/googlesamples/android-sunflower/issues/45","number":45,"state":"open","locked":false,"title":"Slight refactor to Plant adapter and data binding","user":{"login":"tiembo","id":97128,"node_id":"MDQ6VXNlcjk3MTI4","avatar_url":"https://avatars2.githubusercontent.com/u/97128?v=4","gravatar_id":"","url":"https://api.github.com/users/tiembo","html_url":"https://github.com/tiembo","followers_url":"https://api.github.com/users/tiembo/followers","following_url":"https://api.github.com/users/tiembo/following{/other_user}","gists_url":"https://api.github.com/users/tiembo/gists{/gist_id}","starred_url":"https://api.github.com/users/tiembo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiembo/subscriptions","organizations_url":"https://api.github.com/users/tiembo/orgs","repos_url":"https://api.github.com/users/tiembo/repos","events_url":"https://api.github.com/users/tiembo/events{/privacy}","received_events_url":"https://api.github.com/users/tiembo/received_events","type":"User","site_admin":false},"body":"Set data binding variables in a `bind` method in the ViewHolder, following the guidance from the [Android Data Binding: RecyclerView article](https://medium.com/google-developers/android-data-binding-recyclerview-db7c40d9f0e4).\r\n\r\ncc @XinyueZ ","created_at":"2018-06-14T06:53:16Z","updated_at":"2018-06-14T23:15:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0263385a496a3402d7167693f7b682f0c0e5d585","assignee":null,"assignees":[],"requested_reviewers":[{"login":"thagikura","id":796361,"node_id":"MDQ6VXNlcjc5NjM2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/796361?v=4","gravatar_id":"","url":"https://api.github.com/users/thagikura","html_url":"https://github.com/thagikura","followers_url":"https://api.github.com/users/thagikura/followers","following_url":"https://api.github.com/users/thagikura/following{/other_user}","gists_url":"https://api.github.com/users/thagikura/gists{/gist_id}","starred_url":"https://api.github.com/users/thagikura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thagikura/subscriptions","organizations_url":"https://api.github.com/users/thagikura/orgs","repos_url":"https://api.github.com/users/thagikura/repos","events_url":"https://api.github.com/users/thagikura/events{/privacy}","received_events_url":"https://api.github.com/users/thagikura/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/googlesamples/android-sunflower/milestones/3","html_url":"https://github.com/googlesamples/android-sunflower/milestone/3","labels_url":"https://api.github.com/repos/googlesamples/android-sunflower/milestones/3/labels","id":3417908,"node_id":"MDk6TWlsZXN0b25lMzQxNzkwOA==","number":3,"title":"0.1.3","description":"","creator":{"login":"tiembo","id":97128,"node_id":"MDQ6VXNlcjk3MTI4","avatar_url":"https://avatars2.githubusercontent.com/u/97128?v=4","gravatar_id":"","url":"https://api.github.com/users/tiembo","html_url":"https://github.com/tiembo","followers_url":"https://api.github.com/users/tiembo/followers","following_url":"https://api.github.com/users/tiembo/following{/other_user}","gists_url":"https://api.github.com/users/tiembo/gists{/gist_id}","starred_url":"https://api.github.com/users/tiembo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiembo/subscriptions","organizations_url":"https://api.github.com/users/tiembo/orgs","repos_url":"https://api.github.com/users/tiembo/repos","events_url":"https://api.github.com/users/tiembo/events{/privacy}","received_events_url":"https://api.github.com/users/tiembo/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":2,"state":"open","created_at":"2018-06-12T06:09:10Z","updated_at":"2018-06-14T21:46:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/45/commits","review_comments_url":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/45/comments","review_comment_url":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlesamples/android-sunflower/issues/45/comments","statuses_url":"https://api.github.com/repos/googlesamples/android-sunflower/statuses/387a7b8ab4f4dc7655a6cf079bbac32343750b24","head":{"label":"tiembo:databinding","ref":"databinding","sha":"387a7b8ab4f4dc7655a6cf079bbac32343750b24","user":{"login":"tiembo","id":97128,"node_id":"MDQ6VXNlcjk3MTI4","avatar_url":"https://avatars2.githubusercontent.com/u/97128?v=4","gravatar_id":"","url":"https://api.github.com/users/tiembo","html_url":"https://github.com/tiembo","followers_url":"https://api.github.com/users/tiembo/followers","following_url":"https://api.github.com/users/tiembo/following{/other_user}","gists_url":"https://api.github.com/users/tiembo/gists{/gist_id}","starred_url":"https://api.github.com/users/tiembo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiembo/subscriptions","organizations_url":"https://api.github.com/users/tiembo/orgs","repos_url":"https://api.github.com/users/tiembo/repos","events_url":"https://api.github.com/users/tiembo/events{/privacy}","received_events_url":"https://api.github.com/users/tiembo/received_events","type":"User","site_admin":false},"repo":{"id":136359997,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzNTk5OTc=","name":"android-sunflower","full_name":"tiembo/android-sunflower","owner":{"login":"tiembo","id":97128,"node_id":"MDQ6VXNlcjk3MTI4","avatar_url":"https://avatars2.githubusercontent.com/u/97128?v=4","gravatar_id":"","url":"https://api.github.com/users/tiembo","html_url":"https://github.com/tiembo","followers_url":"https://api.github.com/users/tiembo/followers","following_url":"https://api.github.com/users/tiembo/following{/other_user}","gists_url":"https://api.github.com/users/tiembo/gists{/gist_id}","starred_url":"https://api.github.com/users/tiembo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiembo/subscriptions","organizations_url":"https://api.github.com/users/tiembo/orgs","repos_url":"https://api.github.com/users/tiembo/repos","events_url":"https://api.github.com/users/tiembo/events{/privacy}","received_events_url":"https://api.github.com/users/tiembo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiembo/android-sunflower","description":"A gardening app illustrating Android development best practices with Android Jetpack.","fork":true,"url":"https://api.github.com/repos/tiembo/android-sunflower","forks_url":"https://api.github.com/repos/tiembo/android-sunflower/forks","keys_url":"https://api.github.com/repos/tiembo/android-sunflower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiembo/android-sunflower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiembo/android-sunflower/teams","hooks_url":"https://api.github.com/repos/tiembo/android-sunflower/hooks","issue_events_url":"https://api.github.com/repos/tiembo/android-sunflower/issues/events{/number}","events_url":"https://api.github.com/repos/tiembo/android-sunflower/events","assignees_url":"https://api.github.com/repos/tiembo/android-sunflower/assignees{/user}","branches_url":"https://api.github.com/repos/tiembo/android-sunflower/branches{/branch}","tags_url":"https://api.github.com/repos/tiembo/android-sunflower/tags","blobs_url":"https://api.github.com/repos/tiembo/android-sunflower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiembo/android-sunflower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiembo/android-sunflower/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiembo/android-sunflower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiembo/android-sunflower/statuses/{sha}","languages_url":"https://api.github.com/repos/tiembo/android-sunflower/languages","stargazers_url":"https://api.github.com/repos/tiembo/android-sunflower/stargazers","contributors_url":"https://api.github.com/repos/tiembo/android-sunflower/contributors","subscribers_url":"https://api.github.com/repos/tiembo/android-sunflower/subscribers","subscription_url":"https://api.github.com/repos/tiembo/android-sunflower/subscription","commits_url":"https://api.github.com/repos/tiembo/android-sunflower/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiembo/android-sunflower/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiembo/android-sunflower/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiembo/android-sunflower/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiembo/android-sunflower/contents/{+path}","compare_url":"https://api.github.com/repos/tiembo/android-sunflower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiembo/android-sunflower/merges","archive_url":"https://api.github.com/repos/tiembo/android-sunflower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiembo/android-sunflower/downloads","issues_url":"https://api.github.com/repos/tiembo/android-sunflower/issues{/number}","pulls_url":"https://api.github.com/repos/tiembo/android-sunflower/pulls{/number}","milestones_url":"https://api.github.com/repos/tiembo/android-sunflower/milestones{/number}","notifications_url":"https://api.github.com/repos/tiembo/android-sunflower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiembo/android-sunflower/labels{/name}","releases_url":"https://api.github.com/repos/tiembo/android-sunflower/releases{/id}","deployments_url":"https://api.github.com/repos/tiembo/android-sunflower/deployments","created_at":"2018-06-06T17:00:17Z","updated_at":"2018-06-14T03:02:45Z","pushed_at":"2018-06-14T23:11:00Z","git_url":"git://github.com/tiembo/android-sunflower.git","ssh_url":"git@github.com:tiembo/android-sunflower.git","clone_url":"https://github.com/tiembo/android-sunflower.git","svn_url":"https://github.com/tiembo/android-sunflower","homepage":"https://developer.android.com/jetpack/","size":4892,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlesamples:master","ref":"master","sha":"5202bbd0d3ea2875757ff12fd57f37fe457b3117","user":{"login":"googlesamples","id":7378196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNzgxOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"repo":{"id":134505361,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1MDUzNjE=","name":"android-sunflower","full_name":"googlesamples/android-sunflower","owner":{"login":"googlesamples","id":7378196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNzgxOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlesamples/android-sunflower","description":"A gardening app illustrating Android development best practices with Android Jetpack.","fork":false,"url":"https://api.github.com/repos/googlesamples/android-sunflower","forks_url":"https://api.github.com/repos/googlesamples/android-sunflower/forks","keys_url":"https://api.github.com/repos/googlesamples/android-sunflower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlesamples/android-sunflower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlesamples/android-sunflower/teams","hooks_url":"https://api.github.com/repos/googlesamples/android-sunflower/hooks","issue_events_url":"https://api.github.com/repos/googlesamples/android-sunflower/issues/events{/number}","events_url":"https://api.github.com/repos/googlesamples/android-sunflower/events","assignees_url":"https://api.github.com/repos/googlesamples/android-sunflower/assignees{/user}","branches_url":"https://api.github.com/repos/googlesamples/android-sunflower/branches{/branch}","tags_url":"https://api.github.com/repos/googlesamples/android-sunflower/tags","blobs_url":"https://api.github.com/repos/googlesamples/android-sunflower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlesamples/android-sunflower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlesamples/android-sunflower/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlesamples/android-sunflower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlesamples/android-sunflower/statuses/{sha}","languages_url":"https://api.github.com/repos/googlesamples/android-sunflower/languages","stargazers_url":"https://api.github.com/repos/googlesamples/android-sunflower/stargazers","contributors_url":"https://api.github.com/repos/googlesamples/android-sunflower/contributors","subscribers_url":"https://api.github.com/repos/googlesamples/android-sunflower/subscribers","subscription_url":"https://api.github.com/repos/googlesamples/android-sunflower/subscription","commits_url":"https://api.github.com/repos/googlesamples/android-sunflower/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlesamples/android-sunflower/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlesamples/android-sunflower/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlesamples/android-sunflower/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlesamples/android-sunflower/contents/{+path}","compare_url":"https://api.github.com/repos/googlesamples/android-sunflower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlesamples/android-sunflower/merges","archive_url":"https://api.github.com/repos/googlesamples/android-sunflower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlesamples/android-sunflower/downloads","issues_url":"https://api.github.com/repos/googlesamples/android-sunflower/issues{/number}","pulls_url":"https://api.github.com/repos/googlesamples/android-sunflower/pulls{/number}","milestones_url":"https://api.github.com/repos/googlesamples/android-sunflower/milestones{/number}","notifications_url":"https://api.github.com/repos/googlesamples/android-sunflower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlesamples/android-sunflower/labels{/name}","releases_url":"https://api.github.com/repos/googlesamples/android-sunflower/releases{/id}","deployments_url":"https://api.github.com/repos/googlesamples/android-sunflower/deployments","created_at":"2018-05-23T03:02:28Z","updated_at":"2018-06-14T21:58:43Z","pushed_at":"2018-06-14T23:11:01Z","git_url":"git://github.com/googlesamples/android-sunflower.git","ssh_url":"git@github.com:googlesamples/android-sunflower.git","clone_url":"https://github.com/googlesamples/android-sunflower.git","svn_url":"https://github.com/googlesamples/android-sunflower","homepage":"https://developer.android.com/jetpack/","size":4889,"stargazers_count":1523,"watchers_count":1523,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":124,"open_issues":13,"watchers":1523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/45"},"html":{"href":"https://github.com/googlesamples/android-sunflower/pull/45"},"issue":{"href":"https://api.github.com/repos/googlesamples/android-sunflower/issues/45"},"comments":{"href":"https://api.github.com/repos/googlesamples/android-sunflower/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlesamples/android-sunflower/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/googlesamples/android-sunflower/statuses/387a7b8ab4f4dc7655a6cf079bbac32343750b24"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tiembo"}}