{"action":"created","issue":{"url":"https://api.github.com/repos/LLK/scratch-gui/issues/3725","repository_url":"https://api.github.com/repos/LLK/scratch-gui","labels_url":"https://api.github.com/repos/LLK/scratch-gui/issues/3725/labels{/name}","comments_url":"https://api.github.com/repos/LLK/scratch-gui/issues/3725/comments","events_url":"https://api.github.com/repos/LLK/scratch-gui/issues/3725/events","html_url":"https://github.com/LLK/scratch-gui/pull/3725","id":379899540,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjI3OTQ2","number":3725,"title":"Handle ?tutorial= query in gui","user":{"login":"chrisgarrity","id":399209,"node_id":"MDQ6VXNlcjM5OTIwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/399209?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisgarrity","html_url":"https://github.com/chrisgarrity","followers_url":"https://api.github.com/users/chrisgarrity/followers","following_url":"https://api.github.com/users/chrisgarrity/following{/other_user}","gists_url":"https://api.github.com/users/chrisgarrity/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgarrity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgarrity/subscriptions","organizations_url":"https://api.github.com/users/chrisgarrity/orgs","repos_url":"https://api.github.com/users/chrisgarrity/repos","events_url":"https://api.github.com/users/chrisgarrity/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgarrity/received_events","type":"User","site_admin":false},"labels":[{"id":929235872,"node_id":"MDU6TGFiZWw5MjkyMzU4NzI=","url":"https://api.github.com/repos/LLK/scratch-gui/labels/needs%20discussion","name":"needs discussion","color":"efefef","default":false},{"id":461144954,"node_id":"MDU6TGFiZWw0NjExNDQ5NTQ=","url":"https://api.github.com/repos/LLK/scratch-gui/labels/pr%20-%20needs%20review","name":"pr - needs review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"chrisgarrity","id":399209,"node_id":"MDQ6VXNlcjM5OTIwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/399209?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisgarrity","html_url":"https://github.com/chrisgarrity","followers_url":"https://api.github.com/users/chrisgarrity/followers","following_url":"https://api.github.com/users/chrisgarrity/following{/other_user}","gists_url":"https://api.github.com/users/chrisgarrity/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgarrity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgarrity/subscriptions","organizations_url":"https://api.github.com/users/chrisgarrity/orgs","repos_url":"https://api.github.com/users/chrisgarrity/repos","events_url":"https://api.github.com/users/chrisgarrity/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgarrity/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisgarrity","id":399209,"node_id":"MDQ6VXNlcjM5OTIwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/399209?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisgarrity","html_url":"https://github.com/chrisgarrity","followers_url":"https://api.github.com/users/chrisgarrity/followers","following_url":"https://api.github.com/users/chrisgarrity/following{/other_user}","gists_url":"https://api.github.com/users/chrisgarrity/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgarrity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgarrity/subscriptions","organizations_url":"https://api.github.com/users/chrisgarrity/orgs","repos_url":"https://api.github.com/users/chrisgarrity/repos","events_url":"https://api.github.com/users/chrisgarrity/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgarrity/received_events","type":"User","site_admin":false},{"login":"benjiwheeler","id":3431616,"node_id":"MDQ6VXNlcjM0MzE2MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3431616?v=4","gravatar_id":"","url":"https://api.github.com/users/benjiwheeler","html_url":"https://github.com/benjiwheeler","followers_url":"https://api.github.com/users/benjiwheeler/followers","following_url":"https://api.github.com/users/benjiwheeler/following{/other_user}","gists_url":"https://api.github.com/users/benjiwheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/benjiwheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjiwheeler/subscriptions","organizations_url":"https://api.github.com/users/benjiwheeler/orgs","repos_url":"https://api.github.com/users/benjiwheeler/repos","events_url":"https://api.github.com/users/benjiwheeler/events{/privacy}","received_events_url":"https://api.github.com/users/benjiwheeler/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/LLK/scratch-gui/milestones/33","html_url":"https://github.com/LLK/scratch-gui/milestone/33","labels_url":"https://api.github.com/repos/LLK/scratch-gui/milestones/33/labels","id":3605045,"node_id":"MDk6TWlsZXN0b25lMzYwNTA0NQ==","number":33,"title":"November 2018","description":"","creator":{"login":"thisandagain","id":747641,"node_id":"MDQ6VXNlcjc0NzY0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/747641?v=4","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":69,"state":"open","created_at":"2018-08-28T19:58:52Z","updated_at":"2018-11-14T15:32:53Z","due_on":"2018-11-30T08:00:00Z","closed_at":null},"comments":3,"created_at":"2018-11-12T18:26:21Z","updated_at":"2018-11-14T18:35:43Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/LLK/scratch-gui/pulls/3725","html_url":"https://github.com/LLK/scratch-gui/pull/3725","diff_url":"https://github.com/LLK/scratch-gui/pull/3725.diff","patch_url":"https://github.com/LLK/scratch-gui/pull/3725.patch"},"body":"### Resolves\r\nPrerequisite for https://github.com/LLK/scratch-www/issues/2281\r\n\r\n### Proposed Changes\r\n\r\nMoved the tutorial id handling into gui so it works when gui is embedded in www as well as standalone.\r\n\r\nThis seemed better than duplicating the query handling in www, in order to pass an id to gui.\r\n\r\nNote, the `?tutorial=all` handling remains in app-state-hoc. Currently it’s only needed in standalone mode for Hour of Code. It’s easy to move into the gui container if we do want it in gui by default.\r\n\r\nQuestion: are there going to be interactions with project save/new... that will lead to ignoring the query string, or otherwise not the results that users expect.\r\n\r\n### Reason for Changes\r\nSupport opening with a tutorial loaded in www.\r\n\r\n### Test Coverage\r\nCurrent tests pass - it didn't change functionality, just where it was included so it's available in www.\r\n\r\nTry it:\r\nhttps://chrisgarrity.github.io/scratch-gui/issue/www-2281-tutorials/\r\n\r\nManual testing:\r\n- [ ] `/?tutorial=getStarted` should open the getting started tutorial\r\n- [ ] Other tutorials should open as well ('name', 'music', 'chase-game', 'clicker-game', 'animations-that-talk') \r\n- [ ] 'animate-an-adventure-game' should load with a default project\r\n- [ ] `/?tutorial=all` should load with the tutorials library open\r\n- [ ] if the tutorial isn't recognized it should be ignored\r\n\r\n\r\n### Browser Coverage\r\nCheck the OS/browser combinations tested (At least 2)\r\n\r\nMac\r\n * [x] Chrome \r\n * [x] Firefox \r\n * [x] Safari\r\n \r\nWindows\r\n * [ ] Chrome \r\n * [ ] Firefox \r\n * [ ] Edge\r\n \r\nChromebook\r\n * [ ] Chrome\r\n \r\niPad\r\n* [ ] Safari\r\n\r\nAndroid Tablet\r\n* [ ] Chrome\r\n"},"comment":{"url":"https://api.github.com/repos/LLK/scratch-gui/issues/comments/438770062","html_url":"https://github.com/LLK/scratch-gui/pull/3725#issuecomment-438770062","issue_url":"https://api.github.com/repos/LLK/scratch-gui/issues/3725","id":438770062,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODc3MDA2Mg==","user":{"login":"benjiwheeler","id":3431616,"node_id":"MDQ6VXNlcjM0MzE2MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3431616?v=4","gravatar_id":"","url":"https://api.github.com/users/benjiwheeler","html_url":"https://github.com/benjiwheeler","followers_url":"https://api.github.com/users/benjiwheeler/followers","following_url":"https://api.github.com/users/benjiwheeler/following{/other_user}","gists_url":"https://api.github.com/users/benjiwheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/benjiwheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjiwheeler/subscriptions","organizations_url":"https://api.github.com/users/benjiwheeler/orgs","repos_url":"https://api.github.com/users/benjiwheeler/repos","events_url":"https://api.github.com/users/benjiwheeler/events{/privacy}","received_events_url":"https://api.github.com/users/benjiwheeler/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T18:35:43Z","updated_at":"2018-11-14T18:35:43Z","author_association":"CONTRIBUTOR","body":"Thanks, I was able to bring up the project with id and tutorial. But tests are failing..."}}
{"actor":{"display_login":"benjiwheeler"}}