{"action":"created","issue":{"url":"https://api.github.com/repos/boostorg/graph/issues/86","repository_url":"https://api.github.com/repos/boostorg/graph","labels_url":"https://api.github.com/repos/boostorg/graph/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/boostorg/graph/issues/86/comments","events_url":"https://api.github.com/repos/boostorg/graph/issues/86/events","html_url":"https://github.com/boostorg/graph/pull/86","id":210918184,"node_id":"MDExOlB1bGxSZXF1ZXN0MTA4NDIzNzE1","number":86,"title":"fix bucket_sorter bug affecting min_degree_ordering","user":{"login":"felix-salfelder","id":1772519,"node_id":"MDQ6VXNlcjE3NzI1MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1772519?v=4","gravatar_id":"","url":"https://api.github.com/users/felix-salfelder","html_url":"https://github.com/felix-salfelder","followers_url":"https://api.github.com/users/felix-salfelder/followers","following_url":"https://api.github.com/users/felix-salfelder/following{/other_user}","gists_url":"https://api.github.com/users/felix-salfelder/gists{/gist_id}","starred_url":"https://api.github.com/users/felix-salfelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felix-salfelder/subscriptions","organizations_url":"https://api.github.com/users/felix-salfelder/orgs","repos_url":"https://api.github.com/users/felix-salfelder/repos","events_url":"https://api.github.com/users/felix-salfelder/events{/privacy}","received_events_url":"https://api.github.com/users/felix-salfelder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2017-02-28T22:16:27Z","updated_at":"2018-11-05T21:58:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/boostorg/graph/pulls/86","html_url":"https://github.com/boostorg/graph/pull/86","diff_url":"https://github.com/boostorg/graph/pull/86.diff","patch_url":"https://github.com/boostorg/graph/pull/86.patch"},"body":"removing an element from a stack does not always work, since the\r\npredecessor of a stack element is not (always) stored. this patch\r\nmerges the array head into next, so a top element in a stack can point\r\nto the head of the stack it is in.\r\n\r\nremarks:\r\n- i am guessing the intended use (see test below), as it works like that\r\n  for elements deeper down in a stack\r\n- the fix abuses pointers/iterators and infers offsets from address\r\n  differences. (yes it's a bit ugly.)\r\n- memory needs and complexity are unaffected, size_type is probably big\r\n  enough.\r\n\r\ntest case. B is a bucketsorter operating on a vector V.\r\n\r\n V[0]=0;\r\n V[1]=1;\r\n B.push(0);\r\n B.push(1);\r\n\r\n// now, stacks 0 and 1 are singletons.\r\n// try to move 0 to stack 1, should result in\r\n// head_1->0->1->end, but calls remove first, then\r\n\r\n V[0]=1;\r\n B.update(0); // <- BOOM\r\n\r\n// the update calls remove, it \"removes\" 0 from stack V[0]=1.\r\n// it's not there yet (!).\r\n// instead 1 (top of bucket 1) must die.\r\n// the result is head_1->0->end, and wrong."},"comment":{"url":"https://api.github.com/repos/boostorg/graph/issues/comments/436050966","html_url":"https://github.com/boostorg/graph/pull/86#issuecomment-436050966","issue_url":"https://api.github.com/repos/boostorg/graph/issues/86","id":436050966,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjA1MDk2Ng==","user":{"login":"anadon","id":3113477,"node_id":"MDQ6VXNlcjMxMTM0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/3113477?v=4","gravatar_id":"","url":"https://api.github.com/users/anadon","html_url":"https://github.com/anadon","followers_url":"https://api.github.com/users/anadon/followers","following_url":"https://api.github.com/users/anadon/following{/other_user}","gists_url":"https://api.github.com/users/anadon/gists{/gist_id}","starred_url":"https://api.github.com/users/anadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anadon/subscriptions","organizations_url":"https://api.github.com/users/anadon/orgs","repos_url":"https://api.github.com/users/anadon/repos","events_url":"https://api.github.com/users/anadon/events{/privacy}","received_events_url":"https://api.github.com/users/anadon/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T21:58:38Z","updated_at":"2018-11-05T21:58:38Z","author_association":"CONTRIBUTOR","body":"use the `devel` tag, not a hash."}}
{"actor":{"display_login":"anadon"}}