{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68529","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68529/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68529/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68529/events","html_url":"https://github.com/kubernetes/kubernetes/pull/68529","id":359264253,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0Nzk4MTcw","number":68529,"title":"Optionally delete pods when draining them does not work after configu…","user":{"login":"grosser","id":11367,"node_id":"MDQ6VXNlcjExMzY3","avatar_url":"https://avatars3.githubusercontent.com/u/11367?v=4","gravatar_id":"","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"labels":[{"id":1047217136,"node_id":"MDU6TGFiZWwxMDQ3MjE3MTM2","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-kind","name":"needs-kind","color":"ededed","default":false},{"id":573014062,"node_id":"MDU6TGFiZWw1NzMwMTQwNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":617149945,"node_id":"MDU6TGFiZWw2MTcxNDk5NDU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-sig","name":"needs-sig","color":"ededed","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253450895,"node_id":"MDU6TGFiZWwyNTM0NTA4OTU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-11T23:48:29Z","updated_at":"2018-09-11T23:48:36Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68529","html_url":"https://github.com/kubernetes/kubernetes/pull/68529","diff_url":"https://github.com/kubernetes/kubernetes/pull/68529.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/68529.patch"},"body":"…reable retries\r\n\r\n**What this PR does / why we need it**:\r\nProblem:\r\nCurrently draining gets blocked if pods cannot be evicted safely. See https://medium.com/@felipedutratine/when-you-try-to-drain-a-kubernetes-node-but-it-blocks-5aba9592d7c9 for a nice writeup ... basically it is \"Hey go and manually delete this pod node\" especially if this is done via an automated process.\r\n\r\nSolution: delete pods if eviction does not work after N retries and log that it was done\r\n\r\n**Special notes for your reviewer**:\r\nMore of a POC I was just seeing if it was easy to add ... needs more docs/tests etc, but I want to get feedback if this is something mergable or unwanted.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nAdd kubectl drain --max-retried N option to delete pods that could not be evicted after N tries\r\n```\r\n\r\n/cc @jonmoter @adammw "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/420463935","html_url":"https://github.com/kubernetes/kubernetes/pull/68529#issuecomment-420463935","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68529","id":420463935,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDQ2MzkzNQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T23:48:36Z","updated_at":"2018-09-11T23:48:36Z","author_association":"CONTRIBUTOR","body":"Hi @grosser. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}