{"action":"created","issue":{"url":"https://api.github.com/repos/ros-simulation/gazebo_ros_pkgs/issues/637","repository_url":"https://api.github.com/repos/ros-simulation/gazebo_ros_pkgs","labels_url":"https://api.github.com/repos/ros-simulation/gazebo_ros_pkgs/issues/637/labels{/name}","comments_url":"https://api.github.com/repos/ros-simulation/gazebo_ros_pkgs/issues/637/comments","events_url":"https://api.github.com/repos/ros-simulation/gazebo_ros_pkgs/issues/637/events","html_url":"https://github.com/ros-simulation/gazebo_ros_pkgs/pull/637","id":275370527,"number":637,"title":"Don't ignore robotNamespace","user":{"login":"focke-85","id":33652833,"avatar_url":"https://avatars1.githubusercontent.com/u/33652833?v=4","gravatar_id":"","url":"https://api.github.com/users/focke-85","html_url":"https://github.com/focke-85","followers_url":"https://api.github.com/users/focke-85/followers","following_url":"https://api.github.com/users/focke-85/following{/other_user}","gists_url":"https://api.github.com/users/focke-85/gists{/gist_id}","starred_url":"https://api.github.com/users/focke-85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/focke-85/subscriptions","organizations_url":"https://api.github.com/users/focke-85/orgs","repos_url":"https://api.github.com/users/focke-85/repos","events_url":"https://api.github.com/users/focke-85/events{/privacy}","received_events_url":"https://api.github.com/users/focke-85/received_events","type":"User","site_admin":false},"labels":[{"id":364091142,"url":"https://api.github.com/repos/ros-simulation/gazebo_ros_pkgs/labels/needs%20feedback","name":"needs feedback","color":"fef2c0","default":false},{"id":473235790,"url":"https://api.github.com/repos/ros-simulation/gazebo_ros_pkgs/labels/wait-upcoming-release","name":"wait-upcoming-release","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-20T14:17:33Z","updated_at":"2018-04-05T16:51:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ros-simulation/gazebo_ros_pkgs/pulls/637","html_url":"https://github.com/ros-simulation/gazebo_ros_pkgs/pull/637","diff_url":"https://github.com/ros-simulation/gazebo_ros_pkgs/pull/637.diff","patch_url":"https://github.com/ros-simulation/gazebo_ros_pkgs/pull/637.patch"},"body":"When creating the NodeHandle for reading the PID parameters, the model_nh was always ignored. Instead, all parameters were read from /gazebo_ros_control/pid_gains/<joint_name>/* instead of /<robot_name>/gazebo_ros_control/pid_gains/<joint_name>/*.\r\n\r\nThis commit restores the intended behavior, i.e., the parameters will now read from <robot_name>/..., where <robot_name> is specified via the robotNamespace plugin parameter or the parent name."},"comment":{"url":"https://api.github.com/repos/ros-simulation/gazebo_ros_pkgs/issues/comments/379002921","html_url":"https://github.com/ros-simulation/gazebo_ros_pkgs/pull/637#issuecomment-379002921","issue_url":"https://api.github.com/repos/ros-simulation/gazebo_ros_pkgs/issues/637","id":379002921,"user":{"login":"j-rivero","id":2098802,"avatar_url":"https://avatars3.githubusercontent.com/u/2098802?v=4","gravatar_id":"","url":"https://api.github.com/users/j-rivero","html_url":"https://github.com/j-rivero","followers_url":"https://api.github.com/users/j-rivero/followers","following_url":"https://api.github.com/users/j-rivero/following{/other_user}","gists_url":"https://api.github.com/users/j-rivero/gists{/gist_id}","starred_url":"https://api.github.com/users/j-rivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-rivero/subscriptions","organizations_url":"https://api.github.com/users/j-rivero/orgs","repos_url":"https://api.github.com/users/j-rivero/repos","events_url":"https://api.github.com/users/j-rivero/events{/privacy}","received_events_url":"https://api.github.com/users/j-rivero/received_events","type":"User","site_admin":false},"created_at":"2018-04-05T16:51:52Z","updated_at":"2018-04-05T16:51:52Z","author_association":"CONTRIBUTOR","body":"@osrf-jenkins run tests please"}}
{"actor":{"display_login":"j-rivero"}}