{"action":"created","issue":{"url":"https://api.github.com/repos/N00byEdge/BWEM-community/issues/28","repository_url":"https://api.github.com/repos/N00byEdge/BWEM-community","labels_url":"https://api.github.com/repos/N00byEdge/BWEM-community/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/N00byEdge/BWEM-community/issues/28/comments","events_url":"https://api.github.com/repos/N00byEdge/BWEM-community/issues/28/events","html_url":"https://github.com/N00byEdge/BWEM-community/pull/28","id":327574084,"number":28,"title":"WIP: (RFC) Add JSON files with map data; start testing vs that instead of hard-coded","user":{"login":"EvanED","id":508945,"avatar_url":"https://avatars3.githubusercontent.com/u/508945?v=4","gravatar_id":"","url":"https://api.github.com/users/EvanED","html_url":"https://github.com/EvanED","followers_url":"https://api.github.com/users/EvanED/followers","following_url":"https://api.github.com/users/EvanED/following{/other_user}","gists_url":"https://api.github.com/users/EvanED/gists{/gist_id}","starred_url":"https://api.github.com/users/EvanED/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvanED/subscriptions","organizations_url":"https://api.github.com/users/EvanED/orgs","repos_url":"https://api.github.com/users/EvanED/repos","events_url":"https://api.github.com/users/EvanED/events{/privacy}","received_events_url":"https://api.github.com/users/EvanED/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-30T04:55:37Z","updated_at":"2018-05-30T05:06:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/N00byEdge/BWEM-community/pulls/28","html_url":"https://github.com/N00byEdge/BWEM-community/pull/28","diff_url":"https://github.com/N00byEdge/BWEM-community/pull/28.diff","patch_url":"https://github.com/N00byEdge/BWEM-community/pull/28.patch"},"body":"Like I said on Discord, this is not intended to be merged, just to check in about how what I'm doing matches the vision of #24 \r\n\r\nChanges in this encompass a bunch of stuff:\r\n\r\n* Project file changes. Ignore these completely, or at least almost completely. I did have to add `/std:c++17` to be able to use `optional`, though it's not really being used at the moment and I could drop it easily. (I could also change to `/std:c++latest` if that'd be of interest.)\r\n* I \"had\" to add a JSON library, obviously, so that's in `.gitmodules` now\r\n* `Tests/MapResourcesInfo.cpp` is the main file to show what the changes look like, reading from JSON rather than hard-coded values. The change from a `tuple` to `struct` is incidental here.\r\n* `Tests/MapToJson.cpp` is what I used to generate the JSON files. It's currently hacked in as just another `TEST`, but this will eventually become completely separate.\r\n* There are a bunch of new `.json` files under the `Tests/data/maps` directories holding the expected data. Not all data in those files is currently tested."},"comment":{"url":"https://api.github.com/repos/N00byEdge/BWEM-community/issues/comments/393031862","html_url":"https://github.com/N00byEdge/BWEM-community/pull/28#issuecomment-393031862","issue_url":"https://api.github.com/repos/N00byEdge/BWEM-community/issues/28","id":393031862,"user":{"login":"EvanED","id":508945,"avatar_url":"https://avatars3.githubusercontent.com/u/508945?v=4","gravatar_id":"","url":"https://api.github.com/users/EvanED","html_url":"https://github.com/EvanED","followers_url":"https://api.github.com/users/EvanED/followers","following_url":"https://api.github.com/users/EvanED/following{/other_user}","gists_url":"https://api.github.com/users/EvanED/gists{/gist_id}","starred_url":"https://api.github.com/users/EvanED/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvanED/subscriptions","organizations_url":"https://api.github.com/users/EvanED/orgs","repos_url":"https://api.github.com/users/EvanED/repos","events_url":"https://api.github.com/users/EvanED/events{/privacy}","received_events_url":"https://api.github.com/users/EvanED/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T05:06:51Z","updated_at":"2018-05-30T05:06:51Z","author_association":"NONE","body":"Oh yeah, I should also say don't get too caught up in the specifics of the bad error handling when reading the json file, somewhat poor style with the `struct` that replaced the `tuple`, etc.; I'm more looking to make sure I'm not going down some path completely disconnected from what you wanted."}}
{"actor":{"display_login":"EvanED"}}