{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/205982049","pull_request_review_id":141355289,"id":205982049,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk4MjA0OQ==","diff_hunk":"@@ -794,11 +794,11 @@ public void process(ProcessContext c) throws Exception {\n                 ? writeOperation.finalizeDestination(\n                     defaultDest, GlobalWindow.INSTANCE, fixedNumShards, fileResults)\n                 : finalizeAllDestinations(fileResults, fixedNumShards);\n+        writeOperation.moveToOutputFiles(resultsToFinalFilenames);","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java","position":4,"original_position":4,"commit_id":"59c73eaaaa2c00af50d94dfe1d696270e8fba2da","original_commit_id":"59c73eaaaa2c00af50d94dfe1d696270e8fba2da","user":{"login":"reuvenlax","id":21071061,"node_id":"MDQ6VXNlcjIxMDcxMDYx","avatar_url":"https://avatars1.githubusercontent.com/u/21071061?v=4","gravatar_id":"","url":"https://api.github.com/users/reuvenlax","html_url":"https://github.com/reuvenlax","followers_url":"https://api.github.com/users/reuvenlax/followers","following_url":"https://api.github.com/users/reuvenlax/following{/other_user}","gists_url":"https://api.github.com/users/reuvenlax/gists{/gist_id}","starred_url":"https://api.github.com/users/reuvenlax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuvenlax/subscriptions","organizations_url":"https://api.github.com/users/reuvenlax/orgs","repos_url":"https://api.github.com/users/reuvenlax/repos","events_url":"https://api.github.com/users/reuvenlax/events{/privacy}","received_events_url":"https://api.github.com/users/reuvenlax/received_events","type":"User","site_admin":false},"body":"This looks good to me (and I'll go ahead and merge this PR). However I am confused as to why this makes a difference. My understanding is that the outputs should not be delivered until after the DoFn finishes executing, which means that the order inside the DoFn should not matter.","created_at":"2018-07-29T17:47:29Z","updated_at":"2018-07-29T17:47:29Z","html_url":"https://github.com/apache/beam/pull/6075#discussion_r205982049","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/6075","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/205982049"},"html":{"href":"https://github.com/apache/beam/pull/6075#discussion_r205982049"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/6075"}}},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/6075","id":204138819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTM4ODE5","html_url":"https://github.com/apache/beam/pull/6075","diff_url":"https://github.com/apache/beam/pull/6075.diff","patch_url":"https://github.com/apache/beam/pull/6075.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/6075","number":6075,"state":"open","locked":false,"title":"[BEAM-5028] Finalize writes before returning filenames via WriteFileResults","user":{"login":"JozoVilcek","id":3295033,"node_id":"MDQ6VXNlcjMyOTUwMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/3295033?v=4","gravatar_id":"","url":"https://api.github.com/users/JozoVilcek","html_url":"https://github.com/JozoVilcek","followers_url":"https://api.github.com/users/JozoVilcek/followers","following_url":"https://api.github.com/users/JozoVilcek/following{/other_user}","gists_url":"https://api.github.com/users/JozoVilcek/gists{/gist_id}","starred_url":"https://api.github.com/users/JozoVilcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JozoVilcek/subscriptions","organizations_url":"https://api.github.com/users/JozoVilcek/orgs","repos_url":"https://api.github.com/users/JozoVilcek/repos","events_url":"https://api.github.com/users/JozoVilcek/events{/privacy}","received_events_url":"https://api.github.com/users/JozoVilcek/received_events","type":"User","site_admin":false},"body":"\r\n\r\n\r\n\r\n\r\n","created_at":"2018-07-26T13:16:28Z","updated_at":"2018-07-29T17:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b412c268caabcaa439b51168cb112d148a1d91c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/6075/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/6075/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/6075/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/59c73eaaaa2c00af50d94dfe1d696270e8fba2da","head":{"label":"datadrivencz:finalize-write-first","ref":"finalize-write-first","sha":"59c73eaaaa2c00af50d94dfe1d696270e8fba2da","user":{"login":"datadrivencz","id":32707645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzA3NjQ1","avatar_url":"https://avatars1.githubusercontent.com/u/32707645?v=4","gravatar_id":"","url":"https://api.github.com/users/datadrivencz","html_url":"https://github.com/datadrivencz","followers_url":"https://api.github.com/users/datadrivencz/followers","following_url":"https://api.github.com/users/datadrivencz/following{/other_user}","gists_url":"https://api.github.com/users/datadrivencz/gists{/gist_id}","starred_url":"https://api.github.com/users/datadrivencz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datadrivencz/subscriptions","organizations_url":"https://api.github.com/users/datadrivencz/orgs","repos_url":"https://api.github.com/users/datadrivencz/repos","events_url":"https://api.github.com/users/datadrivencz/events{/privacy}","received_events_url":"https://api.github.com/users/datadrivencz/received_events","type":"Organization","site_admin":false},"repo":{"id":142441764,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0NDE3NjQ=","name":"beam","full_name":"datadrivencz/beam","owner":{"login":"datadrivencz","id":32707645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzA3NjQ1","avatar_url":"https://avatars1.githubusercontent.com/u/32707645?v=4","gravatar_id":"","url":"https://api.github.com/users/datadrivencz","html_url":"https://github.com/datadrivencz","followers_url":"https://api.github.com/users/datadrivencz/followers","following_url":"https://api.github.com/users/datadrivencz/following{/other_user}","gists_url":"https://api.github.com/users/datadrivencz/gists{/gist_id}","starred_url":"https://api.github.com/users/datadrivencz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datadrivencz/subscriptions","organizations_url":"https://api.github.com/users/datadrivencz/orgs","repos_url":"https://api.github.com/users/datadrivencz/repos","events_url":"https://api.github.com/users/datadrivencz/events{/privacy}","received_events_url":"https://api.github.com/users/datadrivencz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datadrivencz/beam","description":"Apache Beam","fork":true,"url":"https://api.github.com/repos/datadrivencz/beam","forks_url":"https://api.github.com/repos/datadrivencz/beam/forks","keys_url":"https://api.github.com/repos/datadrivencz/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datadrivencz/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datadrivencz/beam/teams","hooks_url":"https://api.github.com/repos/datadrivencz/beam/hooks","issue_events_url":"https://api.github.com/repos/datadrivencz/beam/issues/events{/number}","events_url":"https://api.github.com/repos/datadrivencz/beam/events","assignees_url":"https://api.github.com/repos/datadrivencz/beam/assignees{/user}","branches_url":"https://api.github.com/repos/datadrivencz/beam/branches{/branch}","tags_url":"https://api.github.com/repos/datadrivencz/beam/tags","blobs_url":"https://api.github.com/repos/datadrivencz/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datadrivencz/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datadrivencz/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/datadrivencz/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datadrivencz/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/datadrivencz/beam/languages","stargazers_url":"https://api.github.com/repos/datadrivencz/beam/stargazers","contributors_url":"https://api.github.com/repos/datadrivencz/beam/contributors","subscribers_url":"https://api.github.com/repos/datadrivencz/beam/subscribers","subscription_url":"https://api.github.com/repos/datadrivencz/beam/subscription","commits_url":"https://api.github.com/repos/datadrivencz/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/datadrivencz/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/datadrivencz/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/datadrivencz/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/datadrivencz/beam/contents/{+path}","compare_url":"https://api.github.com/repos/datadrivencz/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datadrivencz/beam/merges","archive_url":"https://api.github.com/repos/datadrivencz/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datadrivencz/beam/downloads","issues_url":"https://api.github.com/repos/datadrivencz/beam/issues{/number}","pulls_url":"https://api.github.com/repos/datadrivencz/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/datadrivencz/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/datadrivencz/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datadrivencz/beam/labels{/name}","releases_url":"https://api.github.com/repos/datadrivencz/beam/releases{/id}","deployments_url":"https://api.github.com/repos/datadrivencz/beam/deployments","created_at":"2018-07-26T13:02:47Z","updated_at":"2018-07-26T13:03:05Z","pushed_at":"2018-07-26T13:13:00Z","git_url":"git://github.com/datadrivencz/beam.git","ssh_url":"git@github.com:datadrivencz/beam.git","clone_url":"https://github.com/datadrivencz/beam.git","svn_url":"https://github.com/datadrivencz/beam","homepage":"","size":99553,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"aa2b585a5356ce3b607dd3d17a3c6ab2ce65353b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-07-27T23:46:33Z","pushed_at":"2018-07-29T07:33:44Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":99632,"stargazers_count":2011,"watchers_count":2011,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1255,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1255,"open_issues":88,"watchers":2011,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/6075"},"html":{"href":"https://github.com/apache/beam/pull/6075"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/6075"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/6075/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/6075/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/6075/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/59c73eaaaa2c00af50d94dfe1d696270e8fba2da"}},"author_association":"NONE"}}
{"actor":{"display_login":"reuvenlax"}}