{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/211110688","pull_request_review_id":147466625,"id":211110688,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTExMDY4OA==","diff_hunk":"@@ -6607,32 +6560,12 @@ done:;\n \tVMINLINE VM_BytecodeAction\n \tinvokestaticsplit(REGISTER_ARGS_LIST)\n \t{\n-\t\tVM_BytecodeAction rc = GOTO_RUN_METHOD;\n \t\tU_16 splitTableIndex = *(U_16*)(_pc + 1);\n+\t\tprofileCallingMethod(REGISTER_ARGS);","path":"runtime/vm/BytecodeInterpreter.hpp","position":253,"original_position":253,"commit_id":"aea7a0a1cc20f01faeb1d50a16f3a584f514115d","original_commit_id":"aea7a0a1cc20f01faeb1d50a16f3a584f514115d","user":{"login":"gacholio","id":18033688,"node_id":"MDQ6VXNlcjE4MDMzNjg4","avatar_url":"https://avatars2.githubusercontent.com/u/18033688?v=4","gravatar_id":"","url":"https://api.github.com/users/gacholio","html_url":"https://github.com/gacholio","followers_url":"https://api.github.com/users/gacholio/followers","following_url":"https://api.github.com/users/gacholio/following{/other_user}","gists_url":"https://api.github.com/users/gacholio/gists{/gist_id}","starred_url":"https://api.github.com/users/gacholio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gacholio/subscriptions","organizations_url":"https://api.github.com/users/gacholio/orgs","repos_url":"https://api.github.com/users/gacholio/repos","events_url":"https://api.github.com/users/gacholio/events{/privacy}","received_events_url":"https://api.github.com/users/gacholio/received_events","type":"User","site_admin":false},"body":"The profile here is for the calling method, not the target method. invokespecial already did this.\r\n\r\n```\tVMINLINE void\r\n\tprofileCallingMethod(REGISTER_ARGS_LIST)\r\n\t{\r\n\t\tU_8 *profilingCursor = startProfilingRecord(REGISTER_ARGS, sizeof(J9Method*));\r\n\t\tif (NULL != profilingCursor) {\r\n\t\t\t*(J9Method**)profilingCursor = _literals;\r\n\t\t}\r\n\t}\r\n```","created_at":"2018-08-19T18:10:35Z","updated_at":"2018-08-19T18:10:35Z","html_url":"https://github.com/eclipse/openj9/pull/2652#discussion_r211110688","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/2652","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/211110688"},"html":{"href":"https://github.com/eclipse/openj9/pull/2652#discussion_r211110688"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2652"}},"in_reply_to_id":211090610},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/2652","id":209329341,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzI5MzQx","html_url":"https://github.com/eclipse/openj9/pull/2652","diff_url":"https://github.com/eclipse/openj9/pull/2652.diff","patch_url":"https://github.com/eclipse/openj9/pull/2652.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/2652","number":2652,"state":"open","locked":false,"title":"Fix and optimize split bytecodes","user":{"login":"gacholio","id":18033688,"node_id":"MDQ6VXNlcjE4MDMzNjg4","avatar_url":"https://avatars2.githubusercontent.com/u/18033688?v=4","gravatar_id":"","url":"https://api.github.com/users/gacholio","html_url":"https://github.com/gacholio","followers_url":"https://api.github.com/users/gacholio/followers","following_url":"https://api.github.com/users/gacholio/following{/other_user}","gists_url":"https://api.github.com/users/gacholio/gists{/gist_id}","starred_url":"https://api.github.com/users/gacholio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gacholio/subscriptions","organizations_url":"https://api.github.com/users/gacholio/orgs","repos_url":"https://api.github.com/users/gacholio/repos","events_url":"https://api.github.com/users/gacholio/events{/privacy}","received_events_url":"https://api.github.com/users/gacholio/received_events","type":"User","site_admin":false},"body":"- commonize logic for invokespecial and invokespecialsplit\r\n- use initial methods instead of NULL for unresolved split bytecodes\r\n- invokespecial/split throw resolve errors before NPE\r\n- add missing profile call to invokespecialsplit\r\n\r\nFixes: #2602\r\n\r\nSigned-off-by: Graham Chapman <graham_chapman@ca.ibm.com>","created_at":"2018-08-18T20:33:37Z","updated_at":"2018-08-19T18:10:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc2199c91545bb4362c62ed1317de24837453e08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962110,"node_id":"MDU6TGFiZWw2OTc5NjIxMTA=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:vm","name":"comp:vm","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/2652/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/2652/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/2652/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/aea7a0a1cc20f01faeb1d50a16f3a584f514115d","head":{"label":"gacholio:split","ref":"split","sha":"aea7a0a1cc20f01faeb1d50a16f3a584f514115d","user":{"login":"gacholio","id":18033688,"node_id":"MDQ6VXNlcjE4MDMzNjg4","avatar_url":"https://avatars2.githubusercontent.com/u/18033688?v=4","gravatar_id":"","url":"https://api.github.com/users/gacholio","html_url":"https://github.com/gacholio","followers_url":"https://api.github.com/users/gacholio/followers","following_url":"https://api.github.com/users/gacholio/following{/other_user}","gists_url":"https://api.github.com/users/gacholio/gists{/gist_id}","starred_url":"https://api.github.com/users/gacholio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gacholio/subscriptions","organizations_url":"https://api.github.com/users/gacholio/orgs","repos_url":"https://api.github.com/users/gacholio/repos","events_url":"https://api.github.com/users/gacholio/events{/privacy}","received_events_url":"https://api.github.com/users/gacholio/received_events","type":"User","site_admin":false},"repo":{"id":103545954,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM1NDU5NTQ=","name":"openj9","full_name":"gacholio/openj9","owner":{"login":"gacholio","id":18033688,"node_id":"MDQ6VXNlcjE4MDMzNjg4","avatar_url":"https://avatars2.githubusercontent.com/u/18033688?v=4","gravatar_id":"","url":"https://api.github.com/users/gacholio","html_url":"https://github.com/gacholio","followers_url":"https://api.github.com/users/gacholio/followers","following_url":"https://api.github.com/users/gacholio/following{/other_user}","gists_url":"https://api.github.com/users/gacholio/gists{/gist_id}","starred_url":"https://api.github.com/users/gacholio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gacholio/subscriptions","organizations_url":"https://api.github.com/users/gacholio/orgs","repos_url":"https://api.github.com/users/gacholio/repos","events_url":"https://api.github.com/users/gacholio/events{/privacy}","received_events_url":"https://api.github.com/users/gacholio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gacholio/openj9","description":"OpenJ9","fork":true,"url":"https://api.github.com/repos/gacholio/openj9","forks_url":"https://api.github.com/repos/gacholio/openj9/forks","keys_url":"https://api.github.com/repos/gacholio/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gacholio/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gacholio/openj9/teams","hooks_url":"https://api.github.com/repos/gacholio/openj9/hooks","issue_events_url":"https://api.github.com/repos/gacholio/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/gacholio/openj9/events","assignees_url":"https://api.github.com/repos/gacholio/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/gacholio/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/gacholio/openj9/tags","blobs_url":"https://api.github.com/repos/gacholio/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gacholio/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gacholio/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/gacholio/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gacholio/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/gacholio/openj9/languages","stargazers_url":"https://api.github.com/repos/gacholio/openj9/stargazers","contributors_url":"https://api.github.com/repos/gacholio/openj9/contributors","subscribers_url":"https://api.github.com/repos/gacholio/openj9/subscribers","subscription_url":"https://api.github.com/repos/gacholio/openj9/subscription","commits_url":"https://api.github.com/repos/gacholio/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/gacholio/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/gacholio/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/gacholio/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/gacholio/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/gacholio/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gacholio/openj9/merges","archive_url":"https://api.github.com/repos/gacholio/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gacholio/openj9/downloads","issues_url":"https://api.github.com/repos/gacholio/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/gacholio/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/gacholio/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/gacholio/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gacholio/openj9/labels{/name}","releases_url":"https://api.github.com/repos/gacholio/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/gacholio/openj9/deployments","created_at":"2017-09-14T14:56:54Z","updated_at":"2018-08-19T17:44:01Z","pushed_at":"2018-08-19T17:54:39Z","git_url":"git://github.com/gacholio/openj9.git","ssh_url":"git@github.com:gacholio/openj9.git","clone_url":"https://github.com/gacholio/openj9.git","svn_url":"https://github.com/gacholio/openj9","homepage":null,"size":33517,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"1fe403c9958de3f89eb40c4744acffaccfc8eb0d","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-08-19T03:08:12Z","pushed_at":"2018-08-19T15:46:52Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":33202,"stargazers_count":1384,"watchers_count":1384,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"archived":false,"open_issues_count":443,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":270,"open_issues":443,"watchers":1384,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2652"},"html":{"href":"https://github.com/eclipse/openj9/pull/2652"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2652"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2652/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2652/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2652/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/aea7a0a1cc20f01faeb1d50a16f3a584f514115d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gacholio"}}