{"action":"opened","number":2326,"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2326","id":225966500,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTY2NTAw","html_url":"https://github.com/knative/serving/pull/2326","diff_url":"https://github.com/knative/serving/pull/2326.diff","patch_url":"https://github.com/knative/serving/pull/2326.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/2326","number":2326,"state":"open","locked":false,"title":"refine route reconciler logic","user":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"body":"<!--\r\nRequest Prow to automatically lint any go code in this PR:\r\n\r\n/lint\r\n-->\r\n\r\nTo address https://github.com/knative/serving/pull/2243#discussion_r228181193\r\n\r\nSince we already have corresponding condition item to reflect ClusterIngress status, we can extract the logic to handle child resources out of `configureTraffic`, to keep things pure.\r\n\r\n\r\n**Release Note**\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n```\r\nNONE\r\n```\r\n/area networking\r\n/kind cleanup","created_at":"2018-10-26T03:34:33Z","updated_at":"2018-10-26T03:34:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/2326/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/2326/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/2326/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/57291a5e4fb4d80194ef0257fda3370c4ef6c7f1","head":{"label":"lichuqiang:refine_route_reconciler","ref":"refine_route_reconciler","sha":"57291a5e4fb4d80194ef0257fda3370c4ef6c7f1","user":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"repo":{"id":149099865,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwOTk4NjU=","name":"serving","full_name":"lichuqiang/serving","private":false,"owner":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lichuqiang/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/lichuqiang/serving","forks_url":"https://api.github.com/repos/lichuqiang/serving/forks","keys_url":"https://api.github.com/repos/lichuqiang/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lichuqiang/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lichuqiang/serving/teams","hooks_url":"https://api.github.com/repos/lichuqiang/serving/hooks","issue_events_url":"https://api.github.com/repos/lichuqiang/serving/issues/events{/number}","events_url":"https://api.github.com/repos/lichuqiang/serving/events","assignees_url":"https://api.github.com/repos/lichuqiang/serving/assignees{/user}","branches_url":"https://api.github.com/repos/lichuqiang/serving/branches{/branch}","tags_url":"https://api.github.com/repos/lichuqiang/serving/tags","blobs_url":"https://api.github.com/repos/lichuqiang/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lichuqiang/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lichuqiang/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/lichuqiang/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lichuqiang/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/lichuqiang/serving/languages","stargazers_url":"https://api.github.com/repos/lichuqiang/serving/stargazers","contributors_url":"https://api.github.com/repos/lichuqiang/serving/contributors","subscribers_url":"https://api.github.com/repos/lichuqiang/serving/subscribers","subscription_url":"https://api.github.com/repos/lichuqiang/serving/subscription","commits_url":"https://api.github.com/repos/lichuqiang/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/lichuqiang/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/lichuqiang/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/lichuqiang/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/lichuqiang/serving/contents/{+path}","compare_url":"https://api.github.com/repos/lichuqiang/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lichuqiang/serving/merges","archive_url":"https://api.github.com/repos/lichuqiang/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lichuqiang/serving/downloads","issues_url":"https://api.github.com/repos/lichuqiang/serving/issues{/number}","pulls_url":"https://api.github.com/repos/lichuqiang/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/lichuqiang/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/lichuqiang/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lichuqiang/serving/labels{/name}","releases_url":"https://api.github.com/repos/lichuqiang/serving/releases{/id}","deployments_url":"https://api.github.com/repos/lichuqiang/serving/deployments","created_at":"2018-09-17T09:18:42Z","updated_at":"2018-09-17T09:18:45Z","pushed_at":"2018-10-26T03:12:33Z","git_url":"git://github.com/lichuqiang/serving.git","ssh_url":"git@github.com:lichuqiang/serving.git","clone_url":"https://github.com/lichuqiang/serving.git","svn_url":"https://github.com/lichuqiang/serving","homepage":"","size":23404,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"cda99cffb47d77aacbaaddf9c7e8532f6bfe1dd2","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2018-10-26T01:41:37Z","pushed_at":"2018-10-26T03:18:26Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"","size":23368,"stargazers_count":803,"watchers_count":803,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":327,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":151,"open_issues":327,"watchers":803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/2326"},"html":{"href":"https://github.com/knative/serving/pull/2326"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/2326"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/2326/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/2326/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/2326/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/57291a5e4fb4d80194ef0257fda3370c4ef6c7f1"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":76,"deletions":76,"changed_files":3}}
{"actor":{"display_login":"lichuqiang"}}