{"action":"created","comment":{"url":"https://api.github.com/repos/vanilla/addons/pulls/comments/201063873","pull_request_review_id":135492517,"id":201063873,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTA2Mzg3Mw==","diff_hunk":"@@ -122,22 +122,28 @@ function categoryUrl($category, $page = '', $withDomain = true) {\n             return safeURL(val('RedirectUrl', $category));\n         }\n \n-        // Build URL.\n+        // SEOLinks version.\n         if (class_exists('SEOLinksPlugin')) {\n-            // SEOLinks version\n             if (!isset($px)) {\n                 $px = SEOLinksPlugin::Prefix();\n             }\n             $result = '/' . $px . rawurlencode($category['UrlCode']) . '/';\n             if ($page && $page > 1) {\n                 $result .= 'p' . $page . '/';\n             }\n-        } else {\n-            // Normal version\n-            $result = '/categories/'.rawurlencode($category['UrlCode']);\n-            if ($page && $page > 1) {\n-                $result .= '/p'.$page;\n-            }\n+            return $result;\n+        }\n+\n+        // Subcommunities version.","path":"plugins/categoryaslink/class.categoryaslink.plugin.php","position":24,"original_position":24,"commit_id":"72d373a561ce81fccdb150ef9f30eb088cbea064","original_commit_id":"72d373a561ce81fccdb150ef9f30eb088cbea064","user":{"login":"initvector","id":1390241,"node_id":"MDQ6VXNlcjEzOTAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1390241?v=4","gravatar_id":"","url":"https://api.github.com/users/initvector","html_url":"https://github.com/initvector","followers_url":"https://api.github.com/users/initvector/followers","following_url":"https://api.github.com/users/initvector/following{/other_user}","gists_url":"https://api.github.com/users/initvector/gists{/gist_id}","starred_url":"https://api.github.com/users/initvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initvector/subscriptions","organizations_url":"https://api.github.com/users/initvector/orgs","repos_url":"https://api.github.com/users/initvector/repos","events_url":"https://api.github.com/users/initvector/events{/privacy}","received_events_url":"https://api.github.com/users/initvector/received_events","type":"User","site_admin":false},"body":"Should this come before SEO Links?","created_at":"2018-07-09T16:20:22Z","updated_at":"2018-07-09T16:28:46Z","html_url":"https://github.com/vanilla/addons/pull/639#discussion_r201063873","pull_request_url":"https://api.github.com/repos/vanilla/addons/pulls/639","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vanilla/addons/pulls/comments/201063873"},"html":{"href":"https://github.com/vanilla/addons/pull/639#discussion_r201063873"},"pull_request":{"href":"https://api.github.com/repos/vanilla/addons/pulls/639"}}},"pull_request":{"url":"https://api.github.com/repos/vanilla/addons/pulls/639","id":197851507,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODUxNTA3","html_url":"https://github.com/vanilla/addons/pull/639","diff_url":"https://github.com/vanilla/addons/pull/639.diff","patch_url":"https://github.com/vanilla/addons/pull/639.patch","issue_url":"https://api.github.com/repos/vanilla/addons/issues/639","number":639,"state":"open","locked":false,"title":"Fix the Category as Link Addon so it works with Subcommunities.","user":{"login":"nervoustwit","id":2651070,"node_id":"MDQ6VXNlcjI2NTEwNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/2651070?v=4","gravatar_id":"","url":"https://api.github.com/users/nervoustwit","html_url":"https://github.com/nervoustwit","followers_url":"https://api.github.com/users/nervoustwit/followers","following_url":"https://api.github.com/users/nervoustwit/following{/other_user}","gists_url":"https://api.github.com/users/nervoustwit/gists{/gist_id}","starred_url":"https://api.github.com/users/nervoustwit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nervoustwit/subscriptions","organizations_url":"https://api.github.com/users/nervoustwit/orgs","repos_url":"https://api.github.com/users/nervoustwit/repos","events_url":"https://api.github.com/users/nervoustwit/events{/privacy}","received_events_url":"https://api.github.com/users/nervoustwit/received_events","type":"User","site_admin":false},"body":"This PR fixes the fact that the Category as Link plugin doesn't work when subcommunities are turned on by doing two things:\r\n\r\n 1. Making the Category as Link fire first (changing the priority)\r\n 2. Using the Subcommunities way of constructing the URL if Subcommunities are turned on.\r\n","created_at":"2018-06-27T20:57:41Z","updated_at":"2018-07-09T16:28:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fb2dd1f81d07ae2ec28243b4226b0df95000113","assignee":{"login":"linc","id":117672,"node_id":"MDQ6VXNlcjExNzY3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/117672?v=4","gravatar_id":"","url":"https://api.github.com/users/linc","html_url":"https://github.com/linc","followers_url":"https://api.github.com/users/linc/followers","following_url":"https://api.github.com/users/linc/following{/other_user}","gists_url":"https://api.github.com/users/linc/gists{/gist_id}","starred_url":"https://api.github.com/users/linc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linc/subscriptions","organizations_url":"https://api.github.com/users/linc/orgs","repos_url":"https://api.github.com/users/linc/repos","events_url":"https://api.github.com/users/linc/events{/privacy}","received_events_url":"https://api.github.com/users/linc/received_events","type":"User","site_admin":false},"assignees":[{"login":"linc","id":117672,"node_id":"MDQ6VXNlcjExNzY3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/117672?v=4","gravatar_id":"","url":"https://api.github.com/users/linc","html_url":"https://github.com/linc","followers_url":"https://api.github.com/users/linc/followers","following_url":"https://api.github.com/users/linc/following{/other_user}","gists_url":"https://api.github.com/users/linc/gists{/gist_id}","starred_url":"https://api.github.com/users/linc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linc/subscriptions","organizations_url":"https://api.github.com/users/linc/orgs","repos_url":"https://api.github.com/users/linc/repos","events_url":"https://api.github.com/users/linc/events{/privacy}","received_events_url":"https://api.github.com/users/linc/received_events","type":"User","site_admin":false},{"login":"initvector","id":1390241,"node_id":"MDQ6VXNlcjEzOTAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1390241?v=4","gravatar_id":"","url":"https://api.github.com/users/initvector","html_url":"https://github.com/initvector","followers_url":"https://api.github.com/users/initvector/followers","following_url":"https://api.github.com/users/initvector/following{/other_user}","gists_url":"https://api.github.com/users/initvector/gists{/gist_id}","starred_url":"https://api.github.com/users/initvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initvector/subscriptions","organizations_url":"https://api.github.com/users/initvector/orgs","repos_url":"https://api.github.com/users/initvector/repos","events_url":"https://api.github.com/users/initvector/events{/privacy}","received_events_url":"https://api.github.com/users/initvector/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/vanilla/addons/milestones/70","html_url":"https://github.com/vanilla/addons/milestone/70","labels_url":"https://api.github.com/repos/vanilla/addons/milestones/70/labels","id":3457026,"node_id":"MDk6TWlsZXN0b25lMzQ1NzAyNg==","number":70,"title":"2018-07-11","description":"","creator":{"login":"linc","id":117672,"node_id":"MDQ6VXNlcjExNzY3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/117672?v=4","gravatar_id":"","url":"https://api.github.com/users/linc","html_url":"https://github.com/linc","followers_url":"https://api.github.com/users/linc/followers","following_url":"https://api.github.com/users/linc/following{/other_user}","gists_url":"https://api.github.com/users/linc/gists{/gist_id}","starred_url":"https://api.github.com/users/linc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linc/subscriptions","organizations_url":"https://api.github.com/users/linc/orgs","repos_url":"https://api.github.com/users/linc/repos","events_url":"https://api.github.com/users/linc/events{/privacy}","received_events_url":"https://api.github.com/users/linc/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2018-06-27T17:56:58Z","updated_at":"2018-06-27T21:00:57Z","due_on":"2018-07-11T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/vanilla/addons/pulls/639/commits","review_comments_url":"https://api.github.com/repos/vanilla/addons/pulls/639/comments","review_comment_url":"https://api.github.com/repos/vanilla/addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vanilla/addons/issues/639/comments","statuses_url":"https://api.github.com/repos/vanilla/addons/statuses/72d373a561ce81fccdb150ef9f30eb088cbea064","head":{"label":"vanilla:fix/category-link-order","ref":"fix/category-link-order","sha":"72d373a561ce81fccdb150ef9f30eb088cbea064","user":{"login":"vanilla","id":7443552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDM1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7443552?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"repo":{"id":633372,"node_id":"MDEwOlJlcG9zaXRvcnk2MzMzNzI=","name":"addons","full_name":"vanilla/addons","owner":{"login":"vanilla","id":7443552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDM1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7443552?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vanilla/addons","description":"Official addons and tools for Vanilla Forums.","fork":false,"url":"https://api.github.com/repos/vanilla/addons","forks_url":"https://api.github.com/repos/vanilla/addons/forks","keys_url":"https://api.github.com/repos/vanilla/addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilla/addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilla/addons/teams","hooks_url":"https://api.github.com/repos/vanilla/addons/hooks","issue_events_url":"https://api.github.com/repos/vanilla/addons/issues/events{/number}","events_url":"https://api.github.com/repos/vanilla/addons/events","assignees_url":"https://api.github.com/repos/vanilla/addons/assignees{/user}","branches_url":"https://api.github.com/repos/vanilla/addons/branches{/branch}","tags_url":"https://api.github.com/repos/vanilla/addons/tags","blobs_url":"https://api.github.com/repos/vanilla/addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilla/addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilla/addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilla/addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilla/addons/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilla/addons/languages","stargazers_url":"https://api.github.com/repos/vanilla/addons/stargazers","contributors_url":"https://api.github.com/repos/vanilla/addons/contributors","subscribers_url":"https://api.github.com/repos/vanilla/addons/subscribers","subscription_url":"https://api.github.com/repos/vanilla/addons/subscription","commits_url":"https://api.github.com/repos/vanilla/addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilla/addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilla/addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilla/addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilla/addons/contents/{+path}","compare_url":"https://api.github.com/repos/vanilla/addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilla/addons/merges","archive_url":"https://api.github.com/repos/vanilla/addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilla/addons/downloads","issues_url":"https://api.github.com/repos/vanilla/addons/issues{/number}","pulls_url":"https://api.github.com/repos/vanilla/addons/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilla/addons/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilla/addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilla/addons/labels{/name}","releases_url":"https://api.github.com/repos/vanilla/addons/releases{/id}","deployments_url":"https://api.github.com/repos/vanilla/addons/deployments","created_at":"2010-04-28T14:04:03Z","updated_at":"2018-07-04T12:43:42Z","pushed_at":"2018-06-28T21:54:01Z","git_url":"git://github.com/vanilla/addons.git","ssh_url":"git@github.com:vanilla/addons.git","clone_url":"https://github.com/vanilla/addons.git","svn_url":"https://github.com/vanilla/addons","homepage":"http://open.vanillaforums.com","size":11696,"stargazers_count":98,"watchers_count":98,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":182,"mirror_url":null,"archived":false,"open_issues_count":61,"license":null,"forks":182,"open_issues":61,"watchers":98,"default_branch":"master"}},"base":{"label":"vanilla:master","ref":"master","sha":"563ae559016a1791a1b5788fd4d72b94c7dcfcf3","user":{"login":"vanilla","id":7443552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDM1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7443552?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"repo":{"id":633372,"node_id":"MDEwOlJlcG9zaXRvcnk2MzMzNzI=","name":"addons","full_name":"vanilla/addons","owner":{"login":"vanilla","id":7443552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDM1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7443552?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vanilla/addons","description":"Official addons and tools for Vanilla Forums.","fork":false,"url":"https://api.github.com/repos/vanilla/addons","forks_url":"https://api.github.com/repos/vanilla/addons/forks","keys_url":"https://api.github.com/repos/vanilla/addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilla/addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilla/addons/teams","hooks_url":"https://api.github.com/repos/vanilla/addons/hooks","issue_events_url":"https://api.github.com/repos/vanilla/addons/issues/events{/number}","events_url":"https://api.github.com/repos/vanilla/addons/events","assignees_url":"https://api.github.com/repos/vanilla/addons/assignees{/user}","branches_url":"https://api.github.com/repos/vanilla/addons/branches{/branch}","tags_url":"https://api.github.com/repos/vanilla/addons/tags","blobs_url":"https://api.github.com/repos/vanilla/addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilla/addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilla/addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilla/addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilla/addons/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilla/addons/languages","stargazers_url":"https://api.github.com/repos/vanilla/addons/stargazers","contributors_url":"https://api.github.com/repos/vanilla/addons/contributors","subscribers_url":"https://api.github.com/repos/vanilla/addons/subscribers","subscription_url":"https://api.github.com/repos/vanilla/addons/subscription","commits_url":"https://api.github.com/repos/vanilla/addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilla/addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilla/addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilla/addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilla/addons/contents/{+path}","compare_url":"https://api.github.com/repos/vanilla/addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilla/addons/merges","archive_url":"https://api.github.com/repos/vanilla/addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilla/addons/downloads","issues_url":"https://api.github.com/repos/vanilla/addons/issues{/number}","pulls_url":"https://api.github.com/repos/vanilla/addons/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilla/addons/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilla/addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilla/addons/labels{/name}","releases_url":"https://api.github.com/repos/vanilla/addons/releases{/id}","deployments_url":"https://api.github.com/repos/vanilla/addons/deployments","created_at":"2010-04-28T14:04:03Z","updated_at":"2018-07-04T12:43:42Z","pushed_at":"2018-06-28T21:54:01Z","git_url":"git://github.com/vanilla/addons.git","ssh_url":"git@github.com:vanilla/addons.git","clone_url":"https://github.com/vanilla/addons.git","svn_url":"https://github.com/vanilla/addons","homepage":"http://open.vanillaforums.com","size":11696,"stargazers_count":98,"watchers_count":98,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":182,"mirror_url":null,"archived":false,"open_issues_count":61,"license":null,"forks":182,"open_issues":61,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vanilla/addons/pulls/639"},"html":{"href":"https://github.com/vanilla/addons/pull/639"},"issue":{"href":"https://api.github.com/repos/vanilla/addons/issues/639"},"comments":{"href":"https://api.github.com/repos/vanilla/addons/issues/639/comments"},"review_comments":{"href":"https://api.github.com/repos/vanilla/addons/pulls/639/comments"},"review_comment":{"href":"https://api.github.com/repos/vanilla/addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vanilla/addons/pulls/639/commits"},"statuses":{"href":"https://api.github.com/repos/vanilla/addons/statuses/72d373a561ce81fccdb150ef9f30eb088cbea064"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"initvector"}}