{"action":"created","issue":{"url":"https://api.github.com/repos/CGAL/cgal/issues/3035","repository_url":"https://api.github.com/repos/CGAL/cgal","labels_url":"https://api.github.com/repos/CGAL/cgal/issues/3035/labels{/name}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/3035/comments","events_url":"https://api.github.com/repos/CGAL/cgal/issues/3035/events","html_url":"https://github.com/CGAL/cgal/issues/3035","id":316190985,"node_id":"MDU6SXNzdWUzMTYxOTA5ODU=","number":3035,"title":"Use (boost|std)::result_of instead of boost::tr1_result_of","user":{"login":"lrineau","id":5746675,"node_id":"MDQ6VXNlcjU3NDY2NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5746675?v=4","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"labels":[{"id":198056082,"node_id":"MDU6TGFiZWwxOTgwNTYwODI=","url":"https://api.github.com/repos/CGAL/cgal/labels/Modern%20C++%20(C++11%20and%20later)","name":"Modern C++ (C++11 and later)","color":"c7def8","default":false},{"id":197106750,"node_id":"MDU6TGFiZWwxOTcxMDY3NTA=","url":"https://api.github.com/repos/CGAL/cgal/labels/Pkg::Kernel_23","name":"Pkg::Kernel_23","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"afabri","id":3263539,"node_id":"MDQ6VXNlcjMyNjM1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3263539?v=4","gravatar_id":"","url":"https://api.github.com/users/afabri","html_url":"https://github.com/afabri","followers_url":"https://api.github.com/users/afabri/followers","following_url":"https://api.github.com/users/afabri/following{/other_user}","gists_url":"https://api.github.com/users/afabri/gists{/gist_id}","starred_url":"https://api.github.com/users/afabri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afabri/subscriptions","organizations_url":"https://api.github.com/users/afabri/orgs","repos_url":"https://api.github.com/users/afabri/repos","events_url":"https://api.github.com/users/afabri/events{/privacy}","received_events_url":"https://api.github.com/users/afabri/received_events","type":"User","site_admin":false},"assignees":[{"login":"afabri","id":3263539,"node_id":"MDQ6VXNlcjMyNjM1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3263539?v=4","gravatar_id":"","url":"https://api.github.com/users/afabri","html_url":"https://github.com/afabri","followers_url":"https://api.github.com/users/afabri/followers","following_url":"https://api.github.com/users/afabri/following{/other_user}","gists_url":"https://api.github.com/users/afabri/gists{/gist_id}","starred_url":"https://api.github.com/users/afabri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afabri/subscriptions","organizations_url":"https://api.github.com/users/afabri/orgs","repos_url":"https://api.github.com/users/afabri/repos","events_url":"https://api.github.com/users/afabri/events{/privacy}","received_events_url":"https://api.github.com/users/afabri/received_events","type":"User","site_admin":false},{"login":"lrineau","id":5746675,"node_id":"MDQ6VXNlcjU3NDY2NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5746675?v=4","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/CGAL/cgal/milestones/34","html_url":"https://github.com/CGAL/cgal/milestone/34","labels_url":"https://api.github.com/repos/CGAL/cgal/milestones/34/labels","id":3414796,"node_id":"MDk6TWlsZXN0b25lMzQxNDc5Ng==","number":34,"title":"4.14-beta","description":"https://cgal.geometryfactory.com/CGAL/Members/wiki/Releases/4.14","creator":{"login":"lrineau","id":5746675,"node_id":"MDQ6VXNlcjU3NDY2NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5746675?v=4","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"open_issues":88,"closed_issues":12,"state":"open","created_at":"2018-06-11T08:36:14Z","updated_at":"2018-10-10T08:46:23Z","due_on":"2019-02-20T08:00:00Z","closed_at":null},"comments":8,"created_at":"2018-04-20T09:17:07Z","updated_at":"2018-10-10T09:14:09Z","closed_at":null,"author_association":"MEMBER","body":"## Issue Details\r\n\r\nIn CGAL, (current version `master` aka CGAL-4.12-beta2), `CGAL::cpp11::result_of` uses `boost::tr1_result_of`:\r\n\r\nhttps://github.com/CGAL/cgal/blob/66d8d5a8463c5a4481590b4ba89330148324a3d1/STL_Extension/include/CGAL/result_of.h#L41-L51\r\n\r\nThe conditionals deal with the fact that `boost::result_of` was implementing the TR1 semantic before 1.44, and from 1.44 the TR1 implementation was renamed `boost::tr1_result_of`.\r\n\r\nWith Andreas (@afabri) we tried (with MSVC 2017 (15.6) and `/std:c++latest` aka C++20) to use `std::result_of` directly, but that created compilation errors in the Kernel_23 testsuite, the first one being related to `K::Construct_x_3(Weighted_point_3)`.\r\n\r\nThat is something to be investigated for CGAL-4.13.\r\n\r\nCc @mglisse @bo0ts\r\n"},"comment":{"url":"https://api.github.com/repos/CGAL/cgal/issues/comments/428498554","html_url":"https://github.com/CGAL/cgal/issues/3035#issuecomment-428498554","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/3035","id":428498554,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODQ5ODU1NA==","user":{"login":"mglisse","id":10097863,"node_id":"MDQ6VXNlcjEwMDk3ODYz","avatar_url":"https://avatars3.githubusercontent.com/u/10097863?v=4","gravatar_id":"","url":"https://api.github.com/users/mglisse","html_url":"https://github.com/mglisse","followers_url":"https://api.github.com/users/mglisse/followers","following_url":"https://api.github.com/users/mglisse/following{/other_user}","gists_url":"https://api.github.com/users/mglisse/gists{/gist_id}","starred_url":"https://api.github.com/users/mglisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mglisse/subscriptions","organizations_url":"https://api.github.com/users/mglisse/orgs","repos_url":"https://api.github.com/users/mglisse/repos","events_url":"https://api.github.com/users/mglisse/events{/privacy}","received_events_url":"https://api.github.com/users/mglisse/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T09:14:09Z","updated_at":"2018-10-10T09:14:09Z","author_association":"CONTRIBUTOR","body":"`struct result_of : public std::result_of<F>{};` I had used `using std::result_of;` instead, but that's indeed what I experimented with. And on a simple example `decltype(auto)` fixed things. Do you have a particular testcase I should look at?"}}
{"actor":{"display_login":"mglisse"}}