{"action":"created","comment":{"url":"https://api.github.com/repos/w0rp/ale/pulls/comments/205222242","pull_request_review_id":140450253,"id":205222242,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTIyMjI0Mg==","diff_hunk":"@@ -0,0 +1,28 @@\n+Before:\n+  runtime ale_linters/python/vulture.vim\n+\n+After:\n+  Restore\n+\n+  call ale#linter#Reset()\n+\n+  silent file something_else.py\n+\n+Execute(Basic vulture check should be handled):\n+  call ale#test#SetFilename('something_else.py')\n+  AssertEqual\n+  \\ [\n+  \\   {\n+  \\     'lnum': 34,\n+  \\     'text': \"unused variable 'foo' (60% confidence)\",\n+  \\     'type': 'W',\n+  \\   },\n+  \\ ],\n+  \\ ale_linters#python#vulture#Handle(bufnr(''), [\n+  \\   \"/testplugin/test/handler/something_else.py:34: unused variable 'foo' (60% confidence)\",","path":"test/handler/test_vulture_handler.vader","position":22,"original_position":22,"commit_id":"349c37dc8879cb49fedf2ad28fe735e6269ade20","original_commit_id":"349c37dc8879cb49fedf2ad28fe735e6269ade20","user":{"login":"w0rp","id":3518142,"node_id":"MDQ6VXNlcjM1MTgxNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3518142?v=4","gravatar_id":"","url":"https://api.github.com/users/w0rp","html_url":"https://github.com/w0rp","followers_url":"https://api.github.com/users/w0rp/followers","following_url":"https://api.github.com/users/w0rp/following{/other_user}","gists_url":"https://api.github.com/users/w0rp/gists{/gist_id}","starred_url":"https://api.github.com/users/w0rp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0rp/subscriptions","organizations_url":"https://api.github.com/users/w0rp/orgs","repos_url":"https://api.github.com/users/w0rp/repos","events_url":"https://api.github.com/users/w0rp/events{/privacy}","received_events_url":"https://api.github.com/users/w0rp/received_events","type":"User","site_admin":false},"body":"Look at existing tests for uses of `SetDirectory`, `RestoreDirectory`, and `SetFilename`. They will set up paths so an filenames so they work inside and outside of the Docker app. Use the `g:dir` variable and `ale#path#Simplify` so the paths work on both Linux and Windows.","created_at":"2018-07-25T18:46:04Z","updated_at":"2018-07-25T18:46:05Z","html_url":"https://github.com/w0rp/ale/pull/1756#discussion_r205222242","pull_request_url":"https://api.github.com/repos/w0rp/ale/pulls/1756","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/w0rp/ale/pulls/comments/205222242"},"html":{"href":"https://github.com/w0rp/ale/pull/1756#discussion_r205222242"},"pull_request":{"href":"https://api.github.com/repos/w0rp/ale/pulls/1756"}},"in_reply_to_id":204902829},"pull_request":{"url":"https://api.github.com/repos/w0rp/ale/pulls/1756","id":203623533,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjIzNTMz","html_url":"https://github.com/w0rp/ale/pull/1756","diff_url":"https://github.com/w0rp/ale/pull/1756.diff","patch_url":"https://github.com/w0rp/ale/pull/1756.patch","issue_url":"https://api.github.com/repos/w0rp/ale/issues/1756","number":1756,"state":"open","locked":false,"title":"feat(linters: python): add vulture; fixes #1729","user":{"login":"actionless","id":1655669,"node_id":"MDQ6VXNlcjE2NTU2Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1655669?v=4","gravatar_id":"","url":"https://api.github.com/users/actionless","html_url":"https://github.com/actionless","followers_url":"https://api.github.com/users/actionless/followers","following_url":"https://api.github.com/users/actionless/following{/other_user}","gists_url":"https://api.github.com/users/actionless/gists{/gist_id}","starred_url":"https://api.github.com/users/actionless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actionless/subscriptions","organizations_url":"https://api.github.com/users/actionless/orgs","repos_url":"https://api.github.com/users/actionless/repos","events_url":"https://api.github.com/users/actionless/events{/privacy}","received_events_url":"https://api.github.com/users/actionless/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2018-07-24T18:59:58Z","updated_at":"2018-07-25T18:46:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4737c657d0fa3725018b7dd0627fc2889bb2090f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w0rp/ale/pulls/1756/commits","review_comments_url":"https://api.github.com/repos/w0rp/ale/pulls/1756/comments","review_comment_url":"https://api.github.com/repos/w0rp/ale/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w0rp/ale/issues/1756/comments","statuses_url":"https://api.github.com/repos/w0rp/ale/statuses/349c37dc8879cb49fedf2ad28fe735e6269ade20","head":{"label":"actionless:add-python-vulture","ref":"add-python-vulture","sha":"349c37dc8879cb49fedf2ad28fe735e6269ade20","user":{"login":"actionless","id":1655669,"node_id":"MDQ6VXNlcjE2NTU2Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1655669?v=4","gravatar_id":"","url":"https://api.github.com/users/actionless","html_url":"https://github.com/actionless","followers_url":"https://api.github.com/users/actionless/followers","following_url":"https://api.github.com/users/actionless/following{/other_user}","gists_url":"https://api.github.com/users/actionless/gists{/gist_id}","starred_url":"https://api.github.com/users/actionless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actionless/subscriptions","organizations_url":"https://api.github.com/users/actionless/orgs","repos_url":"https://api.github.com/users/actionless/repos","events_url":"https://api.github.com/users/actionless/events{/privacy}","received_events_url":"https://api.github.com/users/actionless/received_events","type":"User","site_admin":false},"repo":{"id":142194153,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxOTQxNTM=","name":"ale","full_name":"actionless/ale","owner":{"login":"actionless","id":1655669,"node_id":"MDQ6VXNlcjE2NTU2Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1655669?v=4","gravatar_id":"","url":"https://api.github.com/users/actionless","html_url":"https://github.com/actionless","followers_url":"https://api.github.com/users/actionless/followers","following_url":"https://api.github.com/users/actionless/following{/other_user}","gists_url":"https://api.github.com/users/actionless/gists{/gist_id}","starred_url":"https://api.github.com/users/actionless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actionless/subscriptions","organizations_url":"https://api.github.com/users/actionless/orgs","repos_url":"https://api.github.com/users/actionless/repos","events_url":"https://api.github.com/users/actionless/events{/privacy}","received_events_url":"https://api.github.com/users/actionless/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/actionless/ale","description":"Asynchronous Lint Engine","fork":true,"url":"https://api.github.com/repos/actionless/ale","forks_url":"https://api.github.com/repos/actionless/ale/forks","keys_url":"https://api.github.com/repos/actionless/ale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/actionless/ale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/actionless/ale/teams","hooks_url":"https://api.github.com/repos/actionless/ale/hooks","issue_events_url":"https://api.github.com/repos/actionless/ale/issues/events{/number}","events_url":"https://api.github.com/repos/actionless/ale/events","assignees_url":"https://api.github.com/repos/actionless/ale/assignees{/user}","branches_url":"https://api.github.com/repos/actionless/ale/branches{/branch}","tags_url":"https://api.github.com/repos/actionless/ale/tags","blobs_url":"https://api.github.com/repos/actionless/ale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/actionless/ale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/actionless/ale/git/refs{/sha}","trees_url":"https://api.github.com/repos/actionless/ale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/actionless/ale/statuses/{sha}","languages_url":"https://api.github.com/repos/actionless/ale/languages","stargazers_url":"https://api.github.com/repos/actionless/ale/stargazers","contributors_url":"https://api.github.com/repos/actionless/ale/contributors","subscribers_url":"https://api.github.com/repos/actionless/ale/subscribers","subscription_url":"https://api.github.com/repos/actionless/ale/subscription","commits_url":"https://api.github.com/repos/actionless/ale/commits{/sha}","git_commits_url":"https://api.github.com/repos/actionless/ale/git/commits{/sha}","comments_url":"https://api.github.com/repos/actionless/ale/comments{/number}","issue_comment_url":"https://api.github.com/repos/actionless/ale/issues/comments{/number}","contents_url":"https://api.github.com/repos/actionless/ale/contents/{+path}","compare_url":"https://api.github.com/repos/actionless/ale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/actionless/ale/merges","archive_url":"https://api.github.com/repos/actionless/ale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/actionless/ale/downloads","issues_url":"https://api.github.com/repos/actionless/ale/issues{/number}","pulls_url":"https://api.github.com/repos/actionless/ale/pulls{/number}","milestones_url":"https://api.github.com/repos/actionless/ale/milestones{/number}","notifications_url":"https://api.github.com/repos/actionless/ale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/actionless/ale/labels{/name}","releases_url":"https://api.github.com/repos/actionless/ale/releases{/id}","deployments_url":"https://api.github.com/repos/actionless/ale/deployments","created_at":"2018-07-24T17:53:44Z","updated_at":"2018-07-24T17:53:47Z","pushed_at":"2018-07-24T20:33:23Z","git_url":"git://github.com/actionless/ale.git","ssh_url":"git@github.com:actionless/ale.git","clone_url":"https://github.com/actionless/ale.git","svn_url":"https://github.com/actionless/ale","homepage":null,"size":12595,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w0rp:master","ref":"master","sha":"341857477011f703664b31d8d76f6872f8399c66","user":{"login":"w0rp","id":3518142,"node_id":"MDQ6VXNlcjM1MTgxNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3518142?v=4","gravatar_id":"","url":"https://api.github.com/users/w0rp","html_url":"https://github.com/w0rp","followers_url":"https://api.github.com/users/w0rp/followers","following_url":"https://api.github.com/users/w0rp/following{/other_user}","gists_url":"https://api.github.com/users/w0rp/gists{/gist_id}","starred_url":"https://api.github.com/users/w0rp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0rp/subscriptions","organizations_url":"https://api.github.com/users/w0rp/orgs","repos_url":"https://api.github.com/users/w0rp/repos","events_url":"https://api.github.com/users/w0rp/events{/privacy}","received_events_url":"https://api.github.com/users/w0rp/received_events","type":"User","site_admin":false},"repo":{"id":67747748,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzc0Nzc0OA==","name":"ale","full_name":"w0rp/ale","owner":{"login":"w0rp","id":3518142,"node_id":"MDQ6VXNlcjM1MTgxNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3518142?v=4","gravatar_id":"","url":"https://api.github.com/users/w0rp","html_url":"https://github.com/w0rp","followers_url":"https://api.github.com/users/w0rp/followers","following_url":"https://api.github.com/users/w0rp/following{/other_user}","gists_url":"https://api.github.com/users/w0rp/gists{/gist_id}","starred_url":"https://api.github.com/users/w0rp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0rp/subscriptions","organizations_url":"https://api.github.com/users/w0rp/orgs","repos_url":"https://api.github.com/users/w0rp/repos","events_url":"https://api.github.com/users/w0rp/events{/privacy}","received_events_url":"https://api.github.com/users/w0rp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/w0rp/ale","description":"Asynchronous Lint Engine","fork":false,"url":"https://api.github.com/repos/w0rp/ale","forks_url":"https://api.github.com/repos/w0rp/ale/forks","keys_url":"https://api.github.com/repos/w0rp/ale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w0rp/ale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w0rp/ale/teams","hooks_url":"https://api.github.com/repos/w0rp/ale/hooks","issue_events_url":"https://api.github.com/repos/w0rp/ale/issues/events{/number}","events_url":"https://api.github.com/repos/w0rp/ale/events","assignees_url":"https://api.github.com/repos/w0rp/ale/assignees{/user}","branches_url":"https://api.github.com/repos/w0rp/ale/branches{/branch}","tags_url":"https://api.github.com/repos/w0rp/ale/tags","blobs_url":"https://api.github.com/repos/w0rp/ale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w0rp/ale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w0rp/ale/git/refs{/sha}","trees_url":"https://api.github.com/repos/w0rp/ale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w0rp/ale/statuses/{sha}","languages_url":"https://api.github.com/repos/w0rp/ale/languages","stargazers_url":"https://api.github.com/repos/w0rp/ale/stargazers","contributors_url":"https://api.github.com/repos/w0rp/ale/contributors","subscribers_url":"https://api.github.com/repos/w0rp/ale/subscribers","subscription_url":"https://api.github.com/repos/w0rp/ale/subscription","commits_url":"https://api.github.com/repos/w0rp/ale/commits{/sha}","git_commits_url":"https://api.github.com/repos/w0rp/ale/git/commits{/sha}","comments_url":"https://api.github.com/repos/w0rp/ale/comments{/number}","issue_comment_url":"https://api.github.com/repos/w0rp/ale/issues/comments{/number}","contents_url":"https://api.github.com/repos/w0rp/ale/contents/{+path}","compare_url":"https://api.github.com/repos/w0rp/ale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w0rp/ale/merges","archive_url":"https://api.github.com/repos/w0rp/ale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w0rp/ale/downloads","issues_url":"https://api.github.com/repos/w0rp/ale/issues{/number}","pulls_url":"https://api.github.com/repos/w0rp/ale/pulls{/number}","milestones_url":"https://api.github.com/repos/w0rp/ale/milestones{/number}","notifications_url":"https://api.github.com/repos/w0rp/ale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w0rp/ale/labels{/name}","releases_url":"https://api.github.com/repos/w0rp/ale/releases{/id}","deployments_url":"https://api.github.com/repos/w0rp/ale/deployments","created_at":"2016-09-08T23:22:45Z","updated_at":"2018-07-25T18:43:33Z","pushed_at":"2018-07-25T18:43:29Z","git_url":"git://github.com/w0rp/ale.git","ssh_url":"git@github.com:w0rp/ale.git","clone_url":"https://github.com/w0rp/ale.git","svn_url":"https://github.com/w0rp/ale","homepage":null,"size":12603,"stargazers_count":5435,"watchers_count":5435,"language":"Vim script","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":544,"mirror_url":null,"archived":false,"open_issues_count":204,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":544,"open_issues":204,"watchers":5435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w0rp/ale/pulls/1756"},"html":{"href":"https://github.com/w0rp/ale/pull/1756"},"issue":{"href":"https://api.github.com/repos/w0rp/ale/issues/1756"},"comments":{"href":"https://api.github.com/repos/w0rp/ale/issues/1756/comments"},"review_comments":{"href":"https://api.github.com/repos/w0rp/ale/pulls/1756/comments"},"review_comment":{"href":"https://api.github.com/repos/w0rp/ale/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w0rp/ale/pulls/1756/commits"},"statuses":{"href":"https://api.github.com/repos/w0rp/ale/statuses/349c37dc8879cb49fedf2ad28fe735e6269ade20"}},"author_association":"NONE"}}
{"actor":{"display_login":"w0rp"}}