{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/58131","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/58131/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/58131/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/58131/events","html_url":"https://github.com/Microsoft/vscode/issues/58131","id":357875547,"node_id":"MDU6SXNzdWUzNTc4NzU1NDc=","number":58131,"title":"removeFromRecentlyOpened Command Broken","user":{"login":"daytonellwanger","id":6383490,"node_id":"MDQ6VXNlcjYzODM0OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6383490?v=4","gravatar_id":"","url":"https://api.github.com/users/daytonellwanger","html_url":"https://github.com/daytonellwanger","followers_url":"https://api.github.com/users/daytonellwanger/followers","following_url":"https://api.github.com/users/daytonellwanger/following{/other_user}","gists_url":"https://api.github.com/users/daytonellwanger/gists{/gist_id}","starred_url":"https://api.github.com/users/daytonellwanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daytonellwanger/subscriptions","organizations_url":"https://api.github.com/users/daytonellwanger/orgs","repos_url":"https://api.github.com/users/daytonellwanger/repos","events_url":"https://api.github.com/users/daytonellwanger/events{/privacy}","received_events_url":"https://api.github.com/users/daytonellwanger/received_events","type":"User","site_admin":false},"labels":[{"id":256129993,"node_id":"MDU6TGFiZWwyNTYxMjk5OTM=","url":"https://api.github.com/repos/Microsoft/vscode/labels/bug","name":"bug","color":"8D6673","default":true},{"id":344002046,"node_id":"MDU6TGFiZWwzNDQwMDIwNDY=","url":"https://api.github.com/repos/Microsoft/vscode/labels/candidate","name":"candidate","color":"fbca04","default":false},{"id":1037423629,"node_id":"MDU6TGFiZWwxMDM3NDIzNjI5","url":"https://api.github.com/repos/Microsoft/vscode/labels/insiders","name":"insiders","color":"006b75","default":false},{"id":291057332,"node_id":"MDU6TGFiZWwyOTEwNTczMzI=","url":"https://api.github.com/repos/Microsoft/vscode/labels/verified","name":"verified","color":"009800","default":false}],"state":"closed","locked":false,"assignee":{"login":"aeschli","id":6461412,"node_id":"MDQ6VXNlcjY0NjE0MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6461412?v=4","gravatar_id":"","url":"https://api.github.com/users/aeschli","html_url":"https://github.com/aeschli","followers_url":"https://api.github.com/users/aeschli/followers","following_url":"https://api.github.com/users/aeschli/following{/other_user}","gists_url":"https://api.github.com/users/aeschli/gists{/gist_id}","starred_url":"https://api.github.com/users/aeschli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeschli/subscriptions","organizations_url":"https://api.github.com/users/aeschli/orgs","repos_url":"https://api.github.com/users/aeschli/repos","events_url":"https://api.github.com/users/aeschli/events{/privacy}","received_events_url":"https://api.github.com/users/aeschli/received_events","type":"User","site_admin":false},"assignees":[{"login":"aeschli","id":6461412,"node_id":"MDQ6VXNlcjY0NjE0MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6461412?v=4","gravatar_id":"","url":"https://api.github.com/users/aeschli","html_url":"https://github.com/aeschli","followers_url":"https://api.github.com/users/aeschli/followers","following_url":"https://api.github.com/users/aeschli/following{/other_user}","gists_url":"https://api.github.com/users/aeschli/gists{/gist_id}","starred_url":"https://api.github.com/users/aeschli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeschli/subscriptions","organizations_url":"https://api.github.com/users/aeschli/orgs","repos_url":"https://api.github.com/users/aeschli/repos","events_url":"https://api.github.com/users/aeschli/events{/privacy}","received_events_url":"https://api.github.com/users/aeschli/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/77","html_url":"https://github.com/Microsoft/vscode/milestone/77","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/77/labels","id":3626557,"node_id":"MDk6TWlsZXN0b25lMzYyNjU1Nw==","number":77,"title":"August Recovery 2018","description":"","creator":{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":8,"state":"closed","created_at":"2018-09-05T20:22:48Z","updated_at":"2018-09-14T11:52:20Z","due_on":null,"closed_at":"2018-09-14T06:37:31Z"},"comments":5,"created_at":"2018-09-07T00:20:46Z","updated_at":"2018-09-17T19:01:06Z","closed_at":"2018-09-11T13:54:48Z","author_association":"NONE","body":"VSCode Version: 1.27.1-Insiders\r\nOS Version: Win10\r\n\r\nSteps to Reproduce:\r\n\r\n1. Create an extension that uses the `removeFromRecentlyOpened` command (e.g. `vscode.commands.executeCommand('vscode.removeFromRecentlyOpened', 'somePath')`)\r\n2. Run the extension\r\n\r\nEXPECTED:\r\nPath is removed from list of recently opened files.\r\n\r\nACTUAL:\r\nCommand fails with `[UriError]: Scheme contains illegal characters`.\r\n\r\nThe stack shows the error is coming from electron:\r\n```\r\nError: [UriError]: Scheme contains illegal characters.\"\r\n1:\"    at C:\\Program Files\\Microsoft VS Code Insiders\\resources\\app\\out\\vs\\code\\electron-main\\main.js:59:35\"\r\n2:\"    at t.e (C:\\Program Files\\Microsoft VS Code Insiders\\resources\\app\\out\\vs\\code\\electron-main\\main.js:59:461)\"\r\n3:\"    at new t (C:\\Program Files\\Microsoft VS Code Insiders\\resources\\app\\out\\vs\\code\\electron-main\\main.js:60:990)\"\r\n4:\"    at Function.e.revive (C:\\Program Files\\Microsoft VS Code Insiders\\resources\\app\\out\\vs\\code\\electron-main\\main.js:60:845)\"\r\n5:\"    at C:\\Program Files\\Microsoft VS Code Insiders\\resources\\app\\out\\vs\\code\\electron-main\\main.js:353:512\"\r\n6:\"    at Array.map (<anonymous>)\"\r\n7:\"    at e.call (C:\\Program Files\\Microsoft VS Code Insiders\\resources\\app\\out\\vs\\code\\electron-main\\main.js:353:450)\"\r\n8:\"    at e.onPromise (C:\\Program Files\\Microsoft VS Code Insiders\\resources\\app\\out\\vs\\code\\electron-main\\main.js:162:803)\"\r\n9:\"    at e.onRequest (C:\\Program Files\\Microsoft VS Code Insiders\\resources\\app\\out\\vs\\code\\electron-main\\main.js:163:968)\"\r\n10:\"    at e.onRawMessage (C:\\Program Files\\Microsoft VS Code Insiders\\resources\\app\\out\\vs\\code\\electron-main\\main.js:163:885)\"\r\n```\r\n\r\nMore info:\r\nI've tried passing in strings that have the path formatted in various ways, and am pretty confident they are valid URIs. Additionally, this is a regression. I can run the same extension, use the same argument to the command, on VS Code 1.26.1 (Stable) and have the expected result.\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/422131883","html_url":"https://github.com/Microsoft/vscode/issues/58131#issuecomment-422131883","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/58131","id":422131883,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjEzMTg4Mw==","user":{"login":"daytonellwanger","id":6383490,"node_id":"MDQ6VXNlcjYzODM0OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6383490?v=4","gravatar_id":"","url":"https://api.github.com/users/daytonellwanger","html_url":"https://github.com/daytonellwanger","followers_url":"https://api.github.com/users/daytonellwanger/followers","following_url":"https://api.github.com/users/daytonellwanger/following{/other_user}","gists_url":"https://api.github.com/users/daytonellwanger/gists{/gist_id}","starred_url":"https://api.github.com/users/daytonellwanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daytonellwanger/subscriptions","organizations_url":"https://api.github.com/users/daytonellwanger/orgs","repos_url":"https://api.github.com/users/daytonellwanger/repos","events_url":"https://api.github.com/users/daytonellwanger/events{/privacy}","received_events_url":"https://api.github.com/users/daytonellwanger/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T19:01:06Z","updated_at":"2018-09-17T19:01:06Z","author_association":"NONE","body":"I just tested this with today's build \r\n(Version: 1.28.0-insider (system setup)\r\nCommit: 7fcd81cd0f88bb2040f249b09cf6bdd83d9ea2ef\r\nDate: 2018-09-17T09:37:55.086Z\r\nElectron: 2.0.9\r\nChrome: 61.0.3163.100\r\nNode.js: 8.9.3\r\nV8: 6.1.534.41\r\nArchitecture: x64)\r\nand am still seeing this issue.\r\nHere's the path I was passing as the argument: `C:\\Users\\daellwan\\AppData\\Local\\Temp\\tmp-4CFE9B9A2EED67B43699F7C3340FDD091F7E\\Visual Studio Live Share.code-workspace`"}}
{"actor":{"display_login":"daytonellwanger"}}