{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/194199709","pull_request_review_id":127336478,"id":194199709,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDE5OTcwOQ==","diff_hunk":"@@ -281,15 +281,51 @@ public HiveTableHandle getTableHandle(ConnectorSession session, SchemaTableName\n     @Override\n     public Optional<SystemTable> getSystemTable(ConnectorSession session, SchemaTableName tableName)\n     {\n-        if (isPartitionsSystemTable(tableName)) {\n-            return getPartitionsSystemTable(session, tableName);\n+        if (partitionsTableHandler.matches(tableName)) {\n+            return getPartitionsSystemTable(session, tableName, partitionsTableHandler.getSourceTableName(tableName));\n+        }\n+        else if (propertiesTableHandler.matches(tableName)) {","path":"presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java","position":45,"original_position":45,"commit_id":"e691cea4f0cc8af6e69322641a9cc4b6b83fc139","original_commit_id":"e691cea4f0cc8af6e69322641a9cc4b6b83fc139","user":{"login":"electrum","id":9230,"node_id":"MDQ6VXNlcjkyMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/9230?v=4","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"body":"Nit: the `else` is redundant since the `if` block above returns unconditionally","created_at":"2018-06-08T23:01:52Z","updated_at":"2018-06-08T23:19:13Z","html_url":"https://github.com/prestodb/presto/pull/10793#discussion_r194199709","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/10793","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/194199709"},"html":{"href":"https://github.com/prestodb/presto/pull/10793#discussion_r194199709"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10793"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/10793","id":193688214,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjg4MjE0","html_url":"https://github.com/prestodb/presto/pull/10793","diff_url":"https://github.com/prestodb/presto/pull/10793.diff","patch_url":"https://github.com/prestodb/presto/pull/10793.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/10793","number":10793,"state":"open","locked":false,"title":"support properties system table","user":{"login":"qqibrow","id":441984,"node_id":"MDQ6VXNlcjQ0MTk4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/441984?v=4","gravatar_id":"","url":"https://api.github.com/users/qqibrow","html_url":"https://github.com/qqibrow","followers_url":"https://api.github.com/users/qqibrow/followers","following_url":"https://api.github.com/users/qqibrow/following{/other_user}","gists_url":"https://api.github.com/users/qqibrow/gists{/gist_id}","starred_url":"https://api.github.com/users/qqibrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qqibrow/subscriptions","organizations_url":"https://api.github.com/users/qqibrow/orgs","repos_url":"https://api.github.com/users/qqibrow/repos","events_url":"https://api.github.com/users/qqibrow/events{/privacy}","received_events_url":"https://api.github.com/users/qqibrow/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-08T18:19:21Z","updated_at":"2018-06-08T23:19:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9daf538747566cbd1a1b850937cab6a6e0aacba7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/10793/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/10793/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/10793/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/e691cea4f0cc8af6e69322641a9cc4b6b83fc139","head":{"label":"qqibrow:show_table_properties","ref":"show_table_properties","sha":"e691cea4f0cc8af6e69322641a9cc4b6b83fc139","user":{"login":"qqibrow","id":441984,"node_id":"MDQ6VXNlcjQ0MTk4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/441984?v=4","gravatar_id":"","url":"https://api.github.com/users/qqibrow","html_url":"https://github.com/qqibrow","followers_url":"https://api.github.com/users/qqibrow/followers","following_url":"https://api.github.com/users/qqibrow/following{/other_user}","gists_url":"https://api.github.com/users/qqibrow/gists{/gist_id}","starred_url":"https://api.github.com/users/qqibrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qqibrow/subscriptions","organizations_url":"https://api.github.com/users/qqibrow/orgs","repos_url":"https://api.github.com/users/qqibrow/repos","events_url":"https://api.github.com/users/qqibrow/events{/privacy}","received_events_url":"https://api.github.com/users/qqibrow/received_events","type":"User","site_admin":false},"repo":{"id":113931727,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5MzE3Mjc=","name":"presto","full_name":"qqibrow/presto","owner":{"login":"qqibrow","id":441984,"node_id":"MDQ6VXNlcjQ0MTk4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/441984?v=4","gravatar_id":"","url":"https://api.github.com/users/qqibrow","html_url":"https://github.com/qqibrow","followers_url":"https://api.github.com/users/qqibrow/followers","following_url":"https://api.github.com/users/qqibrow/following{/other_user}","gists_url":"https://api.github.com/users/qqibrow/gists{/gist_id}","starred_url":"https://api.github.com/users/qqibrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qqibrow/subscriptions","organizations_url":"https://api.github.com/users/qqibrow/orgs","repos_url":"https://api.github.com/users/qqibrow/repos","events_url":"https://api.github.com/users/qqibrow/events{/privacy}","received_events_url":"https://api.github.com/users/qqibrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qqibrow/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/qqibrow/presto","forks_url":"https://api.github.com/repos/qqibrow/presto/forks","keys_url":"https://api.github.com/repos/qqibrow/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qqibrow/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qqibrow/presto/teams","hooks_url":"https://api.github.com/repos/qqibrow/presto/hooks","issue_events_url":"https://api.github.com/repos/qqibrow/presto/issues/events{/number}","events_url":"https://api.github.com/repos/qqibrow/presto/events","assignees_url":"https://api.github.com/repos/qqibrow/presto/assignees{/user}","branches_url":"https://api.github.com/repos/qqibrow/presto/branches{/branch}","tags_url":"https://api.github.com/repos/qqibrow/presto/tags","blobs_url":"https://api.github.com/repos/qqibrow/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qqibrow/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qqibrow/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/qqibrow/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qqibrow/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/qqibrow/presto/languages","stargazers_url":"https://api.github.com/repos/qqibrow/presto/stargazers","contributors_url":"https://api.github.com/repos/qqibrow/presto/contributors","subscribers_url":"https://api.github.com/repos/qqibrow/presto/subscribers","subscription_url":"https://api.github.com/repos/qqibrow/presto/subscription","commits_url":"https://api.github.com/repos/qqibrow/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/qqibrow/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/qqibrow/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/qqibrow/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/qqibrow/presto/contents/{+path}","compare_url":"https://api.github.com/repos/qqibrow/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qqibrow/presto/merges","archive_url":"https://api.github.com/repos/qqibrow/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qqibrow/presto/downloads","issues_url":"https://api.github.com/repos/qqibrow/presto/issues{/number}","pulls_url":"https://api.github.com/repos/qqibrow/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/qqibrow/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/qqibrow/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qqibrow/presto/labels{/name}","releases_url":"https://api.github.com/repos/qqibrow/presto/releases{/id}","deployments_url":"https://api.github.com/repos/qqibrow/presto/deployments","created_at":"2017-12-12T02:13:24Z","updated_at":"2017-12-12T02:13:42Z","pushed_at":"2018-06-08T18:16:42Z","git_url":"git://github.com/qqibrow/presto.git","ssh_url":"git@github.com:qqibrow/presto.git","clone_url":"https://github.com/qqibrow/presto.git","svn_url":"https://github.com/qqibrow/presto","homepage":"https://prestodb.io","size":92073,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"bf503fad642af7caa55336d17c3d3e08c43fb88a","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-06-08T21:36:45Z","pushed_at":"2018-06-08T22:00:01Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":92301,"stargazers_count":7613,"watchers_count":7613,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2560,"mirror_url":null,"archived":false,"open_issues_count":1296,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2560,"open_issues":1296,"watchers":7613,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10793"},"html":{"href":"https://github.com/prestodb/presto/pull/10793"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/10793"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/10793/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10793/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10793/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/e691cea4f0cc8af6e69322641a9cc4b6b83fc139"}},"author_association":"NONE"}}
{"actor":{"display_login":"electrum"}}