{"action":"created","issue":{"url":"https://api.github.com/repos/leon-do/Bitcoin-HTLC-Wallet/issues/1","repository_url":"https://api.github.com/repos/leon-do/Bitcoin-HTLC-Wallet","labels_url":"https://api.github.com/repos/leon-do/Bitcoin-HTLC-Wallet/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/leon-do/Bitcoin-HTLC-Wallet/issues/1/comments","events_url":"https://api.github.com/repos/leon-do/Bitcoin-HTLC-Wallet/issues/1/events","html_url":"https://github.com/leon-do/Bitcoin-HTLC-Wallet/issues/1","id":322304760,"number":1,"title":"Timelock is hard coded","user":{"login":"lerennardleonard","id":36234105,"avatar_url":"https://avatars1.githubusercontent.com/u/36234105?v=4","gravatar_id":"","url":"https://api.github.com/users/lerennardleonard","html_url":"https://github.com/lerennardleonard","followers_url":"https://api.github.com/users/lerennardleonard/followers","following_url":"https://api.github.com/users/lerennardleonard/following{/other_user}","gists_url":"https://api.github.com/users/lerennardleonard/gists{/gist_id}","starred_url":"https://api.github.com/users/lerennardleonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lerennardleonard/subscriptions","organizations_url":"https://api.github.com/users/lerennardleonard/orgs","repos_url":"https://api.github.com/users/lerennardleonard/repos","events_url":"https://api.github.com/users/lerennardleonard/events{/privacy}","received_events_url":"https://api.github.com/users/lerennardleonard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-11T13:51:37Z","updated_at":"2018-05-11T15:03:09Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\nI think the timelock input actually does nothing since the time is hard coded in the script creation.\r\n`.add(bitcore.crypto.BN.fromNumber(1513412288).toScriptNumBuffer())`\r\n\r\nShould'nt it be : \r\n`.add(bitcore.crypto.BN.fromNumber(timeLock).toScriptNumBuffer())`\r\nSince you got timelock from the DOM ?"},"comment":{"url":"https://api.github.com/repos/leon-do/Bitcoin-HTLC-Wallet/issues/comments/388390690","html_url":"https://github.com/leon-do/Bitcoin-HTLC-Wallet/issues/1#issuecomment-388390690","issue_url":"https://api.github.com/repos/leon-do/Bitcoin-HTLC-Wallet/issues/1","id":388390690,"user":{"login":"leon-do","id":19412160,"avatar_url":"https://avatars3.githubusercontent.com/u/19412160?v=4","gravatar_id":"","url":"https://api.github.com/users/leon-do","html_url":"https://github.com/leon-do","followers_url":"https://api.github.com/users/leon-do/followers","following_url":"https://api.github.com/users/leon-do/following{/other_user}","gists_url":"https://api.github.com/users/leon-do/gists{/gist_id}","starred_url":"https://api.github.com/users/leon-do/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leon-do/subscriptions","organizations_url":"https://api.github.com/users/leon-do/orgs","repos_url":"https://api.github.com/users/leon-do/repos","events_url":"https://api.github.com/users/leon-do/events{/privacy}","received_events_url":"https://api.github.com/users/leon-do/received_events","type":"User","site_admin":false},"created_at":"2018-05-11T15:03:09Z","updated_at":"2018-05-11T15:03:09Z","author_association":"OWNER","body":"Good catch and you're correct about the time. \r\n\r\nI seem to be stuck on the same issue. There seems to be a discrepancy between the time on chain and the time from the DOM. \r\n\r\nI haven't figured it out yet but if you do, please share your insight"}}
{"actor":{"display_login":"leon-do"}}