{"action":"closed","number":288,"pull_request":{"url":"https://api.github.com/repos/Semmle/ql/pulls/288","id":220829759,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODI5NzU5","html_url":"https://github.com/Semmle/ql/pull/288","diff_url":"https://github.com/Semmle/ql/pull/288.diff","patch_url":"https://github.com/Semmle/ql/pull/288.patch","issue_url":"https://api.github.com/repos/Semmle/ql/issues/288","number":288,"state":"closed","locked":false,"title":"CPP: Address Widechartype / WChar_t","user":{"login":"geoffw0","id":40627776,"node_id":"MDQ6VXNlcjQwNjI3Nzc2","avatar_url":"https://avatars1.githubusercontent.com/u/40627776?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffw0","html_url":"https://github.com/geoffw0","followers_url":"https://api.github.com/users/geoffw0/followers","following_url":"https://api.github.com/users/geoffw0/following{/other_user}","gists_url":"https://api.github.com/users/geoffw0/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffw0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffw0/subscriptions","organizations_url":"https://api.github.com/users/geoffw0/orgs","repos_url":"https://api.github.com/users/geoffw0/repos","events_url":"https://api.github.com/users/geoffw0/events{/privacy}","received_events_url":"https://api.github.com/users/geoffw0/received_events","type":"User","site_admin":false},"body":"I noticed a few weeks ago that we have two very similar QL classes, 'WideCharType' and 'Wchar_t'.  This PR adds comments to clarify the difference, hinting that 'Wchar_t' is normally the right one to use.  I've also corrected some uses of 'WideCharType' where I believe it to be the wrong choice.\r\n\r\nInvestigative query at https://lgtm.com/query/1506594176863/.","created_at":"2018-10-05T21:31:56Z","updated_at":"2018-10-08T11:46:29Z","closed_at":"2018-10-08T11:46:29Z","merged_at":"2018-10-08T11:46:29Z","merge_commit_sha":"4e25929f82808fad8dafe1abf6ba11855f111a4c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1013984560,"node_id":"MDU6TGFiZWwxMDEzOTg0NTYw","url":"https://api.github.com/repos/Semmle/ql/labels/C++","name":"C++","color":"6add92","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Semmle/ql/pulls/288/commits","review_comments_url":"https://api.github.com/repos/Semmle/ql/pulls/288/comments","review_comment_url":"https://api.github.com/repos/Semmle/ql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Semmle/ql/issues/288/comments","statuses_url":"https://api.github.com/repos/Semmle/ql/statuses/e0140f9112d64458fafeec56afc433149deb01db","head":{"label":"geoffw0:widechartype","ref":"widechartype","sha":"e0140f9112d64458fafeec56afc433149deb01db","user":{"login":"geoffw0","id":40627776,"node_id":"MDQ6VXNlcjQwNjI3Nzc2","avatar_url":"https://avatars1.githubusercontent.com/u/40627776?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffw0","html_url":"https://github.com/geoffw0","followers_url":"https://api.github.com/users/geoffw0/followers","following_url":"https://api.github.com/users/geoffw0/following{/other_user}","gists_url":"https://api.github.com/users/geoffw0/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffw0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffw0/subscriptions","organizations_url":"https://api.github.com/users/geoffw0/orgs","repos_url":"https://api.github.com/users/geoffw0/repos","events_url":"https://api.github.com/users/geoffw0/events{/privacy}","received_events_url":"https://api.github.com/users/geoffw0/received_events","type":"User","site_admin":false},"repo":{"id":144957042,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5NTcwNDI=","name":"ql","full_name":"geoffw0/ql","private":false,"owner":{"login":"geoffw0","id":40627776,"node_id":"MDQ6VXNlcjQwNjI3Nzc2","avatar_url":"https://avatars1.githubusercontent.com/u/40627776?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffw0","html_url":"https://github.com/geoffw0","followers_url":"https://api.github.com/users/geoffw0/followers","following_url":"https://api.github.com/users/geoffw0/following{/other_user}","gists_url":"https://api.github.com/users/geoffw0/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffw0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffw0/subscriptions","organizations_url":"https://api.github.com/users/geoffw0/orgs","repos_url":"https://api.github.com/users/geoffw0/repos","events_url":"https://api.github.com/users/geoffw0/events{/privacy}","received_events_url":"https://api.github.com/users/geoffw0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/geoffw0/ql","description":null,"fork":true,"url":"https://api.github.com/repos/geoffw0/ql","forks_url":"https://api.github.com/repos/geoffw0/ql/forks","keys_url":"https://api.github.com/repos/geoffw0/ql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoffw0/ql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoffw0/ql/teams","hooks_url":"https://api.github.com/repos/geoffw0/ql/hooks","issue_events_url":"https://api.github.com/repos/geoffw0/ql/issues/events{/number}","events_url":"https://api.github.com/repos/geoffw0/ql/events","assignees_url":"https://api.github.com/repos/geoffw0/ql/assignees{/user}","branches_url":"https://api.github.com/repos/geoffw0/ql/branches{/branch}","tags_url":"https://api.github.com/repos/geoffw0/ql/tags","blobs_url":"https://api.github.com/repos/geoffw0/ql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoffw0/ql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoffw0/ql/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoffw0/ql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoffw0/ql/statuses/{sha}","languages_url":"https://api.github.com/repos/geoffw0/ql/languages","stargazers_url":"https://api.github.com/repos/geoffw0/ql/stargazers","contributors_url":"https://api.github.com/repos/geoffw0/ql/contributors","subscribers_url":"https://api.github.com/repos/geoffw0/ql/subscribers","subscription_url":"https://api.github.com/repos/geoffw0/ql/subscription","commits_url":"https://api.github.com/repos/geoffw0/ql/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoffw0/ql/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoffw0/ql/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoffw0/ql/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoffw0/ql/contents/{+path}","compare_url":"https://api.github.com/repos/geoffw0/ql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoffw0/ql/merges","archive_url":"https://api.github.com/repos/geoffw0/ql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoffw0/ql/downloads","issues_url":"https://api.github.com/repos/geoffw0/ql/issues{/number}","pulls_url":"https://api.github.com/repos/geoffw0/ql/pulls{/number}","milestones_url":"https://api.github.com/repos/geoffw0/ql/milestones{/number}","notifications_url":"https://api.github.com/repos/geoffw0/ql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoffw0/ql/labels{/name}","releases_url":"https://api.github.com/repos/geoffw0/ql/releases{/id}","deployments_url":"https://api.github.com/repos/geoffw0/ql/deployments","created_at":"2018-08-16T08:06:23Z","updated_at":"2018-08-16T08:06:35Z","pushed_at":"2018-10-08T11:20:31Z","git_url":"git://github.com/geoffw0/ql.git","ssh_url":"git@github.com:geoffw0/ql.git","clone_url":"https://github.com/geoffw0/ql.git","svn_url":"https://github.com/geoffw0/ql","homepage":null,"size":7999,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Semmle:master","ref":"master","sha":"4720c5ab60064803728faf0c3a92b0d2806e2dd7","user":{"login":"Semmle","id":1101495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1101495?v=4","gravatar_id":"","url":"https://api.github.com/users/Semmle","html_url":"https://github.com/Semmle","followers_url":"https://api.github.com/users/Semmle/followers","following_url":"https://api.github.com/users/Semmle/following{/other_user}","gists_url":"https://api.github.com/users/Semmle/gists{/gist_id}","starred_url":"https://api.github.com/users/Semmle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semmle/subscriptions","organizations_url":"https://api.github.com/users/Semmle/orgs","repos_url":"https://api.github.com/users/Semmle/repos","events_url":"https://api.github.com/users/Semmle/events{/privacy}","received_events_url":"https://api.github.com/users/Semmle/received_events","type":"Organization","site_admin":false},"repo":{"id":143040428,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNDA0Mjg=","name":"ql","full_name":"Semmle/ql","private":false,"owner":{"login":"Semmle","id":1101495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1101495?v=4","gravatar_id":"","url":"https://api.github.com/users/Semmle","html_url":"https://github.com/Semmle","followers_url":"https://api.github.com/users/Semmle/followers","following_url":"https://api.github.com/users/Semmle/following{/other_user}","gists_url":"https://api.github.com/users/Semmle/gists{/gist_id}","starred_url":"https://api.github.com/users/Semmle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semmle/subscriptions","organizations_url":"https://api.github.com/users/Semmle/orgs","repos_url":"https://api.github.com/users/Semmle/repos","events_url":"https://api.github.com/users/Semmle/events{/privacy}","received_events_url":"https://api.github.com/users/Semmle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Semmle/ql","description":"The standard QL libraries and queries that power LGTM.com and other Semmle Products","fork":false,"url":"https://api.github.com/repos/Semmle/ql","forks_url":"https://api.github.com/repos/Semmle/ql/forks","keys_url":"https://api.github.com/repos/Semmle/ql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Semmle/ql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Semmle/ql/teams","hooks_url":"https://api.github.com/repos/Semmle/ql/hooks","issue_events_url":"https://api.github.com/repos/Semmle/ql/issues/events{/number}","events_url":"https://api.github.com/repos/Semmle/ql/events","assignees_url":"https://api.github.com/repos/Semmle/ql/assignees{/user}","branches_url":"https://api.github.com/repos/Semmle/ql/branches{/branch}","tags_url":"https://api.github.com/repos/Semmle/ql/tags","blobs_url":"https://api.github.com/repos/Semmle/ql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Semmle/ql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Semmle/ql/git/refs{/sha}","trees_url":"https://api.github.com/repos/Semmle/ql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Semmle/ql/statuses/{sha}","languages_url":"https://api.github.com/repos/Semmle/ql/languages","stargazers_url":"https://api.github.com/repos/Semmle/ql/stargazers","contributors_url":"https://api.github.com/repos/Semmle/ql/contributors","subscribers_url":"https://api.github.com/repos/Semmle/ql/subscribers","subscription_url":"https://api.github.com/repos/Semmle/ql/subscription","commits_url":"https://api.github.com/repos/Semmle/ql/commits{/sha}","git_commits_url":"https://api.github.com/repos/Semmle/ql/git/commits{/sha}","comments_url":"https://api.github.com/repos/Semmle/ql/comments{/number}","issue_comment_url":"https://api.github.com/repos/Semmle/ql/issues/comments{/number}","contents_url":"https://api.github.com/repos/Semmle/ql/contents/{+path}","compare_url":"https://api.github.com/repos/Semmle/ql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Semmle/ql/merges","archive_url":"https://api.github.com/repos/Semmle/ql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Semmle/ql/downloads","issues_url":"https://api.github.com/repos/Semmle/ql/issues{/number}","pulls_url":"https://api.github.com/repos/Semmle/ql/pulls{/number}","milestones_url":"https://api.github.com/repos/Semmle/ql/milestones{/number}","notifications_url":"https://api.github.com/repos/Semmle/ql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Semmle/ql/labels{/name}","releases_url":"https://api.github.com/repos/Semmle/ql/releases{/id}","deployments_url":"https://api.github.com/repos/Semmle/ql/deployments","created_at":"2018-07-31T16:35:51Z","updated_at":"2018-10-08T11:37:35Z","pushed_at":"2018-10-08T11:46:29Z","git_url":"git://github.com/Semmle/ql.git","ssh_url":"git@github.com:Semmle/ql.git","clone_url":"https://github.com/Semmle/ql.git","svn_url":"https://github.com/Semmle/ql","homepage":"https://semmle.com/ql","size":8104,"stargazers_count":41,"watchers_count":41,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":37,"open_issues":31,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Semmle/ql/pulls/288"},"html":{"href":"https://github.com/Semmle/ql/pull/288"},"issue":{"href":"https://api.github.com/repos/Semmle/ql/issues/288"},"comments":{"href":"https://api.github.com/repos/Semmle/ql/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/Semmle/ql/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/Semmle/ql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Semmle/ql/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/Semmle/ql/statuses/e0140f9112d64458fafeec56afc433149deb01db"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jbj","id":308293,"node_id":"MDQ6VXNlcjMwODI5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/308293?v=4","gravatar_id":"","url":"https://api.github.com/users/jbj","html_url":"https://github.com/jbj","followers_url":"https://api.github.com/users/jbj/followers","following_url":"https://api.github.com/users/jbj/following{/other_user}","gists_url":"https://api.github.com/users/jbj/gists{/gist_id}","starred_url":"https://api.github.com/users/jbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbj/subscriptions","organizations_url":"https://api.github.com/users/jbj/orgs","repos_url":"https://api.github.com/users/jbj/repos","events_url":"https://api.github.com/users/jbj/events{/privacy}","received_events_url":"https://api.github.com/users/jbj/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":20,"deletions":12,"changed_files":4}}
{"actor":{"display_login":"jbj"}}