{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/samson/pulls/comments/216512523","pull_request_review_id":154010742,"id":216512523,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjUxMjUyMw==","diff_hunk":"@@ -47,7 +60,29 @@ def create_stages\n     end\n \n     describe \"#deploy\" do\n-      describe \"deploy for successful deploys\" do\n+      def deploy(deploy_group)\n+        post :deploy, params: {deploy_group_id: deploy_group, status: status}\n+      end\n+\n+      let(:status) { nil }\n+\n+      it \"deploys all\" do\n+        assert_difference('Deploy.count', 1) do\n+          post :deploy, params: {deploy_group_id: deploy_groups(:pod100)}\n+          assert_response :redirect\n+        end\n+      end\n+\n+      it \"complains about unknown status\" do\n+        post :deploy, params: {deploy_group_id: deploy_groups(:pod100), status: \"wut\"}\n+        assert_response :bad_request\n+      end\n+\n+      describe \"successful deploys\" do","path":"test/controllers/mass_rollouts_controller_test.rb","position":null,"original_position":52,"commit_id":"fe9af893817c222fce47e40bb57c07d951e250a4","original_commit_id":"fe9af893817c222fce47e40bb57c07d951e250a4","user":{"login":"adammw","id":153219,"node_id":"MDQ6VXNlcjE1MzIxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/153219?v=4","gravatar_id":"","url":"https://api.github.com/users/adammw","html_url":"https://github.com/adammw","followers_url":"https://api.github.com/users/adammw/followers","following_url":"https://api.github.com/users/adammw/following{/other_user}","gists_url":"https://api.github.com/users/adammw/gists{/gist_id}","starred_url":"https://api.github.com/users/adammw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammw/subscriptions","organizations_url":"https://api.github.com/users/adammw/orgs","repos_url":"https://api.github.com/users/adammw/repos","events_url":"https://api.github.com/users/adammw/events{/privacy}","received_events_url":"https://api.github.com/users/adammw/received_events","type":"User","site_admin":false},"body":"maybe \"successful only mass rollout\"?","created_at":"2018-09-11T00:11:03Z","updated_at":"2018-09-11T00:11:04Z","html_url":"https://github.com/zendesk/samson/pull/2881#discussion_r216512523","pull_request_url":"https://api.github.com/repos/zendesk/samson/pulls/2881","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zendesk/samson/pulls/comments/216512523"},"html":{"href":"https://github.com/zendesk/samson/pull/2881#discussion_r216512523"},"pull_request":{"href":"https://api.github.com/repos/zendesk/samson/pulls/2881"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/samson/pulls/2881","id":209011022,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDExMDIy","html_url":"https://github.com/zendesk/samson/pull/2881","diff_url":"https://github.com/zendesk/samson/pull/2881.diff","patch_url":"https://github.com/zendesk/samson/pull/2881.patch","issue_url":"https://api.github.com/repos/zendesk/samson/issues/2881","number":2881,"state":"open","locked":false,"title":"Add mass rollout for k8s stages","user":{"login":"adammw","id":153219,"node_id":"MDQ6VXNlcjE1MzIxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/153219?v=4","gravatar_id":"","url":"https://api.github.com/users/adammw","html_url":"https://github.com/adammw","followers_url":"https://api.github.com/users/adammw/followers","following_url":"https://api.github.com/users/adammw/following{/other_user}","gists_url":"https://api.github.com/users/adammw/gists{/gist_id}","starred_url":"https://api.github.com/users/adammw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammw/subscriptions","organizations_url":"https://api.github.com/users/adammw/orgs","repos_url":"https://api.github.com/users/adammw/repos","events_url":"https://api.github.com/users/adammw/events{/privacy}","received_events_url":"https://api.github.com/users/adammw/received_events","type":"User","site_admin":false},"body":"Refactor mass rollout to include k8s stage options.\r\n\r\n![screen shot 2018-09-10 at 1 20 11 pm](https://user-images.githubusercontent.com/153219/45322212-760b2400-b4fc-11e8-974d-0fae5458003f.png)\r\n\r\n/cc @zendesk/samson @zendesk/compute\r\n\r\n### Tasks\r\n - [ ] :+1: from team\r\n\r\n### References\r\n - Jira link: https://zendesk.atlassian.net/browse/PAAS-1970\r\n\r\n### Risks\r\n- Level: Medium\r\n- While shouldn't break any existing functionality, the new functionality has the potential to create many K8s deploys so should be rigorously reviewed/tested.\r\n","created_at":"2018-08-16T23:31:37Z","updated_at":"2018-09-11T00:11:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a053ae811c84e85a4328d7c2ec406848f547a0c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/samson/pulls/2881/commits","review_comments_url":"https://api.github.com/repos/zendesk/samson/pulls/2881/comments","review_comment_url":"https://api.github.com/repos/zendesk/samson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/samson/issues/2881/comments","statuses_url":"https://api.github.com/repos/zendesk/samson/statuses/fe9af893817c222fce47e40bb57c07d951e250a4","head":{"label":"zendesk:adammw/k8s-mass-rollout","ref":"adammw/k8s-mass-rollout","sha":"fe9af893817c222fce47e40bb57c07d951e250a4","user":{"login":"zendesk","id":11525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI1","avatar_url":"https://avatars3.githubusercontent.com/u/11525?v=4","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":20208662,"node_id":"MDEwOlJlcG9zaXRvcnkyMDIwODY2Mg==","name":"samson","full_name":"zendesk/samson","owner":{"login":"zendesk","id":11525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI1","avatar_url":"https://avatars3.githubusercontent.com/u/11525?v=4","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/samson","description":"Web interface for deployments","fork":false,"url":"https://api.github.com/repos/zendesk/samson","forks_url":"https://api.github.com/repos/zendesk/samson/forks","keys_url":"https://api.github.com/repos/zendesk/samson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/samson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/samson/teams","hooks_url":"https://api.github.com/repos/zendesk/samson/hooks","issue_events_url":"https://api.github.com/repos/zendesk/samson/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/samson/events","assignees_url":"https://api.github.com/repos/zendesk/samson/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/samson/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/samson/tags","blobs_url":"https://api.github.com/repos/zendesk/samson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/samson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/samson/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/samson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/samson/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/samson/languages","stargazers_url":"https://api.github.com/repos/zendesk/samson/stargazers","contributors_url":"https://api.github.com/repos/zendesk/samson/contributors","subscribers_url":"https://api.github.com/repos/zendesk/samson/subscribers","subscription_url":"https://api.github.com/repos/zendesk/samson/subscription","commits_url":"https://api.github.com/repos/zendesk/samson/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/samson/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/samson/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/samson/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/samson/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/samson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/samson/merges","archive_url":"https://api.github.com/repos/zendesk/samson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/samson/downloads","issues_url":"https://api.github.com/repos/zendesk/samson/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/samson/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/samson/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/samson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/samson/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/samson/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/samson/deployments","created_at":"2014-05-27T05:55:57Z","updated_at":"2018-09-10T17:39:07Z","pushed_at":"2018-09-10T23:30:05Z","git_url":"git://github.com/zendesk/samson.git","ssh_url":"git@github.com:zendesk/samson.git","clone_url":"https://github.com/zendesk/samson.git","svn_url":"https://github.com/zendesk/samson","homepage":null,"size":336741,"stargazers_count":1164,"watchers_count":1164,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":211,"open_issues":78,"watchers":1164,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"d028b73192b024ccbec2c904e5d69851534f1b50","user":{"login":"zendesk","id":11525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI1","avatar_url":"https://avatars3.githubusercontent.com/u/11525?v=4","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":20208662,"node_id":"MDEwOlJlcG9zaXRvcnkyMDIwODY2Mg==","name":"samson","full_name":"zendesk/samson","owner":{"login":"zendesk","id":11525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI1","avatar_url":"https://avatars3.githubusercontent.com/u/11525?v=4","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/samson","description":"Web interface for deployments","fork":false,"url":"https://api.github.com/repos/zendesk/samson","forks_url":"https://api.github.com/repos/zendesk/samson/forks","keys_url":"https://api.github.com/repos/zendesk/samson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/samson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/samson/teams","hooks_url":"https://api.github.com/repos/zendesk/samson/hooks","issue_events_url":"https://api.github.com/repos/zendesk/samson/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/samson/events","assignees_url":"https://api.github.com/repos/zendesk/samson/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/samson/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/samson/tags","blobs_url":"https://api.github.com/repos/zendesk/samson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/samson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/samson/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/samson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/samson/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/samson/languages","stargazers_url":"https://api.github.com/repos/zendesk/samson/stargazers","contributors_url":"https://api.github.com/repos/zendesk/samson/contributors","subscribers_url":"https://api.github.com/repos/zendesk/samson/subscribers","subscription_url":"https://api.github.com/repos/zendesk/samson/subscription","commits_url":"https://api.github.com/repos/zendesk/samson/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/samson/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/samson/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/samson/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/samson/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/samson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/samson/merges","archive_url":"https://api.github.com/repos/zendesk/samson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/samson/downloads","issues_url":"https://api.github.com/repos/zendesk/samson/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/samson/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/samson/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/samson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/samson/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/samson/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/samson/deployments","created_at":"2014-05-27T05:55:57Z","updated_at":"2018-09-10T17:39:07Z","pushed_at":"2018-09-10T23:30:05Z","git_url":"git://github.com/zendesk/samson.git","ssh_url":"git@github.com:zendesk/samson.git","clone_url":"https://github.com/zendesk/samson.git","svn_url":"https://github.com/zendesk/samson","homepage":null,"size":336741,"stargazers_count":1164,"watchers_count":1164,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":211,"open_issues":78,"watchers":1164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/samson/pulls/2881"},"html":{"href":"https://github.com/zendesk/samson/pull/2881"},"issue":{"href":"https://api.github.com/repos/zendesk/samson/issues/2881"},"comments":{"href":"https://api.github.com/repos/zendesk/samson/issues/2881/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/samson/pulls/2881/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/samson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/samson/pulls/2881/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/samson/statuses/fe9af893817c222fce47e40bb57c07d951e250a4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adammw"}}