{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/asset-manager/pulls/comments/167025212","pull_request_review_id":95181920,"id":167025212,"diff_hunk":"@@ -9,7 +9,8 @@ class Error < StandardError; end\n   class InfectedFile < StandardError; end\n \n   def scan(file_path)\n-    out_str, status = Open3.capture2e('govuk_clamscan', '--no-summary', file_path)\n+    clamscan_path = AssetManager.govuk.clamscan_path\n+    out_str, status = Open3.capture2e(clamscan_path, \"--no-summary\", file_path)","path":"lib/virus_scanner.rb","position":6,"original_position":6,"commit_id":"6fd7449a48fefecc16318e910b1446eb88f89892","original_commit_id":"6fd7449a48fefecc16318e910b1446eb88f89892","user":{"login":"floehopper","id":3169,"avatar_url":"https://avatars2.githubusercontent.com/u/3169?v=4","gravatar_id":"","url":"https://api.github.com/users/floehopper","html_url":"https://github.com/floehopper","followers_url":"https://api.github.com/users/floehopper/followers","following_url":"https://api.github.com/users/floehopper/following{/other_user}","gists_url":"https://api.github.com/users/floehopper/gists{/gist_id}","starred_url":"https://api.github.com/users/floehopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floehopper/subscriptions","organizations_url":"https://api.github.com/users/floehopper/orgs","repos_url":"https://api.github.com/users/floehopper/repos","events_url":"https://api.github.com/users/floehopper/events{/privacy}","received_events_url":"https://api.github.com/users/floehopper/received_events","type":"User","site_admin":false},"body":"Very minor: I think it would be better to keep the single quotes around `'--no-summary'`.","created_at":"2018-02-08T18:25:42Z","updated_at":"2018-02-08T18:28:00Z","html_url":"https://github.com/alphagov/asset-manager/pull/462#discussion_r167025212","pull_request_url":"https://api.github.com/repos/alphagov/asset-manager/pulls/462","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/asset-manager/pulls/comments/167025212"},"html":{"href":"https://github.com/alphagov/asset-manager/pull/462#discussion_r167025212"},"pull_request":{"href":"https://api.github.com/repos/alphagov/asset-manager/pulls/462"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/asset-manager/pulls/462","id":167724284,"html_url":"https://github.com/alphagov/asset-manager/pull/462","diff_url":"https://github.com/alphagov/asset-manager/pull/462.diff","patch_url":"https://github.com/alphagov/asset-manager/pull/462.patch","issue_url":"https://api.github.com/repos/alphagov/asset-manager/issues/462","number":462,"state":"open","locked":false,"title":"Allow location of clamscan to be configured by environment variable","user":{"login":"adrianclay","id":976274,"avatar_url":"https://avatars2.githubusercontent.com/u/976274?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianclay","html_url":"https://github.com/adrianclay","followers_url":"https://api.github.com/users/adrianclay/followers","following_url":"https://api.github.com/users/adrianclay/following{/other_user}","gists_url":"https://api.github.com/users/adrianclay/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianclay/subscriptions","organizations_url":"https://api.github.com/users/adrianclay/orgs","repos_url":"https://api.github.com/users/adrianclay/repos","events_url":"https://api.github.com/users/adrianclay/events{/privacy}","received_events_url":"https://api.github.com/users/adrianclay/received_events","type":"User","site_admin":false},"body":"In the end to end tests environment, we want to be able to disable the virus scan easily as it can take more than 60 seconds to complete a scan when several requests are made to it at once.\r\n\r\nBy allowing the path to be passed in we can give it /bin/true when wanting to disable the scan.","created_at":"2018-02-07T15:28:40Z","updated_at":"2018-02-08T18:28:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10a4695e1f8d1a8afad92158d235500dcae85db1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chrisroos","id":6556,"avatar_url":"https://avatars2.githubusercontent.com/u/6556?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false},{"login":"chrislo","id":16707,"avatar_url":"https://avatars0.githubusercontent.com/u/16707?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislo","html_url":"https://github.com/chrislo","followers_url":"https://api.github.com/users/chrislo/followers","following_url":"https://api.github.com/users/chrislo/following{/other_user}","gists_url":"https://api.github.com/users/chrislo/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislo/subscriptions","organizations_url":"https://api.github.com/users/chrislo/orgs","repos_url":"https://api.github.com/users/chrislo/repos","events_url":"https://api.github.com/users/chrislo/events{/privacy}","received_events_url":"https://api.github.com/users/chrislo/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/asset-manager/pulls/462/commits","review_comments_url":"https://api.github.com/repos/alphagov/asset-manager/pulls/462/comments","review_comment_url":"https://api.github.com/repos/alphagov/asset-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/asset-manager/issues/462/comments","statuses_url":"https://api.github.com/repos/alphagov/asset-manager/statuses/6fd7449a48fefecc16318e910b1446eb88f89892","head":{"label":"alphagov:invert-dependency-on-clamav_scan","ref":"invert-dependency-on-clamav_scan","sha":"6fd7449a48fefecc16318e910b1446eb88f89892","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":7868150,"name":"asset-manager","full_name":"alphagov/asset-manager","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/asset-manager","description":"Manages uploaded assets (images, PDFs etc.) for applications on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/asset-manager","forks_url":"https://api.github.com/repos/alphagov/asset-manager/forks","keys_url":"https://api.github.com/repos/alphagov/asset-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/asset-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/asset-manager/teams","hooks_url":"https://api.github.com/repos/alphagov/asset-manager/hooks","issue_events_url":"https://api.github.com/repos/alphagov/asset-manager/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/asset-manager/events","assignees_url":"https://api.github.com/repos/alphagov/asset-manager/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/asset-manager/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/asset-manager/tags","blobs_url":"https://api.github.com/repos/alphagov/asset-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/asset-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/asset-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/asset-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/asset-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/asset-manager/languages","stargazers_url":"https://api.github.com/repos/alphagov/asset-manager/stargazers","contributors_url":"https://api.github.com/repos/alphagov/asset-manager/contributors","subscribers_url":"https://api.github.com/repos/alphagov/asset-manager/subscribers","subscription_url":"https://api.github.com/repos/alphagov/asset-manager/subscription","commits_url":"https://api.github.com/repos/alphagov/asset-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/asset-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/asset-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/asset-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/asset-manager/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/asset-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/asset-manager/merges","archive_url":"https://api.github.com/repos/alphagov/asset-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/asset-manager/downloads","issues_url":"https://api.github.com/repos/alphagov/asset-manager/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/asset-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/asset-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/asset-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/asset-manager/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/asset-manager/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/asset-manager/deployments","created_at":"2013-01-28T11:00:30Z","updated_at":"2017-04-11T11:31:13Z","pushed_at":"2018-02-08T18:24:22Z","git_url":"git://github.com/alphagov/asset-manager.git","ssh_url":"git@github.com:alphagov/asset-manager.git","clone_url":"https://github.com/alphagov/asset-manager.git","svn_url":"https://github.com/alphagov/asset-manager","homepage":"https://docs.publishing.service.gov.uk/apps/asset-manager.html","size":962,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":65,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"f112b500facbced73ae9f41b33ca6e0be4303464","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":7868150,"name":"asset-manager","full_name":"alphagov/asset-manager","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/asset-manager","description":"Manages uploaded assets (images, PDFs etc.) for applications on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/asset-manager","forks_url":"https://api.github.com/repos/alphagov/asset-manager/forks","keys_url":"https://api.github.com/repos/alphagov/asset-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/asset-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/asset-manager/teams","hooks_url":"https://api.github.com/repos/alphagov/asset-manager/hooks","issue_events_url":"https://api.github.com/repos/alphagov/asset-manager/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/asset-manager/events","assignees_url":"https://api.github.com/repos/alphagov/asset-manager/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/asset-manager/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/asset-manager/tags","blobs_url":"https://api.github.com/repos/alphagov/asset-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/asset-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/asset-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/asset-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/asset-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/asset-manager/languages","stargazers_url":"https://api.github.com/repos/alphagov/asset-manager/stargazers","contributors_url":"https://api.github.com/repos/alphagov/asset-manager/contributors","subscribers_url":"https://api.github.com/repos/alphagov/asset-manager/subscribers","subscription_url":"https://api.github.com/repos/alphagov/asset-manager/subscription","commits_url":"https://api.github.com/repos/alphagov/asset-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/asset-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/asset-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/asset-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/asset-manager/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/asset-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/asset-manager/merges","archive_url":"https://api.github.com/repos/alphagov/asset-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/asset-manager/downloads","issues_url":"https://api.github.com/repos/alphagov/asset-manager/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/asset-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/asset-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/asset-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/asset-manager/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/asset-manager/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/asset-manager/deployments","created_at":"2013-01-28T11:00:30Z","updated_at":"2017-04-11T11:31:13Z","pushed_at":"2018-02-08T18:24:22Z","git_url":"git://github.com/alphagov/asset-manager.git","ssh_url":"git@github.com:alphagov/asset-manager.git","clone_url":"https://github.com/alphagov/asset-manager.git","svn_url":"https://github.com/alphagov/asset-manager","homepage":"https://docs.publishing.service.gov.uk/apps/asset-manager.html","size":962,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":65,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/asset-manager/pulls/462"},"html":{"href":"https://github.com/alphagov/asset-manager/pull/462"},"issue":{"href":"https://api.github.com/repos/alphagov/asset-manager/issues/462"},"comments":{"href":"https://api.github.com/repos/alphagov/asset-manager/issues/462/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/asset-manager/pulls/462/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/asset-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/asset-manager/pulls/462/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/asset-manager/statuses/6fd7449a48fefecc16318e910b1446eb88f89892"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"floehopper"}}