{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-updater/pulls/comments/185370527","pull_request_review_id":116744488,"id":185370527,"diff_hunk":"@@ -386,41 +391,37 @@ get_refspec_to_upgrade_on (gchar               **refspec_to_upgrade_on,\n   if (booted_deployment == NULL)\n     return FALSE;\n \n-  if (!get_refspec_to_upgrade_on_from_deployment (sysroot,\n-                                                  booted_deployment,\n-                                                  &refspec,\n-                                                  error))\n+  if (!get_booted_refspec (booted_deployment,\n+                           &refspec,\n+                           &remote,\n+                           &ref,\n+                           &collection_ref,\n+                           error))","path":"src/eos-updater-poll-common.c","position":86,"original_position":86,"commit_id":"e93ea5391fd5bf5eb86e599f9e5ea5268b2af29a","original_commit_id":"e93ea5391fd5bf5eb86e599f9e5ea5268b2af29a","user":{"login":"smspillaz","id":775309,"avatar_url":"https://avatars3.githubusercontent.com/u/775309?v=4","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"body":"I think these can be renamed to `booted_refspec` `booted_remote`, `booted_ref`, `booted_collection_ref` etc. Then below in the branch where we check for the checkpoint, we can set the outparams to the overridden refspec, remote, and booted ref. If that branch isn't followed, then set the outparams to the `booted_refspec` and friends. That should obviate the need for the free/replace dance below.","created_at":"2018-05-02T00:40:54Z","updated_at":"2018-05-02T00:40:54Z","html_url":"https://github.com/endlessm/eos-updater/pull/196#discussion_r185370527","pull_request_url":"https://api.github.com/repos/endlessm/eos-updater/pulls/196","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-updater/pulls/comments/185370527"},"html":{"href":"https://github.com/endlessm/eos-updater/pull/196#discussion_r185370527"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-updater/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-updater/pulls/196","id":185285619,"html_url":"https://github.com/endlessm/eos-updater/pull/196","diff_url":"https://github.com/endlessm/eos-updater/pull/196.diff","patch_url":"https://github.com/endlessm/eos-updater/pull/196.patch","issue_url":"https://api.github.com/repos/endlessm/eos-updater/issues/196","number":196,"state":"open","locked":false,"title":"poll-common: Operate on checkpoint refs, not refspecs","user":{"login":"dbnicholson","id":6495518,"avatar_url":"https://avatars2.githubusercontent.com/u/6495518?v=4","gravatar_id":"","url":"https://api.github.com/users/dbnicholson","html_url":"https://github.com/dbnicholson","followers_url":"https://api.github.com/users/dbnicholson/followers","following_url":"https://api.github.com/users/dbnicholson/following{/other_user}","gists_url":"https://api.github.com/users/dbnicholson/gists{/gist_id}","starred_url":"https://api.github.com/users/dbnicholson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbnicholson/subscriptions","organizations_url":"https://api.github.com/users/dbnicholson/orgs","repos_url":"https://api.github.com/users/dbnicholson/repos","events_url":"https://api.github.com/users/dbnicholson/events{/privacy}","received_events_url":"https://api.github.com/users/dbnicholson/received_events","type":"User","site_admin":false},"body":"The eos.checkpoint-target commit metadata is created on the server side\r\nwhile the remote is a property of the client's configuration. Following\r\na remote specified in the metadata would almost certainly be wrong and\r\nprovide the server with the ability to switch a client's remote.\r\n\r\nInstead, only take the ref from the metadata like the\r\nostree.endoflife-rebase handling. If a full refspec with remote is\r\nincluded, the remote is ignored and a warning is issued.\r\n\r\nhttps://phabricator.endlessm.com/T19437","created_at":"2018-05-01T21:50:12Z","updated_at":"2018-05-02T00:40:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d353dff0ec6d84d62b6777f357a89fd1365f8d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-updater/pulls/196/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-updater/pulls/196/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-updater/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-updater/issues/196/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-updater/statuses/e93ea5391fd5bf5eb86e599f9e5ea5268b2af29a","head":{"label":"endlessm:T19437-checkoint-ref","ref":"T19437-checkoint-ref","sha":"e93ea5391fd5bf5eb86e599f9e5ea5268b2af29a","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":13253303,"name":"eos-updater","full_name":"endlessm/eos-updater","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-updater","description":"System components of the OS Tree based updater","fork":false,"url":"https://api.github.com/repos/endlessm/eos-updater","forks_url":"https://api.github.com/repos/endlessm/eos-updater/forks","keys_url":"https://api.github.com/repos/endlessm/eos-updater/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-updater/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-updater/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-updater/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-updater/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-updater/events","assignees_url":"https://api.github.com/repos/endlessm/eos-updater/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-updater/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-updater/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-updater/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-updater/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-updater/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-updater/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-updater/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-updater/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-updater/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-updater/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-updater/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-updater/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-updater/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-updater/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-updater/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-updater/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-updater/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-updater/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-updater/merges","archive_url":"https://api.github.com/repos/endlessm/eos-updater/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-updater/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-updater/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-updater/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-updater/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-updater/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-updater/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-updater/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-updater/deployments","created_at":"2013-10-01T19:23:58Z","updated_at":"2018-05-01T19:54:10Z","pushed_at":"2018-05-01T23:59:19Z","git_url":"git://github.com/endlessm/eos-updater.git","ssh_url":"git@github.com:endlessm/eos-updater.git","clone_url":"https://github.com/endlessm/eos-updater.git","svn_url":"https://github.com/endlessm/eos-updater","homepage":null,"size":1874,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":5,"open_issues":4,"watchers":8,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"fedd4d6a1b55d1ee2f9a6834cf1b69f2b8a531be","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":13253303,"name":"eos-updater","full_name":"endlessm/eos-updater","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-updater","description":"System components of the OS Tree based updater","fork":false,"url":"https://api.github.com/repos/endlessm/eos-updater","forks_url":"https://api.github.com/repos/endlessm/eos-updater/forks","keys_url":"https://api.github.com/repos/endlessm/eos-updater/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-updater/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-updater/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-updater/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-updater/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-updater/events","assignees_url":"https://api.github.com/repos/endlessm/eos-updater/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-updater/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-updater/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-updater/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-updater/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-updater/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-updater/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-updater/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-updater/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-updater/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-updater/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-updater/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-updater/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-updater/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-updater/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-updater/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-updater/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-updater/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-updater/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-updater/merges","archive_url":"https://api.github.com/repos/endlessm/eos-updater/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-updater/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-updater/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-updater/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-updater/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-updater/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-updater/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-updater/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-updater/deployments","created_at":"2013-10-01T19:23:58Z","updated_at":"2018-05-01T19:54:10Z","pushed_at":"2018-05-01T23:59:19Z","git_url":"git://github.com/endlessm/eos-updater.git","ssh_url":"git@github.com:endlessm/eos-updater.git","clone_url":"https://github.com/endlessm/eos-updater.git","svn_url":"https://github.com/endlessm/eos-updater","homepage":null,"size":1874,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":5,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-updater/pulls/196"},"html":{"href":"https://github.com/endlessm/eos-updater/pull/196"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-updater/issues/196"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-updater/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-updater/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-updater/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-updater/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-updater/statuses/e93ea5391fd5bf5eb86e599f9e5ea5268b2af29a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"smspillaz"}}