{"action":"created","issue":{"url":"https://api.github.com/repos/python/cpython/issues/6581","repository_url":"https://api.github.com/repos/python/cpython","labels_url":"https://api.github.com/repos/python/cpython/issues/6581/labels{/name}","comments_url":"https://api.github.com/repos/python/cpython/issues/6581/comments","events_url":"https://api.github.com/repos/python/cpython/issues/6581/events","html_url":"https://github.com/python/cpython/pull/6581","id":316956585,"number":6581,"title":"bpo-33332: Add signal.valid_signals()","user":{"login":"pitrou","id":1721820,"avatar_url":"https://avatars2.githubusercontent.com/u/1721820?v=4","gravatar_id":"","url":"https://api.github.com/users/pitrou","html_url":"https://github.com/pitrou","followers_url":"https://api.github.com/users/pitrou/followers","following_url":"https://api.github.com/users/pitrou/following{/other_user}","gists_url":"https://api.github.com/users/pitrou/gists{/gist_id}","starred_url":"https://api.github.com/users/pitrou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitrou/subscriptions","organizations_url":"https://api.github.com/users/pitrou/orgs","repos_url":"https://api.github.com/users/pitrou/repos","events_url":"https://api.github.com/users/pitrou/events{/privacy}","received_events_url":"https://api.github.com/users/pitrou/received_events","type":"User","site_admin":false},"labels":[{"id":536945472,"url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666980059,"url":"https://api.github.com/repos/python/cpython/labels/awaiting%20merge","name":"awaiting merge","color":"fbca04","default":false},{"id":536871772,"url":"https://api.github.com/repos/python/cpython/labels/type-enhancement","name":"type-enhancement","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-23T19:43:26Z","updated_at":"2018-05-03T20:17:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/6581","html_url":"https://github.com/python/cpython/pull/6581","diff_url":"https://github.com/python/cpython/pull/6581.diff","patch_url":"https://github.com/python/cpython/pull/6581.patch"},"body":"\n\n<!-- issue-number: bpo-33332 -->\nhttps://bugs.python.org/issue33332\n<!-- /issue-number -->\n"},"comment":{"url":"https://api.github.com/repos/python/cpython/issues/comments/386422804","html_url":"https://github.com/python/cpython/pull/6581#issuecomment-386422804","issue_url":"https://api.github.com/repos/python/cpython/issues/6581","id":386422804,"user":{"login":"vstinner","id":194129,"avatar_url":"https://avatars2.githubusercontent.com/u/194129?v=4","gravatar_id":"","url":"https://api.github.com/users/vstinner","html_url":"https://github.com/vstinner","followers_url":"https://api.github.com/users/vstinner/followers","following_url":"https://api.github.com/users/vstinner/following{/other_user}","gists_url":"https://api.github.com/users/vstinner/gists{/gist_id}","starred_url":"https://api.github.com/users/vstinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vstinner/subscriptions","organizations_url":"https://api.github.com/users/vstinner/orgs","repos_url":"https://api.github.com/users/vstinner/repos","events_url":"https://api.github.com/users/vstinner/events{/privacy}","received_events_url":"https://api.github.com/users/vstinner/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T20:17:13Z","updated_at":"2018-05-03T20:17:13Z","author_association":"MEMBER","body":"First I wanted to get a list, but then I read the PR and I like reusing existing code :-)\r\n\r\nIf someone wants an immutable type, it's very simple: frozenset(signal.valid_signals()).\r\n\r\nAn immutable type might be justified if it was a module constant, but it's a function which creates a new object at each call, so IMHO a set is just fine.\r\n\r\nI don't want to modify other signal functions just to be pedantic. I like Antoine's rationale to use set in valid_signals()."}}
{"actor":{"display_login":"vstinner"}}