{"action":"created","comment":{"url":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/comments/216640865","pull_request_review_id":154166574,"id":216640865,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjY0MDg2NQ==","diff_hunk":"@@ -60,7 +60,7 @@ ADLMIDI_EXPORT struct ADL_MIDIPlayer *adl_init(long sample_rate)\n         return NULL;\n     }\n \n-    MIDIplay *player = new MIDIplay(static_cast<unsigned long>(sample_rate));\n+    MIDIplay *player = new(std::nothrow) MIDIplay(static_cast<unsigned long>(sample_rate));","path":"src/adlmidi.cpp","position":5,"original_position":5,"commit_id":"6a90c71084b2d21c01346075924ebe01b9cfd051","original_commit_id":"6a90c71084b2d21c01346075924ebe01b9cfd051","user":{"login":"jpcima","id":17614485,"node_id":"MDQ6VXNlcjE3NjE0NDg1","avatar_url":"https://avatars0.githubusercontent.com/u/17614485?v=4","gravatar_id":"","url":"https://api.github.com/users/jpcima","html_url":"https://github.com/jpcima","followers_url":"https://api.github.com/users/jpcima/followers","following_url":"https://api.github.com/users/jpcima/following{/other_user}","gists_url":"https://api.github.com/users/jpcima/gists{/gist_id}","starred_url":"https://api.github.com/users/jpcima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpcima/subscriptions","organizations_url":"https://api.github.com/users/jpcima/orgs","repos_url":"https://api.github.com/users/jpcima/repos","events_url":"https://api.github.com/users/jpcima/events{/privacy}","received_events_url":"https://api.github.com/users/jpcima/received_events","type":"User","site_admin":false},"body":"I could as well have kept `new` the way like it is, but remove another null check down below.\r\nHaving new and a null check together just don't make sense.","created_at":"2018-09-11T11:53:56Z","updated_at":"2018-09-11T11:53:56Z","html_url":"https://github.com/Wohlstand/libADLMIDI/pull/173#discussion_r216640865","pull_request_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/173","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/comments/216640865"},"html":{"href":"https://github.com/Wohlstand/libADLMIDI/pull/173#discussion_r216640865"},"pull_request":{"href":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/173"}},"in_reply_to_id":216638594},"pull_request":{"url":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/173","id":214603979,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NjAzOTc5","html_url":"https://github.com/Wohlstand/libADLMIDI/pull/173","diff_url":"https://github.com/Wohlstand/libADLMIDI/pull/173.diff","patch_url":"https://github.com/Wohlstand/libADLMIDI/pull/173.patch","issue_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/173","number":173,"state":"closed","locked":false,"title":"have consistent null checks and returns","user":{"login":"jpcima","id":17614485,"node_id":"MDQ6VXNlcjE3NjE0NDg1","avatar_url":"https://avatars0.githubusercontent.com/u/17614485?v=4","gravatar_id":"","url":"https://api.github.com/users/jpcima","html_url":"https://github.com/jpcima","followers_url":"https://api.github.com/users/jpcima/followers","following_url":"https://api.github.com/users/jpcima/following{/other_user}","gists_url":"https://api.github.com/users/jpcima/gists{/gist_id}","starred_url":"https://api.github.com/users/jpcima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpcima/subscriptions","organizations_url":"https://api.github.com/users/jpcima/orgs","repos_url":"https://api.github.com/users/jpcima/repos","events_url":"https://api.github.com/users/jpcima/events{/privacy}","received_events_url":"https://api.github.com/users/jpcima/received_events","type":"User","site_admin":false},"body":"#172 \r\n\r\nHarmonize the way how are performed the null checks in the public functions, and some other things.\r\n","created_at":"2018-09-11T11:43:22Z","updated_at":"2018-09-11T11:53:56Z","closed_at":"2018-09-11T11:51:21Z","merged_at":"2018-09-11T11:51:21Z","merge_commit_sha":"b294333d585256182da160377c363a1f771a4c8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/173/commits","review_comments_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/173/comments","review_comment_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/173/comments","statuses_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/statuses/6a90c71084b2d21c01346075924ebe01b9cfd051","head":{"label":"jpcima:consistency","ref":"consistency","sha":"6a90c71084b2d21c01346075924ebe01b9cfd051","user":{"login":"jpcima","id":17614485,"node_id":"MDQ6VXNlcjE3NjE0NDg1","avatar_url":"https://avatars0.githubusercontent.com/u/17614485?v=4","gravatar_id":"","url":"https://api.github.com/users/jpcima","html_url":"https://github.com/jpcima","followers_url":"https://api.github.com/users/jpcima/followers","following_url":"https://api.github.com/users/jpcima/following{/other_user}","gists_url":"https://api.github.com/users/jpcima/gists{/gist_id}","starred_url":"https://api.github.com/users/jpcima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpcima/subscriptions","organizations_url":"https://api.github.com/users/jpcima/orgs","repos_url":"https://api.github.com/users/jpcima/repos","events_url":"https://api.github.com/users/jpcima/events{/privacy}","received_events_url":"https://api.github.com/users/jpcima/received_events","type":"User","site_admin":false},"repo":{"id":128603295,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2MDMyOTU=","name":"libADLMIDI","full_name":"jpcima/libADLMIDI","owner":{"login":"jpcima","id":17614485,"node_id":"MDQ6VXNlcjE3NjE0NDg1","avatar_url":"https://avatars0.githubusercontent.com/u/17614485?v=4","gravatar_id":"","url":"https://api.github.com/users/jpcima","html_url":"https://github.com/jpcima","followers_url":"https://api.github.com/users/jpcima/followers","following_url":"https://api.github.com/users/jpcima/following{/other_user}","gists_url":"https://api.github.com/users/jpcima/gists{/gist_id}","starred_url":"https://api.github.com/users/jpcima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpcima/subscriptions","organizations_url":"https://api.github.com/users/jpcima/orgs","repos_url":"https://api.github.com/users/jpcima/repos","events_url":"https://api.github.com/users/jpcima/events{/privacy}","received_events_url":"https://api.github.com/users/jpcima/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpcima/libADLMIDI","description":"A MIDI play library with OPL3 (YMF262) emulator","fork":true,"url":"https://api.github.com/repos/jpcima/libADLMIDI","forks_url":"https://api.github.com/repos/jpcima/libADLMIDI/forks","keys_url":"https://api.github.com/repos/jpcima/libADLMIDI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpcima/libADLMIDI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpcima/libADLMIDI/teams","hooks_url":"https://api.github.com/repos/jpcima/libADLMIDI/hooks","issue_events_url":"https://api.github.com/repos/jpcima/libADLMIDI/issues/events{/number}","events_url":"https://api.github.com/repos/jpcima/libADLMIDI/events","assignees_url":"https://api.github.com/repos/jpcima/libADLMIDI/assignees{/user}","branches_url":"https://api.github.com/repos/jpcima/libADLMIDI/branches{/branch}","tags_url":"https://api.github.com/repos/jpcima/libADLMIDI/tags","blobs_url":"https://api.github.com/repos/jpcima/libADLMIDI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpcima/libADLMIDI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpcima/libADLMIDI/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpcima/libADLMIDI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpcima/libADLMIDI/statuses/{sha}","languages_url":"https://api.github.com/repos/jpcima/libADLMIDI/languages","stargazers_url":"https://api.github.com/repos/jpcima/libADLMIDI/stargazers","contributors_url":"https://api.github.com/repos/jpcima/libADLMIDI/contributors","subscribers_url":"https://api.github.com/repos/jpcima/libADLMIDI/subscribers","subscription_url":"https://api.github.com/repos/jpcima/libADLMIDI/subscription","commits_url":"https://api.github.com/repos/jpcima/libADLMIDI/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpcima/libADLMIDI/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpcima/libADLMIDI/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpcima/libADLMIDI/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpcima/libADLMIDI/contents/{+path}","compare_url":"https://api.github.com/repos/jpcima/libADLMIDI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpcima/libADLMIDI/merges","archive_url":"https://api.github.com/repos/jpcima/libADLMIDI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpcima/libADLMIDI/downloads","issues_url":"https://api.github.com/repos/jpcima/libADLMIDI/issues{/number}","pulls_url":"https://api.github.com/repos/jpcima/libADLMIDI/pulls{/number}","milestones_url":"https://api.github.com/repos/jpcima/libADLMIDI/milestones{/number}","notifications_url":"https://api.github.com/repos/jpcima/libADLMIDI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpcima/libADLMIDI/labels{/name}","releases_url":"https://api.github.com/repos/jpcima/libADLMIDI/releases{/id}","deployments_url":"https://api.github.com/repos/jpcima/libADLMIDI/deployments","created_at":"2018-04-08T05:51:29Z","updated_at":"2018-09-11T10:53:09Z","pushed_at":"2018-09-11T11:32:41Z","git_url":"git://github.com/jpcima/libADLMIDI.git","ssh_url":"git@github.com:jpcima/libADLMIDI.git","clone_url":"https://github.com/jpcima/libADLMIDI.git","svn_url":"https://github.com/jpcima/libADLMIDI","homepage":"","size":15936,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Wohlstand:master","ref":"master","sha":"0fcbbb0c01e850a39bc3ba36b070f0f0bfa8c135","user":{"login":"Wohlstand","id":6751442,"node_id":"MDQ6VXNlcjY3NTE0NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6751442?v=4","gravatar_id":"","url":"https://api.github.com/users/Wohlstand","html_url":"https://github.com/Wohlstand","followers_url":"https://api.github.com/users/Wohlstand/followers","following_url":"https://api.github.com/users/Wohlstand/following{/other_user}","gists_url":"https://api.github.com/users/Wohlstand/gists{/gist_id}","starred_url":"https://api.github.com/users/Wohlstand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wohlstand/subscriptions","organizations_url":"https://api.github.com/users/Wohlstand/orgs","repos_url":"https://api.github.com/users/Wohlstand/repos","events_url":"https://api.github.com/users/Wohlstand/events{/privacy}","received_events_url":"https://api.github.com/users/Wohlstand/received_events","type":"User","site_admin":false},"repo":{"id":43983704,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzk4MzcwNA==","name":"libADLMIDI","full_name":"Wohlstand/libADLMIDI","owner":{"login":"Wohlstand","id":6751442,"node_id":"MDQ6VXNlcjY3NTE0NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6751442?v=4","gravatar_id":"","url":"https://api.github.com/users/Wohlstand","html_url":"https://github.com/Wohlstand","followers_url":"https://api.github.com/users/Wohlstand/followers","following_url":"https://api.github.com/users/Wohlstand/following{/other_user}","gists_url":"https://api.github.com/users/Wohlstand/gists{/gist_id}","starred_url":"https://api.github.com/users/Wohlstand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wohlstand/subscriptions","organizations_url":"https://api.github.com/users/Wohlstand/orgs","repos_url":"https://api.github.com/users/Wohlstand/repos","events_url":"https://api.github.com/users/Wohlstand/events{/privacy}","received_events_url":"https://api.github.com/users/Wohlstand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wohlstand/libADLMIDI","description":"A MIDI play library with OPL3 (YMF262) emulator","fork":false,"url":"https://api.github.com/repos/Wohlstand/libADLMIDI","forks_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/forks","keys_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/teams","hooks_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/hooks","issue_events_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/events{/number}","events_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/events","assignees_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/assignees{/user}","branches_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/branches{/branch}","tags_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/tags","blobs_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/statuses/{sha}","languages_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/languages","stargazers_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/stargazers","contributors_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/contributors","subscribers_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/subscribers","subscription_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/subscription","commits_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/contents/{+path}","compare_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/merges","archive_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/downloads","issues_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues{/number}","pulls_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls{/number}","milestones_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/milestones{/number}","notifications_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/labels{/name}","releases_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/releases{/id}","deployments_url":"https://api.github.com/repos/Wohlstand/libADLMIDI/deployments","created_at":"2015-10-09T22:46:43Z","updated_at":"2018-09-11T11:51:23Z","pushed_at":"2018-09-11T11:51:21Z","git_url":"git://github.com/Wohlstand/libADLMIDI.git","ssh_url":"git@github.com:Wohlstand/libADLMIDI.git","clone_url":"https://github.com/Wohlstand/libADLMIDI.git","svn_url":"https://github.com/Wohlstand/libADLMIDI","homepage":"","size":15887,"stargazers_count":31,"watchers_count":31,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":4,"open_issues":21,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/173"},"html":{"href":"https://github.com/Wohlstand/libADLMIDI/pull/173"},"issue":{"href":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/173"},"comments":{"href":"https://api.github.com/repos/Wohlstand/libADLMIDI/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wohlstand/libADLMIDI/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/Wohlstand/libADLMIDI/statuses/6a90c71084b2d21c01346075924ebe01b9cfd051"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jpcima"}}