{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/pulls/7","id":196158263,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTU4MjYz","html_url":"https://github.com/antmicro/zynq-mkbootimage/pull/7","diff_url":"https://github.com/antmicro/zynq-mkbootimage/pull/7.diff","patch_url":"https://github.com/antmicro/zynq-mkbootimage/pull/7.patch","issue_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/issues/7","number":7,"state":"closed","locked":false,"title":"Fix assumptions about ELF file layout (issue #6)","user":{"login":"anssih","id":509357,"node_id":"MDQ6VXNlcjUwOTM1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/509357?v=4","gravatar_id":"","url":"https://api.github.com/users/anssih","html_url":"https://github.com/anssih","followers_url":"https://api.github.com/users/anssih/followers","following_url":"https://api.github.com/users/anssih/following{/other_user}","gists_url":"https://api.github.com/users/anssih/gists{/gist_id}","starred_url":"https://api.github.com/users/anssih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anssih/subscriptions","organizations_url":"https://api.github.com/users/anssih/orgs","repos_url":"https://api.github.com/users/anssih/repos","events_url":"https://api.github.com/users/anssih/events{/privacy}","received_events_url":"https://api.github.com/users/anssih/received_events","type":"User","site_admin":false},"body":"Fix handling of several cases in the ELF code:\r\n\r\n- the offset between load address and ELF data offset varies by section,\r\n\r\n- some loadable sections follow the first non-loadable section,\r\n\r\n- load address is different than entry point address.\r\n\r\nThe first case is encountered at least in some PMUFW ELF files. The\r\nsecond case is encountered at least in some PMUFW ELF files on Vivado\r\n2018.1.\r\n\r\nThe elf_find_offsets() function is merged into elf_append() as they are\r\nalways called in pairs and having elf_append() continue to work without\r\nlibelf calls would have required elf_find_offsets() to pass much more\r\ninformation for elf_append().\r\n\r\n---\r\n\r\nI haven't tested this extensively, but with this change I seemed to get bootable images again (PMUFW+FSBL+ATF+u-boot for ZynqMP).","created_at":"2018-06-20T14:24:09Z","updated_at":"2018-06-21T07:32:28Z","closed_at":"2018-06-21T07:32:28Z","merged_at":"2018-06-21T07:32:28Z","merge_commit_sha":"b43432cda9934ef9a46cafc6e685dee840e11e9a","assignee":{"login":"tgorochowik","id":8438531,"node_id":"MDQ6VXNlcjg0Mzg1MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8438531?v=4","gravatar_id":"","url":"https://api.github.com/users/tgorochowik","html_url":"https://github.com/tgorochowik","followers_url":"https://api.github.com/users/tgorochowik/followers","following_url":"https://api.github.com/users/tgorochowik/following{/other_user}","gists_url":"https://api.github.com/users/tgorochowik/gists{/gist_id}","starred_url":"https://api.github.com/users/tgorochowik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgorochowik/subscriptions","organizations_url":"https://api.github.com/users/tgorochowik/orgs","repos_url":"https://api.github.com/users/tgorochowik/repos","events_url":"https://api.github.com/users/tgorochowik/events{/privacy}","received_events_url":"https://api.github.com/users/tgorochowik/received_events","type":"User","site_admin":false},"assignees":[{"login":"tgorochowik","id":8438531,"node_id":"MDQ6VXNlcjg0Mzg1MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8438531?v=4","gravatar_id":"","url":"https://api.github.com/users/tgorochowik","html_url":"https://github.com/tgorochowik","followers_url":"https://api.github.com/users/tgorochowik/followers","following_url":"https://api.github.com/users/tgorochowik/following{/other_user}","gists_url":"https://api.github.com/users/tgorochowik/gists{/gist_id}","starred_url":"https://api.github.com/users/tgorochowik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgorochowik/subscriptions","organizations_url":"https://api.github.com/users/tgorochowik/orgs","repos_url":"https://api.github.com/users/tgorochowik/repos","events_url":"https://api.github.com/users/tgorochowik/events{/privacy}","received_events_url":"https://api.github.com/users/tgorochowik/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/pulls/7/commits","review_comments_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/pulls/7/comments","review_comment_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/issues/7/comments","statuses_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/statuses/4d6912ee298fd25f322827c980c286a1eb100493","head":{"label":"anssih:fix/elf","ref":"fix/elf","sha":"4d6912ee298fd25f322827c980c286a1eb100493","user":{"login":"anssih","id":509357,"node_id":"MDQ6VXNlcjUwOTM1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/509357?v=4","gravatar_id":"","url":"https://api.github.com/users/anssih","html_url":"https://github.com/anssih","followers_url":"https://api.github.com/users/anssih/followers","following_url":"https://api.github.com/users/anssih/following{/other_user}","gists_url":"https://api.github.com/users/anssih/gists{/gist_id}","starred_url":"https://api.github.com/users/anssih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anssih/subscriptions","organizations_url":"https://api.github.com/users/anssih/orgs","repos_url":"https://api.github.com/users/anssih/repos","events_url":"https://api.github.com/users/anssih/events{/privacy}","received_events_url":"https://api.github.com/users/anssih/received_events","type":"User","site_admin":false},"repo":{"id":138039910,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgwMzk5MTA=","name":"zynq-mkbootimage","full_name":"anssih/zynq-mkbootimage","owner":{"login":"anssih","id":509357,"node_id":"MDQ6VXNlcjUwOTM1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/509357?v=4","gravatar_id":"","url":"https://api.github.com/users/anssih","html_url":"https://github.com/anssih","followers_url":"https://api.github.com/users/anssih/followers","following_url":"https://api.github.com/users/anssih/following{/other_user}","gists_url":"https://api.github.com/users/anssih/gists{/gist_id}","starred_url":"https://api.github.com/users/anssih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anssih/subscriptions","organizations_url":"https://api.github.com/users/anssih/orgs","repos_url":"https://api.github.com/users/anssih/repos","events_url":"https://api.github.com/users/anssih/events{/privacy}","received_events_url":"https://api.github.com/users/anssih/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anssih/zynq-mkbootimage","description":"This is the open source replacement of the Xilinx's bootgen application.","fork":true,"url":"https://api.github.com/repos/anssih/zynq-mkbootimage","forks_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/forks","keys_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/teams","hooks_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/hooks","issue_events_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/issues/events{/number}","events_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/events","assignees_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/assignees{/user}","branches_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/branches{/branch}","tags_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/tags","blobs_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/git/refs{/sha}","trees_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/statuses/{sha}","languages_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/languages","stargazers_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/stargazers","contributors_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/contributors","subscribers_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/subscribers","subscription_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/subscription","commits_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/commits{/sha}","git_commits_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/git/commits{/sha}","comments_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/comments{/number}","issue_comment_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/issues/comments{/number}","contents_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/contents/{+path}","compare_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/merges","archive_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/downloads","issues_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/issues{/number}","pulls_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/pulls{/number}","milestones_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/milestones{/number}","notifications_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/labels{/name}","releases_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/releases{/id}","deployments_url":"https://api.github.com/repos/anssih/zynq-mkbootimage/deployments","created_at":"2018-06-20T13:56:05Z","updated_at":"2018-06-20T13:56:07Z","pushed_at":"2018-06-21T07:24:01Z","git_url":"git://github.com/anssih/zynq-mkbootimage.git","ssh_url":"git@github.com:anssih/zynq-mkbootimage.git","clone_url":"https://github.com/anssih/zynq-mkbootimage.git","svn_url":"https://github.com/anssih/zynq-mkbootimage","homepage":null,"size":111,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"antmicro:master","ref":"master","sha":"a9faf7cf0bb38b30f55fcbfe20aa0a7260446b80","user":{"login":"antmicro","id":927785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzc4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/927785?v=4","gravatar_id":"","url":"https://api.github.com/users/antmicro","html_url":"https://github.com/antmicro","followers_url":"https://api.github.com/users/antmicro/followers","following_url":"https://api.github.com/users/antmicro/following{/other_user}","gists_url":"https://api.github.com/users/antmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/antmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antmicro/subscriptions","organizations_url":"https://api.github.com/users/antmicro/orgs","repos_url":"https://api.github.com/users/antmicro/repos","events_url":"https://api.github.com/users/antmicro/events{/privacy}","received_events_url":"https://api.github.com/users/antmicro/received_events","type":"Organization","site_admin":false},"repo":{"id":39777052,"node_id":"MDEwOlJlcG9zaXRvcnkzOTc3NzA1Mg==","name":"zynq-mkbootimage","full_name":"antmicro/zynq-mkbootimage","owner":{"login":"antmicro","id":927785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzc4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/927785?v=4","gravatar_id":"","url":"https://api.github.com/users/antmicro","html_url":"https://github.com/antmicro","followers_url":"https://api.github.com/users/antmicro/followers","following_url":"https://api.github.com/users/antmicro/following{/other_user}","gists_url":"https://api.github.com/users/antmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/antmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antmicro/subscriptions","organizations_url":"https://api.github.com/users/antmicro/orgs","repos_url":"https://api.github.com/users/antmicro/repos","events_url":"https://api.github.com/users/antmicro/events{/privacy}","received_events_url":"https://api.github.com/users/antmicro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/antmicro/zynq-mkbootimage","description":"This is the open source replacement of the Xilinx's bootgen application.","fork":false,"url":"https://api.github.com/repos/antmicro/zynq-mkbootimage","forks_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/forks","keys_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/teams","hooks_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/hooks","issue_events_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/issues/events{/number}","events_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/events","assignees_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/assignees{/user}","branches_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/branches{/branch}","tags_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/tags","blobs_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/git/refs{/sha}","trees_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/statuses/{sha}","languages_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/languages","stargazers_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/stargazers","contributors_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/contributors","subscribers_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/subscribers","subscription_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/subscription","commits_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/commits{/sha}","git_commits_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/git/commits{/sha}","comments_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/comments{/number}","issue_comment_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/issues/comments{/number}","contents_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/contents/{+path}","compare_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/merges","archive_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/downloads","issues_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/issues{/number}","pulls_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/pulls{/number}","milestones_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/milestones{/number}","notifications_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/labels{/name}","releases_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/releases{/id}","deployments_url":"https://api.github.com/repos/antmicro/zynq-mkbootimage/deployments","created_at":"2015-07-27T13:53:07Z","updated_at":"2018-02-25T09:11:47Z","pushed_at":"2018-06-21T07:32:28Z","git_url":"git://github.com/antmicro/zynq-mkbootimage.git","ssh_url":"git@github.com:antmicro/zynq-mkbootimage.git","clone_url":"https://github.com/antmicro/zynq-mkbootimage.git","svn_url":"https://github.com/antmicro/zynq-mkbootimage","homepage":null,"size":110,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":14,"open_issues":3,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/antmicro/zynq-mkbootimage/pulls/7"},"html":{"href":"https://github.com/antmicro/zynq-mkbootimage/pull/7"},"issue":{"href":"https://api.github.com/repos/antmicro/zynq-mkbootimage/issues/7"},"comments":{"href":"https://api.github.com/repos/antmicro/zynq-mkbootimage/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/antmicro/zynq-mkbootimage/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/antmicro/zynq-mkbootimage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/antmicro/zynq-mkbootimage/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/antmicro/zynq-mkbootimage/statuses/4d6912ee298fd25f322827c980c286a1eb100493"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tgorochowik","id":8438531,"node_id":"MDQ6VXNlcjg0Mzg1MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8438531?v=4","gravatar_id":"","url":"https://api.github.com/users/tgorochowik","html_url":"https://github.com/tgorochowik","followers_url":"https://api.github.com/users/tgorochowik/followers","following_url":"https://api.github.com/users/tgorochowik/following{/other_user}","gists_url":"https://api.github.com/users/tgorochowik/gists{/gist_id}","starred_url":"https://api.github.com/users/tgorochowik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgorochowik/subscriptions","organizations_url":"https://api.github.com/users/tgorochowik/orgs","repos_url":"https://api.github.com/users/tgorochowik/repos","events_url":"https://api.github.com/users/tgorochowik/events{/privacy}","received_events_url":"https://api.github.com/users/tgorochowik/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":127,"deletions":89,"changed_files":6}}
{"actor":{"display_login":"tgorochowik"}}