{"action":"created","issue":{"url":"https://api.github.com/repos/handshake/pg2kinesis/issues/6","repository_url":"https://api.github.com/repos/handshake/pg2kinesis","labels_url":"https://api.github.com/repos/handshake/pg2kinesis/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/handshake/pg2kinesis/issues/6/comments","events_url":"https://api.github.com/repos/handshake/pg2kinesis/issues/6/events","html_url":"https://github.com/handshake/pg2kinesis/pull/6","id":294033920,"number":6,"title":"Full change","user":{"login":"abconway","id":3363785,"avatar_url":"https://avatars3.githubusercontent.com/u/3363785?v=4","gravatar_id":"","url":"https://api.github.com/users/abconway","html_url":"https://github.com/abconway","followers_url":"https://api.github.com/users/abconway/followers","following_url":"https://api.github.com/users/abconway/following{/other_user}","gists_url":"https://api.github.com/users/abconway/gists{/gist_id}","starred_url":"https://api.github.com/users/abconway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abconway/subscriptions","organizations_url":"https://api.github.com/users/abconway/orgs","repos_url":"https://api.github.com/users/abconway/repos","events_url":"https://api.github.com/users/abconway/events{/privacy}","received_events_url":"https://api.github.com/users/abconway/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-02T21:49:19Z","updated_at":"2018-02-09T05:21:18Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/handshake/pg2kinesis/pulls/6","html_url":"https://github.com/handshake/pg2kinesis/pull/6","diff_url":"https://github.com/handshake/pg2kinesis/pull/6.diff","patch_url":"https://github.com/handshake/pg2kinesis/pull/6.patch"},"body":"- Adds support for specifying the logical replication output_plugin at the command line when starting pg2kinesis\r\n- When using the 'wal2json' output_plugin, adds xid to the output\r\n- Adds a JSONPayloadFormatter (for use with the wal2json output_pluging)\r\n- Adds support for Full Change output (only with the JSONPayloadFormatter and wal2json output_plugin)\r\n\r\nNotes:\r\nThe wal2json output_plugin already bulks the output of a transaction into a single JSON blob.\r\n\r\nThis broke one of the fundamental assumptions of the Formatter class. \r\n\r\nI tackled this by creating a BulkChange tuple that contains a list called 'changes' which contains string formatted changes for each change in the transaction.  \r\n\r\nIn the Stream writer, if the Message object has 'is_bulk' equals True, we assume that there are a list of changes to send instead of a single one.  We send each change with the fmt_msg (eg. '0,CDC,') appended on the front.\r\n\r\nTo ensure the agg_record doesn't get too full, we check if the agg_record is full after each change is added.  \"put_message\" will only return the last agg_record for checking if the messages have been sent.  Thus assuming that any previous agg_records that were sent during the iteration over the change list were successful.\r\n"},"comment":{"url":"https://api.github.com/repos/handshake/pg2kinesis/issues/comments/364338220","html_url":"https://github.com/handshake/pg2kinesis/pull/6#issuecomment-364338220","issue_url":"https://api.github.com/repos/handshake/pg2kinesis/issues/6","id":364338220,"user":{"login":"abconway","id":3363785,"avatar_url":"https://avatars3.githubusercontent.com/u/3363785?v=4","gravatar_id":"","url":"https://api.github.com/users/abconway","html_url":"https://github.com/abconway","followers_url":"https://api.github.com/users/abconway/followers","following_url":"https://api.github.com/users/abconway/following{/other_user}","gists_url":"https://api.github.com/users/abconway/gists{/gist_id}","starred_url":"https://api.github.com/users/abconway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abconway/subscriptions","organizations_url":"https://api.github.com/users/abconway/orgs","repos_url":"https://api.github.com/users/abconway/repos","events_url":"https://api.github.com/users/abconway/events{/privacy}","received_events_url":"https://api.github.com/users/abconway/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T05:21:18Z","updated_at":"2018-02-09T05:21:18Z","author_association":"NONE","body":"Hi @gajohnson, I took a look at your branch.  Nothing in it is breaking on my end.  If you're ready, feel free to merge your branch and close my PR.  Thanks again for your responsiveness!"}}
{"actor":{"display_login":"abconway"}}