{"action":"created","issue":{"url":"https://api.github.com/repos/knative/serving/issues/2300","repository_url":"https://api.github.com/repos/knative/serving","labels_url":"https://api.github.com/repos/knative/serving/issues/2300/labels{/name}","comments_url":"https://api.github.com/repos/knative/serving/issues/2300/comments","events_url":"https://api.github.com/repos/knative/serving/issues/2300/events","html_url":"https://github.com/knative/serving/issues/2300","id":373423214,"node_id":"MDU6SXNzdWUzNzM0MjMyMTQ=","number":2300,"title":"serving.yaml should not include elastic search image","user":{"login":"glyn","id":94953,"node_id":"MDQ6VXNlcjk0OTUz","avatar_url":"https://avatars3.githubusercontent.com/u/94953?v=4","gravatar_id":"","url":"https://api.github.com/users/glyn","html_url":"https://github.com/glyn","followers_url":"https://api.github.com/users/glyn/followers","following_url":"https://api.github.com/users/glyn/following{/other_user}","gists_url":"https://api.github.com/users/glyn/gists{/gist_id}","starred_url":"https://api.github.com/users/glyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyn/subscriptions","organizations_url":"https://api.github.com/users/glyn/orgs","repos_url":"https://api.github.com/users/glyn/repos","events_url":"https://api.github.com/users/glyn/events{/privacy}","received_events_url":"https://api.github.com/users/glyn/received_events","type":"User","site_admin":false},"labels":[{"id":868660853,"node_id":"MDU6TGFiZWw4Njg2NjA4NTM=","url":"https://api.github.com/repos/knative/serving/labels/area/monitoring","name":"area/monitoring","color":"fbca04","default":false},{"id":874441804,"node_id":"MDU6TGFiZWw4NzQ0NDE4MDQ=","url":"https://api.github.com/repos/knative/serving/labels/area/test-and-release","name":"area/test-and-release","color":"daef5f","default":false},{"id":917112268,"node_id":"MDU6TGFiZWw5MTcxMTIyNjg=","url":"https://api.github.com/repos/knative/serving/labels/kind/cleanup","name":"kind/cleanup","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-24T10:54:57Z","updated_at":"2018-10-24T14:08:50Z","closed_at":null,"author_association":"MEMBER","body":"<!--\r\nPro-tip: You can leave this block commented, and it still works!\r\n\r\nSelect the appropriate areas for your issue:\r\n\r\n/area monitoring\r\n/area test-and-release\r\n\r\nClassify what kind of issue this is:\r\n\r\n/kind cleanup\r\n\r\n-->\r\n\r\n## Expected Behavior\r\n\r\nserving.yaml should not include the elastic search image since that is part of a monitoring feature. It should be moved to release.yaml.\r\n\r\n## Actual Behavior\r\n\r\nserving.yaml includes the elastic search image:\r\n\r\n```\r\n---\r\napiVersion: caching.internal.knative.dev/v1alpha1\r\nkind: Image\r\nmetadata:\r\n  name: fluentd-sidecar\r\n  namespace: knative-serving\r\nspec:\r\n  image: k8s.gcr.io/fluentd-elasticsearch:v2.0.4\r\n```\r\n\r\n## Steps to Reproduce the Problem\r\n\r\n  1. Inspect [serving.yaml](https://storage.googleapis.com/knative-releases/serving/latest/serving.yaml)\r\n\r\n## Additional Info\r\n\r\nThe elastic search image is included in knative/serving in [config/999-cache.yaml](https://github.com/knative/serving/blob/9361f9ef4ed66afe12755b8cca2d47eebd7935b4/config/999-cache.yaml) and referred to by logging configuration in [config/config-observability.yaml](https://github.com/knative/serving/blob/91f0bde62eb2f75f3811f7fbfe002a537b50056e/config/config-observability.yaml). The logging configuration is read by [observability.go](https://github.com/knative/serving/blob/e40c552261f090185aa266c1d8f199be9cc2414a/pkg/reconciler/v1alpha1/revision/config/observability.go) and then [deploy.go](https://github.com/knative/serving/blob/001f524512d7fdc25d6989903cc84ed380542b23/pkg/reconciler/v1alpha1/revision/resources/deploy.go#L127) includes a container for the elastic search image as a sidecar in a revision's pod if var log collection is configured. var log collection is a monitoring feature.\r\n"},"comment":{"url":"https://api.github.com/repos/knative/serving/issues/comments/432672791","html_url":"https://github.com/knative/serving/issues/2300#issuecomment-432672791","issue_url":"https://api.github.com/repos/knative/serving/issues/2300","id":432672791,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjY3Mjc5MQ==","user":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T14:08:50Z","updated_at":"2018-10-24T14:08:50Z","author_association":"MEMBER","body":"> I believe, at this time, creating that object has no effect. There's nothing included in the serving release that takes actions on those objects.\r\n\r\nCorrect, this is an extension point, and it's unclear whether we'd ever bundle an implementation, since caching has so many cost trade-offs.  That said, you can installing PoC implementations today that start acting on these resources and giving them substance.  I have a branch that does this on https://github.com/mattmoor/warm-image\r\n\r\n"}}
{"actor":{"display_login":"mattmoor"}}