{"action":"created","issue":{"url":"https://api.github.com/repos/Yoast/search-index-purge/issues/53","repository_url":"https://api.github.com/repos/Yoast/search-index-purge","labels_url":"https://api.github.com/repos/Yoast/search-index-purge/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/Yoast/search-index-purge/issues/53/comments","events_url":"https://api.github.com/repos/Yoast/search-index-purge/issues/53/events","html_url":"https://github.com/Yoast/search-index-purge/pull/53","id":334902710,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NzU3NDY4","number":53,"title":"Build: Add phpcs ruleset and travis check","user":{"login":"jrfnl","id":663378,"node_id":"MDQ6VXNlcjY2MzM3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/663378?v=4","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"labels":[{"id":947907863,"node_id":"MDU6TGFiZWw5NDc5MDc4NjM=","url":"https://api.github.com/repos/Yoast/search-index-purge/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":954277165,"node_id":"MDU6TGFiZWw5NTQyNzcxNjU=","url":"https://api.github.com/repos/Yoast/search-index-purge/labels/yoast%20cs","name":"yoast cs","color":"669ec4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-22T14:37:50Z","updated_at":"2018-06-26T07:28:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Yoast/search-index-purge/pulls/53","html_url":"https://github.com/Yoast/search-index-purge/pull/53","diff_url":"https://github.com/Yoast/search-index-purge/pull/53.diff","patch_url":"https://github.com/Yoast/search-index-purge/pull/53.patch"},"body":"Please see the individual commits for more info.\r\n\r\n@moorscode Currently `warning`s will not break the build. There is only one (1) warning left now and I'm not sure whether or not this issue should be actioned.\r\n\r\n```\r\nFILE: src\\attachment-page-server.php\r\n------------------------------------------------------------------------------------------\r\nFOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE\r\n------------------------------------------------------------------------------------------\r\n 39 | WARNING | File operations should use WP_Filesystem methods instead of direct PHP\r\n    |         | filesystem calls. Found: fopen()\r\n    |         | (WordPress.WP.AlternativeFunctions.file_system_read_fopen)\r\n------------------------------------------------------------------------------------------\r\n```\r\n\r\nI could open a `technical-debt` issue for this and temporarily ignore the `warning` òr if it isn't really an issue, I could add an inline whitelist comment.\r\n\r\nIf either of the above two actions is taken, we can let the build fail on `warning`s as well.\r\n\r\n\r\nOther notes:\r\n* I have not added a `composer.lock` file as all dependencies are `dev` dependencies, so as long as the version restrictions are set properly (which they should be), this should be fine.\r\n"},"comment":{"url":"https://api.github.com/repos/Yoast/search-index-purge/issues/comments/400208206","html_url":"https://github.com/Yoast/search-index-purge/pull/53#issuecomment-400208206","issue_url":"https://api.github.com/repos/Yoast/search-index-purge/issues/53","id":400208206,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDIwODIwNg==","user":{"login":"moorscode","id":2005352,"node_id":"MDQ6VXNlcjIwMDUzNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2005352?v=4","gravatar_id":"","url":"https://api.github.com/users/moorscode","html_url":"https://github.com/moorscode","followers_url":"https://api.github.com/users/moorscode/followers","following_url":"https://api.github.com/users/moorscode/following{/other_user}","gists_url":"https://api.github.com/users/moorscode/gists{/gist_id}","starred_url":"https://api.github.com/users/moorscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorscode/subscriptions","organizations_url":"https://api.github.com/users/moorscode/orgs","repos_url":"https://api.github.com/users/moorscode/repos","events_url":"https://api.github.com/users/moorscode/events{/privacy}","received_events_url":"https://api.github.com/users/moorscode/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T07:28:21Z","updated_at":"2018-06-26T07:28:21Z","author_association":"MEMBER","body":"Please add an inline ignore for the `fopen` command.\r\nThis is a file-read on a media item, which is the most optimal way to resolve the functionality we need.\r\n\r\nOther than that the PR looks good!"}}
{"actor":{"display_login":"moorscode"}}