{"action":"closed","issue":{"url":"https://api.github.com/repos/awslabs/aws-app-mesh-examples/issues/49","repository_url":"https://api.github.com/repos/awslabs/aws-app-mesh-examples","labels_url":"https://api.github.com/repos/awslabs/aws-app-mesh-examples/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/awslabs/aws-app-mesh-examples/issues/49/comments","events_url":"https://api.github.com/repos/awslabs/aws-app-mesh-examples/issues/49/events","html_url":"https://github.com/awslabs/aws-app-mesh-examples/issues/49","id":386282593,"node_id":"MDU6SXNzdWUzODYyODI1OTM=","number":49,"title":"Clarification of \"serviceNames\" field across virtualRouter and virtualNodes","user":{"login":"zbintliff","id":7526039,"node_id":"MDQ6VXNlcjc1MjYwMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/7526039?v=4","gravatar_id":"","url":"https://api.github.com/users/zbintliff","html_url":"https://github.com/zbintliff","followers_url":"https://api.github.com/users/zbintliff/followers","following_url":"https://api.github.com/users/zbintliff/following{/other_user}","gists_url":"https://api.github.com/users/zbintliff/gists{/gist_id}","starred_url":"https://api.github.com/users/zbintliff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbintliff/subscriptions","organizations_url":"https://api.github.com/users/zbintliff/orgs","repos_url":"https://api.github.com/users/zbintliff/repos","events_url":"https://api.github.com/users/zbintliff/events{/privacy}","received_events_url":"https://api.github.com/users/zbintliff/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-11-30T17:33:50Z","updated_at":"2018-12-03T19:35:35Z","closed_at":"2018-12-03T19:35:35Z","author_association":"NONE","body":"From my understanding the [`\"serviceNames\"` in virtualRouters](https://github.com/awslabs/aws-app-mesh-examples/blob/master/examples/apps/colorapp/servicemesh/config/virtualrouters/colorteller-virtualrouter.json#L4) appmesh updates for you to point to the virtualRouters you define. That is if you define serviceNames \"a\" and \"b\" it will update the records in AWS Service discovery to point to your virtualRouters.\r\n\r\nHowever, in the [\"serviceName\"](https://github.com/awslabs/aws-app-mesh-examples/blob/master/examples/apps/colorapp/servicemesh/config/virtualnodes/colorteller-black-virtualnode.json#L13) referenced here it is purely referential and lookup based.\r\n\r\nI was conflating the two thinking they were _both_ referential (i.e. the service names the router will point _to_)\r\n\r\nIs my current understanding correct?"}}
{"actor":{"display_login":"kiranmeduri"}}