{"action":"created","comment":{"url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/comments/234594738","pull_request_review_id":176266111,"id":234594738,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDU5NDczOA==","diff_hunk":"@@ -48,6 +48,15 @@ trait UserProfileStorageClient {\n    */\n   def getBaseAttribute(userId: UserId, name: String): Future[Option[Json]]\n \n+  /**\n+   * Retrieves a subset of base attributes of a user.\n+   *\n+   * @param userId the identifier of the user\n+   * @param userAttributes a set of attributes we want to fetch\n+   * @return a `Future` with the attributes values wrapped in a `Some` if the user exists, `None` otherwise.\n+   */\n+  def getSubsetBaseAttributes(userId: UserId, userAttributes: Set[String]): Future[Option[UserAttributes]]","path":"src/main/scala/eu/shiftforward/adstax/ups/api/UserProfileStorageClient.scala","position":null,"original_position":11,"commit_id":"ab8c0804ce2c63351714cbc1729a52a2f5e8e2b2","original_commit_id":"fdadfa2121a295c6d326837d7b538dd45caf9807","user":{"login":"jcazevedo","id":143188,"node_id":"MDQ6VXNlcjE0MzE4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/143188?v=4","gravatar_id":"","url":"https://api.github.com/users/jcazevedo","html_url":"https://github.com/jcazevedo","followers_url":"https://api.github.com/users/jcazevedo/followers","following_url":"https://api.github.com/users/jcazevedo/following{/other_user}","gists_url":"https://api.github.com/users/jcazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcazevedo/subscriptions","organizations_url":"https://api.github.com/users/jcazevedo/orgs","repos_url":"https://api.github.com/users/jcazevedo/repos","events_url":"https://api.github.com/users/jcazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/jcazevedo/received_events","type":"User","site_admin":false},"body":"It just seems more convenient to me to call the method as `getBaseAttributes(userId, \"attr1\", \"attr2\")` than `getBaseAttributes(userId, List(\"attr1\", \"attr2\"))`.","created_at":"2018-11-19T12:08:50Z","updated_at":"2018-11-19T12:08:51Z","html_url":"https://github.com/velocidi/adstax-sdk-scala/pull/70#discussion_r234594738","pull_request_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/70","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/comments/234594738"},"html":{"href":"https://github.com/velocidi/adstax-sdk-scala/pull/70#discussion_r234594738"},"pull_request":{"href":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/70"}},"in_reply_to_id":234587333},"pull_request":{"url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/70","id":231473984,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDczOTg0","html_url":"https://github.com/velocidi/adstax-sdk-scala/pull/70","diff_url":"https://github.com/velocidi/adstax-sdk-scala/pull/70.diff","patch_url":"https://github.com/velocidi/adstax-sdk-scala/pull/70.patch","issue_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/issues/70","number":70,"state":"open","locked":false,"title":"Ups subset attributes method","user":{"login":"dimamo5","id":7342443,"node_id":"MDQ6VXNlcjczNDI0NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7342443?v=4","gravatar_id":"","url":"https://api.github.com/users/dimamo5","html_url":"https://github.com/dimamo5","followers_url":"https://api.github.com/users/dimamo5/followers","following_url":"https://api.github.com/users/dimamo5/following{/other_user}","gists_url":"https://api.github.com/users/dimamo5/gists{/gist_id}","starred_url":"https://api.github.com/users/dimamo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimamo5/subscriptions","organizations_url":"https://api.github.com/users/dimamo5/orgs","repos_url":"https://api.github.com/users/dimamo5/repos","events_url":"https://api.github.com/users/dimamo5/events{/privacy}","received_events_url":"https://api.github.com/users/dimamo5/received_events","type":"User","site_admin":false},"body":"This PR adds a new endpoint to ups for retrieving a subset of base attributes for a specific user.","created_at":"2018-11-16T09:57:38Z","updated_at":"2018-11-19T12:08:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47d78a98d90d70f807b9c29de0d86c094deb9938","assignee":{"login":"jcazevedo","id":143188,"node_id":"MDQ6VXNlcjE0MzE4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/143188?v=4","gravatar_id":"","url":"https://api.github.com/users/jcazevedo","html_url":"https://github.com/jcazevedo","followers_url":"https://api.github.com/users/jcazevedo/followers","following_url":"https://api.github.com/users/jcazevedo/following{/other_user}","gists_url":"https://api.github.com/users/jcazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcazevedo/subscriptions","organizations_url":"https://api.github.com/users/jcazevedo/orgs","repos_url":"https://api.github.com/users/jcazevedo/repos","events_url":"https://api.github.com/users/jcazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/jcazevedo/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcazevedo","id":143188,"node_id":"MDQ6VXNlcjE0MzE4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/143188?v=4","gravatar_id":"","url":"https://api.github.com/users/jcazevedo","html_url":"https://github.com/jcazevedo","followers_url":"https://api.github.com/users/jcazevedo/followers","following_url":"https://api.github.com/users/jcazevedo/following{/other_user}","gists_url":"https://api.github.com/users/jcazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcazevedo/subscriptions","organizations_url":"https://api.github.com/users/jcazevedo/orgs","repos_url":"https://api.github.com/users/jcazevedo/repos","events_url":"https://api.github.com/users/jcazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/jcazevedo/received_events","type":"User","site_admin":false},{"login":"dimamo5","id":7342443,"node_id":"MDQ6VXNlcjczNDI0NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7342443?v=4","gravatar_id":"","url":"https://api.github.com/users/dimamo5","html_url":"https://github.com/dimamo5","followers_url":"https://api.github.com/users/dimamo5/followers","following_url":"https://api.github.com/users/dimamo5/following{/other_user}","gists_url":"https://api.github.com/users/dimamo5/gists{/gist_id}","starred_url":"https://api.github.com/users/dimamo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimamo5/subscriptions","organizations_url":"https://api.github.com/users/dimamo5/orgs","repos_url":"https://api.github.com/users/dimamo5/repos","events_url":"https://api.github.com/users/dimamo5/events{/privacy}","received_events_url":"https://api.github.com/users/dimamo5/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/70/commits","review_comments_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/70/comments","review_comment_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/issues/70/comments","statuses_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/statuses/ab8c0804ce2c63351714cbc1729a52a2f5e8e2b2","head":{"label":"velocidi:ups-subset-attributes-method","ref":"ups-subset-attributes-method","sha":"ab8c0804ce2c63351714cbc1729a52a2f5e8e2b2","user":{"login":"velocidi","id":8525231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MjUyMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8525231?v=4","gravatar_id":"","url":"https://api.github.com/users/velocidi","html_url":"https://github.com/velocidi","followers_url":"https://api.github.com/users/velocidi/followers","following_url":"https://api.github.com/users/velocidi/following{/other_user}","gists_url":"https://api.github.com/users/velocidi/gists{/gist_id}","starred_url":"https://api.github.com/users/velocidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velocidi/subscriptions","organizations_url":"https://api.github.com/users/velocidi/orgs","repos_url":"https://api.github.com/users/velocidi/repos","events_url":"https://api.github.com/users/velocidi/events{/privacy}","received_events_url":"https://api.github.com/users/velocidi/received_events","type":"Organization","site_admin":false},"repo":{"id":63863997,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzg2Mzk5Nw==","name":"adstax-sdk-scala","full_name":"velocidi/adstax-sdk-scala","private":false,"owner":{"login":"velocidi","id":8525231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MjUyMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8525231?v=4","gravatar_id":"","url":"https://api.github.com/users/velocidi","html_url":"https://github.com/velocidi","followers_url":"https://api.github.com/users/velocidi/followers","following_url":"https://api.github.com/users/velocidi/following{/other_user}","gists_url":"https://api.github.com/users/velocidi/gists{/gist_id}","starred_url":"https://api.github.com/users/velocidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velocidi/subscriptions","organizations_url":"https://api.github.com/users/velocidi/orgs","repos_url":"https://api.github.com/users/velocidi/repos","events_url":"https://api.github.com/users/velocidi/events{/privacy}","received_events_url":"https://api.github.com/users/velocidi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/velocidi/adstax-sdk-scala","description":"Tools for programmatic interaction with an AdStax instance using Scala","fork":false,"url":"https://api.github.com/repos/velocidi/adstax-sdk-scala","forks_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/forks","keys_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/teams","hooks_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/hooks","issue_events_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/issues/events{/number}","events_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/events","assignees_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/assignees{/user}","branches_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/branches{/branch}","tags_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/tags","blobs_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/languages","stargazers_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/stargazers","contributors_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/contributors","subscribers_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/subscribers","subscription_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/subscription","commits_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/contents/{+path}","compare_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/merges","archive_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/downloads","issues_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/issues{/number}","pulls_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/labels{/name}","releases_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/releases{/id}","deployments_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/deployments","created_at":"2016-07-21T11:32:44Z","updated_at":"2018-11-13T11:50:39Z","pushed_at":"2018-11-19T12:04:10Z","git_url":"git://github.com/velocidi/adstax-sdk-scala.git","ssh_url":"git@github.com:velocidi/adstax-sdk-scala.git","clone_url":"https://github.com/velocidi/adstax-sdk-scala.git","svn_url":"https://github.com/velocidi/adstax-sdk-scala","homepage":null,"size":632,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"velocidi:master","ref":"master","sha":"4a4e9a26bac094784719a704ea34d46af81011d7","user":{"login":"velocidi","id":8525231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MjUyMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8525231?v=4","gravatar_id":"","url":"https://api.github.com/users/velocidi","html_url":"https://github.com/velocidi","followers_url":"https://api.github.com/users/velocidi/followers","following_url":"https://api.github.com/users/velocidi/following{/other_user}","gists_url":"https://api.github.com/users/velocidi/gists{/gist_id}","starred_url":"https://api.github.com/users/velocidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velocidi/subscriptions","organizations_url":"https://api.github.com/users/velocidi/orgs","repos_url":"https://api.github.com/users/velocidi/repos","events_url":"https://api.github.com/users/velocidi/events{/privacy}","received_events_url":"https://api.github.com/users/velocidi/received_events","type":"Organization","site_admin":false},"repo":{"id":63863997,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzg2Mzk5Nw==","name":"adstax-sdk-scala","full_name":"velocidi/adstax-sdk-scala","private":false,"owner":{"login":"velocidi","id":8525231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MjUyMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8525231?v=4","gravatar_id":"","url":"https://api.github.com/users/velocidi","html_url":"https://github.com/velocidi","followers_url":"https://api.github.com/users/velocidi/followers","following_url":"https://api.github.com/users/velocidi/following{/other_user}","gists_url":"https://api.github.com/users/velocidi/gists{/gist_id}","starred_url":"https://api.github.com/users/velocidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velocidi/subscriptions","organizations_url":"https://api.github.com/users/velocidi/orgs","repos_url":"https://api.github.com/users/velocidi/repos","events_url":"https://api.github.com/users/velocidi/events{/privacy}","received_events_url":"https://api.github.com/users/velocidi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/velocidi/adstax-sdk-scala","description":"Tools for programmatic interaction with an AdStax instance using Scala","fork":false,"url":"https://api.github.com/repos/velocidi/adstax-sdk-scala","forks_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/forks","keys_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/teams","hooks_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/hooks","issue_events_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/issues/events{/number}","events_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/events","assignees_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/assignees{/user}","branches_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/branches{/branch}","tags_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/tags","blobs_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/languages","stargazers_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/stargazers","contributors_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/contributors","subscribers_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/subscribers","subscription_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/subscription","commits_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/contents/{+path}","compare_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/merges","archive_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/downloads","issues_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/issues{/number}","pulls_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/labels{/name}","releases_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/releases{/id}","deployments_url":"https://api.github.com/repos/velocidi/adstax-sdk-scala/deployments","created_at":"2016-07-21T11:32:44Z","updated_at":"2018-11-13T11:50:39Z","pushed_at":"2018-11-19T12:04:10Z","git_url":"git://github.com/velocidi/adstax-sdk-scala.git","ssh_url":"git@github.com:velocidi/adstax-sdk-scala.git","clone_url":"https://github.com/velocidi/adstax-sdk-scala.git","svn_url":"https://github.com/velocidi/adstax-sdk-scala","homepage":null,"size":632,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/70"},"html":{"href":"https://github.com/velocidi/adstax-sdk-scala/pull/70"},"issue":{"href":"https://api.github.com/repos/velocidi/adstax-sdk-scala/issues/70"},"comments":{"href":"https://api.github.com/repos/velocidi/adstax-sdk-scala/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/velocidi/adstax-sdk-scala/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/velocidi/adstax-sdk-scala/statuses/ab8c0804ce2c63351714cbc1729a52a2f5e8e2b2"}},"author_association":"NONE"}}
{"actor":{"display_login":"jcazevedo"}}