{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/165383358","pull_request_review_id":93311528,"id":165383358,"diff_hunk":"@@ -5120,14 +5121,28 @@ def concatenate_block_managers(mgrs_indexers, axes, concat_axis, copy):\n         elif is_uniform_join_units(join_units):\n             b = join_units[0].block.concat_same_type(\n                 [ju.block for ju in join_units], placement=placement)\n+        elif is_sparse_join_units(join_units):\n+            values = concatenate_join_units(join_units, concat_axis, copy=copy)\n+            values = values[0]","path":"pandas/core/internals.py","position":23,"original_position":23,"commit_id":"555fb91911c7c463b2d45bfcc29743f6bc1f3f9b","original_commit_id":"555fb91911c7c463b2d45bfcc29743f6bc1f3f9b","user":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"body":"I don't understand this line... A comment maybe? or is it incorrect?","created_at":"2018-02-01T15:07:15Z","updated_at":"2018-02-01T15:16:01Z","html_url":"https://github.com/pandas-dev/pandas/pull/19488#discussion_r165383358","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19488","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/165383358"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19488#discussion_r165383358"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19488"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19488","id":166471705,"html_url":"https://github.com/pandas-dev/pandas/pull/19488","diff_url":"https://github.com/pandas-dev/pandas/pull/19488.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/19488.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19488","number":19488,"state":"open","locked":false,"title":"First pass at fixing issues with SparseDataFrame merging","user":{"login":"hexgnu","id":138510,"avatar_url":"https://avatars3.githubusercontent.com/u/138510?v=4","gravatar_id":"","url":"https://api.github.com/users/hexgnu","html_url":"https://github.com/hexgnu","followers_url":"https://api.github.com/users/hexgnu/followers","following_url":"https://api.github.com/users/hexgnu/following{/other_user}","gists_url":"https://api.github.com/users/hexgnu/gists{/gist_id}","starred_url":"https://api.github.com/users/hexgnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexgnu/subscriptions","organizations_url":"https://api.github.com/users/hexgnu/orgs","repos_url":"https://api.github.com/users/hexgnu/repos","events_url":"https://api.github.com/users/hexgnu/events{/privacy}","received_events_url":"https://api.github.com/users/hexgnu/received_events","type":"User","site_admin":false},"body":"- [ ] closes #13665 \r\n- [ ] tests added / passed\r\n- [ ] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [x] whatsnew entry\r\n\r\nThis is still an in progress thing... since this is pretty complected code that I'm trying to unravel.\r\n","created_at":"2018-02-01T08:27:34Z","updated_at":"2018-02-01T15:16:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcde9d8ba4bc32748f5af581b1c8d29332458f88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19488/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19488/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19488/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/555fb91911c7c463b2d45bfcc29743f6bc1f3f9b","head":{"label":"hexgnu:fix_for_merging_sparse_frames","ref":"fix_for_merging_sparse_frames","sha":"555fb91911c7c463b2d45bfcc29743f6bc1f3f9b","user":{"login":"hexgnu","id":138510,"avatar_url":"https://avatars3.githubusercontent.com/u/138510?v=4","gravatar_id":"","url":"https://api.github.com/users/hexgnu","html_url":"https://github.com/hexgnu","followers_url":"https://api.github.com/users/hexgnu/followers","following_url":"https://api.github.com/users/hexgnu/following{/other_user}","gists_url":"https://api.github.com/users/hexgnu/gists{/gist_id}","starred_url":"https://api.github.com/users/hexgnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexgnu/subscriptions","organizations_url":"https://api.github.com/users/hexgnu/orgs","repos_url":"https://api.github.com/users/hexgnu/repos","events_url":"https://api.github.com/users/hexgnu/events{/privacy}","received_events_url":"https://api.github.com/users/hexgnu/received_events","type":"User","site_admin":false},"repo":{"id":114594266,"name":"pandas","full_name":"hexgnu/pandas","owner":{"login":"hexgnu","id":138510,"avatar_url":"https://avatars3.githubusercontent.com/u/138510?v=4","gravatar_id":"","url":"https://api.github.com/users/hexgnu","html_url":"https://github.com/hexgnu","followers_url":"https://api.github.com/users/hexgnu/followers","following_url":"https://api.github.com/users/hexgnu/following{/other_user}","gists_url":"https://api.github.com/users/hexgnu/gists{/gist_id}","starred_url":"https://api.github.com/users/hexgnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexgnu/subscriptions","organizations_url":"https://api.github.com/users/hexgnu/orgs","repos_url":"https://api.github.com/users/hexgnu/repos","events_url":"https://api.github.com/users/hexgnu/events{/privacy}","received_events_url":"https://api.github.com/users/hexgnu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hexgnu/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/hexgnu/pandas","forks_url":"https://api.github.com/repos/hexgnu/pandas/forks","keys_url":"https://api.github.com/repos/hexgnu/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hexgnu/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hexgnu/pandas/teams","hooks_url":"https://api.github.com/repos/hexgnu/pandas/hooks","issue_events_url":"https://api.github.com/repos/hexgnu/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/hexgnu/pandas/events","assignees_url":"https://api.github.com/repos/hexgnu/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/hexgnu/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/hexgnu/pandas/tags","blobs_url":"https://api.github.com/repos/hexgnu/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hexgnu/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hexgnu/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/hexgnu/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hexgnu/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/hexgnu/pandas/languages","stargazers_url":"https://api.github.com/repos/hexgnu/pandas/stargazers","contributors_url":"https://api.github.com/repos/hexgnu/pandas/contributors","subscribers_url":"https://api.github.com/repos/hexgnu/pandas/subscribers","subscription_url":"https://api.github.com/repos/hexgnu/pandas/subscription","commits_url":"https://api.github.com/repos/hexgnu/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/hexgnu/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/hexgnu/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/hexgnu/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/hexgnu/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/hexgnu/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hexgnu/pandas/merges","archive_url":"https://api.github.com/repos/hexgnu/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hexgnu/pandas/downloads","issues_url":"https://api.github.com/repos/hexgnu/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/hexgnu/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/hexgnu/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/hexgnu/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hexgnu/pandas/labels{/name}","releases_url":"https://api.github.com/repos/hexgnu/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/hexgnu/pandas/deployments","created_at":"2017-12-18T04:00:01Z","updated_at":"2017-12-18T04:00:08Z","pushed_at":"2018-02-01T13:26:16Z","git_url":"git://github.com/hexgnu/pandas.git","ssh_url":"git@github.com:hexgnu/pandas.git","clone_url":"https://github.com/hexgnu/pandas.git","svn_url":"https://github.com/hexgnu/pandas","homepage":"http://pandas.pydata.org","size":115360,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"ca4ae4f1798fb63c707c6cca79e1f586cae63391","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-02-01T13:46:33Z","pushed_at":"2018-02-01T14:28:46Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":115588,"stargazers_count":12726,"watchers_count":12726,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4936,"mirror_url":null,"archived":false,"open_issues_count":2309,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":4936,"open_issues":2309,"watchers":12726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19488"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19488"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19488"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19488/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19488/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19488/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/555fb91911c7c463b2d45bfcc29743f6bc1f3f9b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TomAugspurger"}}