{"push_id":3177200485,"size":14,"distinct_size":10,"ref":"refs/heads/transformer-elmo-docs","head":"cd6e226a3111c63284afacb6e27a1bc2c8e82b8b","before":"8be8d017a500f7c7dee195a8c5a1234e59cf9edb","commits":[{"sha":"1938a5af6d1ea3a2d8dccbb831f82990800fa3e1","author":{"name":"Joel Grus","email":"c966ca309f44877963eacb1c803ede295cfed488@gmail.com"},"message":"fix completely masked case in BooleanAccuracy (#2230)\n\n* fix completely masked case in BooleanAccuracy\r\n\r\n* fix dtypes\r\n\r\n* really fix dtypes","distinct":false,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/1938a5af6d1ea3a2d8dccbb831f82990800fa3e1"},{"sha":"3f0953d19de3676ea82e642659fc96d90690e34d","author":{"name":"jbkjr","email":"e75894dbb939eba7d486018d02f94c8ddc0427fc@users.noreply.github.com"},"message":"change mislabeled variable in description (#2242)\n\nthe required parameter \"pretrained_model\" was mislabeled as \"pretrained_model_name\" in the documentation","distinct":false,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/3f0953d19de3676ea82e642659fc96d90690e34d"},{"sha":"e53b4f45c83c244d63da83e58cdd178da0b81224","author":{"name":"Mohan Zhou","email":"d8818726cdccd0dd942c4d9ff73bfccd482e1f87@163.com"},"message":"Allow loading model from path with ~ HOME (#2215)\n\nModify `allennlp/common/file_utils.py` to enable loading model\r\nlike this:\r\n\r\n    from allennlp.predictors import Predictor\r\n    predictor = Predictor.from_path(\"~/<model_file>\")\r\n\r\nIt doesn't affect the origin process of loading model.","distinct":false,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/e53b4f45c83c244d63da83e58cdd178da0b81224"},{"sha":"b5b9b4019f8195bb6c13bad66b8eecc243651c83","author":{"name":"WrRan","email":"2bbed8ce10fb2cf9133889c720fc8b8c90e472c6@outlook.com"},"message":"add some docstrings about parameter `force` (#2226)\n\nThere are some functions with their docstrings ignoring parameter `force` in `allennlp/commands/train.py`","distinct":false,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/b5b9b4019f8195bb6c13bad66b8eecc243651c83"},{"sha":"42e0815e71007ab155e4e00dd2cedfcf7be5ef54","author":{"name":"Brendan Roof","email":"d780a9db774205338f37341069f77f9ae88a0d0a@allenai.org"},"message":"Fix circular dependency. (#2257)\n\n- Fix for #2250","distinct":true,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/42e0815e71007ab155e4e00dd2cedfcf7be5ef54"},{"sha":"2f56765b9c588992f44b37e0de0455761a8654de","author":{"name":"Tingkai Zhang","email":"d0b4df338f71a48dc5fe0b87be13f4d3544ef7a3@outlook.com"},"message":"fix get_output_dim() for ElmoTokenEmbedder (#2234)\n\n1. Fix get_output_dim() of ElmoTokenEmbedder with projection\r\n2. Add test of get_output_dim() of ElmoTokenEmbedder with projection\r\n \r\n#2227","distinct":true,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/2f56765b9c588992f44b37e0de0455761a8654de"},{"sha":"cf67128018f0148498a27683601a17c49340db60","author":{"name":"Nelson Liu","email":"a4c2551e46066177b56cc51008d1e42edd832490@users.noreply.github.com"},"message":"Remove EpochTrackingBucketIterator (#2249)\n\nThis was deprecated in (at least) version v0.6.0, so it's due to be deleted (even though the original deprecation warning didn't mention this...oops)","distinct":true,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/cf67128018f0148498a27683601a17c49340db60"},{"sha":"a98481c88bdf09e884bc1c3ee3366aa027088098","author":{"name":"Nelson Liu","email":"a4c2551e46066177b56cc51008d1e42edd832490@users.noreply.github.com"},"message":"Remove deprecated batch_average argument to sequence ce with logits (#2247)\n\n* Remove deprecated batch_average argument to sequence ce with logits\r\n\r\n* Fix test\r\n\r\n* Fix lint","distinct":true,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/a98481c88bdf09e884bc1c3ee3366aa027088098"},{"sha":"3cff7d35714aaaa6db5cd1d9a46a338b945fb092","author":{"name":"Nelson Liu","email":"a4c2551e46066177b56cc51008d1e42edd832490@users.noreply.github.com"},"message":"Remove deprecated SpanPruner (#2248)\n\n* Remove deprecated SpanPruner\r\n\r\n* Remove mentions of spanpruner\r\n\r\n* Update tutorial to replace num_spans_to_keep with num_items_to_keep","distinct":true,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/3cff7d35714aaaa6db5cd1d9a46a338b945fb092"},{"sha":"fb587833084bf8f1a0cb172b5451e21d980f0d5f","author":{"name":"Nikhil Verma","email":"80436ddcb9bda942850eeea7d37fc747aef9081d@gmail.com"},"message":"Check for existing vocabulary before creating a new one (#2240) (#2261)\n\n* Check for existing vocabulary before creating a new one (#2240)\r\n\r\n* 2261: Check for recover flag before using existing vocabulary.","distinct":true,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/fb587833084bf8f1a0cb172b5451e21d980f0d5f"},{"sha":"ee02ed0fbef746ec0dc2175c3c063cc72f0e5550","author":{"name":"Nelson Liu","email":"a4c2551e46066177b56cc51008d1e42edd832490@users.noreply.github.com"},"message":"Fix multiGPU peak gpu memory test (#2254)\n\nThis test was failing on a multigpu machine i use:\r\n\r\n```\r\n$ py.test -k \"trainer_test\"\r\n=============================================================================================== test session starts ================================================================================================\r\nplatform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0\r\nrootdir: /home/nfliu/Documents/Github/allennlp, inifile: pytest.ini\r\nplugins: cov-2.5.1, flaky-3.4.0\r\ncollected 1161 items / 1140 deselected\r\n\r\nallennlp/tests/training/trainer_test.py .............F.......                                                                                                                                                [100%]\r\n\r\n===================================================================================================== FAILURES =====================================================================================================\r\n__________________________________________________________________________________ TestTrainer.test_trainer_can_run_multiple_gpu ___________________________________________________________________________________\r\n\r\nself = <allennlp.tests.training.trainer_test.TestTrainer testMethod=test_trainer_can_run_multiple_gpu>\r\n\r\n    @pytest.mark.skipif(torch.cuda.device_count() < 2,\r\n                        reason=\"Need multiple GPUs.\")\r\n    def test_trainer_can_run_multiple_gpu(self):\r\n\r\n        class MetaDataCheckWrapper(Model):\r\n            \"\"\"\r\n                Checks that the metadata field has been correctly split across the batch dimension\r\n                when running on multiple gpus.\r\n                \"\"\"\r\n            def __init__(self, model):\r\n                super().__init__(model.vocab)\r\n                self.model = model\r\n\r\n            def forward(self, **kwargs) -> Dict[str, torch.Tensor]:  # type: ignore # pylint: disable=arguments-differ\r\n                assert 'metadata' in kwargs and 'tags' in kwargs, \\\r\n                    f'tokens and metadata must be provided. Got {kwargs.keys()} instead.'\r\n                batch_size = kwargs['tokens']['tokens'].size()[0]\r\n                assert len(kwargs['metadata']) == batch_size, \\\r\n                    f'metadata must be split appropriately. Expected {batch_size} elements, ' \\\r\n                    f\"got {len(kwargs['metadata'])} elements.\"\r\n                return self.model.forward(**kwargs)\r\n\r\n        multigpu_iterator = BasicIterator(batch_size=4)\r\n        multigpu_iterator.index_with(self.vocab)\r\n        trainer = Trainer(MetaDataCheckWrapper(self.model), self.optimizer,\r\n                          multigpu_iterator, self.instances, num_epochs=2,\r\n                          cuda_device=[0, 1])\r\n        metrics = trainer.train()\r\n        assert 'peak_cpu_memory_MB' in metrics\r\n        assert isinstance(metrics['peak_cpu_memory_MB'], float)\r\n        assert metrics['peak_cpu_memory_MB'] > 0\r\n        assert 'peak_gpu_0_memory_MB' in metrics\r\n>       assert isinstance(metrics['peak_gpu_0_memory_MB'], float)\r\nE       AssertionError: assert False\r\nE        +  where False = isinstance(549, float)\r\n\r\nallennlp/tests/training/trainer_test.py:128: AssertionError\r\n----------------------------------------------------------------------------------------------- Captured stderr call -----------------------------------------------------------------------------------------------\r\n12/27/2018 09:34:40 - INFO - allennlp.common.checks -   Pytorch version: 0.4.1\r\n0it [00:00, ?it/s]12/27/2018 09:34:40 - INFO - allennlp.data.dataset_readers.sequence_tagging -   Reading instances from lines in file at: /home/nfliu/Documents/Github/allennlp/allennlp/tests/fixtures/data/sequence_tagging.tsv\r\n4it [00:00, 12409.18it/s]\r\n12/27/2018 09:34:40 - INFO - allennlp.data.vocabulary -   Fitting token dictionary from dataset.\r\n100%|██████████| 4/4 [00:00<00:00, 71392.41it/s]\r\n12/27/2018 09:34:40 - INFO - allennlp.common.from_params -   instantiating class <class 'allennlp.models.simple_tagger.SimpleTagger'> from params {'text_field_embedder': {'token_embedders': {'tokens': {'type': 'embedding', 'embedding_dim': 5}}}, 'encoder': {'type': 'lstm', 'input_size': 5, 'hidden_size': 7, 'num_layers': 2}} and extras {'vocab': <allennlp.data.vocabulary.Vocabulary object at 0x7fe36c0f5438>}\r\n12/27/2018 09:34:40 - INFO - allennlp.common.from_params -   instantiating class <class 'allennlp.modules.text_field_embedders.text_field_embedder.TextFieldEmbedder'> from params {'token_embedders': {'tokens': {'type': 'embedding', 'embedding_dim': 5}}} and extras {'vocab': <allennlp.data.vocabulary.Vocabulary object at 0x7fe36c0f5438>}\r\n12/27/2018 09:34:40 - INFO - allennlp.common.from_params -   instantiating class <class 'allennlp.modules.token_embedders.token_embedder.TokenEmbedder'> from params {'type': 'embedding', 'embedding_dim': 5} and extras {'vocab': <allennlp.data.vocabulary.Vocabulary object at 0x7fe36c0f5438>}\r\n12/27/2018 09:34:40 - INFO - allennlp.common.from_params -   instantiating class <class 'allennlp.modules.seq2seq_encoders.seq2seq_encoder.Seq2SeqEncoder'> from params {'type': 'lstm', 'input_size': 5, 'hidden_size': 7, 'num_layers': 2} and extras {'vocab': <allennlp.data.vocabulary.Vocabulary object at 0x7fe36c0f5438>}\r\n12/27/2018 09:34:40 - WARNING - allennlp.training.trainer -   Multiple GPU support is experimental not recommended for use. In some cases it may lead to incorrect results or undefined behavior.\r\n12/27/2018 09:34:40 - INFO - allennlp.training.trainer -   Beginning training.\r\n12/27/2018 09:34:40 - INFO - allennlp.training.trainer -   Epoch 0/1\r\n12/27/2018 09:34:40 - INFO - allennlp.training.trainer -   Peak CPU memory usage MB: 2121.256\r\n12/27/2018 09:34:40 - INFO - allennlp.training.trainer -   GPU 0 memory usage MB: 533\r\n12/27/2018 09:34:40 - INFO - allennlp.training.trainer -   GPU 1 memory usage MB: 10\r\n12/27/2018 09:34:40 - INFO - allennlp.training.trainer -   Training\r\n  0%|          | 0/1 [00:00<?, ?it/s]12/27/2018 09:34:40 - DEBUG - allennlp.data.iterators.data_iterator -   Batch padding lengths: {'tokens': {'tokens_length': 4, 'num_tokens': 4}, 'tags': {'num_tokens': 4}}\r\n12/27/2018 09:34:40 - DEBUG - allennlp.data.iterators.data_iterator -   Batch size: 4\r\nloss: 0.7543 ||: 100%|██████████| 1/1 [00:02<00:00,  2.04s/it]\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -                       Training |  Validation\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   loss            |     0.754  |       N/A\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   gpu_1_memory_MB |    10.000  |       N/A\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   gpu_0_memory_MB |   533.000  |       N/A\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   cpu_memory_MB   |  2121.256  |       N/A\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   Epoch duration: 00:00:02\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   Estimated training time remaining: 0:00:02\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   Epoch 1/1\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   Peak CPU memory usage MB: 3892.764\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   GPU 0 memory usage MB: 549\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   GPU 1 memory usage MB: 549\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   Training\r\n  0%|          | 0/1 [00:00<?, ?it/s]12/27/2018 09:34:42 - DEBUG - allennlp.data.iterators.data_iterator -   Batch padding lengths: {'tokens': {'tokens_length': 4, 'num_tokens': 4}, 'tags': {'num_tokens': 4}}\r\n12/27/2018 09:34:42 - DEBUG - allennlp.data.iterators.data_iterator -   Batch size: 4\r\nloss: 0.7522 ||: 100%|██████████| 1/1 [00:00<00:00, 59.00it/s]\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -                       Training |  Validation\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   loss            |     0.752  |       N/A\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   gpu_1_memory_MB |   549.000  |       N/A\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   gpu_0_memory_MB |   549.000  |       N/A\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   cpu_memory_MB   |  3892.764  |       N/A\r\n12/27/2018 09:34:42 - INFO - allennlp.training.trainer -   Epoch duration: 00:00:00\r\n------------------------------------------------------------------------------------------------ Captured log call -------------------------------------------------------------------------------------------------\r\n09:34:40 - INFO - allennlp.common.checks - Pytorch version: 0.4.1\r\n09:34:40 - INFO - allennlp.data.dataset_readers.sequence_tagging - Reading instances from lines in file at: /home/nfliu/Documents/Github/allennlp/allennlp/tests/fixtures/data/sequence_tagging.tsv\r\n09:34:40 - INFO - allennlp.data.vocabulary - Fitting token dictionary from dataset.\r\n09:34:40 - INFO - allennlp.common.from_params - instantiating class <class 'allennlp.models.simple_tagger.SimpleTagger'> from params {'text_field_embedder': {'token_embedders': {'tokens': {'type': 'embedding', 'embedding_dim': 5}}}, 'encoder': {'type': 'lstm', 'input_size': 5, 'hidden_size': 7, 'num_layers': 2}} and extras {'vocab': <allennlp.data.vocabulary.Vocabulary object at 0x7fe36c0f5438>}\r\n09:34:40 - INFO - allennlp.common.from_params - instantiating class <class 'allennlp.modules.text_field_embedders.text_field_embedder.TextFieldEmbedder'> from params {'token_embedders': {'tokens': {'type': 'embedding', 'embedding_dim': 5}}} and extras {'vocab': <allennlp.data.vocabulary.Vocabulary object at 0x7fe36c0f5438>}\r\n09:34:40 - INFO - allennlp.common.from_params - instantiating class <class 'allennlp.modules.token_embedders.token_embedder.TokenEmbedder'> from params {'type': 'embedding', 'embedding_dim': 5} and extras {'vocab': <allennlp.data.vocabulary.Vocabulary object at 0x7fe36c0f5438>}\r\n09:34:40 - INFO - allennlp.common.from_params - instantiating class <class 'allennlp.modules.seq2seq_encoders.seq2seq_encoder.Seq2SeqEncoder'> from params {'type': 'lstm', 'input_size': 5, 'hidden_size': 7, 'num_layers': 2} and extras {'vocab': <allennlp.data.vocabulary.Vocabulary object at 0x7fe36c0f5438>}\r\n09:34:40 - WARNING - allennlp.training.trainer - Multiple GPU support is experimental not recommended for use. In some cases it may lead to incorrect results or undefined behavior.\r\n09:34:40 - INFO - allennlp.training.trainer - Beginning training.\r\n09:34:40 - INFO - allennlp.training.trainer - Epoch 0/1\r\n09:34:40 - INFO - allennlp.training.trainer - Peak CPU memory usage MB: 2121.256\r\n09:34:40 - INFO - allennlp.training.trainer - GPU 0 memory usage MB: 533\r\n09:34:40 - INFO - allennlp.training.trainer - GPU 1 memory usage MB: 10\r\n09:34:40 - INFO - allennlp.training.trainer - Training\r\n09:34:40 - DEBUG - allennlp.data.iterators.data_iterator - Batch padding lengths: {'tokens': {'tokens_length': 4, 'num_tokens': 4}, 'tags': {'num_tokens': 4}}\r\n09:34:40 - DEBUG - allennlp.data.iterators.data_iterator - Batch size: 4\r\n09:34:42 - INFO - allennlp.training.trainer -                     Training |  Validation\r\n09:34:42 - INFO - allennlp.training.trainer - loss            |     0.754  |       N/A\r\n09:34:42 - INFO - allennlp.training.trainer - gpu_1_memory_MB |    10.000  |       N/A\r\n09:34:42 - INFO - allennlp.training.trainer - gpu_0_memory_MB |   533.000  |       N/A\r\n09:34:42 - INFO - allennlp.training.trainer - cpu_memory_MB   |  2121.256  |       N/A\r\n09:34:42 - INFO - allennlp.training.trainer - Epoch duration: 00:00:02\r\n09:34:42 - INFO - allennlp.training.trainer - Estimated training time remaining: 0:00:02\r\n09:34:42 - INFO - allennlp.training.trainer - Epoch 1/1\r\n09:34:42 - INFO - allennlp.training.trainer - Peak CPU memory usage MB: 3892.764\r\n09:34:42 - INFO - allennlp.training.trainer - GPU 0 memory usage MB: 549\r\n09:34:42 - INFO - allennlp.training.trainer - GPU 1 memory usage MB: 549\r\n09:34:42 - INFO - allennlp.training.trainer - Training\r\n09:34:42 - DEBUG - allennlp.data.iterators.data_iterator - Batch padding lengths: {'tokens': {'tokens_length': 4, 'num_tokens': 4}, 'tags': {'num_tokens': 4}}\r\n09:34:42 - DEBUG - allennlp.data.iterators.data_iterator - Batch size: 4\r\n09:34:42 - INFO - allennlp.training.trainer -                     Training |  Validation\r\n09:34:42 - INFO - allennlp.training.trainer - loss            |     0.752  |       N/A\r\n09:34:42 - INFO - allennlp.training.trainer - gpu_1_memory_MB |   549.000  |       N/A\r\n09:34:42 - INFO - allennlp.training.trainer - gpu_0_memory_MB |   549.000  |       N/A\r\n09:34:42 - INFO - allennlp.training.trainer - cpu_memory_MB   |  3892.764  |       N/A\r\n09:34:42 - INFO - allennlp.training.trainer - Epoch duration: 00:00:00\r\n===Flaky Test Report===\r\n\r\n\r\n===End Flaky Test Report===\r\n================================================================================================= warnings summary =================================================================================================\r\nallennlp/tests/training/trainer_test.py::TestTrainer::test_trainer_can_run_multiple_gpu\r\n  /home/nfliu/Documents/Github/allennlp/allennlp/modules/encoder_base.py:116: UserWarning: RNN module weights are not part of single contiguous chunk of memory. This means they need to be compacted at every call, possibly greatly increasing memory usage. To compact weights again call flatten_parameters().\r\n    module_output, final_states = module(packed_sequence_input, initial_states)\r\n  /home/nfliu/Documents/Github/allennlp/allennlp/modules/encoder_base.py:116: UserWarning: RNN module weights are not part of single contiguous chunk of memory. This means they need to be compacted at every call, possibly greatly increasing memory usage. To compact weights again call flatten_parameters().\r\n    module_output, final_states = module(packed_sequence_input, initial_states)\r\n\r\n-- Docs: http://doc.pytest.org/en/latest/warnings.html\r\n======================================================================== 1 failed, 20 passed, 1140 deselected, 2 warnings in 26.92 seconds =========================================================================\r\n```\r\n\r\nPretty sure it should be checking for `int` instead of `float`, since `common.util.gpu_memory_mb()` returns `Dict[int, int]`. See https://github.com/allenai/allennlp/blob/3f0953d19de3676ea82e642659fc96d90690e34d/allennlp/common/util.py#L327","distinct":true,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/ee02ed0fbef746ec0dc2175c3c063cc72f0e5550"},{"sha":"07d193ee1086db74d88db77bbbb6653feca1ea73","author":{"name":"HT Liu","email":"825d9de37beb3c221a6a0936f36005aa3ea7edb5@gmail.com"},"message":"clarify the \"num_output_representations\" more clear (#2256)","distinct":true,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/07d193ee1086db74d88db77bbbb6653feca1ea73"},{"sha":"6825483c875a0fdd9bc7e494ef06bdcb5f2ffb7c","author":{"name":"Brendan Roof","email":"d780a9db774205338f37341069f77f9ae88a0d0a@allenai.org"},"message":"Merge branch 'master' into transformer-elmo-docs","distinct":true,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/6825483c875a0fdd9bc7e494ef06bdcb5f2ffb7c"},{"sha":"cd6e226a3111c63284afacb6e27a1bc2c8e82b8b","author":{"name":"Brendan Roof","email":"d780a9db774205338f37341069f77f9ae88a0d0a@allenai.org"},"message":"Respond to feedback","distinct":true,"url":"https://api.github.com/repos/brendan-ai2/allennlp/commits/cd6e226a3111c63284afacb6e27a1bc2c8e82b8b"}]}
{"actor":{"display_login":"brendan-ai2"}}