{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/comments/184532784","pull_request_review_id":115751157,"id":184532784,"diff_hunk":"@@ -0,0 +1,28 @@\n+package io.fabric8.launcher.osio.providers;\n+\n+import org.apache.maven.model.Dependency;\n+\n+import javax.enterprise.context.ApplicationScoped;\n+import javax.enterprise.inject.Instance;\n+import javax.inject.Inject;\n+import javax.ws.rs.ext.ParamConverter;\n+import javax.ws.rs.ext.ParamConverterProvider;\n+import javax.ws.rs.ext.Provider;\n+import java.lang.annotation.Annotation;\n+import java.lang.reflect.Type;\n+\n+@Provider\n+@ApplicationScoped\n+public class DependencyParamConverterProvider implements ParamConverterProvider {\n+    @Inject\n+    private Instance<DependencyParamConverter> dependencyParamConverter;","path":"addons/osio-addon/src/main/java/io/fabric8/launcher/osio/providers/DependencyParamConverterProvider.java","position":18,"original_position":18,"commit_id":"ba79754411691e692ee2a94c2b55b303b830488d","original_commit_id":"ba79754411691e692ee2a94c2b55b303b830488d","user":{"login":"gastaldi","id":54133,"avatar_url":"https://avatars1.githubusercontent.com/u/54133?v=4","gravatar_id":"","url":"https://api.github.com/users/gastaldi","html_url":"https://github.com/gastaldi","followers_url":"https://api.github.com/users/gastaldi/followers","following_url":"https://api.github.com/users/gastaldi/following{/other_user}","gists_url":"https://api.github.com/users/gastaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/gastaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gastaldi/subscriptions","organizations_url":"https://api.github.com/users/gastaldi/orgs","repos_url":"https://api.github.com/users/gastaldi/repos","events_url":"https://api.github.com/users/gastaldi/events{/privacy}","received_events_url":"https://api.github.com/users/gastaldi/received_events","type":"User","site_admin":false},"body":"You can @Inject DependencyParamConverter directly here, since they share the same scope","created_at":"2018-04-26T21:14:22Z","updated_at":"2018-04-26T21:14:22Z","html_url":"https://github.com/fabric8-launcher/launcher-backend/pull/203#discussion_r184532784","pull_request_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/203","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/comments/184532784"},"html":{"href":"https://github.com/fabric8-launcher/launcher-backend/pull/203#discussion_r184532784"},"pull_request":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/203","id":175768939,"html_url":"https://github.com/fabric8-launcher/launcher-backend/pull/203","diff_url":"https://github.com/fabric8-launcher/launcher-backend/pull/203.diff","patch_url":"https://github.com/fabric8-launcher/launcher-backend/pull/203.patch","issue_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/issues/203","number":203,"state":"open","locked":false,"title":"feat(osio): insert dependencies into pom.xml","user":{"login":"ravsa","id":11839674,"avatar_url":"https://avatars3.githubusercontent.com/u/11839674?v=4","gravatar_id":"","url":"https://api.github.com/users/ravsa","html_url":"https://github.com/ravsa","followers_url":"https://api.github.com/users/ravsa/followers","following_url":"https://api.github.com/users/ravsa/following{/other_user}","gists_url":"https://api.github.com/users/ravsa/gists{/gist_id}","starred_url":"https://api.github.com/users/ravsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravsa/subscriptions","organizations_url":"https://api.github.com/users/ravsa/orgs","repos_url":"https://api.github.com/users/ravsa/repos","events_url":"https://api.github.com/users/ravsa/events{/privacy}","received_events_url":"https://api.github.com/users/ravsa/received_events","type":"User","site_admin":false},"body":"API end-point `/osio/launch` will have an optional field `dependency` which will take dependencies in the format of `dependency=groupId:artifactId:version&dependency=groupId:artifactId:version` from the dependency editor to insert the newly added dependencies into the pom.xml file of selected boosters.\r\n\r\nCloses: https://github.com/openshiftio/openshift.io/issues/2644\r\n","created_at":"2018-03-18T19:37:59Z","updated_at":"2018-04-26T21:14:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24a9ee5a65d24fd5aa3301a29554db841355d253","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":871537685,"url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/labels/:no_entry_sign:%20hold","name":":no_entry_sign: hold","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/203/commits","review_comments_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/203/comments","review_comment_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/issues/203/comments","statuses_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/statuses/ba79754411691e692ee2a94c2b55b303b830488d","head":{"label":"ravsa:dev-dependency-snapshot","ref":"dev-dependency-snapshot","sha":"ba79754411691e692ee2a94c2b55b303b830488d","user":{"login":"ravsa","id":11839674,"avatar_url":"https://avatars3.githubusercontent.com/u/11839674?v=4","gravatar_id":"","url":"https://api.github.com/users/ravsa","html_url":"https://github.com/ravsa","followers_url":"https://api.github.com/users/ravsa/followers","following_url":"https://api.github.com/users/ravsa/following{/other_user}","gists_url":"https://api.github.com/users/ravsa/gists{/gist_id}","starred_url":"https://api.github.com/users/ravsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravsa/subscriptions","organizations_url":"https://api.github.com/users/ravsa/orgs","repos_url":"https://api.github.com/users/ravsa/repos","events_url":"https://api.github.com/users/ravsa/events{/privacy}","received_events_url":"https://api.github.com/users/ravsa/received_events","type":"User","site_admin":false},"repo":{"id":125671170,"name":"launcher-backend","full_name":"ravsa/launcher-backend","owner":{"login":"ravsa","id":11839674,"avatar_url":"https://avatars3.githubusercontent.com/u/11839674?v=4","gravatar_id":"","url":"https://api.github.com/users/ravsa","html_url":"https://github.com/ravsa","followers_url":"https://api.github.com/users/ravsa/followers","following_url":"https://api.github.com/users/ravsa/following{/other_user}","gists_url":"https://api.github.com/users/ravsa/gists{/gist_id}","starred_url":"https://api.github.com/users/ravsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravsa/subscriptions","organizations_url":"https://api.github.com/users/ravsa/orgs","repos_url":"https://api.github.com/users/ravsa/repos","events_url":"https://api.github.com/users/ravsa/events{/privacy}","received_events_url":"https://api.github.com/users/ravsa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravsa/launcher-backend","description":"The fabric8-launcher backend","fork":true,"url":"https://api.github.com/repos/ravsa/launcher-backend","forks_url":"https://api.github.com/repos/ravsa/launcher-backend/forks","keys_url":"https://api.github.com/repos/ravsa/launcher-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravsa/launcher-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravsa/launcher-backend/teams","hooks_url":"https://api.github.com/repos/ravsa/launcher-backend/hooks","issue_events_url":"https://api.github.com/repos/ravsa/launcher-backend/issues/events{/number}","events_url":"https://api.github.com/repos/ravsa/launcher-backend/events","assignees_url":"https://api.github.com/repos/ravsa/launcher-backend/assignees{/user}","branches_url":"https://api.github.com/repos/ravsa/launcher-backend/branches{/branch}","tags_url":"https://api.github.com/repos/ravsa/launcher-backend/tags","blobs_url":"https://api.github.com/repos/ravsa/launcher-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravsa/launcher-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravsa/launcher-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravsa/launcher-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravsa/launcher-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/ravsa/launcher-backend/languages","stargazers_url":"https://api.github.com/repos/ravsa/launcher-backend/stargazers","contributors_url":"https://api.github.com/repos/ravsa/launcher-backend/contributors","subscribers_url":"https://api.github.com/repos/ravsa/launcher-backend/subscribers","subscription_url":"https://api.github.com/repos/ravsa/launcher-backend/subscription","commits_url":"https://api.github.com/repos/ravsa/launcher-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravsa/launcher-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravsa/launcher-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravsa/launcher-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravsa/launcher-backend/contents/{+path}","compare_url":"https://api.github.com/repos/ravsa/launcher-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravsa/launcher-backend/merges","archive_url":"https://api.github.com/repos/ravsa/launcher-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravsa/launcher-backend/downloads","issues_url":"https://api.github.com/repos/ravsa/launcher-backend/issues{/number}","pulls_url":"https://api.github.com/repos/ravsa/launcher-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/ravsa/launcher-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/ravsa/launcher-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravsa/launcher-backend/labels{/name}","releases_url":"https://api.github.com/repos/ravsa/launcher-backend/releases{/id}","deployments_url":"https://api.github.com/repos/ravsa/launcher-backend/deployments","created_at":"2018-03-17T21:40:48Z","updated_at":"2018-03-17T21:40:51Z","pushed_at":"2018-04-26T20:35:02Z","git_url":"git://github.com/ravsa/launcher-backend.git","ssh_url":"git@github.com:ravsa/launcher-backend.git","clone_url":"https://github.com/ravsa/launcher-backend.git","svn_url":"https://github.com/ravsa/launcher-backend","homepage":null,"size":35947,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-launcher:master","ref":"master","sha":"2f9216a749a1b3b4f570148c72f12777c92664a7","user":{"login":"fabric8-launcher","id":32217730,"avatar_url":"https://avatars2.githubusercontent.com/u/32217730?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-launcher","html_url":"https://github.com/fabric8-launcher","followers_url":"https://api.github.com/users/fabric8-launcher/followers","following_url":"https://api.github.com/users/fabric8-launcher/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-launcher/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-launcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-launcher/subscriptions","organizations_url":"https://api.github.com/users/fabric8-launcher/orgs","repos_url":"https://api.github.com/users/fabric8-launcher/repos","events_url":"https://api.github.com/users/fabric8-launcher/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-launcher/received_events","type":"Organization","site_admin":false},"repo":{"id":111528311,"name":"launcher-backend","full_name":"fabric8-launcher/launcher-backend","owner":{"login":"fabric8-launcher","id":32217730,"avatar_url":"https://avatars2.githubusercontent.com/u/32217730?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-launcher","html_url":"https://github.com/fabric8-launcher","followers_url":"https://api.github.com/users/fabric8-launcher/followers","following_url":"https://api.github.com/users/fabric8-launcher/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-launcher/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-launcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-launcher/subscriptions","organizations_url":"https://api.github.com/users/fabric8-launcher/orgs","repos_url":"https://api.github.com/users/fabric8-launcher/repos","events_url":"https://api.github.com/users/fabric8-launcher/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-launcher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-launcher/launcher-backend","description":"The fabric8-launcher backend","fork":false,"url":"https://api.github.com/repos/fabric8-launcher/launcher-backend","forks_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/forks","keys_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/teams","hooks_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/hooks","issue_events_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/events","assignees_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/tags","blobs_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/languages","stargazers_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/stargazers","contributors_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/contributors","subscribers_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/subscribers","subscription_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/subscription","commits_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/merges","archive_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/downloads","issues_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-launcher/launcher-backend/deployments","created_at":"2017-11-21T09:35:55Z","updated_at":"2018-04-26T18:28:15Z","pushed_at":"2018-04-26T20:35:03Z","git_url":"git://github.com/fabric8-launcher/launcher-backend.git","ssh_url":"git@github.com:fabric8-launcher/launcher-backend.git","clone_url":"https://github.com/fabric8-launcher/launcher-backend.git","svn_url":"https://github.com/fabric8-launcher/launcher-backend","homepage":null,"size":35979,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":28,"open_issues":20,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/203"},"html":{"href":"https://github.com/fabric8-launcher/launcher-backend/pull/203"},"issue":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-backend/issues/203"},"comments":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-backend/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-backend/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-backend/statuses/ba79754411691e692ee2a94c2b55b303b830488d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gastaldi"}}