{"action":"created","comment":{"url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments/194880335","pull_request_review_id":128138491,"id":194880335,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDg4MDMzNQ==","diff_hunk":"@@ -6,19 +6,19 @@ defmodule Thrift.Parser.ParserTest do\n \n   import Thrift.Parser, only: [parse: 1, parse: 2, parse_file: 2]\n \n-  alias Thrift.Parser.Models.Constant\n-  alias Thrift.Parser.Models.Exception\n-  alias Thrift.Parser.Models.Field\n-  alias Thrift.Parser.Models.Function\n-  alias Thrift.Parser.Models.Include\n-  alias Thrift.Parser.Models.Namespace\n-  alias Thrift.Parser.Models.Schema\n-  alias Thrift.Parser.Models.Service\n-  alias Thrift.Parser.Models.Struct\n-  alias Thrift.Parser.Models.TypeRef\n-  alias Thrift.Parser.Models.TEnum\n-  alias Thrift.Parser.Models.Union\n-  alias Thrift.Parser.Models.ValueRef\n+  alias Thrift.AST.Constant\n+  alias Thrift.AST.Exception\n+  alias Thrift.AST.Field\n+  alias Thrift.AST.Function\n+  alias Thrift.AST.Include\n+  alias Thrift.AST.Namespace\n+  alias Thrift.AST.Schema\n+  alias Thrift.AST.Service\n+  alias Thrift.AST.Struct\n+  alias Thrift.AST.TypeRef\n+  alias Thrift.AST.TEnum\n+  alias Thrift.AST.Union\n+  alias Thrift.AST.ValueRef","path":"test/thrift/parser/parser_test.exs","position":29,"original_position":29,"commit_id":"bed5f6d99eeebfd0407842dddb36e4da5591beeb","original_commit_id":"bed5f6d99eeebfd0407842dddb36e4da5591beeb","user":{"login":"ebert[bot]","id":23344435,"node_id":"MDM6Qm90MjMzNDQ0MzU=","avatar_url":"https://avatars3.githubusercontent.com/in/597?v=4","gravatar_id":"","url":"https://api.github.com/users/ebert%5Bbot%5D","html_url":"https://github.com/apps/ebert","followers_url":"https://api.github.com/users/ebert%5Bbot%5D/followers","following_url":"https://api.github.com/users/ebert%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/ebert%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/ebert%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebert%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/ebert%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/ebert%5Bbot%5D/repos","events_url":"https://api.github.com/users/ebert%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/ebert%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Most of the time you are using the multi-alias/require/import/use syntax, but here you are using multiple single directives","created_at":"2018-06-12T20:37:29Z","updated_at":"2018-06-12T20:37:29Z","html_url":"https://github.com/pinterest/elixir-thrift/pull/346#discussion_r194880335","pull_request_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/346","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments/194880335"},"html":{"href":"https://github.com/pinterest/elixir-thrift/pull/346#discussion_r194880335"},"pull_request":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/346","id":194400565,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDAwNTY1","html_url":"https://github.com/pinterest/elixir-thrift/pull/346","diff_url":"https://github.com/pinterest/elixir-thrift/pull/346.diff","patch_url":"https://github.com/pinterest/elixir-thrift/pull/346.patch","issue_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/346","number":346,"state":"open","locked":false,"title":"Move Thrift.Parser.Models to Thrift.AST","user":{"login":"jparise","id":10311,"node_id":"MDQ6VXNlcjEwMzEx","avatar_url":"https://avatars1.githubusercontent.com/u/10311?v=4","gravatar_id":"","url":"https://api.github.com/users/jparise","html_url":"https://github.com/jparise","followers_url":"https://api.github.com/users/jparise/followers","following_url":"https://api.github.com/users/jparise/following{/other_user}","gists_url":"https://api.github.com/users/jparise/gists{/gist_id}","starred_url":"https://api.github.com/users/jparise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jparise/subscriptions","organizations_url":"https://api.github.com/users/jparise/orgs","repos_url":"https://api.github.com/users/jparise/repos","events_url":"https://api.github.com/users/jparise/events{/privacy}","received_events_url":"https://api.github.com/users/jparise/received_events","type":"User","site_admin":false},"body":"This moves the nested Models into a more distinct top-level namespace.\r\nThere aren't any functional changes here, but it prefaces future work to\r\nbetter define the parsed (AST) representation of a Thrift file.","created_at":"2018-06-12T20:36:57Z","updated_at":"2018-06-12T20:37:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f6e73e86fd48704a85d740321140f24db0b8811","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/346/commits","review_comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/346/comments","review_comment_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/346/comments","statuses_url":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/bed5f6d99eeebfd0407842dddb36e4da5591beeb","head":{"label":"jparise:ast","ref":"ast","sha":"bed5f6d99eeebfd0407842dddb36e4da5591beeb","user":{"login":"jparise","id":10311,"node_id":"MDQ6VXNlcjEwMzEx","avatar_url":"https://avatars1.githubusercontent.com/u/10311?v=4","gravatar_id":"","url":"https://api.github.com/users/jparise","html_url":"https://github.com/jparise","followers_url":"https://api.github.com/users/jparise/followers","following_url":"https://api.github.com/users/jparise/following{/other_user}","gists_url":"https://api.github.com/users/jparise/gists{/gist_id}","starred_url":"https://api.github.com/users/jparise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jparise/subscriptions","organizations_url":"https://api.github.com/users/jparise/orgs","repos_url":"https://api.github.com/users/jparise/repos","events_url":"https://api.github.com/users/jparise/events{/privacy}","received_events_url":"https://api.github.com/users/jparise/received_events","type":"User","site_admin":false},"repo":{"id":71505731,"node_id":"MDEwOlJlcG9zaXRvcnk3MTUwNTczMQ==","name":"elixir-thrift","full_name":"jparise/elixir-thrift","owner":{"login":"jparise","id":10311,"node_id":"MDQ6VXNlcjEwMzEx","avatar_url":"https://avatars1.githubusercontent.com/u/10311?v=4","gravatar_id":"","url":"https://api.github.com/users/jparise","html_url":"https://github.com/jparise","followers_url":"https://api.github.com/users/jparise/followers","following_url":"https://api.github.com/users/jparise/following{/other_user}","gists_url":"https://api.github.com/users/jparise/gists{/gist_id}","starred_url":"https://api.github.com/users/jparise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jparise/subscriptions","organizations_url":"https://api.github.com/users/jparise/orgs","repos_url":"https://api.github.com/users/jparise/repos","events_url":"https://api.github.com/users/jparise/events{/privacy}","received_events_url":"https://api.github.com/users/jparise/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jparise/elixir-thrift","description":"Thrift Utilities for Elixir","fork":true,"url":"https://api.github.com/repos/jparise/elixir-thrift","forks_url":"https://api.github.com/repos/jparise/elixir-thrift/forks","keys_url":"https://api.github.com/repos/jparise/elixir-thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jparise/elixir-thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jparise/elixir-thrift/teams","hooks_url":"https://api.github.com/repos/jparise/elixir-thrift/hooks","issue_events_url":"https://api.github.com/repos/jparise/elixir-thrift/issues/events{/number}","events_url":"https://api.github.com/repos/jparise/elixir-thrift/events","assignees_url":"https://api.github.com/repos/jparise/elixir-thrift/assignees{/user}","branches_url":"https://api.github.com/repos/jparise/elixir-thrift/branches{/branch}","tags_url":"https://api.github.com/repos/jparise/elixir-thrift/tags","blobs_url":"https://api.github.com/repos/jparise/elixir-thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jparise/elixir-thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jparise/elixir-thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jparise/elixir-thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jparise/elixir-thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/jparise/elixir-thrift/languages","stargazers_url":"https://api.github.com/repos/jparise/elixir-thrift/stargazers","contributors_url":"https://api.github.com/repos/jparise/elixir-thrift/contributors","subscribers_url":"https://api.github.com/repos/jparise/elixir-thrift/subscribers","subscription_url":"https://api.github.com/repos/jparise/elixir-thrift/subscription","commits_url":"https://api.github.com/repos/jparise/elixir-thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jparise/elixir-thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jparise/elixir-thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jparise/elixir-thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jparise/elixir-thrift/contents/{+path}","compare_url":"https://api.github.com/repos/jparise/elixir-thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jparise/elixir-thrift/merges","archive_url":"https://api.github.com/repos/jparise/elixir-thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jparise/elixir-thrift/downloads","issues_url":"https://api.github.com/repos/jparise/elixir-thrift/issues{/number}","pulls_url":"https://api.github.com/repos/jparise/elixir-thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/jparise/elixir-thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/jparise/elixir-thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jparise/elixir-thrift/labels{/name}","releases_url":"https://api.github.com/repos/jparise/elixir-thrift/releases{/id}","deployments_url":"https://api.github.com/repos/jparise/elixir-thrift/deployments","created_at":"2016-10-20T21:26:23Z","updated_at":"2018-05-30T04:21:58Z","pushed_at":"2018-06-12T20:36:46Z","git_url":"git://github.com/jparise/elixir-thrift.git","ssh_url":"git@github.com:jparise/elixir-thrift.git","clone_url":"https://github.com/jparise/elixir-thrift.git","svn_url":"https://github.com/jparise/elixir-thrift","homepage":"https://hexdocs.pm/thrift/","size":626,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pinterest:master","ref":"master","sha":"45ce5a6e606e2e3bef5d10e4b59aef303e4b8abb","user":{"login":"pinterest","id":541152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTE1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/541152?v=4","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"repo":{"id":43914111,"node_id":"MDEwOlJlcG9zaXRvcnk0MzkxNDExMQ==","name":"elixir-thrift","full_name":"pinterest/elixir-thrift","owner":{"login":"pinterest","id":541152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTE1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/541152?v=4","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pinterest/elixir-thrift","description":"Thrift Utilities for Elixir","fork":false,"url":"https://api.github.com/repos/pinterest/elixir-thrift","forks_url":"https://api.github.com/repos/pinterest/elixir-thrift/forks","keys_url":"https://api.github.com/repos/pinterest/elixir-thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinterest/elixir-thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinterest/elixir-thrift/teams","hooks_url":"https://api.github.com/repos/pinterest/elixir-thrift/hooks","issue_events_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/events{/number}","events_url":"https://api.github.com/repos/pinterest/elixir-thrift/events","assignees_url":"https://api.github.com/repos/pinterest/elixir-thrift/assignees{/user}","branches_url":"https://api.github.com/repos/pinterest/elixir-thrift/branches{/branch}","tags_url":"https://api.github.com/repos/pinterest/elixir-thrift/tags","blobs_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/pinterest/elixir-thrift/languages","stargazers_url":"https://api.github.com/repos/pinterest/elixir-thrift/stargazers","contributors_url":"https://api.github.com/repos/pinterest/elixir-thrift/contributors","subscribers_url":"https://api.github.com/repos/pinterest/elixir-thrift/subscribers","subscription_url":"https://api.github.com/repos/pinterest/elixir-thrift/subscription","commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/pinterest/elixir-thrift/contents/{+path}","compare_url":"https://api.github.com/repos/pinterest/elixir-thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinterest/elixir-thrift/merges","archive_url":"https://api.github.com/repos/pinterest/elixir-thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinterest/elixir-thrift/downloads","issues_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues{/number}","pulls_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/pinterest/elixir-thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/pinterest/elixir-thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinterest/elixir-thrift/labels{/name}","releases_url":"https://api.github.com/repos/pinterest/elixir-thrift/releases{/id}","deployments_url":"https://api.github.com/repos/pinterest/elixir-thrift/deployments","created_at":"2015-10-08T20:17:30Z","updated_at":"2018-05-31T00:53:05Z","pushed_at":"2018-06-12T20:36:58Z","git_url":"git://github.com/pinterest/elixir-thrift.git","ssh_url":"git@github.com:pinterest/elixir-thrift.git","clone_url":"https://github.com/pinterest/elixir-thrift.git","svn_url":"https://github.com/pinterest/elixir-thrift","homepage":"https://hexdocs.pm/thrift/","size":625,"stargazers_count":83,"watchers_count":83,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":23,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/346"},"html":{"href":"https://github.com/pinterest/elixir-thrift/pull/346"},"issue":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/issues/346"},"comments":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/bed5f6d99eeebfd0407842dddb36e4da5591beeb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ebert"}}