{"action":"created","issue":{"url":"https://api.github.com/repos/lat9/edit_orders/issues/87","repository_url":"https://api.github.com/repos/lat9/edit_orders","labels_url":"https://api.github.com/repos/lat9/edit_orders/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/lat9/edit_orders/issues/87/comments","events_url":"https://api.github.com/repos/lat9/edit_orders/issues/87/events","html_url":"https://github.com/lat9/edit_orders/issues/87","id":367530332,"node_id":"MDU6SXNzdWUzNjc1MzAzMzI=","number":87,"title":"New configuration settings in version 4.3.4 not added to database when performing clean install","user":{"login":"siliconforks","id":1156399,"node_id":"MDQ6VXNlcjExNTYzOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1156399?v=4","gravatar_id":"","url":"https://api.github.com/users/siliconforks","html_url":"https://github.com/siliconforks","followers_url":"https://api.github.com/users/siliconforks/followers","following_url":"https://api.github.com/users/siliconforks/following{/other_user}","gists_url":"https://api.github.com/users/siliconforks/gists{/gist_id}","starred_url":"https://api.github.com/users/siliconforks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siliconforks/subscriptions","organizations_url":"https://api.github.com/users/siliconforks/orgs","repos_url":"https://api.github.com/users/siliconforks/repos","events_url":"https://api.github.com/users/siliconforks/events{/privacy}","received_events_url":"https://api.github.com/users/siliconforks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-07T07:47:01Z","updated_at":"2018-10-07T12:34:34Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Version 4.3.4 appears to have two new configuration settings:\r\n\r\n1. Product Price Calculation — Method (`EO_PRODUCT_PRICE_CALC_METHOD`)\r\n2. Product Price Calculation — Default (`EO_PRODUCT_PRICE_CALC_DEFAULT`)\r\n\r\nI had a site running an old version of Edit Orders and I upgraded it to version 4.3.4; these settings appeared in the admin section under Configuration &rarr; Edit Orders, as expected.  Looking in the database, I can see rows in the `configuration` table for `EO_PRODUCT_PRICE_CALC_METHOD` and `EO_PRODUCT_PRICE_CALC_DEFAULT`.\r\n\r\nHowever, I had another site without Edit Orders installed where I performed a clean install of version 4.3.4, and neither of these settings showed up in the admin section.  Looking in the database, neither `EO_PRODUCT_PRICE_CALC_METHOD` nor `EO_PRODUCT_PRICE_CALC_DEFAULT` are in the `configuration` table.\r\n\r\nIs this the intended behavior?  (I haven't used version 4.3.4 before and I'm not exactly sure what these settings do, but surely they should be present no matter whether Edit Orders is upgraded from an older version or installed for the first time?)"},"comment":{"url":"https://api.github.com/repos/lat9/edit_orders/issues/comments/427649892","html_url":"https://github.com/lat9/edit_orders/issues/87#issuecomment-427649892","issue_url":"https://api.github.com/repos/lat9/edit_orders/issues/87","id":427649892,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzY0OTg5Mg==","user":{"login":"lat9","id":2685585,"node_id":"MDQ6VXNlcjI2ODU1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2685585?v=4","gravatar_id":"","url":"https://api.github.com/users/lat9","html_url":"https://github.com/lat9","followers_url":"https://api.github.com/users/lat9/followers","following_url":"https://api.github.com/users/lat9/following{/other_user}","gists_url":"https://api.github.com/users/lat9/gists{/gist_id}","starred_url":"https://api.github.com/users/lat9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lat9/subscriptions","organizations_url":"https://api.github.com/users/lat9/orgs","repos_url":"https://api.github.com/users/lat9/repos","events_url":"https://api.github.com/users/lat9/events{/privacy}","received_events_url":"https://api.github.com/users/lat9/received_events","type":"User","site_admin":false},"created_at":"2018-10-07T12:34:34Z","updated_at":"2018-10-07T12:34:34Z","author_association":"OWNER","body":"You're correct, of course, @siliconforks.  Let me get a 4.3.5 version going to correct."}}
{"actor":{"display_login":"lat9"}}