{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/22","repository_url":"https://api.github.com/repos/aws/aws-xray-sdk-python","labels_url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/22/comments","events_url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/22/events","html_url":"https://github.com/aws/aws-xray-sdk-python/pull/22","id":298025186,"number":22,"title":"Filter invalid characters from annotation key names; raise warning if found","user":{"login":"tay-bird","id":2468680,"avatar_url":"https://avatars0.githubusercontent.com/u/2468680?v=4","gravatar_id":"","url":"https://api.github.com/users/tay-bird","html_url":"https://github.com/tay-bird","followers_url":"https://api.github.com/users/tay-bird/followers","following_url":"https://api.github.com/users/tay-bird/following{/other_user}","gists_url":"https://api.github.com/users/tay-bird/gists{/gist_id}","starred_url":"https://api.github.com/users/tay-bird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tay-bird/subscriptions","organizations_url":"https://api.github.com/users/tay-bird/orgs","repos_url":"https://api.github.com/users/tay-bird/repos","events_url":"https://api.github.com/users/tay-bird/events{/privacy}","received_events_url":"https://api.github.com/users/tay-bird/received_events","type":"User","site_admin":false},"labels":[{"id":695940838,"url":"https://api.github.com/repos/aws/aws-xray-sdk-python/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-17T18:23:02Z","updated_at":"2018-02-19T20:32:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aws/aws-xray-sdk-python/pulls/22","html_url":"https://github.com/aws/aws-xray-sdk-python/pull/22","diff_url":"https://github.com/aws/aws-xray-sdk-python/pull/22.diff","patch_url":"https://github.com/aws/aws-xray-sdk-python/pull/22.patch"},"body":"Fixes #18 \r\n\r\nI took the approach of stripping invalid characters from annotation key names and raising a warning, rather than exiting the function."},"comment":{"url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/comments/366796269","html_url":"https://github.com/aws/aws-xray-sdk-python/pull/22#issuecomment-366796269","issue_url":"https://api.github.com/repos/aws/aws-xray-sdk-python/issues/22","id":366796269,"user":{"login":"haotianw465","id":3795229,"avatar_url":"https://avatars3.githubusercontent.com/u/3795229?v=4","gravatar_id":"","url":"https://api.github.com/users/haotianw465","html_url":"https://github.com/haotianw465","followers_url":"https://api.github.com/users/haotianw465/followers","following_url":"https://api.github.com/users/haotianw465/following{/other_user}","gists_url":"https://api.github.com/users/haotianw465/gists{/gist_id}","starred_url":"https://api.github.com/users/haotianw465/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haotianw465/subscriptions","organizations_url":"https://api.github.com/users/haotianw465/orgs","repos_url":"https://api.github.com/users/haotianw465/repos","events_url":"https://api.github.com/users/haotianw465/events{/privacy}","received_events_url":"https://api.github.com/users/haotianw465/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T20:32:04Z","updated_at":"2018-02-19T20:32:04Z","author_association":"CONTRIBUTOR","body":"It looks all good. Sorry that I forgot to mention if you could add two line check on this unit test https://github.com/aws/aws-xray-sdk-python/blob/master/tests/test_trace_entities.py#L47 to cover the new key dropping logic. Thanks.\r\n"}}
{"actor":{"display_login":"haotianw465"}}