{"action":"created","comment":{"url":"https://api.github.com/repos/google/go-cloud/pulls/comments/232333366","pull_request_review_id":173500231,"id":232333366,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjMzMzM2Ng==","diff_hunk":"@@ -72,3 +121,89 @@ func TestSendReceive(t *testing.T) {\n \t\tt.Fatal(err)\n \t}\n }\n+\n+func TestLotsOfMessagesAndSubscriptions(t *testing.T) {\n+\thowManyToSend := int(1e3)\n+\tctx := context.Background()\n+\tdt := &driverTopic{}\n+\n+\t// Make subscriptions and start goroutines to receive from them.\n+\tvar subs []*pubsub.Subscription\n+\tnSubs := 100\n+\tvar wg sync.WaitGroup\n+\tfor i := 0; i < nSubs; i++ {\n+\t\tds := NewDriverSub()\n+\t\tdt.subs = append(dt.subs, ds)\n+\t\ts := pubsub.NewSubscription(ctx, ds, pubsub.SubscriptionOptions{})\n+\t\tsubs = append(subs, s)\n+\t\twg.Add(howManyToSend)","path":"pubsub/pubsub_test.go","position":139,"original_position":112,"commit_id":"6968e712289ac22d73bbb68072bb91619f857ce8","original_commit_id":"6968e712289ac22d73bbb68072bb91619f857ce8","user":{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},"body":"1","created_at":"2018-11-09T17:33:30Z","updated_at":"2018-11-09T17:41:57Z","html_url":"https://github.com/google/go-cloud/pull/642#discussion_r232333366","pull_request_url":"https://api.github.com/repos/google/go-cloud/pulls/642","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments/232333366"},"html":{"href":"https://github.com/google/go-cloud/pull/642#discussion_r232333366"},"pull_request":{"href":"https://api.github.com/repos/google/go-cloud/pulls/642"}}},"pull_request":{"url":"https://api.github.com/repos/google/go-cloud/pulls/642","id":228875768,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODc1NzY4","html_url":"https://github.com/google/go-cloud/pull/642","diff_url":"https://github.com/google/go-cloud/pull/642.diff","patch_url":"https://github.com/google/go-cloud/pull/642.patch","issue_url":"https://api.github.com/repos/google/go-cloud/issues/642","number":642,"state":"open","locked":false,"title":"pubsub: add concrete API implementation","user":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"body":"Fixes #607 ","created_at":"2018-11-07T00:00:56Z","updated_at":"2018-11-09T17:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab025d5b3e79b81397999c2d7ce346978552a890","assignee":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"assignees":[{"login":"zombiezen","id":181535,"node_id":"MDQ6VXNlcjE4MTUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/181535?v=4","gravatar_id":"","url":"https://api.github.com/users/zombiezen","html_url":"https://github.com/zombiezen","followers_url":"https://api.github.com/users/zombiezen/followers","following_url":"https://api.github.com/users/zombiezen/following{/other_user}","gists_url":"https://api.github.com/users/zombiezen/gists{/gist_id}","starred_url":"https://api.github.com/users/zombiezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zombiezen/subscriptions","organizations_url":"https://api.github.com/users/zombiezen/orgs","repos_url":"https://api.github.com/users/zombiezen/repos","events_url":"https://api.github.com/users/zombiezen/events{/privacy}","received_events_url":"https://api.github.com/users/zombiezen/received_events","type":"User","site_admin":false},{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zombiezen","id":181535,"node_id":"MDQ6VXNlcjE4MTUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/181535?v=4","gravatar_id":"","url":"https://api.github.com/users/zombiezen","html_url":"https://github.com/zombiezen","followers_url":"https://api.github.com/users/zombiezen/followers","following_url":"https://api.github.com/users/zombiezen/following{/other_user}","gists_url":"https://api.github.com/users/zombiezen/gists{/gist_id}","starred_url":"https://api.github.com/users/zombiezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zombiezen/subscriptions","organizations_url":"https://api.github.com/users/zombiezen/orgs","repos_url":"https://api.github.com/users/zombiezen/repos","events_url":"https://api.github.com/users/zombiezen/events{/privacy}","received_events_url":"https://api.github.com/users/zombiezen/received_events","type":"User","site_admin":false},{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1016532751,"node_id":"MDU6TGFiZWwxMDE2NTMyNzUx","url":"https://api.github.com/repos/google/go-cloud/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-cloud/pulls/642/commits","review_comments_url":"https://api.github.com/repos/google/go-cloud/pulls/642/comments","review_comment_url":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-cloud/issues/642/comments","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/6968e712289ac22d73bbb68072bb91619f857ce8","head":{"label":"ijt:pubsub20181101","ref":"pubsub20181101","sha":"6968e712289ac22d73bbb68072bb91619f857ce8","user":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"repo":{"id":142936626,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MzY2MjY=","name":"go-cloud","full_name":"ijt/go-cloud","private":false,"owner":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ijt/go-cloud","description":"A library and tools for open cloud development in Go.","fork":true,"url":"https://api.github.com/repos/ijt/go-cloud","forks_url":"https://api.github.com/repos/ijt/go-cloud/forks","keys_url":"https://api.github.com/repos/ijt/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijt/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijt/go-cloud/teams","hooks_url":"https://api.github.com/repos/ijt/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/ijt/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/ijt/go-cloud/events","assignees_url":"https://api.github.com/repos/ijt/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/ijt/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/ijt/go-cloud/tags","blobs_url":"https://api.github.com/repos/ijt/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijt/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijt/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijt/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijt/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/ijt/go-cloud/languages","stargazers_url":"https://api.github.com/repos/ijt/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/ijt/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/ijt/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/ijt/go-cloud/subscription","commits_url":"https://api.github.com/repos/ijt/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijt/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijt/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijt/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijt/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/ijt/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijt/go-cloud/merges","archive_url":"https://api.github.com/repos/ijt/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijt/go-cloud/downloads","issues_url":"https://api.github.com/repos/ijt/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/ijt/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/ijt/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/ijt/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijt/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/ijt/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/ijt/go-cloud/deployments","created_at":"2018-07-30T23:02:52Z","updated_at":"2018-07-31T00:27:06Z","pushed_at":"2018-11-09T02:44:42Z","git_url":"git://github.com/ijt/go-cloud.git","ssh_url":"git@github.com:ijt/go-cloud.git","clone_url":"https://github.com/ijt/go-cloud.git","svn_url":"https://github.com/ijt/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":18782,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"08ec72e01c429d8ec2cc47e10bb4810ff0354bd7","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":126250425,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyNTA0MjU=","name":"go-cloud","full_name":"google/go-cloud","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/go-cloud","description":"A library and tools for open cloud development in Go.","fork":false,"url":"https://api.github.com/repos/google/go-cloud","forks_url":"https://api.github.com/repos/google/go-cloud/forks","keys_url":"https://api.github.com/repos/google/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-cloud/teams","hooks_url":"https://api.github.com/repos/google/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/google/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-cloud/events","assignees_url":"https://api.github.com/repos/google/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-cloud/tags","blobs_url":"https://api.github.com/repos/google/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-cloud/languages","stargazers_url":"https://api.github.com/repos/google/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/google/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/google/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/google/go-cloud/subscription","commits_url":"https://api.github.com/repos/google/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-cloud/merges","archive_url":"https://api.github.com/repos/google/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-cloud/downloads","issues_url":"https://api.github.com/repos/google/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/google/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-cloud/deployments","created_at":"2018-03-21T22:57:26Z","updated_at":"2018-11-09T14:10:34Z","pushed_at":"2018-11-09T02:44:43Z","git_url":"git://github.com/google/go-cloud.git","ssh_url":"git@github.com:google/go-cloud.git","clone_url":"https://github.com/google/go-cloud.git","svn_url":"https://github.com/google/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":18526,"stargazers_count":4941,"watchers_count":4941,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":268,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":268,"open_issues":91,"watchers":4941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/642"},"html":{"href":"https://github.com/google/go-cloud/pull/642"},"issue":{"href":"https://api.github.com/repos/google/go-cloud/issues/642"},"comments":{"href":"https://api.github.com/repos/google/go-cloud/issues/642/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-cloud/pulls/642/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-cloud/pulls/642/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-cloud/statuses/6968e712289ac22d73bbb68072bb91619f857ce8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jba"}}