{"action":"created","issue":{"url":"https://api.github.com/repos/scipy/scipy/issues/7373","repository_url":"https://api.github.com/repos/scipy/scipy","labels_url":"https://api.github.com/repos/scipy/scipy/issues/7373/labels{/name}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/7373/comments","events_url":"https://api.github.com/repos/scipy/scipy/issues/7373/events","html_url":"https://github.com/scipy/scipy/pull/7373","id":225886071,"node_id":"MDExOlB1bGxSZXF1ZXN0MTE4NjkyMzc2","number":7373,"title":"BUG: Jaccard distance for all-zero arrays would return np.nan","user":{"login":"ElDeveloper","id":375307,"node_id":"MDQ6VXNlcjM3NTMwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/375307?v=4","gravatar_id":"","url":"https://api.github.com/users/ElDeveloper","html_url":"https://github.com/ElDeveloper","followers_url":"https://api.github.com/users/ElDeveloper/followers","following_url":"https://api.github.com/users/ElDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/ElDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/ElDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElDeveloper/subscriptions","organizations_url":"https://api.github.com/users/ElDeveloper/orgs","repos_url":"https://api.github.com/users/ElDeveloper/repos","events_url":"https://api.github.com/users/ElDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/ElDeveloper/received_events","type":"User","site_admin":false},"labels":[{"id":108549863,"node_id":"MDU6TGFiZWwxMDg1NDk4NjM=","url":"https://api.github.com/repos/scipy/scipy/labels/maintenance","name":"maintenance","color":"fef2c0","default":false},{"id":199201380,"node_id":"MDU6TGFiZWwxOTkyMDEzODA=","url":"https://api.github.com/repos/scipy/scipy/labels/needs-decision","name":"needs-decision","color":"fbca04","default":false},{"id":37345293,"node_id":"MDU6TGFiZWwzNzM0NTI5Mw==","url":"https://api.github.com/repos/scipy/scipy/labels/scipy.spatial","name":"scipy.spatial","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scipy/scipy/milestones/36","html_url":"https://github.com/scipy/scipy/milestone/36","labels_url":"https://api.github.com/repos/scipy/scipy/milestones/36/labels","id":3257163,"node_id":"MDk6TWlsZXN0b25lMzI1NzE2Mw==","number":36,"title":"1.2.0","description":"","creator":{"login":"pv","id":35046,"node_id":"MDQ6VXNlcjM1MDQ2","avatar_url":"https://avatars1.githubusercontent.com/u/35046?v=4","gravatar_id":"","url":"https://api.github.com/users/pv","html_url":"https://github.com/pv","followers_url":"https://api.github.com/users/pv/followers","following_url":"https://api.github.com/users/pv/following{/other_user}","gists_url":"https://api.github.com/users/pv/gists{/gist_id}","starred_url":"https://api.github.com/users/pv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pv/subscriptions","organizations_url":"https://api.github.com/users/pv/orgs","repos_url":"https://api.github.com/users/pv/repos","events_url":"https://api.github.com/users/pv/events{/privacy}","received_events_url":"https://api.github.com/users/pv/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":228,"state":"open","created_at":"2018-04-10T20:26:02Z","updated_at":"2018-10-28T08:59:31Z","due_on":"2018-11-09T08:00:00Z","closed_at":null},"comments":10,"created_at":"2017-05-03T05:14:57Z","updated_at":"2018-10-29T00:50:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/7373","html_url":"https://github.com/scipy/scipy/pull/7373","diff_url":"https://github.com/scipy/scipy/pull/7373.diff","patch_url":"https://github.com/scipy/scipy/pull/7373.patch"},"body":"The Jaccard distance returns `np.nan` when two all-zero vectors are\r\ncompared. This patch changes this to return 0 instead, and avoid a\r\ndivision by zero.\r\n\r\nFixes #7317 \r\n"},"comment":{"url":"https://api.github.com/repos/scipy/scipy/issues/comments/433758737","html_url":"https://github.com/scipy/scipy/pull/7373#issuecomment-433758737","issue_url":"https://api.github.com/repos/scipy/scipy/issues/7373","id":433758737,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzc1ODczNw==","user":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T00:50:29Z","updated_at":"2018-10-29T00:50:29Z","author_association":"CONTRIBUTOR","body":"I'm +1 for returning zero when both inputs are empty given the clear definition in the [arxiv paper](https://arxiv.org/pdf/1612.02696.pdf) mentioned above, which has now been cited ~20 times, including by 1 or 2 journals / proceedings I recognize.\r\n\r\nThe lead author on that paper is a Mathematics Professor in Germany -- I'll ping their github account @synoptiker here. Sven's twitter account is far more active though so I'll ping there too.\r\n\r\nStill that paper + Wikipedia article are pretty clear to me on this matter -- 0 / 0 is special cased to 0 because you formally define the index as `1` in the all-zero case and subtract that from `1` in the formal definition of distance.\r\n\r\nThis could probably do with a doc update / citation of the manuscript if others agree."}}
{"actor":{"display_login":"tylerjereddy"}}