{"action":"created","issue":{"url":"https://api.github.com/repos/wesnoth/wesnoth/issues/2779","repository_url":"https://api.github.com/repos/wesnoth/wesnoth","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/2779/labels{/name}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/2779/comments","events_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/2779/events","html_url":"https://github.com/wesnoth/wesnoth/issues/2779","id":309951427,"number":2779,"title":"Fix issues found by schema validator","user":{"login":"CelticMinstrel","id":578731,"avatar_url":"https://avatars3.githubusercontent.com/u/578731?v=4","gravatar_id":"","url":"https://api.github.com/users/CelticMinstrel","html_url":"https://github.com/CelticMinstrel","followers_url":"https://api.github.com/users/CelticMinstrel/followers","following_url":"https://api.github.com/users/CelticMinstrel/following{/other_user}","gists_url":"https://api.github.com/users/CelticMinstrel/gists{/gist_id}","starred_url":"https://api.github.com/users/CelticMinstrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelticMinstrel/subscriptions","organizations_url":"https://api.github.com/users/CelticMinstrel/orgs","repos_url":"https://api.github.com/users/CelticMinstrel/repos","events_url":"https://api.github.com/users/CelticMinstrel/events{/privacy}","received_events_url":"https://api.github.com/users/CelticMinstrel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/wesnoth/wesnoth/milestones/7","html_url":"https://github.com/wesnoth/wesnoth/milestone/7","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/milestones/7/labels","id":2501324,"number":7,"title":"1.14.0","description":"","creator":{"login":"CelticMinstrel","id":578731,"avatar_url":"https://avatars3.githubusercontent.com/u/578731?v=4","gravatar_id":"","url":"https://api.github.com/users/CelticMinstrel","html_url":"https://github.com/CelticMinstrel","followers_url":"https://api.github.com/users/CelticMinstrel/followers","following_url":"https://api.github.com/users/CelticMinstrel/following{/other_user}","gists_url":"https://api.github.com/users/CelticMinstrel/gists{/gist_id}","starred_url":"https://api.github.com/users/CelticMinstrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelticMinstrel/subscriptions","organizations_url":"https://api.github.com/users/CelticMinstrel/orgs","repos_url":"https://api.github.com/users/CelticMinstrel/repos","events_url":"https://api.github.com/users/CelticMinstrel/events{/privacy}","received_events_url":"https://api.github.com/users/CelticMinstrel/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":38,"state":"open","created_at":"2017-05-04T22:32:30Z","updated_at":"2018-04-05T20:09:00Z","due_on":"2018-04-22T07:00:00Z","closed_at":null},"comments":5,"created_at":"2018-03-30T01:33:17Z","updated_at":"2018-04-06T02:56:46Z","closed_at":null,"author_association":"MEMBER","body":"I've been working on the schema validator (#2562) so that we can track down and fix hard-to-find bugs. This issue stands to get feedback on some cases where I'm not sure what the correct path is, as well as to serve as a checklist for the validation.\r\n\r\nFor completeness, I intend to validate every campaign on every difficulty, as well as MP, the editor, and tests. To be clear, all I actually need to do is load each one up, look at the log, fix any errors, and repeat until there are no errors - I'm not going to be playing through any of the campaigns or anything. I don't expect to find any errors on medium or hard that aren't also on easy, so I'll probably just load medium and hard (and nightmare where applicable) once just to be sure.\r\n\r\n* [x] Core WML (that which is loaded by simply getting to the title screen)\r\n* [ ] Editor WML\r\n* [ ] Interactive tests (accessible by hotkey)\r\n* [ ] Unit tests (not accessible by hotkey)\r\n* [x] Multiplayer WML (that which is loaded by simply getting to the create screen)\r\n* [x] Hornshark Island (2P)\r\n* [x] A New Land (4P)\r\n* [x] Team Survival (6P)\r\n* [ ] Legend of Wesmere MP\r\n* [x] Tutorial\r\n* [x] An Orcish Incursion\r\n* [x] Dead Water\r\n* [x] Defador's Memoirs\r\n* [x] Descent into Darkness\r\n* [x] Eastern Invasion\r\n* [x] Hammer of Thursagan\r\n* [ ] Heir to the Throne\r\n* [ ] Legend of Wesmere\r\n* [x] Liberty\r\n* [ ] Northern Rebirth\r\n* [ ] Rise of Wesnoth\r\n* [x] Sceptre of Fire\r\n* [x] Secrets of the Ancients\r\n* [x] Son of the Black Eye\r\n* [x] South Guard\r\n* [x] Two Brothers\r\n* [ ] Under the Burning Suns\r\n* [ ] Under the Burning Suns (old units) - I know they're going to be removed soon, but I figure checking them anyway could potentially help find bugs in the schema itself\r\n"},"comment":{"url":"https://api.github.com/repos/wesnoth/wesnoth/issues/comments/379134724","html_url":"https://github.com/wesnoth/wesnoth/issues/2779#issuecomment-379134724","issue_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/2779","id":379134724,"user":{"login":"CelticMinstrel","id":578731,"avatar_url":"https://avatars3.githubusercontent.com/u/578731?v=4","gravatar_id":"","url":"https://api.github.com/users/CelticMinstrel","html_url":"https://github.com/CelticMinstrel","followers_url":"https://api.github.com/users/CelticMinstrel/followers","following_url":"https://api.github.com/users/CelticMinstrel/following{/other_user}","gists_url":"https://api.github.com/users/CelticMinstrel/gists{/gist_id}","starred_url":"https://api.github.com/users/CelticMinstrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelticMinstrel/subscriptions","organizations_url":"https://api.github.com/users/CelticMinstrel/orgs","repos_url":"https://api.github.com/users/CelticMinstrel/repos","events_url":"https://api.github.com/users/CelticMinstrel/events{/privacy}","received_events_url":"https://api.github.com/users/CelticMinstrel/received_events","type":"User","site_admin":false},"created_at":"2018-04-06T02:56:46Z","updated_at":"2018-04-06T02:56:46Z","author_association":"MEMBER","body":"@Vultraz pointed out that `config_name` is indeed valid while toplevel `[story]` is not, but I still need to know whether scenario-level `bonus` and `village_gold` are allowed."}}
{"actor":{"display_login":"CelticMinstrel"}}