{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/ecs/pulls/comments/210184313","pull_request_review_id":146345611,"id":210184313,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDE4NDMxMw==","diff_hunk":"@@ -9,7 +9,17 @@\n       type: keyword\n       description: >\n         Network protocol name.\n-      example: http\n+      example: tcp\n+    - name: protocol.name","path":"schemas/network.yml","position":6,"original_position":6,"commit_id":"6f9cb628e980aec6d639d2c704e4296a44499f9a","original_commit_id":"6f9cb628e980aec6d639d2c704e4296a44499f9a","user":{"login":"ruflin","id":244900,"node_id":"MDQ6VXNlcjI0NDkwMA==","avatar_url":"https://avatars3.githubusercontent.com/u/244900?v=4","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"body":"`network.protocol` and `network.protocol.id` can also not coexist.","created_at":"2018-08-15T06:54:12Z","updated_at":"2018-08-15T06:54:12Z","html_url":"https://github.com/elastic/ecs/pull/79#discussion_r210184313","pull_request_url":"https://api.github.com/repos/elastic/ecs/pulls/79","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/ecs/pulls/comments/210184313"},"html":{"href":"https://github.com/elastic/ecs/pull/79#discussion_r210184313"},"pull_request":{"href":"https://api.github.com/repos/elastic/ecs/pulls/79"}},"in_reply_to_id":209854511},"pull_request":{"url":"https://api.github.com/repos/elastic/ecs/pulls/79","id":208042249,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDQyMjQ5","html_url":"https://github.com/elastic/ecs/pull/79","diff_url":"https://github.com/elastic/ecs/pull/79.diff","patch_url":"https://github.com/elastic/ecs/pull/79.patch","issue_url":"https://api.github.com/repos/elastic/ecs/issues/79","number":79,"state":"open","locked":false,"title":" Adds network.protocol.name and network.protocol.id ","user":{"login":"robgil","id":1257843,"node_id":"MDQ6VXNlcjEyNTc4NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1257843?v=4","gravatar_id":"","url":"https://api.github.com/users/robgil","html_url":"https://github.com/robgil","followers_url":"https://api.github.com/users/robgil/followers","following_url":"https://api.github.com/users/robgil/following{/other_user}","gists_url":"https://api.github.com/users/robgil/gists{/gist_id}","starred_url":"https://api.github.com/users/robgil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgil/subscriptions","organizations_url":"https://api.github.com/users/robgil/orgs","repos_url":"https://api.github.com/users/robgil/repos","events_url":"https://api.github.com/users/robgil/events{/privacy}","received_events_url":"https://api.github.com/users/robgil/received_events","type":"User","site_admin":false},"body":"With most logs coming in, the protocol names are not resolved to their respective full name and instead rely on the IDs from [IANA](https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml). This adds names and ids. The regular `network.protocol` would use name, but if you're not planning to use resolution, `network.protocol.id` would be available.","created_at":"2018-08-13T17:03:01Z","updated_at":"2018-08-15T06:54:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e34555bdf20b6ee4f2ae1ecc3c59a42beed4ab0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/ecs/pulls/79/commits","review_comments_url":"https://api.github.com/repos/elastic/ecs/pulls/79/comments","review_comment_url":"https://api.github.com/repos/elastic/ecs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/ecs/issues/79/comments","statuses_url":"https://api.github.com/repos/elastic/ecs/statuses/6f9cb628e980aec6d639d2c704e4296a44499f9a","head":{"label":"robgil:9506-network-fields","ref":"9506-network-fields","sha":"6f9cb628e980aec6d639d2c704e4296a44499f9a","user":{"login":"robgil","id":1257843,"node_id":"MDQ6VXNlcjEyNTc4NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1257843?v=4","gravatar_id":"","url":"https://api.github.com/users/robgil","html_url":"https://github.com/robgil","followers_url":"https://api.github.com/users/robgil/followers","following_url":"https://api.github.com/users/robgil/following{/other_user}","gists_url":"https://api.github.com/users/robgil/gists{/gist_id}","starred_url":"https://api.github.com/users/robgil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgil/subscriptions","organizations_url":"https://api.github.com/users/robgil/orgs","repos_url":"https://api.github.com/users/robgil/repos","events_url":"https://api.github.com/users/robgil/events{/privacy}","received_events_url":"https://api.github.com/users/robgil/received_events","type":"User","site_admin":false},"repo":{"id":134762452,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3NjI0NTI=","name":"ecs","full_name":"robgil/ecs","owner":{"login":"robgil","id":1257843,"node_id":"MDQ6VXNlcjEyNTc4NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1257843?v=4","gravatar_id":"","url":"https://api.github.com/users/robgil","html_url":"https://github.com/robgil","followers_url":"https://api.github.com/users/robgil/followers","following_url":"https://api.github.com/users/robgil/following{/other_user}","gists_url":"https://api.github.com/users/robgil/gists{/gist_id}","starred_url":"https://api.github.com/users/robgil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgil/subscriptions","organizations_url":"https://api.github.com/users/robgil/orgs","repos_url":"https://api.github.com/users/robgil/repos","events_url":"https://api.github.com/users/robgil/events{/privacy}","received_events_url":"https://api.github.com/users/robgil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robgil/ecs","description":"Elastic Common Schema","fork":true,"url":"https://api.github.com/repos/robgil/ecs","forks_url":"https://api.github.com/repos/robgil/ecs/forks","keys_url":"https://api.github.com/repos/robgil/ecs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robgil/ecs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robgil/ecs/teams","hooks_url":"https://api.github.com/repos/robgil/ecs/hooks","issue_events_url":"https://api.github.com/repos/robgil/ecs/issues/events{/number}","events_url":"https://api.github.com/repos/robgil/ecs/events","assignees_url":"https://api.github.com/repos/robgil/ecs/assignees{/user}","branches_url":"https://api.github.com/repos/robgil/ecs/branches{/branch}","tags_url":"https://api.github.com/repos/robgil/ecs/tags","blobs_url":"https://api.github.com/repos/robgil/ecs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robgil/ecs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robgil/ecs/git/refs{/sha}","trees_url":"https://api.github.com/repos/robgil/ecs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robgil/ecs/statuses/{sha}","languages_url":"https://api.github.com/repos/robgil/ecs/languages","stargazers_url":"https://api.github.com/repos/robgil/ecs/stargazers","contributors_url":"https://api.github.com/repos/robgil/ecs/contributors","subscribers_url":"https://api.github.com/repos/robgil/ecs/subscribers","subscription_url":"https://api.github.com/repos/robgil/ecs/subscription","commits_url":"https://api.github.com/repos/robgil/ecs/commits{/sha}","git_commits_url":"https://api.github.com/repos/robgil/ecs/git/commits{/sha}","comments_url":"https://api.github.com/repos/robgil/ecs/comments{/number}","issue_comment_url":"https://api.github.com/repos/robgil/ecs/issues/comments{/number}","contents_url":"https://api.github.com/repos/robgil/ecs/contents/{+path}","compare_url":"https://api.github.com/repos/robgil/ecs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robgil/ecs/merges","archive_url":"https://api.github.com/repos/robgil/ecs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robgil/ecs/downloads","issues_url":"https://api.github.com/repos/robgil/ecs/issues{/number}","pulls_url":"https://api.github.com/repos/robgil/ecs/pulls{/number}","milestones_url":"https://api.github.com/repos/robgil/ecs/milestones{/number}","notifications_url":"https://api.github.com/repos/robgil/ecs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robgil/ecs/labels{/name}","releases_url":"https://api.github.com/repos/robgil/ecs/releases{/id}","deployments_url":"https://api.github.com/repos/robgil/ecs/deployments","created_at":"2018-05-24T19:56:21Z","updated_at":"2018-05-24T19:56:22Z","pushed_at":"2018-08-13T18:25:27Z","git_url":"git://github.com/robgil/ecs.git","ssh_url":"git@github.com:robgil/ecs.git","clone_url":"https://github.com/robgil/ecs.git","svn_url":"https://github.com/robgil/ecs","homepage":null,"size":142,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"404be2e51d91a710a2b6f8422bb8ba7e68339147","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":134683798,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2ODM3OTg=","name":"ecs","full_name":"elastic/ecs","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/ecs","description":"Elastic Common Schema","fork":false,"url":"https://api.github.com/repos/elastic/ecs","forks_url":"https://api.github.com/repos/elastic/ecs/forks","keys_url":"https://api.github.com/repos/elastic/ecs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/ecs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/ecs/teams","hooks_url":"https://api.github.com/repos/elastic/ecs/hooks","issue_events_url":"https://api.github.com/repos/elastic/ecs/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/ecs/events","assignees_url":"https://api.github.com/repos/elastic/ecs/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/ecs/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/ecs/tags","blobs_url":"https://api.github.com/repos/elastic/ecs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/ecs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/ecs/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/ecs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/ecs/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/ecs/languages","stargazers_url":"https://api.github.com/repos/elastic/ecs/stargazers","contributors_url":"https://api.github.com/repos/elastic/ecs/contributors","subscribers_url":"https://api.github.com/repos/elastic/ecs/subscribers","subscription_url":"https://api.github.com/repos/elastic/ecs/subscription","commits_url":"https://api.github.com/repos/elastic/ecs/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/ecs/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/ecs/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/ecs/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/ecs/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/ecs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/ecs/merges","archive_url":"https://api.github.com/repos/elastic/ecs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/ecs/downloads","issues_url":"https://api.github.com/repos/elastic/ecs/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/ecs/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/ecs/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/ecs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/ecs/labels{/name}","releases_url":"https://api.github.com/repos/elastic/ecs/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/ecs/deployments","created_at":"2018-05-24T08:16:29Z","updated_at":"2018-08-14T20:01:17Z","pushed_at":"2018-08-13T18:25:52Z","git_url":"git://github.com/elastic/ecs.git","ssh_url":"git@github.com:elastic/ecs.git","clone_url":"https://github.com/elastic/ecs.git","svn_url":"https://github.com/elastic/ecs","homepage":null,"size":102,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":39,"license":null,"forks":17,"open_issues":39,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/ecs/pulls/79"},"html":{"href":"https://github.com/elastic/ecs/pull/79"},"issue":{"href":"https://api.github.com/repos/elastic/ecs/issues/79"},"comments":{"href":"https://api.github.com/repos/elastic/ecs/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/ecs/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/ecs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/ecs/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/ecs/statuses/6f9cb628e980aec6d639d2c704e4296a44499f9a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ruflin"}}