{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8998","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8998/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8998/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8998/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/8998","id":388455097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzE3NTMz","number":8998,"title":"Ble extended advertising fixes","user":{"login":"pan-","id":409941,"node_id":"MDQ6VXNlcjQwOTk0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/409941?v=4","gravatar_id":"","url":"https://api.github.com/users/pan-","html_url":"https://github.com/pan-","followers_url":"https://api.github.com/users/pan-/followers","following_url":"https://api.github.com/users/pan-/following{/other_user}","gists_url":"https://api.github.com/users/pan-/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-/subscriptions","organizations_url":"https://api.github.com/users/pan-/orgs","repos_url":"https://api.github.com/users/pan-/repos","events_url":"https://api.github.com/users/pan-/events{/privacy}","received_events_url":"https://api.github.com/users/pan-/received_events","type":"User","site_admin":false},"labels":[{"id":1150359641,"node_id":"MDU6TGFiZWwxMTUwMzU5NjQx","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/release-version:%205.11.0-rc3","name":"release-version: 5.11.0-rc3","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-12-07T00:26:04Z","updated_at":"2018-12-12T13:34:24Z","closed_at":"2018-12-10T16:36:06Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8998","html_url":"https://github.com/ARMmbed/mbed-os/pull/8998","diff_url":"https://github.com/ARMmbed/mbed-os/pull/8998.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/8998.patch"},"body":"### Description\r\n\r\nSecond round of fixes discovered with the OOB and our testing.\r\n\r\nIt fixes: https://github.com/ARMmbed/mbed-os-example-ble/issues/198 and many other bug discovered during our internal testing on the Cordio LL.\r\n\r\n### Pull request type\r\n\r\n<!-- \r\n    Required\r\n    Please add only one X to one of the following types. Do not fill multiple types (split the pull request otherwise).\r\n    Please note this is not a GitHub task list, indenting the boxes or changing the format to add a '.' or '*' in front\r\n    of them would change the meaning incorrectly. The only changes to be made are to add a description text under the\r\n    description heading and to add a 'x' to the correct box.\r\n-->\r\n    [X] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/446589433","html_url":"https://github.com/ARMmbed/mbed-os/pull/8998#issuecomment-446589433","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8998","id":446589433,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjU4OTQzMw==","user":{"login":"kjbracey-arm","id":11025917,"node_id":"MDQ6VXNlcjExMDI1OTE3","avatar_url":"https://avatars3.githubusercontent.com/u/11025917?v=4","gravatar_id":"","url":"https://api.github.com/users/kjbracey-arm","html_url":"https://github.com/kjbracey-arm","followers_url":"https://api.github.com/users/kjbracey-arm/followers","following_url":"https://api.github.com/users/kjbracey-arm/following{/other_user}","gists_url":"https://api.github.com/users/kjbracey-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbracey-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbracey-arm/subscriptions","organizations_url":"https://api.github.com/users/kjbracey-arm/orgs","repos_url":"https://api.github.com/users/kjbracey-arm/repos","events_url":"https://api.github.com/users/kjbracey-arm/events{/privacy}","received_events_url":"https://api.github.com/users/kjbracey-arm/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T13:34:24Z","updated_at":"2018-12-12T13:34:24Z","author_association":"CONTRIBUTOR","body":"What actually was the problem here? Compiler deducing that `ble_cordio_get_hci_driver` didn't return by looking at the weak version?\r\n\r\nWas initially puzzled because assert failures are also noreturn, but then this assert is true so doesn't do anything.\r\n\r\nI would have thought the code should be issuing an error in the calling code if `ble_cordio_get_hci_driver` returns NULL (whether it is because it fell through to the weak code, or because a real implementation had some other init problem). That's the pattern we've used in all the `get_default_instance` patterns - any base weak version is just a plain \"return NULL\".\r\n"}}
{"actor":{"display_login":"kjbracey-arm"}}