{"action":"closed","number":232,"pull_request":{"url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/pulls/232","id":180739112,"html_url":"https://github.com/JuliaWeb/HTTP.jl/pull/232","diff_url":"https://github.com/JuliaWeb/HTTP.jl/pull/232.diff","patch_url":"https://github.com/JuliaWeb/HTTP.jl/pull/232.patch","issue_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/issues/232","number":232,"state":"closed","locked":false,"title":"make http client based get requests work again","user":{"login":"amanica","id":849576,"avatar_url":"https://avatars3.githubusercontent.com/u/849576?v=4","gravatar_id":"","url":"https://api.github.com/users/amanica","html_url":"https://github.com/amanica","followers_url":"https://api.github.com/users/amanica/followers","following_url":"https://api.github.com/users/amanica/following{/other_user}","gists_url":"https://api.github.com/users/amanica/gists{/gist_id}","starred_url":"https://api.github.com/users/amanica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amanica/subscriptions","organizations_url":"https://api.github.com/users/amanica/orgs","repos_url":"https://api.github.com/users/amanica/repos","events_url":"https://api.github.com/users/amanica/events{/privacy}","received_events_url":"https://api.github.com/users/amanica/received_events","type":"User","site_admin":false},"body":"hi, \r\nafter struggling quite a bit with the new version of HTTP.jl (and julia 0.6.2) I finally figured out that the query parameters gets ignored when calling via the Client api. (I think a similar issue exists with HTTP.get function and friends)\r\n\r\nWith this fix it is working for me again. Let me know if you are happy with this and if I should attempt to add a test..\r\n\r\nthanks\r\nmarius","created_at":"2018-04-10T21:57:44Z","updated_at":"2018-04-16T05:44:08Z","closed_at":"2018-04-16T05:44:08Z","merged_at":"2018-04-16T05:44:07Z","merge_commit_sha":"5daa105cd8ae32eae22ca125b7511946b56a7ebc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/pulls/232/commits","review_comments_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/pulls/232/comments","review_comment_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/issues/232/comments","statuses_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/statuses/b33208cd437e2a38a8b86611de8c160593f86b57","head":{"label":"amanica:client_request_merge","ref":"client_request_merge","sha":"b33208cd437e2a38a8b86611de8c160593f86b57","user":{"login":"amanica","id":849576,"avatar_url":"https://avatars3.githubusercontent.com/u/849576?v=4","gravatar_id":"","url":"https://api.github.com/users/amanica","html_url":"https://github.com/amanica","followers_url":"https://api.github.com/users/amanica/followers","following_url":"https://api.github.com/users/amanica/following{/other_user}","gists_url":"https://api.github.com/users/amanica/gists{/gist_id}","starred_url":"https://api.github.com/users/amanica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amanica/subscriptions","organizations_url":"https://api.github.com/users/amanica/orgs","repos_url":"https://api.github.com/users/amanica/repos","events_url":"https://api.github.com/users/amanica/events{/privacy}","received_events_url":"https://api.github.com/users/amanica/received_events","type":"User","site_admin":false},"repo":{"id":128997146,"name":"HTTP.jl","full_name":"amanica/HTTP.jl","owner":{"login":"amanica","id":849576,"avatar_url":"https://avatars3.githubusercontent.com/u/849576?v=4","gravatar_id":"","url":"https://api.github.com/users/amanica","html_url":"https://github.com/amanica","followers_url":"https://api.github.com/users/amanica/followers","following_url":"https://api.github.com/users/amanica/following{/other_user}","gists_url":"https://api.github.com/users/amanica/gists{/gist_id}","starred_url":"https://api.github.com/users/amanica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amanica/subscriptions","organizations_url":"https://api.github.com/users/amanica/orgs","repos_url":"https://api.github.com/users/amanica/repos","events_url":"https://api.github.com/users/amanica/events{/privacy}","received_events_url":"https://api.github.com/users/amanica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amanica/HTTP.jl","description":"HTTP for Julia","fork":true,"url":"https://api.github.com/repos/amanica/HTTP.jl","forks_url":"https://api.github.com/repos/amanica/HTTP.jl/forks","keys_url":"https://api.github.com/repos/amanica/HTTP.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amanica/HTTP.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amanica/HTTP.jl/teams","hooks_url":"https://api.github.com/repos/amanica/HTTP.jl/hooks","issue_events_url":"https://api.github.com/repos/amanica/HTTP.jl/issues/events{/number}","events_url":"https://api.github.com/repos/amanica/HTTP.jl/events","assignees_url":"https://api.github.com/repos/amanica/HTTP.jl/assignees{/user}","branches_url":"https://api.github.com/repos/amanica/HTTP.jl/branches{/branch}","tags_url":"https://api.github.com/repos/amanica/HTTP.jl/tags","blobs_url":"https://api.github.com/repos/amanica/HTTP.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amanica/HTTP.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amanica/HTTP.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/amanica/HTTP.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amanica/HTTP.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/amanica/HTTP.jl/languages","stargazers_url":"https://api.github.com/repos/amanica/HTTP.jl/stargazers","contributors_url":"https://api.github.com/repos/amanica/HTTP.jl/contributors","subscribers_url":"https://api.github.com/repos/amanica/HTTP.jl/subscribers","subscription_url":"https://api.github.com/repos/amanica/HTTP.jl/subscription","commits_url":"https://api.github.com/repos/amanica/HTTP.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/amanica/HTTP.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/amanica/HTTP.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/amanica/HTTP.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/amanica/HTTP.jl/contents/{+path}","compare_url":"https://api.github.com/repos/amanica/HTTP.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amanica/HTTP.jl/merges","archive_url":"https://api.github.com/repos/amanica/HTTP.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amanica/HTTP.jl/downloads","issues_url":"https://api.github.com/repos/amanica/HTTP.jl/issues{/number}","pulls_url":"https://api.github.com/repos/amanica/HTTP.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/amanica/HTTP.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/amanica/HTTP.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amanica/HTTP.jl/labels{/name}","releases_url":"https://api.github.com/repos/amanica/HTTP.jl/releases{/id}","deployments_url":"https://api.github.com/repos/amanica/HTTP.jl/deployments","created_at":"2018-04-10T21:29:45Z","updated_at":"2018-04-10T22:11:29Z","pushed_at":"2018-04-10T22:11:28Z","git_url":"git://github.com/amanica/HTTP.jl.git","ssh_url":"git@github.com:amanica/HTTP.jl.git","clone_url":"https://github.com/amanica/HTTP.jl.git","svn_url":"https://github.com/amanica/HTTP.jl","homepage":"https://juliaweb.github.io/HTTP.jl/stable/","size":2117,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaWeb:master","ref":"master","sha":"7f8e4bad85451fd43113e206bcd7fd08b2587139","user":{"login":"JuliaWeb","id":8564604,"avatar_url":"https://avatars0.githubusercontent.com/u/8564604?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaWeb","html_url":"https://github.com/JuliaWeb","followers_url":"https://api.github.com/users/JuliaWeb/followers","following_url":"https://api.github.com/users/JuliaWeb/following{/other_user}","gists_url":"https://api.github.com/users/JuliaWeb/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaWeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaWeb/subscriptions","organizations_url":"https://api.github.com/users/JuliaWeb/orgs","repos_url":"https://api.github.com/users/JuliaWeb/repos","events_url":"https://api.github.com/users/JuliaWeb/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaWeb/received_events","type":"Organization","site_admin":false},"repo":{"id":75249739,"name":"HTTP.jl","full_name":"JuliaWeb/HTTP.jl","owner":{"login":"JuliaWeb","id":8564604,"avatar_url":"https://avatars0.githubusercontent.com/u/8564604?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaWeb","html_url":"https://github.com/JuliaWeb","followers_url":"https://api.github.com/users/JuliaWeb/followers","following_url":"https://api.github.com/users/JuliaWeb/following{/other_user}","gists_url":"https://api.github.com/users/JuliaWeb/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaWeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaWeb/subscriptions","organizations_url":"https://api.github.com/users/JuliaWeb/orgs","repos_url":"https://api.github.com/users/JuliaWeb/repos","events_url":"https://api.github.com/users/JuliaWeb/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaWeb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaWeb/HTTP.jl","description":"HTTP for Julia","fork":false,"url":"https://api.github.com/repos/JuliaWeb/HTTP.jl","forks_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/forks","keys_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/teams","hooks_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/events","assignees_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/tags","blobs_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/subscription","commits_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/merges","archive_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/downloads","issues_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaWeb/HTTP.jl/deployments","created_at":"2016-12-01T03:05:14Z","updated_at":"2018-04-16T05:42:06Z","pushed_at":"2018-04-16T05:44:07Z","git_url":"git://github.com/JuliaWeb/HTTP.jl.git","ssh_url":"git@github.com:JuliaWeb/HTTP.jl.git","clone_url":"https://github.com/JuliaWeb/HTTP.jl.git","svn_url":"https://github.com/JuliaWeb/HTTP.jl","homepage":"https://juliaweb.github.io/HTTP.jl/stable/","size":2149,"stargazers_count":68,"watchers_count":68,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":26,"open_issues":29,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaWeb/HTTP.jl/pulls/232"},"html":{"href":"https://github.com/JuliaWeb/HTTP.jl/pull/232"},"issue":{"href":"https://api.github.com/repos/JuliaWeb/HTTP.jl/issues/232"},"comments":{"href":"https://api.github.com/repos/JuliaWeb/HTTP.jl/issues/232/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaWeb/HTTP.jl/pulls/232/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaWeb/HTTP.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaWeb/HTTP.jl/pulls/232/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaWeb/HTTP.jl/statuses/b33208cd437e2a38a8b86611de8c160593f86b57"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"samoconnor","id":8266283,"avatar_url":"https://avatars2.githubusercontent.com/u/8266283?v=4","gravatar_id":"","url":"https://api.github.com/users/samoconnor","html_url":"https://github.com/samoconnor","followers_url":"https://api.github.com/users/samoconnor/followers","following_url":"https://api.github.com/users/samoconnor/following{/other_user}","gists_url":"https://api.github.com/users/samoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/samoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samoconnor/subscriptions","organizations_url":"https://api.github.com/users/samoconnor/orgs","repos_url":"https://api.github.com/users/samoconnor/repos","events_url":"https://api.github.com/users/samoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/samoconnor/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"samoconnor"}}