{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/184364719","pull_request_review_id":115544145,"id":184364719,"diff_hunk":"@@ -0,0 +1,2 @@\n+\n+MAKEFLAGS := $(MAKEFLAGS) --no-builtin-rules","path":"mk/common.mk","position":2,"original_position":2,"commit_id":"67d0b1477c62a3065dc68266662476fe178ef6c6","original_commit_id":"67d0b1477c62a3065dc68266662476fe178ef6c6","user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars2.githubusercontent.com/u/1376924?v=4","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"body":"We use `MAKEFLAGS += ` in the sdks, probably better than `:=`? https://github.com/mono/mono/blob/81aec9f6932245fa4f41e0c97e4d11a74d71608e/sdks/wasm/Makefile#L6 ","created_at":"2018-04-26T12:07:06Z","updated_at":"2018-04-26T12:09:35Z","html_url":"https://github.com/mono/mono/pull/2280#discussion_r184364719","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/2280","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/184364719"},"html":{"href":"https://github.com/mono/mono/pull/2280#discussion_r184364719"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/2280"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/2280","id":52359044,"html_url":"https://github.com/mono/mono/pull/2280","diff_url":"https://github.com/mono/mono/pull/2280.diff","patch_url":"https://github.com/mono/mono/pull/2280.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/2280","number":2280,"state":"open","locked":false,"title":"[build] Disable make builtin rules for the runtime build. This speeds up a no-changes build by ~25%.","user":{"login":"kumpera","id":5738,"avatar_url":"https://avatars0.githubusercontent.com/u/5738?v=4","gravatar_id":"","url":"https://api.github.com/users/kumpera","html_url":"https://github.com/kumpera","followers_url":"https://api.github.com/users/kumpera/followers","following_url":"https://api.github.com/users/kumpera/following{/other_user}","gists_url":"https://api.github.com/users/kumpera/gists{/gist_id}","starred_url":"https://api.github.com/users/kumpera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumpera/subscriptions","organizations_url":"https://api.github.com/users/kumpera/orgs","repos_url":"https://api.github.com/users/kumpera/repos","events_url":"https://api.github.com/users/kumpera/events{/privacy}","received_events_url":"https://api.github.com/users/kumpera/received_events","type":"User","site_admin":false},"body":"This is a RFC PR over disabling implicit make rules. It does speed up the no-change build a bit.\n\nFor the runtime it's not a lot, but once we factor in the BCL, the difference will be more significant.\n","created_at":"2015-12-02T06:37:21Z","updated_at":"2018-04-26T12:09:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"377015b0373a9ccef46fbde49f467908b4be1dfb","assignee":{"login":"luhenry","id":660779,"avatar_url":"https://avatars1.githubusercontent.com/u/660779?v=4","gravatar_id":"","url":"https://api.github.com/users/luhenry","html_url":"https://github.com/luhenry","followers_url":"https://api.github.com/users/luhenry/followers","following_url":"https://api.github.com/users/luhenry/following{/other_user}","gists_url":"https://api.github.com/users/luhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/luhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luhenry/subscriptions","organizations_url":"https://api.github.com/users/luhenry/orgs","repos_url":"https://api.github.com/users/luhenry/repos","events_url":"https://api.github.com/users/luhenry/events{/privacy}","received_events_url":"https://api.github.com/users/luhenry/received_events","type":"User","site_admin":false},"assignees":[{"login":"luhenry","id":660779,"avatar_url":"https://avatars1.githubusercontent.com/u/660779?v=4","gravatar_id":"","url":"https://api.github.com/users/luhenry","html_url":"https://github.com/luhenry","followers_url":"https://api.github.com/users/luhenry/followers","following_url":"https://api.github.com/users/luhenry/following{/other_user}","gists_url":"https://api.github.com/users/luhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/luhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luhenry/subscriptions","organizations_url":"https://api.github.com/users/luhenry/orgs","repos_url":"https://api.github.com/users/luhenry/repos","events_url":"https://api.github.com/users/luhenry/events{/privacy}","received_events_url":"https://api.github.com/users/luhenry/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"alexrp","id":44076,"avatar_url":"https://avatars0.githubusercontent.com/u/44076?v=4","gravatar_id":"","url":"https://api.github.com/users/alexrp","html_url":"https://github.com/alexrp","followers_url":"https://api.github.com/users/alexrp/followers","following_url":"https://api.github.com/users/alexrp/following{/other_user}","gists_url":"https://api.github.com/users/alexrp/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrp/subscriptions","organizations_url":"https://api.github.com/users/alexrp/orgs","repos_url":"https://api.github.com/users/alexrp/repos","events_url":"https://api.github.com/users/alexrp/events{/privacy}","received_events_url":"https://api.github.com/users/alexrp/received_events","type":"User","site_admin":false},{"login":"vargaz","id":186301,"avatar_url":"https://avatars3.githubusercontent.com/u/186301?v=4","gravatar_id":"","url":"https://api.github.com/users/vargaz","html_url":"https://github.com/vargaz","followers_url":"https://api.github.com/users/vargaz/followers","following_url":"https://api.github.com/users/vargaz/following{/other_user}","gists_url":"https://api.github.com/users/vargaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vargaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vargaz/subscriptions","organizations_url":"https://api.github.com/users/vargaz/orgs","repos_url":"https://api.github.com/users/vargaz/repos","events_url":"https://api.github.com/users/vargaz/events{/privacy}","received_events_url":"https://api.github.com/users/vargaz/received_events","type":"User","site_admin":false},{"login":"marek-safar","id":250852,"avatar_url":"https://avatars1.githubusercontent.com/u/250852?v=4","gravatar_id":"","url":"https://api.github.com/users/marek-safar","html_url":"https://github.com/marek-safar","followers_url":"https://api.github.com/users/marek-safar/followers","following_url":"https://api.github.com/users/marek-safar/following{/other_user}","gists_url":"https://api.github.com/users/marek-safar/gists{/gist_id}","starred_url":"https://api.github.com/users/marek-safar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marek-safar/subscriptions","organizations_url":"https://api.github.com/users/marek-safar/orgs","repos_url":"https://api.github.com/users/marek-safar/repos","events_url":"https://api.github.com/users/marek-safar/events{/privacy}","received_events_url":"https://api.github.com/users/marek-safar/received_events","type":"User","site_admin":false},{"login":"lambdageek","id":480437,"avatar_url":"https://avatars0.githubusercontent.com/u/480437?v=4","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},{"login":"BrzVlad","id":4720621,"avatar_url":"https://avatars3.githubusercontent.com/u/4720621?v=4","gravatar_id":"","url":"https://api.github.com/users/BrzVlad","html_url":"https://github.com/BrzVlad","followers_url":"https://api.github.com/users/BrzVlad/followers","following_url":"https://api.github.com/users/BrzVlad/following{/other_user}","gists_url":"https://api.github.com/users/BrzVlad/gists{/gist_id}","starred_url":"https://api.github.com/users/BrzVlad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrzVlad/subscriptions","organizations_url":"https://api.github.com/users/BrzVlad/orgs","repos_url":"https://api.github.com/users/BrzVlad/repos","events_url":"https://api.github.com/users/BrzVlad/events{/privacy}","received_events_url":"https://api.github.com/users/BrzVlad/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/2280/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/2280/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/2280/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/67d0b1477c62a3065dc68266662476fe178ef6c6","head":{"label":"kumpera:make_make_make","ref":"make_make_make","sha":"67d0b1477c62a3065dc68266662476fe178ef6c6","user":{"login":"kumpera","id":5738,"avatar_url":"https://avatars0.githubusercontent.com/u/5738?v=4","gravatar_id":"","url":"https://api.github.com/users/kumpera","html_url":"https://github.com/kumpera","followers_url":"https://api.github.com/users/kumpera/followers","following_url":"https://api.github.com/users/kumpera/following{/other_user}","gists_url":"https://api.github.com/users/kumpera/gists{/gist_id}","starred_url":"https://api.github.com/users/kumpera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumpera/subscriptions","organizations_url":"https://api.github.com/users/kumpera/orgs","repos_url":"https://api.github.com/users/kumpera/repos","events_url":"https://api.github.com/users/kumpera/events{/privacy}","received_events_url":"https://api.github.com/users/kumpera/received_events","type":"User","site_admin":false},"repo":{"id":793663,"name":"mono","full_name":"kumpera/mono","owner":{"login":"kumpera","id":5738,"avatar_url":"https://avatars0.githubusercontent.com/u/5738?v=4","gravatar_id":"","url":"https://api.github.com/users/kumpera","html_url":"https://github.com/kumpera","followers_url":"https://api.github.com/users/kumpera/followers","following_url":"https://api.github.com/users/kumpera/following{/other_user}","gists_url":"https://api.github.com/users/kumpera/gists{/gist_id}","starred_url":"https://api.github.com/users/kumpera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumpera/subscriptions","organizations_url":"https://api.github.com/users/kumpera/orgs","repos_url":"https://api.github.com/users/kumpera/repos","events_url":"https://api.github.com/users/kumpera/events{/privacy}","received_events_url":"https://api.github.com/users/kumpera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kumpera/mono","description":"Home of the Mono runtime, the Mono C# compiler, and the Mono class libraries.","fork":true,"url":"https://api.github.com/repos/kumpera/mono","forks_url":"https://api.github.com/repos/kumpera/mono/forks","keys_url":"https://api.github.com/repos/kumpera/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kumpera/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kumpera/mono/teams","hooks_url":"https://api.github.com/repos/kumpera/mono/hooks","issue_events_url":"https://api.github.com/repos/kumpera/mono/issues/events{/number}","events_url":"https://api.github.com/repos/kumpera/mono/events","assignees_url":"https://api.github.com/repos/kumpera/mono/assignees{/user}","branches_url":"https://api.github.com/repos/kumpera/mono/branches{/branch}","tags_url":"https://api.github.com/repos/kumpera/mono/tags","blobs_url":"https://api.github.com/repos/kumpera/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kumpera/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kumpera/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/kumpera/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kumpera/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/kumpera/mono/languages","stargazers_url":"https://api.github.com/repos/kumpera/mono/stargazers","contributors_url":"https://api.github.com/repos/kumpera/mono/contributors","subscribers_url":"https://api.github.com/repos/kumpera/mono/subscribers","subscription_url":"https://api.github.com/repos/kumpera/mono/subscription","commits_url":"https://api.github.com/repos/kumpera/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/kumpera/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/kumpera/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/kumpera/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/kumpera/mono/contents/{+path}","compare_url":"https://api.github.com/repos/kumpera/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kumpera/mono/merges","archive_url":"https://api.github.com/repos/kumpera/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kumpera/mono/downloads","issues_url":"https://api.github.com/repos/kumpera/mono/issues{/number}","pulls_url":"https://api.github.com/repos/kumpera/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/kumpera/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/kumpera/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kumpera/mono/labels{/name}","releases_url":"https://api.github.com/repos/kumpera/mono/releases{/id}","deployments_url":"https://api.github.com/repos/kumpera/mono/deployments","created_at":"2010-07-23T17:31:15Z","updated_at":"2018-03-31T21:59:47Z","pushed_at":"2018-04-25T19:02:14Z","git_url":"git://github.com/kumpera/mono.git","ssh_url":"git@github.com:kumpera/mono.git","clone_url":"https://github.com/kumpera/mono.git","svn_url":"https://github.com/kumpera/mono","homepage":"http://www.mono-project.com/","size":460812,"stargazers_count":13,"watchers_count":13,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":0,"watchers":13,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"dd652eee5ae149caddd92ea3508b6e763cf2486c","user":{"login":"mono","id":53395,"avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2018-04-26T12:04:13Z","pushed_at":"2018-04-26T12:03:44Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":476283,"stargazers_count":6455,"watchers_count":6455,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2864,"mirror_url":null,"archived":false,"open_issues_count":499,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2864,"open_issues":499,"watchers":6455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/2280"},"html":{"href":"https://github.com/mono/mono/pull/2280"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/2280"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/2280/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/2280/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/2280/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/67d0b1477c62a3065dc68266662476fe178ef6c6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"akoeplinger"}}