{"action":"created","comment":{"url":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/comments/198834487","pull_request_review_id":132834374,"id":198834487,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODgzNDQ4Nw==","diff_hunk":"@@ -505,21 +508,24 @@ private function remindExpiringConsents()\n \n \t\t$db    = $this->db;\n \t\t$query = $db->getQuery(true)\n-\t\t\t->select($db->quoteName(array('r.id, r.user_id, u.email')));\n-\t\t$query->from($db->quoteName('#__privacy_consents', 'r'));\n-\t\t$query->join('LEFT', $db->quoteName('#__users', 'u') . ' ON u.id = r.user_id');\n+\t\t\t->select($db->quoteName(array('r.id', 'r.user_id', 'u.email')))\n+\t\t\t->from($db->quoteName('#__privacy_consents', 'r'))\n+\t\t\t->leftJoin($db->quoteName('#__users', 'u') . ' ON u.id = r.user_id')\n+\t\t\t->where($db->quoteName('remind') . ' = 0');\n \t\t$query->where($query->dateAdd($now, $period, 'DAY') . ' > ' . $db->quoteName('created'));\n-\t\t$query->where($db->quoteName('remind') . ' = 0');\n \n \t\ttry\n \t\t{\n-\t\t\t$users = (int) $db->setQuery($query)->loadObjectList();\n+\t\t\t$users = $db->setQuery($query)->loadObjectList();\n \t\t}\n-\t\tcatch (JDatabaseException $exception)\n+\t\tcatch (RuntimeException $exception)","path":"plugins/system/privacyconsent/privacyconsent.php","position":null,"original_position":44,"commit_id":"3eddb3b9753774d87d28c07dd1e4da1311da312d","original_commit_id":"e2c05d27a3390759154c616da328428d11637579","user":{"login":"joomdonation","id":977664,"node_id":"MDQ6VXNlcjk3NzY2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/977664?v=4","gravatar_id":"","url":"https://api.github.com/users/joomdonation","html_url":"https://github.com/joomdonation","followers_url":"https://api.github.com/users/joomdonation/followers","following_url":"https://api.github.com/users/joomdonation/following{/other_user}","gists_url":"https://api.github.com/users/joomdonation/gists{/gist_id}","starred_url":"https://api.github.com/users/joomdonation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomdonation/subscriptions","organizations_url":"https://api.github.com/users/joomdonation/orgs","repos_url":"https://api.github.com/users/joomdonation/repos","events_url":"https://api.github.com/users/joomdonation/events{/privacy}","received_events_url":"https://api.github.com/users/joomdonation/received_events","type":"User","site_admin":false},"body":"OK. I changed it back to JDatabaseException","created_at":"2018-06-28T13:13:06Z","updated_at":"2018-06-28T13:13:06Z","html_url":"https://github.com/joomla-projects/privacy-framework/pull/135#discussion_r198834487","pull_request_url":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/135","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/comments/198834487"},"html":{"href":"https://github.com/joomla-projects/privacy-framework/pull/135#discussion_r198834487"},"pull_request":{"href":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/135"}},"in_reply_to_id":198808969},"pull_request":{"url":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/135","id":197948805,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTQ4ODA1","html_url":"https://github.com/joomla-projects/privacy-framework/pull/135","diff_url":"https://github.com/joomla-projects/privacy-framework/pull/135.diff","patch_url":"https://github.com/joomla-projects/privacy-framework/pull/135.patch","issue_url":"https://api.github.com/repos/joomla-projects/privacy-framework/issues/135","number":135,"state":"open","locked":false,"title":"Consent expiration fixes","user":{"login":"joomdonation","id":977664,"node_id":"MDQ6VXNlcjk3NzY2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/977664?v=4","gravatar_id":"","url":"https://api.github.com/users/joomdonation","html_url":"https://github.com/joomdonation","followers_url":"https://api.github.com/users/joomdonation/followers","following_url":"https://api.github.com/users/joomdonation/following{/other_user}","gists_url":"https://api.github.com/users/joomdonation/gists{/gist_id}","starred_url":"https://api.github.com/users/joomdonation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomdonation/subscriptions","organizations_url":"https://api.github.com/users/joomdonation/orgs","repos_url":"https://api.github.com/users/joomdonation/repos","events_url":"https://api.github.com/users/joomdonation/events{/privacy}","received_events_url":"https://api.github.com/users/joomdonation/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue # .\r\n\r\n### Summary of Changes\r\nThis PR fixes some small errors in consent expiration branch (causes SQL errors, 404 not found when click on remind link, token not pre-filled on the form...).\r\n\r\n@alikon Please review and merge this change. After this is merged, consider having success human testing from me.","created_at":"2018-06-28T08:08:47Z","updated_at":"2018-06-28T13:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48b4b823bf7a4f7f14cda9b8aa6e408607fa6f8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/135/commits","review_comments_url":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/135/comments","review_comment_url":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla-projects/privacy-framework/issues/135/comments","statuses_url":"https://api.github.com/repos/joomla-projects/privacy-framework/statuses/3eddb3b9753774d87d28c07dd1e4da1311da312d","head":{"label":"joomdonation:consent-expiration-fixes","ref":"consent-expiration-fixes","sha":"3eddb3b9753774d87d28c07dd1e4da1311da312d","user":{"login":"joomdonation","id":977664,"node_id":"MDQ6VXNlcjk3NzY2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/977664?v=4","gravatar_id":"","url":"https://api.github.com/users/joomdonation","html_url":"https://github.com/joomdonation","followers_url":"https://api.github.com/users/joomdonation/followers","following_url":"https://api.github.com/users/joomdonation/following{/other_user}","gists_url":"https://api.github.com/users/joomdonation/gists{/gist_id}","starred_url":"https://api.github.com/users/joomdonation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomdonation/subscriptions","organizations_url":"https://api.github.com/users/joomdonation/orgs","repos_url":"https://api.github.com/users/joomdonation/repos","events_url":"https://api.github.com/users/joomdonation/events{/privacy}","received_events_url":"https://api.github.com/users/joomdonation/received_events","type":"User","site_admin":false},"repo":{"id":134658255,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2NTgyNTU=","name":"privacy-framework","full_name":"joomdonation/privacy-framework","owner":{"login":"joomdonation","id":977664,"node_id":"MDQ6VXNlcjk3NzY2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/977664?v=4","gravatar_id":"","url":"https://api.github.com/users/joomdonation","html_url":"https://github.com/joomdonation","followers_url":"https://api.github.com/users/joomdonation/followers","following_url":"https://api.github.com/users/joomdonation/following{/other_user}","gists_url":"https://api.github.com/users/joomdonation/gists{/gist_id}","starred_url":"https://api.github.com/users/joomdonation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomdonation/subscriptions","organizations_url":"https://api.github.com/users/joomdonation/orgs","repos_url":"https://api.github.com/users/joomdonation/repos","events_url":"https://api.github.com/users/joomdonation/events{/privacy}","received_events_url":"https://api.github.com/users/joomdonation/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joomdonation/privacy-framework","description":"Collaboration space to work on a privacy framework for Joomla","fork":true,"url":"https://api.github.com/repos/joomdonation/privacy-framework","forks_url":"https://api.github.com/repos/joomdonation/privacy-framework/forks","keys_url":"https://api.github.com/repos/joomdonation/privacy-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomdonation/privacy-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomdonation/privacy-framework/teams","hooks_url":"https://api.github.com/repos/joomdonation/privacy-framework/hooks","issue_events_url":"https://api.github.com/repos/joomdonation/privacy-framework/issues/events{/number}","events_url":"https://api.github.com/repos/joomdonation/privacy-framework/events","assignees_url":"https://api.github.com/repos/joomdonation/privacy-framework/assignees{/user}","branches_url":"https://api.github.com/repos/joomdonation/privacy-framework/branches{/branch}","tags_url":"https://api.github.com/repos/joomdonation/privacy-framework/tags","blobs_url":"https://api.github.com/repos/joomdonation/privacy-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomdonation/privacy-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomdonation/privacy-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomdonation/privacy-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomdonation/privacy-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/joomdonation/privacy-framework/languages","stargazers_url":"https://api.github.com/repos/joomdonation/privacy-framework/stargazers","contributors_url":"https://api.github.com/repos/joomdonation/privacy-framework/contributors","subscribers_url":"https://api.github.com/repos/joomdonation/privacy-framework/subscribers","subscription_url":"https://api.github.com/repos/joomdonation/privacy-framework/subscription","commits_url":"https://api.github.com/repos/joomdonation/privacy-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomdonation/privacy-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomdonation/privacy-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomdonation/privacy-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomdonation/privacy-framework/contents/{+path}","compare_url":"https://api.github.com/repos/joomdonation/privacy-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomdonation/privacy-framework/merges","archive_url":"https://api.github.com/repos/joomdonation/privacy-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomdonation/privacy-framework/downloads","issues_url":"https://api.github.com/repos/joomdonation/privacy-framework/issues{/number}","pulls_url":"https://api.github.com/repos/joomdonation/privacy-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/joomdonation/privacy-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/joomdonation/privacy-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomdonation/privacy-framework/labels{/name}","releases_url":"https://api.github.com/repos/joomdonation/privacy-framework/releases{/id}","deployments_url":"https://api.github.com/repos/joomdonation/privacy-framework/deployments","created_at":"2018-05-24T03:51:12Z","updated_at":"2018-06-25T02:08:55Z","pushed_at":"2018-06-28T13:12:30Z","git_url":"git://github.com/joomdonation/privacy-framework.git","ssh_url":"git@github.com:joomdonation/privacy-framework.git","clone_url":"https://github.com/joomdonation/privacy-framework.git","svn_url":"https://github.com/joomdonation/privacy-framework","homepage":null,"size":134025,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev/privacy"}},"base":{"label":"joomla-projects:alikon-consent-expiration","ref":"alikon-consent-expiration","sha":"c2845e0966cc7d24ef411d796d7e76af2ce10fa0","user":{"login":"joomla-projects","id":4417437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MTc0Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4417437?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla-projects","html_url":"https://github.com/joomla-projects","followers_url":"https://api.github.com/users/joomla-projects/followers","following_url":"https://api.github.com/users/joomla-projects/following{/other_user}","gists_url":"https://api.github.com/users/joomla-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-projects/subscriptions","organizations_url":"https://api.github.com/users/joomla-projects/orgs","repos_url":"https://api.github.com/users/joomla-projects/repos","events_url":"https://api.github.com/users/joomla-projects/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":131858746,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4NTg3NDY=","name":"privacy-framework","full_name":"joomla-projects/privacy-framework","owner":{"login":"joomla-projects","id":4417437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MTc0Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4417437?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla-projects","html_url":"https://github.com/joomla-projects","followers_url":"https://api.github.com/users/joomla-projects/followers","following_url":"https://api.github.com/users/joomla-projects/following{/other_user}","gists_url":"https://api.github.com/users/joomla-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-projects/subscriptions","organizations_url":"https://api.github.com/users/joomla-projects/orgs","repos_url":"https://api.github.com/users/joomla-projects/repos","events_url":"https://api.github.com/users/joomla-projects/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla-projects/privacy-framework","description":"Collaboration space to work on a privacy framework for Joomla","fork":false,"url":"https://api.github.com/repos/joomla-projects/privacy-framework","forks_url":"https://api.github.com/repos/joomla-projects/privacy-framework/forks","keys_url":"https://api.github.com/repos/joomla-projects/privacy-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla-projects/privacy-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla-projects/privacy-framework/teams","hooks_url":"https://api.github.com/repos/joomla-projects/privacy-framework/hooks","issue_events_url":"https://api.github.com/repos/joomla-projects/privacy-framework/issues/events{/number}","events_url":"https://api.github.com/repos/joomla-projects/privacy-framework/events","assignees_url":"https://api.github.com/repos/joomla-projects/privacy-framework/assignees{/user}","branches_url":"https://api.github.com/repos/joomla-projects/privacy-framework/branches{/branch}","tags_url":"https://api.github.com/repos/joomla-projects/privacy-framework/tags","blobs_url":"https://api.github.com/repos/joomla-projects/privacy-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla-projects/privacy-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla-projects/privacy-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla-projects/privacy-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla-projects/privacy-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla-projects/privacy-framework/languages","stargazers_url":"https://api.github.com/repos/joomla-projects/privacy-framework/stargazers","contributors_url":"https://api.github.com/repos/joomla-projects/privacy-framework/contributors","subscribers_url":"https://api.github.com/repos/joomla-projects/privacy-framework/subscribers","subscription_url":"https://api.github.com/repos/joomla-projects/privacy-framework/subscription","commits_url":"https://api.github.com/repos/joomla-projects/privacy-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla-projects/privacy-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla-projects/privacy-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla-projects/privacy-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla-projects/privacy-framework/contents/{+path}","compare_url":"https://api.github.com/repos/joomla-projects/privacy-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla-projects/privacy-framework/merges","archive_url":"https://api.github.com/repos/joomla-projects/privacy-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla-projects/privacy-framework/downloads","issues_url":"https://api.github.com/repos/joomla-projects/privacy-framework/issues{/number}","pulls_url":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla-projects/privacy-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla-projects/privacy-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla-projects/privacy-framework/labels{/name}","releases_url":"https://api.github.com/repos/joomla-projects/privacy-framework/releases{/id}","deployments_url":"https://api.github.com/repos/joomla-projects/privacy-framework/deployments","created_at":"2018-05-02T13:58:58Z","updated_at":"2018-06-28T12:27:08Z","pushed_at":"2018-06-28T13:12:31Z","git_url":"git://github.com/joomla-projects/privacy-framework.git","ssh_url":"git@github.com:joomla-projects/privacy-framework.git","clone_url":"https://github.com/joomla-projects/privacy-framework.git","svn_url":"https://github.com/joomla-projects/privacy-framework","homepage":null,"size":134123,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":9,"open_issues":17,"watchers":19,"default_branch":"dev/privacy"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/135"},"html":{"href":"https://github.com/joomla-projects/privacy-framework/pull/135"},"issue":{"href":"https://api.github.com/repos/joomla-projects/privacy-framework/issues/135"},"comments":{"href":"https://api.github.com/repos/joomla-projects/privacy-framework/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla-projects/privacy-framework/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/joomla-projects/privacy-framework/statuses/3eddb3b9753774d87d28c07dd1e4da1311da312d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joomdonation"}}