{"action":"created","comment":{"url":"https://api.github.com/repos/robotology/idyntree/pulls/comments/217912815","pull_request_review_id":155743394,"id":217912815,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkxMjgxNQ==","diff_hunk":"@@ -8,7 +8,9 @@\n \n project(iDynTree_ModelIO_URDF CXX)\n \n-find_package(LibXml2 REQUIRED)\n+if(NOT LIBXML2_LIBRARY OR NOT LIBXML2_INCLUDE_DIR)","path":"src/model_io/urdf/CMakeLists.txt","position":5,"original_position":5,"commit_id":"f0b81cb14edc6ff9420f94608d13e68d54a4f532","original_commit_id":"f0b81cb14edc6ff9420f94608d13e68d54a4f532","user":{"login":"traversaro","id":1857049,"node_id":"MDQ6VXNlcjE4NTcwNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1857049?v=4","gravatar_id":"","url":"https://api.github.com/users/traversaro","html_url":"https://github.com/traversaro","followers_url":"https://api.github.com/users/traversaro/followers","following_url":"https://api.github.com/users/traversaro/following{/other_user}","gists_url":"https://api.github.com/users/traversaro/gists{/gist_id}","starred_url":"https://api.github.com/users/traversaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traversaro/subscriptions","organizations_url":"https://api.github.com/users/traversaro/orgs","repos_url":"https://api.github.com/users/traversaro/repos","events_url":"https://api.github.com/users/traversaro/events{/privacy}","received_events_url":"https://api.github.com/users/traversaro/received_events","type":"User","site_admin":false},"body":"Sorry, you are right, I messed  up by boolean logic parsing. : ) ","created_at":"2018-09-16T12:35:22Z","updated_at":"2018-09-16T12:35:22Z","html_url":"https://github.com/robotology/idyntree/pull/489#discussion_r217912815","pull_request_url":"https://api.github.com/repos/robotology/idyntree/pulls/489","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/robotology/idyntree/pulls/comments/217912815"},"html":{"href":"https://github.com/robotology/idyntree/pull/489#discussion_r217912815"},"pull_request":{"href":"https://api.github.com/repos/robotology/idyntree/pulls/489"}},"in_reply_to_id":217912782},"pull_request":{"url":"https://api.github.com/repos/robotology/idyntree/pulls/489","id":215820359,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODIwMzU5","html_url":"https://github.com/robotology/idyntree/pull/489","diff_url":"https://github.com/robotology/idyntree/pull/489.diff","patch_url":"https://github.com/robotology/idyntree/pull/489.patch","issue_url":"https://api.github.com/repos/robotology/idyntree/issues/489","number":489,"state":"open","locked":false,"title":"Make libxml2 embeddable","user":{"login":"ahoarau","id":703240,"node_id":"MDQ6VXNlcjcwMzI0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/703240?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoarau","html_url":"https://github.com/ahoarau","followers_url":"https://api.github.com/users/ahoarau/followers","following_url":"https://api.github.com/users/ahoarau/following{/other_user}","gists_url":"https://api.github.com/users/ahoarau/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoarau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoarau/subscriptions","organizations_url":"https://api.github.com/users/ahoarau/orgs","repos_url":"https://api.github.com/users/ahoarau/repos","events_url":"https://api.github.com/users/ahoarau/events{/privacy}","received_events_url":"https://api.github.com/users/ahoarau/received_events","type":"User","site_admin":false},"body":"I see that libxml2 headers are private, so someone else can set :\r\n```cmake\r\n    set(LIBXML2_INCLUDE_DIR /the/master/project/external/libxml2-x.y.z/include)\r\n    set(LIBXML2_LIBRARY xml2)\r\n```\r\n","created_at":"2018-09-16T12:26:54Z","updated_at":"2018-09-16T12:35:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81dd8cfebb35787d64138e872749c70b87e02225","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/robotology/idyntree/pulls/489/commits","review_comments_url":"https://api.github.com/repos/robotology/idyntree/pulls/489/comments","review_comment_url":"https://api.github.com/repos/robotology/idyntree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotology/idyntree/issues/489/comments","statuses_url":"https://api.github.com/repos/robotology/idyntree/statuses/f0b81cb14edc6ff9420f94608d13e68d54a4f532","head":{"label":"ahoarau:patch-1","ref":"patch-1","sha":"f0b81cb14edc6ff9420f94608d13e68d54a4f532","user":{"login":"ahoarau","id":703240,"node_id":"MDQ6VXNlcjcwMzI0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/703240?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoarau","html_url":"https://github.com/ahoarau","followers_url":"https://api.github.com/users/ahoarau/followers","following_url":"https://api.github.com/users/ahoarau/following{/other_user}","gists_url":"https://api.github.com/users/ahoarau/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoarau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoarau/subscriptions","organizations_url":"https://api.github.com/users/ahoarau/orgs","repos_url":"https://api.github.com/users/ahoarau/repos","events_url":"https://api.github.com/users/ahoarau/events{/privacy}","received_events_url":"https://api.github.com/users/ahoarau/received_events","type":"User","site_admin":false},"repo":{"id":148993030,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg5OTMwMzA=","name":"idyntree","full_name":"ahoarau/idyntree","private":false,"owner":{"login":"ahoarau","id":703240,"node_id":"MDQ6VXNlcjcwMzI0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/703240?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoarau","html_url":"https://github.com/ahoarau","followers_url":"https://api.github.com/users/ahoarau/followers","following_url":"https://api.github.com/users/ahoarau/following{/other_user}","gists_url":"https://api.github.com/users/ahoarau/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoarau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoarau/subscriptions","organizations_url":"https://api.github.com/users/ahoarau/orgs","repos_url":"https://api.github.com/users/ahoarau/repos","events_url":"https://api.github.com/users/ahoarau/events{/privacy}","received_events_url":"https://api.github.com/users/ahoarau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ahoarau/idyntree","description":"Multibody Dynamics Library designed for Free Floating Robots ","fork":true,"url":"https://api.github.com/repos/ahoarau/idyntree","forks_url":"https://api.github.com/repos/ahoarau/idyntree/forks","keys_url":"https://api.github.com/repos/ahoarau/idyntree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahoarau/idyntree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahoarau/idyntree/teams","hooks_url":"https://api.github.com/repos/ahoarau/idyntree/hooks","issue_events_url":"https://api.github.com/repos/ahoarau/idyntree/issues/events{/number}","events_url":"https://api.github.com/repos/ahoarau/idyntree/events","assignees_url":"https://api.github.com/repos/ahoarau/idyntree/assignees{/user}","branches_url":"https://api.github.com/repos/ahoarau/idyntree/branches{/branch}","tags_url":"https://api.github.com/repos/ahoarau/idyntree/tags","blobs_url":"https://api.github.com/repos/ahoarau/idyntree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahoarau/idyntree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahoarau/idyntree/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahoarau/idyntree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahoarau/idyntree/statuses/{sha}","languages_url":"https://api.github.com/repos/ahoarau/idyntree/languages","stargazers_url":"https://api.github.com/repos/ahoarau/idyntree/stargazers","contributors_url":"https://api.github.com/repos/ahoarau/idyntree/contributors","subscribers_url":"https://api.github.com/repos/ahoarau/idyntree/subscribers","subscription_url":"https://api.github.com/repos/ahoarau/idyntree/subscription","commits_url":"https://api.github.com/repos/ahoarau/idyntree/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahoarau/idyntree/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahoarau/idyntree/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahoarau/idyntree/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahoarau/idyntree/contents/{+path}","compare_url":"https://api.github.com/repos/ahoarau/idyntree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahoarau/idyntree/merges","archive_url":"https://api.github.com/repos/ahoarau/idyntree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahoarau/idyntree/downloads","issues_url":"https://api.github.com/repos/ahoarau/idyntree/issues{/number}","pulls_url":"https://api.github.com/repos/ahoarau/idyntree/pulls{/number}","milestones_url":"https://api.github.com/repos/ahoarau/idyntree/milestones{/number}","notifications_url":"https://api.github.com/repos/ahoarau/idyntree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahoarau/idyntree/labels{/name}","releases_url":"https://api.github.com/repos/ahoarau/idyntree/releases{/id}","deployments_url":"https://api.github.com/repos/ahoarau/idyntree/deployments","created_at":"2018-09-16T12:23:16Z","updated_at":"2018-09-16T12:23:20Z","pushed_at":"2018-09-16T12:26:15Z","git_url":"git://github.com/ahoarau/idyntree.git","ssh_url":"git@github.com:ahoarau/idyntree.git","clone_url":"https://github.com/ahoarau/idyntree.git","svn_url":"https://github.com/ahoarau/idyntree","homepage":"","size":9357,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"robotology:master","ref":"master","sha":"d07c7c145c234ed1abd8745cd04b0c3a60e2e7bc","user":{"login":"robotology","id":1587191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODcxOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":17824536,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyNDUzNg==","name":"idyntree","full_name":"robotology/idyntree","private":false,"owner":{"login":"robotology","id":1587191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODcxOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/robotology/idyntree","description":"Multibody Dynamics Library designed for Free Floating Robots ","fork":false,"url":"https://api.github.com/repos/robotology/idyntree","forks_url":"https://api.github.com/repos/robotology/idyntree/forks","keys_url":"https://api.github.com/repos/robotology/idyntree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/idyntree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/idyntree/teams","hooks_url":"https://api.github.com/repos/robotology/idyntree/hooks","issue_events_url":"https://api.github.com/repos/robotology/idyntree/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/idyntree/events","assignees_url":"https://api.github.com/repos/robotology/idyntree/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/idyntree/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/idyntree/tags","blobs_url":"https://api.github.com/repos/robotology/idyntree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/idyntree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/idyntree/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/idyntree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/idyntree/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/idyntree/languages","stargazers_url":"https://api.github.com/repos/robotology/idyntree/stargazers","contributors_url":"https://api.github.com/repos/robotology/idyntree/contributors","subscribers_url":"https://api.github.com/repos/robotology/idyntree/subscribers","subscription_url":"https://api.github.com/repos/robotology/idyntree/subscription","commits_url":"https://api.github.com/repos/robotology/idyntree/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/idyntree/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/idyntree/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/idyntree/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/idyntree/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/idyntree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/idyntree/merges","archive_url":"https://api.github.com/repos/robotology/idyntree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/idyntree/downloads","issues_url":"https://api.github.com/repos/robotology/idyntree/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/idyntree/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/idyntree/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/idyntree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/idyntree/labels{/name}","releases_url":"https://api.github.com/repos/robotology/idyntree/releases{/id}","deployments_url":"https://api.github.com/repos/robotology/idyntree/deployments","created_at":"2014-03-17T10:35:53Z","updated_at":"2018-09-13T22:30:47Z","pushed_at":"2018-09-16T12:26:55Z","git_url":"git://github.com/robotology/idyntree.git","ssh_url":"git@github.com:robotology/idyntree.git","clone_url":"https://github.com/robotology/idyntree.git","svn_url":"https://github.com/robotology/idyntree","homepage":"","size":9357,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":23,"open_issues":132,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotology/idyntree/pulls/489"},"html":{"href":"https://github.com/robotology/idyntree/pull/489"},"issue":{"href":"https://api.github.com/repos/robotology/idyntree/issues/489"},"comments":{"href":"https://api.github.com/repos/robotology/idyntree/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/robotology/idyntree/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/robotology/idyntree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotology/idyntree/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/robotology/idyntree/statuses/f0b81cb14edc6ff9420f94608d13e68d54a4f532"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"traversaro"}}