{"action":"created","comment":{"url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/comments/244796574","pull_request_review_id":188755652,"id":244796574,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDc5NjU3NA==","diff_hunk":"@@ -0,0 +1,24 @@\n+{\n+  \"source\": [\n+    \"aws.ecr\"\n+  ],\n+  \"detail-type\": [\n+    \"AWS API Call via CloudTrail\"\n+  ],\n+  \"detail\": {\n+    \"eventSource\": [\n+      \"ecr.amazonaws.com\"\n+    ],\n+    \"eventName\": [\n+      \"PutImage\"\n+    ],\n+    \"requestParameters\": {\n+      \"repositoryName\": [\n+        \"${ecr_repository_name}\"\n+      ],\n+      \"imageTag\": [\n+        \"latest\"","path":"cloudwatch/ecr-source-event.json","position":20,"original_position":20,"commit_id":"110140bf6a20758be08874dc44a743fbf06acf04","original_commit_id":"110140bf6a20758be08874dc44a743fbf06acf04","user":{"login":"robertrossmann","id":3058150,"node_id":"MDQ6VXNlcjMwNTgxNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/3058150?v=4","gravatar_id":"","url":"https://api.github.com/users/robertrossmann","html_url":"https://github.com/robertrossmann","followers_url":"https://api.github.com/users/robertrossmann/followers","following_url":"https://api.github.com/users/robertrossmann/following{/other_user}","gists_url":"https://api.github.com/users/robertrossmann/gists{/gist_id}","starred_url":"https://api.github.com/users/robertrossmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertrossmann/subscriptions","organizations_url":"https://api.github.com/users/robertrossmann/orgs","repos_url":"https://api.github.com/users/robertrossmann/repos","events_url":"https://api.github.com/users/robertrossmann/events{/privacy}","received_events_url":"https://api.github.com/users/robertrossmann/received_events","type":"User","site_admin":false},"body":"Does it have to be the generic `latest` tag? Could we use the actual commit shasum instead?\r\n\r\nI am worried what would happen if multiple concurrent pushes occurred and there would be more than a single pending deployment running.","created_at":"2019-01-02T17:13:09Z","updated_at":"2019-01-02T17:13:10Z","html_url":"https://github.com/strvcom/terraform-aws-strv-fargate/pull/9#discussion_r244796574","pull_request_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/9","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/comments/244796574"},"html":{"href":"https://github.com/strvcom/terraform-aws-strv-fargate/pull/9#discussion_r244796574"},"pull_request":{"href":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/9","id":241318543,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzE4NTQz","html_url":"https://github.com/strvcom/terraform-aws-strv-fargate/pull/9","diff_url":"https://github.com/strvcom/terraform-aws-strv-fargate/pull/9.diff","patch_url":"https://github.com/strvcom/terraform-aws-strv-fargate/pull/9.patch","issue_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/issues/9","number":9,"state":"open","locked":false,"title":"Replace CodePipeline Source trigger from GitHub to ECR","user":{"login":"jlsan92","id":6589792,"node_id":"MDQ6VXNlcjY1ODk3OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/6589792?v=4","gravatar_id":"","url":"https://api.github.com/users/jlsan92","html_url":"https://github.com/jlsan92","followers_url":"https://api.github.com/users/jlsan92/followers","following_url":"https://api.github.com/users/jlsan92/following{/other_user}","gists_url":"https://api.github.com/users/jlsan92/gists{/gist_id}","starred_url":"https://api.github.com/users/jlsan92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlsan92/subscriptions","organizations_url":"https://api.github.com/users/jlsan92/orgs","repos_url":"https://api.github.com/users/jlsan92/repos","events_url":"https://api.github.com/users/jlsan92/events{/privacy}","received_events_url":"https://api.github.com/users/jlsan92/received_events","type":"User","site_admin":false},"body":"This PR changes how the CodePipeline is triggered. Before it was triggered by a new change pushed into a GitHub repo, which was not ideal since the module was strictly coupled to GitHub and also it was needed to specify a GitHub integration token with the first `terraform apply` (as described in the [Basic example](https://github.com/strvcom/terraform-aws-strv-fargate/tree/master/examples/basic))\r\n\r\nNow the trigger for new updates comes from the ECR when a new Docker image is published, so now this modules only cares about updates Docker images and users can delegate other CI/CD processes with a different service like Travis or CircleCI.","created_at":"2018-12-28T11:40:46Z","updated_at":"2019-01-02T17:13:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"131c523bd6449fd7c5c43932caef705b6deae396","assignee":{"login":"jlsan92","id":6589792,"node_id":"MDQ6VXNlcjY1ODk3OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/6589792?v=4","gravatar_id":"","url":"https://api.github.com/users/jlsan92","html_url":"https://github.com/jlsan92","followers_url":"https://api.github.com/users/jlsan92/followers","following_url":"https://api.github.com/users/jlsan92/following{/other_user}","gists_url":"https://api.github.com/users/jlsan92/gists{/gist_id}","starred_url":"https://api.github.com/users/jlsan92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlsan92/subscriptions","organizations_url":"https://api.github.com/users/jlsan92/orgs","repos_url":"https://api.github.com/users/jlsan92/repos","events_url":"https://api.github.com/users/jlsan92/events{/privacy}","received_events_url":"https://api.github.com/users/jlsan92/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlsan92","id":6589792,"node_id":"MDQ6VXNlcjY1ODk3OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/6589792?v=4","gravatar_id":"","url":"https://api.github.com/users/jlsan92","html_url":"https://github.com/jlsan92","followers_url":"https://api.github.com/users/jlsan92/followers","following_url":"https://api.github.com/users/jlsan92/following{/other_user}","gists_url":"https://api.github.com/users/jlsan92/gists{/gist_id}","starred_url":"https://api.github.com/users/jlsan92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlsan92/subscriptions","organizations_url":"https://api.github.com/users/jlsan92/orgs","repos_url":"https://api.github.com/users/jlsan92/repos","events_url":"https://api.github.com/users/jlsan92/events{/privacy}","received_events_url":"https://api.github.com/users/jlsan92/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/9/commits","review_comments_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/9/comments","review_comment_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/issues/9/comments","statuses_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/statuses/110140bf6a20758be08874dc44a743fbf06acf04","head":{"label":"strvcom:refactor/ecr-as-source","ref":"refactor/ecr-as-source","sha":"110140bf6a20758be08874dc44a743fbf06acf04","user":{"login":"strvcom","id":3081447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODE0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3081447?v=4","gravatar_id":"","url":"https://api.github.com/users/strvcom","html_url":"https://github.com/strvcom","followers_url":"https://api.github.com/users/strvcom/followers","following_url":"https://api.github.com/users/strvcom/following{/other_user}","gists_url":"https://api.github.com/users/strvcom/gists{/gist_id}","starred_url":"https://api.github.com/users/strvcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strvcom/subscriptions","organizations_url":"https://api.github.com/users/strvcom/orgs","repos_url":"https://api.github.com/users/strvcom/repos","events_url":"https://api.github.com/users/strvcom/events{/privacy}","received_events_url":"https://api.github.com/users/strvcom/received_events","type":"Organization","site_admin":false},"repo":{"id":148787917,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3ODc5MTc=","name":"terraform-aws-strv-fargate","full_name":"strvcom/terraform-aws-strv-fargate","private":false,"owner":{"login":"strvcom","id":3081447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODE0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3081447?v=4","gravatar_id":"","url":"https://api.github.com/users/strvcom","html_url":"https://github.com/strvcom","followers_url":"https://api.github.com/users/strvcom/followers","following_url":"https://api.github.com/users/strvcom/following{/other_user}","gists_url":"https://api.github.com/users/strvcom/gists{/gist_id}","starred_url":"https://api.github.com/users/strvcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strvcom/subscriptions","organizations_url":"https://api.github.com/users/strvcom/orgs","repos_url":"https://api.github.com/users/strvcom/repos","events_url":"https://api.github.com/users/strvcom/events{/privacy}","received_events_url":"https://api.github.com/users/strvcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strvcom/terraform-aws-strv-fargate","description":"Terraform module to provision a Fargate-ready AWS infrastructure 🚀","fork":false,"url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate","forks_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/forks","keys_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/teams","hooks_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/hooks","issue_events_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/issues/events{/number}","events_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/events","assignees_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/assignees{/user}","branches_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/branches{/branch}","tags_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/tags","blobs_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/git/refs{/sha}","trees_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/statuses/{sha}","languages_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/languages","stargazers_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/stargazers","contributors_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/contributors","subscribers_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/subscribers","subscription_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/subscription","commits_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/commits{/sha}","git_commits_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/git/commits{/sha}","comments_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/comments{/number}","issue_comment_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/issues/comments{/number}","contents_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/contents/{+path}","compare_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/merges","archive_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/downloads","issues_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/issues{/number}","pulls_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls{/number}","milestones_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/milestones{/number}","notifications_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/labels{/name}","releases_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/releases{/id}","deployments_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/deployments","created_at":"2018-09-14T12:51:50Z","updated_at":"2018-12-20T12:23:04Z","pushed_at":"2019-01-02T17:06:31Z","git_url":"git://github.com/strvcom/terraform-aws-strv-fargate.git","ssh_url":"git@github.com:strvcom/terraform-aws-strv-fargate.git","clone_url":"https://github.com/strvcom/terraform-aws-strv-fargate.git","svn_url":"https://github.com/strvcom/terraform-aws-strv-fargate","homepage":"","size":43,"stargazers_count":3,"watchers_count":3,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"strvcom:master","ref":"master","sha":"4f33afae7eebc9a4da78f0ab0fa1269f6f33b88c","user":{"login":"strvcom","id":3081447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODE0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3081447?v=4","gravatar_id":"","url":"https://api.github.com/users/strvcom","html_url":"https://github.com/strvcom","followers_url":"https://api.github.com/users/strvcom/followers","following_url":"https://api.github.com/users/strvcom/following{/other_user}","gists_url":"https://api.github.com/users/strvcom/gists{/gist_id}","starred_url":"https://api.github.com/users/strvcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strvcom/subscriptions","organizations_url":"https://api.github.com/users/strvcom/orgs","repos_url":"https://api.github.com/users/strvcom/repos","events_url":"https://api.github.com/users/strvcom/events{/privacy}","received_events_url":"https://api.github.com/users/strvcom/received_events","type":"Organization","site_admin":false},"repo":{"id":148787917,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3ODc5MTc=","name":"terraform-aws-strv-fargate","full_name":"strvcom/terraform-aws-strv-fargate","private":false,"owner":{"login":"strvcom","id":3081447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODE0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3081447?v=4","gravatar_id":"","url":"https://api.github.com/users/strvcom","html_url":"https://github.com/strvcom","followers_url":"https://api.github.com/users/strvcom/followers","following_url":"https://api.github.com/users/strvcom/following{/other_user}","gists_url":"https://api.github.com/users/strvcom/gists{/gist_id}","starred_url":"https://api.github.com/users/strvcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strvcom/subscriptions","organizations_url":"https://api.github.com/users/strvcom/orgs","repos_url":"https://api.github.com/users/strvcom/repos","events_url":"https://api.github.com/users/strvcom/events{/privacy}","received_events_url":"https://api.github.com/users/strvcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strvcom/terraform-aws-strv-fargate","description":"Terraform module to provision a Fargate-ready AWS infrastructure 🚀","fork":false,"url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate","forks_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/forks","keys_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/teams","hooks_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/hooks","issue_events_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/issues/events{/number}","events_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/events","assignees_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/assignees{/user}","branches_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/branches{/branch}","tags_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/tags","blobs_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/git/refs{/sha}","trees_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/statuses/{sha}","languages_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/languages","stargazers_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/stargazers","contributors_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/contributors","subscribers_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/subscribers","subscription_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/subscription","commits_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/commits{/sha}","git_commits_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/git/commits{/sha}","comments_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/comments{/number}","issue_comment_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/issues/comments{/number}","contents_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/contents/{+path}","compare_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/merges","archive_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/downloads","issues_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/issues{/number}","pulls_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls{/number}","milestones_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/milestones{/number}","notifications_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/labels{/name}","releases_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/releases{/id}","deployments_url":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/deployments","created_at":"2018-09-14T12:51:50Z","updated_at":"2018-12-20T12:23:04Z","pushed_at":"2019-01-02T17:06:31Z","git_url":"git://github.com/strvcom/terraform-aws-strv-fargate.git","ssh_url":"git@github.com:strvcom/terraform-aws-strv-fargate.git","clone_url":"https://github.com/strvcom/terraform-aws-strv-fargate.git","svn_url":"https://github.com/strvcom/terraform-aws-strv-fargate","homepage":"","size":43,"stargazers_count":3,"watchers_count":3,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/9"},"html":{"href":"https://github.com/strvcom/terraform-aws-strv-fargate/pull/9"},"issue":{"href":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/issues/9"},"comments":{"href":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/strvcom/terraform-aws-strv-fargate/statuses/110140bf6a20758be08874dc44a743fbf06acf04"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robertrossmann"}}