{"action":"created","issue":{"url":"https://api.github.com/repos/Lora-net/LoRaMac-node/issues/418","repository_url":"https://api.github.com/repos/Lora-net/LoRaMac-node","labels_url":"https://api.github.com/repos/Lora-net/LoRaMac-node/issues/418/labels{/name}","comments_url":"https://api.github.com/repos/Lora-net/LoRaMac-node/issues/418/comments","events_url":"https://api.github.com/repos/Lora-net/LoRaMac-node/issues/418/events","html_url":"https://github.com/Lora-net/LoRaMac-node/issues/418","id":304341177,"number":418,"title":"FSK / GFSK SX1272/SX1276","user":{"login":"GrumpyOldPizza","id":7213180,"avatar_url":"https://avatars0.githubusercontent.com/u/7213180?v=4","gravatar_id":"","url":"https://api.github.com/users/GrumpyOldPizza","html_url":"https://github.com/GrumpyOldPizza","followers_url":"https://api.github.com/users/GrumpyOldPizza/followers","following_url":"https://api.github.com/users/GrumpyOldPizza/following{/other_user}","gists_url":"https://api.github.com/users/GrumpyOldPizza/gists{/gist_id}","starred_url":"https://api.github.com/users/GrumpyOldPizza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrumpyOldPizza/subscriptions","organizations_url":"https://api.github.com/users/GrumpyOldPizza/orgs","repos_url":"https://api.github.com/users/GrumpyOldPizza/repos","events_url":"https://api.github.com/users/GrumpyOldPizza/events{/privacy}","received_events_url":"https://api.github.com/users/GrumpyOldPizza/received_events","type":"User","site_admin":false},"labels":[{"id":77622019,"url":"https://api.github.com/repos/Lora-net/LoRaMac-node/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-12T11:53:00Z","updated_at":"2018-03-28T13:38:57Z","closed_at":"2018-03-28T13:09:10Z","author_association":"NONE","body":"As per https://github.com/Lora-net/LoRaMac-node/issues/417, EU868 DR_7 should use GFSK with BT 0.5. The SX1272/SX1276 code uses the default register settings, which leads to FSK usage instead of GFSK.\r\n\r\nFurthermore, there is this here in https://github.com/Lora-net/lora_gateway/blob/master/libloragw/src/loragw_radio.c:\r\n\r\n    /* Set in FSK mode */\r\n    x = lgw_sx127x_reg_w(SX1276_REG_OPMODE, 0);\r\n    wait_ms(100);\r\n    x |= lgw_sx127x_reg_w(SX1276_REG_OPMODE, 0 | (ModulationShaping << 3)); /* Sleep mode, no FSK shaping */\r\n    wait_ms(100);\r\n    x |= lgw_sx127x_reg_w(SX1276_REG_OPMODE, 1 | (ModulationShaping << 3)); /* Standby mode, no FSK shaping */\r\n    wait_ms(100);\r\n\r\n\r\nSo will a if you change SX1272/SX1276 from FSK to GFSK BT 0.5, will that break then gateways as well ?\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Lora-net/LoRaMac-node/issues/comments/376889947","html_url":"https://github.com/Lora-net/LoRaMac-node/issues/418#issuecomment-376889947","issue_url":"https://api.github.com/repos/Lora-net/LoRaMac-node/issues/418","id":376889947,"user":{"login":"GrumpyOldPizza","id":7213180,"avatar_url":"https://avatars0.githubusercontent.com/u/7213180?v=4","gravatar_id":"","url":"https://api.github.com/users/GrumpyOldPizza","html_url":"https://github.com/GrumpyOldPizza","followers_url":"https://api.github.com/users/GrumpyOldPizza/followers","following_url":"https://api.github.com/users/GrumpyOldPizza/following{/other_user}","gists_url":"https://api.github.com/users/GrumpyOldPizza/gists{/gist_id}","starred_url":"https://api.github.com/users/GrumpyOldPizza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrumpyOldPizza/subscriptions","organizations_url":"https://api.github.com/users/GrumpyOldPizza/orgs","repos_url":"https://api.github.com/users/GrumpyOldPizza/repos","events_url":"https://api.github.com/users/GrumpyOldPizza/events{/privacy}","received_events_url":"https://api.github.com/users/GrumpyOldPizza/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T13:38:56Z","updated_at":"2018-03-28T13:38:56Z","author_association":"NONE","body":"Does this apply to SX1276 as well ?\n\nOn Wed, Mar 28, 2018 at 7:09 AM, Miguel Luis <notifications@github.com>\nwrote:\n\n> In a future version of the LoRaWAN Regional Parameters document the\n> modulation shaping is to be set to 1.\n> Thus we reverted back the commit b137f86\n> <https://github.com/Lora-net/LoRaMac-node/commit/b137f8633c6fccb7027dc703c3193dd5ee8645c1>\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/Lora-net/LoRaMac-node/issues/418#issuecomment-376880373>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AG4QfP02G-R2yAjbO9dehw2tDrWPg1nBks5ti4uBgaJpZM4SmgV8>\n> .\n>\n"}}
{"actor":{"display_login":"GrumpyOldPizza"}}