{"action":"created","issue":{"url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/979","repository_url":"https://api.github.com/repos/hibernate/hibernate-ogm","labels_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/979/labels{/name}","comments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/979/comments","events_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/979/events","html_url":"https://github.com/hibernate/hibernate-ogm/pull/979","id":301443541,"number":979,"title":"OGM-359 Stored procedures for Mongo","user":{"login":"DavideD","id":559221,"avatar_url":"https://avatars1.githubusercontent.com/u/559221?v=4","gravatar_id":"","url":"https://api.github.com/users/DavideD","html_url":"https://github.com/DavideD","followers_url":"https://api.github.com/users/DavideD/followers","following_url":"https://api.github.com/users/DavideD/following{/other_user}","gists_url":"https://api.github.com/users/DavideD/gists{/gist_id}","starred_url":"https://api.github.com/users/DavideD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavideD/subscriptions","organizations_url":"https://api.github.com/users/DavideD/orgs","repos_url":"https://api.github.com/users/DavideD/repos","events_url":"https://api.github.com/users/DavideD/events{/privacy}","received_events_url":"https://api.github.com/users/DavideD/received_events","type":"User","site_admin":false},"labels":[{"id":370839767,"url":"https://api.github.com/repos/hibernate/hibernate-ogm/labels/Ready%20for%20review","name":"Ready for review","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":{"login":"DavideD","id":559221,"avatar_url":"https://avatars1.githubusercontent.com/u/559221?v=4","gravatar_id":"","url":"https://api.github.com/users/DavideD","html_url":"https://github.com/DavideD","followers_url":"https://api.github.com/users/DavideD/followers","following_url":"https://api.github.com/users/DavideD/following{/other_user}","gists_url":"https://api.github.com/users/DavideD/gists{/gist_id}","starred_url":"https://api.github.com/users/DavideD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavideD/subscriptions","organizations_url":"https://api.github.com/users/DavideD/orgs","repos_url":"https://api.github.com/users/DavideD/repos","events_url":"https://api.github.com/users/DavideD/events{/privacy}","received_events_url":"https://api.github.com/users/DavideD/received_events","type":"User","site_admin":false},"assignees":[{"login":"DavideD","id":559221,"avatar_url":"https://avatars1.githubusercontent.com/u/559221?v=4","gravatar_id":"","url":"https://api.github.com/users/DavideD","html_url":"https://github.com/DavideD","followers_url":"https://api.github.com/users/DavideD/followers","following_url":"https://api.github.com/users/DavideD/following{/other_user}","gists_url":"https://api.github.com/users/DavideD/gists{/gist_id}","starred_url":"https://api.github.com/users/DavideD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavideD/subscriptions","organizations_url":"https://api.github.com/users/DavideD/orgs","repos_url":"https://api.github.com/users/DavideD/repos","events_url":"https://api.github.com/users/DavideD/events{/privacy}","received_events_url":"https://api.github.com/users/DavideD/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-03-01T15:19:27Z","updated_at":"2018-03-08T17:47:44Z","closed_at":"2018-03-08T17:34:26Z","author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/979","html_url":"https://github.com/hibernate/hibernate-ogm/pull/979","diff_url":"https://github.com/hibernate/hibernate-ogm/pull/979.diff","patch_url":"https://github.com/hibernate/hibernate-ogm/pull/979.patch"},"body":"[OGM-359](https://hibernate.atlassian.net/browse/OGM-359)\r\n\r\nFollows #976 \r\n\r\nWhile  I was checking the latest PR on stored procedures I noticed several issues and ended up fixing them and rebase the history. I think now it's in a state the we can merge. In particular,  this PR:\r\n\r\n* Fix the logic by making it more similar to the one in ORM\r\n* Removes commons-lang library to escape strings and created a utility method that hopefully will work\r\n* Adds test cases for when an exception is raised\r\n* NoSQLProcedureResultSetOutputImpl.java is now the same as the one in ORM. The problem with the one in ORM is that it is package private\r\n* Clean up the exception messages, they are more user friendly now \r\n\r\nThere are still a couple of tests to add:\r\n* Check storeprocedures returning multiple entities\r\n* Test case for stored procedures in MongoDB causing log.multipleDocumentReturnedByStoredProcedure\r\n\r\nI'll create a separate issue for these latest couple of cases"},"comment":{"url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/comments/371566543","html_url":"https://github.com/hibernate/hibernate-ogm/pull/979#issuecomment-371566543","issue_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/979","id":371566543,"user":{"login":"gsmet","id":1279749,"avatar_url":"https://avatars1.githubusercontent.com/u/1279749?v=4","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T17:47:44Z","updated_at":"2018-03-08T17:47:44Z","author_association":"OWNER","body":"@DavideD Nice, glad to see this in."}}
{"actor":{"display_login":"gsmet"}}