{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/237613974","pull_request_review_id":179957187,"id":237613974,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzYxMzk3NA==","diff_hunk":"@@ -20,6 +19,14 @@ const RCTAsyncStorage =\n   NativeModules.AsyncSQLiteDBStorage ||\n   NativeModules.AsyncLocalStorage;\n \n+type MultiRequestType = {|\n+  keys: Array<string>,\n+  callback: ?(errors: ?Array<Error>, result: ?Array<Array<string>>) => void,\n+  keyIndex: number,\n+  resolve: ?(result?: Promise<any>) => void,","path":"Libraries/Storage/AsyncStorage.js","position":18,"original_position":18,"commit_id":"7695f79b752d42e07c24d15e9bd81af3235491c5","original_commit_id":"7695f79b752d42e07c24d15e9bd81af3235491c5","user":{"login":"TheSavior","id":249164,"node_id":"MDQ6VXNlcjI0OTE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/249164?v=4","gravatar_id":"","url":"https://api.github.com/users/TheSavior","html_url":"https://github.com/TheSavior","followers_url":"https://api.github.com/users/TheSavior/followers","following_url":"https://api.github.com/users/TheSavior/following{/other_user}","gists_url":"https://api.github.com/users/TheSavior/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSavior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSavior/subscriptions","organizations_url":"https://api.github.com/users/TheSavior/orgs","repos_url":"https://api.github.com/users/TheSavior/repos","events_url":"https://api.github.com/users/TheSavior/events{/privacy}","received_events_url":"https://api.github.com/users/TheSavior/received_events","type":"User","site_admin":false},"body":"Why does this Promise resolve the `any` type? Are we able to be more specific with this type?","created_at":"2018-11-29T18:51:39Z","updated_at":"2018-11-29T18:51:39Z","html_url":"https://github.com/facebook/react-native/pull/22212#discussion_r237613974","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/22212","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/237613974"},"html":{"href":"https://github.com/facebook/react-native/pull/22212#discussion_r237613974"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/22212"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/22212","id":229333027,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzMzMDI3","html_url":"https://github.com/facebook/react-native/pull/22212","diff_url":"https://github.com/facebook/react-native/pull/22212.diff","patch_url":"https://github.com/facebook/react-native/pull/22212.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/22212","number":22212,"state":"open","locked":false,"title":"Fixed for supporting flow of AsyncStorage.","user":{"login":"ifsnow","id":3139234,"node_id":"MDQ6VXNlcjMxMzkyMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3139234?v=4","gravatar_id":"","url":"https://api.github.com/users/ifsnow","html_url":"https://github.com/ifsnow","followers_url":"https://api.github.com/users/ifsnow/followers","following_url":"https://api.github.com/users/ifsnow/following{/other_user}","gists_url":"https://api.github.com/users/ifsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/ifsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifsnow/subscriptions","organizations_url":"https://api.github.com/users/ifsnow/orgs","repos_url":"https://api.github.com/users/ifsnow/repos","events_url":"https://api.github.com/users/ifsnow/events{/privacy}","received_events_url":"https://api.github.com/users/ifsnow/received_events","type":"User","site_admin":false},"body":"As you know, `AsyncStorage` does not support flow. This is a little inconvenient when developing.\r\n\r\nI hope this helps.\r\n\r\nTest Plan:\r\n----------\r\n- [x] Check npm run flow\r\n- [x] Check npm run flow-check-ios\r\n- [x] Check npm run flow-check-android\r\n\r\nRelease Notes:\r\n----------\r\n[GENERAL] [ENHANCEMENT] [Libraries/Storage/AsyncStorage.js] - support flow\r\n","created_at":"2018-11-08T11:28:29Z","updated_at":"2018-11-29T18:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ecb10301233c41cac1c05272c2f03c7789f7e76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196858975,"node_id":"MDU6TGFiZWwxOTY4NTg5NzU=","url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"ffffff","default":false},{"id":1117070725,"node_id":"MDU6TGFiZWwxMTE3MDcwNzI1","url":"https://api.github.com/repos/facebook/react-native/labels/Flow","name":"Flow","color":"E8BD36","default":false},{"id":869759799,"node_id":"MDU6TGFiZWw4Njk3NTk3OTk=","url":"https://api.github.com/repos/facebook/react-native/labels/%E2%9C%85Release%20Notes","name":"✅Release Notes","color":"0e8a16","default":false},{"id":1065062573,"node_id":"MDU6TGFiZWwxMDY1MDYyNTcz","url":"https://api.github.com/repos/facebook/react-native/labels/%F0%9F%94%B6APIs","name":"🔶APIs","color":"fef2c0","default":false},{"id":934529168,"node_id":"MDU6TGFiZWw5MzQ1MjkxNjg=","url":"https://api.github.com/repos/facebook/react-native/labels/%F0%9F%94%B6AsyncStorage","name":"🔶AsyncStorage","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/22212/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/22212/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/22212/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/7695f79b752d42e07c24d15e9bd81af3235491c5","head":{"label":"ifsnow:fix/support-flow-asyncstorage","ref":"fix/support-flow-asyncstorage","sha":"7695f79b752d42e07c24d15e9bd81af3235491c5","user":{"login":"ifsnow","id":3139234,"node_id":"MDQ6VXNlcjMxMzkyMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3139234?v=4","gravatar_id":"","url":"https://api.github.com/users/ifsnow","html_url":"https://github.com/ifsnow","followers_url":"https://api.github.com/users/ifsnow/followers","following_url":"https://api.github.com/users/ifsnow/following{/other_user}","gists_url":"https://api.github.com/users/ifsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/ifsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifsnow/subscriptions","organizations_url":"https://api.github.com/users/ifsnow/orgs","repos_url":"https://api.github.com/users/ifsnow/repos","events_url":"https://api.github.com/users/ifsnow/events{/privacy}","received_events_url":"https://api.github.com/users/ifsnow/received_events","type":"User","site_admin":false},"repo":{"id":111864810,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4NjQ4MTA=","name":"react-native","full_name":"ifsnow/react-native","private":false,"owner":{"login":"ifsnow","id":3139234,"node_id":"MDQ6VXNlcjMxMzkyMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3139234?v=4","gravatar_id":"","url":"https://api.github.com/users/ifsnow","html_url":"https://github.com/ifsnow","followers_url":"https://api.github.com/users/ifsnow/followers","following_url":"https://api.github.com/users/ifsnow/following{/other_user}","gists_url":"https://api.github.com/users/ifsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/ifsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifsnow/subscriptions","organizations_url":"https://api.github.com/users/ifsnow/orgs","repos_url":"https://api.github.com/users/ifsnow/repos","events_url":"https://api.github.com/users/ifsnow/events{/privacy}","received_events_url":"https://api.github.com/users/ifsnow/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ifsnow/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/ifsnow/react-native","forks_url":"https://api.github.com/repos/ifsnow/react-native/forks","keys_url":"https://api.github.com/repos/ifsnow/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifsnow/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifsnow/react-native/teams","hooks_url":"https://api.github.com/repos/ifsnow/react-native/hooks","issue_events_url":"https://api.github.com/repos/ifsnow/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/ifsnow/react-native/events","assignees_url":"https://api.github.com/repos/ifsnow/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/ifsnow/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/ifsnow/react-native/tags","blobs_url":"https://api.github.com/repos/ifsnow/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifsnow/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifsnow/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifsnow/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifsnow/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/ifsnow/react-native/languages","stargazers_url":"https://api.github.com/repos/ifsnow/react-native/stargazers","contributors_url":"https://api.github.com/repos/ifsnow/react-native/contributors","subscribers_url":"https://api.github.com/repos/ifsnow/react-native/subscribers","subscription_url":"https://api.github.com/repos/ifsnow/react-native/subscription","commits_url":"https://api.github.com/repos/ifsnow/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifsnow/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifsnow/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifsnow/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifsnow/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/ifsnow/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifsnow/react-native/merges","archive_url":"https://api.github.com/repos/ifsnow/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifsnow/react-native/downloads","issues_url":"https://api.github.com/repos/ifsnow/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/ifsnow/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/ifsnow/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/ifsnow/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifsnow/react-native/labels{/name}","releases_url":"https://api.github.com/repos/ifsnow/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/ifsnow/react-native/deployments","created_at":"2017-11-24T01:48:14Z","updated_at":"2018-11-05T04:46:18Z","pushed_at":"2018-11-29T07:32:37Z","git_url":"git://github.com/ifsnow/react-native.git","ssh_url":"git@github.com:ifsnow/react-native.git","clone_url":"https://github.com/ifsnow/react-native.git","svn_url":"https://github.com/ifsnow/react-native","homepage":"http://facebook.github.io/react-native/","size":171235,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"54e8d6cdc8ba9eebfc75a435d7249f6b0449d518","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"node_id":"MDEwOlJlcG9zaXRvcnkyOTAyODc3NQ==","name":"react-native","full_name":"facebook/react-native","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2018-11-29T18:46:05Z","pushed_at":"2018-11-29T07:32:42Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"https://facebook.github.io/react-native/","size":287539,"stargazers_count":71424,"watchers_count":71424,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15992,"mirror_url":null,"archived":false,"open_issues_count":975,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15992,"open_issues":975,"watchers":71424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/22212"},"html":{"href":"https://github.com/facebook/react-native/pull/22212"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/22212"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/22212/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/22212/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/22212/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/7695f79b752d42e07c24d15e9bd81af3235491c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TheSavior"}}