{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/openj9/issues/3259","repository_url":"https://api.github.com/repos/eclipse/openj9","labels_url":"https://api.github.com/repos/eclipse/openj9/issues/3259/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/3259/comments","events_url":"https://api.github.com/repos/eclipse/openj9/issues/3259/events","html_url":"https://github.com/eclipse/openj9/pull/3259","id":369726610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTk4Njg5","number":3259,"title":"OpenJ9 JDK8 Support for OSX","user":{"login":"babsingh","id":8634038,"node_id":"MDQ6VXNlcjg2MzQwMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/8634038?v=4","gravatar_id":"","url":"https://api.github.com/users/babsingh","html_url":"https://github.com/babsingh","followers_url":"https://api.github.com/users/babsingh/followers","following_url":"https://api.github.com/users/babsingh/following{/other_user}","gists_url":"https://api.github.com/users/babsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/babsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babsingh/subscriptions","organizations_url":"https://api.github.com/users/babsingh/orgs","repos_url":"https://api.github.com/users/babsingh/repos","events_url":"https://api.github.com/users/babsingh/events{/privacy}","received_events_url":"https://api.github.com/users/babsingh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-12T22:10:04Z","updated_at":"2018-10-15T02:58:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/3259","html_url":"https://github.com/eclipse/openj9/pull/3259","diff_url":"https://github.com/eclipse/openj9/pull/3259.diff","patch_url":"https://github.com/eclipse/openj9/pull/3259.patch"},"body":"**1) Add flag to toggle assembly syntax while building OpenJ9 JDK8 on OSX** \r\n\r\nOpenJ9 JDK8 is built on OSX 10.10 Yosemite with Xcode4.6.3. The assembly\r\nsyntax is different in this setup.\r\n\r\nWhile building m4 files, `-DOSX_JAVA8` is enabled to recognize the setup\r\nfor JDK8 on OSX.\r\n\r\ngcc version on Xcode4 and Xcode9 is 4.2.1. So, compiler version can't be\r\nused to recognize the setup for JDK8 on OSX.\r\n\r\n**2) Replace .global with .globl for JDK8 on OSX**\r\n\r\nThe setup for JDK8 on OSX uses old assembly syntax where `.global` is not\r\nrecognized. `.global` is replaced with `.globl`.\r\n\r\n**3) Fix compiler error related to stackswap.s for JDK8 on OSX**\r\n\r\nThe following compiler error is seen when building OpenJ9 JDK8 on OSX:\r\n```\r\nstackswap.s:133:Alignment too large: 15. assumed.\r\nstackswap.s:153:suffix or operands invalid for `call'\r\n```\r\nAssembly code on stackswap.s:153 -\r\n```\r\n        call _vmSignalHandler\r\n```\r\nIn stackswap.s, `_vmSignalHandler` is declared as:\r\n```\r\n        .globl _vmSignalHandler\r\n```\r\nRemoving `.globl _vmSignalHandler` resolves the compiler error.\r\n\r\nJDK8 on OSX is built using Xcode4, which has an old assembler. In this\r\nassembler, all symbols are considered external by default, and\r\nstackswap.s doesn't contain the definition of `_vmSignalHandler`. So,\r\n`_vmSignalHandler` doesn't need to be declared as a global in stackswap.s.\r\n\r\nSigned-off-by: Babneet Singh <sbabneet@ca.ibm.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/openj9/issues/comments/429693906","html_url":"https://github.com/eclipse/openj9/pull/3259#issuecomment-429693906","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/3259","id":429693906,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTY5MzkwNg==","user":{"login":"DanHeidinga","id":8503711,"node_id":"MDQ6VXNlcjg1MDM3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8503711?v=4","gravatar_id":"","url":"https://api.github.com/users/DanHeidinga","html_url":"https://github.com/DanHeidinga","followers_url":"https://api.github.com/users/DanHeidinga/followers","following_url":"https://api.github.com/users/DanHeidinga/following{/other_user}","gists_url":"https://api.github.com/users/DanHeidinga/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHeidinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHeidinga/subscriptions","organizations_url":"https://api.github.com/users/DanHeidinga/orgs","repos_url":"https://api.github.com/users/DanHeidinga/repos","events_url":"https://api.github.com/users/DanHeidinga/events{/privacy}","received_events_url":"https://api.github.com/users/DanHeidinga/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T02:58:55Z","updated_at":"2018-10-15T02:58:55Z","author_association":"CONTRIBUTOR","body":"Jenkins test sanity xlinux,win jdk8"}}
{"actor":{"display_login":"DanHeidinga"}}