{"action":"closed","number":6568,"pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/6568","id":224943957,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTQzOTU3","html_url":"https://github.com/yarnpkg/yarn/pull/6568","diff_url":"https://github.com/yarnpkg/yarn/pull/6568.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/6568.patch","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/6568","number":6568,"state":"closed","locked":false,"title":"Support Darwin bash in bin/yarn","user":{"login":"hboomsma","id":1465009,"node_id":"MDQ6VXNlcjE0NjUwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1465009?v=4","gravatar_id":"","url":"https://api.github.com/users/hboomsma","html_url":"https://github.com/hboomsma","followers_url":"https://api.github.com/users/hboomsma/followers","following_url":"https://api.github.com/users/hboomsma/following{/other_user}","gists_url":"https://api.github.com/users/hboomsma/gists{/gist_id}","starred_url":"https://api.github.com/users/hboomsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hboomsma/subscriptions","organizations_url":"https://api.github.com/users/hboomsma/orgs","repos_url":"https://api.github.com/users/hboomsma/repos","events_url":"https://api.github.com/users/hboomsma/events{/privacy}","received_events_url":"https://api.github.com/users/hboomsma/received_events","type":"User","site_admin":false},"body":"If the yarn binary is a symlink the `basepath` is not correctly resolved on OSX/Darwin.\r\n\r\nFor example take the following structure:\r\n```\r\nvendor/yarnpkg/yarn/bin/yarn\r\nvendor/bin/yarn -> ../yarnpkg/yarn/bin/yarn\r\n```\r\n\r\nAnd run yarn:\r\n```\r\n$ yarn\r\ninternal/modules/cjs/loader.js:582\r\n    throw err;\r\n    ^\r\n\r\nError: Cannot find module '/Users/yarnpkg/yarn/bin/yarn.js'\r\n    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:580:15)\r\n    at Function.Module._load (internal/modules/cjs/loader.js:506:25)\r\n    at Function.Module.runMain (internal/modules/cjs/loader.js:741:12)\r\n    at startup (internal/bootstrap/node.js:285:19)\r\n    at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)\r\n```\r\nSince the symlink is not resolved the relative path in the symlink leads to the wrong path.\r\n\r\nThis PR, fixes that issue.\r\n\r\n<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->\r\n\r\n**Summary**\r\n\r\n<!-- Is the feature a substantial feature request? Please use https://github.com/yarnpkg/rfcs -->\r\n\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n\r\n<!-- Don't forget to update the CHANGELOG.md to quickly describe your changes to other users! -->\r\n\r\n**Test plan**\r\n\r\n<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->\r\n","created_at":"2018-10-23T08:33:07Z","updated_at":"2018-10-23T14:11:16Z","closed_at":"2018-10-23T14:11:16Z","merged_at":"2018-10-23T14:11:16Z","merge_commit_sha":"af72e6a1f721d94f89e1b8b11b8dad6795b81119","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/6568/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/6568/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/6568/comments","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/2ef397b79e92f69ea8e9387d0de12bcc57fb368e","head":{"label":"hboomsma:patch-1","ref":"patch-1","sha":"2ef397b79e92f69ea8e9387d0de12bcc57fb368e","user":{"login":"hboomsma","id":1465009,"node_id":"MDQ6VXNlcjE0NjUwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1465009?v=4","gravatar_id":"","url":"https://api.github.com/users/hboomsma","html_url":"https://github.com/hboomsma","followers_url":"https://api.github.com/users/hboomsma/followers","following_url":"https://api.github.com/users/hboomsma/following{/other_user}","gists_url":"https://api.github.com/users/hboomsma/gists{/gist_id}","starred_url":"https://api.github.com/users/hboomsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hboomsma/subscriptions","organizations_url":"https://api.github.com/users/hboomsma/orgs","repos_url":"https://api.github.com/users/hboomsma/repos","events_url":"https://api.github.com/users/hboomsma/events{/privacy}","received_events_url":"https://api.github.com/users/hboomsma/received_events","type":"User","site_admin":false},"repo":{"id":154290507,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyOTA1MDc=","name":"yarn","full_name":"hboomsma/yarn","private":false,"owner":{"login":"hboomsma","id":1465009,"node_id":"MDQ6VXNlcjE0NjUwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1465009?v=4","gravatar_id":"","url":"https://api.github.com/users/hboomsma","html_url":"https://github.com/hboomsma","followers_url":"https://api.github.com/users/hboomsma/followers","following_url":"https://api.github.com/users/hboomsma/following{/other_user}","gists_url":"https://api.github.com/users/hboomsma/gists{/gist_id}","starred_url":"https://api.github.com/users/hboomsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hboomsma/subscriptions","organizations_url":"https://api.github.com/users/hboomsma/orgs","repos_url":"https://api.github.com/users/hboomsma/repos","events_url":"https://api.github.com/users/hboomsma/events{/privacy}","received_events_url":"https://api.github.com/users/hboomsma/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hboomsma/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":true,"url":"https://api.github.com/repos/hboomsma/yarn","forks_url":"https://api.github.com/repos/hboomsma/yarn/forks","keys_url":"https://api.github.com/repos/hboomsma/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hboomsma/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hboomsma/yarn/teams","hooks_url":"https://api.github.com/repos/hboomsma/yarn/hooks","issue_events_url":"https://api.github.com/repos/hboomsma/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/hboomsma/yarn/events","assignees_url":"https://api.github.com/repos/hboomsma/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/hboomsma/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/hboomsma/yarn/tags","blobs_url":"https://api.github.com/repos/hboomsma/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hboomsma/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hboomsma/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/hboomsma/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hboomsma/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/hboomsma/yarn/languages","stargazers_url":"https://api.github.com/repos/hboomsma/yarn/stargazers","contributors_url":"https://api.github.com/repos/hboomsma/yarn/contributors","subscribers_url":"https://api.github.com/repos/hboomsma/yarn/subscribers","subscription_url":"https://api.github.com/repos/hboomsma/yarn/subscription","commits_url":"https://api.github.com/repos/hboomsma/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/hboomsma/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/hboomsma/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/hboomsma/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/hboomsma/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/hboomsma/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hboomsma/yarn/merges","archive_url":"https://api.github.com/repos/hboomsma/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hboomsma/yarn/downloads","issues_url":"https://api.github.com/repos/hboomsma/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/hboomsma/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/hboomsma/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/hboomsma/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hboomsma/yarn/labels{/name}","releases_url":"https://api.github.com/repos/hboomsma/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/hboomsma/yarn/deployments","created_at":"2018-10-23T08:23:11Z","updated_at":"2018-10-23T08:23:18Z","pushed_at":"2018-10-23T14:10:09Z","git_url":"git://github.com/hboomsma/yarn.git","ssh_url":"git@github.com:hboomsma/yarn.git","clone_url":"https://github.com/hboomsma/yarn.git","svn_url":"https://github.com/hboomsma/yarn","homepage":"https://yarnpkg.com","size":118668,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"f6d0a5b85aa465280a87bd8b04f74fee980bc77c","user":{"login":"yarnpkg","id":22247014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjQ3MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":49970642,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3MDY0Mg==","name":"yarn","full_name":"yarnpkg/yarn","private":false,"owner":{"login":"yarnpkg","id":22247014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjQ3MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yarnpkg/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":false,"url":"https://api.github.com/repos/yarnpkg/yarn","forks_url":"https://api.github.com/repos/yarnpkg/yarn/forks","keys_url":"https://api.github.com/repos/yarnpkg/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/yarn/teams","hooks_url":"https://api.github.com/repos/yarnpkg/yarn/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/yarn/events","assignees_url":"https://api.github.com/repos/yarnpkg/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/yarn/tags","blobs_url":"https://api.github.com/repos/yarnpkg/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/yarn/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/yarn/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/yarn/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/yarn/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/yarn/subscription","commits_url":"https://api.github.com/repos/yarnpkg/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/yarn/merges","archive_url":"https://api.github.com/repos/yarnpkg/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/yarn/downloads","issues_url":"https://api.github.com/repos/yarnpkg/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/yarn/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/yarn/deployments","created_at":"2016-01-19T17:39:16Z","updated_at":"2018-10-23T14:06:52Z","pushed_at":"2018-10-23T14:11:16Z","git_url":"git://github.com/yarnpkg/yarn.git","ssh_url":"git@github.com:yarnpkg/yarn.git","clone_url":"https://github.com/yarnpkg/yarn.git","svn_url":"https://github.com/yarnpkg/yarn","homepage":"https://yarnpkg.com","size":118668,"stargazers_count":33508,"watchers_count":33508,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1941,"mirror_url":null,"archived":false,"open_issues_count":1483,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1941,"open_issues":1483,"watchers":33508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/6568"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/6568"},"issue":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/6568"},"comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/6568/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/6568/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/6568/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/yarn/statuses/2ef397b79e92f69ea8e9387d0de12bcc57fb368e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"arcanis","id":1037931,"node_id":"MDQ6VXNlcjEwMzc5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1037931?v=4","gravatar_id":"","url":"https://api.github.com/users/arcanis","html_url":"https://github.com/arcanis","followers_url":"https://api.github.com/users/arcanis/followers","following_url":"https://api.github.com/users/arcanis/following{/other_user}","gists_url":"https://api.github.com/users/arcanis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanis/subscriptions","organizations_url":"https://api.github.com/users/arcanis/orgs","repos_url":"https://api.github.com/users/arcanis/repos","events_url":"https://api.github.com/users/arcanis/events{/privacy}","received_events_url":"https://api.github.com/users/arcanis/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":5,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"arcanis"}}