{"action":"created","issue":{"url":"https://api.github.com/repos/boostorg/beast/issues/999","repository_url":"https://api.github.com/repos/boostorg/beast","labels_url":"https://api.github.com/repos/boostorg/beast/issues/999/labels{/name}","comments_url":"https://api.github.com/repos/boostorg/beast/issues/999/comments","events_url":"https://api.github.com/repos/boostorg/beast/issues/999/events","html_url":"https://github.com/boostorg/beast/pull/999","id":292232824,"number":999,"title":"fixes issue 982","user":{"login":"chrisics","id":2297967,"avatar_url":"https://avatars3.githubusercontent.com/u/2297967?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisics","html_url":"https://github.com/chrisics","followers_url":"https://api.github.com/users/chrisics/followers","following_url":"https://api.github.com/users/chrisics/following{/other_user}","gists_url":"https://api.github.com/users/chrisics/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisics/subscriptions","organizations_url":"https://api.github.com/users/chrisics/orgs","repos_url":"https://api.github.com/users/chrisics/repos","events_url":"https://api.github.com/users/chrisics/events{/privacy}","received_events_url":"https://api.github.com/users/chrisics/received_events","type":"User","site_admin":false},"labels":[{"id":452918760,"url":"https://api.github.com/repos/boostorg/beast/labels/API%20Change","name":"API Change","color":"b60205","default":false},{"id":458528982,"url":"https://api.github.com/repos/boostorg/beast/labels/Bug","name":"Bug","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-01-28T19:53:28Z","updated_at":"2018-02-16T19:16:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/boostorg/beast/pulls/999","html_url":"https://github.com/boostorg/beast/pull/999","diff_url":"https://github.com/boostorg/beast/pull/999.diff","patch_url":"https://github.com/boostorg/beast/pull/999.patch"},"body":"Fixes issue https://github.com/boostorg/beast/issues/982\r\n\r\nSince we don't want to loose the \"write_new\" option to open files, \r\nand since this option is only available in std::fopen since c++17 \r\n(apart from the posix and win32 api's)\r\nI suggest to assert that we are dealing with c++17, in case we are using std::fopen.\r\n"},"comment":{"url":"https://api.github.com/repos/boostorg/beast/issues/comments/366332165","html_url":"https://github.com/boostorg/beast/pull/999#issuecomment-366332165","issue_url":"https://api.github.com/repos/boostorg/beast/issues/999","id":366332165,"user":{"login":"vinniefalco","id":1503976,"avatar_url":"https://avatars3.githubusercontent.com/u/1503976?v=4","gravatar_id":"","url":"https://api.github.com/users/vinniefalco","html_url":"https://github.com/vinniefalco","followers_url":"https://api.github.com/users/vinniefalco/followers","following_url":"https://api.github.com/users/vinniefalco/following{/other_user}","gists_url":"https://api.github.com/users/vinniefalco/gists{/gist_id}","starred_url":"https://api.github.com/users/vinniefalco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinniefalco/subscriptions","organizations_url":"https://api.github.com/users/vinniefalco/orgs","repos_url":"https://api.github.com/users/vinniefalco/repos","events_url":"https://api.github.com/users/vinniefalco/events{/privacy}","received_events_url":"https://api.github.com/users/vinniefalco/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T19:16:55Z","updated_at":"2018-02-16T19:16:55Z","author_association":"MEMBER","body":"Hmm this problem is a bit more nuanced than I originally thought. Only `file_stdio` doesn't support `write_new` on C++11, the other file implementations do support it (`file_win32` and `file_posix`). So the constant cannot be made conditionally available at compile time depending on language version.\r\n\r\nFurthermore, `__cplusplus` is not always a reliable method of checking for features. We should define a macro, say `BOOST_BEAST_HAS_C11_FILE_MODES` and if that is not set, then throw an exception on `write_new` and `append_new`. Then we can work out the logic for setting that macro separately. The macro should be documented.\r\n"}}
{"actor":{"display_login":"vinniefalco"}}