{"action":"opened","issue":{"url":"https://api.github.com/repos/philip-brohan/pyIMMA/issues/2","repository_url":"https://api.github.com/repos/philip-brohan/pyIMMA","labels_url":"https://api.github.com/repos/philip-brohan/pyIMMA/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/philip-brohan/pyIMMA/issues/2/comments","events_url":"https://api.github.com/repos/philip-brohan/pyIMMA/issues/2/events","html_url":"https://github.com/philip-brohan/pyIMMA/issues/2","id":367294045,"node_id":"MDU6SXNzdWUzNjcyOTQwNDU=","number":2,"title":"Performance enhancements","user":{"login":"bmschmidt","id":1110758,"node_id":"MDQ6VXNlcjExMTA3NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1110758?v=4","gravatar_id":"","url":"https://api.github.com/users/bmschmidt","html_url":"https://github.com/bmschmidt","followers_url":"https://api.github.com/users/bmschmidt/followers","following_url":"https://api.github.com/users/bmschmidt/following{/other_user}","gists_url":"https://api.github.com/users/bmschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/bmschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmschmidt/subscriptions","organizations_url":"https://api.github.com/users/bmschmidt/orgs","repos_url":"https://api.github.com/users/bmschmidt/repos","events_url":"https://api.github.com/users/bmschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/bmschmidt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-05T17:04:09Z","updated_at":"2018-10-05T17:04:09Z","closed_at":null,"author_association":"NONE","body":"Some performance enhancements for reading. I'm filing a pull request here: If the `oldweather` fork is also a going concern, the first one might be worth implementing there. The other two do less.\r\n\r\n* use str.isspace() instead of re.search(\"\\S\", string), and eliminate the `re` import. This is a big one--it knocks my test file (one of the late 19th century ICOADS months) down from 28 to 15 seconds. (I was doing a version of this before, which is why I was getting a 2x speedup and you were only seeing 33%).\r\n\r\n* Allow optionally passing a list of keys to the getter instance. This means that if (like me) you don't want to do anything with the temperature value, you don't have to waste time parsing and validating it. Usefulness varies depending on how much information you're extracting, but it can be significant.\r\n\r\n* Define the attachment and definitions dicts with *both* integer and character keys. I'm not sure how much of a difference this one makes--I don't think it could be more than 10%, though, and it might be basically zero."}}
{"actor":{"display_login":"bmschmidt"}}