{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cordova-coho/pulls/comments/170090965","pull_request_review_id":98725224,"id":170090965,"diff_hunk":"@@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have Apache-compatible licenses.\n     coho check-license -r android\n \n ## Prepare Release\n-Increase the version within package.json using SemVer, and remove the `-dev` suffix.\n+\n+### Remove the `-dev` suffix from version\n+\n+This command removes `-dev` from the `version` entry in `package.json`:\n \n     for l in cordova-android; do ( cd $l; v=\"$(grep '\"version\"' package.json | cut -d'\"' -f4)\"; if [[ $v = *-dev ]]; then v2=\"${v%-dev}\"; echo \"$l: Setting version to $v2\"; sed -i '' -E 's/version\":.*/version\": \"'$v2'\",/' package.json; fi) ; done\n \n-In `cordova-android`, also remember to bump the version in `framework/build.gradle`.\n+Note: This command [doesn't actually work](https://issues.apache.org/jira/browse/CB-13809). You can also replace `-dev` manually of course.\n \n-If the changes merit it, manually bump the major / minor/ patch version in `package.json`. View the changes via:\n+Note: In `cordova-android`, also remember to handle the version in `framework/build.gradle`.","path":"docs/platforms-release-process.md","position":161,"original_position":161,"commit_id":"46295dbc2de88a3817dec648c5cf4dc83b091920","original_commit_id":"46295dbc2de88a3817dec648c5cf4dc83b091920","user":{"login":"janpio","id":183673,"avatar_url":"https://avatars0.githubusercontent.com/u/183673?v=4","gravatar_id":"","url":"https://api.github.com/users/janpio","html_url":"https://github.com/janpio","followers_url":"https://api.github.com/users/janpio/followers","following_url":"https://api.github.com/users/janpio/following{/other_user}","gists_url":"https://api.github.com/users/janpio/gists{/gist_id}","starred_url":"https://api.github.com/users/janpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janpio/subscriptions","organizations_url":"https://api.github.com/users/janpio/orgs","repos_url":"https://api.github.com/users/janpio/repos","events_url":"https://api.github.com/users/janpio/events{/privacy}","received_events_url":"https://api.github.com/users/janpio/received_events","type":"User","site_admin":false},"body":"Is this good enough? I was somehow thinking there was a reason that \"remove -dev\" and the other version stuff later is split in 2 parts?","created_at":"2018-02-22T20:58:38Z","updated_at":"2018-02-22T20:58:38Z","html_url":"https://github.com/apache/cordova-coho/pull/170#discussion_r170090965","pull_request_url":"https://api.github.com/repos/apache/cordova-coho/pulls/170","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-coho/pulls/comments/170090965"},"html":{"href":"https://github.com/apache/cordova-coho/pull/170#discussion_r170090965"},"pull_request":{"href":"https://api.github.com/repos/apache/cordova-coho/pulls/170"}},"in_reply_to_id":170086993},"pull_request":{"url":"https://api.github.com/repos/apache/cordova-coho/pulls/170","id":165134036,"html_url":"https://github.com/apache/cordova-coho/pull/170","diff_url":"https://github.com/apache/cordova-coho/pull/170.diff","patch_url":"https://github.com/apache/cordova-coho/pull/170.patch","issue_url":"https://api.github.com/repos/apache/cordova-coho/issues/170","number":170,"state":"open","locked":false,"title":"CB-13828: Improve cordova-coho/docs","user":{"login":"janpio","id":183673,"avatar_url":"https://avatars0.githubusercontent.com/u/183673?v=4","gravatar_id":"","url":"https://api.github.com/users/janpio","html_url":"https://github.com/janpio","followers_url":"https://api.github.com/users/janpio/followers","following_url":"https://api.github.com/users/janpio/following{/other_user}","gists_url":"https://api.github.com/users/janpio/gists{/gist_id}","starred_url":"https://api.github.com/users/janpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janpio/subscriptions","organizations_url":"https://api.github.com/users/janpio/orgs","repos_url":"https://api.github.com/users/janpio/repos","events_url":"https://api.github.com/users/janpio/events{/privacy}","received_events_url":"https://api.github.com/users/janpio/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nImprove readability of index.md/README.md:\r\n\r\n- Better headlines and grouping\r\n- Add missing files that were not linked before\r\n- Short introduction\r\n\r\nReworked platforms-release-process.md:\r\n\r\n- Table of Contents\r\n- More headlines with more structure, added \"groups\"\r\n- Tested all the commands, added notes and important information\r\n\r\n\r\n### Checklist\r\n- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database\r\n- [x] Commit message follows the format: \"CB-3232: (android) Fix bug with resolving file paths\", where CB-xxxx is the JIRA ID & \"android\" is the platform affected.\r\n- [ ] Added automated test coverage as appropriate for this change.\r\n","created_at":"2018-01-25T14:34:41Z","updated_at":"2018-02-22T20:58:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bb14b76131dcaaec3e0633b906eb37a2466c473","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/cordova-coho/pulls/170/commits","review_comments_url":"https://api.github.com/repos/apache/cordova-coho/pulls/170/comments","review_comment_url":"https://api.github.com/repos/apache/cordova-coho/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cordova-coho/issues/170/comments","statuses_url":"https://api.github.com/repos/apache/cordova-coho/statuses/46295dbc2de88a3817dec648c5cf4dc83b091920","head":{"label":"apache:janpio-CB-13828","ref":"janpio-CB-13828","sha":"46295dbc2de88a3817dec648c5cf4dc83b091920","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":6898375,"name":"cordova-coho","full_name":"apache/cordova-coho","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cordova-coho","description":"Mirror of Apache Cordova coho","fork":false,"url":"https://api.github.com/repos/apache/cordova-coho","forks_url":"https://api.github.com/repos/apache/cordova-coho/forks","keys_url":"https://api.github.com/repos/apache/cordova-coho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cordova-coho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cordova-coho/teams","hooks_url":"https://api.github.com/repos/apache/cordova-coho/hooks","issue_events_url":"https://api.github.com/repos/apache/cordova-coho/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cordova-coho/events","assignees_url":"https://api.github.com/repos/apache/cordova-coho/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cordova-coho/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cordova-coho/tags","blobs_url":"https://api.github.com/repos/apache/cordova-coho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cordova-coho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cordova-coho/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cordova-coho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cordova-coho/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cordova-coho/languages","stargazers_url":"https://api.github.com/repos/apache/cordova-coho/stargazers","contributors_url":"https://api.github.com/repos/apache/cordova-coho/contributors","subscribers_url":"https://api.github.com/repos/apache/cordova-coho/subscribers","subscription_url":"https://api.github.com/repos/apache/cordova-coho/subscription","commits_url":"https://api.github.com/repos/apache/cordova-coho/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cordova-coho/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cordova-coho/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cordova-coho/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cordova-coho/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cordova-coho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cordova-coho/merges","archive_url":"https://api.github.com/repos/apache/cordova-coho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cordova-coho/downloads","issues_url":"https://api.github.com/repos/apache/cordova-coho/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cordova-coho/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cordova-coho/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cordova-coho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cordova-coho/labels{/name}","releases_url":"https://api.github.com/repos/apache/cordova-coho/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cordova-coho/deployments","created_at":"2012-11-28T08:00:17Z","updated_at":"2017-04-28T19:38:55Z","pushed_at":"2018-02-21T22:31:30Z","git_url":"git://github.com/apache/cordova-coho.git","ssh_url":"git@github.com:apache/cordova-coho.git","clone_url":"https://github.com/apache/cordova-coho.git","svn_url":"https://github.com/apache/cordova-coho","homepage":null,"size":2066,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":50,"open_issues":2,"watchers":22,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a7bc963c314f5c720374a22d102ad09692ead056","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":6898375,"name":"cordova-coho","full_name":"apache/cordova-coho","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cordova-coho","description":"Mirror of Apache Cordova coho","fork":false,"url":"https://api.github.com/repos/apache/cordova-coho","forks_url":"https://api.github.com/repos/apache/cordova-coho/forks","keys_url":"https://api.github.com/repos/apache/cordova-coho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cordova-coho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cordova-coho/teams","hooks_url":"https://api.github.com/repos/apache/cordova-coho/hooks","issue_events_url":"https://api.github.com/repos/apache/cordova-coho/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cordova-coho/events","assignees_url":"https://api.github.com/repos/apache/cordova-coho/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cordova-coho/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cordova-coho/tags","blobs_url":"https://api.github.com/repos/apache/cordova-coho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cordova-coho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cordova-coho/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cordova-coho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cordova-coho/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cordova-coho/languages","stargazers_url":"https://api.github.com/repos/apache/cordova-coho/stargazers","contributors_url":"https://api.github.com/repos/apache/cordova-coho/contributors","subscribers_url":"https://api.github.com/repos/apache/cordova-coho/subscribers","subscription_url":"https://api.github.com/repos/apache/cordova-coho/subscription","commits_url":"https://api.github.com/repos/apache/cordova-coho/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cordova-coho/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cordova-coho/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cordova-coho/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cordova-coho/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cordova-coho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cordova-coho/merges","archive_url":"https://api.github.com/repos/apache/cordova-coho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cordova-coho/downloads","issues_url":"https://api.github.com/repos/apache/cordova-coho/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cordova-coho/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cordova-coho/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cordova-coho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cordova-coho/labels{/name}","releases_url":"https://api.github.com/repos/apache/cordova-coho/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cordova-coho/deployments","created_at":"2012-11-28T08:00:17Z","updated_at":"2017-04-28T19:38:55Z","pushed_at":"2018-02-21T22:31:30Z","git_url":"git://github.com/apache/cordova-coho.git","ssh_url":"git@github.com:apache/cordova-coho.git","clone_url":"https://github.com/apache/cordova-coho.git","svn_url":"https://github.com/apache/cordova-coho","homepage":null,"size":2066,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":50,"open_issues":2,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-coho/pulls/170"},"html":{"href":"https://github.com/apache/cordova-coho/pull/170"},"issue":{"href":"https://api.github.com/repos/apache/cordova-coho/issues/170"},"comments":{"href":"https://api.github.com/repos/apache/cordova-coho/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cordova-coho/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cordova-coho/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cordova-coho/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cordova-coho/statuses/46295dbc2de88a3817dec648c5cf4dc83b091920"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"janpio"}}