{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/joist/issues/486","repository_url":"https://api.github.com/repos/phetsims/joist","labels_url":"https://api.github.com/repos/phetsims/joist/issues/486/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/joist/issues/486/comments","events_url":"https://api.github.com/repos/phetsims/joist/issues/486/events","html_url":"https://github.com/phetsims/joist/issues/486","id":317736227,"number":486,"title":"KeyboardHelpDialog: remove custom close button","user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars1.githubusercontent.com/u/3046552?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"labels":[{"id":299601968,"url":"https://api.github.com/repos/phetsims/joist/labels/dev:a11y","name":"dev:a11y","color":"008080","default":false},{"id":64201824,"url":"https://api.github.com/repos/phetsims/joist/labels/priority:2-high","name":"priority:2-high","color":"e11d21","default":false},{"id":322344998,"url":"https://api.github.com/repos/phetsims/joist/labels/status:ready-for-review","name":"status:ready-for-review","color":"3E766D","default":false}],"state":"open","locked":false,"assignee":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars1.githubusercontent.com/u/3046552?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"assignees":[{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars1.githubusercontent.com/u/3046552?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-04-25T18:07:29Z","updated_at":"2018-04-27T17:38:07Z","closed_at":null,"author_association":"NONE","body":"Related to https://github.com/phetsims/joist/issues/413#issuecomment-384010740, where the Dialog close button is now mandatory. \r\n\r\nKeyboardHelpDialog creates its own custom close button, exactly on top of the standard close button. \r\n\r\nThis button needs to be removed.  I’ll compare the a11y and phet-io instrumentation to Dialog.  If they are the same, I’ll remove it.  If they are different, someone else will have to untangle this."},"comment":{"url":"https://api.github.com/repos/phetsims/joist/issues/comments/385041997","html_url":"https://github.com/phetsims/joist/issues/486#issuecomment-385041997","issue_url":"https://api.github.com/repos/phetsims/joist/issues/486","id":385041997,"user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars1.githubusercontent.com/u/3046552?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T17:38:07Z","updated_at":"2018-04-27T17:38:07Z","author_association":"NONE","body":"The close button should (ideally) be private to Dialog. \r\n\r\nDialogs owns the close button, and all Dialogs have a close button. So Dialog should be responsible for anything and everything related to a11y (and phet-io) for the close button.   If there's something needed in KeyboardHelpDialog's, I suspect that it's something that should either (a) be moved to Dialog, or (b) be reexamined because it is inconsistent with other Dialogs.\r\n\r\n"}}
{"actor":{"display_login":"pixelzoom"}}