{"action":"created","issue":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/1610","repository_url":"https://api.github.com/repos/OrchardCMS/OrchardCore","labels_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/1610/labels{/name}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/1610/comments","events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/1610/events","html_url":"https://github.com/OrchardCMS/OrchardCore/issues/1610","id":305293403,"number":1610,"title":"Consider introducing ShellSettings.Id","user":{"login":"PinpointTownes","id":6998306,"avatar_url":"https://avatars1.githubusercontent.com/u/6998306?v=4","gravatar_id":"","url":"https://api.github.com/users/PinpointTownes","html_url":"https://github.com/PinpointTownes","followers_url":"https://api.github.com/users/PinpointTownes/followers","following_url":"https://api.github.com/users/PinpointTownes/following{/other_user}","gists_url":"https://api.github.com/users/PinpointTownes/gists{/gist_id}","starred_url":"https://api.github.com/users/PinpointTownes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PinpointTownes/subscriptions","organizations_url":"https://api.github.com/users/PinpointTownes/orgs","repos_url":"https://api.github.com/users/PinpointTownes/repos","events_url":"https://api.github.com/users/PinpointTownes/events{/privacy}","received_events_url":"https://api.github.com/users/PinpointTownes/received_events","type":"User","site_admin":false},"labels":[{"id":492591198,"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/labels/discussion","name":"discussion","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-14T19:13:33Z","updated_at":"2018-03-22T01:26:50Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"We're currently using `ShellSettings.Name` as a stable tenant identifier for the Data Protection services (it's also heavily used in my last PR to determine token audiences).\r\n\r\nUnfortunately, this is not an ideal candidate as the tenant name can be accidentally re-assigned to another tenant (after deleting the existing one). It has security implications if the tenant is managed by someone else, as data encrypted by the removed tenant could be decrypted by the new tenant (since they share the same name).\r\n\r\nTo fix that, I suggest introducing a new opaque `Id` property (typically... a GUID) we can safely use for isolation purposes.\r\n\r\n/cc @sebastienros "},"comment":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/comments/375148400","html_url":"https://github.com/OrchardCMS/OrchardCore/issues/1610#issuecomment-375148400","issue_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/1610","id":375148400,"user":{"login":"PinpointTownes","id":6998306,"avatar_url":"https://avatars1.githubusercontent.com/u/6998306?v=4","gravatar_id":"","url":"https://api.github.com/users/PinpointTownes","html_url":"https://github.com/PinpointTownes","followers_url":"https://api.github.com/users/PinpointTownes/followers","following_url":"https://api.github.com/users/PinpointTownes/following{/other_user}","gists_url":"https://api.github.com/users/PinpointTownes/gists{/gist_id}","starred_url":"https://api.github.com/users/PinpointTownes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PinpointTownes/subscriptions","organizations_url":"https://api.github.com/users/PinpointTownes/orgs","repos_url":"https://api.github.com/users/PinpointTownes/repos","events_url":"https://api.github.com/users/PinpointTownes/events{/privacy}","received_events_url":"https://api.github.com/users/PinpointTownes/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T01:26:50Z","updated_at":"2018-03-22T01:26:50Z","author_association":"CONTRIBUTOR","body":"I'll do that in a future PR, as this is a quite massive change that deserves a dedicated PR."}}
{"actor":{"display_login":"PinpointTownes"}}