{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/root/pulls/comments/200128077","pull_request_review_id":134382188,"id":200128077,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDEyODA3Nw==","diff_hunk":"@@ -43,22 +44,23 @@ using ReaderValueOrArray_t = typename TReaderValueOrArray<T>::Proxy_t;\n /// is passed instead.\n template <typename RDFValueTuple, std::size_t... S>\n void InitRDFValues(unsigned int slot, RDFValueTuple &valueTuple, TTreeReader *r, const ColumnNames_t &bn,\n-                   const ColumnNames_t &tmpbn,\n-                   const std::map<std::string, std::shared_ptr<RCustomColumnBase>> &customCols,\n-                   std::index_sequence<S...>)\n+                   const RBookedCustomColumns &customCols, std::index_sequence<S...>)\n {\n    // isTmpBranch has length bn.size(). Elements are true if the corresponding\n    // branch is a temporary branch created with Define, false if they are\n    // actual branches present in the TTree.\n+   // TODO: evaluate this once, pass it down","path":"tree/dataframe/inc/ROOT/RDFNodesUtils.hxx","position":20,"original_position":20,"commit_id":"7c27d30c99dcd3f9e0bbab770fb2056eb6ac2c51","original_commit_id":"d5c9dbc3ae6fe1169d2a07a061858022af31ca68","user":{"login":"imaxoi","id":23223138,"node_id":"MDQ6VXNlcjIzMjIzMTM4","avatar_url":"https://avatars1.githubusercontent.com/u/23223138?v=4","gravatar_id":"","url":"https://api.github.com/users/imaxoi","html_url":"https://github.com/imaxoi","followers_url":"https://api.github.com/users/imaxoi/followers","following_url":"https://api.github.com/users/imaxoi/following{/other_user}","gists_url":"https://api.github.com/users/imaxoi/gists{/gist_id}","starred_url":"https://api.github.com/users/imaxoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imaxoi/subscriptions","organizations_url":"https://api.github.com/users/imaxoi/orgs","repos_url":"https://api.github.com/users/imaxoi/repos","events_url":"https://api.github.com/users/imaxoi/events{/privacy}","received_events_url":"https://api.github.com/users/imaxoi/received_events","type":"User","site_admin":false},"body":"I am pretty sure this TODO is yours and was already there before the PR. I have no idea why I added it.","created_at":"2018-07-04T13:33:24Z","updated_at":"2018-07-04T13:33:24Z","html_url":"https://github.com/root-project/root/pull/2259#discussion_r200128077","pull_request_url":"https://api.github.com/repos/root-project/root/pulls/2259","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/comments/200128077"},"html":{"href":"https://github.com/root-project/root/pull/2259#discussion_r200128077"},"pull_request":{"href":"https://api.github.com/repos/root-project/root/pulls/2259"}},"in_reply_to_id":199246550},"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/2259","id":197694459,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3Njk0NDU5","html_url":"https://github.com/root-project/root/pull/2259","diff_url":"https://github.com/root-project/root/pull/2259.diff","patch_url":"https://github.com/root-project/root/pull/2259.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/2259","number":2259,"state":"open","locked":false,"title":"[DF] Custom column managed locally","user":{"login":"imaxoi","id":23223138,"node_id":"MDQ6VXNlcjIzMjIzMTM4","avatar_url":"https://avatars1.githubusercontent.com/u/23223138?v=4","gravatar_id":"","url":"https://api.github.com/users/imaxoi","html_url":"https://github.com/imaxoi","followers_url":"https://api.github.com/users/imaxoi/followers","following_url":"https://api.github.com/users/imaxoi/following{/other_user}","gists_url":"https://api.github.com/users/imaxoi/gists{/gist_id}","starred_url":"https://api.github.com/users/imaxoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imaxoi/subscriptions","organizations_url":"https://api.github.com/users/imaxoi/orgs","repos_url":"https://api.github.com/users/imaxoi/repos","events_url":"https://api.github.com/users/imaxoi/events{/privacy}","received_events_url":"https://api.github.com/users/imaxoi/received_events","type":"User","site_admin":false},"body":"Before this PR only the root node, the RLoopManager, kept the list of the custom columns defined by the user. This meant that it was not possible to define two columns with the same names in two different branches.\r\n\r\nAfter this PR, each node in the graph has a map with pointers to all the columns defined up to that node. Nodes in different branches may see different custom column. This allows operations like the following to work:\r\n```\r\n ROOT::RDataFrame d(3);\r\n   auto branch1 = d.Define(\"b2\", []() { return 1; });\r\n   auto branch2 = d.Define(\"b2\", []() { return 2; });\r\n```\r\n\r\nThis commit resolves the issue ROOT-9465.","created_at":"2018-06-27T11:01:35Z","updated_at":"2018-07-04T13:33:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2ff32b86e0f158481ba497bdce475da57fb2a72","assignee":{"login":"bluehood","id":10999034,"node_id":"MDQ6VXNlcjEwOTk5MDM0","avatar_url":"https://avatars3.githubusercontent.com/u/10999034?v=4","gravatar_id":"","url":"https://api.github.com/users/bluehood","html_url":"https://github.com/bluehood","followers_url":"https://api.github.com/users/bluehood/followers","following_url":"https://api.github.com/users/bluehood/following{/other_user}","gists_url":"https://api.github.com/users/bluehood/gists{/gist_id}","starred_url":"https://api.github.com/users/bluehood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluehood/subscriptions","organizations_url":"https://api.github.com/users/bluehood/orgs","repos_url":"https://api.github.com/users/bluehood/repos","events_url":"https://api.github.com/users/bluehood/events{/privacy}","received_events_url":"https://api.github.com/users/bluehood/received_events","type":"User","site_admin":false},"assignees":[{"login":"bluehood","id":10999034,"node_id":"MDQ6VXNlcjEwOTk5MDM0","avatar_url":"https://avatars3.githubusercontent.com/u/10999034?v=4","gravatar_id":"","url":"https://api.github.com/users/bluehood","html_url":"https://github.com/bluehood","followers_url":"https://api.github.com/users/bluehood/followers","following_url":"https://api.github.com/users/bluehood/following{/other_user}","gists_url":"https://api.github.com/users/bluehood/gists{/gist_id}","starred_url":"https://api.github.com/users/bluehood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluehood/subscriptions","organizations_url":"https://api.github.com/users/bluehood/orgs","repos_url":"https://api.github.com/users/bluehood/repos","events_url":"https://api.github.com/users/bluehood/events{/privacy}","received_events_url":"https://api.github.com/users/bluehood/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dpiparo","id":7850302,"node_id":"MDQ6VXNlcjc4NTAzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},{"login":"etejedor","id":8089558,"node_id":"MDQ6VXNlcjgwODk1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8089558?v=4","gravatar_id":"","url":"https://api.github.com/users/etejedor","html_url":"https://github.com/etejedor","followers_url":"https://api.github.com/users/etejedor/followers","following_url":"https://api.github.com/users/etejedor/following{/other_user}","gists_url":"https://api.github.com/users/etejedor/gists{/gist_id}","starred_url":"https://api.github.com/users/etejedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etejedor/subscriptions","organizations_url":"https://api.github.com/users/etejedor/orgs","repos_url":"https://api.github.com/users/etejedor/repos","events_url":"https://api.github.com/users/etejedor/events{/privacy}","received_events_url":"https://api.github.com/users/etejedor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":45304160,"node_id":"MDU6TGFiZWw0NTMwNDE2MA==","url":"https://api.github.com/repos/root-project/root/labels/new%20feature","name":"new feature","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/2259/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/2259/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/2259/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/7c27d30c99dcd3f9e0bbab770fb2056eb6ac2c51","head":{"label":"imaxoi:RDF_MultipleCustomColumns","ref":"RDF_MultipleCustomColumns","sha":"7c27d30c99dcd3f9e0bbab770fb2056eb6ac2c51","user":{"login":"imaxoi","id":23223138,"node_id":"MDQ6VXNlcjIzMjIzMTM4","avatar_url":"https://avatars1.githubusercontent.com/u/23223138?v=4","gravatar_id":"","url":"https://api.github.com/users/imaxoi","html_url":"https://github.com/imaxoi","followers_url":"https://api.github.com/users/imaxoi/followers","following_url":"https://api.github.com/users/imaxoi/following{/other_user}","gists_url":"https://api.github.com/users/imaxoi/gists{/gist_id}","starred_url":"https://api.github.com/users/imaxoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imaxoi/subscriptions","organizations_url":"https://api.github.com/users/imaxoi/orgs","repos_url":"https://api.github.com/users/imaxoi/repos","events_url":"https://api.github.com/users/imaxoi/events{/privacy}","received_events_url":"https://api.github.com/users/imaxoi/received_events","type":"User","site_admin":false},"repo":{"id":137210594,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMTA1OTQ=","name":"root","full_name":"imaxoi/root","owner":{"login":"imaxoi","id":23223138,"node_id":"MDQ6VXNlcjIzMjIzMTM4","avatar_url":"https://avatars1.githubusercontent.com/u/23223138?v=4","gravatar_id":"","url":"https://api.github.com/users/imaxoi","html_url":"https://github.com/imaxoi","followers_url":"https://api.github.com/users/imaxoi/followers","following_url":"https://api.github.com/users/imaxoi/following{/other_user}","gists_url":"https://api.github.com/users/imaxoi/gists{/gist_id}","starred_url":"https://api.github.com/users/imaxoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imaxoi/subscriptions","organizations_url":"https://api.github.com/users/imaxoi/orgs","repos_url":"https://api.github.com/users/imaxoi/repos","events_url":"https://api.github.com/users/imaxoi/events{/privacy}","received_events_url":"https://api.github.com/users/imaxoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imaxoi/root","description":"The official repository for ROOT: analyzing, storing and visualizing big data","fork":true,"url":"https://api.github.com/repos/imaxoi/root","forks_url":"https://api.github.com/repos/imaxoi/root/forks","keys_url":"https://api.github.com/repos/imaxoi/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imaxoi/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imaxoi/root/teams","hooks_url":"https://api.github.com/repos/imaxoi/root/hooks","issue_events_url":"https://api.github.com/repos/imaxoi/root/issues/events{/number}","events_url":"https://api.github.com/repos/imaxoi/root/events","assignees_url":"https://api.github.com/repos/imaxoi/root/assignees{/user}","branches_url":"https://api.github.com/repos/imaxoi/root/branches{/branch}","tags_url":"https://api.github.com/repos/imaxoi/root/tags","blobs_url":"https://api.github.com/repos/imaxoi/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imaxoi/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imaxoi/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/imaxoi/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imaxoi/root/statuses/{sha}","languages_url":"https://api.github.com/repos/imaxoi/root/languages","stargazers_url":"https://api.github.com/repos/imaxoi/root/stargazers","contributors_url":"https://api.github.com/repos/imaxoi/root/contributors","subscribers_url":"https://api.github.com/repos/imaxoi/root/subscribers","subscription_url":"https://api.github.com/repos/imaxoi/root/subscription","commits_url":"https://api.github.com/repos/imaxoi/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/imaxoi/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/imaxoi/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/imaxoi/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/imaxoi/root/contents/{+path}","compare_url":"https://api.github.com/repos/imaxoi/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imaxoi/root/merges","archive_url":"https://api.github.com/repos/imaxoi/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imaxoi/root/downloads","issues_url":"https://api.github.com/repos/imaxoi/root/issues{/number}","pulls_url":"https://api.github.com/repos/imaxoi/root/pulls{/number}","milestones_url":"https://api.github.com/repos/imaxoi/root/milestones{/number}","notifications_url":"https://api.github.com/repos/imaxoi/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imaxoi/root/labels{/name}","releases_url":"https://api.github.com/repos/imaxoi/root/releases{/id}","deployments_url":"https://api.github.com/repos/imaxoi/root/deployments","created_at":"2018-06-13T12:10:09Z","updated_at":"2018-06-13T12:11:10Z","pushed_at":"2018-07-04T13:16:33Z","git_url":"git://github.com/imaxoi/root.git","ssh_url":"git@github.com:imaxoi/root.git","clone_url":"https://github.com/imaxoi/root.git","svn_url":"https://github.com/imaxoi/root","homepage":"https://root.cern","size":700183,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"47dd373aa455bbe213e3a422dc2aead7d484543d","user":{"login":"root-project","id":6450093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NTAwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5NDM0NQ==","name":"root","full_name":"root-project/root","owner":{"login":"root-project","id":6450093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NTAwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/root","description":"The official repository for ROOT: analyzing, storing and visualizing big data","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2018-07-04T11:04:37Z","pushed_at":"2018-07-04T13:16:36Z","git_url":"git://github.com/root-project/root.git","ssh_url":"git@github.com:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"https://root.cern","size":700079,"stargazers_count":598,"watchers_count":598,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":433,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":433,"open_issues":66,"watchers":598,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/2259"},"html":{"href":"https://github.com/root-project/root/pull/2259"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/2259"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/2259/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/2259/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/2259/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/7c27d30c99dcd3f9e0bbab770fb2056eb6ac2c51"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"imaxoi"}}