{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30926","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30926/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30926/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30926/events","html_url":"https://github.com/cockroachdb/cockroach/pull/30926","id":366435074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTA5NjAw","number":30926,"title":"ui: use new React ref API","user":{"login":"janowsiany","id":17599228,"node_id":"MDQ6VXNlcjE3NTk5MjI4","avatar_url":"https://avatars3.githubusercontent.com/u/17599228?v=4","gravatar_id":"","url":"https://api.github.com/users/janowsiany","html_url":"https://github.com/janowsiany","followers_url":"https://api.github.com/users/janowsiany/followers","following_url":"https://api.github.com/users/janowsiany/following{/other_user}","gists_url":"https://api.github.com/users/janowsiany/gists{/gist_id}","starred_url":"https://api.github.com/users/janowsiany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janowsiany/subscriptions","organizations_url":"https://api.github.com/users/janowsiany/orgs","repos_url":"https://api.github.com/users/janowsiany/repos","events_url":"https://api.github.com/users/janowsiany/events{/privacy}","received_events_url":"https://api.github.com/users/janowsiany/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-03T16:57:32Z","updated_at":"2018-10-03T17:55:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/30926","html_url":"https://github.com/cockroachdb/cockroach/pull/30926","diff_url":"https://github.com/cockroachdb/cockroach/pull/30926.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/30926.patch"},"body":"Solves #28845\r\nCurrently can not run test due to #30619, any workarounds?\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/426734199","html_url":"https://github.com/cockroachdb/cockroach/pull/30926#issuecomment-426734199","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30926","id":426734199,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjczNDE5OQ==","user":{"login":"vilterp","id":7341,"node_id":"MDQ6VXNlcjczNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7341?v=4","gravatar_id":"","url":"https://api.github.com/users/vilterp","html_url":"https://github.com/vilterp","followers_url":"https://api.github.com/users/vilterp/followers","following_url":"https://api.github.com/users/vilterp/following{/other_user}","gists_url":"https://api.github.com/users/vilterp/gists{/gist_id}","starred_url":"https://api.github.com/users/vilterp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilterp/subscriptions","organizations_url":"https://api.github.com/users/vilterp/orgs","repos_url":"https://api.github.com/users/vilterp/repos","events_url":"https://api.github.com/users/vilterp/events{/privacy}","received_events_url":"https://api.github.com/users/vilterp/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T17:55:10Z","updated_at":"2018-10-03T17:55:10Z","author_association":"CONTRIBUTOR","body":"Actually, I just noticed that there are some type errors which caused the CI to fail for this PR. I don't think the CI server is visible to non-CR employees, so pasted below:\r\n\r\n```\r\nccl/src/views/clusterviz/containers/map/mapLayout.tsx(204,10): error TS2322: Type '{ ref: RefObject<Node>; children: (Element | Element[])[]; }' is not assignable to type 'SVGProps<SVGGElement>'.\r\n[17:12:30]  Types of property 'ref' are incompatible.\r\n[17:12:30]    Type 'RefObject<Node>' is not assignable to type 'Ref<SVGGElement>'.\r\n[17:12:30]      Type 'RefObject<Node>' is not assignable to type 'RefObject<SVGGElement>'.\r\n[17:12:30]        Type 'Node' is not assignable to type 'SVGGElement'.\r\n[17:12:30]          Property 'farthestViewportElement' is missing in type 'Node'.\r\n[17:12:30]ccl/src/views/clusterviz/containers/map/nodeCanvas.tsx(150,13): error TS2322: Type '{ style: { width: string; height: string; marginBottom: number; position: \"absolute\"; }; classNam...' is not assignable to type 'SVGProps<SVGSVGElement>'.\r\n[17:12:30]  Types of property 'ref' are incompatible.\r\n[17:12:30]    Type 'RefObject<SVGElement>' is not assignable to type 'Ref<SVGSVGElement>'.\r\n[17:12:30]      Type 'RefObject<SVGElement>' is not assignable to type 'RefObject<SVGSVGElement>'.\r\n[17:12:30]        Type 'SVGElement' is not assignable to type 'SVGSVGElement'.\r\n[17:12:30]          Property 'contentScriptType' is missing in type 'SVGElement'.\r\n[17:12:30]src/views/cluster/components/linegraph/index.tsx(197,16): error TS2322: Type '{ className: string; color?: string; height?: string | number; id?: string; lang?: string; max?: ...' is not assignable to type 'SVGProps<SVGSVGElement>'.\r\n[17:12:30]  Types of property 'ref' are incompatible.\r\n[17:12:30]    Type 'string | RefObject<SVGElement> | ((instance: SVGSVGElement) => any) | RefObject<SVGSVGElement>' is not assignable to type 'Ref<SVGSVGElement>'.\r\n[17:12:30]      Type 'RefObject<SVGElement>' is not assignable to type 'Ref<SVGSVGElement>'.\r\n[17:12:30]        Type 'RefObject<SVGElement>' is not assignable to type 'RefObject<SVGSVGElement>'.\r\n[17:12:30]src/views/shared/components/sql/box.tsx(27,12): error TS2322: Type '{ className: \"sql-highlight\"; ref: RefObject<Node>; children: string; }' is not assignable to type 'DetailedHTMLProps<HTMLAttributes<HTMLPreElement>, HTMLPreElement>'.\r\n[17:12:30]  Type '{ className: \"sql-highlight\"; ref: RefObject<Node>; children: string; }' is not assignable to type 'ClassAttributes<HTMLPreElement>'.\r\n[17:12:30]    Types of property 'ref' are incompatible.\r\n[17:12:30]      Type 'RefObject<Node>' is not assignable to type 'Ref<HTMLPreElement>'.\r\n[17:12:30]        Type 'RefObject<Node>' is not assignable to type 'RefObject<HTMLPreElement>'.\r\n[17:12:30]          Type 'Node' is not assignable to type 'HTMLPreElement'.\r\n[17:12:30]            Property 'width' is missing in type 'Node'.\r\n```\r\n\r\nI'm not sure what the root issues are here; think you could investigate? You can run the typechecker locally with `make ui-lint` to verify that they are fixed."}}
{"actor":{"display_login":"vilterp"}}