{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/177555231","pull_request_review_id":107447475,"id":177555231,"diff_hunk":"@@ -0,0 +1,222 @@\n+// Type definitions for jwt-express 1.1\n+// Project: https://github.com/AustP/jwt-express#readme\n+// Definitions by: Nick Paddock <https://github.com/nickp10>\n+// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n+// TypeScript Version: 2.2\n+\n+/// <reference types=\"node\" />\n+\n+import express = require(\"express\");\n+import jsonwebtoken = require(\"jsonwebtoken\");\n+\n+declare global {","path":"types/jwt-express/index.d.ts","position":12,"original_position":12,"commit_id":"06163d88898bbed112af9d288806a1486230ba42","original_commit_id":"06163d88898bbed112af9d288806a1486230ba42","user":{"login":"nickp10","id":13040092,"avatar_url":"https://avatars2.githubusercontent.com/u/13040092?v=4","gravatar_id":"","url":"https://api.github.com/users/nickp10","html_url":"https://github.com/nickp10","followers_url":"https://api.github.com/users/nickp10/followers","following_url":"https://api.github.com/users/nickp10/following{/other_user}","gists_url":"https://api.github.com/users/nickp10/gists{/gist_id}","starred_url":"https://api.github.com/users/nickp10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickp10/subscriptions","organizations_url":"https://api.github.com/users/nickp10/orgs","repos_url":"https://api.github.com/users/nickp10/repos","events_url":"https://api.github.com/users/nickp10/events{/privacy}","received_events_url":"https://api.github.com/users/nickp10/received_events","type":"User","site_admin":false},"body":"Yes, this is case #2. I was using the types for express-session as an example. I can make the changes you requested, but this does work as-is. You're right I forgot to include a test for this scenario and I will add that as well.","created_at":"2018-03-27T20:06:27Z","updated_at":"2018-03-27T20:06:27Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24563#discussion_r177555231","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24563","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/177555231"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24563#discussion_r177555231"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24563"}},"in_reply_to_id":177554465},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24563","id":177810888,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24563","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24563.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24563.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24563","number":24563,"state":"open","locked":false,"title":"Add types for the jwt-express package","user":{"login":"nickp10","id":13040092,"avatar_url":"https://avatars2.githubusercontent.com/u/13040092?v=4","gravatar_id":"","url":"https://api.github.com/users/nickp10","html_url":"https://github.com/nickp10","followers_url":"https://api.github.com/users/nickp10/followers","following_url":"https://api.github.com/users/nickp10/following{/other_user}","gists_url":"https://api.github.com/users/nickp10/gists{/gist_id}","starred_url":"https://api.github.com/users/nickp10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickp10/subscriptions","organizations_url":"https://api.github.com/users/nickp10/orgs","repos_url":"https://api.github.com/users/nickp10/repos","events_url":"https://api.github.com/users/nickp10/events{/privacy}","received_events_url":"https://api.github.com/users/nickp10/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [x] The package does not provide its own types, and you can not add them.\r\n- [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [x] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [x] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, `strictNullChecks`, and `strictFunctionTypes` set to `true`.","created_at":"2018-03-27T17:26:59Z","updated_at":"2018-03-27T20:06:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62173ac9ba2030a70eb896a28ad894e6d5a1daa8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":397523192,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":646788888,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/New%20Definition","name":"New Definition","color":"4eca56","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24563/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24563/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24563/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/06163d88898bbed112af9d288806a1486230ba42","head":{"label":"nickp10:master","ref":"master","sha":"06163d88898bbed112af9d288806a1486230ba42","user":{"login":"nickp10","id":13040092,"avatar_url":"https://avatars2.githubusercontent.com/u/13040092?v=4","gravatar_id":"","url":"https://api.github.com/users/nickp10","html_url":"https://github.com/nickp10","followers_url":"https://api.github.com/users/nickp10/followers","following_url":"https://api.github.com/users/nickp10/following{/other_user}","gists_url":"https://api.github.com/users/nickp10/gists{/gist_id}","starred_url":"https://api.github.com/users/nickp10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickp10/subscriptions","organizations_url":"https://api.github.com/users/nickp10/orgs","repos_url":"https://api.github.com/users/nickp10/repos","events_url":"https://api.github.com/users/nickp10/events{/privacy}","received_events_url":"https://api.github.com/users/nickp10/received_events","type":"User","site_admin":false},"repo":{"id":127013345,"name":"DefinitelyTyped","full_name":"nickp10/DefinitelyTyped","owner":{"login":"nickp10","id":13040092,"avatar_url":"https://avatars2.githubusercontent.com/u/13040092?v=4","gravatar_id":"","url":"https://api.github.com/users/nickp10","html_url":"https://github.com/nickp10","followers_url":"https://api.github.com/users/nickp10/followers","following_url":"https://api.github.com/users/nickp10/following{/other_user}","gists_url":"https://api.github.com/users/nickp10/gists{/gist_id}","starred_url":"https://api.github.com/users/nickp10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickp10/subscriptions","organizations_url":"https://api.github.com/users/nickp10/orgs","repos_url":"https://api.github.com/users/nickp10/repos","events_url":"https://api.github.com/users/nickp10/events{/privacy}","received_events_url":"https://api.github.com/users/nickp10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickp10/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/nickp10/DefinitelyTyped","forks_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/nickp10/DefinitelyTyped/deployments","created_at":"2018-03-27T16:09:28Z","updated_at":"2018-03-27T17:35:06Z","pushed_at":"2018-03-27T17:34:59Z","git_url":"git://github.com/nickp10/DefinitelyTyped.git","ssh_url":"git@github.com:nickp10/DefinitelyTyped.git","clone_url":"https://github.com/nickp10/DefinitelyTyped.git","svn_url":"https://github.com/nickp10/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":308189,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"38bda769b62d2583bf14ad37db854460b833bbfa","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-03-27T19:39:38Z","pushed_at":"2018-03-27T19:48:26Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":308278,"stargazers_count":14829,"watchers_count":14829,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12351,"mirror_url":null,"archived":false,"open_issues_count":2093,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12351,"open_issues":2093,"watchers":14829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24563"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24563"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24563"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24563/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24563/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24563/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/06163d88898bbed112af9d288806a1486230ba42"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nickp10"}}