{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/195894599","pull_request_review_id":129354619,"id":195894599,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTg5NDU5OQ==","diff_hunk":"@@ -488,9 +488,16 @@ private[spark] class ExecutorAllocationManager(\n     newExecutorTotal = numExistingExecutors\n     if (testing || executorsRemoved.nonEmpty) {\n       executorsRemoved.foreach { removedExecutorId =>\n+        // If it is cachedBlcok timeout is configured using\n+        // spark.dynamicAllocation.cachedExecutorIdleTimeout\n+        val idleTimeout = if (SparkEnv.get.blockManager.master.hasCachedBlocks(removedExecutorId)) {","path":"core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala","position":6,"original_position":6,"commit_id":"30fcef650ee2bd2873bf402448652acba055f989","original_commit_id":"30fcef650ee2bd2873bf402448652acba055f989","user":{"login":"maropu","id":692303,"node_id":"MDQ6VXNlcjY5MjMwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/692303?v=4","gravatar_id":"","url":"https://api.github.com/users/maropu","html_url":"https://github.com/maropu","followers_url":"https://api.github.com/users/maropu/followers","following_url":"https://api.github.com/users/maropu/following{/other_user}","gists_url":"https://api.github.com/users/maropu/gists{/gist_id}","starred_url":"https://api.github.com/users/maropu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maropu/subscriptions","organizations_url":"https://api.github.com/users/maropu/orgs","repos_url":"https://api.github.com/users/maropu/repos","events_url":"https://api.github.com/users/maropu/events{/privacy}","received_events_url":"https://api.github.com/users/maropu/received_events","type":"User","site_admin":false},"body":"`blockManagerMaster.hasCachedBlocks(removedExecutorId)`?","created_at":"2018-06-16T05:18:48Z","updated_at":"2018-06-16T05:18:48Z","html_url":"https://github.com/apache/spark/pull/21565#discussion_r195894599","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/21565","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/195894599"},"html":{"href":"https://github.com/apache/spark/pull/21565#discussion_r195894599"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/21565"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/21565","id":194849191,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODQ5MTkx","html_url":"https://github.com/apache/spark/pull/21565","diff_url":"https://github.com/apache/spark/pull/21565.diff","patch_url":"https://github.com/apache/spark/pull/21565.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/21565","number":21565,"state":"open","locked":false,"title":"[SPARK-24558][Core]wrong Idle Timeout value is used in case of the cacheBlock.","user":{"login":"sandeep-katta","id":35216143,"node_id":"MDQ6VXNlcjM1MjE2MTQz","avatar_url":"https://avatars1.githubusercontent.com/u/35216143?v=4","gravatar_id":"","url":"https://api.github.com/users/sandeep-katta","html_url":"https://github.com/sandeep-katta","followers_url":"https://api.github.com/users/sandeep-katta/followers","following_url":"https://api.github.com/users/sandeep-katta/following{/other_user}","gists_url":"https://api.github.com/users/sandeep-katta/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeep-katta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeep-katta/subscriptions","organizations_url":"https://api.github.com/users/sandeep-katta/orgs","repos_url":"https://api.github.com/users/sandeep-katta/repos","events_url":"https://api.github.com/users/sandeep-katta/events{/privacy}","received_events_url":"https://api.github.com/users/sandeep-katta/received_events","type":"User","site_admin":false},"body":"It is corrected as per the configuration.\r\n\r\n## What changes were proposed in this pull request?\r\nIdleTimeout info used to print in the logs is taken based on the cacheBlock. If it is cacheBlock then cachedExecutorIdleTimeoutS is considered else executorIdleTimeoutS \r\n\r\n## How was this patch tested?\r\nManual Test\r\nspark-sql> cache table sample;\r\n2018-05-15 14:44:02 INFO  DAGScheduler:54 - Submitting 3 missing tasks from ShuffleMapStage 0 (MapPartitionsRDD[8] at processCmd at CliDriver.java:376) (first 15 tasks are for partitions Vector(0, 1, 2))\r\n2018-05-15 14:44:02 INFO  YarnScheduler:54 - Adding task set 0.0 with 3 tasks\r\n2018-05-15 14:44:03 INFO  ExecutorAllocationManager:54 - Requesting 1 new executor because tasks are backlogged (new desired total will be 1)\r\n...\r\n...\r\n2018-05-15 14:46:10 INFO  YarnClientSchedulerBackend:54 - Actual list of executor(s) to be killed is 1\r\n2018-05-15 14:46:10 INFO  **ExecutorAllocationManager:54 - Removing executor 1 because it has been idle for 120 seconds (new desired total will be 0)**\r\n2018-05-15 14:46:11 INFO  YarnSchedulerBackend$YarnDriverEndpoint:54 - Disabling executor 1.\r\n2018-05-15 14:46:11 INFO  DAGScheduler:54 - Executor lost: 1 (epoch 1)\r\n","created_at":"2018-06-14T10:35:47Z","updated_at":"2018-06-16T05:18:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2a2593f7337b40773ef6262747d6460b16e8ada","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/21565/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/21565/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/21565/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/30fcef650ee2bd2873bf402448652acba055f989","head":{"label":"sandeep-katta:loginfoBug","ref":"loginfoBug","sha":"30fcef650ee2bd2873bf402448652acba055f989","user":{"login":"sandeep-katta","id":35216143,"node_id":"MDQ6VXNlcjM1MjE2MTQz","avatar_url":"https://avatars1.githubusercontent.com/u/35216143?v=4","gravatar_id":"","url":"https://api.github.com/users/sandeep-katta","html_url":"https://github.com/sandeep-katta","followers_url":"https://api.github.com/users/sandeep-katta/followers","following_url":"https://api.github.com/users/sandeep-katta/following{/other_user}","gists_url":"https://api.github.com/users/sandeep-katta/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeep-katta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeep-katta/subscriptions","organizations_url":"https://api.github.com/users/sandeep-katta/orgs","repos_url":"https://api.github.com/users/sandeep-katta/repos","events_url":"https://api.github.com/users/sandeep-katta/events{/privacy}","received_events_url":"https://api.github.com/users/sandeep-katta/received_events","type":"User","site_admin":false},"repo":{"id":116654613,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY2NTQ2MTM=","name":"spark","full_name":"sandeep-katta/spark","owner":{"login":"sandeep-katta","id":35216143,"node_id":"MDQ6VXNlcjM1MjE2MTQz","avatar_url":"https://avatars1.githubusercontent.com/u/35216143?v=4","gravatar_id":"","url":"https://api.github.com/users/sandeep-katta","html_url":"https://github.com/sandeep-katta","followers_url":"https://api.github.com/users/sandeep-katta/followers","following_url":"https://api.github.com/users/sandeep-katta/following{/other_user}","gists_url":"https://api.github.com/users/sandeep-katta/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeep-katta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeep-katta/subscriptions","organizations_url":"https://api.github.com/users/sandeep-katta/orgs","repos_url":"https://api.github.com/users/sandeep-katta/repos","events_url":"https://api.github.com/users/sandeep-katta/events{/privacy}","received_events_url":"https://api.github.com/users/sandeep-katta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sandeep-katta/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/sandeep-katta/spark","forks_url":"https://api.github.com/repos/sandeep-katta/spark/forks","keys_url":"https://api.github.com/repos/sandeep-katta/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandeep-katta/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandeep-katta/spark/teams","hooks_url":"https://api.github.com/repos/sandeep-katta/spark/hooks","issue_events_url":"https://api.github.com/repos/sandeep-katta/spark/issues/events{/number}","events_url":"https://api.github.com/repos/sandeep-katta/spark/events","assignees_url":"https://api.github.com/repos/sandeep-katta/spark/assignees{/user}","branches_url":"https://api.github.com/repos/sandeep-katta/spark/branches{/branch}","tags_url":"https://api.github.com/repos/sandeep-katta/spark/tags","blobs_url":"https://api.github.com/repos/sandeep-katta/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandeep-katta/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandeep-katta/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandeep-katta/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandeep-katta/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sandeep-katta/spark/languages","stargazers_url":"https://api.github.com/repos/sandeep-katta/spark/stargazers","contributors_url":"https://api.github.com/repos/sandeep-katta/spark/contributors","subscribers_url":"https://api.github.com/repos/sandeep-katta/spark/subscribers","subscription_url":"https://api.github.com/repos/sandeep-katta/spark/subscription","commits_url":"https://api.github.com/repos/sandeep-katta/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandeep-katta/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandeep-katta/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandeep-katta/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandeep-katta/spark/contents/{+path}","compare_url":"https://api.github.com/repos/sandeep-katta/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandeep-katta/spark/merges","archive_url":"https://api.github.com/repos/sandeep-katta/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandeep-katta/spark/downloads","issues_url":"https://api.github.com/repos/sandeep-katta/spark/issues{/number}","pulls_url":"https://api.github.com/repos/sandeep-katta/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sandeep-katta/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sandeep-katta/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandeep-katta/spark/labels{/name}","releases_url":"https://api.github.com/repos/sandeep-katta/spark/releases{/id}","deployments_url":"https://api.github.com/repos/sandeep-katta/spark/deployments","created_at":"2018-01-08T09:11:40Z","updated_at":"2018-01-08T09:12:07Z","pushed_at":"2018-06-14T10:22:57Z","git_url":"git://github.com/sandeep-katta/spark.git","ssh_url":"git@github.com:sandeep-katta/spark.git","clone_url":"https://github.com/sandeep-katta/spark.git","svn_url":"https://github.com/sandeep-katta/spark","homepage":null,"size":270232,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"534065efeb51ff0d308fa6cc9dea0715f8ce25ad","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-06-16T04:57:12Z","pushed_at":"2018-06-16T04:48:48Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":271953,"stargazers_count":17719,"watchers_count":17719,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16144,"mirror_url":null,"archived":false,"open_issues_count":562,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16144,"open_issues":562,"watchers":17719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/21565"},"html":{"href":"https://github.com/apache/spark/pull/21565"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/21565"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/21565/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/21565/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/21565/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/30fcef650ee2bd2873bf402448652acba055f989"}},"author_association":"NONE"}}
{"actor":{"display_login":"maropu"}}