{"action":"created","comment":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments/236139110","pull_request_review_id":178151447,"id":236139110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjEzOTExMA==","diff_hunk":"@@ -131,3 +148,68 @@ function createInfoWindow(text) {\n         content: text\n     });\n }\n+\n+\n+/**\n+ * The SearchNearMeCheckbox adds a checkbox to the given DIV (which should be in a map)","path":"app/assets/javascripts/google-maps.js","position":119,"original_position":119,"commit_id":"eac2bccf9652adcecab8cdeb7bdcd07814d32841","original_commit_id":"eac2bccf9652adcecab8cdeb7bdcd07814d32841","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line is too long.","created_at":"2018-11-26T06:58:31Z","updated_at":"2018-11-26T06:58:31Z","html_url":"https://github.com/AgileVentures/shf-project/pull/568#discussion_r236139110","pull_request_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/568","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments/236139110"},"html":{"href":"https://github.com/AgileVentures/shf-project/pull/568#discussion_r236139110"},"pull_request":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/568"}}},"pull_request":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/568","id":233433662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDMzNjYy","html_url":"https://github.com/AgileVentures/shf-project/pull/568","diff_url":"https://github.com/AgileVentures/shf-project/pull/568.diff","patch_url":"https://github.com/AgileVentures/shf-project/pull/568.patch","issue_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/568","number":568,"state":"open","locked":false,"title":"WIP: Search Near... frontend work","user":{"login":"weedySeaDragon","id":673794,"node_id":"MDQ6VXNlcjY3Mzc5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/673794?v=4","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"body":"### PT Story:  Find Companies Near Me\r\nhttps://www.pivotaltracker.com/story/show/140181097\r\n\r\n### WIP Notes\r\n- THIS STILL ONLY SEARCHES NEAR STOCKHOLM (not the actual user's location)\r\n  - I will have to add some view controls so that during test or development we can artificially set the user location and whether or not the user location is available\r\n\r\n- **Order matters**: If you _first_ choose a search filter (ex: kategori/category), _then_ check 'Search Near Me', the results are correct and what you'd expect.\r\n   But if you first check 'Search Near Me' and then enter search filters, the 'Search Near Me' checkbox becomes unchecked.  \r\n  - This behavior is difficult to change because of how rigid the Ransack gem is and because it changes the ActiveRecord queries.\r\n  - **_How can we let the users know this is how it works?_**\r\n\r\n- had to change the parameters passed to the controller\r\n  - I need to review the controller specs to see if additional tests are needed or existing tests need to be changed.  If anyone sees specs needed or modifications needed, please do comment.\r\n\r\n- Integration testing:  Not sure how to accomplish some of this:\r\n   When Google renders a map, it does _not_ render the element id for the controls that are added (e.g. the \"search near me\" checkbox).  So I'm not sure if or how to check for that.\r\n   We can certainly check the results, but I'm not sure if we'll be able to check the initial state (e.g. that the \"search near me\" checkbox has been checked or not).\r\n\r\n- I am in the middle of seeing if the \"optimized\" parameter to markers will help.  That is why there is an `optimize` argument in the javascript functions.  It may or may not be \r\n\r\n- I didn't spend much time styling the checkbox.  Suggestions needed!\r\n\r\n- I couldn't stand watching the long and slow queries that are generated by the current `` scope.  So I created the faster, more efficient scope (and resulting query).  But since I have not tested it, I will revert to the original, tested scope and submit a PivotalTracker task for it.  (I just haven't cleaned up the code yet.)\r\n\r\n\r\n### Changes proposed in this pull request:\r\n1. Changed the parameters passed to the controller \r\n2. Changed the layout for the search filters and map to vertical\r\n3. Removed the 'show/hide search box' button. Changed the features to search for results only in the companies list\r\n\r\n### Screenshots (Optional):\r\n\r\n#### Vertical Layout for Search Filters and Map\r\n\r\n_all companies are being shown_\r\n\r\n<img width=\"814\" alt=\"search-near-me-none 2018-11-25 at 75945 pm\" src=\"https://user-images.githubusercontent.com/673794/48992642-c2bece00-f0ed-11e8-974e-dcb41896e505.png\">\r\n\r\n---\r\n\r\n#### Show all companies with the \"Civilia tjänstehundar\" kategori/category\r\n\r\n_Civilia tjänstehundar companies everywhere_ ( = 2)\r\n\r\n<img width=\"792\" alt=\"search-near-me-kategory-only 2018-11-25 at 80501 pm\" src=\"https://user-images.githubusercontent.com/673794/48992641-c2bece00-f0ed-11e8-9067-c9764acfd4ca.png\">\r\n\r\n---\r\n\r\n#### Show all \"Civilia tjänstehundar\" companies near Stockholm\r\n\r\n_There is only 1 Civilia tjänstehundar company near Stockholm_\r\n\r\n<img width=\"794\" alt=\"search-near-me-kategory-and-near 2018-11-25 at 80515 pm\" src=\"https://user-images.githubusercontent.com/673794/48992640-c2bece00-f0ed-11e8-850b-713c906f8b8c.png\">\r\n\r\n\r\n\r\nReady for review:\r\n@AgileVentures/shf-project-team \r\n","created_at":"2018-11-26T04:12:24Z","updated_at":"2018-11-26T06:58:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29a2a1d336870c8ab9bf1cdfd5d699f5e145eefb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/568/commits","review_comments_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/568/comments","review_comment_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/568/comments","statuses_url":"https://api.github.com/repos/AgileVentures/shf-project/statuses/eac2bccf9652adcecab8cdeb7bdcd07814d32841","head":{"label":"weedySeaDragon:sprint55-search-near-frontend","ref":"sprint55-search-near-frontend","sha":"eac2bccf9652adcecab8cdeb7bdcd07814d32841","user":{"login":"weedySeaDragon","id":673794,"node_id":"MDQ6VXNlcjY3Mzc5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/673794?v=4","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"repo":{"id":72142277,"node_id":"MDEwOlJlcG9zaXRvcnk3MjE0MjI3Nw==","name":"shf-project","full_name":"weedySeaDragon/shf-project","private":false,"owner":{"login":"weedySeaDragon","id":673794,"node_id":"MDQ6VXNlcjY3Mzc5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/673794?v=4","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/weedySeaDragon/shf-project","description":null,"fork":true,"url":"https://api.github.com/repos/weedySeaDragon/shf-project","forks_url":"https://api.github.com/repos/weedySeaDragon/shf-project/forks","keys_url":"https://api.github.com/repos/weedySeaDragon/shf-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weedySeaDragon/shf-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weedySeaDragon/shf-project/teams","hooks_url":"https://api.github.com/repos/weedySeaDragon/shf-project/hooks","issue_events_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues/events{/number}","events_url":"https://api.github.com/repos/weedySeaDragon/shf-project/events","assignees_url":"https://api.github.com/repos/weedySeaDragon/shf-project/assignees{/user}","branches_url":"https://api.github.com/repos/weedySeaDragon/shf-project/branches{/branch}","tags_url":"https://api.github.com/repos/weedySeaDragon/shf-project/tags","blobs_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weedySeaDragon/shf-project/statuses/{sha}","languages_url":"https://api.github.com/repos/weedySeaDragon/shf-project/languages","stargazers_url":"https://api.github.com/repos/weedySeaDragon/shf-project/stargazers","contributors_url":"https://api.github.com/repos/weedySeaDragon/shf-project/contributors","subscribers_url":"https://api.github.com/repos/weedySeaDragon/shf-project/subscribers","subscription_url":"https://api.github.com/repos/weedySeaDragon/shf-project/subscription","commits_url":"https://api.github.com/repos/weedySeaDragon/shf-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/weedySeaDragon/shf-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/weedySeaDragon/shf-project/contents/{+path}","compare_url":"https://api.github.com/repos/weedySeaDragon/shf-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weedySeaDragon/shf-project/merges","archive_url":"https://api.github.com/repos/weedySeaDragon/shf-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weedySeaDragon/shf-project/downloads","issues_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues{/number}","pulls_url":"https://api.github.com/repos/weedySeaDragon/shf-project/pulls{/number}","milestones_url":"https://api.github.com/repos/weedySeaDragon/shf-project/milestones{/number}","notifications_url":"https://api.github.com/repos/weedySeaDragon/shf-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weedySeaDragon/shf-project/labels{/name}","releases_url":"https://api.github.com/repos/weedySeaDragon/shf-project/releases{/id}","deployments_url":"https://api.github.com/repos/weedySeaDragon/shf-project/deployments","created_at":"2016-10-27T19:44:01Z","updated_at":"2018-11-08T19:23:58Z","pushed_at":"2018-11-26T06:58:08Z","git_url":"git://github.com/weedySeaDragon/shf-project.git","ssh_url":"git@github.com:weedySeaDragon/shf-project.git","clone_url":"https://github.com/weedySeaDragon/shf-project.git","svn_url":"https://github.com/weedySeaDragon/shf-project","homepage":null,"size":35283,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"AgileVentures:develop","ref":"develop","sha":"330772a9cbe153b1079948bbff2f4b3573983021","user":{"login":"AgileVentures","id":5116968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTY5Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/5116968?v=4","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"repo":{"id":71157737,"node_id":"MDEwOlJlcG9zaXRvcnk3MTE1NzczNw==","name":"shf-project","full_name":"AgileVentures/shf-project","private":false,"owner":{"login":"AgileVentures","id":5116968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTY5Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/5116968?v=4","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AgileVentures/shf-project","description":"Part of the website for and membership management for Sveriges Hundföretagare  (The Swedish Dog  Industry association). A project run with AgileVentures.org","fork":true,"url":"https://api.github.com/repos/AgileVentures/shf-project","forks_url":"https://api.github.com/repos/AgileVentures/shf-project/forks","keys_url":"https://api.github.com/repos/AgileVentures/shf-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AgileVentures/shf-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AgileVentures/shf-project/teams","hooks_url":"https://api.github.com/repos/AgileVentures/shf-project/hooks","issue_events_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/events{/number}","events_url":"https://api.github.com/repos/AgileVentures/shf-project/events","assignees_url":"https://api.github.com/repos/AgileVentures/shf-project/assignees{/user}","branches_url":"https://api.github.com/repos/AgileVentures/shf-project/branches{/branch}","tags_url":"https://api.github.com/repos/AgileVentures/shf-project/tags","blobs_url":"https://api.github.com/repos/AgileVentures/shf-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AgileVentures/shf-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AgileVentures/shf-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/AgileVentures/shf-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AgileVentures/shf-project/statuses/{sha}","languages_url":"https://api.github.com/repos/AgileVentures/shf-project/languages","stargazers_url":"https://api.github.com/repos/AgileVentures/shf-project/stargazers","contributors_url":"https://api.github.com/repos/AgileVentures/shf-project/contributors","subscribers_url":"https://api.github.com/repos/AgileVentures/shf-project/subscribers","subscription_url":"https://api.github.com/repos/AgileVentures/shf-project/subscription","commits_url":"https://api.github.com/repos/AgileVentures/shf-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/AgileVentures/shf-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/AgileVentures/shf-project/contents/{+path}","compare_url":"https://api.github.com/repos/AgileVentures/shf-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AgileVentures/shf-project/merges","archive_url":"https://api.github.com/repos/AgileVentures/shf-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AgileVentures/shf-project/downloads","issues_url":"https://api.github.com/repos/AgileVentures/shf-project/issues{/number}","pulls_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls{/number}","milestones_url":"https://api.github.com/repos/AgileVentures/shf-project/milestones{/number}","notifications_url":"https://api.github.com/repos/AgileVentures/shf-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AgileVentures/shf-project/labels{/name}","releases_url":"https://api.github.com/repos/AgileVentures/shf-project/releases{/id}","deployments_url":"https://api.github.com/repos/AgileVentures/shf-project/deployments","created_at":"2016-10-17T16:18:10Z","updated_at":"2018-11-23T13:37:29Z","pushed_at":"2018-11-26T06:58:09Z","git_url":"git://github.com/AgileVentures/shf-project.git","ssh_url":"git@github.com:AgileVentures/shf-project.git","clone_url":"https://github.com/AgileVentures/shf-project.git","svn_url":"https://github.com/AgileVentures/shf-project","homepage":"","size":33025,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":26,"open_issues":4,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/568"},"html":{"href":"https://github.com/AgileVentures/shf-project/pull/568"},"issue":{"href":"https://api.github.com/repos/AgileVentures/shf-project/issues/568"},"comments":{"href":"https://api.github.com/repos/AgileVentures/shf-project/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/AgileVentures/shf-project/statuses/eac2bccf9652adcecab8cdeb7bdcd07814d32841"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"houndci-bot"}}