{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/22521","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/22521/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22521/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/22521/events","html_url":"https://github.com/nodejs/node/pull/22521","id":354006474,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODk5Mjg2","number":22521,"title":"src,deps: add isolate parameter to String::Concat","user":{"login":"targos","id":2352663,"node_id":"MDQ6VXNlcjIzNTI2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-25T11:47:55Z","updated_at":"2018-08-25T12:50:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22521","html_url":"https://github.com/nodejs/node/pull/22521","diff_url":"https://github.com/nodejs/node/pull/22521.diff","patch_url":"https://github.com/nodejs/node/pull/22521.patch"},"body":"Partially backport an upstream commit that deprecates String::Concat\r\nwithout the isolate parameter. This overload has already been removed\r\nin V8 7.0.\r\n\r\nRefs: https://github.com/v8/v8/commit/8a011b57d8b26e9cfe1c20a2ef26adb14be6ecc2\r\n\r\n/cc @nodejs/v8-update \r\n\r\nI'd like your opinion on this proactive approach about V8 deprecations. If everyone is fine with it, I'm ready to open other PRs for `StackTrace::GetFrame`, `String::Write`, etc.\r\nI would like to do this because it can be backported to `v10.x`.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/415967165","html_url":"https://github.com/nodejs/node/pull/22521#issuecomment-415967165","issue_url":"https://api.github.com/repos/nodejs/node/issues/22521","id":415967165,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTk2NzE2NQ==","user":{"login":"ryzokuken","id":13121330,"node_id":"MDQ6VXNlcjEzMTIxMzMw","avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"created_at":"2018-08-25T12:50:25Z","updated_at":"2018-08-25T12:50:25Z","author_association":"MEMBER","body":"As I said, I agree that we should just directly use it, I just had been wondering why it wasn't being used before this patch if the parameter always existed."}}
{"actor":{"display_login":"ryzokuken"}}