{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/175715957","pull_request_review_id":105288702,"id":175715957,"diff_hunk":"@@ -533,6 +533,10 @@ static int write_temporary_shadow(const char *shadow_path, FILE **tmpfile, char\n                                 ordered_hashmap_remove(todo_uids, UID_TO_PTR(i->uid));\n                         }\n \n+                        /* Make sure we keep the NIS entries (if any) at the end. */\n+                        if (IN_SET(sp->sp_namp[0], '+', '-'))\n+                                break;\n+\n                         errno = 0;","path":"src/sysusers/sysusers.c","position":24,"original_position":24,"commit_id":"dbaf47bc9838ba29a8cc6b4c99e6375efedf6ad4","original_commit_id":"dbaf47bc9838ba29a8cc6b4c99e6375efedf6ad4","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"body":"ok, i am officially an idiot. I just asked you to move the errno down, but actually your original code was right. Because we check errno right after this loop, and in that case we should not trip up on any side-effect of fgetspent()...\r\n\r\nSo sorry for the forth and back!\r\n\r\nPlease move the errno initializuation before the if check again!","created_at":"2018-03-20T10:26:18Z","updated_at":"2018-03-20T10:26:18Z","html_url":"https://github.com/systemd/systemd/pull/8499#discussion_r175715957","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/8499","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/175715957"},"html":{"href":"https://github.com/systemd/systemd/pull/8499#discussion_r175715957"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8499"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/8499","id":176120805,"html_url":"https://github.com/systemd/systemd/pull/8499","diff_url":"https://github.com/systemd/systemd/pull/8499.diff","patch_url":"https://github.com/systemd/systemd/pull/8499.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/8499","number":8499,"state":"open","locked":false,"title":"sysusers: also add support for NIS entries in /etc/shadow","user":{"login":"fbuihuu","id":251384,"avatar_url":"https://avatars3.githubusercontent.com/u/251384?v=4","gravatar_id":"","url":"https://api.github.com/users/fbuihuu","html_url":"https://github.com/fbuihuu","followers_url":"https://api.github.com/users/fbuihuu/followers","following_url":"https://api.github.com/users/fbuihuu/following{/other_user}","gists_url":"https://api.github.com/users/fbuihuu/gists{/gist_id}","starred_url":"https://api.github.com/users/fbuihuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbuihuu/subscriptions","organizations_url":"https://api.github.com/users/fbuihuu/orgs","repos_url":"https://api.github.com/users/fbuihuu/repos","events_url":"https://api.github.com/users/fbuihuu/events{/privacy}","received_events_url":"https://api.github.com/users/fbuihuu/received_events","type":"User","site_admin":false},"body":"Commit 563dc6f8e2cda4114dd20f32655890ed378c3740 added support for\r\n/etc/{passwd,group} only but since nsswitch.conf(5) appears to document the NIS\r\nentries also for shadow, let's support this case too.","created_at":"2018-03-20T08:44:25Z","updated_at":"2018-03-20T10:26:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f2e9698a726a309523d3cee1bbd8c9de7ab3046","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":222775092,"url":"https://api.github.com/repos/systemd/systemd/labels/reviewed/needs-rework%20%F0%9F%94%A8","name":"reviewed/needs-rework 🔨","color":"eb6420","default":false},{"id":264145532,"url":"https://api.github.com/repos/systemd/systemd/labels/sysusers","name":"sysusers","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/8499/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/8499/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/8499/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/dbaf47bc9838ba29a8cc6b4c99e6375efedf6ad4","head":{"label":"fbuihuu:shadow-support-nis","ref":"shadow-support-nis","sha":"dbaf47bc9838ba29a8cc6b4c99e6375efedf6ad4","user":{"login":"fbuihuu","id":251384,"avatar_url":"https://avatars3.githubusercontent.com/u/251384?v=4","gravatar_id":"","url":"https://api.github.com/users/fbuihuu","html_url":"https://github.com/fbuihuu","followers_url":"https://api.github.com/users/fbuihuu/followers","following_url":"https://api.github.com/users/fbuihuu/following{/other_user}","gists_url":"https://api.github.com/users/fbuihuu/gists{/gist_id}","starred_url":"https://api.github.com/users/fbuihuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbuihuu/subscriptions","organizations_url":"https://api.github.com/users/fbuihuu/orgs","repos_url":"https://api.github.com/users/fbuihuu/repos","events_url":"https://api.github.com/users/fbuihuu/events{/privacy}","received_events_url":"https://api.github.com/users/fbuihuu/received_events","type":"User","site_admin":false},"repo":{"id":43303412,"name":"systemd","full_name":"fbuihuu/systemd","owner":{"login":"fbuihuu","id":251384,"avatar_url":"https://avatars3.githubusercontent.com/u/251384?v=4","gravatar_id":"","url":"https://api.github.com/users/fbuihuu","html_url":"https://github.com/fbuihuu","followers_url":"https://api.github.com/users/fbuihuu/followers","following_url":"https://api.github.com/users/fbuihuu/following{/other_user}","gists_url":"https://api.github.com/users/fbuihuu/gists{/gist_id}","starred_url":"https://api.github.com/users/fbuihuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbuihuu/subscriptions","organizations_url":"https://api.github.com/users/fbuihuu/orgs","repos_url":"https://api.github.com/users/fbuihuu/repos","events_url":"https://api.github.com/users/fbuihuu/events{/privacy}","received_events_url":"https://api.github.com/users/fbuihuu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbuihuu/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/fbuihuu/systemd","forks_url":"https://api.github.com/repos/fbuihuu/systemd/forks","keys_url":"https://api.github.com/repos/fbuihuu/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbuihuu/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbuihuu/systemd/teams","hooks_url":"https://api.github.com/repos/fbuihuu/systemd/hooks","issue_events_url":"https://api.github.com/repos/fbuihuu/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/fbuihuu/systemd/events","assignees_url":"https://api.github.com/repos/fbuihuu/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/fbuihuu/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/fbuihuu/systemd/tags","blobs_url":"https://api.github.com/repos/fbuihuu/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbuihuu/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbuihuu/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbuihuu/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbuihuu/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/fbuihuu/systemd/languages","stargazers_url":"https://api.github.com/repos/fbuihuu/systemd/stargazers","contributors_url":"https://api.github.com/repos/fbuihuu/systemd/contributors","subscribers_url":"https://api.github.com/repos/fbuihuu/systemd/subscribers","subscription_url":"https://api.github.com/repos/fbuihuu/systemd/subscription","commits_url":"https://api.github.com/repos/fbuihuu/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbuihuu/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbuihuu/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbuihuu/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbuihuu/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/fbuihuu/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbuihuu/systemd/merges","archive_url":"https://api.github.com/repos/fbuihuu/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbuihuu/systemd/downloads","issues_url":"https://api.github.com/repos/fbuihuu/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/fbuihuu/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/fbuihuu/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/fbuihuu/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbuihuu/systemd/labels{/name}","releases_url":"https://api.github.com/repos/fbuihuu/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/fbuihuu/systemd/deployments","created_at":"2015-09-28T13:44:04Z","updated_at":"2016-02-25T09:44:48Z","pushed_at":"2018-03-20T10:18:07Z","git_url":"git://github.com/fbuihuu/systemd.git","ssh_url":"git@github.com:fbuihuu/systemd.git","clone_url":"https://github.com/fbuihuu/systemd.git","svn_url":"https://github.com/fbuihuu/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":87562,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"27b6cb1f59e1e7a5cc0e70d293dbb1607f754a99","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"⚙️ 🐧 systemd System and Service Manager ","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2018-03-20T08:54:32Z","pushed_at":"2018-03-20T10:18:09Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"https://www.freedesktop.org/wiki/Software/systemd/","size":87330,"stargazers_count":2933,"watchers_count":2933,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1178,"mirror_url":null,"archived":false,"open_issues_count":912,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1178,"open_issues":912,"watchers":2933,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8499"},"html":{"href":"https://github.com/systemd/systemd/pull/8499"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/8499"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/8499/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8499/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8499/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/dbaf47bc9838ba29a8cc6b4c99e6375efedf6ad4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"poettering"}}