{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/gristlabs/grain-rpc/pulls/19","id":197242184,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjQyMTg0","html_url":"https://github.com/gristlabs/grain-rpc/pull/19","diff_url":"https://github.com/gristlabs/grain-rpc/pull/19.diff","patch_url":"https://github.com/gristlabs/grain-rpc/pull/19.patch","issue_url":"https://api.github.com/repos/gristlabs/grain-rpc/issues/19","number":19,"state":"closed","locked":false,"title":"better queuing support","user":{"login":"cpind","id":3463195,"node_id":"MDQ6VXNlcjM0NjMxOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3463195?v=4","gravatar_id":"","url":"https://api.github.com/users/cpind","html_url":"https://github.com/cpind","followers_url":"https://api.github.com/users/cpind/followers","following_url":"https://api.github.com/users/cpind/following{/other_user}","gists_url":"https://api.github.com/users/cpind/gists{/gist_id}","starred_url":"https://api.github.com/users/cpind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpind/subscriptions","organizations_url":"https://api.github.com/users/cpind/orgs","repos_url":"https://api.github.com/users/cpind/repos","events_url":"https://api.github.com/users/cpind/events{/privacy}","received_events_url":"https://api.github.com/users/cpind/received_events","type":"User","site_admin":false},"body":"With this PR both received and sent message are queued.\r\nIt introduces as well a `stop()` method that put rpc back to the same state it was in before calling `start()`.\r\nAs well proposes a fix to what seems to be a poor types support in `getStub`. Although there were may be a reason to use `any` instead of `Iface` so this should be reviewed with attention.","created_at":"2018-06-25T21:33:22Z","updated_at":"2018-06-27T16:23:31Z","closed_at":"2018-06-27T16:23:31Z","merged_at":"2018-06-27T16:23:31Z","merge_commit_sha":"50b9dae054fdc092785c0696d9c912baf6d08652","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gristlabs/grain-rpc/pulls/19/commits","review_comments_url":"https://api.github.com/repos/gristlabs/grain-rpc/pulls/19/comments","review_comment_url":"https://api.github.com/repos/gristlabs/grain-rpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gristlabs/grain-rpc/issues/19/comments","statuses_url":"https://api.github.com/repos/gristlabs/grain-rpc/statuses/60c58060b9ca5aef6c718b618ed846e0314f9341","head":{"label":"gristlabs:better-queueing","ref":"better-queueing","sha":"60c58060b9ca5aef6c718b618ed846e0314f9341","user":{"login":"gristlabs","id":19978005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc4MDA1","avatar_url":"https://avatars0.githubusercontent.com/u/19978005?v=4","gravatar_id":"","url":"https://api.github.com/users/gristlabs","html_url":"https://github.com/gristlabs","followers_url":"https://api.github.com/users/gristlabs/followers","following_url":"https://api.github.com/users/gristlabs/following{/other_user}","gists_url":"https://api.github.com/users/gristlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/gristlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gristlabs/subscriptions","organizations_url":"https://api.github.com/users/gristlabs/orgs","repos_url":"https://api.github.com/users/gristlabs/repos","events_url":"https://api.github.com/users/gristlabs/events{/privacy}","received_events_url":"https://api.github.com/users/gristlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":123234761,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMyMzQ3NjE=","name":"grain-rpc","full_name":"gristlabs/grain-rpc","owner":{"login":"gristlabs","id":19978005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc4MDA1","avatar_url":"https://avatars0.githubusercontent.com/u/19978005?v=4","gravatar_id":"","url":"https://api.github.com/users/gristlabs","html_url":"https://github.com/gristlabs","followers_url":"https://api.github.com/users/gristlabs/followers","following_url":"https://api.github.com/users/gristlabs/following{/other_user}","gists_url":"https://api.github.com/users/gristlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/gristlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gristlabs/subscriptions","organizations_url":"https://api.github.com/users/gristlabs/orgs","repos_url":"https://api.github.com/users/gristlabs/repos","events_url":"https://api.github.com/users/gristlabs/events{/privacy}","received_events_url":"https://api.github.com/users/gristlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gristlabs/grain-rpc","description":"Typed RPC interface on top of an arbitrary communication channel","fork":false,"url":"https://api.github.com/repos/gristlabs/grain-rpc","forks_url":"https://api.github.com/repos/gristlabs/grain-rpc/forks","keys_url":"https://api.github.com/repos/gristlabs/grain-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gristlabs/grain-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gristlabs/grain-rpc/teams","hooks_url":"https://api.github.com/repos/gristlabs/grain-rpc/hooks","issue_events_url":"https://api.github.com/repos/gristlabs/grain-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/gristlabs/grain-rpc/events","assignees_url":"https://api.github.com/repos/gristlabs/grain-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/gristlabs/grain-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/gristlabs/grain-rpc/tags","blobs_url":"https://api.github.com/repos/gristlabs/grain-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gristlabs/grain-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gristlabs/grain-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/gristlabs/grain-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gristlabs/grain-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/gristlabs/grain-rpc/languages","stargazers_url":"https://api.github.com/repos/gristlabs/grain-rpc/stargazers","contributors_url":"https://api.github.com/repos/gristlabs/grain-rpc/contributors","subscribers_url":"https://api.github.com/repos/gristlabs/grain-rpc/subscribers","subscription_url":"https://api.github.com/repos/gristlabs/grain-rpc/subscription","commits_url":"https://api.github.com/repos/gristlabs/grain-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/gristlabs/grain-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/gristlabs/grain-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/gristlabs/grain-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/gristlabs/grain-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/gristlabs/grain-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gristlabs/grain-rpc/merges","archive_url":"https://api.github.com/repos/gristlabs/grain-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gristlabs/grain-rpc/downloads","issues_url":"https://api.github.com/repos/gristlabs/grain-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/gristlabs/grain-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/gristlabs/grain-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/gristlabs/grain-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gristlabs/grain-rpc/labels{/name}","releases_url":"https://api.github.com/repos/gristlabs/grain-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/gristlabs/grain-rpc/deployments","created_at":"2018-02-28T05:36:24Z","updated_at":"2018-06-20T21:44:26Z","pushed_at":"2018-06-27T16:23:32Z","git_url":"git://github.com/gristlabs/grain-rpc.git","ssh_url":"git@github.com:gristlabs/grain-rpc.git","clone_url":"https://github.com/gristlabs/grain-rpc.git","svn_url":"https://github.com/gristlabs/grain-rpc","homepage":null,"size":81,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"gristlabs:master","ref":"master","sha":"aa37efba3bcbd8f574cd316f00d9d087f7b099f8","user":{"login":"gristlabs","id":19978005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc4MDA1","avatar_url":"https://avatars0.githubusercontent.com/u/19978005?v=4","gravatar_id":"","url":"https://api.github.com/users/gristlabs","html_url":"https://github.com/gristlabs","followers_url":"https://api.github.com/users/gristlabs/followers","following_url":"https://api.github.com/users/gristlabs/following{/other_user}","gists_url":"https://api.github.com/users/gristlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/gristlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gristlabs/subscriptions","organizations_url":"https://api.github.com/users/gristlabs/orgs","repos_url":"https://api.github.com/users/gristlabs/repos","events_url":"https://api.github.com/users/gristlabs/events{/privacy}","received_events_url":"https://api.github.com/users/gristlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":123234761,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMyMzQ3NjE=","name":"grain-rpc","full_name":"gristlabs/grain-rpc","owner":{"login":"gristlabs","id":19978005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc4MDA1","avatar_url":"https://avatars0.githubusercontent.com/u/19978005?v=4","gravatar_id":"","url":"https://api.github.com/users/gristlabs","html_url":"https://github.com/gristlabs","followers_url":"https://api.github.com/users/gristlabs/followers","following_url":"https://api.github.com/users/gristlabs/following{/other_user}","gists_url":"https://api.github.com/users/gristlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/gristlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gristlabs/subscriptions","organizations_url":"https://api.github.com/users/gristlabs/orgs","repos_url":"https://api.github.com/users/gristlabs/repos","events_url":"https://api.github.com/users/gristlabs/events{/privacy}","received_events_url":"https://api.github.com/users/gristlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gristlabs/grain-rpc","description":"Typed RPC interface on top of an arbitrary communication channel","fork":false,"url":"https://api.github.com/repos/gristlabs/grain-rpc","forks_url":"https://api.github.com/repos/gristlabs/grain-rpc/forks","keys_url":"https://api.github.com/repos/gristlabs/grain-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gristlabs/grain-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gristlabs/grain-rpc/teams","hooks_url":"https://api.github.com/repos/gristlabs/grain-rpc/hooks","issue_events_url":"https://api.github.com/repos/gristlabs/grain-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/gristlabs/grain-rpc/events","assignees_url":"https://api.github.com/repos/gristlabs/grain-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/gristlabs/grain-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/gristlabs/grain-rpc/tags","blobs_url":"https://api.github.com/repos/gristlabs/grain-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gristlabs/grain-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gristlabs/grain-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/gristlabs/grain-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gristlabs/grain-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/gristlabs/grain-rpc/languages","stargazers_url":"https://api.github.com/repos/gristlabs/grain-rpc/stargazers","contributors_url":"https://api.github.com/repos/gristlabs/grain-rpc/contributors","subscribers_url":"https://api.github.com/repos/gristlabs/grain-rpc/subscribers","subscription_url":"https://api.github.com/repos/gristlabs/grain-rpc/subscription","commits_url":"https://api.github.com/repos/gristlabs/grain-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/gristlabs/grain-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/gristlabs/grain-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/gristlabs/grain-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/gristlabs/grain-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/gristlabs/grain-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gristlabs/grain-rpc/merges","archive_url":"https://api.github.com/repos/gristlabs/grain-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gristlabs/grain-rpc/downloads","issues_url":"https://api.github.com/repos/gristlabs/grain-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/gristlabs/grain-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/gristlabs/grain-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/gristlabs/grain-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gristlabs/grain-rpc/labels{/name}","releases_url":"https://api.github.com/repos/gristlabs/grain-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/gristlabs/grain-rpc/deployments","created_at":"2018-02-28T05:36:24Z","updated_at":"2018-06-20T21:44:26Z","pushed_at":"2018-06-27T16:23:32Z","git_url":"git://github.com/gristlabs/grain-rpc.git","ssh_url":"git@github.com:gristlabs/grain-rpc.git","clone_url":"https://github.com/gristlabs/grain-rpc.git","svn_url":"https://github.com/gristlabs/grain-rpc","homepage":null,"size":81,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gristlabs/grain-rpc/pulls/19"},"html":{"href":"https://github.com/gristlabs/grain-rpc/pull/19"},"issue":{"href":"https://api.github.com/repos/gristlabs/grain-rpc/issues/19"},"comments":{"href":"https://api.github.com/repos/gristlabs/grain-rpc/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/gristlabs/grain-rpc/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/gristlabs/grain-rpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gristlabs/grain-rpc/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/gristlabs/grain-rpc/statuses/60c58060b9ca5aef6c718b618ed846e0314f9341"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cpind","id":3463195,"node_id":"MDQ6VXNlcjM0NjMxOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3463195?v=4","gravatar_id":"","url":"https://api.github.com/users/cpind","html_url":"https://github.com/cpind","followers_url":"https://api.github.com/users/cpind/followers","following_url":"https://api.github.com/users/cpind/following{/other_user}","gists_url":"https://api.github.com/users/cpind/gists{/gist_id}","starred_url":"https://api.github.com/users/cpind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpind/subscriptions","organizations_url":"https://api.github.com/users/cpind/orgs","repos_url":"https://api.github.com/users/cpind/repos","events_url":"https://api.github.com/users/cpind/events{/privacy}","received_events_url":"https://api.github.com/users/cpind/received_events","type":"User","site_admin":false},"comments":0,"review_comments":18,"maintainer_can_modify":false,"commits":4,"additions":116,"deletions":25,"changed_files":2}}
{"actor":{"display_login":"cpind"}}