{"action":"created","issue":{"url":"https://api.github.com/repos/postmanlabs/postman-app-support/issues/4300","repository_url":"https://api.github.com/repos/postmanlabs/postman-app-support","labels_url":"https://api.github.com/repos/postmanlabs/postman-app-support/issues/4300/labels{/name}","comments_url":"https://api.github.com/repos/postmanlabs/postman-app-support/issues/4300/comments","events_url":"https://api.github.com/repos/postmanlabs/postman-app-support/issues/4300/events","html_url":"https://github.com/postmanlabs/postman-app-support/issues/4300","id":303269541,"number":4300,"title":"Postman Desktop Oauth Fails when Consumer Key contains Exclamation Point","user":{"login":"jamesfrankman","id":20843139,"avatar_url":"https://avatars3.githubusercontent.com/u/20843139?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesfrankman","html_url":"https://github.com/jamesfrankman","followers_url":"https://api.github.com/users/jamesfrankman/followers","following_url":"https://api.github.com/users/jamesfrankman/following{/other_user}","gists_url":"https://api.github.com/users/jamesfrankman/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesfrankman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesfrankman/subscriptions","organizations_url":"https://api.github.com/users/jamesfrankman/orgs","repos_url":"https://api.github.com/users/jamesfrankman/repos","events_url":"https://api.github.com/users/jamesfrankman/events{/privacy}","received_events_url":"https://api.github.com/users/jamesfrankman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-07T21:39:46Z","updated_at":"2018-03-08T12:12:25Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nWelcome to the Postman Issue tracker. Any feature requests / bug reports can be posted here.\r\nAny security-related bugs should be reported directly to security@getpostman.com\r\n-->\r\n\r\n## App Details:\r\n```\r\nPostman for Windows\r\nVersion 5.5.0\r\nwin32 6.1.7601 / x64\r\n```\r\n\r\n## Issue Report:\r\n 1. Did you encounter this recently, or has this bug always been there: \r\nIt has always been in the Desktop version, works fine in the Chrome version of Postman.\r\n 2. Expected behaviour:\r\nWhen setting a consumer key in OAuth that contains an exclamation point the authorization header should not url escape the exclamation point.  For instance, given a consumer key of:\r\n \r\nfoo!bar\r\n\r\nThe authorization header's consumer key should be:\r\nOAuth oauth_consumer_key=\"foo!bar\",........\r\n\r\n\r\n 3. Console logs (http://blog.getpostman.com/2014/01/27/enabling-chrome-developer-tools-inside-postman/ for the Chrome App, View->Toggle Dev Tools for the Mac app): None\r\n\r\n 4. Screenshots (if applicable)\r\n![win32postmanoauthsetting](https://user-images.githubusercontent.com/20843139/37119560-c92f855a-2225-11e8-943e-758575ea6098.PNG)\r\n![chomepostmanoauthauthorizationheader](https://user-images.githubusercontent.com/20843139/37119561-c942fa68-2225-11e8-80a9-a01a17bef2dd.PNG)\r\n![chomepostmanoauthsetting](https://user-images.githubusercontent.com/20843139/37119562-c951d268-2225-11e8-8f4b-183a46edc573.PNG)\r\n![win32postmanoauthauthorizationheader](https://user-images.githubusercontent.com/20843139/37119563-c9607d2c-2225-11e8-838d-368108cb822d.PNG)\r\n\r\n\r\n\r\n\r\nSteps to reproduce the problem\r\n1. Create Post Request to some REST endpoint where the provided OAuth consumer key contains an exclamation point.\r\n2. Set Authorization Type to OAuth 1.0\r\n3. Enter consumer key that contains an exclamation point. i.e. foo!bar\r\n4. Click Preview Request button\r\n5. Check Authorization header and look for consumer_key. The key will be set to 'oauth_consumer_key=\"foo%21bar\"' rather than 'oauth_consumer_key=\"foo!bar\"' which will result in failed authentication with the rest endpoint.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/postmanlabs/postman-app-support/issues/comments/371469982","html_url":"https://github.com/postmanlabs/postman-app-support/issues/4300#issuecomment-371469982","issue_url":"https://api.github.com/repos/postmanlabs/postman-app-support/issues/4300","id":371469982,"user":{"login":"thecuriousdev","id":22293666,"avatar_url":"https://avatars0.githubusercontent.com/u/22293666?v=4","gravatar_id":"","url":"https://api.github.com/users/thecuriousdev","html_url":"https://github.com/thecuriousdev","followers_url":"https://api.github.com/users/thecuriousdev/followers","following_url":"https://api.github.com/users/thecuriousdev/following{/other_user}","gists_url":"https://api.github.com/users/thecuriousdev/gists{/gist_id}","starred_url":"https://api.github.com/users/thecuriousdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecuriousdev/subscriptions","organizations_url":"https://api.github.com/users/thecuriousdev/orgs","repos_url":"https://api.github.com/users/thecuriousdev/repos","events_url":"https://api.github.com/users/thecuriousdev/events{/privacy}","received_events_url":"https://api.github.com/users/thecuriousdev/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T12:12:25Z","updated_at":"2018-03-08T12:12:25Z","author_association":"NONE","body":"@jamesfrankman thanks for reporting this. This is reproducible, We'll look into this. "}}
{"actor":{"display_login":"thecuriousdev"}}