{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/216495211","pull_request_review_id":153990081,"id":216495211,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ5NTIxMQ==","diff_hunk":"@@ -619,6 +619,19 @@ def test_drop(self):\n         self.assertEqual(dc._force_count_rows(), 199)\n         self.assertEqual(dc._force_count_cols(), 0)\n \n+    def test_linear_regression(self):\n+        hl.index_bgen(resource('example.8bits.bgen'))","path":"hail/python/test/hail/methods/test_impex.py","position":5,"original_position":5,"commit_id":"9246718a3d5b1cc5559d21ce65fb8702a020ffab","original_commit_id":"9246718a3d5b1cc5559d21ce65fb8702a020ffab","user":{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"body":"I'm pushing back because I think we need to be much more diligent about code that makes it into tests - see our struggles with the scala tests as an example of why. \r\n\r\nas written, this is a test that tests over the integration of a bunch of things, but it doesn't test correctness, just that the thing executes successfully. The name doesn't really reflect what it's designed to test, either (the requiredness bug).\r\n\r\nWe should have integration tests, but IMO that doesn't mean we should let things that can have isolated unit tests become integration tests unnecessarily .","created_at":"2018-09-10T22:30:32Z","updated_at":"2018-09-10T22:30:32Z","html_url":"https://github.com/hail-is/hail/pull/4308#discussion_r216495211","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/4308","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/216495211"},"html":{"href":"https://github.com/hail-is/hail/pull/4308#discussion_r216495211"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4308"}},"in_reply_to_id":216487665},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/4308","id":214456330,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDU2MzMw","html_url":"https://github.com/hail-is/hail/pull/4308","diff_url":"https://github.com/hail-is/hail/pull/4308.diff","patch_url":"https://github.com/hail-is/hail/pull/4308.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/4308","number":4308,"state":"open","locked":false,"title":"Fix BGEN missingness bug","user":{"login":"jigold","id":1693348,"node_id":"MDQ6VXNlcjE2OTMzNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1693348?v=4","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"body":"The BGEN spec allows missing values of GP and hence dosage since dosage is computed from GP.","created_at":"2018-09-10T21:58:32Z","updated_at":"2018-09-10T22:30:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a205a04f97969b8cc56a8cdfb8dd9565df202cca","assignee":{"login":"catoverdrive","id":19789871,"node_id":"MDQ6VXNlcjE5Nzg5ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/19789871?v=4","gravatar_id":"","url":"https://api.github.com/users/catoverdrive","html_url":"https://github.com/catoverdrive","followers_url":"https://api.github.com/users/catoverdrive/followers","following_url":"https://api.github.com/users/catoverdrive/following{/other_user}","gists_url":"https://api.github.com/users/catoverdrive/gists{/gist_id}","starred_url":"https://api.github.com/users/catoverdrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catoverdrive/subscriptions","organizations_url":"https://api.github.com/users/catoverdrive/orgs","repos_url":"https://api.github.com/users/catoverdrive/repos","events_url":"https://api.github.com/users/catoverdrive/events{/privacy}","received_events_url":"https://api.github.com/users/catoverdrive/received_events","type":"User","site_admin":false},"assignees":[{"login":"catoverdrive","id":19789871,"node_id":"MDQ6VXNlcjE5Nzg5ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/19789871?v=4","gravatar_id":"","url":"https://api.github.com/users/catoverdrive","html_url":"https://github.com/catoverdrive","followers_url":"https://api.github.com/users/catoverdrive/followers","following_url":"https://api.github.com/users/catoverdrive/following{/other_user}","gists_url":"https://api.github.com/users/catoverdrive/gists{/gist_id}","starred_url":"https://api.github.com/users/catoverdrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catoverdrive/subscriptions","organizations_url":"https://api.github.com/users/catoverdrive/orgs","repos_url":"https://api.github.com/users/catoverdrive/repos","events_url":"https://api.github.com/users/catoverdrive/events{/privacy}","received_events_url":"https://api.github.com/users/catoverdrive/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":278787612,"node_id":"MDU6TGFiZWwyNzg3ODc2MTI=","url":"https://api.github.com/repos/hail-is/hail/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/4308/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/4308/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/4308/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/9246718a3d5b1cc5559d21ce65fb8702a020ffab","head":{"label":"jigold:bgen-linreg-req-field-bug","ref":"bgen-linreg-req-field-bug","sha":"9246718a3d5b1cc5559d21ce65fb8702a020ffab","user":{"login":"jigold","id":1693348,"node_id":"MDQ6VXNlcjE2OTMzNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1693348?v=4","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"repo":{"id":64695542,"node_id":"MDEwOlJlcG9zaXRvcnk2NDY5NTU0Mg==","name":"hail","full_name":"jigold/hail","owner":{"login":"jigold","id":1693348,"node_id":"MDQ6VXNlcjE2OTMzNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1693348?v=4","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jigold/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/jigold/hail","forks_url":"https://api.github.com/repos/jigold/hail/forks","keys_url":"https://api.github.com/repos/jigold/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jigold/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jigold/hail/teams","hooks_url":"https://api.github.com/repos/jigold/hail/hooks","issue_events_url":"https://api.github.com/repos/jigold/hail/issues/events{/number}","events_url":"https://api.github.com/repos/jigold/hail/events","assignees_url":"https://api.github.com/repos/jigold/hail/assignees{/user}","branches_url":"https://api.github.com/repos/jigold/hail/branches{/branch}","tags_url":"https://api.github.com/repos/jigold/hail/tags","blobs_url":"https://api.github.com/repos/jigold/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jigold/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jigold/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/jigold/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jigold/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/jigold/hail/languages","stargazers_url":"https://api.github.com/repos/jigold/hail/stargazers","contributors_url":"https://api.github.com/repos/jigold/hail/contributors","subscribers_url":"https://api.github.com/repos/jigold/hail/subscribers","subscription_url":"https://api.github.com/repos/jigold/hail/subscription","commits_url":"https://api.github.com/repos/jigold/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/jigold/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/jigold/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/jigold/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/jigold/hail/contents/{+path}","compare_url":"https://api.github.com/repos/jigold/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jigold/hail/merges","archive_url":"https://api.github.com/repos/jigold/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jigold/hail/downloads","issues_url":"https://api.github.com/repos/jigold/hail/issues{/number}","pulls_url":"https://api.github.com/repos/jigold/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/jigold/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/jigold/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jigold/hail/labels{/name}","releases_url":"https://api.github.com/repos/jigold/hail/releases{/id}","deployments_url":"https://api.github.com/repos/jigold/hail/deployments","created_at":"2016-08-01T19:28:56Z","updated_at":"2018-09-10T21:57:19Z","pushed_at":"2018-09-10T21:57:28Z","git_url":"git://github.com/jigold/hail.git","ssh_url":"git@github.com:jigold/hail.git","clone_url":"https://github.com/jigold/hail.git","svn_url":"https://github.com/jigold/hail","homepage":"","size":49238,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"1225a6c838c15230de07c1c562f7e6e0f255e7c4","user":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTQ2Nw==","name":"hail","full_name":"hail-is/hail","owner":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2018-09-10T21:55:59Z","pushed_at":"2018-09-10T22:19:15Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":41605,"stargazers_count":366,"watchers_count":366,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":105,"open_issues":155,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4308"},"html":{"href":"https://github.com/hail-is/hail/pull/4308"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/4308"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/4308/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4308/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4308/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/9246718a3d5b1cc5559d21ce65fb8702a020ffab"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tpoterba"}}