{"action":"created","comment":{"url":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/comments/243106472","pull_request_review_id":186787850,"id":243106472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzEwNjQ3Mg==","diff_hunk":"@@ -90,8 +90,8 @@\n                     \"source.tsx\",\n                     \"text.html.basic\"","path":"package.json","position":2,"original_position":2,"commit_id":"49ce6a38a676c4f0f11d649022fdbac7717f9639","original_commit_id":"49ce6a38a676c4f0f11d649022fdbac7717f9639","user":{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"body":"I don't think so. `injectTo` specifies that target grammar id while the injectionSelector specifies the scope within the grammar to inject into","created_at":"2018-12-19T23:01:17Z","updated_at":"2018-12-19T23:01:17Z","html_url":"https://github.com/mjbvz/vscode-lit-html/pull/57#discussion_r243106472","pull_request_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/57","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/comments/243106472"},"html":{"href":"https://github.com/mjbvz/vscode-lit-html/pull/57#discussion_r243106472"},"pull_request":{"href":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/57"}},"in_reply_to_id":243103513},"pull_request":{"url":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/57","id":239534473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTM0NDcz","html_url":"https://github.com/mjbvz/vscode-lit-html/pull/57","diff_url":"https://github.com/mjbvz/vscode-lit-html/pull/57.diff","patch_url":"https://github.com/mjbvz/vscode-lit-html/pull/57.patch","issue_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/issues/57","number":57,"state":"open","locked":false,"title":"Fix highlight for unquoted attributes","user":{"login":"csvn","id":8770194,"node_id":"MDQ6VXNlcjg3NzAxOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8770194?v=4","gravatar_id":"","url":"https://api.github.com/users/csvn","html_url":"https://github.com/csvn","followers_url":"https://api.github.com/users/csvn/followers","following_url":"https://api.github.com/users/csvn/following{/other_user}","gists_url":"https://api.github.com/users/csvn/gists{/gist_id}","starred_url":"https://api.github.com/users/csvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csvn/subscriptions","organizations_url":"https://api.github.com/users/csvn/orgs","repos_url":"https://api.github.com/users/csvn/repos","events_url":"https://api.github.com/users/csvn/events{/privacy}","received_events_url":"https://api.github.com/users/csvn/received_events","type":"User","site_admin":false},"body":"The tests I have done seem to indicate this works correctly. I also used \"Inspect TM scopes\" to check that attribute names and tokens still had correct scopes, which was true as far as I could see.\r\n\r\n![image](https://user-images.githubusercontent.com/8770194/50163814-8a23a600-02e1-11e9-82a6-2f75dcac0b27.png)\r\n\r\n![image](https://user-images.githubusercontent.com/8770194/50163831-93147780-02e1-11e9-818e-1f10ad59ce9b.png)\r\n\r\nI was not able to find any documentation on the syntax for `injectionSelector`, so `meta.tag` scope was the best I could find that still matches native tags, custom tags, void/regular tags etc. I tried to use `(meta.tag.html)` and `(meta.tag.*.html)` to limit the selector, but that did not work. These were the scopes I could find that should be targeted:\r\n\r\n- `meta.tag.custom.start.html`\r\n- `meta.tag.structure.<tagname>.<start|void>.html`\r\n- `meta.tag.other.<tagname>.html`\r\n\r\nI'm not sure if there are performance issues with using only `meta.tag`, or if it is too general, but any tips would be helpful.\r\n\r\nFixes #46","created_at":"2018-12-18T15:40:52Z","updated_at":"2018-12-19T23:01:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28c4a0fb873c4887d5837e8f94faf9e9e455dab4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/57/commits","review_comments_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/57/comments","review_comment_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/issues/57/comments","statuses_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/statuses/49ce6a38a676c4f0f11d649022fdbac7717f9639","head":{"label":"csvn:fix-unquoted-highlight","ref":"fix-unquoted-highlight","sha":"49ce6a38a676c4f0f11d649022fdbac7717f9639","user":{"login":"csvn","id":8770194,"node_id":"MDQ6VXNlcjg3NzAxOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8770194?v=4","gravatar_id":"","url":"https://api.github.com/users/csvn","html_url":"https://github.com/csvn","followers_url":"https://api.github.com/users/csvn/followers","following_url":"https://api.github.com/users/csvn/following{/other_user}","gists_url":"https://api.github.com/users/csvn/gists{/gist_id}","starred_url":"https://api.github.com/users/csvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csvn/subscriptions","organizations_url":"https://api.github.com/users/csvn/orgs","repos_url":"https://api.github.com/users/csvn/repos","events_url":"https://api.github.com/users/csvn/events{/privacy}","received_events_url":"https://api.github.com/users/csvn/received_events","type":"User","site_admin":false},"repo":{"id":162297852,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIyOTc4NTI=","name":"vscode-lit-html","full_name":"csvn/vscode-lit-html","private":false,"owner":{"login":"csvn","id":8770194,"node_id":"MDQ6VXNlcjg3NzAxOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8770194?v=4","gravatar_id":"","url":"https://api.github.com/users/csvn","html_url":"https://github.com/csvn","followers_url":"https://api.github.com/users/csvn/followers","following_url":"https://api.github.com/users/csvn/following{/other_user}","gists_url":"https://api.github.com/users/csvn/gists{/gist_id}","starred_url":"https://api.github.com/users/csvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csvn/subscriptions","organizations_url":"https://api.github.com/users/csvn/orgs","repos_url":"https://api.github.com/users/csvn/repos","events_url":"https://api.github.com/users/csvn/events{/privacy}","received_events_url":"https://api.github.com/users/csvn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/csvn/vscode-lit-html","description":"Adds syntax highlighting for html inside of JavaScript and TypeScript tagged template strings","fork":true,"url":"https://api.github.com/repos/csvn/vscode-lit-html","forks_url":"https://api.github.com/repos/csvn/vscode-lit-html/forks","keys_url":"https://api.github.com/repos/csvn/vscode-lit-html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csvn/vscode-lit-html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csvn/vscode-lit-html/teams","hooks_url":"https://api.github.com/repos/csvn/vscode-lit-html/hooks","issue_events_url":"https://api.github.com/repos/csvn/vscode-lit-html/issues/events{/number}","events_url":"https://api.github.com/repos/csvn/vscode-lit-html/events","assignees_url":"https://api.github.com/repos/csvn/vscode-lit-html/assignees{/user}","branches_url":"https://api.github.com/repos/csvn/vscode-lit-html/branches{/branch}","tags_url":"https://api.github.com/repos/csvn/vscode-lit-html/tags","blobs_url":"https://api.github.com/repos/csvn/vscode-lit-html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csvn/vscode-lit-html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csvn/vscode-lit-html/git/refs{/sha}","trees_url":"https://api.github.com/repos/csvn/vscode-lit-html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csvn/vscode-lit-html/statuses/{sha}","languages_url":"https://api.github.com/repos/csvn/vscode-lit-html/languages","stargazers_url":"https://api.github.com/repos/csvn/vscode-lit-html/stargazers","contributors_url":"https://api.github.com/repos/csvn/vscode-lit-html/contributors","subscribers_url":"https://api.github.com/repos/csvn/vscode-lit-html/subscribers","subscription_url":"https://api.github.com/repos/csvn/vscode-lit-html/subscription","commits_url":"https://api.github.com/repos/csvn/vscode-lit-html/commits{/sha}","git_commits_url":"https://api.github.com/repos/csvn/vscode-lit-html/git/commits{/sha}","comments_url":"https://api.github.com/repos/csvn/vscode-lit-html/comments{/number}","issue_comment_url":"https://api.github.com/repos/csvn/vscode-lit-html/issues/comments{/number}","contents_url":"https://api.github.com/repos/csvn/vscode-lit-html/contents/{+path}","compare_url":"https://api.github.com/repos/csvn/vscode-lit-html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csvn/vscode-lit-html/merges","archive_url":"https://api.github.com/repos/csvn/vscode-lit-html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csvn/vscode-lit-html/downloads","issues_url":"https://api.github.com/repos/csvn/vscode-lit-html/issues{/number}","pulls_url":"https://api.github.com/repos/csvn/vscode-lit-html/pulls{/number}","milestones_url":"https://api.github.com/repos/csvn/vscode-lit-html/milestones{/number}","notifications_url":"https://api.github.com/repos/csvn/vscode-lit-html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csvn/vscode-lit-html/labels{/name}","releases_url":"https://api.github.com/repos/csvn/vscode-lit-html/releases{/id}","deployments_url":"https://api.github.com/repos/csvn/vscode-lit-html/deployments","created_at":"2018-12-18T14:10:06Z","updated_at":"2018-12-18T14:10:08Z","pushed_at":"2018-12-19T22:28:20Z","git_url":"git://github.com/csvn/vscode-lit-html.git","ssh_url":"git@github.com:csvn/vscode-lit-html.git","clone_url":"https://github.com/csvn/vscode-lit-html.git","svn_url":"https://github.com/csvn/vscode-lit-html","homepage":"https://marketplace.visualstudio.com/items?itemName=bierner.lit-html","size":7782,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mjbvz:master","ref":"master","sha":"310d7ca827fc47dafcb1c79cdb3f4991fe28d15d","user":{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"repo":{"id":106485115,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0ODUxMTU=","name":"vscode-lit-html","full_name":"mjbvz/vscode-lit-html","private":false,"owner":{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mjbvz/vscode-lit-html","description":"Adds syntax highlighting for html inside of JavaScript and TypeScript tagged template strings","fork":false,"url":"https://api.github.com/repos/mjbvz/vscode-lit-html","forks_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/forks","keys_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/teams","hooks_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/hooks","issue_events_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/issues/events{/number}","events_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/events","assignees_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/assignees{/user}","branches_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/branches{/branch}","tags_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/tags","blobs_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/statuses/{sha}","languages_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/languages","stargazers_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/stargazers","contributors_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/contributors","subscribers_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/subscribers","subscription_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/subscription","commits_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/contents/{+path}","compare_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/merges","archive_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/downloads","issues_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/issues{/number}","pulls_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls{/number}","milestones_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/milestones{/number}","notifications_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/labels{/name}","releases_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/releases{/id}","deployments_url":"https://api.github.com/repos/mjbvz/vscode-lit-html/deployments","created_at":"2017-10-11T00:18:30Z","updated_at":"2018-12-14T01:33:22Z","pushed_at":"2018-12-19T22:28:21Z","git_url":"git://github.com/mjbvz/vscode-lit-html.git","ssh_url":"git@github.com:mjbvz/vscode-lit-html.git","clone_url":"https://github.com/mjbvz/vscode-lit-html.git","svn_url":"https://github.com/mjbvz/vscode-lit-html","homepage":"https://marketplace.visualstudio.com/items?itemName=bierner.lit-html","size":7809,"stargazers_count":166,"watchers_count":166,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":11,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/57"},"html":{"href":"https://github.com/mjbvz/vscode-lit-html/pull/57"},"issue":{"href":"https://api.github.com/repos/mjbvz/vscode-lit-html/issues/57"},"comments":{"href":"https://api.github.com/repos/mjbvz/vscode-lit-html/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mjbvz/vscode-lit-html/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/mjbvz/vscode-lit-html/statuses/49ce6a38a676c4f0f11d649022fdbac7717f9639"}},"author_association":"NONE"}}
{"actor":{"display_login":"mjbvz"}}