{"action":"closed","number":1684,"pull_request":{"url":"https://api.github.com/repos/lagom/lagom/pulls/1684","id":240409261,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNDA5MjYx","html_url":"https://github.com/lagom/lagom/pull/1684","diff_url":"https://github.com/lagom/lagom/pull/1684.diff","patch_url":"https://github.com/lagom/lagom/pull/1684.patch","issue_url":"https://api.github.com/repos/lagom/lagom/issues/1684","number":1684,"state":"closed","locked":false,"title":"removed metaspace limit","user":{"login":"renatocaval","id":502982,"node_id":"MDQ6VXNlcjUwMjk4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/502982?v=4","gravatar_id":"","url":"https://api.github.com/users/renatocaval","html_url":"https://github.com/renatocaval","followers_url":"https://api.github.com/users/renatocaval/followers","following_url":"https://api.github.com/users/renatocaval/following{/other_user}","gists_url":"https://api.github.com/users/renatocaval/gists{/gist_id}","starred_url":"https://api.github.com/users/renatocaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatocaval/subscriptions","organizations_url":"https://api.github.com/users/renatocaval/orgs","repos_url":"https://api.github.com/users/renatocaval/repos","events_url":"https://api.github.com/users/renatocaval/events{/privacy}","received_events_url":"https://api.github.com/users/renatocaval/received_events","type":"User","site_admin":false},"body":"We have observed Travis failures because: `java.lang.OutOfMemoryError: Metaspace`. \r\n\r\nInstead of increasing the metaspace, I would like to first remove it to see how the build will behave. \r\n\r\nOn the first commit of this file, we were using `MaxPermSize`, but `MaxMetaspaceSize` is not equivalent. As far as I know, if we set `MaxMetaspaceSize` we put an upper bound and we avoid swap. However, we never experimented to build without that limit as we simply switched from `MaxPermSize` to `MaxMetaspaceSize`.\r\n\r\nRefs: #1671 \r\n(cc @2m) ","created_at":"2018-12-21T08:55:23Z","updated_at":"2019-01-03T12:10:30Z","closed_at":"2019-01-03T12:10:30Z","merged_at":null,"merge_commit_sha":"1566307128e9c85856d81fadcd5813d39705954d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ignasi35","id":762126,"node_id":"MDQ6VXNlcjc2MjEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lagom/lagom/pulls/1684/commits","review_comments_url":"https://api.github.com/repos/lagom/lagom/pulls/1684/comments","review_comment_url":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lagom/lagom/issues/1684/comments","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/759c90378ec2ad3a434a985886f26536c495cd12","head":{"label":"renatocaval:travis-metaspace","ref":"travis-metaspace","sha":"759c90378ec2ad3a434a985886f26536c495cd12","user":{"login":"renatocaval","id":502982,"node_id":"MDQ6VXNlcjUwMjk4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/502982?v=4","gravatar_id":"","url":"https://api.github.com/users/renatocaval","html_url":"https://github.com/renatocaval","followers_url":"https://api.github.com/users/renatocaval/followers","following_url":"https://api.github.com/users/renatocaval/following{/other_user}","gists_url":"https://api.github.com/users/renatocaval/gists{/gist_id}","starred_url":"https://api.github.com/users/renatocaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatocaval/subscriptions","organizations_url":"https://api.github.com/users/renatocaval/orgs","repos_url":"https://api.github.com/users/renatocaval/repos","events_url":"https://api.github.com/users/renatocaval/events{/privacy}","received_events_url":"https://api.github.com/users/renatocaval/received_events","type":"User","site_admin":false},"repo":{"id":54745780,"node_id":"MDEwOlJlcG9zaXRvcnk1NDc0NTc4MA==","name":"lagom","full_name":"renatocaval/lagom","private":false,"owner":{"login":"renatocaval","id":502982,"node_id":"MDQ6VXNlcjUwMjk4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/502982?v=4","gravatar_id":"","url":"https://api.github.com/users/renatocaval","html_url":"https://github.com/renatocaval","followers_url":"https://api.github.com/users/renatocaval/followers","following_url":"https://api.github.com/users/renatocaval/following{/other_user}","gists_url":"https://api.github.com/users/renatocaval/gists{/gist_id}","starred_url":"https://api.github.com/users/renatocaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatocaval/subscriptions","organizations_url":"https://api.github.com/users/renatocaval/orgs","repos_url":"https://api.github.com/users/renatocaval/repos","events_url":"https://api.github.com/users/renatocaval/events{/privacy}","received_events_url":"https://api.github.com/users/renatocaval/received_events","type":"User","site_admin":false},"html_url":"https://github.com/renatocaval/lagom","description":"Reactive Microservices for the JVM","fork":true,"url":"https://api.github.com/repos/renatocaval/lagom","forks_url":"https://api.github.com/repos/renatocaval/lagom/forks","keys_url":"https://api.github.com/repos/renatocaval/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renatocaval/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renatocaval/lagom/teams","hooks_url":"https://api.github.com/repos/renatocaval/lagom/hooks","issue_events_url":"https://api.github.com/repos/renatocaval/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/renatocaval/lagom/events","assignees_url":"https://api.github.com/repos/renatocaval/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/renatocaval/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/renatocaval/lagom/tags","blobs_url":"https://api.github.com/repos/renatocaval/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renatocaval/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renatocaval/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/renatocaval/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renatocaval/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/renatocaval/lagom/languages","stargazers_url":"https://api.github.com/repos/renatocaval/lagom/stargazers","contributors_url":"https://api.github.com/repos/renatocaval/lagom/contributors","subscribers_url":"https://api.github.com/repos/renatocaval/lagom/subscribers","subscription_url":"https://api.github.com/repos/renatocaval/lagom/subscription","commits_url":"https://api.github.com/repos/renatocaval/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/renatocaval/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/renatocaval/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/renatocaval/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/renatocaval/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/renatocaval/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renatocaval/lagom/merges","archive_url":"https://api.github.com/repos/renatocaval/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renatocaval/lagom/downloads","issues_url":"https://api.github.com/repos/renatocaval/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/renatocaval/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/renatocaval/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/renatocaval/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renatocaval/lagom/labels{/name}","releases_url":"https://api.github.com/repos/renatocaval/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/renatocaval/lagom/deployments","created_at":"2016-03-25T20:29:03Z","updated_at":"2018-05-25T06:44:17Z","pushed_at":"2018-12-21T08:49:46Z","git_url":"git://github.com/renatocaval/lagom.git","ssh_url":"git@github.com:renatocaval/lagom.git","clone_url":"https://github.com/renatocaval/lagom.git","svn_url":"https://github.com/renatocaval/lagom","homepage":"https://lightbend.com/lagom","size":8681,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lagom:master","ref":"master","sha":"6dc90faf88ca25f4195aca75d3f22005a5cdfae9","user":{"login":"lagom","id":17168851,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTY4ODUx","avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"repo":{"id":52320967,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMyMDk2Nw==","name":"lagom","full_name":"lagom/lagom","private":false,"owner":{"login":"lagom","id":17168851,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTY4ODUx","avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lagom/lagom","description":"Reactive Microservices for the JVM","fork":false,"url":"https://api.github.com/repos/lagom/lagom","forks_url":"https://api.github.com/repos/lagom/lagom/forks","keys_url":"https://api.github.com/repos/lagom/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagom/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagom/lagom/teams","hooks_url":"https://api.github.com/repos/lagom/lagom/hooks","issue_events_url":"https://api.github.com/repos/lagom/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/lagom/lagom/events","assignees_url":"https://api.github.com/repos/lagom/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/lagom/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/lagom/lagom/tags","blobs_url":"https://api.github.com/repos/lagom/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagom/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagom/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagom/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/lagom/lagom/languages","stargazers_url":"https://api.github.com/repos/lagom/lagom/stargazers","contributors_url":"https://api.github.com/repos/lagom/lagom/contributors","subscribers_url":"https://api.github.com/repos/lagom/lagom/subscribers","subscription_url":"https://api.github.com/repos/lagom/lagom/subscription","commits_url":"https://api.github.com/repos/lagom/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagom/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagom/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagom/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagom/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/lagom/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagom/lagom/merges","archive_url":"https://api.github.com/repos/lagom/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagom/lagom/downloads","issues_url":"https://api.github.com/repos/lagom/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/lagom/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/lagom/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/lagom/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagom/lagom/labels{/name}","releases_url":"https://api.github.com/repos/lagom/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/lagom/lagom/deployments","created_at":"2016-02-23T01:51:06Z","updated_at":"2019-01-03T08:04:38Z","pushed_at":"2019-01-03T12:09:31Z","git_url":"git://github.com/lagom/lagom.git","ssh_url":"git@github.com:lagom/lagom.git","clone_url":"https://github.com/lagom/lagom.git","svn_url":"https://github.com/lagom/lagom","homepage":"https://www.lagomframework.com","size":8663,"stargazers_count":2061,"watchers_count":2061,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":478,"mirror_url":null,"archived":false,"open_issues_count":352,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":478,"open_issues":352,"watchers":2061,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1684"},"html":{"href":"https://github.com/lagom/lagom/pull/1684"},"issue":{"href":"https://api.github.com/repos/lagom/lagom/issues/1684"},"comments":{"href":"https://api.github.com/repos/lagom/lagom/issues/1684/comments"},"review_comments":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1684/comments"},"review_comment":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1684/commits"},"statuses":{"href":"https://api.github.com/repos/lagom/lagom/statuses/759c90378ec2ad3a434a985886f26536c495cd12"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"ignasi35"}}