{"action":"created","issue":{"url":"https://api.github.com/repos/batfish/batfish/issues/990","repository_url":"https://api.github.com/repos/batfish/batfish","labels_url":"https://api.github.com/repos/batfish/batfish/issues/990/labels{/name}","comments_url":"https://api.github.com/repos/batfish/batfish/issues/990/comments","events_url":"https://api.github.com/repos/batfish/batfish/issues/990/events","html_url":"https://github.com/batfish/batfish/pull/990","id":300364521,"number":990,"title":"Fixed NAT tests.","user":{"login":"anothermattbrown","id":15133240,"avatar_url":"https://avatars2.githubusercontent.com/u/15133240?v=4","gravatar_id":"","url":"https://api.github.com/users/anothermattbrown","html_url":"https://github.com/anothermattbrown","followers_url":"https://api.github.com/users/anothermattbrown/followers","following_url":"https://api.github.com/users/anothermattbrown/following{/other_user}","gists_url":"https://api.github.com/users/anothermattbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/anothermattbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anothermattbrown/subscriptions","organizations_url":"https://api.github.com/users/anothermattbrown/orgs","repos_url":"https://api.github.com/users/anothermattbrown/repos","events_url":"https://api.github.com/users/anothermattbrown/events{/privacy}","received_events_url":"https://api.github.com/users/anothermattbrown/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-02-26T19:26:10Z","updated_at":"2018-02-27T01:04:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/batfish/batfish/pulls/990","html_url":"https://github.com/batfish/batfish/pull/990","diff_url":"https://github.com/batfish/batfish/pull/990.diff","patch_url":"https://github.com/batfish/batfish/pull/990.patch"},"body":"- Generate rules to derive NAT Acl relations.\r\n- Make Query a BasicStateExpr\r\n- Transform the consequent of a TransformedBasicRuleStatement\r\n- Move sane and header constraints to origination state rather\r\n  than query state."},"comment":{"url":"https://api.github.com/repos/batfish/batfish/issues/comments/368709196","html_url":"https://github.com/batfish/batfish/pull/990#issuecomment-368709196","issue_url":"https://api.github.com/repos/batfish/batfish/issues/990","id":368709196,"user":{"login":"dhalperi","id":526415,"avatar_url":"https://avatars0.githubusercontent.com/u/526415?v=4","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T01:04:50Z","updated_at":"2018-02-27T01:04:50Z","author_association":"OWNER","body":"\n\n\n\n\n\n\n\n*[tests/basic/commands, line 83 at r3](https://beta.reviewable.io/reviews/batfish/batfish/990#-L6JmZHD5W-UtqR8Vk9J:-L6JmZHD5W-UtqR8Vk9K:b-3rztkg) ([raw file](https://github.com/batfish/batfish/blob/b01ec85796790b121bf9deeb4766e11ed9414960/tests/basic/commands#L83)):*\n> ```\n> test tests/basic/example-iptables-init.ref init-testrig test_rigs/example-iptables\n> test tests/basic/example-iptables-reachability.ref get reachability ingressNodeRegex=\"z1-.*\", dstIps=[\"10.0.4.20\",\"10.0.4.21\"], srcIps=[\"10.0.3.0/24\"], actions=[\"DROP\"]\n> # TODO fix notTransitNodes\n> ```\n\nlink to the github issue?\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/batfish/batfish/990)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"dhalperi"}}