{"action":"created","comment":{"url":"https://api.github.com/repos/irods/irods/pulls/comments/179932279","pull_request_review_id":110271485,"id":179932279,"diff_hunk":"@@ -727,7 +727,32 @@ dirPathReg( rsComm_t *rsComm, dataObjInp_t *phyPathRegInp, char *filePath,\n         fileStatInp_t fileStatInp;\n         memset( &fileStatInp, 0, sizeof( fileStatInp ) );\n \n-        snprintf( fileStatInp.fileName, MAX_NAME_LEN, \"%s/%s\", filePath, rodsDirent->d_name );\n+        // Issue #3658 - https://github.com/irods/irods/issues/3658\n+        //\n+        // TODO:  This is a localized fix that addresses any trailing slashes\n+        // in inPath. Any future refactoring of the code that deals with paths\n+        // would most probably take care of this issue, and the code segment\n+        // below would/should then be removed.\n+        //\n+        // This is the second part of a two part fix.  This section removes trailing","path":"server/api/src/rsPhyPathReg.cpp","position":12,"original_position":12,"commit_id":"fac17365e11f54fc7576e1547d901ca06b315ed4","original_commit_id":"fac17365e11f54fc7576e1547d901ca06b315ed4","user":{"login":"trel","id":55238,"avatar_url":"https://avatars3.githubusercontent.com/u/55238?v=4","gravatar_id":"","url":"https://api.github.com/users/trel","html_url":"https://github.com/trel","followers_url":"https://api.github.com/users/trel/followers","following_url":"https://api.github.com/users/trel/following{/other_user}","gists_url":"https://api.github.com/users/trel/gists{/gist_id}","starred_url":"https://api.github.com/users/trel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trel/subscriptions","organizations_url":"https://api.github.com/users/trel/orgs","repos_url":"https://api.github.com/users/trel/repos","events_url":"https://api.github.com/users/trel/events{/privacy}","received_events_url":"https://api.github.com/users/trel/received_events","type":"User","site_admin":false},"body":"reduce comment to just:\r\n`This section removes trailing slashes from the directory path in the server when the path is already in the catalog.`","created_at":"2018-04-08T01:30:43Z","updated_at":"2018-04-08T01:32:33Z","html_url":"https://github.com/irods/irods/pull/3870#discussion_r179932279","pull_request_url":"https://api.github.com/repos/irods/irods/pulls/3870","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/irods/irods/pulls/comments/179932279"},"html":{"href":"https://github.com/irods/irods/pull/3870#discussion_r179932279"},"pull_request":{"href":"https://api.github.com/repos/irods/irods/pulls/3870"}}},"pull_request":{"url":"https://api.github.com/repos/irods/irods/pulls/3870","id":179606784,"html_url":"https://github.com/irods/irods/pull/3870","diff_url":"https://github.com/irods/irods/pull/3870.diff","patch_url":"https://github.com/irods/irods/pull/3870.patch","issue_url":"https://api.github.com/repos/irods/irods/issues/3870","number":3870,"state":"open","locked":false,"title":"[#3658] ireg should trim trailing slash ","user":{"login":"andrew-irods","id":36961833,"avatar_url":"https://avatars0.githubusercontent.com/u/36961833?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-irods","html_url":"https://github.com/andrew-irods","followers_url":"https://api.github.com/users/andrew-irods/followers","following_url":"https://api.github.com/users/andrew-irods/following{/other_user}","gists_url":"https://api.github.com/users/andrew-irods/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-irods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-irods/subscriptions","organizations_url":"https://api.github.com/users/andrew-irods/orgs","repos_url":"https://api.github.com/users/andrew-irods/repos","events_url":"https://api.github.com/users/andrew-irods/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-irods/received_events","type":"User","site_admin":false},"body":"Resolves:\r\n\r\n#3658 irods/irods ireg should trim trailing slash\r\n\r\nIn lib/core/src/rodsPath.cpp (around line# 268), a check is made for trailing slashes in the physical directory path, and they are removed if they're there. (This is the code path for dealing with \"ireg -C ......\").\r\n\r\nIn server/api/src/rsPhyPathReg.cpp (line# around 730), a check is made by the server for trailing slashes in the physical directory path, and they are removed if they're there before a /filename is appended to that string. This takes care of physical directory paths associated with resources in the catalog pre-dating this fix.\r\n\r\nTest case:  test_ireg_double_slashes__issue_3658() in scripts/irods/test/test_ireg.py\r\n\r\nContinuous Integration:  Build 702 -  http://172.25.14.125:8080/view/2.%20Personal/job/irods-build-and-test-workflow/702/\r\n","created_at":"2018-04-05T08:38:12Z","updated_at":"2018-04-08T01:32:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cfe2b5e8e815128f34f9fd6a57c0eb099a3b4de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/irods/irods/pulls/3870/commits","review_comments_url":"https://api.github.com/repos/irods/irods/pulls/3870/comments","review_comment_url":"https://api.github.com/repos/irods/irods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/irods/irods/issues/3870/comments","statuses_url":"https://api.github.com/repos/irods/irods/statuses/fac17365e11f54fc7576e1547d901ca06b315ed4","head":{"label":"andrew-irods:4-2-stable","ref":"4-2-stable","sha":"fac17365e11f54fc7576e1547d901ca06b315ed4","user":{"login":"andrew-irods","id":36961833,"avatar_url":"https://avatars0.githubusercontent.com/u/36961833?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-irods","html_url":"https://github.com/andrew-irods","followers_url":"https://api.github.com/users/andrew-irods/followers","following_url":"https://api.github.com/users/andrew-irods/following{/other_user}","gists_url":"https://api.github.com/users/andrew-irods/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-irods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-irods/subscriptions","organizations_url":"https://api.github.com/users/andrew-irods/orgs","repos_url":"https://api.github.com/users/andrew-irods/repos","events_url":"https://api.github.com/users/andrew-irods/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-irods/received_events","type":"User","site_admin":false},"repo":{"id":126332264,"name":"irods","full_name":"andrew-irods/irods","owner":{"login":"andrew-irods","id":36961833,"avatar_url":"https://avatars0.githubusercontent.com/u/36961833?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-irods","html_url":"https://github.com/andrew-irods","followers_url":"https://api.github.com/users/andrew-irods/followers","following_url":"https://api.github.com/users/andrew-irods/following{/other_user}","gists_url":"https://api.github.com/users/andrew-irods/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-irods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-irods/subscriptions","organizations_url":"https://api.github.com/users/andrew-irods/orgs","repos_url":"https://api.github.com/users/andrew-irods/repos","events_url":"https://api.github.com/users/andrew-irods/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-irods/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrew-irods/irods","description":"Open Source Data Management Software","fork":true,"url":"https://api.github.com/repos/andrew-irods/irods","forks_url":"https://api.github.com/repos/andrew-irods/irods/forks","keys_url":"https://api.github.com/repos/andrew-irods/irods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrew-irods/irods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrew-irods/irods/teams","hooks_url":"https://api.github.com/repos/andrew-irods/irods/hooks","issue_events_url":"https://api.github.com/repos/andrew-irods/irods/issues/events{/number}","events_url":"https://api.github.com/repos/andrew-irods/irods/events","assignees_url":"https://api.github.com/repos/andrew-irods/irods/assignees{/user}","branches_url":"https://api.github.com/repos/andrew-irods/irods/branches{/branch}","tags_url":"https://api.github.com/repos/andrew-irods/irods/tags","blobs_url":"https://api.github.com/repos/andrew-irods/irods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrew-irods/irods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrew-irods/irods/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrew-irods/irods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrew-irods/irods/statuses/{sha}","languages_url":"https://api.github.com/repos/andrew-irods/irods/languages","stargazers_url":"https://api.github.com/repos/andrew-irods/irods/stargazers","contributors_url":"https://api.github.com/repos/andrew-irods/irods/contributors","subscribers_url":"https://api.github.com/repos/andrew-irods/irods/subscribers","subscription_url":"https://api.github.com/repos/andrew-irods/irods/subscription","commits_url":"https://api.github.com/repos/andrew-irods/irods/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrew-irods/irods/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrew-irods/irods/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrew-irods/irods/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrew-irods/irods/contents/{+path}","compare_url":"https://api.github.com/repos/andrew-irods/irods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrew-irods/irods/merges","archive_url":"https://api.github.com/repos/andrew-irods/irods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrew-irods/irods/downloads","issues_url":"https://api.github.com/repos/andrew-irods/irods/issues{/number}","pulls_url":"https://api.github.com/repos/andrew-irods/irods/pulls{/number}","milestones_url":"https://api.github.com/repos/andrew-irods/irods/milestones{/number}","notifications_url":"https://api.github.com/repos/andrew-irods/irods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrew-irods/irods/labels{/name}","releases_url":"https://api.github.com/repos/andrew-irods/irods/releases{/id}","deployments_url":"https://api.github.com/repos/andrew-irods/irods/deployments","created_at":"2018-03-22T12:31:27Z","updated_at":"2018-03-22T12:31:32Z","pushed_at":"2018-04-06T22:18:26Z","git_url":"git://github.com/andrew-irods/irods.git","ssh_url":"git@github.com:andrew-irods/irods.git","clone_url":"https://github.com/andrew-irods/irods.git","svn_url":"https://github.com/andrew-irods/irods","homepage":"https://irods.org","size":37061,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"irods:4-2-stable","ref":"4-2-stable","sha":"8fafad56abce19f6019dcf8a93be54049e4fd240","user":{"login":"irods","id":1790166,"avatar_url":"https://avatars0.githubusercontent.com/u/1790166?v=4","gravatar_id":"","url":"https://api.github.com/users/irods","html_url":"https://github.com/irods","followers_url":"https://api.github.com/users/irods/followers","following_url":"https://api.github.com/users/irods/following{/other_user}","gists_url":"https://api.github.com/users/irods/gists{/gist_id}","starred_url":"https://api.github.com/users/irods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irods/subscriptions","organizations_url":"https://api.github.com/users/irods/orgs","repos_url":"https://api.github.com/users/irods/repos","events_url":"https://api.github.com/users/irods/events{/privacy}","received_events_url":"https://api.github.com/users/irods/received_events","type":"Organization","site_admin":false},"repo":{"id":14724975,"name":"irods","full_name":"irods/irods","owner":{"login":"irods","id":1790166,"avatar_url":"https://avatars0.githubusercontent.com/u/1790166?v=4","gravatar_id":"","url":"https://api.github.com/users/irods","html_url":"https://github.com/irods","followers_url":"https://api.github.com/users/irods/followers","following_url":"https://api.github.com/users/irods/following{/other_user}","gists_url":"https://api.github.com/users/irods/gists{/gist_id}","starred_url":"https://api.github.com/users/irods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irods/subscriptions","organizations_url":"https://api.github.com/users/irods/orgs","repos_url":"https://api.github.com/users/irods/repos","events_url":"https://api.github.com/users/irods/events{/privacy}","received_events_url":"https://api.github.com/users/irods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/irods/irods","description":"Open Source Data Management Software","fork":false,"url":"https://api.github.com/repos/irods/irods","forks_url":"https://api.github.com/repos/irods/irods/forks","keys_url":"https://api.github.com/repos/irods/irods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irods/irods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irods/irods/teams","hooks_url":"https://api.github.com/repos/irods/irods/hooks","issue_events_url":"https://api.github.com/repos/irods/irods/issues/events{/number}","events_url":"https://api.github.com/repos/irods/irods/events","assignees_url":"https://api.github.com/repos/irods/irods/assignees{/user}","branches_url":"https://api.github.com/repos/irods/irods/branches{/branch}","tags_url":"https://api.github.com/repos/irods/irods/tags","blobs_url":"https://api.github.com/repos/irods/irods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irods/irods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irods/irods/git/refs{/sha}","trees_url":"https://api.github.com/repos/irods/irods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irods/irods/statuses/{sha}","languages_url":"https://api.github.com/repos/irods/irods/languages","stargazers_url":"https://api.github.com/repos/irods/irods/stargazers","contributors_url":"https://api.github.com/repos/irods/irods/contributors","subscribers_url":"https://api.github.com/repos/irods/irods/subscribers","subscription_url":"https://api.github.com/repos/irods/irods/subscription","commits_url":"https://api.github.com/repos/irods/irods/commits{/sha}","git_commits_url":"https://api.github.com/repos/irods/irods/git/commits{/sha}","comments_url":"https://api.github.com/repos/irods/irods/comments{/number}","issue_comment_url":"https://api.github.com/repos/irods/irods/issues/comments{/number}","contents_url":"https://api.github.com/repos/irods/irods/contents/{+path}","compare_url":"https://api.github.com/repos/irods/irods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irods/irods/merges","archive_url":"https://api.github.com/repos/irods/irods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irods/irods/downloads","issues_url":"https://api.github.com/repos/irods/irods/issues{/number}","pulls_url":"https://api.github.com/repos/irods/irods/pulls{/number}","milestones_url":"https://api.github.com/repos/irods/irods/milestones{/number}","notifications_url":"https://api.github.com/repos/irods/irods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irods/irods/labels{/name}","releases_url":"https://api.github.com/repos/irods/irods/releases{/id}","deployments_url":"https://api.github.com/repos/irods/irods/deployments","created_at":"2013-11-26T18:10:18Z","updated_at":"2018-04-04T20:18:56Z","pushed_at":"2018-04-06T22:18:26Z","git_url":"git://github.com/irods/irods.git","ssh_url":"git@github.com:irods/irods.git","clone_url":"https://github.com/irods/irods.git","svn_url":"https://github.com/irods/irods","homepage":"https://irods.org","size":37050,"stargazers_count":217,"watchers_count":217,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":518,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":69,"open_issues":518,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/irods/irods/pulls/3870"},"html":{"href":"https://github.com/irods/irods/pull/3870"},"issue":{"href":"https://api.github.com/repos/irods/irods/issues/3870"},"comments":{"href":"https://api.github.com/repos/irods/irods/issues/3870/comments"},"review_comments":{"href":"https://api.github.com/repos/irods/irods/pulls/3870/comments"},"review_comment":{"href":"https://api.github.com/repos/irods/irods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/irods/irods/pulls/3870/commits"},"statuses":{"href":"https://api.github.com/repos/irods/irods/statuses/fac17365e11f54fc7576e1547d901ca06b315ed4"}},"author_association":"NONE"}}
{"actor":{"display_login":"trel"}}