{"action":"closed","number":627,"pull_request":{"url":"https://api.github.com/repos/kiali/kiali/pulls/627","id":228413879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDEzODc5","html_url":"https://github.com/kiali/kiali/pull/627","diff_url":"https://github.com/kiali/kiali/pull/627.diff","patch_url":"https://github.com/kiali/kiali/pull/627.patch","issue_url":"https://api.github.com/repos/kiali/kiali/issues/627","number":627,"state":"closed","locked":false,"title":"KIALI-1819 Support generic handlers for Istio 1.1.x","user":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"This fix allows to support generic handlers introduced in Istio 1.1.x.\r\nInstead to use a specific type \"i.e. kind: prometheus\", in Istio 1.1.x there will be a \"kind: handler\".\r\n\r\nNote, this patch allows to support 1.0.x and 1.1.x in the same codebase.\r\nOn this scenario is possible.\r\n\r\nPotentially it can solve also https://issues.jboss.org/browse/KIALI-1579 but only on 1.1.x onwards.\r\n\r\n** Issue reference **\r\n\r\nhttps://issues.jboss.org/browse/KIALI-1819","created_at":"2018-11-05T16:34:27Z","updated_at":"2018-11-06T12:08:51Z","closed_at":"2018-11-06T12:08:51Z","merged_at":"2018-11-06T12:08:51Z","merge_commit_sha":"6e81e1d679aaa6d22e4055e1462c62ff9f3e2793","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali/pulls/627/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali/pulls/627/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali/issues/627/comments","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/110f7abf5fb0a88b88d1e1edd1046c8b7e224cce","head":{"label":"lucasponce:istio-1.1-fix-rules","ref":"istio-1.1-fix-rules","sha":"110f7abf5fb0a88b88d1e1edd1046c8b7e224cce","user":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"repo":{"id":120277582,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyNzc1ODI=","name":"kiali","full_name":"lucasponce/kiali","private":false,"owner":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lucasponce/kiali","description":null,"fork":true,"url":"https://api.github.com/repos/lucasponce/kiali","forks_url":"https://api.github.com/repos/lucasponce/kiali/forks","keys_url":"https://api.github.com/repos/lucasponce/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasponce/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasponce/kiali/teams","hooks_url":"https://api.github.com/repos/lucasponce/kiali/hooks","issue_events_url":"https://api.github.com/repos/lucasponce/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/lucasponce/kiali/events","assignees_url":"https://api.github.com/repos/lucasponce/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/lucasponce/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/lucasponce/kiali/tags","blobs_url":"https://api.github.com/repos/lucasponce/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasponce/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasponce/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasponce/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasponce/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasponce/kiali/languages","stargazers_url":"https://api.github.com/repos/lucasponce/kiali/stargazers","contributors_url":"https://api.github.com/repos/lucasponce/kiali/contributors","subscribers_url":"https://api.github.com/repos/lucasponce/kiali/subscribers","subscription_url":"https://api.github.com/repos/lucasponce/kiali/subscription","commits_url":"https://api.github.com/repos/lucasponce/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasponce/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasponce/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasponce/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasponce/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/lucasponce/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasponce/kiali/merges","archive_url":"https://api.github.com/repos/lucasponce/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasponce/kiali/downloads","issues_url":"https://api.github.com/repos/lucasponce/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/lucasponce/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasponce/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasponce/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasponce/kiali/labels{/name}","releases_url":"https://api.github.com/repos/lucasponce/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/lucasponce/kiali/deployments","created_at":"2018-02-05T08:42:11Z","updated_at":"2018-11-05T17:16:02Z","pushed_at":"2018-11-05T17:16:00Z","git_url":"git://github.com/lucasponce/kiali.git","ssh_url":"git@github.com:lucasponce/kiali.git","clone_url":"https://github.com/lucasponce/kiali.git","svn_url":"https://github.com/lucasponce/kiali","homepage":null,"size":16225,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"e81b0cf737ff9ff0433ac971532f885faa363b8d","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120181748,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAxODE3NDg=","name":"kiali","full_name":"kiali/kiali","private":false,"owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiali/kiali","description":"Kiali project, observability for the Istio service mesh","fork":false,"url":"https://api.github.com/repos/kiali/kiali","forks_url":"https://api.github.com/repos/kiali/kiali/forks","keys_url":"https://api.github.com/repos/kiali/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali/teams","hooks_url":"https://api.github.com/repos/kiali/kiali/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali/events","assignees_url":"https://api.github.com/repos/kiali/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali/tags","blobs_url":"https://api.github.com/repos/kiali/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali/subscription","commits_url":"https://api.github.com/repos/kiali/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali/merges","archive_url":"https://api.github.com/repos/kiali/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali/downloads","issues_url":"https://api.github.com/repos/kiali/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali/deployments","created_at":"2018-02-04T12:11:57Z","updated_at":"2018-11-06T06:50:39Z","pushed_at":"2018-11-06T12:08:51Z","git_url":"git://github.com/kiali/kiali.git","ssh_url":"git@github.com:kiali/kiali.git","clone_url":"https://github.com/kiali/kiali.git","svn_url":"https://github.com/kiali/kiali","homepage":"https://kiali.io","size":16189,"stargazers_count":462,"watchers_count":462,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":69,"open_issues":31,"watchers":462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/627"},"html":{"href":"https://github.com/kiali/kiali/pull/627"},"issue":{"href":"https://api.github.com/repos/kiali/kiali/issues/627"},"comments":{"href":"https://api.github.com/repos/kiali/kiali/issues/627/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali/pulls/627/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali/pulls/627/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali/statuses/110f7abf5fb0a88b88d1e1edd1046c8b7e224cce"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jotak","id":2153442,"node_id":"MDQ6VXNlcjIxNTM0NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2153442?v=4","gravatar_id":"","url":"https://api.github.com/users/jotak","html_url":"https://github.com/jotak","followers_url":"https://api.github.com/users/jotak/followers","following_url":"https://api.github.com/users/jotak/following{/other_user}","gists_url":"https://api.github.com/users/jotak/gists{/gist_id}","starred_url":"https://api.github.com/users/jotak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotak/subscriptions","organizations_url":"https://api.github.com/users/jotak/orgs","repos_url":"https://api.github.com/users/jotak/repos","events_url":"https://api.github.com/users/jotak/events{/privacy}","received_events_url":"https://api.github.com/users/jotak/received_events","type":"User","site_admin":false},"comments":4,"review_comments":5,"maintainer_can_modify":false,"commits":2,"additions":140,"deletions":14,"changed_files":6}}
{"actor":{"display_login":"jotak"}}