{"action":"created","comment":{"url":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/comments/178302389","pull_request_review_id":108261199,"id":178302389,"diff_hunk":"@@ -421,6 +433,24 @@ private void processEnd(\n         doEnd();\n     }\n \n+    private void processAbort(\n+            DirectBuffer buffer,\n+            int index,\n+            int length)\n+    {\n+        factory.correlations.remove(acceptCorrelationId);\n+        if (targetBeginIssued)\n+        {\n+            factory.writer.doAbort(target, targetId);\n+            cleanupConnectReply.run();\n+        }\n+        else\n+        {\n+            factory.writer.doAbort(acceptReply, replyStreamId);\n+        }\n+        releaseSlotIfNecessary();","path":"src/main/java/org/reaktivity/nukleus/http/internal/stream/ServerAcceptStream.java","position":75,"original_position":75,"commit_id":"eecd3e33b8316c370901bd18c28648e7890ebd01","original_commit_id":"eecd3e33b8316c370901bd18c28648e7890ebd01","user":{"login":"akrambek","id":1646641,"avatar_url":"https://avatars3.githubusercontent.com/u/1646641?v=4","gravatar_id":"","url":"https://api.github.com/users/akrambek","html_url":"https://github.com/akrambek","followers_url":"https://api.github.com/users/akrambek/followers","following_url":"https://api.github.com/users/akrambek/following{/other_user}","gists_url":"https://api.github.com/users/akrambek/gists{/gist_id}","starred_url":"https://api.github.com/users/akrambek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akrambek/subscriptions","organizations_url":"https://api.github.com/users/akrambek/orgs","repos_url":"https://api.github.com/users/akrambek/repos","events_url":"https://api.github.com/users/akrambek/events{/privacy}","received_events_url":"https://api.github.com/users/akrambek/received_events","type":"User","site_admin":false},"body":"> RESET connect reply (by calling cleanupConnectReply) if removed correlation is non-null\r\n\r\nI thought it should be `if removed correlation is NULL`","created_at":"2018-03-30T14:37:52Z","updated_at":"2018-03-30T14:37:57Z","html_url":"https://github.com/reaktivity/nukleus-http.java/pull/65#discussion_r178302389","pull_request_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/65","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/comments/178302389"},"html":{"href":"https://github.com/reaktivity/nukleus-http.java/pull/65#discussion_r178302389"},"pull_request":{"href":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/65"}},"in_reply_to_id":178230161},"pull_request":{"url":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/65","id":178173371,"html_url":"https://github.com/reaktivity/nukleus-http.java/pull/65","diff_url":"https://github.com/reaktivity/nukleus-http.java/pull/65.diff","patch_url":"https://github.com/reaktivity/nukleus-http.java/pull/65.patch","issue_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/issues/65","number":65,"state":"open","locked":false,"title":"Added missing abort handler to fix connection leak issue","user":{"login":"akrambek","id":1646641,"avatar_url":"https://avatars3.githubusercontent.com/u/1646641?v=4","gravatar_id":"","url":"https://api.github.com/users/akrambek","html_url":"https://github.com/akrambek","followers_url":"https://api.github.com/users/akrambek/followers","following_url":"https://api.github.com/users/akrambek/following{/other_user}","gists_url":"https://api.github.com/users/akrambek/gists{/gist_id}","starred_url":"https://api.github.com/users/akrambek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akrambek/subscriptions","organizations_url":"https://api.github.com/users/akrambek/orgs","repos_url":"https://api.github.com/users/akrambek/repos","events_url":"https://api.github.com/users/akrambek/events{/privacy}","received_events_url":"https://api.github.com/users/akrambek/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-28T21:45:52Z","updated_at":"2018-03-30T14:37:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af8b6848441a5e706e97444c3d4ff5ac8f483af5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/65/commits","review_comments_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/65/comments","review_comment_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/issues/65/comments","statuses_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/statuses/eecd3e33b8316c370901bd18c28648e7890ebd01","head":{"label":"akrambek:bug/hand_abort","ref":"bug/hand_abort","sha":"eecd3e33b8316c370901bd18c28648e7890ebd01","user":{"login":"akrambek","id":1646641,"avatar_url":"https://avatars3.githubusercontent.com/u/1646641?v=4","gravatar_id":"","url":"https://api.github.com/users/akrambek","html_url":"https://github.com/akrambek","followers_url":"https://api.github.com/users/akrambek/followers","following_url":"https://api.github.com/users/akrambek/following{/other_user}","gists_url":"https://api.github.com/users/akrambek/gists{/gist_id}","starred_url":"https://api.github.com/users/akrambek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akrambek/subscriptions","organizations_url":"https://api.github.com/users/akrambek/orgs","repos_url":"https://api.github.com/users/akrambek/repos","events_url":"https://api.github.com/users/akrambek/events{/privacy}","received_events_url":"https://api.github.com/users/akrambek/received_events","type":"User","site_admin":false},"repo":{"id":126667948,"name":"nukleus-http.java","full_name":"akrambek/nukleus-http.java","owner":{"login":"akrambek","id":1646641,"avatar_url":"https://avatars3.githubusercontent.com/u/1646641?v=4","gravatar_id":"","url":"https://api.github.com/users/akrambek","html_url":"https://github.com/akrambek","followers_url":"https://api.github.com/users/akrambek/followers","following_url":"https://api.github.com/users/akrambek/following{/other_user}","gists_url":"https://api.github.com/users/akrambek/gists{/gist_id}","starred_url":"https://api.github.com/users/akrambek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akrambek/subscriptions","organizations_url":"https://api.github.com/users/akrambek/orgs","repos_url":"https://api.github.com/users/akrambek/repos","events_url":"https://api.github.com/users/akrambek/events{/privacy}","received_events_url":"https://api.github.com/users/akrambek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akrambek/nukleus-http.java","description":"HTTP Nukleus Implementation","fork":true,"url":"https://api.github.com/repos/akrambek/nukleus-http.java","forks_url":"https://api.github.com/repos/akrambek/nukleus-http.java/forks","keys_url":"https://api.github.com/repos/akrambek/nukleus-http.java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akrambek/nukleus-http.java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akrambek/nukleus-http.java/teams","hooks_url":"https://api.github.com/repos/akrambek/nukleus-http.java/hooks","issue_events_url":"https://api.github.com/repos/akrambek/nukleus-http.java/issues/events{/number}","events_url":"https://api.github.com/repos/akrambek/nukleus-http.java/events","assignees_url":"https://api.github.com/repos/akrambek/nukleus-http.java/assignees{/user}","branches_url":"https://api.github.com/repos/akrambek/nukleus-http.java/branches{/branch}","tags_url":"https://api.github.com/repos/akrambek/nukleus-http.java/tags","blobs_url":"https://api.github.com/repos/akrambek/nukleus-http.java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akrambek/nukleus-http.java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akrambek/nukleus-http.java/git/refs{/sha}","trees_url":"https://api.github.com/repos/akrambek/nukleus-http.java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akrambek/nukleus-http.java/statuses/{sha}","languages_url":"https://api.github.com/repos/akrambek/nukleus-http.java/languages","stargazers_url":"https://api.github.com/repos/akrambek/nukleus-http.java/stargazers","contributors_url":"https://api.github.com/repos/akrambek/nukleus-http.java/contributors","subscribers_url":"https://api.github.com/repos/akrambek/nukleus-http.java/subscribers","subscription_url":"https://api.github.com/repos/akrambek/nukleus-http.java/subscription","commits_url":"https://api.github.com/repos/akrambek/nukleus-http.java/commits{/sha}","git_commits_url":"https://api.github.com/repos/akrambek/nukleus-http.java/git/commits{/sha}","comments_url":"https://api.github.com/repos/akrambek/nukleus-http.java/comments{/number}","issue_comment_url":"https://api.github.com/repos/akrambek/nukleus-http.java/issues/comments{/number}","contents_url":"https://api.github.com/repos/akrambek/nukleus-http.java/contents/{+path}","compare_url":"https://api.github.com/repos/akrambek/nukleus-http.java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akrambek/nukleus-http.java/merges","archive_url":"https://api.github.com/repos/akrambek/nukleus-http.java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akrambek/nukleus-http.java/downloads","issues_url":"https://api.github.com/repos/akrambek/nukleus-http.java/issues{/number}","pulls_url":"https://api.github.com/repos/akrambek/nukleus-http.java/pulls{/number}","milestones_url":"https://api.github.com/repos/akrambek/nukleus-http.java/milestones{/number}","notifications_url":"https://api.github.com/repos/akrambek/nukleus-http.java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akrambek/nukleus-http.java/labels{/name}","releases_url":"https://api.github.com/repos/akrambek/nukleus-http.java/releases{/id}","deployments_url":"https://api.github.com/repos/akrambek/nukleus-http.java/deployments","created_at":"2018-03-25T05:36:47Z","updated_at":"2018-03-25T05:36:49Z","pushed_at":"2018-03-29T22:56:00Z","git_url":"git://github.com/akrambek/nukleus-http.java.git","ssh_url":"git@github.com:akrambek/nukleus-http.java.git","clone_url":"https://github.com/akrambek/nukleus-http.java.git","svn_url":"https://github.com/akrambek/nukleus-http.java","homepage":null,"size":768,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"reaktivity:develop","ref":"develop","sha":"d21bc0d8a4fccdd9b765f562d40c8f82fac27381","user":{"login":"reaktivity","id":22941769,"avatar_url":"https://avatars0.githubusercontent.com/u/22941769?v=4","gravatar_id":"","url":"https://api.github.com/users/reaktivity","html_url":"https://github.com/reaktivity","followers_url":"https://api.github.com/users/reaktivity/followers","following_url":"https://api.github.com/users/reaktivity/following{/other_user}","gists_url":"https://api.github.com/users/reaktivity/gists{/gist_id}","starred_url":"https://api.github.com/users/reaktivity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaktivity/subscriptions","organizations_url":"https://api.github.com/users/reaktivity/orgs","repos_url":"https://api.github.com/users/reaktivity/repos","events_url":"https://api.github.com/users/reaktivity/events{/privacy}","received_events_url":"https://api.github.com/users/reaktivity/received_events","type":"Organization","site_admin":false},"repo":{"id":78046432,"name":"nukleus-http.java","full_name":"reaktivity/nukleus-http.java","owner":{"login":"reaktivity","id":22941769,"avatar_url":"https://avatars0.githubusercontent.com/u/22941769?v=4","gravatar_id":"","url":"https://api.github.com/users/reaktivity","html_url":"https://github.com/reaktivity","followers_url":"https://api.github.com/users/reaktivity/followers","following_url":"https://api.github.com/users/reaktivity/following{/other_user}","gists_url":"https://api.github.com/users/reaktivity/gists{/gist_id}","starred_url":"https://api.github.com/users/reaktivity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaktivity/subscriptions","organizations_url":"https://api.github.com/users/reaktivity/orgs","repos_url":"https://api.github.com/users/reaktivity/repos","events_url":"https://api.github.com/users/reaktivity/events{/privacy}","received_events_url":"https://api.github.com/users/reaktivity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reaktivity/nukleus-http.java","description":"HTTP Nukleus Implementation","fork":false,"url":"https://api.github.com/repos/reaktivity/nukleus-http.java","forks_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/forks","keys_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/teams","hooks_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/hooks","issue_events_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/issues/events{/number}","events_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/events","assignees_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/assignees{/user}","branches_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/branches{/branch}","tags_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/tags","blobs_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/git/refs{/sha}","trees_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/statuses/{sha}","languages_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/languages","stargazers_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/stargazers","contributors_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/contributors","subscribers_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/subscribers","subscription_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/subscription","commits_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/commits{/sha}","git_commits_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/git/commits{/sha}","comments_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/comments{/number}","issue_comment_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/issues/comments{/number}","contents_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/contents/{+path}","compare_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/merges","archive_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/downloads","issues_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/issues{/number}","pulls_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls{/number}","milestones_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/milestones{/number}","notifications_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/labels{/name}","releases_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/releases{/id}","deployments_url":"https://api.github.com/repos/reaktivity/nukleus-http.java/deployments","created_at":"2017-01-04T19:32:30Z","updated_at":"2018-03-27T22:12:58Z","pushed_at":"2018-03-29T22:56:01Z","git_url":"git://github.com/reaktivity/nukleus-http.java.git","ssh_url":"git@github.com:reaktivity/nukleus-http.java.git","clone_url":"https://github.com/reaktivity/nukleus-http.java.git","svn_url":"https://github.com/reaktivity/nukleus-http.java","homepage":null,"size":752,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6,"open_issues":13,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/65"},"html":{"href":"https://github.com/reaktivity/nukleus-http.java/pull/65"},"issue":{"href":"https://api.github.com/repos/reaktivity/nukleus-http.java/issues/65"},"comments":{"href":"https://api.github.com/repos/reaktivity/nukleus-http.java/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reaktivity/nukleus-http.java/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/reaktivity/nukleus-http.java/statuses/eecd3e33b8316c370901bd18c28648e7890ebd01"}},"author_association":"NONE"}}
{"actor":{"display_login":"akrambek"}}