{"action":"opened","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/13862","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/13862/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/13862/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/13862/events","html_url":"https://github.com/brave/browser-laptop/issues/13862","id":315701427,"number":13862,"title":"Manual test run on OS X for 0.22.x w/ Chromium 66","user":{"login":"kjozwiak","id":2602313,"avatar_url":"https://avatars0.githubusercontent.com/u/2602313?v=4","gravatar_id":"","url":"https://api.github.com/users/kjozwiak","html_url":"https://github.com/kjozwiak","followers_url":"https://api.github.com/users/kjozwiak/followers","following_url":"https://api.github.com/users/kjozwiak/following{/other_user}","gists_url":"https://api.github.com/users/kjozwiak/gists{/gist_id}","starred_url":"https://api.github.com/users/kjozwiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjozwiak/subscriptions","organizations_url":"https://api.github.com/users/kjozwiak/orgs","repos_url":"https://api.github.com/users/kjozwiak/repos","events_url":"https://api.github.com/users/kjozwiak/events{/privacy}","received_events_url":"https://api.github.com/users/kjozwiak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"LaurenWags","id":28145373,"avatar_url":"https://avatars1.githubusercontent.com/u/28145373?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurenWags","html_url":"https://github.com/LaurenWags","followers_url":"https://api.github.com/users/LaurenWags/followers","following_url":"https://api.github.com/users/LaurenWags/following{/other_user}","gists_url":"https://api.github.com/users/LaurenWags/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurenWags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurenWags/subscriptions","organizations_url":"https://api.github.com/users/LaurenWags/orgs","repos_url":"https://api.github.com/users/LaurenWags/repos","events_url":"https://api.github.com/users/LaurenWags/events{/privacy}","received_events_url":"https://api.github.com/users/LaurenWags/received_events","type":"User","site_admin":false},"assignees":[{"login":"LaurenWags","id":28145373,"avatar_url":"https://avatars1.githubusercontent.com/u/28145373?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurenWags","html_url":"https://github.com/LaurenWags","followers_url":"https://api.github.com/users/LaurenWags/followers","following_url":"https://api.github.com/users/LaurenWags/following{/other_user}","gists_url":"https://api.github.com/users/LaurenWags/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurenWags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurenWags/subscriptions","organizations_url":"https://api.github.com/users/LaurenWags/orgs","repos_url":"https://api.github.com/users/LaurenWags/repos","events_url":"https://api.github.com/users/LaurenWags/events{/privacy}","received_events_url":"https://api.github.com/users/LaurenWags/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/111","html_url":"https://github.com/brave/browser-laptop/milestone/111","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/111/labels","id":3262058,"number":111,"title":"0.22.x w/ Chromium 66","description":"","creator":{"login":"LaurenWags","id":28145373,"avatar_url":"https://avatars1.githubusercontent.com/u/28145373?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurenWags","html_url":"https://github.com/LaurenWags","followers_url":"https://api.github.com/users/LaurenWags/followers","following_url":"https://api.github.com/users/LaurenWags/following{/other_user}","gists_url":"https://api.github.com/users/LaurenWags/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurenWags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurenWags/subscriptions","organizations_url":"https://api.github.com/users/LaurenWags/orgs","repos_url":"https://api.github.com/users/LaurenWags/repos","events_url":"https://api.github.com/users/LaurenWags/events{/privacy}","received_events_url":"https://api.github.com/users/LaurenWags/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":11,"state":"open","created_at":"2018-04-12T13:06:53Z","updated_at":"2018-04-19T02:03:38Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-04-19T02:03:37Z","updated_at":"2018-04-19T02:03:37Z","closed_at":null,"author_association":"MEMBER","body":"## Per release specialty tests\n - [ ] Chrome://crashes says crash reporting is disabled when it is not. ([#13842](https://github.com/brave/browser-laptop/issues/13842))\n - [ ] Unable to view PDFs on c66 with clean profile. ([#13840](https://github.com/brave/browser-laptop/issues/13840))\n - [ ] Cannot enable extensions. ([#13838](https://github.com/brave/browser-laptop/issues/13838))\n - [ ] Netflix does not work on c66 with clean profile. ([#13837](https://github.com/brave/browser-laptop/issues/13837))\n - [ ] Time reporting for twitch isn't accurate. ([#13828](https://github.com/brave/browser-laptop/issues/13828))\n - [ ] C66 build crashes on launch. ([#13814](https://github.com/brave/browser-laptop/issues/13814))\n\n## Installer\n\n- [ ] Check that installer is close to the size of last release\n- [ ] Check signature: If OS Run `spctl --assess --verbose /Applications/Brave.app/` and make sure it returns `accepted`.  If Windows right click on the installer exe and go to Properties, go to the Digital Signatures tab and double click on the signature.  Make sure it says \"The digital signature is OK\" in the popup window\n- [ ] Check Brave, muon, and libchromiumcontent version in `about:brave` and make sure it is EXACTLY as expected\n\n## Data\n\n- [ ] Make sure that data from the last version appears in the new version OK\n- [ ] With data from the last version, test that\n  - [ ] cookies are preserved\n  - [ ] pinned tabs can be opened\n  - [ ] pinned tabs can be unpinned\n  - [ ] unpinned tabs can be re-pinned\n  - [ ] opened tabs can be reloaded\n  - [ ] bookmarks on the bookmark toolbar can be opened\n  - [ ] bookmarks in the bookmark folder toolbar can be opened\n\n## Last changeset test\n\n- [ ] Test what is covered by the last changeset (you can find this by clicking on the SHA in about:brave)\n\n## Widevine/Netflix test\n\n- [ ] Test that you can log into Netflix and start a show\n\n## Ledger\n\n- [ ] Verify wallet is auto created after enabling payments\n- [ ] Verify monthly budget and account balance shows correct BAT and USD value\n- [ ] Click on `add funds` and click on each currency and verify it shows wallet address and QR Code\n- [ ] Verify that Brave BAT wallet address can be copied\n- [ ] Verify adding funds via any of the currencies flows into BAT Wallet after specified amount of time\n- [ ] Verify adding funds to an existing wallet with amount, adjusts the BAT value appropriately\n- [ ] Change min visit and min time in advance setting and verify if the publisher list gets updated based on new setting\n- [ ] Visit nytimes.com for a few seconds and make sure it shows up in the Payments table\n- [ ] Check that disabling payments and enabling them again does not lose state\n- [ ] Upgrade from older version\n  - [ ] Verify the wallet overlay is shown when wallet transition is happening upon upgrade\n  - [ ] Verify transition overlay is shown post upgrade even if the payment is disabled before upgrade\n  - [ ] Verify publishers list is not lost after upgrade when payment is disabled in the older version\n### Ledger Media\n  - [ ] Visit any YouTube video in a normal/session tab and ensure the video publisher name is listed in ledger table\n  - [ ] Visit any YouTube video in a private tab and ensure the video publisher name is not listed in ledger table\n  - [ ] Visit any live YouTube video and ensure the time spent is shown under ledger table\n  - [ ] Visit any embeded YouTube video and ensure the video publisher name is listed in ledger table\n  - [ ] Ensure total time spent is correctly calculated for each publisher video\n  - [ ] Ensure total time spent is correctly calculated when switching to YouTube video from an embeded video\n  - [ ] Ensure YouTube publishers are not listed when `Allow contributions to video` is disabled in adavanced settings\n  - [ ] Ensure existing YouTube publishers are not lost when `Allow contributions to video` is disabled in adavanced settings\n  - [ ] Ensure YouTube publishers is listed but not included when `auto-include` is disabled\n  - [ ] Update Advanced settings to different time/visit value and ensure YouTube videos are added to ledger table once criteria is met\n\n## Sync\n\n- [ ] Verify you are able to sync two devices using the secret code\n- [ ] Visit a site on device 1 and change shield setting, ensure that the saved site preference is synced to device 2\n- [ ] Enable Browsing history sync on device 1, ensure the history is shown on device 2\n- [ ] Clear browsing history on device 1, ensure the history is sync back on device 1 from device 2\n- [ ] Import/Add bookmarks on device 1, ensure it is synced on device 2\n- [ ] Ensure imported bookmark folder structure is maintained on device 2\n- [ ] Ensure bookmark favicons are shown after sync\n\n## About pages\n\n- [ ] Test that about:adblock loads\n- [ ] Test that about:autofill loads\n- [ ] Test that about:bookmarks loads bookmarks\n- [ ] Test that about:downloads loads downloads\n- [ ] Test that about:extensions loads\n- [ ] Test that about:history loads history\n- [ ] Test that about:passwords loads\n- [ ] Test that about:styles loads\n- [ ] Test that about:welcome loads\n- [ ] Test that about:preferences changing a preference takes effect right away\n- [ ] Test that about:preferences language change takes effect on re-start\n\n## Bookmarks\n\n- [ ] Test that creating a bookmark on the bookmarks toolbar with the star button works\n- [ ] Test that creating a bookmark on the bookmarks toolbar by dragging the un/lock icon works\n- [ ] Test that creating a bookmark folder on the bookmarks toolbar works\n- [ ] Test that moving a bookmark into a folder by drag and drop on the bookmarks folder works\n- [ ] Test that clicking a bookmark in the toolbar loads the bookmark.\n- [ ] Test that clicking a bookmark in a bookmark toolbar folder loads the bookmark.\n- [ ] Test that a bookmark on the bookmark toolbar can be removed via context menu\n- [ ] Test that a bookmark in a bookmark folder on the bookmark toolbar can be removed via context menu\n- [ ] Test that a bookmark subfolder can be removed via context menu\n- [ ] Test that a bookmark folder on the bookmark toolbar can be removed via context menu\n\n## Context menus\n\n- [ ] Make sure context menu items in the URL bar work\n- [ ] Make sure context menu items on content work with no selected text\n- [ ] Make sure context menu items on content work with selected text\n- [ ] Make sure context menu items on content work inside an editable control on `about:styles` (input, textarea, or contenteditable)\n\n## Find on page\n\n- [ ] Ensure search box is shown with shortcut\n- [ ] Test successful find\n- [ ] Test forward and backward find navigation\n- [ ] Test failed find shows 0 results\n- [ ] Test match case find\n\n## Keyboard Shortcuts\n\n- [ ] Open a new window: `Command` + `n` (macOS) || `Ctrl` + `n` (Win/Linux)\n- [ ] Open a new tab: `Command` + `t` (macOS) || `Ctrl` + `t` (Win/Linux)\n- [ ] Open a new private tab: `Command` + `Shift` + `p` (macOS) || `Ctrl` + `Shift` + `p` (Win/Linux)\n- [ ] Reopen the latest closed tab: `Command` + `Shift` + `t` (macOS) || `Ctrl` + `Shift` + `t` (Win/Linux)\n- [ ] Jump to the next tab: `Command` + `Option` + `->` (macOS) || `Ctrl` + `PgDn` (Win/Linux)\n- [ ] Jump to the previous tab: `Command` + `Option` + `<-` (macOS) || `Ctrl` + `PgUp` (Win/Linux)\n- [ ] Jump to the next tab: `Ctrl` + `Tab` (macOS/Win/Linux)\n- [ ] Jump to the previous tab: `Ctrl` + `Shift` + `Tab` (macOS/Win/Linux)\n- [ ] Open Brave preferences: `Command` + `,` (macOS) || `Ctrl` + `,` (Win/Linux)\n- [ ] Jump into the URL bar: `Command` + `l` (macOS) || `Ctrl` + `l` (Win/Linux)\n- [ ] Reload page: `Command` + `r` (macOS) || `Ctrl` + `r` (Win/Linux)\n- [ ] Select All: `Command` + `a` (macOS) || `Ctrl` + `a` (Win/Linux)\n- [ ] Copying text: `Command` + `c` (macOS) || `Ctrl` + `c` (Win/Linux)\n- [ ] Pasting text: `Command` + `v` (macOS) || `Ctrl` + `v` (Win/Linux)\n- [ ] Minimize Brave: `Command` + `m` (macOS) || `Ctrl` + `m` (Win/Linux)\n- [ ] Quit Brave: `Command` + `q` (macOS) || `Ctrl` + `q` (Win/Linux)\n\n## Geolocation\n\n- [ ] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation is blocked due to cross-origin iframes\n- [ ] Check that https://browserleaks.com/geo works and shows correct location\n- [ ] Check that https://html5demos.com/geo/ works but doesn't require an accurate location\n\n## Crash Reporting\n\n- [ ] Check that loading `chrome://crash` causes the new tab to crash \n- [ ] Check that `chrome://crashes` lists all the crashes and includes both Crash Report ID & Local Crash ID\n- [ ] Verify the crash ID matches the report on brave stats\n\n## Site hacks\n\n- [ ] Test https://www.twitch.tv/adobe sub-page loads a video and you can play it\n\n## Downloads\n\n- [ ] Test downloading a file works and that all actions on the download item works\n\n## Fullscreen\n\n- [ ] Test that entering full screen window works View -> Toggle Full Screen. And exit back (Not Esc)\n- [ ] Test that entering HTML5 full screen works. And Esc to go back. (youtube.com)\n\n## Tabs, Pinning and Tear off tabs\n\n- [ ] Test that tabs are pinnable\n- [ ] Test that tabs are unpinnable\n- [ ] Test that tabs are draggable to same tabset\n- [ ] Test that tabs are draggable to alternate tabset\n- [ ] Test that tabs can be teared off into a new window\n- [ ] Test that you are able to reattach a tab that is teared off into a new window\n- [ ] Test that tab pages can be closed\n- [ ] Test that tab pages can be muted\n- [ ] Test that tabs can be cloned\n\n## Zoom\n\n- [ ] Test zoom in / out shortcut works\n- [ ] Test hamburger menu zooms\n- [ ] Test zoom saved when you close the browser and restore on a single site\n- [ ] Test zoom saved when you navigate within a single origin site\n- [ ] Test that navigating to a different origin resets the zoom\n\n## Bravery settings\n\n- [ ] Check that HTTPS Everywhere works by loading https://https-everywhere.badssl.com/\n- [ ] Turning HTTPS Everywhere off and shields off both disable the redirect to https://https-everywhere.badssl.com/\n- [ ] Check that ad replacement works on http://slashdot.org\n- [ ] Check that toggling to blocking and allow ads works as expected\n- [ ] Test that clicking through a cert error in https://badssl.com/ works\n- [ ] Test that Safe Browsing works (https://www.raisegame.com/)\n- [ ] Turning Safe Browsing off and shields off both disable safe browsing for https://www.raisegame.com/\n- [ ] Visit https://brianbondy.com/ and then turn on script blocking, nothing should load. Allow it from the script blocking UI in the URL bar and it should work\n- [ ] Test that about:preferences default Bravery settings take effect on pages with no site settings\n- [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/9/ when 3rd party cookies are blocked and not blank when 3rd party cookies are unblocked\n### Fingerprint Tests\n  - [ ] Visit https://jsfiddle.net/bkf50r8v/13/, ensure 3 blocked items are listed in shields. Result window should show `got canvas fingerprint 0`  and  `got webgl fingerprint 00`\n  - [ ] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ only when `Block all fingerprinting protection` is on\n  - [ ] Test that Brave browser isn't detected on https://extensions.inrialpes.fr/brave/\n  - [ ] Test that https://diafygi.github.io/webrtc-ips/ doesn't leak IP address when `Block all fingerprinting protection` is on\n\n## Content tests\n\n- [ ] Go to https://brianbondy.com/ and click on the twitter icon on the top right. Test that context menus work in the new twitter tab\n- [ ] Load twitter and click on a tweet so the popup div shows.   Click to dismiss and repeat with another div. Make sure it shows\n- [ ] Go to https://www.bennish.net/web-notifications.html and test that clicking on 'Show' pops up a notification asking for permission. Make sure that clicking 'Deny' leads to no notifications being shown\n- [ ] Go to https://trac.torproject.org/projects/tor/login and make sure that the password can be saved. Make sure the saved password shows up in `about:passwords`. Then reload https://trac.torproject.org/projects/tor/login and make sure the saved credentials aren't autofilled instead shows saved id as a dropdown under the login field\n- [ ] Open `about:styles` and type some misspellings on a textbox, make sure they are underlined.\n- [ ] Make sure that right clicking on a word with suggestions gives a suggestion and that clicking on the suggestion replaces the text\n- [ ] Make sure that Command + Click (Control + Click on Windows, Control + Click on Ubuntu) on a link opens a new tab but does NOT switch to it.  Click on it and make sure it is already loaded\n- [ ] Open an email on http://mail.google.com/ or inbox.google.com and click on a link. Make sure it works\n- [ ] Test that PDF is loaded over https at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf\n- [ ] Test that PDF is loaded over http at http://www.pdf995.com/samples/pdf.pdf\n- [ ] Test that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run).\n- [ ] Test that hovering the cursor over a link changes the cursor into a pointer (hand)\n\n\n## Flash tests\n\n- [ ] Test that flash placeholder appears on http://www.homestarrunner.com\n- [ ] Test with flash enabled in preferences, auto play option is shown when visiting http://www.homestarrunner.com\n\n## Autofill tests\n\n- [ ] Test that autofill works on http://www.roboform.com/filling-test-all-fields\n\n## Session storage\n\nDo not forget to make a backup of your entire `~/Library/Application\\ Support/Brave` folder.\n\n- [ ] Temporarily move away your `~/Library/Application\\ Support/Brave/session-store-1` and test that clean session storage works. (`%appdata%\\Brave` in Windows, `./config/brave` in Ubuntu)\n- [ ] Test that windows and tabs restore when closed, including active tab.\n- [ ] Move away your entire `~/Library/Application\\ Support/Brave` folder (`%appdata%\\Brave` in Windows, `./config/brave` in Ubuntu)\n\n## Cookie and Cache\n\n- [ ] Make a backup of your profile, turn on all clearing in preferences and shut down.  Make sure when you bring the browser back up everything is gone that is specified.\n- [ ] Go to http://samy.pl/evercookie/ and set an evercookie. Check that going to prefs, clearing site data and cache, and going back to the Evercookie site does not remember the old evercookie value.\n\n## Update tests\n\n- [ ] Test that updating using `BRAVE_UPDATE_VERSION=0.8.3` env variable works correctly.\n- [ ] Test that using `BRAVE_ENABLE_PREVIEW_UPDATES=TRUE` env variable works and prompts for preview build updates.\n"}}
{"actor":{"display_login":"kjozwiak"}}