{"action":"created","issue":{"url":"https://api.github.com/repos/zeromq/libzmq/issues/3070","repository_url":"https://api.github.com/repos/zeromq/libzmq","labels_url":"https://api.github.com/repos/zeromq/libzmq/issues/3070/labels{/name}","comments_url":"https://api.github.com/repos/zeromq/libzmq/issues/3070/comments","events_url":"https://api.github.com/repos/zeromq/libzmq/issues/3070/events","html_url":"https://github.com/zeromq/libzmq/pull/3070","id":318930006,"number":3070,"title":"Problem: address parsing code is tied to the TCP code","user":{"login":"simias","id":7925386,"avatar_url":"https://avatars0.githubusercontent.com/u/7925386?v=4","gravatar_id":"","url":"https://api.github.com/users/simias","html_url":"https://github.com/simias","followers_url":"https://api.github.com/users/simias/followers","following_url":"https://api.github.com/users/simias/following{/other_user}","gists_url":"https://api.github.com/users/simias/gists{/gist_id}","starred_url":"https://api.github.com/users/simias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simias/subscriptions","organizations_url":"https://api.github.com/users/simias/orgs","repos_url":"https://api.github.com/users/simias/repos","events_url":"https://api.github.com/users/simias/events{/privacy}","received_events_url":"https://api.github.com/users/simias/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-30T15:22:52Z","updated_at":"2018-04-30T15:55:53Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/zeromq/libzmq/pulls/3070","html_url":"https://github.com/zeromq/libzmq/pull/3070","diff_url":"https://github.com/zeromq/libzmq/pull/3070.diff","patch_url":"https://github.com/zeromq/libzmq/pull/3070.patch"},"body":"Solution: Factor the code into a different file with a well defined API and add\r\nunit tests.\r\n\r\nMy Debian doesn't have a recent-enough `clang-format` to run `make clang-format-check` so apologies in advance if I messed up the coding style here and there (which is almost certain given the size of the patch).\r\n\r\nI've attempted to match the previous implementation perfectly, including the arguable \"quirks\" such as the ones I've reported in #3069 (and a few others that I'm not sure about, such as specifying a %scope for an IPv4 address).\r\n\r\nThis is a pretty huge patch so I tried to be very comprehensive in the unit tests. I think the only path of the code that's not tested is when specifying an interface name as a bind point since the implementations to find the IP address associated with a network interface vary wildly from platform to platform so it's not trivial to come up with generic test code. I've tested manually that it still worked on Linux at least and I haven't made significant modifications to the architecture-specific code so I have good hopes that I haven't irremediably broken it."},"comment":{"url":"https://api.github.com/repos/zeromq/libzmq/issues/comments/385442775","html_url":"https://github.com/zeromq/libzmq/pull/3070#issuecomment-385442775","issue_url":"https://api.github.com/repos/zeromq/libzmq/issues/3070","id":385442775,"user":{"login":"bluca","id":782193,"avatar_url":"https://avatars3.githubusercontent.com/u/782193?v=4","gravatar_id":"","url":"https://api.github.com/users/bluca","html_url":"https://github.com/bluca","followers_url":"https://api.github.com/users/bluca/followers","following_url":"https://api.github.com/users/bluca/following{/other_user}","gists_url":"https://api.github.com/users/bluca/gists{/gist_id}","starred_url":"https://api.github.com/users/bluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluca/subscriptions","organizations_url":"https://api.github.com/users/bluca/orgs","repos_url":"https://api.github.com/users/bluca/repos","events_url":"https://api.github.com/users/bluca/events{/privacy}","received_events_url":"https://api.github.com/users/bluca/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T15:55:53Z","updated_at":"2018-04-30T15:55:53Z","author_association":"OWNER","body":"Please squash them, given they are fixing the first commit\r\n\r\nHave you tried adding the ```__THROW``` to the mock as well?"}}
{"actor":{"display_login":"bluca"}}