{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/plutus/issues/214","repository_url":"https://api.github.com/repos/input-output-hk/plutus","labels_url":"https://api.github.com/repos/input-output-hk/plutus/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/plutus/issues/214/comments","events_url":"https://api.github.com/repos/input-output-hk/plutus/issues/214/events","html_url":"https://github.com/input-output-hk/plutus/pull/214","id":372942752,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTk0NzE3","number":214,"title":"Http client","user":{"login":"shmish111","id":934267,"node_id":"MDQ6VXNlcjkzNDI2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/934267?v=4","gravatar_id":"","url":"https://api.github.com/users/shmish111","html_url":"https://github.com/shmish111","followers_url":"https://api.github.com/users/shmish111/followers","following_url":"https://api.github.com/users/shmish111/following{/other_user}","gists_url":"https://api.github.com/users/shmish111/gists{/gist_id}","starred_url":"https://api.github.com/users/shmish111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmish111/subscriptions","organizations_url":"https://api.github.com/users/shmish111/orgs","repos_url":"https://api.github.com/users/shmish111/repos","events_url":"https://api.github.com/users/shmish111/events{/privacy}","received_events_url":"https://api.github.com/users/shmish111/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-10-23T11:09:19Z","updated_at":"2018-10-24T11:54:47Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/input-output-hk/plutus/pulls/214","html_url":"https://github.com/input-output-hk/plutus/pull/214","diff_url":"https://github.com/input-output-hk/plutus/pull/214.diff","patch_url":"https://github.com/input-output-hk/plutus/pull/214.patch"},"body":"There are 2 parts to this PR (in 2 commits)\r\n\r\n1. Clean up the HTTP server so that it reuses the existing machinery from `Trace`\r\n2. Create an HTTP client for all the endpoints\r\n\r\nI am actually unsure where to go from here. The client can't fit into `Trace` since that contains `EmulatedWalletApi` which is a wrapper around `StateT WalletState`. Basically I'm unsure how or where we now use this client?\r\n\r\nAnyway, that would be the remit of another PR, I don't think it should stop this PR being merged."},"comment":{"url":"https://api.github.com/repos/input-output-hk/plutus/issues/comments/432625327","html_url":"https://github.com/input-output-hk/plutus/pull/214#issuecomment-432625327","issue_url":"https://api.github.com/repos/input-output-hk/plutus/issues/214","id":432625327,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjYyNTMyNw==","user":{"login":"shmish111","id":934267,"node_id":"MDQ6VXNlcjkzNDI2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/934267?v=4","gravatar_id":"","url":"https://api.github.com/users/shmish111","html_url":"https://github.com/shmish111","followers_url":"https://api.github.com/users/shmish111/followers","following_url":"https://api.github.com/users/shmish111/following{/other_user}","gists_url":"https://api.github.com/users/shmish111/gists{/gist_id}","starred_url":"https://api.github.com/users/shmish111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmish111/subscriptions","organizations_url":"https://api.github.com/users/shmish111/orgs","repos_url":"https://api.github.com/users/shmish111/repos","events_url":"https://api.github.com/users/shmish111/events{/privacy}","received_events_url":"https://api.github.com/users/shmish111/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T11:54:47Z","updated_at":"2018-10-24T11:54:47Z","author_association":"COLLABORATOR","body":"OK, I've made the changes suggested I think. I haven't wrapped up the client yet as I'm not quite sure how the classes will work but I'd prefer to keep that for the next PR as this is getting quite big. This PR should just now represent a refactoring of how the http server works as well as creating a client.\r\n\r\nI will do a squash once it is approved.\r\n\r\nIn reality it was more of a learning experience for everyone :-)"}}
{"actor":{"display_login":"shmish111"}}