{"action":"created","comment":{"url":"https://api.github.com/repos/nextcloud/server/pulls/comments/223222634","pull_request_review_id":162299173,"id":223222634,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIyMjYzNA==","diff_hunk":"@@ -412,7 +412,20 @@ public static function initSession() {\n \t\tini_set('session.cookie_path', $cookie_path);\n \n \t\t// Let the session name be changed in the initSession Hook\n-\t\t$sessionName = OC_Util::getInstanceId();\n+\t\ttry {\n+\t\t\t$sessionName = OC_Util::getInstanceId();\n+\t\t} catch (\\OC\\HintException $e) {\n+\t\t\t$error = [\n+\t\t\t\t'error' => $e->getMessage(),\n+\t\t\t\t'hint' => $e->getHint(),\n+\t\t\t];\n+\n+\t\t\thttp_response_code(503);\n+\t\t\tOC_Util::addStyle('guest');\n+\t\t\tOC_Template::printGuestPage('', 'error', ['errors' => [$error]]);","path":"lib/base.php","position":15,"original_position":15,"commit_id":"e37e248a8f8fa89f427ad0c51cf3bb2c5547a3b7","original_commit_id":"e37e248a8f8fa89f427ad0c51cf3bb2c5547a3b7","user":{"login":"danielkesselberg","id":3902676,"node_id":"MDQ6VXNlcjM5MDI2NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3902676?v=4","gravatar_id":"","url":"https://api.github.com/users/danielkesselberg","html_url":"https://github.com/danielkesselberg","followers_url":"https://api.github.com/users/danielkesselberg/followers","following_url":"https://api.github.com/users/danielkesselberg/following{/other_user}","gists_url":"https://api.github.com/users/danielkesselberg/gists{/gist_id}","starred_url":"https://api.github.com/users/danielkesselberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielkesselberg/subscriptions","organizations_url":"https://api.github.com/users/danielkesselberg/orgs","repos_url":"https://api.github.com/users/danielkesselberg/repos","events_url":"https://api.github.com/users/danielkesselberg/events{/privacy}","received_events_url":"https://api.github.com/users/danielkesselberg/received_events","type":"User","site_admin":false},"body":"https://github.com/nextcloud/server/blob/c9e93b8084e45d6773e57932165739738c075889/lib/private/legacy/template.php#L339-L346\r\n\r\nThere is a helper for error page. Maybe this would work here as well? ","created_at":"2018-10-07T18:08:55Z","updated_at":"2018-10-07T18:12:09Z","html_url":"https://github.com/nextcloud/server/pull/11663#discussion_r223222634","pull_request_url":"https://api.github.com/repos/nextcloud/server/pulls/11663","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments/223222634"},"html":{"href":"https://github.com/nextcloud/server/pull/11663#discussion_r223222634"},"pull_request":{"href":"https://api.github.com/repos/nextcloud/server/pulls/11663"}}},"pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/11663","id":220948086,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTQ4MDg2","html_url":"https://github.com/nextcloud/server/pull/11663","diff_url":"https://github.com/nextcloud/server/pull/11663.diff","patch_url":"https://github.com/nextcloud/server/pull/11663.patch","issue_url":"https://api.github.com/repos/nextcloud/server/issues/11663","number":11663,"state":"open","locked":false,"title":"[WIP] Show a more specific error message if config file is not writable","user":{"login":"burned42","id":16883833,"node_id":"MDQ6VXNlcjE2ODgzODMz","avatar_url":"https://avatars2.githubusercontent.com/u/16883833?v=4","gravatar_id":"","url":"https://api.github.com/users/burned42","html_url":"https://github.com/burned42","followers_url":"https://api.github.com/users/burned42/followers","following_url":"https://api.github.com/users/burned42/following{/other_user}","gists_url":"https://api.github.com/users/burned42/gists{/gist_id}","starred_url":"https://api.github.com/users/burned42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burned42/subscriptions","organizations_url":"https://api.github.com/users/burned42/orgs","repos_url":"https://api.github.com/users/burned42/repos","events_url":"https://api.github.com/users/burned42/events{/privacy}","received_events_url":"https://api.github.com/users/burned42/received_events","type":"User","site_admin":false},"body":"When I tried reproducing the problem described in #8580 I noticed that there is only a very generic error message displayed (like in the attached screenshot in this issue) when the config file does not exist and the config directory is not writable, so e.g. if you set up a new installation and didn't adjust the permissions correctly.\r\n\r\nSo this PR should introduce a more helpful error message for that case.","created_at":"2018-10-07T13:27:08Z","updated_at":"2018-10-07T18:12:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"064aa78c754e35aff80f1f7190cac6e499ad9b23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nextcloud/server/pulls/11663/commits","review_comments_url":"https://api.github.com/repos/nextcloud/server/pulls/11663/comments","review_comment_url":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/11663/comments","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/e37e248a8f8fa89f427ad0c51cf3bb2c5547a3b7","head":{"label":"burned42:show_error_if_config_not_writable","ref":"show_error_if_config_not_writable","sha":"e37e248a8f8fa89f427ad0c51cf3bb2c5547a3b7","user":{"login":"burned42","id":16883833,"node_id":"MDQ6VXNlcjE2ODgzODMz","avatar_url":"https://avatars2.githubusercontent.com/u/16883833?v=4","gravatar_id":"","url":"https://api.github.com/users/burned42","html_url":"https://github.com/burned42","followers_url":"https://api.github.com/users/burned42/followers","following_url":"https://api.github.com/users/burned42/following{/other_user}","gists_url":"https://api.github.com/users/burned42/gists{/gist_id}","starred_url":"https://api.github.com/users/burned42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burned42/subscriptions","organizations_url":"https://api.github.com/users/burned42/orgs","repos_url":"https://api.github.com/users/burned42/repos","events_url":"https://api.github.com/users/burned42/events{/privacy}","received_events_url":"https://api.github.com/users/burned42/received_events","type":"User","site_admin":false},"repo":{"id":107443057,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc0NDMwNTc=","name":"server","full_name":"burned42/server","private":false,"owner":{"login":"burned42","id":16883833,"node_id":"MDQ6VXNlcjE2ODgzODMz","avatar_url":"https://avatars2.githubusercontent.com/u/16883833?v=4","gravatar_id":"","url":"https://api.github.com/users/burned42","html_url":"https://github.com/burned42","followers_url":"https://api.github.com/users/burned42/followers","following_url":"https://api.github.com/users/burned42/following{/other_user}","gists_url":"https://api.github.com/users/burned42/gists{/gist_id}","starred_url":"https://api.github.com/users/burned42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burned42/subscriptions","organizations_url":"https://api.github.com/users/burned42/orgs","repos_url":"https://api.github.com/users/burned42/repos","events_url":"https://api.github.com/users/burned42/events{/privacy}","received_events_url":"https://api.github.com/users/burned42/received_events","type":"User","site_admin":false},"html_url":"https://github.com/burned42/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":true,"url":"https://api.github.com/repos/burned42/server","forks_url":"https://api.github.com/repos/burned42/server/forks","keys_url":"https://api.github.com/repos/burned42/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burned42/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burned42/server/teams","hooks_url":"https://api.github.com/repos/burned42/server/hooks","issue_events_url":"https://api.github.com/repos/burned42/server/issues/events{/number}","events_url":"https://api.github.com/repos/burned42/server/events","assignees_url":"https://api.github.com/repos/burned42/server/assignees{/user}","branches_url":"https://api.github.com/repos/burned42/server/branches{/branch}","tags_url":"https://api.github.com/repos/burned42/server/tags","blobs_url":"https://api.github.com/repos/burned42/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burned42/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burned42/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/burned42/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burned42/server/statuses/{sha}","languages_url":"https://api.github.com/repos/burned42/server/languages","stargazers_url":"https://api.github.com/repos/burned42/server/stargazers","contributors_url":"https://api.github.com/repos/burned42/server/contributors","subscribers_url":"https://api.github.com/repos/burned42/server/subscribers","subscription_url":"https://api.github.com/repos/burned42/server/subscription","commits_url":"https://api.github.com/repos/burned42/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/burned42/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/burned42/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/burned42/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/burned42/server/contents/{+path}","compare_url":"https://api.github.com/repos/burned42/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burned42/server/merges","archive_url":"https://api.github.com/repos/burned42/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burned42/server/downloads","issues_url":"https://api.github.com/repos/burned42/server/issues{/number}","pulls_url":"https://api.github.com/repos/burned42/server/pulls{/number}","milestones_url":"https://api.github.com/repos/burned42/server/milestones{/number}","notifications_url":"https://api.github.com/repos/burned42/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burned42/server/labels{/name}","releases_url":"https://api.github.com/repos/burned42/server/releases{/id}","deployments_url":"https://api.github.com/repos/burned42/server/deployments","created_at":"2017-10-18T17:47:52Z","updated_at":"2018-10-07T10:47:58Z","pushed_at":"2018-10-07T13:37:44Z","git_url":"git://github.com/burned42/server.git","ssh_url":"git@github.com:burned42/server.git","clone_url":"https://github.com/burned42/server.git","svn_url":"https://github.com/burned42/server","homepage":"https://nextcloud.com","size":316620,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nextcloud:master","ref":"master","sha":"4c47ec005f31e10b55af1bec277c6c0d011e4c28","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MzE5Nw==","name":"server","full_name":"nextcloud/server","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2018-10-07T08:16:28Z","pushed_at":"2018-10-07T16:27:44Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":321252,"stargazers_count":5435,"watchers_count":5435,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":955,"mirror_url":null,"archived":false,"open_issues_count":1502,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":955,"open_issues":1502,"watchers":5435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/11663"},"html":{"href":"https://github.com/nextcloud/server/pull/11663"},"issue":{"href":"https://api.github.com/repos/nextcloud/server/issues/11663"},"comments":{"href":"https://api.github.com/repos/nextcloud/server/issues/11663/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/server/pulls/11663/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/server/pulls/11663/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/server/statuses/e37e248a8f8fa89f427ad0c51cf3bb2c5547a3b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danielkesselberg"}}