{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/232201627","pull_request_review_id":173346041,"id":232201627,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjIwMTYyNw==","diff_hunk":"@@ -84,6 +84,10 @@ public function add(\n \n         if (!isset($defaults['_controller'])) {\n             $actionJoiner = false === \\strpos($this->baseControllerName, '\\\\') ? ':' : '::';\n+            if (false !== \\strpos($this->baseControllerName, '\\\\') && false !== \\strpos($this->baseControllerName, ':')) {","path":"src/Route/RouteCollection.php","position":4,"original_position":4,"commit_id":"73a7934f9c213d9bf1f39700d578e474e8a3e507","original_commit_id":"73a7934f9c213d9bf1f39700d578e474e8a3e507","user":{"login":"tifabien","id":705356,"node_id":"MDQ6VXNlcjcwNTM1Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/705356?v=4","gravatar_id":"","url":"https://api.github.com/users/tifabien","html_url":"https://github.com/tifabien","followers_url":"https://api.github.com/users/tifabien/followers","following_url":"https://api.github.com/users/tifabien/following{/other_user}","gists_url":"https://api.github.com/users/tifabien/gists{/gist_id}","starred_url":"https://api.github.com/users/tifabien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tifabien/subscriptions","organizations_url":"https://api.github.com/users/tifabien/orgs","repos_url":"https://api.github.com/users/tifabien/repos","events_url":"https://api.github.com/users/tifabien/events{/privacy}","received_events_url":"https://api.github.com/users/tifabien/received_events","type":"User","site_admin":false},"body":"What is your suggestion?","created_at":"2018-11-09T10:09:39Z","updated_at":"2018-11-09T10:09:40Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/5287#discussion_r232201627","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5287","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/232201627"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/5287#discussion_r232201627"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5287"}},"in_reply_to_id":232198126},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5287","id":229427980,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDI3OTgw","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/5287","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/5287.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/5287.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/5287","number":5287,"state":"open","locked":false,"title":"Fix BC break when baseControllerName uses bundle notation with subfolder","user":{"login":"tifabien","id":705356,"node_id":"MDQ6VXNlcjcwNTM1Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/705356?v=4","gravatar_id":"","url":"https://api.github.com/users/tifabien","html_url":"https://github.com/tifabien","followers_url":"https://api.github.com/users/tifabien/followers","following_url":"https://api.github.com/users/tifabien/following{/other_user}","gists_url":"https://api.github.com/users/tifabien/gists{/gist_id}","starred_url":"https://api.github.com/users/tifabien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tifabien/subscriptions","organizations_url":"https://api.github.com/users/tifabien/orgs","repos_url":"https://api.github.com/users/tifabien/repos","events_url":"https://api.github.com/users/tifabien/events{/privacy}","received_events_url":"https://api.github.com/users/tifabien/received_events","type":"User","site_admin":false},"body":"I am targeting this branch, because it fixes a BC break when using Bundle notation with Subfolder.\r\n\r\n## Changelog\r\n\r\n```markdown\r\n### Fixed\r\n- Fixed BC break when baseControllerName uses bundle notation with subfolder\r\n```\r\n## Subject\r\n\r\nRelated to #5228 \r\n","created_at":"2018-11-08T16:26:02Z","updated_at":"2018-11-09T10:09:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97bd450c01638dde56cd08df1286521f7262eee3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5287/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5287/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/5287/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/73a7934f9c213d9bf1f39700d578e474e8a3e507","head":{"label":"tifabien:fix-controller-notation","ref":"fix-controller-notation","sha":"73a7934f9c213d9bf1f39700d578e474e8a3e507","user":{"login":"tifabien","id":705356,"node_id":"MDQ6VXNlcjcwNTM1Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/705356?v=4","gravatar_id":"","url":"https://api.github.com/users/tifabien","html_url":"https://github.com/tifabien","followers_url":"https://api.github.com/users/tifabien/followers","following_url":"https://api.github.com/users/tifabien/following{/other_user}","gists_url":"https://api.github.com/users/tifabien/gists{/gist_id}","starred_url":"https://api.github.com/users/tifabien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tifabien/subscriptions","organizations_url":"https://api.github.com/users/tifabien/orgs","repos_url":"https://api.github.com/users/tifabien/repos","events_url":"https://api.github.com/users/tifabien/events{/privacy}","received_events_url":"https://api.github.com/users/tifabien/received_events","type":"User","site_admin":false},"repo":{"id":126539001,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY1MzkwMDE=","name":"SonataAdminBundle","full_name":"tifabien/SonataAdminBundle","private":false,"owner":{"login":"tifabien","id":705356,"node_id":"MDQ6VXNlcjcwNTM1Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/705356?v=4","gravatar_id":"","url":"https://api.github.com/users/tifabien","html_url":"https://github.com/tifabien","followers_url":"https://api.github.com/users/tifabien/followers","following_url":"https://api.github.com/users/tifabien/following{/other_user}","gists_url":"https://api.github.com/users/tifabien/gists{/gist_id}","starred_url":"https://api.github.com/users/tifabien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tifabien/subscriptions","organizations_url":"https://api.github.com/users/tifabien/orgs","repos_url":"https://api.github.com/users/tifabien/repos","events_url":"https://api.github.com/users/tifabien/events{/privacy}","received_events_url":"https://api.github.com/users/tifabien/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tifabien/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/tifabien/SonataAdminBundle","forks_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/tifabien/SonataAdminBundle/deployments","created_at":"2018-03-23T21:07:27Z","updated_at":"2018-07-31T13:41:49Z","pushed_at":"2018-11-08T16:24:23Z","git_url":"git://github.com/tifabien/SonataAdminBundle.git","ssh_url":"git@github.com:tifabien/SonataAdminBundle.git","clone_url":"https://github.com/tifabien/SonataAdminBundle.git","svn_url":"https://github.com/tifabien/SonataAdminBundle","homepage":"https://sonata-project.org/","size":21804,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"73f1cb5bcccc1e7cc4e979db804e2caf6cae9616","user":{"login":"sonata-project","id":404157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk1MjI4","name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","private":false,"owner":{"login":"sonata-project","id":404157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2018-11-09T08:46:29Z","pushed_at":"2018-11-08T16:26:03Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"https://sonata-project.org/","size":22081,"stargazers_count":1726,"watchers_count":1726,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1179,"mirror_url":null,"archived":false,"open_issues_count":274,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1179,"open_issues":274,"watchers":1726,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5287"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/5287"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/5287"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/5287/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5287/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5287/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/73a7934f9c213d9bf1f39700d578e474e8a3e507"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tifabien"}}