{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/reaction/pulls/comments/196105928","pull_request_review_id":129595946,"id":196105928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjEwNTkyOA==","diff_hunk":"@@ -24,6 +24,14 @@ const BaseImageArea = styled.div`\n \n const SmallImageArea = styled(BaseImageArea)`\n   max-height: calc(100vh - 120px);\n+\n+  /**\n+   * This will make sure the image area already exists prior to image loading\n+   * and the layout won’t jump later on, but it does rely on the current design\n+   * where this image is supposed to be shown from the left side of the screen\n+   * to the right side of the screen, i.e. the width of the viewport.\n+   */\n+  height: calc(100vw / ${({ aspectRatio }) => aspectRatio});","path":"src/Styleguide/Components/Artwork/ImageCarousel.tsx","position":20,"original_position":20,"commit_id":"26b39f70175299544c27fa0f4f981f39b63eb509","original_commit_id":"26b39f70175299544c27fa0f4f981f39b63eb509","user":{"login":"oxaudo","id":437156,"node_id":"MDQ6VXNlcjQzNzE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/437156?v=4","gravatar_id":"","url":"https://api.github.com/users/oxaudo","html_url":"https://github.com/oxaudo","followers_url":"https://api.github.com/users/oxaudo/followers","following_url":"https://api.github.com/users/oxaudo/following{/other_user}","gists_url":"https://api.github.com/users/oxaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/oxaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxaudo/subscriptions","organizations_url":"https://api.github.com/users/oxaudo/orgs","repos_url":"https://api.github.com/users/oxaudo/repos","events_url":"https://api.github.com/users/oxaudo/events{/privacy}","received_events_url":"https://api.github.com/users/oxaudo/received_events","type":"User","site_admin":false},"body":"This all looks good to me. Just trying to understand - here we are trying to make the image height proportional to view width? This will guarantee that really wide images do not take the whole width of the screen? That is an idea?\r\n\r\nBut should not the height of the image be the same for all the images in the carousel?  Or the idea is that it will jump in size when going image to image?","created_at":"2018-06-18T14:46:35Z","updated_at":"2018-06-18T14:53:40Z","html_url":"https://github.com/artsy/reaction/pull/802#discussion_r196105928","pull_request_url":"https://api.github.com/repos/artsy/reaction/pulls/802","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/artsy/reaction/pulls/comments/196105928"},"html":{"href":"https://github.com/artsy/reaction/pull/802#discussion_r196105928"},"pull_request":{"href":"https://api.github.com/repos/artsy/reaction/pulls/802"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/reaction/pulls/802","id":194943858,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTQzODU4","html_url":"https://github.com/artsy/reaction/pull/802","diff_url":"https://github.com/artsy/reaction/pull/802.diff","patch_url":"https://github.com/artsy/reaction/pull/802.patch","issue_url":"https://api.github.com/repos/artsy/reaction/issues/802","number":802,"state":"open","locked":false,"title":"[Artwork/ImageCarousel] Use aspect ratio so layout doesn’t jump.","user":{"login":"alloy","id":2320,"node_id":"MDQ6VXNlcjIzMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2320?v=4","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"body":"See the inline comment https://github.com/artsy/reaction/compare/more-artwork-image-carousel-work?expand=1#diff-182d6f0b0c129e245b5c501ddad78c93R29","created_at":"2018-06-14T16:05:30Z","updated_at":"2018-06-18T14:53:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae667b5da3ea0ee50f7462823e4b9a68aeb738b4","assignee":{"login":"oxaudo","id":437156,"node_id":"MDQ6VXNlcjQzNzE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/437156?v=4","gravatar_id":"","url":"https://api.github.com/users/oxaudo","html_url":"https://github.com/oxaudo","followers_url":"https://api.github.com/users/oxaudo/followers","following_url":"https://api.github.com/users/oxaudo/following{/other_user}","gists_url":"https://api.github.com/users/oxaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/oxaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxaudo/subscriptions","organizations_url":"https://api.github.com/users/oxaudo/orgs","repos_url":"https://api.github.com/users/oxaudo/repos","events_url":"https://api.github.com/users/oxaudo/events{/privacy}","received_events_url":"https://api.github.com/users/oxaudo/received_events","type":"User","site_admin":false},"assignees":[{"login":"oxaudo","id":437156,"node_id":"MDQ6VXNlcjQzNzE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/437156?v=4","gravatar_id":"","url":"https://api.github.com/users/oxaudo","html_url":"https://github.com/oxaudo","followers_url":"https://api.github.com/users/oxaudo/followers","following_url":"https://api.github.com/users/oxaudo/following{/other_user}","gists_url":"https://api.github.com/users/oxaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/oxaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxaudo/subscriptions","organizations_url":"https://api.github.com/users/oxaudo/orgs","repos_url":"https://api.github.com/users/oxaudo/repos","events_url":"https://api.github.com/users/oxaudo/events{/privacy}","received_events_url":"https://api.github.com/users/oxaudo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/reaction/pulls/802/commits","review_comments_url":"https://api.github.com/repos/artsy/reaction/pulls/802/comments","review_comment_url":"https://api.github.com/repos/artsy/reaction/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/reaction/issues/802/comments","statuses_url":"https://api.github.com/repos/artsy/reaction/statuses/26b39f70175299544c27fa0f4f981f39b63eb509","head":{"label":"artsy:more-artwork-image-carousel-work","ref":"more-artwork-image-carousel-work","sha":"26b39f70175299544c27fa0f4f981f39b63eb509","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":81253735,"node_id":"MDEwOlJlcG9zaXRvcnk4MTI1MzczNQ==","name":"reaction","full_name":"artsy/reaction","owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/reaction","description":"Artsy’s React Components","fork":false,"url":"https://api.github.com/repos/artsy/reaction","forks_url":"https://api.github.com/repos/artsy/reaction/forks","keys_url":"https://api.github.com/repos/artsy/reaction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/reaction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/reaction/teams","hooks_url":"https://api.github.com/repos/artsy/reaction/hooks","issue_events_url":"https://api.github.com/repos/artsy/reaction/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/reaction/events","assignees_url":"https://api.github.com/repos/artsy/reaction/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/reaction/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/reaction/tags","blobs_url":"https://api.github.com/repos/artsy/reaction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/reaction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/reaction/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/reaction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/reaction/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/reaction/languages","stargazers_url":"https://api.github.com/repos/artsy/reaction/stargazers","contributors_url":"https://api.github.com/repos/artsy/reaction/contributors","subscribers_url":"https://api.github.com/repos/artsy/reaction/subscribers","subscription_url":"https://api.github.com/repos/artsy/reaction/subscription","commits_url":"https://api.github.com/repos/artsy/reaction/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/reaction/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/reaction/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/reaction/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/reaction/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/reaction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/reaction/merges","archive_url":"https://api.github.com/repos/artsy/reaction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/reaction/downloads","issues_url":"https://api.github.com/repos/artsy/reaction/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/reaction/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/reaction/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/reaction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/reaction/labels{/name}","releases_url":"https://api.github.com/repos/artsy/reaction/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/reaction/deployments","created_at":"2017-02-07T21:00:51Z","updated_at":"2018-06-16T10:03:52Z","pushed_at":"2018-06-16T10:12:15Z","git_url":"git://github.com/artsy/reaction.git","ssh_url":"git@github.com:artsy/reaction.git","clone_url":"https://github.com/artsy/reaction.git","svn_url":"https://github.com/artsy/reaction","homepage":"https://artsy.github.io/reaction","size":15883,"stargazers_count":112,"watchers_count":112,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":18,"watchers":112,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"79564690000d42b7f3badda96dcb25e5bb8d0c2c","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":81253735,"node_id":"MDEwOlJlcG9zaXRvcnk4MTI1MzczNQ==","name":"reaction","full_name":"artsy/reaction","owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/reaction","description":"Artsy’s React Components","fork":false,"url":"https://api.github.com/repos/artsy/reaction","forks_url":"https://api.github.com/repos/artsy/reaction/forks","keys_url":"https://api.github.com/repos/artsy/reaction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/reaction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/reaction/teams","hooks_url":"https://api.github.com/repos/artsy/reaction/hooks","issue_events_url":"https://api.github.com/repos/artsy/reaction/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/reaction/events","assignees_url":"https://api.github.com/repos/artsy/reaction/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/reaction/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/reaction/tags","blobs_url":"https://api.github.com/repos/artsy/reaction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/reaction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/reaction/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/reaction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/reaction/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/reaction/languages","stargazers_url":"https://api.github.com/repos/artsy/reaction/stargazers","contributors_url":"https://api.github.com/repos/artsy/reaction/contributors","subscribers_url":"https://api.github.com/repos/artsy/reaction/subscribers","subscription_url":"https://api.github.com/repos/artsy/reaction/subscription","commits_url":"https://api.github.com/repos/artsy/reaction/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/reaction/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/reaction/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/reaction/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/reaction/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/reaction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/reaction/merges","archive_url":"https://api.github.com/repos/artsy/reaction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/reaction/downloads","issues_url":"https://api.github.com/repos/artsy/reaction/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/reaction/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/reaction/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/reaction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/reaction/labels{/name}","releases_url":"https://api.github.com/repos/artsy/reaction/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/reaction/deployments","created_at":"2017-02-07T21:00:51Z","updated_at":"2018-06-16T10:03:52Z","pushed_at":"2018-06-16T10:12:15Z","git_url":"git://github.com/artsy/reaction.git","ssh_url":"git@github.com:artsy/reaction.git","clone_url":"https://github.com/artsy/reaction.git","svn_url":"https://github.com/artsy/reaction","homepage":"https://artsy.github.io/reaction","size":15883,"stargazers_count":112,"watchers_count":112,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":18,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/reaction/pulls/802"},"html":{"href":"https://github.com/artsy/reaction/pull/802"},"issue":{"href":"https://api.github.com/repos/artsy/reaction/issues/802"},"comments":{"href":"https://api.github.com/repos/artsy/reaction/issues/802/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/reaction/pulls/802/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/reaction/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/reaction/pulls/802/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/reaction/statuses/26b39f70175299544c27fa0f4f981f39b63eb509"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"oxaudo"}}