{"action":"opened","number":8625,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/8625","id":217180911,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTgwOTEx","html_url":"https://github.com/playframework/playframework/pull/8625","diff_url":"https://github.com/playframework/playframework/pull/8625.diff","patch_url":"https://github.com/playframework/playframework/pull/8625.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/8625","number":8625,"state":"open","locked":false,"title":"Add exception handling around synchronous lifecycle stop hook execution","user":{"login":"Woodz","id":966157,"node_id":"MDQ6VXNlcjk2NjE1Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/966157?v=4","gravatar_id":"","url":"https://api.github.com/users/Woodz","html_url":"https://github.com/Woodz","followers_url":"https://api.github.com/users/Woodz/followers","following_url":"https://api.github.com/users/Woodz/following{/other_user}","gists_url":"https://api.github.com/users/Woodz/gists{/gist_id}","starred_url":"https://api.github.com/users/Woodz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Woodz/subscriptions","organizations_url":"https://api.github.com/users/Woodz/orgs","repos_url":"https://api.github.com/users/Woodz/repos","events_url":"https://api.github.com/users/Woodz/events{/privacy}","received_events_url":"https://api.github.com/users/Woodz/received_events","type":"User","site_admin":false},"body":"Add unit test to verify synchronous exceptions do not cause the\r\n lifecycle stop hook future to fail\r\nResolve: https://github.com/playframework/playframework/issues/8624\r\n\r\n# Pull Request Checklist\r\n\r\n* [ ] Have you read [How to write the perfect pull request](https://github.com/blog/1943-how-to-write-the-perfect-pull-request)?\r\n* [X] Have you read through the [contributor guidelines](https://www.playframework.com/contributing)?\r\n* [In progress] Have you signed the [Lightbend CLA](https://www.lightbend.com/contribute/cla)?\r\n* [X] Have you referenced any issues you're fixing using [commit message keywords](https://help.github.com/articles/closing-issues-using-keywords/)?\r\n* [X] Have you added copyright headers to new files?\r\n* [N/A] Have you checked that both Scala and Java APIs are updated?\r\n* [N/A] Have you updated the documentation for both Scala and Java sections?\r\n* [X] Have you added tests for any changed functionality?\r\n\r\n# Helpful things\r\n\r\n## Fixes\r\n\r\nhttps://github.com/playframework/playframework/issues/8624\r\n\r\n## Purpose\r\n\r\nFixes bug https://github.com/playframework/playframework/issues/8624\r\n\r\n## Background Context\r\n\r\nThe existing implementation only used `recover` to handle failure which assumes all failures happen on the asynchronous path. However, a method that returns `Future` is not guaranteed to only throw an exception on the asynchronous path, so we need to handle exceptions on both the synchronous and asynchronous paths - hence the addition of the `try ... catch`\r\n\r\n## References\r\n\r\nNone\r\n","created_at":"2018-09-21T06:13:42Z","updated_at":"2018-09-21T06:13:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/8625/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/8625/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/8625/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/43a7044b499fe096212bc4f92222544856811d01","head":{"label":"Redmart:feature/issue-8624-handle-errors-when-converting-java-stop-hook-promises-to-futures","ref":"feature/issue-8624-handle-errors-when-converting-java-stop-hook-promises-to-futures","sha":"43a7044b499fe096212bc4f92222544856811d01","user":{"login":"Redmart","id":3480598,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODA1OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3480598?v=4","gravatar_id":"","url":"https://api.github.com/users/Redmart","html_url":"https://github.com/Redmart","followers_url":"https://api.github.com/users/Redmart/followers","following_url":"https://api.github.com/users/Redmart/following{/other_user}","gists_url":"https://api.github.com/users/Redmart/gists{/gist_id}","starred_url":"https://api.github.com/users/Redmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Redmart/subscriptions","organizations_url":"https://api.github.com/users/Redmart/orgs","repos_url":"https://api.github.com/users/Redmart/repos","events_url":"https://api.github.com/users/Redmart/events{/privacy}","received_events_url":"https://api.github.com/users/Redmart/received_events","type":"Organization","site_admin":false},"repo":{"id":149717611,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk3MTc2MTE=","name":"playframework","full_name":"Redmart/playframework","private":false,"owner":{"login":"Redmart","id":3480598,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODA1OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3480598?v=4","gravatar_id":"","url":"https://api.github.com/users/Redmart","html_url":"https://github.com/Redmart","followers_url":"https://api.github.com/users/Redmart/followers","following_url":"https://api.github.com/users/Redmart/following{/other_user}","gists_url":"https://api.github.com/users/Redmart/gists{/gist_id}","starred_url":"https://api.github.com/users/Redmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Redmart/subscriptions","organizations_url":"https://api.github.com/users/Redmart/orgs","repos_url":"https://api.github.com/users/Redmart/repos","events_url":"https://api.github.com/users/Redmart/events{/privacy}","received_events_url":"https://api.github.com/users/Redmart/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Redmart/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/Redmart/playframework","forks_url":"https://api.github.com/repos/Redmart/playframework/forks","keys_url":"https://api.github.com/repos/Redmart/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Redmart/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Redmart/playframework/teams","hooks_url":"https://api.github.com/repos/Redmart/playframework/hooks","issue_events_url":"https://api.github.com/repos/Redmart/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/Redmart/playframework/events","assignees_url":"https://api.github.com/repos/Redmart/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/Redmart/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/Redmart/playframework/tags","blobs_url":"https://api.github.com/repos/Redmart/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Redmart/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Redmart/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Redmart/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Redmart/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/Redmart/playframework/languages","stargazers_url":"https://api.github.com/repos/Redmart/playframework/stargazers","contributors_url":"https://api.github.com/repos/Redmart/playframework/contributors","subscribers_url":"https://api.github.com/repos/Redmart/playframework/subscribers","subscription_url":"https://api.github.com/repos/Redmart/playframework/subscription","commits_url":"https://api.github.com/repos/Redmart/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Redmart/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Redmart/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Redmart/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Redmart/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/Redmart/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Redmart/playframework/merges","archive_url":"https://api.github.com/repos/Redmart/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Redmart/playframework/downloads","issues_url":"https://api.github.com/repos/Redmart/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/Redmart/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/Redmart/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/Redmart/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Redmart/playframework/labels{/name}","releases_url":"https://api.github.com/repos/Redmart/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/Redmart/playframework/deployments","created_at":"2018-09-21T06:06:31Z","updated_at":"2018-09-21T06:06:37Z","pushed_at":"2018-09-21T06:11:18Z","git_url":"git://github.com/Redmart/playframework.git","ssh_url":"git@github.com:Redmart/playframework.git","clone_url":"https://github.com/Redmart/playframework.git","svn_url":"https://github.com/Redmart/playframework","homepage":"http://www.playframework.com/","size":90200,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:2.4.x","ref":"2.4.x","sha":"b3d1aec6f221b6109384a901455bf62108d0ce17","user":{"login":"playframework","id":319107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTEwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/319107?v=4","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"node_id":"MDEwOlJlcG9zaXRvcnkyMzQwNTQ5","name":"playframework","full_name":"playframework/playframework","private":false,"owner":{"login":"playframework","id":319107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTEwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/319107?v=4","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2018-09-20T22:46:31Z","pushed_at":"2018-09-20T22:55:15Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":90200,"stargazers_count":10716,"watchers_count":10716,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3625,"mirror_url":null,"archived":false,"open_issues_count":400,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3625,"open_issues":400,"watchers":10716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/8625"},"html":{"href":"https://github.com/playframework/playframework/pull/8625"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/8625"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/8625/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/8625/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/8625/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/43a7044b499fe096212bc4f92222544856811d01"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":36,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"Woodz"}}