{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59359","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59359/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59359/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59359/events","html_url":"https://github.com/kubernetes/kubernetes/pull/59359","id":294493819,"number":59359,"title":"Remove controller-manager --service-sync-period flag","user":{"login":"khenidak","id":10683203,"avatar_url":"https://avatars2.githubusercontent.com/u/10683203?v=4","gravatar_id":"","url":"https://api.github.com/users/khenidak","html_url":"https://github.com/khenidak","followers_url":"https://api.github.com/users/khenidak/followers","following_url":"https://api.github.com/users/khenidak/following{/other_user}","gists_url":"https://api.github.com/users/khenidak/gists{/gist_id}","starred_url":"https://api.github.com/users/khenidak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khenidak/subscriptions","organizations_url":"https://api.github.com/users/khenidak/orgs","repos_url":"https://api.github.com/users/khenidak/repos","events_url":"https://api.github.com/users/khenidak/events{/privacy}","received_events_url":"https://api.github.com/users/khenidak/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":114528223,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"cheftako","id":947971,"avatar_url":"https://avatars3.githubusercontent.com/u/947971?v=4","gravatar_id":"","url":"https://api.github.com/users/cheftako","html_url":"https://github.com/cheftako","followers_url":"https://api.github.com/users/cheftako/followers","following_url":"https://api.github.com/users/cheftako/following{/other_user}","gists_url":"https://api.github.com/users/cheftako/gists{/gist_id}","starred_url":"https://api.github.com/users/cheftako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheftako/subscriptions","organizations_url":"https://api.github.com/users/cheftako/orgs","repos_url":"https://api.github.com/users/cheftako/repos","events_url":"https://api.github.com/users/cheftako/events{/privacy}","received_events_url":"https://api.github.com/users/cheftako/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},{"login":"cheftako","id":947971,"avatar_url":"https://avatars3.githubusercontent.com/u/947971?v=4","gravatar_id":"","url":"https://api.github.com/users/cheftako","html_url":"https://github.com/cheftako","followers_url":"https://api.github.com/users/cheftako/followers","following_url":"https://api.github.com/users/cheftako/following{/other_user}","gists_url":"https://api.github.com/users/cheftako/gists{/gist_id}","starred_url":"https://api.github.com/users/cheftako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheftako/subscriptions","organizations_url":"https://api.github.com/users/cheftako/orgs","repos_url":"https://api.github.com/users/cheftako/repos","events_url":"https://api.github.com/users/cheftako/events{/privacy}","received_events_url":"https://api.github.com/users/cheftako/received_events","type":"User","site_admin":false},{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars3.githubusercontent.com/u/1787169?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-02-05T18:23:28Z","updated_at":"2018-02-12T18:06:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59359","html_url":"https://github.com/kubernetes/kubernetes/pull/59359","diff_url":"https://github.com/kubernetes/kubernetes/pull/59359.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59359.patch"},"body":"**What this PR does / why we need it**:\r\nThis PR removes controller manager --service-sync-period flag which is not used anywhere in the code and is causing confusion\r\n \r\n**Which issue(s) this PR fixes** \r\nhttps://github.com/kubernetes/kubernetes/issues/58776\r\n\r\n**Special notes for your reviewer**:\r\n@deads2k this remove the flag as per the discussion on #58776 \r\n2 commits \r\n1. one for code change\r\n2. one for auto generated code\r\n\r\n**Release note**:\r\n```release-note\r\n1. Controller-manager --service-sync-period flag is removed (was never used in the code).\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/365009128","html_url":"https://github.com/kubernetes/kubernetes/pull/59359#issuecomment-365009128","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59359","id":365009128,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T18:06:34Z","updated_at":"2018-02-12T18:06:34Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/59359#issuecomment-363767983\" title=\"LGTM\">deads2k</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/59359#\" title=\"Author self-approved\">khenidak</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/59359#issuecomment-365008930\" title=\"Approved\">mikedanese</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/devel/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these OWNERS Files:\n\n- ~~[cmd/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/OWNERS)~~ [mikedanese]\n- ~~[pkg/apis/componentconfig/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/componentconfig/OWNERS)~~ [mikedanese]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}