{"action":"created","issue":{"url":"https://api.github.com/repos/brave/brave-core/issues/547","repository_url":"https://api.github.com/repos/brave/brave-core","labels_url":"https://api.github.com/repos/brave/brave-core/issues/547/labels{/name}","comments_url":"https://api.github.com/repos/brave/brave-core/issues/547/comments","events_url":"https://api.github.com/repos/brave/brave-core/issues/547/events","html_url":"https://github.com/brave/brave-core/pull/547","id":365746803,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTg5ODc5","number":547,"title":"Toolbar Tor profile icon","user":{"login":"petemill","id":741836,"node_id":"MDQ6VXNlcjc0MTgzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/741836?v=4","gravatar_id":"","url":"https://api.github.com/users/petemill","html_url":"https://github.com/petemill","followers_url":"https://api.github.com/users/petemill/followers","following_url":"https://api.github.com/users/petemill/following{/other_user}","gists_url":"https://api.github.com/users/petemill/gists{/gist_id}","starred_url":"https://api.github.com/users/petemill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petemill/subscriptions","organizations_url":"https://api.github.com/users/petemill/orgs","repos_url":"https://api.github.com/users/petemill/repos","events_url":"https://api.github.com/users/petemill/events{/privacy}","received_events_url":"https://api.github.com/users/petemill/received_events","type":"User","site_admin":false},"labels":[{"id":898321352,"node_id":"MDU6TGFiZWw4OTgzMjEzNTI=","url":"https://api.github.com/repos/brave/brave-core/labels/UI","name":"UI","color":"fbca04","default":false},{"id":1055142903,"node_id":"MDU6TGFiZWwxMDU1MTQyOTAz","url":"https://api.github.com/repos/brave/brave-core/labels/feature/tor","name":"feature/tor","color":"7585ee","default":false}],"state":"open","locked":false,"assignee":{"login":"petemill","id":741836,"node_id":"MDQ6VXNlcjc0MTgzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/741836?v=4","gravatar_id":"","url":"https://api.github.com/users/petemill","html_url":"https://github.com/petemill","followers_url":"https://api.github.com/users/petemill/followers","following_url":"https://api.github.com/users/petemill/following{/other_user}","gists_url":"https://api.github.com/users/petemill/gists{/gist_id}","starred_url":"https://api.github.com/users/petemill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petemill/subscriptions","organizations_url":"https://api.github.com/users/petemill/orgs","repos_url":"https://api.github.com/users/petemill/repos","events_url":"https://api.github.com/users/petemill/events{/privacy}","received_events_url":"https://api.github.com/users/petemill/received_events","type":"User","site_admin":false},"assignees":[{"login":"petemill","id":741836,"node_id":"MDQ6VXNlcjc0MTgzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/741836?v=4","gravatar_id":"","url":"https://api.github.com/users/petemill","html_url":"https://github.com/petemill","followers_url":"https://api.github.com/users/petemill/followers","following_url":"https://api.github.com/users/petemill/following{/other_user}","gists_url":"https://api.github.com/users/petemill/gists{/gist_id}","starred_url":"https://api.github.com/users/petemill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petemill/subscriptions","organizations_url":"https://api.github.com/users/petemill/orgs","repos_url":"https://api.github.com/users/petemill/repos","events_url":"https://api.github.com/users/petemill/events{/privacy}","received_events_url":"https://api.github.com/users/petemill/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-10-02T05:31:46Z","updated_at":"2018-10-02T05:45:53Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/brave/brave-core/pulls/547","html_url":"https://github.com/brave/brave-core/pull/547","diff_url":"https://github.com/brave/brave-core/pull/547.diff","patch_url":"https://github.com/brave/brave-core/pull/547.patch"},"body":"Fix https://github.com/brave/brave-browser/issues/1384\r\n\r\n![image](https://user-images.githubusercontent.com/741836/46330750-6a75bf00-c5c9-11e8-947a-7976d6cb4f06.png)\r\n\r\nAdded two sizes of vector icons since it's text and wanted to scale appropriately (the icon displays at different sizes for touch UI vs normal)\r\n\r\n## Submitter Checklist:\r\n\r\n- [ ] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [ ] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [ ] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone\r\n\r\n## Test Plan:\r\n- Open Tor Window\r\n- Observe that Avatar icon is 'Tor' icon\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Adequate test coverage exists to prevent regressions \r\n- [ ] Verify test plan is specified in PR before merging to source"},"comment":{"url":"https://api.github.com/repos/brave/brave-core/issues/comments/426156025","html_url":"https://github.com/brave/brave-core/pull/547#issuecomment-426156025","issue_url":"https://api.github.com/repos/brave/brave-core/issues/547","id":426156025,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjE1NjAyNQ==","user":{"login":"petemill","id":741836,"node_id":"MDQ6VXNlcjc0MTgzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/741836?v=4","gravatar_id":"","url":"https://api.github.com/users/petemill","html_url":"https://github.com/petemill","followers_url":"https://api.github.com/users/petemill/followers","following_url":"https://api.github.com/users/petemill/following{/other_user}","gists_url":"https://api.github.com/users/petemill/gists{/gist_id}","starred_url":"https://api.github.com/users/petemill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petemill/subscriptions","organizations_url":"https://api.github.com/users/petemill/orgs","repos_url":"https://api.github.com/users/petemill/repos","events_url":"https://api.github.com/users/petemill/events{/privacy}","received_events_url":"https://api.github.com/users/petemill/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T05:45:53Z","updated_at":"2018-10-02T05:45:53Z","author_association":"MEMBER","body":"@simonhong I think Guest Window uses a different flag on `profile` since the icon is unchanged:\r\n![image](https://user-images.githubusercontent.com/741836/46331233-bc1f4900-c5cb-11e8-819b-6620c1bd6374.png)\r\n"}}
{"actor":{"display_login":"petemill"}}