{"action":"created","issue":{"url":"https://api.github.com/repos/DEFRA/water-abstraction-service/issues/248","repository_url":"https://api.github.com/repos/DEFRA/water-abstraction-service","labels_url":"https://api.github.com/repos/DEFRA/water-abstraction-service/issues/248/labels{/name}","comments_url":"https://api.github.com/repos/DEFRA/water-abstraction-service/issues/248/comments","events_url":"https://api.github.com/repos/DEFRA/water-abstraction-service/issues/248/events","html_url":"https://github.com/DEFRA/water-abstraction-service/pull/248","id":391829157,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjM1ODQ4","number":248,"title":"Uses a unique id for points and conditions data","user":{"login":"swaff","id":885922,"node_id":"MDQ6VXNlcjg4NTkyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/885922?v=4","gravatar_id":"","url":"https://api.github.com/users/swaff","html_url":"https://github.com/swaff","followers_url":"https://api.github.com/users/swaff/followers","following_url":"https://api.github.com/users/swaff/following{/other_user}","gists_url":"https://api.github.com/users/swaff/gists{/gist_id}","starred_url":"https://api.github.com/users/swaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaff/subscriptions","organizations_url":"https://api.github.com/users/swaff/orgs","repos_url":"https://api.github.com/users/swaff/repos","events_url":"https://api.github.com/users/swaff/events{/privacy}","received_events_url":"https://api.github.com/users/swaff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-17T18:06:06Z","updated_at":"2018-12-18T10:15:55Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/DEFRA/water-abstraction-service/pulls/248","html_url":"https://github.com/DEFRA/water-abstraction-service/pull/248","diff_url":"https://github.com/DEFRA/water-abstraction-service/pull/248.diff","patch_url":"https://github.com/DEFRA/water-abstraction-service/pull/248.patch"},"body":"Create a truly unique id for points and conditions when found via the\r\n`/documents/{documentId}/licences/points` URL.\r\n\r\nThis is to overcome the legacy problem of non unique ids because each\r\nregion had its own datastore.\r\n\r\nAlso adds a reverse function to parse the unique id if required to break\r\ndown into type, region code and id."},"comment":{"url":"https://api.github.com/repos/DEFRA/water-abstraction-service/issues/comments/448169062","html_url":"https://github.com/DEFRA/water-abstraction-service/pull/248#issuecomment-448169062","issue_url":"https://api.github.com/repos/DEFRA/water-abstraction-service/issues/248","id":448169062,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODE2OTA2Mg==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T10:15:55Z","updated_at":"2018-12-18T10:15:55Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248?src=pr&el=h1) Report\n> Merging [#248](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248?src=pr&el=desc) into [develop](https://codecov.io/gh/DEFRA/water-abstraction-service/commit/ec08b54aa104e715e852b4cc52664e15ed61ad3d?src=pr&el=desc) will **increase** coverage by `0.11%`.\n> The diff coverage is `96.77%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248/graphs/tree.svg?width=650&token=Z3fFLBVzfS&height=150&src=pr)](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff             @@\n##           develop     #248      +/-   ##\n===========================================\n+ Coverage    87.36%   87.48%   +0.11%     \n===========================================\n  Files          117      118       +1     \n  Lines         8500     8531      +31     \n===========================================\n+ Hits          7426     7463      +37     \n+ Misses        1074     1068       -6\n```\n\n\n| [Impacted Files](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/lib/licence-transformer/nald-helpers.js](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248/diff?src=pr&el=tree#diff-c3JjL2xpYi9saWNlbmNlLXRyYW5zZm9ybWVyL25hbGQtaGVscGVycy5qcw==) | `89.23% <100%> (+4.12%)` | :arrow_up: |\n| [src/modules/licences/lib/extractConditions.js](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248/diff?src=pr&el=tree#diff-c3JjL21vZHVsZXMvbGljZW5jZXMvbGliL2V4dHJhY3RDb25kaXRpb25zLmpz) | `100% <100%> (ø)` | :arrow_up: |\n| [src/modules/licences/lib/extractPoints.js](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248/diff?src=pr&el=tree#diff-c3JjL21vZHVsZXMvbGljZW5jZXMvbGliL2V4dHJhY3RQb2ludHMuanM=) | `100% <100%> (ø)` | :arrow_up: |\n| [src/lib/licence-transformer/csv-transformer.js](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248/diff?src=pr&el=tree#diff-c3JjL2xpYi9saWNlbmNlLXRyYW5zZm9ybWVyL2Nzdi10cmFuc2Zvcm1lci5qcw==) | `76.85% <50%> (+0.18%)` | :arrow_up: |\n| [src/controllers/tasks/refreshS3data.js](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248/diff?src=pr&el=tree#diff-c3JjL2NvbnRyb2xsZXJzL3Rhc2tzL3JlZnJlc2hTM2RhdGEuanM=) | `93.75% <0%> (ø)` | |\n| [src/controllers/taskRunner.js](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248/diff?src=pr&el=tree#diff-c3JjL2NvbnRyb2xsZXJzL3Rhc2tSdW5uZXIuanM=) | `92.85% <0%> (+1.02%)` | :arrow_up: |\n| [src/lib/connectors/db.js](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248/diff?src=pr&el=tree#diff-c3JjL2xpYi9jb25uZWN0b3JzL2RiLmpz) | `94.59% <0%> (+2.7%)` | :arrow_up: |\n| [src/modules/import/index.js](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248/diff?src=pr&el=tree#diff-c3JjL21vZHVsZXMvaW1wb3J0L2luZGV4Lmpz) | `66.66% <0%> (+3.92%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248?src=pr&el=footer). Last update [ec08b54...fa4d014](https://codecov.io/gh/DEFRA/water-abstraction-service/pull/248?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}