{"action":"created","comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/209722445","pull_request_review_id":145791625,"id":209722445,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTcyMjQ0NQ==","diff_hunk":"@@ -1375,11 +1375,13 @@ def path_rewriter(path):\n                             return path\n \n                         dataset.metadata.from_JSON_dict(output_filename, path_rewriter=path_rewriter)\n+                    line_count = context.get('line_count', None)\n                     try:\n-                        assert context.get('line_count', None) is not None\n-                        dataset.set_peek(line_count=context['line_count'])\n-                    except Exception:\n-                        dataset.set_peek()\n+                        # Certain datatype's set_peek methods contain a line_count argument\n+                        dataset_assoc.dataset.set_peek(line_count=line_count)\n+                    except TypeError:","path":"lib/galaxy/jobs/__init__.py","position":12,"original_position":12,"commit_id":"f4343d876f13e55e92ca228582b4430dcd01e4aa","original_commit_id":"f4343d876f13e55e92ca228582b4430dcd01e4aa","user":{"login":"mvdbeek","id":6804901,"node_id":"MDQ6VXNlcjY4MDQ5MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6804901?v=4","gravatar_id":"","url":"https://api.github.com/users/mvdbeek","html_url":"https://github.com/mvdbeek","followers_url":"https://api.github.com/users/mvdbeek/followers","following_url":"https://api.github.com/users/mvdbeek/following{/other_user}","gists_url":"https://api.github.com/users/mvdbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdbeek/subscriptions","organizations_url":"https://api.github.com/users/mvdbeek/orgs","repos_url":"https://api.github.com/users/mvdbeek/repos","events_url":"https://api.github.com/users/mvdbeek/events{/privacy}","received_events_url":"https://api.github.com/users/mvdbeek/received_events","type":"User","site_admin":false},"body":"absolutely, I think we should do that.","created_at":"2018-08-13T19:01:20Z","updated_at":"2018-08-13T19:01:20Z","html_url":"https://github.com/galaxyproject/galaxy/pull/6594#discussion_r209722445","pull_request_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6594","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/209722445"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/6594#discussion_r209722445"},"pull_request":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6594"}},"in_reply_to_id":209703581},"pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6594","id":207993505,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTkzNTA1","html_url":"https://github.com/galaxyproject/galaxy/pull/6594","diff_url":"https://github.com/galaxyproject/galaxy/pull/6594.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/6594.patch","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6594","number":6594,"state":"closed","locked":false,"title":"Respect unavailable display peek","user":{"login":"mvdbeek","id":6804901,"node_id":"MDQ6VXNlcjY4MDQ5MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6804901?v=4","gravatar_id":"","url":"https://api.github.com/users/mvdbeek","html_url":"https://github.com/mvdbeek","followers_url":"https://api.github.com/users/mvdbeek/followers","following_url":"https://api.github.com/users/mvdbeek/following{/other_user}","gists_url":"https://api.github.com/users/mvdbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdbeek/subscriptions","organizations_url":"https://api.github.com/users/mvdbeek/orgs","repos_url":"https://api.github.com/users/mvdbeek/repos","events_url":"https://api.github.com/users/mvdbeek/events{/privacy}","received_events_url":"https://api.github.com/users/mvdbeek/received_events","type":"User","site_admin":false},"body":"This fixes the following exception when running the Filter1 tool via the API\r\n\r\n```\r\ngalaxy.datatypes.tabular ERROR 2018-08-12 22:53:42,939 make_html_peek_rows failed on HDA 64\r\nTraceback (most recent call last):\r\n  File \"/Users/mvandenb/src/galaxy/lib/galaxy/datatypes/tabular.py\", line 186, in make_html_peek_rows\r\n    dataset.set_peek()\r\n  File \"/Users/mvandenb/src/galaxy/lib/galaxy/model/__init__.py\", line 2264, in set_peek\r\n    return self.datatype.set_peek(self)\r\n  File \"/Users/mvandenb/src/galaxy/lib/galaxy/datatypes/tabular.py\", line 57, in set_peek\r\n    super(TabularData, self).set_peek(dataset, line_count=line_count, WIDTH=WIDTH, skipchars=skipchars, line_wrap=False)\r\n  File \"/Users/mvandenb/src/galaxy/lib/galaxy/datatypes/data.py\", line 813, in set_peek\r\n    dataset.peek = get_file_peek(dataset.file_name, WIDTH=WIDTH, skipchars=skipchars, line_wrap=line_wrap)\r\n  File \"/Users/mvandenb/src/galaxy/lib/galaxy/datatypes/data.py\", line 1029, in get_file_peek\r\n    with compression_utils.get_fileobj(file_name, \"U\") as temp:\r\n  File \"/Users/mvandenb/src/galaxy/lib/galaxy/util/compression_utils.py\", line 29, in get_fileobj\r\n    return get_fileobj_raw(filename, mode, compressed_formats)[1]\r\n  File \"/Users/mvandenb/src/galaxy/lib/galaxy/util/compression_utils.py\", line 58, in get_fileobj_raw\r\n    return compressed_format, io.open(filename, mode, encoding='utf-8')\r\nFileNotFoundError: [Errno 2] No such file or directory: '/private/var/folders/df/6xqpqpcd7h73b6jpx9t6cwhw0000gn/T/tmpan_4qaow/tmpfzus9jhv/tmplqjtbp5c/database/files/000/dataset_40.dat'\r\n```","created_at":"2018-08-13T14:19:24Z","updated_at":"2018-08-13T19:01:20Z","closed_at":"2018-08-13T18:02:59Z","merged_at":"2018-08-13T18:02:59Z","merge_commit_sha":"3d0763f71c795549e6c133f2734cf7ae5337c296","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":276558486,"node_id":"MDU6TGFiZWwyNzY1NTg0ODY=","url":"https://api.github.com/repos/galaxyproject/galaxy/labels/area/API","name":"area/API","color":"006b75","default":false},{"id":276558748,"node_id":"MDU6TGFiZWwyNzY1NTg3NDg=","url":"https://api.github.com/repos/galaxyproject/galaxy/labels/area/jobs","name":"area/jobs","color":"006b75","default":false},{"id":180024669,"node_id":"MDU6TGFiZWwxODAwMjQ2Njk=","url":"https://api.github.com/repos/galaxyproject/galaxy/labels/kind/bug","name":"kind/bug","color":"84b6eb","default":false},{"id":276566862,"node_id":"MDU6TGFiZWwyNzY1NjY4NjI=","url":"https://api.github.com/repos/galaxyproject/galaxy/labels/status/review","name":"status/review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6594/commits","review_comments_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6594/comments","review_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6594/comments","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/f4343d876f13e55e92ca228582b4430dcd01e4aa","head":{"label":"mvdbeek:respect_unavailable_display_peek","ref":"respect_unavailable_display_peek","sha":"f4343d876f13e55e92ca228582b4430dcd01e4aa","user":{"login":"mvdbeek","id":6804901,"node_id":"MDQ6VXNlcjY4MDQ5MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6804901?v=4","gravatar_id":"","url":"https://api.github.com/users/mvdbeek","html_url":"https://github.com/mvdbeek","followers_url":"https://api.github.com/users/mvdbeek/followers","following_url":"https://api.github.com/users/mvdbeek/following{/other_user}","gists_url":"https://api.github.com/users/mvdbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdbeek/subscriptions","organizations_url":"https://api.github.com/users/mvdbeek/orgs","repos_url":"https://api.github.com/users/mvdbeek/repos","events_url":"https://api.github.com/users/mvdbeek/events{/privacy}","received_events_url":"https://api.github.com/users/mvdbeek/received_events","type":"User","site_admin":false},"repo":{"id":38568566,"node_id":"MDEwOlJlcG9zaXRvcnkzODU2ODU2Ng==","name":"galaxy","full_name":"mvdbeek/galaxy","owner":{"login":"mvdbeek","id":6804901,"node_id":"MDQ6VXNlcjY4MDQ5MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6804901?v=4","gravatar_id":"","url":"https://api.github.com/users/mvdbeek","html_url":"https://github.com/mvdbeek","followers_url":"https://api.github.com/users/mvdbeek/followers","following_url":"https://api.github.com/users/mvdbeek/following{/other_user}","gists_url":"https://api.github.com/users/mvdbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdbeek/subscriptions","organizations_url":"https://api.github.com/users/mvdbeek/orgs","repos_url":"https://api.github.com/users/mvdbeek/repos","events_url":"https://api.github.com/users/mvdbeek/events{/privacy}","received_events_url":"https://api.github.com/users/mvdbeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mvdbeek/galaxy","description":"Data intensive biology for everyone.","fork":true,"url":"https://api.github.com/repos/mvdbeek/galaxy","forks_url":"https://api.github.com/repos/mvdbeek/galaxy/forks","keys_url":"https://api.github.com/repos/mvdbeek/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvdbeek/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvdbeek/galaxy/teams","hooks_url":"https://api.github.com/repos/mvdbeek/galaxy/hooks","issue_events_url":"https://api.github.com/repos/mvdbeek/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/mvdbeek/galaxy/events","assignees_url":"https://api.github.com/repos/mvdbeek/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/mvdbeek/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/mvdbeek/galaxy/tags","blobs_url":"https://api.github.com/repos/mvdbeek/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvdbeek/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvdbeek/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvdbeek/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvdbeek/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mvdbeek/galaxy/languages","stargazers_url":"https://api.github.com/repos/mvdbeek/galaxy/stargazers","contributors_url":"https://api.github.com/repos/mvdbeek/galaxy/contributors","subscribers_url":"https://api.github.com/repos/mvdbeek/galaxy/subscribers","subscription_url":"https://api.github.com/repos/mvdbeek/galaxy/subscription","commits_url":"https://api.github.com/repos/mvdbeek/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvdbeek/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvdbeek/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvdbeek/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvdbeek/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/mvdbeek/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvdbeek/galaxy/merges","archive_url":"https://api.github.com/repos/mvdbeek/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvdbeek/galaxy/downloads","issues_url":"https://api.github.com/repos/mvdbeek/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/mvdbeek/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mvdbeek/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mvdbeek/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvdbeek/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/mvdbeek/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/mvdbeek/galaxy/deployments","created_at":"2015-07-05T12:40:16Z","updated_at":"2018-06-12T12:30:26Z","pushed_at":"2018-08-13T15:19:40Z","git_url":"git://github.com/mvdbeek/galaxy.git","ssh_url":"git@github.com:mvdbeek/galaxy.git","clone_url":"https://github.com/mvdbeek/galaxy.git","svn_url":"https://github.com/mvdbeek/galaxy","homepage":"http://galaxyproject.org/","size":459600,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"galaxyproject:dev","ref":"dev","sha":"0b1d804cf675fb47f4132363f32b27680becbdf8","user":{"login":"galaxyproject","id":7937847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5Mzc4NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7937847?v=4","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"repo":{"id":31211061,"node_id":"MDEwOlJlcG9zaXRvcnkzMTIxMTA2MQ==","name":"galaxy","full_name":"galaxyproject/galaxy","owner":{"login":"galaxyproject","id":7937847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5Mzc4NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7937847?v=4","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/galaxyproject/galaxy","description":"Data intensive science for everyone.","fork":false,"url":"https://api.github.com/repos/galaxyproject/galaxy","forks_url":"https://api.github.com/repos/galaxyproject/galaxy/forks","keys_url":"https://api.github.com/repos/galaxyproject/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galaxyproject/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galaxyproject/galaxy/teams","hooks_url":"https://api.github.com/repos/galaxyproject/galaxy/hooks","issue_events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/galaxyproject/galaxy/events","assignees_url":"https://api.github.com/repos/galaxyproject/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/galaxyproject/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/galaxyproject/galaxy/tags","blobs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galaxyproject/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/galaxyproject/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/galaxyproject/galaxy/languages","stargazers_url":"https://api.github.com/repos/galaxyproject/galaxy/stargazers","contributors_url":"https://api.github.com/repos/galaxyproject/galaxy/contributors","subscribers_url":"https://api.github.com/repos/galaxyproject/galaxy/subscribers","subscription_url":"https://api.github.com/repos/galaxyproject/galaxy/subscription","commits_url":"https://api.github.com/repos/galaxyproject/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/galaxyproject/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/galaxyproject/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/galaxyproject/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galaxyproject/galaxy/merges","archive_url":"https://api.github.com/repos/galaxyproject/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galaxyproject/galaxy/downloads","issues_url":"https://api.github.com/repos/galaxyproject/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/galaxyproject/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/galaxyproject/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/galaxyproject/galaxy/deployments","created_at":"2015-02-23T14:18:06Z","updated_at":"2018-08-13T18:03:14Z","pushed_at":"2018-08-13T18:40:39Z","git_url":"git://github.com/galaxyproject/galaxy.git","ssh_url":"git@github.com:galaxyproject/galaxy.git","clone_url":"https://github.com/galaxyproject/galaxy.git","svn_url":"https://github.com/galaxyproject/galaxy","homepage":"https://galaxyproject.org/","size":459770,"stargazers_count":486,"watchers_count":486,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":463,"mirror_url":null,"archived":false,"open_issues_count":1173,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":463,"open_issues":1173,"watchers":486,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6594"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/6594"},"issue":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/6594"},"comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/6594/comments"},"review_comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6594/comments"},"review_comment":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6594/commits"},"statuses":{"href":"https://api.github.com/repos/galaxyproject/galaxy/statuses/f4343d876f13e55e92ca228582b4430dcd01e4aa"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mvdbeek"}}