{"action":"created","comment":{"url":"https://api.github.com/repos/rear/rear/pulls/comments/187300075","pull_request_review_id":119050277,"id":187300075,"diff_hunk":"@@ -29,17 +29,24 @@ recovery_system_roots_home_dir=$TARGET_FS_ROOT/root\n test -d $recovery_system_roots_home_dir || mkdir $verbose -m 0700 $recovery_system_roots_home_dir >&2\n ln -s $recover_log_dir/$final_logfile_name $recovery_system_roots_home_dir/rear-$( date -Iseconds ).log || true\n \n+# Copy backup restore related files (in particular the backup restore log file) if exists.\n+# This will be done as the last one of the exit tasks of this script because\n+# the exit tasks are executed in reverse ordering of how AddExitTask is called\n+# (see AddExitTask in _input-output-functions.sh) the ordering of how AddExitTask is called\n+# must begin with the to-be-last-run exit task and end with the to-be-first-run exit task:\n+if test \"$( echo $VAR_DIR/restore/* )\" ; then\n+    copy_restore_log_exit_task=\"mkdir $recovery_system_recover_log_dir/restore && cp -pr $VAR_DIR/restore/* $recovery_system_recover_log_dir/restore || true\"\n+    AddExitTask \"$copy_restore_log_exit_task\"\n+fi\n+\n # Do not copy layout and recovery related files for the 'restoreonly' workflow:\n if ! test $WORKFLOW = \"restoreonly\" ; then\n     copy_layout_files_exit_task=\"mkdir $recovery_system_recover_log_dir/layout && cp -pr $VAR_DIR/layout/* $recovery_system_recover_log_dir/layout || true\"","path":"usr/share/rear/wrapup/default/990_copy_logfile.sh","position":25,"original_position":25,"commit_id":"0a4a6369779d70e990fbd61bed9592ac111a1c7c","original_commit_id":"0a4a6369779d70e990fbd61bed9592ac111a1c7c","user":{"login":"schabrolles","id":19491077,"avatar_url":"https://avatars1.githubusercontent.com/u/19491077?v=4","gravatar_id":"","url":"https://api.github.com/users/schabrolles","html_url":"https://github.com/schabrolles","followers_url":"https://api.github.com/users/schabrolles/followers","following_url":"https://api.github.com/users/schabrolles/following{/other_user}","gists_url":"https://api.github.com/users/schabrolles/gists{/gist_id}","starred_url":"https://api.github.com/users/schabrolles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schabrolles/subscriptions","organizations_url":"https://api.github.com/users/schabrolles/orgs","repos_url":"https://api.github.com/users/schabrolles/repos","events_url":"https://api.github.com/users/schabrolles/events{/privacy}","received_events_url":"https://api.github.com/users/schabrolles/received_events","type":"User","site_admin":false},"body":"same here: `mkdir -p`","created_at":"2018-05-10T10:59:12Z","updated_at":"2018-05-10T11:02:39Z","html_url":"https://github.com/rear/rear/pull/1803#discussion_r187300075","pull_request_url":"https://api.github.com/repos/rear/rear/pulls/1803","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rear/rear/pulls/comments/187300075"},"html":{"href":"https://github.com/rear/rear/pull/1803#discussion_r187300075"},"pull_request":{"href":"https://api.github.com/repos/rear/rear/pulls/1803"}}},"pull_request":{"url":"https://api.github.com/repos/rear/rear/pulls/1803","id":186641056,"html_url":"https://github.com/rear/rear/pull/1803","diff_url":"https://github.com/rear/rear/pull/1803.diff","patch_url":"https://github.com/rear/rear/pull/1803.patch","issue_url":"https://api.github.com/repos/rear/rear/issues/1803","number":1803,"state":"open","locked":false,"title":"Copy backup restore log into recreated system (related to pull request 1797)","user":{"login":"jsmeix","id":1788608,"avatar_url":"https://avatars0.githubusercontent.com/u/1788608?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"body":"* Type: **Enhancement**\r\n\r\n* Impact: **Normal**\r\n\r\n* Reference to related issue (URL):\r\nhttps://github.com/rear/rear/pull/1797\r\n\r\n* How was this pull request tested?\r\nWorks for me with BACKUP=NETFS.\r\nNot tested BACKUP=TSM but also changed for that\r\n@schabrolles please have a look regarding TSM\r\nin particular related to https://github.com/rear/rear/pull/1799\r\n\r\n* Brief description of the changes in this pull request:\r\nHave backup restore log in the new separated directory $VAR_DIR/restore/\r\nand copy that directory contents into the recreated system a the end of\r\n\"rear recover\" via usr/share/rear/wrapup/default/990_copy_logfile.sh\r\n\r\n","created_at":"2018-05-08T13:51:08Z","updated_at":"2018-05-10T11:02:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7afd881aea61bcbadfdc76c9f076321640d3a11d","assignee":{"login":"jsmeix","id":1788608,"avatar_url":"https://avatars0.githubusercontent.com/u/1788608?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsmeix","id":1788608,"avatar_url":"https://avatars0.githubusercontent.com/u/1788608?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1741281,"url":"https://api.github.com/repos/rear/rear/labels/enhancement","name":"enhancement","color":"0000ff","default":true}],"milestone":{"url":"https://api.github.com/repos/rear/rear/milestones/15","html_url":"https://github.com/rear/rear/milestone/15","labels_url":"https://api.github.com/repos/rear/rear/milestones/15/labels","id":2824211,"number":15,"title":"ReaR v2.4","description":"As ReaR v2.3 will be released a month or so before FOSDEM 2018, we better move the 2.4 release a few months away","creator":{"login":"gdha","id":888633,"avatar_url":"https://avatars2.githubusercontent.com/u/888633?v=4","gravatar_id":"","url":"https://api.github.com/users/gdha","html_url":"https://github.com/gdha","followers_url":"https://api.github.com/users/gdha/followers","following_url":"https://api.github.com/users/gdha/following{/other_user}","gists_url":"https://api.github.com/users/gdha/gists{/gist_id}","starred_url":"https://api.github.com/users/gdha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdha/subscriptions","organizations_url":"https://api.github.com/users/gdha/orgs","repos_url":"https://api.github.com/users/gdha/repos","events_url":"https://api.github.com/users/gdha/events{/privacy}","received_events_url":"https://api.github.com/users/gdha/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":115,"state":"open","created_at":"2017-10-09T11:05:23Z","updated_at":"2018-05-10T08:42:26Z","due_on":"2018-05-26T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/rear/rear/pulls/1803/commits","review_comments_url":"https://api.github.com/repos/rear/rear/pulls/1803/comments","review_comment_url":"https://api.github.com/repos/rear/rear/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rear/rear/issues/1803/comments","statuses_url":"https://api.github.com/repos/rear/rear/statuses/0a4a6369779d70e990fbd61bed9592ac111a1c7c","head":{"label":"jsmeix:copy_backup_restore_log_into_recreated_system_related_to_pull_request_1797","ref":"copy_backup_restore_log_into_recreated_system_related_to_pull_request_1797","sha":"0a4a6369779d70e990fbd61bed9592ac111a1c7c","user":{"login":"jsmeix","id":1788608,"avatar_url":"https://avatars0.githubusercontent.com/u/1788608?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"repo":{"id":39959406,"name":"rear","full_name":"jsmeix/rear","owner":{"login":"jsmeix","id":1788608,"avatar_url":"https://avatars0.githubusercontent.com/u/1788608?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsmeix/rear","description":"Relax-and-Recover - Linux bare metal disaster recovery and system migration solution (cfr. mksysb, ignite)","fork":true,"url":"https://api.github.com/repos/jsmeix/rear","forks_url":"https://api.github.com/repos/jsmeix/rear/forks","keys_url":"https://api.github.com/repos/jsmeix/rear/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsmeix/rear/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsmeix/rear/teams","hooks_url":"https://api.github.com/repos/jsmeix/rear/hooks","issue_events_url":"https://api.github.com/repos/jsmeix/rear/issues/events{/number}","events_url":"https://api.github.com/repos/jsmeix/rear/events","assignees_url":"https://api.github.com/repos/jsmeix/rear/assignees{/user}","branches_url":"https://api.github.com/repos/jsmeix/rear/branches{/branch}","tags_url":"https://api.github.com/repos/jsmeix/rear/tags","blobs_url":"https://api.github.com/repos/jsmeix/rear/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsmeix/rear/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsmeix/rear/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsmeix/rear/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsmeix/rear/statuses/{sha}","languages_url":"https://api.github.com/repos/jsmeix/rear/languages","stargazers_url":"https://api.github.com/repos/jsmeix/rear/stargazers","contributors_url":"https://api.github.com/repos/jsmeix/rear/contributors","subscribers_url":"https://api.github.com/repos/jsmeix/rear/subscribers","subscription_url":"https://api.github.com/repos/jsmeix/rear/subscription","commits_url":"https://api.github.com/repos/jsmeix/rear/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsmeix/rear/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsmeix/rear/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsmeix/rear/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsmeix/rear/contents/{+path}","compare_url":"https://api.github.com/repos/jsmeix/rear/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsmeix/rear/merges","archive_url":"https://api.github.com/repos/jsmeix/rear/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsmeix/rear/downloads","issues_url":"https://api.github.com/repos/jsmeix/rear/issues{/number}","pulls_url":"https://api.github.com/repos/jsmeix/rear/pulls{/number}","milestones_url":"https://api.github.com/repos/jsmeix/rear/milestones{/number}","notifications_url":"https://api.github.com/repos/jsmeix/rear/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsmeix/rear/labels{/name}","releases_url":"https://api.github.com/repos/jsmeix/rear/releases{/id}","deployments_url":"https://api.github.com/repos/jsmeix/rear/deployments","created_at":"2015-07-30T16:02:09Z","updated_at":"2018-05-08T11:51:47Z","pushed_at":"2018-05-09T16:35:09Z","git_url":"git://github.com/jsmeix/rear.git","ssh_url":"git@github.com:jsmeix/rear.git","clone_url":"https://github.com/jsmeix/rear.git","svn_url":"https://github.com/jsmeix/rear","homepage":"http://relax-and-recover.org/","size":6576,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rear:master","ref":"master","sha":"ffde7c9cbcebe071016ba5d1c20cb9b96dc8fd65","user":{"login":"rear","id":1389578,"avatar_url":"https://avatars1.githubusercontent.com/u/1389578?v=4","gravatar_id":"","url":"https://api.github.com/users/rear","html_url":"https://github.com/rear","followers_url":"https://api.github.com/users/rear/followers","following_url":"https://api.github.com/users/rear/following{/other_user}","gists_url":"https://api.github.com/users/rear/gists{/gist_id}","starred_url":"https://api.github.com/users/rear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rear/subscriptions","organizations_url":"https://api.github.com/users/rear/orgs","repos_url":"https://api.github.com/users/rear/repos","events_url":"https://api.github.com/users/rear/events{/privacy}","received_events_url":"https://api.github.com/users/rear/received_events","type":"Organization","site_admin":false},"repo":{"id":3449791,"name":"rear","full_name":"rear/rear","owner":{"login":"rear","id":1389578,"avatar_url":"https://avatars1.githubusercontent.com/u/1389578?v=4","gravatar_id":"","url":"https://api.github.com/users/rear","html_url":"https://github.com/rear","followers_url":"https://api.github.com/users/rear/followers","following_url":"https://api.github.com/users/rear/following{/other_user}","gists_url":"https://api.github.com/users/rear/gists{/gist_id}","starred_url":"https://api.github.com/users/rear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rear/subscriptions","organizations_url":"https://api.github.com/users/rear/orgs","repos_url":"https://api.github.com/users/rear/repos","events_url":"https://api.github.com/users/rear/events{/privacy}","received_events_url":"https://api.github.com/users/rear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rear/rear","description":"Relax-and-Recover - Linux bare metal disaster recovery and system migration solution (cfr. mksysb, ignite)","fork":false,"url":"https://api.github.com/repos/rear/rear","forks_url":"https://api.github.com/repos/rear/rear/forks","keys_url":"https://api.github.com/repos/rear/rear/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rear/rear/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rear/rear/teams","hooks_url":"https://api.github.com/repos/rear/rear/hooks","issue_events_url":"https://api.github.com/repos/rear/rear/issues/events{/number}","events_url":"https://api.github.com/repos/rear/rear/events","assignees_url":"https://api.github.com/repos/rear/rear/assignees{/user}","branches_url":"https://api.github.com/repos/rear/rear/branches{/branch}","tags_url":"https://api.github.com/repos/rear/rear/tags","blobs_url":"https://api.github.com/repos/rear/rear/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rear/rear/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rear/rear/git/refs{/sha}","trees_url":"https://api.github.com/repos/rear/rear/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rear/rear/statuses/{sha}","languages_url":"https://api.github.com/repos/rear/rear/languages","stargazers_url":"https://api.github.com/repos/rear/rear/stargazers","contributors_url":"https://api.github.com/repos/rear/rear/contributors","subscribers_url":"https://api.github.com/repos/rear/rear/subscribers","subscription_url":"https://api.github.com/repos/rear/rear/subscription","commits_url":"https://api.github.com/repos/rear/rear/commits{/sha}","git_commits_url":"https://api.github.com/repos/rear/rear/git/commits{/sha}","comments_url":"https://api.github.com/repos/rear/rear/comments{/number}","issue_comment_url":"https://api.github.com/repos/rear/rear/issues/comments{/number}","contents_url":"https://api.github.com/repos/rear/rear/contents/{+path}","compare_url":"https://api.github.com/repos/rear/rear/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rear/rear/merges","archive_url":"https://api.github.com/repos/rear/rear/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rear/rear/downloads","issues_url":"https://api.github.com/repos/rear/rear/issues{/number}","pulls_url":"https://api.github.com/repos/rear/rear/pulls{/number}","milestones_url":"https://api.github.com/repos/rear/rear/milestones{/number}","notifications_url":"https://api.github.com/repos/rear/rear/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rear/rear/labels{/name}","releases_url":"https://api.github.com/repos/rear/rear/releases{/id}","deployments_url":"https://api.github.com/repos/rear/rear/deployments","created_at":"2012-02-15T13:44:45Z","updated_at":"2018-05-08T11:39:02Z","pushed_at":"2018-05-09T17:37:18Z","git_url":"git://github.com/rear/rear.git","ssh_url":"git@github.com:rear/rear.git","clone_url":"https://github.com/rear/rear.git","svn_url":"https://github.com/rear/rear","homepage":"http://relax-and-recover.org/","size":6536,"stargazers_count":303,"watchers_count":303,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":132,"open_issues":95,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rear/rear/pulls/1803"},"html":{"href":"https://github.com/rear/rear/pull/1803"},"issue":{"href":"https://api.github.com/repos/rear/rear/issues/1803"},"comments":{"href":"https://api.github.com/repos/rear/rear/issues/1803/comments"},"review_comments":{"href":"https://api.github.com/repos/rear/rear/pulls/1803/comments"},"review_comment":{"href":"https://api.github.com/repos/rear/rear/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rear/rear/pulls/1803/commits"},"statuses":{"href":"https://api.github.com/repos/rear/rear/statuses/0a4a6369779d70e990fbd61bed9592ac111a1c7c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"schabrolles"}}