{"action":"created","comment":{"url":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/comments/176684138","pull_request_review_id":106431600,"id":176684138,"diff_hunk":"@@ -185,23 +163,30 @@ var settings = {\n }\n \n // The rest is collections and can be stored in firestore\n-var personCollection = [\n+const personCollection = [\n   {\n     login: firebaseUserId, // Only for people with a login\n     name: 'Test User',\n     phone: '+62 123 123 123',\n     address: 'Jalan Batu Mejan No. 88, Canggu, Kuta Utara, Kabupaten Badung, Bali 80361',\n     email: 'some@address.com',\n-    geolaction: {\n+    geolocation: {\n       latitude: '8.39111',\n       longitude: '115.07361'\n     },\n-    type: 'employee | client | community manager | facility manager | super admin | village guy',\n+    type: {\n+      employee:false,\n+      client:false,\n+      community_manager:false,\n+      facility_manager:false,\n+      super_admin: true","path":"README.md","position":71,"original_position":71,"commit_id":"30039f771aef5d618a899e2621a7d19d5cd1ca8a","original_commit_id":"30039f771aef5d618a899e2621a7d19d5cd1ca8a","user":{"login":"nicksarafa","id":7340254,"avatar_url":"https://avatars1.githubusercontent.com/u/7340254?v=4","gravatar_id":"","url":"https://api.github.com/users/nicksarafa","html_url":"https://github.com/nicksarafa","followers_url":"https://api.github.com/users/nicksarafa/followers","following_url":"https://api.github.com/users/nicksarafa/following{/other_user}","gists_url":"https://api.github.com/users/nicksarafa/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksarafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksarafa/subscriptions","organizations_url":"https://api.github.com/users/nicksarafa/orgs","repos_url":"https://api.github.com/users/nicksarafa/repos","events_url":"https://api.github.com/users/nicksarafa/events{/privacy}","received_events_url":"https://api.github.com/users/nicksarafa/received_events","type":"User","site_admin":false},"body":"unless there is overlap between these permissions, i think its okay to keep the `personCollection.type` set to a string rather than passing in a nested boolean. @piggydoughnut are you sure about this change? if you are, you have my full support, but it feels off","created_at":"2018-03-23T09:53:11Z","updated_at":"2018-03-23T09:53:11Z","html_url":"https://github.com/MPH-Bali/green-village-project/pull/28#discussion_r176684138","pull_request_url":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/28","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/comments/176684138"},"html":{"href":"https://github.com/MPH-Bali/green-village-project/pull/28#discussion_r176684138"},"pull_request":{"href":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/28"}},"in_reply_to_id":176683765},"pull_request":{"url":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/28","id":177011984,"html_url":"https://github.com/MPH-Bali/green-village-project/pull/28","diff_url":"https://github.com/MPH-Bali/green-village-project/pull/28.diff","patch_url":"https://github.com/MPH-Bali/green-village-project/pull/28.patch","issue_url":"https://api.github.com/repos/MPH-Bali/green-village-project/issues/28","number":28,"state":"open","locked":false,"title":"more Setup","user":{"login":"piggydoughnut","id":2395326,"avatar_url":"https://avatars0.githubusercontent.com/u/2395326?v=4","gravatar_id":"","url":"https://api.github.com/users/piggydoughnut","html_url":"https://github.com/piggydoughnut","followers_url":"https://api.github.com/users/piggydoughnut/followers","following_url":"https://api.github.com/users/piggydoughnut/following{/other_user}","gists_url":"https://api.github.com/users/piggydoughnut/gists{/gist_id}","starred_url":"https://api.github.com/users/piggydoughnut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piggydoughnut/subscriptions","organizations_url":"https://api.github.com/users/piggydoughnut/orgs","repos_url":"https://api.github.com/users/piggydoughnut/repos","events_url":"https://api.github.com/users/piggydoughnut/events{/privacy}","received_events_url":"https://api.github.com/users/piggydoughnut/received_events","type":"User","site_admin":false},"body":"README changes\r\n\r\ncorrect eslint file extension\r\n\r\nchanges in sample data - added feeCollection\r\n\r\nsample cloud function","created_at":"2018-03-23T09:23:20Z","updated_at":"2018-03-23T09:53:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b39d94e761d3d3cdc40270b3808a6b7f6bf858c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/28/commits","review_comments_url":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/28/comments","review_comment_url":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MPH-Bali/green-village-project/issues/28/comments","statuses_url":"https://api.github.com/repos/MPH-Bali/green-village-project/statuses/30039f771aef5d618a899e2621a7d19d5cd1ca8a","head":{"label":"MPH-Bali:functions_init_setup","ref":"functions_init_setup","sha":"30039f771aef5d618a899e2621a7d19d5cd1ca8a","user":{"login":"MPH-Bali","id":36029458,"avatar_url":"https://avatars3.githubusercontent.com/u/36029458?v=4","gravatar_id":"","url":"https://api.github.com/users/MPH-Bali","html_url":"https://github.com/MPH-Bali","followers_url":"https://api.github.com/users/MPH-Bali/followers","following_url":"https://api.github.com/users/MPH-Bali/following{/other_user}","gists_url":"https://api.github.com/users/MPH-Bali/gists{/gist_id}","starred_url":"https://api.github.com/users/MPH-Bali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MPH-Bali/subscriptions","organizations_url":"https://api.github.com/users/MPH-Bali/orgs","repos_url":"https://api.github.com/users/MPH-Bali/repos","events_url":"https://api.github.com/users/MPH-Bali/events{/privacy}","received_events_url":"https://api.github.com/users/MPH-Bali/received_events","type":"Organization","site_admin":false},"repo":{"id":119803891,"name":"green-village-project","full_name":"MPH-Bali/green-village-project","owner":{"login":"MPH-Bali","id":36029458,"avatar_url":"https://avatars3.githubusercontent.com/u/36029458?v=4","gravatar_id":"","url":"https://api.github.com/users/MPH-Bali","html_url":"https://github.com/MPH-Bali","followers_url":"https://api.github.com/users/MPH-Bali/followers","following_url":"https://api.github.com/users/MPH-Bali/following{/other_user}","gists_url":"https://api.github.com/users/MPH-Bali/gists{/gist_id}","starred_url":"https://api.github.com/users/MPH-Bali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MPH-Bali/subscriptions","organizations_url":"https://api.github.com/users/MPH-Bali/orgs","repos_url":"https://api.github.com/users/MPH-Bali/repos","events_url":"https://api.github.com/users/MPH-Bali/events{/privacy}","received_events_url":"https://api.github.com/users/MPH-Bali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MPH-Bali/green-village-project","description":"Powering MPH recycling and composting facilities in Bali","fork":false,"url":"https://api.github.com/repos/MPH-Bali/green-village-project","forks_url":"https://api.github.com/repos/MPH-Bali/green-village-project/forks","keys_url":"https://api.github.com/repos/MPH-Bali/green-village-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MPH-Bali/green-village-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MPH-Bali/green-village-project/teams","hooks_url":"https://api.github.com/repos/MPH-Bali/green-village-project/hooks","issue_events_url":"https://api.github.com/repos/MPH-Bali/green-village-project/issues/events{/number}","events_url":"https://api.github.com/repos/MPH-Bali/green-village-project/events","assignees_url":"https://api.github.com/repos/MPH-Bali/green-village-project/assignees{/user}","branches_url":"https://api.github.com/repos/MPH-Bali/green-village-project/branches{/branch}","tags_url":"https://api.github.com/repos/MPH-Bali/green-village-project/tags","blobs_url":"https://api.github.com/repos/MPH-Bali/green-village-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MPH-Bali/green-village-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MPH-Bali/green-village-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/MPH-Bali/green-village-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MPH-Bali/green-village-project/statuses/{sha}","languages_url":"https://api.github.com/repos/MPH-Bali/green-village-project/languages","stargazers_url":"https://api.github.com/repos/MPH-Bali/green-village-project/stargazers","contributors_url":"https://api.github.com/repos/MPH-Bali/green-village-project/contributors","subscribers_url":"https://api.github.com/repos/MPH-Bali/green-village-project/subscribers","subscription_url":"https://api.github.com/repos/MPH-Bali/green-village-project/subscription","commits_url":"https://api.github.com/repos/MPH-Bali/green-village-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/MPH-Bali/green-village-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/MPH-Bali/green-village-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/MPH-Bali/green-village-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/MPH-Bali/green-village-project/contents/{+path}","compare_url":"https://api.github.com/repos/MPH-Bali/green-village-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MPH-Bali/green-village-project/merges","archive_url":"https://api.github.com/repos/MPH-Bali/green-village-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MPH-Bali/green-village-project/downloads","issues_url":"https://api.github.com/repos/MPH-Bali/green-village-project/issues{/number}","pulls_url":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls{/number}","milestones_url":"https://api.github.com/repos/MPH-Bali/green-village-project/milestones{/number}","notifications_url":"https://api.github.com/repos/MPH-Bali/green-village-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MPH-Bali/green-village-project/labels{/name}","releases_url":"https://api.github.com/repos/MPH-Bali/green-village-project/releases{/id}","deployments_url":"https://api.github.com/repos/MPH-Bali/green-village-project/deployments","created_at":"2018-02-01T08:07:52Z","updated_at":"2018-03-22T07:37:44Z","pushed_at":"2018-03-23T09:23:21Z","git_url":"git://github.com/MPH-Bali/green-village-project.git","ssh_url":"git@github.com:MPH-Bali/green-village-project.git","clone_url":"https://github.com/MPH-Bali/green-village-project.git","svn_url":"https://github.com/MPH-Bali/green-village-project","homepage":null,"size":335,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":2,"open_issues":22,"watchers":2,"default_branch":"develop"}},"base":{"label":"MPH-Bali:develop","ref":"develop","sha":"989c949bd4e907911c36050a64ece44219d87bc2","user":{"login":"MPH-Bali","id":36029458,"avatar_url":"https://avatars3.githubusercontent.com/u/36029458?v=4","gravatar_id":"","url":"https://api.github.com/users/MPH-Bali","html_url":"https://github.com/MPH-Bali","followers_url":"https://api.github.com/users/MPH-Bali/followers","following_url":"https://api.github.com/users/MPH-Bali/following{/other_user}","gists_url":"https://api.github.com/users/MPH-Bali/gists{/gist_id}","starred_url":"https://api.github.com/users/MPH-Bali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MPH-Bali/subscriptions","organizations_url":"https://api.github.com/users/MPH-Bali/orgs","repos_url":"https://api.github.com/users/MPH-Bali/repos","events_url":"https://api.github.com/users/MPH-Bali/events{/privacy}","received_events_url":"https://api.github.com/users/MPH-Bali/received_events","type":"Organization","site_admin":false},"repo":{"id":119803891,"name":"green-village-project","full_name":"MPH-Bali/green-village-project","owner":{"login":"MPH-Bali","id":36029458,"avatar_url":"https://avatars3.githubusercontent.com/u/36029458?v=4","gravatar_id":"","url":"https://api.github.com/users/MPH-Bali","html_url":"https://github.com/MPH-Bali","followers_url":"https://api.github.com/users/MPH-Bali/followers","following_url":"https://api.github.com/users/MPH-Bali/following{/other_user}","gists_url":"https://api.github.com/users/MPH-Bali/gists{/gist_id}","starred_url":"https://api.github.com/users/MPH-Bali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MPH-Bali/subscriptions","organizations_url":"https://api.github.com/users/MPH-Bali/orgs","repos_url":"https://api.github.com/users/MPH-Bali/repos","events_url":"https://api.github.com/users/MPH-Bali/events{/privacy}","received_events_url":"https://api.github.com/users/MPH-Bali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MPH-Bali/green-village-project","description":"Powering MPH recycling and composting facilities in Bali","fork":false,"url":"https://api.github.com/repos/MPH-Bali/green-village-project","forks_url":"https://api.github.com/repos/MPH-Bali/green-village-project/forks","keys_url":"https://api.github.com/repos/MPH-Bali/green-village-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MPH-Bali/green-village-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MPH-Bali/green-village-project/teams","hooks_url":"https://api.github.com/repos/MPH-Bali/green-village-project/hooks","issue_events_url":"https://api.github.com/repos/MPH-Bali/green-village-project/issues/events{/number}","events_url":"https://api.github.com/repos/MPH-Bali/green-village-project/events","assignees_url":"https://api.github.com/repos/MPH-Bali/green-village-project/assignees{/user}","branches_url":"https://api.github.com/repos/MPH-Bali/green-village-project/branches{/branch}","tags_url":"https://api.github.com/repos/MPH-Bali/green-village-project/tags","blobs_url":"https://api.github.com/repos/MPH-Bali/green-village-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MPH-Bali/green-village-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MPH-Bali/green-village-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/MPH-Bali/green-village-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MPH-Bali/green-village-project/statuses/{sha}","languages_url":"https://api.github.com/repos/MPH-Bali/green-village-project/languages","stargazers_url":"https://api.github.com/repos/MPH-Bali/green-village-project/stargazers","contributors_url":"https://api.github.com/repos/MPH-Bali/green-village-project/contributors","subscribers_url":"https://api.github.com/repos/MPH-Bali/green-village-project/subscribers","subscription_url":"https://api.github.com/repos/MPH-Bali/green-village-project/subscription","commits_url":"https://api.github.com/repos/MPH-Bali/green-village-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/MPH-Bali/green-village-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/MPH-Bali/green-village-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/MPH-Bali/green-village-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/MPH-Bali/green-village-project/contents/{+path}","compare_url":"https://api.github.com/repos/MPH-Bali/green-village-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MPH-Bali/green-village-project/merges","archive_url":"https://api.github.com/repos/MPH-Bali/green-village-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MPH-Bali/green-village-project/downloads","issues_url":"https://api.github.com/repos/MPH-Bali/green-village-project/issues{/number}","pulls_url":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls{/number}","milestones_url":"https://api.github.com/repos/MPH-Bali/green-village-project/milestones{/number}","notifications_url":"https://api.github.com/repos/MPH-Bali/green-village-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MPH-Bali/green-village-project/labels{/name}","releases_url":"https://api.github.com/repos/MPH-Bali/green-village-project/releases{/id}","deployments_url":"https://api.github.com/repos/MPH-Bali/green-village-project/deployments","created_at":"2018-02-01T08:07:52Z","updated_at":"2018-03-22T07:37:44Z","pushed_at":"2018-03-23T09:23:21Z","git_url":"git://github.com/MPH-Bali/green-village-project.git","ssh_url":"git@github.com:MPH-Bali/green-village-project.git","clone_url":"https://github.com/MPH-Bali/green-village-project.git","svn_url":"https://github.com/MPH-Bali/green-village-project","homepage":null,"size":335,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":2,"open_issues":22,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/28"},"html":{"href":"https://github.com/MPH-Bali/green-village-project/pull/28"},"issue":{"href":"https://api.github.com/repos/MPH-Bali/green-village-project/issues/28"},"comments":{"href":"https://api.github.com/repos/MPH-Bali/green-village-project/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MPH-Bali/green-village-project/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/MPH-Bali/green-village-project/statuses/30039f771aef5d618a899e2621a7d19d5cd1ca8a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nicksarafa"}}