{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/jinzhu/now/pulls/19","id":125679474,"html_url":"https://github.com/jinzhu/now/pull/19","diff_url":"https://github.com/jinzhu/now/pull/19.diff","patch_url":"https://github.com/jinzhu/now/pull/19.patch","issue_url":"https://api.github.com/repos/jinzhu/now/issues/19","number":19,"state":"closed","locked":false,"title":"Added WeekStartDay so that any day can be the start of the week. ","user":{"login":"ThatEric","id":2856176,"avatar_url":"https://avatars2.githubusercontent.com/u/2856176?v=4","gravatar_id":"","url":"https://api.github.com/users/ThatEric","html_url":"https://github.com/ThatEric","followers_url":"https://api.github.com/users/ThatEric/followers","following_url":"https://api.github.com/users/ThatEric/following{/other_user}","gists_url":"https://api.github.com/users/ThatEric/gists{/gist_id}","starred_url":"https://api.github.com/users/ThatEric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThatEric/subscriptions","organizations_url":"https://api.github.com/users/ThatEric/orgs","repos_url":"https://api.github.com/users/ThatEric/repos","events_url":"https://api.github.com/users/ThatEric/events{/privacy}","received_events_url":"https://api.github.com/users/ThatEric/received_events","type":"User","site_admin":false},"body":"My use case is that we let clients choose whatever start of week they want so it makes the BeginningOfWeek method not usable in some instances.\r\n\r\nAllowing the user to set the week start as time.Monday is a little more elegant than setting a bool in my opinion. So although most people won't want the start of week to be Tuesday, this code change can still be viewed as an improvement.","created_at":"2017-06-14T19:55:54Z","updated_at":"2018-03-14T00:45:07Z","closed_at":"2018-03-14T00:45:06Z","merged_at":"2018-03-14T00:45:06Z","merge_commit_sha":"f992845dda920517ba87dc854cf3c96b748dd8f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jinzhu/now/pulls/19/commits","review_comments_url":"https://api.github.com/repos/jinzhu/now/pulls/19/comments","review_comment_url":"https://api.github.com/repos/jinzhu/now/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jinzhu/now/issues/19/comments","statuses_url":"https://api.github.com/repos/jinzhu/now/statuses/9da05f45388181152f0a0b78585060f7502c6fbd","head":{"label":"ThatEric:master","ref":"master","sha":"9da05f45388181152f0a0b78585060f7502c6fbd","user":{"login":"ThatEric","id":2856176,"avatar_url":"https://avatars2.githubusercontent.com/u/2856176?v=4","gravatar_id":"","url":"https://api.github.com/users/ThatEric","html_url":"https://github.com/ThatEric","followers_url":"https://api.github.com/users/ThatEric/followers","following_url":"https://api.github.com/users/ThatEric/following{/other_user}","gists_url":"https://api.github.com/users/ThatEric/gists{/gist_id}","starred_url":"https://api.github.com/users/ThatEric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThatEric/subscriptions","organizations_url":"https://api.github.com/users/ThatEric/orgs","repos_url":"https://api.github.com/users/ThatEric/repos","events_url":"https://api.github.com/users/ThatEric/events{/privacy}","received_events_url":"https://api.github.com/users/ThatEric/received_events","type":"User","site_admin":false},"repo":{"id":94367031,"name":"now","full_name":"ThatEric/now","owner":{"login":"ThatEric","id":2856176,"avatar_url":"https://avatars2.githubusercontent.com/u/2856176?v=4","gravatar_id":"","url":"https://api.github.com/users/ThatEric","html_url":"https://github.com/ThatEric","followers_url":"https://api.github.com/users/ThatEric/followers","following_url":"https://api.github.com/users/ThatEric/following{/other_user}","gists_url":"https://api.github.com/users/ThatEric/gists{/gist_id}","starred_url":"https://api.github.com/users/ThatEric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThatEric/subscriptions","organizations_url":"https://api.github.com/users/ThatEric/orgs","repos_url":"https://api.github.com/users/ThatEric/repos","events_url":"https://api.github.com/users/ThatEric/events{/privacy}","received_events_url":"https://api.github.com/users/ThatEric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThatEric/now","description":"Now is a time toolkit for golang","fork":true,"url":"https://api.github.com/repos/ThatEric/now","forks_url":"https://api.github.com/repos/ThatEric/now/forks","keys_url":"https://api.github.com/repos/ThatEric/now/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThatEric/now/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThatEric/now/teams","hooks_url":"https://api.github.com/repos/ThatEric/now/hooks","issue_events_url":"https://api.github.com/repos/ThatEric/now/issues/events{/number}","events_url":"https://api.github.com/repos/ThatEric/now/events","assignees_url":"https://api.github.com/repos/ThatEric/now/assignees{/user}","branches_url":"https://api.github.com/repos/ThatEric/now/branches{/branch}","tags_url":"https://api.github.com/repos/ThatEric/now/tags","blobs_url":"https://api.github.com/repos/ThatEric/now/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThatEric/now/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThatEric/now/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThatEric/now/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThatEric/now/statuses/{sha}","languages_url":"https://api.github.com/repos/ThatEric/now/languages","stargazers_url":"https://api.github.com/repos/ThatEric/now/stargazers","contributors_url":"https://api.github.com/repos/ThatEric/now/contributors","subscribers_url":"https://api.github.com/repos/ThatEric/now/subscribers","subscription_url":"https://api.github.com/repos/ThatEric/now/subscription","commits_url":"https://api.github.com/repos/ThatEric/now/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThatEric/now/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThatEric/now/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThatEric/now/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThatEric/now/contents/{+path}","compare_url":"https://api.github.com/repos/ThatEric/now/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThatEric/now/merges","archive_url":"https://api.github.com/repos/ThatEric/now/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThatEric/now/downloads","issues_url":"https://api.github.com/repos/ThatEric/now/issues{/number}","pulls_url":"https://api.github.com/repos/ThatEric/now/pulls{/number}","milestones_url":"https://api.github.com/repos/ThatEric/now/milestones{/number}","notifications_url":"https://api.github.com/repos/ThatEric/now/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThatEric/now/labels{/name}","releases_url":"https://api.github.com/repos/ThatEric/now/releases{/id}","deployments_url":"https://api.github.com/repos/ThatEric/now/deployments","created_at":"2017-06-14T19:42:13Z","updated_at":"2018-03-14T00:44:11Z","pushed_at":"2018-03-14T00:44:10Z","git_url":"git://github.com/ThatEric/now.git","ssh_url":"git@github.com:ThatEric/now.git","clone_url":"https://github.com/ThatEric/now.git","svn_url":"https://github.com/ThatEric/now","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jinzhu:master","ref":"master","sha":"d0d89933cb0e984452409d4a6a595df4b3b78a6f","user":{"login":"jinzhu","id":6843,"avatar_url":"https://avatars3.githubusercontent.com/u/6843?v=4","gravatar_id":"","url":"https://api.github.com/users/jinzhu","html_url":"https://github.com/jinzhu","followers_url":"https://api.github.com/users/jinzhu/followers","following_url":"https://api.github.com/users/jinzhu/following{/other_user}","gists_url":"https://api.github.com/users/jinzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/jinzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinzhu/subscriptions","organizations_url":"https://api.github.com/users/jinzhu/orgs","repos_url":"https://api.github.com/users/jinzhu/repos","events_url":"https://api.github.com/users/jinzhu/events{/privacy}","received_events_url":"https://api.github.com/users/jinzhu/received_events","type":"User","site_admin":false},"repo":{"id":14489838,"name":"now","full_name":"jinzhu/now","owner":{"login":"jinzhu","id":6843,"avatar_url":"https://avatars3.githubusercontent.com/u/6843?v=4","gravatar_id":"","url":"https://api.github.com/users/jinzhu","html_url":"https://github.com/jinzhu","followers_url":"https://api.github.com/users/jinzhu/followers","following_url":"https://api.github.com/users/jinzhu/following{/other_user}","gists_url":"https://api.github.com/users/jinzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/jinzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinzhu/subscriptions","organizations_url":"https://api.github.com/users/jinzhu/orgs","repos_url":"https://api.github.com/users/jinzhu/repos","events_url":"https://api.github.com/users/jinzhu/events{/privacy}","received_events_url":"https://api.github.com/users/jinzhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jinzhu/now","description":"Now is a time toolkit for golang","fork":false,"url":"https://api.github.com/repos/jinzhu/now","forks_url":"https://api.github.com/repos/jinzhu/now/forks","keys_url":"https://api.github.com/repos/jinzhu/now/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jinzhu/now/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jinzhu/now/teams","hooks_url":"https://api.github.com/repos/jinzhu/now/hooks","issue_events_url":"https://api.github.com/repos/jinzhu/now/issues/events{/number}","events_url":"https://api.github.com/repos/jinzhu/now/events","assignees_url":"https://api.github.com/repos/jinzhu/now/assignees{/user}","branches_url":"https://api.github.com/repos/jinzhu/now/branches{/branch}","tags_url":"https://api.github.com/repos/jinzhu/now/tags","blobs_url":"https://api.github.com/repos/jinzhu/now/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jinzhu/now/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jinzhu/now/git/refs{/sha}","trees_url":"https://api.github.com/repos/jinzhu/now/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jinzhu/now/statuses/{sha}","languages_url":"https://api.github.com/repos/jinzhu/now/languages","stargazers_url":"https://api.github.com/repos/jinzhu/now/stargazers","contributors_url":"https://api.github.com/repos/jinzhu/now/contributors","subscribers_url":"https://api.github.com/repos/jinzhu/now/subscribers","subscription_url":"https://api.github.com/repos/jinzhu/now/subscription","commits_url":"https://api.github.com/repos/jinzhu/now/commits{/sha}","git_commits_url":"https://api.github.com/repos/jinzhu/now/git/commits{/sha}","comments_url":"https://api.github.com/repos/jinzhu/now/comments{/number}","issue_comment_url":"https://api.github.com/repos/jinzhu/now/issues/comments{/number}","contents_url":"https://api.github.com/repos/jinzhu/now/contents/{+path}","compare_url":"https://api.github.com/repos/jinzhu/now/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jinzhu/now/merges","archive_url":"https://api.github.com/repos/jinzhu/now/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jinzhu/now/downloads","issues_url":"https://api.github.com/repos/jinzhu/now/issues{/number}","pulls_url":"https://api.github.com/repos/jinzhu/now/pulls{/number}","milestones_url":"https://api.github.com/repos/jinzhu/now/milestones{/number}","notifications_url":"https://api.github.com/repos/jinzhu/now/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jinzhu/now/labels{/name}","releases_url":"https://api.github.com/repos/jinzhu/now/releases{/id}","deployments_url":"https://api.github.com/repos/jinzhu/now/deployments","created_at":"2013-11-18T10:55:30Z","updated_at":"2018-03-14T00:40:10Z","pushed_at":"2018-03-14T00:45:06Z","git_url":"git://github.com/jinzhu/now.git","ssh_url":"git@github.com:jinzhu/now.git","clone_url":"https://github.com/jinzhu/now.git","svn_url":"https://github.com/jinzhu/now","homepage":null,"size":38,"stargazers_count":1290,"watchers_count":1290,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":75,"open_issues":11,"watchers":1290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jinzhu/now/pulls/19"},"html":{"href":"https://github.com/jinzhu/now/pull/19"},"issue":{"href":"https://api.github.com/repos/jinzhu/now/issues/19"},"comments":{"href":"https://api.github.com/repos/jinzhu/now/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/jinzhu/now/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/jinzhu/now/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jinzhu/now/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/jinzhu/now/statuses/9da05f45388181152f0a0b78585060f7502c6fbd"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jinzhu","id":6843,"avatar_url":"https://avatars3.githubusercontent.com/u/6843?v=4","gravatar_id":"","url":"https://api.github.com/users/jinzhu","html_url":"https://github.com/jinzhu","followers_url":"https://api.github.com/users/jinzhu/followers","following_url":"https://api.github.com/users/jinzhu/following{/other_user}","gists_url":"https://api.github.com/users/jinzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/jinzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinzhu/subscriptions","organizations_url":"https://api.github.com/users/jinzhu/orgs","repos_url":"https://api.github.com/users/jinzhu/repos","events_url":"https://api.github.com/users/jinzhu/events{/privacy}","received_events_url":"https://api.github.com/users/jinzhu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":98,"deletions":44,"changed_files":4}}
{"actor":{"display_login":"jinzhu"}}