{"action":"created","issue":{"url":"https://api.github.com/repos/code16/sharp/issues/32","repository_url":"https://api.github.com/repos/code16/sharp","labels_url":"https://api.github.com/repos/code16/sharp/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/code16/sharp/issues/32/comments","events_url":"https://api.github.com/repos/code16/sharp/issues/32/events","html_url":"https://github.com/code16/sharp/pull/32","id":325896618,"number":32,"title":"Custom assets may be injected by defining their paths in the config","user":{"login":"mdcass","id":13783325,"avatar_url":"https://avatars2.githubusercontent.com/u/13783325?v=4","gravatar_id":"","url":"https://api.github.com/users/mdcass","html_url":"https://github.com/mdcass","followers_url":"https://api.github.com/users/mdcass/followers","following_url":"https://api.github.com/users/mdcass/following{/other_user}","gists_url":"https://api.github.com/users/mdcass/gists{/gist_id}","starred_url":"https://api.github.com/users/mdcass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdcass/subscriptions","organizations_url":"https://api.github.com/users/mdcass/orgs","repos_url":"https://api.github.com/users/mdcass/repos","events_url":"https://api.github.com/users/mdcass/events{/privacy}","received_events_url":"https://api.github.com/users/mdcass/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-05-23T22:30:01Z","updated_at":"2018-05-24T22:12:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/code16/sharp/pulls/32","html_url":"https://github.com/code16/sharp/pull/32","diff_url":"https://github.com/code16/sharp/pull/32.diff","patch_url":"https://github.com/code16/sharp/pull/32.patch"},"body":"Hi,\r\n\r\n# Requirement\r\n\r\nI required the ability to add custom assets to the base layout\r\n\r\n## Notes\r\n\r\n* I appreciate this functionality could cover a broad scope, I opted for a simple implementation to start with\r\n* I wasn't sure whether the documentation should live in the place that i've put it, open to suggestions\r\n* I wasn't sure whether there would be implications with including the view composer in [all views](https://github.com/mdcass/sharp/commit/bda06dc4b50d5bee2b246763ca2b5b086729abae#diff-e6e21d24614b09ab3bfa2d2ce37af9f9R53)\r\n* I wasn't sure what the best location for a test would be\r\n* The current test doesn't cover injecting assets using the Laravel `asset()` or `mix()` functions, as I felt attempting to mock those may make the tests lengthy and obsolete when they're a core part of the framework\r\n\r\nFeedback appreciated!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/code16/sharp/issues/comments/391882150","html_url":"https://github.com/code16/sharp/pull/32#issuecomment-391882150","issue_url":"https://api.github.com/repos/code16/sharp/issues/32","id":391882150,"user":{"login":"mdcass","id":13783325,"avatar_url":"https://avatars2.githubusercontent.com/u/13783325?v=4","gravatar_id":"","url":"https://api.github.com/users/mdcass","html_url":"https://github.com/mdcass","followers_url":"https://api.github.com/users/mdcass/followers","following_url":"https://api.github.com/users/mdcass/following{/other_user}","gists_url":"https://api.github.com/users/mdcass/gists{/gist_id}","starred_url":"https://api.github.com/users/mdcass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdcass/subscriptions","organizations_url":"https://api.github.com/users/mdcass/orgs","repos_url":"https://api.github.com/users/mdcass/repos","events_url":"https://api.github.com/users/mdcass/events{/privacy}","received_events_url":"https://api.github.com/users/mdcass/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T22:12:00Z","updated_at":"2018-05-24T22:12:00Z","author_association":"CONTRIBUTOR","body":"I've added a small change to the `sharp.js` asset which was part of the previous pull request (link command) but I missed off the compiled JS (sorry!)"}}
{"actor":{"display_login":"mdcass"}}