{"action":"created","comment":{"url":"https://api.github.com/repos/personalrobotics/aikido/pulls/comments/171993517","pull_request_review_id":100950089,"id":171993517,"diff_hunk":"@@ -60,27 +60,26 @@ class CollisionFree : public Testable\n   std::unique_ptr<TestableOutcome> createOutcome() const override;\n \n   /// Checks collision between group1 and group2.\n-  /// \\param group1 First collision group.\n-  /// \\param group2 Second collision group.\n+  /// \\param _group1 First collision group.\n+  /// \\param _group2 Second collision group.\n   void addPairwiseCheck(\n       std::shared_ptr<::dart::collision::CollisionGroup> _group1,\n       std::shared_ptr<::dart::collision::CollisionGroup> _group2);\n \n   /// Remove collision check between group1 and group2.\n-  /// \\param group1 First collision group.\n-  /// \\param group2 Second collision group.\n+  /// \\param _group1 First collision group.\n+  /// \\param _group2 Second collision group.\n   void removePairwiseCheck(\n       std::shared_ptr<::dart::collision::CollisionGroup> _group1,\n       std::shared_ptr<::dart::collision::CollisionGroup> _group2);\n \n   /// Checks collision within group.\n-  /// \\param group Collision group.\n-  void addSelfCheck(std::shared_ptr<::dart::collision::CollisionGroup> _group);\n+  /// \\param _group Collision group.\n+  void addSelfCheck(std::shared_ptr<dart::collision::CollisionGroup> _group);\n \n   /// Remove self-collision check within group.\n-  /// \\param group Collision group.\n-  void removeSelfCheck(\n-      std::shared_ptr<::dart::collision::CollisionGroup> _group);\n+  /// \\param _group Collision group.\n+  void removeSelfCheck(std::shared_ptr<dart::collision::CollisionGroup> _group);","path":"include/aikido/constraint/dart/CollisionFree.hpp","position":32,"original_position":32,"commit_id":"decbe7f208e69f521731b8476b2696fabf7d5cae","original_commit_id":"decbe7f208e69f521731b8476b2696fabf7d5cae","user":{"login":"jslee02","id":4038467,"avatar_url":"https://avatars3.githubusercontent.com/u/4038467?v=4","gravatar_id":"","url":"https://api.github.com/users/jslee02","html_url":"https://github.com/jslee02","followers_url":"https://api.github.com/users/jslee02/followers","following_url":"https://api.github.com/users/jslee02/following{/other_user}","gists_url":"https://api.github.com/users/jslee02/gists{/gist_id}","starred_url":"https://api.github.com/users/jslee02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslee02/subscriptions","organizations_url":"https://api.github.com/users/jslee02/orgs","repos_url":"https://api.github.com/users/jslee02/repos","events_url":"https://api.github.com/users/jslee02/events{/privacy}","received_events_url":"https://api.github.com/users/jslee02/received_events","type":"User","site_admin":false},"body":"Nit: Was this one of the reasons of the Doxygen warnings? We used global namespace resolutions for dart (i.e., `::dart`) to avoid conflicts with `::aikido::constraint::dart`. It might be good to leave it as it was if it's not a cause of the warnings.","created_at":"2018-03-03T00:06:50Z","updated_at":"2018-03-03T00:51:10Z","html_url":"https://github.com/personalrobotics/aikido/pull/357#discussion_r171993517","pull_request_url":"https://api.github.com/repos/personalrobotics/aikido/pulls/357","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/comments/171993517"},"html":{"href":"https://github.com/personalrobotics/aikido/pull/357#discussion_r171993517"},"pull_request":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/357"}}},"pull_request":{"url":"https://api.github.com/repos/personalrobotics/aikido/pulls/357","id":172621955,"html_url":"https://github.com/personalrobotics/aikido/pull/357","diff_url":"https://github.com/personalrobotics/aikido/pull/357.diff","patch_url":"https://github.com/personalrobotics/aikido/pull/357.patch","issue_url":"https://api.github.com/repos/personalrobotics/aikido/issues/357","number":357,"state":"open","locked":false,"title":"[WIP] Squash doxygen errors.","user":{"login":"sniyaz","id":8022223,"avatar_url":"https://avatars3.githubusercontent.com/u/8022223?v=4","gravatar_id":"","url":"https://api.github.com/users/sniyaz","html_url":"https://github.com/sniyaz","followers_url":"https://api.github.com/users/sniyaz/followers","following_url":"https://api.github.com/users/sniyaz/following{/other_user}","gists_url":"https://api.github.com/users/sniyaz/gists{/gist_id}","starred_url":"https://api.github.com/users/sniyaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sniyaz/subscriptions","organizations_url":"https://api.github.com/users/sniyaz/orgs","repos_url":"https://api.github.com/users/sniyaz/repos","events_url":"https://api.github.com/users/sniyaz/events{/privacy}","received_events_url":"https://api.github.com/users/sniyaz/received_events","type":"User","site_admin":false},"body":"See https://github.com/personalrobotics/aikido/issues/329.\r\n\r\nThis mainly involved fixing some doc-strings and renaming parameters. \r\n\r\n**TODO:** I had some trouble squashing the warnings involving `SplineTrajectory-impl.hpp.` @jslee02 and other people who know doxygen better, could take a look? There doesn't appear to be an documentation in that file at all, so I'm confused 😖 \r\n\r\n***\r\n\r\n**Before creating a pull request**\r\n\r\n- [x] Document new methods and classes\r\n- [x] Format code with `make format`\r\n\r\n**Before merging a pull request**\r\n\r\n- [ ] Set version target by selecting a milestone on the right side\r\n- [ ] Summarize this change in `CHANGELOG.md`\r\n- [ ] Add unit test(s) for this change\r\n","created_at":"2018-03-02T22:37:54Z","updated_at":"2018-03-03T00:51:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd5699afe833815ea20b49c1b090a57b8968221f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brianhou","id":2406919,"avatar_url":"https://avatars0.githubusercontent.com/u/2406919?v=4","gravatar_id":"","url":"https://api.github.com/users/brianhou","html_url":"https://github.com/brianhou","followers_url":"https://api.github.com/users/brianhou/followers","following_url":"https://api.github.com/users/brianhou/following{/other_user}","gists_url":"https://api.github.com/users/brianhou/gists{/gist_id}","starred_url":"https://api.github.com/users/brianhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianhou/subscriptions","organizations_url":"https://api.github.com/users/brianhou/orgs","repos_url":"https://api.github.com/users/brianhou/repos","events_url":"https://api.github.com/users/brianhou/events{/privacy}","received_events_url":"https://api.github.com/users/brianhou/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/personalrobotics/aikido/pulls/357/commits","review_comments_url":"https://api.github.com/repos/personalrobotics/aikido/pulls/357/comments","review_comment_url":"https://api.github.com/repos/personalrobotics/aikido/pulls/comments{/number}","comments_url":"https://api.github.com/repos/personalrobotics/aikido/issues/357/comments","statuses_url":"https://api.github.com/repos/personalrobotics/aikido/statuses/decbe7f208e69f521731b8476b2696fabf7d5cae","head":{"label":"personalrobotics:sniyaz/doxygen","ref":"sniyaz/doxygen","sha":"decbe7f208e69f521731b8476b2696fabf7d5cae","user":{"login":"personalrobotics","id":4705918,"avatar_url":"https://avatars3.githubusercontent.com/u/4705918?v=4","gravatar_id":"","url":"https://api.github.com/users/personalrobotics","html_url":"https://github.com/personalrobotics","followers_url":"https://api.github.com/users/personalrobotics/followers","following_url":"https://api.github.com/users/personalrobotics/following{/other_user}","gists_url":"https://api.github.com/users/personalrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/personalrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/personalrobotics/subscriptions","organizations_url":"https://api.github.com/users/personalrobotics/orgs","repos_url":"https://api.github.com/users/personalrobotics/repos","events_url":"https://api.github.com/users/personalrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/personalrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":34424077,"name":"aikido","full_name":"personalrobotics/aikido","owner":{"login":"personalrobotics","id":4705918,"avatar_url":"https://avatars3.githubusercontent.com/u/4705918?v=4","gravatar_id":"","url":"https://api.github.com/users/personalrobotics","html_url":"https://github.com/personalrobotics","followers_url":"https://api.github.com/users/personalrobotics/followers","following_url":"https://api.github.com/users/personalrobotics/following{/other_user}","gists_url":"https://api.github.com/users/personalrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/personalrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/personalrobotics/subscriptions","organizations_url":"https://api.github.com/users/personalrobotics/orgs","repos_url":"https://api.github.com/users/personalrobotics/repos","events_url":"https://api.github.com/users/personalrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/personalrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/personalrobotics/aikido","description":"Artificial Intelligence for Kinematics, Dynamics, and Optimization","fork":false,"url":"https://api.github.com/repos/personalrobotics/aikido","forks_url":"https://api.github.com/repos/personalrobotics/aikido/forks","keys_url":"https://api.github.com/repos/personalrobotics/aikido/keys{/key_id}","collaborators_url":"https://api.github.com/repos/personalrobotics/aikido/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/personalrobotics/aikido/teams","hooks_url":"https://api.github.com/repos/personalrobotics/aikido/hooks","issue_events_url":"https://api.github.com/repos/personalrobotics/aikido/issues/events{/number}","events_url":"https://api.github.com/repos/personalrobotics/aikido/events","assignees_url":"https://api.github.com/repos/personalrobotics/aikido/assignees{/user}","branches_url":"https://api.github.com/repos/personalrobotics/aikido/branches{/branch}","tags_url":"https://api.github.com/repos/personalrobotics/aikido/tags","blobs_url":"https://api.github.com/repos/personalrobotics/aikido/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/personalrobotics/aikido/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/personalrobotics/aikido/git/refs{/sha}","trees_url":"https://api.github.com/repos/personalrobotics/aikido/git/trees{/sha}","statuses_url":"https://api.github.com/repos/personalrobotics/aikido/statuses/{sha}","languages_url":"https://api.github.com/repos/personalrobotics/aikido/languages","stargazers_url":"https://api.github.com/repos/personalrobotics/aikido/stargazers","contributors_url":"https://api.github.com/repos/personalrobotics/aikido/contributors","subscribers_url":"https://api.github.com/repos/personalrobotics/aikido/subscribers","subscription_url":"https://api.github.com/repos/personalrobotics/aikido/subscription","commits_url":"https://api.github.com/repos/personalrobotics/aikido/commits{/sha}","git_commits_url":"https://api.github.com/repos/personalrobotics/aikido/git/commits{/sha}","comments_url":"https://api.github.com/repos/personalrobotics/aikido/comments{/number}","issue_comment_url":"https://api.github.com/repos/personalrobotics/aikido/issues/comments{/number}","contents_url":"https://api.github.com/repos/personalrobotics/aikido/contents/{+path}","compare_url":"https://api.github.com/repos/personalrobotics/aikido/compare/{base}...{head}","merges_url":"https://api.github.com/repos/personalrobotics/aikido/merges","archive_url":"https://api.github.com/repos/personalrobotics/aikido/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/personalrobotics/aikido/downloads","issues_url":"https://api.github.com/repos/personalrobotics/aikido/issues{/number}","pulls_url":"https://api.github.com/repos/personalrobotics/aikido/pulls{/number}","milestones_url":"https://api.github.com/repos/personalrobotics/aikido/milestones{/number}","notifications_url":"https://api.github.com/repos/personalrobotics/aikido/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/personalrobotics/aikido/labels{/name}","releases_url":"https://api.github.com/repos/personalrobotics/aikido/releases{/id}","deployments_url":"https://api.github.com/repos/personalrobotics/aikido/deployments","created_at":"2015-04-23T00:33:33Z","updated_at":"2018-02-26T04:49:37Z","pushed_at":"2018-03-03T00:43:33Z","git_url":"git://github.com/personalrobotics/aikido.git","ssh_url":"git@github.com:personalrobotics/aikido.git","clone_url":"https://github.com/personalrobotics/aikido.git","svn_url":"https://github.com/personalrobotics/aikido","homepage":"https://personalrobotics.github.io/aikido/","size":8911,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":10,"open_issues":69,"watchers":35,"default_branch":"master"}},"base":{"label":"personalrobotics:master","ref":"master","sha":"04c04beb2ee0493e76700d0b6b256b34f96c35ec","user":{"login":"personalrobotics","id":4705918,"avatar_url":"https://avatars3.githubusercontent.com/u/4705918?v=4","gravatar_id":"","url":"https://api.github.com/users/personalrobotics","html_url":"https://github.com/personalrobotics","followers_url":"https://api.github.com/users/personalrobotics/followers","following_url":"https://api.github.com/users/personalrobotics/following{/other_user}","gists_url":"https://api.github.com/users/personalrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/personalrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/personalrobotics/subscriptions","organizations_url":"https://api.github.com/users/personalrobotics/orgs","repos_url":"https://api.github.com/users/personalrobotics/repos","events_url":"https://api.github.com/users/personalrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/personalrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":34424077,"name":"aikido","full_name":"personalrobotics/aikido","owner":{"login":"personalrobotics","id":4705918,"avatar_url":"https://avatars3.githubusercontent.com/u/4705918?v=4","gravatar_id":"","url":"https://api.github.com/users/personalrobotics","html_url":"https://github.com/personalrobotics","followers_url":"https://api.github.com/users/personalrobotics/followers","following_url":"https://api.github.com/users/personalrobotics/following{/other_user}","gists_url":"https://api.github.com/users/personalrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/personalrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/personalrobotics/subscriptions","organizations_url":"https://api.github.com/users/personalrobotics/orgs","repos_url":"https://api.github.com/users/personalrobotics/repos","events_url":"https://api.github.com/users/personalrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/personalrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/personalrobotics/aikido","description":"Artificial Intelligence for Kinematics, Dynamics, and Optimization","fork":false,"url":"https://api.github.com/repos/personalrobotics/aikido","forks_url":"https://api.github.com/repos/personalrobotics/aikido/forks","keys_url":"https://api.github.com/repos/personalrobotics/aikido/keys{/key_id}","collaborators_url":"https://api.github.com/repos/personalrobotics/aikido/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/personalrobotics/aikido/teams","hooks_url":"https://api.github.com/repos/personalrobotics/aikido/hooks","issue_events_url":"https://api.github.com/repos/personalrobotics/aikido/issues/events{/number}","events_url":"https://api.github.com/repos/personalrobotics/aikido/events","assignees_url":"https://api.github.com/repos/personalrobotics/aikido/assignees{/user}","branches_url":"https://api.github.com/repos/personalrobotics/aikido/branches{/branch}","tags_url":"https://api.github.com/repos/personalrobotics/aikido/tags","blobs_url":"https://api.github.com/repos/personalrobotics/aikido/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/personalrobotics/aikido/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/personalrobotics/aikido/git/refs{/sha}","trees_url":"https://api.github.com/repos/personalrobotics/aikido/git/trees{/sha}","statuses_url":"https://api.github.com/repos/personalrobotics/aikido/statuses/{sha}","languages_url":"https://api.github.com/repos/personalrobotics/aikido/languages","stargazers_url":"https://api.github.com/repos/personalrobotics/aikido/stargazers","contributors_url":"https://api.github.com/repos/personalrobotics/aikido/contributors","subscribers_url":"https://api.github.com/repos/personalrobotics/aikido/subscribers","subscription_url":"https://api.github.com/repos/personalrobotics/aikido/subscription","commits_url":"https://api.github.com/repos/personalrobotics/aikido/commits{/sha}","git_commits_url":"https://api.github.com/repos/personalrobotics/aikido/git/commits{/sha}","comments_url":"https://api.github.com/repos/personalrobotics/aikido/comments{/number}","issue_comment_url":"https://api.github.com/repos/personalrobotics/aikido/issues/comments{/number}","contents_url":"https://api.github.com/repos/personalrobotics/aikido/contents/{+path}","compare_url":"https://api.github.com/repos/personalrobotics/aikido/compare/{base}...{head}","merges_url":"https://api.github.com/repos/personalrobotics/aikido/merges","archive_url":"https://api.github.com/repos/personalrobotics/aikido/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/personalrobotics/aikido/downloads","issues_url":"https://api.github.com/repos/personalrobotics/aikido/issues{/number}","pulls_url":"https://api.github.com/repos/personalrobotics/aikido/pulls{/number}","milestones_url":"https://api.github.com/repos/personalrobotics/aikido/milestones{/number}","notifications_url":"https://api.github.com/repos/personalrobotics/aikido/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/personalrobotics/aikido/labels{/name}","releases_url":"https://api.github.com/repos/personalrobotics/aikido/releases{/id}","deployments_url":"https://api.github.com/repos/personalrobotics/aikido/deployments","created_at":"2015-04-23T00:33:33Z","updated_at":"2018-02-26T04:49:37Z","pushed_at":"2018-03-03T00:43:33Z","git_url":"git://github.com/personalrobotics/aikido.git","ssh_url":"git@github.com:personalrobotics/aikido.git","clone_url":"https://github.com/personalrobotics/aikido.git","svn_url":"https://github.com/personalrobotics/aikido","homepage":"https://personalrobotics.github.io/aikido/","size":8911,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":10,"open_issues":69,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/357"},"html":{"href":"https://github.com/personalrobotics/aikido/pull/357"},"issue":{"href":"https://api.github.com/repos/personalrobotics/aikido/issues/357"},"comments":{"href":"https://api.github.com/repos/personalrobotics/aikido/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/personalrobotics/aikido/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/personalrobotics/aikido/statuses/decbe7f208e69f521731b8476b2696fabf7d5cae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jslee02"}}