{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/196759942","pull_request_review_id":130372659,"id":196759942,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Njc1OTk0Mg==","diff_hunk":"@@ -351,8 +351,9 @@ def annotate_legacy_addon_restrictions(results, is_new_upload):\n         max_target_firefox_version < 99000000000000)\n \n     # Thunderbird/Seamonkey only add-ons are moving to addons.thunderbird.net.\n-    if (waffle.switch_is_active('disallow-thunderbird-and-seamonkey') and\n-            is_targeting_thunderbird_or_seamonkey_only):\n+    if (not is_webextension and","path":"src/olympia/devhub/tasks.py","position":20,"original_position":20,"commit_id":"a00a9821a7447d2ad099fa747590beafaf08bea7","original_commit_id":"a00a9821a7447d2ad099fa747590beafaf08bea7","user":{"login":"diox","id":187006,"node_id":"MDQ6VXNlcjE4NzAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/187006?v=4","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":"It's because when the add-on is parsed with the linter, `metadata['applications']` is absent - the linter cannot determine this, since webextensions manifests don't contain actual applications information, only \"engines\".\r\n\r\nSo `target_apps` was empty, and that was causing the issue. Adding the check on `target_apps` in both variables like I did is enough so we don't need the extra `is_webextension` check. I could add an early return at the beginning of the function if `is_webextension` is `True`, though: after all, this is supposed to be `annotate_legacy_addon_restrictions` ...","created_at":"2018-06-20T12:38:58Z","updated_at":"2018-06-20T12:38:58Z","html_url":"https://github.com/mozilla/addons-server/pull/8568#discussion_r196759942","pull_request_url":"https://api.github.com/repos/mozilla/addons-server/pulls/8568","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/196759942"},"html":{"href":"https://github.com/mozilla/addons-server/pull/8568#discussion_r196759942"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/8568"}},"in_reply_to_id":196732349},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/8568","id":195857012,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODU3MDEy","html_url":"https://github.com/mozilla/addons-server/pull/8568","diff_url":"https://github.com/mozilla/addons-server/pull/8568.diff","patch_url":"https://github.com/mozilla/addons-server/pull/8568.patch","issue_url":"https://api.github.com/repos/mozilla/addons-server/issues/8568","number":8568,"state":"open","locked":false,"title":"Fix compatibility form/validation issues when disallow-thunderbird-and-seamonkey switch is active","user":{"login":"diox","id":187006,"node_id":"MDQ6VXNlcjE4NzAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/187006?v=4","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":"Hopefully re-fix #8344 ","created_at":"2018-06-19T14:55:51Z","updated_at":"2018-06-20T12:38:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa3b5f703c567baf0755690c14411252bb3234f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-server/pulls/8568/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-server/pulls/8568/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-server/issues/8568/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/a00a9821a7447d2ad099fa747590beafaf08bea7","head":{"label":"diox:disallow-thunderbird-seamonkey-waffle-fixes","ref":"disallow-thunderbird-seamonkey-waffle-fixes","sha":"a00a9821a7447d2ad099fa747590beafaf08bea7","user":{"login":"diox","id":187006,"node_id":"MDQ6VXNlcjE4NzAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/187006?v=4","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"repo":{"id":16844921,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg0NDkyMQ==","name":"olympia","full_name":"diox/olympia","owner":{"login":"diox","id":187006,"node_id":"MDQ6VXNlcjE4NzAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/187006?v=4","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diox/olympia","description":"AMO, reloaded.","fork":true,"url":"https://api.github.com/repos/diox/olympia","forks_url":"https://api.github.com/repos/diox/olympia/forks","keys_url":"https://api.github.com/repos/diox/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diox/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diox/olympia/teams","hooks_url":"https://api.github.com/repos/diox/olympia/hooks","issue_events_url":"https://api.github.com/repos/diox/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/diox/olympia/events","assignees_url":"https://api.github.com/repos/diox/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/diox/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/diox/olympia/tags","blobs_url":"https://api.github.com/repos/diox/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diox/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diox/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/diox/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diox/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/diox/olympia/languages","stargazers_url":"https://api.github.com/repos/diox/olympia/stargazers","contributors_url":"https://api.github.com/repos/diox/olympia/contributors","subscribers_url":"https://api.github.com/repos/diox/olympia/subscribers","subscription_url":"https://api.github.com/repos/diox/olympia/subscription","commits_url":"https://api.github.com/repos/diox/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/diox/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/diox/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/diox/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/diox/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/diox/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diox/olympia/merges","archive_url":"https://api.github.com/repos/diox/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diox/olympia/downloads","issues_url":"https://api.github.com/repos/diox/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/diox/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/diox/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/diox/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diox/olympia/labels{/name}","releases_url":"https://api.github.com/repos/diox/olympia/releases{/id}","deployments_url":"https://api.github.com/repos/diox/olympia/deployments","created_at":"2014-02-14T17:54:49Z","updated_at":"2018-05-21T16:38:35Z","pushed_at":"2018-06-20T11:53:10Z","git_url":"git://github.com/diox/olympia.git","ssh_url":"git@github.com:diox/olympia.git","clone_url":"https://github.com/diox/olympia.git","svn_url":"https://github.com/diox/olympia","homepage":"","size":891138,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"d60c2f82076d6967f3a6c2830d36005c8de46cb2","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQxNjg2Nw==","name":"addons-server","full_name":"mozilla/addons-server","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-server","description":"🕶 addons.mozilla.org Django app and API 🎉","fork":false,"url":"https://api.github.com/repos/mozilla/addons-server","forks_url":"https://api.github.com/repos/mozilla/addons-server/forks","keys_url":"https://api.github.com/repos/mozilla/addons-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-server/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-server/events","assignees_url":"https://api.github.com/repos/mozilla/addons-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-server/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-server/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-server/merges","archive_url":"https://api.github.com/repos/mozilla/addons-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-server/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-server/deployments","created_at":"2014-01-31T18:44:15Z","updated_at":"2018-06-20T11:14:58Z","pushed_at":"2018-06-20T12:15:18Z","git_url":"git://github.com/mozilla/addons-server.git","ssh_url":"git@github.com:mozilla/addons-server.git","clone_url":"https://github.com/mozilla/addons-server.git","svn_url":"https://github.com/mozilla/addons-server","homepage":"https://addons.mozilla.org/","size":889694,"stargazers_count":315,"watchers_count":315,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":297,"mirror_url":null,"archived":false,"open_issues_count":372,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":297,"open_issues":372,"watchers":315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/8568"},"html":{"href":"https://github.com/mozilla/addons-server/pull/8568"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/8568"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/8568/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/8568/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/8568/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-server/statuses/a00a9821a7447d2ad099fa747590beafaf08bea7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"diox"}}