{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/21935","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/21935/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21935/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/21935/events","html_url":"https://github.com/nodejs/node/pull/21935","id":343429936,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDcxMjUx","number":21935,"title":"src: remove calls to deprecated v8 functions (ToString)","user":{"login":"ryzokuken","id":13121330,"node_id":"MDQ6VXNlcjEzMTIxMzMw","avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-22T19:00:10Z","updated_at":"2018-07-22T19:16:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21935","html_url":"https://github.com/nodejs/node/pull/21935","diff_url":"https://github.com/nodejs/node/pull/21935.diff","patch_url":"https://github.com/nodejs/node/pull/21935.patch"},"body":"Remove all calls to deprecated v8 functions (here: Value::ToString) inside\r\nthe code (src directory only).\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n/cc @hashseed "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/406889807","html_url":"https://github.com/nodejs/node/pull/21935#issuecomment-406889807","issue_url":"https://api.github.com/repos/nodejs/node/issues/21935","id":406889807,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg4OTgwNw==","user":{"login":"ryzokuken","id":13121330,"node_id":"MDQ6VXNlcjEzMTIxMzMw","avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T19:16:49Z","updated_at":"2018-07-22T19:16:49Z","author_association":"MEMBER","body":"Testing locally, but what we have:\r\n\r\n```console\r\nnot ok 1381 parallel/test-process-env-symbols\r\n  ---\r\n  duration_ms: 0.413\r\n  severity: crashed\r\n  exitcode: -6\r\n  stack: |-\r\n    FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal.\r\n     1: 0x834fe0 node::Abort() [out/Release/node]\r\n     2: 0x8351d2  [out/Release/node]\r\n     3: 0x9dc661 v8::V8::ToLocalEmpty() [out/Release/node]\r\n     4: 0x837aef  [out/Release/node]\r\n     5: 0xded05e v8::internal::PropertyCallbackArguments::CallNamedSetter(v8::internal::Handle<v8::internal::InterceptorInfo>, v8::internal::Handle<v8::internal::Name>, v8::internal::Handle<v8::internal::Object>) [out/Release/node]\r\n     6: 0xe7500a  [out/Release/node]\r\n     7: 0xe8439f v8::internal::Object::SetPropertyInternal(v8::internal::LookupIterator*, v8::internal::Handle<v8::internal::Object>, v8::internal::LanguageMode, v8::internal::Object::StoreFromKeyed, bool*) [out/Release/node]\r\n     8: 0xe84237 v8::internal::Object::SetProperty(v8::internal::LookupIterator*, v8::internal::Handle<v8::internal::Object>, v8::internal::LanguageMode, v8::internal::Object::StoreFromKeyed) [out/Release/node]\r\n     9: 0xde338c v8::internal::StoreIC::Store(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Name>, v8::internal::Handle<v8::internal::Object>, v8::internal::Object::StoreFromKeyed) [out/Release/node]\r\n    10: 0xde5365 v8::internal::KeyedStoreIC::Store(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>) [out/Release/node]\r\n    11: 0xde92e7 v8::internal::Runtime_KeyedStoreIC_Miss(int, v8::internal::Object**, v8::internal::Isolate*) [out/Release/node]\r\n    12: 0x9e04e8841bd \r\n  ...\r\n```"}}
{"actor":{"display_login":"ryzokuken"}}