{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/216836268","pull_request_review_id":154413438,"id":216836268,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjgzNjI2OA==","diff_hunk":"@@ -124,6 +124,9 @@\n #elif defined(CONFIG_SOC_STM32L433XC)\n #define DT_FLASH_SIZE\t\t__SIZE_K(256)\n #define DT_SRAM_SIZE\t\t__SIZE_K(64)\n+#elif defined(CONFIG_SOC_DUMMY)","path":"dts/arm/st/mem.h","position":13,"original_position":13,"commit_id":"096827abed13ab7ed2956186ca7f3716562709d1","original_commit_id":"096827abed13ab7ed2956186ca7f3716562709d1","user":{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},"body":"> From a quick read, this approach feels kind of ad hoc\r\n\r\nI thought that was intended to be ad-hoc, this PR is just to illustrate the discussion we had on IRC. I agree on all the points you list above.","created_at":"2018-09-11T21:56:24Z","updated_at":"2018-09-11T21:56:24Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9925#discussion_r216836268","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9925","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/216836268"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/9925#discussion_r216836268"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9925"}},"in_reply_to_id":216826127},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9925","id":214752822,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NzUyODIy","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9925","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9925.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9925.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9925","number":9925,"state":"open","locked":false,"title":"[DNM][RFC] dts: Get SoC from dts and not from kconfig generated autoconfig.h","user":{"login":"galak","id":16417047,"node_id":"MDQ6VXNlcjE2NDE3MDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/16417047?v=4","gravatar_id":"","url":"https://api.github.com/users/galak","html_url":"https://github.com/galak","followers_url":"https://api.github.com/users/galak/followers","following_url":"https://api.github.com/users/galak/following{/other_user}","gists_url":"https://api.github.com/users/galak/gists{/gist_id}","starred_url":"https://api.github.com/users/galak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galak/subscriptions","organizations_url":"https://api.github.com/users/galak/orgs","repos_url":"https://api.github.com/users/galak/repos","events_url":"https://api.github.com/users/galak/events{/privacy}","received_events_url":"https://api.github.com/users/galak/received_events","type":"User","site_admin":false},"body":"Example of how we can remove the dep between Kconfig & dts.  We still\r\nneed to deal with MCUBOOT define, but at least this shows how to deal\r\nwith the SoC defines.\r\n\r\nSigned-off-by: Kumar Gala <kumar.gala@linaro.org>","created_at":"2018-09-11T20:15:18Z","updated_at":"2018-09-11T21:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2886ce57a74f3afc87a67bfafeab2660ec209a95","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ulfalizer","id":154768,"node_id":"MDQ6VXNlcjE1NDc2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/154768?v=4","gravatar_id":"","url":"https://api.github.com/users/ulfalizer","html_url":"https://github.com/ulfalizer","followers_url":"https://api.github.com/users/ulfalizer/followers","following_url":"https://api.github.com/users/ulfalizer/following{/other_user}","gists_url":"https://api.github.com/users/ulfalizer/gists{/gist_id}","starred_url":"https://api.github.com/users/ulfalizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulfalizer/subscriptions","organizations_url":"https://api.github.com/users/ulfalizer/orgs","repos_url":"https://api.github.com/users/ulfalizer/repos","events_url":"https://api.github.com/users/ulfalizer/events{/privacy}","received_events_url":"https://api.github.com/users/ulfalizer/received_events","type":"User","site_admin":false},{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},{"login":"SebastianBoe","id":609230,"node_id":"MDQ6VXNlcjYwOTIzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/609230?v=4","gravatar_id":"","url":"https://api.github.com/users/SebastianBoe","html_url":"https://github.com/SebastianBoe","followers_url":"https://api.github.com/users/SebastianBoe/followers","following_url":"https://api.github.com/users/SebastianBoe/following{/other_user}","gists_url":"https://api.github.com/users/SebastianBoe/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastianBoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastianBoe/subscriptions","organizations_url":"https://api.github.com/users/SebastianBoe/orgs","repos_url":"https://api.github.com/users/SebastianBoe/repos","events_url":"https://api.github.com/users/SebastianBoe/events{/privacy}","received_events_url":"https://api.github.com/users/SebastianBoe/received_events","type":"User","site_admin":false},{"login":"erwango","id":18574308,"node_id":"MDQ6VXNlcjE4NTc0MzA4","avatar_url":"https://avatars1.githubusercontent.com/u/18574308?v=4","gravatar_id":"","url":"https://api.github.com/users/erwango","html_url":"https://github.com/erwango","followers_url":"https://api.github.com/users/erwango/followers","following_url":"https://api.github.com/users/erwango/following{/other_user}","gists_url":"https://api.github.com/users/erwango/gists{/gist_id}","starred_url":"https://api.github.com/users/erwango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwango/subscriptions","organizations_url":"https://api.github.com/users/erwango/orgs","repos_url":"https://api.github.com/users/erwango/repos","events_url":"https://api.github.com/users/erwango/events{/privacy}","received_events_url":"https://api.github.com/users/erwango/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":807706246,"node_id":"MDU6TGFiZWw4MDc3MDYyNDY=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/DNM","name":"DNM","color":"b60205","default":false},{"id":724796876,"node_id":"MDU6TGFiZWw3MjQ3OTY4NzY=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/RFC","name":"RFC","color":"d8af5d","default":false},{"id":700909632,"node_id":"MDU6TGFiZWw3MDA5MDk2MzI=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Device%20Tree","name":"area: Device Tree","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9925/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9925/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9925/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/096827abed13ab7ed2956186ca7f3716562709d1","head":{"label":"galak:dts-soc-hack","ref":"dts-soc-hack","sha":"096827abed13ab7ed2956186ca7f3716562709d1","user":{"login":"galak","id":16417047,"node_id":"MDQ6VXNlcjE2NDE3MDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/16417047?v=4","gravatar_id":"","url":"https://api.github.com/users/galak","html_url":"https://github.com/galak","followers_url":"https://api.github.com/users/galak/followers","following_url":"https://api.github.com/users/galak/following{/other_user}","gists_url":"https://api.github.com/users/galak/gists{/gist_id}","starred_url":"https://api.github.com/users/galak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galak/subscriptions","organizations_url":"https://api.github.com/users/galak/orgs","repos_url":"https://api.github.com/users/galak/repos","events_url":"https://api.github.com/users/galak/events{/privacy}","received_events_url":"https://api.github.com/users/galak/received_events","type":"User","site_admin":false},"repo":{"id":70709632,"node_id":"MDEwOlJlcG9zaXRvcnk3MDcwOTYzMg==","name":"zephyr","full_name":"galak/zephyr","owner":{"login":"galak","id":16417047,"node_id":"MDQ6VXNlcjE2NDE3MDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/16417047?v=4","gravatar_id":"","url":"https://api.github.com/users/galak","html_url":"https://github.com/galak","followers_url":"https://api.github.com/users/galak/followers","following_url":"https://api.github.com/users/galak/following{/other_user}","gists_url":"https://api.github.com/users/galak/gists{/gist_id}","starred_url":"https://api.github.com/users/galak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galak/subscriptions","organizations_url":"https://api.github.com/users/galak/orgs","repos_url":"https://api.github.com/users/galak/repos","events_url":"https://api.github.com/users/galak/events{/privacy}","received_events_url":"https://api.github.com/users/galak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/galak/zephyr","description":"Mirror of the zephyr repo on https://gerrit.zephyrproject.org","fork":true,"url":"https://api.github.com/repos/galak/zephyr","forks_url":"https://api.github.com/repos/galak/zephyr/forks","keys_url":"https://api.github.com/repos/galak/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galak/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galak/zephyr/teams","hooks_url":"https://api.github.com/repos/galak/zephyr/hooks","issue_events_url":"https://api.github.com/repos/galak/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/galak/zephyr/events","assignees_url":"https://api.github.com/repos/galak/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/galak/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/galak/zephyr/tags","blobs_url":"https://api.github.com/repos/galak/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galak/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galak/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/galak/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galak/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/galak/zephyr/languages","stargazers_url":"https://api.github.com/repos/galak/zephyr/stargazers","contributors_url":"https://api.github.com/repos/galak/zephyr/contributors","subscribers_url":"https://api.github.com/repos/galak/zephyr/subscribers","subscription_url":"https://api.github.com/repos/galak/zephyr/subscription","commits_url":"https://api.github.com/repos/galak/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/galak/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/galak/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/galak/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/galak/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/galak/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galak/zephyr/merges","archive_url":"https://api.github.com/repos/galak/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galak/zephyr/downloads","issues_url":"https://api.github.com/repos/galak/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/galak/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/galak/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/galak/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galak/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/galak/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/galak/zephyr/deployments","created_at":"2016-10-12T14:45:03Z","updated_at":"2018-08-15T16:22:00Z","pushed_at":"2018-09-11T20:33:09Z","git_url":"git://github.com/galak/zephyr.git","ssh_url":"git@github.com:galak/zephyr.git","clone_url":"https://github.com/galak/zephyr.git","svn_url":"https://github.com/galak/zephyr","homepage":null,"size":134316,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"1d88e8684c4ce0609216c98f9324e298f8544ddd","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-09-11T21:30:25Z","pushed_at":"2018-09-11T21:43:05Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":131901,"stargazers_count":1179,"watchers_count":1179,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":785,"mirror_url":null,"archived":false,"open_issues_count":1010,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":785,"open_issues":1010,"watchers":1179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9925"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/9925"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9925"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9925/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9925/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9925/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/096827abed13ab7ed2956186ca7f3716562709d1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nashif"}}