{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/community/issues/2737","repository_url":"https://api.github.com/repos/kubernetes/community","labels_url":"https://api.github.com/repos/kubernetes/community/issues/2737/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/community/issues/2737/comments","events_url":"https://api.github.com/repos/kubernetes/community/issues/2737/events","html_url":"https://github.com/kubernetes/community/pull/2737","id":365730037,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTc4MDg1","number":2737,"title":"Add per version field section to custom resource webhook conversion KEP","user":{"login":"mbohlool","id":1613024,"node_id":"MDQ6VXNlcjE2MTMwMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1613024?v=4","gravatar_id":"","url":"https://api.github.com/users/mbohlool","html_url":"https://github.com/mbohlool","followers_url":"https://api.github.com/users/mbohlool/followers","following_url":"https://api.github.com/users/mbohlool/following{/other_user}","gists_url":"https://api.github.com/users/mbohlool/gists{/gist_id}","starred_url":"https://api.github.com/users/mbohlool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbohlool/subscriptions","organizations_url":"https://api.github.com/users/mbohlool/orgs","repos_url":"https://api.github.com/users/mbohlool/repos","events_url":"https://api.github.com/users/mbohlool/events{/privacy}","received_events_url":"https://api.github.com/users/mbohlool/received_events","type":"User","site_admin":false},"labels":[{"id":486032367,"node_id":"MDU6TGFiZWw0ODYwMzIzNjc=","url":"https://api.github.com/repos/kubernetes/community/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":653942785,"node_id":"MDU6TGFiZWw2NTM5NDI3ODU=","url":"https://api.github.com/repos/kubernetes/community/labels/kind/design","name":"kind/design","color":"c7def8","default":false},{"id":1076074046,"node_id":"MDU6TGFiZWwxMDc2MDc0MDQ2","url":"https://api.github.com/repos/kubernetes/community/labels/kind/kep","name":"kind/kep","color":"cc99ff","default":false},{"id":653942861,"node_id":"MDU6TGFiZWw2NTM5NDI4NjE=","url":"https://api.github.com/repos/kubernetes/community/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":653942911,"node_id":"MDU6TGFiZWw2NTM5NDI5MTE=","url":"https://api.github.com/repos/kubernetes/community/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-02T03:49:39Z","updated_at":"2018-10-17T19:41:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/community/pulls/2737","html_url":"https://github.com/kubernetes/community/pull/2737","diff_url":"https://github.com/kubernetes/community/pull/2737.diff","patch_url":"https://github.com/kubernetes/community/pull/2737.patch"},"body":"The defaulting section of customresource webhook conversion KEP was backward incompatible. This PR suggest a new approach. Different approaches as well as the problem description is detailed in [this document](http://bit.ly/k8s-crd-per-version-defaulting).\r\n\r\n@liggitt @lavalamp @deads2k @sttts @erictune @roycaihw "},"comment":{"url":"https://api.github.com/repos/kubernetes/community/issues/comments/430761786","html_url":"https://github.com/kubernetes/community/pull/2737#issuecomment-430761786","issue_url":"https://api.github.com/repos/kubernetes/community/issues/2737","id":430761786,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDc2MTc4Ng==","user":{"login":"roycaihw","id":6629765,"node_id":"MDQ6VXNlcjY2Mjk3NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/6629765?v=4","gravatar_id":"","url":"https://api.github.com/users/roycaihw","html_url":"https://github.com/roycaihw","followers_url":"https://api.github.com/users/roycaihw/followers","following_url":"https://api.github.com/users/roycaihw/following{/other_user}","gists_url":"https://api.github.com/users/roycaihw/gists{/gist_id}","starred_url":"https://api.github.com/users/roycaihw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roycaihw/subscriptions","organizations_url":"https://api.github.com/users/roycaihw/orgs","repos_url":"https://api.github.com/users/roycaihw/repos","events_url":"https://api.github.com/users/roycaihw/events{/privacy}","received_events_url":"https://api.github.com/users/roycaihw/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T19:41:29Z","updated_at":"2018-10-17T19:41:29Z","author_association":"MEMBER","body":"Talked with @mbohlool offline, the purposed strategy for how to use feature gate is more strict compared with https://github.com/kubernetes/kubernetes/pull/67521#issuecomment-417796881.  \r\n\r\nhttps://github.com/kubernetes/kubernetes/pull/67521#issuecomment-417796881 will be discussed in sig-arch meeting. If we want to go with that strategy in future, it's safe (backward compatible) to relax the validation. \r\n\r\n/lgtm"}}
{"actor":{"display_login":"roycaihw"}}