{"action":"created","comment":{"url":"https://api.github.com/repos/dotCMS/core-web/pulls/comments/174255712","pull_request_review_id":103574108,"id":174255712,"diff_hunk":"@@ -221,26 +231,9 @@ describe('DotEditPageToolbarComponent', () => {\n         expect(component.onLockerClick).toHaveBeenCalledTimes(1);\n     });\n \n-    it('should NOT have an action split button', () => {\n-        const primaryAction: DebugElement = de.query(By.css('.edit-page-toolbar__actions'));\n-        expect(primaryAction).toBeFalsy();\n-    });\n-\n     it('should have an action split button', () => {\n-        component.pageWorkflows = [{ name: 'Workflow 1', id: 'one' }, { name: 'Workflow 2', id: 'two' }];\n-        fixture.detectChanges();\n         const primaryAction: DebugElement = de.query(By.css('.edit-page-toolbar__actions'));\n-        expect(primaryAction).toBeTruthy();\n-        expect(primaryAction.name).toEqual('p-splitButton', 'is a splitbutton');\n-    });\n-\n-    it('should set action split buttons params', () => {\n-        component.pageWorkflows = [{ name: 'Workflow 1', id: 'one' }, { name: 'Workflow 2', id: 'two' }];\n-        fixture.detectChanges();\n-        const actionsButton: SplitButton = de.query(By.css('.edit-page-toolbar__actions')).componentInstance;\n-\n-        expect(actionsButton.label).toEqual('Acciones', 'actions label is set');\n-        expect(actionsButton.model).toEqual([{ label: 'Workflow 1' }, { label: 'Workflow 2' }]);\n+        expect(primaryAction === null).toBe(false);","path":"src/app/portlets/dot-edit-page/content/components/dot-edit-page-toolbar/dot-edit-page-toolbar.component.spec.ts","position":62,"original_position":62,"commit_id":"96fa050de3866ff421fe605262b6fa561e2404af","original_commit_id":"96fa050de3866ff421fe605262b6fa561e2404af","user":{"login":"fmontes","id":751424,"avatar_url":"https://avatars3.githubusercontent.com/u/751424?v=4","gravatar_id":"","url":"https://api.github.com/users/fmontes","html_url":"https://github.com/fmontes","followers_url":"https://api.github.com/users/fmontes/followers","following_url":"https://api.github.com/users/fmontes/following{/other_user}","gists_url":"https://api.github.com/users/fmontes/gists{/gist_id}","starred_url":"https://api.github.com/users/fmontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmontes/subscriptions","organizations_url":"https://api.github.com/users/fmontes/orgs","repos_url":"https://api.github.com/users/fmontes/repos","events_url":"https://api.github.com/users/fmontes/events{/privacy}","received_events_url":"https://api.github.com/users/fmontes/received_events","type":"User","site_admin":false},"body":"This test it's not ok, because you are querying the node element by ```.edit-page-toolbar__actions``` but the toolbar can't know the the ```.edit-page-toolbar__actions``` in inside a node element of the component ```<dot-edit-page-workflows-actions>```, you should do the query by the direct tag that the toolbar have in the HTML: ```dot-edit-page-workflows-actions```","created_at":"2018-03-13T19:26:15Z","updated_at":"2018-03-13T19:29:12Z","html_url":"https://github.com/dotCMS/core-web/pull/567#discussion_r174255712","pull_request_url":"https://api.github.com/repos/dotCMS/core-web/pulls/567","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/comments/174255712"},"html":{"href":"https://github.com/dotCMS/core-web/pull/567#discussion_r174255712"},"pull_request":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/567"}}},"pull_request":{"url":"https://api.github.com/repos/dotCMS/core-web/pulls/567","id":174034228,"html_url":"https://github.com/dotCMS/core-web/pull/567","diff_url":"https://github.com/dotCMS/core-web/pull/567.diff","patch_url":"https://github.com/dotCMS/core-web/pull/567.patch","issue_url":"https://api.github.com/repos/dotCMS/core-web/issues/567","number":567,"state":"open","locked":false,"title":"Add new component for workflow actions","user":{"login":"alfredo-dotcms","id":37185433,"avatar_url":"https://avatars0.githubusercontent.com/u/37185433?v=4","gravatar_id":"","url":"https://api.github.com/users/alfredo-dotcms","html_url":"https://github.com/alfredo-dotcms","followers_url":"https://api.github.com/users/alfredo-dotcms/followers","following_url":"https://api.github.com/users/alfredo-dotcms/following{/other_user}","gists_url":"https://api.github.com/users/alfredo-dotcms/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredo-dotcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredo-dotcms/subscriptions","organizations_url":"https://api.github.com/users/alfredo-dotcms/orgs","repos_url":"https://api.github.com/users/alfredo-dotcms/repos","events_url":"https://api.github.com/users/alfredo-dotcms/events{/privacy}","received_events_url":"https://api.github.com/users/alfredo-dotcms/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-09T15:31:47Z","updated_at":"2018-03-13T19:29:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6379cc6a8f305b491daf94202fe832e352fbb9ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotCMS/core-web/pulls/567/commits","review_comments_url":"https://api.github.com/repos/dotCMS/core-web/pulls/567/comments","review_comment_url":"https://api.github.com/repos/dotCMS/core-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotCMS/core-web/issues/567/comments","statuses_url":"https://api.github.com/repos/dotCMS/core-web/statuses/96fa050de3866ff421fe605262b6fa561e2404af","head":{"label":"dotCMS:issue-13299-Implement-workflows-in-the-edit-page","ref":"issue-13299-Implement-workflows-in-the-edit-page","sha":"96fa050de3866ff421fe605262b6fa561e2404af","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":36376350,"name":"core-web","full_name":"dotCMS/core-web","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core-web","description":"dotCMS UI","fork":false,"url":"https://api.github.com/repos/dotCMS/core-web","forks_url":"https://api.github.com/repos/dotCMS/core-web/forks","keys_url":"https://api.github.com/repos/dotCMS/core-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core-web/teams","hooks_url":"https://api.github.com/repos/dotCMS/core-web/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core-web/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core-web/events","assignees_url":"https://api.github.com/repos/dotCMS/core-web/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core-web/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core-web/tags","blobs_url":"https://api.github.com/repos/dotCMS/core-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core-web/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core-web/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core-web/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core-web/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core-web/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core-web/subscription","commits_url":"https://api.github.com/repos/dotCMS/core-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core-web/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core-web/merges","archive_url":"https://api.github.com/repos/dotCMS/core-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core-web/downloads","issues_url":"https://api.github.com/repos/dotCMS/core-web/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core-web/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core-web/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core-web/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core-web/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core-web/deployments","created_at":"2015-05-27T15:26:16Z","updated_at":"2018-02-05T15:59:54Z","pushed_at":"2018-03-13T17:30:48Z","git_url":"git://github.com/dotCMS/core-web.git","ssh_url":"git@github.com:dotCMS/core-web.git","clone_url":"https://github.com/dotCMS/core-web.git","svn_url":"https://github.com/dotCMS/core-web","homepage":"https://dotcms.com","size":9672,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":2,"open_issues":10,"watchers":4,"default_branch":"master"}},"base":{"label":"dotCMS:master","ref":"master","sha":"2cde01938767486fb893f8ac20e2af631a420e40","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":36376350,"name":"core-web","full_name":"dotCMS/core-web","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core-web","description":"dotCMS UI","fork":false,"url":"https://api.github.com/repos/dotCMS/core-web","forks_url":"https://api.github.com/repos/dotCMS/core-web/forks","keys_url":"https://api.github.com/repos/dotCMS/core-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core-web/teams","hooks_url":"https://api.github.com/repos/dotCMS/core-web/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core-web/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core-web/events","assignees_url":"https://api.github.com/repos/dotCMS/core-web/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core-web/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core-web/tags","blobs_url":"https://api.github.com/repos/dotCMS/core-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core-web/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core-web/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core-web/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core-web/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core-web/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core-web/subscription","commits_url":"https://api.github.com/repos/dotCMS/core-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core-web/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core-web/merges","archive_url":"https://api.github.com/repos/dotCMS/core-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core-web/downloads","issues_url":"https://api.github.com/repos/dotCMS/core-web/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core-web/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core-web/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core-web/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core-web/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core-web/deployments","created_at":"2015-05-27T15:26:16Z","updated_at":"2018-02-05T15:59:54Z","pushed_at":"2018-03-13T17:30:48Z","git_url":"git://github.com/dotCMS/core-web.git","ssh_url":"git@github.com:dotCMS/core-web.git","clone_url":"https://github.com/dotCMS/core-web.git","svn_url":"https://github.com/dotCMS/core-web","homepage":"https://dotcms.com","size":9672,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":2,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/567"},"html":{"href":"https://github.com/dotCMS/core-web/pull/567"},"issue":{"href":"https://api.github.com/repos/dotCMS/core-web/issues/567"},"comments":{"href":"https://api.github.com/repos/dotCMS/core-web/issues/567/comments"},"review_comments":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/567/comments"},"review_comment":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/567/commits"},"statuses":{"href":"https://api.github.com/repos/dotCMS/core-web/statuses/96fa050de3866ff421fe605262b6fa561e2404af"}},"author_association":"NONE"}}
{"actor":{"display_login":"fmontes"}}