{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/19030","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/19030/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/19030/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/19030/events","html_url":"https://github.com/magento/magento2/pull/19030","id":376815421,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTQwNjg4","number":19030,"title":"[ISM][#18651 tierprice can t save float percentage value","user":{"login":"SikailoISM","id":44577971,"node_id":"MDQ6VXNlcjQ0NTc3OTcx","avatar_url":"https://avatars2.githubusercontent.com/u/44577971?v=4","gravatar_id":"","url":"https://api.github.com/users/SikailoISM","html_url":"https://github.com/SikailoISM","followers_url":"https://api.github.com/users/SikailoISM/followers","following_url":"https://api.github.com/users/SikailoISM/following{/other_user}","gists_url":"https://api.github.com/users/SikailoISM/gists{/gist_id}","starred_url":"https://api.github.com/users/SikailoISM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SikailoISM/subscriptions","organizations_url":"https://api.github.com/users/SikailoISM/orgs","repos_url":"https://api.github.com/users/SikailoISM/repos","events_url":"https://api.github.com/users/SikailoISM/events{/privacy}","received_events_url":"https://api.github.com/users/SikailoISM/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-02T13:43:57Z","updated_at":"2018-11-02T13:44:00Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/19030","html_url":"https://github.com/magento/magento2/pull/19030","diff_url":"https://github.com/magento/magento2/pull/19030.diff","patch_url":"https://github.com/magento/magento2/pull/19030.patch"},"body":"### Tierprice can't save float percentage value\r\n\r\n### Description\r\nProblem:\r\nAfter save tierprice for product, `discount` field lost value after comma.\r\nFix:\r\nUpdated getPercentage method in TierPrices:\r\n- Type conversation changed: int -> float\r\n- Added strict types\r\n- Database has remained unchanged since the percentage_value is a decimal field\r\n\r\n### Fixed Issues\r\n1. magento/magento2#18651: Tierprice can't save float percentage value\r\n\r\n### Manual testing scenarios\r\n1. Add new product\r\n2. Add new tierprice with `discount` value \"2.5\"\r\n3. Save the product\r\n4. Value \"2.5\" is saved\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/435384286","html_url":"https://github.com/magento/magento2/pull/19030#issuecomment-435384286","issue_url":"https://api.github.com/repos/magento/magento2/issues/19030","id":435384286,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTM4NDI4Ng==","user":{"login":"magento-cicd2","id":14279950,"node_id":"MDQ6VXNlcjE0Mjc5OTUw","avatar_url":"https://avatars2.githubusercontent.com/u/14279950?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-cicd2","html_url":"https://github.com/magento-cicd2","followers_url":"https://api.github.com/users/magento-cicd2/followers","following_url":"https://api.github.com/users/magento-cicd2/following{/other_user}","gists_url":"https://api.github.com/users/magento-cicd2/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-cicd2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-cicd2/subscriptions","organizations_url":"https://api.github.com/users/magento-cicd2/orgs","repos_url":"https://api.github.com/users/magento-cicd2/repos","events_url":"https://api.github.com/users/magento-cicd2/events{/privacy}","received_events_url":"https://api.github.com/users/magento-cicd2/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T13:44:00Z","updated_at":"2018-11-02T13:44:00Z","author_association":"CONTRIBUTOR","body":"[![CLA assistant check](https://cla.dev.magento.com/pull/badge/not_signed)](https://cla.dev.magento.com/magento/magento2?pullRequest=19030) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla.dev.magento.com/magento/magento2?pullRequest=19030) before we can accept your contribution.<br/>"}}
{"actor":{"display_login":"magento-cicd2"}}