{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaMath/IntervalSets.jl/issues/26","repository_url":"https://api.github.com/repos/JuliaMath/IntervalSets.jl","labels_url":"https://api.github.com/repos/JuliaMath/IntervalSets.jl/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/JuliaMath/IntervalSets.jl/issues/26/comments","events_url":"https://api.github.com/repos/JuliaMath/IntervalSets.jl/issues/26/events","html_url":"https://github.com/JuliaMath/IntervalSets.jl/pull/26","id":306512249,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1OTM2MzU2","number":26,"title":"Add open and mixed open/closed intervals","user":{"login":"dlfivefifty","id":1229737,"node_id":"MDQ6VXNlcjEyMjk3Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1229737?v=4","gravatar_id":"","url":"https://api.github.com/users/dlfivefifty","html_url":"https://github.com/dlfivefifty","followers_url":"https://api.github.com/users/dlfivefifty/followers","following_url":"https://api.github.com/users/dlfivefifty/following{/other_user}","gists_url":"https://api.github.com/users/dlfivefifty/gists{/gist_id}","starred_url":"https://api.github.com/users/dlfivefifty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlfivefifty/subscriptions","organizations_url":"https://api.github.com/users/dlfivefifty/orgs","repos_url":"https://api.github.com/users/dlfivefifty/repos","events_url":"https://api.github.com/users/dlfivefifty/events{/privacy}","received_events_url":"https://api.github.com/users/dlfivefifty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-03-19T15:30:15Z","updated_at":"2018-09-01T14:39:13Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/JuliaMath/IntervalSets.jl/pulls/26","html_url":"https://github.com/JuliaMath/IntervalSets.jl/pull/26","diff_url":"https://github.com/JuliaMath/IntervalSets.jl/pull/26.diff","patch_url":"https://github.com/JuliaMath/IntervalSets.jl/pull/26.patch"},"body":"This PR adds support for general closed/open endpoints.\r\n\r\nIt also makes the following changes which I believe are necessary:\r\n\r\n1. `union(a .. b, nextfloat(b) .. c)` now throws an error (for `a < b < c`): this is consistent with the fact that `union(0 .. 1, 2..3)` should not be `0 .. 3`, and because \r\n```julia\r\na, b, c = 0.0, 1.0, 2.0\r\nx = nextfloat(BigFloat(b))\r\n!(x in a..b) && !(x in nextfloat(b)..c)\r\n```\r\nPreviously `x in union(a .. b, nextfloat(b) .. c)`  returned true, which is inconsistent with the above!\r\n2. `convert(UnitRange, 0..1)` is now deprecated in favour of `UnitRange(0..1)`, as `convert` should throw an error (e.g. `convert(Int, 1+Im)` throws an error)."},"comment":{"url":"https://api.github.com/repos/JuliaMath/IntervalSets.jl/issues/comments/417863967","html_url":"https://github.com/JuliaMath/IntervalSets.jl/pull/26#issuecomment-417863967","issue_url":"https://api.github.com/repos/JuliaMath/IntervalSets.jl/issues/26","id":417863967,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzg2Mzk2Nw==","user":{"login":"timholy","id":1525481,"node_id":"MDQ6VXNlcjE1MjU0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525481?v=4","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"created_at":"2018-09-01T14:39:13Z","updated_at":"2018-09-01T14:39:13Z","author_association":"CONTRIBUTOR","body":"On my phone. See my recent PR to Base re issubset. Can't really check rest\nnow, you are authorized to decide😀\n\nOn Sat, Sep 1, 2018, 8:39 AM Sheehan Olver <notifications@github.com> wrote:\n\n> That's OK, I've resolved the conflicts, though you might have comments on\n> the changes I made:\n>\n>    1. I removed the general AbstractUnitRange conversion because it\n>    seemed to broad, in favour of specific ones:\n>\n> UnitRange{T}(i::TypedEndpointsInterval{:closed,:closed,I}) where {T<:Integer,I<:Integer} = UnitRange{T}(minimum(i), maximum(i))UnitRange(i::TypedEndpointsInterval{:closed,:closed,I}) where {I<:Integer} = UnitRange{I}(i)\n>\n>\n>    1. I added convert(AbstractInterval, x::Number) and variants\n>    2. I overrode issubset, as the existing definition called the now\n>    deprecated length.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/JuliaMath/IntervalSets.jl/pull/26#issuecomment-417860448>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABdG6e1ZaYls6XNKD2UV4ZIUspZDGOLvks5uWo3_gaJpZM4SwYH_>\n> .\n>\n"}}
{"actor":{"display_login":"timholy"}}