{"action":"created","issue":{"url":"https://api.github.com/repos/vector-im/riot-web/issues/6365","repository_url":"https://api.github.com/repos/vector-im/riot-web","labels_url":"https://api.github.com/repos/vector-im/riot-web/issues/6365/labels{/name}","comments_url":"https://api.github.com/repos/vector-im/riot-web/issues/6365/comments","events_url":"https://api.github.com/repos/vector-im/riot-web/issues/6365/events","html_url":"https://github.com/vector-im/riot-web/issues/6365","id":307319437,"number":6365,"title":"We don't cache bust /sync (and presumably other APIs)","user":{"login":"lukebarnard1","id":6750344,"avatar_url":"https://avatars1.githubusercontent.com/u/6750344?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebarnard1","html_url":"https://github.com/lukebarnard1","followers_url":"https://api.github.com/users/lukebarnard1/followers","following_url":"https://api.github.com/users/lukebarnard1/following{/other_user}","gists_url":"https://api.github.com/users/lukebarnard1/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebarnard1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebarnard1/subscriptions","organizations_url":"https://api.github.com/users/lukebarnard1/orgs","repos_url":"https://api.github.com/users/lukebarnard1/repos","events_url":"https://api.github.com/users/lukebarnard1/events{/privacy}","received_events_url":"https://api.github.com/users/lukebarnard1/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-21T16:23:57Z","updated_at":"2018-03-21T17:43:25Z","closed_at":"2018-03-21T17:43:25Z","author_association":"CONTRIBUTOR","body":"If nothing happens on a homeserver for >30s, the /sync request will respond with a sync token = the token we sent a request with. Apparently, this gets cached in a way that means we'll never get a newer /sync because the browser hits cache when we do the next request (with the same token).\r\n\r\nSo we should probably bust the cache on the /sync API, and presumably others (but this is probably worse because the failure mode is quite bad). \r\n\r\nIt's a bit of an edge case because the common case is that the homeserver has changes to give to clients.\r\n\r\ncc. @erikjohnston, @rxl881 (who discovered this)"},"comment":{"url":"https://api.github.com/repos/vector-im/riot-web/issues/comments/375034003","html_url":"https://github.com/vector-im/riot-web/issues/6365#issuecomment-375034003","issue_url":"https://api.github.com/repos/vector-im/riot-web/issues/6365","id":375034003,"user":{"login":"richvdh","id":1389908,"avatar_url":"https://avatars1.githubusercontent.com/u/1389908?v=4","gravatar_id":"","url":"https://api.github.com/users/richvdh","html_url":"https://github.com/richvdh","followers_url":"https://api.github.com/users/richvdh/followers","following_url":"https://api.github.com/users/richvdh/following{/other_user}","gists_url":"https://api.github.com/users/richvdh/gists{/gist_id}","starred_url":"https://api.github.com/users/richvdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richvdh/subscriptions","organizations_url":"https://api.github.com/users/richvdh/orgs","repos_url":"https://api.github.com/users/richvdh/repos","events_url":"https://api.github.com/users/richvdh/events{/privacy}","received_events_url":"https://api.github.com/users/richvdh/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T17:43:25Z","updated_at":"2018-03-21T17:43:25Z","author_association":"CONTRIBUTOR","body":"After further discussion, the conclusion was that we should fix this using cache-control headers from the server, rather than using cachebusters on the client (which are a bit ming)."}}
{"actor":{"display_login":"richvdh"}}