{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/18790","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/18790/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18790/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/18790/events","html_url":"https://github.com/magento/magento2/pull/18790","id":373648846,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTI4Mzkx","number":18790,"title":"fixed Product Advanced Pricing design issue #18775","user":{"login":"ashutoshwebkul","id":35421797,"node_id":"MDQ6VXNlcjM1NDIxNzk3","avatar_url":"https://avatars2.githubusercontent.com/u/35421797?v=4","gravatar_id":"","url":"https://api.github.com/users/ashutoshwebkul","html_url":"https://github.com/ashutoshwebkul","followers_url":"https://api.github.com/users/ashutoshwebkul/followers","following_url":"https://api.github.com/users/ashutoshwebkul/following{/other_user}","gists_url":"https://api.github.com/users/ashutoshwebkul/gists{/gist_id}","starred_url":"https://api.github.com/users/ashutoshwebkul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashutoshwebkul/subscriptions","organizations_url":"https://api.github.com/users/ashutoshwebkul/orgs","repos_url":"https://api.github.com/users/ashutoshwebkul/repos","events_url":"https://api.github.com/users/ashutoshwebkul/events{/privacy}","received_events_url":"https://api.github.com/users/ashutoshwebkul/received_events","type":"User","site_admin":false},"labels":[{"id":394366531,"node_id":"MDU6TGFiZWwzOTQzNjY1MzE=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Frontend","name":"Area: Frontend","color":"1d76db","default":false},{"id":944460665,"node_id":"MDU6TGFiZWw5NDQ0NjA2NjU=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Ui","name":"Component: Ui","color":"7fb703","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"sidolov","id":11355520,"node_id":"MDQ6VXNlcjExMzU1NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/11355520?v=4","gravatar_id":"","url":"https://api.github.com/users/sidolov","html_url":"https://github.com/sidolov","followers_url":"https://api.github.com/users/sidolov/followers","following_url":"https://api.github.com/users/sidolov/following{/other_user}","gists_url":"https://api.github.com/users/sidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/sidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidolov/subscriptions","organizations_url":"https://api.github.com/users/sidolov/orgs","repos_url":"https://api.github.com/users/sidolov/repos","events_url":"https://api.github.com/users/sidolov/events{/privacy}","received_events_url":"https://api.github.com/users/sidolov/received_events","type":"User","site_admin":false},"assignees":[{"login":"sidolov","id":11355520,"node_id":"MDQ6VXNlcjExMzU1NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/11355520?v=4","gravatar_id":"","url":"https://api.github.com/users/sidolov","html_url":"https://github.com/sidolov","followers_url":"https://api.github.com/users/sidolov/followers","following_url":"https://api.github.com/users/sidolov/following{/other_user}","gists_url":"https://api.github.com/users/sidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/sidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidolov/subscriptions","organizations_url":"https://api.github.com/users/sidolov/orgs","repos_url":"https://api.github.com/users/sidolov/repos","events_url":"https://api.github.com/users/sidolov/events{/privacy}","received_events_url":"https://api.github.com/users/sidolov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/23","html_url":"https://github.com/magento/magento2/milestone/23","labels_url":"https://api.github.com/repos/magento/magento2/milestones/23/labels","id":3664445,"node_id":"MDk6TWlsZXN0b25lMzY2NDQ0NQ==","number":23,"title":"Release: 2.3.1","description":"Community pull requests delivered to Release: 2.3.1 release","creator":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"open_issues":108,"closed_issues":112,"state":"open","created_at":"2018-09-18T07:31:32Z","updated_at":"2018-10-25T08:18:06Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-10-24T19:48:38Z","updated_at":"2018-10-25T08:18:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18790","html_url":"https://github.com/magento/magento2/pull/18790","diff_url":"https://github.com/magento/magento2/pull/18790.diff","patch_url":"https://github.com/magento/magento2/pull/18790.patch"},"body":"\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description (*)\r\nThere was a small design issue die to app/code/Magento/Ui/view/base/web/templates/form/field.html file visible=\"$data.labelVisible\" was on child element of the label, because of that parent was still visible even if the label visibility was false.\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\n1. magento/magento2#18775: Product Advanced Pricing design issue\r\n\r\n### Manual testing scenarios (*)\r\n<!---\r\n    Please provide a set of unambiguous steps to test the proposed code change.\r\n    Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1. login magento admin\r\n2. goto catalog products\r\n3: click on Add Product button\r\n4: fill details then click on Advanced Pricing\r\n5: in customer group price click Add\r\n\r\n### Contribution checklist (*)\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/432958014","html_url":"https://github.com/magento/magento2/pull/18790#issuecomment-432958014","issue_url":"https://api.github.com/repos/magento/magento2/issues/18790","id":432958014,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjk1ODAxNA==","user":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T08:18:29Z","updated_at":"2018-10-25T08:18:29Z","author_association":"CONTRIBUTOR","body":"Hi @sidolov, thank you for the review.\n[ENGCOM-3267](https://jira.corp.magento.com/browse/ENGCOM-3267) has been created to process this Pull Request"}}
{"actor":{"display_login":"magento-engcom-team"}}