{"action":"created","comment":{"url":"https://api.github.com/repos/fanequinha/cerebro/pulls/comments/209437244","pull_request_review_id":145456882,"id":209437244,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQzNzI0NA==","diff_hunk":"@@ -0,0 +1,54 @@\n+#!/usr/bin/env python\n+# -*- coding: utf-8 -*-\n+import argparse\n+\n+import settings\n+from engine import Engine\n+\n+\n+def main():\n+    connection_string = settings.DEFAULT_SERIAL_PORT\n+    baud_rate = settings.DEFAULT_BAUD_RATE\n+\n+    if arg_options.connect:\n+        connection_string = arg_options.connect\n+    if arg_options.baud_rate:\n+        baud_rate = arg_options.baud_rate\n+\n+    engine = Engine(connection_string, baudrate=baud_rate)","path":"commander/main.py","position":18,"original_position":18,"commit_id":"0da07702f5ea5781d3a1c16262f83753707a3b36","original_commit_id":"0da07702f5ea5781d3a1c16262f83753707a3b36","user":{"login":"alexhermida","id":4062867,"node_id":"MDQ6VXNlcjQwNjI4Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/4062867?v=4","gravatar_id":"","url":"https://api.github.com/users/alexhermida","html_url":"https://github.com/alexhermida","followers_url":"https://api.github.com/users/alexhermida/followers","following_url":"https://api.github.com/users/alexhermida/following{/other_user}","gists_url":"https://api.github.com/users/alexhermida/gists{/gist_id}","starred_url":"https://api.github.com/users/alexhermida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexhermida/subscriptions","organizations_url":"https://api.github.com/users/alexhermida/orgs","repos_url":"https://api.github.com/users/alexhermida/repos","events_url":"https://api.github.com/users/alexhermida/events{/privacy}","received_events_url":"https://api.github.com/users/alexhermida/received_events","type":"User","site_admin":false},"body":"Would be an option but I think that in this case it makes sense to be in the initialization of the `Engine` class because those attributes are essential for it to work. ","created_at":"2018-08-11T20:49:33Z","updated_at":"2018-08-11T20:49:33Z","html_url":"https://github.com/fanequinha/cerebro/pull/19#discussion_r209437244","pull_request_url":"https://api.github.com/repos/fanequinha/cerebro/pulls/19","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fanequinha/cerebro/pulls/comments/209437244"},"html":{"href":"https://github.com/fanequinha/cerebro/pull/19#discussion_r209437244"},"pull_request":{"href":"https://api.github.com/repos/fanequinha/cerebro/pulls/19"}},"in_reply_to_id":208814346},"pull_request":{"url":"https://api.github.com/repos/fanequinha/cerebro/pulls/19","id":207090940,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDkwOTQw","html_url":"https://github.com/fanequinha/cerebro/pull/19","diff_url":"https://github.com/fanequinha/cerebro/pull/19.diff","patch_url":"https://github.com/fanequinha/cerebro/pull/19.patch","issue_url":"https://api.github.com/repos/fanequinha/cerebro/issues/19","number":19,"state":"open","locked":false,"title":"Add testing and first commands","user":{"login":"alexhermida","id":4062867,"node_id":"MDQ6VXNlcjQwNjI4Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/4062867?v=4","gravatar_id":"","url":"https://api.github.com/users/alexhermida","html_url":"https://github.com/alexhermida","followers_url":"https://api.github.com/users/alexhermida/followers","following_url":"https://api.github.com/users/alexhermida/following{/other_user}","gists_url":"https://api.github.com/users/alexhermida/gists{/gist_id}","starred_url":"https://api.github.com/users/alexhermida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexhermida/subscriptions","organizations_url":"https://api.github.com/users/alexhermida/orgs","repos_url":"https://api.github.com/users/alexhermida/repos","events_url":"https://api.github.com/users/alexhermida/events{/privacy}","received_events_url":"https://api.github.com/users/alexhermida/received_events","type":"User","site_admin":false},"body":"* Added first test\r\n\r\n    ```\r\n        >cd commander/\r\n        >pytest .\r\n    ```\r\n\r\n* First connection\r\n\r\n    ```\r\n        >cd commander/\r\n        >./main.py\r\n    ```\r\n\r\n* Listen location, attitude, velocity and gps\r\n\r\n    ```\r\n        >cd commander/\r\n        >./main.py -l\r\n    ```","created_at":"2018-08-08T18:04:32Z","updated_at":"2018-08-11T20:49:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eadbad1df61e510fa7678760c9a86b6a2c7c1961","assignee":null,"assignees":[],"requested_reviewers":[{"login":"eloycoto","id":868013,"node_id":"MDQ6VXNlcjg2ODAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fanequinha/cerebro/pulls/19/commits","review_comments_url":"https://api.github.com/repos/fanequinha/cerebro/pulls/19/comments","review_comment_url":"https://api.github.com/repos/fanequinha/cerebro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fanequinha/cerebro/issues/19/comments","statuses_url":"https://api.github.com/repos/fanequinha/cerebro/statuses/0da07702f5ea5781d3a1c16262f83753707a3b36","head":{"label":"fanequinha:ft/add_testing","ref":"ft/add_testing","sha":"0da07702f5ea5781d3a1c16262f83753707a3b36","user":{"login":"fanequinha","id":40213746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjEzNzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/40213746?v=4","gravatar_id":"","url":"https://api.github.com/users/fanequinha","html_url":"https://github.com/fanequinha","followers_url":"https://api.github.com/users/fanequinha/followers","following_url":"https://api.github.com/users/fanequinha/following{/other_user}","gists_url":"https://api.github.com/users/fanequinha/gists{/gist_id}","starred_url":"https://api.github.com/users/fanequinha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanequinha/subscriptions","organizations_url":"https://api.github.com/users/fanequinha/orgs","repos_url":"https://api.github.com/users/fanequinha/repos","events_url":"https://api.github.com/users/fanequinha/events{/privacy}","received_events_url":"https://api.github.com/users/fanequinha/received_events","type":"Organization","site_admin":false},"repo":{"id":137116144,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMTYxNDQ=","name":"cerebro","full_name":"fanequinha/cerebro","owner":{"login":"fanequinha","id":40213746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjEzNzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/40213746?v=4","gravatar_id":"","url":"https://api.github.com/users/fanequinha","html_url":"https://github.com/fanequinha","followers_url":"https://api.github.com/users/fanequinha/followers","following_url":"https://api.github.com/users/fanequinha/following{/other_user}","gists_url":"https://api.github.com/users/fanequinha/gists{/gist_id}","starred_url":"https://api.github.com/users/fanequinha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanequinha/subscriptions","organizations_url":"https://api.github.com/users/fanequinha/orgs","repos_url":"https://api.github.com/users/fanequinha/repos","events_url":"https://api.github.com/users/fanequinha/events{/privacy}","received_events_url":"https://api.github.com/users/fanequinha/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fanequinha/cerebro","description":null,"fork":false,"url":"https://api.github.com/repos/fanequinha/cerebro","forks_url":"https://api.github.com/repos/fanequinha/cerebro/forks","keys_url":"https://api.github.com/repos/fanequinha/cerebro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fanequinha/cerebro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fanequinha/cerebro/teams","hooks_url":"https://api.github.com/repos/fanequinha/cerebro/hooks","issue_events_url":"https://api.github.com/repos/fanequinha/cerebro/issues/events{/number}","events_url":"https://api.github.com/repos/fanequinha/cerebro/events","assignees_url":"https://api.github.com/repos/fanequinha/cerebro/assignees{/user}","branches_url":"https://api.github.com/repos/fanequinha/cerebro/branches{/branch}","tags_url":"https://api.github.com/repos/fanequinha/cerebro/tags","blobs_url":"https://api.github.com/repos/fanequinha/cerebro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fanequinha/cerebro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fanequinha/cerebro/git/refs{/sha}","trees_url":"https://api.github.com/repos/fanequinha/cerebro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fanequinha/cerebro/statuses/{sha}","languages_url":"https://api.github.com/repos/fanequinha/cerebro/languages","stargazers_url":"https://api.github.com/repos/fanequinha/cerebro/stargazers","contributors_url":"https://api.github.com/repos/fanequinha/cerebro/contributors","subscribers_url":"https://api.github.com/repos/fanequinha/cerebro/subscribers","subscription_url":"https://api.github.com/repos/fanequinha/cerebro/subscription","commits_url":"https://api.github.com/repos/fanequinha/cerebro/commits{/sha}","git_commits_url":"https://api.github.com/repos/fanequinha/cerebro/git/commits{/sha}","comments_url":"https://api.github.com/repos/fanequinha/cerebro/comments{/number}","issue_comment_url":"https://api.github.com/repos/fanequinha/cerebro/issues/comments{/number}","contents_url":"https://api.github.com/repos/fanequinha/cerebro/contents/{+path}","compare_url":"https://api.github.com/repos/fanequinha/cerebro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fanequinha/cerebro/merges","archive_url":"https://api.github.com/repos/fanequinha/cerebro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fanequinha/cerebro/downloads","issues_url":"https://api.github.com/repos/fanequinha/cerebro/issues{/number}","pulls_url":"https://api.github.com/repos/fanequinha/cerebro/pulls{/number}","milestones_url":"https://api.github.com/repos/fanequinha/cerebro/milestones{/number}","notifications_url":"https://api.github.com/repos/fanequinha/cerebro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fanequinha/cerebro/labels{/name}","releases_url":"https://api.github.com/repos/fanequinha/cerebro/releases{/id}","deployments_url":"https://api.github.com/repos/fanequinha/cerebro/deployments","created_at":"2018-06-12T19:07:15Z","updated_at":"2018-08-08T08:39:24Z","pushed_at":"2018-08-08T18:04:33Z","git_url":"git://github.com/fanequinha/cerebro.git","ssh_url":"git@github.com:fanequinha/cerebro.git","clone_url":"https://github.com/fanequinha/cerebro.git","svn_url":"https://github.com/fanequinha/cerebro","homepage":null,"size":12822,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"fanequinha:master","ref":"master","sha":"a0ff02957ffe5596616fc85829c29c71227aefa3","user":{"login":"fanequinha","id":40213746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjEzNzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/40213746?v=4","gravatar_id":"","url":"https://api.github.com/users/fanequinha","html_url":"https://github.com/fanequinha","followers_url":"https://api.github.com/users/fanequinha/followers","following_url":"https://api.github.com/users/fanequinha/following{/other_user}","gists_url":"https://api.github.com/users/fanequinha/gists{/gist_id}","starred_url":"https://api.github.com/users/fanequinha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanequinha/subscriptions","organizations_url":"https://api.github.com/users/fanequinha/orgs","repos_url":"https://api.github.com/users/fanequinha/repos","events_url":"https://api.github.com/users/fanequinha/events{/privacy}","received_events_url":"https://api.github.com/users/fanequinha/received_events","type":"Organization","site_admin":false},"repo":{"id":137116144,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMTYxNDQ=","name":"cerebro","full_name":"fanequinha/cerebro","owner":{"login":"fanequinha","id":40213746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjEzNzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/40213746?v=4","gravatar_id":"","url":"https://api.github.com/users/fanequinha","html_url":"https://github.com/fanequinha","followers_url":"https://api.github.com/users/fanequinha/followers","following_url":"https://api.github.com/users/fanequinha/following{/other_user}","gists_url":"https://api.github.com/users/fanequinha/gists{/gist_id}","starred_url":"https://api.github.com/users/fanequinha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanequinha/subscriptions","organizations_url":"https://api.github.com/users/fanequinha/orgs","repos_url":"https://api.github.com/users/fanequinha/repos","events_url":"https://api.github.com/users/fanequinha/events{/privacy}","received_events_url":"https://api.github.com/users/fanequinha/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fanequinha/cerebro","description":null,"fork":false,"url":"https://api.github.com/repos/fanequinha/cerebro","forks_url":"https://api.github.com/repos/fanequinha/cerebro/forks","keys_url":"https://api.github.com/repos/fanequinha/cerebro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fanequinha/cerebro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fanequinha/cerebro/teams","hooks_url":"https://api.github.com/repos/fanequinha/cerebro/hooks","issue_events_url":"https://api.github.com/repos/fanequinha/cerebro/issues/events{/number}","events_url":"https://api.github.com/repos/fanequinha/cerebro/events","assignees_url":"https://api.github.com/repos/fanequinha/cerebro/assignees{/user}","branches_url":"https://api.github.com/repos/fanequinha/cerebro/branches{/branch}","tags_url":"https://api.github.com/repos/fanequinha/cerebro/tags","blobs_url":"https://api.github.com/repos/fanequinha/cerebro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fanequinha/cerebro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fanequinha/cerebro/git/refs{/sha}","trees_url":"https://api.github.com/repos/fanequinha/cerebro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fanequinha/cerebro/statuses/{sha}","languages_url":"https://api.github.com/repos/fanequinha/cerebro/languages","stargazers_url":"https://api.github.com/repos/fanequinha/cerebro/stargazers","contributors_url":"https://api.github.com/repos/fanequinha/cerebro/contributors","subscribers_url":"https://api.github.com/repos/fanequinha/cerebro/subscribers","subscription_url":"https://api.github.com/repos/fanequinha/cerebro/subscription","commits_url":"https://api.github.com/repos/fanequinha/cerebro/commits{/sha}","git_commits_url":"https://api.github.com/repos/fanequinha/cerebro/git/commits{/sha}","comments_url":"https://api.github.com/repos/fanequinha/cerebro/comments{/number}","issue_comment_url":"https://api.github.com/repos/fanequinha/cerebro/issues/comments{/number}","contents_url":"https://api.github.com/repos/fanequinha/cerebro/contents/{+path}","compare_url":"https://api.github.com/repos/fanequinha/cerebro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fanequinha/cerebro/merges","archive_url":"https://api.github.com/repos/fanequinha/cerebro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fanequinha/cerebro/downloads","issues_url":"https://api.github.com/repos/fanequinha/cerebro/issues{/number}","pulls_url":"https://api.github.com/repos/fanequinha/cerebro/pulls{/number}","milestones_url":"https://api.github.com/repos/fanequinha/cerebro/milestones{/number}","notifications_url":"https://api.github.com/repos/fanequinha/cerebro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fanequinha/cerebro/labels{/name}","releases_url":"https://api.github.com/repos/fanequinha/cerebro/releases{/id}","deployments_url":"https://api.github.com/repos/fanequinha/cerebro/deployments","created_at":"2018-06-12T19:07:15Z","updated_at":"2018-08-08T08:39:24Z","pushed_at":"2018-08-08T18:04:33Z","git_url":"git://github.com/fanequinha/cerebro.git","ssh_url":"git@github.com:fanequinha/cerebro.git","clone_url":"https://github.com/fanequinha/cerebro.git","svn_url":"https://github.com/fanequinha/cerebro","homepage":null,"size":12822,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fanequinha/cerebro/pulls/19"},"html":{"href":"https://github.com/fanequinha/cerebro/pull/19"},"issue":{"href":"https://api.github.com/repos/fanequinha/cerebro/issues/19"},"comments":{"href":"https://api.github.com/repos/fanequinha/cerebro/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/fanequinha/cerebro/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/fanequinha/cerebro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fanequinha/cerebro/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/fanequinha/cerebro/statuses/0da07702f5ea5781d3a1c16262f83753707a3b36"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alexhermida"}}