{"action":"created","issue":{"url":"https://api.github.com/repos/zmxv/react-native-sound/issues/380","repository_url":"https://api.github.com/repos/zmxv/react-native-sound","labels_url":"https://api.github.com/repos/zmxv/react-native-sound/issues/380/labels{/name}","comments_url":"https://api.github.com/repos/zmxv/react-native-sound/issues/380/comments","events_url":"https://api.github.com/repos/zmxv/react-native-sound/issues/380/events","html_url":"https://github.com/zmxv/react-native-sound/issues/380","id":298637374,"number":380,"title":"[Android + iOS] Build errors incompatible types: Double cannot be converted to Integer, etc.","user":{"login":"esutton","id":6115047,"avatar_url":"https://avatars3.githubusercontent.com/u/6115047?v=4","gravatar_id":"","url":"https://api.github.com/users/esutton","html_url":"https://github.com/esutton","followers_url":"https://api.github.com/users/esutton/followers","following_url":"https://api.github.com/users/esutton/following{/other_user}","gists_url":"https://api.github.com/users/esutton/gists{/gist_id}","starred_url":"https://api.github.com/users/esutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esutton/subscriptions","organizations_url":"https://api.github.com/users/esutton/orgs","repos_url":"https://api.github.com/users/esutton/repos","events_url":"https://api.github.com/users/esutton/events{/privacy}","received_events_url":"https://api.github.com/users/esutton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-02-20T15:30:55Z","updated_at":"2018-02-21T00:01:37Z","closed_at":null,"author_association":"NONE","body":"* Building and using react-native-sound was working fine on RN 0.53.0, and then it was not. \r\n* A brand new project with RN 0.53.3 builds fine.\r\n\r\nSorry I am stumped.  Any suggestions are appreciated.  \r\n* I have tried unlink and link.  \r\n* Manually removing all traces of 'sound' from build files, react-native link react-native-sound\r\n* Comparing a new working project build settings to my existing project.\r\n\r\n````\r\nmy-app/source/node_modules/react-native-sound/android/src/main/java/com/zmxv/RNSound/\r\nRNSoundModule.java:43: error: cannot find symbol\r\n    final ReactContext reactContext = this.context;\r\n          ^\r\n  symbol:   class ReactContext\r\n  location: class RNSoundModule\r\nmy-app/source/node_modules/react-native-sound/android/src/main/java/com/zmxv/RNSound/\r\nRNSoundModule.java:207: error: incompatible types: Double cannot be converted to Integer\r\n      setOnPlay(false, key);\r\n                       ^\r\nmy-app/source/node_modules/react-native-sound/android/src/main/java/com/zmxv/RNSound/\r\nRNSoundModule.java:223: error: incompatible types: Double cannot be converted to Integer\r\n      this.focusedPlayerKey = key;\r\n````                              ^\r\nmy-app/source/node_modules/react-native-sound/android/src/main/java/com/zmxv/RNSound/\r\nRNSoundModule.java:260: error: incompatible types: Double cannot be converted to Integer\r\n    setOnPlay(true, key);\r\n                    ^\r\nmy-app/source/node_modules/react-native-sound/android/src/main/java/com/zmxv/RNSound/\r\nRNSoundModule.java:284: error: incomparable types: Double and Integer\r\n    if (!this.mixWithOthers && key == this.focusedPlayerKey) {\r\n                                   ^\r\nmy-app/source/node_modules/react-native-sound/android/src/main/java/com/zmxv/RNSound/\r\nRNSoundModule.java:416: error: incompatible types: Integer cannot be converted to Double\r\n              this.pause(this.focusedPlayerKey, null);\r\n````\r\n\r\napp/build.gradle\r\n````\r\nandroid {\r\n    compileSdkVersion 23\r\n    buildToolsVersion \"23.0.1\"    \r\n\r\n    updateVersionInfoJs()\r\n\r\n    android {\r\n    dexOptions {\r\n        javaMaxHeapSize \"4g\"\r\n    }\r\n\r\n    defaultConfig {\r\n        applicationId \"com.ditchwitch.fieldscout\"\r\n        minSdkVersion 16\r\n        multiDexEnabled true\r\n        targetSdkVersion 22\r\n        versionCode getBuildNumber()\r\n        versionName getVersionString()\r\n        setProperty(\"archivesBaseName\", \"field-scout-android-$versionName\")        \r\n        ndk {\r\n            abiFilters \"armeabi-v7a\", \"x86\"\r\n        }\r\n    }\r\n````\r\n\r\n````\r\n\t\"react\": \"^16.2.0\",\r\n\t\"react-native\": \"^0.53.3\",\r\n\t\"react-native-sound\": \"^0.10.4\",\r\n````\r\n\r\niOS Build Errors:\r\n````\r\nmy-app/source/node_modules/react-native-sound/RNSound/RNSound.h:11:1: error: missing '@end'\r\n@interface RNSound : NSObject <RCTBridgeModule, AVAudioPlayerDelegate>\r\n^\r\nmy-app/source/node_modules/react-native-sound/RNSound/RNSound.h:10:1: note: class started here\r\n@interface RNSound : RCTEventEmitter <RCTBridgeModule, AVAudioPlayerDelegate>\r\n^\r\nmy-app/source/node_modules/react-native-sound/RNSound/RNSound.h:11:20: error: expected identifier or '('\r\n@interface RNSound : NSObject <RCTBridgeModule, AVAudioPlayerDelegate>\r\n                   ^\r\nmy-app/source/node_modules/react-native-sound/RNSound/RNSound.m:14:13: error: property implementation must\r\n      have its declaration in interface 'RNSound' or one of its extensions\r\n@synthesize _key = _key;\r\n            ^\r\nmy-app/source/node_modules/react-native-sound/RNSound/RNSound.m:20:53: error: property '_key' not found on\r\n      object of type 'RNSound *'\r\n    AVAudioPlayer* player = [self playerForKey:self._key];\r\n                                                    ^\r\nmy-app/source/node_modules/react-native-sound/RNSound/RNSound.m:221:8: error: property '_key' not found on\r\n      object of type 'RNSound *'\r\n  self._key = key;\r\n````\r\n Thank you for sharing your work and react-native-sound !\r\n\r\nThanks in advance for any tips or suggestions."},"comment":{"url":"https://api.github.com/repos/zmxv/react-native-sound/issues/comments/367164846","html_url":"https://github.com/zmxv/react-native-sound/issues/380#issuecomment-367164846","issue_url":"https://api.github.com/repos/zmxv/react-native-sound/issues/380","id":367164846,"user":{"login":"esutton","id":6115047,"avatar_url":"https://avatars3.githubusercontent.com/u/6115047?v=4","gravatar_id":"","url":"https://api.github.com/users/esutton","html_url":"https://github.com/esutton","followers_url":"https://api.github.com/users/esutton/followers","following_url":"https://api.github.com/users/esutton/following{/other_user}","gists_url":"https://api.github.com/users/esutton/gists{/gist_id}","starred_url":"https://api.github.com/users/esutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esutton/subscriptions","organizations_url":"https://api.github.com/users/esutton/orgs","repos_url":"https://api.github.com/users/esutton/repos","events_url":"https://api.github.com/users/esutton/events{/privacy}","received_events_url":"https://api.github.com/users/esutton/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T00:01:37Z","updated_at":"2018-02-21T00:01:37Z","author_association":"NONE","body":"@trepidity Same compile errors\r\n````\r\n\t\"react-native-sound\": \"^0.10.6\",\r\n\r\n: error: cannot find symbol\r\n    final ReactContext reactContext = this.context;\r\n\r\n7: error: incompatible types: Double cannot be converted to Integer\r\n      setOnPlay(false, key);\r\n````"}}
{"actor":{"display_login":"esutton"}}