{"action":"closed","number":5860,"pull_request":{"url":"https://api.github.com/repos/auth0/docs/pulls/5860","id":173665682,"node_id":"MDExOlB1bGxSZXF1ZXN0MTczNjY1Njgy","html_url":"https://github.com/auth0/docs/pull/5860","diff_url":"https://github.com/auth0/docs/pull/5860.diff","patch_url":"https://github.com/auth0/docs/pull/5860.patch","issue_url":"https://api.github.com/repos/auth0/docs/issues/5860","number":5860,"state":"closed","locked":false,"title":"Fix for sign up slack message rule","user":{"login":"neshanjo","id":22233722,"node_id":"MDQ6VXNlcjIyMjMzNzIy","avatar_url":"https://avatars0.githubusercontent.com/u/22233722?v=4","gravatar_id":"","url":"https://api.github.com/users/neshanjo","html_url":"https://github.com/neshanjo","followers_url":"https://api.github.com/users/neshanjo/followers","following_url":"https://api.github.com/users/neshanjo/following{/other_user}","gists_url":"https://api.github.com/users/neshanjo/gists{/gist_id}","starred_url":"https://api.github.com/users/neshanjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neshanjo/subscriptions","organizations_url":"https://api.github.com/users/neshanjo/orgs","repos_url":"https://api.github.com/users/neshanjo/repos","events_url":"https://api.github.com/users/neshanjo/events{/privacy}","received_events_url":"https://api.github.com/users/neshanjo/received_events","type":"User","site_admin":false},"body":"Also considering the following case:\r\nUser requests refresh token during sign up, hence user has registered and authenticated (context.stats.loginsCount is 1), message sent --> OK!\r\nUser uses refresh token to authenticate (context.stats.loginsCount still is 1 since refresh token usage does not count as login), message sent --> WRONG!\r\n\r\nChecking for context.protocol === 'oauth2-refresh-token' fixes this issue.\r\n\r\n<!---\r\nNotes:\r\n- Your PR should conform to our [Contributing Guidelines](https://github.com/auth0/docs/blob/master/CONTRIBUTING.md)\r\n- If applicable, add details to the [update feed](https://github.com/auth0/docs/tree/master/updates)\r\n- Make sure your PR gets deployed to a Heroku [Review App](https://github.com/auth0/docs/blob/master/CONTRIBUTING.md#review-apps) without errors.\r\n- Please include a short description\r\n- If your PR is a work in progress title it [DO NOT MERGE]\r\n--->\r\n","created_at":"2018-03-08T07:40:29Z","updated_at":"2018-08-07T14:39:00Z","closed_at":"2018-08-07T14:39:00Z","merged_at":"2018-08-07T14:39:00Z","merge_commit_sha":"0c2db85c926cea638394a20928373b87983b0356","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":411508269,"node_id":"MDU6TGFiZWw0MTE1MDgyNjk=","url":"https://api.github.com/repos/auth0/docs/labels/in-review","name":"in-review","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/auth0/docs/pulls/5860/commits","review_comments_url":"https://api.github.com/repos/auth0/docs/pulls/5860/comments","review_comment_url":"https://api.github.com/repos/auth0/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/auth0/docs/issues/5860/comments","statuses_url":"https://api.github.com/repos/auth0/docs/statuses/d7c3209ca63550faa368c129c499d48facaa7e31","head":{"label":"neshanjo:patch-1","ref":"patch-1","sha":"d7c3209ca63550faa368c129c499d48facaa7e31","user":{"login":"neshanjo","id":22233722,"node_id":"MDQ6VXNlcjIyMjMzNzIy","avatar_url":"https://avatars0.githubusercontent.com/u/22233722?v=4","gravatar_id":"","url":"https://api.github.com/users/neshanjo","html_url":"https://github.com/neshanjo","followers_url":"https://api.github.com/users/neshanjo/followers","following_url":"https://api.github.com/users/neshanjo/following{/other_user}","gists_url":"https://api.github.com/users/neshanjo/gists{/gist_id}","starred_url":"https://api.github.com/users/neshanjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neshanjo/subscriptions","organizations_url":"https://api.github.com/users/neshanjo/orgs","repos_url":"https://api.github.com/users/neshanjo/repos","events_url":"https://api.github.com/users/neshanjo/events{/privacy}","received_events_url":"https://api.github.com/users/neshanjo/received_events","type":"User","site_admin":false},"repo":{"id":124354299,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzNTQyOTk=","name":"docs","full_name":"neshanjo/docs","owner":{"login":"neshanjo","id":22233722,"node_id":"MDQ6VXNlcjIyMjMzNzIy","avatar_url":"https://avatars0.githubusercontent.com/u/22233722?v=4","gravatar_id":"","url":"https://api.github.com/users/neshanjo","html_url":"https://github.com/neshanjo","followers_url":"https://api.github.com/users/neshanjo/followers","following_url":"https://api.github.com/users/neshanjo/following{/other_user}","gists_url":"https://api.github.com/users/neshanjo/gists{/gist_id}","starred_url":"https://api.github.com/users/neshanjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neshanjo/subscriptions","organizations_url":"https://api.github.com/users/neshanjo/orgs","repos_url":"https://api.github.com/users/neshanjo/repos","events_url":"https://api.github.com/users/neshanjo/events{/privacy}","received_events_url":"https://api.github.com/users/neshanjo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neshanjo/docs","description":"Auth0 documentation","fork":true,"url":"https://api.github.com/repos/neshanjo/docs","forks_url":"https://api.github.com/repos/neshanjo/docs/forks","keys_url":"https://api.github.com/repos/neshanjo/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neshanjo/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neshanjo/docs/teams","hooks_url":"https://api.github.com/repos/neshanjo/docs/hooks","issue_events_url":"https://api.github.com/repos/neshanjo/docs/issues/events{/number}","events_url":"https://api.github.com/repos/neshanjo/docs/events","assignees_url":"https://api.github.com/repos/neshanjo/docs/assignees{/user}","branches_url":"https://api.github.com/repos/neshanjo/docs/branches{/branch}","tags_url":"https://api.github.com/repos/neshanjo/docs/tags","blobs_url":"https://api.github.com/repos/neshanjo/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neshanjo/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neshanjo/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/neshanjo/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neshanjo/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/neshanjo/docs/languages","stargazers_url":"https://api.github.com/repos/neshanjo/docs/stargazers","contributors_url":"https://api.github.com/repos/neshanjo/docs/contributors","subscribers_url":"https://api.github.com/repos/neshanjo/docs/subscribers","subscription_url":"https://api.github.com/repos/neshanjo/docs/subscription","commits_url":"https://api.github.com/repos/neshanjo/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/neshanjo/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/neshanjo/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/neshanjo/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/neshanjo/docs/contents/{+path}","compare_url":"https://api.github.com/repos/neshanjo/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neshanjo/docs/merges","archive_url":"https://api.github.com/repos/neshanjo/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neshanjo/docs/downloads","issues_url":"https://api.github.com/repos/neshanjo/docs/issues{/number}","pulls_url":"https://api.github.com/repos/neshanjo/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/neshanjo/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/neshanjo/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neshanjo/docs/labels{/name}","releases_url":"https://api.github.com/repos/neshanjo/docs/releases{/id}","deployments_url":"https://api.github.com/repos/neshanjo/docs/deployments","created_at":"2018-03-08T07:32:24Z","updated_at":"2018-03-08T07:32:33Z","pushed_at":"2018-03-08T07:39:15Z","git_url":"git://github.com/neshanjo/docs.git","ssh_url":"git@github.com:neshanjo/docs.git","clone_url":"https://github.com/neshanjo/docs.git","svn_url":"https://github.com/neshanjo/docs","homepage":null,"size":436998,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"auth0:master","ref":"master","sha":"24e105cc82907dd8981d9f24cac2792879de6c89","user":{"login":"auth0","id":2824157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQxNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2824157?v=4","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"repo":{"id":33872272,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg3MjI3Mg==","name":"docs","full_name":"auth0/docs","owner":{"login":"auth0","id":2824157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQxNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2824157?v=4","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auth0/docs","description":"Auth0 documentation","fork":false,"url":"https://api.github.com/repos/auth0/docs","forks_url":"https://api.github.com/repos/auth0/docs/forks","keys_url":"https://api.github.com/repos/auth0/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auth0/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auth0/docs/teams","hooks_url":"https://api.github.com/repos/auth0/docs/hooks","issue_events_url":"https://api.github.com/repos/auth0/docs/issues/events{/number}","events_url":"https://api.github.com/repos/auth0/docs/events","assignees_url":"https://api.github.com/repos/auth0/docs/assignees{/user}","branches_url":"https://api.github.com/repos/auth0/docs/branches{/branch}","tags_url":"https://api.github.com/repos/auth0/docs/tags","blobs_url":"https://api.github.com/repos/auth0/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auth0/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auth0/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/auth0/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auth0/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/auth0/docs/languages","stargazers_url":"https://api.github.com/repos/auth0/docs/stargazers","contributors_url":"https://api.github.com/repos/auth0/docs/contributors","subscribers_url":"https://api.github.com/repos/auth0/docs/subscribers","subscription_url":"https://api.github.com/repos/auth0/docs/subscription","commits_url":"https://api.github.com/repos/auth0/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/auth0/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/auth0/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/auth0/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/auth0/docs/contents/{+path}","compare_url":"https://api.github.com/repos/auth0/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auth0/docs/merges","archive_url":"https://api.github.com/repos/auth0/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auth0/docs/downloads","issues_url":"https://api.github.com/repos/auth0/docs/issues{/number}","pulls_url":"https://api.github.com/repos/auth0/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/auth0/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/auth0/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auth0/docs/labels{/name}","releases_url":"https://api.github.com/repos/auth0/docs/releases{/id}","deployments_url":"https://api.github.com/repos/auth0/docs/deployments","created_at":"2015-04-13T14:09:26Z","updated_at":"2018-08-07T10:37:15Z","pushed_at":"2018-08-07T14:39:00Z","git_url":"git://github.com/auth0/docs.git","ssh_url":"git@github.com:auth0/docs.git","clone_url":"https://github.com/auth0/docs.git","svn_url":"https://github.com/auth0/docs","homepage":null,"size":444138,"stargazers_count":128,"watchers_count":128,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":857,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":857,"open_issues":173,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/auth0/docs/pulls/5860"},"html":{"href":"https://github.com/auth0/docs/pull/5860"},"issue":{"href":"https://api.github.com/repos/auth0/docs/issues/5860"},"comments":{"href":"https://api.github.com/repos/auth0/docs/issues/5860/comments"},"review_comments":{"href":"https://api.github.com/repos/auth0/docs/pulls/5860/comments"},"review_comment":{"href":"https://api.github.com/repos/auth0/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/auth0/docs/pulls/5860/commits"},"statuses":{"href":"https://api.github.com/repos/auth0/docs/statuses/d7c3209ca63550faa368c129c499d48facaa7e31"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mpaktiti","id":11715799,"node_id":"MDQ6VXNlcjExNzE1Nzk5","avatar_url":"https://avatars2.githubusercontent.com/u/11715799?v=4","gravatar_id":"","url":"https://api.github.com/users/mpaktiti","html_url":"https://github.com/mpaktiti","followers_url":"https://api.github.com/users/mpaktiti/followers","following_url":"https://api.github.com/users/mpaktiti/following{/other_user}","gists_url":"https://api.github.com/users/mpaktiti/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaktiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaktiti/subscriptions","organizations_url":"https://api.github.com/users/mpaktiti/orgs","repos_url":"https://api.github.com/users/mpaktiti/repos","events_url":"https://api.github.com/users/mpaktiti/events{/privacy}","received_events_url":"https://api.github.com/users/mpaktiti/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"mpaktiti"}}