{"action":"created","issue":{"url":"https://api.github.com/repos/ElemeFE/element/issues/12415","repository_url":"https://api.github.com/repos/ElemeFE/element","labels_url":"https://api.github.com/repos/ElemeFE/element/issues/12415/labels{/name}","comments_url":"https://api.github.com/repos/ElemeFE/element/issues/12415/comments","events_url":"https://api.github.com/repos/ElemeFE/element/issues/12415/events","html_url":"https://github.com/ElemeFE/element/pull/12415","id":351821906,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzEyOTI3","number":12415,"title":"Dynamic scroll position of time-spinner items","user":{"login":"rang-ali","id":22007719,"node_id":"MDQ6VXNlcjIyMDA3NzE5","avatar_url":"https://avatars1.githubusercontent.com/u/22007719?v=4","gravatar_id":"","url":"https://api.github.com/users/rang-ali","html_url":"https://github.com/rang-ali","followers_url":"https://api.github.com/users/rang-ali/followers","following_url":"https://api.github.com/users/rang-ali/following{/other_user}","gists_url":"https://api.github.com/users/rang-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/rang-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rang-ali/subscriptions","organizations_url":"https://api.github.com/users/rang-ali/orgs","repos_url":"https://api.github.com/users/rang-ali/repos","events_url":"https://api.github.com/users/rang-ali/events{/privacy}","received_events_url":"https://api.github.com/users/rang-ali/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-18T13:49:19Z","updated_at":"2018-08-19T09:03:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ElemeFE/element/pulls/12415","html_url":"https://github.com/ElemeFE/element/pull/12415","diff_url":"https://github.com/ElemeFE/element/pull/12415.diff","patch_url":"https://github.com/ElemeFE/element/pull/12415.patch"},"body":"Makes it possible to style the height of \".el-time-spinner__item\". \r\nRemoved the fixed values associated to a height and line-height: 32px. It's now possible to set whichever height a user wants and the scrollbar will adjust itself accordingly.\r\n\r\nPlease make sure these boxes are checked before submitting your PR, thank you!\r\n\r\n* [X] Make sure you follow Element's contributing guide ([中文](https://github.com/ElemeFE/element/blob/master/.github/CONTRIBUTING.zh-CN.md) | [English](https://github.com/ElemeFE/element/blob/master/.github/CONTRIBUTING.en-US.md) | [Español](https://github.com/ElemeFE/element/blob/master/.github/CONTRIBUTING.es.md)).\r\n* [X] Make sure you are merging your commits to `dev` branch.\r\n* [X] Add some descriptions and refer relative issues for you PR.\r\n"},"comment":{"url":"https://api.github.com/repos/ElemeFE/element/issues/comments/414114057","html_url":"https://github.com/ElemeFE/element/pull/12415#issuecomment-414114057","issue_url":"https://api.github.com/repos/ElemeFE/element/issues/12415","id":414114057,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDExNDA1Nw==","user":{"login":"rang-ali","id":22007719,"node_id":"MDQ6VXNlcjIyMDA3NzE5","avatar_url":"https://avatars1.githubusercontent.com/u/22007719?v=4","gravatar_id":"","url":"https://api.github.com/users/rang-ali","html_url":"https://github.com/rang-ali","followers_url":"https://api.github.com/users/rang-ali/followers","following_url":"https://api.github.com/users/rang-ali/following{/other_user}","gists_url":"https://api.github.com/users/rang-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/rang-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rang-ali/subscriptions","organizations_url":"https://api.github.com/users/rang-ali/orgs","repos_url":"https://api.github.com/users/rang-ali/repos","events_url":"https://api.github.com/users/rang-ali/events{/privacy}","received_events_url":"https://api.github.com/users/rang-ali/received_events","type":"User","site_admin":false},"created_at":"2018-08-19T09:03:10Z","updated_at":"2018-08-19T09:03:10Z","author_association":"NONE","body":"Right now the code that controls the scrollbar is hard coded to 32px, making it hard to change the height and styling of the time spinner items.\r\n\r\nFor example, with styling  \r\n`.el-time-spinner__item {\r\n    height: 40px;\r\n    line-height: 40px;\r\n    font-size: 16px;\r\n}`\r\n\r\n**Before the fix** (look at the scrollbar): \r\n![before-fix](https://user-images.githubusercontent.com/22007719/44307240-3179e600-a39f-11e8-92f4-aa3f8a644225.gif)\r\n\r\n**After the fix**:\r\n![after-fix](https://user-images.githubusercontent.com/22007719/44307242-3f2f6b80-a39f-11e8-983b-6a1ed3153385.gif)\r\n"}}
{"actor":{"display_login":"rang-ali"}}