{"action":"created","issue":{"url":"https://api.github.com/repos/jaegertracing/spark-dependencies/issues/50","repository_url":"https://api.github.com/repos/jaegertracing/spark-dependencies","labels_url":"https://api.github.com/repos/jaegertracing/spark-dependencies/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/jaegertracing/spark-dependencies/issues/50/comments","events_url":"https://api.github.com/repos/jaegertracing/spark-dependencies/issues/50/events","html_url":"https://github.com/jaegertracing/spark-dependencies/issues/50","id":393065677,"node_id":"MDU6SXNzdWUzOTMwNjU2Nzc=","number":50,"title":"Add the possibility to suffix the service name with a tag","user":{"login":"Etienne-Carriere","id":2909360,"node_id":"MDQ6VXNlcjI5MDkzNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2909360?v=4","gravatar_id":"","url":"https://api.github.com/users/Etienne-Carriere","html_url":"https://github.com/Etienne-Carriere","followers_url":"https://api.github.com/users/Etienne-Carriere/followers","following_url":"https://api.github.com/users/Etienne-Carriere/following{/other_user}","gists_url":"https://api.github.com/users/Etienne-Carriere/gists{/gist_id}","starred_url":"https://api.github.com/users/Etienne-Carriere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Etienne-Carriere/subscriptions","organizations_url":"https://api.github.com/users/Etienne-Carriere/orgs","repos_url":"https://api.github.com/users/Etienne-Carriere/repos","events_url":"https://api.github.com/users/Etienne-Carriere/events{/privacy}","received_events_url":"https://api.github.com/users/Etienne-Carriere/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-20T14:18:19Z","updated_at":"2018-12-21T14:02:52Z","closed_at":null,"author_association":"NONE","body":"## Requirement - what kind of business use case are you trying to solve?\r\n\r\nIn order to handle same service but on different environment (staging/live), we would like to have differents nodes in the dependency graph : it will help us to see which services are shared among environments and which are specific\r\n\r\n## Problem - what in Jaeger blocks you from solving the requirement?\r\n\r\nOne solution could be to have environment name in the service name but it will be not pratical to compare 2 traces : when the service name are different, the spans in the trace are considered to be completely differents. \r\nSo my solution is to add a tag describing the environment \r\n\r\n## Proposal - what do you suggest to solve the problem or improve the existing situation?\r\n\r\nI propose to add an environment variable (ex: DEPENDENCY_TAG_SUFF= tag_key) . \r\nWhen this variable is absent, current behavior\r\nWhen this variable is filled : For each span which has the tag (whose key is tag_key), the service name will be suffixed with the value of the tag whose key is tag_key"},"comment":{"url":"https://api.github.com/repos/jaegertracing/spark-dependencies/issues/comments/449396425","html_url":"https://github.com/jaegertracing/spark-dependencies/issues/50#issuecomment-449396425","issue_url":"https://api.github.com/repos/jaegertracing/spark-dependencies/issues/50","id":449396425,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTM5NjQyNQ==","user":{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T14:02:52Z","updated_at":"2018-12-21T14:02:52Z","author_association":"MEMBER","body":"It looks reasonable, maybe there could be a standard tag describing the environment. \r\n\r\nAt the moment you can control this by manually overring the service name during the deployment. e.g add suffix to env prop `JAEGER_SERVICE_NAME`"}}
{"actor":{"display_login":"pavolloffay"}}