{"action":"created","issue":{"url":"https://api.github.com/repos/pmodels/mpich/issues/2918","repository_url":"https://api.github.com/repos/pmodels/mpich","labels_url":"https://api.github.com/repos/pmodels/mpich/issues/2918/labels{/name}","comments_url":"https://api.github.com/repos/pmodels/mpich/issues/2918/comments","events_url":"https://api.github.com/repos/pmodels/mpich/issues/2918/events","html_url":"https://github.com/pmodels/mpich/pull/2918","id":287279194,"number":2918,"title":"ROMIO: check filetype and etype error","user":{"login":"wkliao","id":1634098,"avatar_url":"https://avatars2.githubusercontent.com/u/1634098?v=4","gravatar_id":"","url":"https://api.github.com/users/wkliao","html_url":"https://github.com/wkliao","followers_url":"https://api.github.com/users/wkliao/followers","following_url":"https://api.github.com/users/wkliao/following{/other_user}","gists_url":"https://api.github.com/users/wkliao/gists{/gist_id}","starred_url":"https://api.github.com/users/wkliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkliao/subscriptions","organizations_url":"https://api.github.com/users/wkliao/orgs","repos_url":"https://api.github.com/users/wkliao/repos","events_url":"https://api.github.com/users/wkliao/events{/privacy}","received_events_url":"https://api.github.com/users/wkliao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pmodels/mpich/milestones/32","html_url":"https://github.com/pmodels/mpich/milestone/32","labels_url":"https://api.github.com/repos/pmodels/mpich/milestones/32/labels","id":3087446,"number":32,"title":"mpich-3.3b2","description":"Blockers:\r\n\r\nMDTA:\r\n  - https://github.com/pmodels/mpich/pull/2951 (prereq)\r\n  - https://github.com/pmodels/mpich/pull/2957 (prereq)\r\n  - Primary PR is missing\r\n\r\nPMIx:\r\n  - https://github.com/pmodels/mpich/pull/2807\r\n\r\nComm_split_type on-node:\r\n  - https://github.com/pmodels/mpich/pull/2959\r\n  - Primary PR is missing\r\n\r\nNoncatastrophic errors:\r\n  - https://github.com/pmodels/mpich/pull/2911\r\n  - More PRs to come\r\n\r\nDTpools:\r\n  - https://github.com/pmodels/mpich/pull/2954\r\n\r\nHCOLL integration:\r\n  - Primary PR is missing","creator":{"login":"pavanbalaji","id":4279602,"avatar_url":"https://avatars0.githubusercontent.com/u/4279602?v=4","gravatar_id":"","url":"https://api.github.com/users/pavanbalaji","html_url":"https://github.com/pavanbalaji","followers_url":"https://api.github.com/users/pavanbalaji/followers","following_url":"https://api.github.com/users/pavanbalaji/following{/other_user}","gists_url":"https://api.github.com/users/pavanbalaji/gists{/gist_id}","starred_url":"https://api.github.com/users/pavanbalaji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavanbalaji/subscriptions","organizations_url":"https://api.github.com/users/pavanbalaji/orgs","repos_url":"https://api.github.com/users/pavanbalaji/repos","events_url":"https://api.github.com/users/pavanbalaji/events{/privacy}","received_events_url":"https://api.github.com/users/pavanbalaji/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":21,"state":"open","created_at":"2018-02-04T18:10:19Z","updated_at":"2018-02-09T19:53:52Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-01-10T00:44:08Z","updated_at":"2018-02-09T20:09:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pmodels/mpich/pulls/2918","html_url":"https://github.com/pmodels/mpich/pull/2918","diff_url":"https://github.com/pmodels/mpich/pull/2918.diff","patch_url":"https://github.com/pmodels/mpich/pull/2918.patch"},"body":"This PR adds the following checks:\r\n1. File displacements of filetype must be non-negative and in a monotonically nondecreasing order.\r\n2. If the file is opened for writing, neither the etype nor the filetype is permitted to contain overlapping regions.\r\nThe above MPI-IO requirement can be found in MPI standard Chapter 13.3."},"comment":{"url":"https://api.github.com/repos/pmodels/mpich/issues/comments/364550219","html_url":"https://github.com/pmodels/mpich/pull/2918#issuecomment-364550219","issue_url":"https://api.github.com/repos/pmodels/mpich/issues/2918","id":364550219,"user":{"login":"pavanbalaji","id":4279602,"avatar_url":"https://avatars0.githubusercontent.com/u/4279602?v=4","gravatar_id":"","url":"https://api.github.com/users/pavanbalaji","html_url":"https://github.com/pavanbalaji","followers_url":"https://api.github.com/users/pavanbalaji/followers","following_url":"https://api.github.com/users/pavanbalaji/following{/other_user}","gists_url":"https://api.github.com/users/pavanbalaji/gists{/gist_id}","starred_url":"https://api.github.com/users/pavanbalaji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavanbalaji/subscriptions","organizations_url":"https://api.github.com/users/pavanbalaji/orgs","repos_url":"https://api.github.com/users/pavanbalaji/repos","events_url":"https://api.github.com/users/pavanbalaji/events{/privacy}","received_events_url":"https://api.github.com/users/pavanbalaji/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T20:09:25Z","updated_at":"2018-02-09T20:09:25Z","author_association":"CONTRIBUTOR","body":"I'll let @roblatham00 review this, but a minor comment.  I usually don't like these sort of macros:\r\n\r\n```\r\n    err = MPI_Type_free(&filetype);\r\n    ERR;\r\n```\r\n\r\nHere `ERR` is assuming that there will exist a variable called `err`.  Something like this will be better:\r\n\r\n```\r\n    err = MPI_Type_free(&filetype);\r\n    CHECK_ERROR(err);\r\n```\r\n\r\nI realize that we have this problem in some places in `mpich` too, but I'd rather not add more of them into the code."}}
{"actor":{"display_login":"pavanbalaji"}}