{"action":"created","comment":{"url":"https://api.github.com/repos/AlexAltea/orbital/pulls/comments/240825030","pull_request_review_id":183945946,"id":240825030,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDgyNTAzMA==","diff_hunk":"@@ -30,19 +24,12 @@ function build_grub() {\n }\n \n function build_qemu() {\n-  # Dependencies\n-  if [ -x \"$(command -v apt)\" ]; then\n-    sudo apt -qq install git \\\n-                         zlib1g-dev \\\n-                         libglib2.0-dev libfdt-dev libpixman-1-dev \\\n-                         libsdl2-dev libvulkan-dev\n-  fi\n   # Building\n   cd ${path_orbital}\n   cd ${path_qemu}\n   ./configure --target-list=ps4-softmmu \\\n     --enable-sdl --enable-vulkan --enable-debug --disable-capstone \\\n-    --enable-hax\n+    --enable-hax --disable-stack-protector","path":"build.sh","position":30,"original_position":30,"commit_id":"f4e956e04c5614d5061498a66f2533b8b0a36916","original_commit_id":"f4e956e04c5614d5061498a66f2533b8b0a36916","user":{"login":"AlexAltea","id":5306886,"node_id":"MDQ6VXNlcjUzMDY4ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/5306886?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexAltea","html_url":"https://github.com/AlexAltea","followers_url":"https://api.github.com/users/AlexAltea/followers","following_url":"https://api.github.com/users/AlexAltea/following{/other_user}","gists_url":"https://api.github.com/users/AlexAltea/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexAltea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexAltea/subscriptions","organizations_url":"https://api.github.com/users/AlexAltea/orgs","repos_url":"https://api.github.com/users/AlexAltea/repos","events_url":"https://api.github.com/users/AlexAltea/events{/privacy}","received_events_url":"https://api.github.com/users/AlexAltea/received_events","type":"User","site_admin":false},"body":"Sorry, but this is not a viable solution. We need to understand why this happens and if it's required under certain circumstances we should add this conditionally.","created_at":"2018-12-11T23:01:52Z","updated_at":"2018-12-11T23:01:52Z","html_url":"https://github.com/AlexAltea/orbital/pull/24#discussion_r240825030","pull_request_url":"https://api.github.com/repos/AlexAltea/orbital/pulls/24","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/AlexAltea/orbital/pulls/comments/240825030"},"html":{"href":"https://github.com/AlexAltea/orbital/pull/24#discussion_r240825030"},"pull_request":{"href":"https://api.github.com/repos/AlexAltea/orbital/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/AlexAltea/orbital/pulls/24","id":237856582,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODU2NTgy","html_url":"https://github.com/AlexAltea/orbital/pull/24","diff_url":"https://github.com/AlexAltea/orbital/pull/24.diff","patch_url":"https://github.com/AlexAltea/orbital/pull/24.patch","issue_url":"https://api.github.com/repos/AlexAltea/orbital/issues/24","number":24,"state":"open","locked":false,"title":"Update build.sh to include fixes for MSYS","user":{"login":"MasonLeeBack","id":12467547,"node_id":"MDQ6VXNlcjEyNDY3NTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12467547?v=4","gravatar_id":"","url":"https://api.github.com/users/MasonLeeBack","html_url":"https://github.com/MasonLeeBack","followers_url":"https://api.github.com/users/MasonLeeBack/followers","following_url":"https://api.github.com/users/MasonLeeBack/following{/other_user}","gists_url":"https://api.github.com/users/MasonLeeBack/gists{/gist_id}","starred_url":"https://api.github.com/users/MasonLeeBack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasonLeeBack/subscriptions","organizations_url":"https://api.github.com/users/MasonLeeBack/orgs","repos_url":"https://api.github.com/users/MasonLeeBack/repos","events_url":"https://api.github.com/users/MasonLeeBack/events{/privacy}","received_events_url":"https://api.github.com/users/MasonLeeBack/received_events","type":"User","site_admin":false},"body":"This change also gets rid of apt dependencies, because some clients may use different package managers. Implement a dependency check later to make it less platform specific.","created_at":"2018-12-11T22:58:39Z","updated_at":"2018-12-11T23:01:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70932316a036aca53450aee595acac5a3b8ef513","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AlexAltea/orbital/pulls/24/commits","review_comments_url":"https://api.github.com/repos/AlexAltea/orbital/pulls/24/comments","review_comment_url":"https://api.github.com/repos/AlexAltea/orbital/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AlexAltea/orbital/issues/24/comments","statuses_url":"https://api.github.com/repos/AlexAltea/orbital/statuses/f4e956e04c5614d5061498a66f2533b8b0a36916","head":{"label":"MasonLeeBack:patch-1","ref":"patch-1","sha":"f4e956e04c5614d5061498a66f2533b8b0a36916","user":{"login":"MasonLeeBack","id":12467547,"node_id":"MDQ6VXNlcjEyNDY3NTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12467547?v=4","gravatar_id":"","url":"https://api.github.com/users/MasonLeeBack","html_url":"https://github.com/MasonLeeBack","followers_url":"https://api.github.com/users/MasonLeeBack/followers","following_url":"https://api.github.com/users/MasonLeeBack/following{/other_user}","gists_url":"https://api.github.com/users/MasonLeeBack/gists{/gist_id}","starred_url":"https://api.github.com/users/MasonLeeBack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasonLeeBack/subscriptions","organizations_url":"https://api.github.com/users/MasonLeeBack/orgs","repos_url":"https://api.github.com/users/MasonLeeBack/repos","events_url":"https://api.github.com/users/MasonLeeBack/events{/privacy}","received_events_url":"https://api.github.com/users/MasonLeeBack/received_events","type":"User","site_admin":false},"repo":{"id":136871263,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY4NzEyNjM=","name":"orbital","full_name":"MasonLeeBack/orbital","private":false,"owner":{"login":"MasonLeeBack","id":12467547,"node_id":"MDQ6VXNlcjEyNDY3NTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12467547?v=4","gravatar_id":"","url":"https://api.github.com/users/MasonLeeBack","html_url":"https://github.com/MasonLeeBack","followers_url":"https://api.github.com/users/MasonLeeBack/followers","following_url":"https://api.github.com/users/MasonLeeBack/following{/other_user}","gists_url":"https://api.github.com/users/MasonLeeBack/gists{/gist_id}","starred_url":"https://api.github.com/users/MasonLeeBack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasonLeeBack/subscriptions","organizations_url":"https://api.github.com/users/MasonLeeBack/orgs","repos_url":"https://api.github.com/users/MasonLeeBack/repos","events_url":"https://api.github.com/users/MasonLeeBack/events{/privacy}","received_events_url":"https://api.github.com/users/MasonLeeBack/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MasonLeeBack/orbital","description":"Experimental PlayStation 4 emulator","fork":true,"url":"https://api.github.com/repos/MasonLeeBack/orbital","forks_url":"https://api.github.com/repos/MasonLeeBack/orbital/forks","keys_url":"https://api.github.com/repos/MasonLeeBack/orbital/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MasonLeeBack/orbital/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MasonLeeBack/orbital/teams","hooks_url":"https://api.github.com/repos/MasonLeeBack/orbital/hooks","issue_events_url":"https://api.github.com/repos/MasonLeeBack/orbital/issues/events{/number}","events_url":"https://api.github.com/repos/MasonLeeBack/orbital/events","assignees_url":"https://api.github.com/repos/MasonLeeBack/orbital/assignees{/user}","branches_url":"https://api.github.com/repos/MasonLeeBack/orbital/branches{/branch}","tags_url":"https://api.github.com/repos/MasonLeeBack/orbital/tags","blobs_url":"https://api.github.com/repos/MasonLeeBack/orbital/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MasonLeeBack/orbital/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MasonLeeBack/orbital/git/refs{/sha}","trees_url":"https://api.github.com/repos/MasonLeeBack/orbital/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MasonLeeBack/orbital/statuses/{sha}","languages_url":"https://api.github.com/repos/MasonLeeBack/orbital/languages","stargazers_url":"https://api.github.com/repos/MasonLeeBack/orbital/stargazers","contributors_url":"https://api.github.com/repos/MasonLeeBack/orbital/contributors","subscribers_url":"https://api.github.com/repos/MasonLeeBack/orbital/subscribers","subscription_url":"https://api.github.com/repos/MasonLeeBack/orbital/subscription","commits_url":"https://api.github.com/repos/MasonLeeBack/orbital/commits{/sha}","git_commits_url":"https://api.github.com/repos/MasonLeeBack/orbital/git/commits{/sha}","comments_url":"https://api.github.com/repos/MasonLeeBack/orbital/comments{/number}","issue_comment_url":"https://api.github.com/repos/MasonLeeBack/orbital/issues/comments{/number}","contents_url":"https://api.github.com/repos/MasonLeeBack/orbital/contents/{+path}","compare_url":"https://api.github.com/repos/MasonLeeBack/orbital/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MasonLeeBack/orbital/merges","archive_url":"https://api.github.com/repos/MasonLeeBack/orbital/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MasonLeeBack/orbital/downloads","issues_url":"https://api.github.com/repos/MasonLeeBack/orbital/issues{/number}","pulls_url":"https://api.github.com/repos/MasonLeeBack/orbital/pulls{/number}","milestones_url":"https://api.github.com/repos/MasonLeeBack/orbital/milestones{/number}","notifications_url":"https://api.github.com/repos/MasonLeeBack/orbital/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MasonLeeBack/orbital/labels{/name}","releases_url":"https://api.github.com/repos/MasonLeeBack/orbital/releases{/id}","deployments_url":"https://api.github.com/repos/MasonLeeBack/orbital/deployments","created_at":"2018-06-11T03:44:10Z","updated_at":"2018-06-12T16:18:25Z","pushed_at":"2018-12-11T22:58:26Z","git_url":"git://github.com/MasonLeeBack/orbital.git","ssh_url":"git@github.com:MasonLeeBack/orbital.git","clone_url":"https://github.com/MasonLeeBack/orbital.git","svn_url":"https://github.com/MasonLeeBack/orbital","homepage":"https://phi.nz/orbital/","size":119,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AlexAltea:master","ref":"master","sha":"566466c97b56e29469fd4e3db4ca47833c8026e4","user":{"login":"AlexAltea","id":5306886,"node_id":"MDQ6VXNlcjUzMDY4ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/5306886?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexAltea","html_url":"https://github.com/AlexAltea","followers_url":"https://api.github.com/users/AlexAltea/followers","following_url":"https://api.github.com/users/AlexAltea/following{/other_user}","gists_url":"https://api.github.com/users/AlexAltea/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexAltea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexAltea/subscriptions","organizations_url":"https://api.github.com/users/AlexAltea/orgs","repos_url":"https://api.github.com/users/AlexAltea/repos","events_url":"https://api.github.com/users/AlexAltea/events{/privacy}","received_events_url":"https://api.github.com/users/AlexAltea/received_events","type":"User","site_admin":false},"repo":{"id":108667201,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2NjcyMDE=","name":"orbital","full_name":"AlexAltea/orbital","private":false,"owner":{"login":"AlexAltea","id":5306886,"node_id":"MDQ6VXNlcjUzMDY4ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/5306886?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexAltea","html_url":"https://github.com/AlexAltea","followers_url":"https://api.github.com/users/AlexAltea/followers","following_url":"https://api.github.com/users/AlexAltea/following{/other_user}","gists_url":"https://api.github.com/users/AlexAltea/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexAltea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexAltea/subscriptions","organizations_url":"https://api.github.com/users/AlexAltea/orgs","repos_url":"https://api.github.com/users/AlexAltea/repos","events_url":"https://api.github.com/users/AlexAltea/events{/privacy}","received_events_url":"https://api.github.com/users/AlexAltea/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AlexAltea/orbital","description":"Experimental PlayStation 4 emulator","fork":false,"url":"https://api.github.com/repos/AlexAltea/orbital","forks_url":"https://api.github.com/repos/AlexAltea/orbital/forks","keys_url":"https://api.github.com/repos/AlexAltea/orbital/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexAltea/orbital/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexAltea/orbital/teams","hooks_url":"https://api.github.com/repos/AlexAltea/orbital/hooks","issue_events_url":"https://api.github.com/repos/AlexAltea/orbital/issues/events{/number}","events_url":"https://api.github.com/repos/AlexAltea/orbital/events","assignees_url":"https://api.github.com/repos/AlexAltea/orbital/assignees{/user}","branches_url":"https://api.github.com/repos/AlexAltea/orbital/branches{/branch}","tags_url":"https://api.github.com/repos/AlexAltea/orbital/tags","blobs_url":"https://api.github.com/repos/AlexAltea/orbital/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexAltea/orbital/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexAltea/orbital/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexAltea/orbital/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexAltea/orbital/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexAltea/orbital/languages","stargazers_url":"https://api.github.com/repos/AlexAltea/orbital/stargazers","contributors_url":"https://api.github.com/repos/AlexAltea/orbital/contributors","subscribers_url":"https://api.github.com/repos/AlexAltea/orbital/subscribers","subscription_url":"https://api.github.com/repos/AlexAltea/orbital/subscription","commits_url":"https://api.github.com/repos/AlexAltea/orbital/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexAltea/orbital/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexAltea/orbital/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexAltea/orbital/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexAltea/orbital/contents/{+path}","compare_url":"https://api.github.com/repos/AlexAltea/orbital/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexAltea/orbital/merges","archive_url":"https://api.github.com/repos/AlexAltea/orbital/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexAltea/orbital/downloads","issues_url":"https://api.github.com/repos/AlexAltea/orbital/issues{/number}","pulls_url":"https://api.github.com/repos/AlexAltea/orbital/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexAltea/orbital/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexAltea/orbital/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexAltea/orbital/labels{/name}","releases_url":"https://api.github.com/repos/AlexAltea/orbital/releases{/id}","deployments_url":"https://api.github.com/repos/AlexAltea/orbital/deployments","created_at":"2017-10-28T16:55:52Z","updated_at":"2018-12-11T17:09:32Z","pushed_at":"2018-12-11T22:58:40Z","git_url":"git://github.com/AlexAltea/orbital.git","ssh_url":"git@github.com:AlexAltea/orbital.git","clone_url":"https://github.com/AlexAltea/orbital.git","svn_url":"https://github.com/AlexAltea/orbital","homepage":"https://phi.nz/orbital/","size":143,"stargazers_count":828,"watchers_count":828,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":63,"open_issues":7,"watchers":828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AlexAltea/orbital/pulls/24"},"html":{"href":"https://github.com/AlexAltea/orbital/pull/24"},"issue":{"href":"https://api.github.com/repos/AlexAltea/orbital/issues/24"},"comments":{"href":"https://api.github.com/repos/AlexAltea/orbital/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/AlexAltea/orbital/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/AlexAltea/orbital/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AlexAltea/orbital/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/AlexAltea/orbital/statuses/f4e956e04c5614d5061498a66f2533b8b0a36916"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlexAltea"}}