{"action":"created","issue":{"url":"https://api.github.com/repos/ucsdlib/damspas/issues/473","repository_url":"https://api.github.com/repos/ucsdlib/damspas","labels_url":"https://api.github.com/repos/ucsdlib/damspas/issues/473/labels{/name}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/issues/473/comments","events_url":"https://api.github.com/repos/ucsdlib/damspas/issues/473/events","html_url":"https://github.com/ucsdlib/damspas/pull/473","id":336370236,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODM5ODYw","number":473,"title":"Fixes #467 - Disable file downloading for localDisplay videos/audios and metadataDisplay objects.","user":{"login":"lsitu","id":2430784,"node_id":"MDQ6VXNlcjI0MzA3ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2430784?v=4","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-27T20:10:51Z","updated_at":"2018-06-27T23:59:10Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ucsdlib/damspas/pulls/473","html_url":"https://github.com/ucsdlib/damspas/pull/473","diff_url":"https://github.com/ucsdlib/damspas/pull/473.diff","patch_url":"https://github.com/ucsdlib/damspas/pull/473.patch"},"body":"Fixes #467\r\n\r\n#### Local Checklist\r\n- [x] Tests written and passing locally?\r\n- [x] Code style checked?\r\n- [ ] QA-ed locally?\r\n- [x] Rebased with `master` branch?\r\n- [ ] Configuration updated (if needed)?\r\n- [ ] Documentation updated (if needed)?\r\n\r\n#### What does this PR do?\r\nDisable file downloading for localDisplay videos/audios and metadataDisplay objects, while allowing campus users to download localDisplay images.\r\n\r\n##### Why are we doing this? Any context of related work?\r\nReferences #466, #467 \r\n\r\n@ucsdlib/developers - please review\r\n"},"comment":{"url":"https://api.github.com/repos/ucsdlib/damspas/issues/comments/400867330","html_url":"https://github.com/ucsdlib/damspas/pull/473#issuecomment-400867330","issue_url":"https://api.github.com/repos/ucsdlib/damspas/issues/473","id":400867330,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDg2NzMzMA==","user":{"login":"lsitu","id":2430784,"node_id":"MDQ6VXNlcjI0MzA3ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2430784?v=4","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T23:59:10Z","updated_at":"2018-06-27T23:59:10Z","author_association":"MEMBER","body":"@mcritchlow Good point! I was thinking about it but it seem like we may need to add the file_id parameter to the can_download? method to support the specs in #466 that need those UCSD IP/metadata collections to be viewable from campus or through VPN (UCSD IP restriction).\r\nIn this case, we may need to disallow the downloading of files like _2.jpg, as well as other _1.* service files. So it seem like we should keep it as a method. What do you think? Do you think if we make a simple check with the filename will be enough, or need to look up and parse the data for all the files o check the file use property, which is not so efficient for a match?"}}
{"actor":{"display_login":"lsitu"}}