{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/comments/219987245","pull_request_review_id":158293114,"id":219987245,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTk4NzI0NQ==","diff_hunk":"@@ -544,33 +614,45 @@ func (b *AirflowBase) Validate() error {\n \terrs := field.ErrorList{}\n \tspec := field.NewPath(\"spec\")\n \n-\terrs = append(errs, b.Spec.MySQL.validate(spec.Child(\"mysql\"))...)\n+\terrs = append(errs, b.Spec.Database.validate(spec.Child(\"database\"))...)\n \terrs = append(errs, b.Spec.UI.validate(spec.Child(\"ui\"))...)\n \terrs = append(errs, b.Spec.Storage.validate(spec.Child(\"storage\"))...)\n-\terrs = append(errs, b.Spec.SQLProxy.validate(spec.Child(\"sqlproxy\"))...)\n \n-\tif b.Spec.MySQL == nil && b.Spec.SQLProxy == nil {\n-\t\terrs = append(errs, field.Required(spec.Child(\"mysql\"), \"Either MySQL or SQLProxy is required\"))\n-\t\terrs = append(errs, field.Required(spec.Child(\"sqlproxy\"), \"Either MySQL or SQLProxy is required\"))\n+\tif b.Spec.Database == nil || (b.Spec.Database != nil && b.Spec.Database.MySQL == nil && b.Spec.Database.Postgres == nil && b.Spec.Database.SQLProxy == nil) {\n+\t\terrs = append(errs, field.Required(spec.Child(\"database\"), \"Either MySQL or Postgres or SQLProxy is required\"))","path":"pkg/apis/airflow/v1alpha1/airflowbase_types.go","position":222,"original_position":222,"commit_id":"6756f04931a385368afce2caf63f99ba6e89add9","original_commit_id":"6756f04931a385368afce2caf63f99ba6e89add9","user":{"login":"hxquangnhat","id":7327897,"node_id":"MDQ6VXNlcjczMjc4OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7327897?v=4","gravatar_id":"","url":"https://api.github.com/users/hxquangnhat","html_url":"https://github.com/hxquangnhat","followers_url":"https://api.github.com/users/hxquangnhat/followers","following_url":"https://api.github.com/users/hxquangnhat/following{/other_user}","gists_url":"https://api.github.com/users/hxquangnhat/gists{/gist_id}","starred_url":"https://api.github.com/users/hxquangnhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hxquangnhat/subscriptions","organizations_url":"https://api.github.com/users/hxquangnhat/orgs","repos_url":"https://api.github.com/users/hxquangnhat/repos","events_url":"https://api.github.com/users/hxquangnhat/events{/privacy}","received_events_url":"https://api.github.com/users/hxquangnhat/received_events","type":"User","site_admin":false},"body":"also the error message?","created_at":"2018-09-24T20:59:52Z","updated_at":"2018-09-24T20:59:52Z","html_url":"https://github.com/GoogleCloudPlatform/airflow-operator/pull/17#discussion_r219987245","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/comments/219987245"},"html":{"href":"https://github.com/GoogleCloudPlatform/airflow-operator/pull/17#discussion_r219987245"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/17"}},"in_reply_to_id":219735831},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/17","id":217409165,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDA5MTY1","html_url":"https://github.com/GoogleCloudPlatform/airflow-operator/pull/17","diff_url":"https://github.com/GoogleCloudPlatform/airflow-operator/pull/17.diff","patch_url":"https://github.com/GoogleCloudPlatform/airflow-operator/pull/17.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/issues/17","number":17,"state":"open","locked":false,"title":"Support Postgres as database for Airflow","user":{"login":"hxquangnhat","id":7327897,"node_id":"MDQ6VXNlcjczMjc4OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7327897?v=4","gravatar_id":"","url":"https://api.github.com/users/hxquangnhat","html_url":"https://github.com/hxquangnhat","followers_url":"https://api.github.com/users/hxquangnhat/followers","following_url":"https://api.github.com/users/hxquangnhat/following{/other_user}","gists_url":"https://api.github.com/users/hxquangnhat/gists{/gist_id}","starred_url":"https://api.github.com/users/hxquangnhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hxquangnhat/subscriptions","organizations_url":"https://api.github.com/users/hxquangnhat/orgs","repos_url":"https://api.github.com/users/hxquangnhat/repos","events_url":"https://api.github.com/users/hxquangnhat/events{/privacy}","received_events_url":"https://api.github.com/users/hxquangnhat/received_events","type":"User","site_admin":false},"body":"This PR contains several changes:\r\n- add `postgres` as new database\r\n- move `mysql`,`sqlproxy`,`postgres` under `database`\r\n- change `e2e` test with supporting new database\r\n- modify current samples by moving `mysql` and `sqlproxy` under `database`\r\n- add samples of postgres\r\n- modify quickstart\r\n\r\nRelated Issue: [Support Postgres](https://github.com/GoogleCloudPlatform/airflow-operator/issues/16)","created_at":"2018-09-21T21:44:36Z","updated_at":"2018-09-24T20:59:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b420908927637ac2e11ff4fae84b5e3796283599","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/17/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/17/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/issues/17/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/statuses/6756f04931a385368afce2caf63f99ba6e89add9","head":{"label":"hxquangnhat:master","ref":"master","sha":"6756f04931a385368afce2caf63f99ba6e89add9","user":{"login":"hxquangnhat","id":7327897,"node_id":"MDQ6VXNlcjczMjc4OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7327897?v=4","gravatar_id":"","url":"https://api.github.com/users/hxquangnhat","html_url":"https://github.com/hxquangnhat","followers_url":"https://api.github.com/users/hxquangnhat/followers","following_url":"https://api.github.com/users/hxquangnhat/following{/other_user}","gists_url":"https://api.github.com/users/hxquangnhat/gists{/gist_id}","starred_url":"https://api.github.com/users/hxquangnhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hxquangnhat/subscriptions","organizations_url":"https://api.github.com/users/hxquangnhat/orgs","repos_url":"https://api.github.com/users/hxquangnhat/repos","events_url":"https://api.github.com/users/hxquangnhat/events{/privacy}","received_events_url":"https://api.github.com/users/hxquangnhat/received_events","type":"User","site_admin":false},"repo":{"id":149029848,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwMjk4NDg=","name":"airflow-operator","full_name":"hxquangnhat/airflow-operator","private":false,"owner":{"login":"hxquangnhat","id":7327897,"node_id":"MDQ6VXNlcjczMjc4OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7327897?v=4","gravatar_id":"","url":"https://api.github.com/users/hxquangnhat","html_url":"https://github.com/hxquangnhat","followers_url":"https://api.github.com/users/hxquangnhat/followers","following_url":"https://api.github.com/users/hxquangnhat/following{/other_user}","gists_url":"https://api.github.com/users/hxquangnhat/gists{/gist_id}","starred_url":"https://api.github.com/users/hxquangnhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hxquangnhat/subscriptions","organizations_url":"https://api.github.com/users/hxquangnhat/orgs","repos_url":"https://api.github.com/users/hxquangnhat/repos","events_url":"https://api.github.com/users/hxquangnhat/events{/privacy}","received_events_url":"https://api.github.com/users/hxquangnhat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hxquangnhat/airflow-operator","description":"Kubernetes custom controller and CRDs to managing Airflow","fork":true,"url":"https://api.github.com/repos/hxquangnhat/airflow-operator","forks_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/forks","keys_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/teams","hooks_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/hooks","issue_events_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/issues/events{/number}","events_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/events","assignees_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/assignees{/user}","branches_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/branches{/branch}","tags_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/tags","blobs_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/languages","stargazers_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/stargazers","contributors_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/contributors","subscribers_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/subscribers","subscription_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/subscription","commits_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/contents/{+path}","compare_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/merges","archive_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/downloads","issues_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/issues{/number}","pulls_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/labels{/name}","releases_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/releases{/id}","deployments_url":"https://api.github.com/repos/hxquangnhat/airflow-operator/deployments","created_at":"2018-09-16T19:44:21Z","updated_at":"2018-09-21T21:44:12Z","pushed_at":"2018-09-21T21:44:11Z","git_url":"git://github.com/hxquangnhat/airflow-operator.git","ssh_url":"git@github.com:hxquangnhat/airflow-operator.git","clone_url":"https://github.com/hxquangnhat/airflow-operator.git","svn_url":"https://github.com/hxquangnhat/airflow-operator","homepage":"","size":27393,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"0f55343f31d7dc21a0200a51ba47b52c8851b365","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":141745756,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NDU3NTY=","name":"airflow-operator","full_name":"GoogleCloudPlatform/airflow-operator","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/airflow-operator","description":"Kubernetes custom controller and CRDs to managing Airflow","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/deployments","created_at":"2018-07-20T18:35:37Z","updated_at":"2018-09-23T21:05:47Z","pushed_at":"2018-09-21T21:44:37Z","git_url":"git://github.com/GoogleCloudPlatform/airflow-operator.git","ssh_url":"git@github.com:GoogleCloudPlatform/airflow-operator.git","clone_url":"https://github.com/GoogleCloudPlatform/airflow-operator.git","svn_url":"https://github.com/GoogleCloudPlatform/airflow-operator","homepage":"","size":27374,"stargazers_count":57,"watchers_count":57,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":12,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/17"},"html":{"href":"https://github.com/GoogleCloudPlatform/airflow-operator/pull/17"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/issues/17"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/airflow-operator/statuses/6756f04931a385368afce2caf63f99ba6e89add9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hxquangnhat"}}