{"action":"opened","number":13364,"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13364","id":241330158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzMwMTU4","html_url":"https://github.com/civicrm/civicrm-core/pull/13364","diff_url":"https://github.com/civicrm/civicrm-core/pull/13364.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/13364.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13364","number":13364,"state":"open","locked":false,"title":"REF Convert deprecated functions to buildOptions for case","user":{"login":"mattwire","id":2052161,"node_id":"MDQ6VXNlcjIwNTIxNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2052161?v=4","gravatar_id":"","url":"https://api.github.com/users/mattwire","html_url":"https://github.com/mattwire","followers_url":"https://api.github.com/users/mattwire/followers","following_url":"https://api.github.com/users/mattwire/following{/other_user}","gists_url":"https://api.github.com/users/mattwire/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwire/subscriptions","organizations_url":"https://api.github.com/users/mattwire/orgs","repos_url":"https://api.github.com/users/mattwire/repos","events_url":"https://api.github.com/users/mattwire/events{/privacy}","received_events_url":"https://api.github.com/users/mattwire/received_events","type":"User","site_admin":false},"body":"Overview\r\n----------------------------------------\r\nConvert `CRM_Core_PseudoConstant::activityType()` and `CRM_Core_PseudoConstant::activityStatus()` to non deprecated `buildOptions()` function.\r\n\r\nFix a couple of PHP notices.\r\n\r\nBefore\r\n----------------------------------------\r\nDeprecated code, php notices.\r\n\r\nAfter\r\n----------------------------------------\r\nLess deprecated code, less PHP notices\r\n\r\nTechnical Details\r\n----------------------------------------\r\nIn most cases these methods are functionally the same.  In some cases the `buildOptions()` replacement for `activityType()` function also returns campaign activities but this does not matter because the activity type arrays are being used to lookup (via array_search) specific activity types.\r\n\r\nComments\r\n----------------------------------------\r\n","created_at":"2018-12-28T13:05:38Z","updated_at":"2018-12-28T13:05:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13364/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13364/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13364/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/12a0043a4b2e5a9481c270593cbbc215f85dc466","head":{"label":"mattwire:activitytype_pseudoconstant","ref":"activitytype_pseudoconstant","sha":"12a0043a4b2e5a9481c270593cbbc215f85dc466","user":{"login":"mattwire","id":2052161,"node_id":"MDQ6VXNlcjIwNTIxNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2052161?v=4","gravatar_id":"","url":"https://api.github.com/users/mattwire","html_url":"https://github.com/mattwire","followers_url":"https://api.github.com/users/mattwire/followers","following_url":"https://api.github.com/users/mattwire/following{/other_user}","gists_url":"https://api.github.com/users/mattwire/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwire/subscriptions","organizations_url":"https://api.github.com/users/mattwire/orgs","repos_url":"https://api.github.com/users/mattwire/repos","events_url":"https://api.github.com/users/mattwire/events{/privacy}","received_events_url":"https://api.github.com/users/mattwire/received_events","type":"User","site_admin":false},"repo":{"id":80881389,"node_id":"MDEwOlJlcG9zaXRvcnk4MDg4MTM4OQ==","name":"civicrm-core","full_name":"mattwire/civicrm-core","private":false,"owner":{"login":"mattwire","id":2052161,"node_id":"MDQ6VXNlcjIwNTIxNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2052161?v=4","gravatar_id":"","url":"https://api.github.com/users/mattwire","html_url":"https://github.com/mattwire","followers_url":"https://api.github.com/users/mattwire/followers","following_url":"https://api.github.com/users/mattwire/following{/other_user}","gists_url":"https://api.github.com/users/mattwire/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwire/subscriptions","organizations_url":"https://api.github.com/users/mattwire/orgs","repos_url":"https://api.github.com/users/mattwire/repos","events_url":"https://api.github.com/users/mattwire/events{/privacy}","received_events_url":"https://api.github.com/users/mattwire/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mattwire/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/mattwire/civicrm-core","forks_url":"https://api.github.com/repos/mattwire/civicrm-core/forks","keys_url":"https://api.github.com/repos/mattwire/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattwire/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattwire/civicrm-core/teams","hooks_url":"https://api.github.com/repos/mattwire/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/mattwire/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/mattwire/civicrm-core/events","assignees_url":"https://api.github.com/repos/mattwire/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/mattwire/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/mattwire/civicrm-core/tags","blobs_url":"https://api.github.com/repos/mattwire/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattwire/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattwire/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattwire/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattwire/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/mattwire/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/mattwire/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/mattwire/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/mattwire/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/mattwire/civicrm-core/subscription","commits_url":"https://api.github.com/repos/mattwire/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattwire/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattwire/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattwire/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattwire/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/mattwire/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattwire/civicrm-core/merges","archive_url":"https://api.github.com/repos/mattwire/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattwire/civicrm-core/downloads","issues_url":"https://api.github.com/repos/mattwire/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/mattwire/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/mattwire/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/mattwire/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattwire/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/mattwire/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/mattwire/civicrm-core/deployments","created_at":"2017-02-04T00:33:41Z","updated_at":"2018-12-20T13:17:40Z","pushed_at":"2018-12-28T13:01:02Z","git_url":"git://github.com/mattwire/civicrm-core.git","ssh_url":"git@github.com:mattwire/civicrm-core.git","clone_url":"https://github.com/mattwire/civicrm-core.git","svn_url":"https://github.com/mattwire/civicrm-core","homepage":null,"size":168982,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"f0230c6321e32a6f260f4fb8d968ca21833e2e0f","user":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk1NDk5","name":"civicrm-core","full_name":"civicrm/civicrm-core","private":false,"owner":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2018-12-28T10:21:17Z","pushed_at":"2018-12-28T11:42:34Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":173523,"stargazers_count":304,"watchers_count":304,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":659,"mirror_url":null,"archived":false,"open_issues_count":114,"license":null,"forks":659,"open_issues":114,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13364"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/13364"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/13364"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/13364/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13364/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13364/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/12a0043a4b2e5a9481c270593cbbc215f85dc466"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":14,"deletions":19,"changed_files":6}}
{"actor":{"display_login":"mattwire"}}