{"push_id":2573895455,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"869c8671e50a53755259777f6e9b3b0a00fb5ee5","before":"8f721d5478248b1ebccdff93e6639b254c5a1a34","commits":[{"sha":"869c8671e50a53755259777f6e9b3b0a00fb5ee5","author":{"name":"Dennis Adjei-Baah","email":"7965a665163253a12f43312bf69d07012a113a2a@buoyant.io"},"message":"make linkerd and namerd honor shutdown grace period in config (#1951)\n\nLinkerd's admin/shutdown endpoint does not use the shutdownGraceMs value set in the admin config section. This causes Linkerd to shut down before requests are drained from the request queue. In addition, Namerd does not take advantage of the SIGTERM and SIGINT os signal hooks like Linkerd. This means Namerd is unable to wait for the maximum set grace period whenever the Namerd process receives the above-mentioned os signals.\r\n\r\nThis PR sets the Linkerd's defaultShutdownGracePeriod to be the value configured in the admin section, or, a default value of 10.seconds. The PR also adds documentation that describes how to configure the shutdownGraceMs field. Finally, we add SignalHandler functionality to handle SIGTERM and SIGINT graceful shutdown in Namerd.\r\n\r\nTests were conducted manually. I set Linkerd's shutdownGraceMs to 20 seconds, sent a request to be routed by Linkerd (request had a 20-second latency) and, I simultaneously called Linkerd's admin/shutdown webhook. Linkerd terminated gracefully after the configured duration.\r\n\r\nSigned-off-by: Dennis Adjei-Baah <dennis@buoyant.io>","distinct":true,"url":"https://api.github.com/repos/ii/linkerd/commits/869c8671e50a53755259777f6e9b3b0a00fb5ee5"}]}
{"actor":{"display_login":"hh"}}