{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/clarity/pulls/comments/200741184","pull_request_review_id":135121144,"id":200741184,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDc0MTE4NA==","diff_hunk":"@@ -90,6 +90,10 @@\n       }\n     }\n \n+    .stack-block-label {\n+      outline: none;","path":"src/clr-angular/data/stack-view/_stack-view.clarity.scss","position":5,"original_position":5,"commit_id":"d3d8370d96527e29ca97df3db7c816cb34cfe353","original_commit_id":"d3d8370d96527e29ca97df3db7c816cb34cfe353","user":{"login":"adityarb88","id":1426805,"node_id":"MDQ6VXNlcjE0MjY4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1426805?v=4","gravatar_id":"","url":"https://api.github.com/users/adityarb88","html_url":"https://github.com/adityarb88","followers_url":"https://api.github.com/users/adityarb88/followers","following_url":"https://api.github.com/users/adityarb88/following{/other_user}","gists_url":"https://api.github.com/users/adityarb88/gists{/gist_id}","starred_url":"https://api.github.com/users/adityarb88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityarb88/subscriptions","organizations_url":"https://api.github.com/users/adityarb88/orgs","repos_url":"https://api.github.com/users/adityarb88/repos","events_url":"https://api.github.com/users/adityarb88/events{/privacy}","received_events_url":"https://api.github.com/users/adityarb88/received_events","type":"User","site_admin":false},"body":"@shijir: Here the hover and the focus states are the same. We do this in a components like the sidenav, subnav, vertical nav etc too.","created_at":"2018-07-06T18:52:30Z","updated_at":"2018-07-06T18:52:30Z","html_url":"https://github.com/vmware/clarity/pull/2433#discussion_r200741184","pull_request_url":"https://api.github.com/repos/vmware/clarity/pulls/2433","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vmware/clarity/pulls/comments/200741184"},"html":{"href":"https://github.com/vmware/clarity/pull/2433#discussion_r200741184"},"pull_request":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2433"}},"in_reply_to_id":200740120},"pull_request":{"url":"https://api.github.com/repos/vmware/clarity/pulls/2433","id":199799766,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5Nzk5NzY2","html_url":"https://github.com/vmware/clarity/pull/2433","diff_url":"https://github.com/vmware/clarity/pull/2433.diff","patch_url":"https://github.com/vmware/clarity/pull/2433.patch","issue_url":"https://api.github.com/repos/vmware/clarity/issues/2433","number":2433,"state":"open","locked":false,"title":"[NG] StackView Accessibility Bug Fixes","user":{"login":"adityarb88","id":1426805,"node_id":"MDQ6VXNlcjE0MjY4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1426805?v=4","gravatar_id":"","url":"https://api.github.com/users/adityarb88","html_url":"https://github.com/adityarb88","followers_url":"https://api.github.com/users/adityarb88/followers","following_url":"https://api.github.com/users/adityarb88/following{/other_user}","gists_url":"https://api.github.com/users/adityarb88/gists{/gist_id}","starred_url":"https://api.github.com/users/adityarb88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityarb88/subscriptions","organizations_url":"https://api.github.com/users/adityarb88/orgs","repos_url":"https://api.github.com/users/adityarb88/repos","events_url":"https://api.github.com/users/adityarb88/events{/privacy}","received_events_url":"https://api.github.com/users/adityarb88/received_events","type":"User","site_admin":false},"body":"Fixes: #2357, #1946\r\n\r\n**Demo:**\r\n![stackview demo](https://user-images.githubusercontent.com/1426805/42391055-ff5be7d6-811b-11e8-80a2-d54fac4fb0fd.gif)\r\n\r\n\r\n**NOTE:** \r\n1. The static markup cannot be fixed without a breaking change. This PR fixes the accessibility issues in the Angular component. We still have the generated icon in use for the static markup but the angular component uses `clr-icon`.\r\n2. Tested on Chrome, Firefox and Safari. My VM isn't working properly so couldnt test on IE and Edge. 🤞 \r\n3. @youdz: I am pretty sure you wont like the way the tests are structured, but I didn't want to fix that in this PR.\r\n\r\n**Fixes:**\r\n1. Adds a `button` `role` to the `.stack-block-label`\r\n2. Adds a `tabindex` to the `.stack-block-label`\r\n3. Opens the stack block on `enter` and `space`\r\n4. Uses `clr-icon` instead of the generated icon.\r\n\r\nSigned-off-by: Aditya Bhandari <adityab@vmware.com>","created_at":"2018-07-06T16:57:40Z","updated_at":"2018-07-06T18:52:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9570f9cf8a690bce801bb2dd4746adc78fec48bf","assignee":{"login":"adityarb88","id":1426805,"node_id":"MDQ6VXNlcjE0MjY4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1426805?v=4","gravatar_id":"","url":"https://api.github.com/users/adityarb88","html_url":"https://github.com/adityarb88","followers_url":"https://api.github.com/users/adityarb88/followers","following_url":"https://api.github.com/users/adityarb88/following{/other_user}","gists_url":"https://api.github.com/users/adityarb88/gists{/gist_id}","starred_url":"https://api.github.com/users/adityarb88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityarb88/subscriptions","organizations_url":"https://api.github.com/users/adityarb88/orgs","repos_url":"https://api.github.com/users/adityarb88/repos","events_url":"https://api.github.com/users/adityarb88/events{/privacy}","received_events_url":"https://api.github.com/users/adityarb88/received_events","type":"User","site_admin":false},"assignees":[{"login":"adityarb88","id":1426805,"node_id":"MDQ6VXNlcjE0MjY4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1426805?v=4","gravatar_id":"","url":"https://api.github.com/users/adityarb88","html_url":"https://github.com/adityarb88","followers_url":"https://api.github.com/users/adityarb88/followers","following_url":"https://api.github.com/users/adityarb88/following{/other_user}","gists_url":"https://api.github.com/users/adityarb88/gists{/gist_id}","starred_url":"https://api.github.com/users/adityarb88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityarb88/subscriptions","organizations_url":"https://api.github.com/users/adityarb88/orgs","repos_url":"https://api.github.com/users/adityarb88/repos","events_url":"https://api.github.com/users/adityarb88/events{/privacy}","received_events_url":"https://api.github.com/users/adityarb88/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"youdz","id":4647197,"node_id":"MDQ6VXNlcjQ2NDcxOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4647197?v=4","gravatar_id":"","url":"https://api.github.com/users/youdz","html_url":"https://github.com/youdz","followers_url":"https://api.github.com/users/youdz/followers","following_url":"https://api.github.com/users/youdz/following{/other_user}","gists_url":"https://api.github.com/users/youdz/gists{/gist_id}","starred_url":"https://api.github.com/users/youdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youdz/subscriptions","organizations_url":"https://api.github.com/users/youdz/orgs","repos_url":"https://api.github.com/users/youdz/repos","events_url":"https://api.github.com/users/youdz/events{/privacy}","received_events_url":"https://api.github.com/users/youdz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":473349743,"node_id":"MDU6TGFiZWw0NzMzNDk3NDM=","url":"https://api.github.com/repos/vmware/clarity/labels/ClarityNG","name":"ClarityNG","color":"bfdadc","default":false},{"id":825088764,"node_id":"MDU6TGFiZWw4MjUwODg3NjQ=","url":"https://api.github.com/repos/vmware/clarity/labels/In%20Review","name":"In Review","color":"faf270","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/clarity/pulls/2433/commits","review_comments_url":"https://api.github.com/repos/vmware/clarity/pulls/2433/comments","review_comment_url":"https://api.github.com/repos/vmware/clarity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/clarity/issues/2433/comments","statuses_url":"https://api.github.com/repos/vmware/clarity/statuses/d3d8370d96527e29ca97df3db7c816cb34cfe353","head":{"label":"adityarb88:topic/aditya/stack-view","ref":"topic/aditya/stack-view","sha":"d3d8370d96527e29ca97df3db7c816cb34cfe353","user":{"login":"adityarb88","id":1426805,"node_id":"MDQ6VXNlcjE0MjY4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1426805?v=4","gravatar_id":"","url":"https://api.github.com/users/adityarb88","html_url":"https://github.com/adityarb88","followers_url":"https://api.github.com/users/adityarb88/followers","following_url":"https://api.github.com/users/adityarb88/following{/other_user}","gists_url":"https://api.github.com/users/adityarb88/gists{/gist_id}","starred_url":"https://api.github.com/users/adityarb88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityarb88/subscriptions","organizations_url":"https://api.github.com/users/adityarb88/orgs","repos_url":"https://api.github.com/users/adityarb88/repos","events_url":"https://api.github.com/users/adityarb88/events{/privacy}","received_events_url":"https://api.github.com/users/adityarb88/received_events","type":"User","site_admin":false},"repo":{"id":74024509,"node_id":"MDEwOlJlcG9zaXRvcnk3NDAyNDUwOQ==","name":"clarity","full_name":"adityarb88/clarity","owner":{"login":"adityarb88","id":1426805,"node_id":"MDQ6VXNlcjE0MjY4MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1426805?v=4","gravatar_id":"","url":"https://api.github.com/users/adityarb88","html_url":"https://github.com/adityarb88","followers_url":"https://api.github.com/users/adityarb88/followers","following_url":"https://api.github.com/users/adityarb88/following{/other_user}","gists_url":"https://api.github.com/users/adityarb88/gists{/gist_id}","starred_url":"https://api.github.com/users/adityarb88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityarb88/subscriptions","organizations_url":"https://api.github.com/users/adityarb88/orgs","repos_url":"https://api.github.com/users/adityarb88/repos","events_url":"https://api.github.com/users/adityarb88/events{/privacy}","received_events_url":"https://api.github.com/users/adityarb88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adityarb88/clarity","description":"Clarity Design System: UX guidelines, HTML/CSS framework, and Angular 2 components working together to craft exceptional experiences","fork":true,"url":"https://api.github.com/repos/adityarb88/clarity","forks_url":"https://api.github.com/repos/adityarb88/clarity/forks","keys_url":"https://api.github.com/repos/adityarb88/clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adityarb88/clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adityarb88/clarity/teams","hooks_url":"https://api.github.com/repos/adityarb88/clarity/hooks","issue_events_url":"https://api.github.com/repos/adityarb88/clarity/issues/events{/number}","events_url":"https://api.github.com/repos/adityarb88/clarity/events","assignees_url":"https://api.github.com/repos/adityarb88/clarity/assignees{/user}","branches_url":"https://api.github.com/repos/adityarb88/clarity/branches{/branch}","tags_url":"https://api.github.com/repos/adityarb88/clarity/tags","blobs_url":"https://api.github.com/repos/adityarb88/clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adityarb88/clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adityarb88/clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/adityarb88/clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adityarb88/clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/adityarb88/clarity/languages","stargazers_url":"https://api.github.com/repos/adityarb88/clarity/stargazers","contributors_url":"https://api.github.com/repos/adityarb88/clarity/contributors","subscribers_url":"https://api.github.com/repos/adityarb88/clarity/subscribers","subscription_url":"https://api.github.com/repos/adityarb88/clarity/subscription","commits_url":"https://api.github.com/repos/adityarb88/clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/adityarb88/clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/adityarb88/clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/adityarb88/clarity/issues/comments{/number}","contents_url":"https://api.github.com/repos/adityarb88/clarity/contents/{+path}","compare_url":"https://api.github.com/repos/adityarb88/clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adityarb88/clarity/merges","archive_url":"https://api.github.com/repos/adityarb88/clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adityarb88/clarity/downloads","issues_url":"https://api.github.com/repos/adityarb88/clarity/issues{/number}","pulls_url":"https://api.github.com/repos/adityarb88/clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/adityarb88/clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/adityarb88/clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adityarb88/clarity/labels{/name}","releases_url":"https://api.github.com/repos/adityarb88/clarity/releases{/id}","deployments_url":"https://api.github.com/repos/adityarb88/clarity/deployments","created_at":"2016-11-17T12:23:01Z","updated_at":"2018-07-03T16:41:49Z","pushed_at":"2018-07-06T16:33:41Z","git_url":"git://github.com/adityarb88/clarity.git","ssh_url":"git@github.com:adityarb88/clarity.git","clone_url":"https://github.com/adityarb88/clarity.git","svn_url":"https://github.com/adityarb88/clarity","homepage":"https://vmware.github.io/clarity/","size":171906,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"219b85a04fb4a9dec40704c630b3c4690970893a","user":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":69590701,"node_id":"MDEwOlJlcG9zaXRvcnk2OTU5MDcwMQ==","name":"clarity","full_name":"vmware/clarity","owner":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/clarity","description":"UX guidelines, HTML/CSS framework, and Angular components working together to craft exceptional experiences","fork":false,"url":"https://api.github.com/repos/vmware/clarity","forks_url":"https://api.github.com/repos/vmware/clarity/forks","keys_url":"https://api.github.com/repos/vmware/clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/clarity/teams","hooks_url":"https://api.github.com/repos/vmware/clarity/hooks","issue_events_url":"https://api.github.com/repos/vmware/clarity/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/clarity/events","assignees_url":"https://api.github.com/repos/vmware/clarity/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/clarity/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/clarity/tags","blobs_url":"https://api.github.com/repos/vmware/clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/clarity/languages","stargazers_url":"https://api.github.com/repos/vmware/clarity/stargazers","contributors_url":"https://api.github.com/repos/vmware/clarity/contributors","subscribers_url":"https://api.github.com/repos/vmware/clarity/subscribers","subscription_url":"https://api.github.com/repos/vmware/clarity/subscription","commits_url":"https://api.github.com/repos/vmware/clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/clarity/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/clarity/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/clarity/merges","archive_url":"https://api.github.com/repos/vmware/clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/clarity/downloads","issues_url":"https://api.github.com/repos/vmware/clarity/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/clarity/labels{/name}","releases_url":"https://api.github.com/repos/vmware/clarity/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/clarity/deployments","created_at":"2016-09-29T17:24:17Z","updated_at":"2018-07-06T17:40:12Z","pushed_at":"2018-07-06T17:49:03Z","git_url":"git://github.com/vmware/clarity.git","ssh_url":"git@github.com:vmware/clarity.git","clone_url":"https://github.com/vmware/clarity.git","svn_url":"https://github.com/vmware/clarity","homepage":"http://clarity.design","size":256521,"stargazers_count":3768,"watchers_count":3768,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":343,"mirror_url":null,"archived":false,"open_issues_count":327,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":343,"open_issues":327,"watchers":3768,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2433"},"html":{"href":"https://github.com/vmware/clarity/pull/2433"},"issue":{"href":"https://api.github.com/repos/vmware/clarity/issues/2433"},"comments":{"href":"https://api.github.com/repos/vmware/clarity/issues/2433/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2433/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/clarity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2433/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/clarity/statuses/d3d8370d96527e29ca97df3db7c816cb34cfe353"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adityarb88"}}