{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/211025107","pull_request_review_id":147371769,"id":211025107,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTAyNTEwNw==","diff_hunk":"@@ -124,7 +126,7 @@ protected function getGroups()\n \t\t\t\t$workflowStages[$workflowStageKey] = array();\n \t\t\t}\n \n-\t\t\t$workflowStages[$workflowStageKey][] = HTMLHelper::_('select.option', $stage->workflow_stage_id, $stage->workflow_stage_title);\n+\t\t\t$workflowStates[$workflowStateKey][] = HTMLHelper::_('select.option', $state->workflow_stage_id, Text::_($state->workflow_stage_title));","path":"libraries/src/Form/Field/WorkflowStageField.php","position":15,"original_position":15,"commit_id":"a709ca0e481d870bc0eb8cd7f036e3038c6976c7","original_commit_id":"a709ca0e481d870bc0eb8cd7f036e3038c6976c7","user":{"login":"Joomv","id":5618499,"node_id":"MDQ6VXNlcjU2MTg0OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/5618499?v=4","gravatar_id":"","url":"https://api.github.com/users/Joomv","html_url":"https://github.com/Joomv","followers_url":"https://api.github.com/users/Joomv/followers","following_url":"https://api.github.com/users/Joomv/following{/other_user}","gists_url":"https://api.github.com/users/Joomv/gists{/gist_id}","starred_url":"https://api.github.com/users/Joomv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joomv/subscriptions","organizations_url":"https://api.github.com/users/Joomv/orgs","repos_url":"https://api.github.com/users/Joomv/repos","events_url":"https://api.github.com/users/Joomv/events{/privacy}","received_events_url":"https://api.github.com/users/Joomv/received_events","type":"User","site_admin":false},"body":"Should be $stage","created_at":"2018-08-17T20:32:11Z","updated_at":"2018-08-17T20:32:11Z","html_url":"https://github.com/joomla/joomla-cms/pull/21506#discussion_r211025107","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/21506","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/211025107"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/21506#discussion_r211025107"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/21506"}},"in_reply_to_id":209901563},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/21506","id":207415645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDE1NjQ1","html_url":"https://github.com/joomla/joomla-cms/pull/21506","diff_url":"https://github.com/joomla/joomla-cms/pull/21506.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/21506.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/21506","number":21506,"state":"open","locked":false,"title":"[4.0] Translate stages via language files","user":{"login":"bembelimen","id":1229869,"node_id":"MDQ6VXNlcjEyMjk4Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/1229869?v=4","gravatar_id":"","url":"https://api.github.com/users/bembelimen","html_url":"https://github.com/bembelimen","followers_url":"https://api.github.com/users/bembelimen/followers","following_url":"https://api.github.com/users/bembelimen/following{/other_user}","gists_url":"https://api.github.com/users/bembelimen/gists{/gist_id}","starred_url":"https://api.github.com/users/bembelimen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bembelimen/subscriptions","organizations_url":"https://api.github.com/users/bembelimen/orgs","repos_url":"https://api.github.com/users/bembelimen/repos","events_url":"https://api.github.com/users/bembelimen/events{/privacy}","received_events_url":"https://api.github.com/users/bembelimen/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue https://github.com/joomla/joomla-cms/issues/21476#issuecomment-411694584.\r\n\r\n### Summary of Changes\r\nNow one can use languages constants to have multilingual states\r\n\r\n\r\n\r\n### Testing Instructions\r\nCreate a state called \"JPUBLISHED\" and check it everywhere in the system (state list, article edit form, article list, transition edit form, ...)\r\n\r\n\r\n### Expected result\r\nThe language constant will be translated\r\n\r\n\r\n### Actual result\r\nNo translation at all","created_at":"2018-08-09T19:14:42Z","updated_at":"2018-08-17T20:32:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e707bcc379761e074e9e5c1c87efe6c4d1e0f590","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1020658346,"node_id":"MDU6TGFiZWwxMDIwNjU4MzQ2","url":"https://api.github.com/repos/joomla/joomla-cms/labels/New%20Feature%20Workflow","name":"New Feature Workflow","color":"c06ad8","default":false},{"id":444033883,"node_id":"MDU6TGFiZWw0NDQwMzM4ODM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/21506/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/21506/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/21506/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/a709ca0e481d870bc0eb8cd7f036e3038c6976c7","head":{"label":"bembelimen:translate-states-via-language-files","ref":"translate-states-via-language-files","sha":"a709ca0e481d870bc0eb8cd7f036e3038c6976c7","user":{"login":"bembelimen","id":1229869,"node_id":"MDQ6VXNlcjEyMjk4Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/1229869?v=4","gravatar_id":"","url":"https://api.github.com/users/bembelimen","html_url":"https://github.com/bembelimen","followers_url":"https://api.github.com/users/bembelimen/followers","following_url":"https://api.github.com/users/bembelimen/following{/other_user}","gists_url":"https://api.github.com/users/bembelimen/gists{/gist_id}","starred_url":"https://api.github.com/users/bembelimen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bembelimen/subscriptions","organizations_url":"https://api.github.com/users/bembelimen/orgs","repos_url":"https://api.github.com/users/bembelimen/repos","events_url":"https://api.github.com/users/bembelimen/events{/privacy}","received_events_url":"https://api.github.com/users/bembelimen/received_events","type":"User","site_admin":false},"repo":{"id":19490472,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ5MDQ3Mg==","name":"joomla-cms","full_name":"bembelimen/joomla-cms","owner":{"login":"bembelimen","id":1229869,"node_id":"MDQ6VXNlcjEyMjk4Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/1229869?v=4","gravatar_id":"","url":"https://api.github.com/users/bembelimen","html_url":"https://github.com/bembelimen","followers_url":"https://api.github.com/users/bembelimen/followers","following_url":"https://api.github.com/users/bembelimen/following{/other_user}","gists_url":"https://api.github.com/users/bembelimen/gists{/gist_id}","starred_url":"https://api.github.com/users/bembelimen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bembelimen/subscriptions","organizations_url":"https://api.github.com/users/bembelimen/orgs","repos_url":"https://api.github.com/users/bembelimen/repos","events_url":"https://api.github.com/users/bembelimen/events{/privacy}","received_events_url":"https://api.github.com/users/bembelimen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bembelimen/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/bembelimen/joomla-cms","forks_url":"https://api.github.com/repos/bembelimen/joomla-cms/forks","keys_url":"https://api.github.com/repos/bembelimen/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bembelimen/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bembelimen/joomla-cms/teams","hooks_url":"https://api.github.com/repos/bembelimen/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/bembelimen/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/bembelimen/joomla-cms/events","assignees_url":"https://api.github.com/repos/bembelimen/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/bembelimen/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/bembelimen/joomla-cms/tags","blobs_url":"https://api.github.com/repos/bembelimen/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bembelimen/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bembelimen/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/bembelimen/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bembelimen/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/bembelimen/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/bembelimen/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/bembelimen/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/bembelimen/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/bembelimen/joomla-cms/subscription","commits_url":"https://api.github.com/repos/bembelimen/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/bembelimen/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/bembelimen/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/bembelimen/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/bembelimen/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/bembelimen/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bembelimen/joomla-cms/merges","archive_url":"https://api.github.com/repos/bembelimen/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bembelimen/joomla-cms/downloads","issues_url":"https://api.github.com/repos/bembelimen/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/bembelimen/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/bembelimen/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/bembelimen/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bembelimen/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/bembelimen/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/bembelimen/joomla-cms/deployments","created_at":"2014-05-06T10:36:06Z","updated_at":"2018-04-14T23:12:56Z","pushed_at":"2018-08-17T09:32:58Z","git_url":"git://github.com/bembelimen/joomla-cms.git","ssh_url":"git@github.com:bembelimen/joomla-cms.git","clone_url":"https://github.com/bembelimen/joomla-cms.git","svn_url":"https://github.com/bembelimen/joomla-cms","homepage":"http://joomla.org","size":240576,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2,"open_issues":2,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:4.0-dev","ref":"4.0-dev","sha":"82d48d71fa2947df25e7b54160c1f954895b809a","user":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"node_id":"MDEwOlJlcG9zaXRvcnkyNDY0OTA4","name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2018-08-17T20:05:54Z","pushed_at":"2018-08-17T20:25:12Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":240590,"stargazers_count":2843,"watchers_count":2843,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2729,"mirror_url":null,"archived":false,"open_issues_count":782,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2729,"open_issues":782,"watchers":2843,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/21506"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/21506"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/21506"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/21506/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/21506/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/21506/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/a709ca0e481d870bc0eb8cd7f036e3038c6976c7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Joomv"}}