{"action":"created","issue":{"url":"https://api.github.com/repos/apache/geode/issues/3027","repository_url":"https://api.github.com/repos/apache/geode","labels_url":"https://api.github.com/repos/apache/geode/issues/3027/labels{/name}","comments_url":"https://api.github.com/repos/apache/geode/issues/3027/comments","events_url":"https://api.github.com/repos/apache/geode/issues/3027/events","html_url":"https://github.com/apache/geode/pull/3027","id":393166223,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjY1ODA5","number":3027,"title":"GEODE-6205: Set disk-dir in gfsh either absolute or relative based on…","user":{"login":"boglesby","id":1002028,"node_id":"MDQ6VXNlcjEwMDIwMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1002028?v=4","gravatar_id":"","url":"https://api.github.com/users/boglesby","html_url":"https://github.com/boglesby","followers_url":"https://api.github.com/users/boglesby/followers","following_url":"https://api.github.com/users/boglesby/following{/other_user}","gists_url":"https://api.github.com/users/boglesby/gists{/gist_id}","starred_url":"https://api.github.com/users/boglesby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boglesby/subscriptions","organizations_url":"https://api.github.com/users/boglesby/orgs","repos_url":"https://api.github.com/users/boglesby/repos","events_url":"https://api.github.com/users/boglesby/events{/privacy}","received_events_url":"https://api.github.com/users/boglesby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-20T18:41:38Z","updated_at":"2018-12-20T22:01:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/3027","html_url":"https://github.com/apache/geode/pull/3027","diff_url":"https://github.com/apache/geode/pull/3027.diff","patch_url":"https://github.com/apache/geode/pull/3027.patch"},"body":"… input directory\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n- [ ] Does `gradlew build` run cleanly?\r\n\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/geode/issues/comments/449149294","html_url":"https://github.com/apache/geode/pull/3027#issuecomment-449149294","issue_url":"https://api.github.com/repos/apache/geode/issues/3027","id":449149294,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTE0OTI5NA==","user":{"login":"boglesby","id":1002028,"node_id":"MDQ6VXNlcjEwMDIwMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1002028?v=4","gravatar_id":"","url":"https://api.github.com/users/boglesby","html_url":"https://github.com/boglesby","followers_url":"https://api.github.com/users/boglesby/followers","following_url":"https://api.github.com/users/boglesby/following{/other_user}","gists_url":"https://api.github.com/users/boglesby/gists{/gist_id}","starred_url":"https://api.github.com/users/boglesby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boglesby/subscriptions","organizations_url":"https://api.github.com/users/boglesby/orgs","repos_url":"https://api.github.com/users/boglesby/repos","events_url":"https://api.github.com/users/boglesby/events{/privacy}","received_events_url":"https://api.github.com/users/boglesby/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T22:01:05Z","updated_at":"2018-12-20T22:01:05Z","author_association":"CONTRIBUTOR","body":"@Petahhh: Yes, thats right. This is changing what is persisted in cluster configuration. Without the change, this command:\r\n```\r\ncreate disk-store --name=DISKSTORE --dir=/absolute/path/to/myDiskDir\r\n```\r\nSaved the relative `disk-dir` to cluster configuration:\r\n```\r\n<disk-store name=\"DISKSTORE\" ...>\r\n  <disk-dirs>\r\n    <disk-dir>myDiskDir</disk-dir>\r\n  </disk-dirs>\r\n</disk-store>\r\n```\r\nWhen a new server was started, it created a DiskStore in the working directory instead of the absolute directory.\r\n\r\nWith the change, this command:\r\n```\r\ncreate disk-store --name=DISKSTORE --dir=/absolute/path/to/myDiskDir\r\n```\r\nSaves the absolute `disk-dir` to cluster configuration:\r\n```\r\n<disk-store name=\"DISKSTORE\" ...>\r\n  <disk-dirs>\r\n    <disk-dir>/absolute/path/to/myDiskDir</disk-dir>\r\n  </disk-dirs>\r\n</disk-store>\r\n```\r\nAnd this command:\r\n```\r\ncreate disk-store --name=DISKSTORE --dir=myDiskDir\r\n```\r\nSaves the relative `disk-dir` to cluster configuration:\r\n```\r\n<disk-store name=\"DISKSTORE\" ...>\r\n  <disk-dirs>\r\n      <disk-dir>myDiskDir</disk-dir>\r\n  </disk-dirs>\r\n</disk-store>\r\n```\r\nIn both cases, the server gets the correct disk directory.\r\n\r\nBasically whatever is typed as the value of the `dir` in the command is saved to cluster configuration.\r\n"}}
{"actor":{"display_login":"boglesby"}}