{"action":"opened","number":65,"pull_request":{"url":"https://api.github.com/repos/bwrrp/slimdom.js/pulls/65","id":195446493,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDQ2NDkz","html_url":"https://github.com/bwrrp/slimdom.js/pull/65","diff_url":"https://github.com/bwrrp/slimdom.js/pull/65.diff","patch_url":"https://github.com/bwrrp/slimdom.js/pull/65.patch","issue_url":"https://api.github.com/repos/bwrrp/slimdom.js/issues/65","number":65,"state":"open","locked":false,"title":"Generics","user":{"login":"bwrrp","id":1515404,"node_id":"MDQ6VXNlcjE1MTU0MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1515404?v=4","gravatar_id":"","url":"https://api.github.com/users/bwrrp","html_url":"https://github.com/bwrrp","followers_url":"https://api.github.com/users/bwrrp/followers","following_url":"https://api.github.com/users/bwrrp/following{/other_user}","gists_url":"https://api.github.com/users/bwrrp/gists{/gist_id}","starred_url":"https://api.github.com/users/bwrrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwrrp/subscriptions","organizations_url":"https://api.github.com/users/bwrrp/orgs","repos_url":"https://api.github.com/users/bwrrp/repos","events_url":"https://api.github.com/users/bwrrp/events{/privacy}","received_events_url":"https://api.github.com/users/bwrrp/received_events","type":"User","site_admin":false},"body":"This updates the types of a few methods to use generics, in order to make things like cloneNode and appendChild directly return the expected subtype of Node rather than requiring a cast.\r\n\r\nIt is not completely clear whether this use of the `this` type (for cloneNode) is correct. Comments on the relevant Typescript issues range between \"this also solves clone methods\" and \"this is only for method chaining\". It seems that the compiler does allow returning a different instance of the type (instead of only allowing returning the this reference), so everything does type-check as intended.","created_at":"2018-06-18T07:56:54Z","updated_at":"2018-06-18T07:56:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bwrrp/slimdom.js/pulls/65/commits","review_comments_url":"https://api.github.com/repos/bwrrp/slimdom.js/pulls/65/comments","review_comment_url":"https://api.github.com/repos/bwrrp/slimdom.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bwrrp/slimdom.js/issues/65/comments","statuses_url":"https://api.github.com/repos/bwrrp/slimdom.js/statuses/69d063befb1b459969f8e2fc7b80a05a3f0c2329","head":{"label":"bwrrp:generics","ref":"generics","sha":"69d063befb1b459969f8e2fc7b80a05a3f0c2329","user":{"login":"bwrrp","id":1515404,"node_id":"MDQ6VXNlcjE1MTU0MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1515404?v=4","gravatar_id":"","url":"https://api.github.com/users/bwrrp","html_url":"https://github.com/bwrrp","followers_url":"https://api.github.com/users/bwrrp/followers","following_url":"https://api.github.com/users/bwrrp/following{/other_user}","gists_url":"https://api.github.com/users/bwrrp/gists{/gist_id}","starred_url":"https://api.github.com/users/bwrrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwrrp/subscriptions","organizations_url":"https://api.github.com/users/bwrrp/orgs","repos_url":"https://api.github.com/users/bwrrp/repos","events_url":"https://api.github.com/users/bwrrp/events{/privacy}","received_events_url":"https://api.github.com/users/bwrrp/received_events","type":"User","site_admin":false},"repo":{"id":12862734,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2MjczNA==","name":"slimdom.js","full_name":"bwrrp/slimdom.js","owner":{"login":"bwrrp","id":1515404,"node_id":"MDQ6VXNlcjE1MTU0MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1515404?v=4","gravatar_id":"","url":"https://api.github.com/users/bwrrp","html_url":"https://github.com/bwrrp","followers_url":"https://api.github.com/users/bwrrp/followers","following_url":"https://api.github.com/users/bwrrp/following{/other_user}","gists_url":"https://api.github.com/users/bwrrp/gists{/gist_id}","starred_url":"https://api.github.com/users/bwrrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwrrp/subscriptions","organizations_url":"https://api.github.com/users/bwrrp/orgs","repos_url":"https://api.github.com/users/bwrrp/repos","events_url":"https://api.github.com/users/bwrrp/events{/privacy}","received_events_url":"https://api.github.com/users/bwrrp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwrrp/slimdom.js","description":"Fast, tiny, standards-compliant XML DOM implementation for node and the browser","fork":false,"url":"https://api.github.com/repos/bwrrp/slimdom.js","forks_url":"https://api.github.com/repos/bwrrp/slimdom.js/forks","keys_url":"https://api.github.com/repos/bwrrp/slimdom.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwrrp/slimdom.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwrrp/slimdom.js/teams","hooks_url":"https://api.github.com/repos/bwrrp/slimdom.js/hooks","issue_events_url":"https://api.github.com/repos/bwrrp/slimdom.js/issues/events{/number}","events_url":"https://api.github.com/repos/bwrrp/slimdom.js/events","assignees_url":"https://api.github.com/repos/bwrrp/slimdom.js/assignees{/user}","branches_url":"https://api.github.com/repos/bwrrp/slimdom.js/branches{/branch}","tags_url":"https://api.github.com/repos/bwrrp/slimdom.js/tags","blobs_url":"https://api.github.com/repos/bwrrp/slimdom.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwrrp/slimdom.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwrrp/slimdom.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwrrp/slimdom.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwrrp/slimdom.js/statuses/{sha}","languages_url":"https://api.github.com/repos/bwrrp/slimdom.js/languages","stargazers_url":"https://api.github.com/repos/bwrrp/slimdom.js/stargazers","contributors_url":"https://api.github.com/repos/bwrrp/slimdom.js/contributors","subscribers_url":"https://api.github.com/repos/bwrrp/slimdom.js/subscribers","subscription_url":"https://api.github.com/repos/bwrrp/slimdom.js/subscription","commits_url":"https://api.github.com/repos/bwrrp/slimdom.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwrrp/slimdom.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwrrp/slimdom.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwrrp/slimdom.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwrrp/slimdom.js/contents/{+path}","compare_url":"https://api.github.com/repos/bwrrp/slimdom.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwrrp/slimdom.js/merges","archive_url":"https://api.github.com/repos/bwrrp/slimdom.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwrrp/slimdom.js/downloads","issues_url":"https://api.github.com/repos/bwrrp/slimdom.js/issues{/number}","pulls_url":"https://api.github.com/repos/bwrrp/slimdom.js/pulls{/number}","milestones_url":"https://api.github.com/repos/bwrrp/slimdom.js/milestones{/number}","notifications_url":"https://api.github.com/repos/bwrrp/slimdom.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwrrp/slimdom.js/labels{/name}","releases_url":"https://api.github.com/repos/bwrrp/slimdom.js/releases{/id}","deployments_url":"https://api.github.com/repos/bwrrp/slimdom.js/deployments","created_at":"2013-09-16T08:53:15Z","updated_at":"2018-03-16T12:25:40Z","pushed_at":"2018-06-18T07:52:20Z","git_url":"git://github.com/bwrrp/slimdom.js.git","ssh_url":"git@github.com:bwrrp/slimdom.js.git","clone_url":"https://github.com/bwrrp/slimdom.js.git","svn_url":"https://github.com/bwrrp/slimdom.js","homepage":"","size":481,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":12,"watchers":6,"default_branch":"master"}},"base":{"label":"bwrrp:master","ref":"master","sha":"7efec25b1b5aa003122850b5f6d4fb31e06417eb","user":{"login":"bwrrp","id":1515404,"node_id":"MDQ6VXNlcjE1MTU0MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1515404?v=4","gravatar_id":"","url":"https://api.github.com/users/bwrrp","html_url":"https://github.com/bwrrp","followers_url":"https://api.github.com/users/bwrrp/followers","following_url":"https://api.github.com/users/bwrrp/following{/other_user}","gists_url":"https://api.github.com/users/bwrrp/gists{/gist_id}","starred_url":"https://api.github.com/users/bwrrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwrrp/subscriptions","organizations_url":"https://api.github.com/users/bwrrp/orgs","repos_url":"https://api.github.com/users/bwrrp/repos","events_url":"https://api.github.com/users/bwrrp/events{/privacy}","received_events_url":"https://api.github.com/users/bwrrp/received_events","type":"User","site_admin":false},"repo":{"id":12862734,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2MjczNA==","name":"slimdom.js","full_name":"bwrrp/slimdom.js","owner":{"login":"bwrrp","id":1515404,"node_id":"MDQ6VXNlcjE1MTU0MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1515404?v=4","gravatar_id":"","url":"https://api.github.com/users/bwrrp","html_url":"https://github.com/bwrrp","followers_url":"https://api.github.com/users/bwrrp/followers","following_url":"https://api.github.com/users/bwrrp/following{/other_user}","gists_url":"https://api.github.com/users/bwrrp/gists{/gist_id}","starred_url":"https://api.github.com/users/bwrrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwrrp/subscriptions","organizations_url":"https://api.github.com/users/bwrrp/orgs","repos_url":"https://api.github.com/users/bwrrp/repos","events_url":"https://api.github.com/users/bwrrp/events{/privacy}","received_events_url":"https://api.github.com/users/bwrrp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwrrp/slimdom.js","description":"Fast, tiny, standards-compliant XML DOM implementation for node and the browser","fork":false,"url":"https://api.github.com/repos/bwrrp/slimdom.js","forks_url":"https://api.github.com/repos/bwrrp/slimdom.js/forks","keys_url":"https://api.github.com/repos/bwrrp/slimdom.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwrrp/slimdom.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwrrp/slimdom.js/teams","hooks_url":"https://api.github.com/repos/bwrrp/slimdom.js/hooks","issue_events_url":"https://api.github.com/repos/bwrrp/slimdom.js/issues/events{/number}","events_url":"https://api.github.com/repos/bwrrp/slimdom.js/events","assignees_url":"https://api.github.com/repos/bwrrp/slimdom.js/assignees{/user}","branches_url":"https://api.github.com/repos/bwrrp/slimdom.js/branches{/branch}","tags_url":"https://api.github.com/repos/bwrrp/slimdom.js/tags","blobs_url":"https://api.github.com/repos/bwrrp/slimdom.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwrrp/slimdom.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwrrp/slimdom.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwrrp/slimdom.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwrrp/slimdom.js/statuses/{sha}","languages_url":"https://api.github.com/repos/bwrrp/slimdom.js/languages","stargazers_url":"https://api.github.com/repos/bwrrp/slimdom.js/stargazers","contributors_url":"https://api.github.com/repos/bwrrp/slimdom.js/contributors","subscribers_url":"https://api.github.com/repos/bwrrp/slimdom.js/subscribers","subscription_url":"https://api.github.com/repos/bwrrp/slimdom.js/subscription","commits_url":"https://api.github.com/repos/bwrrp/slimdom.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwrrp/slimdom.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwrrp/slimdom.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwrrp/slimdom.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwrrp/slimdom.js/contents/{+path}","compare_url":"https://api.github.com/repos/bwrrp/slimdom.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwrrp/slimdom.js/merges","archive_url":"https://api.github.com/repos/bwrrp/slimdom.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwrrp/slimdom.js/downloads","issues_url":"https://api.github.com/repos/bwrrp/slimdom.js/issues{/number}","pulls_url":"https://api.github.com/repos/bwrrp/slimdom.js/pulls{/number}","milestones_url":"https://api.github.com/repos/bwrrp/slimdom.js/milestones{/number}","notifications_url":"https://api.github.com/repos/bwrrp/slimdom.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwrrp/slimdom.js/labels{/name}","releases_url":"https://api.github.com/repos/bwrrp/slimdom.js/releases{/id}","deployments_url":"https://api.github.com/repos/bwrrp/slimdom.js/deployments","created_at":"2013-09-16T08:53:15Z","updated_at":"2018-03-16T12:25:40Z","pushed_at":"2018-06-18T07:52:20Z","git_url":"git://github.com/bwrrp/slimdom.js.git","ssh_url":"git@github.com:bwrrp/slimdom.js.git","clone_url":"https://github.com/bwrrp/slimdom.js.git","svn_url":"https://github.com/bwrrp/slimdom.js","homepage":"","size":481,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":12,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bwrrp/slimdom.js/pulls/65"},"html":{"href":"https://github.com/bwrrp/slimdom.js/pull/65"},"issue":{"href":"https://api.github.com/repos/bwrrp/slimdom.js/issues/65"},"comments":{"href":"https://api.github.com/repos/bwrrp/slimdom.js/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/bwrrp/slimdom.js/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/bwrrp/slimdom.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bwrrp/slimdom.js/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/bwrrp/slimdom.js/statuses/69d063befb1b459969f8e2fc7b80a05a3f0c2329"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":104,"deletions":84,"changed_files":22}}
{"actor":{"display_login":"bwrrp"}}