{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/191687093","pull_request_review_id":124303282,"id":191687093,"diff_hunk":"@@ -24,17 +24,18 @@\n  * International Registered Trademark & Property of PrestaShop SA\n  */\n \n-namespace PrestaShop\\PrestaShop\\Core\\Localization\\Pack;\n+namespace PrestaShop\\PrestaShop\\Core\\Localization\\Pack\\Factory;\n+use LocalizationPack;","path":"src/Core/Localization/Pack/Factory/LocalizationPackFactoryInterface.php","position":null,"original_position":6,"commit_id":"78edf0d197a56c44b0e42691469137d8c7f56d6d","original_commit_id":"78edf0d197a56c44b0e42691469137d8c7f56d6d","user":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars2.githubusercontent.com/u/1247388?v=4","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"body":"Yes, thanks","created_at":"2018-05-30T08:44:33Z","updated_at":"2018-05-30T08:44:33Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9116#discussion_r191687093","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9116","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/191687093"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/9116#discussion_r191687093"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9116"}},"in_reply_to_id":191575303},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9116","id":190025470,"html_url":"https://github.com/PrestaShop/PrestaShop/pull/9116","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/9116.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/9116.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9116","number":9116,"state":"open","locked":false,"title":"[WIP] Migrate localization page","user":{"login":"sarjon","id":15143151,"avatar_url":"https://avatars3.githubusercontent.com/u/15143151?v=4","gravatar_id":"","url":"https://api.github.com/users/sarjon","html_url":"https://github.com/sarjon","followers_url":"https://api.github.com/users/sarjon/followers","following_url":"https://api.github.com/users/sarjon/following{/other_user}","gists_url":"https://api.github.com/users/sarjon/gists{/gist_id}","starred_url":"https://api.github.com/users/sarjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarjon/subscriptions","organizations_url":"https://api.github.com/users/sarjon/orgs","repos_url":"https://api.github.com/users/sarjon/repos","events_url":"https://api.github.com/users/sarjon/events{/privacy}","received_events_url":"https://api.github.com/users/sarjon/received_events","type":"User","site_admin":false},"body":"| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | develop\r\n| Description?  | Migrates \"Improve > International > Localization\" page to Symfony\r\n| Type?         | new feature\r\n| Category?     | CO\r\n| BC breaks?    | yes (overrides)\r\n| Deprecations? | no\r\n| Fixed ticket? | n/a\r\n| How to test?  | Access \"Improve > International > Localization\" and it should work the same as legacy page.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/9116)\n<!-- Reviewable:end -->\n","created_at":"2018-05-23T15:55:45Z","updated_at":"2018-05-30T08:44:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6462d01b82eacc82a15592ab5745bee488da49e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":904910825,"url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/develop","name":"develop","color":"3ce091","default":false},{"id":630442847,"url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/feature","name":"feature","color":"b9d854","default":false},{"id":186105912,"url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/waiting%20for%20author%20feedback","name":"waiting for author feedback","color":"fbca04","default":false},{"id":268030897,"url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/wip","name":"wip","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9116/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9116/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9116/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/78edf0d197a56c44b0e42691469137d8c7f56d6d","head":{"label":"sarjon:migrate-localization-page","ref":"migrate-localization-page","sha":"78edf0d197a56c44b0e42691469137d8c7f56d6d","user":{"login":"sarjon","id":15143151,"avatar_url":"https://avatars3.githubusercontent.com/u/15143151?v=4","gravatar_id":"","url":"https://api.github.com/users/sarjon","html_url":"https://github.com/sarjon","followers_url":"https://api.github.com/users/sarjon/followers","following_url":"https://api.github.com/users/sarjon/following{/other_user}","gists_url":"https://api.github.com/users/sarjon/gists{/gist_id}","starred_url":"https://api.github.com/users/sarjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarjon/subscriptions","organizations_url":"https://api.github.com/users/sarjon/orgs","repos_url":"https://api.github.com/users/sarjon/repos","events_url":"https://api.github.com/users/sarjon/events{/privacy}","received_events_url":"https://api.github.com/users/sarjon/received_events","type":"User","site_admin":false},"repo":{"id":77449609,"name":"PrestaShop","full_name":"sarjon/PrestaShop","owner":{"login":"sarjon","id":15143151,"avatar_url":"https://avatars3.githubusercontent.com/u/15143151?v=4","gravatar_id":"","url":"https://api.github.com/users/sarjon","html_url":"https://github.com/sarjon","followers_url":"https://api.github.com/users/sarjon/followers","following_url":"https://api.github.com/users/sarjon/following{/other_user}","gists_url":"https://api.github.com/users/sarjon/gists{/gist_id}","starred_url":"https://api.github.com/users/sarjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarjon/subscriptions","organizations_url":"https://api.github.com/users/sarjon/orgs","repos_url":"https://api.github.com/users/sarjon/repos","events_url":"https://api.github.com/users/sarjon/events{/privacy}","received_events_url":"https://api.github.com/users/sarjon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarjon/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open Source e-commerce solution.","fork":true,"url":"https://api.github.com/repos/sarjon/PrestaShop","forks_url":"https://api.github.com/repos/sarjon/PrestaShop/forks","keys_url":"https://api.github.com/repos/sarjon/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarjon/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarjon/PrestaShop/teams","hooks_url":"https://api.github.com/repos/sarjon/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/sarjon/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/sarjon/PrestaShop/events","assignees_url":"https://api.github.com/repos/sarjon/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/sarjon/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/sarjon/PrestaShop/tags","blobs_url":"https://api.github.com/repos/sarjon/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarjon/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarjon/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarjon/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarjon/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/sarjon/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/sarjon/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/sarjon/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/sarjon/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/sarjon/PrestaShop/subscription","commits_url":"https://api.github.com/repos/sarjon/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarjon/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarjon/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarjon/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarjon/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/sarjon/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarjon/PrestaShop/merges","archive_url":"https://api.github.com/repos/sarjon/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarjon/PrestaShop/downloads","issues_url":"https://api.github.com/repos/sarjon/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/sarjon/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/sarjon/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/sarjon/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarjon/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/sarjon/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/sarjon/PrestaShop/deployments","created_at":"2016-12-27T11:12:19Z","updated_at":"2018-05-24T07:14:46Z","pushed_at":"2018-05-29T20:18:28Z","git_url":"git://github.com/sarjon/PrestaShop.git","ssh_url":"git@github.com:sarjon/PrestaShop.git","clone_url":"https://github.com/sarjon/PrestaShop.git","svn_url":"https://github.com/sarjon/PrestaShop","homepage":"http://www.prestashop.com/","size":314531,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:develop","ref":"develop","sha":"c38afb55c6c658b73c492f336bd0cf1eb3a066d7","user":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open Source e-commerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2018-05-29T18:08:42Z","pushed_at":"2018-05-29T20:30:36Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":337583,"stargazers_count":3045,"watchers_count":3045,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2769,"mirror_url":null,"archived":false,"open_issues_count":339,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2769,"open_issues":339,"watchers":3045,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9116"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/9116"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9116"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9116/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9116/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9116/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/78edf0d197a56c44b0e42691469137d8c7f56d6d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mickaelandrieu"}}