{"action":"created","issue":{"url":"https://api.github.com/repos/PYPIT/PYPIT/issues/314","repository_url":"https://api.github.com/repos/PYPIT/PYPIT","labels_url":"https://api.github.com/repos/PYPIT/PYPIT/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/PYPIT/PYPIT/issues/314/comments","events_url":"https://api.github.com/repos/PYPIT/PYPIT/issues/314/events","html_url":"https://github.com/PYPIT/PYPIT/pull/314","id":311688812,"number":314,"title":"All imports in file headers","user":{"login":"kbwestfall","id":15785898,"avatar_url":"https://avatars2.githubusercontent.com/u/15785898?v=4","gravatar_id":"","url":"https://api.github.com/users/kbwestfall","html_url":"https://github.com/kbwestfall","followers_url":"https://api.github.com/users/kbwestfall/followers","following_url":"https://api.github.com/users/kbwestfall/following{/other_user}","gists_url":"https://api.github.com/users/kbwestfall/gists{/gist_id}","starred_url":"https://api.github.com/users/kbwestfall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbwestfall/subscriptions","organizations_url":"https://api.github.com/users/kbwestfall/orgs","repos_url":"https://api.github.com/users/kbwestfall/repos","events_url":"https://api.github.com/users/kbwestfall/events{/privacy}","received_events_url":"https://api.github.com/users/kbwestfall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-05T16:49:08Z","updated_at":"2018-04-10T16:32:40Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/PYPIT/PYPIT/pulls/314","html_url":"https://github.com/PYPIT/PYPIT/pull/314","diff_url":"https://github.com/PYPIT/PYPIT/pull/314.diff","patch_url":"https://github.com/PYPIT/PYPIT/pull/314.patch"},"body":"I've moved all imports to the file headers of all modules.  This adheres to PEP 8 and helps track down circular imports caused by modularity issues in the code.  I also removed most of the `import ... as ... ` constructs.  The latter is really just my personal preference for making the code more readable, and we can switch these back if it's super annoying to anyone.  Here's a summary of what this PR does:\r\n\r\n - I had to remove the ability to run arlris.read_lris() from within ginga.show_image(); we need to refactor this\r\n - move dummy_self from arutils to arsciexp\r\n - remove dependency of ararclines functions on slf\r\n    - parse_nist(): slf never used\r\n    - load_arcline_list():\r\n        - if slf is None, created using dummy_self\r\n        - only operation is to pass slf to reject_lines()\r\n    - reject_lines():\r\n        - only ever called by ararclines.load_arcline_list()\r\n        - slf is never None because ararclines.load_arcline_list() will set it using dummy_self()\r\n        - slf only affects the workflow of reject_lines() if it is None, and it should never by None\r\n \r\n - move dummy_settings from arutils to arparse\r\n - move dummy_specobj from arutils to arspecobj\r\n\r\n - propagated dummy_* moves to tests\r\n\r\n - require version of astropy that started to use 'overwrite' instead of clobber\r\n - add numba as a dependency\r\n\r\nPython 3 tests pass.  Python 2 tests fail because of a linetools import that causes problems for my installation, but this may be particular to my installation, see #313 .\r\n\r\nAll the tests in the dev suite pass in both python 2 and 3.\r\n"},"comment":{"url":"https://api.github.com/repos/PYPIT/PYPIT/issues/comments/380165526","html_url":"https://github.com/PYPIT/PYPIT/pull/314#issuecomment-380165526","issue_url":"https://api.github.com/repos/PYPIT/PYPIT/issues/314","id":380165526,"user":{"login":"profxj","id":3998093,"avatar_url":"https://avatars2.githubusercontent.com/u/3998093?v=4","gravatar_id":"","url":"https://api.github.com/users/profxj","html_url":"https://github.com/profxj","followers_url":"https://api.github.com/users/profxj/followers","following_url":"https://api.github.com/users/profxj/following{/other_user}","gists_url":"https://api.github.com/users/profxj/gists{/gist_id}","starred_url":"https://api.github.com/users/profxj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/profxj/subscriptions","organizations_url":"https://api.github.com/users/profxj/orgs","repos_url":"https://api.github.com/users/profxj/repos","events_url":"https://api.github.com/users/profxj/events{/privacy}","received_events_url":"https://api.github.com/users/profxj/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T16:32:40Z","updated_at":"2018-04-10T16:32:40Z","author_association":"OWNER","body":"and Travis barfed on my change while this\r\nworks fine on my machine (3.6).   Now I really\r\nknow what circular imports mean! ;)"}}
{"actor":{"display_login":"profxj"}}