{"action":"created","issue":{"url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2/issues/17","repository_url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2","labels_url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2/issues/17/comments","events_url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2/issues/17/events","html_url":"https://github.com/nus-cs2103-AY1819S1/addressbook-level2/pull/17","id":356257558,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTc4Njg0","number":17,"title":"[W4.11e][W17-2]Edric Teo Jin Kai","user":{"login":"etjk","id":7698646,"node_id":"MDQ6VXNlcjc2OTg2NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7698646?v=4","gravatar_id":"","url":"https://api.github.com/users/etjk","html_url":"https://github.com/etjk","followers_url":"https://api.github.com/users/etjk/followers","following_url":"https://api.github.com/users/etjk/following{/other_user}","gists_url":"https://api.github.com/users/etjk/gists{/gist_id}","starred_url":"https://api.github.com/users/etjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etjk/subscriptions","organizations_url":"https://api.github.com/users/etjk/orgs","repos_url":"https://api.github.com/users/etjk/repos","events_url":"https://api.github.com/users/etjk/events{/privacy}","received_events_url":"https://api.github.com/users/etjk/received_events","type":"User","site_admin":false},"labels":[{"id":1043647420,"node_id":"MDU6TGFiZWwxMDQzNjQ3NDIw","url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2/labels/Reviewed","name":"Reviewed","color":"01c125","default":false},{"id":1043567485,"node_id":"MDU6TGFiZWwxMDQzNTY3NDg1","url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2/labels/team.2","name":"team.2","color":"ededed","default":false},{"id":1043567484,"node_id":"MDU6TGFiZWwxMDQzNTY3NDg0","url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2/labels/tutorial.W17","name":"tutorial.W17","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"amrut-prabhu","id":29021586,"node_id":"MDQ6VXNlcjI5MDIxNTg2","avatar_url":"https://avatars0.githubusercontent.com/u/29021586?v=4","gravatar_id":"","url":"https://api.github.com/users/amrut-prabhu","html_url":"https://github.com/amrut-prabhu","followers_url":"https://api.github.com/users/amrut-prabhu/followers","following_url":"https://api.github.com/users/amrut-prabhu/following{/other_user}","gists_url":"https://api.github.com/users/amrut-prabhu/gists{/gist_id}","starred_url":"https://api.github.com/users/amrut-prabhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrut-prabhu/subscriptions","organizations_url":"https://api.github.com/users/amrut-prabhu/orgs","repos_url":"https://api.github.com/users/amrut-prabhu/repos","events_url":"https://api.github.com/users/amrut-prabhu/events{/privacy}","received_events_url":"https://api.github.com/users/amrut-prabhu/received_events","type":"User","site_admin":false},"assignees":[{"login":"amrut-prabhu","id":29021586,"node_id":"MDQ6VXNlcjI5MDIxNTg2","avatar_url":"https://avatars0.githubusercontent.com/u/29021586?v=4","gravatar_id":"","url":"https://api.github.com/users/amrut-prabhu","html_url":"https://github.com/amrut-prabhu","followers_url":"https://api.github.com/users/amrut-prabhu/followers","following_url":"https://api.github.com/users/amrut-prabhu/following{/other_user}","gists_url":"https://api.github.com/users/amrut-prabhu/gists{/gist_id}","starred_url":"https://api.github.com/users/amrut-prabhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrut-prabhu/subscriptions","organizations_url":"https://api.github.com/users/amrut-prabhu/orgs","repos_url":"https://api.github.com/users/amrut-prabhu/repos","events_url":"https://api.github.com/users/amrut-prabhu/events{/privacy}","received_events_url":"https://api.github.com/users/amrut-prabhu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-02T06:43:33Z","updated_at":"2018-09-19T11:37:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2/pulls/17","html_url":"https://github.com/nus-cs2103-AY1819S1/addressbook-level2/pull/17","diff_url":"https://github.com/nus-cs2103-AY1819S1/addressbook-level2/pull/17.diff","patch_url":"https://github.com/nus-cs2103-AY1819S1/addressbook-level2/pull/17.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2/issues/comments/422767844","html_url":"https://github.com/nus-cs2103-AY1819S1/addressbook-level2/pull/17#issuecomment-422767844","issue_url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level2/issues/17","id":422767844,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjc2Nzg0NA==","user":{"login":"amrut-prabhu","id":29021586,"node_id":"MDQ6VXNlcjI5MDIxNTg2","avatar_url":"https://avatars0.githubusercontent.com/u/29021586?v=4","gravatar_id":"","url":"https://api.github.com/users/amrut-prabhu","html_url":"https://github.com/amrut-prabhu","followers_url":"https://api.github.com/users/amrut-prabhu/followers","following_url":"https://api.github.com/users/amrut-prabhu/following{/other_user}","gists_url":"https://api.github.com/users/amrut-prabhu/gists{/gist_id}","starred_url":"https://api.github.com/users/amrut-prabhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrut-prabhu/subscriptions","organizations_url":"https://api.github.com/users/amrut-prabhu/orgs","repos_url":"https://api.github.com/users/amrut-prabhu/repos","events_url":"https://api.github.com/users/amrut-prabhu/events{/privacy}","received_events_url":"https://api.github.com/users/amrut-prabhu/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T11:37:12Z","updated_at":"2018-09-19T11:37:12Z","author_association":"NONE","body":"Sorry for the late reply, must have missed this. 😅 \r\n\r\nHaha, yep, this looks better. \r\n\r\nBut, maybe you can try something like this as well. \r\n```\r\n    // non-empty list with no null\r\n    assertFalse(Utils.isAnyNull(1));\r\n    assertFalse(Utils.isAnyNull(\"\"));\r\n    assertFalse(Utils.isAnyNull(\"1\", 1, (Object) 1));\r\n    \r\n    // non-empty list with one null\r\n    assertTrue(Utils.isAnyNull(null));\r\n    assertTrue(Utils.isAnyNull((Object) null));\r\n```\r\n\r\nI guess it's kind of subjective. Just make sure that your code is readable and that, you don't unintentionally mislead the reader (eg. by just putting 1 assertFalse in the middle of a group of 5 assertTrue statements)"}}
{"actor":{"display_login":"amrut-prabhu"}}