{"action":"created","issue":{"url":"https://api.github.com/repos/domoticz/domoticz/issues/2697","repository_url":"https://api.github.com/repos/domoticz/domoticz","labels_url":"https://api.github.com/repos/domoticz/domoticz/issues/2697/labels{/name}","comments_url":"https://api.github.com/repos/domoticz/domoticz/issues/2697/comments","events_url":"https://api.github.com/repos/domoticz/domoticz/issues/2697/events","html_url":"https://github.com/domoticz/domoticz/pull/2697","id":356207831,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTQ5ODQ0","number":2697,"title":"Refactor ASyncTCP class","user":{"login":"emontnemery","id":14281572,"node_id":"MDQ6VXNlcjE0MjgxNTcy","avatar_url":"https://avatars1.githubusercontent.com/u/14281572?v=4","gravatar_id":"","url":"https://api.github.com/users/emontnemery","html_url":"https://github.com/emontnemery","followers_url":"https://api.github.com/users/emontnemery/followers","following_url":"https://api.github.com/users/emontnemery/following{/other_user}","gists_url":"https://api.github.com/users/emontnemery/gists{/gist_id}","starred_url":"https://api.github.com/users/emontnemery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emontnemery/subscriptions","organizations_url":"https://api.github.com/users/emontnemery/orgs","repos_url":"https://api.github.com/users/emontnemery/repos","events_url":"https://api.github.com/users/emontnemery/events{/privacy}","received_events_url":"https://api.github.com/users/emontnemery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-09-01T14:46:46Z","updated_at":"2018-09-03T06:06:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/domoticz/domoticz/pulls/2697","html_url":"https://github.com/domoticz/domoticz/pull/2697","diff_url":"https://github.com/domoticz/domoticz/pull/2697.diff","patch_url":"https://github.com/domoticz/domoticz/pull/2697.patch"},"body":"Changes:\r\n- No need to poll\r\n- Thread safe write() since WriteToHardware() is accessed from mainworker as pointed out by @gordonb3\r\n- Fix access modifiers: ASyncTCP does not need any public members or methods, only private and some protected (for use in the derived HW classes)\r\n- Refactor all derived HW classes, including removal of dead / useless code from Do_Work() loop"},"comment":{"url":"https://api.github.com/repos/domoticz/domoticz/issues/comments/418009361","html_url":"https://github.com/domoticz/domoticz/pull/2697#issuecomment-418009361","issue_url":"https://api.github.com/repos/domoticz/domoticz/issues/2697","id":418009361,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODAwOTM2MQ==","user":{"login":"gizmocuz","id":2265299,"node_id":"MDQ6VXNlcjIyNjUyOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2265299?v=4","gravatar_id":"","url":"https://api.github.com/users/gizmocuz","html_url":"https://github.com/gizmocuz","followers_url":"https://api.github.com/users/gizmocuz/followers","following_url":"https://api.github.com/users/gizmocuz/following{/other_user}","gists_url":"https://api.github.com/users/gizmocuz/gists{/gist_id}","starred_url":"https://api.github.com/users/gizmocuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gizmocuz/subscriptions","organizations_url":"https://api.github.com/users/gizmocuz/orgs","repos_url":"https://api.github.com/users/gizmocuz/repos","events_url":"https://api.github.com/users/gizmocuz/events{/privacy}","received_events_url":"https://api.github.com/users/gizmocuz/received_events","type":"User","site_admin":false},"created_at":"2018-09-03T06:06:29Z","updated_at":"2018-09-03T06:06:29Z","author_association":"CONTRIBUTOR","body":"I agree, see above"}}
{"actor":{"display_login":"gizmocuz"}}