{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/perfview/pulls/comments/174217613","pull_request_review_id":103533452,"id":174217613,"diff_hunk":"@@ -1,3 +1,4 @@\n+#define SUPPORT_V1_V2","path":"src/TraceEvent/EventPipe/EventPipeTraceEventParser.cs","position":1,"original_position":1,"commit_id":"26fdca6a3a2c05500b80f6ee55b472074839b52f","original_commit_id":"26fdca6a3a2c05500b80f6ee55b472074839b52f","user":{"login":"vancem","id":8459414,"avatar_url":"https://avatars2.githubusercontent.com/u/8459414?v=4","gravatar_id":"","url":"https://api.github.com/users/vancem","html_url":"https://github.com/vancem","followers_url":"https://api.github.com/users/vancem/followers","following_url":"https://api.github.com/users/vancem/following{/other_user}","gists_url":"https://api.github.com/users/vancem/gists{/gist_id}","starred_url":"https://api.github.com/users/vancem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vancem/subscriptions","organizations_url":"https://api.github.com/users/vancem/orgs","repos_url":"https://api.github.com/users/vancem/repos","events_url":"https://api.github.com/users/vancem/events{/privacy}","received_events_url":"https://api.github.com/users/vancem/received_events","type":"User","site_admin":false},"body":"We now need this define in two files, we should move it to the TraceEvent.csproj file under DefineConstants.","created_at":"2018-03-13T17:26:00Z","updated_at":"2018-03-13T17:26:00Z","html_url":"https://github.com/Microsoft/perfview/pull/597#discussion_r174217613","pull_request_url":"https://api.github.com/repos/Microsoft/perfview/pulls/597","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/perfview/pulls/comments/174217613"},"html":{"href":"https://github.com/Microsoft/perfview/pull/597#discussion_r174217613"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/perfview/pulls/597"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/perfview/pulls/597","id":174386504,"html_url":"https://github.com/Microsoft/perfview/pull/597","diff_url":"https://github.com/Microsoft/perfview/pull/597.diff","patch_url":"https://github.com/Microsoft/perfview/pull/597.patch","issue_url":"https://api.github.com/repos/Microsoft/perfview/issues/597","number":597,"state":"open","locked":false,"title":"Add Support for Nested Structs to EventPipe","user":{"login":"brianrob","id":6210322,"avatar_url":"https://avatars0.githubusercontent.com/u/6210322?v=4","gravatar_id":"","url":"https://api.github.com/users/brianrob","html_url":"https://github.com/brianrob","followers_url":"https://api.github.com/users/brianrob/followers","following_url":"https://api.github.com/users/brianrob/following{/other_user}","gists_url":"https://api.github.com/users/brianrob/gists{/gist_id}","starred_url":"https://api.github.com/users/brianrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianrob/subscriptions","organizations_url":"https://api.github.com/users/brianrob/orgs","repos_url":"https://api.github.com/users/brianrob/repos","events_url":"https://api.github.com/users/brianrob/events{/privacy}","received_events_url":"https://api.github.com/users/brianrob/received_events","type":"User","site_admin":false},"body":"Required to support TraceLogging in EventPipe: https://github.com/dotnet/coreclr/pull/16861.","created_at":"2018-03-12T14:34:11Z","updated_at":"2018-03-13T17:26:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b258d95d027b95e8457b8f72f281d72ae73468bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/perfview/pulls/597/commits","review_comments_url":"https://api.github.com/repos/Microsoft/perfview/pulls/597/comments","review_comment_url":"https://api.github.com/repos/Microsoft/perfview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/perfview/issues/597/comments","statuses_url":"https://api.github.com/repos/Microsoft/perfview/statuses/26fdca6a3a2c05500b80f6ee55b472074839b52f","head":{"label":"brianrob:eventpipe_tracelogging","ref":"eventpipe_tracelogging","sha":"26fdca6a3a2c05500b80f6ee55b472074839b52f","user":{"login":"brianrob","id":6210322,"avatar_url":"https://avatars0.githubusercontent.com/u/6210322?v=4","gravatar_id":"","url":"https://api.github.com/users/brianrob","html_url":"https://github.com/brianrob","followers_url":"https://api.github.com/users/brianrob/followers","following_url":"https://api.github.com/users/brianrob/following{/other_user}","gists_url":"https://api.github.com/users/brianrob/gists{/gist_id}","starred_url":"https://api.github.com/users/brianrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianrob/subscriptions","organizations_url":"https://api.github.com/users/brianrob/orgs","repos_url":"https://api.github.com/users/brianrob/repos","events_url":"https://api.github.com/users/brianrob/events{/privacy}","received_events_url":"https://api.github.com/users/brianrob/received_events","type":"User","site_admin":false},"repo":{"id":119560750,"name":"perfview","full_name":"brianrob/perfview","owner":{"login":"brianrob","id":6210322,"avatar_url":"https://avatars0.githubusercontent.com/u/6210322?v=4","gravatar_id":"","url":"https://api.github.com/users/brianrob","html_url":"https://github.com/brianrob","followers_url":"https://api.github.com/users/brianrob/followers","following_url":"https://api.github.com/users/brianrob/following{/other_user}","gists_url":"https://api.github.com/users/brianrob/gists{/gist_id}","starred_url":"https://api.github.com/users/brianrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianrob/subscriptions","organizations_url":"https://api.github.com/users/brianrob/orgs","repos_url":"https://api.github.com/users/brianrob/repos","events_url":"https://api.github.com/users/brianrob/events{/privacy}","received_events_url":"https://api.github.com/users/brianrob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianrob/perfview","description":"PerfView is a CPU and memory performance-analysis tool","fork":true,"url":"https://api.github.com/repos/brianrob/perfview","forks_url":"https://api.github.com/repos/brianrob/perfview/forks","keys_url":"https://api.github.com/repos/brianrob/perfview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianrob/perfview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianrob/perfview/teams","hooks_url":"https://api.github.com/repos/brianrob/perfview/hooks","issue_events_url":"https://api.github.com/repos/brianrob/perfview/issues/events{/number}","events_url":"https://api.github.com/repos/brianrob/perfview/events","assignees_url":"https://api.github.com/repos/brianrob/perfview/assignees{/user}","branches_url":"https://api.github.com/repos/brianrob/perfview/branches{/branch}","tags_url":"https://api.github.com/repos/brianrob/perfview/tags","blobs_url":"https://api.github.com/repos/brianrob/perfview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianrob/perfview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianrob/perfview/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianrob/perfview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianrob/perfview/statuses/{sha}","languages_url":"https://api.github.com/repos/brianrob/perfview/languages","stargazers_url":"https://api.github.com/repos/brianrob/perfview/stargazers","contributors_url":"https://api.github.com/repos/brianrob/perfview/contributors","subscribers_url":"https://api.github.com/repos/brianrob/perfview/subscribers","subscription_url":"https://api.github.com/repos/brianrob/perfview/subscription","commits_url":"https://api.github.com/repos/brianrob/perfview/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianrob/perfview/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianrob/perfview/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianrob/perfview/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianrob/perfview/contents/{+path}","compare_url":"https://api.github.com/repos/brianrob/perfview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianrob/perfview/merges","archive_url":"https://api.github.com/repos/brianrob/perfview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianrob/perfview/downloads","issues_url":"https://api.github.com/repos/brianrob/perfview/issues{/number}","pulls_url":"https://api.github.com/repos/brianrob/perfview/pulls{/number}","milestones_url":"https://api.github.com/repos/brianrob/perfview/milestones{/number}","notifications_url":"https://api.github.com/repos/brianrob/perfview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianrob/perfview/labels{/name}","releases_url":"https://api.github.com/repos/brianrob/perfview/releases{/id}","deployments_url":"https://api.github.com/repos/brianrob/perfview/deployments","created_at":"2018-01-30T16:12:05Z","updated_at":"2018-01-30T16:12:11Z","pushed_at":"2018-03-12T18:37:51Z","git_url":"git://github.com/brianrob/perfview.git","ssh_url":"git@github.com:brianrob/perfview.git","clone_url":"https://github.com/brianrob/perfview.git","svn_url":"https://github.com/brianrob/perfview","homepage":"http://channel9.msdn.com/Series/PerfView-Tutorial","size":198518,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"e4c066c4a32a49d3a3ce9f1de2eb8e26a4b17791","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":33010673,"name":"perfview","full_name":"Microsoft/perfview","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/perfview","description":"PerfView is a CPU and memory performance-analysis tool","fork":false,"url":"https://api.github.com/repos/Microsoft/perfview","forks_url":"https://api.github.com/repos/Microsoft/perfview/forks","keys_url":"https://api.github.com/repos/Microsoft/perfview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/perfview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/perfview/teams","hooks_url":"https://api.github.com/repos/Microsoft/perfview/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/perfview/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/perfview/events","assignees_url":"https://api.github.com/repos/Microsoft/perfview/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/perfview/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/perfview/tags","blobs_url":"https://api.github.com/repos/Microsoft/perfview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/perfview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/perfview/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/perfview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/perfview/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/perfview/languages","stargazers_url":"https://api.github.com/repos/Microsoft/perfview/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/perfview/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/perfview/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/perfview/subscription","commits_url":"https://api.github.com/repos/Microsoft/perfview/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/perfview/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/perfview/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/perfview/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/perfview/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/perfview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/perfview/merges","archive_url":"https://api.github.com/repos/Microsoft/perfview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/perfview/downloads","issues_url":"https://api.github.com/repos/Microsoft/perfview/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/perfview/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/perfview/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/perfview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/perfview/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/perfview/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/perfview/deployments","created_at":"2015-03-27T21:48:45Z","updated_at":"2018-03-12T23:23:53Z","pushed_at":"2018-03-13T16:43:06Z","git_url":"git://github.com/Microsoft/perfview.git","ssh_url":"git@github.com:Microsoft/perfview.git","clone_url":"https://github.com/Microsoft/perfview.git","svn_url":"https://github.com/Microsoft/perfview","homepage":"http://channel9.msdn.com/Series/PerfView-Tutorial","size":198530,"stargazers_count":850,"watchers_count":850,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":171,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":171,"open_issues":106,"watchers":850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/perfview/pulls/597"},"html":{"href":"https://github.com/Microsoft/perfview/pull/597"},"issue":{"href":"https://api.github.com/repos/Microsoft/perfview/issues/597"},"comments":{"href":"https://api.github.com/repos/Microsoft/perfview/issues/597/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/perfview/pulls/597/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/perfview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/perfview/pulls/597/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/perfview/statuses/26fdca6a3a2c05500b80f6ee55b472074839b52f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vancem"}}