{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/18841","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/18841/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/18841/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/18841/events","html_url":"https://github.com/openshift/origin/pull/18841","id":302416382,"number":18841,"title":"Improve NGINX-based router","user":{"login":"pleshakov","id":2199726,"avatar_url":"https://avatars1.githubusercontent.com/u/2199726?v=4","gravatar_id":"","url":"https://api.github.com/users/pleshakov","html_url":"https://github.com/pleshakov","followers_url":"https://api.github.com/users/pleshakov/followers","following_url":"https://api.github.com/users/pleshakov/following{/other_user}","gists_url":"https://api.github.com/users/pleshakov/gists{/gist_id}","starred_url":"https://api.github.com/users/pleshakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleshakov/subscriptions","organizations_url":"https://api.github.com/users/pleshakov/orgs","repos_url":"https://api.github.com/users/pleshakov/repos","events_url":"https://api.github.com/users/pleshakov/events{/privacy}","received_events_url":"https://api.github.com/users/pleshakov/received_events","type":"User","site_admin":false},"labels":[{"id":223051294,"url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":640548612,"url":"https://api.github.com/repos/openshift/origin/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"ramr","id":928868,"avatar_url":"https://avatars1.githubusercontent.com/u/928868?v=4","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},"assignees":[{"login":"ramr","id":928868,"avatar_url":"https://avatars1.githubusercontent.com/u/928868?v=4","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},{"login":"rajatchopra","id":982221,"avatar_url":"https://avatars2.githubusercontent.com/u/982221?v=4","gravatar_id":"","url":"https://api.github.com/users/rajatchopra","html_url":"https://github.com/rajatchopra","followers_url":"https://api.github.com/users/rajatchopra/followers","following_url":"https://api.github.com/users/rajatchopra/following{/other_user}","gists_url":"https://api.github.com/users/rajatchopra/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatchopra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatchopra/subscriptions","organizations_url":"https://api.github.com/users/rajatchopra/orgs","repos_url":"https://api.github.com/users/rajatchopra/repos","events_url":"https://api.github.com/users/rajatchopra/events{/privacy}","received_events_url":"https://api.github.com/users/rajatchopra/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-03-05T18:47:18Z","updated_at":"2018-04-26T13:25:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/18841","html_url":"https://github.com/openshift/origin/pull/18841","diff_url":"https://github.com/openshift/origin/pull/18841.diff","patch_url":"https://github.com/openshift/origin/pull/18841.patch"},"body":"This PR brings the following changes to the NGINX-based router:\r\n\r\nMisc imrovements:\r\n- [x] Use the latest (1.13.8) version of NGINX\r\n- [x] Create an HTML error page based on `error-page-503.http` file\r\n- [x] Handle configuration reload failures\r\n- [x] Harden NGINX configuration\r\n\r\nImplemented features:\r\n- [x] Edge termination\r\n- [x] Passthrough termination\r\n- [x] Re-encryption\r\n- [x] Alternate backends and weights\r\n- [x] Wildcard Subdomain policy\r\n- [x] The default server (handles HTTP/HTTPS requests for non-existing routes)\r\n- [x] Pass-based Routing\r\n- [x] Websocket\r\n- [x] Router Environment Variables\r\n- [x] Route-specific Annotations, similar to HAProxy router\r\n\r\nDocs:\r\n- [ ] how to build, run and test NGINX Router\r\n\r\nNote, to run the NGINX Plus Router, assuming you have built `openshift/nginx-router` image, you can use the following commands:\r\n```\r\n$ oc delete dc router # remove the default HAProxy router\r\n$ oc adm router nginx-router --images=openshift/nginx-router\r\n$ oc set env dc/nginx-router ROUTER_METRICS_TYPE=\"\"\r\n```"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/384639828","html_url":"https://github.com/openshift/origin/pull/18841#issuecomment-384639828","issue_url":"https://api.github.com/repos/openshift/origin/issues/18841","id":384639828,"user":{"login":"openshift-ci-robot","id":30189103,"avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T13:25:30Z","updated_at":"2018-04-26T13:25:30Z","author_association":"NONE","body":"@pleshakov: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/openshift-jenkins/extended_conformance_install | a4fa7e63412afbef846ab828b61d32b446ea78ce | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18841/test_pull_request_origin_extended_conformance_install/10857/) | `/test extended_conformance_install`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/18841). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/pleshakov). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/origin/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}