{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/29043","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/29043/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/29043/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/29043/events","html_url":"https://github.com/symfony/symfony/pull/29043","id":376036191,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzQ0MTM4","number":29043,"title":"Update ValidationListener.php","user":{"login":"DonCallisto","id":7060632,"node_id":"MDQ6VXNlcjcwNjA2MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/7060632?v=4","gravatar_id":"","url":"https://api.github.com/users/DonCallisto","html_url":"https://github.com/DonCallisto","followers_url":"https://api.github.com/users/DonCallisto/followers","following_url":"https://api.github.com/users/DonCallisto/following{/other_user}","gists_url":"https://api.github.com/users/DonCallisto/gists{/gist_id}","starred_url":"https://api.github.com/users/DonCallisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonCallisto/subscriptions","organizations_url":"https://api.github.com/users/DonCallisto/orgs","repos_url":"https://api.github.com/users/DonCallisto/repos","events_url":"https://api.github.com/users/DonCallisto/events{/privacy}","received_events_url":"https://api.github.com/users/DonCallisto/received_events","type":"User","site_admin":false},"labels":[{"id":100079,"node_id":"MDU6TGFiZWwxMDAwNzk=","url":"https://api.github.com/repos/symfony/symfony/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":99594,"node_id":"MDU6TGFiZWw5OTU5NA==","url":"https://api.github.com/repos/symfony/symfony/labels/Form","name":"Form","color":"DDDDDD","default":false},{"id":237550465,"node_id":"MDU6TGFiZWwyMzc1NTA0NjU=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Reviewed","name":"Status: Reviewed","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/10","html_url":"https://github.com/symfony/symfony/milestone/10","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/10/labels","id":2117464,"node_id":"MDk6TWlsZXN0b25lMjExNzQ2NA==","number":10,"title":"3.4","description":"https://symfony.com/roadmap?version=3.4#checker","creator":{"login":"javiereguiluz","id":73419,"node_id":"MDQ6VXNlcjczNDE5","avatar_url":"https://avatars3.githubusercontent.com/u/73419?v=4","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":1011,"state":"open","created_at":"2016-11-06T20:24:23Z","updated_at":"2018-12-11T15:29:41Z","due_on":"2020-11-30T08:00:00Z","closed_at":null},"comments":0,"created_at":"2018-10-31T15:57:22Z","updated_at":"2018-12-12T06:48:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/29043","html_url":"https://github.com/symfony/symfony/pull/29043","diff_url":"https://github.com/symfony/symfony/pull/29043.diff","patch_url":"https://github.com/symfony/symfony/pull/29043.patch"},"body":"This comment was misleading.\r\nIt's true that no groups (ie.: `Default`) are setted into validation process but it's not clear from the comment.\r\nI suppose that is better to be more explicit about this process.\r\nBTW I'm still not sure if `FormValidator` reference is necessary as we can change it and we should remember to update this comment and this does not seems to fit.\r\nWDYT, is better to leave `FormValidator` out of this comment?\r\n\r\nFor reference: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Extension/Validator/Constraints/FormValidator.php#L46-L92\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 3.4 (careful when merging)\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no     <!-- see https://symfony.com/bc -->\r\n| Deprecations? | no\r\n| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->\r\n| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->\r\n| License       | MIT\r\n| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->\r\n\r\n<!--\r\nWrite a short README entry for your feature/bugfix here (replace this comment block.)\r\nThis will help people understand your PR and can be used as a start of the Doc PR.\r\nAdditionally:\r\n - Bug fixes must be submitted against the lowest branch where they apply\r\n   (lowest branches are regularly merged to upper ones so they get the fixes too).\r\n - Features and deprecations must be submitted against the master branch.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/446481012","html_url":"https://github.com/symfony/symfony/pull/29043#issuecomment-446481012","issue_url":"https://api.github.com/repos/symfony/symfony/issues/29043","id":446481012,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjQ4MTAxMg==","user":{"login":"fabpot","id":47313,"node_id":"MDQ6VXNlcjQ3MzEz","avatar_url":"https://avatars3.githubusercontent.com/u/47313?v=4","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T06:48:01Z","updated_at":"2018-12-12T06:48:01Z","author_association":"MEMBER","body":"Thank you @DonCallisto."}}
{"actor":{"display_login":"fabpot"}}