{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/206346012","pull_request_review_id":141745244,"id":206346012,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjM0NjAxMg==","diff_hunk":"@@ -8420,6 +8420,8 @@ with pkgs;\n \n   pyprof2calltree = pythonPackages.callPackage ../development/tools/profiling/pyprof2calltree { };\n \n+  pre-commit = pythonPackages.callPackage ../development/tools/pre-commit { };","path":"pkgs/top-level/all-packages.nix","position":4,"original_position":4,"commit_id":"0fe940777ddd1cb3d752aef1b04855ec473bbc5a","original_commit_id":"0fe940777ddd1cb3d752aef1b04855ec473bbc5a","user":{"login":"dotlambda","id":6806011,"node_id":"MDQ6VXNlcjY4MDYwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"body":"Also, since pre-commit seems to support Python 3, please use that if possible.","created_at":"2018-07-30T22:45:01Z","updated_at":"2018-07-30T22:45:01Z","html_url":"https://github.com/NixOS/nixpkgs/pull/44239#discussion_r206346012","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44239","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/206346012"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44239#discussion_r206346012"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44239"}},"in_reply_to_id":206332095},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44239","id":204893500,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODkzNTAw","html_url":"https://github.com/NixOS/nixpkgs/pull/44239","diff_url":"https://github.com/NixOS/nixpkgs/pull/44239.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44239.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44239","number":44239,"state":"open","locked":false,"title":"Init pre-commit","user":{"login":"borisbabic","id":1743184,"node_id":"MDQ6VXNlcjE3NDMxODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1743184?v=4","gravatar_id":"","url":"https://api.github.com/users/borisbabic","html_url":"https://github.com/borisbabic","followers_url":"https://api.github.com/users/borisbabic/followers","following_url":"https://api.github.com/users/borisbabic/following{/other_user}","gists_url":"https://api.github.com/users/borisbabic/gists{/gist_id}","starred_url":"https://api.github.com/users/borisbabic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisbabic/subscriptions","organizations_url":"https://api.github.com/users/borisbabic/orgs","repos_url":"https://api.github.com/users/borisbabic/repos","events_url":"https://api.github.com/users/borisbabic/events{/privacy}","received_events_url":"https://api.github.com/users/borisbabic/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nAdd [pre-commit](https://pre-commit.com/) - a useful tool for managing and sharing git commit hooks.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-07-30T18:39:13Z","updated_at":"2018-07-30T22:45:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f3facd61a64d997af47b567e454209d881e57ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":9820195,"node_id":"MDU6TGFiZWw5ODIwMTk1","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20python","name":"6.topic: python","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44239/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44239/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44239/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/0fe940777ddd1cb3d752aef1b04855ec473bbc5a","head":{"label":"borisbabic:feature/init-pre-commit","ref":"feature/init-pre-commit","sha":"0fe940777ddd1cb3d752aef1b04855ec473bbc5a","user":{"login":"borisbabic","id":1743184,"node_id":"MDQ6VXNlcjE3NDMxODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1743184?v=4","gravatar_id":"","url":"https://api.github.com/users/borisbabic","html_url":"https://github.com/borisbabic","followers_url":"https://api.github.com/users/borisbabic/followers","following_url":"https://api.github.com/users/borisbabic/following{/other_user}","gists_url":"https://api.github.com/users/borisbabic/gists{/gist_id}","starred_url":"https://api.github.com/users/borisbabic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisbabic/subscriptions","organizations_url":"https://api.github.com/users/borisbabic/orgs","repos_url":"https://api.github.com/users/borisbabic/repos","events_url":"https://api.github.com/users/borisbabic/events{/privacy}","received_events_url":"https://api.github.com/users/borisbabic/received_events","type":"User","site_admin":false},"repo":{"id":141564522,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1NjQ1MjI=","name":"nixpkgs","full_name":"borisbabic/nixpkgs","owner":{"login":"borisbabic","id":1743184,"node_id":"MDQ6VXNlcjE3NDMxODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1743184?v=4","gravatar_id":"","url":"https://api.github.com/users/borisbabic","html_url":"https://github.com/borisbabic","followers_url":"https://api.github.com/users/borisbabic/followers","following_url":"https://api.github.com/users/borisbabic/following{/other_user}","gists_url":"https://api.github.com/users/borisbabic/gists{/gist_id}","starred_url":"https://api.github.com/users/borisbabic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisbabic/subscriptions","organizations_url":"https://api.github.com/users/borisbabic/orgs","repos_url":"https://api.github.com/users/borisbabic/repos","events_url":"https://api.github.com/users/borisbabic/events{/privacy}","received_events_url":"https://api.github.com/users/borisbabic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/borisbabic/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/borisbabic/nixpkgs","forks_url":"https://api.github.com/repos/borisbabic/nixpkgs/forks","keys_url":"https://api.github.com/repos/borisbabic/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borisbabic/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borisbabic/nixpkgs/teams","hooks_url":"https://api.github.com/repos/borisbabic/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/borisbabic/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/borisbabic/nixpkgs/events","assignees_url":"https://api.github.com/repos/borisbabic/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/borisbabic/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/borisbabic/nixpkgs/tags","blobs_url":"https://api.github.com/repos/borisbabic/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borisbabic/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borisbabic/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/borisbabic/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borisbabic/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/borisbabic/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/borisbabic/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/borisbabic/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/borisbabic/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/borisbabic/nixpkgs/subscription","commits_url":"https://api.github.com/repos/borisbabic/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/borisbabic/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/borisbabic/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/borisbabic/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/borisbabic/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/borisbabic/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borisbabic/nixpkgs/merges","archive_url":"https://api.github.com/repos/borisbabic/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borisbabic/nixpkgs/downloads","issues_url":"https://api.github.com/repos/borisbabic/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/borisbabic/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/borisbabic/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/borisbabic/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borisbabic/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/borisbabic/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/borisbabic/nixpkgs/deployments","created_at":"2018-07-19T10:34:47Z","updated_at":"2018-07-19T10:35:22Z","pushed_at":"2018-07-30T21:33:43Z","git_url":"git://github.com/borisbabic/nixpkgs.git","ssh_url":"git@github.com:borisbabic/nixpkgs.git","clone_url":"https://github.com/borisbabic/nixpkgs.git","svn_url":"https://github.com/borisbabic/nixpkgs","homepage":null,"size":818216,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"7474362af274ccf1ff5b01457bddfcfb94163a68","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-07-30T22:33:56Z","pushed_at":"2018-07-30T22:30:21Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":828709,"stargazers_count":2610,"watchers_count":2610,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2903,"mirror_url":null,"archived":false,"open_issues_count":3067,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2903,"open_issues":3067,"watchers":2610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44239"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44239"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44239"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44239/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44239/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44239/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/0fe940777ddd1cb3d752aef1b04855ec473bbc5a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dotlambda"}}