{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kops/issues/6091","repository_url":"https://api.github.com/repos/kubernetes/kops","labels_url":"https://api.github.com/repos/kubernetes/kops/issues/6091/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/6091/comments","events_url":"https://api.github.com/repos/kubernetes/kops/issues/6091/events","html_url":"https://github.com/kubernetes/kops/pull/6091","id":381833346,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzEwMDI2","number":6091,"title":"feat(cmd/kops/create_cluster): default to kubelet.anonymousAuth false on k8s versions >=1.10","user":{"login":"jaredallard","id":2391349,"node_id":"MDQ6VXNlcjIzOTEzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/2391349?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredallard","html_url":"https://github.com/jaredallard","followers_url":"https://api.github.com/users/jaredallard/followers","following_url":"https://api.github.com/users/jaredallard/following{/other_user}","gists_url":"https://api.github.com/users/jaredallard/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredallard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredallard/subscriptions","organizations_url":"https://api.github.com/users/jaredallard/orgs","repos_url":"https://api.github.com/users/jaredallard/repos","events_url":"https://api.github.com/users/jaredallard/events{/privacy}","received_events_url":"https://api.github.com/users/jaredallard/received_events","type":"User","site_admin":false},"labels":[{"id":655705079,"node_id":"MDU6TGFiZWw2NTU3MDUwNzk=","url":"https://api.github.com/repos/kubernetes/kops/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":485059302,"node_id":"MDU6TGFiZWw0ODUwNTkzMDI=","url":"https://api.github.com/repos/kubernetes/kops/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":493914979,"node_id":"MDU6TGFiZWw0OTM5MTQ5Nzk=","url":"https://api.github.com/repos/kubernetes/kops/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1086778261,"node_id":"MDU6TGFiZWwxMDg2Nzc4MjYx","url":"https://api.github.com/repos/kubernetes/kops/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":675982814,"node_id":"MDU6TGFiZWw2NzU5ODI4MTQ=","url":"https://api.github.com/repos/kubernetes/kops/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"closed","locked":false,"assignee":{"login":"justinsb","id":100893,"node_id":"MDQ6VXNlcjEwMDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinsb","id":100893,"node_id":"MDQ6VXNlcjEwMDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kops/milestones/21","html_url":"https://github.com/kubernetes/kops/milestone/21","labels_url":"https://api.github.com/repos/kubernetes/kops/milestones/21/labels","id":3442381,"node_id":"MDk6TWlsZXN0b25lMzQ0MjM4MQ==","number":21,"title":"1.12","description":null,"creator":{"login":"justinsb","id":100893,"node_id":"MDQ6VXNlcjEwMDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":7,"state":"open","created_at":"2018-06-21T15:06:49Z","updated_at":"2018-12-07T15:30:13Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2018-11-17T06:17:27Z","updated_at":"2018-12-08T06:13:29Z","closed_at":"2018-11-26T18:26:14Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/6091","html_url":"https://github.com/kubernetes/kops/pull/6091","diff_url":"https://github.com/kubernetes/kops/pull/6091.diff","patch_url":"https://github.com/kubernetes/kops/pull/6091.patch"},"body":"**What this PR does**: Sets `kubelet.anonymousAuth` to `false` by default on new cluster creation\r\n\r\n**Why**: It's _extremely_ dangerous to have this be undefined by default (which defaults to `true`) _and_ not have it in bold letters on the README.md that it's off by default. It's very easy to overlook this as a \"newbie\" or somebody who skims through stuff (not saying that's OK, but people will be that way regardless). So, this introduces setting it to `false` by default on new cluster creation.\r\n\r\n**Notes**: I'm sure this probably isn't the best place to do this, but it seemed like it probably was. I could also see it being moved to `pkg/apis/kops/apiserver.go` as well. "},"comment":{"url":"https://api.github.com/repos/kubernetes/kops/issues/comments/445434928","html_url":"https://github.com/kubernetes/kops/pull/6091#issuecomment-445434928","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/6091","id":445434928,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTQzNDkyOA==","user":{"login":"jaredallard","id":2391349,"node_id":"MDQ6VXNlcjIzOTEzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/2391349?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredallard","html_url":"https://github.com/jaredallard","followers_url":"https://api.github.com/users/jaredallard/followers","following_url":"https://api.github.com/users/jaredallard/following{/other_user}","gists_url":"https://api.github.com/users/jaredallard/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredallard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredallard/subscriptions","organizations_url":"https://api.github.com/users/jaredallard/orgs","repos_url":"https://api.github.com/users/jaredallard/repos","events_url":"https://api.github.com/users/jaredallard/events{/privacy}","received_events_url":"https://api.github.com/users/jaredallard/received_events","type":"User","site_admin":false},"created_at":"2018-12-08T06:13:29Z","updated_at":"2018-12-08T06:13:29Z","author_association":"CONTRIBUTOR","body":"@tsuna :tada: Glad it was helpful! That's a really good point, I don't think that is actually 100% true that the masters need to be rolled out first when changing that parameter. Regardless, it's usually (at least in my mind) best practice to roll the masters first when doing any changes.\r\n\r\nThis could probably be refined to state that in a clearer way so that nobody accidentally runs into some sort of issues if my deductions are wrong. Thoughts @justinsb?"}}
{"actor":{"display_login":"jaredallard"}}