{"action":"created","issue":{"url":"https://api.github.com/repos/dgraph-io/badger/issues/447","repository_url":"https://api.github.com/repos/dgraph-io/badger","labels_url":"https://api.github.com/repos/dgraph-io/badger/issues/447/labels{/name}","comments_url":"https://api.github.com/repos/dgraph-io/badger/issues/447/comments","events_url":"https://api.github.com/repos/dgraph-io/badger/issues/447/events","html_url":"https://github.com/dgraph-io/badger/pull/447","id":310347947,"number":447,"title":"[WIP] Export block size option","user":{"login":"schomatis","id":10407385,"avatar_url":"https://avatars0.githubusercontent.com/u/10407385?v=4","gravatar_id":"","url":"https://api.github.com/users/schomatis","html_url":"https://github.com/schomatis","followers_url":"https://api.github.com/users/schomatis/followers","following_url":"https://api.github.com/users/schomatis/following{/other_user}","gists_url":"https://api.github.com/users/schomatis/gists{/gist_id}","starred_url":"https://api.github.com/users/schomatis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schomatis/subscriptions","organizations_url":"https://api.github.com/users/schomatis/orgs","repos_url":"https://api.github.com/users/schomatis/repos","events_url":"https://api.github.com/users/schomatis/events{/privacy}","received_events_url":"https://api.github.com/users/schomatis/received_events","type":"User","site_admin":false},"labels":[{"id":927166721,"url":"https://api.github.com/repos/dgraph-io/badger/labels/needs-work","name":"needs-work","color":"0923c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-04-01T19:35:17Z","updated_at":"2018-05-09T23:40:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dgraph-io/badger/pulls/447","html_url":"https://github.com/dgraph-io/badger/pull/447","diff_url":"https://github.com/dgraph-io/badger/pull/447.diff","patch_url":"https://github.com/dgraph-io/badger/pull/447.patch"},"body":"This is a work in progress, do not merge. It addresses issue #446.\r\n\r\nIt exports the number of entries per block (block size) configuration to Badger's options. There was no direct way for the table builder to reach the database general options so a temporal solution was used (passing the block size as a parameter and setting it with `SetBlockSize`).\r\n\r\nThe added test is a PoC benchmark to measure the performance impact of different block sizes.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dgraph-io/badger/447)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/dgraph-io/badger/issues/comments/387907051","html_url":"https://github.com/dgraph-io/badger/pull/447#issuecomment-387907051","issue_url":"https://api.github.com/repos/dgraph-io/badger/issues/447","id":387907051,"user":{"login":"manishrjain","id":1782324,"avatar_url":"https://avatars1.githubusercontent.com/u/1782324?v=4","gravatar_id":"","url":"https://api.github.com/users/manishrjain","html_url":"https://github.com/manishrjain","followers_url":"https://api.github.com/users/manishrjain/followers","following_url":"https://api.github.com/users/manishrjain/following{/other_user}","gists_url":"https://api.github.com/users/manishrjain/gists{/gist_id}","starred_url":"https://api.github.com/users/manishrjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishrjain/subscriptions","organizations_url":"https://api.github.com/users/manishrjain/orgs","repos_url":"https://api.github.com/users/manishrjain/repos","events_url":"https://api.github.com/users/manishrjain/events{/privacy}","received_events_url":"https://api.github.com/users/manishrjain/received_events","type":"User","site_admin":false},"created_at":"2018-05-09T23:40:45Z","updated_at":"2018-05-09T23:40:45Z","author_association":"OWNER","body":"> The first objective here is to expose the block size\r\n\r\nOk. I got that. That makes sense.\r\n\r\n> The second objective is to change the linear search of the block to a logarithmic one\r\n\r\nHow would that be achieved, without somehow storing the list of offsets in memory? My main concern is here really."}}
{"actor":{"display_login":"manishrjain"}}