{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/22901","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/22901/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/22901/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/22901/events","html_url":"https://github.com/elastic/kibana/pull/22901","id":358784879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDM2NjU3","number":22901,"title":"Fix a few dashboard flaky tests","user":{"login":"Stacey-Gammon","id":16563603,"node_id":"MDQ6VXNlcjE2NTYzNjAz","avatar_url":"https://avatars3.githubusercontent.com/u/16563603?v=4","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-10T20:37:26Z","updated_at":"2018-09-11T15:53:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/22901","html_url":"https://github.com/elastic/kibana/pull/22901","diff_url":"https://github.com/elastic/kibana/pull/22901.diff","patch_url":"https://github.com/elastic/kibana/pull/22901.patch"},"body":"After discover the \"slow 3g\" option in Chrome, I was able to reproduce many flaky dashboard issues.\r\n\r\n- `clickNewDashboard` checked for an `add dashboard` button, if it didn't exist, it tried until failure to find the button on the prompt.  Problem is sometimes it was slow to render the page, so dashboards existed, and the `add dashboard` button just didn't render yet.  But once it failed to find it, it assumed there were no dashboards and only waited to find the \"add your first dashboard\" prompt button.\r\n\r\n- similarly, `gotoDashboardLandingPage` first checked for the existence of an item to determine where it was, but if that came back incorrectly (because the page was slow to load), it would fail. Wrapping both checks in a retry should fix this.\r\n\r\n- The second `click save` button happened too quickly, this waits for the button to be enabled before clicking.  Clicking the button when disabled doesn't throw an error.  Rather than fix for this specific test, I pushed the check for a disabled button into the find service so any other clicks on an element will wait for the button to be enabled, or will throw an error as unsuccessful.\r\n\r\n- Added in a check to wait for the EuiTableLoading indicator to be removed after searching for a dashboard on the listing page.  If it's in the process of loading, some clicks can miss their elements. \r\n\r\nFixes https://github.com/elastic/kibana/issues/22409 ... probably many more! 🎉  "},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/420323748","html_url":"https://github.com/elastic/kibana/pull/22901#issuecomment-420323748","issue_url":"https://api.github.com/repos/elastic/kibana/issues/22901","id":420323748,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDMyMzc0OA==","user":{"login":"Stacey-Gammon","id":16563603,"node_id":"MDQ6VXNlcjE2NTYzNjAz","avatar_url":"https://avatars3.githubusercontent.com/u/16563603?v=4","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T15:53:51Z","updated_at":"2018-09-11T15:53:51Z","author_association":"CONTRIBUTOR","body":"retest"}}
{"actor":{"display_login":"Stacey-Gammon"}}