{"action":"created","issue":{"url":"https://api.github.com/repos/sympy/sympy/issues/14038","repository_url":"https://api.github.com/repos/sympy/sympy","labels_url":"https://api.github.com/repos/sympy/sympy/issues/14038/labels{/name}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/14038/comments","events_url":"https://api.github.com/repos/sympy/sympy/issues/14038/events","html_url":"https://github.com/sympy/sympy/pull/14038","id":292644340,"number":14038,"title":"If the term of a Product is Add, just factor it","user":{"login":"normalhuman","id":13082030,"avatar_url":"https://avatars1.githubusercontent.com/u/13082030?v=4","gravatar_id":"","url":"https://api.github.com/users/normalhuman","html_url":"https://github.com/normalhuman","followers_url":"https://api.github.com/users/normalhuman/followers","following_url":"https://api.github.com/users/normalhuman/following{/other_user}","gists_url":"https://api.github.com/users/normalhuman/gists{/gist_id}","starred_url":"https://api.github.com/users/normalhuman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normalhuman/subscriptions","organizations_url":"https://api.github.com/users/normalhuman/orgs","repos_url":"https://api.github.com/users/normalhuman/repos","events_url":"https://api.github.com/users/normalhuman/events{/privacy}","received_events_url":"https://api.github.com/users/normalhuman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-01-30T03:49:58Z","updated_at":"2018-02-04T18:22:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/14038","html_url":"https://github.com/sympy/sympy/pull/14038","diff_url":"https://github.com/sympy/sympy/pull/14038.diff","patch_url":"https://github.com/sympy/sympy/pull/14038.patch"},"body":"#### References to other Issues or PRs\r\n\r\nFixes #14036\r\n\r\n#### Brief description of what is fixed or changed\r\n\r\nThe product-evaluating code handling the case `term.is_Add` was trying questionable things, such as rewriting as sum of logarithms (only possible with positive terms), or computing the product of denominators and then deciding that the rewrite didn't work if the result was is_Number (when it fact this could mean the product of computed).\r\n\r\nRealistically, all we can do with an Add in a product is to factor it, and let the code for `term.is_Mul` do the rest. If it doesn't factor, give up. This is what is done now."},"comment":{"url":"https://api.github.com/repos/sympy/sympy/issues/comments/362927693","html_url":"https://github.com/sympy/sympy/pull/14038#issuecomment-362927693","issue_url":"https://api.github.com/repos/sympy/sympy/issues/14038","id":362927693,"user":{"login":"normalhuman","id":13082030,"avatar_url":"https://avatars1.githubusercontent.com/u/13082030?v=4","gravatar_id":"","url":"https://api.github.com/users/normalhuman","html_url":"https://github.com/normalhuman","followers_url":"https://api.github.com/users/normalhuman/followers","following_url":"https://api.github.com/users/normalhuman/following{/other_user}","gists_url":"https://api.github.com/users/normalhuman/gists{/gist_id}","starred_url":"https://api.github.com/users/normalhuman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normalhuman/subscriptions","organizations_url":"https://api.github.com/users/normalhuman/orgs","repos_url":"https://api.github.com/users/normalhuman/repos","events_url":"https://api.github.com/users/normalhuman/events{/privacy}","received_events_url":"https://api.github.com/users/normalhuman/received_events","type":"User","site_admin":false},"created_at":"2018-02-04T18:22:00Z","updated_at":"2018-02-04T18:22:00Z","author_association":"MEMBER","body":"@smichr Can I take your comment as positive review of this PR?"}}
{"actor":{"display_login":"normalhuman"}}