{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/169315550","pull_request_review_id":97820195,"id":169315550,"diff_hunk":"@@ -249,6 +250,29 @@ def map_objs(self, src_obj, dest_objs, **attrs_for_template):\n         dest_obj in help_utils.convert_to_list(dest_objs)]\n \n \n+class AssessmentsFromTemplateService(HelpRestService):\n+  \"\"\"Service for creating asessments from templates\"\"\"\n+  def __init__(self):\n+    super(AssessmentsFromTemplateService, self).__init__(url.ASSESSMENTS)\n+\n+  def create_assessment_from_template(self, audit, template,","path":"test/selenium/src/lib/service/rest_service.py","position":null,"original_position":20,"commit_id":"0549d7dce6a3799af299ebd851b6c79c448812ed","original_commit_id":"404b0fd8dcc5b37b81b882565f484d806fb39a6e","user":{"login":"abotalov","id":1497867,"avatar_url":"https://avatars1.githubusercontent.com/u/1497867?v=4","gravatar_id":"","url":"https://api.github.com/users/abotalov","html_url":"https://github.com/abotalov","followers_url":"https://api.github.com/users/abotalov/followers","following_url":"https://api.github.com/users/abotalov/following{/other_user}","gists_url":"https://api.github.com/users/abotalov/gists{/gist_id}","starred_url":"https://api.github.com/users/abotalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abotalov/subscriptions","organizations_url":"https://api.github.com/users/abotalov/orgs","repos_url":"https://api.github.com/users/abotalov/repos","events_url":"https://api.github.com/users/abotalov/events{/privacy}","received_events_url":"https://api.github.com/users/abotalov/received_events","type":"User","site_admin":false},"body":"Changed to `create_assessments`. `create_assessments_from_template` is considered too long name.","created_at":"2018-02-20T13:24:00Z","updated_at":"2018-02-20T13:24:00Z","html_url":"https://github.com/google/ggrc-core/pull/7335#discussion_r169315550","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/7335","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/169315550"},"html":{"href":"https://github.com/google/ggrc-core/pull/7335#discussion_r169315550"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/7335"}},"in_reply_to_id":169120755},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/7335","id":169665121,"html_url":"https://github.com/google/ggrc-core/pull/7335","diff_url":"https://github.com/google/ggrc-core/pull/7335.diff","patch_url":"https://github.com/google/ggrc-core/pull/7335.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/7335","number":7335,"state":"open","locked":false,"title":"QUICK-FIX Test filtering of assessments based on assessment template with LCA","user":{"login":"abotalov","id":1497867,"avatar_url":"https://avatars1.githubusercontent.com/u/1497867?v=4","gravatar_id":"","url":"https://api.github.com/users/abotalov","html_url":"https://github.com/abotalov","followers_url":"https://api.github.com/users/abotalov/followers","following_url":"https://api.github.com/users/abotalov/following{/other_user}","gists_url":"https://api.github.com/users/abotalov/gists{/gist_id}","starred_url":"https://api.github.com/users/abotalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abotalov/subscriptions","organizations_url":"https://api.github.com/users/abotalov/orgs","repos_url":"https://api.github.com/users/abotalov/repos","events_url":"https://api.github.com/users/abotalov/events{/privacy}","received_events_url":"https://api.github.com/users/abotalov/received_events","type":"User","site_admin":false},"body":"# PR description\r\n\r\n* Add a test to filter assessments based on the template with LCA\r\n* \"generate_ca_value\" function was modified because \"modified_by\" is not set for LCA\r\n\r\n# Sanity checklist\r\n\r\n- [ ] I have clicked through the app to make sure my changes work and not break the app.\r\n- [ ] I have applied the correct milestone and labels.\r\n- [x] My changes fix the issue described in the description (and do nothing else). 🤞\r\n- [ ] My changes are covered by tests.\r\n- [ ] My changes follow our [performance guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/performance.rst).\r\n- [x] My changes follow our [js](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/javascript.rst) and/or [python](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/python.rst) guidelines.\r\n- [x] My commits follow our [commit guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/how_to_write_a_commit_message.rst).\r\n\r\n<!-- If your PR includes a migration include the additional checklist items\r\n# Migration checklist\r\n- [ ] Migration passes all checks from our [PR review guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/reviewing_pull_requests.rst#reviewing-a-pr-containing-database-migration-scripts)\r\n-->\r\n\r\n# PR Review checklist\r\n\r\n- [x] The changes fix the issue and don't cause any apparent regressions.\r\n- [x] Labels and milestone are correctly set.\r\n- [x] The solution description matches the changes in the code.\r\n- [x] There is no apparent way to improve the performance & design of the new code.\r\n- [x] The pull request is opened against the correct base branch.\r\n- [ ] Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to \"QA - In Progress\".\r\n\r\n<!-- If your code is not finished yet can include a TODO check list\r\n# TODO\r\n\r\n- [ ] First item on the TODO\r\n-->\r\n","created_at":"2018-02-16T16:17:51Z","updated_at":"2018-02-20T13:24:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fafae7fa723f4488352933e02267f0252a8ecc3","assignee":{"login":"SergeyRabtsau","id":12732485,"avatar_url":"https://avatars1.githubusercontent.com/u/12732485?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyRabtsau","html_url":"https://github.com/SergeyRabtsau","followers_url":"https://api.github.com/users/SergeyRabtsau/followers","following_url":"https://api.github.com/users/SergeyRabtsau/following{/other_user}","gists_url":"https://api.github.com/users/SergeyRabtsau/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyRabtsau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyRabtsau/subscriptions","organizations_url":"https://api.github.com/users/SergeyRabtsau/orgs","repos_url":"https://api.github.com/users/SergeyRabtsau/repos","events_url":"https://api.github.com/users/SergeyRabtsau/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyRabtsau/received_events","type":"User","site_admin":false},"assignees":[{"login":"SergeyRabtsau","id":12732485,"avatar_url":"https://avatars1.githubusercontent.com/u/12732485?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyRabtsau","html_url":"https://github.com/SergeyRabtsau","followers_url":"https://api.github.com/users/SergeyRabtsau/followers","following_url":"https://api.github.com/users/SergeyRabtsau/following{/other_user}","gists_url":"https://api.github.com/users/SergeyRabtsau/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyRabtsau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyRabtsau/subscriptions","organizations_url":"https://api.github.com/users/SergeyRabtsau/orgs","repos_url":"https://api.github.com/users/SergeyRabtsau/repos","events_url":"https://api.github.com/users/SergeyRabtsau/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyRabtsau/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":653911749,"url":"https://api.github.com/repos/google/ggrc-core/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":86898803,"url":"https://api.github.com/repos/google/ggrc-core/labels/needs%20work","name":"needs work","color":"f9d0c4","default":false},{"id":378589735,"url":"https://api.github.com/repos/google/ggrc-core/labels/new%20contribution","name":"new contribution","color":"bfdadc","default":false}],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/77","html_url":"https://github.com/google/ggrc-core/milestone/77","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/77/labels","id":3110951,"number":77,"title":"1.5.0-Strawberry","description":null,"creator":{"login":"m-vitaly","id":24203972,"avatar_url":"https://avatars0.githubusercontent.com/u/24203972?v=4","gravatar_id":"","url":"https://api.github.com/users/m-vitaly","html_url":"https://github.com/m-vitaly","followers_url":"https://api.github.com/users/m-vitaly/followers","following_url":"https://api.github.com/users/m-vitaly/following{/other_user}","gists_url":"https://api.github.com/users/m-vitaly/gists{/gist_id}","starred_url":"https://api.github.com/users/m-vitaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-vitaly/subscriptions","organizations_url":"https://api.github.com/users/m-vitaly/orgs","repos_url":"https://api.github.com/users/m-vitaly/repos","events_url":"https://api.github.com/users/m-vitaly/events{/privacy}","received_events_url":"https://api.github.com/users/m-vitaly/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":15,"state":"open","created_at":"2018-02-13T11:29:36Z","updated_at":"2018-02-20T11:43:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/7335/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/7335/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/7335/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/0549d7dce6a3799af299ebd851b6c79c448812ed","head":{"label":"abotalov:test_filtering_assessments_with_lca","ref":"test_filtering_assessments_with_lca","sha":"0549d7dce6a3799af299ebd851b6c79c448812ed","user":{"login":"abotalov","id":1497867,"avatar_url":"https://avatars1.githubusercontent.com/u/1497867?v=4","gravatar_id":"","url":"https://api.github.com/users/abotalov","html_url":"https://github.com/abotalov","followers_url":"https://api.github.com/users/abotalov/followers","following_url":"https://api.github.com/users/abotalov/following{/other_user}","gists_url":"https://api.github.com/users/abotalov/gists{/gist_id}","starred_url":"https://api.github.com/users/abotalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abotalov/subscriptions","organizations_url":"https://api.github.com/users/abotalov/orgs","repos_url":"https://api.github.com/users/abotalov/repos","events_url":"https://api.github.com/users/abotalov/events{/privacy}","received_events_url":"https://api.github.com/users/abotalov/received_events","type":"User","site_admin":false},"repo":{"id":121769784,"name":"ggrc-core","full_name":"abotalov/ggrc-core","owner":{"login":"abotalov","id":1497867,"avatar_url":"https://avatars1.githubusercontent.com/u/1497867?v=4","gravatar_id":"","url":"https://api.github.com/users/abotalov","html_url":"https://github.com/abotalov","followers_url":"https://api.github.com/users/abotalov/followers","following_url":"https://api.github.com/users/abotalov/following{/other_user}","gists_url":"https://api.github.com/users/abotalov/gists{/gist_id}","starred_url":"https://api.github.com/users/abotalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abotalov/subscriptions","organizations_url":"https://api.github.com/users/abotalov/orgs","repos_url":"https://api.github.com/users/abotalov/repos","events_url":"https://api.github.com/users/abotalov/events{/privacy}","received_events_url":"https://api.github.com/users/abotalov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abotalov/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/abotalov/ggrc-core","forks_url":"https://api.github.com/repos/abotalov/ggrc-core/forks","keys_url":"https://api.github.com/repos/abotalov/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abotalov/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abotalov/ggrc-core/teams","hooks_url":"https://api.github.com/repos/abotalov/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/abotalov/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/abotalov/ggrc-core/events","assignees_url":"https://api.github.com/repos/abotalov/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/abotalov/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/abotalov/ggrc-core/tags","blobs_url":"https://api.github.com/repos/abotalov/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abotalov/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abotalov/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/abotalov/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abotalov/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/abotalov/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/abotalov/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/abotalov/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/abotalov/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/abotalov/ggrc-core/subscription","commits_url":"https://api.github.com/repos/abotalov/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/abotalov/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/abotalov/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/abotalov/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/abotalov/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/abotalov/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abotalov/ggrc-core/merges","archive_url":"https://api.github.com/repos/abotalov/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abotalov/ggrc-core/downloads","issues_url":"https://api.github.com/repos/abotalov/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/abotalov/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/abotalov/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/abotalov/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abotalov/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/abotalov/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/abotalov/ggrc-core/deployments","created_at":"2018-02-16T15:59:54Z","updated_at":"2018-02-16T16:00:02Z","pushed_at":"2018-02-20T13:19:51Z","git_url":"git://github.com/abotalov/ggrc-core.git","ssh_url":"git@github.com:abotalov/ggrc-core.git","clone_url":"https://github.com/abotalov/ggrc-core.git","svn_url":"https://github.com/abotalov/ggrc-core","homepage":null,"size":74363,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"google:dev","ref":"dev","sha":"25368a3b76a477f8c838c1dd4dd9a33fc017ae28","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2018-02-19T23:46:58Z","pushed_at":"2018-02-20T13:19:53Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":74434,"stargazers_count":257,"watchers_count":257,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":190,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":190,"open_issues":43,"watchers":257,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/7335"},"html":{"href":"https://github.com/google/ggrc-core/pull/7335"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/7335"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/7335/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/7335/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/7335/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/0549d7dce6a3799af299ebd851b6c79c448812ed"}},"author_association":"NONE"}}
{"actor":{"display_login":"abotalov"}}