{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/208398838","pull_request_review_id":144201273,"id":208398838,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODM5ODgzOA==","diff_hunk":"@@ -38,7 +38,15 @@ REGISTER_NO_GRADIENT_OP(\"NotEqual\");\n REGISTER_NO_GRADIENT_OP(\"LogicalAnd\");\n REGISTER_NO_GRADIENT_OP(\"LogicalOr\");\n REGISTER_NO_GRADIENT_OP(\"LogicalNot\");\n+// These are really zero (almost everywhere) gradients, but we return\n+// NoGradient() following the current python implementation.\n+// Additional discussion on this topic:\n+// https://github.com/tensorflow/tensorflow/issues/897\n+// https://github.com/tensorflow/tensorflow/issues/783\n REGISTER_NO_GRADIENT_OP(\"Floor\");\n+REGISTER_NO_GRADIENT_OP(\"Ceil\");","path":"tensorflow/cc/gradients/math_grad.cc","position":10,"original_position":10,"commit_id":"10a016a6028ae65a5d562284675dbdbd7cf2d619","original_commit_id":"10a016a6028ae65a5d562284675dbdbd7cf2d619","user":{"login":"drpngx","id":20959853,"node_id":"MDQ6VXNlcjIwOTU5ODUz","avatar_url":"https://avatars1.githubusercontent.com/u/20959853?v=4","gravatar_id":"","url":"https://api.github.com/users/drpngx","html_url":"https://github.com/drpngx","followers_url":"https://api.github.com/users/drpngx/followers","following_url":"https://api.github.com/users/drpngx/following{/other_user}","gists_url":"https://api.github.com/users/drpngx/gists{/gist_id}","starred_url":"https://api.github.com/users/drpngx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drpngx/subscriptions","organizations_url":"https://api.github.com/users/drpngx/orgs","repos_url":"https://api.github.com/users/drpngx/repos","events_url":"https://api.github.com/users/drpngx/events{/privacy}","received_events_url":"https://api.github.com/users/drpngx/received_events","type":"User","site_admin":false},"body":"Can we have a separate test for these as well?","created_at":"2018-08-07T21:58:01Z","updated_at":"2018-08-07T21:58:33Z","html_url":"https://github.com/tensorflow/tensorflow/pull/21025#discussion_r208398838","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21025","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/208398838"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/21025#discussion_r208398838"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21025"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21025","id":203035775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDM1Nzc1","html_url":"https://github.com/tensorflow/tensorflow/pull/21025","diff_url":"https://github.com/tensorflow/tensorflow/pull/21025.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/21025.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21025","number":21025,"state":"open","locked":false,"title":"Add C++ gradient for Cast","user":{"login":"kbsriram","id":1495065,"node_id":"MDQ6VXNlcjE0OTUwNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1495065?v=4","gravatar_id":"","url":"https://api.github.com/users/kbsriram","html_url":"https://github.com/kbsriram","followers_url":"https://api.github.com/users/kbsriram/followers","following_url":"https://api.github.com/users/kbsriram/following{/other_user}","gists_url":"https://api.github.com/users/kbsriram/gists{/gist_id}","starred_url":"https://api.github.com/users/kbsriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbsriram/subscriptions","organizations_url":"https://api.github.com/users/kbsriram/orgs","repos_url":"https://api.github.com/users/kbsriram/repos","events_url":"https://api.github.com/users/kbsriram/events{/privacy}","received_events_url":"https://api.github.com/users/kbsriram/received_events","type":"User","site_admin":false},"body":"- add ops (Ceil, Round and Rint) that return zero gradients\r\n- minor formatting fixes from clang-format\r\n\r\nTested for flakes with:\r\n```\r\n$ bazel test --runs_per_test=100 tensorflow/cc:gradients_math_grad_test\r\n...\r\n//tensorflow/cc:gradients_math_grad_test                                 PASSED in 1.6s\r\n  Stats over 100 runs: max = 1.6s, min = 0.6s, avg = 1.3s, dev = 0.1s\r\n```\r\n\r\nFixes https://github.com/tensorflow/tensorflow/issues/14081","created_at":"2018-07-22T02:20:59Z","updated_at":"2018-08-07T21:58:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d12dd9d9a4acea3c4786e1a902ad96008965c1c","assignee":{"login":"caisq","id":16824702,"node_id":"MDQ6VXNlcjE2ODI0NzAy","avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false},"assignees":[{"login":"caisq","id":16824702,"node_id":"MDQ6VXNlcjE2ODI0NzAy","avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"benoitsteiner","id":6969686,"node_id":"MDQ6VXNlcjY5Njk2ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/6969686?v=4","gravatar_id":"","url":"https://api.github.com/users/benoitsteiner","html_url":"https://github.com/benoitsteiner","followers_url":"https://api.github.com/users/benoitsteiner/followers","following_url":"https://api.github.com/users/benoitsteiner/following{/other_user}","gists_url":"https://api.github.com/users/benoitsteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitsteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitsteiner/subscriptions","organizations_url":"https://api.github.com/users/benoitsteiner/orgs","repos_url":"https://api.github.com/users/benoitsteiner/repos","events_url":"https://api.github.com/users/benoitsteiner/events{/privacy}","received_events_url":"https://api.github.com/users/benoitsteiner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":390482148,"node_id":"MDU6TGFiZWwzOTA0ODIxNDg=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review","name":"awaiting review","color":"fef2c0","default":false},{"id":300136587,"node_id":"MDU6TGFiZWwzMDAxMzY1ODc=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21025/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21025/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21025/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/10a016a6028ae65a5d562284675dbdbd7cf2d619","head":{"label":"kbsriram:tf-cast-grad","ref":"tf-cast-grad","sha":"10a016a6028ae65a5d562284675dbdbd7cf2d619","user":{"login":"kbsriram","id":1495065,"node_id":"MDQ6VXNlcjE0OTUwNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1495065?v=4","gravatar_id":"","url":"https://api.github.com/users/kbsriram","html_url":"https://github.com/kbsriram","followers_url":"https://api.github.com/users/kbsriram/followers","following_url":"https://api.github.com/users/kbsriram/following{/other_user}","gists_url":"https://api.github.com/users/kbsriram/gists{/gist_id}","starred_url":"https://api.github.com/users/kbsriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbsriram/subscriptions","organizations_url":"https://api.github.com/users/kbsriram/orgs","repos_url":"https://api.github.com/users/kbsriram/repos","events_url":"https://api.github.com/users/kbsriram/events{/privacy}","received_events_url":"https://api.github.com/users/kbsriram/received_events","type":"User","site_admin":false},"repo":{"id":90090867,"node_id":"MDEwOlJlcG9zaXRvcnk5MDA5MDg2Nw==","name":"tensorflow","full_name":"kbsriram/tensorflow","owner":{"login":"kbsriram","id":1495065,"node_id":"MDQ6VXNlcjE0OTUwNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1495065?v=4","gravatar_id":"","url":"https://api.github.com/users/kbsriram","html_url":"https://github.com/kbsriram","followers_url":"https://api.github.com/users/kbsriram/followers","following_url":"https://api.github.com/users/kbsriram/following{/other_user}","gists_url":"https://api.github.com/users/kbsriram/gists{/gist_id}","starred_url":"https://api.github.com/users/kbsriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbsriram/subscriptions","organizations_url":"https://api.github.com/users/kbsriram/orgs","repos_url":"https://api.github.com/users/kbsriram/repos","events_url":"https://api.github.com/users/kbsriram/events{/privacy}","received_events_url":"https://api.github.com/users/kbsriram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbsriram/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/kbsriram/tensorflow","forks_url":"https://api.github.com/repos/kbsriram/tensorflow/forks","keys_url":"https://api.github.com/repos/kbsriram/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbsriram/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbsriram/tensorflow/teams","hooks_url":"https://api.github.com/repos/kbsriram/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/kbsriram/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/kbsriram/tensorflow/events","assignees_url":"https://api.github.com/repos/kbsriram/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/kbsriram/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/kbsriram/tensorflow/tags","blobs_url":"https://api.github.com/repos/kbsriram/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbsriram/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbsriram/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbsriram/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbsriram/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kbsriram/tensorflow/languages","stargazers_url":"https://api.github.com/repos/kbsriram/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/kbsriram/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/kbsriram/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/kbsriram/tensorflow/subscription","commits_url":"https://api.github.com/repos/kbsriram/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbsriram/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbsriram/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbsriram/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbsriram/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/kbsriram/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbsriram/tensorflow/merges","archive_url":"https://api.github.com/repos/kbsriram/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbsriram/tensorflow/downloads","issues_url":"https://api.github.com/repos/kbsriram/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/kbsriram/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kbsriram/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kbsriram/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbsriram/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/kbsriram/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/kbsriram/tensorflow/deployments","created_at":"2017-05-03T00:24:44Z","updated_at":"2017-05-03T00:25:09Z","pushed_at":"2018-08-07T17:35:53Z","git_url":"git://github.com/kbsriram/tensorflow.git","ssh_url":"git@github.com:kbsriram/tensorflow.git","clone_url":"https://github.com/kbsriram/tensorflow.git","svn_url":"https://github.com/kbsriram/tensorflow","homepage":"http://tensorflow.org","size":183615,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"2279279fd15369e361a02fb09a1df41e08a34aae","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcxNzI1MA==","name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2018-08-07T21:56:42Z","pushed_at":"2018-08-07T21:56:17Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"https://tensorflow.org","size":187704,"stargazers_count":106867,"watchers_count":106867,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66243,"mirror_url":null,"archived":false,"open_issues_count":1861,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":66243,"open_issues":1861,"watchers":106867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21025"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/21025"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/21025"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/21025/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21025/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21025/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/10a016a6028ae65a5d562284675dbdbd7cf2d619"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drpngx"}}