{"action":"created","comment":{"url":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/comments/191015688","pull_request_review_id":123519845,"id":191015688,"diff_hunk":"@@ -144,11 +144,25 @@ class Scaffold {\n             const crewmemberIdsToAdd = DOM.getSelectedValues(DOM.fromElement);\n \n             // if add has been implemented, reflect changes in model and view\n-            if (this.addAwayTeamMembersFn(crewmemberIdsToAdd)) {\n-                model.addAwayTeamMembers(crewmemberIdsToAdd);\n-                DOM.moveItemsBetweenSelects(DOM.fromElement, DOM.toElement);\n+            const addMembersPromise = this.addAwayTeamMembersFn(crewmemberIdsToAdd);\n+            if(!addMembersPromise){\n+                return;\n+            }\n+\n+            if(crewmemberIdsToAdd.length === 0){\n+                DOM.alertBox(\"Please select a crew member to add\");\n+            }else{\n+                DOM.alertBox(\"Adding crew member(s)\");\n             }\n \n+            model.addAwayTeamMembers(crewmemberIdsToAdd);\n+            DOM.moveItemsBetweenSelects(DOM.fromElement, DOM.toElement);\n+\n+            addMembersPromise.then(() => {\n+                DOM.hideElement(DOM.alertBoxElement);\n+                console.log(\"Successfully added new members to away team\");\n+            })","path":"app/scaffold/scaffold.js","position":24,"original_position":24,"commit_id":"0d377b971ea386dda006c58b3faa5359b06f5a8f","original_commit_id":"0d377b971ea386dda006c58b3faa5359b06f5a8f","user":{"login":"madison-kerndt","id":19200284,"avatar_url":"https://avatars3.githubusercontent.com/u/19200284?v=4","gravatar_id":"","url":"https://api.github.com/users/madison-kerndt","html_url":"https://github.com/madison-kerndt","followers_url":"https://api.github.com/users/madison-kerndt/followers","following_url":"https://api.github.com/users/madison-kerndt/following{/other_user}","gists_url":"https://api.github.com/users/madison-kerndt/gists{/gist_id}","starred_url":"https://api.github.com/users/madison-kerndt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madison-kerndt/subscriptions","organizations_url":"https://api.github.com/users/madison-kerndt/orgs","repos_url":"https://api.github.com/users/madison-kerndt/repos","events_url":"https://api.github.com/users/madison-kerndt/events{/privacy}","received_events_url":"https://api.github.com/users/madison-kerndt/received_events","type":"User","site_admin":false},"body":"Nitpick: semicolon to complete this line.","created_at":"2018-05-25T21:43:04Z","updated_at":"2018-05-25T21:45:22Z","html_url":"https://github.com/IronCoreLabs/getting-started/pull/2#discussion_r191015688","pull_request_url":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/comments/191015688"},"html":{"href":"https://github.com/IronCoreLabs/getting-started/pull/2#discussion_r191015688"},"pull_request":{"href":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/2","id":190430318,"html_url":"https://github.com/IronCoreLabs/getting-started/pull/2","diff_url":"https://github.com/IronCoreLabs/getting-started/pull/2.diff","patch_url":"https://github.com/IronCoreLabs/getting-started/pull/2.patch","issue_url":"https://api.github.com/repos/IronCoreLabs/getting-started/issues/2","number":2,"state":"open","locked":false,"title":"added loading messages to ironcore api calls","user":{"login":"miyo6032","id":32251924,"avatar_url":"https://avatars1.githubusercontent.com/u/32251924?v=4","gravatar_id":"","url":"https://api.github.com/users/miyo6032","html_url":"https://github.com/miyo6032","followers_url":"https://api.github.com/users/miyo6032/followers","following_url":"https://api.github.com/users/miyo6032/following{/other_user}","gists_url":"https://api.github.com/users/miyo6032/gists{/gist_id}","starred_url":"https://api.github.com/users/miyo6032/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miyo6032/subscriptions","organizations_url":"https://api.github.com/users/miyo6032/orgs","repos_url":"https://api.github.com/users/miyo6032/repos","events_url":"https://api.github.com/users/miyo6032/events{/privacy}","received_events_url":"https://api.github.com/users/miyo6032/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-24T21:51:27Z","updated_at":"2018-05-25T21:45:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5853e1c14abca4121a465fe84b97b1cc08702c5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/2/commits","review_comments_url":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/2/comments","review_comment_url":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IronCoreLabs/getting-started/issues/2/comments","statuses_url":"https://api.github.com/repos/IronCoreLabs/getting-started/statuses/0d377b971ea386dda006c58b3faa5359b06f5a8f","head":{"label":"IronCoreLabs:loading-message","ref":"loading-message","sha":"0d377b971ea386dda006c58b3faa5359b06f5a8f","user":{"login":"IronCoreLabs","id":11394047,"avatar_url":"https://avatars3.githubusercontent.com/u/11394047?v=4","gravatar_id":"","url":"https://api.github.com/users/IronCoreLabs","html_url":"https://github.com/IronCoreLabs","followers_url":"https://api.github.com/users/IronCoreLabs/followers","following_url":"https://api.github.com/users/IronCoreLabs/following{/other_user}","gists_url":"https://api.github.com/users/IronCoreLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IronCoreLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronCoreLabs/subscriptions","organizations_url":"https://api.github.com/users/IronCoreLabs/orgs","repos_url":"https://api.github.com/users/IronCoreLabs/repos","events_url":"https://api.github.com/users/IronCoreLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IronCoreLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":134741655,"name":"getting-started","full_name":"IronCoreLabs/getting-started","owner":{"login":"IronCoreLabs","id":11394047,"avatar_url":"https://avatars3.githubusercontent.com/u/11394047?v=4","gravatar_id":"","url":"https://api.github.com/users/IronCoreLabs","html_url":"https://github.com/IronCoreLabs","followers_url":"https://api.github.com/users/IronCoreLabs/followers","following_url":"https://api.github.com/users/IronCoreLabs/following{/other_user}","gists_url":"https://api.github.com/users/IronCoreLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IronCoreLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronCoreLabs/subscriptions","organizations_url":"https://api.github.com/users/IronCoreLabs/orgs","repos_url":"https://api.github.com/users/IronCoreLabs/repos","events_url":"https://api.github.com/users/IronCoreLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IronCoreLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IronCoreLabs/getting-started","description":"Get started with IronCore to grant, monitor and revoke access to sensitive data in just a few minutes.","fork":false,"url":"https://api.github.com/repos/IronCoreLabs/getting-started","forks_url":"https://api.github.com/repos/IronCoreLabs/getting-started/forks","keys_url":"https://api.github.com/repos/IronCoreLabs/getting-started/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IronCoreLabs/getting-started/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IronCoreLabs/getting-started/teams","hooks_url":"https://api.github.com/repos/IronCoreLabs/getting-started/hooks","issue_events_url":"https://api.github.com/repos/IronCoreLabs/getting-started/issues/events{/number}","events_url":"https://api.github.com/repos/IronCoreLabs/getting-started/events","assignees_url":"https://api.github.com/repos/IronCoreLabs/getting-started/assignees{/user}","branches_url":"https://api.github.com/repos/IronCoreLabs/getting-started/branches{/branch}","tags_url":"https://api.github.com/repos/IronCoreLabs/getting-started/tags","blobs_url":"https://api.github.com/repos/IronCoreLabs/getting-started/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IronCoreLabs/getting-started/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IronCoreLabs/getting-started/git/refs{/sha}","trees_url":"https://api.github.com/repos/IronCoreLabs/getting-started/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IronCoreLabs/getting-started/statuses/{sha}","languages_url":"https://api.github.com/repos/IronCoreLabs/getting-started/languages","stargazers_url":"https://api.github.com/repos/IronCoreLabs/getting-started/stargazers","contributors_url":"https://api.github.com/repos/IronCoreLabs/getting-started/contributors","subscribers_url":"https://api.github.com/repos/IronCoreLabs/getting-started/subscribers","subscription_url":"https://api.github.com/repos/IronCoreLabs/getting-started/subscription","commits_url":"https://api.github.com/repos/IronCoreLabs/getting-started/commits{/sha}","git_commits_url":"https://api.github.com/repos/IronCoreLabs/getting-started/git/commits{/sha}","comments_url":"https://api.github.com/repos/IronCoreLabs/getting-started/comments{/number}","issue_comment_url":"https://api.github.com/repos/IronCoreLabs/getting-started/issues/comments{/number}","contents_url":"https://api.github.com/repos/IronCoreLabs/getting-started/contents/{+path}","compare_url":"https://api.github.com/repos/IronCoreLabs/getting-started/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IronCoreLabs/getting-started/merges","archive_url":"https://api.github.com/repos/IronCoreLabs/getting-started/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IronCoreLabs/getting-started/downloads","issues_url":"https://api.github.com/repos/IronCoreLabs/getting-started/issues{/number}","pulls_url":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls{/number}","milestones_url":"https://api.github.com/repos/IronCoreLabs/getting-started/milestones{/number}","notifications_url":"https://api.github.com/repos/IronCoreLabs/getting-started/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IronCoreLabs/getting-started/labels{/name}","releases_url":"https://api.github.com/repos/IronCoreLabs/getting-started/releases{/id}","deployments_url":"https://api.github.com/repos/IronCoreLabs/getting-started/deployments","created_at":"2018-05-24T16:27:43Z","updated_at":"2018-05-24T16:37:18Z","pushed_at":"2018-05-25T21:33:49Z","git_url":"git://github.com/IronCoreLabs/getting-started.git","ssh_url":"git@github.com:IronCoreLabs/getting-started.git","clone_url":"https://github.com/IronCoreLabs/getting-started.git","svn_url":"https://github.com/IronCoreLabs/getting-started","homepage":"https://docs.ironcorelabs.com/getting-started","size":2512,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"IronCoreLabs:master","ref":"master","sha":"25a715ef7b69cb37c959953d6a007d1d5d91dfb0","user":{"login":"IronCoreLabs","id":11394047,"avatar_url":"https://avatars3.githubusercontent.com/u/11394047?v=4","gravatar_id":"","url":"https://api.github.com/users/IronCoreLabs","html_url":"https://github.com/IronCoreLabs","followers_url":"https://api.github.com/users/IronCoreLabs/followers","following_url":"https://api.github.com/users/IronCoreLabs/following{/other_user}","gists_url":"https://api.github.com/users/IronCoreLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IronCoreLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronCoreLabs/subscriptions","organizations_url":"https://api.github.com/users/IronCoreLabs/orgs","repos_url":"https://api.github.com/users/IronCoreLabs/repos","events_url":"https://api.github.com/users/IronCoreLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IronCoreLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":134741655,"name":"getting-started","full_name":"IronCoreLabs/getting-started","owner":{"login":"IronCoreLabs","id":11394047,"avatar_url":"https://avatars3.githubusercontent.com/u/11394047?v=4","gravatar_id":"","url":"https://api.github.com/users/IronCoreLabs","html_url":"https://github.com/IronCoreLabs","followers_url":"https://api.github.com/users/IronCoreLabs/followers","following_url":"https://api.github.com/users/IronCoreLabs/following{/other_user}","gists_url":"https://api.github.com/users/IronCoreLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IronCoreLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronCoreLabs/subscriptions","organizations_url":"https://api.github.com/users/IronCoreLabs/orgs","repos_url":"https://api.github.com/users/IronCoreLabs/repos","events_url":"https://api.github.com/users/IronCoreLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IronCoreLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IronCoreLabs/getting-started","description":"Get started with IronCore to grant, monitor and revoke access to sensitive data in just a few minutes.","fork":false,"url":"https://api.github.com/repos/IronCoreLabs/getting-started","forks_url":"https://api.github.com/repos/IronCoreLabs/getting-started/forks","keys_url":"https://api.github.com/repos/IronCoreLabs/getting-started/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IronCoreLabs/getting-started/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IronCoreLabs/getting-started/teams","hooks_url":"https://api.github.com/repos/IronCoreLabs/getting-started/hooks","issue_events_url":"https://api.github.com/repos/IronCoreLabs/getting-started/issues/events{/number}","events_url":"https://api.github.com/repos/IronCoreLabs/getting-started/events","assignees_url":"https://api.github.com/repos/IronCoreLabs/getting-started/assignees{/user}","branches_url":"https://api.github.com/repos/IronCoreLabs/getting-started/branches{/branch}","tags_url":"https://api.github.com/repos/IronCoreLabs/getting-started/tags","blobs_url":"https://api.github.com/repos/IronCoreLabs/getting-started/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IronCoreLabs/getting-started/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IronCoreLabs/getting-started/git/refs{/sha}","trees_url":"https://api.github.com/repos/IronCoreLabs/getting-started/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IronCoreLabs/getting-started/statuses/{sha}","languages_url":"https://api.github.com/repos/IronCoreLabs/getting-started/languages","stargazers_url":"https://api.github.com/repos/IronCoreLabs/getting-started/stargazers","contributors_url":"https://api.github.com/repos/IronCoreLabs/getting-started/contributors","subscribers_url":"https://api.github.com/repos/IronCoreLabs/getting-started/subscribers","subscription_url":"https://api.github.com/repos/IronCoreLabs/getting-started/subscription","commits_url":"https://api.github.com/repos/IronCoreLabs/getting-started/commits{/sha}","git_commits_url":"https://api.github.com/repos/IronCoreLabs/getting-started/git/commits{/sha}","comments_url":"https://api.github.com/repos/IronCoreLabs/getting-started/comments{/number}","issue_comment_url":"https://api.github.com/repos/IronCoreLabs/getting-started/issues/comments{/number}","contents_url":"https://api.github.com/repos/IronCoreLabs/getting-started/contents/{+path}","compare_url":"https://api.github.com/repos/IronCoreLabs/getting-started/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IronCoreLabs/getting-started/merges","archive_url":"https://api.github.com/repos/IronCoreLabs/getting-started/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IronCoreLabs/getting-started/downloads","issues_url":"https://api.github.com/repos/IronCoreLabs/getting-started/issues{/number}","pulls_url":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls{/number}","milestones_url":"https://api.github.com/repos/IronCoreLabs/getting-started/milestones{/number}","notifications_url":"https://api.github.com/repos/IronCoreLabs/getting-started/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IronCoreLabs/getting-started/labels{/name}","releases_url":"https://api.github.com/repos/IronCoreLabs/getting-started/releases{/id}","deployments_url":"https://api.github.com/repos/IronCoreLabs/getting-started/deployments","created_at":"2018-05-24T16:27:43Z","updated_at":"2018-05-24T16:37:18Z","pushed_at":"2018-05-25T21:33:49Z","git_url":"git://github.com/IronCoreLabs/getting-started.git","ssh_url":"git@github.com:IronCoreLabs/getting-started.git","clone_url":"https://github.com/IronCoreLabs/getting-started.git","svn_url":"https://github.com/IronCoreLabs/getting-started","homepage":"https://docs.ironcorelabs.com/getting-started","size":2512,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/2"},"html":{"href":"https://github.com/IronCoreLabs/getting-started/pull/2"},"issue":{"href":"https://api.github.com/repos/IronCoreLabs/getting-started/issues/2"},"comments":{"href":"https://api.github.com/repos/IronCoreLabs/getting-started/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IronCoreLabs/getting-started/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/IronCoreLabs/getting-started/statuses/0d377b971ea386dda006c58b3faa5359b06f5a8f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"madison-kerndt"}}