{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/comments/187179216","pull_request_review_id":118908545,"id":187179216,"diff_hunk":"@@ -221,7 +221,7 @@ def create_relationship_hash(base_key, relationship_type, options, block)\n       end\n \n       def compute_serializer_name(serializer_key)\n-        return serializer_key unless serializer_key.is_a? Symbol\n+        return serializer_key.to_s.to_sym unless serializer_key.is_a? Symbol","path":"lib/fast_jsonapi/object_serializer.rb","position":5,"original_position":5,"commit_id":"b1a85cc1dac7119f6d79201a8b19a462716a1ad4","original_commit_id":"b1a85cc1dac7119f6d79201a8b19a462716a1ad4","user":{"login":"zinosama","id":9384600,"avatar_url":"https://avatars1.githubusercontent.com/u/9384600?v=4","gravatar_id":"","url":"https://api.github.com/users/zinosama","html_url":"https://github.com/zinosama","followers_url":"https://api.github.com/users/zinosama/followers","following_url":"https://api.github.com/users/zinosama/following{/other_user}","gists_url":"https://api.github.com/users/zinosama/gists{/gist_id}","starred_url":"https://api.github.com/users/zinosama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zinosama/subscriptions","organizations_url":"https://api.github.com/users/zinosama/orgs","repos_url":"https://api.github.com/users/zinosama/repos","events_url":"https://api.github.com/users/zinosama/events{/privacy}","received_events_url":"https://api.github.com/users/zinosama/received_events","type":"User","site_admin":false},"body":"The output of this method is always used as\r\n`@relationships_to_serialize[item][:serializer].to_s.constantize` \r\n\r\nso why not change this method to simply return a string? Not sure what's the point of converting to symbol then back to string.","created_at":"2018-05-09T21:18:15Z","updated_at":"2018-05-09T21:18:16Z","html_url":"https://github.com/Netflix/fast_jsonapi/pull/206#discussion_r187179216","pull_request_url":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/206","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/comments/187179216"},"html":{"href":"https://github.com/Netflix/fast_jsonapi/pull/206#discussion_r187179216"},"pull_request":{"href":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/206","id":187041613,"html_url":"https://github.com/Netflix/fast_jsonapi/pull/206","diff_url":"https://github.com/Netflix/fast_jsonapi/pull/206.diff","patch_url":"https://github.com/Netflix/fast_jsonapi/pull/206.patch","issue_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/206","number":206,"state":"open","locked":false,"title":"Always return a symbol from compute_serializer_name.","user":{"login":"carsol","id":1127090,"avatar_url":"https://avatars2.githubusercontent.com/u/1127090?v=4","gravatar_id":"","url":"https://api.github.com/users/carsol","html_url":"https://github.com/carsol","followers_url":"https://api.github.com/users/carsol/followers","following_url":"https://api.github.com/users/carsol/following{/other_user}","gists_url":"https://api.github.com/users/carsol/gists{/gist_id}","starred_url":"https://api.github.com/users/carsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carsol/subscriptions","organizations_url":"https://api.github.com/users/carsol/orgs","repos_url":"https://api.github.com/users/carsol/repos","events_url":"https://api.github.com/users/carsol/events{/privacy}","received_events_url":"https://api.github.com/users/carsol/received_events","type":"User","site_admin":false},"body":"I made a previous change that if you passed a class instead of a symbol, it would just return it (https://github.com/Netflix/fast_jsonapi/pull/198). This method works either way but it makes more sense to be uniform about what we return (always a symbol class). It also allows for us to clean up a test also.\r\n\r\n### Related PRs:\r\n#198\r\n#201\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/netflix/fast_jsonapi/206)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-05-09T21:12:07Z","updated_at":"2018-05-09T21:18:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"666486e1347280fd92300c99669988ef9d8a17cf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shishirmk","id":604135,"avatar_url":"https://avatars0.githubusercontent.com/u/604135?v=4","gravatar_id":"","url":"https://api.github.com/users/shishirmk","html_url":"https://github.com/shishirmk","followers_url":"https://api.github.com/users/shishirmk/followers","following_url":"https://api.github.com/users/shishirmk/following{/other_user}","gists_url":"https://api.github.com/users/shishirmk/gists{/gist_id}","starred_url":"https://api.github.com/users/shishirmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shishirmk/subscriptions","organizations_url":"https://api.github.com/users/shishirmk/orgs","repos_url":"https://api.github.com/users/shishirmk/repos","events_url":"https://api.github.com/users/shishirmk/events{/privacy}","received_events_url":"https://api.github.com/users/shishirmk/received_events","type":"User","site_admin":false},{"login":"mrryanjohnston","id":630029,"avatar_url":"https://avatars3.githubusercontent.com/u/630029?v=4","gravatar_id":"","url":"https://api.github.com/users/mrryanjohnston","html_url":"https://github.com/mrryanjohnston","followers_url":"https://api.github.com/users/mrryanjohnston/followers","following_url":"https://api.github.com/users/mrryanjohnston/following{/other_user}","gists_url":"https://api.github.com/users/mrryanjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/mrryanjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrryanjohnston/subscriptions","organizations_url":"https://api.github.com/users/mrryanjohnston/orgs","repos_url":"https://api.github.com/users/mrryanjohnston/repos","events_url":"https://api.github.com/users/mrryanjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/mrryanjohnston/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/206/commits","review_comments_url":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/206/comments","review_comment_url":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/206/comments","statuses_url":"https://api.github.com/repos/Netflix/fast_jsonapi/statuses/b1a85cc1dac7119f6d79201a8b19a462716a1ad4","head":{"label":"carsol:cs/serializer_name","ref":"cs/serializer_name","sha":"b1a85cc1dac7119f6d79201a8b19a462716a1ad4","user":{"login":"carsol","id":1127090,"avatar_url":"https://avatars2.githubusercontent.com/u/1127090?v=4","gravatar_id":"","url":"https://api.github.com/users/carsol","html_url":"https://github.com/carsol","followers_url":"https://api.github.com/users/carsol/followers","following_url":"https://api.github.com/users/carsol/following{/other_user}","gists_url":"https://api.github.com/users/carsol/gists{/gist_id}","starred_url":"https://api.github.com/users/carsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carsol/subscriptions","organizations_url":"https://api.github.com/users/carsol/orgs","repos_url":"https://api.github.com/users/carsol/repos","events_url":"https://api.github.com/users/carsol/events{/privacy}","received_events_url":"https://api.github.com/users/carsol/received_events","type":"User","site_admin":false},"repo":{"id":131639989,"name":"fast_jsonapi","full_name":"carsol/fast_jsonapi","owner":{"login":"carsol","id":1127090,"avatar_url":"https://avatars2.githubusercontent.com/u/1127090?v=4","gravatar_id":"","url":"https://api.github.com/users/carsol","html_url":"https://github.com/carsol","followers_url":"https://api.github.com/users/carsol/followers","following_url":"https://api.github.com/users/carsol/following{/other_user}","gists_url":"https://api.github.com/users/carsol/gists{/gist_id}","starred_url":"https://api.github.com/users/carsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carsol/subscriptions","organizations_url":"https://api.github.com/users/carsol/orgs","repos_url":"https://api.github.com/users/carsol/repos","events_url":"https://api.github.com/users/carsol/events{/privacy}","received_events_url":"https://api.github.com/users/carsol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carsol/fast_jsonapi","description":"A lightning fast JSON:API serializer for Ruby Objects.","fork":true,"url":"https://api.github.com/repos/carsol/fast_jsonapi","forks_url":"https://api.github.com/repos/carsol/fast_jsonapi/forks","keys_url":"https://api.github.com/repos/carsol/fast_jsonapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carsol/fast_jsonapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carsol/fast_jsonapi/teams","hooks_url":"https://api.github.com/repos/carsol/fast_jsonapi/hooks","issue_events_url":"https://api.github.com/repos/carsol/fast_jsonapi/issues/events{/number}","events_url":"https://api.github.com/repos/carsol/fast_jsonapi/events","assignees_url":"https://api.github.com/repos/carsol/fast_jsonapi/assignees{/user}","branches_url":"https://api.github.com/repos/carsol/fast_jsonapi/branches{/branch}","tags_url":"https://api.github.com/repos/carsol/fast_jsonapi/tags","blobs_url":"https://api.github.com/repos/carsol/fast_jsonapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carsol/fast_jsonapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carsol/fast_jsonapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/carsol/fast_jsonapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carsol/fast_jsonapi/statuses/{sha}","languages_url":"https://api.github.com/repos/carsol/fast_jsonapi/languages","stargazers_url":"https://api.github.com/repos/carsol/fast_jsonapi/stargazers","contributors_url":"https://api.github.com/repos/carsol/fast_jsonapi/contributors","subscribers_url":"https://api.github.com/repos/carsol/fast_jsonapi/subscribers","subscription_url":"https://api.github.com/repos/carsol/fast_jsonapi/subscription","commits_url":"https://api.github.com/repos/carsol/fast_jsonapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/carsol/fast_jsonapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/carsol/fast_jsonapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/carsol/fast_jsonapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/carsol/fast_jsonapi/contents/{+path}","compare_url":"https://api.github.com/repos/carsol/fast_jsonapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carsol/fast_jsonapi/merges","archive_url":"https://api.github.com/repos/carsol/fast_jsonapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carsol/fast_jsonapi/downloads","issues_url":"https://api.github.com/repos/carsol/fast_jsonapi/issues{/number}","pulls_url":"https://api.github.com/repos/carsol/fast_jsonapi/pulls{/number}","milestones_url":"https://api.github.com/repos/carsol/fast_jsonapi/milestones{/number}","notifications_url":"https://api.github.com/repos/carsol/fast_jsonapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carsol/fast_jsonapi/labels{/name}","releases_url":"https://api.github.com/repos/carsol/fast_jsonapi/releases{/id}","deployments_url":"https://api.github.com/repos/carsol/fast_jsonapi/deployments","created_at":"2018-04-30T19:52:17Z","updated_at":"2018-04-30T19:52:19Z","pushed_at":"2018-05-09T21:05:06Z","git_url":"git://github.com/carsol/fast_jsonapi.git","ssh_url":"git@github.com:carsol/fast_jsonapi.git","clone_url":"https://github.com/carsol/fast_jsonapi.git","svn_url":"https://github.com/carsol/fast_jsonapi","homepage":null,"size":145,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:dev","ref":"dev","sha":"966b3509a4999ec4a1905f999c81d99df8fe5d16","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":119760423,"name":"fast_jsonapi","full_name":"Netflix/fast_jsonapi","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/fast_jsonapi","description":"A lightning fast JSON:API serializer for Ruby Objects.","fork":false,"url":"https://api.github.com/repos/Netflix/fast_jsonapi","forks_url":"https://api.github.com/repos/Netflix/fast_jsonapi/forks","keys_url":"https://api.github.com/repos/Netflix/fast_jsonapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/fast_jsonapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/fast_jsonapi/teams","hooks_url":"https://api.github.com/repos/Netflix/fast_jsonapi/hooks","issue_events_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/fast_jsonapi/events","assignees_url":"https://api.github.com/repos/Netflix/fast_jsonapi/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/fast_jsonapi/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/fast_jsonapi/tags","blobs_url":"https://api.github.com/repos/Netflix/fast_jsonapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/fast_jsonapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/fast_jsonapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/fast_jsonapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/fast_jsonapi/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/fast_jsonapi/languages","stargazers_url":"https://api.github.com/repos/Netflix/fast_jsonapi/stargazers","contributors_url":"https://api.github.com/repos/Netflix/fast_jsonapi/contributors","subscribers_url":"https://api.github.com/repos/Netflix/fast_jsonapi/subscribers","subscription_url":"https://api.github.com/repos/Netflix/fast_jsonapi/subscription","commits_url":"https://api.github.com/repos/Netflix/fast_jsonapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/fast_jsonapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/fast_jsonapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/fast_jsonapi/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/fast_jsonapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/fast_jsonapi/merges","archive_url":"https://api.github.com/repos/Netflix/fast_jsonapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/fast_jsonapi/downloads","issues_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/fast_jsonapi/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/fast_jsonapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/fast_jsonapi/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/fast_jsonapi/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/fast_jsonapi/deployments","created_at":"2018-02-01T00:19:19Z","updated_at":"2018-05-09T19:06:46Z","pushed_at":"2018-05-09T21:12:20Z","git_url":"git://github.com/Netflix/fast_jsonapi.git","ssh_url":"git@github.com:Netflix/fast_jsonapi.git","clone_url":"https://github.com/Netflix/fast_jsonapi.git","svn_url":"https://github.com/Netflix/fast_jsonapi","homepage":null,"size":167,"stargazers_count":2709,"watchers_count":2709,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":159,"open_issues":45,"watchers":2709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/206"},"html":{"href":"https://github.com/Netflix/fast_jsonapi/pull/206"},"issue":{"href":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/206"},"comments":{"href":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/fast_jsonapi/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/fast_jsonapi/statuses/b1a85cc1dac7119f6d79201a8b19a462716a1ad4"}},"author_association":"NONE"}}
{"actor":{"display_login":"zinosama"}}