{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9948","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9948/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9948/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9948/events","html_url":"https://github.com/civicrm/civicrm-core/pull/9948","id":212636884,"node_id":"MDExOlB1bGxSZXF1ZXN0MTA5NjI3NzYz","number":9948,"title":"CRM-19966 Unfair Double Taxation and net_amounts.","user":{"login":"KarinG","id":5340555,"node_id":"MDQ6VXNlcjUzNDA1NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5340555?v=4","gravatar_id":"","url":"https://api.github.com/users/KarinG","html_url":"https://github.com/KarinG","followers_url":"https://api.github.com/users/KarinG/followers","following_url":"https://api.github.com/users/KarinG/following{/other_user}","gists_url":"https://api.github.com/users/KarinG/gists{/gist_id}","starred_url":"https://api.github.com/users/KarinG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarinG/subscriptions","organizations_url":"https://api.github.com/users/KarinG/orgs","repos_url":"https://api.github.com/users/KarinG/repos","events_url":"https://api.github.com/users/KarinG/events{/privacy}","received_events_url":"https://api.github.com/users/KarinG/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false},{"id":275096971,"node_id":"MDU6TGFiZWwyNzUwOTY5NzE=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/merge%20on%20pass","name":"merge on pass","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":33,"created_at":"2017-03-08T04:48:18Z","updated_at":"2018-07-20T04:28:04Z","closed_at":"2017-03-10T06:12:20Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9948","html_url":"https://github.com/civicrm/civicrm-core/pull/9948","diff_url":"https://github.com/civicrm/civicrm-core/pull/9948.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/9948.patch"},"body":"1. if the total_amount is not in the currently submittedValues -> then it needs to be retrieved from $this->_values - however that total_amount is 'after' sales tax was previously added to it. Hence the subtraction. If we don't subtract it here - you end up being charged sales_tax on top of sales_tax - hence the screenshots in the JIRA issue\r\n\r\n2. net_amount is defined as \r\n\"Net value of the contribution (Total Amount minus Fee).\"\r\nfee_amount is defined as:\r\n\"Processing fee for this transaction (if applicable).\"\r\nNeither are related to sales taxes\n\n---\n\n * [CRM-19966: Remove unfair double taxation](https://issues.civicrm.org/jira/browse/CRM-19966)"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/406485780","html_url":"https://github.com/civicrm/civicrm-core/pull/9948#issuecomment-406485780","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9948","id":406485780,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjQ4NTc4MA==","user":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T04:28:04Z","updated_at":"2018-07-20T04:28:04Z","author_association":"CONTRIBUTOR","body":"Just a few follow on links\r\n\r\nThe form validation issue was discussed here but it was left out of scope due to the feedback in the discussion. It seemed to be a non issue in 2017 & 2018 but has now become an issue for one site. There are 3 related gitlab issues\r\n\r\n\r\nhttps://lab.civicrm.org/dev/core/issues/267\r\nhttps://lab.civicrm.org/dev/core/issues/265\r\nhttps://lab.civicrm.org/dev/core/issues/260"}}
{"actor":{"display_login":"eileenmcnaughton"}}