{"action":"closed","issue":{"url":"https://api.github.com/repos/aowen87/BAR/issues/1586","repository_url":"https://api.github.com/repos/aowen87/BAR","labels_url":"https://api.github.com/repos/aowen87/BAR/issues/1586/labels{/name}","comments_url":"https://api.github.com/repos/aowen87/BAR/issues/1586/comments","events_url":"https://api.github.com/repos/aowen87/BAR/issues/1586/events","html_url":"https://github.com/aowen87/BAR/issues/1586","id":351470355,"node_id":"MDU6SXNzdWUzNTE0NzAzNTU=","number":1586,"title":"suggested change to basic netcdf reader","user":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"labels":[{"id":1026660232,"node_id":"MDU6TGFiZWwxMDI2NjYwMjMy","url":"https://api.github.com/repos/aowen87/BAR/labels/Expected%20Use:%203%20-%20Occasional","name":"Expected Use: 3 - Occasional","color":"003152","default":false},{"id":1026660167,"node_id":"MDU6TGFiZWwxMDI2NjYwMTY3","url":"https://api.github.com/repos/aowen87/BAR/labels/Feature","name":"Feature","color":"0E4D92","default":false},{"id":1026660741,"node_id":"MDU6TGFiZWwxMDI2NjYwNzQx","url":"https://api.github.com/repos/aowen87/BAR/labels/Impact:%202%20-%20Low","name":"Impact: 2 - Low","color":"0F52BA","default":false},{"id":1026660117,"node_id":"MDU6TGFiZWwxMDI2NjYwMTE3","url":"https://api.github.com/repos/aowen87/BAR/labels/Priority:%20Normal","name":"Priority: Normal","color":"008081","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/aowen87/BAR/milestones/44","html_url":"https://github.com/aowen87/BAR/milestone/44","labels_url":"https://api.github.com/repos/aowen87/BAR/milestones/44/labels","id":3577653,"node_id":"MDk6TWlsZXN0b25lMzU3NzY1Mw==","number":44,"title":"2.0.2","description":null,"creator":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":12,"state":"open","created_at":"2018-08-17T01:46:39Z","updated_at":"2018-08-17T06:17:59Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-08-17T06:17:56Z","updated_at":"2018-08-17T06:17:59Z","closed_at":"2018-08-17T06:17:59Z","author_association":"OWNER","body":"cq-id: VisIt00008968\r\ncq-submitter: Kathleen S. Bonnell\r\ncq-submit-date: 09/17/09\r\n\r\nThis came in to the visit-users list.  I am not familiar enough\r\nwith the netcdf reader to judge if the suggested change is\r\ncorrect ...\r\n\r\n=========================\r\n>From Preeti's email:\r\n\r\n\r\nI am using the NETCDF output files from WRF(Weather Research and\r\nForecast Model). The basic reader is not being used for this. The\r\nbasic NETCDF reader could not display all variables properly so I had\r\ncoded a NETCDF reader for WRF. It can recognize all variables and time\r\ndimension as well.\r\n\r\nI have seen the code for the same in BasicNETCDFFileFormat.C in VisIt\r\nv1.11.1 and v1.12.0. I have tried to read the WRF output NETCDF file\r\nusing this basic reader, it recognizes the file but the domain\r\ndecomposition does not occur. I would like to elaborate my findings\r\nregarding this,\r\n\r\nIn databases/NETCDF/avtBasicNETCDFFileFormat.C,\r\nline #272 -- PopulateDatabaseMetaData -- This function has a call to\r\nReturnValidDimensions like below\r\n\r\nLine 411\r\n                    bool valid = ReturnValidDimensions(meshDims,\r\n                         validDims, nValidDims);\r\n\r\n\r\nSince this is called using 3 arguments, the rest two are 0 (as\r\ndeclared in header file)\r\nAs a result in function 'ReturnValidDimensions' in Line #518, the if\r\nstatement \"if (!(dimStarts && dimCounts))\" is always true, thus the\r\nfunction returns without proceeding to the domain decomposition code\r\nie the function 'ComputeRectilinearDecomposition' at Line #562 is\r\nnever called, Hence no domain decomposition occurs.\r\n\r\nI have verified this from the log files also.\r\nPlease let me know if I made some mistake in understanding.\n\n\n\n\n\n-----------------------REDMINE MIGRATION-----------------------\nThis ticket was migrated from Redmine. As such, not all \ninformation was able to be captured in the transition. Below is\na complete record of the original redmine ticket.\n\nTicket number: 146\nStatus: Resolved\nProject: VisIt\nTracker: Feature\nPriority: Normal\nSubject: suggested change to basic netcdf reader\nAssigned to: Mark Miller\nCategory: \nTarget version: 2.0.2\nAuthor: Cyrus Harrison\nStart: \nDue date: \n% Done: 0\nEstimated time: 0.25\nCreated: 06/21/2010 07:17 pm\nUpdated: 07/26/2010 07:22 pm\nLikelihood: \nSeverity: \nFound in version: \nImpact: 2 - Low\nExpected Use: 3 - Occasional\nOS: All\nSupport Group: Any\nDescription:\n cq-id: VisIt00008968\r\ncq-submitter: Kathleen S. Bonnell\r\ncq-submit-date: 09/17/09\r\n\r\nThis came in to the visit-users list.  I am not familiar enough\r\nwith the netcdf reader to judge if the suggested change is\r\ncorrect ...\r\n\r\n=========================\r\n>From Preeti's email:\r\n\r\n\r\nI am using the NETCDF output files from WRF(Weather Research and\r\nForecast Model). The basic reader is not being used for this. The\r\nbasic NETCDF reader could not display all variables properly so I had\r\ncoded a NETCDF reader for WRF. It can recognize all variables and time\r\ndimension as well.\r\n\r\nI have seen the code for the same in BasicNETCDFFileFormat.C in VisIt\r\nv1.11.1 and v1.12.0. I have tried to read the WRF output NETCDF file\r\nusing this basic reader, it recognizes the file but the domain\r\ndecomposition does not occur. I would like to elaborate my findings\r\nregarding this,\r\n\r\nIn databases/NETCDF/avtBasicNETCDFFileFormat.C,\r\nline #272 -- PopulateDatabaseMetaData -- This function has a call to\r\nReturnValidDimensions like below\r\n\r\nLine 411\r\n                    bool valid = ReturnValidDimensions(meshDims,\r\n                         validDims, nValidDims);\r\n\r\n\r\nSince this is called using 3 arguments, the rest two are 0 (as\r\ndeclared in header file)\r\nAs a result in function 'ReturnValidDimensions' in Line #518, the if\r\nstatement \"if (!(dimStarts && dimCounts))\" is always true, thus the\r\nfunction returns without proceeding to the domain decomposition code\r\nie the function 'ComputeRectilinearDecomposition' at Line #562 is\r\nnever called, Hence no domain decomposition occurs.\r\n\r\nI have verified this from the log files also.\r\nPlease let me know if I made some mistake in understanding.\n\nComments:\nOk, I looked at the code and it has changed a lot since this user's report.I also obtained some WRF test data, wrfda_4dvar_testdata.tar.gz, disabled the 100,000 zone threshold for dynamic decomp in the plugin and then viewed the WRF test data and it correctly decomposed the simple example test data. So, I consider this issue incidentally resolved in that other changes to plugin seem to have corrected it.I opted not to add WRF test because the test data is too small (below the 100,000 threshold) to trigger dynamic decomp logic.\n\n"}}
{"actor":{"display_login":"aowen87"}}