{"action":"closed","number":3888,"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/3888","id":186492584,"html_url":"https://github.com/palantir/tslint/pull/3888","diff_url":"https://github.com/palantir/tslint/pull/3888.diff","patch_url":"https://github.com/palantir/tslint/pull/3888.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/3888","number":3888,"state":"closed","locked":false,"title":"[docs] Fix prefer-while docs","user":{"login":"rwaskiewicz","id":1930213,"avatar_url":"https://avatars0.githubusercontent.com/u/1930213?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaskiewicz","html_url":"https://github.com/rwaskiewicz","followers_url":"https://api.github.com/users/rwaskiewicz/followers","following_url":"https://api.github.com/users/rwaskiewicz/following{/other_user}","gists_url":"https://api.github.com/users/rwaskiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaskiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaskiewicz/subscriptions","organizations_url":"https://api.github.com/users/rwaskiewicz/orgs","repos_url":"https://api.github.com/users/rwaskiewicz/repos","events_url":"https://api.github.com/users/rwaskiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/rwaskiewicz/received_events","type":"User","site_admin":false},"body":"#### PR checklist\r\n\r\n- [ ] Addresses an existing issue: #0000\r\n- [ ] New feature, bugfix, or enhancement\r\n  - [ ] Includes tests\r\n- [X] Documentation update\r\n\r\n#### Overview of change:\r\n- Updated docs to make sense semantically (use vars that should exist in the scope of each for-loop)\r\n- Updated tests with same issue\r\n\r\n#### Is there anything you'd like reviewers to focus on?\r\n\r\n<!-- optional -->\r\n\r\n#### CHANGELOG.md entry:\r\n\r\n<!-- optional (example: \"[new-rule] `arrow-return-shorthand`\") -->\r\n<!-- suggested tags: [new-rule], [new-rule-option], [new-fixer], [bugfix], [enhancement], [api], [rule-change], [no-log] -->\r\n[docs] Updated `prefer-while` docs to be semantically correct","created_at":"2018-05-07T23:41:59Z","updated_at":"2018-05-10T17:56:24Z","closed_at":"2018-05-10T17:56:24Z","merged_at":"2018-05-10T17:56:24Z","merge_commit_sha":"681218d57deba9a6c89c8aae70312636d0538a60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/3888/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/3888/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/3888/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/9fd5b821538da6931e953782db60635bad92bf8e","head":{"label":"rwaskiewicz:fix-prefer-while-docs","ref":"fix-prefer-while-docs","sha":"9fd5b821538da6931e953782db60635bad92bf8e","user":{"login":"rwaskiewicz","id":1930213,"avatar_url":"https://avatars0.githubusercontent.com/u/1930213?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaskiewicz","html_url":"https://github.com/rwaskiewicz","followers_url":"https://api.github.com/users/rwaskiewicz/followers","following_url":"https://api.github.com/users/rwaskiewicz/following{/other_user}","gists_url":"https://api.github.com/users/rwaskiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaskiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaskiewicz/subscriptions","organizations_url":"https://api.github.com/users/rwaskiewicz/orgs","repos_url":"https://api.github.com/users/rwaskiewicz/repos","events_url":"https://api.github.com/users/rwaskiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/rwaskiewicz/received_events","type":"User","site_admin":false},"repo":{"id":116753425,"name":"tslint","full_name":"rwaskiewicz/tslint","owner":{"login":"rwaskiewicz","id":1930213,"avatar_url":"https://avatars0.githubusercontent.com/u/1930213?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaskiewicz","html_url":"https://github.com/rwaskiewicz","followers_url":"https://api.github.com/users/rwaskiewicz/followers","following_url":"https://api.github.com/users/rwaskiewicz/following{/other_user}","gists_url":"https://api.github.com/users/rwaskiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaskiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaskiewicz/subscriptions","organizations_url":"https://api.github.com/users/rwaskiewicz/orgs","repos_url":"https://api.github.com/users/rwaskiewicz/repos","events_url":"https://api.github.com/users/rwaskiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/rwaskiewicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwaskiewicz/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":true,"url":"https://api.github.com/repos/rwaskiewicz/tslint","forks_url":"https://api.github.com/repos/rwaskiewicz/tslint/forks","keys_url":"https://api.github.com/repos/rwaskiewicz/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwaskiewicz/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwaskiewicz/tslint/teams","hooks_url":"https://api.github.com/repos/rwaskiewicz/tslint/hooks","issue_events_url":"https://api.github.com/repos/rwaskiewicz/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/rwaskiewicz/tslint/events","assignees_url":"https://api.github.com/repos/rwaskiewicz/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/rwaskiewicz/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/rwaskiewicz/tslint/tags","blobs_url":"https://api.github.com/repos/rwaskiewicz/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwaskiewicz/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwaskiewicz/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwaskiewicz/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwaskiewicz/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/rwaskiewicz/tslint/languages","stargazers_url":"https://api.github.com/repos/rwaskiewicz/tslint/stargazers","contributors_url":"https://api.github.com/repos/rwaskiewicz/tslint/contributors","subscribers_url":"https://api.github.com/repos/rwaskiewicz/tslint/subscribers","subscription_url":"https://api.github.com/repos/rwaskiewicz/tslint/subscription","commits_url":"https://api.github.com/repos/rwaskiewicz/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwaskiewicz/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwaskiewicz/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwaskiewicz/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwaskiewicz/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/rwaskiewicz/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwaskiewicz/tslint/merges","archive_url":"https://api.github.com/repos/rwaskiewicz/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwaskiewicz/tslint/downloads","issues_url":"https://api.github.com/repos/rwaskiewicz/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/rwaskiewicz/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/rwaskiewicz/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/rwaskiewicz/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwaskiewicz/tslint/labels{/name}","releases_url":"https://api.github.com/repos/rwaskiewicz/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/rwaskiewicz/tslint/deployments","created_at":"2018-01-09T02:12:57Z","updated_at":"2018-01-09T02:13:00Z","pushed_at":"2018-05-07T23:40:11Z","git_url":"git://github.com/rwaskiewicz/tslint.git","ssh_url":"git@github.com:rwaskiewicz/tslint.git","clone_url":"https://github.com/rwaskiewicz/tslint.git","svn_url":"https://github.com/rwaskiewicz/tslint","homepage":"http://palantir.github.io/tslint/","size":13771,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"5af26e2c0ceaddd6c3f03defead5de047f0234ff","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/tslint/deployments","created_at":"2013-07-25T22:19:18Z","updated_at":"2018-05-10T17:55:54Z","pushed_at":"2018-05-10T17:56:24Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":"http://palantir.github.io/tslint/","size":13809,"stargazers_count":3297,"watchers_count":3297,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":637,"mirror_url":null,"archived":false,"open_issues_count":598,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":637,"open_issues":598,"watchers":3297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3888"},"html":{"href":"https://github.com/palantir/tslint/pull/3888"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/3888"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/3888/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3888/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3888/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/9fd5b821538da6931e953782db60635bad92bf8e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"giladgray","id":464822,"avatar_url":"https://avatars1.githubusercontent.com/u/464822?v=4","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":18,"deletions":18,"changed_files":3}}
{"actor":{"display_login":"giladgray"}}