{"action":"created","issue":{"url":"https://api.github.com/repos/mtlynch/spaceduck/issues/79","repository_url":"https://api.github.com/repos/mtlynch/spaceduck","labels_url":"https://api.github.com/repos/mtlynch/spaceduck/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/mtlynch/spaceduck/issues/79/comments","events_url":"https://api.github.com/repos/mtlynch/spaceduck/issues/79/events","html_url":"https://github.com/mtlynch/spaceduck/pull/79","id":314850341,"number":79,"title":"Feature: Adding border option to responsive image template","user":{"login":"shredtechular","id":2396774,"avatar_url":"https://avatars3.githubusercontent.com/u/2396774?v=4","gravatar_id":"","url":"https://api.github.com/users/shredtechular","html_url":"https://github.com/shredtechular","followers_url":"https://api.github.com/users/shredtechular/followers","following_url":"https://api.github.com/users/shredtechular/following{/other_user}","gists_url":"https://api.github.com/users/shredtechular/gists{/gist_id}","starred_url":"https://api.github.com/users/shredtechular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shredtechular/subscriptions","organizations_url":"https://api.github.com/users/shredtechular/orgs","repos_url":"https://api.github.com/users/shredtechular/repos","events_url":"https://api.github.com/users/shredtechular/events{/privacy}","received_events_url":"https://api.github.com/users/shredtechular/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-16T23:16:46Z","updated_at":"2018-04-17T00:58:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mtlynch/spaceduck/pulls/79","html_url":"https://github.com/mtlynch/spaceduck/pull/79","diff_url":"https://github.com/mtlynch/spaceduck/pull/79.diff","patch_url":"https://github.com/mtlynch/spaceduck/pull/79.patch"},"body":"This PR fixes #47 .\r\n\r\nThis update adds in a new ability to pass in a border parameter to the image template in order to draw a 1px solid border around an image.\r\n\r\nFor now, I coded this feature so that a writer can simple add: `border=\"true\"` to the image include and the template will add the proper border class to the image.  In the future, if additional styles of borders are desired, then we may want to add a little more logic to also give the user the ability to pass in a specific border class.  In other words, please see the table below:\r\n\r\n| Parameter Value        | Result           | Complete in this PR?  |\r\n| ------------- | ------------- |:-----:|\r\n| paramter null or not defined at all      | no border around image | Yes |\r\n| false      | no border around image | Yes |\r\n| true      | adds default border class for 1px solid gray border | Yes |\r\n| specific border class (string) | adds specified border class | No, can include now or for future release if desired.  The CSS would have to exist as well for any other use-cases/styles for it to really work |\r\n\r\n**Please NOTE:** I included 1 example of the image include with the border turned on for 1 image in the `_posts/2018-04-12-load-test-3.md` article.  I'm not sure if a border is desired on this image or not, but thought it would be good to include an example?  If you'd like me to add that parameter to ALL graph images or remove the 1 example, I can do either of those, but wanted to specifically call that example out.\r\n"},"comment":{"url":"https://api.github.com/repos/mtlynch/spaceduck/issues/comments/381795819","html_url":"https://github.com/mtlynch/spaceduck/pull/79#issuecomment-381795819","issue_url":"https://api.github.com/repos/mtlynch/spaceduck/issues/79","id":381795819,"user":{"login":"shredtechular","id":2396774,"avatar_url":"https://avatars3.githubusercontent.com/u/2396774?v=4","gravatar_id":"","url":"https://api.github.com/users/shredtechular","html_url":"https://github.com/shredtechular","followers_url":"https://api.github.com/users/shredtechular/followers","following_url":"https://api.github.com/users/shredtechular/following{/other_user}","gists_url":"https://api.github.com/users/shredtechular/gists{/gist_id}","starred_url":"https://api.github.com/users/shredtechular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shredtechular/subscriptions","organizations_url":"https://api.github.com/users/shredtechular/orgs","repos_url":"https://api.github.com/users/shredtechular/repos","events_url":"https://api.github.com/users/shredtechular/events{/privacy}","received_events_url":"https://api.github.com/users/shredtechular/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T00:58:43Z","updated_at":"2018-04-17T00:58:43Z","author_association":"CONTRIBUTOR","body":"Absolutely, I can definitely add that parameter where it makes sense on existing images.  I will do that along with fixing the conflict."}}
{"actor":{"display_login":"shredtechular"}}