{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/198514646","pull_request_review_id":132457009,"id":198514646,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODUxNDY0Ng==","diff_hunk":"@@ -93,6 +93,8 @@ in stdenv.mkDerivation rec {\n     \"sysconfdir=$(out)/var/lib\"\n   ];\n \n+  binPath = [ iptables iproute pmutils numad numactl bridge-utils dmidecode dnsmasq ebtables ] ++ optionals enableIscsi [ openiscsi ];","path":"pkgs/development/libraries/libvirt/default.nix","position":null,"original_position":4,"commit_id":"3f9d9686377464fe0637c693a0c801b5df75ec34","original_commit_id":"2e9de9b832c85032f994685fc4aeea3a2245f0ff","user":{"login":"ajs124","id":1229027,"node_id":"MDQ6VXNlcjEyMjkwMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1229027?v=4","gravatar_id":"","url":"https://api.github.com/users/ajs124","html_url":"https://github.com/ajs124","followers_url":"https://api.github.com/users/ajs124/followers","following_url":"https://api.github.com/users/ajs124/following{/other_user}","gists_url":"https://api.github.com/users/ajs124/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs124/subscriptions","organizations_url":"https://api.github.com/users/ajs124/orgs","repos_url":"https://api.github.com/users/ajs124/repos","events_url":"https://api.github.com/users/ajs124/events{/privacy}","received_events_url":"https://api.github.com/users/ajs124/received_events","type":"User","site_admin":false},"body":"Like this?","created_at":"2018-06-27T14:24:12Z","updated_at":"2018-06-27T14:24:12Z","html_url":"https://github.com/NixOS/nixpkgs/pull/42643#discussion_r198514646","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42643","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/198514646"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/42643#discussion_r198514646"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42643"}},"in_reply_to_id":198455664},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42643","id":197680745,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjgwNzQ1","html_url":"https://github.com/NixOS/nixpkgs/pull/42643","diff_url":"https://github.com/NixOS/nixpkgs/pull/42643.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/42643.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42643","number":42643,"state":"open","locked":false,"title":"libvirt: fix iscsi storage support","user":{"login":"ajs124","id":1229027,"node_id":"MDQ6VXNlcjEyMjkwMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1229027?v=4","gravatar_id":"","url":"https://api.github.com/users/ajs124","html_url":"https://github.com/ajs124","followers_url":"https://api.github.com/users/ajs124/followers","following_url":"https://api.github.com/users/ajs124/following{/other_user}","gists_url":"https://api.github.com/users/ajs124/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs124/subscriptions","organizations_url":"https://api.github.com/users/ajs124/orgs","repos_url":"https://api.github.com/users/ajs124/repos","events_url":"https://api.github.com/users/ajs124/events{/privacy}","received_events_url":"https://api.github.com/users/ajs124/received_events","type":"User","site_admin":false},"body":"Turns out, I was testing #42545 in a nix-shell and forgot how it handles dependencies and PATH different from environments. Sorry about that.\r\n\r\nI really feel like there should be a huge, red and bold disclaimer somewhere that tells you about this. This is not the first time I've run into problems with this, but I really hope I will manage to get it into my head now.\r\n\r\n###### Things done\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).","created_at":"2018-06-27T10:06:45Z","updated_at":"2018-06-27T14:24:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efc4bdbcdb342a7f9ca724f3cfaa320fe6370d8c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731734101,"node_id":"MDU6TGFiZWw3MzE3MzQxMDE=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%2011-100","name":"10.rebuild-linux: 11-100","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42643/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42643/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42643/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/3f9d9686377464fe0637c693a0c801b5df75ec34","head":{"label":"ajs124:libvirt_iscsi","ref":"libvirt_iscsi","sha":"3f9d9686377464fe0637c693a0c801b5df75ec34","user":{"login":"ajs124","id":1229027,"node_id":"MDQ6VXNlcjEyMjkwMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1229027?v=4","gravatar_id":"","url":"https://api.github.com/users/ajs124","html_url":"https://github.com/ajs124","followers_url":"https://api.github.com/users/ajs124/followers","following_url":"https://api.github.com/users/ajs124/following{/other_user}","gists_url":"https://api.github.com/users/ajs124/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs124/subscriptions","organizations_url":"https://api.github.com/users/ajs124/orgs","repos_url":"https://api.github.com/users/ajs124/repos","events_url":"https://api.github.com/users/ajs124/events{/privacy}","received_events_url":"https://api.github.com/users/ajs124/received_events","type":"User","site_admin":false},"repo":{"id":99602409,"node_id":"MDEwOlJlcG9zaXRvcnk5OTYwMjQwOQ==","name":"nixpkgs","full_name":"ajs124/nixpkgs","owner":{"login":"ajs124","id":1229027,"node_id":"MDQ6VXNlcjEyMjkwMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1229027?v=4","gravatar_id":"","url":"https://api.github.com/users/ajs124","html_url":"https://github.com/ajs124","followers_url":"https://api.github.com/users/ajs124/followers","following_url":"https://api.github.com/users/ajs124/following{/other_user}","gists_url":"https://api.github.com/users/ajs124/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs124/subscriptions","organizations_url":"https://api.github.com/users/ajs124/orgs","repos_url":"https://api.github.com/users/ajs124/repos","events_url":"https://api.github.com/users/ajs124/events{/privacy}","received_events_url":"https://api.github.com/users/ajs124/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajs124/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/ajs124/nixpkgs","forks_url":"https://api.github.com/repos/ajs124/nixpkgs/forks","keys_url":"https://api.github.com/repos/ajs124/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajs124/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajs124/nixpkgs/teams","hooks_url":"https://api.github.com/repos/ajs124/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/ajs124/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/ajs124/nixpkgs/events","assignees_url":"https://api.github.com/repos/ajs124/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/ajs124/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/ajs124/nixpkgs/tags","blobs_url":"https://api.github.com/repos/ajs124/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajs124/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajs124/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajs124/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajs124/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/ajs124/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/ajs124/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/ajs124/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/ajs124/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/ajs124/nixpkgs/subscription","commits_url":"https://api.github.com/repos/ajs124/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajs124/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajs124/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajs124/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajs124/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/ajs124/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajs124/nixpkgs/merges","archive_url":"https://api.github.com/repos/ajs124/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajs124/nixpkgs/downloads","issues_url":"https://api.github.com/repos/ajs124/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/ajs124/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/ajs124/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/ajs124/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajs124/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/ajs124/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/ajs124/nixpkgs/deployments","created_at":"2017-08-07T17:22:19Z","updated_at":"2018-06-07T21:03:59Z","pushed_at":"2018-06-27T14:22:12Z","git_url":"git://github.com/ajs124/nixpkgs.git","ssh_url":"git@github.com:ajs124/nixpkgs.git","clone_url":"https://github.com/ajs124/nixpkgs.git","svn_url":"https://github.com/ajs124/nixpkgs","homepage":null,"size":749672,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"63d82f3a1959f1cc26cddd5631657d2d52bd9b15","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-06-27T13:49:31Z","pushed_at":"2018-06-27T14:22:17Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":811379,"stargazers_count":2530,"watchers_count":2530,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2834,"mirror_url":null,"archived":false,"open_issues_count":2993,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2834,"open_issues":2993,"watchers":2530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42643"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/42643"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/42643"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/42643/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42643/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42643/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/3f9d9686377464fe0637c693a0c801b5df75ec34"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ajs124"}}