{"action":"created","comment":{"url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/comments/224956259","pull_request_review_id":164458469,"id":224956259,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk1NjI1OQ==","diff_hunk":"@@ -165,8 +152,39 @@ public boolean equals(Object obj) {\n                 && filteredGuests.equals(other.filteredGuests);\n     }\n \n+    //=========== Filtered Room List Accessors =============================================================\n+\n+    /**\n+     * Returns an unmodifiable view of the list of {@code Room} backed by the internal list of\n+     * {@code versionedAddressBook}\n+     */\n+    @Override\n+    public ObservableList<Room> getFilteredRoomList() {\n+        return FXCollections.unmodifiableObservableList(filteredRooms);\n+    }\n+\n+    @Override\n+    public void updateFilteredRoomList(Predicate<Room> predicate) {\n+        requireNonNull(predicate);\n+        filteredRooms.setPredicate(predicate);\n+    }\n+\n+    /*\n+    @Override\n+    public RoomList getRoomList() {\n+        return roomList;\n+    }*/\n     @Override\n     public void checkoutRoom(RoomNumber roomNumber) {}\n     @Override\n     public void commitRoomList() {}\n+\n+    /*\n+    @Override\n+    public void displayRoomList(Predicate<Room> predicate) {\n+        //Disable guest list\n+        requireNonNull(predicate);\n+        //filteredGuests.setPredicate(predicate);\n+\n+    }*/","path":"src/main/java/seedu/address/model/ModelManager.java","position":81,"original_position":81,"commit_id":"095617a0635c79de612ba7f846da16c4d0e5b8f9","original_commit_id":"095617a0635c79de612ba7f846da16c4d0e5b8f9","user":{"login":"teowz46","id":32194393,"node_id":"MDQ6VXNlcjMyMTk0Mzkz","avatar_url":"https://avatars3.githubusercontent.com/u/32194393?v=4","gravatar_id":"","url":"https://api.github.com/users/teowz46","html_url":"https://github.com/teowz46","followers_url":"https://api.github.com/users/teowz46/followers","following_url":"https://api.github.com/users/teowz46/following{/other_user}","gists_url":"https://api.github.com/users/teowz46/gists{/gist_id}","starred_url":"https://api.github.com/users/teowz46/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teowz46/subscriptions","organizations_url":"https://api.github.com/users/teowz46/orgs","repos_url":"https://api.github.com/users/teowz46/repos","events_url":"https://api.github.com/users/teowz46/events{/privacy}","received_events_url":"https://api.github.com/users/teowz46/received_events","type":"User","site_admin":false},"body":"what are these two blocks of commented out code for","created_at":"2018-10-13T10:25:36Z","updated_at":"2018-10-13T10:34:18Z","html_url":"https://github.com/CS2103-AY1819S1-F11-2/main/pull/90#discussion_r224956259","pull_request_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/90","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/comments/224956259"},"html":{"href":"https://github.com/CS2103-AY1819S1-F11-2/main/pull/90#discussion_r224956259"},"pull_request":{"href":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/90","id":221135572,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTM1NTcy","html_url":"https://github.com/CS2103-AY1819S1-F11-2/main/pull/90","diff_url":"https://github.com/CS2103-AY1819S1-F11-2/main/pull/90.diff","patch_url":"https://github.com/CS2103-AY1819S1-F11-2/main/pull/90.patch","issue_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/issues/90","number":90,"state":"open","locked":false,"title":"Update list function with flags, add functionality to read and display rooms","user":{"login":"JiaqingTan","id":29890683,"node_id":"MDQ6VXNlcjI5ODkwNjgz","avatar_url":"https://avatars2.githubusercontent.com/u/29890683?v=4","gravatar_id":"","url":"https://api.github.com/users/JiaqingTan","html_url":"https://github.com/JiaqingTan","followers_url":"https://api.github.com/users/JiaqingTan/followers","following_url":"https://api.github.com/users/JiaqingTan/following{/other_user}","gists_url":"https://api.github.com/users/JiaqingTan/gists{/gist_id}","starred_url":"https://api.github.com/users/JiaqingTan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiaqingTan/subscriptions","organizations_url":"https://api.github.com/users/JiaqingTan/orgs","repos_url":"https://api.github.com/users/JiaqingTan/repos","events_url":"https://api.github.com/users/JiaqingTan/events{/privacy}","received_events_url":"https://api.github.com/users/JiaqingTan/received_events","type":"User","site_admin":false},"body":"Its quite challenging right now to place both the listing of guests and rooms under the same column, might need to rewrite and modify a number of files. \r\n\r\nList function is now separated with -g, -r flags. \r\nOn start, both lists will be displayed. After that, one command will toggle off the other list. \r\n\r\nThe program reads in a list of rooms with its details from the \"addressbook.xml\" file, on top of the guests. \r\n\r\n","created_at":"2018-10-08T14:21:48Z","updated_at":"2018-10-13T10:34:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e0435492a34da31ab646f28dd2126a09ae00627","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/90/commits","review_comments_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/90/comments","review_comment_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/issues/90/comments","statuses_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/statuses/095617a0635c79de612ba7f846da16c4d0e5b8f9","head":{"label":"JiaqingTan:master","ref":"master","sha":"095617a0635c79de612ba7f846da16c4d0e5b8f9","user":{"login":"JiaqingTan","id":29890683,"node_id":"MDQ6VXNlcjI5ODkwNjgz","avatar_url":"https://avatars2.githubusercontent.com/u/29890683?v=4","gravatar_id":"","url":"https://api.github.com/users/JiaqingTan","html_url":"https://github.com/JiaqingTan","followers_url":"https://api.github.com/users/JiaqingTan/followers","following_url":"https://api.github.com/users/JiaqingTan/following{/other_user}","gists_url":"https://api.github.com/users/JiaqingTan/gists{/gist_id}","starred_url":"https://api.github.com/users/JiaqingTan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiaqingTan/subscriptions","organizations_url":"https://api.github.com/users/JiaqingTan/orgs","repos_url":"https://api.github.com/users/JiaqingTan/repos","events_url":"https://api.github.com/users/JiaqingTan/events{/privacy}","received_events_url":"https://api.github.com/users/JiaqingTan/received_events","type":"User","site_admin":false},"repo":{"id":149412362,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0MTIzNjI=","name":"main","full_name":"JiaqingTan/main","private":false,"owner":{"login":"JiaqingTan","id":29890683,"node_id":"MDQ6VXNlcjI5ODkwNjgz","avatar_url":"https://avatars2.githubusercontent.com/u/29890683?v=4","gravatar_id":"","url":"https://api.github.com/users/JiaqingTan","html_url":"https://github.com/JiaqingTan","followers_url":"https://api.github.com/users/JiaqingTan/followers","following_url":"https://api.github.com/users/JiaqingTan/following{/other_user}","gists_url":"https://api.github.com/users/JiaqingTan/gists{/gist_id}","starred_url":"https://api.github.com/users/JiaqingTan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiaqingTan/subscriptions","organizations_url":"https://api.github.com/users/JiaqingTan/orgs","repos_url":"https://api.github.com/users/JiaqingTan/repos","events_url":"https://api.github.com/users/JiaqingTan/events{/privacy}","received_events_url":"https://api.github.com/users/JiaqingTan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JiaqingTan/main","description":":ab::four: Address Book sample application (Level 4)","fork":true,"url":"https://api.github.com/repos/JiaqingTan/main","forks_url":"https://api.github.com/repos/JiaqingTan/main/forks","keys_url":"https://api.github.com/repos/JiaqingTan/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JiaqingTan/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JiaqingTan/main/teams","hooks_url":"https://api.github.com/repos/JiaqingTan/main/hooks","issue_events_url":"https://api.github.com/repos/JiaqingTan/main/issues/events{/number}","events_url":"https://api.github.com/repos/JiaqingTan/main/events","assignees_url":"https://api.github.com/repos/JiaqingTan/main/assignees{/user}","branches_url":"https://api.github.com/repos/JiaqingTan/main/branches{/branch}","tags_url":"https://api.github.com/repos/JiaqingTan/main/tags","blobs_url":"https://api.github.com/repos/JiaqingTan/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JiaqingTan/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JiaqingTan/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/JiaqingTan/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JiaqingTan/main/statuses/{sha}","languages_url":"https://api.github.com/repos/JiaqingTan/main/languages","stargazers_url":"https://api.github.com/repos/JiaqingTan/main/stargazers","contributors_url":"https://api.github.com/repos/JiaqingTan/main/contributors","subscribers_url":"https://api.github.com/repos/JiaqingTan/main/subscribers","subscription_url":"https://api.github.com/repos/JiaqingTan/main/subscription","commits_url":"https://api.github.com/repos/JiaqingTan/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/JiaqingTan/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/JiaqingTan/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/JiaqingTan/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/JiaqingTan/main/contents/{+path}","compare_url":"https://api.github.com/repos/JiaqingTan/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JiaqingTan/main/merges","archive_url":"https://api.github.com/repos/JiaqingTan/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JiaqingTan/main/downloads","issues_url":"https://api.github.com/repos/JiaqingTan/main/issues{/number}","pulls_url":"https://api.github.com/repos/JiaqingTan/main/pulls{/number}","milestones_url":"https://api.github.com/repos/JiaqingTan/main/milestones{/number}","notifications_url":"https://api.github.com/repos/JiaqingTan/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JiaqingTan/main/labels{/name}","releases_url":"https://api.github.com/repos/JiaqingTan/main/releases{/id}","deployments_url":"https://api.github.com/repos/JiaqingTan/main/deployments","created_at":"2018-09-19T07:46:17Z","updated_at":"2018-10-12T03:26:02Z","pushed_at":"2018-10-12T03:26:00Z","git_url":"git://github.com/JiaqingTan/main.git","ssh_url":"git@github.com:JiaqingTan/main.git","clone_url":"https://github.com/JiaqingTan/main.git","svn_url":"https://github.com/JiaqingTan/main","homepage":"https://se-edu.github.io/addressbook-level4","size":12036,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CS2103-AY1819S1-F11-2:master","ref":"master","sha":"42208f7c4f03dcc62d4c04de335808820ab2a8d4","user":{"login":"CS2103-AY1819S1-F11-2","id":42995197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTk1MTk3","avatar_url":"https://avatars3.githubusercontent.com/u/42995197?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103-AY1819S1-F11-2","html_url":"https://github.com/CS2103-AY1819S1-F11-2","followers_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/followers","following_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/following{/other_user}","gists_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/subscriptions","organizations_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/orgs","repos_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/repos","events_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/received_events","type":"Organization","site_admin":false},"repo":{"id":147481415,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc0ODE0MTU=","name":"main","full_name":"CS2103-AY1819S1-F11-2/main","private":false,"owner":{"login":"CS2103-AY1819S1-F11-2","id":42995197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTk1MTk3","avatar_url":"https://avatars3.githubusercontent.com/u/42995197?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103-AY1819S1-F11-2","html_url":"https://github.com/CS2103-AY1819S1-F11-2","followers_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/followers","following_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/following{/other_user}","gists_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/subscriptions","organizations_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/orgs","repos_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/repos","events_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103-AY1819S1-F11-2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CS2103-AY1819S1-F11-2/main","description":":ab::four: Address Book sample application (Level 4)","fork":true,"url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main","forks_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/forks","keys_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/teams","hooks_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/hooks","issue_events_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/issues/events{/number}","events_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/events","assignees_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/assignees{/user}","branches_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/branches{/branch}","tags_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/tags","blobs_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/statuses/{sha}","languages_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/languages","stargazers_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/stargazers","contributors_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/contributors","subscribers_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/subscribers","subscription_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/subscription","commits_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/contents/{+path}","compare_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/merges","archive_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/downloads","issues_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/issues{/number}","pulls_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls{/number}","milestones_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/milestones{/number}","notifications_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/labels{/name}","releases_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/releases{/id}","deployments_url":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/deployments","created_at":"2018-09-05T07:56:39Z","updated_at":"2018-10-12T08:24:13Z","pushed_at":"2018-10-13T04:20:00Z","git_url":"git://github.com/CS2103-AY1819S1-F11-2/main.git","ssh_url":"git@github.com:CS2103-AY1819S1-F11-2/main.git","clone_url":"https://github.com/CS2103-AY1819S1-F11-2/main.git","svn_url":"https://github.com/CS2103-AY1819S1-F11-2/main","homepage":"https://se-edu.github.io/addressbook-level4","size":12057,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":64,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/90"},"html":{"href":"https://github.com/CS2103-AY1819S1-F11-2/main/pull/90"},"issue":{"href":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/issues/90"},"comments":{"href":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/CS2103-AY1819S1-F11-2/main/statuses/095617a0635c79de612ba7f846da16c4d0e5b8f9"}},"author_association":"NONE"}}
{"actor":{"display_login":"teowz46"}}