{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/126","repository_url":"https://api.github.com/repos/zooniverse/front-end-monorepo","labels_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/126/comments","events_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/126/events","html_url":"https://github.com/zooniverse/front-end-monorepo/pull/126","id":354815657,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDg4NzAz","number":126,"title":"Updated description of the workflow resource updates","user":{"login":"srallen","id":5016731,"node_id":"MDQ6VXNlcjUwMTY3MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/5016731?v=4","gravatar_id":"","url":"https://api.github.com/users/srallen","html_url":"https://github.com/srallen","followers_url":"https://api.github.com/users/srallen/followers","following_url":"https://api.github.com/users/srallen/following{/other_user}","gists_url":"https://api.github.com/users/srallen/gists{/gist_id}","starred_url":"https://api.github.com/users/srallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srallen/subscriptions","organizations_url":"https://api.github.com/users/srallen/orgs","repos_url":"https://api.github.com/users/srallen/repos","events_url":"https://api.github.com/users/srallen/events{/privacy}","received_events_url":"https://api.github.com/users/srallen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-28T16:47:16Z","updated_at":"2018-09-06T15:17:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/zooniverse/front-end-monorepo/pulls/126","html_url":"https://github.com/zooniverse/front-end-monorepo/pull/126","diff_url":"https://github.com/zooniverse/front-end-monorepo/pull/126.diff","patch_url":"https://github.com/zooniverse/front-end-monorepo/pull/126.patch"},"body":"Package: lib-classifier related proposal\r\n\r\nRelated #123, This updates the ADR-5 proposal with a more detailed description of precisely how steps will be implemented on the workflow resource. \r\n\r\n# Review Checklist\r\n\r\n## General\r\n\r\n- [ ] Are the tests passing locally and on Travis?\r\n- [ ] Is the documentation up to date?\r\n- [ ] Is the changelog updated?\r\n\r\n## Apps\r\n\r\n- [ ] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?\r\n- [ ] Does it work on mobile?\r\n- [ ] Can you `rm -rf node_modules/ && npm install` and app works as expected?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/comments/419133565","html_url":"https://github.com/zooniverse/front-end-monorepo/pull/126#issuecomment-419133565","issue_url":"https://api.github.com/repos/zooniverse/front-end-monorepo/issues/126","id":419133565,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTEzMzU2NQ==","user":{"login":"srallen","id":5016731,"node_id":"MDQ6VXNlcjUwMTY3MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/5016731?v=4","gravatar_id":"","url":"https://api.github.com/users/srallen","html_url":"https://github.com/srallen","followers_url":"https://api.github.com/users/srallen/followers","following_url":"https://api.github.com/users/srallen/following{/other_user}","gists_url":"https://api.github.com/users/srallen/gists{/gist_id}","starred_url":"https://api.github.com/users/srallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srallen/subscriptions","organizations_url":"https://api.github.com/users/srallen/orgs","repos_url":"https://api.github.com/users/srallen/repos","events_url":"https://api.github.com/users/srallen/events{/privacy}","received_events_url":"https://api.github.com/users/srallen/received_events","type":"User","site_admin":false},"created_at":"2018-09-06T15:17:39Z","updated_at":"2018-09-06T15:17:39Z","author_association":"MEMBER","body":"@rogerhutchings and @eatyourgreens I think this is close for being ready for final review. I think we should specify how we'll store steps in the database. Right now I have listed these options:\r\n\r\n> Use a javascript helper library that has full support for map to [serialize](https://github.com/sonnyp/JSON8/tree/master/packages/json8#ooserialize) it as an object (maps are a sub-class of objects) and JSON [parse](https://github.com/sonnyp/JSON8/tree/master/packages/json8#ooparse) back to a map. This would probably be preferred since it would make sure our serialization and parsing is consistent and the keys we are using are strings, so it would be a straight forward conversion to a standard object.\r\n\r\nI think we should go with the JSON8 library. I don't see any reason to DIY here. "}}
{"actor":{"display_login":"srallen"}}