{"action":"opened","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-events-ios/issues/91","repository_url":"https://api.github.com/repos/mapbox/mapbox-events-ios","labels_url":"https://api.github.com/repos/mapbox/mapbox-events-ios/issues/91/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-events-ios/issues/91/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-events-ios/issues/91/events","html_url":"https://github.com/mapbox/mapbox-events-ios/issues/91","id":382464669,"node_id":"MDU6SXNzdWUzODI0NjQ2Njk=","number":91,"title":"Fix variety of minor warnings","user":{"login":"friedbunny","id":1198851,"node_id":"MDQ6VXNlcjExOTg4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1198851?v=4","gravatar_id":"","url":"https://api.github.com/users/friedbunny","html_url":"https://github.com/friedbunny","followers_url":"https://api.github.com/users/friedbunny/followers","following_url":"https://api.github.com/users/friedbunny/following{/other_user}","gists_url":"https://api.github.com/users/friedbunny/gists{/gist_id}","starred_url":"https://api.github.com/users/friedbunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedbunny/subscriptions","organizations_url":"https://api.github.com/users/friedbunny/orgs","repos_url":"https://api.github.com/users/friedbunny/repos","events_url":"https://api.github.com/users/friedbunny/events{/privacy}","received_events_url":"https://api.github.com/users/friedbunny/received_events","type":"User","site_admin":false},"labels":[{"id":497948550,"node_id":"MDU6TGFiZWw0OTc5NDg1NTA=","url":"https://api.github.com/repos/mapbox/mapbox-events-ios/labels/bug","name":"bug","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-20T01:47:57Z","updated_at":"2018-11-20T01:47:57Z","closed_at":null,"author_association":"MEMBER","body":"\r\nEnabling `WARNING_CFLAGS = -Wunused-property-ivar -Wsemicolon-before-method-body -Wmismatched-tags -Wsign-compare` gets us a variety of warnings we should fix:\r\n\r\n```\r\nmapbox-events-ios/MapboxMobileEvents/MMEMetricsManager.m:102:60: Semicolon before method body is ignored\r\nmapbox-events-ios/vendor/TrustKit/Reporting/TSKBackgroundReporter.m:41:77: Semicolon before method body is ignored\r\nmapbox-events-ios/vendor/TrustKit/Reporting/TSKPinFailureReport.m:57:25: Semicolon before method body is ignored\r\nmapbox-events-ios/MapboxMobileEvents/MMEEvent.m:54:120: Semicolon before method body is ignored\r\nmapbox-events-ios/MapboxMobileEvents/MMEDependencyManager.m:16:47: Semicolon before method body is ignored\r\n\r\nmapbox-events-ios/MapboxMobileEvents/MMEEventLogger.m:55:1: Ivar '_timeForNewLogFile' which backs the property is not referenced in this property's accessor\r\n```\r\n\r\nThese are all trivial issues, but several of them exist in TrustKit, so we’ll have to decide on a strategy for how to fix/handle those.\r\n\r\n/cc @rclee @andrlee @zugaldia @chloekraw "}}
{"actor":{"display_login":"friedbunny"}}