{"action":"created","issue":{"url":"https://api.github.com/repos/balderdashy/sails/issues/4455","repository_url":"https://api.github.com/repos/balderdashy/sails","labels_url":"https://api.github.com/repos/balderdashy/sails/issues/4455/labels{/name}","comments_url":"https://api.github.com/repos/balderdashy/sails/issues/4455/comments","events_url":"https://api.github.com/repos/balderdashy/sails/issues/4455/events","html_url":"https://github.com/balderdashy/sails/issues/4455","id":333227619,"node_id":"MDU6SXNzdWUzMzMyMjc2MTk=","number":4455,"title":"Model primary key now mandatory?","user":{"login":"danielsharvey","id":12858056,"node_id":"MDQ6VXNlcjEyODU4MDU2","avatar_url":"https://avatars3.githubusercontent.com/u/12858056?v=4","gravatar_id":"","url":"https://api.github.com/users/danielsharvey","html_url":"https://github.com/danielsharvey","followers_url":"https://api.github.com/users/danielsharvey/followers","following_url":"https://api.github.com/users/danielsharvey/following{/other_user}","gists_url":"https://api.github.com/users/danielsharvey/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsharvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsharvey/subscriptions","organizations_url":"https://api.github.com/users/danielsharvey/orgs","repos_url":"https://api.github.com/users/danielsharvey/repos","events_url":"https://api.github.com/users/danielsharvey/events{/privacy}","received_events_url":"https://api.github.com/users/danielsharvey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-18T11:16:40Z","updated_at":"2018-06-18T11:16:54Z","closed_at":null,"author_association":"NONE","body":"<!--\r\n======================================================\r\nHELLO, and welcome to the (experimental) Sailsbot\r\nissue-submission system.  If you encounter any\r\nproblems with this system, please contact us directly\r\nat http://sailsjs.com/contact.\r\n\r\nFIRST THINGS FIRST: before posting, please carefully\r\nread the contribution guide (http://bit.ly/sails-issue-guide),\r\nparticularly if this is a security issue or an issue of a\r\nnon-technical nature (Github org issues, code of conduct\r\nissues, etc.).  Those should be sent directly at\r\nhttp://sailsjs.com/contact.\r\n\r\nNOW THEN: please fill out the following info\r\n(Don't change text between **)\r\n======================================================\r\n### BEGIN VERSION INFO ###\r\n-->\r\n\r\n**Sails version**: v1.0.2\r\n**Node version**: v10.2.1\r\n**NPM version**: 6.1.0\r\n**DB adapter name**: N/A\r\n**DB adapter version**: N/A\r\n**Operating system**: MacOS 10.13.5\r\n\r\n<!--\r\n### END VERSION INFO ###\r\n======================================================\r\nGREAT! - Now read carefully\r\n(Sailsbot will know if you don't)!\r\n======================================================\r\n\r\nBefore you submit an issue for Sails, please make sure you have read the issue contribution guide (http://bit.ly/sails-issue-guide) carefully, and then verify the following by typing an X in between each set of [ ] brackets below (don't make any other changes to the text!):\r\n\r\n### BEGIN PLEDGE ###\r\n- [X] I am experiencing a concrete technical issue (aka a bug) with Sails (ideas and feature proposals should follow the guide for proposing features and enhancements (http://bit.ly/sails-feature-guide), which involves making a pull request).  If you're not 100% certain whether it's a bug or not, that's okay--you may continue.  The worst that can happen is that the issue will be closed and we'll point you in the right direction.\r\n\r\n- [X] I am not asking a question about how to use Sails or about whether or not Sails has a certain feature (please refer to the documentation(http://sailsjs.com), or post on http://stackoverflow.com, our Google Group (http://bit.ly/sails-google-group) or our live chat (https://gitter.im/balderdashy/sails).\r\n\r\n- [X] I have already searched for related issues, and found none open (if you found a related _closed_ issue, please link to it in your post).\r\n\r\n- [X] My issue title is concise, on-topic and polite (\"jst.js being removed from layout.ejs on lift\" is good; \"templates dont work\" or \"why is sails dumb\" are not so good).\r\n\r\n- [X] I have tried all the following (if relevant) and my issue remains:\r\n  - Make sure you have the right app lifted.\r\n  - Make sure you've killed the Sails server with CTRL+C and started it again.\r\n  - Make sure you closed any open browser tabs pointed at localhost before starting Sails.\r\n  - Make sure you do not have any other Sails apps running in other terminal windows.\r\n  - Make sure the app you are using to reproduce the issue has a clean node_modules/ directory, meaning:\r\n    * no dependencies are linked (e.g. you haven't run npm link foo)\r\n    * that you haven't made any inline changes to files in the node_modules/ folder\r\n    * that you don't have any weird global dependency loops. The easiest way to double-check any of the above, if you aren't sure, is to run: rm -rf node_modules && npm cache clear && npm install.\r\n\r\nand finally...\r\n- [X] **I can provide steps to reproduce this issue that others can follow.**\r\n\r\nIdeally, this involves creating a new repo that demonstrates the problem (see instructions at http://bit.ly/sails-issue-repro).  Even though your issue may seem so simple to reproduce that a new repo is unnecessary, you'd be surprised how many solutions present themselves when you start from `sails new` and attempt to recreate your issue from scratch in a new app.  This ensures that the real issue isn't in your user code (a forgotten policy file, perhaps?) or in a third-party module.  If you're absolutely _convinced_ that a new repo is unnecessary, provide clear, concise and _specific_ steps to reproduce the problem in your post (not \"create a model then do blueprint create\").\r\n### END PLEDGE ###\r\n\r\nOKAY--THANKS FOR READING!  Continue posting details of your issue below. -->\r\n<hr/>\r\n\r\nIs the primary key now mandatory?\r\n\r\nThe documentation does not explicitly say so, although the error messages produced by the ORM hook imply so.\r\n\r\nCan this be formally confirmed?\r\n\r\nIf it is possible (table with no primary key), how? I have a number of models in 0.12 that contained association mappings which did not have or require primary keys. I've tried `primaryKey: false` and `primaryKey: null`.\r\n\r\nIf a primary key is now mandatory, I'd be interested in the reasons.\r\n\r\nI'm happy to submit a PR updating the documentation either way. I'd suggest these two places should note this:\r\n1. Models settings: https://sailsjs.com/documentation/concepts/models-and-orm/model-settings#?primarykey\r\n2. Upgrading to v1.0: https://sailsjs.com/documentation/upgrading/to-v-1-0#?step-4-adopt-the-new-release-of-waterline-orm"},"comment":{"url":"https://api.github.com/repos/balderdashy/sails/issues/comments/398021452","html_url":"https://github.com/balderdashy/sails/issues/4455#issuecomment-398021452","issue_url":"https://api.github.com/repos/balderdashy/sails/issues/4455","id":398021452,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODAyMTQ1Mg==","user":{"login":"sailsbot","id":14700466,"node_id":"MDQ6VXNlcjE0NzAwNDY2","avatar_url":"https://avatars2.githubusercontent.com/u/14700466?v=4","gravatar_id":"","url":"https://api.github.com/users/sailsbot","html_url":"https://github.com/sailsbot","followers_url":"https://api.github.com/users/sailsbot/followers","following_url":"https://api.github.com/users/sailsbot/following{/other_user}","gists_url":"https://api.github.com/users/sailsbot/gists{/gist_id}","starred_url":"https://api.github.com/users/sailsbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailsbot/subscriptions","organizations_url":"https://api.github.com/users/sailsbot/orgs","repos_url":"https://api.github.com/users/sailsbot/repos","events_url":"https://api.github.com/users/sailsbot/events{/privacy}","received_events_url":"https://api.github.com/users/sailsbot/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T11:16:54Z","updated_at":"2018-06-18T11:16:54Z","author_association":"NONE","body":"@danielsharvey Thanks for posting, we'll take a look as soon as possible.\n\n---\n\nFor help with questions about Sails, [click here](http://sailsjs.com/support).  If you&rsquo;re interested in hiring @sailsbot and her minions in Austin, [click here](http://sailsjs.com/studio)."}}
{"actor":{"display_login":"sailsbot"}}