{"action":"created","issue":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/3023","repository_url":"https://api.github.com/repos/mitmproxy/mitmproxy","labels_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/3023/labels{/name}","comments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/3023/comments","events_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/3023/events","html_url":"https://github.com/mitmproxy/mitmproxy/issues/3023","id":310045957,"number":3023,"title":"Custom keybindings with modifier keys don’t work","user":{"login":"vfaronov","id":300211,"avatar_url":"https://avatars0.githubusercontent.com/u/300211?v=4","gravatar_id":"","url":"https://api.github.com/users/vfaronov","html_url":"https://github.com/vfaronov","followers_url":"https://api.github.com/users/vfaronov/followers","following_url":"https://api.github.com/users/vfaronov/following{/other_user}","gists_url":"https://api.github.com/users/vfaronov/gists{/gist_id}","starred_url":"https://api.github.com/users/vfaronov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vfaronov/subscriptions","organizations_url":"https://api.github.com/users/vfaronov/orgs","repos_url":"https://api.github.com/users/vfaronov/repos","events_url":"https://api.github.com/users/vfaronov/events{/privacy}","received_events_url":"https://api.github.com/users/vfaronov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-30T11:40:25Z","updated_at":"2018-03-30T16:04:59Z","closed_at":null,"author_association":"NONE","body":"##### Steps to reproduce the problem:\r\n\r\n1. Run `mitmproxy`\r\n2. Type `:console.key.bind global \"ctrl q\" console.exit` to add a keybinding\r\n3. Type `?` to open the keybindings list\r\n4. Scroll down to check that Ctrl+Q has been registered as a keybinding along with the built-in Ctrl+B and Ctrl+F\r\n4. Press Ctrl+Q\r\n\r\nThis should trigger the `console.exit` command and thus exit mitmproxy. Instead, nothing happens.\r\n\r\n##### Any other comments? What have you tried so far?\r\n\r\nSame if I replace `ctrl q` with `shift pgup`, so not limited to Ctrl.\r\n\r\n##### System information\r\n\r\nMitmproxy: 3.0.3 binary\r\nPython:    3.5.2\r\nOpenSSL:   OpenSSL 1.1.0g  2 Nov 2017\r\nPlatform:  Linux-4.4.0-116-generic-x86_64-with-debian-stretch-sid\r\n\r\nRunning in xfce4-terminal 0.6.3"},"comment":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/comments/377557972","html_url":"https://github.com/mitmproxy/mitmproxy/issues/3023#issuecomment-377557972","issue_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/3023","id":377557972,"user":{"login":"vfaronov","id":300211,"avatar_url":"https://avatars0.githubusercontent.com/u/300211?v=4","gravatar_id":"","url":"https://api.github.com/users/vfaronov","html_url":"https://github.com/vfaronov","followers_url":"https://api.github.com/users/vfaronov/followers","following_url":"https://api.github.com/users/vfaronov/following{/other_user}","gists_url":"https://api.github.com/users/vfaronov/gists{/gist_id}","starred_url":"https://api.github.com/users/vfaronov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vfaronov/subscriptions","organizations_url":"https://api.github.com/users/vfaronov/orgs","repos_url":"https://api.github.com/users/vfaronov/repos","events_url":"https://api.github.com/users/vfaronov/events{/privacy}","received_events_url":"https://api.github.com/users/vfaronov/received_events","type":"User","site_admin":false},"created_at":"2018-03-30T16:04:58Z","updated_at":"2018-03-30T16:04:58Z","author_association":"NONE","body":"> documenting this. Or, furthermore, identify the 'faulty' key combinations and notice the user\r\n\r\nSounds good enough to me. Feedback would be helpful in any case, because right now you can e.g. bind `F4` and wonder why it does nothing (because you have to bind `f4` instead)."}}
{"actor":{"display_login":"vfaronov"}}