{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/218796502","pull_request_review_id":156811338,"id":218796502,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODc5NjUwMg==","diff_hunk":"@@ -0,0 +1,16 @@\n+import jsftp from 'jsftp';\n+import jsftpLsr from 'jsftp-lsr';","path":"types/jsftp-lsr/jsftp-lsr-tests.ts","position":null,"original_position":2,"commit_id":"f8842c427c3084bd271e09e35b13a8262e588513","original_commit_id":"5ece2a61c75d208d1b7d3abb5051eaec7ef7bd62","user":{"login":"xyleen","id":8103363,"node_id":"MDQ6VXNlcjgxMDMzNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8103363?v=4","gravatar_id":"","url":"https://api.github.com/users/xyleen","html_url":"https://github.com/xyleen","followers_url":"https://api.github.com/users/xyleen/followers","following_url":"https://api.github.com/users/xyleen/following{/other_user}","gists_url":"https://api.github.com/users/xyleen/gists{/gist_id}","starred_url":"https://api.github.com/users/xyleen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xyleen/subscriptions","organizations_url":"https://api.github.com/users/xyleen/orgs","repos_url":"https://api.github.com/users/xyleen/repos","events_url":"https://api.github.com/users/xyleen/events{/privacy}","received_events_url":"https://api.github.com/users/xyleen/received_events","type":"User","site_admin":false},"body":"I've updated the code according to your suggestions. Also, I've made changes to `jsftp` typings, in order to avoid:\r\n```\r\nimport jsftp = require('jsftp');\r\nconst ftp = new jsftp.default();\r\n```\r\nAlso, `jsftp` typings should now be more compliant with the [class template](https://www.typescriptlang.org/docs/handbook/declaration-files/templates/module-class-d-ts.html).","created_at":"2018-09-19T13:11:59Z","updated_at":"2018-09-19T13:11:59Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28984#discussion_r218796502","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28984","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/218796502"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28984#discussion_r218796502"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28984"}},"in_reply_to_id":218578063},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28984","id":216365288,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzY1Mjg4","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28984","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28984.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28984.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28984","number":28984,"state":"open","locked":false,"title":"[jsftp-lsr] Add types for jsftp-lsr","user":{"login":"xyleen","id":8103363,"node_id":"MDQ6VXNlcjgxMDMzNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8103363?v=4","gravatar_id":"","url":"https://api.github.com/users/xyleen","html_url":"https://github.com/xyleen","followers_url":"https://api.github.com/users/xyleen/followers","following_url":"https://api.github.com/users/xyleen/following{/other_user}","gists_url":"https://api.github.com/users/xyleen/gists{/gist_id}","starred_url":"https://api.github.com/users/xyleen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xyleen/subscriptions","organizations_url":"https://api.github.com/users/xyleen/orgs","repos_url":"https://api.github.com/users/xyleen/repos","events_url":"https://api.github.com/users/xyleen/events{/privacy}","received_events_url":"https://api.github.com/users/xyleen/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [x] The package does not already provide its own types, or cannot have its `.d.ts` files generated via `--declaration`\r\n- [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [x] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [x] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, `strictNullChecks`, and `strictFunctionTypes` set to `true`.\r\n","created_at":"2018-09-18T16:13:30Z","updated_at":"2018-09-19T13:11:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a2e44c398f997f3cbf5746ed30155333e284317","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":646788888,"node_id":"MDU6TGFiZWw2NDY3ODg4ODg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/New%20Definition","name":"New Definition","color":"4eca56","default":false},{"id":395679059,"node_id":"MDU6TGFiZWwzOTU2NzkwNTk=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28984/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28984/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28984/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/f8842c427c3084bd271e09e35b13a8262e588513","head":{"label":"xyleen:jsftp-lsr","ref":"jsftp-lsr","sha":"f8842c427c3084bd271e09e35b13a8262e588513","user":{"login":"xyleen","id":8103363,"node_id":"MDQ6VXNlcjgxMDMzNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8103363?v=4","gravatar_id":"","url":"https://api.github.com/users/xyleen","html_url":"https://github.com/xyleen","followers_url":"https://api.github.com/users/xyleen/followers","following_url":"https://api.github.com/users/xyleen/following{/other_user}","gists_url":"https://api.github.com/users/xyleen/gists{/gist_id}","starred_url":"https://api.github.com/users/xyleen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xyleen/subscriptions","organizations_url":"https://api.github.com/users/xyleen/orgs","repos_url":"https://api.github.com/users/xyleen/repos","events_url":"https://api.github.com/users/xyleen/events{/privacy}","received_events_url":"https://api.github.com/users/xyleen/received_events","type":"User","site_admin":false},"repo":{"id":95567681,"node_id":"MDEwOlJlcG9zaXRvcnk5NTU2NzY4MQ==","name":"DefinitelyTyped","full_name":"xyleen/DefinitelyTyped","private":false,"owner":{"login":"xyleen","id":8103363,"node_id":"MDQ6VXNlcjgxMDMzNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/8103363?v=4","gravatar_id":"","url":"https://api.github.com/users/xyleen","html_url":"https://github.com/xyleen","followers_url":"https://api.github.com/users/xyleen/followers","following_url":"https://api.github.com/users/xyleen/following{/other_user}","gists_url":"https://api.github.com/users/xyleen/gists{/gist_id}","starred_url":"https://api.github.com/users/xyleen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xyleen/subscriptions","organizations_url":"https://api.github.com/users/xyleen/orgs","repos_url":"https://api.github.com/users/xyleen/repos","events_url":"https://api.github.com/users/xyleen/events{/privacy}","received_events_url":"https://api.github.com/users/xyleen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xyleen/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/xyleen/DefinitelyTyped","forks_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/xyleen/DefinitelyTyped/deployments","created_at":"2017-06-27T14:32:41Z","updated_at":"2018-09-18T14:17:50Z","pushed_at":"2018-09-19T13:02:55Z","git_url":"git://github.com/xyleen/DefinitelyTyped.git","ssh_url":"git@github.com:xyleen/DefinitelyTyped.git","clone_url":"https://github.com/xyleen/DefinitelyTyped.git","svn_url":"https://github.com/xyleen/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":355937,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"b697ec8a1bb26313b4d56a0af66b9c45c9920cef","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-09-19T12:33:45Z","pushed_at":"2018-09-19T13:03:01Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":355710,"stargazers_count":17500,"watchers_count":17500,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14586,"mirror_url":null,"archived":false,"open_issues_count":2366,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14586,"open_issues":2366,"watchers":17500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28984"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28984"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28984"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28984/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28984/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28984/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/f8842c427c3084bd271e09e35b13a8262e588513"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xyleen"}}