{"action":"created","comment":{"url":"https://api.github.com/repos/graphite-project/whisper/pulls/comments/242267686","pull_request_review_id":185738942,"id":242267686,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjI2NzY4Ng==","diff_hunk":"@@ -170,6 +172,11 @@ def cli_opts():\n     parser.add_argument('--aggregate', action='store_true', dest='aggregate',\n                         help=\"Passed through to whisper-resize.py, roll up values\",\n                         default=False)\n+    parser.add_argument('--bindir', action='store', dest='bindir',\n+                        help=\"The root path to whisper-resize.py and whisper-info.py\",\n+                        default='/opt/graphite/bin')\n+    parser.add_argument('--sleep', action='store', dest='sleep',\n+                        help=\"Sleep this amount of time in seconds between metric comparisons\")","path":"contrib/update-storage-times.py","position":51,"original_position":51,"commit_id":"669da5e985c64e0d76744e03b5f359ce4f28a6f9","original_commit_id":"669da5e985c64e0d76744e03b5f359ce4f28a6f9","user":{"login":"piotr1212","id":2911066,"node_id":"MDQ6VXNlcjI5MTEwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2911066?v=4","gravatar_id":"","url":"https://api.github.com/users/piotr1212","html_url":"https://github.com/piotr1212","followers_url":"https://api.github.com/users/piotr1212/followers","following_url":"https://api.github.com/users/piotr1212/following{/other_user}","gists_url":"https://api.github.com/users/piotr1212/gists{/gist_id}","starred_url":"https://api.github.com/users/piotr1212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotr1212/subscriptions","organizations_url":"https://api.github.com/users/piotr1212/orgs","repos_url":"https://api.github.com/users/piotr1212/repos","events_url":"https://api.github.com/users/piotr1212/events{/privacy}","received_events_url":"https://api.github.com/users/piotr1212/received_events","type":"User","site_admin":false},"body":"Think you accidentally added this sleep argument which doesn't do anything. Could you please remove the argument, or add the feature if you have it ready?","created_at":"2018-12-17T18:40:49Z","updated_at":"2018-12-17T18:41:02Z","html_url":"https://github.com/graphite-project/whisper/pull/265#discussion_r242267686","pull_request_url":"https://api.github.com/repos/graphite-project/whisper/pulls/265","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/comments/242267686"},"html":{"href":"https://github.com/graphite-project/whisper/pull/265#discussion_r242267686"},"pull_request":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/graphite-project/whisper/pulls/265","id":238222126,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjIyMTI2","html_url":"https://github.com/graphite-project/whisper/pull/265","diff_url":"https://github.com/graphite-project/whisper/pull/265.diff","patch_url":"https://github.com/graphite-project/whisper/pull/265.patch","issue_url":"https://api.github.com/repos/graphite-project/whisper/issues/265","number":265,"state":"open","locked":false,"title":"update-storage-times.py enhancements","user":{"login":"n0coast","id":1903102,"node_id":"MDQ6VXNlcjE5MDMxMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1903102?v=4","gravatar_id":"","url":"https://api.github.com/users/n0coast","html_url":"https://github.com/n0coast","followers_url":"https://api.github.com/users/n0coast/followers","following_url":"https://api.github.com/users/n0coast/following{/other_user}","gists_url":"https://api.github.com/users/n0coast/gists{/gist_id}","starred_url":"https://api.github.com/users/n0coast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n0coast/subscriptions","organizations_url":"https://api.github.com/users/n0coast/orgs","repos_url":"https://api.github.com/users/n0coast/repos","events_url":"https://api.github.com/users/n0coast/events{/privacy}","received_events_url":"https://api.github.com/users/n0coast/received_events","type":"User","site_admin":false},"body":"I have added an optional 'bindir' parameter to allow usage of whisper-resize.py and whisper-info.py located in a different directory. Because whisper-resize.py writes the files using the owner/group/umask of the process running the command, and update-storage-times.py throws an error if you are not root I added code to store that info from the original file and apply it to the newly created whisper file after whisper-resize.py is complete. Lastly since storage-schemas are written in dot-delimeted format I updated the matching logic to transpose forward slashes in the metric name to dots for the matching portion.","created_at":"2018-12-12T23:55:05Z","updated_at":"2018-12-17T18:41:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e05261c7c880d1773284f4564e3d70cc652f08b0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"iksaif","id":1032963,"node_id":"MDQ6VXNlcjEwMzI5NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1032963?v=4","gravatar_id":"","url":"https://api.github.com/users/iksaif","html_url":"https://github.com/iksaif","followers_url":"https://api.github.com/users/iksaif/followers","following_url":"https://api.github.com/users/iksaif/following{/other_user}","gists_url":"https://api.github.com/users/iksaif/gists{/gist_id}","starred_url":"https://api.github.com/users/iksaif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iksaif/subscriptions","organizations_url":"https://api.github.com/users/iksaif/orgs","repos_url":"https://api.github.com/users/iksaif/repos","events_url":"https://api.github.com/users/iksaif/events{/privacy}","received_events_url":"https://api.github.com/users/iksaif/received_events","type":"User","site_admin":false},{"login":"DanCech","id":1443603,"node_id":"MDQ6VXNlcjE0NDM2MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1443603?v=4","gravatar_id":"","url":"https://api.github.com/users/DanCech","html_url":"https://github.com/DanCech","followers_url":"https://api.github.com/users/DanCech/followers","following_url":"https://api.github.com/users/DanCech/following{/other_user}","gists_url":"https://api.github.com/users/DanCech/gists{/gist_id}","starred_url":"https://api.github.com/users/DanCech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanCech/subscriptions","organizations_url":"https://api.github.com/users/DanCech/orgs","repos_url":"https://api.github.com/users/DanCech/repos","events_url":"https://api.github.com/users/DanCech/events{/privacy}","received_events_url":"https://api.github.com/users/DanCech/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":4571140,"node_id":"MDU6TGFiZWw0NTcxMTQw","url":"https://api.github.com/repos/graphite-project/whisper/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/graphite-project/whisper/milestones/2","html_url":"https://github.com/graphite-project/whisper/milestone/2","labels_url":"https://api.github.com/repos/graphite-project/whisper/milestones/2/labels","id":3896689,"node_id":"MDk6TWlsZXN0b25lMzg5NjY4OQ==","number":2,"title":"1.1.5","description":"","creator":{"login":"deniszh","id":1227222,"node_id":"MDQ6VXNlcjEyMjcyMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1227222?v=4","gravatar_id":"","url":"https://api.github.com/users/deniszh","html_url":"https://github.com/deniszh","followers_url":"https://api.github.com/users/deniszh/followers","following_url":"https://api.github.com/users/deniszh/following{/other_user}","gists_url":"https://api.github.com/users/deniszh/gists{/gist_id}","starred_url":"https://api.github.com/users/deniszh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deniszh/subscriptions","organizations_url":"https://api.github.com/users/deniszh/orgs","repos_url":"https://api.github.com/users/deniszh/repos","events_url":"https://api.github.com/users/deniszh/events{/privacy}","received_events_url":"https://api.github.com/users/deniszh/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2018-12-13T13:57:45Z","updated_at":"2018-12-16T11:49:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/graphite-project/whisper/pulls/265/commits","review_comments_url":"https://api.github.com/repos/graphite-project/whisper/pulls/265/comments","review_comment_url":"https://api.github.com/repos/graphite-project/whisper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphite-project/whisper/issues/265/comments","statuses_url":"https://api.github.com/repos/graphite-project/whisper/statuses/669da5e985c64e0d76744e03b5f359ce4f28a6f9","head":{"label":"n0coast:master","ref":"master","sha":"669da5e985c64e0d76744e03b5f359ce4f28a6f9","user":{"login":"n0coast","id":1903102,"node_id":"MDQ6VXNlcjE5MDMxMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1903102?v=4","gravatar_id":"","url":"https://api.github.com/users/n0coast","html_url":"https://github.com/n0coast","followers_url":"https://api.github.com/users/n0coast/followers","following_url":"https://api.github.com/users/n0coast/following{/other_user}","gists_url":"https://api.github.com/users/n0coast/gists{/gist_id}","starred_url":"https://api.github.com/users/n0coast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n0coast/subscriptions","organizations_url":"https://api.github.com/users/n0coast/orgs","repos_url":"https://api.github.com/users/n0coast/repos","events_url":"https://api.github.com/users/n0coast/events{/privacy}","received_events_url":"https://api.github.com/users/n0coast/received_events","type":"User","site_admin":false},"repo":{"id":161409754,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE0MDk3NTQ=","name":"whisper","full_name":"n0coast/whisper","private":false,"owner":{"login":"n0coast","id":1903102,"node_id":"MDQ6VXNlcjE5MDMxMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1903102?v=4","gravatar_id":"","url":"https://api.github.com/users/n0coast","html_url":"https://github.com/n0coast","followers_url":"https://api.github.com/users/n0coast/followers","following_url":"https://api.github.com/users/n0coast/following{/other_user}","gists_url":"https://api.github.com/users/n0coast/gists{/gist_id}","starred_url":"https://api.github.com/users/n0coast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n0coast/subscriptions","organizations_url":"https://api.github.com/users/n0coast/orgs","repos_url":"https://api.github.com/users/n0coast/repos","events_url":"https://api.github.com/users/n0coast/events{/privacy}","received_events_url":"https://api.github.com/users/n0coast/received_events","type":"User","site_admin":false},"html_url":"https://github.com/n0coast/whisper","description":"Whisper is a file-based time-series database format for Graphite.","fork":true,"url":"https://api.github.com/repos/n0coast/whisper","forks_url":"https://api.github.com/repos/n0coast/whisper/forks","keys_url":"https://api.github.com/repos/n0coast/whisper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n0coast/whisper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n0coast/whisper/teams","hooks_url":"https://api.github.com/repos/n0coast/whisper/hooks","issue_events_url":"https://api.github.com/repos/n0coast/whisper/issues/events{/number}","events_url":"https://api.github.com/repos/n0coast/whisper/events","assignees_url":"https://api.github.com/repos/n0coast/whisper/assignees{/user}","branches_url":"https://api.github.com/repos/n0coast/whisper/branches{/branch}","tags_url":"https://api.github.com/repos/n0coast/whisper/tags","blobs_url":"https://api.github.com/repos/n0coast/whisper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n0coast/whisper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n0coast/whisper/git/refs{/sha}","trees_url":"https://api.github.com/repos/n0coast/whisper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n0coast/whisper/statuses/{sha}","languages_url":"https://api.github.com/repos/n0coast/whisper/languages","stargazers_url":"https://api.github.com/repos/n0coast/whisper/stargazers","contributors_url":"https://api.github.com/repos/n0coast/whisper/contributors","subscribers_url":"https://api.github.com/repos/n0coast/whisper/subscribers","subscription_url":"https://api.github.com/repos/n0coast/whisper/subscription","commits_url":"https://api.github.com/repos/n0coast/whisper/commits{/sha}","git_commits_url":"https://api.github.com/repos/n0coast/whisper/git/commits{/sha}","comments_url":"https://api.github.com/repos/n0coast/whisper/comments{/number}","issue_comment_url":"https://api.github.com/repos/n0coast/whisper/issues/comments{/number}","contents_url":"https://api.github.com/repos/n0coast/whisper/contents/{+path}","compare_url":"https://api.github.com/repos/n0coast/whisper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n0coast/whisper/merges","archive_url":"https://api.github.com/repos/n0coast/whisper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n0coast/whisper/downloads","issues_url":"https://api.github.com/repos/n0coast/whisper/issues{/number}","pulls_url":"https://api.github.com/repos/n0coast/whisper/pulls{/number}","milestones_url":"https://api.github.com/repos/n0coast/whisper/milestones{/number}","notifications_url":"https://api.github.com/repos/n0coast/whisper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n0coast/whisper/labels{/name}","releases_url":"https://api.github.com/repos/n0coast/whisper/releases{/id}","deployments_url":"https://api.github.com/repos/n0coast/whisper/deployments","created_at":"2018-12-12T00:12:39Z","updated_at":"2018-12-17T17:07:59Z","pushed_at":"2018-12-17T17:07:57Z","git_url":"git://github.com/n0coast/whisper.git","ssh_url":"git@github.com:n0coast/whisper.git","clone_url":"https://github.com/n0coast/whisper.git","svn_url":"https://github.com/n0coast/whisper","homepage":"http://graphite.readthedocs.org/","size":432,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphite-project:master","ref":"master","sha":"60c8b9bab5dff6bdafca6880aafca5fcadc0aa77","user":{"login":"graphite-project","id":1714806,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTQ4MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1714806?v=4","gravatar_id":"","url":"https://api.github.com/users/graphite-project","html_url":"https://github.com/graphite-project","followers_url":"https://api.github.com/users/graphite-project/followers","following_url":"https://api.github.com/users/graphite-project/following{/other_user}","gists_url":"https://api.github.com/users/graphite-project/gists{/gist_id}","starred_url":"https://api.github.com/users/graphite-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphite-project/subscriptions","organizations_url":"https://api.github.com/users/graphite-project/orgs","repos_url":"https://api.github.com/users/graphite-project/repos","events_url":"https://api.github.com/users/graphite-project/events{/privacy}","received_events_url":"https://api.github.com/users/graphite-project/received_events","type":"Organization","site_admin":false},"repo":{"id":4254334,"node_id":"MDEwOlJlcG9zaXRvcnk0MjU0MzM0","name":"whisper","full_name":"graphite-project/whisper","private":false,"owner":{"login":"graphite-project","id":1714806,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTQ4MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1714806?v=4","gravatar_id":"","url":"https://api.github.com/users/graphite-project","html_url":"https://github.com/graphite-project","followers_url":"https://api.github.com/users/graphite-project/followers","following_url":"https://api.github.com/users/graphite-project/following{/other_user}","gists_url":"https://api.github.com/users/graphite-project/gists{/gist_id}","starred_url":"https://api.github.com/users/graphite-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphite-project/subscriptions","organizations_url":"https://api.github.com/users/graphite-project/orgs","repos_url":"https://api.github.com/users/graphite-project/repos","events_url":"https://api.github.com/users/graphite-project/events{/privacy}","received_events_url":"https://api.github.com/users/graphite-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/graphite-project/whisper","description":"Whisper is a file-based time-series database format for Graphite.","fork":false,"url":"https://api.github.com/repos/graphite-project/whisper","forks_url":"https://api.github.com/repos/graphite-project/whisper/forks","keys_url":"https://api.github.com/repos/graphite-project/whisper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphite-project/whisper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphite-project/whisper/teams","hooks_url":"https://api.github.com/repos/graphite-project/whisper/hooks","issue_events_url":"https://api.github.com/repos/graphite-project/whisper/issues/events{/number}","events_url":"https://api.github.com/repos/graphite-project/whisper/events","assignees_url":"https://api.github.com/repos/graphite-project/whisper/assignees{/user}","branches_url":"https://api.github.com/repos/graphite-project/whisper/branches{/branch}","tags_url":"https://api.github.com/repos/graphite-project/whisper/tags","blobs_url":"https://api.github.com/repos/graphite-project/whisper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphite-project/whisper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphite-project/whisper/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphite-project/whisper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphite-project/whisper/statuses/{sha}","languages_url":"https://api.github.com/repos/graphite-project/whisper/languages","stargazers_url":"https://api.github.com/repos/graphite-project/whisper/stargazers","contributors_url":"https://api.github.com/repos/graphite-project/whisper/contributors","subscribers_url":"https://api.github.com/repos/graphite-project/whisper/subscribers","subscription_url":"https://api.github.com/repos/graphite-project/whisper/subscription","commits_url":"https://api.github.com/repos/graphite-project/whisper/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphite-project/whisper/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphite-project/whisper/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphite-project/whisper/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphite-project/whisper/contents/{+path}","compare_url":"https://api.github.com/repos/graphite-project/whisper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphite-project/whisper/merges","archive_url":"https://api.github.com/repos/graphite-project/whisper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphite-project/whisper/downloads","issues_url":"https://api.github.com/repos/graphite-project/whisper/issues{/number}","pulls_url":"https://api.github.com/repos/graphite-project/whisper/pulls{/number}","milestones_url":"https://api.github.com/repos/graphite-project/whisper/milestones{/number}","notifications_url":"https://api.github.com/repos/graphite-project/whisper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphite-project/whisper/labels{/name}","releases_url":"https://api.github.com/repos/graphite-project/whisper/releases{/id}","deployments_url":"https://api.github.com/repos/graphite-project/whisper/deployments","created_at":"2012-05-07T21:30:26Z","updated_at":"2018-12-12T19:42:39Z","pushed_at":"2018-12-17T17:07:58Z","git_url":"git://github.com/graphite-project/whisper.git","ssh_url":"git@github.com:graphite-project/whisper.git","clone_url":"https://github.com/graphite-project/whisper.git","svn_url":"https://github.com/graphite-project/whisper","homepage":"http://graphite.readthedocs.org/","size":429,"stargazers_count":957,"watchers_count":957,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":288,"open_issues":30,"watchers":957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/265"},"html":{"href":"https://github.com/graphite-project/whisper/pull/265"},"issue":{"href":"https://api.github.com/repos/graphite-project/whisper/issues/265"},"comments":{"href":"https://api.github.com/repos/graphite-project/whisper/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphite-project/whisper/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/graphite-project/whisper/statuses/669da5e985c64e0d76744e03b5f359ce4f28a6f9"}},"author_association":"NONE"}}
{"actor":{"display_login":"piotr1212"}}