{"action":"closed","number":21766,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/21766","id":222631609,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjMxNjA5","html_url":"https://github.com/facebook/react-native/pull/21766","diff_url":"https://github.com/facebook/react-native/pull/21766.diff","patch_url":"https://github.com/facebook/react-native/pull/21766.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/21766","number":21766,"state":"closed","locked":false,"title":"Bump xcode@1.0.0","user":{"login":"peat-psuwit","id":6771175,"node_id":"MDQ6VXNlcjY3NzExNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/6771175?v=4","gravatar_id":"","url":"https://api.github.com/users/peat-psuwit","html_url":"https://github.com/peat-psuwit","followers_url":"https://api.github.com/users/peat-psuwit/followers","following_url":"https://api.github.com/users/peat-psuwit/following{/other_user}","gists_url":"https://api.github.com/users/peat-psuwit/gists{/gist_id}","starred_url":"https://api.github.com/users/peat-psuwit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peat-psuwit/subscriptions","organizations_url":"https://api.github.com/users/peat-psuwit/orgs","repos_url":"https://api.github.com/users/peat-psuwit/repos","events_url":"https://api.github.com/users/peat-psuwit/events{/privacy}","received_events_url":"https://api.github.com/users/peat-psuwit/received_events","type":"User","site_admin":false},"body":"(cordova-node-)xcode 1.0.0 includes a fix for #13160 plus a few more\r\nfixes. This should increase robustness in Xcode project handling\r\noverall.\r\n\r\nFixes #13160.\r\n\r\n-------------------------\r\n\r\nThank you for sending the PR! We appreciate you spending the time to work on these changes.\r\nHelp us understand your motivation by explaining why you decided to make this change.\r\n\r\nIf this PR fixes an issue, type \"Fixes #issueNumber\" to automatically close the issue when the PR is merged.\r\n\r\n_Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_\r\n\r\nTest Plan:\r\n----------\r\nWrite your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!\r\n\r\n- Make sure native module unlinking doesn't crash with peat-psuwit/react-native-xcode-project-unlink-demo@2a0aa590e3794d24b013f4219e39a59b442b424d\r\n  - Try unlink `react-native-restart`, which is linked to iOS project.\r\n  - Don't worry about Android unlink. It's linked before 4dfdec9.\r\n\r\nRelease Notes:\r\n--------------\r\nHelp reviewers and the release process by writing your own release notes. See below for an example.\r\n\r\n-- I'm sorry. I'm not sure how to write a changelog for a dependency bump.\r\n\r\n<!--\r\n  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**\r\n\r\n    CATEGORY\r\n  [----------]      TYPE\r\n  [ CLI      ] [-------------]    LOCATION\r\n  [ DOCS     ] [ BREAKING    ] [-------------]\r\n  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]\r\n  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]\r\n  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|\r\n  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |\r\n  [----------] [-------------] [-------------]   |-----------|\r\n\r\n EXAMPLES:\r\n\r\n [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things\r\n [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput\r\n [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with\r\n [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word\r\n [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position\r\n [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see\r\n-->\r\n","created_at":"2018-10-13T06:32:04Z","updated_at":"2018-10-17T19:15:14Z","closed_at":"2018-10-17T19:15:14Z","merged_at":null,"merge_commit_sha":"d1fc097425e68d54f302bf2e9d6018b7b4e05131","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hramos","id":165856,"node_id":"MDQ6VXNlcjE2NTg1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/165856?v=4","gravatar_id":"","url":"https://api.github.com/users/hramos","html_url":"https://github.com/hramos","followers_url":"https://api.github.com/users/hramos/followers","following_url":"https://api.github.com/users/hramos/following{/other_user}","gists_url":"https://api.github.com/users/hramos/gists{/gist_id}","starred_url":"https://api.github.com/users/hramos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hramos/subscriptions","organizations_url":"https://api.github.com/users/hramos/orgs","repos_url":"https://api.github.com/users/hramos/repos","events_url":"https://api.github.com/users/hramos/events{/privacy}","received_events_url":"https://api.github.com/users/hramos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196858975,"node_id":"MDU6TGFiZWwxOTY4NTg5NzU=","url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"ffffff","default":false},{"id":302755315,"node_id":"MDU6TGFiZWwzMDI3NTUzMTU=","url":"https://api.github.com/repos/facebook/react-native/labels/Import%20Failed","name":"Import Failed","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/21766/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/21766/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/21766/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/eedece53b5291518ce9d9be3e7583bd4d20e6b3f","head":{"label":"peat-psuwit:bugfix/upgrade-xcode-lib","ref":"bugfix/upgrade-xcode-lib","sha":"eedece53b5291518ce9d9be3e7583bd4d20e6b3f","user":{"login":"peat-psuwit","id":6771175,"node_id":"MDQ6VXNlcjY3NzExNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/6771175?v=4","gravatar_id":"","url":"https://api.github.com/users/peat-psuwit","html_url":"https://github.com/peat-psuwit","followers_url":"https://api.github.com/users/peat-psuwit/followers","following_url":"https://api.github.com/users/peat-psuwit/following{/other_user}","gists_url":"https://api.github.com/users/peat-psuwit/gists{/gist_id}","starred_url":"https://api.github.com/users/peat-psuwit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peat-psuwit/subscriptions","organizations_url":"https://api.github.com/users/peat-psuwit/orgs","repos_url":"https://api.github.com/users/peat-psuwit/repos","events_url":"https://api.github.com/users/peat-psuwit/events{/privacy}","received_events_url":"https://api.github.com/users/peat-psuwit/received_events","type":"User","site_admin":false},"repo":{"id":152631772,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2MzE3NzI=","name":"react-native","full_name":"peat-psuwit/react-native","private":false,"owner":{"login":"peat-psuwit","id":6771175,"node_id":"MDQ6VXNlcjY3NzExNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/6771175?v=4","gravatar_id":"","url":"https://api.github.com/users/peat-psuwit","html_url":"https://github.com/peat-psuwit","followers_url":"https://api.github.com/users/peat-psuwit/followers","following_url":"https://api.github.com/users/peat-psuwit/following{/other_user}","gists_url":"https://api.github.com/users/peat-psuwit/gists{/gist_id}","starred_url":"https://api.github.com/users/peat-psuwit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peat-psuwit/subscriptions","organizations_url":"https://api.github.com/users/peat-psuwit/orgs","repos_url":"https://api.github.com/users/peat-psuwit/repos","events_url":"https://api.github.com/users/peat-psuwit/events{/privacy}","received_events_url":"https://api.github.com/users/peat-psuwit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/peat-psuwit/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/peat-psuwit/react-native","forks_url":"https://api.github.com/repos/peat-psuwit/react-native/forks","keys_url":"https://api.github.com/repos/peat-psuwit/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peat-psuwit/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peat-psuwit/react-native/teams","hooks_url":"https://api.github.com/repos/peat-psuwit/react-native/hooks","issue_events_url":"https://api.github.com/repos/peat-psuwit/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/peat-psuwit/react-native/events","assignees_url":"https://api.github.com/repos/peat-psuwit/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/peat-psuwit/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/peat-psuwit/react-native/tags","blobs_url":"https://api.github.com/repos/peat-psuwit/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peat-psuwit/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peat-psuwit/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/peat-psuwit/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peat-psuwit/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/peat-psuwit/react-native/languages","stargazers_url":"https://api.github.com/repos/peat-psuwit/react-native/stargazers","contributors_url":"https://api.github.com/repos/peat-psuwit/react-native/contributors","subscribers_url":"https://api.github.com/repos/peat-psuwit/react-native/subscribers","subscription_url":"https://api.github.com/repos/peat-psuwit/react-native/subscription","commits_url":"https://api.github.com/repos/peat-psuwit/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/peat-psuwit/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/peat-psuwit/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/peat-psuwit/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/peat-psuwit/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/peat-psuwit/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peat-psuwit/react-native/merges","archive_url":"https://api.github.com/repos/peat-psuwit/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peat-psuwit/react-native/downloads","issues_url":"https://api.github.com/repos/peat-psuwit/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/peat-psuwit/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/peat-psuwit/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/peat-psuwit/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peat-psuwit/react-native/labels{/name}","releases_url":"https://api.github.com/repos/peat-psuwit/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/peat-psuwit/react-native/deployments","created_at":"2018-10-11T17:43:27Z","updated_at":"2018-10-11T17:43:40Z","pushed_at":"2018-10-13T21:26:38Z","git_url":"git://github.com/peat-psuwit/react-native.git","ssh_url":"git@github.com:peat-psuwit/react-native.git","clone_url":"https://github.com/peat-psuwit/react-native.git","svn_url":"https://github.com/peat-psuwit/react-native","homepage":"https://facebook.github.io/react-native/","size":273171,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"5e7c774d646d4d53398a64bb087909575c7de271","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"node_id":"MDEwOlJlcG9zaXRvcnkyOTAyODc3NQ==","name":"react-native","full_name":"facebook/react-native","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2018-10-17T18:50:52Z","pushed_at":"2018-10-17T19:13:37Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"https://facebook.github.io/react-native/","size":273344,"stargazers_count":69865,"watchers_count":69865,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15660,"mirror_url":null,"archived":false,"open_issues_count":904,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15660,"open_issues":904,"watchers":69865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/21766"},"html":{"href":"https://github.com/facebook/react-native/pull/21766"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/21766"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/21766/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/21766/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/21766/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/eedece53b5291518ce9d9be3e7583bd4d20e6b3f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"facebook-github-bot"}}