{"action":"created","issue":{"url":"https://api.github.com/repos/MITgcm/MITgcm/issues/113","repository_url":"https://api.github.com/repos/MITgcm/MITgcm","labels_url":"https://api.github.com/repos/MITgcm/MITgcm/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/MITgcm/MITgcm/issues/113/comments","events_url":"https://api.github.com/repos/MITgcm/MITgcm/issues/113/events","html_url":"https://github.com/MITgcm/MITgcm/pull/113","id":331261729,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDM2NTcy","number":113,"title":"Consistent masking of thin ice shelf draft","user":{"login":"knaughten","id":12178472,"node_id":"MDQ6VXNlcjEyMTc4NDcy","avatar_url":"https://avatars3.githubusercontent.com/u/12178472?v=4","gravatar_id":"","url":"https://api.github.com/users/knaughten","html_url":"https://github.com/knaughten","followers_url":"https://api.github.com/users/knaughten/followers","following_url":"https://api.github.com/users/knaughten/following{/other_user}","gists_url":"https://api.github.com/users/knaughten/gists{/gist_id}","starred_url":"https://api.github.com/users/knaughten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knaughten/subscriptions","organizations_url":"https://api.github.com/users/knaughten/orgs","repos_url":"https://api.github.com/users/knaughten/repos","events_url":"https://api.github.com/users/knaughten/events{/privacy}","received_events_url":"https://api.github.com/users/knaughten/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"jm-c","id":5165946,"node_id":"MDQ6VXNlcjUxNjU5NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5165946?v=4","gravatar_id":"","url":"https://api.github.com/users/jm-c","html_url":"https://github.com/jm-c","followers_url":"https://api.github.com/users/jm-c/followers","following_url":"https://api.github.com/users/jm-c/following{/other_user}","gists_url":"https://api.github.com/users/jm-c/gists{/gist_id}","starred_url":"https://api.github.com/users/jm-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jm-c/subscriptions","organizations_url":"https://api.github.com/users/jm-c/orgs","repos_url":"https://api.github.com/users/jm-c/repos","events_url":"https://api.github.com/users/jm-c/events{/privacy}","received_events_url":"https://api.github.com/users/jm-c/received_events","type":"User","site_admin":false},"assignees":[{"login":"jm-c","id":5165946,"node_id":"MDQ6VXNlcjUxNjU5NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5165946?v=4","gravatar_id":"","url":"https://api.github.com/users/jm-c","html_url":"https://github.com/jm-c","followers_url":"https://api.github.com/users/jm-c/followers","following_url":"https://api.github.com/users/jm-c/following{/other_user}","gists_url":"https://api.github.com/users/jm-c/gists{/gist_id}","starred_url":"https://api.github.com/users/jm-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jm-c/subscriptions","organizations_url":"https://api.github.com/users/jm-c/orgs","repos_url":"https://api.github.com/users/jm-c/repos","events_url":"https://api.github.com/users/jm-c/events{/privacy}","received_events_url":"https://api.github.com/users/jm-c/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-06-11T16:31:41Z","updated_at":"2018-12-20T15:03:57Z","closed_at":"2018-07-19T19:49:06Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MITgcm/MITgcm/pulls/113","html_url":"https://github.com/MITgcm/MITgcm/pull/113","diff_url":"https://github.com/MITgcm/MITgcm/pull/113.diff","patch_url":"https://github.com/MITgcm/MITgcm/pull/113.patch"},"body":"## What changes does this PR introduce?\r\nThis ensures the ice shelf mask is consistent throughout all parts of the code, by replacing R_shelfice with Ro_surf in shelfice_thermodynamics and shelfice_init_fixed.\r\n\r\n\r\n## What is the current behaviour? \r\nIssue #99 describes how cells with very thin ice draft (violating hFacMin and hFacMinDr) are treated as open ocean cells by most of the code, but the ice shelf thermodynamics still sees the original ice shelf draft in its mask. Therefore, the cells are simultaneously sea ice cells and ice shelf cells.\r\n\r\n\r\n## What is the new behaviour \r\nCells with sufficiently thin ice draft are now consistently treated as open ocean cells (hFac=1).\r\n\r\n\r\n## Does this PR introduce a breaking change? \r\nMartin Losch has confirmed this fix changes the results of the isomip verification experiment, and suggests this experiment should be rerun.\r\n\r\n\r\n## Other information:"},"comment":{"url":"https://api.github.com/repos/MITgcm/MITgcm/issues/comments/449027766","html_url":"https://github.com/MITgcm/MITgcm/pull/113#issuecomment-449027766","issue_url":"https://api.github.com/repos/MITgcm/MITgcm/issues/113","id":449027766,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTAyNzc2Ng==","user":{"login":"jm-c","id":5165946,"node_id":"MDQ6VXNlcjUxNjU5NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5165946?v=4","gravatar_id":"","url":"https://api.github.com/users/jm-c","html_url":"https://github.com/jm-c","followers_url":"https://api.github.com/users/jm-c/followers","following_url":"https://api.github.com/users/jm-c/following{/other_user}","gists_url":"https://api.github.com/users/jm-c/gists{/gist_id}","starred_url":"https://api.github.com/users/jm-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jm-c/subscriptions","organizations_url":"https://api.github.com/users/jm-c/orgs","repos_url":"https://api.github.com/users/jm-c/repos","events_url":"https://api.github.com/users/jm-c/events{/privacy}","received_events_url":"https://api.github.com/users/jm-c/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T15:03:57Z","updated_at":"2018-12-20T15:03:57Z","author_association":"MEMBER","body":"@mjlosch I am working on this. But since there are more changes involved with pkg/seaice,\nI thought it would be cleaner to split this set of changes in 2 separated PR,\nthe first one (PR #187) for pkg/thsice and a new one (to come soon) for pkg/seaice.\n\nOn Thu, Dec 20, 2018 at 02:26:21AM -0800, Martin Losch wrote:\n> In order to do the same for `pkg/seaice` that PR #187 does for `pkg/thsice`, one could adjust the mask `HEFFM` according to `kTopC` (`where(kTopC>0) HEFFM = 0`). But this would bring back all the TAF-dependencies on `HEFFM`and would require putting back all sorts of store directives, unless this is only done within `packages_init_fixed` after moving the initialisation of `pkg/shelfice` before that of `pkg/seaice`. I don't have a better idea. @jm-c what do you think?\n> \n> -- \n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub:\n> https://github.com/MITgcm/MITgcm/pull/113#issuecomment-448948516\n"}}
{"actor":{"display_login":"jm-c"}}