{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/pulls/15","id":185448624,"html_url":"https://github.com/wireapp/wire-ios-ziphy/pull/15","diff_url":"https://github.com/wireapp/wire-ios-ziphy/pull/15.diff","patch_url":"https://github.com/wireapp/wire-ios-ziphy/pull/15.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/issues/15","number":15,"state":"closed","locked":false,"title":"Fix/zios 9807 return ziphs in callback","user":{"login":"billypchan","id":11852044,"avatar_url":"https://avatars3.githubusercontent.com/u/11852044?v=4","gravatar_id":"","url":"https://api.github.com/users/billypchan","html_url":"https://github.com/billypchan","followers_url":"https://api.github.com/users/billypchan/followers","following_url":"https://api.github.com/users/billypchan/following{/other_user}","gists_url":"https://api.github.com/users/billypchan/gists{/gist_id}","starred_url":"https://api.github.com/users/billypchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billypchan/subscriptions","organizations_url":"https://api.github.com/users/billypchan/orgs","repos_url":"https://api.github.com/users/billypchan/repos","events_url":"https://api.github.com/users/billypchan/events{/privacy}","received_events_url":"https://api.github.com/users/billypchan/received_events","type":"User","site_admin":false},"body":"## What's new in this PR?\r\n\r\nAdd ziphs array to SuccessOrErrorCallback to prevert the UI directly access paginationController.ziphs. It fixes the UI (a collection view) out of sync issue which may cause a crash.","created_at":"2018-05-02T14:02:50Z","updated_at":"2018-05-02T14:25:13Z","closed_at":"2018-05-02T14:25:13Z","merged_at":"2018-05-02T14:25:12Z","merge_commit_sha":"c997cdaabfdcd842f107109eb2a1c7915cd8345e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":414574743,"url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/labels/API%20breaker","name":"API breaker","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/pulls/15/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/pulls/15/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/issues/15/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/statuses/e68743179e80601e72bfa52f128657718bf634f7","head":{"label":"wireapp:fix/ZIOS-9807-return-ziphs-in-callback-take2","ref":"fix/ZIOS-9807-return-ziphs-in-callback-take2","sha":"e68743179e80601e72bfa52f128657718bf634f7","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63859382,"name":"wire-ios-ziphy","full_name":"wireapp/wire-ios-ziphy","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-ziphy","description":"https://wire.com","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-ziphy","forks_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/deployments","created_at":"2016-07-21T10:16:04Z","updated_at":"2018-04-09T12:18:56Z","pushed_at":"2018-05-02T14:25:12Z","git_url":"git://github.com/wireapp/wire-ios-ziphy.git","ssh_url":"git@github.com:wireapp/wire-ios-ziphy.git","clone_url":"https://github.com/wireapp/wire-ios-ziphy.git","svn_url":"https://github.com/wireapp/wire-ios-ziphy","homepage":null,"size":241,"stargazers_count":25,"watchers_count":25,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":13,"open_issues":0,"watchers":25,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"f04f4780cd16ee52878a1cc2c593765c7d45ec44","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63859382,"name":"wire-ios-ziphy","full_name":"wireapp/wire-ios-ziphy","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-ziphy","description":"https://wire.com","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-ziphy","forks_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-ziphy/deployments","created_at":"2016-07-21T10:16:04Z","updated_at":"2018-04-09T12:18:56Z","pushed_at":"2018-05-02T14:25:12Z","git_url":"git://github.com/wireapp/wire-ios-ziphy.git","ssh_url":"git@github.com:wireapp/wire-ios-ziphy.git","clone_url":"https://github.com/wireapp/wire-ios-ziphy.git","svn_url":"https://github.com/wireapp/wire-ios-ziphy","homepage":null,"size":241,"stargazers_count":25,"watchers_count":25,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":13,"open_issues":0,"watchers":25,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-ziphy/pulls/15"},"html":{"href":"https://github.com/wireapp/wire-ios-ziphy/pull/15"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios-ziphy/issues/15"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-ziphy/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-ziphy/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios-ziphy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios-ziphy/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios-ziphy/statuses/e68743179e80601e72bfa52f128657718bf634f7"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"billypchan","id":11852044,"avatar_url":"https://avatars3.githubusercontent.com/u/11852044?v=4","gravatar_id":"","url":"https://api.github.com/users/billypchan","html_url":"https://github.com/billypchan","followers_url":"https://api.github.com/users/billypchan/followers","following_url":"https://api.github.com/users/billypchan/following{/other_user}","gists_url":"https://api.github.com/users/billypchan/gists{/gist_id}","starred_url":"https://api.github.com/users/billypchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billypchan/subscriptions","organizations_url":"https://api.github.com/users/billypchan/orgs","repos_url":"https://api.github.com/users/billypchan/repos","events_url":"https://api.github.com/users/billypchan/events{/privacy}","received_events_url":"https://api.github.com/users/billypchan/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":5,"additions":27,"deletions":32,"changed_files":3}}
{"actor":{"display_login":"billypchan"}}