{"action":"created","issue":{"url":"https://api.github.com/repos/freeCodeCamp/testable-projects-fcc/issues/426","repository_url":"https://api.github.com/repos/freeCodeCamp/testable-projects-fcc","labels_url":"https://api.github.com/repos/freeCodeCamp/testable-projects-fcc/issues/426/labels{/name}","comments_url":"https://api.github.com/repos/freeCodeCamp/testable-projects-fcc/issues/426/comments","events_url":"https://api.github.com/repos/freeCodeCamp/testable-projects-fcc/issues/426/events","html_url":"https://github.com/freeCodeCamp/testable-projects-fcc/pull/426","id":339161347,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTA1ODcw","number":426,"title":"fix/pomodoro minutes&seconds getter couldn't handle React html comments","user":{"login":"Rock-son","id":12340956,"node_id":"MDQ6VXNlcjEyMzQwOTU2","avatar_url":"https://avatars1.githubusercontent.com/u/12340956?v=4","gravatar_id":"","url":"https://api.github.com/users/Rock-son","html_url":"https://github.com/Rock-son","followers_url":"https://api.github.com/users/Rock-son/followers","following_url":"https://api.github.com/users/Rock-son/following{/other_user}","gists_url":"https://api.github.com/users/Rock-son/gists{/gist_id}","starred_url":"https://api.github.com/users/Rock-son/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rock-son/subscriptions","organizations_url":"https://api.github.com/users/Rock-son/orgs","repos_url":"https://api.github.com/users/Rock-son/repos","events_url":"https://api.github.com/users/Rock-son/events{/privacy}","received_events_url":"https://api.github.com/users/Rock-son/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-07T17:17:17Z","updated_at":"2018-07-09T00:32:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/freeCodeCamp/testable-projects-fcc/pulls/426","html_url":"https://github.com/freeCodeCamp/testable-projects-fcc/pull/426","diff_url":"https://github.com/freeCodeCamp/testable-projects-fcc/pull/426.diff","patch_url":"https://github.com/freeCodeCamp/testable-projects-fcc/pull/426.patch"},"body":"#### Pre-Submission Checklist\r\n<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply. -->\r\n<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->\r\n<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n- [x] Your pull request targets the `master` branch of freeCodeCamp/testable-projects-fcc\r\n- [x] Branch starts with either `fix/`, `feature/`, or `translate/` (e.g. `fix/signin-issue`)\r\n- [x] You have only one commit (if not, [squash](http://forum.freecodecamp.com/t/how-to-squash-multiple-commits-into-one-with-git/13231) them into one commit).\r\n- [x] Your changes have been tested either locally or using a newly created CDN based on your fork's testable-projects-fcc/build/bundle.js file\r\n- [x] Working changes have been added to the build by running `npm run build`\r\n\r\n#### Type of Change\r\n<!-- What type of change does your code introduce? After creating the PR, tick the checkboxes that apply. -->\r\n\r\n- [x] Small bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds new functionality)\r\n- [ ] Breaking change (fix or feature that would change existing functionality)\r\n- [ ] Add new translation (feature adding new translations)\r\n\r\n#### Checklist:\r\n<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply. -->\r\n<!-- If you're unsure about any of these, don't hesitate to ask in the Help Contributors room linked above. We're here to help! -->\r\n\r\n- [x] Tested changes locally.\r\n<!-- replace XXX with an issue # -->\r\n- [x] Closes currently open issue: Closes #399 \r\n\r\n#### Description\r\n<!-- Describe your changes in detail -->\r\n\r\nIn functions **getMinutes()** and **getSeconds()** added a fix **`\\s?(?:\\<!--.*--\\>)?`** to the regex fetching minutes and seconds from the pomodoro clock container, capturing possible React html comments (zero, one or more) with possible spaces in between.\r\n\r\nPrevious regex couldn't handle React HTML comments **before** the content: \r\n\\<!-- react-text: 22 --\\>**25:00**\\<!-- /react-text --\\><!-- react-text: 23 --\\> \\<!-- /react-text --\\>\r\n\r\nChanged file: [/src/project-tests/pomodoro-clock-tests.js](https://github.com/Rock-son/testable-projects-fcc/blob/issue%23399-pomodoro-regex-handle-react-comments/src/project-tests/pomodoro-clock-tests.js#LC20)\r\n\r\nNew line after `const matches` due to eslint **enforce a maximum line length (max-len): 80**"},"comment":{"url":"https://api.github.com/repos/freeCodeCamp/testable-projects-fcc/issues/comments/403329923","html_url":"https://github.com/freeCodeCamp/testable-projects-fcc/pull/426#issuecomment-403329923","issue_url":"https://api.github.com/repos/freeCodeCamp/testable-projects-fcc/issues/426","id":403329923,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzMyOTkyMw==","user":{"login":"tbushman","id":7049294,"node_id":"MDQ6VXNlcjcwNDkyOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7049294?v=4","gravatar_id":"","url":"https://api.github.com/users/tbushman","html_url":"https://github.com/tbushman","followers_url":"https://api.github.com/users/tbushman/followers","following_url":"https://api.github.com/users/tbushman/following{/other_user}","gists_url":"https://api.github.com/users/tbushman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbushman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbushman/subscriptions","organizations_url":"https://api.github.com/users/tbushman/orgs","repos_url":"https://api.github.com/users/tbushman/repos","events_url":"https://api.github.com/users/tbushman/events{/privacy}","received_events_url":"https://api.github.com/users/tbushman/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T00:32:26Z","updated_at":"2018-07-09T00:32:26Z","author_association":"COLLABORATOR","body":"@Rock-son Sure. Thanks. :) I only tested the minutes regex and it seems like it works... "}}
{"actor":{"display_login":"tbushman"}}