{"action":"created","issue":{"url":"https://api.github.com/repos/flowtype/flow-typed/issues/2165","repository_url":"https://api.github.com/repos/flowtype/flow-typed","labels_url":"https://api.github.com/repos/flowtype/flow-typed/issues/2165/labels{/name}","comments_url":"https://api.github.com/repos/flowtype/flow-typed/issues/2165/comments","events_url":"https://api.github.com/repos/flowtype/flow-typed/issues/2165/events","html_url":"https://github.com/flowtype/flow-typed/pull/2165","id":319779793,"number":2165,"title":"React-Navigation: Fixed issue related to export magic","user":{"login":"mwalkerwells","id":16157429,"avatar_url":"https://avatars1.githubusercontent.com/u/16157429?v=4","gravatar_id":"","url":"https://api.github.com/users/mwalkerwells","html_url":"https://github.com/mwalkerwells","followers_url":"https://api.github.com/users/mwalkerwells/followers","following_url":"https://api.github.com/users/mwalkerwells/following{/other_user}","gists_url":"https://api.github.com/users/mwalkerwells/gists{/gist_id}","starred_url":"https://api.github.com/users/mwalkerwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwalkerwells/subscriptions","organizations_url":"https://api.github.com/users/mwalkerwells/orgs","repos_url":"https://api.github.com/users/mwalkerwells/repos","events_url":"https://api.github.com/users/mwalkerwells/events{/privacy}","received_events_url":"https://api.github.com/users/mwalkerwells/received_events","type":"User","site_admin":false},"labels":[{"id":874276722,"url":"https://api.github.com/repos/flowtype/flow-typed/labels/changes-requested","name":"changes-requested","color":"fef2c0","default":false},{"id":874822104,"url":"https://api.github.com/repos/flowtype/flow-typed/labels/libdef","name":"libdef","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"AndrewSouthpaw","id":5187404,"avatar_url":"https://avatars1.githubusercontent.com/u/5187404?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewSouthpaw","html_url":"https://github.com/AndrewSouthpaw","followers_url":"https://api.github.com/users/AndrewSouthpaw/followers","following_url":"https://api.github.com/users/AndrewSouthpaw/following{/other_user}","gists_url":"https://api.github.com/users/AndrewSouthpaw/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewSouthpaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewSouthpaw/subscriptions","organizations_url":"https://api.github.com/users/AndrewSouthpaw/orgs","repos_url":"https://api.github.com/users/AndrewSouthpaw/repos","events_url":"https://api.github.com/users/AndrewSouthpaw/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewSouthpaw/received_events","type":"User","site_admin":false},"assignees":[{"login":"AndrewSouthpaw","id":5187404,"avatar_url":"https://avatars1.githubusercontent.com/u/5187404?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewSouthpaw","html_url":"https://github.com/AndrewSouthpaw","followers_url":"https://api.github.com/users/AndrewSouthpaw/followers","following_url":"https://api.github.com/users/AndrewSouthpaw/following{/other_user}","gists_url":"https://api.github.com/users/AndrewSouthpaw/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewSouthpaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewSouthpaw/subscriptions","organizations_url":"https://api.github.com/users/AndrewSouthpaw/orgs","repos_url":"https://api.github.com/users/AndrewSouthpaw/repos","events_url":"https://api.github.com/users/AndrewSouthpaw/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewSouthpaw/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-05-03T03:46:57Z","updated_at":"2018-05-18T12:38:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/flowtype/flow-typed/pulls/2165","html_url":"https://github.com/flowtype/flow-typed/pull/2165","diff_url":"https://github.com/flowtype/flow-typed/pull/2165.diff","patch_url":"https://github.com/flowtype/flow-typed/pull/2165.patch"},"body":"Context: https://github.com/facebook/flow/issues/3119\r\nBug: Flow would not recognize the module definition & would exhibit this behavior: https://github.com/flowtype/flow-typed/issues/2164"},"comment":{"url":"https://api.github.com/repos/flowtype/flow-typed/issues/comments/390193720","html_url":"https://github.com/flowtype/flow-typed/pull/2165#issuecomment-390193720","issue_url":"https://api.github.com/repos/flowtype/flow-typed/issues/2165","id":390193720,"user":{"login":"Ashoat","id":863579,"avatar_url":"https://avatars0.githubusercontent.com/u/863579?v=4","gravatar_id":"","url":"https://api.github.com/users/Ashoat","html_url":"https://github.com/Ashoat","followers_url":"https://api.github.com/users/Ashoat/followers","following_url":"https://api.github.com/users/Ashoat/following{/other_user}","gists_url":"https://api.github.com/users/Ashoat/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashoat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashoat/subscriptions","organizations_url":"https://api.github.com/users/Ashoat/orgs","repos_url":"https://api.github.com/users/Ashoat/repos","events_url":"https://api.github.com/users/Ashoat/events{/privacy}","received_events_url":"https://api.github.com/users/Ashoat/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T12:38:39Z","updated_at":"2018-05-18T12:38:39Z","author_association":"CONTRIBUTOR","body":"@mwalkerwells:\r\n\r\n1. The expectation in the open source community (as well as in industry, which I'm sure you're familiar with) is that each PR should represent a small, indivisible change. By saying you don't have the time to split your PR into three, what you're really saying is that your time is worth more than your reviewers' time. We're all volunteers here.\r\n2. Regarding pulling the non-exported types up into the global namespace, the main downside here is that error messages will now talk about `$npm$ReactNavigation$NavigationState` instead of `NavigationState`. I think this outweighs the benefit of \"end users will not be surprised in the future when it inevitably changes\". I don't expect too many end users are using the types prefixed with underscores anyways.\r\n3. Changing the libdef to use the old CommonJS style instead of ESM style doesn't make sense to me. It's true that `react-navigation` uses CommonJS exports for compatibility with various web configs, but there's no reason the libdef can't be typed in the ESM style. The fact that this breaks your Nuclide setup sounds like a good reason to send Nuclide a PR, not a good reason to send this libdef a PR.\r\n\r\nIf you update this PR to be the addition of a `declare export default` statement, I'll gladly accept it. But as it stands I don't think this PR represents an improvement to the libdef."}}
{"actor":{"display_login":"Ashoat"}}