{"action":"created","comment":{"url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/comments/227620037","pull_request_review_id":167703004,"id":227620037,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzYyMDAzNw==","diff_hunk":"@@ -445,6 +459,11 @@ function activateCellVim(app: JupyterLab, tracker: INotebookTracker): Promise<vo\n             keys: ['Escape'],\n             command: 'leave-insert-mode'\n         });\n+        commands.addKeyBinding({\n+            selector: '.jp-Notebook:focus.jp-mod-commandMode',\n+            keys: ['I'],\n+            command: 'enter-insert-mode'\n+        });","path":"src/index.ts","position":29,"original_position":29,"commit_id":"aefcf89985beefae1ab61a32a40365a682909af4","original_commit_id":"aefcf89985beefae1ab61a32a40365a682909af4","user":{"login":"jwkvam","id":86304,"node_id":"MDQ6VXNlcjg2MzA0","avatar_url":"https://avatars0.githubusercontent.com/u/86304?v=4","gravatar_id":"","url":"https://api.github.com/users/jwkvam","html_url":"https://github.com/jwkvam","followers_url":"https://api.github.com/users/jwkvam/followers","following_url":"https://api.github.com/users/jwkvam/following{/other_user}","gists_url":"https://api.github.com/users/jwkvam/gists{/gist_id}","starred_url":"https://api.github.com/users/jwkvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwkvam/subscriptions","organizations_url":"https://api.github.com/users/jwkvam/orgs","repos_url":"https://api.github.com/users/jwkvam/repos","events_url":"https://api.github.com/users/jwkvam/events{/privacy}","received_events_url":"https://api.github.com/users/jwkvam/received_events","type":"User","site_admin":false},"body":"I'm not if you need to have a custom command here. You can probably just use `notebook:enter-edit-mode`. Similar to jlab, I'd probably change the selector to `.jp-Notebook:focus`. Here's the shortcuts from jlab:\r\n\r\nhttps://github.com/jupyterlab/jupyterlab/blob/master/packages/shortcuts-extension/schema/plugin.json#L599","created_at":"2018-10-24T01:50:20Z","updated_at":"2018-10-24T01:51:45Z","html_url":"https://github.com/jwkvam/jupyterlab-vim/pull/71#discussion_r227620037","pull_request_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/71","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/comments/227620037"},"html":{"href":"https://github.com/jwkvam/jupyterlab-vim/pull/71#discussion_r227620037"},"pull_request":{"href":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/71","id":225192728,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTkyNzI4","html_url":"https://github.com/jwkvam/jupyterlab-vim/pull/71","diff_url":"https://github.com/jwkvam/jupyterlab-vim/pull/71.diff","patch_url":"https://github.com/jwkvam/jupyterlab-vim/pull/71.patch","issue_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/issues/71","number":71,"state":"open","locked":false,"title":"`i` enters Vim insert mode from Jupyter command mode","user":{"login":"wmayner","id":1775632,"node_id":"MDQ6VXNlcjE3NzU2MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1775632?v=4","gravatar_id":"","url":"https://api.github.com/users/wmayner","html_url":"https://github.com/wmayner","followers_url":"https://api.github.com/users/wmayner/followers","following_url":"https://api.github.com/users/wmayner/following{/other_user}","gists_url":"https://api.github.com/users/wmayner/gists{/gist_id}","starred_url":"https://api.github.com/users/wmayner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmayner/subscriptions","organizations_url":"https://api.github.com/users/wmayner/orgs","repos_url":"https://api.github.com/users/wmayner/repos","events_url":"https://api.github.com/users/wmayner/events{/privacy}","received_events_url":"https://api.github.com/users/wmayner/received_events","type":"User","site_admin":false},"body":"This addresses #70.","created_at":"2018-10-23T21:26:13Z","updated_at":"2018-10-24T01:51:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f10fac8bdbc6a5086af66d59fc3c2d21ce87d633","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/71/commits","review_comments_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/71/comments","review_comment_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/issues/71/comments","statuses_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/statuses/aefcf89985beefae1ab61a32a40365a682909af4","head":{"label":"wmayner:master","ref":"master","sha":"aefcf89985beefae1ab61a32a40365a682909af4","user":{"login":"wmayner","id":1775632,"node_id":"MDQ6VXNlcjE3NzU2MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1775632?v=4","gravatar_id":"","url":"https://api.github.com/users/wmayner","html_url":"https://github.com/wmayner","followers_url":"https://api.github.com/users/wmayner/followers","following_url":"https://api.github.com/users/wmayner/following{/other_user}","gists_url":"https://api.github.com/users/wmayner/gists{/gist_id}","starred_url":"https://api.github.com/users/wmayner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmayner/subscriptions","organizations_url":"https://api.github.com/users/wmayner/orgs","repos_url":"https://api.github.com/users/wmayner/repos","events_url":"https://api.github.com/users/wmayner/events{/privacy}","received_events_url":"https://api.github.com/users/wmayner/received_events","type":"User","site_admin":false},"repo":{"id":154393998,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzOTM5OTg=","name":"jupyterlab-vim","full_name":"wmayner/jupyterlab-vim","private":false,"owner":{"login":"wmayner","id":1775632,"node_id":"MDQ6VXNlcjE3NzU2MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1775632?v=4","gravatar_id":"","url":"https://api.github.com/users/wmayner","html_url":"https://github.com/wmayner","followers_url":"https://api.github.com/users/wmayner/followers","following_url":"https://api.github.com/users/wmayner/following{/other_user}","gists_url":"https://api.github.com/users/wmayner/gists{/gist_id}","starred_url":"https://api.github.com/users/wmayner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmayner/subscriptions","organizations_url":"https://api.github.com/users/wmayner/orgs","repos_url":"https://api.github.com/users/wmayner/repos","events_url":"https://api.github.com/users/wmayner/events{/privacy}","received_events_url":"https://api.github.com/users/wmayner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wmayner/jupyterlab-vim","description":":neckbeard: Vim notebook cell bindings for JupyterLab","fork":true,"url":"https://api.github.com/repos/wmayner/jupyterlab-vim","forks_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/forks","keys_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/teams","hooks_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/hooks","issue_events_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/issues/events{/number}","events_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/events","assignees_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/assignees{/user}","branches_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/branches{/branch}","tags_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/tags","blobs_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/statuses/{sha}","languages_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/languages","stargazers_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/stargazers","contributors_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/contributors","subscribers_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/subscribers","subscription_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/subscription","commits_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/contents/{+path}","compare_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/merges","archive_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/downloads","issues_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/issues{/number}","pulls_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/pulls{/number}","milestones_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/milestones{/number}","notifications_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/labels{/name}","releases_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/releases{/id}","deployments_url":"https://api.github.com/repos/wmayner/jupyterlab-vim/deployments","created_at":"2018-10-23T20:41:15Z","updated_at":"2018-10-23T21:22:53Z","pushed_at":"2018-10-23T21:22:51Z","git_url":"git://github.com/wmayner/jupyterlab-vim.git","ssh_url":"git@github.com:wmayner/jupyterlab-vim.git","clone_url":"https://github.com/wmayner/jupyterlab-vim.git","svn_url":"https://github.com/wmayner/jupyterlab-vim","homepage":"","size":97,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jwkvam:master","ref":"master","sha":"024c6cf1fa3b06e7485f55e2a4140fedd1fa77a6","user":{"login":"jwkvam","id":86304,"node_id":"MDQ6VXNlcjg2MzA0","avatar_url":"https://avatars0.githubusercontent.com/u/86304?v=4","gravatar_id":"","url":"https://api.github.com/users/jwkvam","html_url":"https://github.com/jwkvam","followers_url":"https://api.github.com/users/jwkvam/followers","following_url":"https://api.github.com/users/jwkvam/following{/other_user}","gists_url":"https://api.github.com/users/jwkvam/gists{/gist_id}","starred_url":"https://api.github.com/users/jwkvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwkvam/subscriptions","organizations_url":"https://api.github.com/users/jwkvam/orgs","repos_url":"https://api.github.com/users/jwkvam/repos","events_url":"https://api.github.com/users/jwkvam/events{/privacy}","received_events_url":"https://api.github.com/users/jwkvam/received_events","type":"User","site_admin":false},"repo":{"id":112877413,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI4Nzc0MTM=","name":"jupyterlab-vim","full_name":"jwkvam/jupyterlab-vim","private":false,"owner":{"login":"jwkvam","id":86304,"node_id":"MDQ6VXNlcjg2MzA0","avatar_url":"https://avatars0.githubusercontent.com/u/86304?v=4","gravatar_id":"","url":"https://api.github.com/users/jwkvam","html_url":"https://github.com/jwkvam","followers_url":"https://api.github.com/users/jwkvam/followers","following_url":"https://api.github.com/users/jwkvam/following{/other_user}","gists_url":"https://api.github.com/users/jwkvam/gists{/gist_id}","starred_url":"https://api.github.com/users/jwkvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwkvam/subscriptions","organizations_url":"https://api.github.com/users/jwkvam/orgs","repos_url":"https://api.github.com/users/jwkvam/repos","events_url":"https://api.github.com/users/jwkvam/events{/privacy}","received_events_url":"https://api.github.com/users/jwkvam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jwkvam/jupyterlab-vim","description":":neckbeard: Vim notebook cell bindings for JupyterLab","fork":false,"url":"https://api.github.com/repos/jwkvam/jupyterlab-vim","forks_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/forks","keys_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/teams","hooks_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/hooks","issue_events_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/issues/events{/number}","events_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/events","assignees_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/assignees{/user}","branches_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/branches{/branch}","tags_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/tags","blobs_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/statuses/{sha}","languages_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/languages","stargazers_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/stargazers","contributors_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/contributors","subscribers_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/subscribers","subscription_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/subscription","commits_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/contents/{+path}","compare_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/merges","archive_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/downloads","issues_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/issues{/number}","pulls_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls{/number}","milestones_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/milestones{/number}","notifications_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/labels{/name}","releases_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/releases{/id}","deployments_url":"https://api.github.com/repos/jwkvam/jupyterlab-vim/deployments","created_at":"2017-12-02T21:16:38Z","updated_at":"2018-10-23T19:22:45Z","pushed_at":"2018-10-23T21:26:14Z","git_url":"git://github.com/jwkvam/jupyterlab-vim.git","ssh_url":"git@github.com:jwkvam/jupyterlab-vim.git","clone_url":"https://github.com/jwkvam/jupyterlab-vim.git","svn_url":"https://github.com/jwkvam/jupyterlab-vim","homepage":"","size":89,"stargazers_count":207,"watchers_count":207,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":27,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/71"},"html":{"href":"https://github.com/jwkvam/jupyterlab-vim/pull/71"},"issue":{"href":"https://api.github.com/repos/jwkvam/jupyterlab-vim/issues/71"},"comments":{"href":"https://api.github.com/repos/jwkvam/jupyterlab-vim/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwkvam/jupyterlab-vim/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/jwkvam/jupyterlab-vim/statuses/aefcf89985beefae1ab61a32a40365a682909af4"}},"author_association":"NONE"}}
{"actor":{"display_login":"jwkvam"}}