{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/182312256","pull_request_review_id":113080604,"id":182312256,"diff_hunk":"@@ -14,15 +14,15 @@ names.\n \n The available categories are:\n \n-* `node`\n-* `node.async_hooks` - Enables capture of detailed async_hooks trace data.\n+* `node` - is a placeholder. Doesn't actually contain anything.","path":"doc/api/tracing.md","position":null,"original_position":12,"commit_id":"b3c14c863b97b55f8889d2794f7b81bc971e8000","original_commit_id":"8ca0ad8b6f2cd8ed5617f4479cb8cf351496b7e6","user":{"login":"BeniCheni","id":6441326,"avatar_url":"https://avatars2.githubusercontent.com/u/6441326?v=4","gravatar_id":"","url":"https://api.github.com/users/BeniCheni","html_url":"https://github.com/BeniCheni","followers_url":"https://api.github.com/users/BeniCheni/followers","following_url":"https://api.github.com/users/BeniCheni/following{/other_user}","gists_url":"https://api.github.com/users/BeniCheni/gists{/gist_id}","starred_url":"https://api.github.com/users/BeniCheni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeniCheni/subscriptions","organizations_url":"https://api.github.com/users/BeniCheni/orgs","repos_url":"https://api.github.com/users/BeniCheni/repos","events_url":"https://api.github.com/users/BeniCheni/events{/privacy}","received_events_url":"https://api.github.com/users/BeniCheni/received_events","type":"User","site_admin":false},"body":"@apapirovski & @vsemozhetbyt, 👍& 🙏for both of your suggestions. Updated to go with \"*An empty placeholder.*\", as it seems \"short and sweet\" for now. Happy to do follow-up PR, if there's a new content for `node`.","created_at":"2018-04-18T05:27:24Z","updated_at":"2018-04-18T05:27:24Z","html_url":"https://github.com/nodejs/node/pull/20092#discussion_r182312256","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/20092","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/182312256"},"html":{"href":"https://github.com/nodejs/node/pull/20092#discussion_r182312256"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/20092"}},"in_reply_to_id":181999823},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20092","id":182052510,"html_url":"https://github.com/nodejs/node/pull/20092","diff_url":"https://github.com/nodejs/node/pull/20092.diff","patch_url":"https://github.com/nodejs/node/pull/20092.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/20092","number":20092,"state":"open","locked":false,"title":"doc: update trace_event doc in tracing.md","user":{"login":"BeniCheni","id":6441326,"avatar_url":"https://avatars2.githubusercontent.com/u/6441326?v=4","gravatar_id":"","url":"https://api.github.com/users/BeniCheni","html_url":"https://github.com/BeniCheni","followers_url":"https://api.github.com/users/BeniCheni/followers","following_url":"https://api.github.com/users/BeniCheni/following{/other_user}","gists_url":"https://api.github.com/users/BeniCheni/gists{/gist_id}","starred_url":"https://api.github.com/users/BeniCheni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeniCheni/subscriptions","organizations_url":"https://api.github.com/users/BeniCheni/orgs","repos_url":"https://api.github.com/users/BeniCheni/repos","events_url":"https://api.github.com/users/BeniCheni/events{/privacy}","received_events_url":"https://api.github.com/users/BeniCheni/received_events","type":"User","site_admin":false},"body":"Change title from `tracing` to `trace_event` in the documentation content. Update the description of `node `, `node.async_hooks` and `v8` category to contain information highlighted in #16315.\r\n\r\nFixes: #16315\r\n\r\n##### Checklist\r\n- [x] make -j4 test (UNIX), or vcbuild test (Windows) passes\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\nP.S.: After reading #16315, the the [async_hooks](https://github.com/nodejs/node/blob/master/doc/api/async_hooks.md) and [v8](https://github.com/nodejs/node/blob/master/doc/api/v8.md) documentations in details, I'm hoping to give this \"_good first issue_\" issue an attempt.\r\n\r\nThanks for your time to review in advance. Hoping the PR looks okay. Happy to update according to any review feedback. ✌️ ","created_at":"2018-04-17T05:07:18Z","updated_at":"2018-04-18T05:27:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88d4f0679b077040eb3683f5d61cadc904af3eee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267517,"url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":527937726,"url":"https://api.github.com/repos/nodejs/node/labels/trace_events","name":"trace_events","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/20092/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/20092/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20092/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b3c14c863b97b55f8889d2794f7b81bc971e8000","head":{"label":"BeniCheni:trace-event-doc","ref":"trace-event-doc","sha":"b3c14c863b97b55f8889d2794f7b81bc971e8000","user":{"login":"BeniCheni","id":6441326,"avatar_url":"https://avatars2.githubusercontent.com/u/6441326?v=4","gravatar_id":"","url":"https://api.github.com/users/BeniCheni","html_url":"https://github.com/BeniCheni","followers_url":"https://api.github.com/users/BeniCheni/followers","following_url":"https://api.github.com/users/BeniCheni/following{/other_user}","gists_url":"https://api.github.com/users/BeniCheni/gists{/gist_id}","starred_url":"https://api.github.com/users/BeniCheni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeniCheni/subscriptions","organizations_url":"https://api.github.com/users/BeniCheni/orgs","repos_url":"https://api.github.com/users/BeniCheni/repos","events_url":"https://api.github.com/users/BeniCheni/events{/privacy}","received_events_url":"https://api.github.com/users/BeniCheni/received_events","type":"User","site_admin":false},"repo":{"id":129842489,"name":"node","full_name":"BeniCheni/node","owner":{"login":"BeniCheni","id":6441326,"avatar_url":"https://avatars2.githubusercontent.com/u/6441326?v=4","gravatar_id":"","url":"https://api.github.com/users/BeniCheni","html_url":"https://github.com/BeniCheni","followers_url":"https://api.github.com/users/BeniCheni/followers","following_url":"https://api.github.com/users/BeniCheni/following{/other_user}","gists_url":"https://api.github.com/users/BeniCheni/gists{/gist_id}","starred_url":"https://api.github.com/users/BeniCheni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeniCheni/subscriptions","organizations_url":"https://api.github.com/users/BeniCheni/orgs","repos_url":"https://api.github.com/users/BeniCheni/repos","events_url":"https://api.github.com/users/BeniCheni/events{/privacy}","received_events_url":"https://api.github.com/users/BeniCheni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BeniCheni/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/BeniCheni/node","forks_url":"https://api.github.com/repos/BeniCheni/node/forks","keys_url":"https://api.github.com/repos/BeniCheni/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BeniCheni/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BeniCheni/node/teams","hooks_url":"https://api.github.com/repos/BeniCheni/node/hooks","issue_events_url":"https://api.github.com/repos/BeniCheni/node/issues/events{/number}","events_url":"https://api.github.com/repos/BeniCheni/node/events","assignees_url":"https://api.github.com/repos/BeniCheni/node/assignees{/user}","branches_url":"https://api.github.com/repos/BeniCheni/node/branches{/branch}","tags_url":"https://api.github.com/repos/BeniCheni/node/tags","blobs_url":"https://api.github.com/repos/BeniCheni/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BeniCheni/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BeniCheni/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/BeniCheni/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BeniCheni/node/statuses/{sha}","languages_url":"https://api.github.com/repos/BeniCheni/node/languages","stargazers_url":"https://api.github.com/repos/BeniCheni/node/stargazers","contributors_url":"https://api.github.com/repos/BeniCheni/node/contributors","subscribers_url":"https://api.github.com/repos/BeniCheni/node/subscribers","subscription_url":"https://api.github.com/repos/BeniCheni/node/subscription","commits_url":"https://api.github.com/repos/BeniCheni/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/BeniCheni/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/BeniCheni/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/BeniCheni/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/BeniCheni/node/contents/{+path}","compare_url":"https://api.github.com/repos/BeniCheni/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BeniCheni/node/merges","archive_url":"https://api.github.com/repos/BeniCheni/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BeniCheni/node/downloads","issues_url":"https://api.github.com/repos/BeniCheni/node/issues{/number}","pulls_url":"https://api.github.com/repos/BeniCheni/node/pulls{/number}","milestones_url":"https://api.github.com/repos/BeniCheni/node/milestones{/number}","notifications_url":"https://api.github.com/repos/BeniCheni/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BeniCheni/node/labels{/name}","releases_url":"https://api.github.com/repos/BeniCheni/node/releases{/id}","deployments_url":"https://api.github.com/repos/BeniCheni/node/deployments","created_at":"2018-04-17T03:46:56Z","updated_at":"2018-04-17T03:47:17Z","pushed_at":"2018-04-18T05:20:34Z","git_url":"git://github.com/BeniCheni/node.git","ssh_url":"git@github.com:BeniCheni/node.git","clone_url":"https://github.com/BeniCheni/node.git","svn_url":"https://github.com/BeniCheni/node","homepage":"https://nodejs.org","size":373825,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"5eb9f3c91ce48a1c6818aaf4eddb0b8ff8071ecc","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-04-18T05:14:15Z","pushed_at":"2018-04-18T05:27:19Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":373903,"stargazers_count":47710,"watchers_count":47710,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10041,"mirror_url":null,"archived":false,"open_issues_count":732,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10041,"open_issues":732,"watchers":47710,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/20092"},"html":{"href":"https://github.com/nodejs/node/pull/20092"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/20092"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/20092/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/20092/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/20092/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b3c14c863b97b55f8889d2794f7b81bc971e8000"}},"author_association":"NONE"}}
{"actor":{"display_login":"BeniCheni"}}