{"action":"created","comment":{"url":"https://api.github.com/repos/dividat/driver/pulls/comments/233793823","pull_request_review_id":175253343,"id":233793823,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzc5MzgyMw==","diff_hunk":"@@ -1,30 +1,12 @@\n-### Release configuration #################################\n-# Path to folder in S3 (without slash at end)\n-BUCKET = s3://dist.dividat.ch/releases/driver2\n-\n-# where the BUCKET folder is accessible for getting updates (needs to end with a slash)\n-RELEASE_URL = https://dist.dividat.com/releases/driver2/\n-\n-\n ### Basic setup ###########################################\n-# Set GOPATH to repository path\n-CWD = $(dir $(realpath $(firstword $(MAKEFILE_LIST))))\n-GOPATH ?= $(CWD)\n-\n # Main source to build\n SRC = ./src/dividat-driver/main.go\n \n-# Default location where built binary will be placed\n-OUT ?= bin/dividat-driver\n-\n-# Get version from git\n-VERSION := $(shell git describe --always HEAD)\n+# Get version from git if not already set\n+VERSION ?= $(shell git describe --always HEAD)","path":"Makefile","position":23,"original_position":23,"commit_id":"ea63a4dc2b604b3d52a67171b817f692a9324d0c","original_commit_id":"ea63a4dc2b604b3d52a67171b817f692a9324d0c","user":{"login":"knuton","id":47458,"node_id":"MDQ6VXNlcjQ3NDU4","avatar_url":"https://avatars2.githubusercontent.com/u/47458?v=4","gravatar_id":"","url":"https://api.github.com/users/knuton","html_url":"https://github.com/knuton","followers_url":"https://api.github.com/users/knuton/followers","following_url":"https://api.github.com/users/knuton/following{/other_user}","gists_url":"https://api.github.com/users/knuton/gists{/gist_id}","starred_url":"https://api.github.com/users/knuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knuton/subscriptions","organizations_url":"https://api.github.com/users/knuton/orgs","repos_url":"https://api.github.com/users/knuton/repos","events_url":"https://api.github.com/users/knuton/events{/privacy}","received_events_url":"https://api.github.com/users/knuton/received_events","type":"User","site_admin":false},"body":"Now `bin/dividat-driver` has different version from build artifacts.","created_at":"2018-11-15T10:46:48Z","updated_at":"2018-11-15T10:57:26Z","html_url":"https://github.com/dividat/driver/pull/100#discussion_r233793823","pull_request_url":"https://api.github.com/repos/dividat/driver/pulls/100","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dividat/driver/pulls/comments/233793823"},"html":{"href":"https://github.com/dividat/driver/pull/100#discussion_r233793823"},"pull_request":{"href":"https://api.github.com/repos/dividat/driver/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/dividat/driver/pulls/100","id":231113106,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTEzMTA2","html_url":"https://github.com/dividat/driver/pull/100","diff_url":"https://github.com/dividat/driver/pull/100.diff","patch_url":"https://github.com/dividat/driver/pull/100.patch","issue_url":"https://api.github.com/repos/dividat/driver/issues/100","number":100,"state":"open","locked":false,"title":"[WIP] Nix managed node dependencies & deployment script","user":{"login":"pukkamustard","id":7925125,"node_id":"MDQ6VXNlcjc5MjUxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7925125?v=4","gravatar_id":"","url":"https://api.github.com/users/pukkamustard","html_url":"https://github.com/pukkamustard","followers_url":"https://api.github.com/users/pukkamustard/followers","following_url":"https://api.github.com/users/pukkamustard/following{/other_user}","gists_url":"https://api.github.com/users/pukkamustard/gists{/gist_id}","starred_url":"https://api.github.com/users/pukkamustard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pukkamustard/subscriptions","organizations_url":"https://api.github.com/users/pukkamustard/orgs","repos_url":"https://api.github.com/users/pukkamustard/repos","events_url":"https://api.github.com/users/pukkamustard/events{/privacy}","received_events_url":"https://api.github.com/users/pukkamustard/received_events","type":"User","site_admin":false},"body":"- Node dependencies are provided by Nix: This makes building purer (in Nix terms) as everything required for building and testing is defined in Nix expressions.\r\n- Make crossbuilding non-recursive. Previously crossbuilds where created by recursively starting nix-shells with cross-compilation tooling. Now crossbuilds are just nix expressions that are used from the main derivation.\r\n- `nix build` will build package containing all artifacts to be released (including crossbuilds) and a deployment script. This is made possible by the two points above.\r\n\r\nFor illustration this is the output from `nix build`:\r\n\r\n```\r\nresult\r\n├── [8.5M]  bin\r\n│   ├── [4.0K]  deploy\r\n│   └── [8.5M]  dividat-driver\r\n└── [ 15M]  release-unsigned\r\n    └── [ 15M]  develop\r\n        ├── [ 15M]  2.2.0-dev\r\n        │   ├── [8.6M]  dividat-driver-linux-amd64-2.2.0-dev\r\n        │   └── [6.6M]  dividat-driver-windows-amd64-2.2.0-dev.exe\r\n        └── [  10]  latest\r\n```\r\n\r\nThe `release-unsigned` folder contains unsigned artifacts to be released. The `bin/deploy` script creates all signatures and can deploy the release.\r\n\r\nA dynamically linked binary for the local system is provided (`bin/dividat-driver`) for testing or immediate usage.\r\n\r\nOther changes:\r\n\r\n- Version/channel is defined in `default.nix`: This is so that Nix can create releasable artifacts without relying on git to provide version/channel information.\r\n- `nix build` runs the test suite.\r\n- Remove `package-lock.json` file: To deduplicate exact definition of which version to use. Now the lock is in `nix/node/packages.nix`.\r\n\r\n## Todos\r\n\r\n- [ ] `nix-shell` from darwin will fail as we currently cannot crosscompile to target platforms from darwin. Add a `shell.nix` that does not include the crossbuilds for starting a development terminal on darwin.\r\n- [ ] Remove git-crypted keys and update external tooling to use them.\r\n- [ ] Update CI to simply run `nix build`","created_at":"2018-11-15T08:53:04Z","updated_at":"2018-11-15T10:57:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"463722d93bfbcdfb002f59a2bdf81de0b2f1f264","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dividat/driver/pulls/100/commits","review_comments_url":"https://api.github.com/repos/dividat/driver/pulls/100/comments","review_comment_url":"https://api.github.com/repos/dividat/driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dividat/driver/issues/100/comments","statuses_url":"https://api.github.com/repos/dividat/driver/statuses/ea63a4dc2b604b3d52a67171b817f692a9324d0c","head":{"label":"pukkamustard:nix-deps-deployment","ref":"nix-deps-deployment","sha":"ea63a4dc2b604b3d52a67171b817f692a9324d0c","user":{"login":"pukkamustard","id":7925125,"node_id":"MDQ6VXNlcjc5MjUxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7925125?v=4","gravatar_id":"","url":"https://api.github.com/users/pukkamustard","html_url":"https://github.com/pukkamustard","followers_url":"https://api.github.com/users/pukkamustard/followers","following_url":"https://api.github.com/users/pukkamustard/following{/other_user}","gists_url":"https://api.github.com/users/pukkamustard/gists{/gist_id}","starred_url":"https://api.github.com/users/pukkamustard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pukkamustard/subscriptions","organizations_url":"https://api.github.com/users/pukkamustard/orgs","repos_url":"https://api.github.com/users/pukkamustard/repos","events_url":"https://api.github.com/users/pukkamustard/events{/privacy}","received_events_url":"https://api.github.com/users/pukkamustard/received_events","type":"User","site_admin":false},"repo":{"id":82160894,"node_id":"MDEwOlJlcG9zaXRvcnk4MjE2MDg5NA==","name":"driver","full_name":"pukkamustard/driver","private":false,"owner":{"login":"pukkamustard","id":7925125,"node_id":"MDQ6VXNlcjc5MjUxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7925125?v=4","gravatar_id":"","url":"https://api.github.com/users/pukkamustard","html_url":"https://github.com/pukkamustard","followers_url":"https://api.github.com/users/pukkamustard/followers","following_url":"https://api.github.com/users/pukkamustard/following{/other_user}","gists_url":"https://api.github.com/users/pukkamustard/gists{/gist_id}","starred_url":"https://api.github.com/users/pukkamustard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pukkamustard/subscriptions","organizations_url":"https://api.github.com/users/pukkamustard/orgs","repos_url":"https://api.github.com/users/pukkamustard/repos","events_url":"https://api.github.com/users/pukkamustard/events{/privacy}","received_events_url":"https://api.github.com/users/pukkamustard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pukkamustard/driver","description":"Dividat drivers and hardware test suites","fork":true,"url":"https://api.github.com/repos/pukkamustard/driver","forks_url":"https://api.github.com/repos/pukkamustard/driver/forks","keys_url":"https://api.github.com/repos/pukkamustard/driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pukkamustard/driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pukkamustard/driver/teams","hooks_url":"https://api.github.com/repos/pukkamustard/driver/hooks","issue_events_url":"https://api.github.com/repos/pukkamustard/driver/issues/events{/number}","events_url":"https://api.github.com/repos/pukkamustard/driver/events","assignees_url":"https://api.github.com/repos/pukkamustard/driver/assignees{/user}","branches_url":"https://api.github.com/repos/pukkamustard/driver/branches{/branch}","tags_url":"https://api.github.com/repos/pukkamustard/driver/tags","blobs_url":"https://api.github.com/repos/pukkamustard/driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pukkamustard/driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pukkamustard/driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/pukkamustard/driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pukkamustard/driver/statuses/{sha}","languages_url":"https://api.github.com/repos/pukkamustard/driver/languages","stargazers_url":"https://api.github.com/repos/pukkamustard/driver/stargazers","contributors_url":"https://api.github.com/repos/pukkamustard/driver/contributors","subscribers_url":"https://api.github.com/repos/pukkamustard/driver/subscribers","subscription_url":"https://api.github.com/repos/pukkamustard/driver/subscription","commits_url":"https://api.github.com/repos/pukkamustard/driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/pukkamustard/driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/pukkamustard/driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/pukkamustard/driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/pukkamustard/driver/contents/{+path}","compare_url":"https://api.github.com/repos/pukkamustard/driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pukkamustard/driver/merges","archive_url":"https://api.github.com/repos/pukkamustard/driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pukkamustard/driver/downloads","issues_url":"https://api.github.com/repos/pukkamustard/driver/issues{/number}","pulls_url":"https://api.github.com/repos/pukkamustard/driver/pulls{/number}","milestones_url":"https://api.github.com/repos/pukkamustard/driver/milestones{/number}","notifications_url":"https://api.github.com/repos/pukkamustard/driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pukkamustard/driver/labels{/name}","releases_url":"https://api.github.com/repos/pukkamustard/driver/releases{/id}","deployments_url":"https://api.github.com/repos/pukkamustard/driver/deployments","created_at":"2017-02-16T09:03:26Z","updated_at":"2017-02-16T09:03:28Z","pushed_at":"2018-11-15T09:02:38Z","git_url":"git://github.com/pukkamustard/driver.git","ssh_url":"git@github.com:pukkamustard/driver.git","clone_url":"https://github.com/pukkamustard/driver.git","svn_url":"https://github.com/pukkamustard/driver","homepage":"","size":3621,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"dividat:develop","ref":"develop","sha":"dc52083c3f4fdfde5953eee028313cd6eee2431b","user":{"login":"dividat","id":17985246,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTg1MjQ2","avatar_url":"https://avatars1.githubusercontent.com/u/17985246?v=4","gravatar_id":"","url":"https://api.github.com/users/dividat","html_url":"https://github.com/dividat","followers_url":"https://api.github.com/users/dividat/followers","following_url":"https://api.github.com/users/dividat/following{/other_user}","gists_url":"https://api.github.com/users/dividat/gists{/gist_id}","starred_url":"https://api.github.com/users/dividat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dividat/subscriptions","organizations_url":"https://api.github.com/users/dividat/orgs","repos_url":"https://api.github.com/users/dividat/repos","events_url":"https://api.github.com/users/dividat/events{/privacy}","received_events_url":"https://api.github.com/users/dividat/received_events","type":"Organization","site_admin":false},"repo":{"id":66946468,"node_id":"MDEwOlJlcG9zaXRvcnk2Njk0NjQ2OA==","name":"driver","full_name":"dividat/driver","private":false,"owner":{"login":"dividat","id":17985246,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTg1MjQ2","avatar_url":"https://avatars1.githubusercontent.com/u/17985246?v=4","gravatar_id":"","url":"https://api.github.com/users/dividat","html_url":"https://github.com/dividat","followers_url":"https://api.github.com/users/dividat/followers","following_url":"https://api.github.com/users/dividat/following{/other_user}","gists_url":"https://api.github.com/users/dividat/gists{/gist_id}","starred_url":"https://api.github.com/users/dividat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dividat/subscriptions","organizations_url":"https://api.github.com/users/dividat/orgs","repos_url":"https://api.github.com/users/dividat/repos","events_url":"https://api.github.com/users/dividat/events{/privacy}","received_events_url":"https://api.github.com/users/dividat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dividat/driver","description":"Dividat drivers and hardware test suites","fork":false,"url":"https://api.github.com/repos/dividat/driver","forks_url":"https://api.github.com/repos/dividat/driver/forks","keys_url":"https://api.github.com/repos/dividat/driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dividat/driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dividat/driver/teams","hooks_url":"https://api.github.com/repos/dividat/driver/hooks","issue_events_url":"https://api.github.com/repos/dividat/driver/issues/events{/number}","events_url":"https://api.github.com/repos/dividat/driver/events","assignees_url":"https://api.github.com/repos/dividat/driver/assignees{/user}","branches_url":"https://api.github.com/repos/dividat/driver/branches{/branch}","tags_url":"https://api.github.com/repos/dividat/driver/tags","blobs_url":"https://api.github.com/repos/dividat/driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dividat/driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dividat/driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/dividat/driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dividat/driver/statuses/{sha}","languages_url":"https://api.github.com/repos/dividat/driver/languages","stargazers_url":"https://api.github.com/repos/dividat/driver/stargazers","contributors_url":"https://api.github.com/repos/dividat/driver/contributors","subscribers_url":"https://api.github.com/repos/dividat/driver/subscribers","subscription_url":"https://api.github.com/repos/dividat/driver/subscription","commits_url":"https://api.github.com/repos/dividat/driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/dividat/driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/dividat/driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/dividat/driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/dividat/driver/contents/{+path}","compare_url":"https://api.github.com/repos/dividat/driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dividat/driver/merges","archive_url":"https://api.github.com/repos/dividat/driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dividat/driver/downloads","issues_url":"https://api.github.com/repos/dividat/driver/issues{/number}","pulls_url":"https://api.github.com/repos/dividat/driver/pulls{/number}","milestones_url":"https://api.github.com/repos/dividat/driver/milestones{/number}","notifications_url":"https://api.github.com/repos/dividat/driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dividat/driver/labels{/name}","releases_url":"https://api.github.com/repos/dividat/driver/releases{/id}","deployments_url":"https://api.github.com/repos/dividat/driver/deployments","created_at":"2016-08-30T14:08:31Z","updated_at":"2018-11-14T16:47:59Z","pushed_at":"2018-11-15T09:02:39Z","git_url":"git://github.com/dividat/driver.git","ssh_url":"git@github.com:dividat/driver.git","clone_url":"https://github.com/dividat/driver.git","svn_url":"https://github.com/dividat/driver","homepage":"","size":3596,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dividat/driver/pulls/100"},"html":{"href":"https://github.com/dividat/driver/pull/100"},"issue":{"href":"https://api.github.com/repos/dividat/driver/issues/100"},"comments":{"href":"https://api.github.com/repos/dividat/driver/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/dividat/driver/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/dividat/driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dividat/driver/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/dividat/driver/statuses/ea63a4dc2b604b3d52a67171b817f692a9324d0c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"knuton"}}