{"action":"created","issue":{"url":"https://api.github.com/repos/auth0/cosmos/issues/695","repository_url":"https://api.github.com/repos/auth0/cosmos","labels_url":"https://api.github.com/repos/auth0/cosmos/issues/695/labels{/name}","comments_url":"https://api.github.com/repos/auth0/cosmos/issues/695/comments","events_url":"https://api.github.com/repos/auth0/cosmos/issues/695/events","html_url":"https://github.com/auth0/cosmos/pull/695","id":341905034,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTMwMjAy","number":695,"title":"Add multiple links to breadcrumbs","user":{"login":"siddharthkp","id":1863771,"node_id":"MDQ6VXNlcjE4NjM3NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1863771?v=4","gravatar_id":"","url":"https://api.github.com/users/siddharthkp","html_url":"https://github.com/siddharthkp","followers_url":"https://api.github.com/users/siddharthkp/followers","following_url":"https://api.github.com/users/siddharthkp/following{/other_user}","gists_url":"https://api.github.com/users/siddharthkp/gists{/gist_id}","starred_url":"https://api.github.com/users/siddharthkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddharthkp/subscriptions","organizations_url":"https://api.github.com/users/siddharthkp/orgs","repos_url":"https://api.github.com/users/siddharthkp/repos","events_url":"https://api.github.com/users/siddharthkp/events{/privacy}","received_events_url":"https://api.github.com/users/siddharthkp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-17T12:49:43Z","updated_at":"2018-07-17T19:04:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/auth0/cosmos/pulls/695","html_url":"https://github.com/auth0/cosmos/pull/695","diff_url":"https://github.com/auth0/cosmos/pull/695.diff","patch_url":"https://github.com/auth0/cosmos/pull/695.patch"},"body":"Supersedes https://github.com/auth0/cosmos/pull/672\r\n\r\nBased on the [discussion in #672](https://github.com/auth0/cosmos/pull/672/files/5a4de096a1db52f39461163dcc22613374485f06#diff-65309c65c82b131312368482cd6d6761), I've made the API more declarative:\r\n\r\n```jsx\r\n<Breadcrumb>\r\n  <Breadcrumb.Link href=\"/home\">Home</Breadcrumb.Link>\r\n  <Breadcrumb.Link href=\"/parent\">Parent</Breadcrumb.Link>\r\n  <Breadcrumb.Link href=\"/parent/child\">Child</Breadcrumb.Link>\r\n</Breadcrumb>\r\n```\r\n\r\n`Breadcrumb.Link` is a proxy to `Link` which means we get `href` and `onClick` both. (We also get the prop validations along with it)\r\n\r\n`Breadcrumb` component adds the separators between them making it a purely visual layer.\r\n\r\nI'm not sure what the left arrow in the component means, is it attached the first link or is the expectation that it takes you back one step?"},"comment":{"url":"https://api.github.com/repos/auth0/cosmos/issues/comments/405692887","html_url":"https://github.com/auth0/cosmos/pull/695#issuecomment-405692887","issue_url":"https://api.github.com/repos/auth0/cosmos/issues/695","id":405692887,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTY5Mjg4Nw==","user":{"login":"nkohari","id":1576,"node_id":"MDQ6VXNlcjE1NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1576?v=4","gravatar_id":"","url":"https://api.github.com/users/nkohari","html_url":"https://github.com/nkohari","followers_url":"https://api.github.com/users/nkohari/followers","following_url":"https://api.github.com/users/nkohari/following{/other_user}","gists_url":"https://api.github.com/users/nkohari/gists{/gist_id}","starred_url":"https://api.github.com/users/nkohari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkohari/subscriptions","organizations_url":"https://api.github.com/users/nkohari/orgs","repos_url":"https://api.github.com/users/nkohari/repos","events_url":"https://api.github.com/users/nkohari/events{/privacy}","received_events_url":"https://api.github.com/users/nkohari/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T19:04:12Z","updated_at":"2018-07-17T19:04:12Z","author_association":"COLLABORATOR","body":"I think we might want to just let the user decide what icons to use with an `icon` prop. That way they can make the first crumb \"home\" if they want, and if they want to just have a single crumb with a back button (as in the third example) they can do so. (Although that could also just be implemented using a regular `Link`, to be honest.)"}}
{"actor":{"display_login":"nkohari"}}