{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/bond/pulls/comments/181923507","pull_request_review_id":112633325,"id":181923507,"diff_hunk":"@@ -107,6 +126,259 @@ TEST_CASE_BEGIN(MaybeInterface)\n }\n TEST_CASE_END\n \n+TEST_CASE_BEGIN(CopyAndMoveFromValues)\n+{\n+    { // simple type","path":"cpp/test/core/maybe_tests.cpp","position":127,"original_position":127,"commit_id":"0cc85db31942decf7fadc709fb3b84bcfc8d014e","original_commit_id":"0cc85db31942decf7fadc709fb3b84bcfc8d014e","user":{"login":"ara-ayvazyan","id":25734498,"avatar_url":"https://avatars1.githubusercontent.com/u/25734498?v=4","gravatar_id":"","url":"https://api.github.com/users/ara-ayvazyan","html_url":"https://github.com/ara-ayvazyan","followers_url":"https://api.github.com/users/ara-ayvazyan/followers","following_url":"https://api.github.com/users/ara-ayvazyan/following{/other_user}","gists_url":"https://api.github.com/users/ara-ayvazyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ara-ayvazyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ara-ayvazyan/subscriptions","organizations_url":"https://api.github.com/users/ara-ayvazyan/orgs","repos_url":"https://api.github.com/users/ara-ayvazyan/repos","events_url":"https://api.github.com/users/ara-ayvazyan/events{/privacy}","received_events_url":"https://api.github.com/users/ara-ayvazyan/received_events","type":"User","site_admin":false},"body":"Use `BOOST_TEST_CONTEXT`?","created_at":"2018-04-17T00:31:02Z","updated_at":"2018-04-17T00:31:02Z","html_url":"https://github.com/Microsoft/bond/pull/849#discussion_r181923507","pull_request_url":"https://api.github.com/repos/Microsoft/bond/pulls/849","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/comments/181923507"},"html":{"href":"https://github.com/Microsoft/bond/pull/849#discussion_r181923507"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/849"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/bond/pulls/849","id":180092500,"html_url":"https://github.com/Microsoft/bond/pull/849","diff_url":"https://github.com/Microsoft/bond/pull/849.diff","patch_url":"https://github.com/Microsoft/bond/pull/849.patch","issue_url":"https://api.github.com/repos/Microsoft/bond/issues/849","number":849,"state":"open","locked":false,"title":"[c++] Overhaul bond::maybe","user":{"login":"chwarr","id":10605667,"avatar_url":"https://avatars3.githubusercontent.com/u/10605667?v=4","gravatar_id":"","url":"https://api.github.com/users/chwarr","html_url":"https://github.com/chwarr","followers_url":"https://api.github.com/users/chwarr/followers","following_url":"https://api.github.com/users/chwarr/following{/other_user}","gists_url":"https://api.github.com/users/chwarr/gists{/gist_id}","starred_url":"https://api.github.com/users/chwarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chwarr/subscriptions","organizations_url":"https://api.github.com/users/chwarr/orgs","repos_url":"https://api.github.com/users/chwarr/repos","events_url":"https://api.github.com/users/chwarr/events{/privacy}","received_events_url":"https://api.github.com/users/chwarr/received_events","type":"User","site_admin":false},"body":"bond::maybe now has better support for rvalue-references and allocator\r\npropagation.\r\n\r\nThis implementation also avoids default initializing an instance of T\r\nwhen creating an maybe that holds nothing\r\n\r\nbond::maybe is now implemented in terms of boost::optional. We should be\r\nable to std::optional with minimal effort when Bond requires a minimum\r\nof C++17.\r\n\r\nAdditional changes:\r\n\r\n* Removed a dangerous implicit conversion operator from `bond::maybe<T>`\r\n  to `const T&`. To access a `bond::maybe<T>` value, use\r\n* Added noexcept variants of `bond::maybe<T>::value`.\r\n* Added `bond::maybe<T>::emplace` to construct a maybe's value in place.\r\n* Added various rvalue-reference and allocator-aware constructors and\r\n  assignment operators.\r\n* Added `bond::maybe<T>::operator==(const T&)` to comapre directly to\r\n  instances of `T`.\r\n* Improved test coverage of `set_value()`: it was only effectively\r\n  constructing a new T the first time.\r\n* Added tests for moved-from bond::maybe instances.\r\n* Added tests for allocator propagation.","created_at":"2018-04-07T06:36:05Z","updated_at":"2018-04-17T00:31:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adda10a30e4302da0cc59c82bbf05e894bf93afb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/bond/pulls/849/commits","review_comments_url":"https://api.github.com/repos/Microsoft/bond/pulls/849/comments","review_comment_url":"https://api.github.com/repos/Microsoft/bond/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/bond/issues/849/comments","statuses_url":"https://api.github.com/repos/Microsoft/bond/statuses/0cc85db31942decf7fadc709fb3b84bcfc8d014e","head":{"label":"chwarr:chwarr/maybe-default-init","ref":"chwarr/maybe-default-init","sha":"0cc85db31942decf7fadc709fb3b84bcfc8d014e","user":{"login":"chwarr","id":10605667,"avatar_url":"https://avatars3.githubusercontent.com/u/10605667?v=4","gravatar_id":"","url":"https://api.github.com/users/chwarr","html_url":"https://github.com/chwarr","followers_url":"https://api.github.com/users/chwarr/followers","following_url":"https://api.github.com/users/chwarr/following{/other_user}","gists_url":"https://api.github.com/users/chwarr/gists{/gist_id}","starred_url":"https://api.github.com/users/chwarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chwarr/subscriptions","organizations_url":"https://api.github.com/users/chwarr/orgs","repos_url":"https://api.github.com/users/chwarr/repos","events_url":"https://api.github.com/users/chwarr/events{/privacy}","received_events_url":"https://api.github.com/users/chwarr/received_events","type":"User","site_admin":false},"repo":{"id":30380978,"name":"bond","full_name":"chwarr/bond","owner":{"login":"chwarr","id":10605667,"avatar_url":"https://avatars3.githubusercontent.com/u/10605667?v=4","gravatar_id":"","url":"https://api.github.com/users/chwarr","html_url":"https://github.com/chwarr","followers_url":"https://api.github.com/users/chwarr/followers","following_url":"https://api.github.com/users/chwarr/following{/other_user}","gists_url":"https://api.github.com/users/chwarr/gists{/gist_id}","starred_url":"https://api.github.com/users/chwarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chwarr/subscriptions","organizations_url":"https://api.github.com/users/chwarr/orgs","repos_url":"https://api.github.com/users/chwarr/repos","events_url":"https://api.github.com/users/chwarr/events{/privacy}","received_events_url":"https://api.github.com/users/chwarr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chwarr/bond","description":"Bond is a cross-platform framework for working with schematized data. It supports cross-language de/serialization and powerful generic mechanisms for efficiently manipulating data. Bond is broadly used at Microsoft in high scale services. ","fork":true,"url":"https://api.github.com/repos/chwarr/bond","forks_url":"https://api.github.com/repos/chwarr/bond/forks","keys_url":"https://api.github.com/repos/chwarr/bond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chwarr/bond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chwarr/bond/teams","hooks_url":"https://api.github.com/repos/chwarr/bond/hooks","issue_events_url":"https://api.github.com/repos/chwarr/bond/issues/events{/number}","events_url":"https://api.github.com/repos/chwarr/bond/events","assignees_url":"https://api.github.com/repos/chwarr/bond/assignees{/user}","branches_url":"https://api.github.com/repos/chwarr/bond/branches{/branch}","tags_url":"https://api.github.com/repos/chwarr/bond/tags","blobs_url":"https://api.github.com/repos/chwarr/bond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chwarr/bond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chwarr/bond/git/refs{/sha}","trees_url":"https://api.github.com/repos/chwarr/bond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chwarr/bond/statuses/{sha}","languages_url":"https://api.github.com/repos/chwarr/bond/languages","stargazers_url":"https://api.github.com/repos/chwarr/bond/stargazers","contributors_url":"https://api.github.com/repos/chwarr/bond/contributors","subscribers_url":"https://api.github.com/repos/chwarr/bond/subscribers","subscription_url":"https://api.github.com/repos/chwarr/bond/subscription","commits_url":"https://api.github.com/repos/chwarr/bond/commits{/sha}","git_commits_url":"https://api.github.com/repos/chwarr/bond/git/commits{/sha}","comments_url":"https://api.github.com/repos/chwarr/bond/comments{/number}","issue_comment_url":"https://api.github.com/repos/chwarr/bond/issues/comments{/number}","contents_url":"https://api.github.com/repos/chwarr/bond/contents/{+path}","compare_url":"https://api.github.com/repos/chwarr/bond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chwarr/bond/merges","archive_url":"https://api.github.com/repos/chwarr/bond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chwarr/bond/downloads","issues_url":"https://api.github.com/repos/chwarr/bond/issues{/number}","pulls_url":"https://api.github.com/repos/chwarr/bond/pulls{/number}","milestones_url":"https://api.github.com/repos/chwarr/bond/milestones{/number}","notifications_url":"https://api.github.com/repos/chwarr/bond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chwarr/bond/labels{/name}","releases_url":"https://api.github.com/repos/chwarr/bond/releases{/id}","deployments_url":"https://api.github.com/repos/chwarr/bond/deployments","created_at":"2015-02-05T22:05:22Z","updated_at":"2018-04-06T23:54:41Z","pushed_at":"2018-04-16T23:09:17Z","git_url":"git://github.com/chwarr/bond.git","ssh_url":"git@github.com:chwarr/bond.git","clone_url":"https://github.com/chwarr/bond.git","svn_url":"https://github.com/chwarr/bond","homepage":null,"size":6806,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"a256dbc3191471be822bdbe35257c263de6a8941","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":28014525,"name":"bond","full_name":"Microsoft/bond","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/bond","description":"Bond is a cross-platform framework for working with schematized data. It supports cross-language de/serialization and powerful generic mechanisms for efficiently manipulating data. Bond is broadly used at Microsoft in high scale services. ","fork":false,"url":"https://api.github.com/repos/Microsoft/bond","forks_url":"https://api.github.com/repos/Microsoft/bond/forks","keys_url":"https://api.github.com/repos/Microsoft/bond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/bond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/bond/teams","hooks_url":"https://api.github.com/repos/Microsoft/bond/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/bond/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/bond/events","assignees_url":"https://api.github.com/repos/Microsoft/bond/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/bond/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/bond/tags","blobs_url":"https://api.github.com/repos/Microsoft/bond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/bond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/bond/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/bond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/bond/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/bond/languages","stargazers_url":"https://api.github.com/repos/Microsoft/bond/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/bond/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/bond/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/bond/subscription","commits_url":"https://api.github.com/repos/Microsoft/bond/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/bond/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/bond/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/bond/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/bond/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/bond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/bond/merges","archive_url":"https://api.github.com/repos/Microsoft/bond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/bond/downloads","issues_url":"https://api.github.com/repos/Microsoft/bond/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/bond/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/bond/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/bond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/bond/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/bond/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/bond/deployments","created_at":"2014-12-15T01:05:31Z","updated_at":"2018-04-16T22:05:27Z","pushed_at":"2018-04-16T23:33:52Z","git_url":"git://github.com/Microsoft/bond.git","ssh_url":"git@github.com:Microsoft/bond.git","clone_url":"https://github.com/Microsoft/bond.git","svn_url":"https://github.com/Microsoft/bond","homepage":null,"size":13025,"stargazers_count":1711,"watchers_count":1711,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":235,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":235,"open_issues":123,"watchers":1711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/849"},"html":{"href":"https://github.com/Microsoft/bond/pull/849"},"issue":{"href":"https://api.github.com/repos/Microsoft/bond/issues/849"},"comments":{"href":"https://api.github.com/repos/Microsoft/bond/issues/849/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/849/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/849/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/bond/statuses/0cc85db31942decf7fadc709fb3b84bcfc8d014e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ara-ayvazyan"}}