{"action":"created","comment":{"url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/comments/244521911","pull_request_review_id":188425770,"id":244521911,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDUyMTkxMQ==","diff_hunk":"@@ -143,7 +143,6 @@ void BuildEvents_OnBuildProjConfigDone(string Project, string ProjectConfig, str\n \n         void BuildEvents_OnBuildBegin(vsBuildScope Scope, vsBuildAction Action)\n         {\n-            DataModel.CollectPerformanceData(true);   //TODO: I wouldn't collect data here. Problem is that few projects starts in the same moment, so we have overload. I would just get performance statistics in the same time interval.","path":"ParallelBuildsMonitorWindowCommand.cs","position":4,"original_position":4,"commit_id":"d82b094ca332f27595eb56d4ac06916935b2b327","original_commit_id":"d82b094ca332f27595eb56d4ac06916935b2b327","user":{"login":"atrelinski","id":37815148,"node_id":"MDQ6VXNlcjM3ODE1MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/37815148?v=4","gravatar_id":"","url":"https://api.github.com/users/atrelinski","html_url":"https://github.com/atrelinski","followers_url":"https://api.github.com/users/atrelinski/followers","following_url":"https://api.github.com/users/atrelinski/following{/other_user}","gists_url":"https://api.github.com/users/atrelinski/gists{/gist_id}","starred_url":"https://api.github.com/users/atrelinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atrelinski/subscriptions","organizations_url":"https://api.github.com/users/atrelinski/orgs","repos_url":"https://api.github.com/users/atrelinski/repos","events_url":"https://api.github.com/users/atrelinski/events{/privacy}","received_events_url":"https://api.github.com/users/atrelinski/received_events","type":"User","site_admin":false},"body":"Issue 3: For case when 3 builds starts in the same time (because they depend on the same previous project), this will collect data in the same point of time 3 times. Problem is that if performance data is collected several times in the same moment, the first one may vary, but next ones are always 100%. This happen probably because measuring occupy CPU and HDD.\r\nLooks like [Schrödinger's cat](https://en.wikipedia.org/wiki/Schr%C3%B6dinger%27s_cat) issue ;)","created_at":"2018-12-30T01:03:32Z","updated_at":"2018-12-30T01:07:36Z","html_url":"https://github.com/KrzysztofBuchacz/ParallelBuildsMonitor/pull/15#discussion_r244521911","pull_request_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/comments/244521911"},"html":{"href":"https://github.com/KrzysztofBuchacz/ParallelBuildsMonitor/pull/15#discussion_r244521911"},"pull_request":{"href":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/15","id":241470320,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDcwMzIw","html_url":"https://github.com/KrzysztofBuchacz/ParallelBuildsMonitor/pull/15","diff_url":"https://github.com/KrzysztofBuchacz/ParallelBuildsMonitor/pull/15.diff","patch_url":"https://github.com/KrzysztofBuchacz/ParallelBuildsMonitor/pull/15.patch","issue_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/issues/15","number":15,"state":"open","locked":false,"title":"Fix performance timer; Fix graph refresh timer","user":{"login":"atrelinski","id":37815148,"node_id":"MDQ6VXNlcjM3ODE1MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/37815148?v=4","gravatar_id":"","url":"https://api.github.com/users/atrelinski","html_url":"https://github.com/atrelinski","followers_url":"https://api.github.com/users/atrelinski/followers","following_url":"https://api.github.com/users/atrelinski/following{/other_user}","gists_url":"https://api.github.com/users/atrelinski/gists{/gist_id}","starred_url":"https://api.github.com/users/atrelinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atrelinski/subscriptions","organizations_url":"https://api.github.com/users/atrelinski/orgs","repos_url":"https://api.github.com/users/atrelinski/repos","events_url":"https://api.github.com/users/atrelinski/events{/privacy}","received_events_url":"https://api.github.com/users/atrelinski/received_events","type":"User","site_admin":false},"body":"With this change even big solutions doesn't hung up, like few versions before","created_at":"2018-12-30T00:38:25Z","updated_at":"2018-12-30T01:07:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"900620ed1b6c64c84052b46e4e036f7e13cfdd0c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/15/commits","review_comments_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/15/comments","review_comment_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/issues/15/comments","statuses_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/statuses/d82b094ca332f27595eb56d4ac06916935b2b327","head":{"label":"atrelinski:FixPerformanceTimer","ref":"FixPerformanceTimer","sha":"d82b094ca332f27595eb56d4ac06916935b2b327","user":{"login":"atrelinski","id":37815148,"node_id":"MDQ6VXNlcjM3ODE1MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/37815148?v=4","gravatar_id":"","url":"https://api.github.com/users/atrelinski","html_url":"https://github.com/atrelinski","followers_url":"https://api.github.com/users/atrelinski/followers","following_url":"https://api.github.com/users/atrelinski/following{/other_user}","gists_url":"https://api.github.com/users/atrelinski/gists{/gist_id}","starred_url":"https://api.github.com/users/atrelinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atrelinski/subscriptions","organizations_url":"https://api.github.com/users/atrelinski/orgs","repos_url":"https://api.github.com/users/atrelinski/repos","events_url":"https://api.github.com/users/atrelinski/events{/privacy}","received_events_url":"https://api.github.com/users/atrelinski/received_events","type":"User","site_admin":false},"repo":{"id":160976614,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5NzY2MTQ=","name":"ParallelBuildsMonitor","full_name":"atrelinski/ParallelBuildsMonitor","private":false,"owner":{"login":"atrelinski","id":37815148,"node_id":"MDQ6VXNlcjM3ODE1MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/37815148?v=4","gravatar_id":"","url":"https://api.github.com/users/atrelinski","html_url":"https://github.com/atrelinski","followers_url":"https://api.github.com/users/atrelinski/followers","following_url":"https://api.github.com/users/atrelinski/following{/other_user}","gists_url":"https://api.github.com/users/atrelinski/gists{/gist_id}","starred_url":"https://api.github.com/users/atrelinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atrelinski/subscriptions","organizations_url":"https://api.github.com/users/atrelinski/orgs","repos_url":"https://api.github.com/users/atrelinski/repos","events_url":"https://api.github.com/users/atrelinski/events{/privacy}","received_events_url":"https://api.github.com/users/atrelinski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/atrelinski/ParallelBuildsMonitor","description":null,"fork":true,"url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor","forks_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/forks","keys_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/teams","hooks_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/hooks","issue_events_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/issues/events{/number}","events_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/events","assignees_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/assignees{/user}","branches_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/branches{/branch}","tags_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/tags","blobs_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/statuses/{sha}","languages_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/languages","stargazers_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/stargazers","contributors_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/contributors","subscribers_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/subscribers","subscription_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/subscription","commits_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/contents/{+path}","compare_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/merges","archive_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/downloads","issues_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/issues{/number}","pulls_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/pulls{/number}","milestones_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/milestones{/number}","notifications_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/labels{/name}","releases_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/releases{/id}","deployments_url":"https://api.github.com/repos/atrelinski/ParallelBuildsMonitor/deployments","created_at":"2018-12-08T20:37:37Z","updated_at":"2018-12-24T14:13:44Z","pushed_at":"2018-12-30T00:37:13Z","git_url":"git://github.com/atrelinski/ParallelBuildsMonitor.git","ssh_url":"git@github.com:atrelinski/ParallelBuildsMonitor.git","clone_url":"https://github.com/atrelinski/ParallelBuildsMonitor.git","svn_url":"https://github.com/atrelinski/ParallelBuildsMonitor","homepage":null,"size":173,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KrzysztofBuchacz:master","ref":"master","sha":"d9c86b135f47b4267caf44cd9514de6bdc612b62","user":{"login":"KrzysztofBuchacz","id":11552368,"node_id":"MDQ6VXNlcjExNTUyMzY4","avatar_url":"https://avatars0.githubusercontent.com/u/11552368?v=4","gravatar_id":"","url":"https://api.github.com/users/KrzysztofBuchacz","html_url":"https://github.com/KrzysztofBuchacz","followers_url":"https://api.github.com/users/KrzysztofBuchacz/followers","following_url":"https://api.github.com/users/KrzysztofBuchacz/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofBuchacz/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofBuchacz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofBuchacz/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofBuchacz/orgs","repos_url":"https://api.github.com/users/KrzysztofBuchacz/repos","events_url":"https://api.github.com/users/KrzysztofBuchacz/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofBuchacz/received_events","type":"User","site_admin":false},"repo":{"id":74284813,"node_id":"MDEwOlJlcG9zaXRvcnk3NDI4NDgxMw==","name":"ParallelBuildsMonitor","full_name":"KrzysztofBuchacz/ParallelBuildsMonitor","private":false,"owner":{"login":"KrzysztofBuchacz","id":11552368,"node_id":"MDQ6VXNlcjExNTUyMzY4","avatar_url":"https://avatars0.githubusercontent.com/u/11552368?v=4","gravatar_id":"","url":"https://api.github.com/users/KrzysztofBuchacz","html_url":"https://github.com/KrzysztofBuchacz","followers_url":"https://api.github.com/users/KrzysztofBuchacz/followers","following_url":"https://api.github.com/users/KrzysztofBuchacz/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofBuchacz/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofBuchacz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofBuchacz/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofBuchacz/orgs","repos_url":"https://api.github.com/users/KrzysztofBuchacz/repos","events_url":"https://api.github.com/users/KrzysztofBuchacz/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofBuchacz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KrzysztofBuchacz/ParallelBuildsMonitor","description":null,"fork":false,"url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor","forks_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/forks","keys_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/teams","hooks_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/hooks","issue_events_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/issues/events{/number}","events_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/events","assignees_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/assignees{/user}","branches_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/branches{/branch}","tags_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/tags","blobs_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/statuses/{sha}","languages_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/languages","stargazers_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/stargazers","contributors_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/contributors","subscribers_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/subscribers","subscription_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/subscription","commits_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/contents/{+path}","compare_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/merges","archive_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/downloads","issues_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/issues{/number}","pulls_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls{/number}","milestones_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/milestones{/number}","notifications_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/labels{/name}","releases_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/releases{/id}","deployments_url":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/deployments","created_at":"2016-11-20T15:47:01Z","updated_at":"2018-12-29T18:58:18Z","pushed_at":"2018-12-30T00:38:26Z","git_url":"git://github.com/KrzysztofBuchacz/ParallelBuildsMonitor.git","ssh_url":"git@github.com:KrzysztofBuchacz/ParallelBuildsMonitor.git","clone_url":"https://github.com/KrzysztofBuchacz/ParallelBuildsMonitor.git","svn_url":"https://github.com/KrzysztofBuchacz/ParallelBuildsMonitor","homepage":null,"size":79,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/15"},"html":{"href":"https://github.com/KrzysztofBuchacz/ParallelBuildsMonitor/pull/15"},"issue":{"href":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/issues/15"},"comments":{"href":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/KrzysztofBuchacz/ParallelBuildsMonitor/statuses/d82b094ca332f27595eb56d4ac06916935b2b327"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"atrelinski"}}