{"action":"created","comment":{"url":"https://api.github.com/repos/ipmitool/ipmitool/pulls/comments/231201592","pull_request_review_id":172109488,"id":231201592,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTIwMTU5Mg==","diff_hunk":"@@ -875,9 +877,11 @@ ipmi_start_daemon(struct ipmi_intf *intf)\n \t}\n \n \tfd = open(\"/dev/null\", O_RDWR);\n-\tassert(0 == fd);\n-\tdup(fd);\n-\tdup(fd);\n+\tassert(STDIN_FILENO == fd);\n+\tret = dup(fd);\n+\tassert(STDOUT_FILENO == ret);\n+\tret = dup(fd);\n+\tassert(STDERR_FILENO == ret);","path":"lib/helper.c","position":29,"original_position":29,"commit_id":"6eef07cdb23ff8c92ffb2bdfea456e9a64fc9a1f","original_commit_id":"e31b502c76ab4c580f2c3a8919f97bf68512f71a","user":{"login":"AlexanderAmelkin","id":4518124,"node_id":"MDQ6VXNlcjQ1MTgxMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4518124?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexanderAmelkin","html_url":"https://github.com/AlexanderAmelkin","followers_url":"https://api.github.com/users/AlexanderAmelkin/followers","following_url":"https://api.github.com/users/AlexanderAmelkin/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderAmelkin/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderAmelkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderAmelkin/subscriptions","organizations_url":"https://api.github.com/users/AlexanderAmelkin/orgs","repos_url":"https://api.github.com/users/AlexanderAmelkin/repos","events_url":"https://api.github.com/users/AlexanderAmelkin/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderAmelkin/received_events","type":"User","site_admin":false},"body":"Same here. Don't use assertions. Check return values of `dup()` and print out a errno-based message on errors.","created_at":"2018-11-06T16:45:44Z","updated_at":"2018-11-06T16:58:55Z","html_url":"https://github.com/ipmitool/ipmitool/pull/49#discussion_r231201592","pull_request_url":"https://api.github.com/repos/ipmitool/ipmitool/pulls/49","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ipmitool/ipmitool/pulls/comments/231201592"},"html":{"href":"https://github.com/ipmitool/ipmitool/pull/49#discussion_r231201592"},"pull_request":{"href":"https://api.github.com/repos/ipmitool/ipmitool/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/ipmitool/ipmitool/pulls/49","id":228514776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTE0Nzc2","html_url":"https://github.com/ipmitool/ipmitool/pull/49","diff_url":"https://github.com/ipmitool/ipmitool/pull/49.diff","patch_url":"https://github.com/ipmitool/ipmitool/pull/49.patch","issue_url":"https://api.github.com/repos/ipmitool/ipmitool/issues/49","number":49,"state":"open","locked":false,"title":"Cleanup compiler warnings","user":{"login":"vmauery","id":41592,"node_id":"MDQ6VXNlcjQxNTky","avatar_url":"https://avatars3.githubusercontent.com/u/41592?v=4","gravatar_id":"","url":"https://api.github.com/users/vmauery","html_url":"https://github.com/vmauery","followers_url":"https://api.github.com/users/vmauery/followers","following_url":"https://api.github.com/users/vmauery/following{/other_user}","gists_url":"https://api.github.com/users/vmauery/gists{/gist_id}","starred_url":"https://api.github.com/users/vmauery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmauery/subscriptions","organizations_url":"https://api.github.com/users/vmauery/orgs","repos_url":"https://api.github.com/users/vmauery/repos","events_url":"https://api.github.com/users/vmauery/events{/privacy}","received_events_url":"https://api.github.com/users/vmauery/received_events","type":"User","site_admin":false},"body":"I really don't like seeing so many compiler warnings when ipmitool builds. This is the first round of removing a few of them.","created_at":"2018-11-05T22:35:41Z","updated_at":"2018-11-06T16:58:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a53ac9629539771e21bf53a87839325f5860a1b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ipmitool/ipmitool/pulls/49/commits","review_comments_url":"https://api.github.com/repos/ipmitool/ipmitool/pulls/49/comments","review_comment_url":"https://api.github.com/repos/ipmitool/ipmitool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipmitool/ipmitool/issues/49/comments","statuses_url":"https://api.github.com/repos/ipmitool/ipmitool/statuses/6eef07cdb23ff8c92ffb2bdfea456e9a64fc9a1f","head":{"label":"vmauery:cleanup-1","ref":"cleanup-1","sha":"6eef07cdb23ff8c92ffb2bdfea456e9a64fc9a1f","user":{"login":"vmauery","id":41592,"node_id":"MDQ6VXNlcjQxNTky","avatar_url":"https://avatars3.githubusercontent.com/u/41592?v=4","gravatar_id":"","url":"https://api.github.com/users/vmauery","html_url":"https://github.com/vmauery","followers_url":"https://api.github.com/users/vmauery/followers","following_url":"https://api.github.com/users/vmauery/following{/other_user}","gists_url":"https://api.github.com/users/vmauery/gists{/gist_id}","starred_url":"https://api.github.com/users/vmauery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmauery/subscriptions","organizations_url":"https://api.github.com/users/vmauery/orgs","repos_url":"https://api.github.com/users/vmauery/repos","events_url":"https://api.github.com/users/vmauery/events{/privacy}","received_events_url":"https://api.github.com/users/vmauery/received_events","type":"User","site_admin":false},"repo":{"id":128822955,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4MjI5NTU=","name":"ipmitool","full_name":"vmauery/ipmitool","private":false,"owner":{"login":"vmauery","id":41592,"node_id":"MDQ6VXNlcjQxNTky","avatar_url":"https://avatars3.githubusercontent.com/u/41592?v=4","gravatar_id":"","url":"https://api.github.com/users/vmauery","html_url":"https://github.com/vmauery","followers_url":"https://api.github.com/users/vmauery/followers","following_url":"https://api.github.com/users/vmauery/following{/other_user}","gists_url":"https://api.github.com/users/vmauery/gists{/gist_id}","starred_url":"https://api.github.com/users/vmauery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmauery/subscriptions","organizations_url":"https://api.github.com/users/vmauery/orgs","repos_url":"https://api.github.com/users/vmauery/repos","events_url":"https://api.github.com/users/vmauery/events{/privacy}","received_events_url":"https://api.github.com/users/vmauery/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vmauery/ipmitool","description":null,"fork":true,"url":"https://api.github.com/repos/vmauery/ipmitool","forks_url":"https://api.github.com/repos/vmauery/ipmitool/forks","keys_url":"https://api.github.com/repos/vmauery/ipmitool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmauery/ipmitool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmauery/ipmitool/teams","hooks_url":"https://api.github.com/repos/vmauery/ipmitool/hooks","issue_events_url":"https://api.github.com/repos/vmauery/ipmitool/issues/events{/number}","events_url":"https://api.github.com/repos/vmauery/ipmitool/events","assignees_url":"https://api.github.com/repos/vmauery/ipmitool/assignees{/user}","branches_url":"https://api.github.com/repos/vmauery/ipmitool/branches{/branch}","tags_url":"https://api.github.com/repos/vmauery/ipmitool/tags","blobs_url":"https://api.github.com/repos/vmauery/ipmitool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmauery/ipmitool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmauery/ipmitool/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmauery/ipmitool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmauery/ipmitool/statuses/{sha}","languages_url":"https://api.github.com/repos/vmauery/ipmitool/languages","stargazers_url":"https://api.github.com/repos/vmauery/ipmitool/stargazers","contributors_url":"https://api.github.com/repos/vmauery/ipmitool/contributors","subscribers_url":"https://api.github.com/repos/vmauery/ipmitool/subscribers","subscription_url":"https://api.github.com/repos/vmauery/ipmitool/subscription","commits_url":"https://api.github.com/repos/vmauery/ipmitool/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmauery/ipmitool/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmauery/ipmitool/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmauery/ipmitool/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmauery/ipmitool/contents/{+path}","compare_url":"https://api.github.com/repos/vmauery/ipmitool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmauery/ipmitool/merges","archive_url":"https://api.github.com/repos/vmauery/ipmitool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmauery/ipmitool/downloads","issues_url":"https://api.github.com/repos/vmauery/ipmitool/issues{/number}","pulls_url":"https://api.github.com/repos/vmauery/ipmitool/pulls{/number}","milestones_url":"https://api.github.com/repos/vmauery/ipmitool/milestones{/number}","notifications_url":"https://api.github.com/repos/vmauery/ipmitool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmauery/ipmitool/labels{/name}","releases_url":"https://api.github.com/repos/vmauery/ipmitool/releases{/id}","deployments_url":"https://api.github.com/repos/vmauery/ipmitool/deployments","created_at":"2018-04-09T19:25:46Z","updated_at":"2018-08-13T20:27:30Z","pushed_at":"2018-11-05T22:31:18Z","git_url":"git://github.com/vmauery/ipmitool.git","ssh_url":"git@github.com:vmauery/ipmitool.git","clone_url":"https://github.com/vmauery/ipmitool.git","svn_url":"https://github.com/vmauery/ipmitool","homepage":null,"size":2479,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ipmitool:master","ref":"master","sha":"65a2c548d8b78833ca7aa1fa383272c8ab8466e8","user":{"login":"ipmitool","id":38139577,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTM5NTc3","avatar_url":"https://avatars2.githubusercontent.com/u/38139577?v=4","gravatar_id":"","url":"https://api.github.com/users/ipmitool","html_url":"https://github.com/ipmitool","followers_url":"https://api.github.com/users/ipmitool/followers","following_url":"https://api.github.com/users/ipmitool/following{/other_user}","gists_url":"https://api.github.com/users/ipmitool/gists{/gist_id}","starred_url":"https://api.github.com/users/ipmitool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipmitool/subscriptions","organizations_url":"https://api.github.com/users/ipmitool/orgs","repos_url":"https://api.github.com/users/ipmitool/repos","events_url":"https://api.github.com/users/ipmitool/events{/privacy}","received_events_url":"https://api.github.com/users/ipmitool/received_events","type":"Organization","site_admin":false},"repo":{"id":128686483,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2ODY0ODM=","name":"ipmitool","full_name":"ipmitool/ipmitool","private":false,"owner":{"login":"ipmitool","id":38139577,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTM5NTc3","avatar_url":"https://avatars2.githubusercontent.com/u/38139577?v=4","gravatar_id":"","url":"https://api.github.com/users/ipmitool","html_url":"https://github.com/ipmitool","followers_url":"https://api.github.com/users/ipmitool/followers","following_url":"https://api.github.com/users/ipmitool/following{/other_user}","gists_url":"https://api.github.com/users/ipmitool/gists{/gist_id}","starred_url":"https://api.github.com/users/ipmitool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipmitool/subscriptions","organizations_url":"https://api.github.com/users/ipmitool/orgs","repos_url":"https://api.github.com/users/ipmitool/repos","events_url":"https://api.github.com/users/ipmitool/events{/privacy}","received_events_url":"https://api.github.com/users/ipmitool/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipmitool/ipmitool","description":"An open-source tool for controlling IPMI-enabled systems","fork":false,"url":"https://api.github.com/repos/ipmitool/ipmitool","forks_url":"https://api.github.com/repos/ipmitool/ipmitool/forks","keys_url":"https://api.github.com/repos/ipmitool/ipmitool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipmitool/ipmitool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipmitool/ipmitool/teams","hooks_url":"https://api.github.com/repos/ipmitool/ipmitool/hooks","issue_events_url":"https://api.github.com/repos/ipmitool/ipmitool/issues/events{/number}","events_url":"https://api.github.com/repos/ipmitool/ipmitool/events","assignees_url":"https://api.github.com/repos/ipmitool/ipmitool/assignees{/user}","branches_url":"https://api.github.com/repos/ipmitool/ipmitool/branches{/branch}","tags_url":"https://api.github.com/repos/ipmitool/ipmitool/tags","blobs_url":"https://api.github.com/repos/ipmitool/ipmitool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipmitool/ipmitool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipmitool/ipmitool/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipmitool/ipmitool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipmitool/ipmitool/statuses/{sha}","languages_url":"https://api.github.com/repos/ipmitool/ipmitool/languages","stargazers_url":"https://api.github.com/repos/ipmitool/ipmitool/stargazers","contributors_url":"https://api.github.com/repos/ipmitool/ipmitool/contributors","subscribers_url":"https://api.github.com/repos/ipmitool/ipmitool/subscribers","subscription_url":"https://api.github.com/repos/ipmitool/ipmitool/subscription","commits_url":"https://api.github.com/repos/ipmitool/ipmitool/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipmitool/ipmitool/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipmitool/ipmitool/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipmitool/ipmitool/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipmitool/ipmitool/contents/{+path}","compare_url":"https://api.github.com/repos/ipmitool/ipmitool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipmitool/ipmitool/merges","archive_url":"https://api.github.com/repos/ipmitool/ipmitool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipmitool/ipmitool/downloads","issues_url":"https://api.github.com/repos/ipmitool/ipmitool/issues{/number}","pulls_url":"https://api.github.com/repos/ipmitool/ipmitool/pulls{/number}","milestones_url":"https://api.github.com/repos/ipmitool/ipmitool/milestones{/number}","notifications_url":"https://api.github.com/repos/ipmitool/ipmitool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipmitool/ipmitool/labels{/name}","releases_url":"https://api.github.com/repos/ipmitool/ipmitool/releases{/id}","deployments_url":"https://api.github.com/repos/ipmitool/ipmitool/deployments","created_at":"2018-04-08T22:18:30Z","updated_at":"2018-11-06T14:27:15Z","pushed_at":"2018-11-06T14:27:12Z","git_url":"git://github.com/ipmitool/ipmitool.git","ssh_url":"git@github.com:ipmitool/ipmitool.git","clone_url":"https://github.com/ipmitool/ipmitool.git","svn_url":"https://github.com/ipmitool/ipmitool","homepage":"","size":2463,"stargazers_count":74,"watchers_count":74,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":20,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipmitool/ipmitool/pulls/49"},"html":{"href":"https://github.com/ipmitool/ipmitool/pull/49"},"issue":{"href":"https://api.github.com/repos/ipmitool/ipmitool/issues/49"},"comments":{"href":"https://api.github.com/repos/ipmitool/ipmitool/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/ipmitool/ipmitool/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/ipmitool/ipmitool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipmitool/ipmitool/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/ipmitool/ipmitool/statuses/6eef07cdb23ff8c92ffb2bdfea456e9a64fc9a1f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlexanderAmelkin"}}