{"action":"closed","number":3942,"pull_request":{"url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3942","id":215124234,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTI0MjM0","html_url":"https://github.com/endless-sky/endless-sky/pull/3942","diff_url":"https://github.com/endless-sky/endless-sky/pull/3942.diff","patch_url":"https://github.com/endless-sky/endless-sky/pull/3942.patch","issue_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/3942","number":3942,"state":"closed","locked":false,"title":"remove extra call to glUniform1i in Font.cpp","user":{"login":"comnom","id":22107649,"node_id":"MDQ6VXNlcjIyMTA3NjQ5","avatar_url":"https://avatars0.githubusercontent.com/u/22107649?v=4","gravatar_id":"","url":"https://api.github.com/users/comnom","html_url":"https://github.com/comnom","followers_url":"https://api.github.com/users/comnom/followers","following_url":"https://api.github.com/users/comnom/following{/other_user}","gists_url":"https://api.github.com/users/comnom/gists{/gist_id}","starred_url":"https://api.github.com/users/comnom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comnom/subscriptions","organizations_url":"https://api.github.com/users/comnom/orgs","repos_url":"https://api.github.com/users/comnom/repos","events_url":"https://api.github.com/users/comnom/events{/privacy}","received_events_url":"https://api.github.com/users/comnom/received_events","type":"User","site_admin":false},"body":"https://github.com/endless-sky/endless-sky/commit/406c34e2baf6f88246d45a7ac70b8751c2c9092e#diff-38b37fd2bcdee403e42b45bbde753a3e moved the call to `glUniform1i(shader.Uniform(\"tex\"), 0);` in `Font::SetUpShader()` up top without removing the old one. \r\n\r\nThe second call logs `glUniform1i has failed because the operation requires a currently active program object (GL_INVALID_OPERATION)` if gl context debugging is enabled.","created_at":"2018-09-12T23:27:57Z","updated_at":"2018-09-14T15:07:40Z","closed_at":"2018-09-14T15:07:40Z","merged_at":"2018-09-14T15:07:40Z","merge_commit_sha":"726cd23dc638b888ec25acded1288cb2e45eb09d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3942/commits","review_comments_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3942/comments","review_comment_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/3942/comments","statuses_url":"https://api.github.com/repos/endless-sky/endless-sky/statuses/61d927da22c55d932f83ad9701804dd8abd2a898","head":{"label":"comnom:remove-call","ref":"remove-call","sha":"61d927da22c55d932f83ad9701804dd8abd2a898","user":{"login":"comnom","id":22107649,"node_id":"MDQ6VXNlcjIyMTA3NjQ5","avatar_url":"https://avatars0.githubusercontent.com/u/22107649?v=4","gravatar_id":"","url":"https://api.github.com/users/comnom","html_url":"https://github.com/comnom","followers_url":"https://api.github.com/users/comnom/followers","following_url":"https://api.github.com/users/comnom/following{/other_user}","gists_url":"https://api.github.com/users/comnom/gists{/gist_id}","starred_url":"https://api.github.com/users/comnom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comnom/subscriptions","organizations_url":"https://api.github.com/users/comnom/orgs","repos_url":"https://api.github.com/users/comnom/repos","events_url":"https://api.github.com/users/comnom/events{/privacy}","received_events_url":"https://api.github.com/users/comnom/received_events","type":"User","site_admin":false},"repo":{"id":92963878,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjk2Mzg3OA==","name":"endless-sky","full_name":"comnom/endless-sky","owner":{"login":"comnom","id":22107649,"node_id":"MDQ6VXNlcjIyMTA3NjQ5","avatar_url":"https://avatars0.githubusercontent.com/u/22107649?v=4","gravatar_id":"","url":"https://api.github.com/users/comnom","html_url":"https://github.com/comnom","followers_url":"https://api.github.com/users/comnom/followers","following_url":"https://api.github.com/users/comnom/following{/other_user}","gists_url":"https://api.github.com/users/comnom/gists{/gist_id}","starred_url":"https://api.github.com/users/comnom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comnom/subscriptions","organizations_url":"https://api.github.com/users/comnom/orgs","repos_url":"https://api.github.com/users/comnom/repos","events_url":"https://api.github.com/users/comnom/events{/privacy}","received_events_url":"https://api.github.com/users/comnom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/comnom/endless-sky","description":"Space exploration, trading, and combat game.","fork":true,"url":"https://api.github.com/repos/comnom/endless-sky","forks_url":"https://api.github.com/repos/comnom/endless-sky/forks","keys_url":"https://api.github.com/repos/comnom/endless-sky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/comnom/endless-sky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/comnom/endless-sky/teams","hooks_url":"https://api.github.com/repos/comnom/endless-sky/hooks","issue_events_url":"https://api.github.com/repos/comnom/endless-sky/issues/events{/number}","events_url":"https://api.github.com/repos/comnom/endless-sky/events","assignees_url":"https://api.github.com/repos/comnom/endless-sky/assignees{/user}","branches_url":"https://api.github.com/repos/comnom/endless-sky/branches{/branch}","tags_url":"https://api.github.com/repos/comnom/endless-sky/tags","blobs_url":"https://api.github.com/repos/comnom/endless-sky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/comnom/endless-sky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/comnom/endless-sky/git/refs{/sha}","trees_url":"https://api.github.com/repos/comnom/endless-sky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/comnom/endless-sky/statuses/{sha}","languages_url":"https://api.github.com/repos/comnom/endless-sky/languages","stargazers_url":"https://api.github.com/repos/comnom/endless-sky/stargazers","contributors_url":"https://api.github.com/repos/comnom/endless-sky/contributors","subscribers_url":"https://api.github.com/repos/comnom/endless-sky/subscribers","subscription_url":"https://api.github.com/repos/comnom/endless-sky/subscription","commits_url":"https://api.github.com/repos/comnom/endless-sky/commits{/sha}","git_commits_url":"https://api.github.com/repos/comnom/endless-sky/git/commits{/sha}","comments_url":"https://api.github.com/repos/comnom/endless-sky/comments{/number}","issue_comment_url":"https://api.github.com/repos/comnom/endless-sky/issues/comments{/number}","contents_url":"https://api.github.com/repos/comnom/endless-sky/contents/{+path}","compare_url":"https://api.github.com/repos/comnom/endless-sky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/comnom/endless-sky/merges","archive_url":"https://api.github.com/repos/comnom/endless-sky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/comnom/endless-sky/downloads","issues_url":"https://api.github.com/repos/comnom/endless-sky/issues{/number}","pulls_url":"https://api.github.com/repos/comnom/endless-sky/pulls{/number}","milestones_url":"https://api.github.com/repos/comnom/endless-sky/milestones{/number}","notifications_url":"https://api.github.com/repos/comnom/endless-sky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/comnom/endless-sky/labels{/name}","releases_url":"https://api.github.com/repos/comnom/endless-sky/releases{/id}","deployments_url":"https://api.github.com/repos/comnom/endless-sky/deployments","created_at":"2017-05-31T16:00:30Z","updated_at":"2018-09-09T13:53:44Z","pushed_at":"2018-09-12T23:24:57Z","git_url":"git://github.com/comnom/endless-sky.git","ssh_url":"git@github.com:comnom/endless-sky.git","clone_url":"https://github.com/comnom/endless-sky.git","svn_url":"https://github.com/comnom/endless-sky","homepage":"http://endless-sky.github.io/","size":158890,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"endless-sky:master","ref":"master","sha":"d92b6676e3cb81429b59f248abb6ef04659edfe1","user":{"login":"endless-sky","id":11450262,"node_id":"MDQ6VXNlcjExNDUwMjYy","avatar_url":"https://avatars2.githubusercontent.com/u/11450262?v=4","gravatar_id":"","url":"https://api.github.com/users/endless-sky","html_url":"https://github.com/endless-sky","followers_url":"https://api.github.com/users/endless-sky/followers","following_url":"https://api.github.com/users/endless-sky/following{/other_user}","gists_url":"https://api.github.com/users/endless-sky/gists{/gist_id}","starred_url":"https://api.github.com/users/endless-sky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endless-sky/subscriptions","organizations_url":"https://api.github.com/users/endless-sky/orgs","repos_url":"https://api.github.com/users/endless-sky/repos","events_url":"https://api.github.com/users/endless-sky/events{/privacy}","received_events_url":"https://api.github.com/users/endless-sky/received_events","type":"User","site_admin":false},"repo":{"id":32231207,"node_id":"MDEwOlJlcG9zaXRvcnkzMjIzMTIwNw==","name":"endless-sky","full_name":"endless-sky/endless-sky","owner":{"login":"endless-sky","id":11450262,"node_id":"MDQ6VXNlcjExNDUwMjYy","avatar_url":"https://avatars2.githubusercontent.com/u/11450262?v=4","gravatar_id":"","url":"https://api.github.com/users/endless-sky","html_url":"https://github.com/endless-sky","followers_url":"https://api.github.com/users/endless-sky/followers","following_url":"https://api.github.com/users/endless-sky/following{/other_user}","gists_url":"https://api.github.com/users/endless-sky/gists{/gist_id}","starred_url":"https://api.github.com/users/endless-sky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endless-sky/subscriptions","organizations_url":"https://api.github.com/users/endless-sky/orgs","repos_url":"https://api.github.com/users/endless-sky/repos","events_url":"https://api.github.com/users/endless-sky/events{/privacy}","received_events_url":"https://api.github.com/users/endless-sky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endless-sky/endless-sky","description":"Space exploration, trading, and combat game.","fork":false,"url":"https://api.github.com/repos/endless-sky/endless-sky","forks_url":"https://api.github.com/repos/endless-sky/endless-sky/forks","keys_url":"https://api.github.com/repos/endless-sky/endless-sky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endless-sky/endless-sky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endless-sky/endless-sky/teams","hooks_url":"https://api.github.com/repos/endless-sky/endless-sky/hooks","issue_events_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/events{/number}","events_url":"https://api.github.com/repos/endless-sky/endless-sky/events","assignees_url":"https://api.github.com/repos/endless-sky/endless-sky/assignees{/user}","branches_url":"https://api.github.com/repos/endless-sky/endless-sky/branches{/branch}","tags_url":"https://api.github.com/repos/endless-sky/endless-sky/tags","blobs_url":"https://api.github.com/repos/endless-sky/endless-sky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endless-sky/endless-sky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endless-sky/endless-sky/git/refs{/sha}","trees_url":"https://api.github.com/repos/endless-sky/endless-sky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endless-sky/endless-sky/statuses/{sha}","languages_url":"https://api.github.com/repos/endless-sky/endless-sky/languages","stargazers_url":"https://api.github.com/repos/endless-sky/endless-sky/stargazers","contributors_url":"https://api.github.com/repos/endless-sky/endless-sky/contributors","subscribers_url":"https://api.github.com/repos/endless-sky/endless-sky/subscribers","subscription_url":"https://api.github.com/repos/endless-sky/endless-sky/subscription","commits_url":"https://api.github.com/repos/endless-sky/endless-sky/commits{/sha}","git_commits_url":"https://api.github.com/repos/endless-sky/endless-sky/git/commits{/sha}","comments_url":"https://api.github.com/repos/endless-sky/endless-sky/comments{/number}","issue_comment_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/comments{/number}","contents_url":"https://api.github.com/repos/endless-sky/endless-sky/contents/{+path}","compare_url":"https://api.github.com/repos/endless-sky/endless-sky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endless-sky/endless-sky/merges","archive_url":"https://api.github.com/repos/endless-sky/endless-sky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endless-sky/endless-sky/downloads","issues_url":"https://api.github.com/repos/endless-sky/endless-sky/issues{/number}","pulls_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls{/number}","milestones_url":"https://api.github.com/repos/endless-sky/endless-sky/milestones{/number}","notifications_url":"https://api.github.com/repos/endless-sky/endless-sky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endless-sky/endless-sky/labels{/name}","releases_url":"https://api.github.com/repos/endless-sky/endless-sky/releases{/id}","deployments_url":"https://api.github.com/repos/endless-sky/endless-sky/deployments","created_at":"2015-03-14T20:44:39Z","updated_at":"2018-09-13T09:56:07Z","pushed_at":"2018-09-14T15:07:39Z","git_url":"git://github.com/endless-sky/endless-sky.git","ssh_url":"git@github.com:endless-sky/endless-sky.git","clone_url":"https://github.com/endless-sky/endless-sky.git","svn_url":"https://github.com/endless-sky/endless-sky","homepage":"http://endless-sky.github.io/","size":160152,"stargazers_count":1541,"watchers_count":1541,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":410,"mirror_url":null,"archived":false,"open_issues_count":533,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":410,"open_issues":533,"watchers":1541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3942"},"html":{"href":"https://github.com/endless-sky/endless-sky/pull/3942"},"issue":{"href":"https://api.github.com/repos/endless-sky/endless-sky/issues/3942"},"comments":{"href":"https://api.github.com/repos/endless-sky/endless-sky/issues/3942/comments"},"review_comments":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3942/comments"},"review_comment":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/3942/commits"},"statuses":{"href":"https://api.github.com/repos/endless-sky/endless-sky/statuses/61d927da22c55d932f83ad9701804dd8abd2a898"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"endless-sky","id":11450262,"node_id":"MDQ6VXNlcjExNDUwMjYy","avatar_url":"https://avatars2.githubusercontent.com/u/11450262?v=4","gravatar_id":"","url":"https://api.github.com/users/endless-sky","html_url":"https://github.com/endless-sky","followers_url":"https://api.github.com/users/endless-sky/followers","following_url":"https://api.github.com/users/endless-sky/following{/other_user}","gists_url":"https://api.github.com/users/endless-sky/gists{/gist_id}","starred_url":"https://api.github.com/users/endless-sky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endless-sky/subscriptions","organizations_url":"https://api.github.com/users/endless-sky/orgs","repos_url":"https://api.github.com/users/endless-sky/repos","events_url":"https://api.github.com/users/endless-sky/events{/privacy}","received_events_url":"https://api.github.com/users/endless-sky/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"endless-sky"}}