{"action":"created","issue":{"url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1708","repository_url":"https://api.github.com/repos/rhinstaller/anaconda","labels_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1708/labels{/name}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1708/comments","events_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1708/events","html_url":"https://github.com/rhinstaller/anaconda/pull/1708","id":385745316,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjQ0NjMw","number":1708,"title":"Disable BLS config if new-kernel-pkg is installed","user":{"login":"martinezjavier","id":498974,"node_id":"MDQ6VXNlcjQ5ODk3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/498974?v=4","gravatar_id":"","url":"https://api.github.com/users/martinezjavier","html_url":"https://github.com/martinezjavier","followers_url":"https://api.github.com/users/martinezjavier/followers","following_url":"https://api.github.com/users/martinezjavier/following{/other_user}","gists_url":"https://api.github.com/users/martinezjavier/gists{/gist_id}","starred_url":"https://api.github.com/users/martinezjavier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinezjavier/subscriptions","organizations_url":"https://api.github.com/users/martinezjavier/orgs","repos_url":"https://api.github.com/users/martinezjavier/repos","events_url":"https://api.github.com/users/martinezjavier/events{/privacy}","received_events_url":"https://api.github.com/users/martinezjavier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-11-29T13:50:02Z","updated_at":"2018-12-03T10:06:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/1708","html_url":"https://github.com/rhinstaller/anaconda/pull/1708","diff_url":"https://github.com/rhinstaller/anaconda/pull/1708.diff","patch_url":"https://github.com/rhinstaller/anaconda/pull/1708.patch"},"body":"The kernel-install scripts installs kernels and adds BLS snippets in the\r\n/boot/loader/entries directory if new-kernel-pkg isn't present or a BLS\r\nsetup was explicility configured (i.e: setting GRUB_ENABLE_BLSCFG=true).\r\n\r\nBut the kernel package is installed before writing any bootloader config,\r\nso the kernel-install script only rely on the existence of new-kernel-pkg\r\nto choose if a BLS or non-BLS kernel installation will be made.\r\n\r\nSo if new-kernel-pkg is present and the inst.noblscfg boot option wasn't\r\nused, then kernels will be installed without a BLS snippet but bootloader\r\nconfig will expect them, leading to an unbootable installed system.\r\n\r\nResolves: rhbz#1654036\r\n\r\nSigned-off-by: Javier Martinez Canillas <javierm@redhat.com>"},"comment":{"url":"https://api.github.com/repos/rhinstaller/anaconda/issues/comments/443654888","html_url":"https://github.com/rhinstaller/anaconda/pull/1708#issuecomment-443654888","issue_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1708","id":443654888,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzY1NDg4OA==","user":{"login":"martinezjavier","id":498974,"node_id":"MDQ6VXNlcjQ5ODk3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/498974?v=4","gravatar_id":"","url":"https://api.github.com/users/martinezjavier","html_url":"https://github.com/martinezjavier","followers_url":"https://api.github.com/users/martinezjavier/followers","following_url":"https://api.github.com/users/martinezjavier/following{/other_user}","gists_url":"https://api.github.com/users/martinezjavier/gists{/gist_id}","starred_url":"https://api.github.com/users/martinezjavier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinezjavier/subscriptions","organizations_url":"https://api.github.com/users/martinezjavier/orgs","repos_url":"https://api.github.com/users/martinezjavier/repos","events_url":"https://api.github.com/users/martinezjavier/events{/privacy}","received_events_url":"https://api.github.com/users/martinezjavier/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T10:06:02Z","updated_at":"2018-12-03T10:06:02Z","author_association":"CONTRIBUTOR","body":"> In fact...do we really want/need it? Who requested that it be added, and do they still want it? Can we maybe get rid of it now?\r\n\r\nI don't remember now who asked for it, but it was part of the contingency plan in the [Changes page](https://fedoraproject.org/wiki/Changes/BootLoaderSpecByDefault) and also to allow users to do a non-BLS installation if they didn't want to use BLS."}}
{"actor":{"display_login":"martinezjavier"}}