{"action":"created","comment":{"url":"https://api.github.com/repos/hqucms/NanoHRT/pulls/comments/217825876","pull_request_review_id":155640550,"id":217825876,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzgyNTg3Ng==","diff_hunk":"@@ -482,7 +496,7 @@ void BoostedEventShapeTagger::getJetValues( const pat::Jet& jet ){\n     m_BESTvars[\"et\"]      = thisJet.Pt();\n     m_BESTvars[\"eta\"]     = thisJet.Rapidity();\n     m_BESTvars[\"mass\"]    = thisJet.M();\n-    m_BESTvars[\"SDmass\"]  = jet.userFloat(\"ak8PFJetsPuppiSoftDropMass\");\n+    m_BESTvars[\"SDmass\"]  = jet.mass();","path":"src/BoostedEventShapeTagger.cc","position":null,"original_position":105,"commit_id":"ec8a39f320a7e9c23cd31e3c5fdf71b3000673d6","original_commit_id":"0db684c7fb6a90ccd141b6adc25c3b25f74dfc9b","user":{"login":"hqucms","id":7973717,"node_id":"MDQ6VXNlcjc5NzM3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7973717?v=4","gravatar_id":"","url":"https://api.github.com/users/hqucms","html_url":"https://github.com/hqucms","followers_url":"https://api.github.com/users/hqucms/followers","following_url":"https://api.github.com/users/hqucms/following{/other_user}","gists_url":"https://api.github.com/users/hqucms/gists{/gist_id}","starred_url":"https://api.github.com/users/hqucms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqucms/subscriptions","organizations_url":"https://api.github.com/users/hqucms/orgs","repos_url":"https://api.github.com/users/hqucms/repos","events_url":"https://api.github.com/users/hqucms/events{/privacy}","received_events_url":"https://api.github.com/users/hqucms/received_events","type":"User","site_admin":false},"body":"@justinrpilot \r\n\r\nI think if you use `float puppiSDmass = (puppi_subjet0+puppi_subjet1).M();` for the training, then the most consistent one would be `jet.groomedMass()` [0] which are also computed from the subjets (`ak8PFJetsPuppiSoftDropMass` is computed from subjets before applying the JEC though).\r\n\r\n[0] https://github.com/cms-sw/cmssw/blob/master/DataFormats/PatCandidates/interface/Jet.h#L527","created_at":"2018-09-14T19:56:40Z","updated_at":"2018-09-14T19:56:41Z","html_url":"https://github.com/hqucms/NanoHRT/pull/2#discussion_r217825876","pull_request_url":"https://api.github.com/repos/hqucms/NanoHRT/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/hqucms/NanoHRT/pulls/comments/217825876"},"html":{"href":"https://github.com/hqucms/NanoHRT/pull/2#discussion_r217825876"},"pull_request":{"href":"https://api.github.com/repos/hqucms/NanoHRT/pulls/2"}},"in_reply_to_id":217812634},"pull_request":{"url":"https://api.github.com/repos/hqucms/NanoHRT/pulls/2","id":215680251,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjgwMjUx","html_url":"https://github.com/hqucms/NanoHRT/pull/2","diff_url":"https://github.com/hqucms/NanoHRT/pull/2.diff","patch_url":"https://github.com/hqucms/NanoHRT/pull/2.patch","issue_url":"https://api.github.com/repos/hqucms/NanoHRT/issues/2","number":2,"state":"closed","locked":false,"title":"Updated to BEST+PUPPI","user":{"login":"justinrpilot","id":4748043,"node_id":"MDQ6VXNlcjQ3NDgwNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4748043?v=4","gravatar_id":"","url":"https://api.github.com/users/justinrpilot","html_url":"https://github.com/justinrpilot","followers_url":"https://api.github.com/users/justinrpilot/followers","following_url":"https://api.github.com/users/justinrpilot/following{/other_user}","gists_url":"https://api.github.com/users/justinrpilot/gists{/gist_id}","starred_url":"https://api.github.com/users/justinrpilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinrpilot/subscriptions","organizations_url":"https://api.github.com/users/justinrpilot/orgs","repos_url":"https://api.github.com/users/justinrpilot/repos","events_url":"https://api.github.com/users/justinrpilot/events{/privacy}","received_events_url":"https://api.github.com/users/justinrpilot/received_events","type":"User","site_admin":false},"body":"I updated the code to include the new 6-category BEST NN which is trained on PUPPI jets.  Several path names changed to point to the new JSON file in data/BEST/.  Also a few changes to the BoostedEventShapeTagger.cc to fix how the jet constituents are used.","created_at":"2018-09-14T18:48:18Z","updated_at":"2018-09-14T19:56:41Z","closed_at":"2018-09-14T19:45:02Z","merged_at":null,"merge_commit_sha":"60033779a1e08f350e68eb41480421112b09d21d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hqucms/NanoHRT/pulls/2/commits","review_comments_url":"https://api.github.com/repos/hqucms/NanoHRT/pulls/2/comments","review_comment_url":"https://api.github.com/repos/hqucms/NanoHRT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hqucms/NanoHRT/issues/2/comments","statuses_url":"https://api.github.com/repos/hqucms/NanoHRT/statuses/ec8a39f320a7e9c23cd31e3c5fdf71b3000673d6","head":{"label":"justinrpilot:master","ref":"master","sha":"ec8a39f320a7e9c23cd31e3c5fdf71b3000673d6","user":{"login":"justinrpilot","id":4748043,"node_id":"MDQ6VXNlcjQ3NDgwNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4748043?v=4","gravatar_id":"","url":"https://api.github.com/users/justinrpilot","html_url":"https://github.com/justinrpilot","followers_url":"https://api.github.com/users/justinrpilot/followers","following_url":"https://api.github.com/users/justinrpilot/following{/other_user}","gists_url":"https://api.github.com/users/justinrpilot/gists{/gist_id}","starred_url":"https://api.github.com/users/justinrpilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinrpilot/subscriptions","organizations_url":"https://api.github.com/users/justinrpilot/orgs","repos_url":"https://api.github.com/users/justinrpilot/repos","events_url":"https://api.github.com/users/justinrpilot/events{/privacy}","received_events_url":"https://api.github.com/users/justinrpilot/received_events","type":"User","site_admin":false},"repo":{"id":147867061,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4NjcwNjE=","name":"NanoHRT","full_name":"justinrpilot/NanoHRT","owner":{"login":"justinrpilot","id":4748043,"node_id":"MDQ6VXNlcjQ3NDgwNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4748043?v=4","gravatar_id":"","url":"https://api.github.com/users/justinrpilot","html_url":"https://github.com/justinrpilot","followers_url":"https://api.github.com/users/justinrpilot/followers","following_url":"https://api.github.com/users/justinrpilot/following{/other_user}","gists_url":"https://api.github.com/users/justinrpilot/gists{/gist_id}","starred_url":"https://api.github.com/users/justinrpilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinrpilot/subscriptions","organizations_url":"https://api.github.com/users/justinrpilot/orgs","repos_url":"https://api.github.com/users/justinrpilot/repos","events_url":"https://api.github.com/users/justinrpilot/events{/privacy}","received_events_url":"https://api.github.com/users/justinrpilot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinrpilot/NanoHRT","description":null,"fork":true,"url":"https://api.github.com/repos/justinrpilot/NanoHRT","forks_url":"https://api.github.com/repos/justinrpilot/NanoHRT/forks","keys_url":"https://api.github.com/repos/justinrpilot/NanoHRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinrpilot/NanoHRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinrpilot/NanoHRT/teams","hooks_url":"https://api.github.com/repos/justinrpilot/NanoHRT/hooks","issue_events_url":"https://api.github.com/repos/justinrpilot/NanoHRT/issues/events{/number}","events_url":"https://api.github.com/repos/justinrpilot/NanoHRT/events","assignees_url":"https://api.github.com/repos/justinrpilot/NanoHRT/assignees{/user}","branches_url":"https://api.github.com/repos/justinrpilot/NanoHRT/branches{/branch}","tags_url":"https://api.github.com/repos/justinrpilot/NanoHRT/tags","blobs_url":"https://api.github.com/repos/justinrpilot/NanoHRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinrpilot/NanoHRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinrpilot/NanoHRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinrpilot/NanoHRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinrpilot/NanoHRT/statuses/{sha}","languages_url":"https://api.github.com/repos/justinrpilot/NanoHRT/languages","stargazers_url":"https://api.github.com/repos/justinrpilot/NanoHRT/stargazers","contributors_url":"https://api.github.com/repos/justinrpilot/NanoHRT/contributors","subscribers_url":"https://api.github.com/repos/justinrpilot/NanoHRT/subscribers","subscription_url":"https://api.github.com/repos/justinrpilot/NanoHRT/subscription","commits_url":"https://api.github.com/repos/justinrpilot/NanoHRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinrpilot/NanoHRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinrpilot/NanoHRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinrpilot/NanoHRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinrpilot/NanoHRT/contents/{+path}","compare_url":"https://api.github.com/repos/justinrpilot/NanoHRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinrpilot/NanoHRT/merges","archive_url":"https://api.github.com/repos/justinrpilot/NanoHRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinrpilot/NanoHRT/downloads","issues_url":"https://api.github.com/repos/justinrpilot/NanoHRT/issues{/number}","pulls_url":"https://api.github.com/repos/justinrpilot/NanoHRT/pulls{/number}","milestones_url":"https://api.github.com/repos/justinrpilot/NanoHRT/milestones{/number}","notifications_url":"https://api.github.com/repos/justinrpilot/NanoHRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinrpilot/NanoHRT/labels{/name}","releases_url":"https://api.github.com/repos/justinrpilot/NanoHRT/releases{/id}","deployments_url":"https://api.github.com/repos/justinrpilot/NanoHRT/deployments","created_at":"2018-09-07T19:37:02Z","updated_at":"2018-09-14T19:42:35Z","pushed_at":"2018-09-14T19:42:33Z","git_url":"git://github.com/justinrpilot/NanoHRT.git","ssh_url":"git@github.com:justinrpilot/NanoHRT.git","clone_url":"https://github.com/justinrpilot/NanoHRT.git","svn_url":"https://github.com/justinrpilot/NanoHRT","homepage":null,"size":480,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hqucms:master","ref":"master","sha":"c9f1d9bfa19eb450a307e39128d2d93b2e4260fe","user":{"login":"hqucms","id":7973717,"node_id":"MDQ6VXNlcjc5NzM3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7973717?v=4","gravatar_id":"","url":"https://api.github.com/users/hqucms","html_url":"https://github.com/hqucms","followers_url":"https://api.github.com/users/hqucms/followers","following_url":"https://api.github.com/users/hqucms/following{/other_user}","gists_url":"https://api.github.com/users/hqucms/gists{/gist_id}","starred_url":"https://api.github.com/users/hqucms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqucms/subscriptions","organizations_url":"https://api.github.com/users/hqucms/orgs","repos_url":"https://api.github.com/users/hqucms/repos","events_url":"https://api.github.com/users/hqucms/events{/privacy}","received_events_url":"https://api.github.com/users/hqucms/received_events","type":"User","site_admin":false},"repo":{"id":145418222,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0MTgyMjI=","name":"NanoHRT","full_name":"hqucms/NanoHRT","owner":{"login":"hqucms","id":7973717,"node_id":"MDQ6VXNlcjc5NzM3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7973717?v=4","gravatar_id":"","url":"https://api.github.com/users/hqucms","html_url":"https://github.com/hqucms","followers_url":"https://api.github.com/users/hqucms/followers","following_url":"https://api.github.com/users/hqucms/following{/other_user}","gists_url":"https://api.github.com/users/hqucms/gists{/gist_id}","starred_url":"https://api.github.com/users/hqucms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqucms/subscriptions","organizations_url":"https://api.github.com/users/hqucms/orgs","repos_url":"https://api.github.com/users/hqucms/repos","events_url":"https://api.github.com/users/hqucms/events{/privacy}","received_events_url":"https://api.github.com/users/hqucms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hqucms/NanoHRT","description":null,"fork":false,"url":"https://api.github.com/repos/hqucms/NanoHRT","forks_url":"https://api.github.com/repos/hqucms/NanoHRT/forks","keys_url":"https://api.github.com/repos/hqucms/NanoHRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hqucms/NanoHRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hqucms/NanoHRT/teams","hooks_url":"https://api.github.com/repos/hqucms/NanoHRT/hooks","issue_events_url":"https://api.github.com/repos/hqucms/NanoHRT/issues/events{/number}","events_url":"https://api.github.com/repos/hqucms/NanoHRT/events","assignees_url":"https://api.github.com/repos/hqucms/NanoHRT/assignees{/user}","branches_url":"https://api.github.com/repos/hqucms/NanoHRT/branches{/branch}","tags_url":"https://api.github.com/repos/hqucms/NanoHRT/tags","blobs_url":"https://api.github.com/repos/hqucms/NanoHRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hqucms/NanoHRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hqucms/NanoHRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/hqucms/NanoHRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hqucms/NanoHRT/statuses/{sha}","languages_url":"https://api.github.com/repos/hqucms/NanoHRT/languages","stargazers_url":"https://api.github.com/repos/hqucms/NanoHRT/stargazers","contributors_url":"https://api.github.com/repos/hqucms/NanoHRT/contributors","subscribers_url":"https://api.github.com/repos/hqucms/NanoHRT/subscribers","subscription_url":"https://api.github.com/repos/hqucms/NanoHRT/subscription","commits_url":"https://api.github.com/repos/hqucms/NanoHRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/hqucms/NanoHRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/hqucms/NanoHRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/hqucms/NanoHRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/hqucms/NanoHRT/contents/{+path}","compare_url":"https://api.github.com/repos/hqucms/NanoHRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hqucms/NanoHRT/merges","archive_url":"https://api.github.com/repos/hqucms/NanoHRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hqucms/NanoHRT/downloads","issues_url":"https://api.github.com/repos/hqucms/NanoHRT/issues{/number}","pulls_url":"https://api.github.com/repos/hqucms/NanoHRT/pulls{/number}","milestones_url":"https://api.github.com/repos/hqucms/NanoHRT/milestones{/number}","notifications_url":"https://api.github.com/repos/hqucms/NanoHRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hqucms/NanoHRT/labels{/name}","releases_url":"https://api.github.com/repos/hqucms/NanoHRT/releases{/id}","deployments_url":"https://api.github.com/repos/hqucms/NanoHRT/deployments","created_at":"2018-08-20T13:01:14Z","updated_at":"2018-08-22T10:52:58Z","pushed_at":"2018-09-14T19:46:11Z","git_url":"git://github.com/hqucms/NanoHRT.git","ssh_url":"git@github.com:hqucms/NanoHRT.git","clone_url":"https://github.com/hqucms/NanoHRT.git","svn_url":"https://github.com/hqucms/NanoHRT","homepage":null,"size":408,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hqucms/NanoHRT/pulls/2"},"html":{"href":"https://github.com/hqucms/NanoHRT/pull/2"},"issue":{"href":"https://api.github.com/repos/hqucms/NanoHRT/issues/2"},"comments":{"href":"https://api.github.com/repos/hqucms/NanoHRT/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/hqucms/NanoHRT/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/hqucms/NanoHRT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hqucms/NanoHRT/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/hqucms/NanoHRT/statuses/ec8a39f320a7e9c23cd31e3c5fdf71b3000673d6"}},"author_association":"NONE"}}
{"actor":{"display_login":"hqucms"}}