{"action":"created","issue":{"url":"https://api.github.com/repos/prestodb/presto/issues/11685","repository_url":"https://api.github.com/repos/prestodb/presto","labels_url":"https://api.github.com/repos/prestodb/presto/issues/11685/labels{/name}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/11685/comments","events_url":"https://api.github.com/repos/prestodb/presto/issues/11685/events","html_url":"https://github.com/prestodb/presto/issues/11685","id":368649337,"node_id":"MDU6SXNzdWUzNjg2NDkzMzc=","number":11685,"title":"ConnectorAccessControl#checkCanCreateTable should accept properties of the to-be-created table","user":{"login":"findepi","id":144328,"node_id":"MDQ6VXNlcjE0NDMyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/144328?v=4","gravatar_id":"","url":"https://api.github.com/users/findepi","html_url":"https://github.com/findepi","followers_url":"https://api.github.com/users/findepi/followers","following_url":"https://api.github.com/users/findepi/following{/other_user}","gists_url":"https://api.github.com/users/findepi/gists{/gist_id}","starred_url":"https://api.github.com/users/findepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findepi/subscriptions","organizations_url":"https://api.github.com/users/findepi/orgs","repos_url":"https://api.github.com/users/findepi/repos","events_url":"https://api.github.com/users/findepi/events{/privacy}","received_events_url":"https://api.github.com/users/findepi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-10T12:49:33Z","updated_at":"2018-10-11T07:07:20Z","closed_at":"2018-10-11T07:07:20Z","author_association":"MEMBER","body":"For example, `hive.non-managed-table-creates-enabled` is implemented in `com.facebook.presto.hive.HiveMetadata#createTable` while this logic should probably belong more to `ConnectorAccessControl`"},"comment":{"url":"https://api.github.com/repos/prestodb/presto/issues/comments/428845008","html_url":"https://github.com/prestodb/presto/issues/11685#issuecomment-428845008","issue_url":"https://api.github.com/repos/prestodb/presto/issues/11685","id":428845008,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODg0NTAwOA==","user":{"login":"findepi","id":144328,"node_id":"MDQ6VXNlcjE0NDMyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/144328?v=4","gravatar_id":"","url":"https://api.github.com/users/findepi","html_url":"https://github.com/findepi","followers_url":"https://api.github.com/users/findepi/followers","following_url":"https://api.github.com/users/findepi/following{/other_user}","gists_url":"https://api.github.com/users/findepi/gists{/gist_id}","starred_url":"https://api.github.com/users/findepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findepi/subscriptions","organizations_url":"https://api.github.com/users/findepi/orgs","repos_url":"https://api.github.com/users/findepi/repos","events_url":"https://api.github.com/users/findepi/events{/privacy}","received_events_url":"https://api.github.com/users/findepi/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T07:07:20Z","updated_at":"2018-10-11T07:07:20Z","author_association":"MEMBER","body":"> Also for this use case, this seems like any other validation check we have on new tables in the Hive connector. In this case, they user specified a property that isn't supported in that installation.\r\n\r\n@dain If i understand you correctly, you mean something like that: \"this warehouse does not use external tables\" and such use makes a lot of sense to me. For this use-case, current impl is the best.\r\n\r\nI was thinking about different use-case though: \"only this, this and this user can create external tables, for security reasons\". For this use-case, passing table properties would be needed.\r\n\r\nI am closing this now, as the proposed change is clearly debatable. I will reopen when i can back this with real-life requirements."}}
{"actor":{"display_login":"findepi"}}