{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/ui-components/pulls/comments/181985737","pull_request_review_id":112704624,"id":181985737,"diff_hunk":"@@ -67,6 +67,17 @@ function getReadableValueType(type) {\n   return type.name;\n }\n \n+function getDefaultValue(defaultValue) {\n+  if (!defaultValue) return '';\n+\n+  // If default value is a function, show only its name.\n+  if (defaultValue.value.indexOf('function') === 0) {","path":"docs/js/Example.js","position":8,"original_position":8,"commit_id":"4338ab64bad59b084b51ba4027bde0bf3c6c870c","original_commit_id":"4338ab64bad59b084b51ba4027bde0bf3c6c870c","user":{"login":"foot","id":22008,"avatar_url":"https://avatars0.githubusercontent.com/u/22008?v=4","gravatar_id":"","url":"https://api.github.com/users/foot","html_url":"https://github.com/foot","followers_url":"https://api.github.com/users/foot/followers","following_url":"https://api.github.com/users/foot/following{/other_user}","gists_url":"https://api.github.com/users/foot/gists{/gist_id}","starred_url":"https://api.github.com/users/foot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foot/subscriptions","organizations_url":"https://api.github.com/users/foot/orgs","repos_url":"https://api.github.com/users/foot/repos","events_url":"https://api.github.com/users/foot/events{/privacy}","received_events_url":"https://api.github.com/users/foot/received_events","type":"User","site_admin":false},"body":"is this a js fn or a prom fn?","created_at":"2018-04-17T08:08:46Z","updated_at":"2018-04-17T08:44:38Z","html_url":"https://github.com/weaveworks/ui-components/pull/170#discussion_r181985737","pull_request_url":"https://api.github.com/repos/weaveworks/ui-components/pulls/170","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/ui-components/pulls/comments/181985737"},"html":{"href":"https://github.com/weaveworks/ui-components/pull/170#discussion_r181985737"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/ui-components/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/ui-components/pulls/170","id":180880450,"html_url":"https://github.com/weaveworks/ui-components/pull/170","diff_url":"https://github.com/weaveworks/ui-components/pull/170.diff","patch_url":"https://github.com/weaveworks/ui-components/pull/170.patch","issue_url":"https://api.github.com/repos/weaveworks/ui-components/issues/170","number":170,"state":"open","locked":false,"title":"Remove metrics repeated across all series","user":{"login":"fbarl","id":1216874,"avatar_url":"https://avatars1.githubusercontent.com/u/1216874?v=4","gravatar_id":"","url":"https://api.github.com/users/fbarl","html_url":"https://github.com/fbarl","followers_url":"https://api.github.com/users/fbarl/followers","following_url":"https://api.github.com/users/fbarl/following{/other_user}","gists_url":"https://api.github.com/users/fbarl/gists{/gist_id}","starred_url":"https://api.github.com/users/fbarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbarl/subscriptions","organizations_url":"https://api.github.com/users/fbarl/orgs","repos_url":"https://api.github.com/users/fbarl/repos","events_url":"https://api.github.com/users/fbarl/events{/privacy}","received_events_url":"https://api.github.com/users/fbarl/received_events","type":"User","site_admin":false},"body":"Resolves #145.\r\n\r\nAfter this change, all the metric keys that appear across all graph series will be removed by default in legend (unless an explicit `getSeriesName` function is given); hover info will stay the same.\r\n\r\n##### Before\r\n\r\n![image](https://user-images.githubusercontent.com/1216874/38624399-44af6040-3da8-11e8-8698-51e0808e74df.png)\r\n\r\n##### After\r\n\r\n![image](https://user-images.githubusercontent.com/1216874/38802266-3fb1cc96-416c-11e8-9a7a-6fb37f50165c.png)\r\n","created_at":"2018-04-11T12:03:19Z","updated_at":"2018-04-17T08:44:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d641cea04649063f8c65a1bb28dffae82ff27e72","assignee":{"login":"fbarl","id":1216874,"avatar_url":"https://avatars1.githubusercontent.com/u/1216874?v=4","gravatar_id":"","url":"https://api.github.com/users/fbarl","html_url":"https://github.com/fbarl","followers_url":"https://api.github.com/users/fbarl/followers","following_url":"https://api.github.com/users/fbarl/following{/other_user}","gists_url":"https://api.github.com/users/fbarl/gists{/gist_id}","starred_url":"https://api.github.com/users/fbarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbarl/subscriptions","organizations_url":"https://api.github.com/users/fbarl/orgs","repos_url":"https://api.github.com/users/fbarl/repos","events_url":"https://api.github.com/users/fbarl/events{/privacy}","received_events_url":"https://api.github.com/users/fbarl/received_events","type":"User","site_admin":false},"assignees":[{"login":"fbarl","id":1216874,"avatar_url":"https://avatars1.githubusercontent.com/u/1216874?v=4","gravatar_id":"","url":"https://api.github.com/users/fbarl","html_url":"https://github.com/fbarl","followers_url":"https://api.github.com/users/fbarl/followers","following_url":"https://api.github.com/users/fbarl/following{/other_user}","gists_url":"https://api.github.com/users/fbarl/gists{/gist_id}","starred_url":"https://api.github.com/users/fbarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbarl/subscriptions","organizations_url":"https://api.github.com/users/fbarl/orgs","repos_url":"https://api.github.com/users/fbarl/repos","events_url":"https://api.github.com/users/fbarl/events{/privacy}","received_events_url":"https://api.github.com/users/fbarl/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/ui-components/pulls/170/commits","review_comments_url":"https://api.github.com/repos/weaveworks/ui-components/pulls/170/comments","review_comment_url":"https://api.github.com/repos/weaveworks/ui-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/ui-components/issues/170/comments","statuses_url":"https://api.github.com/repos/weaveworks/ui-components/statuses/4338ab64bad59b084b51ba4027bde0bf3c6c870c","head":{"label":"weaveworks:145-remove-repeated-metrics","ref":"145-remove-repeated-metrics","sha":"4338ab64bad59b084b51ba4027bde0bf3c6c870c","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":75203262,"name":"ui-components","full_name":"weaveworks/ui-components","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/ui-components","description":"A collection of UI components that are shared across Weaveworks projects","fork":false,"url":"https://api.github.com/repos/weaveworks/ui-components","forks_url":"https://api.github.com/repos/weaveworks/ui-components/forks","keys_url":"https://api.github.com/repos/weaveworks/ui-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/ui-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/ui-components/teams","hooks_url":"https://api.github.com/repos/weaveworks/ui-components/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/ui-components/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/ui-components/events","assignees_url":"https://api.github.com/repos/weaveworks/ui-components/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/ui-components/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/ui-components/tags","blobs_url":"https://api.github.com/repos/weaveworks/ui-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/ui-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/ui-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/ui-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/ui-components/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/ui-components/languages","stargazers_url":"https://api.github.com/repos/weaveworks/ui-components/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/ui-components/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/ui-components/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/ui-components/subscription","commits_url":"https://api.github.com/repos/weaveworks/ui-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/ui-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/ui-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/ui-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/ui-components/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/ui-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/ui-components/merges","archive_url":"https://api.github.com/repos/weaveworks/ui-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/ui-components/downloads","issues_url":"https://api.github.com/repos/weaveworks/ui-components/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/ui-components/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/ui-components/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/ui-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/ui-components/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/ui-components/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/ui-components/deployments","created_at":"2016-11-30T16:04:37Z","updated_at":"2018-04-16T15:34:54Z","pushed_at":"2018-04-16T15:34:53Z","git_url":"git://github.com/weaveworks/ui-components.git","ssh_url":"git@github.com:weaveworks/ui-components.git","clone_url":"https://github.com/weaveworks/ui-components.git","svn_url":"https://github.com/weaveworks/ui-components","homepage":"","size":889,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":8,"open_issues":28,"watchers":11,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"61a3b3603e943f891f7694949b5028406887d448","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":75203262,"name":"ui-components","full_name":"weaveworks/ui-components","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/ui-components","description":"A collection of UI components that are shared across Weaveworks projects","fork":false,"url":"https://api.github.com/repos/weaveworks/ui-components","forks_url":"https://api.github.com/repos/weaveworks/ui-components/forks","keys_url":"https://api.github.com/repos/weaveworks/ui-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/ui-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/ui-components/teams","hooks_url":"https://api.github.com/repos/weaveworks/ui-components/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/ui-components/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/ui-components/events","assignees_url":"https://api.github.com/repos/weaveworks/ui-components/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/ui-components/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/ui-components/tags","blobs_url":"https://api.github.com/repos/weaveworks/ui-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/ui-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/ui-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/ui-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/ui-components/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/ui-components/languages","stargazers_url":"https://api.github.com/repos/weaveworks/ui-components/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/ui-components/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/ui-components/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/ui-components/subscription","commits_url":"https://api.github.com/repos/weaveworks/ui-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/ui-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/ui-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/ui-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/ui-components/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/ui-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/ui-components/merges","archive_url":"https://api.github.com/repos/weaveworks/ui-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/ui-components/downloads","issues_url":"https://api.github.com/repos/weaveworks/ui-components/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/ui-components/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/ui-components/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/ui-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/ui-components/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/ui-components/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/ui-components/deployments","created_at":"2016-11-30T16:04:37Z","updated_at":"2018-04-16T15:34:54Z","pushed_at":"2018-04-16T15:34:53Z","git_url":"git://github.com/weaveworks/ui-components.git","ssh_url":"git@github.com:weaveworks/ui-components.git","clone_url":"https://github.com/weaveworks/ui-components.git","svn_url":"https://github.com/weaveworks/ui-components","homepage":"","size":889,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":8,"open_issues":28,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/ui-components/pulls/170"},"html":{"href":"https://github.com/weaveworks/ui-components/pull/170"},"issue":{"href":"https://api.github.com/repos/weaveworks/ui-components/issues/170"},"comments":{"href":"https://api.github.com/repos/weaveworks/ui-components/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/ui-components/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/ui-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/ui-components/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/ui-components/statuses/4338ab64bad59b084b51ba4027bde0bf3c6c870c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"foot"}}