{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/comments/175662853","pull_request_review_id":105226932,"id":175662853,"diff_hunk":"@@ -196,4 +196,10 @@ public void removePreferencesChangeListener(IPreferencesChangeListener listener)\n \tpublic IEclipsePreferences getEclipsePreferences() {\n \t\treturn eclipsePrefs;\n \t}\n+\n+\tpublic void setDefaultPreferences() {","path":"org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/PreferenceManager.java","position":5,"original_position":5,"commit_id":"55347bf8c90cac9d2da232967a2d8f5a85798dc6","original_commit_id":"55347bf8c90cac9d2da232967a2d8f5a85798dc6","user":{"login":"fbricon","id":148698,"avatar_url":"https://avatars3.githubusercontent.com/u/148698?v=4","gravatar_id":"","url":"https://api.github.com/users/fbricon","html_url":"https://github.com/fbricon","followers_url":"https://api.github.com/users/fbricon/followers","following_url":"https://api.github.com/users/fbricon/following{/other_user}","gists_url":"https://api.github.com/users/fbricon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbricon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbricon/subscriptions","organizations_url":"https://api.github.com/users/fbricon/orgs","repos_url":"https://api.github.com/users/fbricon/repos","events_url":"https://api.github.com/users/fbricon/events{/privacy}","received_events_url":"https://api.github.com/users/fbricon/received_events","type":"User","site_admin":false},"body":"initialize() already sets those prefs for the DefaultScope, which is called in the PreferenceManager constructor, so I don't see why we need this new method","created_at":"2018-03-20T06:09:41Z","updated_at":"2018-03-20T06:09:42Z","html_url":"https://github.com/eclipse/eclipse.jdt.ls/pull/592#discussion_r175662853","pull_request_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/592","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/comments/175662853"},"html":{"href":"https://github.com/eclipse/eclipse.jdt.ls/pull/592#discussion_r175662853"},"pull_request":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/592"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/592","id":176000557,"html_url":"https://github.com/eclipse/eclipse.jdt.ls/pull/592","diff_url":"https://github.com/eclipse/eclipse.jdt.ls/pull/592.diff","patch_url":"https://github.com/eclipse/eclipse.jdt.ls/pull/592.patch","issue_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/592","number":592,"state":"open","locked":false,"title":"Random test failure in testOrganizeImportsModuleInfo","user":{"login":"snjeza","id":388609,"avatar_url":"https://avatars2.githubusercontent.com/u/388609?v=4","gravatar_id":"","url":"https://api.github.com/users/snjeza","html_url":"https://github.com/snjeza","followers_url":"https://api.github.com/users/snjeza/followers","following_url":"https://api.github.com/users/snjeza/following{/other_user}","gists_url":"https://api.github.com/users/snjeza/gists{/gist_id}","starred_url":"https://api.github.com/users/snjeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snjeza/subscriptions","organizations_url":"https://api.github.com/users/snjeza/orgs","repos_url":"https://api.github.com/users/snjeza/repos","events_url":"https://api.github.com/users/snjeza/events{/privacy}","received_events_url":"https://api.github.com/users/snjeza/received_events","type":"User","site_admin":false},"body":"Fixes #587 \r\n\r\nSigned-off-by: Snjezana Peco <snjezana.peco@redhat.com>","created_at":"2018-03-19T19:22:44Z","updated_at":"2018-03-20T06:09:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59b0c785fa315538991ec844950207d50182289c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gorkem","id":82738,"avatar_url":"https://avatars2.githubusercontent.com/u/82738?v=4","gravatar_id":"","url":"https://api.github.com/users/gorkem","html_url":"https://github.com/gorkem","followers_url":"https://api.github.com/users/gorkem/followers","following_url":"https://api.github.com/users/gorkem/following{/other_user}","gists_url":"https://api.github.com/users/gorkem/gists{/gist_id}","starred_url":"https://api.github.com/users/gorkem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorkem/subscriptions","organizations_url":"https://api.github.com/users/gorkem/orgs","repos_url":"https://api.github.com/users/gorkem/repos","events_url":"https://api.github.com/users/gorkem/events{/privacy}","received_events_url":"https://api.github.com/users/gorkem/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":446413461,"url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/592/commits","review_comments_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/592/comments","review_comment_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/592/comments","statuses_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/statuses/55347bf8c90cac9d2da232967a2d8f5a85798dc6","head":{"label":"snjeza:issue-587import","ref":"issue-587import","sha":"55347bf8c90cac9d2da232967a2d8f5a85798dc6","user":{"login":"snjeza","id":388609,"avatar_url":"https://avatars2.githubusercontent.com/u/388609?v=4","gravatar_id":"","url":"https://api.github.com/users/snjeza","html_url":"https://github.com/snjeza","followers_url":"https://api.github.com/users/snjeza/followers","following_url":"https://api.github.com/users/snjeza/following{/other_user}","gists_url":"https://api.github.com/users/snjeza/gists{/gist_id}","starred_url":"https://api.github.com/users/snjeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snjeza/subscriptions","organizations_url":"https://api.github.com/users/snjeza/orgs","repos_url":"https://api.github.com/users/snjeza/repos","events_url":"https://api.github.com/users/snjeza/events{/privacy}","received_events_url":"https://api.github.com/users/snjeza/received_events","type":"User","site_admin":false},"repo":{"id":90472196,"name":"eclipse.jdt.ls","full_name":"snjeza/eclipse.jdt.ls","owner":{"login":"snjeza","id":388609,"avatar_url":"https://avatars2.githubusercontent.com/u/388609?v=4","gravatar_id":"","url":"https://api.github.com/users/snjeza","html_url":"https://github.com/snjeza","followers_url":"https://api.github.com/users/snjeza/followers","following_url":"https://api.github.com/users/snjeza/following{/other_user}","gists_url":"https://api.github.com/users/snjeza/gists{/gist_id}","starred_url":"https://api.github.com/users/snjeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snjeza/subscriptions","organizations_url":"https://api.github.com/users/snjeza/orgs","repos_url":"https://api.github.com/users/snjeza/repos","events_url":"https://api.github.com/users/snjeza/events{/privacy}","received_events_url":"https://api.github.com/users/snjeza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snjeza/eclipse.jdt.ls","description":"Java language server","fork":true,"url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls","forks_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/forks","keys_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/teams","hooks_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/hooks","issue_events_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/issues/events{/number}","events_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/events","assignees_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/assignees{/user}","branches_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/branches{/branch}","tags_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/tags","blobs_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/git/refs{/sha}","trees_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/statuses/{sha}","languages_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/languages","stargazers_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/stargazers","contributors_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/contributors","subscribers_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/subscribers","subscription_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/subscription","commits_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/commits{/sha}","git_commits_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/git/commits{/sha}","comments_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/comments{/number}","issue_comment_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/issues/comments{/number}","contents_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/contents/{+path}","compare_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/merges","archive_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/downloads","issues_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/issues{/number}","pulls_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/pulls{/number}","milestones_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/milestones{/number}","notifications_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/labels{/name}","releases_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/releases{/id}","deployments_url":"https://api.github.com/repos/snjeza/eclipse.jdt.ls/deployments","created_at":"2017-05-06T15:24:07Z","updated_at":"2018-03-16T21:40:41Z","pushed_at":"2018-03-19T23:52:33Z","git_url":"git://github.com/snjeza/eclipse.jdt.ls.git","ssh_url":"git@github.com:snjeza/eclipse.jdt.ls.git","clone_url":"https://github.com/snjeza/eclipse.jdt.ls.git","svn_url":"https://github.com/snjeza/eclipse.jdt.ls","homepage":null,"size":4375,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"ddca6bac944c0ac7b3f5f6df33d8467a464b5e14","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":62056780,"name":"eclipse.jdt.ls","full_name":"eclipse/eclipse.jdt.ls","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/eclipse.jdt.ls","description":"Java language server","fork":false,"url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls","forks_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/forks","keys_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/teams","hooks_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/hooks","issue_events_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/events","assignees_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/tags","blobs_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/languages","stargazers_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/stargazers","contributors_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/contributors","subscribers_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/subscribers","subscription_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/subscription","commits_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/merges","archive_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/downloads","issues_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/deployments","created_at":"2016-06-27T13:06:53Z","updated_at":"2018-03-16T21:35:11Z","pushed_at":"2018-03-20T05:51:35Z","git_url":"git://github.com/eclipse/eclipse.jdt.ls.git","ssh_url":"git@github.com:eclipse/eclipse.jdt.ls.git","clone_url":"https://github.com/eclipse/eclipse.jdt.ls.git","svn_url":"https://github.com/eclipse/eclipse.jdt.ls","homepage":null,"size":4307,"stargazers_count":290,"watchers_count":290,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":81,"open_issues":97,"watchers":290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/592"},"html":{"href":"https://github.com/eclipse/eclipse.jdt.ls/pull/592"},"issue":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/592"},"comments":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/592/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/592/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/592/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/statuses/55347bf8c90cac9d2da232967a2d8f5a85798dc6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fbricon"}}