{"action":"created","issue":{"url":"https://api.github.com/repos/recombee/net-api-client/issues/1","repository_url":"https://api.github.com/repos/recombee/net-api-client","labels_url":"https://api.github.com/repos/recombee/net-api-client/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/recombee/net-api-client/issues/1/comments","events_url":"https://api.github.com/repos/recombee/net-api-client/issues/1/events","html_url":"https://github.com/recombee/net-api-client/issues/1","id":278037993,"node_id":"MDU6SXNzdWUyNzgwMzc5OTM=","number":1,"title":"Async methods","user":{"login":"nadjibus","id":3637280,"node_id":"MDQ6VXNlcjM2MzcyODA=","avatar_url":"https://avatars1.githubusercontent.com/u/3637280?v=4","gravatar_id":"","url":"https://api.github.com/users/nadjibus","html_url":"https://github.com/nadjibus","followers_url":"https://api.github.com/users/nadjibus/followers","following_url":"https://api.github.com/users/nadjibus/following{/other_user}","gists_url":"https://api.github.com/users/nadjibus/gists{/gist_id}","starred_url":"https://api.github.com/users/nadjibus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadjibus/subscriptions","organizations_url":"https://api.github.com/users/nadjibus/orgs","repos_url":"https://api.github.com/users/nadjibus/repos","events_url":"https://api.github.com/users/nadjibus/events{/privacy}","received_events_url":"https://api.github.com/users/nadjibus/received_events","type":"User","site_admin":false},"labels":[{"id":603056098,"node_id":"MDU6TGFiZWw2MDMwNTYwOTg=","url":"https://api.github.com/repos/recombee/net-api-client/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-30T08:39:04Z","updated_at":"2018-10-30T17:35:41Z","closed_at":null,"author_association":"NONE","body":"It's very useful, especially for network related tasks (like Recombee API) to use async methods rather than sync ones."},"comment":{"url":"https://api.github.com/repos/recombee/net-api-client/issues/comments/434398548","html_url":"https://github.com/recombee/net-api-client/issues/1#issuecomment-434398548","issue_url":"https://api.github.com/repos/recombee/net-api-client/issues/1","id":434398548,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDM5ODU0OA==","user":{"login":"nadjibus","id":3637280,"node_id":"MDQ6VXNlcjM2MzcyODA=","avatar_url":"https://avatars1.githubusercontent.com/u/3637280?v=4","gravatar_id":"","url":"https://api.github.com/users/nadjibus","html_url":"https://github.com/nadjibus","followers_url":"https://api.github.com/users/nadjibus/followers","following_url":"https://api.github.com/users/nadjibus/following{/other_user}","gists_url":"https://api.github.com/users/nadjibus/gists{/gist_id}","starred_url":"https://api.github.com/users/nadjibus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadjibus/subscriptions","organizations_url":"https://api.github.com/users/nadjibus/orgs","repos_url":"https://api.github.com/users/nadjibus/repos","events_url":"https://api.github.com/users/nadjibus/events{/privacy}","received_events_url":"https://api.github.com/users/nadjibus/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T17:35:40Z","updated_at":"2018-10-30T17:35:40Z","author_association":"NONE","body":"Thank you for your reply.\r\n\r\nFor HttpClient instance, I still think that it is indeed created each request, because HttpClient default timeout is 100 seconds, and your requests are 1 second I think, so it will always be different (unless the user makes it manually 100 seconds for each request)\r\n\r\nAlso you can define a timeout by request easily without having to create a new HttpClient instance, by using HttpClient.SendAsync(HttpRequestMessage) instead of HttpClient.GetAsync/PostAsync (you can check [my implementation](https://github.com/nadjibus/net-api-client/blob/211a0cca8a5d05c17f9e1228e9e2a7016804d468/Src/Recombee.ApiClient/RecombeeClient.cs#L227))\r\n\r\nAlso in my implementation I made the default request timeout to 10 seconds. 1 was too optimistic, 60-80% of unit tests were failing due to timeouts (the remaining 20% were bad tests, didn't have the time to fix them sorry).\r\n\r\nYour team had successful unit tests with the 1 sec timeout maybe because you are located near your servers (just guessing here...)\r\n\r\nFor other bugs, they were minor (spelling errors, unoptimized code...)\r\n\r\nThe code itself can be optimized and simplified A LOT by using generics (probably around 60-70% of the can be removed). Sorry didn't have enough time to do it, since I have to implement your awesome SDK into my project :)\r\n\r\n"}}
{"actor":{"display_login":"nadjibus"}}