{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/8900","repository_url":"https://api.github.com/repos/kubernetes/test-infra","labels_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8900/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8900/comments","events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8900/events","html_url":"https://github.com/kubernetes/test-infra/pull/8900","id":346244687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTU2Mjk3","number":8900,"title":"Add top-level test-grid category \"vmware\"","user":{"login":"akutz","id":101085,"node_id":"MDQ6VXNlcjEwMTA4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/101085?v=4","gravatar_id":"","url":"https://api.github.com/users/akutz","html_url":"https://github.com/akutz","followers_url":"https://api.github.com/users/akutz/followers","following_url":"https://api.github.com/users/akutz/following{/other_user}","gists_url":"https://api.github.com/users/akutz/gists{/gist_id}","starred_url":"https://api.github.com/users/akutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akutz/subscriptions","organizations_url":"https://api.github.com/users/akutz/orgs","repos_url":"https://api.github.com/users/akutz/repos","events_url":"https://api.github.com/users/akutz/events{/privacy}","received_events_url":"https://api.github.com/users/akutz/received_events","type":"User","site_admin":false},"labels":[{"id":484580953,"node_id":"MDU6TGFiZWw0ODQ1ODA5NTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":671133328,"node_id":"MDU6TGFiZWw2NzExMzMzMjg=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-31T15:39:33Z","updated_at":"2018-07-31T16:07:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8900","html_url":"https://github.com/kubernetes/test-infra/pull/8900","diff_url":"https://github.com/kubernetes/test-infra/pull/8900.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/8900.patch"},"body":"This patch adds a new top-level category named `vmware` to the test grid in order to organize all VMware-related test results / dashboards in a single location. The same results will still be organized under other, appropriate top-level categories as well, but this will provide a much easier way for visitors concerned specifically with VMware-related results to find said results.\r\n\r\nThis [document](\r\nhttps://docs.google.com/document/d/1bW2WxS1tprXwC9VBFDcs8W5yh9MNytj8f73_7TGNNWM/edit?usp=sharing) was the focal point of a discussion of what to name a top-level category. The reasons behind the decision to use `vmware` over a SIG are highlighted in the linked document."},"comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments/409276509","html_url":"https://github.com/kubernetes/test-infra/pull/8900#issuecomment-409276509","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8900","id":409276509,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTI3NjUwOQ==","user":{"login":"akutz","id":101085,"node_id":"MDQ6VXNlcjEwMTA4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/101085?v=4","gravatar_id":"","url":"https://api.github.com/users/akutz","html_url":"https://github.com/akutz","followers_url":"https://api.github.com/users/akutz/followers","following_url":"https://api.github.com/users/akutz/following{/other_user}","gists_url":"https://api.github.com/users/akutz/gists{/gist_id}","starred_url":"https://api.github.com/users/akutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akutz/subscriptions","organizations_url":"https://api.github.com/users/akutz/orgs","repos_url":"https://api.github.com/users/akutz/repos","events_url":"https://api.github.com/users/akutz/events{/privacy}","received_events_url":"https://api.github.com/users/akutz/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T16:07:17Z","updated_at":"2018-07-31T16:07:17Z","author_association":"NONE","body":"Hi @figo and @frapposelli,\r\n\r\nThis PR failed for the following reason:\r\n\r\n```\r\nexec ${PAGER:-/usr/bin/less} \"$0\" || exit 1\r\nExecuting tests from //testgrid/cmd/configurator:go_default_test\r\n-----------------------------------------------------------------------------\r\n--- FAIL: TestConfig (0.01s)\r\n\tconfig_test.go:252: Dashboard group vmware: must prefix with one of: [[conformance presubmits sig wg] [canonical cri-o istio google kopeio tectonic redhat]]\r\n\tconfig_test.go:269: Duplicated dashboard presubmits-cloud-provider-vsphere-blocking in dashboard group presubmits and vmware\r\n\tconfig_test.go:279: Dashboard presubmits-cloud-provider-vsphere-blocking in group vmware must have the group name as a prefix\r\nFAIL\r\n```\r\n\r\nMy thoughts on the failure:\r\n\r\n1. It appears it's possible to add new group names to a predefined whitelist. I believe instead of renaming the group we should add `vmware` to the whitelist.\r\n2. It seems that for tests to reside in a category the test must include the category's name as a prefix? I thought that @spiffxp mentioned dashboards could be grouped into multiple categories. Aaron, was I mistaken?"}}
{"actor":{"display_login":"akutz"}}