{"action":"created","issue":{"url":"https://api.github.com/repos/mdn/browser-compat-data/issues/2413","repository_url":"https://api.github.com/repos/mdn/browser-compat-data","labels_url":"https://api.github.com/repos/mdn/browser-compat-data/issues/2413/labels{/name}","comments_url":"https://api.github.com/repos/mdn/browser-compat-data/issues/2413/comments","events_url":"https://api.github.com/repos/mdn/browser-compat-data/issues/2413/events","html_url":"https://github.com/mdn/browser-compat-data/pull/2413","id":338077492,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTAwODMx","number":2413,"title":"Enable shape outside","user":{"login":"wbamberg","id":432915,"node_id":"MDQ6VXNlcjQzMjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/432915?v=4","gravatar_id":"","url":"https://api.github.com/users/wbamberg","html_url":"https://github.com/wbamberg","followers_url":"https://api.github.com/users/wbamberg/followers","following_url":"https://api.github.com/users/wbamberg/following{/other_user}","gists_url":"https://api.github.com/users/wbamberg/gists{/gist_id}","starred_url":"https://api.github.com/users/wbamberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbamberg/subscriptions","organizations_url":"https://api.github.com/users/wbamberg/orgs","repos_url":"https://api.github.com/users/wbamberg/repos","events_url":"https://api.github.com/users/wbamberg/events{/privacy}","received_events_url":"https://api.github.com/users/wbamberg/received_events","type":"User","site_admin":false},"labels":[{"id":597839539,"node_id":"MDU6TGFiZWw1OTc4Mzk1Mzk=","url":"https://api.github.com/repos/mdn/browser-compat-data/labels/data:css%20:art:","name":"data:css :art:","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mdn/browser-compat-data/milestones/3","html_url":"https://github.com/mdn/browser-compat-data/milestone/3","labels_url":"https://api.github.com/repos/mdn/browser-compat-data/milestones/3/labels","id":3457313,"node_id":"MDk6TWlsZXN0b25lMzQ1NzMxMw==","number":3,"title":"Sprint 1 Q3 2018","description":"See https://github.com/mdn/sprints/milestone/3","creator":{"login":"jwhitlock","id":286017,"node_id":"MDQ6VXNlcjI4NjAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/286017?v=4","gravatar_id":"","url":"https://api.github.com/users/jwhitlock","html_url":"https://github.com/jwhitlock","followers_url":"https://api.github.com/users/jwhitlock/followers","following_url":"https://api.github.com/users/jwhitlock/following{/other_user}","gists_url":"https://api.github.com/users/jwhitlock/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhitlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhitlock/subscriptions","organizations_url":"https://api.github.com/users/jwhitlock/orgs","repos_url":"https://api.github.com/users/jwhitlock/repos","events_url":"https://api.github.com/users/jwhitlock/events{/privacy}","received_events_url":"https://api.github.com/users/jwhitlock/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":10,"state":"open","created_at":"2018-06-27T19:19:10Z","updated_at":"2018-07-04T13:55:19Z","due_on":"2018-07-17T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-07-03T22:46:07Z","updated_at":"2018-07-04T20:47:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mdn/browser-compat-data/pulls/2413","html_url":"https://github.com/mdn/browser-compat-data/pull/2413","diff_url":"https://github.com/mdn/browser-compat-data/pull/2413.diff","patch_url":"https://github.com/mdn/browser-compat-data/pull/2413.patch"},"body":"Firefox 61 supported https://developer.mozilla.org/en-US/docs/Web/CSS/shape-margin and [`shape-outside`](https://developer.mozilla.org/en-US/docs/Web/CSS/shape-outside) behind a pref, in Firefox 62 this pref was enabled by default.\r\n\r\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1457297"},"comment":{"url":"https://api.github.com/repos/mdn/browser-compat-data/issues/comments/402557039","html_url":"https://github.com/mdn/browser-compat-data/pull/2413#issuecomment-402557039","issue_url":"https://api.github.com/repos/mdn/browser-compat-data/issues/2413","id":402557039,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjU1NzAzOQ==","user":{"login":"wbamberg","id":432915,"node_id":"MDQ6VXNlcjQzMjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/432915?v=4","gravatar_id":"","url":"https://api.github.com/users/wbamberg","html_url":"https://github.com/wbamberg","followers_url":"https://api.github.com/users/wbamberg/followers","following_url":"https://api.github.com/users/wbamberg/following{/other_user}","gists_url":"https://api.github.com/users/wbamberg/gists{/gist_id}","starred_url":"https://api.github.com/users/wbamberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbamberg/subscriptions","organizations_url":"https://api.github.com/users/wbamberg/orgs","repos_url":"https://api.github.com/users/wbamberg/repos","events_url":"https://api.github.com/users/wbamberg/events{/privacy}","received_events_url":"https://api.github.com/users/wbamberg/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T20:47:26Z","updated_at":"2018-07-04T20:47:26Z","author_association":"MEMBER","body":"> 1. this contains an unrelated commit, can you rebase so it disappears?\r\n\r\nD'oh!\r\n\r\n> 2. css/types/basic-shape.json and css/properties/shape-image-threshold.json are also affected I think (I searched for \"layout.css.shape-outside.enabled\" on the BCD repo)\r\n\r\nThis seems to be correct for `shape-image-threshold` but incorrect for `basic-shape`.\r\n\r\nEasy-ish way to test:\r\n* fire up, say release Firefox (61) and make sure the \"layout.css.shape-outside.enabled\" pref is set to its default value (should be false)\r\n* load https://developer.mozilla.org/en-US/docs/Web/CSS/basic-shape and see if the interactive demo works\r\n* load https://developer.mozilla.org/en-US/docs/Web/CSS/shape-image-threshold and see if the interactive demo works\r\n\r\nLooking at the code, it seems there are 3 relevant hits for \"layout.css.shape-outside.enabled\", corresponding to those three properties: https://searchfox.org/mozilla-central/source/servo/components/style/properties/longhands/box.mako.rs#657-687. But not for `basic-shape`.\r\n\r\n"}}
{"actor":{"display_login":"wbamberg"}}