{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/166127735","pull_request_review_id":94160703,"id":166127735,"diff_hunk":"@@ -63,6 +63,7 @@ cover_basic_blockst::cover_basic_blockst(const goto_programt &_goto_program)\n \n     // set representative program location to instrument\n     if(\n+      !it->function.empty() &&","path":"src/goto-instrument/cover_basic_blocks.cpp","position":4,"original_position":4,"commit_id":"74cba8ddd34e3b62c286dd97665caf8fe0c1b051","original_commit_id":"74cba8ddd34e3b62c286dd97665caf8fe0c1b051","user":{"login":"peterschrammel","id":4222448,"avatar_url":"https://avatars3.githubusercontent.com/u/4222448?v=4","gravatar_id":"","url":"https://api.github.com/users/peterschrammel","html_url":"https://github.com/peterschrammel","followers_url":"https://api.github.com/users/peterschrammel/followers","following_url":"https://api.github.com/users/peterschrammel/following{/other_user}","gists_url":"https://api.github.com/users/peterschrammel/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschrammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschrammel/subscriptions","organizations_url":"https://api.github.com/users/peterschrammel/orgs","repos_url":"https://api.github.com/users/peterschrammel/repos","events_url":"https://api.github.com/users/peterschrammel/events{/privacy}","received_events_url":"https://api.github.com/users/peterschrammel/received_events","type":"User","site_admin":false},"body":"Correct. Let me check how big this piece of work will be. I will then put an INVARIANT in goto_programt::update.","created_at":"2018-02-05T22:08:44Z","updated_at":"2018-02-05T22:08:44Z","html_url":"https://github.com/diffblue/cbmc/pull/1799#discussion_r166127735","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1799","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/166127735"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1799#discussion_r166127735"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1799"}},"in_reply_to_id":166122238},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/1799","id":167261840,"html_url":"https://github.com/diffblue/cbmc/pull/1799","diff_url":"https://github.com/diffblue/cbmc/pull/1799.diff","patch_url":"https://github.com/diffblue/cbmc/pull/1799.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/1799","number":1799,"state":"open","locked":false,"title":"Select instruction with non-empty function in coverage block [TG-2341]","user":{"login":"peterschrammel","id":4222448,"avatar_url":"https://avatars3.githubusercontent.com/u/4222448?v=4","gravatar_id":"","url":"https://api.github.com/users/peterschrammel","html_url":"https://github.com/peterschrammel","followers_url":"https://api.github.com/users/peterschrammel/followers","following_url":"https://api.github.com/users/peterschrammel/following{/other_user}","gists_url":"https://api.github.com/users/peterschrammel/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschrammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschrammel/subscriptions","organizations_url":"https://api.github.com/users/peterschrammel/orgs","repos_url":"https://api.github.com/users/peterschrammel/repos","events_url":"https://api.github.com/users/peterschrammel/events{/privacy}","received_events_url":"https://api.github.com/users/peterschrammel/received_events","type":"User","site_admin":false},"body":"Otherwise coverage goals cannot be linked to functions in consumers of CBMC output.","created_at":"2018-02-05T21:40:21Z","updated_at":"2018-02-05T22:08:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"793f6dcecd8dc9d65db84b6a8ea7a1093928ebc7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"martin-cs","id":5333188,"avatar_url":"https://avatars0.githubusercontent.com/u/5333188?v=4","gravatar_id":"","url":"https://api.github.com/users/martin-cs","html_url":"https://github.com/martin-cs","followers_url":"https://api.github.com/users/martin-cs/followers","following_url":"https://api.github.com/users/martin-cs/following{/other_user}","gists_url":"https://api.github.com/users/martin-cs/gists{/gist_id}","starred_url":"https://api.github.com/users/martin-cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin-cs/subscriptions","organizations_url":"https://api.github.com/users/martin-cs/orgs","repos_url":"https://api.github.com/users/martin-cs/repos","events_url":"https://api.github.com/users/martin-cs/events{/privacy}","received_events_url":"https://api.github.com/users/martin-cs/received_events","type":"User","site_admin":false},{"login":"chrisr-diffblue","id":32060010,"avatar_url":"https://avatars2.githubusercontent.com/u/32060010?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisr-diffblue","html_url":"https://github.com/chrisr-diffblue","followers_url":"https://api.github.com/users/chrisr-diffblue/followers","following_url":"https://api.github.com/users/chrisr-diffblue/following{/other_user}","gists_url":"https://api.github.com/users/chrisr-diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisr-diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisr-diffblue/subscriptions","organizations_url":"https://api.github.com/users/chrisr-diffblue/orgs","repos_url":"https://api.github.com/users/chrisr-diffblue/repos","events_url":"https://api.github.com/users/chrisr-diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/chrisr-diffblue/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1799/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1799/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/1799/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/74cba8ddd34e3b62c286dd97665caf8fe0c1b051","head":{"label":"peterschrammel:cover-repr-instr-with-function","ref":"cover-repr-instr-with-function","sha":"74cba8ddd34e3b62c286dd97665caf8fe0c1b051","user":{"login":"peterschrammel","id":4222448,"avatar_url":"https://avatars3.githubusercontent.com/u/4222448?v=4","gravatar_id":"","url":"https://api.github.com/users/peterschrammel","html_url":"https://github.com/peterschrammel","followers_url":"https://api.github.com/users/peterschrammel/followers","following_url":"https://api.github.com/users/peterschrammel/following{/other_user}","gists_url":"https://api.github.com/users/peterschrammel/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschrammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschrammel/subscriptions","organizations_url":"https://api.github.com/users/peterschrammel/orgs","repos_url":"https://api.github.com/users/peterschrammel/repos","events_url":"https://api.github.com/users/peterschrammel/events{/privacy}","received_events_url":"https://api.github.com/users/peterschrammel/received_events","type":"User","site_admin":false},"repo":{"id":55680594,"name":"cbmc","full_name":"peterschrammel/cbmc","owner":{"login":"peterschrammel","id":4222448,"avatar_url":"https://avatars3.githubusercontent.com/u/4222448?v=4","gravatar_id":"","url":"https://api.github.com/users/peterschrammel","html_url":"https://github.com/peterschrammel","followers_url":"https://api.github.com/users/peterschrammel/followers","following_url":"https://api.github.com/users/peterschrammel/following{/other_user}","gists_url":"https://api.github.com/users/peterschrammel/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschrammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschrammel/subscriptions","organizations_url":"https://api.github.com/users/peterschrammel/orgs","repos_url":"https://api.github.com/users/peterschrammel/repos","events_url":"https://api.github.com/users/peterschrammel/events{/privacy}","received_events_url":"https://api.github.com/users/peterschrammel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterschrammel/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/peterschrammel/cbmc","forks_url":"https://api.github.com/repos/peterschrammel/cbmc/forks","keys_url":"https://api.github.com/repos/peterschrammel/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterschrammel/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterschrammel/cbmc/teams","hooks_url":"https://api.github.com/repos/peterschrammel/cbmc/hooks","issue_events_url":"https://api.github.com/repos/peterschrammel/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/peterschrammel/cbmc/events","assignees_url":"https://api.github.com/repos/peterschrammel/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/peterschrammel/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/peterschrammel/cbmc/tags","blobs_url":"https://api.github.com/repos/peterschrammel/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterschrammel/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterschrammel/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterschrammel/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterschrammel/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/peterschrammel/cbmc/languages","stargazers_url":"https://api.github.com/repos/peterschrammel/cbmc/stargazers","contributors_url":"https://api.github.com/repos/peterschrammel/cbmc/contributors","subscribers_url":"https://api.github.com/repos/peterschrammel/cbmc/subscribers","subscription_url":"https://api.github.com/repos/peterschrammel/cbmc/subscription","commits_url":"https://api.github.com/repos/peterschrammel/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterschrammel/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterschrammel/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterschrammel/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterschrammel/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/peterschrammel/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterschrammel/cbmc/merges","archive_url":"https://api.github.com/repos/peterschrammel/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterschrammel/cbmc/downloads","issues_url":"https://api.github.com/repos/peterschrammel/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/peterschrammel/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/peterschrammel/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/peterschrammel/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterschrammel/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/peterschrammel/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/peterschrammel/cbmc/deployments","created_at":"2016-04-07T09:12:29Z","updated_at":"2016-04-07T09:12:36Z","pushed_at":"2018-02-05T16:05:11Z","git_url":"git://github.com/peterschrammel/cbmc.git","ssh_url":"git@github.com:peterschrammel/cbmc.git","clone_url":"https://github.com/peterschrammel/cbmc.git","svn_url":"https://github.com/peterschrammel/cbmc","homepage":"http://www.cprover.org/cbmc","size":28042,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"diffblue:develop","ref":"develop","sha":"6f6fda765f3c1f0412dfb4c8e0a109dc0c2868c7","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2018-01-23T02:11:10Z","pushed_at":"2018-02-05T21:52:35Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":27731,"stargazers_count":93,"watchers_count":93,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":306,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":86,"open_issues":306,"watchers":93,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1799"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1799"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1799"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1799/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1799/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1799/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/74cba8ddd34e3b62c286dd97665caf8fe0c1b051"}},"author_association":"OWNER"}}
{"actor":{"display_login":"peterschrammel"}}