{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/21607","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/21607/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21607/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/21607/events","html_url":"https://github.com/nodejs/node/pull/21607","id":337213724,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDc2MTM2","number":21607,"title":"zlib: fix memory leak for unused zlib instances","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":155436008,"node_id":"MDU6TGFiZWwxNTU0MzYwMDg=","url":"https://api.github.com/repos/nodejs/node/labels/zlib","name":"zlib","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-30T13:07:50Z","updated_at":"2018-07-03T17:23:42Z","closed_at":"2018-07-03T17:23:42Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21607","html_url":"https://github.com/nodejs/node/pull/21607","diff_url":"https://github.com/nodejs/node/pull/21607.diff","patch_url":"https://github.com/nodejs/node/pull/21607.patch"},"body":"An oversight in an earlier commit led to a memory leak\r\nin the untypical situation that zlib instances are created\r\nbut never used, because zlib handles no longer started\r\nout their life as weak handles.\r\n\r\nThe bug was introduced in bd201102862a194f3f5ce669e0a3c8143eafc900.\r\n\r\nRefs: https://github.com/nodejs/node/pull/20455\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/402232797","html_url":"https://github.com/nodejs/node/pull/21607#issuecomment-402232797","issue_url":"https://api.github.com/repos/nodejs/node/issues/21607","id":402232797,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjIzMjc5Nw==","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T17:23:42Z","updated_at":"2018-07-03T17:23:42Z","author_association":"MEMBER","body":"Landed in 6e16ad7a63ba843aafa1284e51ce220a775e11d8"}}
{"actor":{"display_login":"addaleax"}}