{"action":"created","comment":{"url":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/comments/222675564","pull_request_review_id":161619108,"id":222675564,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjY3NTU2NA==","diff_hunk":"@@ -1,25 +1,37 @@\n-# https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server\n+# Puma can serve each request in a thread from an internal thread pool.\n+# The `threads` method setting takes two numbers: a minimum and maximum.\n+# Any libraries that use thread pools should be configured to match\n+# the maximum value specified for Puma. Default is set to 5 threads for minimum\n+# and maximum; this matches the default thread size of Active Record.\n+#\n+threads_count = ENV.fetch(\"RAILS_MAX_THREADS\") { 5 }\n+threads threads_count, threads_count\n \n-# The environment variable WEB_CONCURRENCY may be set to a default value based\n-# on dyno size. To manually configure this value use heroku config:set\n-# WEB_CONCURRENCY.\n+# Specifies the `port` that Puma will listen on to receive requests; default is 3000.\n #\n-# Increasing the number of workers will increase the amount of resting memory\n-# your dynos use. Increasing the number of threads will increase the amount of\n-# potential bloat added to your dynos when they are responding to heavy\n-# requests.\n+port        ENV.fetch(\"PORT\") { 3000 }","path":"config/puma.rb","position":20,"original_position":20,"commit_id":"a3695af129fab9a6b9b362f80e29c40c3b9515c7","original_commit_id":"a3695af129fab9a6b9b362f80e29c40c3b9515c7","user":{"login":"SViccari","id":4016985,"node_id":"MDQ6VXNlcjQwMTY5ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/4016985?v=4","gravatar_id":"","url":"https://api.github.com/users/SViccari","html_url":"https://github.com/SViccari","followers_url":"https://api.github.com/users/SViccari/followers","following_url":"https://api.github.com/users/SViccari/following{/other_user}","gists_url":"https://api.github.com/users/SViccari/gists{/gist_id}","starred_url":"https://api.github.com/users/SViccari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SViccari/subscriptions","organizations_url":"https://api.github.com/users/SViccari/orgs","repos_url":"https://api.github.com/users/SViccari/repos","events_url":"https://api.github.com/users/SViccari/events{/privacy}","received_events_url":"https://api.github.com/users/SViccari/received_events","type":"User","site_admin":false},"body":"So many empty spaces 👾 👾 . Seems odd 🤔 ","created_at":"2018-10-04T13:47:57Z","updated_at":"2018-10-04T13:47:57Z","html_url":"https://github.com/bostonrb/bostonrb.org/pull/39#discussion_r222675564","pull_request_url":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/39","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/comments/222675564"},"html":{"href":"https://github.com/bostonrb/bostonrb.org/pull/39#discussion_r222675564"},"pull_request":{"href":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/39","id":220112725,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTEyNzI1","html_url":"https://github.com/bostonrb/bostonrb.org/pull/39","diff_url":"https://github.com/bostonrb/bostonrb.org/pull/39.diff","patch_url":"https://github.com/bostonrb/bostonrb.org/pull/39.patch","issue_url":"https://api.github.com/repos/bostonrb/bostonrb.org/issues/39","number":39,"state":"open","locked":false,"title":"Update rails to version 5.2, and misc version bumps to get there","user":{"login":"mjankowski","id":225,"node_id":"MDQ6VXNlcjIyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/225?v=4","gravatar_id":"","url":"https://api.github.com/users/mjankowski","html_url":"https://github.com/mjankowski","followers_url":"https://api.github.com/users/mjankowski/followers","following_url":"https://api.github.com/users/mjankowski/following{/other_user}","gists_url":"https://api.github.com/users/mjankowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mjankowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjankowski/subscriptions","organizations_url":"https://api.github.com/users/mjankowski/orgs","repos_url":"https://api.github.com/users/mjankowski/repos","events_url":"https://api.github.com/users/mjankowski/events{/privacy}","received_events_url":"https://api.github.com/users/mjankowski/received_events","type":"User","site_admin":false},"body":"Summary:\r\n\r\n- Rails updated from 5.1 to 5.2\r\n- Misc config/ and bin/ changes as result of running `app:update` - I don't believe any of these actually changed any config options, they just shuffled the files in line with latest rails format/style\r\n- Misc gem version bumps prior to the rails update\r\n- Added bootsnap gem as part of 5.2 update","created_at":"2018-10-03T17:08:11Z","updated_at":"2018-10-04T13:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72f863037e2410046d907b5703841370f83dce36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/39/commits","review_comments_url":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/39/comments","review_comment_url":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bostonrb/bostonrb.org/issues/39/comments","statuses_url":"https://api.github.com/repos/bostonrb/bostonrb.org/statuses/a3695af129fab9a6b9b362f80e29c40c3b9515c7","head":{"label":"mjankowski:versions","ref":"versions","sha":"a3695af129fab9a6b9b362f80e29c40c3b9515c7","user":{"login":"mjankowski","id":225,"node_id":"MDQ6VXNlcjIyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/225?v=4","gravatar_id":"","url":"https://api.github.com/users/mjankowski","html_url":"https://github.com/mjankowski","followers_url":"https://api.github.com/users/mjankowski/followers","following_url":"https://api.github.com/users/mjankowski/following{/other_user}","gists_url":"https://api.github.com/users/mjankowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mjankowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjankowski/subscriptions","organizations_url":"https://api.github.com/users/mjankowski/orgs","repos_url":"https://api.github.com/users/mjankowski/repos","events_url":"https://api.github.com/users/mjankowski/events{/privacy}","received_events_url":"https://api.github.com/users/mjankowski/received_events","type":"User","site_admin":false},"repo":{"id":151440178,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE0NDAxNzg=","name":"bostonrb.org","full_name":"mjankowski/bostonrb.org","private":false,"owner":{"login":"mjankowski","id":225,"node_id":"MDQ6VXNlcjIyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/225?v=4","gravatar_id":"","url":"https://api.github.com/users/mjankowski","html_url":"https://github.com/mjankowski","followers_url":"https://api.github.com/users/mjankowski/followers","following_url":"https://api.github.com/users/mjankowski/following{/other_user}","gists_url":"https://api.github.com/users/mjankowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mjankowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjankowski/subscriptions","organizations_url":"https://api.github.com/users/mjankowski/orgs","repos_url":"https://api.github.com/users/mjankowski/repos","events_url":"https://api.github.com/users/mjankowski/events{/privacy}","received_events_url":"https://api.github.com/users/mjankowski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mjankowski/bostonrb.org","description":"BostonRB Website","fork":true,"url":"https://api.github.com/repos/mjankowski/bostonrb.org","forks_url":"https://api.github.com/repos/mjankowski/bostonrb.org/forks","keys_url":"https://api.github.com/repos/mjankowski/bostonrb.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjankowski/bostonrb.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjankowski/bostonrb.org/teams","hooks_url":"https://api.github.com/repos/mjankowski/bostonrb.org/hooks","issue_events_url":"https://api.github.com/repos/mjankowski/bostonrb.org/issues/events{/number}","events_url":"https://api.github.com/repos/mjankowski/bostonrb.org/events","assignees_url":"https://api.github.com/repos/mjankowski/bostonrb.org/assignees{/user}","branches_url":"https://api.github.com/repos/mjankowski/bostonrb.org/branches{/branch}","tags_url":"https://api.github.com/repos/mjankowski/bostonrb.org/tags","blobs_url":"https://api.github.com/repos/mjankowski/bostonrb.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjankowski/bostonrb.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjankowski/bostonrb.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjankowski/bostonrb.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjankowski/bostonrb.org/statuses/{sha}","languages_url":"https://api.github.com/repos/mjankowski/bostonrb.org/languages","stargazers_url":"https://api.github.com/repos/mjankowski/bostonrb.org/stargazers","contributors_url":"https://api.github.com/repos/mjankowski/bostonrb.org/contributors","subscribers_url":"https://api.github.com/repos/mjankowski/bostonrb.org/subscribers","subscription_url":"https://api.github.com/repos/mjankowski/bostonrb.org/subscription","commits_url":"https://api.github.com/repos/mjankowski/bostonrb.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjankowski/bostonrb.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjankowski/bostonrb.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjankowski/bostonrb.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjankowski/bostonrb.org/contents/{+path}","compare_url":"https://api.github.com/repos/mjankowski/bostonrb.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjankowski/bostonrb.org/merges","archive_url":"https://api.github.com/repos/mjankowski/bostonrb.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjankowski/bostonrb.org/downloads","issues_url":"https://api.github.com/repos/mjankowski/bostonrb.org/issues{/number}","pulls_url":"https://api.github.com/repos/mjankowski/bostonrb.org/pulls{/number}","milestones_url":"https://api.github.com/repos/mjankowski/bostonrb.org/milestones{/number}","notifications_url":"https://api.github.com/repos/mjankowski/bostonrb.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjankowski/bostonrb.org/labels{/name}","releases_url":"https://api.github.com/repos/mjankowski/bostonrb.org/releases{/id}","deployments_url":"https://api.github.com/repos/mjankowski/bostonrb.org/deployments","created_at":"2018-10-03T15:59:05Z","updated_at":"2018-10-03T15:59:07Z","pushed_at":"2018-10-03T16:00:01Z","git_url":"git://github.com/mjankowski/bostonrb.org.git","ssh_url":"git@github.com:mjankowski/bostonrb.org.git","clone_url":"https://github.com/mjankowski/bostonrb.org.git","svn_url":"https://github.com/mjankowski/bostonrb.org","homepage":"http://staging.bostonrb.org","size":4207,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bostonrb:master","ref":"master","sha":"8eee2a55bdc19203268dd3cdbdc9f88b6096ed2d","user":{"login":"bostonrb","id":11708,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzA4","avatar_url":"https://avatars0.githubusercontent.com/u/11708?v=4","gravatar_id":"","url":"https://api.github.com/users/bostonrb","html_url":"https://github.com/bostonrb","followers_url":"https://api.github.com/users/bostonrb/followers","following_url":"https://api.github.com/users/bostonrb/following{/other_user}","gists_url":"https://api.github.com/users/bostonrb/gists{/gist_id}","starred_url":"https://api.github.com/users/bostonrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bostonrb/subscriptions","organizations_url":"https://api.github.com/users/bostonrb/orgs","repos_url":"https://api.github.com/users/bostonrb/repos","events_url":"https://api.github.com/users/bostonrb/events{/privacy}","received_events_url":"https://api.github.com/users/bostonrb/received_events","type":"Organization","site_admin":false},"repo":{"id":117277851,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcyNzc4NTE=","name":"bostonrb.org","full_name":"bostonrb/bostonrb.org","private":false,"owner":{"login":"bostonrb","id":11708,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzA4","avatar_url":"https://avatars0.githubusercontent.com/u/11708?v=4","gravatar_id":"","url":"https://api.github.com/users/bostonrb","html_url":"https://github.com/bostonrb","followers_url":"https://api.github.com/users/bostonrb/followers","following_url":"https://api.github.com/users/bostonrb/following{/other_user}","gists_url":"https://api.github.com/users/bostonrb/gists{/gist_id}","starred_url":"https://api.github.com/users/bostonrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bostonrb/subscriptions","organizations_url":"https://api.github.com/users/bostonrb/orgs","repos_url":"https://api.github.com/users/bostonrb/repos","events_url":"https://api.github.com/users/bostonrb/events{/privacy}","received_events_url":"https://api.github.com/users/bostonrb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bostonrb/bostonrb.org","description":"BostonRB Website","fork":false,"url":"https://api.github.com/repos/bostonrb/bostonrb.org","forks_url":"https://api.github.com/repos/bostonrb/bostonrb.org/forks","keys_url":"https://api.github.com/repos/bostonrb/bostonrb.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bostonrb/bostonrb.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bostonrb/bostonrb.org/teams","hooks_url":"https://api.github.com/repos/bostonrb/bostonrb.org/hooks","issue_events_url":"https://api.github.com/repos/bostonrb/bostonrb.org/issues/events{/number}","events_url":"https://api.github.com/repos/bostonrb/bostonrb.org/events","assignees_url":"https://api.github.com/repos/bostonrb/bostonrb.org/assignees{/user}","branches_url":"https://api.github.com/repos/bostonrb/bostonrb.org/branches{/branch}","tags_url":"https://api.github.com/repos/bostonrb/bostonrb.org/tags","blobs_url":"https://api.github.com/repos/bostonrb/bostonrb.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bostonrb/bostonrb.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bostonrb/bostonrb.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/bostonrb/bostonrb.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bostonrb/bostonrb.org/statuses/{sha}","languages_url":"https://api.github.com/repos/bostonrb/bostonrb.org/languages","stargazers_url":"https://api.github.com/repos/bostonrb/bostonrb.org/stargazers","contributors_url":"https://api.github.com/repos/bostonrb/bostonrb.org/contributors","subscribers_url":"https://api.github.com/repos/bostonrb/bostonrb.org/subscribers","subscription_url":"https://api.github.com/repos/bostonrb/bostonrb.org/subscription","commits_url":"https://api.github.com/repos/bostonrb/bostonrb.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/bostonrb/bostonrb.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/bostonrb/bostonrb.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/bostonrb/bostonrb.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/bostonrb/bostonrb.org/contents/{+path}","compare_url":"https://api.github.com/repos/bostonrb/bostonrb.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bostonrb/bostonrb.org/merges","archive_url":"https://api.github.com/repos/bostonrb/bostonrb.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bostonrb/bostonrb.org/downloads","issues_url":"https://api.github.com/repos/bostonrb/bostonrb.org/issues{/number}","pulls_url":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls{/number}","milestones_url":"https://api.github.com/repos/bostonrb/bostonrb.org/milestones{/number}","notifications_url":"https://api.github.com/repos/bostonrb/bostonrb.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bostonrb/bostonrb.org/labels{/name}","releases_url":"https://api.github.com/repos/bostonrb/bostonrb.org/releases{/id}","deployments_url":"https://api.github.com/repos/bostonrb/bostonrb.org/deployments","created_at":"2018-01-12T19:03:00Z","updated_at":"2018-10-03T18:28:40Z","pushed_at":"2018-10-03T20:42:10Z","git_url":"git://github.com/bostonrb/bostonrb.org.git","ssh_url":"git@github.com:bostonrb/bostonrb.org.git","clone_url":"https://github.com/bostonrb/bostonrb.org.git","svn_url":"https://github.com/bostonrb/bostonrb.org","homepage":"http://staging.bostonrb.org","size":4214,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/39"},"html":{"href":"https://github.com/bostonrb/bostonrb.org/pull/39"},"issue":{"href":"https://api.github.com/repos/bostonrb/bostonrb.org/issues/39"},"comments":{"href":"https://api.github.com/repos/bostonrb/bostonrb.org/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bostonrb/bostonrb.org/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/bostonrb/bostonrb.org/statuses/a3695af129fab9a6b9b362f80e29c40c3b9515c7"}},"author_association":"NONE"}}
{"actor":{"display_login":"SViccari"}}