{"action":"created","comment":{"url":"https://api.github.com/repos/habitat-sh/core-plans/pulls/comments/233189147","pull_request_review_id":174545056,"id":233189147,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE4OTE0Nw==","diff_hunk":"@@ -139,6 +139,7 @@ interval = 1800\n splay = 180\n run_lock_timeout = 1800\n log_level = \"warn\"\n+chef_client_ident = \"\" # this is blank by default so it can be populated from the bind","path":"scaffolding-chef/lib/scaffolding.sh","position":4,"original_position":4,"commit_id":"c896c99894986c51dc2dd1df1c98e7c894813b52","original_commit_id":"c896c99894986c51dc2dd1df1c98e7c894813b52","user":{"login":"jeremymv2","id":1991696,"node_id":"MDQ6VXNlcjE5OTE2OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1991696?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremymv2","html_url":"https://github.com/jeremymv2","followers_url":"https://api.github.com/users/jeremymv2/followers","following_url":"https://api.github.com/users/jeremymv2/following{/other_user}","gists_url":"https://api.github.com/users/jeremymv2/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremymv2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremymv2/subscriptions","organizations_url":"https://api.github.com/users/jeremymv2/orgs","repos_url":"https://api.github.com/users/jeremymv2/repos","events_url":"https://api.github.com/users/jeremymv2/events{/privacy}","received_events_url":"https://api.github.com/users/jeremymv2/received_events","type":"User","site_admin":false},"body":"Ahh ok, that makes sense. 👍 ","created_at":"2018-11-13T19:26:01Z","updated_at":"2018-11-13T19:26:01Z","html_url":"https://github.com/habitat-sh/core-plans/pull/1987#discussion_r233189147","pull_request_url":"https://api.github.com/repos/habitat-sh/core-plans/pulls/1987","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/habitat-sh/core-plans/pulls/comments/233189147"},"html":{"href":"https://github.com/habitat-sh/core-plans/pull/1987#discussion_r233189147"},"pull_request":{"href":"https://api.github.com/repos/habitat-sh/core-plans/pulls/1987"}},"in_reply_to_id":233182107},"pull_request":{"url":"https://api.github.com/repos/habitat-sh/core-plans/pulls/1987","id":230587185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTg3MTg1","html_url":"https://github.com/habitat-sh/core-plans/pull/1987","diff_url":"https://github.com/habitat-sh/core-plans/pull/1987.diff","patch_url":"https://github.com/habitat-sh/core-plans/pull/1987.patch","issue_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/1987","number":1987,"state":"open","locked":false,"title":"[scaffolding-chef] bugfix to add default value for bind in default.toml","user":{"login":"echohack","id":3253989,"node_id":"MDQ6VXNlcjMyNTM5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/3253989?v=4","gravatar_id":"","url":"https://api.github.com/users/echohack","html_url":"https://github.com/echohack","followers_url":"https://api.github.com/users/echohack/followers","following_url":"https://api.github.com/users/echohack/following{/other_user}","gists_url":"https://api.github.com/users/echohack/gists{/gist_id}","starred_url":"https://api.github.com/users/echohack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echohack/subscriptions","organizations_url":"https://api.github.com/users/echohack/orgs","repos_url":"https://api.github.com/users/echohack/repos","events_url":"https://api.github.com/users/echohack/events{/privacy}","received_events_url":"https://api.github.com/users/echohack/received_events","type":"User","site_admin":false},"body":"Signed-off-by: echohack <echohack@users.noreply.github.com>\r\n\r\nShortly after merging #1985, I realized that some people are deleting their default.toml, and it was required by the scaffolding to provide a default for `chef_client_ident`. In this case, empty string is the best option, since we don't want to assume any previous values.\r\n\r\n\r\nThank you @robbkidd for the additional details here:\r\n\r\n- In #1985, chef_client_ident is set to the pkg.ident of the package using the Chef scaffolding.\r\n- pkg.ident is the fully qualified identifier for a Habitat package—origin/name/version/release—so this is expected to change whenever a new release of a Chef package has started up in an existing service group.\r\n- The config version_number advances and the value of the chef_client_ident bind changes when the scaffold-generated run hook fires which will be the trigger for a bound Habitat service to restart and rerun its own run hook.\r\n","created_at":"2018-11-13T18:53:45Z","updated_at":"2018-11-13T19:26:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0e728dddab358ea9e3e8c6f2f1d188737b14114","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"scaffolding-maintainers","id":2497907,"node_id":"MDQ6VGVhbTI0OTc5MDc=","slug":"scaffolding-maintainers","description":"","privacy":"closed","url":"https://api.github.com/teams/2497907","members_url":"https://api.github.com/teams/2497907/members{/member}","repositories_url":"https://api.github.com/teams/2497907/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/habitat-sh/core-plans/pulls/1987/commits","review_comments_url":"https://api.github.com/repos/habitat-sh/core-plans/pulls/1987/comments","review_comment_url":"https://api.github.com/repos/habitat-sh/core-plans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/1987/comments","statuses_url":"https://api.github.com/repos/habitat-sh/core-plans/statuses/c896c99894986c51dc2dd1df1c98e7c894813b52","head":{"label":"echohack:add_default_chef_client_ident","ref":"add_default_chef_client_ident","sha":"c896c99894986c51dc2dd1df1c98e7c894813b52","user":{"login":"echohack","id":3253989,"node_id":"MDQ6VXNlcjMyNTM5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/3253989?v=4","gravatar_id":"","url":"https://api.github.com/users/echohack","html_url":"https://github.com/echohack","followers_url":"https://api.github.com/users/echohack/followers","following_url":"https://api.github.com/users/echohack/following{/other_user}","gists_url":"https://api.github.com/users/echohack/gists{/gist_id}","starred_url":"https://api.github.com/users/echohack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echohack/subscriptions","organizations_url":"https://api.github.com/users/echohack/orgs","repos_url":"https://api.github.com/users/echohack/repos","events_url":"https://api.github.com/users/echohack/events{/privacy}","received_events_url":"https://api.github.com/users/echohack/received_events","type":"User","site_admin":false},"repo":{"id":106574639,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY1NzQ2Mzk=","name":"core-plans","full_name":"echohack/core-plans","private":false,"owner":{"login":"echohack","id":3253989,"node_id":"MDQ6VXNlcjMyNTM5ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/3253989?v=4","gravatar_id":"","url":"https://api.github.com/users/echohack","html_url":"https://github.com/echohack","followers_url":"https://api.github.com/users/echohack/followers","following_url":"https://api.github.com/users/echohack/following{/other_user}","gists_url":"https://api.github.com/users/echohack/gists{/gist_id}","starred_url":"https://api.github.com/users/echohack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echohack/subscriptions","organizations_url":"https://api.github.com/users/echohack/orgs","repos_url":"https://api.github.com/users/echohack/repos","events_url":"https://api.github.com/users/echohack/events{/privacy}","received_events_url":"https://api.github.com/users/echohack/received_events","type":"User","site_admin":false},"html_url":"https://github.com/echohack/core-plans","description":"Core Habitat Plan definitions","fork":true,"url":"https://api.github.com/repos/echohack/core-plans","forks_url":"https://api.github.com/repos/echohack/core-plans/forks","keys_url":"https://api.github.com/repos/echohack/core-plans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/echohack/core-plans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/echohack/core-plans/teams","hooks_url":"https://api.github.com/repos/echohack/core-plans/hooks","issue_events_url":"https://api.github.com/repos/echohack/core-plans/issues/events{/number}","events_url":"https://api.github.com/repos/echohack/core-plans/events","assignees_url":"https://api.github.com/repos/echohack/core-plans/assignees{/user}","branches_url":"https://api.github.com/repos/echohack/core-plans/branches{/branch}","tags_url":"https://api.github.com/repos/echohack/core-plans/tags","blobs_url":"https://api.github.com/repos/echohack/core-plans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/echohack/core-plans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/echohack/core-plans/git/refs{/sha}","trees_url":"https://api.github.com/repos/echohack/core-plans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/echohack/core-plans/statuses/{sha}","languages_url":"https://api.github.com/repos/echohack/core-plans/languages","stargazers_url":"https://api.github.com/repos/echohack/core-plans/stargazers","contributors_url":"https://api.github.com/repos/echohack/core-plans/contributors","subscribers_url":"https://api.github.com/repos/echohack/core-plans/subscribers","subscription_url":"https://api.github.com/repos/echohack/core-plans/subscription","commits_url":"https://api.github.com/repos/echohack/core-plans/commits{/sha}","git_commits_url":"https://api.github.com/repos/echohack/core-plans/git/commits{/sha}","comments_url":"https://api.github.com/repos/echohack/core-plans/comments{/number}","issue_comment_url":"https://api.github.com/repos/echohack/core-plans/issues/comments{/number}","contents_url":"https://api.github.com/repos/echohack/core-plans/contents/{+path}","compare_url":"https://api.github.com/repos/echohack/core-plans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/echohack/core-plans/merges","archive_url":"https://api.github.com/repos/echohack/core-plans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/echohack/core-plans/downloads","issues_url":"https://api.github.com/repos/echohack/core-plans/issues{/number}","pulls_url":"https://api.github.com/repos/echohack/core-plans/pulls{/number}","milestones_url":"https://api.github.com/repos/echohack/core-plans/milestones{/number}","notifications_url":"https://api.github.com/repos/echohack/core-plans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/echohack/core-plans/labels{/name}","releases_url":"https://api.github.com/repos/echohack/core-plans/releases{/id}","deployments_url":"https://api.github.com/repos/echohack/core-plans/deployments","created_at":"2017-10-11T15:45:11Z","updated_at":"2018-11-13T18:47:54Z","pushed_at":"2018-11-13T18:51:33Z","git_url":"git://github.com/echohack/core-plans.git","ssh_url":"git@github.com:echohack/core-plans.git","clone_url":"https://github.com/echohack/core-plans.git","svn_url":"https://github.com/echohack/core-plans","homepage":"","size":15497,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"habitat-sh:master","ref":"master","sha":"e027dd66440a66a96ede78952bd5d842641084eb","user":{"login":"habitat-sh","id":18171698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTcxNjk4","avatar_url":"https://avatars0.githubusercontent.com/u/18171698?v=4","gravatar_id":"","url":"https://api.github.com/users/habitat-sh","html_url":"https://github.com/habitat-sh","followers_url":"https://api.github.com/users/habitat-sh/followers","following_url":"https://api.github.com/users/habitat-sh/following{/other_user}","gists_url":"https://api.github.com/users/habitat-sh/gists{/gist_id}","starred_url":"https://api.github.com/users/habitat-sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/habitat-sh/subscriptions","organizations_url":"https://api.github.com/users/habitat-sh/orgs","repos_url":"https://api.github.com/users/habitat-sh/repos","events_url":"https://api.github.com/users/habitat-sh/events{/privacy}","received_events_url":"https://api.github.com/users/habitat-sh/received_events","type":"Organization","site_admin":false},"repo":{"id":46349776,"node_id":"MDEwOlJlcG9zaXRvcnk0NjM0OTc3Ng==","name":"core-plans","full_name":"habitat-sh/core-plans","private":false,"owner":{"login":"habitat-sh","id":18171698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTcxNjk4","avatar_url":"https://avatars0.githubusercontent.com/u/18171698?v=4","gravatar_id":"","url":"https://api.github.com/users/habitat-sh","html_url":"https://github.com/habitat-sh","followers_url":"https://api.github.com/users/habitat-sh/followers","following_url":"https://api.github.com/users/habitat-sh/following{/other_user}","gists_url":"https://api.github.com/users/habitat-sh/gists{/gist_id}","starred_url":"https://api.github.com/users/habitat-sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/habitat-sh/subscriptions","organizations_url":"https://api.github.com/users/habitat-sh/orgs","repos_url":"https://api.github.com/users/habitat-sh/repos","events_url":"https://api.github.com/users/habitat-sh/events{/privacy}","received_events_url":"https://api.github.com/users/habitat-sh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/habitat-sh/core-plans","description":"Core Habitat Plan definitions","fork":false,"url":"https://api.github.com/repos/habitat-sh/core-plans","forks_url":"https://api.github.com/repos/habitat-sh/core-plans/forks","keys_url":"https://api.github.com/repos/habitat-sh/core-plans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/habitat-sh/core-plans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/habitat-sh/core-plans/teams","hooks_url":"https://api.github.com/repos/habitat-sh/core-plans/hooks","issue_events_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/events{/number}","events_url":"https://api.github.com/repos/habitat-sh/core-plans/events","assignees_url":"https://api.github.com/repos/habitat-sh/core-plans/assignees{/user}","branches_url":"https://api.github.com/repos/habitat-sh/core-plans/branches{/branch}","tags_url":"https://api.github.com/repos/habitat-sh/core-plans/tags","blobs_url":"https://api.github.com/repos/habitat-sh/core-plans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/habitat-sh/core-plans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/habitat-sh/core-plans/git/refs{/sha}","trees_url":"https://api.github.com/repos/habitat-sh/core-plans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/habitat-sh/core-plans/statuses/{sha}","languages_url":"https://api.github.com/repos/habitat-sh/core-plans/languages","stargazers_url":"https://api.github.com/repos/habitat-sh/core-plans/stargazers","contributors_url":"https://api.github.com/repos/habitat-sh/core-plans/contributors","subscribers_url":"https://api.github.com/repos/habitat-sh/core-plans/subscribers","subscription_url":"https://api.github.com/repos/habitat-sh/core-plans/subscription","commits_url":"https://api.github.com/repos/habitat-sh/core-plans/commits{/sha}","git_commits_url":"https://api.github.com/repos/habitat-sh/core-plans/git/commits{/sha}","comments_url":"https://api.github.com/repos/habitat-sh/core-plans/comments{/number}","issue_comment_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/comments{/number}","contents_url":"https://api.github.com/repos/habitat-sh/core-plans/contents/{+path}","compare_url":"https://api.github.com/repos/habitat-sh/core-plans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/habitat-sh/core-plans/merges","archive_url":"https://api.github.com/repos/habitat-sh/core-plans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/habitat-sh/core-plans/downloads","issues_url":"https://api.github.com/repos/habitat-sh/core-plans/issues{/number}","pulls_url":"https://api.github.com/repos/habitat-sh/core-plans/pulls{/number}","milestones_url":"https://api.github.com/repos/habitat-sh/core-plans/milestones{/number}","notifications_url":"https://api.github.com/repos/habitat-sh/core-plans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/habitat-sh/core-plans/labels{/name}","releases_url":"https://api.github.com/repos/habitat-sh/core-plans/releases{/id}","deployments_url":"https://api.github.com/repos/habitat-sh/core-plans/deployments","created_at":"2015-11-17T13:45:46Z","updated_at":"2018-11-13T18:37:15Z","pushed_at":"2018-11-13T18:53:46Z","git_url":"git://github.com/habitat-sh/core-plans.git","ssh_url":"git@github.com:habitat-sh/core-plans.git","clone_url":"https://github.com/habitat-sh/core-plans.git","svn_url":"https://github.com/habitat-sh/core-plans","homepage":"","size":15705,"stargazers_count":98,"watchers_count":98,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":203,"mirror_url":null,"archived":false,"open_issues_count":132,"license":null,"forks":203,"open_issues":132,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/habitat-sh/core-plans/pulls/1987"},"html":{"href":"https://github.com/habitat-sh/core-plans/pull/1987"},"issue":{"href":"https://api.github.com/repos/habitat-sh/core-plans/issues/1987"},"comments":{"href":"https://api.github.com/repos/habitat-sh/core-plans/issues/1987/comments"},"review_comments":{"href":"https://api.github.com/repos/habitat-sh/core-plans/pulls/1987/comments"},"review_comment":{"href":"https://api.github.com/repos/habitat-sh/core-plans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/habitat-sh/core-plans/pulls/1987/commits"},"statuses":{"href":"https://api.github.com/repos/habitat-sh/core-plans/statuses/c896c99894986c51dc2dd1df1c98e7c894813b52"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeremymv2"}}