{"action":"created","comment":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/comments/217108185","pull_request_review_id":154744201,"id":217108185,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzEwODE4NQ==","diff_hunk":"@@ -21,12 +21,18 @@ public FindSymbolsHandler(OmniSharpWorkspace workspace)\n \n         public override Task<QuickFixResponse> Handle(FindSymbolsRequest request)\n         {\n+            if (request != null && request.Filter != null && request.Filter.Length < request.MinFilterLength)","path":"src/OmniSharp.Cake/Services/RequestHandlers/Navigation/FindSymbolsHandler.cs","position":4,"original_position":4,"commit_id":"6a4bf261c781794343ad2d288b0e343b6eacfce5","original_commit_id":"6a4bf261c781794343ad2d288b0e343b6eacfce5","user":{"login":"rchande","id":3751401,"node_id":"MDQ6VXNlcjM3NTE0MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/3751401?v=4","gravatar_id":"","url":"https://api.github.com/users/rchande","html_url":"https://github.com/rchande","followers_url":"https://api.github.com/users/rchande/followers","following_url":"https://api.github.com/users/rchande/following{/other_user}","gists_url":"https://api.github.com/users/rchande/gists{/gist_id}","starred_url":"https://api.github.com/users/rchande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchande/subscriptions","organizations_url":"https://api.github.com/users/rchande/orgs","repos_url":"https://api.github.com/users/rchande/repos","events_url":"https://api.github.com/users/rchande/events{/privacy}","received_events_url":"https://api.github.com/users/rchande/received_events","type":"User","site_admin":false},"body":"This changes how the API works, so we probably need to implement this as a V2 API","created_at":"2018-09-12T16:46:35Z","updated_at":"2018-09-12T16:50:18Z","html_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/1284#discussion_r217108185","pull_request_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/1284","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/comments/217108185"},"html":{"href":"https://github.com/OmniSharp/omnisharp-roslyn/pull/1284#discussion_r217108185"},"pull_request":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/1284"}}},"pull_request":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/1284","id":212629436,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNjI5NDM2","html_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/1284","diff_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/1284.diff","patch_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/1284.patch","issue_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/1284","number":1284,"state":"open","locked":false,"title":"Introduce configuration for \"Go to Symbol in Workspace\"","user":{"login":"dmgonch","id":30739723,"node_id":"MDQ6VXNlcjMwNzM5NzIz","avatar_url":"https://avatars2.githubusercontent.com/u/30739723?v=4","gravatar_id":"","url":"https://api.github.com/users/dmgonch","html_url":"https://github.com/dmgonch","followers_url":"https://api.github.com/users/dmgonch/followers","following_url":"https://api.github.com/users/dmgonch/following{/other_user}","gists_url":"https://api.github.com/users/dmgonch/gists{/gist_id}","starred_url":"https://api.github.com/users/dmgonch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmgonch/subscriptions","organizations_url":"https://api.github.com/users/dmgonch/orgs","repos_url":"https://api.github.com/users/dmgonch/repos","events_url":"https://api.github.com/users/dmgonch/events{/privacy}","received_events_url":"https://api.github.com/users/dmgonch/received_events","type":"User","site_admin":false},"body":"Allow configuring number of chars user must to type in for \"Go to Symbol in Workspace\" command to return any results (default is 0 to preserve existing behavior). The reasoning here is that when lots of projects are loaded by OmniSharp it makes little sense to return all symbols discovered. This change should largely address these issues as well: https://github.com/OmniSharp/omnisharp-roslyn/issues/1243, https://github.com/OmniSharp/omnisharp-vscode/issues/1808.\r\nAdditionally allow configuring max number of items returned by \"Go to Symbol in Workspace\" command. Similarly to the above in a big repo returning pages and pages of items in most cases will be wasteful. But default is 0 which is indicates no limit to preserve existing behavior.","created_at":"2018-09-03T02:49:08Z","updated_at":"2018-09-12T16:50:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"998321b31ee26108a03c093c13351ade966cac91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/1284/commits","review_comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/1284/comments","review_comment_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/1284/comments","statuses_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/statuses/6a4bf261c781794343ad2d288b0e343b6eacfce5","head":{"label":"dmgonch:feature/minFindSymbolsFilterLength","ref":"feature/minFindSymbolsFilterLength","sha":"6a4bf261c781794343ad2d288b0e343b6eacfce5","user":{"login":"dmgonch","id":30739723,"node_id":"MDQ6VXNlcjMwNzM5NzIz","avatar_url":"https://avatars2.githubusercontent.com/u/30739723?v=4","gravatar_id":"","url":"https://api.github.com/users/dmgonch","html_url":"https://github.com/dmgonch","followers_url":"https://api.github.com/users/dmgonch/followers","following_url":"https://api.github.com/users/dmgonch/following{/other_user}","gists_url":"https://api.github.com/users/dmgonch/gists{/gist_id}","starred_url":"https://api.github.com/users/dmgonch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmgonch/subscriptions","organizations_url":"https://api.github.com/users/dmgonch/orgs","repos_url":"https://api.github.com/users/dmgonch/repos","events_url":"https://api.github.com/users/dmgonch/events{/privacy}","received_events_url":"https://api.github.com/users/dmgonch/received_events","type":"User","site_admin":false},"repo":{"id":131432015,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE0MzIwMTU=","name":"oms-r","full_name":"dmgonch/oms-r","owner":{"login":"dmgonch","id":30739723,"node_id":"MDQ6VXNlcjMwNzM5NzIz","avatar_url":"https://avatars2.githubusercontent.com/u/30739723?v=4","gravatar_id":"","url":"https://api.github.com/users/dmgonch","html_url":"https://github.com/dmgonch","followers_url":"https://api.github.com/users/dmgonch/followers","following_url":"https://api.github.com/users/dmgonch/following{/other_user}","gists_url":"https://api.github.com/users/dmgonch/gists{/gist_id}","starred_url":"https://api.github.com/users/dmgonch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmgonch/subscriptions","organizations_url":"https://api.github.com/users/dmgonch/orgs","repos_url":"https://api.github.com/users/dmgonch/repos","events_url":"https://api.github.com/users/dmgonch/events{/privacy}","received_events_url":"https://api.github.com/users/dmgonch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmgonch/oms-r","description":"oms-r","fork":true,"url":"https://api.github.com/repos/dmgonch/oms-r","forks_url":"https://api.github.com/repos/dmgonch/oms-r/forks","keys_url":"https://api.github.com/repos/dmgonch/oms-r/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmgonch/oms-r/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmgonch/oms-r/teams","hooks_url":"https://api.github.com/repos/dmgonch/oms-r/hooks","issue_events_url":"https://api.github.com/repos/dmgonch/oms-r/issues/events{/number}","events_url":"https://api.github.com/repos/dmgonch/oms-r/events","assignees_url":"https://api.github.com/repos/dmgonch/oms-r/assignees{/user}","branches_url":"https://api.github.com/repos/dmgonch/oms-r/branches{/branch}","tags_url":"https://api.github.com/repos/dmgonch/oms-r/tags","blobs_url":"https://api.github.com/repos/dmgonch/oms-r/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmgonch/oms-r/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmgonch/oms-r/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmgonch/oms-r/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmgonch/oms-r/statuses/{sha}","languages_url":"https://api.github.com/repos/dmgonch/oms-r/languages","stargazers_url":"https://api.github.com/repos/dmgonch/oms-r/stargazers","contributors_url":"https://api.github.com/repos/dmgonch/oms-r/contributors","subscribers_url":"https://api.github.com/repos/dmgonch/oms-r/subscribers","subscription_url":"https://api.github.com/repos/dmgonch/oms-r/subscription","commits_url":"https://api.github.com/repos/dmgonch/oms-r/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmgonch/oms-r/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmgonch/oms-r/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmgonch/oms-r/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmgonch/oms-r/contents/{+path}","compare_url":"https://api.github.com/repos/dmgonch/oms-r/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmgonch/oms-r/merges","archive_url":"https://api.github.com/repos/dmgonch/oms-r/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmgonch/oms-r/downloads","issues_url":"https://api.github.com/repos/dmgonch/oms-r/issues{/number}","pulls_url":"https://api.github.com/repos/dmgonch/oms-r/pulls{/number}","milestones_url":"https://api.github.com/repos/dmgonch/oms-r/milestones{/number}","notifications_url":"https://api.github.com/repos/dmgonch/oms-r/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmgonch/oms-r/labels{/name}","releases_url":"https://api.github.com/repos/dmgonch/oms-r/releases{/id}","deployments_url":"https://api.github.com/repos/dmgonch/oms-r/deployments","created_at":"2018-04-28T17:56:24Z","updated_at":"2018-08-20T02:49:34Z","pushed_at":"2018-09-11T23:38:41Z","git_url":"git://github.com/dmgonch/oms-r.git","ssh_url":"git@github.com:dmgonch/oms-r.git","clone_url":"https://github.com/dmgonch/oms-r.git","svn_url":"https://github.com/dmgonch/oms-r","homepage":"","size":8115,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OmniSharp:master","ref":"master","sha":"5c779523aad3f2de6308f1b66d2169a951af3c26","user":{"login":"OmniSharp","id":9420663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0MjA2NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/9420663?v=4","gravatar_id":"","url":"https://api.github.com/users/OmniSharp","html_url":"https://github.com/OmniSharp","followers_url":"https://api.github.com/users/OmniSharp/followers","following_url":"https://api.github.com/users/OmniSharp/following{/other_user}","gists_url":"https://api.github.com/users/OmniSharp/gists{/gist_id}","starred_url":"https://api.github.com/users/OmniSharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmniSharp/subscriptions","organizations_url":"https://api.github.com/users/OmniSharp/orgs","repos_url":"https://api.github.com/users/OmniSharp/repos","events_url":"https://api.github.com/users/OmniSharp/events{/privacy}","received_events_url":"https://api.github.com/users/OmniSharp/received_events","type":"Organization","site_admin":false},"repo":{"id":27927984,"node_id":"MDEwOlJlcG9zaXRvcnkyNzkyNzk4NA==","name":"omnisharp-roslyn","full_name":"OmniSharp/omnisharp-roslyn","owner":{"login":"OmniSharp","id":9420663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0MjA2NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/9420663?v=4","gravatar_id":"","url":"https://api.github.com/users/OmniSharp","html_url":"https://github.com/OmniSharp","followers_url":"https://api.github.com/users/OmniSharp/followers","following_url":"https://api.github.com/users/OmniSharp/following{/other_user}","gists_url":"https://api.github.com/users/OmniSharp/gists{/gist_id}","starred_url":"https://api.github.com/users/OmniSharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmniSharp/subscriptions","organizations_url":"https://api.github.com/users/OmniSharp/orgs","repos_url":"https://api.github.com/users/OmniSharp/repos","events_url":"https://api.github.com/users/OmniSharp/events{/privacy}","received_events_url":"https://api.github.com/users/OmniSharp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OmniSharp/omnisharp-roslyn","description":"OmniSharp based on roslyn workspaces","fork":false,"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn","forks_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/forks","keys_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/teams","hooks_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/hooks","issue_events_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/events","assignees_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/tags","blobs_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/languages","stargazers_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/stargazers","contributors_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/contributors","subscribers_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/subscribers","subscription_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/subscription","commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/merges","archive_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/downloads","issues_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/labels{/name}","releases_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/deployments","created_at":"2014-12-12T16:21:03Z","updated_at":"2018-09-12T02:59:56Z","pushed_at":"2018-09-12T13:44:51Z","git_url":"git://github.com/OmniSharp/omnisharp-roslyn.git","ssh_url":"git@github.com:OmniSharp/omnisharp-roslyn.git","clone_url":"https://github.com/OmniSharp/omnisharp-roslyn.git","svn_url":"https://github.com/OmniSharp/omnisharp-roslyn","homepage":"","size":8087,"stargazers_count":595,"watchers_count":595,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":214,"open_issues":202,"watchers":595,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/1284"},"html":{"href":"https://github.com/OmniSharp/omnisharp-roslyn/pull/1284"},"issue":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/1284"},"comments":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/1284/comments"},"review_comments":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/1284/comments"},"review_comment":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/1284/commits"},"statuses":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/statuses/6a4bf261c781794343ad2d288b0e343b6eacfce5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rchande"}}