{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments/195063717","pull_request_review_id":128354085,"id":195063717,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTA2MzcxNw==","diff_hunk":"@@ -473,19 +536,92 @@ export default class Renderer {\n \t * filler should be rendered.\n \t */\n \t_updateChildren( viewElement, options ) {\n+\t\tconst diff = this._diffElementChildren( viewElement,\n+\t\t\t{ inlineFillerPosition: options.inlineFillerPosition, bind: true, withChildren: true } );\n+\n+\t\tif ( diff ) {","path":"src/view/renderer.js","position":206,"original_position":204,"commit_id":"e0972462c8567c95f9a3696aaac5b8e35dda483d","original_commit_id":"3a8085fac79ed6fb71e6c80f4b36dab2ecdbb4e2","user":{"login":"f1ames","id":1061942,"node_id":"MDQ6VXNlcjEwNjE5NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1061942?v=4","gravatar_id":"","url":"https://api.github.com/users/f1ames","html_url":"https://github.com/f1ames","followers_url":"https://api.github.com/users/f1ames/followers","following_url":"https://api.github.com/users/f1ames/following{/other_user}","gists_url":"https://api.github.com/users/f1ames/gists{/gist_id}","starred_url":"https://api.github.com/users/f1ames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f1ames/subscriptions","organizations_url":"https://api.github.com/users/f1ames/orgs","repos_url":"https://api.github.com/users/f1ames/repos","events_url":"https://api.github.com/users/f1ames/events{/privacy}","received_events_url":"https://api.github.com/users/f1ames/received_events","type":"User","site_admin":false},"body":"> And – how is it possible that we call this method when its children are up to date?\r\n\r\nI'm not sure what you meant here? Do you have any particular case in mind?","created_at":"2018-06-13T12:34:40Z","updated_at":"2018-06-13T12:34:41Z","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1424#discussion_r195063717","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1424","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments/195063717"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/1424#discussion_r195063717"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1424"}},"in_reply_to_id":194754854},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1424","id":192008868,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDA4ODY4","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1424","diff_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1424.diff","patch_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1424.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1424","number":1424,"state":"open","locked":false,"title":"Avoid unnecessary DOM structure updates in renderer","user":{"login":"f1ames","id":1061942,"node_id":"MDQ6VXNlcjEwNjE5NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1061942?v=4","gravatar_id":"","url":"https://api.github.com/users/f1ames","html_url":"https://github.com/f1ames","followers_url":"https://api.github.com/users/f1ames/followers","following_url":"https://api.github.com/users/f1ames/following{/other_user}","gists_url":"https://api.github.com/users/f1ames/gists{/gist_id}","starred_url":"https://api.github.com/users/f1ames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f1ames/subscriptions","organizations_url":"https://api.github.com/users/f1ames/orgs","repos_url":"https://api.github.com/users/f1ames/repos","events_url":"https://api.github.com/users/f1ames/events{/privacy}","received_events_url":"https://api.github.com/users/f1ames/received_events","type":"User","site_admin":false},"body":"### Suggested merge commit message ([convention](https://github.com/ckeditor/ckeditor5-design/wiki/Git-commit-message-convention))\r\n\r\nFix: Avoid unnecessary DOM structure updates in `Renderer`. Closes #1417. Closes #1409. Closes #1349. Closes #1334. Closes #898. Closes ckeditor/ckeditor5-typing#129. Closes ckeditor/ckeditor5-typing#89. Closes #1427.\r\n\r\n---\r\n\r\n### Additional information\r\n\r\nSee the extensive comment about the implemented solution in https://github.com/ckeditor/ckeditor5-engine/issues/1417#issuecomment-393845235.\r\n\r\nThere is also one issue which I'm unable to reproduce (from the beginning) so we should definitely ping the person who reported it to recheck after this PR gets merged - https://github.com/ckeditor/ckeditor5/issues/748.","created_at":"2018-06-01T11:33:41Z","updated_at":"2018-06-13T12:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0716f66a5fd43848b09423372a065a939acd043","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":167749141,"node_id":"MDU6TGFiZWwxNjc3NDkxNDE=","url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels/status:review-","name":"status:review-","color":"ee6622","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1424/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1424/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1424/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/e0972462c8567c95f9a3696aaac5b8e35dda483d","head":{"label":"ckeditor:t/1417","ref":"t/1417","sha":"e0972462c8567c95f9a3696aaac5b8e35dda483d","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"node_id":"MDEwOlJlcG9zaXRvcnkyODk3Mjg5MA==","name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 editing engine.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2018-06-11T13:09:34Z","pushed_at":"2018-06-13T12:26:17Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"https://ckeditor.com","size":9768,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":185,"watchers":53,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"3e74554fa97741189050f7a4014ee6c558645cb8","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"node_id":"MDEwOlJlcG9zaXRvcnkyODk3Mjg5MA==","name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 editing engine.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2018-06-11T13:09:34Z","pushed_at":"2018-06-13T12:26:17Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"https://ckeditor.com","size":9768,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":185,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1424"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/1424"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1424"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1424/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1424/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1424/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/e0972462c8567c95f9a3696aaac5b8e35dda483d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"f1ames"}}