{"action":"created","comment":{"url":"https://api.github.com/repos/apache/libcloud/pulls/comments/192599591","pull_request_review_id":125405338,"id":192599591,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU5OTU5MQ==","diff_hunk":"@@ -0,0 +1,271 @@\n+#!/usr/bin/env python\n+#\n+#  Licensed to the Apache Software Foundation (ASF) under one\n+#  or more contributor license agreements.  See the NOTICE file\n+#  distributed with this work for additional information\n+#  regarding copyright ownership.  The ASF licenses this file\n+#  to you under the Apache License, Version 2.0 (the\n+#  \"License\"); you may not use this file except in compliance\n+#  with the License.  You may obtain a copy of the License at\n+#\n+#    http://www.apache.org/licenses/LICENSE-2.0\n+#\n+#  Unless required by applicable law or agreed to in writing,\n+#  software distributed under the License is distributed on an\n+#  \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+#  KIND, either express or implied.  See the License for the\n+#  specific language governing permissions and limitations\n+#  under the License.\n+\"\"\"\n+This script downloads and parses AWS EC2 from https://pricing.us-east-1.amazonaws.com/offers/v1.0/aws/AmazonEC2/current/index.json.\n+It writes a Python module with constants about EC2's sizes and regions.\n+\n+Use it as following:\n+    $ python scrap-ec2-sizes.py > ../libcloud/compute/constants.py","path":"contrib/scrap-ec2-sizes.py","position":24,"original_position":24,"commit_id":"ff4682795a6413934e32efde219718beab02a0b4","original_commit_id":"ff4682795a6413934e32efde219718beab02a0b4","user":{"login":"ZuluPro","id":2029180,"node_id":"MDQ6VXNlcjIwMjkxODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2029180?v=4","gravatar_id":"","url":"https://api.github.com/users/ZuluPro","html_url":"https://github.com/ZuluPro","followers_url":"https://api.github.com/users/ZuluPro/followers","following_url":"https://api.github.com/users/ZuluPro/following{/other_user}","gists_url":"https://api.github.com/users/ZuluPro/gists{/gist_id}","starred_url":"https://api.github.com/users/ZuluPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZuluPro/subscriptions","organizations_url":"https://api.github.com/users/ZuluPro/orgs","repos_url":"https://api.github.com/users/ZuluPro/repos","events_url":"https://api.github.com/users/ZuluPro/events{/privacy}","received_events_url":"https://api.github.com/users/ZuluPro/received_events","type":"User","site_admin":false},"body":"Sorry, I'm not sure to understand, could you rephrase it ?","created_at":"2018-06-03T19:14:36Z","updated_at":"2018-06-03T19:14:37Z","html_url":"https://github.com/apache/libcloud/pull/1211#discussion_r192599591","pull_request_url":"https://api.github.com/repos/apache/libcloud/pulls/1211","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/libcloud/pulls/comments/192599591"},"html":{"href":"https://github.com/apache/libcloud/pull/1211#discussion_r192599591"},"pull_request":{"href":"https://api.github.com/repos/apache/libcloud/pulls/1211"}},"in_reply_to_id":192551483},"pull_request":{"url":"https://api.github.com/repos/apache/libcloud/pulls/1211","id":189217385,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MjE3Mzg1","html_url":"https://github.com/apache/libcloud/pull/1211","diff_url":"https://github.com/apache/libcloud/pull/1211.diff","patch_url":"https://github.com/apache/libcloud/pull/1211.patch","issue_url":"https://api.github.com/repos/apache/libcloud/issues/1211","number":1211,"state":"open","locked":false,"title":"Added script to get automatically EC2 instance sizes","user":{"login":"ZuluPro","id":2029180,"node_id":"MDQ6VXNlcjIwMjkxODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2029180?v=4","gravatar_id":"","url":"https://api.github.com/users/ZuluPro","html_url":"https://github.com/ZuluPro","followers_url":"https://api.github.com/users/ZuluPro/followers","following_url":"https://api.github.com/users/ZuluPro/following{/other_user}","gists_url":"https://api.github.com/users/ZuluPro/gists{/gist_id}","starred_url":"https://api.github.com/users/ZuluPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZuluPro/subscriptions","organizations_url":"https://api.github.com/users/ZuluPro/orgs","repos_url":"https://api.github.com/users/ZuluPro/repos","events_url":"https://api.github.com/users/ZuluPro/events{/privacy}","received_events_url":"https://api.github.com/users/ZuluPro/received_events","type":"User","site_admin":false},"body":"Added script to get automatically EC2 instance sizes\r\n\r\n### Description\r\n\r\n- I created a script to download & parse the big JSON from AWS\r\nThis script outputs Python constants in the same format than in `ec2.py`\r\nI placed the output in libcloud/compute/constants.py (maybe bad?)\r\n- I cleaned `ec2.py` from the big dicts configuring sizes and region\r\nI import from constants and just add things not related to AWS (nimbus)\r\n- Updated tests\r\nTests were too static, so I deleted some.\r\nI also disable lint on the constants file as it is autogenerated and prettified\r\nI remove some lint config from tox.ini to setup.cfg.\r\n\r\n### Status\r\n\r\nDone\r\n\r\n### Checklist (tick everything that applies)\r\n\r\n- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)\r\n- [x] Documentation\r\n- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)\r\n- [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)\r\n","created_at":"2018-05-20T03:32:49Z","updated_at":"2018-06-03T19:14:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90ba485d62a287263dcfada9c4f886a068e60ec4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/libcloud/pulls/1211/commits","review_comments_url":"https://api.github.com/repos/apache/libcloud/pulls/1211/comments","review_comment_url":"https://api.github.com/repos/apache/libcloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/libcloud/issues/1211/comments","statuses_url":"https://api.github.com/repos/apache/libcloud/statuses/ff4682795a6413934e32efde219718beab02a0b4","head":{"label":"ZuluPro:ec2_sizes","ref":"ec2_sizes","sha":"ff4682795a6413934e32efde219718beab02a0b4","user":{"login":"ZuluPro","id":2029180,"node_id":"MDQ6VXNlcjIwMjkxODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2029180?v=4","gravatar_id":"","url":"https://api.github.com/users/ZuluPro","html_url":"https://github.com/ZuluPro","followers_url":"https://api.github.com/users/ZuluPro/followers","following_url":"https://api.github.com/users/ZuluPro/following{/other_user}","gists_url":"https://api.github.com/users/ZuluPro/gists{/gist_id}","starred_url":"https://api.github.com/users/ZuluPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZuluPro/subscriptions","organizations_url":"https://api.github.com/users/ZuluPro/orgs","repos_url":"https://api.github.com/users/ZuluPro/repos","events_url":"https://api.github.com/users/ZuluPro/events{/privacy}","received_events_url":"https://api.github.com/users/ZuluPro/received_events","type":"User","site_admin":false},"repo":{"id":35958307,"node_id":"MDEwOlJlcG9zaXRvcnkzNTk1ODMwNw==","name":"libcloud","full_name":"ZuluPro/libcloud","owner":{"login":"ZuluPro","id":2029180,"node_id":"MDQ6VXNlcjIwMjkxODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2029180?v=4","gravatar_id":"","url":"https://api.github.com/users/ZuluPro","html_url":"https://github.com/ZuluPro","followers_url":"https://api.github.com/users/ZuluPro/followers","following_url":"https://api.github.com/users/ZuluPro/following{/other_user}","gists_url":"https://api.github.com/users/ZuluPro/gists{/gist_id}","starred_url":"https://api.github.com/users/ZuluPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZuluPro/subscriptions","organizations_url":"https://api.github.com/users/ZuluPro/orgs","repos_url":"https://api.github.com/users/ZuluPro/repos","events_url":"https://api.github.com/users/ZuluPro/events{/privacy}","received_events_url":"https://api.github.com/users/ZuluPro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZuluPro/libcloud","description":"Apache Libcloud is a Python library which hides differences between different cloud provider APIs and allows you to manage different cloud resources through a unified and easy to use API","fork":true,"url":"https://api.github.com/repos/ZuluPro/libcloud","forks_url":"https://api.github.com/repos/ZuluPro/libcloud/forks","keys_url":"https://api.github.com/repos/ZuluPro/libcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZuluPro/libcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZuluPro/libcloud/teams","hooks_url":"https://api.github.com/repos/ZuluPro/libcloud/hooks","issue_events_url":"https://api.github.com/repos/ZuluPro/libcloud/issues/events{/number}","events_url":"https://api.github.com/repos/ZuluPro/libcloud/events","assignees_url":"https://api.github.com/repos/ZuluPro/libcloud/assignees{/user}","branches_url":"https://api.github.com/repos/ZuluPro/libcloud/branches{/branch}","tags_url":"https://api.github.com/repos/ZuluPro/libcloud/tags","blobs_url":"https://api.github.com/repos/ZuluPro/libcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZuluPro/libcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZuluPro/libcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZuluPro/libcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZuluPro/libcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/ZuluPro/libcloud/languages","stargazers_url":"https://api.github.com/repos/ZuluPro/libcloud/stargazers","contributors_url":"https://api.github.com/repos/ZuluPro/libcloud/contributors","subscribers_url":"https://api.github.com/repos/ZuluPro/libcloud/subscribers","subscription_url":"https://api.github.com/repos/ZuluPro/libcloud/subscription","commits_url":"https://api.github.com/repos/ZuluPro/libcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZuluPro/libcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZuluPro/libcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZuluPro/libcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZuluPro/libcloud/contents/{+path}","compare_url":"https://api.github.com/repos/ZuluPro/libcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZuluPro/libcloud/merges","archive_url":"https://api.github.com/repos/ZuluPro/libcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZuluPro/libcloud/downloads","issues_url":"https://api.github.com/repos/ZuluPro/libcloud/issues{/number}","pulls_url":"https://api.github.com/repos/ZuluPro/libcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/ZuluPro/libcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/ZuluPro/libcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZuluPro/libcloud/labels{/name}","releases_url":"https://api.github.com/repos/ZuluPro/libcloud/releases{/id}","deployments_url":"https://api.github.com/repos/ZuluPro/libcloud/deployments","created_at":"2015-05-20T15:54:22Z","updated_at":"2016-10-04T17:49:28Z","pushed_at":"2018-05-20T04:01:19Z","git_url":"git://github.com/ZuluPro/libcloud.git","ssh_url":"git@github.com:ZuluPro/libcloud.git","clone_url":"https://github.com/ZuluPro/libcloud.git","svn_url":"https://github.com/ZuluPro/libcloud","homepage":"http://libcloud.apache.org","size":18042,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"c58e89222c34849b51ae698e26ea027f887ea024","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":419555,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk1NTU=","name":"libcloud","full_name":"apache/libcloud","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/libcloud","description":"Apache Libcloud is a Python library which hides differences between different cloud provider APIs and allows you to manage different cloud resources through a unified and easy to use API","fork":false,"url":"https://api.github.com/repos/apache/libcloud","forks_url":"https://api.github.com/repos/apache/libcloud/forks","keys_url":"https://api.github.com/repos/apache/libcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/libcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/libcloud/teams","hooks_url":"https://api.github.com/repos/apache/libcloud/hooks","issue_events_url":"https://api.github.com/repos/apache/libcloud/issues/events{/number}","events_url":"https://api.github.com/repos/apache/libcloud/events","assignees_url":"https://api.github.com/repos/apache/libcloud/assignees{/user}","branches_url":"https://api.github.com/repos/apache/libcloud/branches{/branch}","tags_url":"https://api.github.com/repos/apache/libcloud/tags","blobs_url":"https://api.github.com/repos/apache/libcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/libcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/libcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/libcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/libcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/libcloud/languages","stargazers_url":"https://api.github.com/repos/apache/libcloud/stargazers","contributors_url":"https://api.github.com/repos/apache/libcloud/contributors","subscribers_url":"https://api.github.com/repos/apache/libcloud/subscribers","subscription_url":"https://api.github.com/repos/apache/libcloud/subscription","commits_url":"https://api.github.com/repos/apache/libcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/libcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/libcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/libcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/libcloud/contents/{+path}","compare_url":"https://api.github.com/repos/apache/libcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/libcloud/merges","archive_url":"https://api.github.com/repos/apache/libcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/libcloud/downloads","issues_url":"https://api.github.com/repos/apache/libcloud/issues{/number}","pulls_url":"https://api.github.com/repos/apache/libcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/libcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/libcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/libcloud/labels{/name}","releases_url":"https://api.github.com/repos/apache/libcloud/releases{/id}","deployments_url":"https://api.github.com/repos/apache/libcloud/deployments","created_at":"2009-12-11T09:00:14Z","updated_at":"2018-05-29T15:20:41Z","pushed_at":"2018-06-01T18:32:23Z","git_url":"git://github.com/apache/libcloud.git","ssh_url":"git@github.com:apache/libcloud.git","clone_url":"https://github.com/apache/libcloud.git","svn_url":"https://github.com/apache/libcloud","homepage":"http://libcloud.apache.org","size":18022,"stargazers_count":1320,"watchers_count":1320,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":765,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":765,"open_issues":46,"watchers":1320,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/libcloud/pulls/1211"},"html":{"href":"https://github.com/apache/libcloud/pull/1211"},"issue":{"href":"https://api.github.com/repos/apache/libcloud/issues/1211"},"comments":{"href":"https://api.github.com/repos/apache/libcloud/issues/1211/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/libcloud/pulls/1211/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/libcloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/libcloud/pulls/1211/commits"},"statuses":{"href":"https://api.github.com/repos/apache/libcloud/statuses/ff4682795a6413934e32efde219718beab02a0b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ZuluPro"}}