{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/library-go/issues/55","repository_url":"https://api.github.com/repos/openshift/library-go","labels_url":"https://api.github.com/repos/openshift/library-go/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/openshift/library-go/issues/55/comments","events_url":"https://api.github.com/repos/openshift/library-go/issues/55/events","html_url":"https://github.com/openshift/library-go/pull/55","id":372851612,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTI4MzI5","number":55,"title":"Add build-machinery, start using it and enable CI","user":{"login":"tnozicka","id":11869554,"node_id":"MDQ6VXNlcjExODY5NTU0","avatar_url":"https://avatars2.githubusercontent.com/u/11869554?v=4","gravatar_id":"","url":"https://api.github.com/users/tnozicka","html_url":"https://github.com/tnozicka","followers_url":"https://api.github.com/users/tnozicka/followers","following_url":"https://api.github.com/users/tnozicka/following{/other_user}","gists_url":"https://api.github.com/users/tnozicka/gists{/gist_id}","starred_url":"https://api.github.com/users/tnozicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnozicka/subscriptions","organizations_url":"https://api.github.com/users/tnozicka/orgs","repos_url":"https://api.github.com/users/tnozicka/repos","events_url":"https://api.github.com/users/tnozicka/events{/privacy}","received_events_url":"https://api.github.com/users/tnozicka/received_events","type":"User","site_admin":false},"labels":[{"id":930108630,"node_id":"MDU6TGFiZWw5MzAxMDg2MzA=","url":"https://api.github.com/repos/openshift/library-go/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":930108054,"node_id":"MDU6TGFiZWw5MzAxMDgwNTQ=","url":"https://api.github.com/repos/openshift/library-go/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-10-23T07:40:42Z","updated_at":"2018-10-25T10:43:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openshift/library-go/pulls/55","html_url":"https://github.com/openshift/library-go/pull/55","diff_url":"https://github.com/openshift/library-go/pull/55.diff","patch_url":"https://github.com/openshift/library-go/pull/55.patch"},"body":"This adds unified and reusable build machinery to share common parts of makefiles, scripts and others.\r\n\r\ne.g. makefiles for go repository can get as simple as this\r\n```makefile\r\nall: build\r\n.PHONY: all\r\n\r\ninclude build-machinery/make/golang.mk\r\ninclude build-machinery/make/targets/openshift/deps.mk\r\n\r\nGO_BUILD_PACKAGES :=./pkg/...\r\n```\r\nAlso every makefile gets `make help` to help folks understand what targets are available, as some are generated.\r\n\r\nThis results in unified experience across our repositories and simplifies maintenance to one place. As with every generalization the shared code isn't as simple as when it's copy pasted around, but this pays of even more with the growth of our repos and the maintenance burden we are facing.\r\n(Every sync I have seen so far has forgotten to change part of some script referencing current repo by name or a variable derived from it.)\r\n\r\nI am gonna setup CI job and open use case PR for https://github.com/openshift/cluster-openshift-apiserver-operator.\r\n\r\n/cc @sttts @deads2k @openshift/sig-master "},"comment":{"url":"https://api.github.com/repos/openshift/library-go/issues/comments/433003314","html_url":"https://github.com/openshift/library-go/pull/55#issuecomment-433003314","issue_url":"https://api.github.com/repos/openshift/library-go/issues/55","id":433003314,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzAwMzMxNA==","user":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T10:43:50Z","updated_at":"2018-10-25T10:43:50Z","author_association":"MEMBER","body":"I wonder what's worse bash scripts or make scripts, but the overall goal lgtm."}}
{"actor":{"display_login":"soltysh"}}