{"action":"created","comment":{"url":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/comments/239962126","pull_request_review_id":182893977,"id":239962126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk2MjEyNg==","diff_hunk":"@@ -0,0 +1,78 @@\n+# Debugging Desktop Flutter Applications\n+\n+While the current workflow for debugging on desktop is not ideal, it is\n+possible to do most things, including source-level debugging and hot reload.\n+\n+Because this relies on workarounds for desktop not being a supported device,\n+Flutter changes may break the workflows described below. We hope to extend\n+the `flutter` tool to improve support, but in the meantime please file\n+bugs in this project if you encounter issues with these instructions.\n+\n+## Getting the Observatory Port\n+\n+For all of these approaches, you will need the Observatory port of the\n+desktop application. Usually, `flutter run` would handle this, but there's\n+currently no way to `flutter run` a desktop application, so you will need to\n+provide it manually.\n+\n+There are two options:\n+\n+1. **Find the port in the console.** After launching your application, check\n+   the console output (your terminal in Linux,\n+   [Console](https://developer.apple.com/library/archive/documentation/DeveloperTools/Conceptual/debugging_with_xcode/chapters/debugging_tools.html)\n+   in Xcode, etc.) for a line like:\n+   ```\n+   Observatory listening on http://127.0.0.1:49494/\n+   ```\n+   The port in this case is `49494`. This will change on every run of the\n+   application, so you'll need to repeat this every time you relaunch.\n+\n+1. **Hard-code the port**. In your embedder code, add `--observatory-port=49494`\n+   (substituting a port of your choice) to the list of arguments passed to the\n+   engine. If you are using `example/`, or code based on it, look for the\n+   line that adds `--dart-non-checked-mode` for an example of adding arguments.\n+   (Be sure not to add the `observatory-port` argument inside the `#if`,\n+   however.)\n+\n+## Debugging\n+\n+### Command Line\n+\n+The `flutter attach` command can connect to a desktop Flutter application","path":"Debugging.md","position":41,"original_position":41,"commit_id":"04d0ab1023d3264c1976bea46a2f6f7bf2b1a5cc","original_commit_id":"04d0ab1023d3264c1976bea46a2f6f7bf2b1a5cc","user":{"login":"franciscojma86","id":2388229,"node_id":"MDQ6VXNlcjIzODgyMjk=","avatar_url":"https://avatars3.githubusercontent.com/u/2388229?v=4","gravatar_id":"","url":"https://api.github.com/users/franciscojma86","html_url":"https://github.com/franciscojma86","followers_url":"https://api.github.com/users/franciscojma86/followers","following_url":"https://api.github.com/users/franciscojma86/following{/other_user}","gists_url":"https://api.github.com/users/franciscojma86/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscojma86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscojma86/subscriptions","organizations_url":"https://api.github.com/users/franciscojma86/orgs","repos_url":"https://api.github.com/users/franciscojma86/repos","events_url":"https://api.github.com/users/franciscojma86/events{/privacy}","received_events_url":"https://api.github.com/users/franciscojma86/received_events","type":"User","site_admin":false},"body":"Not sure if this is obvious, but might be worth clarifying that this command should be called from a directory that contains 'lib/main.dart'. I was getting an error when trying from another directory.","created_at":"2018-12-07T22:14:49Z","updated_at":"2018-12-07T22:15:30Z","html_url":"https://github.com/google/flutter-desktop-embedding/pull/168#discussion_r239962126","pull_request_url":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/168","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/comments/239962126"},"html":{"href":"https://github.com/google/flutter-desktop-embedding/pull/168#discussion_r239962126"},"pull_request":{"href":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/168","id":236710678,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzEwNjc4","html_url":"https://github.com/google/flutter-desktop-embedding/pull/168","diff_url":"https://github.com/google/flutter-desktop-embedding/pull/168.diff","patch_url":"https://github.com/google/flutter-desktop-embedding/pull/168.patch","issue_url":"https://api.github.com/repos/google/flutter-desktop-embedding/issues/168","number":168,"state":"open","locked":false,"title":"Add initial debugging instructions","user":{"login":"stuartmorgan","id":122189,"node_id":"MDQ6VXNlcjEyMjE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/122189?v=4","gravatar_id":"","url":"https://api.github.com/users/stuartmorgan","html_url":"https://github.com/stuartmorgan","followers_url":"https://api.github.com/users/stuartmorgan/followers","following_url":"https://api.github.com/users/stuartmorgan/following{/other_user}","gists_url":"https://api.github.com/users/stuartmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartmorgan/subscriptions","organizations_url":"https://api.github.com/users/stuartmorgan/orgs","repos_url":"https://api.github.com/users/stuartmorgan/repos","events_url":"https://api.github.com/users/stuartmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/stuartmorgan/received_events","type":"User","site_admin":false},"body":"Provides basic instructions for debugging the Flutter side of a desktop\r\napplication, since the normal approaches for Flutter debugging require\r\nsome modifications on desktop.\r\n\r\nRelated to issue #14 and issue #164, although doesn't fully address\r\neither.","created_at":"2018-12-06T23:46:32Z","updated_at":"2018-12-07T22:15:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d1e869d101fdbc6416600767a88881a2a272d1a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/168/commits","review_comments_url":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/168/comments","review_comment_url":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/flutter-desktop-embedding/issues/168/comments","statuses_url":"https://api.github.com/repos/google/flutter-desktop-embedding/statuses/04d0ab1023d3264c1976bea46a2f6f7bf2b1a5cc","head":{"label":"stuartmorgan:debugging-info","ref":"debugging-info","sha":"04d0ab1023d3264c1976bea46a2f6f7bf2b1a5cc","user":{"login":"stuartmorgan","id":122189,"node_id":"MDQ6VXNlcjEyMjE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/122189?v=4","gravatar_id":"","url":"https://api.github.com/users/stuartmorgan","html_url":"https://github.com/stuartmorgan","followers_url":"https://api.github.com/users/stuartmorgan/followers","following_url":"https://api.github.com/users/stuartmorgan/following{/other_user}","gists_url":"https://api.github.com/users/stuartmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartmorgan/subscriptions","organizations_url":"https://api.github.com/users/stuartmorgan/orgs","repos_url":"https://api.github.com/users/stuartmorgan/repos","events_url":"https://api.github.com/users/stuartmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/stuartmorgan/received_events","type":"User","site_admin":false},"repo":{"id":123022790,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwMjI3OTA=","name":"flutter-desktop-embedding","full_name":"stuartmorgan/flutter-desktop-embedding","private":false,"owner":{"login":"stuartmorgan","id":122189,"node_id":"MDQ6VXNlcjEyMjE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/122189?v=4","gravatar_id":"","url":"https://api.github.com/users/stuartmorgan","html_url":"https://github.com/stuartmorgan","followers_url":"https://api.github.com/users/stuartmorgan/followers","following_url":"https://api.github.com/users/stuartmorgan/following{/other_user}","gists_url":"https://api.github.com/users/stuartmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartmorgan/subscriptions","organizations_url":"https://api.github.com/users/stuartmorgan/orgs","repos_url":"https://api.github.com/users/stuartmorgan/repos","events_url":"https://api.github.com/users/stuartmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/stuartmorgan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stuartmorgan/flutter-desktop-embedding","description":"Desktop implementations of the Flutter embedding API","fork":true,"url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding","forks_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/forks","keys_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/teams","hooks_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/hooks","issue_events_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/issues/events{/number}","events_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/events","assignees_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/assignees{/user}","branches_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/branches{/branch}","tags_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/tags","blobs_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/git/refs{/sha}","trees_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/statuses/{sha}","languages_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/languages","stargazers_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/stargazers","contributors_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/contributors","subscribers_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/subscribers","subscription_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/subscription","commits_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/commits{/sha}","git_commits_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/git/commits{/sha}","comments_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/comments{/number}","issue_comment_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/issues/comments{/number}","contents_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/contents/{+path}","compare_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/merges","archive_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/downloads","issues_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/issues{/number}","pulls_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/pulls{/number}","milestones_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/milestones{/number}","notifications_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/labels{/name}","releases_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/releases{/id}","deployments_url":"https://api.github.com/repos/stuartmorgan/flutter-desktop-embedding/deployments","created_at":"2018-02-26T19:56:28Z","updated_at":"2018-05-30T23:23:37Z","pushed_at":"2018-12-06T23:45:23Z","git_url":"git://github.com/stuartmorgan/flutter-desktop-embedding.git","ssh_url":"git@github.com:stuartmorgan/flutter-desktop-embedding.git","clone_url":"https://github.com/stuartmorgan/flutter-desktop-embedding.git","svn_url":"https://github.com/stuartmorgan/flutter-desktop-embedding","homepage":"","size":1196,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"37919be3a536ced24fc4a2e9ee13b3408351d725","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":121454193,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NTQxOTM=","name":"flutter-desktop-embedding","full_name":"google/flutter-desktop-embedding","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/flutter-desktop-embedding","description":"Desktop implementations of the Flutter embedding API","fork":false,"url":"https://api.github.com/repos/google/flutter-desktop-embedding","forks_url":"https://api.github.com/repos/google/flutter-desktop-embedding/forks","keys_url":"https://api.github.com/repos/google/flutter-desktop-embedding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/flutter-desktop-embedding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/flutter-desktop-embedding/teams","hooks_url":"https://api.github.com/repos/google/flutter-desktop-embedding/hooks","issue_events_url":"https://api.github.com/repos/google/flutter-desktop-embedding/issues/events{/number}","events_url":"https://api.github.com/repos/google/flutter-desktop-embedding/events","assignees_url":"https://api.github.com/repos/google/flutter-desktop-embedding/assignees{/user}","branches_url":"https://api.github.com/repos/google/flutter-desktop-embedding/branches{/branch}","tags_url":"https://api.github.com/repos/google/flutter-desktop-embedding/tags","blobs_url":"https://api.github.com/repos/google/flutter-desktop-embedding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/flutter-desktop-embedding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/flutter-desktop-embedding/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/flutter-desktop-embedding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/flutter-desktop-embedding/statuses/{sha}","languages_url":"https://api.github.com/repos/google/flutter-desktop-embedding/languages","stargazers_url":"https://api.github.com/repos/google/flutter-desktop-embedding/stargazers","contributors_url":"https://api.github.com/repos/google/flutter-desktop-embedding/contributors","subscribers_url":"https://api.github.com/repos/google/flutter-desktop-embedding/subscribers","subscription_url":"https://api.github.com/repos/google/flutter-desktop-embedding/subscription","commits_url":"https://api.github.com/repos/google/flutter-desktop-embedding/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/flutter-desktop-embedding/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/flutter-desktop-embedding/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/flutter-desktop-embedding/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/flutter-desktop-embedding/contents/{+path}","compare_url":"https://api.github.com/repos/google/flutter-desktop-embedding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/flutter-desktop-embedding/merges","archive_url":"https://api.github.com/repos/google/flutter-desktop-embedding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/flutter-desktop-embedding/downloads","issues_url":"https://api.github.com/repos/google/flutter-desktop-embedding/issues{/number}","pulls_url":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls{/number}","milestones_url":"https://api.github.com/repos/google/flutter-desktop-embedding/milestones{/number}","notifications_url":"https://api.github.com/repos/google/flutter-desktop-embedding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/flutter-desktop-embedding/labels{/name}","releases_url":"https://api.github.com/repos/google/flutter-desktop-embedding/releases{/id}","deployments_url":"https://api.github.com/repos/google/flutter-desktop-embedding/deployments","created_at":"2018-02-14T00:41:16Z","updated_at":"2018-12-07T21:24:43Z","pushed_at":"2018-12-06T23:52:14Z","git_url":"git://github.com/google/flutter-desktop-embedding.git","ssh_url":"git@github.com:google/flutter-desktop-embedding.git","clone_url":"https://github.com/google/flutter-desktop-embedding.git","svn_url":"https://github.com/google/flutter-desktop-embedding","homepage":"","size":1181,"stargazers_count":2197,"watchers_count":2197,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":120,"open_issues":36,"watchers":2197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/168"},"html":{"href":"https://github.com/google/flutter-desktop-embedding/pull/168"},"issue":{"href":"https://api.github.com/repos/google/flutter-desktop-embedding/issues/168"},"comments":{"href":"https://api.github.com/repos/google/flutter-desktop-embedding/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/flutter-desktop-embedding/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/google/flutter-desktop-embedding/statuses/04d0ab1023d3264c1976bea46a2f6f7bf2b1a5cc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"franciscojma86"}}