{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/24759","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24759/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24759/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24759/events","html_url":"https://github.com/cms-sw/cmssw/pull/24759","id":364969674,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDMwMjUx","number":24759,"title":"[10.3.X] CalibrationTrackSelectorFromDetIdList: clone hits only when building track","user":{"login":"mmusich","id":5082376,"node_id":"MDQ6VXNlcjUwODIzNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5082376?v=4","gravatar_id":"","url":"https://api.github.com/users/mmusich","html_url":"https://github.com/mmusich","followers_url":"https://api.github.com/users/mmusich/followers","following_url":"https://api.github.com/users/mmusich/following{/other_user}","gists_url":"https://api.github.com/users/mmusich/gists{/gist_id}","starred_url":"https://api.github.com/users/mmusich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmusich/subscriptions","organizations_url":"https://api.github.com/users/mmusich/orgs","repos_url":"https://api.github.com/users/mmusich/repos","events_url":"https://api.github.com/users/mmusich/events{/privacy}","received_events_url":"https://api.github.com/users/mmusich/received_events","type":"User","site_admin":false},"labels":[{"id":52881463,"node_id":"MDU6TGFiZWw1Mjg4MTQ2Mw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04","default":false},{"id":673935056,"node_id":"MDU6TGFiZWw2NzM5MzUwNTY=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-pending","name":"code-checks-pending","color":"fbca04","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":56131152,"node_id":"MDU6TGFiZWw1NjEzMTE1Mg==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/77","html_url":"https://github.com/cms-sw/cmssw/milestone/77","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/77/labels","id":3502981,"node_id":"MDk6TWlsZXN0b25lMzUwMjk4MQ==","number":77,"title":"CMSSW_10_3_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":92,"closed_issues":680,"state":"open","created_at":"2018-07-17T14:14:12Z","updated_at":"2018-09-28T17:04:17Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-09-28T17:04:03Z","updated_at":"2018-09-28T17:08:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24759","html_url":"https://github.com/cms-sw/cmssw/pull/24759","diff_url":"https://github.com/cms-sw/cmssw/pull/24759.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/24759.patch"},"body":"Greetings,\r\nin the review of #24626, it has been hinted in https://github.com/cms-sw/cmssw/pull/24626#discussion_r219674569 that in `CalibrationTrackSelectorFromDetIdList` it might be more efficient not to clone all hits for all the tracks and then let the unused hits to be deleted (by going out of scope), but instead to store them in a `std::vector<const TrackingRecHit*>`  and clone them later in\r\n`CalibrationTrackSelectorFromDetIdList::makeCandidate` only when a track candidate is built.\r\nThis is what is proposed here. \r\nI checked that there is no memory penalty by re-ALCARECOeing 1000  `ExpressStream` \r\nevents as I don't observe substantial deviations from the baseline. \r\n\r\n![memory2](https://user-images.githubusercontent.com/5082376/46221728-8883bb00-c34e-11e8-9340-c50425a4afc5.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/425503303","html_url":"https://github.com/cms-sw/cmssw/pull/24759#issuecomment-425503303","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24759","id":425503303,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTUwMzMwMw==","user":{"login":"cmsbuild","id":4170616,"node_id":"MDQ6VXNlcjQxNzA2MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T17:08:53Z","updated_at":"2018-09-28T17:08:53Z","author_association":"CONTRIBUTOR","body":"+code-checks\n\nLogs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24759/6701"}}
{"actor":{"display_login":"cmsbuild"}}