{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/469","repository_url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet","labels_url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/469/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/469/comments","events_url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/469/events","html_url":"https://github.com/ethereum/meteor-dapp-wallet/pull/469","id":303208862,"number":469,"title":"Upgrade to web3.js 1.0.0 with subscription support","user":{"login":"ryanio","id":22116,"avatar_url":"https://avatars0.githubusercontent.com/u/22116?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanio","html_url":"https://github.com/ryanio","followers_url":"https://api.github.com/users/ryanio/followers","following_url":"https://api.github.com/users/ryanio/following{/other_user}","gists_url":"https://api.github.com/users/ryanio/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanio/subscriptions","organizations_url":"https://api.github.com/users/ryanio/orgs","repos_url":"https://api.github.com/users/ryanio/repos","events_url":"https://api.github.com/users/ryanio/events{/privacy}","received_events_url":"https://api.github.com/users/ryanio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-07T18:25:12Z","updated_at":"2018-03-09T19:31:07Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/pulls/469","html_url":"https://github.com/ethereum/meteor-dapp-wallet/pull/469","diff_url":"https://github.com/ethereum/meteor-dapp-wallet/pull/469.diff","patch_url":"https://github.com/ethereum/meteor-dapp-wallet/pull/469.patch"},"body":"This PR upgrades meteor-dapp-wallet to use web3.js 1.0.0\r\n\r\nThe primary benefit is using subscriptions instead of filters, which results in much fewer web3 calls.\r\n\r\nTo test this branch, please use local versions of packages: accounts, blocks, elements, tools, and web3.js. I've created a ZIP with all these, which you can put into the directory meteor-dapp-wallet/app/packages. Meteor will automatically pick these up first before going to Atmosphere for the packages. [ZIP link](https://drive.google.com/file/d/14eVLcAaQeLcieq5o0nuB_xYcDeVHF9zU/view).\r\n\r\nFor testing, it would be great to help test in both Mist and any other browser with geth in websockets mode (`geth --ws --wsorigins \"*\"`). I would appreciate testing: sending transactions, sending erc20 tokens, creating wallets, sending transactions to/from wallets, watching contracts, deploying contracts.\r\n\r\nThere is a bug fix in web3.js to make subscriptions work in Mist. Once this is released as beta31, I will update this PR and the subpackage PRs from beta30 to beta31. The local package available in the zip above is gulp'd from the master branch with the fix. All the meteor packages need to be on the exact same dependency versions (in this case, web3.js) for it to run/compile at all.\r\n\r\nAfter this PR is tested and approved, we will want to approve the meteor subpackage PRs and update Atmosphere first, then merge this PR. (After the subpackages are approved, I should be able to update this PR to ensure travis build is successful. It's failing right now due to package mismatches.)\r\n\r\nBefore deploying to production, we will want to consider when MetaMask releases subscription support as to not break wallet.ethereum.org for MetaMask users.\r\n\r\n### Checklist:\r\n\r\n- [ ] Test/approve wallet locally\r\n  - [ ] Test/approve meteor subpackages\r\n- [ ] Release web3.js beta 31\r\n  - [ ] Update wallet and meteor subpackages for beta 31\r\n  - [ ] Merge meteor subpackage PRs and update Atmosphere\r\n- [ ] Finalize this PR\r\n- [ ] Check in with MetaMask"},"comment":{"url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/comments/371921649","html_url":"https://github.com/ethereum/meteor-dapp-wallet/pull/469#issuecomment-371921649","issue_url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/469","id":371921649,"user":{"login":"marcgarreau","id":3621728,"avatar_url":"https://avatars1.githubusercontent.com/u/3621728?v=4","gravatar_id":"","url":"https://api.github.com/users/marcgarreau","html_url":"https://github.com/marcgarreau","followers_url":"https://api.github.com/users/marcgarreau/followers","following_url":"https://api.github.com/users/marcgarreau/following{/other_user}","gists_url":"https://api.github.com/users/marcgarreau/gists{/gist_id}","starred_url":"https://api.github.com/users/marcgarreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcgarreau/subscriptions","organizations_url":"https://api.github.com/users/marcgarreau/orgs","repos_url":"https://api.github.com/users/marcgarreau/repos","events_url":"https://api.github.com/users/marcgarreau/events{/privacy}","received_events_url":"https://api.github.com/users/marcgarreau/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T19:31:07Z","updated_at":"2018-03-09T19:31:07Z","author_association":"COLLABORATOR","body":"(Testing with `--mode wallet`) when creating accounts, the UI looks as expected (I see the warning to backup keystore files) and the keystore directory does contain the new file, but the UI doesn't update with the new account and the logs spam the following message:\r\n```\r\n[2018-03-09T12:14:24.597] [ERROR] ipcProviderBackend - Send request failed { code: -32000, message: 'no suitable peers available' }\r\n(node:23380) Warning: a promise was rejected with a non-error: [object Object]\r\n```\r\nThe error seems to appear whether or not I'm synced up. Upon restart, accounts are still not shown. "}}
{"actor":{"display_login":"marcgarreau"}}