{"action":"created","comment":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments/202287933","pull_request_review_id":136958275,"id":202287933,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjI4NzkzMw==","diff_hunk":"@@ -756,16 +756,18 @@ def compute_flux_point_sqrt_ts(self, fit, stat_best_fit):\n     def fit_point(self, model, energy_group, energy_ref, sqrt_ts_threshold=1):\n         from .fit import SpectrumFit\n \n-        energy_min = energy_group.energy_min\n-        energy_max = energy_group.energy_max\n+ #       energy_min = energy_group.energy_min","path":"gammapy/spectrum/flux_point.py","position":15,"original_position":15,"commit_id":"2a6df2c8dd2d6a45bd52faeefd771ac542b06372","original_commit_id":"2a6df2c8dd2d6a45bd52faeefd771ac542b06372","user":{"login":"mackaiver","id":4076745,"node_id":"MDQ6VXNlcjQwNzY3NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4076745?v=4","gravatar_id":"","url":"https://api.github.com/users/mackaiver","html_url":"https://github.com/mackaiver","followers_url":"https://api.github.com/users/mackaiver/followers","following_url":"https://api.github.com/users/mackaiver/following{/other_user}","gists_url":"https://api.github.com/users/mackaiver/gists{/gist_id}","starred_url":"https://api.github.com/users/mackaiver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mackaiver/subscriptions","organizations_url":"https://api.github.com/users/mackaiver/orgs","repos_url":"https://api.github.com/users/mackaiver/repos","events_url":"https://api.github.com/users/mackaiver/events{/privacy}","received_events_url":"https://api.github.com/users/mackaiver/received_events","type":"User","site_admin":false},"body":"Can we remove the commented lines?","created_at":"2018-07-13T09:02:16Z","updated_at":"2018-07-13T09:02:17Z","html_url":"https://github.com/gammapy/gammapy/pull/1500#discussion_r202287933","pull_request_url":"https://api.github.com/repos/gammapy/gammapy/pulls/1500","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments/202287933"},"html":{"href":"https://github.com/gammapy/gammapy/pull/1500#discussion_r202287933"},"pull_request":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/1500"}}},"pull_request":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/1500","id":201228529,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjI4NTI5","html_url":"https://github.com/gammapy/gammapy/pull/1500","diff_url":"https://github.com/gammapy/gammapy/pull/1500.diff","patch_url":"https://github.com/gammapy/gammapy/pull/1500.patch","issue_url":"https://api.github.com/repos/gammapy/gammapy/issues/1500","number":1500,"state":"open","locked":false,"title":"Cleanup FluxPointEstimator and SpectrumFit","user":{"login":"mealworm","id":6325035,"node_id":"MDQ6VXNlcjYzMjUwMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6325035?v=4","gravatar_id":"","url":"https://api.github.com/users/mealworm","html_url":"https://github.com/mealworm","followers_url":"https://api.github.com/users/mealworm/followers","following_url":"https://api.github.com/users/mealworm/following{/other_user}","gists_url":"https://api.github.com/users/mealworm/gists{/gist_id}","starred_url":"https://api.github.com/users/mealworm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mealworm/subscriptions","organizations_url":"https://api.github.com/users/mealworm/orgs","repos_url":"https://api.github.com/users/mealworm/repos","events_url":"https://api.github.com/users/mealworm/events{/privacy}","received_events_url":"https://api.github.com/users/mealworm/received_events","type":"User","site_admin":false},"body":"FluxPointEstimator.fit_point() no longer uses fit_range; instead, rewrites bins_in_safe_range in a copy of obs. Also changed 'convolved' to 'intersection' in SpectrumFit._apply_fit_range().","created_at":"2018-07-13T09:00:27Z","updated_at":"2018-07-13T09:02:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"339306cec0c3913195dda75667f8e944be94edcc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gammapy/gammapy/pulls/1500/commits","review_comments_url":"https://api.github.com/repos/gammapy/gammapy/pulls/1500/comments","review_comment_url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gammapy/gammapy/issues/1500/comments","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/2a6df2c8dd2d6a45bd52faeefd771ac542b06372","head":{"label":"mealworm:flux_point","ref":"flux_point","sha":"2a6df2c8dd2d6a45bd52faeefd771ac542b06372","user":{"login":"mealworm","id":6325035,"node_id":"MDQ6VXNlcjYzMjUwMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6325035?v=4","gravatar_id":"","url":"https://api.github.com/users/mealworm","html_url":"https://github.com/mealworm","followers_url":"https://api.github.com/users/mealworm/followers","following_url":"https://api.github.com/users/mealworm/following{/other_user}","gists_url":"https://api.github.com/users/mealworm/gists{/gist_id}","starred_url":"https://api.github.com/users/mealworm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mealworm/subscriptions","organizations_url":"https://api.github.com/users/mealworm/orgs","repos_url":"https://api.github.com/users/mealworm/repos","events_url":"https://api.github.com/users/mealworm/events{/privacy}","received_events_url":"https://api.github.com/users/mealworm/received_events","type":"User","site_admin":false},"repo":{"id":140428210,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MjgyMTA=","name":"gammapy","full_name":"mealworm/gammapy","owner":{"login":"mealworm","id":6325035,"node_id":"MDQ6VXNlcjYzMjUwMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6325035?v=4","gravatar_id":"","url":"https://api.github.com/users/mealworm","html_url":"https://github.com/mealworm","followers_url":"https://api.github.com/users/mealworm/followers","following_url":"https://api.github.com/users/mealworm/following{/other_user}","gists_url":"https://api.github.com/users/mealworm/gists{/gist_id}","starred_url":"https://api.github.com/users/mealworm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mealworm/subscriptions","organizations_url":"https://api.github.com/users/mealworm/orgs","repos_url":"https://api.github.com/users/mealworm/repos","events_url":"https://api.github.com/users/mealworm/events{/privacy}","received_events_url":"https://api.github.com/users/mealworm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mealworm/gammapy","description":"A Python package for gamma-ray astronomy","fork":true,"url":"https://api.github.com/repos/mealworm/gammapy","forks_url":"https://api.github.com/repos/mealworm/gammapy/forks","keys_url":"https://api.github.com/repos/mealworm/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mealworm/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mealworm/gammapy/teams","hooks_url":"https://api.github.com/repos/mealworm/gammapy/hooks","issue_events_url":"https://api.github.com/repos/mealworm/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/mealworm/gammapy/events","assignees_url":"https://api.github.com/repos/mealworm/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/mealworm/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/mealworm/gammapy/tags","blobs_url":"https://api.github.com/repos/mealworm/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mealworm/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mealworm/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mealworm/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mealworm/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/mealworm/gammapy/languages","stargazers_url":"https://api.github.com/repos/mealworm/gammapy/stargazers","contributors_url":"https://api.github.com/repos/mealworm/gammapy/contributors","subscribers_url":"https://api.github.com/repos/mealworm/gammapy/subscribers","subscription_url":"https://api.github.com/repos/mealworm/gammapy/subscription","commits_url":"https://api.github.com/repos/mealworm/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mealworm/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mealworm/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mealworm/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mealworm/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/mealworm/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mealworm/gammapy/merges","archive_url":"https://api.github.com/repos/mealworm/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mealworm/gammapy/downloads","issues_url":"https://api.github.com/repos/mealworm/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/mealworm/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/mealworm/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/mealworm/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mealworm/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/mealworm/gammapy/releases{/id}","deployments_url":"https://api.github.com/repos/mealworm/gammapy/deployments","created_at":"2018-07-10T12:24:53Z","updated_at":"2018-07-10T12:24:56Z","pushed_at":"2018-07-13T08:58:52Z","git_url":"git://github.com/mealworm/gammapy.git","ssh_url":"git@github.com:mealworm/gammapy.git","clone_url":"https://github.com/mealworm/gammapy.git","svn_url":"https://github.com/mealworm/gammapy","homepage":"http://gammapy.org","size":11184,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gammapy:master","ref":"master","sha":"a45527c7abbb96fdaa63166044e61996813803a1","user":{"login":"gammapy","id":852764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1Mjc2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/852764?v=4","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"repo":{"id":10073640,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA3MzY0MA==","name":"gammapy","full_name":"gammapy/gammapy","owner":{"login":"gammapy","id":852764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1Mjc2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/852764?v=4","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gammapy/gammapy","description":"A Python package for gamma-ray astronomy","fork":false,"url":"https://api.github.com/repos/gammapy/gammapy","forks_url":"https://api.github.com/repos/gammapy/gammapy/forks","keys_url":"https://api.github.com/repos/gammapy/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gammapy/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gammapy/gammapy/teams","hooks_url":"https://api.github.com/repos/gammapy/gammapy/hooks","issue_events_url":"https://api.github.com/repos/gammapy/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/gammapy/gammapy/events","assignees_url":"https://api.github.com/repos/gammapy/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/gammapy/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/gammapy/gammapy/tags","blobs_url":"https://api.github.com/repos/gammapy/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gammapy/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gammapy/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gammapy/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/gammapy/gammapy/languages","stargazers_url":"https://api.github.com/repos/gammapy/gammapy/stargazers","contributors_url":"https://api.github.com/repos/gammapy/gammapy/contributors","subscribers_url":"https://api.github.com/repos/gammapy/gammapy/subscribers","subscription_url":"https://api.github.com/repos/gammapy/gammapy/subscription","commits_url":"https://api.github.com/repos/gammapy/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gammapy/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gammapy/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gammapy/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gammapy/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/gammapy/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gammapy/gammapy/merges","archive_url":"https://api.github.com/repos/gammapy/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gammapy/gammapy/downloads","issues_url":"https://api.github.com/repos/gammapy/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/gammapy/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/gammapy/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/gammapy/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gammapy/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/gammapy/gammapy/releases{/id}","deployments_url":"https://api.github.com/repos/gammapy/gammapy/deployments","created_at":"2013-05-15T07:50:40Z","updated_at":"2018-07-13T07:15:26Z","pushed_at":"2018-07-13T09:00:27Z","git_url":"git://github.com/gammapy/gammapy.git","ssh_url":"git@github.com:gammapy/gammapy.git","clone_url":"https://github.com/gammapy/gammapy.git","svn_url":"https://github.com/gammapy/gammapy","homepage":"http://gammapy.org","size":11265,"stargazers_count":48,"watchers_count":48,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":215,"license":null,"forks":78,"open_issues":215,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/1500"},"html":{"href":"https://github.com/gammapy/gammapy/pull/1500"},"issue":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/1500"},"comments":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/1500/comments"},"review_comments":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/1500/comments"},"review_comment":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/1500/commits"},"statuses":{"href":"https://api.github.com/repos/gammapy/gammapy/statuses/2a6df2c8dd2d6a45bd52faeefd771ac542b06372"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mackaiver"}}