{"action":"opened","number":110,"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/110","id":238221418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjIxNDE4","html_url":"https://github.com/openshift/cluster-kube-controller-manager-operator/pull/110","diff_url":"https://github.com/openshift/cluster-kube-controller-manager-operator/pull/110.diff","patch_url":"https://github.com/openshift/cluster-kube-controller-manager-operator/pull/110.patch","issue_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/110","number":110,"state":"open","locked":false,"title":"bindata/bootkube: use root-ca.crt for the root-ca-file","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"body":"https://github.com/openshift/cluster-kube-controller-manager-operator/blob/60ddae3e99ce150f5befb34cbcfe4318577c8bd7/bindata/bootkube/config/bootstrap-config-overrides.yaml already uses `root-ca.crt` for root-ca-file\r\nhttps://github.com/openshift/cluster-kube-controller-manager-operator/blob/60ddae3e99ce150f5befb34cbcfe4318577c8bd7/bindata/bootkube/manifests/configmap-kube-controller-manager-client-ca.yaml#L8 is using `kube-ca.crt` that ends up being used as root-ca-file\r\nhere https://github.com/openshift/cluster-kube-controller-manager-operator/blob/60ddae3e99ce150f5befb34cbcfe4318577c8bd7/bindata/bootkube/config/config-overrides.yaml#L5\r\n\r\n*I am not completely sure that how the root-ca-file gets set in bootstrap and long running phase.* :innocent: \r\n\r\n/cc @aaronlevy @deads2k ","created_at":"2018-12-12T23:51:05Z","updated_at":"2018-12-12T23:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/110/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/110/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/110/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/statuses/3dbab1b1e1575a2b665bfe6473c0a4ba733f13bb","head":{"label":"abhinavdahiya:master","ref":"master","sha":"3dbab1b1e1575a2b665bfe6473c0a4ba733f13bb","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"repo":{"id":150656205,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA2NTYyMDU=","name":"cluster-kube-controller-manager-operator","full_name":"abhinavdahiya/cluster-kube-controller-manager-operator","private":false,"owner":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"html_url":"https://github.com/abhinavdahiya/cluster-kube-controller-manager-operator","description":"The kube-controller-manager operator installs and maintains the kube-controller-manager on a cluster","fork":true,"url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator","forks_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/forks","keys_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/teams","hooks_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/hooks","issue_events_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/issues/events{/number}","events_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/events","assignees_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/assignees{/user}","branches_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/branches{/branch}","tags_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/tags","blobs_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/languages","stargazers_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/stargazers","contributors_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/contributors","subscribers_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/subscribers","subscription_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/subscription","commits_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/contents/{+path}","compare_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/merges","archive_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/downloads","issues_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/issues{/number}","pulls_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/labels{/name}","releases_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/releases{/id}","deployments_url":"https://api.github.com/repos/abhinavdahiya/cluster-kube-controller-manager-operator/deployments","created_at":"2018-09-27T22:44:57Z","updated_at":"2018-12-12T23:50:14Z","pushed_at":"2018-12-12T23:49:49Z","git_url":"git://github.com/abhinavdahiya/cluster-kube-controller-manager-operator.git","ssh_url":"git@github.com:abhinavdahiya/cluster-kube-controller-manager-operator.git","clone_url":"https://github.com/abhinavdahiya/cluster-kube-controller-manager-operator.git","svn_url":"https://github.com/abhinavdahiya/cluster-kube-controller-manager-operator","homepage":null,"size":15357,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"60ddae3e99ce150f5befb34cbcfe4318577c8bd7","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":148497748,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg0OTc3NDg=","name":"cluster-kube-controller-manager-operator","full_name":"openshift/cluster-kube-controller-manager-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/cluster-kube-controller-manager-operator","description":"The kube-controller-manager operator installs and maintains the kube-controller-manager on a cluster","fork":false,"url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator","forks_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/deployments","created_at":"2018-09-12T14:59:05Z","updated_at":"2018-12-11T01:42:07Z","pushed_at":"2018-12-12T08:00:33Z","git_url":"git://github.com/openshift/cluster-kube-controller-manager-operator.git","ssh_url":"git@github.com:openshift/cluster-kube-controller-manager-operator.git","clone_url":"https://github.com/openshift/cluster-kube-controller-manager-operator.git","svn_url":"https://github.com/openshift/cluster-kube-controller-manager-operator","homepage":null,"size":19617,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/110"},"html":{"href":"https://github.com/openshift/cluster-kube-controller-manager-operator/pull/110"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/110"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-kube-controller-manager-operator/statuses/3dbab1b1e1575a2b665bfe6473c0a4ba733f13bb"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"abhinavdahiya"}}