{"action":"closed","number":215,"pull_request":{"url":"https://api.github.com/repos/moment/luxon/pulls/215","id":174523083,"html_url":"https://github.com/moment/luxon/pull/215","diff_url":"https://github.com/moment/luxon/pull/215.diff","patch_url":"https://github.com/moment/luxon/pull/215.patch","issue_url":"https://api.github.com/repos/moment/luxon/issues/215","number":215,"state":"closed","locked":false,"title":"Include AMD build in npm tarball so Ember can use luxon directly","user":{"login":"tim-evans","id":177701,"avatar_url":"https://avatars3.githubusercontent.com/u/177701?v=4","gravatar_id":"","url":"https://api.github.com/users/tim-evans","html_url":"https://github.com/tim-evans","followers_url":"https://api.github.com/users/tim-evans/followers","following_url":"https://api.github.com/users/tim-evans/following{/other_user}","gists_url":"https://api.github.com/users/tim-evans/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-evans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-evans/subscriptions","organizations_url":"https://api.github.com/users/tim-evans/orgs","repos_url":"https://api.github.com/users/tim-evans/repos","events_url":"https://api.github.com/users/tim-evans/events{/privacy}","received_events_url":"https://api.github.com/users/tim-evans/received_events","type":"User","site_admin":false},"body":"Hello! Thanks for this wonderful library.\r\n\r\nThis is more of a suggested PR, since [ember-luxon](https://github.com/willrax/ember-luxon) exists.\r\n\r\nEssentially, I would like to import luxon directly into my Ember application, so I can keep up to date with the most recent versions of luxon without depending on another package to be published. The change here adds an AMD output, which would allow Ember apps / addons to directly import luxon into their application without running rollup. I understand that adding this build file will result in some bloat in the npm tarball, so I've added that info below:\r\n\r\n| Before | After |\r\n|--------|------|\r\n| 410704 bytes | 532358 bytes |\r\n\r\nThis adds ~100K to the npm tarball.\r\n\r\nOnce again, thanks for this library ❤️","created_at":"2018-03-12T23:36:23Z","updated_at":"2018-03-13T00:13:08Z","closed_at":"2018-03-13T00:13:08Z","merged_at":"2018-03-13T00:13:08Z","merge_commit_sha":"7477ba48cf8b2e478f7098486abef1daca74ea8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/moment/luxon/pulls/215/commits","review_comments_url":"https://api.github.com/repos/moment/luxon/pulls/215/comments","review_comment_url":"https://api.github.com/repos/moment/luxon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moment/luxon/issues/215/comments","statuses_url":"https://api.github.com/repos/moment/luxon/statuses/584fcb942e08236dced8074f4bcfc0004fe2f2b4","head":{"label":"tim-evans:master","ref":"master","sha":"584fcb942e08236dced8074f4bcfc0004fe2f2b4","user":{"login":"tim-evans","id":177701,"avatar_url":"https://avatars3.githubusercontent.com/u/177701?v=4","gravatar_id":"","url":"https://api.github.com/users/tim-evans","html_url":"https://github.com/tim-evans","followers_url":"https://api.github.com/users/tim-evans/followers","following_url":"https://api.github.com/users/tim-evans/following{/other_user}","gists_url":"https://api.github.com/users/tim-evans/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-evans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-evans/subscriptions","organizations_url":"https://api.github.com/users/tim-evans/orgs","repos_url":"https://api.github.com/users/tim-evans/repos","events_url":"https://api.github.com/users/tim-evans/events{/privacy}","received_events_url":"https://api.github.com/users/tim-evans/received_events","type":"User","site_admin":false},"repo":{"id":124963863,"name":"luxon","full_name":"tim-evans/luxon","owner":{"login":"tim-evans","id":177701,"avatar_url":"https://avatars3.githubusercontent.com/u/177701?v=4","gravatar_id":"","url":"https://api.github.com/users/tim-evans","html_url":"https://github.com/tim-evans","followers_url":"https://api.github.com/users/tim-evans/followers","following_url":"https://api.github.com/users/tim-evans/following{/other_user}","gists_url":"https://api.github.com/users/tim-evans/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-evans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-evans/subscriptions","organizations_url":"https://api.github.com/users/tim-evans/orgs","repos_url":"https://api.github.com/users/tim-evans/repos","events_url":"https://api.github.com/users/tim-evans/events{/privacy}","received_events_url":"https://api.github.com/users/tim-evans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tim-evans/luxon","description":"⏱ A library for working with dates and times in JS","fork":true,"url":"https://api.github.com/repos/tim-evans/luxon","forks_url":"https://api.github.com/repos/tim-evans/luxon/forks","keys_url":"https://api.github.com/repos/tim-evans/luxon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tim-evans/luxon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tim-evans/luxon/teams","hooks_url":"https://api.github.com/repos/tim-evans/luxon/hooks","issue_events_url":"https://api.github.com/repos/tim-evans/luxon/issues/events{/number}","events_url":"https://api.github.com/repos/tim-evans/luxon/events","assignees_url":"https://api.github.com/repos/tim-evans/luxon/assignees{/user}","branches_url":"https://api.github.com/repos/tim-evans/luxon/branches{/branch}","tags_url":"https://api.github.com/repos/tim-evans/luxon/tags","blobs_url":"https://api.github.com/repos/tim-evans/luxon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tim-evans/luxon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tim-evans/luxon/git/refs{/sha}","trees_url":"https://api.github.com/repos/tim-evans/luxon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tim-evans/luxon/statuses/{sha}","languages_url":"https://api.github.com/repos/tim-evans/luxon/languages","stargazers_url":"https://api.github.com/repos/tim-evans/luxon/stargazers","contributors_url":"https://api.github.com/repos/tim-evans/luxon/contributors","subscribers_url":"https://api.github.com/repos/tim-evans/luxon/subscribers","subscription_url":"https://api.github.com/repos/tim-evans/luxon/subscription","commits_url":"https://api.github.com/repos/tim-evans/luxon/commits{/sha}","git_commits_url":"https://api.github.com/repos/tim-evans/luxon/git/commits{/sha}","comments_url":"https://api.github.com/repos/tim-evans/luxon/comments{/number}","issue_comment_url":"https://api.github.com/repos/tim-evans/luxon/issues/comments{/number}","contents_url":"https://api.github.com/repos/tim-evans/luxon/contents/{+path}","compare_url":"https://api.github.com/repos/tim-evans/luxon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tim-evans/luxon/merges","archive_url":"https://api.github.com/repos/tim-evans/luxon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tim-evans/luxon/downloads","issues_url":"https://api.github.com/repos/tim-evans/luxon/issues{/number}","pulls_url":"https://api.github.com/repos/tim-evans/luxon/pulls{/number}","milestones_url":"https://api.github.com/repos/tim-evans/luxon/milestones{/number}","notifications_url":"https://api.github.com/repos/tim-evans/luxon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tim-evans/luxon/labels{/name}","releases_url":"https://api.github.com/repos/tim-evans/luxon/releases{/id}","deployments_url":"https://api.github.com/repos/tim-evans/luxon/deployments","created_at":"2018-03-12T23:24:40Z","updated_at":"2018-03-12T23:24:42Z","pushed_at":"2018-03-12T23:26:28Z","git_url":"git://github.com/tim-evans/luxon.git","ssh_url":"git@github.com:tim-evans/luxon.git","clone_url":"https://github.com/tim-evans/luxon.git","svn_url":"https://github.com/tim-evans/luxon","homepage":"https://moment.github.io/luxon","size":39889,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moment:master","ref":"master","sha":"1c8fa168753b237c01510777570d65fbbc824485","user":{"login":"moment","id":4129662,"avatar_url":"https://avatars1.githubusercontent.com/u/4129662?v=4","gravatar_id":"","url":"https://api.github.com/users/moment","html_url":"https://github.com/moment","followers_url":"https://api.github.com/users/moment/followers","following_url":"https://api.github.com/users/moment/following{/other_user}","gists_url":"https://api.github.com/users/moment/gists{/gist_id}","starred_url":"https://api.github.com/users/moment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moment/subscriptions","organizations_url":"https://api.github.com/users/moment/orgs","repos_url":"https://api.github.com/users/moment/repos","events_url":"https://api.github.com/users/moment/events{/privacy}","received_events_url":"https://api.github.com/users/moment/received_events","type":"Organization","site_admin":false},"repo":{"id":47118129,"name":"luxon","full_name":"moment/luxon","owner":{"login":"moment","id":4129662,"avatar_url":"https://avatars1.githubusercontent.com/u/4129662?v=4","gravatar_id":"","url":"https://api.github.com/users/moment","html_url":"https://github.com/moment","followers_url":"https://api.github.com/users/moment/followers","following_url":"https://api.github.com/users/moment/following{/other_user}","gists_url":"https://api.github.com/users/moment/gists{/gist_id}","starred_url":"https://api.github.com/users/moment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moment/subscriptions","organizations_url":"https://api.github.com/users/moment/orgs","repos_url":"https://api.github.com/users/moment/repos","events_url":"https://api.github.com/users/moment/events{/privacy}","received_events_url":"https://api.github.com/users/moment/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moment/luxon","description":"⏱ A library for working with dates and times in JS","fork":false,"url":"https://api.github.com/repos/moment/luxon","forks_url":"https://api.github.com/repos/moment/luxon/forks","keys_url":"https://api.github.com/repos/moment/luxon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moment/luxon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moment/luxon/teams","hooks_url":"https://api.github.com/repos/moment/luxon/hooks","issue_events_url":"https://api.github.com/repos/moment/luxon/issues/events{/number}","events_url":"https://api.github.com/repos/moment/luxon/events","assignees_url":"https://api.github.com/repos/moment/luxon/assignees{/user}","branches_url":"https://api.github.com/repos/moment/luxon/branches{/branch}","tags_url":"https://api.github.com/repos/moment/luxon/tags","blobs_url":"https://api.github.com/repos/moment/luxon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moment/luxon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moment/luxon/git/refs{/sha}","trees_url":"https://api.github.com/repos/moment/luxon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moment/luxon/statuses/{sha}","languages_url":"https://api.github.com/repos/moment/luxon/languages","stargazers_url":"https://api.github.com/repos/moment/luxon/stargazers","contributors_url":"https://api.github.com/repos/moment/luxon/contributors","subscribers_url":"https://api.github.com/repos/moment/luxon/subscribers","subscription_url":"https://api.github.com/repos/moment/luxon/subscription","commits_url":"https://api.github.com/repos/moment/luxon/commits{/sha}","git_commits_url":"https://api.github.com/repos/moment/luxon/git/commits{/sha}","comments_url":"https://api.github.com/repos/moment/luxon/comments{/number}","issue_comment_url":"https://api.github.com/repos/moment/luxon/issues/comments{/number}","contents_url":"https://api.github.com/repos/moment/luxon/contents/{+path}","compare_url":"https://api.github.com/repos/moment/luxon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moment/luxon/merges","archive_url":"https://api.github.com/repos/moment/luxon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moment/luxon/downloads","issues_url":"https://api.github.com/repos/moment/luxon/issues{/number}","pulls_url":"https://api.github.com/repos/moment/luxon/pulls{/number}","milestones_url":"https://api.github.com/repos/moment/luxon/milestones{/number}","notifications_url":"https://api.github.com/repos/moment/luxon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moment/luxon/labels{/name}","releases_url":"https://api.github.com/repos/moment/luxon/releases{/id}","deployments_url":"https://api.github.com/repos/moment/luxon/deployments","created_at":"2015-11-30T12:48:48Z","updated_at":"2018-03-12T19:59:51Z","pushed_at":"2018-03-13T00:13:08Z","git_url":"git://github.com/moment/luxon.git","ssh_url":"git@github.com:moment/luxon.git","clone_url":"https://github.com/moment/luxon.git","svn_url":"https://github.com/moment/luxon","homepage":"https://moment.github.io/luxon","size":39889,"stargazers_count":5770,"watchers_count":5770,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":193,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":193,"open_issues":13,"watchers":5770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moment/luxon/pulls/215"},"html":{"href":"https://github.com/moment/luxon/pull/215"},"issue":{"href":"https://api.github.com/repos/moment/luxon/issues/215"},"comments":{"href":"https://api.github.com/repos/moment/luxon/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/moment/luxon/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/moment/luxon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moment/luxon/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/moment/luxon/statuses/584fcb942e08236dced8074f4bcfc0004fe2f2b4"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"icambron","id":244988,"avatar_url":"https://avatars3.githubusercontent.com/u/244988?v=4","gravatar_id":"","url":"https://api.github.com/users/icambron","html_url":"https://github.com/icambron","followers_url":"https://api.github.com/users/icambron/followers","following_url":"https://api.github.com/users/icambron/following{/other_user}","gists_url":"https://api.github.com/users/icambron/gists{/gist_id}","starred_url":"https://api.github.com/users/icambron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icambron/subscriptions","organizations_url":"https://api.github.com/users/icambron/orgs","repos_url":"https://api.github.com/users/icambron/repos","events_url":"https://api.github.com/users/icambron/events{/privacy}","received_events_url":"https://api.github.com/users/icambron/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"icambron"}}