{"action":"closed","number":643,"pull_request":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/643","id":181031099,"html_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/643","diff_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/643.diff","patch_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/643.patch","issue_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/643","number":643,"state":"closed","locked":false,"title":"Make channel easily configurable","user":{"login":"cijothomas","id":5232798,"avatar_url":"https://avatars3.githubusercontent.com/u/5232798?v=4","gravatar_id":"","url":"https://api.github.com/users/cijothomas","html_url":"https://github.com/cijothomas","followers_url":"https://api.github.com/users/cijothomas/followers","following_url":"https://api.github.com/users/cijothomas/following{/other_user}","gists_url":"https://api.github.com/users/cijothomas/gists{/gist_id}","starred_url":"https://api.github.com/users/cijothomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cijothomas/subscriptions","organizations_url":"https://api.github.com/users/cijothomas/orgs","repos_url":"https://api.github.com/users/cijothomas/repos","events_url":"https://api.github.com/users/cijothomas/events{/privacy}","received_events_url":"https://api.github.com/users/cijothomas/received_events","type":"User","site_admin":false},"body":"Fixes:\r\nhttps://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/641\r\nhttps://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/642\r\n\r\nThis does not change existing behaviours:\r\n1. ServerTelemetryChannel is added by default\r\n2. If user adds any ITelemetryChannel to DI, then it takes precedence over default.\r\n3. If user explicitly removed all channels, SDK falls back to base sdk provided default channel (InMemoryChannel)\r\n\r\nHow to modify channel after this PR?\r\nAdd the following in `ConfigureServices()` method of Application Startup class.\r\n```\r\nservices.AddSingleton(typeof(ITelemetryChannel), new InMemoryChannel() {MaxTelemetryBufferCapacity = 19898 });\r\n```\r\n(SDK will pick this channel up automatically, and applies to TelemetryConfiguration)\r\n\r\n\r\n\r\nThis also modifies QP/Sampling enableing code to be NOT dependency on the type of channel. @netgh0st confirmed that QP should be enabled irrespective of channel.\r\n\r\n\r\n- [ ] I ran Unit Tests locally.\r\n\r\nFor significant contributions please make sure you have completed the following items:\r\n\r\n- [ ] Changes in public surface reviewed\r\n- [ ] Design discussion issue #\r\n- [ ] CHANGELOG.md updated with one line description of the fix, and a link to the original issue.\r\n- [ ] The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.\r\n\t  If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)\r\n\r\n- Please follow [these] (https://github.com/Microsoft/ApplicationInsights-aspnetcore/blob/develop/Readme.md) instructions to build and test locally.\r\n","created_at":"2018-04-11T21:18:32Z","updated_at":"2018-04-11T22:54:29Z","closed_at":"2018-04-11T22:54:29Z","merged_at":"2018-04-11T22:54:29Z","merge_commit_sha":"fecf25acfa69e86e6aaa649ef50409e10b8ec1be","assignee":null,"assignees":[],"requested_reviewers":[{"login":"netgh0st","id":1855900,"avatar_url":"https://avatars3.githubusercontent.com/u/1855900?v=4","gravatar_id":"","url":"https://api.github.com/users/netgh0st","html_url":"https://github.com/netgh0st","followers_url":"https://api.github.com/users/netgh0st/followers","following_url":"https://api.github.com/users/netgh0st/following{/other_user}","gists_url":"https://api.github.com/users/netgh0st/gists{/gist_id}","starred_url":"https://api.github.com/users/netgh0st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netgh0st/subscriptions","organizations_url":"https://api.github.com/users/netgh0st/orgs","repos_url":"https://api.github.com/users/netgh0st/repos","events_url":"https://api.github.com/users/netgh0st/events{/privacy}","received_events_url":"https://api.github.com/users/netgh0st/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/643/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/643/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/643/comments","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/statuses/352e8a8929cf331eef4fe2a23b953363910ec70e","head":{"label":"Microsoft:cithomas/fixchannelconfig","ref":"cithomas/fixchannelconfig","sha":"352e8a8929cf331eef4fe2a23b953363910ec70e","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32415843,"name":"ApplicationInsights-aspnetcore","full_name":"Microsoft/ApplicationInsights-aspnetcore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore","description":"ASP.NET Core web applications monitoring","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/deployments","created_at":"2015-03-17T19:39:40Z","updated_at":"2018-04-11T22:43:31Z","pushed_at":"2018-04-11T22:54:29Z","git_url":"git://github.com/Microsoft/ApplicationInsights-aspnetcore.git","ssh_url":"git@github.com:Microsoft/ApplicationInsights-aspnetcore.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore","homepage":"","size":6237,"stargazers_count":158,"watchers_count":158,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":87,"open_issues":91,"watchers":158,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"dd665e9e91d903cb27f906634e2b4f0be69875da","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32415843,"name":"ApplicationInsights-aspnetcore","full_name":"Microsoft/ApplicationInsights-aspnetcore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore","description":"ASP.NET Core web applications monitoring","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/deployments","created_at":"2015-03-17T19:39:40Z","updated_at":"2018-04-11T22:43:31Z","pushed_at":"2018-04-11T22:54:29Z","git_url":"git://github.com/Microsoft/ApplicationInsights-aspnetcore.git","ssh_url":"git@github.com:Microsoft/ApplicationInsights-aspnetcore.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-aspnetcore","homepage":"","size":6237,"stargazers_count":158,"watchers_count":158,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":87,"open_issues":91,"watchers":158,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/643"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/643"},"issue":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/643"},"comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/issues/643/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/643/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/pulls/643/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-aspnetcore/statuses/352e8a8929cf331eef4fe2a23b953363910ec70e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cijothomas","id":5232798,"avatar_url":"https://avatars3.githubusercontent.com/u/5232798?v=4","gravatar_id":"","url":"https://api.github.com/users/cijothomas","html_url":"https://github.com/cijothomas","followers_url":"https://api.github.com/users/cijothomas/followers","following_url":"https://api.github.com/users/cijothomas/following{/other_user}","gists_url":"https://api.github.com/users/cijothomas/gists{/gist_id}","starred_url":"https://api.github.com/users/cijothomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cijothomas/subscriptions","organizations_url":"https://api.github.com/users/cijothomas/orgs","repos_url":"https://api.github.com/users/cijothomas/repos","events_url":"https://api.github.com/users/cijothomas/events{/privacy}","received_events_url":"https://api.github.com/users/cijothomas/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":70,"deletions":47,"changed_files":4}}
{"actor":{"display_login":"cijothomas"}}