{"action":"created","comment":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/240111455","pull_request_review_id":183063921,"id":240111455,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDExMTQ1NQ==","diff_hunk":"@@ -2574,10 +2578,15 @@ void TextBase::draw(QPainter* p) const\n             if (circle())\n                   p->drawEllipse(frame);\n             else {\n-                  int r2 = frameRound();\n+                  qreal baseSpatium = MScore::baseStyle().value(Sid::spatium).toDouble();\n+                  qreal frameRoundFactor = (spatium()/baseSpatium)/2;","path":"libmscore/textbase.cpp","position":19,"original_position":19,"commit_id":"bb088cb470319dc6411a80bcdfdedca83df2fa92","original_commit_id":"bb088cb470319dc6411a80bcdfdedca83df2fa92","user":{"login":"anatoly-os","id":18065034,"node_id":"MDQ6VXNlcjE4MDY1MDM0","avatar_url":"https://avatars2.githubusercontent.com/u/18065034?v=4","gravatar_id":"","url":"https://api.github.com/users/anatoly-os","html_url":"https://github.com/anatoly-os","followers_url":"https://api.github.com/users/anatoly-os/followers","following_url":"https://api.github.com/users/anatoly-os/following{/other_user}","gists_url":"https://api.github.com/users/anatoly-os/gists{/gist_id}","starred_url":"https://api.github.com/users/anatoly-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anatoly-os/subscriptions","organizations_url":"https://api.github.com/users/anatoly-os/orgs","repos_url":"https://api.github.com/users/anatoly-os/repos","events_url":"https://api.github.com/users/anatoly-os/events{/privacy}","received_events_url":"https://api.github.com/users/anatoly-os/received_events","type":"User","site_admin":false},"body":"See above. It is better to have one place which assigns the value to the variable and later modify it by multiplication if necessary.","created_at":"2018-12-10T08:05:18Z","updated_at":"2018-12-10T08:05:24Z","html_url":"https://github.com/musescore/MuseScore/pull/4355#discussion_r240111455","pull_request_url":"https://api.github.com/repos/musescore/MuseScore/pulls/4355","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/240111455"},"html":{"href":"https://github.com/musescore/MuseScore/pull/4355#discussion_r240111455"},"pull_request":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/4355"}}},"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/4355","id":237061814,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDYxODE0","html_url":"https://github.com/musescore/MuseScore/pull/4355","diff_url":"https://github.com/musescore/MuseScore/pull/4355.diff","patch_url":"https://github.com/musescore/MuseScore/pull/4355.patch","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/4355","number":4355,"state":"open","locked":false,"title":"fix #279119: frame radius and border width don't scale with spatium","user":{"login":"jthistle","id":8274049,"node_id":"MDQ6VXNlcjgyNzQwNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/8274049?v=4","gravatar_id":"","url":"https://api.github.com/users/jthistle","html_url":"https://github.com/jthistle","followers_url":"https://api.github.com/users/jthistle/followers","following_url":"https://api.github.com/users/jthistle/following{/other_user}","gists_url":"https://api.github.com/users/jthistle/gists{/gist_id}","starred_url":"https://api.github.com/users/jthistle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthistle/subscriptions","organizations_url":"https://api.github.com/users/jthistle/orgs","repos_url":"https://api.github.com/users/jthistle/repos","events_url":"https://api.github.com/users/jthistle/events{/privacy}","received_events_url":"https://api.github.com/users/jthistle/received_events","type":"User","site_admin":false},"body":"Resolves: https://musescore.org/en/node/279119\r\n\r\nBecause frame round is a percentage, and so has no unit, we can't just multiply it by `spatium()`. So, this fix multiplies it by the percentage that `spatium()` is of the default value, divided by a constant (2). The constant exists to provide a more similar look to 2.0 frames, although it hasn't been completely replicated (because that would be impossible due to the new way we handle frames in MS3).\r\n\r\nFor example, if the default spatium is 25, and the styled spatium is 50, then the border radius will be multiplied by (50/25)/2 = 1.\r\nIf the default is 25, and the styled is 100, then (100/25)/2 = 2.\r\n\r\nComparisons for 25 border radius and 50 border radius respectively:\r\n\r\nMuseScore 2.3.2:\r\n![1544266454](https://user-images.githubusercontent.com/8274049/49685284-00056180-fad9-11e8-8371-9c934c3685f5.png)\r\n\r\nMuseScore 3.0-dev (this fix):\r\n![1544266444](https://user-images.githubusercontent.com/8274049/49685283-00056180-fad9-11e8-9517-a102d46c066f.png)\r\n\r\nThis fix also makes both the frame round and border width properties obey the `SIZE_SPATIUM_DEPENDENT` property.","created_at":"2018-12-08T11:05:46Z","updated_at":"2018-12-10T08:05:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d970deb7e809368b22912dd3c21e16b2117c0eef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/musescore/MuseScore/pulls/4355/commits","review_comments_url":"https://api.github.com/repos/musescore/MuseScore/pulls/4355/comments","review_comment_url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/4355/comments","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/bb088cb470319dc6411a80bcdfdedca83df2fa92","head":{"label":"jthistle:279119-text-frame-doesnt-scale-with-size","ref":"279119-text-frame-doesnt-scale-with-size","sha":"bb088cb470319dc6411a80bcdfdedca83df2fa92","user":{"login":"jthistle","id":8274049,"node_id":"MDQ6VXNlcjgyNzQwNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/8274049?v=4","gravatar_id":"","url":"https://api.github.com/users/jthistle","html_url":"https://github.com/jthistle","followers_url":"https://api.github.com/users/jthistle/followers","following_url":"https://api.github.com/users/jthistle/following{/other_user}","gists_url":"https://api.github.com/users/jthistle/gists{/gist_id}","starred_url":"https://api.github.com/users/jthistle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthistle/subscriptions","organizations_url":"https://api.github.com/users/jthistle/orgs","repos_url":"https://api.github.com/users/jthistle/repos","events_url":"https://api.github.com/users/jthistle/events{/privacy}","received_events_url":"https://api.github.com/users/jthistle/received_events","type":"User","site_admin":false},"repo":{"id":141881298,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE4ODEyOTg=","name":"MuseScore","full_name":"jthistle/MuseScore","private":false,"owner":{"login":"jthistle","id":8274049,"node_id":"MDQ6VXNlcjgyNzQwNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/8274049?v=4","gravatar_id":"","url":"https://api.github.com/users/jthistle","html_url":"https://github.com/jthistle","followers_url":"https://api.github.com/users/jthistle/followers","following_url":"https://api.github.com/users/jthistle/following{/other_user}","gists_url":"https://api.github.com/users/jthistle/gists{/gist_id}","starred_url":"https://api.github.com/users/jthistle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthistle/subscriptions","organizations_url":"https://api.github.com/users/jthistle/orgs","repos_url":"https://api.github.com/users/jthistle/repos","events_url":"https://api.github.com/users/jthistle/events{/privacy}","received_events_url":"https://api.github.com/users/jthistle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jthistle/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":true,"url":"https://api.github.com/repos/jthistle/MuseScore","forks_url":"https://api.github.com/repos/jthistle/MuseScore/forks","keys_url":"https://api.github.com/repos/jthistle/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jthistle/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jthistle/MuseScore/teams","hooks_url":"https://api.github.com/repos/jthistle/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/jthistle/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/jthistle/MuseScore/events","assignees_url":"https://api.github.com/repos/jthistle/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/jthistle/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/jthistle/MuseScore/tags","blobs_url":"https://api.github.com/repos/jthistle/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jthistle/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jthistle/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jthistle/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jthistle/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/jthistle/MuseScore/languages","stargazers_url":"https://api.github.com/repos/jthistle/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/jthistle/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/jthistle/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/jthistle/MuseScore/subscription","commits_url":"https://api.github.com/repos/jthistle/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jthistle/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jthistle/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jthistle/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/jthistle/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/jthistle/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jthistle/MuseScore/merges","archive_url":"https://api.github.com/repos/jthistle/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jthistle/MuseScore/downloads","issues_url":"https://api.github.com/repos/jthistle/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/jthistle/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/jthistle/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/jthistle/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jthistle/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/jthistle/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/jthistle/MuseScore/deployments","created_at":"2018-07-22T09:08:57Z","updated_at":"2018-12-08T18:42:44Z","pushed_at":"2018-12-08T18:44:42Z","git_url":"git://github.com/jthistle/MuseScore.git","ssh_url":"git@github.com:jthistle/MuseScore.git","clone_url":"https://github.com/jthistle/MuseScore.git","svn_url":"https://github.com/jthistle/MuseScore","homepage":"https://musescore.org","size":325589,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"musescore:master","ref":"master","sha":"a9203cb028b06bd74c95fc461811a59ba959156e","user":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"repo":{"id":4454793,"node_id":"MDEwOlJlcG9zaXRvcnk0NDU0Nzkz","name":"MuseScore","full_name":"musescore/MuseScore","private":false,"owner":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/musescore/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":false,"url":"https://api.github.com/repos/musescore/MuseScore","forks_url":"https://api.github.com/repos/musescore/MuseScore/forks","keys_url":"https://api.github.com/repos/musescore/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musescore/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musescore/MuseScore/teams","hooks_url":"https://api.github.com/repos/musescore/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/musescore/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/musescore/MuseScore/events","assignees_url":"https://api.github.com/repos/musescore/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/musescore/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/musescore/MuseScore/tags","blobs_url":"https://api.github.com/repos/musescore/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musescore/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musescore/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/musescore/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/musescore/MuseScore/languages","stargazers_url":"https://api.github.com/repos/musescore/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/musescore/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/musescore/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/musescore/MuseScore/subscription","commits_url":"https://api.github.com/repos/musescore/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/musescore/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/musescore/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/musescore/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/musescore/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/musescore/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musescore/MuseScore/merges","archive_url":"https://api.github.com/repos/musescore/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musescore/MuseScore/downloads","issues_url":"https://api.github.com/repos/musescore/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/musescore/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/musescore/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/musescore/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musescore/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/musescore/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/musescore/MuseScore/deployments","created_at":"2012-05-26T12:46:33Z","updated_at":"2018-12-10T07:57:23Z","pushed_at":"2018-12-10T07:57:00Z","git_url":"git://github.com/musescore/MuseScore.git","ssh_url":"git@github.com:musescore/MuseScore.git","clone_url":"https://github.com/musescore/MuseScore.git","svn_url":"https://github.com/musescore/MuseScore","homepage":"https://musescore.org","size":329906,"stargazers_count":3153,"watchers_count":3153,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1077,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1077,"open_issues":144,"watchers":3153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/4355"},"html":{"href":"https://github.com/musescore/MuseScore/pull/4355"},"issue":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/4355"},"comments":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/4355/comments"},"review_comments":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/4355/comments"},"review_comment":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/4355/commits"},"statuses":{"href":"https://api.github.com/repos/musescore/MuseScore/statuses/bb088cb470319dc6411a80bcdfdedca83df2fa92"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anatoly-os"}}