{"action":"closed","number":542,"pull_request":{"url":"https://api.github.com/repos/rooseveltframework/roosevelt/pulls/542","id":220410436,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDEwNDM2","html_url":"https://github.com/rooseveltframework/roosevelt/pull/542","diff_url":"https://github.com/rooseveltframework/roosevelt/pull/542.diff","patch_url":"https://github.com/rooseveltframework/roosevelt/pull/542.patch","issue_url":"https://api.github.com/repos/rooseveltframework/roosevelt/issues/542","number":542,"state":"closed","locked":false,"title":"Modified logger to consistently concatenate arguments into a string","user":{"login":"mulligan121","id":3014282,"node_id":"MDQ6VXNlcjMwMTQyODI=","avatar_url":"https://avatars3.githubusercontent.com/u/3014282?v=4","gravatar_id":"","url":"https://api.github.com/users/mulligan121","html_url":"https://github.com/mulligan121","followers_url":"https://api.github.com/users/mulligan121/followers","following_url":"https://api.github.com/users/mulligan121/following{/other_user}","gists_url":"https://api.github.com/users/mulligan121/gists{/gist_id}","starred_url":"https://api.github.com/users/mulligan121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulligan121/subscriptions","organizations_url":"https://api.github.com/users/mulligan121/orgs","repos_url":"https://api.github.com/users/mulligan121/repos","events_url":"https://api.github.com/users/mulligan121/events{/privacy}","received_events_url":"https://api.github.com/users/mulligan121/received_events","type":"User","site_admin":false},"body":"This fixes/closes #540  \r\n\r\nIf no arguments get passed into the logger it would never iterate through the `for loop` and convert the array into a string. Instead it would try to use `String.prototype.replace()` on the array which isn't a function. \r\n\r\nSo this PR just changes that array into a string at declaration and concatenates by default. This also adds more unit tests for the logger which check for empty logs and other data types.","created_at":"2018-10-04T14:58:51Z","updated_at":"2018-10-04T17:55:26Z","closed_at":"2018-10-04T17:55:26Z","merged_at":"2018-10-04T17:55:25Z","merge_commit_sha":"9efd8c4d39078e84fcb26a76fa3cc68d4a0a19e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rooseveltframework/roosevelt/pulls/542/commits","review_comments_url":"https://api.github.com/repos/rooseveltframework/roosevelt/pulls/542/comments","review_comment_url":"https://api.github.com/repos/rooseveltframework/roosevelt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rooseveltframework/roosevelt/issues/542/comments","statuses_url":"https://api.github.com/repos/rooseveltframework/roosevelt/statuses/807d6293c797f1ced79f0084e469c720066c2a30","head":{"label":"mulligan121:loggerFix","ref":"loggerFix","sha":"807d6293c797f1ced79f0084e469c720066c2a30","user":{"login":"mulligan121","id":3014282,"node_id":"MDQ6VXNlcjMwMTQyODI=","avatar_url":"https://avatars3.githubusercontent.com/u/3014282?v=4","gravatar_id":"","url":"https://api.github.com/users/mulligan121","html_url":"https://github.com/mulligan121","followers_url":"https://api.github.com/users/mulligan121/followers","following_url":"https://api.github.com/users/mulligan121/following{/other_user}","gists_url":"https://api.github.com/users/mulligan121/gists{/gist_id}","starred_url":"https://api.github.com/users/mulligan121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulligan121/subscriptions","organizations_url":"https://api.github.com/users/mulligan121/orgs","repos_url":"https://api.github.com/users/mulligan121/repos","events_url":"https://api.github.com/users/mulligan121/events{/privacy}","received_events_url":"https://api.github.com/users/mulligan121/received_events","type":"User","site_admin":false},"repo":{"id":134462345,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NjIzNDU=","name":"roosevelt","full_name":"mulligan121/roosevelt","private":false,"owner":{"login":"mulligan121","id":3014282,"node_id":"MDQ6VXNlcjMwMTQyODI=","avatar_url":"https://avatars3.githubusercontent.com/u/3014282?v=4","gravatar_id":"","url":"https://api.github.com/users/mulligan121","html_url":"https://github.com/mulligan121","followers_url":"https://api.github.com/users/mulligan121/followers","following_url":"https://api.github.com/users/mulligan121/following{/other_user}","gists_url":"https://api.github.com/users/mulligan121/gists{/gist_id}","starred_url":"https://api.github.com/users/mulligan121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulligan121/subscriptions","organizations_url":"https://api.github.com/users/mulligan121/orgs","repos_url":"https://api.github.com/users/mulligan121/repos","events_url":"https://api.github.com/users/mulligan121/events{/privacy}","received_events_url":"https://api.github.com/users/mulligan121/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mulligan121/roosevelt","description":"MVC web framework for Node.js designed to make Express easier to use.","fork":true,"url":"https://api.github.com/repos/mulligan121/roosevelt","forks_url":"https://api.github.com/repos/mulligan121/roosevelt/forks","keys_url":"https://api.github.com/repos/mulligan121/roosevelt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mulligan121/roosevelt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mulligan121/roosevelt/teams","hooks_url":"https://api.github.com/repos/mulligan121/roosevelt/hooks","issue_events_url":"https://api.github.com/repos/mulligan121/roosevelt/issues/events{/number}","events_url":"https://api.github.com/repos/mulligan121/roosevelt/events","assignees_url":"https://api.github.com/repos/mulligan121/roosevelt/assignees{/user}","branches_url":"https://api.github.com/repos/mulligan121/roosevelt/branches{/branch}","tags_url":"https://api.github.com/repos/mulligan121/roosevelt/tags","blobs_url":"https://api.github.com/repos/mulligan121/roosevelt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mulligan121/roosevelt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mulligan121/roosevelt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mulligan121/roosevelt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mulligan121/roosevelt/statuses/{sha}","languages_url":"https://api.github.com/repos/mulligan121/roosevelt/languages","stargazers_url":"https://api.github.com/repos/mulligan121/roosevelt/stargazers","contributors_url":"https://api.github.com/repos/mulligan121/roosevelt/contributors","subscribers_url":"https://api.github.com/repos/mulligan121/roosevelt/subscribers","subscription_url":"https://api.github.com/repos/mulligan121/roosevelt/subscription","commits_url":"https://api.github.com/repos/mulligan121/roosevelt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mulligan121/roosevelt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mulligan121/roosevelt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mulligan121/roosevelt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mulligan121/roosevelt/contents/{+path}","compare_url":"https://api.github.com/repos/mulligan121/roosevelt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mulligan121/roosevelt/merges","archive_url":"https://api.github.com/repos/mulligan121/roosevelt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mulligan121/roosevelt/downloads","issues_url":"https://api.github.com/repos/mulligan121/roosevelt/issues{/number}","pulls_url":"https://api.github.com/repos/mulligan121/roosevelt/pulls{/number}","milestones_url":"https://api.github.com/repos/mulligan121/roosevelt/milestones{/number}","notifications_url":"https://api.github.com/repos/mulligan121/roosevelt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mulligan121/roosevelt/labels{/name}","releases_url":"https://api.github.com/repos/mulligan121/roosevelt/releases{/id}","deployments_url":"https://api.github.com/repos/mulligan121/roosevelt/deployments","created_at":"2018-05-22T18:59:43Z","updated_at":"2018-10-04T13:05:08Z","pushed_at":"2018-10-04T14:42:14Z","git_url":"git://github.com/mulligan121/roosevelt.git","ssh_url":"git@github.com:mulligan121/roosevelt.git","clone_url":"https://github.com/mulligan121/roosevelt.git","svn_url":"https://github.com/mulligan121/roosevelt","homepage":"","size":2379,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rooseveltframework:master","ref":"master","sha":"be55d5542dcb311f31423d926d19514cd1214b51","user":{"login":"rooseveltframework","id":28904200,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTA0MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/28904200?v=4","gravatar_id":"","url":"https://api.github.com/users/rooseveltframework","html_url":"https://github.com/rooseveltframework","followers_url":"https://api.github.com/users/rooseveltframework/followers","following_url":"https://api.github.com/users/rooseveltframework/following{/other_user}","gists_url":"https://api.github.com/users/rooseveltframework/gists{/gist_id}","starred_url":"https://api.github.com/users/rooseveltframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rooseveltframework/subscriptions","organizations_url":"https://api.github.com/users/rooseveltframework/orgs","repos_url":"https://api.github.com/users/rooseveltframework/repos","events_url":"https://api.github.com/users/rooseveltframework/events{/privacy}","received_events_url":"https://api.github.com/users/rooseveltframework/received_events","type":"Organization","site_admin":false},"repo":{"id":8179851,"node_id":"MDEwOlJlcG9zaXRvcnk4MTc5ODUx","name":"roosevelt","full_name":"rooseveltframework/roosevelt","private":false,"owner":{"login":"rooseveltframework","id":28904200,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTA0MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/28904200?v=4","gravatar_id":"","url":"https://api.github.com/users/rooseveltframework","html_url":"https://github.com/rooseveltframework","followers_url":"https://api.github.com/users/rooseveltframework/followers","following_url":"https://api.github.com/users/rooseveltframework/following{/other_user}","gists_url":"https://api.github.com/users/rooseveltframework/gists{/gist_id}","starred_url":"https://api.github.com/users/rooseveltframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rooseveltframework/subscriptions","organizations_url":"https://api.github.com/users/rooseveltframework/orgs","repos_url":"https://api.github.com/users/rooseveltframework/repos","events_url":"https://api.github.com/users/rooseveltframework/events{/privacy}","received_events_url":"https://api.github.com/users/rooseveltframework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rooseveltframework/roosevelt","description":"MVC web framework for Node.js designed to make Express easier to use.","fork":false,"url":"https://api.github.com/repos/rooseveltframework/roosevelt","forks_url":"https://api.github.com/repos/rooseveltframework/roosevelt/forks","keys_url":"https://api.github.com/repos/rooseveltframework/roosevelt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rooseveltframework/roosevelt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rooseveltframework/roosevelt/teams","hooks_url":"https://api.github.com/repos/rooseveltframework/roosevelt/hooks","issue_events_url":"https://api.github.com/repos/rooseveltframework/roosevelt/issues/events{/number}","events_url":"https://api.github.com/repos/rooseveltframework/roosevelt/events","assignees_url":"https://api.github.com/repos/rooseveltframework/roosevelt/assignees{/user}","branches_url":"https://api.github.com/repos/rooseveltframework/roosevelt/branches{/branch}","tags_url":"https://api.github.com/repos/rooseveltframework/roosevelt/tags","blobs_url":"https://api.github.com/repos/rooseveltframework/roosevelt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rooseveltframework/roosevelt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rooseveltframework/roosevelt/git/refs{/sha}","trees_url":"https://api.github.com/repos/rooseveltframework/roosevelt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rooseveltframework/roosevelt/statuses/{sha}","languages_url":"https://api.github.com/repos/rooseveltframework/roosevelt/languages","stargazers_url":"https://api.github.com/repos/rooseveltframework/roosevelt/stargazers","contributors_url":"https://api.github.com/repos/rooseveltframework/roosevelt/contributors","subscribers_url":"https://api.github.com/repos/rooseveltframework/roosevelt/subscribers","subscription_url":"https://api.github.com/repos/rooseveltframework/roosevelt/subscription","commits_url":"https://api.github.com/repos/rooseveltframework/roosevelt/commits{/sha}","git_commits_url":"https://api.github.com/repos/rooseveltframework/roosevelt/git/commits{/sha}","comments_url":"https://api.github.com/repos/rooseveltframework/roosevelt/comments{/number}","issue_comment_url":"https://api.github.com/repos/rooseveltframework/roosevelt/issues/comments{/number}","contents_url":"https://api.github.com/repos/rooseveltframework/roosevelt/contents/{+path}","compare_url":"https://api.github.com/repos/rooseveltframework/roosevelt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rooseveltframework/roosevelt/merges","archive_url":"https://api.github.com/repos/rooseveltframework/roosevelt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rooseveltframework/roosevelt/downloads","issues_url":"https://api.github.com/repos/rooseveltframework/roosevelt/issues{/number}","pulls_url":"https://api.github.com/repos/rooseveltframework/roosevelt/pulls{/number}","milestones_url":"https://api.github.com/repos/rooseveltframework/roosevelt/milestones{/number}","notifications_url":"https://api.github.com/repos/rooseveltframework/roosevelt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rooseveltframework/roosevelt/labels{/name}","releases_url":"https://api.github.com/repos/rooseveltframework/roosevelt/releases{/id}","deployments_url":"https://api.github.com/repos/rooseveltframework/roosevelt/deployments","created_at":"2013-02-13T13:45:26Z","updated_at":"2018-09-28T09:10:12Z","pushed_at":"2018-10-04T17:55:25Z","git_url":"git://github.com/rooseveltframework/roosevelt.git","ssh_url":"git@github.com:rooseveltframework/roosevelt.git","clone_url":"https://github.com/rooseveltframework/roosevelt.git","svn_url":"https://github.com/rooseveltframework/roosevelt","homepage":"","size":2671,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":20,"open_issues":30,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rooseveltframework/roosevelt/pulls/542"},"html":{"href":"https://github.com/rooseveltframework/roosevelt/pull/542"},"issue":{"href":"https://api.github.com/repos/rooseveltframework/roosevelt/issues/542"},"comments":{"href":"https://api.github.com/repos/rooseveltframework/roosevelt/issues/542/comments"},"review_comments":{"href":"https://api.github.com/repos/rooseveltframework/roosevelt/pulls/542/comments"},"review_comment":{"href":"https://api.github.com/repos/rooseveltframework/roosevelt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rooseveltframework/roosevelt/pulls/542/commits"},"statuses":{"href":"https://api.github.com/repos/rooseveltframework/roosevelt/statuses/807d6293c797f1ced79f0084e469c720066c2a30"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kethinov","id":419567,"node_id":"MDQ6VXNlcjQxOTU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/419567?v=4","gravatar_id":"","url":"https://api.github.com/users/kethinov","html_url":"https://github.com/kethinov","followers_url":"https://api.github.com/users/kethinov/followers","following_url":"https://api.github.com/users/kethinov/following{/other_user}","gists_url":"https://api.github.com/users/kethinov/gists{/gist_id}","starred_url":"https://api.github.com/users/kethinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kethinov/subscriptions","organizations_url":"https://api.github.com/users/kethinov/orgs","repos_url":"https://api.github.com/users/kethinov/repos","events_url":"https://api.github.com/users/kethinov/events{/privacy}","received_events_url":"https://api.github.com/users/kethinov/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":36,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"kethinov"}}