{"action":"opened","number":6632,"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/6632","id":222902453,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTAyNDUz","html_url":"https://github.com/minio/minio/pull/6632","diff_url":"https://github.com/minio/minio/pull/6632.diff","patch_url":"https://github.com/minio/minio/pull/6632.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/6632","number":6632,"state":"open","locked":false,"title":"Add missing error check","user":{"login":"leitzler","id":3111805,"node_id":"MDQ6VXNlcjMxMTE4MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3111805?v=4","gravatar_id":"","url":"https://api.github.com/users/leitzler","html_url":"https://github.com/leitzler","followers_url":"https://api.github.com/users/leitzler/followers","following_url":"https://api.github.com/users/leitzler/following{/other_user}","gists_url":"https://api.github.com/users/leitzler/gists{/gist_id}","starred_url":"https://api.github.com/users/leitzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leitzler/subscriptions","organizations_url":"https://api.github.com/users/leitzler/orgs","repos_url":"https://api.github.com/users/leitzler/repos","events_url":"https://api.github.com/users/leitzler/events{/privacy}","received_events_url":"https://api.github.com/users/leitzler/received_events","type":"User","site_admin":false},"body":"GetObjectNInfo in disk-cache.go is missing an error check.\r\n\r\n## Description\r\nAdded error check.\r\n\r\n## Motivation and Context\r\nBackend call might fail silently.\r\n\r\n## How Has This Been Tested?\r\n`make test`\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed.","created_at":"2018-10-15T13:16:54Z","updated_at":"2018-10-15T13:16:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/6632/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/6632/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/6632/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/ec64bc36fc7f8c6b9b1f17828291cdee8e611b31","head":{"label":"zebware:add-missing-error-check","ref":"add-missing-error-check","sha":"ec64bc36fc7f8c6b9b1f17828291cdee8e611b31","user":{"login":"zebware","id":16755728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzU1NzI4","avatar_url":"https://avatars2.githubusercontent.com/u/16755728?v=4","gravatar_id":"","url":"https://api.github.com/users/zebware","html_url":"https://github.com/zebware","followers_url":"https://api.github.com/users/zebware/followers","following_url":"https://api.github.com/users/zebware/following{/other_user}","gists_url":"https://api.github.com/users/zebware/gists{/gist_id}","starred_url":"https://api.github.com/users/zebware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zebware/subscriptions","organizations_url":"https://api.github.com/users/zebware/orgs","repos_url":"https://api.github.com/users/zebware/repos","events_url":"https://api.github.com/users/zebware/events{/privacy}","received_events_url":"https://api.github.com/users/zebware/received_events","type":"Organization","site_admin":false},"repo":{"id":100690621,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA2OTA2MjE=","name":"minio","full_name":"zebware/minio","private":false,"owner":{"login":"zebware","id":16755728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzU1NzI4","avatar_url":"https://avatars2.githubusercontent.com/u/16755728?v=4","gravatar_id":"","url":"https://api.github.com/users/zebware","html_url":"https://github.com/zebware","followers_url":"https://api.github.com/users/zebware/followers","following_url":"https://api.github.com/users/zebware/following{/other_user}","gists_url":"https://api.github.com/users/zebware/gists{/gist_id}","starred_url":"https://api.github.com/users/zebware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zebware/subscriptions","organizations_url":"https://api.github.com/users/zebware/orgs","repos_url":"https://api.github.com/users/zebware/repos","events_url":"https://api.github.com/users/zebware/events{/privacy}","received_events_url":"https://api.github.com/users/zebware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zebware/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":true,"url":"https://api.github.com/repos/zebware/minio","forks_url":"https://api.github.com/repos/zebware/minio/forks","keys_url":"https://api.github.com/repos/zebware/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zebware/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zebware/minio/teams","hooks_url":"https://api.github.com/repos/zebware/minio/hooks","issue_events_url":"https://api.github.com/repos/zebware/minio/issues/events{/number}","events_url":"https://api.github.com/repos/zebware/minio/events","assignees_url":"https://api.github.com/repos/zebware/minio/assignees{/user}","branches_url":"https://api.github.com/repos/zebware/minio/branches{/branch}","tags_url":"https://api.github.com/repos/zebware/minio/tags","blobs_url":"https://api.github.com/repos/zebware/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zebware/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zebware/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/zebware/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zebware/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/zebware/minio/languages","stargazers_url":"https://api.github.com/repos/zebware/minio/stargazers","contributors_url":"https://api.github.com/repos/zebware/minio/contributors","subscribers_url":"https://api.github.com/repos/zebware/minio/subscribers","subscription_url":"https://api.github.com/repos/zebware/minio/subscription","commits_url":"https://api.github.com/repos/zebware/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/zebware/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/zebware/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/zebware/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/zebware/minio/contents/{+path}","compare_url":"https://api.github.com/repos/zebware/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zebware/minio/merges","archive_url":"https://api.github.com/repos/zebware/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zebware/minio/downloads","issues_url":"https://api.github.com/repos/zebware/minio/issues{/number}","pulls_url":"https://api.github.com/repos/zebware/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/zebware/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/zebware/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zebware/minio/labels{/name}","releases_url":"https://api.github.com/repos/zebware/minio/releases{/id}","deployments_url":"https://api.github.com/repos/zebware/minio/deployments","created_at":"2017-08-18T08:26:58Z","updated_at":"2018-09-25T07:16:17Z","pushed_at":"2018-10-15T13:10:56Z","git_url":"git://github.com/zebware/minio.git","ssh_url":"git@github.com:zebware/minio.git","clone_url":"https://github.com/zebware/minio.git","svn_url":"https://github.com/zebware/minio","homepage":"https://minio.io","size":43503,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"3ef3fefd5483696bd5d38f8cd9e2f37e6feaeed3","user":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI2MTQ3Mw==","name":"minio","full_name":"minio/minio","private":false,"owner":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2018-10-15T11:39:16Z","pushed_at":"2018-10-15T12:46:30Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":43081,"stargazers_count":13183,"watchers_count":13183,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1180,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1180,"open_issues":159,"watchers":13183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/6632"},"html":{"href":"https://github.com/minio/minio/pull/6632"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/6632"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/6632/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/6632/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/6632/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/ec64bc36fc7f8c6b9b1f17828291cdee8e611b31"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"leitzler"}}