{"action":"created","issue":{"url":"https://api.github.com/repos/d3lm/ngx-drag-to-select/issues/22","repository_url":"https://api.github.com/repos/d3lm/ngx-drag-to-select","labels_url":"https://api.github.com/repos/d3lm/ngx-drag-to-select/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/d3lm/ngx-drag-to-select/issues/22/comments","events_url":"https://api.github.com/repos/d3lm/ngx-drag-to-select/issues/22/events","html_url":"https://github.com/d3lm/ngx-drag-to-select/pull/22","id":337198975,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDY3MDk3","number":22,"title":"refactor: remove use of proxy to support IE","user":{"login":"mattlewis92","id":6425649,"node_id":"MDQ6VXNlcjY0MjU2NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6425649?v=4","gravatar_id":"","url":"https://api.github.com/users/mattlewis92","html_url":"https://github.com/mattlewis92","followers_url":"https://api.github.com/users/mattlewis92/followers","following_url":"https://api.github.com/users/mattlewis92/following{/other_user}","gists_url":"https://api.github.com/users/mattlewis92/gists{/gist_id}","starred_url":"https://api.github.com/users/mattlewis92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattlewis92/subscriptions","organizations_url":"https://api.github.com/users/mattlewis92/orgs","repos_url":"https://api.github.com/users/mattlewis92/repos","events_url":"https://api.github.com/users/mattlewis92/events{/privacy}","received_events_url":"https://api.github.com/users/mattlewis92/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-30T08:47:00Z","updated_at":"2018-07-05T13:04:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/d3lm/ngx-drag-to-select/pulls/22","html_url":"https://github.com/d3lm/ngx-drag-to-select/pull/22","diff_url":"https://github.com/d3lm/ngx-drag-to-select/pull/22.diff","patch_url":"https://github.com/d3lm/ngx-drag-to-select/pull/22.patch"},"body":"It felt so wrong to remove this as it was such a nice implementation, but it should mean this will work with IE now (which doesn't support proxies and they're only partially polyfillable 😢)"},"comment":{"url":"https://api.github.com/repos/d3lm/ngx-drag-to-select/issues/comments/402714985","html_url":"https://github.com/d3lm/ngx-drag-to-select/pull/22#issuecomment-402714985","issue_url":"https://api.github.com/repos/d3lm/ngx-drag-to-select/issues/22","id":402714985,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjcxNDk4NQ==","user":{"login":"d3lm","id":12571019,"node_id":"MDQ6VXNlcjEyNTcxMDE5","avatar_url":"https://avatars1.githubusercontent.com/u/12571019?v=4","gravatar_id":"","url":"https://api.github.com/users/d3lm","html_url":"https://github.com/d3lm","followers_url":"https://api.github.com/users/d3lm/followers","following_url":"https://api.github.com/users/d3lm/following{/other_user}","gists_url":"https://api.github.com/users/d3lm/gists{/gist_id}","starred_url":"https://api.github.com/users/d3lm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3lm/subscriptions","organizations_url":"https://api.github.com/users/d3lm/orgs","repos_url":"https://api.github.com/users/d3lm/repos","events_url":"https://api.github.com/users/d3lm/events{/privacy}","received_events_url":"https://api.github.com/users/d3lm/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T13:04:48Z","updated_at":"2018-07-05T13:04:48Z","author_association":"OWNER","body":"I am thinking whether we should refactor the code a little bit more so that we get rid of subscribing inside `selectItem` and `deselectItem`. What do you think? Maybe we can even refactor it so that we only subscribe once to each stream and not every time we call that method. I am just thinking out loud here. Pulling in @cartant or @KwintenP for some help or ideas. Otherwise we could also merge it and refactor this later. Any thoughts?"}}
{"actor":{"display_login":"d3lm"}}