{"action":"closed","number":45,"pull_request":{"url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/pulls/45","id":131782424,"html_url":"https://github.com/SuperNEMO-DBD/Falaise/pull/45","diff_url":"https://github.com/SuperNEMO-DBD/Falaise/pull/45.diff","patch_url":"https://github.com/SuperNEMO-DBD/Falaise/pull/45.patch","issue_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/issues/45","number":45,"state":"closed","locked":false,"title":"Fix event header cut","user":{"login":"drbenmorgan","id":1102642,"avatar_url":"https://avatars0.githubusercontent.com/u/1102642?v=4","gravatar_id":"","url":"https://api.github.com/users/drbenmorgan","html_url":"https://github.com/drbenmorgan","followers_url":"https://api.github.com/users/drbenmorgan/followers","following_url":"https://api.github.com/users/drbenmorgan/following{/other_user}","gists_url":"https://api.github.com/users/drbenmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/drbenmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbenmorgan/subscriptions","organizations_url":"https://api.github.com/users/drbenmorgan/orgs","repos_url":"https://api.github.com/users/drbenmorgan/repos","events_url":"https://api.github.com/users/drbenmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/drbenmorgan/received_events","type":"User","site_admin":false},"body":"As found in #35 and reported in BxCppDev/Bayeux/issues/9, use of the streaming operator to read `datatools::event_id` objects from input strings results in invalid run/event numbers where the \"any\" flags has been supplied. This breaks event header selection downstream of `flsimulate` as this sets the run number in the event header to the \"any\" flags as recommended in #37.\r\n\r\nThis PR provides a workaround for the issue until BxCppDev/Bayeux/issues/9 is resolved and Falaise uses a release with a resolution. The code to construct a `datatools::event_id` from an `istream` has been imported into `event_header_cut` as a private factory function. Direct construction is used to workaround the buggy `event_id::set` member function, but otherwise the implementation is the same, as is error handling.\r\n\r\nThe relevant areas of `event_header_cut` are updated to use this function, and a basic set of tests is provided to check behaviour. Invalid `event_id` are always read, but are now stripped from the stored list in both of the read methods (property list vs file list).\r\n\r\nC++11 constructs have been used where possible, and the formatting has been unified.  ","created_at":"2017-07-21T14:09:11Z","updated_at":"2018-04-09T11:40:10Z","closed_at":"2018-04-09T11:40:10Z","merged_at":null,"merge_commit_sha":"b4c287f446718453b61288702e3686ef9f675671","assignee":{"login":"fmauger","id":13448163,"avatar_url":"https://avatars0.githubusercontent.com/u/13448163?v=4","gravatar_id":"","url":"https://api.github.com/users/fmauger","html_url":"https://github.com/fmauger","followers_url":"https://api.github.com/users/fmauger/followers","following_url":"https://api.github.com/users/fmauger/following{/other_user}","gists_url":"https://api.github.com/users/fmauger/gists{/gist_id}","starred_url":"https://api.github.com/users/fmauger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmauger/subscriptions","organizations_url":"https://api.github.com/users/fmauger/orgs","repos_url":"https://api.github.com/users/fmauger/repos","events_url":"https://api.github.com/users/fmauger/events{/privacy}","received_events_url":"https://api.github.com/users/fmauger/received_events","type":"User","site_admin":false},"assignees":[{"login":"fmauger","id":13448163,"avatar_url":"https://avatars0.githubusercontent.com/u/13448163?v=4","gravatar_id":"","url":"https://api.github.com/users/fmauger","html_url":"https://github.com/fmauger","followers_url":"https://api.github.com/users/fmauger/followers","following_url":"https://api.github.com/users/fmauger/following{/other_user}","gists_url":"https://api.github.com/users/fmauger/gists{/gist_id}","starred_url":"https://api.github.com/users/fmauger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmauger/subscriptions","organizations_url":"https://api.github.com/users/fmauger/orgs","repos_url":"https://api.github.com/users/fmauger/repos","events_url":"https://api.github.com/users/fmauger/events{/privacy}","received_events_url":"https://api.github.com/users/fmauger/received_events","type":"User","site_admin":false},{"login":"goliviero","id":19649307,"avatar_url":"https://avatars3.githubusercontent.com/u/19649307?v=4","gravatar_id":"","url":"https://api.github.com/users/goliviero","html_url":"https://github.com/goliviero","followers_url":"https://api.github.com/users/goliviero/followers","following_url":"https://api.github.com/users/goliviero/following{/other_user}","gists_url":"https://api.github.com/users/goliviero/gists{/gist_id}","starred_url":"https://api.github.com/users/goliviero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goliviero/subscriptions","organizations_url":"https://api.github.com/users/goliviero/orgs","repos_url":"https://api.github.com/users/goliviero/repos","events_url":"https://api.github.com/users/goliviero/events{/privacy}","received_events_url":"https://api.github.com/users/goliviero/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fmauger","id":13448163,"avatar_url":"https://avatars0.githubusercontent.com/u/13448163?v=4","gravatar_id":"","url":"https://api.github.com/users/fmauger","html_url":"https://github.com/fmauger","followers_url":"https://api.github.com/users/fmauger/followers","following_url":"https://api.github.com/users/fmauger/following{/other_user}","gists_url":"https://api.github.com/users/fmauger/gists{/gist_id}","starred_url":"https://api.github.com/users/fmauger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmauger/subscriptions","organizations_url":"https://api.github.com/users/fmauger/orgs","repos_url":"https://api.github.com/users/fmauger/repos","events_url":"https://api.github.com/users/fmauger/events{/privacy}","received_events_url":"https://api.github.com/users/fmauger/received_events","type":"User","site_admin":false},{"login":"goliviero","id":19649307,"avatar_url":"https://avatars3.githubusercontent.com/u/19649307?v=4","gravatar_id":"","url":"https://api.github.com/users/goliviero","html_url":"https://github.com/goliviero","followers_url":"https://api.github.com/users/goliviero/followers","following_url":"https://api.github.com/users/goliviero/following{/other_user}","gists_url":"https://api.github.com/users/goliviero/gists{/gist_id}","starred_url":"https://api.github.com/users/goliviero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goliviero/subscriptions","organizations_url":"https://api.github.com/users/goliviero/orgs","repos_url":"https://api.github.com/users/goliviero/repos","events_url":"https://api.github.com/users/goliviero/events{/privacy}","received_events_url":"https://api.github.com/users/goliviero/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":597866683,"url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/pulls/45/commits","review_comments_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/pulls/45/comments","review_comment_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/issues/45/comments","statuses_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/statuses/fcdfef63d097bd4983921ef524ff69e2b5513279","head":{"label":"drbenmorgan:fix-event-header-cut","ref":"fix-event-header-cut","sha":"fcdfef63d097bd4983921ef524ff69e2b5513279","user":{"login":"drbenmorgan","id":1102642,"avatar_url":"https://avatars0.githubusercontent.com/u/1102642?v=4","gravatar_id":"","url":"https://api.github.com/users/drbenmorgan","html_url":"https://github.com/drbenmorgan","followers_url":"https://api.github.com/users/drbenmorgan/followers","following_url":"https://api.github.com/users/drbenmorgan/following{/other_user}","gists_url":"https://api.github.com/users/drbenmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/drbenmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbenmorgan/subscriptions","organizations_url":"https://api.github.com/users/drbenmorgan/orgs","repos_url":"https://api.github.com/users/drbenmorgan/repos","events_url":"https://api.github.com/users/drbenmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/drbenmorgan/received_events","type":"User","site_admin":false},"repo":{"id":90749509,"name":"Falaise","full_name":"drbenmorgan/Falaise","owner":{"login":"drbenmorgan","id":1102642,"avatar_url":"https://avatars0.githubusercontent.com/u/1102642?v=4","gravatar_id":"","url":"https://api.github.com/users/drbenmorgan","html_url":"https://github.com/drbenmorgan","followers_url":"https://api.github.com/users/drbenmorgan/followers","following_url":"https://api.github.com/users/drbenmorgan/following{/other_user}","gists_url":"https://api.github.com/users/drbenmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/drbenmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbenmorgan/subscriptions","organizations_url":"https://api.github.com/users/drbenmorgan/orgs","repos_url":"https://api.github.com/users/drbenmorgan/repos","events_url":"https://api.github.com/users/drbenmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/drbenmorgan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drbenmorgan/Falaise","description":"Simulation, Reconstruction and Analysis for the SuperNEMO Experiment","fork":true,"url":"https://api.github.com/repos/drbenmorgan/Falaise","forks_url":"https://api.github.com/repos/drbenmorgan/Falaise/forks","keys_url":"https://api.github.com/repos/drbenmorgan/Falaise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drbenmorgan/Falaise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drbenmorgan/Falaise/teams","hooks_url":"https://api.github.com/repos/drbenmorgan/Falaise/hooks","issue_events_url":"https://api.github.com/repos/drbenmorgan/Falaise/issues/events{/number}","events_url":"https://api.github.com/repos/drbenmorgan/Falaise/events","assignees_url":"https://api.github.com/repos/drbenmorgan/Falaise/assignees{/user}","branches_url":"https://api.github.com/repos/drbenmorgan/Falaise/branches{/branch}","tags_url":"https://api.github.com/repos/drbenmorgan/Falaise/tags","blobs_url":"https://api.github.com/repos/drbenmorgan/Falaise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drbenmorgan/Falaise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drbenmorgan/Falaise/git/refs{/sha}","trees_url":"https://api.github.com/repos/drbenmorgan/Falaise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drbenmorgan/Falaise/statuses/{sha}","languages_url":"https://api.github.com/repos/drbenmorgan/Falaise/languages","stargazers_url":"https://api.github.com/repos/drbenmorgan/Falaise/stargazers","contributors_url":"https://api.github.com/repos/drbenmorgan/Falaise/contributors","subscribers_url":"https://api.github.com/repos/drbenmorgan/Falaise/subscribers","subscription_url":"https://api.github.com/repos/drbenmorgan/Falaise/subscription","commits_url":"https://api.github.com/repos/drbenmorgan/Falaise/commits{/sha}","git_commits_url":"https://api.github.com/repos/drbenmorgan/Falaise/git/commits{/sha}","comments_url":"https://api.github.com/repos/drbenmorgan/Falaise/comments{/number}","issue_comment_url":"https://api.github.com/repos/drbenmorgan/Falaise/issues/comments{/number}","contents_url":"https://api.github.com/repos/drbenmorgan/Falaise/contents/{+path}","compare_url":"https://api.github.com/repos/drbenmorgan/Falaise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drbenmorgan/Falaise/merges","archive_url":"https://api.github.com/repos/drbenmorgan/Falaise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drbenmorgan/Falaise/downloads","issues_url":"https://api.github.com/repos/drbenmorgan/Falaise/issues{/number}","pulls_url":"https://api.github.com/repos/drbenmorgan/Falaise/pulls{/number}","milestones_url":"https://api.github.com/repos/drbenmorgan/Falaise/milestones{/number}","notifications_url":"https://api.github.com/repos/drbenmorgan/Falaise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drbenmorgan/Falaise/labels{/name}","releases_url":"https://api.github.com/repos/drbenmorgan/Falaise/releases{/id}","deployments_url":"https://api.github.com/repos/drbenmorgan/Falaise/deployments","created_at":"2017-05-09T13:34:14Z","updated_at":"2018-03-27T18:29:34Z","pushed_at":"2018-03-27T18:29:53Z","git_url":"git://github.com/drbenmorgan/Falaise.git","ssh_url":"git@github.com:drbenmorgan/Falaise.git","clone_url":"https://github.com/drbenmorgan/Falaise.git","svn_url":"https://github.com/drbenmorgan/Falaise","homepage":"https://supernemo-dbd.github.io/Falaise","size":20107,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"SuperNEMO-DBD:develop","ref":"develop","sha":"4778322abb4c8f1499fa5718c79a1f9e7a9fa5b0","user":{"login":"SuperNEMO-DBD","id":12397332,"avatar_url":"https://avatars0.githubusercontent.com/u/12397332?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperNEMO-DBD","html_url":"https://github.com/SuperNEMO-DBD","followers_url":"https://api.github.com/users/SuperNEMO-DBD/followers","following_url":"https://api.github.com/users/SuperNEMO-DBD/following{/other_user}","gists_url":"https://api.github.com/users/SuperNEMO-DBD/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperNEMO-DBD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperNEMO-DBD/subscriptions","organizations_url":"https://api.github.com/users/SuperNEMO-DBD/orgs","repos_url":"https://api.github.com/users/SuperNEMO-DBD/repos","events_url":"https://api.github.com/users/SuperNEMO-DBD/events{/privacy}","received_events_url":"https://api.github.com/users/SuperNEMO-DBD/received_events","type":"Organization","site_admin":false},"repo":{"id":90256992,"name":"Falaise","full_name":"SuperNEMO-DBD/Falaise","owner":{"login":"SuperNEMO-DBD","id":12397332,"avatar_url":"https://avatars0.githubusercontent.com/u/12397332?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperNEMO-DBD","html_url":"https://github.com/SuperNEMO-DBD","followers_url":"https://api.github.com/users/SuperNEMO-DBD/followers","following_url":"https://api.github.com/users/SuperNEMO-DBD/following{/other_user}","gists_url":"https://api.github.com/users/SuperNEMO-DBD/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperNEMO-DBD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperNEMO-DBD/subscriptions","organizations_url":"https://api.github.com/users/SuperNEMO-DBD/orgs","repos_url":"https://api.github.com/users/SuperNEMO-DBD/repos","events_url":"https://api.github.com/users/SuperNEMO-DBD/events{/privacy}","received_events_url":"https://api.github.com/users/SuperNEMO-DBD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SuperNEMO-DBD/Falaise","description":"Simulation, Reconstruction and Analysis for the SuperNEMO Experiment","fork":false,"url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise","forks_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/forks","keys_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/teams","hooks_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/hooks","issue_events_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/issues/events{/number}","events_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/events","assignees_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/assignees{/user}","branches_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/branches{/branch}","tags_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/tags","blobs_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/statuses/{sha}","languages_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/languages","stargazers_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/stargazers","contributors_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/contributors","subscribers_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/subscribers","subscription_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/subscription","commits_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/contents/{+path}","compare_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/merges","archive_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/downloads","issues_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/issues{/number}","pulls_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/pulls{/number}","milestones_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/milestones{/number}","notifications_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/labels{/name}","releases_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/releases{/id}","deployments_url":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/deployments","created_at":"2017-05-04T11:46:20Z","updated_at":"2018-04-09T11:39:28Z","pushed_at":"2018-04-09T11:39:25Z","git_url":"git://github.com/SuperNEMO-DBD/Falaise.git","ssh_url":"git@github.com:SuperNEMO-DBD/Falaise.git","clone_url":"https://github.com/SuperNEMO-DBD/Falaise.git","svn_url":"https://github.com/SuperNEMO-DBD/Falaise","homepage":"http://supernemo.org/Falaise","size":20341,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":26,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/pulls/45"},"html":{"href":"https://github.com/SuperNEMO-DBD/Falaise/pull/45"},"issue":{"href":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/issues/45"},"comments":{"href":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/SuperNEMO-DBD/Falaise/statuses/fcdfef63d097bd4983921ef524ff69e2b5513279"}},"author_association":"OWNER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":680,"deletions":648,"changed_files":5}}
{"actor":{"display_login":"drbenmorgan"}}