{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/207684195","pull_request_review_id":143354979,"id":207684195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzY4NDE5NQ==","diff_hunk":"@@ -8,16 +8,31 @@\n \n namespace System.Security.Cryptography\n {\n-    internal static class Helpers\n+    internal static class KeySizeHelpers\n     {\n-        public static byte[] CloneByteArray(this byte[] src)\n+        public static KeySizes[] CloneKeySizesArray(this KeySizes[] src)\n         {\n-            if (src == null)\n+            return (KeySizes[])(src.Clone());\n+        }\n+\n+        public static bool UsesIv(this CipherMode cipherMode)","path":"src/Common/src/System/Security/Cryptography/KeySizeHelpers.cs","position":14,"original_position":14,"commit_id":"b6f33df5caf3b3d62eadac09fc445ef8fdf08a37","original_commit_id":"b6f33df5caf3b3d62eadac09fc445ef8fdf08a37","user":{"login":"bartonjs","id":10642668,"node_id":"MDQ6VXNlcjEwNjQyNjY4","avatar_url":"https://avatars3.githubusercontent.com/u/10642668?v=4","gravatar_id":"","url":"https://api.github.com/users/bartonjs","html_url":"https://github.com/bartonjs","followers_url":"https://api.github.com/users/bartonjs/followers","following_url":"https://api.github.com/users/bartonjs/following{/other_user}","gists_url":"https://api.github.com/users/bartonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bartonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartonjs/subscriptions","organizations_url":"https://api.github.com/users/bartonjs/orgs","repos_url":"https://api.github.com/users/bartonjs/repos","events_url":"https://api.github.com/users/bartonjs/events{/privacy}","received_events_url":"https://api.github.com/users/bartonjs/received_events","type":"User","site_admin":false},"body":"This isn't a KeySizes operation.","created_at":"2018-08-03T22:47:39Z","updated_at":"2018-08-03T22:47:39Z","html_url":"https://github.com/dotnet/corefx/pull/31578#discussion_r207684195","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/31578","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/207684195"},"html":{"href":"https://github.com/dotnet/corefx/pull/31578#discussion_r207684195"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31578"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/31578","id":206006591,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDA2NTkx","html_url":"https://github.com/dotnet/corefx/pull/31578","diff_url":"https://github.com/dotnet/corefx/pull/31578.diff","patch_url":"https://github.com/dotnet/corefx/pull/31578.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/31578","number":31578,"state":"open","locked":false,"title":"System.Security: Consolidate IsLegalKeySize and related methods into common code.","user":{"login":"filipnavara","id":1764393,"node_id":"MDQ6VXNlcjE3NjQzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1764393?v=4","gravatar_id":"","url":"https://api.github.com/users/filipnavara","html_url":"https://github.com/filipnavara","followers_url":"https://api.github.com/users/filipnavara/followers","following_url":"https://api.github.com/users/filipnavara/following{/other_user}","gists_url":"https://api.github.com/users/filipnavara/gists{/gist_id}","starred_url":"https://api.github.com/users/filipnavara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipnavara/subscriptions","organizations_url":"https://api.github.com/users/filipnavara/orgs","repos_url":"https://api.github.com/users/filipnavara/repos","events_url":"https://api.github.com/users/filipnavara/events{/privacy}","received_events_url":"https://api.github.com/users/filipnavara/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-03T11:47:42Z","updated_at":"2018-08-03T22:47:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ac15c4c57af890380583a09db31f4526296c220","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/31578/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/31578/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/31578/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/b6f33df5caf3b3d62eadac09fc445ef8fdf08a37","head":{"label":"filipnavara:asn-keysizehelpers","ref":"asn-keysizehelpers","sha":"b6f33df5caf3b3d62eadac09fc445ef8fdf08a37","user":{"login":"filipnavara","id":1764393,"node_id":"MDQ6VXNlcjE3NjQzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1764393?v=4","gravatar_id":"","url":"https://api.github.com/users/filipnavara","html_url":"https://github.com/filipnavara","followers_url":"https://api.github.com/users/filipnavara/followers","following_url":"https://api.github.com/users/filipnavara/following{/other_user}","gists_url":"https://api.github.com/users/filipnavara/gists{/gist_id}","starred_url":"https://api.github.com/users/filipnavara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipnavara/subscriptions","organizations_url":"https://api.github.com/users/filipnavara/orgs","repos_url":"https://api.github.com/users/filipnavara/repos","events_url":"https://api.github.com/users/filipnavara/events{/privacy}","received_events_url":"https://api.github.com/users/filipnavara/received_events","type":"User","site_admin":false},"repo":{"id":135734017,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3MzQwMTc=","name":"corefx","full_name":"filipnavara/corefx","owner":{"login":"filipnavara","id":1764393,"node_id":"MDQ6VXNlcjE3NjQzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1764393?v=4","gravatar_id":"","url":"https://api.github.com/users/filipnavara","html_url":"https://github.com/filipnavara","followers_url":"https://api.github.com/users/filipnavara/followers","following_url":"https://api.github.com/users/filipnavara/following{/other_user}","gists_url":"https://api.github.com/users/filipnavara/gists{/gist_id}","starred_url":"https://api.github.com/users/filipnavara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipnavara/subscriptions","organizations_url":"https://api.github.com/users/filipnavara/orgs","repos_url":"https://api.github.com/users/filipnavara/repos","events_url":"https://api.github.com/users/filipnavara/events{/privacy}","received_events_url":"https://api.github.com/users/filipnavara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filipnavara/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/filipnavara/corefx","forks_url":"https://api.github.com/repos/filipnavara/corefx/forks","keys_url":"https://api.github.com/repos/filipnavara/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filipnavara/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filipnavara/corefx/teams","hooks_url":"https://api.github.com/repos/filipnavara/corefx/hooks","issue_events_url":"https://api.github.com/repos/filipnavara/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/filipnavara/corefx/events","assignees_url":"https://api.github.com/repos/filipnavara/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/filipnavara/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/filipnavara/corefx/tags","blobs_url":"https://api.github.com/repos/filipnavara/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filipnavara/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filipnavara/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/filipnavara/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filipnavara/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/filipnavara/corefx/languages","stargazers_url":"https://api.github.com/repos/filipnavara/corefx/stargazers","contributors_url":"https://api.github.com/repos/filipnavara/corefx/contributors","subscribers_url":"https://api.github.com/repos/filipnavara/corefx/subscribers","subscription_url":"https://api.github.com/repos/filipnavara/corefx/subscription","commits_url":"https://api.github.com/repos/filipnavara/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/filipnavara/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/filipnavara/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/filipnavara/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/filipnavara/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/filipnavara/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filipnavara/corefx/merges","archive_url":"https://api.github.com/repos/filipnavara/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filipnavara/corefx/downloads","issues_url":"https://api.github.com/repos/filipnavara/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/filipnavara/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/filipnavara/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/filipnavara/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filipnavara/corefx/labels{/name}","releases_url":"https://api.github.com/repos/filipnavara/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/filipnavara/corefx/deployments","created_at":"2018-06-01T15:25:02Z","updated_at":"2018-08-03T11:49:43Z","pushed_at":"2018-08-03T12:06:21Z","git_url":"git://github.com/filipnavara/corefx.git","ssh_url":"git@github.com:filipnavara/corefx.git","clone_url":"https://github.com/filipnavara/corefx.git","svn_url":"https://github.com/filipnavara/corefx","homepage":"https://github.com/dotnet/core","size":186459,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"23915a606017197aed1d24960096b532d24d626e","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-08-03T22:17:27Z","pushed_at":"2018-08-03T22:17:12Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":185203,"stargazers_count":14524,"watchers_count":14524,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4204,"mirror_url":null,"archived":false,"open_issues_count":2533,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4204,"open_issues":2533,"watchers":14524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31578"},"html":{"href":"https://github.com/dotnet/corefx/pull/31578"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/31578"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/31578/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31578/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31578/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/b6f33df5caf3b3d62eadac09fc445ef8fdf08a37"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bartonjs"}}