{"action":"created","comment":{"url":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/comments/243064589","pull_request_review_id":186730071,"id":243064589,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzA2NDU4OQ==","diff_hunk":"@@ -0,0 +1,70 @@\n+/*\n+ * Copyright 2018 Dropbox, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.arpnetworking.metrics.portal.reports.impl;\n+\n+import com.arpnetworking.metrics.portal.reports.Job;\n+import com.arpnetworking.metrics.portal.reports.JobRepository;\n+import com.google.common.collect.Maps;\n+import com.google.inject.Inject;\n+\n+import java.util.Map;\n+import java.util.concurrent.atomic.AtomicLong;\n+import java.util.stream.Stream;\n+import javax.annotation.Nullable;\n+\n+/**\n+ * A simple in-memory {@link JobRepository}. Not in any way persistent.\n+ *\n+ * @author Spencer Pearson\n+ */\n+public final class MapJobRepository implements JobRepository {\n+\n+    /**\n+     * Guice constructor.\n+     */\n+    @Inject\n+    public MapJobRepository() {}\n+\n+    private final AtomicLong _nonce = new AtomicLong(0);\n+    private final Map<String, Job> _specs = Maps.newConcurrentMap();\n+    @Override","path":"app/com/arpnetworking/metrics/portal/reports/impl/MapJobRepository.java","position":43,"original_position":43,"commit_id":"3dbba0391678b9679bb56bad3d4823e24d3df82a","original_commit_id":"1812e2d0757eaedebb643d9484e935e6e3688a3e","user":{"login":"vjkoskela","id":1775197,"node_id":"MDQ6VXNlcjE3NzUxOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1775197?v=4","gravatar_id":"","url":"https://api.github.com/users/vjkoskela","html_url":"https://github.com/vjkoskela","followers_url":"https://api.github.com/users/vjkoskela/followers","following_url":"https://api.github.com/users/vjkoskela/following{/other_user}","gists_url":"https://api.github.com/users/vjkoskela/gists{/gist_id}","starred_url":"https://api.github.com/users/vjkoskela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjkoskela/subscriptions","organizations_url":"https://api.github.com/users/vjkoskela/orgs","repos_url":"https://api.github.com/users/vjkoskela/repos","events_url":"https://api.github.com/users/vjkoskela/events{/privacy}","received_events_url":"https://api.github.com/users/vjkoskela/received_events","type":"User","site_admin":false},"body":"nit: missing blank line","created_at":"2018-12-19T20:29:06Z","updated_at":"2018-12-19T20:31:47Z","html_url":"https://github.com/ArpNetworking/metrics-portal/pull/135#discussion_r243064589","pull_request_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/135","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/comments/243064589"},"html":{"href":"https://github.com/ArpNetworking/metrics-portal/pull/135#discussion_r243064589"},"pull_request":{"href":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/135","id":239668142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NjY4MTQy","html_url":"https://github.com/ArpNetworking/metrics-portal/pull/135","diff_url":"https://github.com/ArpNetworking/metrics-portal/pull/135.diff","patch_url":"https://github.com/ArpNetworking/metrics-portal/pull/135.patch","issue_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/issues/135","number":135,"state":"open","locked":false,"title":"Report scheduling","user":{"login":"speezepearson","id":1899701,"node_id":"MDQ6VXNlcjE4OTk3MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1899701?v=4","gravatar_id":"","url":"https://api.github.com/users/speezepearson","html_url":"https://github.com/speezepearson","followers_url":"https://api.github.com/users/speezepearson/followers","following_url":"https://api.github.com/users/speezepearson/following{/other_user}","gists_url":"https://api.github.com/users/speezepearson/gists{/gist_id}","starred_url":"https://api.github.com/users/speezepearson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/speezepearson/subscriptions","organizations_url":"https://api.github.com/users/speezepearson/orgs","repos_url":"https://api.github.com/users/speezepearson/repos","events_url":"https://api.github.com/users/speezepearson/events{/privacy}","received_events_url":"https://api.github.com/users/speezepearson/received_events","type":"User","site_admin":false},"body":"First steps towards adding reporting:\r\n- ReportSpec and ReportSink interfaces for generating/sending reports\r\n- Job dataclass which ties together details about a recurring reporting job\r\n- JobRepository interface for storing Jobs\r\n- Simplest possible implementations of those interfaces, for examples/testing\r\n- JobScheduler actor, and tests","created_at":"2018-12-18T23:41:32Z","updated_at":"2018-12-19T20:31:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5480249a6f89668dcf76cd5c23e439723fe1bf7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/135/commits","review_comments_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/135/comments","review_comment_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/issues/135/comments","statuses_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/statuses/3dbba0391678b9679bb56bad3d4823e24d3df82a","head":{"label":"speezepearson:report-scheduling","ref":"report-scheduling","sha":"3dbba0391678b9679bb56bad3d4823e24d3df82a","user":{"login":"speezepearson","id":1899701,"node_id":"MDQ6VXNlcjE4OTk3MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1899701?v=4","gravatar_id":"","url":"https://api.github.com/users/speezepearson","html_url":"https://github.com/speezepearson","followers_url":"https://api.github.com/users/speezepearson/followers","following_url":"https://api.github.com/users/speezepearson/following{/other_user}","gists_url":"https://api.github.com/users/speezepearson/gists{/gist_id}","starred_url":"https://api.github.com/users/speezepearson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/speezepearson/subscriptions","organizations_url":"https://api.github.com/users/speezepearson/orgs","repos_url":"https://api.github.com/users/speezepearson/repos","events_url":"https://api.github.com/users/speezepearson/events{/privacy}","received_events_url":"https://api.github.com/users/speezepearson/received_events","type":"User","site_admin":false},"repo":{"id":159572032,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk1NzIwMzI=","name":"metrics-portal","full_name":"speezepearson/metrics-portal","private":false,"owner":{"login":"speezepearson","id":1899701,"node_id":"MDQ6VXNlcjE4OTk3MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1899701?v=4","gravatar_id":"","url":"https://api.github.com/users/speezepearson","html_url":"https://github.com/speezepearson","followers_url":"https://api.github.com/users/speezepearson/followers","following_url":"https://api.github.com/users/speezepearson/following{/other_user}","gists_url":"https://api.github.com/users/speezepearson/gists{/gist_id}","starred_url":"https://api.github.com/users/speezepearson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/speezepearson/subscriptions","organizations_url":"https://api.github.com/users/speezepearson/orgs","repos_url":"https://api.github.com/users/speezepearson/repos","events_url":"https://api.github.com/users/speezepearson/events{/privacy}","received_events_url":"https://api.github.com/users/speezepearson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/speezepearson/metrics-portal","description":null,"fork":true,"url":"https://api.github.com/repos/speezepearson/metrics-portal","forks_url":"https://api.github.com/repos/speezepearson/metrics-portal/forks","keys_url":"https://api.github.com/repos/speezepearson/metrics-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/speezepearson/metrics-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/speezepearson/metrics-portal/teams","hooks_url":"https://api.github.com/repos/speezepearson/metrics-portal/hooks","issue_events_url":"https://api.github.com/repos/speezepearson/metrics-portal/issues/events{/number}","events_url":"https://api.github.com/repos/speezepearson/metrics-portal/events","assignees_url":"https://api.github.com/repos/speezepearson/metrics-portal/assignees{/user}","branches_url":"https://api.github.com/repos/speezepearson/metrics-portal/branches{/branch}","tags_url":"https://api.github.com/repos/speezepearson/metrics-portal/tags","blobs_url":"https://api.github.com/repos/speezepearson/metrics-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/speezepearson/metrics-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/speezepearson/metrics-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/speezepearson/metrics-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/speezepearson/metrics-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/speezepearson/metrics-portal/languages","stargazers_url":"https://api.github.com/repos/speezepearson/metrics-portal/stargazers","contributors_url":"https://api.github.com/repos/speezepearson/metrics-portal/contributors","subscribers_url":"https://api.github.com/repos/speezepearson/metrics-portal/subscribers","subscription_url":"https://api.github.com/repos/speezepearson/metrics-portal/subscription","commits_url":"https://api.github.com/repos/speezepearson/metrics-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/speezepearson/metrics-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/speezepearson/metrics-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/speezepearson/metrics-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/speezepearson/metrics-portal/contents/{+path}","compare_url":"https://api.github.com/repos/speezepearson/metrics-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/speezepearson/metrics-portal/merges","archive_url":"https://api.github.com/repos/speezepearson/metrics-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/speezepearson/metrics-portal/downloads","issues_url":"https://api.github.com/repos/speezepearson/metrics-portal/issues{/number}","pulls_url":"https://api.github.com/repos/speezepearson/metrics-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/speezepearson/metrics-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/speezepearson/metrics-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/speezepearson/metrics-portal/labels{/name}","releases_url":"https://api.github.com/repos/speezepearson/metrics-portal/releases{/id}","deployments_url":"https://api.github.com/repos/speezepearson/metrics-portal/deployments","created_at":"2018-11-28T22:09:26Z","updated_at":"2018-11-28T22:09:29Z","pushed_at":"2018-12-19T20:03:58Z","git_url":"git://github.com/speezepearson/metrics-portal.git","ssh_url":"git@github.com:speezepearson/metrics-portal.git","clone_url":"https://github.com/speezepearson/metrics-portal.git","svn_url":"https://github.com/speezepearson/metrics-portal","homepage":null,"size":3938,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArpNetworking:master","ref":"master","sha":"3c3f42f18dc2126f3b914fa81527bd0f7654ce2d","user":{"login":"ArpNetworking","id":7937343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MzczNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7937343?v=4","gravatar_id":"","url":"https://api.github.com/users/ArpNetworking","html_url":"https://github.com/ArpNetworking","followers_url":"https://api.github.com/users/ArpNetworking/followers","following_url":"https://api.github.com/users/ArpNetworking/following{/other_user}","gists_url":"https://api.github.com/users/ArpNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/ArpNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArpNetworking/subscriptions","organizations_url":"https://api.github.com/users/ArpNetworking/orgs","repos_url":"https://api.github.com/users/ArpNetworking/repos","events_url":"https://api.github.com/users/ArpNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/ArpNetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":44266630,"node_id":"MDEwOlJlcG9zaXRvcnk0NDI2NjYzMA==","name":"metrics-portal","full_name":"ArpNetworking/metrics-portal","private":false,"owner":{"login":"ArpNetworking","id":7937343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MzczNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7937343?v=4","gravatar_id":"","url":"https://api.github.com/users/ArpNetworking","html_url":"https://github.com/ArpNetworking","followers_url":"https://api.github.com/users/ArpNetworking/followers","following_url":"https://api.github.com/users/ArpNetworking/following{/other_user}","gists_url":"https://api.github.com/users/ArpNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/ArpNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArpNetworking/subscriptions","organizations_url":"https://api.github.com/users/ArpNetworking/orgs","repos_url":"https://api.github.com/users/ArpNetworking/repos","events_url":"https://api.github.com/users/ArpNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/ArpNetworking/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArpNetworking/metrics-portal","description":null,"fork":false,"url":"https://api.github.com/repos/ArpNetworking/metrics-portal","forks_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/forks","keys_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/teams","hooks_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/hooks","issue_events_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/events","assignees_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/tags","blobs_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/languages","stargazers_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/stargazers","contributors_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/contributors","subscribers_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/subscribers","subscription_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/subscription","commits_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/merges","archive_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/downloads","issues_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/labels{/name}","releases_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ArpNetworking/metrics-portal/deployments","created_at":"2015-10-14T18:03:17Z","updated_at":"2018-12-10T19:11:46Z","pushed_at":"2018-12-19T20:04:00Z","git_url":"git://github.com/ArpNetworking/metrics-portal.git","ssh_url":"git@github.com:ArpNetworking/metrics-portal.git","clone_url":"https://github.com/ArpNetworking/metrics-portal.git","svn_url":"https://github.com/ArpNetworking/metrics-portal","homepage":null,"size":3934,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":29,"license":null,"forks":9,"open_issues":29,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/135"},"html":{"href":"https://github.com/ArpNetworking/metrics-portal/pull/135"},"issue":{"href":"https://api.github.com/repos/ArpNetworking/metrics-portal/issues/135"},"comments":{"href":"https://api.github.com/repos/ArpNetworking/metrics-portal/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArpNetworking/metrics-portal/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/ArpNetworking/metrics-portal/statuses/3dbba0391678b9679bb56bad3d4823e24d3df82a"}},"author_association":"NONE"}}
{"actor":{"display_login":"vjkoskela"}}