{"action":"created","comment":{"url":"https://api.github.com/repos/openspending/os-conductor/pulls/comments/173769439","pull_request_review_id":103005097,"id":173769439,"diff_hunk":"@@ -1,23 +1,16 @@\n FROM python:3.6-alpine\n \n-RUN apk --no-cache add \\\n-    python3 \\\n-    git \\\n-    libpq \\\n-    wget \\\n-    libffi \\\n-    libffi-dev \\\n-    ca-certificates \\\n-    python3-dev \\\n-    postgresql-dev \\\n-    build-base \\\n-    bash \\\n-    curl\n-RUN update-ca-certificates\n+RUN apk add --update --no-cache libpq postgresql-dev libffi libffi-dev bash libstdc++ nodejs\n+RUN apk add --update --no-cache --virtual=build-dependencies build-base \n+RUN apk --repository http://dl-3.alpinelinux.org/alpine/edge/testing/ --update add leveldb leveldb-dev\n \n WORKDIR /app\n ADD requirements.txt .\n RUN pip install -r requirements.txt\n+RUN npm install -g os-types\n+\n+RUN apk del build-dependencies\n+RUN rm -rf /var/cache/apk/*","path":"Dockerfile","position":27,"original_position":27,"commit_id":"006c5200bbc57db401b36d9a3c10b1b230e3fdc0","original_commit_id":"006c5200bbc57db401b36d9a3c10b1b230e3fdc0","user":{"login":"brew","id":3993,"avatar_url":"https://avatars1.githubusercontent.com/u/3993?v=4","gravatar_id":"","url":"https://api.github.com/users/brew","html_url":"https://github.com/brew","followers_url":"https://api.github.com/users/brew/followers","following_url":"https://api.github.com/users/brew/following{/other_user}","gists_url":"https://api.github.com/users/brew/gists{/gist_id}","starred_url":"https://api.github.com/users/brew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brew/subscriptions","organizations_url":"https://api.github.com/users/brew/orgs","repos_url":"https://api.github.com/users/brew/repos","events_url":"https://api.github.com/users/brew/events{/privacy}","received_events_url":"https://api.github.com/users/brew/received_events","type":"User","site_admin":false},"body":"Can L12-13 be put before `WORKDIR /app` etc, as the results will change less frequently than requirement.txt installation, making better use of the Docker cache and help speed up Docker builds.","created_at":"2018-03-12T11:46:59Z","updated_at":"2018-03-12T12:01:46Z","html_url":"https://github.com/openspending/os-conductor/pull/28#discussion_r173769439","pull_request_url":"https://api.github.com/repos/openspending/os-conductor/pulls/28","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/openspending/os-conductor/pulls/comments/173769439"},"html":{"href":"https://github.com/openspending/os-conductor/pull/28#discussion_r173769439"},"pull_request":{"href":"https://api.github.com/repos/openspending/os-conductor/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/openspending/os-conductor/pulls/28","id":174330930,"html_url":"https://github.com/openspending/os-conductor/pull/28","diff_url":"https://github.com/openspending/os-conductor/pull/28.diff","patch_url":"https://github.com/openspending/os-conductor/pull/28.patch","issue_url":"https://api.github.com/repos/openspending/os-conductor/issues/28","number":28,"state":"open","locked":false,"title":"Use DPP runner instead of API loader","user":{"login":"akariv","id":265333,"avatar_url":"https://avatars3.githubusercontent.com/u/265333?v=4","gravatar_id":"","url":"https://api.github.com/users/akariv","html_url":"https://github.com/akariv","followers_url":"https://api.github.com/users/akariv/followers","following_url":"https://api.github.com/users/akariv/following{/other_user}","gists_url":"https://api.github.com/users/akariv/gists{/gist_id}","starred_url":"https://api.github.com/users/akariv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akariv/subscriptions","organizations_url":"https://api.github.com/users/akariv/orgs","repos_url":"https://api.github.com/users/akariv/repos","events_url":"https://api.github.com/users/akariv/events{/privacy}","received_events_url":"https://api.github.com/users/akariv/received_events","type":"User","site_admin":false},"body":"DPP Runner (https://github.com/akariv/dpp-runner) is a small utility library for running a single pipeline/source spec in a temporary workspace and as a separate thread.\r\nYou can submit these specs to it, and it will call a callback function with status updates.\r\n\r\nThe modifications in this PR:\r\n- [ ] Remove the status callback from os conductor (the one that API loader used to call), and repurposes the code to serve as the dpp-runner callback.\r\n- [ ] Modifies the package/upload handler, to create a fiscal source-spec from the provided datapackage and use that spec as an input to dpp-runner\r\n- [ ] Modifications to the Dockerfile to allow all that goodness to actually work in a single container.\r\n\r\n(there are still a couple of tests failing, will take care of them)","created_at":"2018-03-12T10:48:41Z","updated_at":"2018-03-12T12:01:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02f03576c84c103c1caea131984403ca838455aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":369846504,"url":"https://api.github.com/repos/openspending/os-conductor/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openspending/os-conductor/pulls/28/commits","review_comments_url":"https://api.github.com/repos/openspending/os-conductor/pulls/28/comments","review_comment_url":"https://api.github.com/repos/openspending/os-conductor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openspending/os-conductor/issues/28/comments","statuses_url":"https://api.github.com/repos/openspending/os-conductor/statuses/006c5200bbc57db401b36d9a3c10b1b230e3fdc0","head":{"label":"openspending:feature/dpp-runner","ref":"feature/dpp-runner","sha":"006c5200bbc57db401b36d9a3c10b1b230e3fdc0","user":{"login":"openspending","id":1392301,"avatar_url":"https://avatars3.githubusercontent.com/u/1392301?v=4","gravatar_id":"","url":"https://api.github.com/users/openspending","html_url":"https://github.com/openspending","followers_url":"https://api.github.com/users/openspending/followers","following_url":"https://api.github.com/users/openspending/following{/other_user}","gists_url":"https://api.github.com/users/openspending/gists{/gist_id}","starred_url":"https://api.github.com/users/openspending/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openspending/subscriptions","organizations_url":"https://api.github.com/users/openspending/orgs","repos_url":"https://api.github.com/users/openspending/repos","events_url":"https://api.github.com/users/openspending/events{/privacy}","received_events_url":"https://api.github.com/users/openspending/received_events","type":"Organization","site_admin":false},"repo":{"id":44969473,"name":"os-conductor","full_name":"openspending/os-conductor","owner":{"login":"openspending","id":1392301,"avatar_url":"https://avatars3.githubusercontent.com/u/1392301?v=4","gravatar_id":"","url":"https://api.github.com/users/openspending","html_url":"https://github.com/openspending","followers_url":"https://api.github.com/users/openspending/followers","following_url":"https://api.github.com/users/openspending/following{/other_user}","gists_url":"https://api.github.com/users/openspending/gists{/gist_id}","starred_url":"https://api.github.com/users/openspending/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openspending/subscriptions","organizations_url":"https://api.github.com/users/openspending/orgs","repos_url":"https://api.github.com/users/openspending/repos","events_url":"https://api.github.com/users/openspending/events{/privacy}","received_events_url":"https://api.github.com/users/openspending/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openspending/os-conductor","description":"OS Conductor is a set of integration web services of OpenSpending, responsible for identity, notification, and access control.","fork":false,"url":"https://api.github.com/repos/openspending/os-conductor","forks_url":"https://api.github.com/repos/openspending/os-conductor/forks","keys_url":"https://api.github.com/repos/openspending/os-conductor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openspending/os-conductor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openspending/os-conductor/teams","hooks_url":"https://api.github.com/repos/openspending/os-conductor/hooks","issue_events_url":"https://api.github.com/repos/openspending/os-conductor/issues/events{/number}","events_url":"https://api.github.com/repos/openspending/os-conductor/events","assignees_url":"https://api.github.com/repos/openspending/os-conductor/assignees{/user}","branches_url":"https://api.github.com/repos/openspending/os-conductor/branches{/branch}","tags_url":"https://api.github.com/repos/openspending/os-conductor/tags","blobs_url":"https://api.github.com/repos/openspending/os-conductor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openspending/os-conductor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openspending/os-conductor/git/refs{/sha}","trees_url":"https://api.github.com/repos/openspending/os-conductor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openspending/os-conductor/statuses/{sha}","languages_url":"https://api.github.com/repos/openspending/os-conductor/languages","stargazers_url":"https://api.github.com/repos/openspending/os-conductor/stargazers","contributors_url":"https://api.github.com/repos/openspending/os-conductor/contributors","subscribers_url":"https://api.github.com/repos/openspending/os-conductor/subscribers","subscription_url":"https://api.github.com/repos/openspending/os-conductor/subscription","commits_url":"https://api.github.com/repos/openspending/os-conductor/commits{/sha}","git_commits_url":"https://api.github.com/repos/openspending/os-conductor/git/commits{/sha}","comments_url":"https://api.github.com/repos/openspending/os-conductor/comments{/number}","issue_comment_url":"https://api.github.com/repos/openspending/os-conductor/issues/comments{/number}","contents_url":"https://api.github.com/repos/openspending/os-conductor/contents/{+path}","compare_url":"https://api.github.com/repos/openspending/os-conductor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openspending/os-conductor/merges","archive_url":"https://api.github.com/repos/openspending/os-conductor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openspending/os-conductor/downloads","issues_url":"https://api.github.com/repos/openspending/os-conductor/issues{/number}","pulls_url":"https://api.github.com/repos/openspending/os-conductor/pulls{/number}","milestones_url":"https://api.github.com/repos/openspending/os-conductor/milestones{/number}","notifications_url":"https://api.github.com/repos/openspending/os-conductor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openspending/os-conductor/labels{/name}","releases_url":"https://api.github.com/repos/openspending/os-conductor/releases{/id}","deployments_url":"https://api.github.com/repos/openspending/os-conductor/deployments","created_at":"2015-10-26T13:17:33Z","updated_at":"2018-01-18T14:00:48Z","pushed_at":"2018-03-12T11:21:10Z","git_url":"git://github.com/openspending/os-conductor.git","ssh_url":"git@github.com:openspending/os-conductor.git","clone_url":"https://github.com/openspending/os-conductor.git","svn_url":"https://github.com/openspending/os-conductor","homepage":"","size":171,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"openspending:master","ref":"master","sha":"198bf5c0223818422a053453566545afd56c30cb","user":{"login":"openspending","id":1392301,"avatar_url":"https://avatars3.githubusercontent.com/u/1392301?v=4","gravatar_id":"","url":"https://api.github.com/users/openspending","html_url":"https://github.com/openspending","followers_url":"https://api.github.com/users/openspending/followers","following_url":"https://api.github.com/users/openspending/following{/other_user}","gists_url":"https://api.github.com/users/openspending/gists{/gist_id}","starred_url":"https://api.github.com/users/openspending/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openspending/subscriptions","organizations_url":"https://api.github.com/users/openspending/orgs","repos_url":"https://api.github.com/users/openspending/repos","events_url":"https://api.github.com/users/openspending/events{/privacy}","received_events_url":"https://api.github.com/users/openspending/received_events","type":"Organization","site_admin":false},"repo":{"id":44969473,"name":"os-conductor","full_name":"openspending/os-conductor","owner":{"login":"openspending","id":1392301,"avatar_url":"https://avatars3.githubusercontent.com/u/1392301?v=4","gravatar_id":"","url":"https://api.github.com/users/openspending","html_url":"https://github.com/openspending","followers_url":"https://api.github.com/users/openspending/followers","following_url":"https://api.github.com/users/openspending/following{/other_user}","gists_url":"https://api.github.com/users/openspending/gists{/gist_id}","starred_url":"https://api.github.com/users/openspending/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openspending/subscriptions","organizations_url":"https://api.github.com/users/openspending/orgs","repos_url":"https://api.github.com/users/openspending/repos","events_url":"https://api.github.com/users/openspending/events{/privacy}","received_events_url":"https://api.github.com/users/openspending/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openspending/os-conductor","description":"OS Conductor is a set of integration web services of OpenSpending, responsible for identity, notification, and access control.","fork":false,"url":"https://api.github.com/repos/openspending/os-conductor","forks_url":"https://api.github.com/repos/openspending/os-conductor/forks","keys_url":"https://api.github.com/repos/openspending/os-conductor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openspending/os-conductor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openspending/os-conductor/teams","hooks_url":"https://api.github.com/repos/openspending/os-conductor/hooks","issue_events_url":"https://api.github.com/repos/openspending/os-conductor/issues/events{/number}","events_url":"https://api.github.com/repos/openspending/os-conductor/events","assignees_url":"https://api.github.com/repos/openspending/os-conductor/assignees{/user}","branches_url":"https://api.github.com/repos/openspending/os-conductor/branches{/branch}","tags_url":"https://api.github.com/repos/openspending/os-conductor/tags","blobs_url":"https://api.github.com/repos/openspending/os-conductor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openspending/os-conductor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openspending/os-conductor/git/refs{/sha}","trees_url":"https://api.github.com/repos/openspending/os-conductor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openspending/os-conductor/statuses/{sha}","languages_url":"https://api.github.com/repos/openspending/os-conductor/languages","stargazers_url":"https://api.github.com/repos/openspending/os-conductor/stargazers","contributors_url":"https://api.github.com/repos/openspending/os-conductor/contributors","subscribers_url":"https://api.github.com/repos/openspending/os-conductor/subscribers","subscription_url":"https://api.github.com/repos/openspending/os-conductor/subscription","commits_url":"https://api.github.com/repos/openspending/os-conductor/commits{/sha}","git_commits_url":"https://api.github.com/repos/openspending/os-conductor/git/commits{/sha}","comments_url":"https://api.github.com/repos/openspending/os-conductor/comments{/number}","issue_comment_url":"https://api.github.com/repos/openspending/os-conductor/issues/comments{/number}","contents_url":"https://api.github.com/repos/openspending/os-conductor/contents/{+path}","compare_url":"https://api.github.com/repos/openspending/os-conductor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openspending/os-conductor/merges","archive_url":"https://api.github.com/repos/openspending/os-conductor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openspending/os-conductor/downloads","issues_url":"https://api.github.com/repos/openspending/os-conductor/issues{/number}","pulls_url":"https://api.github.com/repos/openspending/os-conductor/pulls{/number}","milestones_url":"https://api.github.com/repos/openspending/os-conductor/milestones{/number}","notifications_url":"https://api.github.com/repos/openspending/os-conductor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openspending/os-conductor/labels{/name}","releases_url":"https://api.github.com/repos/openspending/os-conductor/releases{/id}","deployments_url":"https://api.github.com/repos/openspending/os-conductor/deployments","created_at":"2015-10-26T13:17:33Z","updated_at":"2018-01-18T14:00:48Z","pushed_at":"2018-03-12T11:21:10Z","git_url":"git://github.com/openspending/os-conductor.git","ssh_url":"git@github.com:openspending/os-conductor.git","clone_url":"https://github.com/openspending/os-conductor.git","svn_url":"https://github.com/openspending/os-conductor","homepage":"","size":171,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openspending/os-conductor/pulls/28"},"html":{"href":"https://github.com/openspending/os-conductor/pull/28"},"issue":{"href":"https://api.github.com/repos/openspending/os-conductor/issues/28"},"comments":{"href":"https://api.github.com/repos/openspending/os-conductor/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/openspending/os-conductor/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/openspending/os-conductor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openspending/os-conductor/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/openspending/os-conductor/statuses/006c5200bbc57db401b36d9a3c10b1b230e3fdc0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brew"}}