{"action":"created","comment":{"url":"https://api.github.com/repos/convexengineering/gplibrary/pulls/comments/182275658","pull_request_review_id":113039427,"id":182275658,"diff_hunk":"@@ -20,37 +24,61 @@ class Propeller_Performance(Model):\n     CP                      [-]         power coefficient\n     Q                       [N*m]       torque\n     omega                   [rpm]       propeller rotation rate\n-\n+    omega_max  10000        [rpm]       max rotation rate\n+    P_shaft                 [kW]        shaft power\n+    M_tip      .5           [-]         Tip mach number\n+    a          295          [m/s]       Speed of sound at altitude\n     \"\"\"\n \n     def helper(self, c):\n-        \" helper function to avoid signomial constraint \"\n         return 2. - 1./c[self.etaadd]\n \n-    def setup(self, static, state):\n-        exec parse_variables(Propeller_Performance.__doc__)\n+    def setup(self, static, state = None, rho = None, V = None):\n+        exec parse_variables(ActuatorProp.__doc__)\n \n         V = state.V\n         rho = state.rho\n         R = static.R\n \n-        return [eta <= etav*etai,\n-                Tc == T/(0.5*rho*V**2*pi*R**2),\n-                z2 >= Tc + 1,\n-                etai*(z1 + z2**0.5/etaadd) <= 2,\n-               ], static\n+        constraints = [eta <= etav*etai,\n+                       Tc >= T/(0.5*rho*V**2*pi*R**2),\n+                       z2 >= Tc + 1,\n+                       etai*(z1 + z2**0.5/etaadd) <= 2,\n+                       lam >= V/(omega*R),\n+                       CT >= Tc*lam**2,\n+                       CP <= Q*omega/(.5*rho*(omega*R)**3*pi*R**2),\n+                       eta >= CT*lam/CP,","path":"gpkitmodels/GP/aircraft/prop/propeller.py","position":62,"original_position":62,"commit_id":"ec4eb08696bd09dee9e13b07c59a3a26ae7aea36","original_commit_id":"ec4eb08696bd09dee9e13b07c59a3a26ae7aea36","user":{"login":"mjburton11","id":14276241,"avatar_url":"https://avatars1.githubusercontent.com/u/14276241?v=4","gravatar_id":"","url":"https://api.github.com/users/mjburton11","html_url":"https://github.com/mjburton11","followers_url":"https://api.github.com/users/mjburton11/followers","following_url":"https://api.github.com/users/mjburton11/following{/other_user}","gists_url":"https://api.github.com/users/mjburton11/gists{/gist_id}","starred_url":"https://api.github.com/users/mjburton11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjburton11/subscriptions","organizations_url":"https://api.github.com/users/mjburton11/orgs","repos_url":"https://api.github.com/users/mjburton11/repos","events_url":"https://api.github.com/users/mjburton11/events{/privacy}","received_events_url":"https://api.github.com/users/mjburton11/received_events","type":"User","site_admin":false},"body":"Does this over constrain `eta`?","created_at":"2018-04-17T23:58:51Z","updated_at":"2018-04-17T23:59:36Z","html_url":"https://github.com/convexengineering/gplibrary/pull/161#discussion_r182275658","pull_request_url":"https://api.github.com/repos/convexengineering/gplibrary/pulls/161","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/convexengineering/gplibrary/pulls/comments/182275658"},"html":{"href":"https://github.com/convexengineering/gplibrary/pull/161#discussion_r182275658"},"pull_request":{"href":"https://api.github.com/repos/convexengineering/gplibrary/pulls/161"}}},"pull_request":{"url":"https://api.github.com/repos/convexengineering/gplibrary/pulls/161","id":182265574,"html_url":"https://github.com/convexengineering/gplibrary/pull/161","diff_url":"https://github.com/convexengineering/gplibrary/pull/161.diff","patch_url":"https://github.com/convexengineering/gplibrary/pull/161.patch","issue_url":"https://api.github.com/repos/convexengineering/gplibrary/issues/161","number":161,"state":"open","locked":false,"title":"Actuator updates","user":{"login":"courtin","id":32649540,"avatar_url":"https://avatars0.githubusercontent.com/u/32649540?v=4","gravatar_id":"","url":"https://api.github.com/users/courtin","html_url":"https://github.com/courtin","followers_url":"https://api.github.com/users/courtin/followers","following_url":"https://api.github.com/users/courtin/following{/other_user}","gists_url":"https://api.github.com/users/courtin/gists{/gist_id}","starred_url":"https://api.github.com/users/courtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/courtin/subscriptions","organizations_url":"https://api.github.com/users/courtin/orgs","repos_url":"https://api.github.com/users/courtin/repos","events_url":"https://api.github.com/users/courtin/events{/privacy}","received_events_url":"https://api.github.com/users/courtin/received_events","type":"User","site_admin":false},"body":"Updates to the actuator disk propeller and electric motor models for integration into the solar model. ","created_at":"2018-04-17T19:09:27Z","updated_at":"2018-04-17T23:59:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81eecc8d76514f4c72813dec44c4e072979ccd7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/convexengineering/gplibrary/pulls/161/commits","review_comments_url":"https://api.github.com/repos/convexengineering/gplibrary/pulls/161/comments","review_comment_url":"https://api.github.com/repos/convexengineering/gplibrary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convexengineering/gplibrary/issues/161/comments","statuses_url":"https://api.github.com/repos/convexengineering/gplibrary/statuses/ec4eb08696bd09dee9e13b07c59a3a26ae7aea36","head":{"label":"convexengineering:actuator_updates","ref":"actuator_updates","sha":"ec4eb08696bd09dee9e13b07c59a3a26ae7aea36","user":{"login":"convexengineering","id":32085780,"avatar_url":"https://avatars2.githubusercontent.com/u/32085780?v=4","gravatar_id":"","url":"https://api.github.com/users/convexengineering","html_url":"https://github.com/convexengineering","followers_url":"https://api.github.com/users/convexengineering/followers","following_url":"https://api.github.com/users/convexengineering/following{/other_user}","gists_url":"https://api.github.com/users/convexengineering/gists{/gist_id}","starred_url":"https://api.github.com/users/convexengineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convexengineering/subscriptions","organizations_url":"https://api.github.com/users/convexengineering/orgs","repos_url":"https://api.github.com/users/convexengineering/repos","events_url":"https://api.github.com/users/convexengineering/events{/privacy}","received_events_url":"https://api.github.com/users/convexengineering/received_events","type":"Organization","site_admin":false},"repo":{"id":44559346,"name":"gplibrary","full_name":"convexengineering/gplibrary","owner":{"login":"convexengineering","id":32085780,"avatar_url":"https://avatars2.githubusercontent.com/u/32085780?v=4","gravatar_id":"","url":"https://api.github.com/users/convexengineering","html_url":"https://github.com/convexengineering","followers_url":"https://api.github.com/users/convexengineering/followers","following_url":"https://api.github.com/users/convexengineering/following{/other_user}","gists_url":"https://api.github.com/users/convexengineering/gists{/gist_id}","starred_url":"https://api.github.com/users/convexengineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convexengineering/subscriptions","organizations_url":"https://api.github.com/users/convexengineering/orgs","repos_url":"https://api.github.com/users/convexengineering/repos","events_url":"https://api.github.com/users/convexengineering/events{/privacy}","received_events_url":"https://api.github.com/users/convexengineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convexengineering/gplibrary","description":"Useful subsystem models","fork":false,"url":"https://api.github.com/repos/convexengineering/gplibrary","forks_url":"https://api.github.com/repos/convexengineering/gplibrary/forks","keys_url":"https://api.github.com/repos/convexengineering/gplibrary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convexengineering/gplibrary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convexengineering/gplibrary/teams","hooks_url":"https://api.github.com/repos/convexengineering/gplibrary/hooks","issue_events_url":"https://api.github.com/repos/convexengineering/gplibrary/issues/events{/number}","events_url":"https://api.github.com/repos/convexengineering/gplibrary/events","assignees_url":"https://api.github.com/repos/convexengineering/gplibrary/assignees{/user}","branches_url":"https://api.github.com/repos/convexengineering/gplibrary/branches{/branch}","tags_url":"https://api.github.com/repos/convexengineering/gplibrary/tags","blobs_url":"https://api.github.com/repos/convexengineering/gplibrary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convexengineering/gplibrary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convexengineering/gplibrary/git/refs{/sha}","trees_url":"https://api.github.com/repos/convexengineering/gplibrary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convexengineering/gplibrary/statuses/{sha}","languages_url":"https://api.github.com/repos/convexengineering/gplibrary/languages","stargazers_url":"https://api.github.com/repos/convexengineering/gplibrary/stargazers","contributors_url":"https://api.github.com/repos/convexengineering/gplibrary/contributors","subscribers_url":"https://api.github.com/repos/convexengineering/gplibrary/subscribers","subscription_url":"https://api.github.com/repos/convexengineering/gplibrary/subscription","commits_url":"https://api.github.com/repos/convexengineering/gplibrary/commits{/sha}","git_commits_url":"https://api.github.com/repos/convexengineering/gplibrary/git/commits{/sha}","comments_url":"https://api.github.com/repos/convexengineering/gplibrary/comments{/number}","issue_comment_url":"https://api.github.com/repos/convexengineering/gplibrary/issues/comments{/number}","contents_url":"https://api.github.com/repos/convexengineering/gplibrary/contents/{+path}","compare_url":"https://api.github.com/repos/convexengineering/gplibrary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convexengineering/gplibrary/merges","archive_url":"https://api.github.com/repos/convexengineering/gplibrary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convexengineering/gplibrary/downloads","issues_url":"https://api.github.com/repos/convexengineering/gplibrary/issues{/number}","pulls_url":"https://api.github.com/repos/convexengineering/gplibrary/pulls{/number}","milestones_url":"https://api.github.com/repos/convexengineering/gplibrary/milestones{/number}","notifications_url":"https://api.github.com/repos/convexengineering/gplibrary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convexengineering/gplibrary/labels{/name}","releases_url":"https://api.github.com/repos/convexengineering/gplibrary/releases{/id}","deployments_url":"https://api.github.com/repos/convexengineering/gplibrary/deployments","created_at":"2015-10-19T19:44:45Z","updated_at":"2018-04-03T23:58:30Z","pushed_at":"2018-04-17T20:34:27Z","git_url":"git://github.com/convexengineering/gplibrary.git","ssh_url":"git@github.com:convexengineering/gplibrary.git","clone_url":"https://github.com/convexengineering/gplibrary.git","svn_url":"https://github.com/convexengineering/gplibrary","homepage":"","size":9023,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":27,"watchers":7,"default_branch":"master"}},"base":{"label":"convexengineering:master","ref":"master","sha":"3824690dad9dd0d95323d63fb2ed01740e732e4c","user":{"login":"convexengineering","id":32085780,"avatar_url":"https://avatars2.githubusercontent.com/u/32085780?v=4","gravatar_id":"","url":"https://api.github.com/users/convexengineering","html_url":"https://github.com/convexengineering","followers_url":"https://api.github.com/users/convexengineering/followers","following_url":"https://api.github.com/users/convexengineering/following{/other_user}","gists_url":"https://api.github.com/users/convexengineering/gists{/gist_id}","starred_url":"https://api.github.com/users/convexengineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convexengineering/subscriptions","organizations_url":"https://api.github.com/users/convexengineering/orgs","repos_url":"https://api.github.com/users/convexengineering/repos","events_url":"https://api.github.com/users/convexengineering/events{/privacy}","received_events_url":"https://api.github.com/users/convexengineering/received_events","type":"Organization","site_admin":false},"repo":{"id":44559346,"name":"gplibrary","full_name":"convexengineering/gplibrary","owner":{"login":"convexengineering","id":32085780,"avatar_url":"https://avatars2.githubusercontent.com/u/32085780?v=4","gravatar_id":"","url":"https://api.github.com/users/convexengineering","html_url":"https://github.com/convexengineering","followers_url":"https://api.github.com/users/convexengineering/followers","following_url":"https://api.github.com/users/convexengineering/following{/other_user}","gists_url":"https://api.github.com/users/convexengineering/gists{/gist_id}","starred_url":"https://api.github.com/users/convexengineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convexengineering/subscriptions","organizations_url":"https://api.github.com/users/convexengineering/orgs","repos_url":"https://api.github.com/users/convexengineering/repos","events_url":"https://api.github.com/users/convexengineering/events{/privacy}","received_events_url":"https://api.github.com/users/convexengineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convexengineering/gplibrary","description":"Useful subsystem models","fork":false,"url":"https://api.github.com/repos/convexengineering/gplibrary","forks_url":"https://api.github.com/repos/convexengineering/gplibrary/forks","keys_url":"https://api.github.com/repos/convexengineering/gplibrary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convexengineering/gplibrary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convexengineering/gplibrary/teams","hooks_url":"https://api.github.com/repos/convexengineering/gplibrary/hooks","issue_events_url":"https://api.github.com/repos/convexengineering/gplibrary/issues/events{/number}","events_url":"https://api.github.com/repos/convexengineering/gplibrary/events","assignees_url":"https://api.github.com/repos/convexengineering/gplibrary/assignees{/user}","branches_url":"https://api.github.com/repos/convexengineering/gplibrary/branches{/branch}","tags_url":"https://api.github.com/repos/convexengineering/gplibrary/tags","blobs_url":"https://api.github.com/repos/convexengineering/gplibrary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convexengineering/gplibrary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convexengineering/gplibrary/git/refs{/sha}","trees_url":"https://api.github.com/repos/convexengineering/gplibrary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convexengineering/gplibrary/statuses/{sha}","languages_url":"https://api.github.com/repos/convexengineering/gplibrary/languages","stargazers_url":"https://api.github.com/repos/convexengineering/gplibrary/stargazers","contributors_url":"https://api.github.com/repos/convexengineering/gplibrary/contributors","subscribers_url":"https://api.github.com/repos/convexengineering/gplibrary/subscribers","subscription_url":"https://api.github.com/repos/convexengineering/gplibrary/subscription","commits_url":"https://api.github.com/repos/convexengineering/gplibrary/commits{/sha}","git_commits_url":"https://api.github.com/repos/convexengineering/gplibrary/git/commits{/sha}","comments_url":"https://api.github.com/repos/convexengineering/gplibrary/comments{/number}","issue_comment_url":"https://api.github.com/repos/convexengineering/gplibrary/issues/comments{/number}","contents_url":"https://api.github.com/repos/convexengineering/gplibrary/contents/{+path}","compare_url":"https://api.github.com/repos/convexengineering/gplibrary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convexengineering/gplibrary/merges","archive_url":"https://api.github.com/repos/convexengineering/gplibrary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convexengineering/gplibrary/downloads","issues_url":"https://api.github.com/repos/convexengineering/gplibrary/issues{/number}","pulls_url":"https://api.github.com/repos/convexengineering/gplibrary/pulls{/number}","milestones_url":"https://api.github.com/repos/convexengineering/gplibrary/milestones{/number}","notifications_url":"https://api.github.com/repos/convexengineering/gplibrary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convexengineering/gplibrary/labels{/name}","releases_url":"https://api.github.com/repos/convexengineering/gplibrary/releases{/id}","deployments_url":"https://api.github.com/repos/convexengineering/gplibrary/deployments","created_at":"2015-10-19T19:44:45Z","updated_at":"2018-04-03T23:58:30Z","pushed_at":"2018-04-17T20:34:27Z","git_url":"git://github.com/convexengineering/gplibrary.git","ssh_url":"git@github.com:convexengineering/gplibrary.git","clone_url":"https://github.com/convexengineering/gplibrary.git","svn_url":"https://github.com/convexengineering/gplibrary","homepage":"","size":9023,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":27,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convexengineering/gplibrary/pulls/161"},"html":{"href":"https://github.com/convexengineering/gplibrary/pull/161"},"issue":{"href":"https://api.github.com/repos/convexengineering/gplibrary/issues/161"},"comments":{"href":"https://api.github.com/repos/convexengineering/gplibrary/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/convexengineering/gplibrary/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/convexengineering/gplibrary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convexengineering/gplibrary/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/convexengineering/gplibrary/statuses/ec4eb08696bd09dee9e13b07c59a3a26ae7aea36"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mjburton11"}}