{"action":"created","issue":{"url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/issues/425","repository_url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library","labels_url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/issues/425/labels{/name}","comments_url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/issues/425/comments","events_url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/issues/425/events","html_url":"https://github.com/OpenLightingProject/open-fixture-library/pull/425","id":298124378,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY5ODUzNzE2","number":425,"title":"Capability types","user":{"login":"fxedel","id":7782229,"node_id":"MDQ6VXNlcjc3ODIyMjk=","avatar_url":"https://avatars3.githubusercontent.com/u/7782229?v=4","gravatar_id":"","url":"https://api.github.com/users/fxedel","html_url":"https://github.com/fxedel","followers_url":"https://api.github.com/users/fxedel/followers","following_url":"https://api.github.com/users/fxedel/following{/other_user}","gists_url":"https://api.github.com/users/fxedel/gists{/gist_id}","starred_url":"https://api.github.com/users/fxedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxedel/subscriptions","organizations_url":"https://api.github.com/users/fxedel/orgs","repos_url":"https://api.github.com/users/fxedel/repos","events_url":"https://api.github.com/users/fxedel/events{/privacy}","received_events_url":"https://api.github.com/users/fxedel/received_events","type":"User","site_admin":false},"labels":[{"id":564676637,"node_id":"MDU6TGFiZWw1NjQ2NzY2Mzc=","url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/labels/component-editor","name":"component-editor","color":"bfd4f2","default":false},{"id":561317951,"node_id":"MDU6TGFiZWw1NjEzMTc5NTE=","url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/labels/component-fixture","name":"component-fixture","color":"c2e0c6","default":false},{"id":638086584,"node_id":"MDU6TGFiZWw2MzgwODY1ODQ=","url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/labels/component-model","name":"component-model","color":"c5f5c5","default":false},{"id":561318064,"node_id":"MDU6TGFiZWw1NjEzMTgwNjQ=","url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/labels/component-plugin","name":"component-plugin","color":"d4c5f9","default":false},{"id":660076922,"node_id":"MDU6TGFiZWw2NjAwNzY5MjI=","url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/labels/component-schema","name":"component-schema","color":"e9d5b8","default":false},{"id":547934951,"node_id":"MDU6TGFiZWw1NDc5MzQ5NTE=","url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/labels/component-test","name":"component-test","color":"bfdadc","default":false},{"id":549186704,"node_id":"MDU6TGFiZWw1NDkxODY3MDQ=","url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/labels/component-ui","name":"component-ui","color":"c5def5","default":false},{"id":630294586,"node_id":"MDU6TGFiZWw2MzAyOTQ1ODY=","url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/labels/difficulty-medium","name":"difficulty-medium","color":"e99695","default":false},{"id":547319908,"node_id":"MDU6TGFiZWw1NDczMTk5MDg=","url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/labels/documentation","name":"documentation","color":"1d76db","default":false},{"id":561318348,"node_id":"MDU6TGFiZWw1NjEzMTgzNDg=","url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/labels/priority-medium","name":"priority-medium","color":"fcdf6f","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-02-18T22:22:57Z","updated_at":"2018-06-04T18:54:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/pulls/425","html_url":"https://github.com/OpenLightingProject/open-fixture-library/pull/425","diff_url":"https://github.com/OpenLightingProject/open-fixture-library/pull/425.diff","patch_url":"https://github.com/OpenLightingProject/open-fixture-library/pull/425.patch"},"body":"Closes #267 and #352. #177 and #437 will be added in a future pull request, but we make the syntax ready to make it easy later.\r\n\r\nSome links:\r\n\r\n- #267 for the initial idea, plus the [capability type concept](https://github.com/FloEdelmann/open-fixture-library/issues/267#issuecomment-366445444)\r\n- [QLC+ forum: \"How to help?\"](http://www.qlcplus.org/forum/viewtopic.php?f=12&t=11867#p50721)\r\n- [QLC+ document: \"Fixture definition rework\"](https://docs.google.com/document/d/1cnHt-ITpa1Uk-cJD6HgGHqy0Dl1bobEHYOGgf8zaJkc/edit)\r\n- [QLC+ issue: \"Fixture definition rework\"](https://github.com/mcallegari/qlcplus/issues/1026)\r\n\r\n\r\n# Todo\r\n\r\n* [ ] Schema\r\n  * [x] Add capability types with type-specific properties\r\n  * [x] Remove channel type\r\n  * [x] Divide schema into several files for better readability\r\n  * [x] Allow BPM as unit (see #460)\r\n  * [x] Allow \"infinite\" as value for pan/tiltMax\r\n  * [x] ~Add Hue, Saturation capability types~ (work for #505)\r\n  * [ ] Rethink capability type order (also update documentation and UI)\r\n  * [x] Rethink type-specific property order (also update documentation and UI)\r\n* [ ] Model\r\n  * [x] Parse new capabilities (except ColorPreset)\r\n  * [x] ~Color names <-> Hex codes~ (work for #437)\r\n  * [ ] Handle start/end colors\r\n  * [ ] Auto-generate:\r\n    * [x] `channel.type`\r\n    * [x] `channel.color`\r\n    * [x] `channel.invert`\r\n    * [x] `channel.crossfade`\r\n    * [x] `capability.name`\r\n    * [x] ~`capability.menuClick`?~ Do this in another PR\r\n    * [ ] `capability.helpWanted` for ColorPreset capabilities without a `colors` property\r\n    * [ ] + maybe more channel or capability options?\r\n* [ ] Fixture test\r\n  * [x] Remove a lot of no-longer-used code\r\n  * [x] Migrate category tests (which mainly depend on channel types)\r\n  * [x] Validate start/end values: Should be of the same unit and either both or none of them with keyword\r\n  * [ ] Add new type-specific checks\r\n    * [x] Pan/Tilt (Continuous): Check if angle doesn't conflict with physical's angle (maybe warn if not whole possible angle is used?)\r\n    * [x] ShutterStrobe: speed only allowed when `shutterEffect` is neither Closed nor Open\r\n    * [x] Effect: error when `effectName` would also be a valid `effectPreset`\r\n    * [ ] Maybe more?\r\n  * [ ] Channels with only a Nothing capability should not define fine channels or similar stuff -> maybe also possible using schema as there is the single capability shorthand now?\r\n* [ ] Adapt usage to new capabilities\r\n  * [x] Fixtures (see #478)\r\n    * [x] Test fixtures\r\n  * [ ] Plugins\r\n    * [x] e:cue export\r\n    * [ ] e:cue import\r\n    * [x] D::Light export\r\n    * [x] Millumin export (downgrading needed!)\r\n    * [x] QLC+ export\r\n    * [ ] QLC+ import\r\n  * [x] UI (not much to do because model generates capability names)\r\n  * [ ] Editor\r\n  * [ ] everywhere else\r\n* [ ] Update documentation\r\n  * [x] Add a note about the single capability shorthand\r\n  * [ ] Rethink capability type order (see schema)\r\n* [ ] Things to do shortly before merging\r\n  * [ ] Test all code examples in the documentation\r\n  * [x] Re-add `colors` property for ColorWheelIndex capabilities\r\n  * [ ] Check all `helpWanted` properties in the fixtures\r\n  * [ ] Remove migration helper script (won't be needed anymore)\r\n  * [ ] Update `lastModifyDate` in all fixtures"},"comment":{"url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/issues/comments/394460661","html_url":"https://github.com/OpenLightingProject/open-fixture-library/pull/425#issuecomment-394460661","issue_url":"https://api.github.com/repos/OpenLightingProject/open-fixture-library/issues/425","id":394460661,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDQ2MDY2MQ==","user":{"login":"FloEdelmann","id":202916,"node_id":"MDQ6VXNlcjIwMjkxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/202916?v=4","gravatar_id":"","url":"https://api.github.com/users/FloEdelmann","html_url":"https://github.com/FloEdelmann","followers_url":"https://api.github.com/users/FloEdelmann/followers","following_url":"https://api.github.com/users/FloEdelmann/following{/other_user}","gists_url":"https://api.github.com/users/FloEdelmann/gists{/gist_id}","starred_url":"https://api.github.com/users/FloEdelmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FloEdelmann/subscriptions","organizations_url":"https://api.github.com/users/FloEdelmann/orgs","repos_url":"https://api.github.com/users/FloEdelmann/repos","events_url":"https://api.github.com/users/FloEdelmann/events{/privacy}","received_events_url":"https://api.github.com/users/FloEdelmann/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T18:54:12Z","updated_at":"2018-06-04T18:54:12Z","author_association":"MEMBER","body":"<!-- GITHUB-TEST: tests/http-status.js -->\n# Broken links\n(Output of test script `tests/http-status.js`.)\n\nThere were 0 internal and 3 external links failing.\n\n- https://www.claypaky.it/en/home/\n- http://www.adblighting.com/?page=getsupportfile&file=165\n- https://www.claypaky.it/media/documents/HR_Sharpy_Manual_05.2016_EN.pdf"}}
{"actor":{"display_login":"FloEdelmann"}}