{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/29024","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/29024/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/29024/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/29024/events","html_url":"https://github.com/Automattic/wp-calypso/pull/29024","id":386829646,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDU2MjQx","number":29024,"title":"NUX: Always submit the original English site topic if it's from the suggestions","user":{"login":"southp","id":1842898,"node_id":"MDQ6VXNlcjE4NDI4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1842898?v=4","gravatar_id":"","url":"https://api.github.com/users/southp","html_url":"https://github.com/southp","followers_url":"https://api.github.com/users/southp/followers","following_url":"https://api.github.com/users/southp/following{/other_user}","gists_url":"https://api.github.com/users/southp/gists{/gist_id}","starred_url":"https://api.github.com/users/southp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/southp/subscriptions","organizations_url":"https://api.github.com/users/southp/orgs","repos_url":"https://api.github.com/users/southp/repos","events_url":"https://api.github.com/users/southp/events{/privacy}","received_events_url":"https://api.github.com/users/southp/received_events","type":"User","site_admin":false},"labels":[{"id":285010057,"node_id":"MDU6TGFiZWwyODUwMTAwNTc=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/NUX","name":"NUX","color":"006b75","default":false},{"id":285010049,"node_id":"MDU6TGFiZWwyODUwMTAwNDk=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Signup","name":"Signup","color":"006b75","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"southp","id":1842898,"node_id":"MDQ6VXNlcjE4NDI4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1842898?v=4","gravatar_id":"","url":"https://api.github.com/users/southp","html_url":"https://github.com/southp","followers_url":"https://api.github.com/users/southp/followers","following_url":"https://api.github.com/users/southp/following{/other_user}","gists_url":"https://api.github.com/users/southp/gists{/gist_id}","starred_url":"https://api.github.com/users/southp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/southp/subscriptions","organizations_url":"https://api.github.com/users/southp/orgs","repos_url":"https://api.github.com/users/southp/repos","events_url":"https://api.github.com/users/southp/events{/privacy}","received_events_url":"https://api.github.com/users/southp/received_events","type":"User","site_admin":false},"assignees":[{"login":"southp","id":1842898,"node_id":"MDQ6VXNlcjE4NDI4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1842898?v=4","gravatar_id":"","url":"https://api.github.com/users/southp","html_url":"https://github.com/southp","followers_url":"https://api.github.com/users/southp/followers","following_url":"https://api.github.com/users/southp/following{/other_user}","gists_url":"https://api.github.com/users/southp/gists{/gist_id}","starred_url":"https://api.github.com/users/southp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/southp/subscriptions","organizations_url":"https://api.github.com/users/southp/orgs","repos_url":"https://api.github.com/users/southp/repos","events_url":"https://api.github.com/users/southp/events{/privacy}","received_events_url":"https://api.github.com/users/southp/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-12-03T13:57:54Z","updated_at":"2018-12-11T01:37:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/29024","html_url":"https://github.com/Automattic/wp-calypso/pull/29024","diff_url":"https://github.com/Automattic/wp-calypso/pull/29024.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/29024.patch"},"body":"#### Changes proposed in this Pull Request\r\n\r\nThis PR adds the code that maps the translated site topic back to its original English slug. It also fixes the bug that the topic suggestions list isn't always localized.\r\n\r\nThe reason that the topic suggestions list isn't always localized currently is because `lib/hint-data` defines it as a module-level variable. Thus, any locale update simply won't update it and it will just stay in English. Moving it to the component level makes sure it gets updated properly.\r\n\r\nA screencast of this PR in action:\r\n![demo-site-topic-slug](https://user-images.githubusercontent.com/1842898/49426735-5ffbbf80-f7dc-11e8-8e3e-4bffcef231e9.gif)\r\n\r\n\r\n#### Testing instructions\r\n\r\n1. Change your locale to something other than English.\r\n1. Go through the improved onboarding flow from http://calypso.localhost:3000/start/onboarding\r\n1. At the site topic step, use auto-completion to pick a topic.\r\n1. After that, check `getState().signup` and make sure it has been mapped back to the original English slug.\r\n1. Redo 1~2. Then, at the site topic step, enter an arbitrary string.\r\n1. Check `getState().signup` and it should be whatever you just have entered.\r\n1. Go through the current main flow from http://calypso.localhost:3000/start/main, and the site topic field from the About step should act the same as above."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/446039975","html_url":"https://github.com/Automattic/wp-calypso/pull/29024#issuecomment-446039975","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/29024","id":446039975,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjAzOTk3NQ==","user":{"login":"southp","id":1842898,"node_id":"MDQ6VXNlcjE4NDI4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1842898?v=4","gravatar_id":"","url":"https://api.github.com/users/southp","html_url":"https://github.com/southp","followers_url":"https://api.github.com/users/southp/followers","following_url":"https://api.github.com/users/southp/following{/other_user}","gists_url":"https://api.github.com/users/southp/gists{/gist_id}","starred_url":"https://api.github.com/users/southp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/southp/subscriptions","organizations_url":"https://api.github.com/users/southp/orgs","repos_url":"https://api.github.com/users/southp/repos","events_url":"https://api.github.com/users/southp/events{/privacy}","received_events_url":"https://api.github.com/users/southp/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T01:37:04Z","updated_at":"2018-12-11T01:37:04Z","author_association":"CONTRIBUTOR","body":"@ramonjd @niranjan-uma-shankar Sorry If I missed the discussion, but why we would need to send back the English vertical name or the translated one? Since there is already an `vertical_id` field, I'd expect that's the only thing we need for sending back.\r\n\r\nAlso, given @ramonjd 's progress in #29172 , I'm wondering if I should just drop this PR so that we don't cause foreseeable code conflict 🤔"}}
{"actor":{"display_login":"southp"}}