{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/184563119","pull_request_review_id":115786706,"id":184563119,"diff_hunk":"@@ -451,3 +451,17 @@ bool AP_GPS_SBF::prepare_for_arming(void) {\n \n     return is_logging;\n }\n+\n+void AP_GPS_SBF::inject_data(const uint8_t *data, uint16_t len)\n+{\n+    // Septentrio configuration step fails if RTCM corrections are injected while configuring\n+    // so wait until configuration is completed, before injecting data\n+    if (state.status != AP_GPS::NO_GPS) {","path":"libraries/AP_GPS/AP_GPS_SBF.cpp","position":9,"original_position":9,"commit_id":"0c78eb9a876ee58a71888acc766f67a395e8c011","original_commit_id":"0c78eb9a876ee58a71888acc766f67a395e8c011","user":{"login":"amilcarlucas","id":24453563,"avatar_url":"https://avatars1.githubusercontent.com/u/24453563?v=4","gravatar_id":"","url":"https://api.github.com/users/amilcarlucas","html_url":"https://github.com/amilcarlucas","followers_url":"https://api.github.com/users/amilcarlucas/followers","following_url":"https://api.github.com/users/amilcarlucas/following{/other_user}","gists_url":"https://api.github.com/users/amilcarlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/amilcarlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amilcarlucas/subscriptions","organizations_url":"https://api.github.com/users/amilcarlucas/orgs","repos_url":"https://api.github.com/users/amilcarlucas/repos","events_url":"https://api.github.com/users/amilcarlucas/events{/privacy}","received_events_url":"https://api.github.com/users/amilcarlucas/received_events","type":"User","site_admin":false},"body":"That will flood the debug output a bit... but yes it avoids code duplication.\r\nWhy use is_configured instead of status != NO_GPS ?\r\n","created_at":"2018-04-27T00:03:20Z","updated_at":"2018-04-27T00:03:20Z","html_url":"https://github.com/ArduPilot/ardupilot/pull/8253#discussion_r184563119","pull_request_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8253","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/184563119"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/8253#discussion_r184563119"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8253"}},"in_reply_to_id":184536377},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8253","id":184467948,"html_url":"https://github.com/ArduPilot/ardupilot/pull/8253","diff_url":"https://github.com/ArduPilot/ardupilot/pull/8253.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/8253.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8253","number":8253,"state":"open","locked":false,"title":"AP_GPS: Do not inject RTCM data into a non-initialized Septentrio GPS","user":{"login":"amilcarlucas","id":24453563,"avatar_url":"https://avatars1.githubusercontent.com/u/24453563?v=4","gravatar_id":"","url":"https://api.github.com/users/amilcarlucas","html_url":"https://github.com/amilcarlucas","followers_url":"https://api.github.com/users/amilcarlucas/followers","following_url":"https://api.github.com/users/amilcarlucas/following{/other_user}","gists_url":"https://api.github.com/users/amilcarlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/amilcarlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amilcarlucas/subscriptions","organizations_url":"https://api.github.com/users/amilcarlucas/orgs","repos_url":"https://api.github.com/users/amilcarlucas/repos","events_url":"https://api.github.com/users/amilcarlucas/events{/privacy}","received_events_url":"https://api.github.com/users/amilcarlucas/received_events","type":"User","site_admin":false},"body":"Septentrio configuration step fails if RTCM corrections are injected while configuring/initializing.\r\nSo wait until configuration is completed, before injecting RTCM data.","created_at":"2018-04-26T21:22:53Z","updated_at":"2018-04-27T00:03:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"709f4531f7a42e79b396905b090e2e1f397c57ba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":243404494,"url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/GPS","name":"GPS","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8253/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8253/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8253/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/0c78eb9a876ee58a71888acc766f67a395e8c011","head":{"label":"amilcarlucas:pr-avoid-sbf-misconfiguration","ref":"pr-avoid-sbf-misconfiguration","sha":"0c78eb9a876ee58a71888acc766f67a395e8c011","user":{"login":"amilcarlucas","id":24453563,"avatar_url":"https://avatars1.githubusercontent.com/u/24453563?v=4","gravatar_id":"","url":"https://api.github.com/users/amilcarlucas","html_url":"https://github.com/amilcarlucas","followers_url":"https://api.github.com/users/amilcarlucas/followers","following_url":"https://api.github.com/users/amilcarlucas/following{/other_user}","gists_url":"https://api.github.com/users/amilcarlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/amilcarlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amilcarlucas/subscriptions","organizations_url":"https://api.github.com/users/amilcarlucas/orgs","repos_url":"https://api.github.com/users/amilcarlucas/repos","events_url":"https://api.github.com/users/amilcarlucas/events{/privacy}","received_events_url":"https://api.github.com/users/amilcarlucas/received_events","type":"User","site_admin":false},"repo":{"id":75927972,"name":"ardupilot","full_name":"amilcarlucas/ardupilot","owner":{"login":"amilcarlucas","id":24453563,"avatar_url":"https://avatars1.githubusercontent.com/u/24453563?v=4","gravatar_id":"","url":"https://api.github.com/users/amilcarlucas","html_url":"https://github.com/amilcarlucas","followers_url":"https://api.github.com/users/amilcarlucas/followers","following_url":"https://api.github.com/users/amilcarlucas/following{/other_user}","gists_url":"https://api.github.com/users/amilcarlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/amilcarlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amilcarlucas/subscriptions","organizations_url":"https://api.github.com/users/amilcarlucas/orgs","repos_url":"https://api.github.com/users/amilcarlucas/repos","events_url":"https://api.github.com/users/amilcarlucas/events{/privacy}","received_events_url":"https://api.github.com/users/amilcarlucas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amilcarlucas/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":true,"url":"https://api.github.com/repos/amilcarlucas/ardupilot","forks_url":"https://api.github.com/repos/amilcarlucas/ardupilot/forks","keys_url":"https://api.github.com/repos/amilcarlucas/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amilcarlucas/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amilcarlucas/ardupilot/teams","hooks_url":"https://api.github.com/repos/amilcarlucas/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/amilcarlucas/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/amilcarlucas/ardupilot/events","assignees_url":"https://api.github.com/repos/amilcarlucas/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/amilcarlucas/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/amilcarlucas/ardupilot/tags","blobs_url":"https://api.github.com/repos/amilcarlucas/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amilcarlucas/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amilcarlucas/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/amilcarlucas/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amilcarlucas/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/amilcarlucas/ardupilot/languages","stargazers_url":"https://api.github.com/repos/amilcarlucas/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/amilcarlucas/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/amilcarlucas/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/amilcarlucas/ardupilot/subscription","commits_url":"https://api.github.com/repos/amilcarlucas/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/amilcarlucas/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/amilcarlucas/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/amilcarlucas/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/amilcarlucas/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/amilcarlucas/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amilcarlucas/ardupilot/merges","archive_url":"https://api.github.com/repos/amilcarlucas/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amilcarlucas/ardupilot/downloads","issues_url":"https://api.github.com/repos/amilcarlucas/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/amilcarlucas/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/amilcarlucas/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/amilcarlucas/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amilcarlucas/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/amilcarlucas/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/amilcarlucas/ardupilot/deployments","created_at":"2016-12-08T10:31:35Z","updated_at":"2018-04-26T08:38:08Z","pushed_at":"2018-04-26T21:22:10Z","git_url":"git://github.com/amilcarlucas/ardupilot.git","ssh_url":"git@github.com:amilcarlucas/ardupilot.git","clone_url":"https://github.com/amilcarlucas/ardupilot.git","svn_url":"https://github.com/amilcarlucas/ardupilot","homepage":"http://ardupilot.org/","size":99569,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"c20351202da204cf9cc71beaa1d321a99d9ce8ac","user":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"name":"ardupilot","full_name":"ArduPilot/ardupilot","owner":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2018-04-26T23:30:52Z","pushed_at":"2018-04-26T23:30:11Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":100612,"stargazers_count":3155,"watchers_count":3155,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6256,"mirror_url":null,"archived":false,"open_issues_count":1119,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":6256,"open_issues":1119,"watchers":3155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8253"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/8253"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8253"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8253/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8253/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8253/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/0c78eb9a876ee58a71888acc766f67a395e8c011"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amilcarlucas"}}