{"action":"created","comment":{"url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/comments/194184617","pull_request_review_id":127318781,"id":194184617,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDE4NDYxNw==","diff_hunk":"@@ -79,6 +84,49 @@ export default class Plate extends PlateBase {\n     return totalTorque.applyMatrix3(this.invMomentOfInertia)\n   }\n \n+  updateCenter() {\n+    const safeFields = {}\n+    let safeSum = new THREE.Vector3()","path":"js/plates-model/plate.js","position":null,"original_position":34,"commit_id":"7263bcae54f30403b36905d07998100ff766bacd","original_commit_id":"f12c2df18aada6941410d54861dde8cc80f754a6","user":{"login":"ekosmin","id":3824039,"node_id":"MDQ6VXNlcjM4MjQwMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3824039?v=4","gravatar_id":"","url":"https://api.github.com/users/ekosmin","html_url":"https://github.com/ekosmin","followers_url":"https://api.github.com/users/ekosmin/followers","following_url":"https://api.github.com/users/ekosmin/following{/other_user}","gists_url":"https://api.github.com/users/ekosmin/gists{/gist_id}","starred_url":"https://api.github.com/users/ekosmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekosmin/subscriptions","organizations_url":"https://api.github.com/users/ekosmin/orgs","repos_url":"https://api.github.com/users/ekosmin/repos","events_url":"https://api.github.com/users/ekosmin/events{/privacy}","received_events_url":"https://api.github.com/users/ekosmin/received_events","type":"User","site_admin":false},"body":"Whoops! I actually was changing the reference before, I didn't realize I could mutate Vectors. Fixed now, nice catch","created_at":"2018-06-08T21:22:28Z","updated_at":"2018-06-08T21:22:28Z","html_url":"https://github.com/concord-consortium/tectonic-explorer/pull/33#discussion_r194184617","pull_request_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/comments/194184617"},"html":{"href":"https://github.com/concord-consortium/tectonic-explorer/pull/33#discussion_r194184617"},"pull_request":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/33"}},"in_reply_to_id":194031891},"pull_request":{"url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/33","id":192570118,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTcwMTE4","html_url":"https://github.com/concord-consortium/tectonic-explorer/pull/33","diff_url":"https://github.com/concord-consortium/tectonic-explorer/pull/33.diff","patch_url":"https://github.com/concord-consortium/tectonic-explorer/pull/33.patch","issue_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/33","number":33,"state":"open","locked":false,"title":"Plate markers","user":{"login":"ekosmin","id":3824039,"node_id":"MDQ6VXNlcjM4MjQwMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3824039?v=4","gravatar_id":"","url":"https://api.github.com/users/ekosmin","html_url":"https://github.com/ekosmin","followers_url":"https://api.github.com/users/ekosmin/followers","following_url":"https://api.github.com/users/ekosmin/following{/other_user}","gists_url":"https://api.github.com/users/ekosmin/gists{/gist_id}","starred_url":"https://api.github.com/users/ekosmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekosmin/subscriptions","organizations_url":"https://api.github.com/users/ekosmin/orgs","repos_url":"https://api.github.com/users/ekosmin/repos","events_url":"https://api.github.com/users/ekosmin/events{/privacy}","received_events_url":"https://api.github.com/users/ekosmin/received_events","type":"User","site_admin":false},"body":"@pjanik The plate markers might keep changing, but I was hoping you could take a look at the code I have so far! I think the commits ended up pretty clean and straightforward.\r\n\r\nhttp://tectonic-explorer.concord.org/branch/plate-markers/index.html\r\n\r\nhttps://www.pivotaltracker.com/story/show/157632753","created_at":"2018-06-05T01:44:35Z","updated_at":"2018-06-08T21:22:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8e02a4901bea3091a755c07116b2fcdbc3e8dfe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lbondaryk","id":1867623,"node_id":"MDQ6VXNlcjE4Njc2MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1867623?v=4","gravatar_id":"","url":"https://api.github.com/users/lbondaryk","html_url":"https://github.com/lbondaryk","followers_url":"https://api.github.com/users/lbondaryk/followers","following_url":"https://api.github.com/users/lbondaryk/following{/other_user}","gists_url":"https://api.github.com/users/lbondaryk/gists{/gist_id}","starred_url":"https://api.github.com/users/lbondaryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbondaryk/subscriptions","organizations_url":"https://api.github.com/users/lbondaryk/orgs","repos_url":"https://api.github.com/users/lbondaryk/repos","events_url":"https://api.github.com/users/lbondaryk/events{/privacy}","received_events_url":"https://api.github.com/users/lbondaryk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/33/commits","review_comments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/33/comments","review_comment_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/33/comments","statuses_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/statuses/7263bcae54f30403b36905d07998100ff766bacd","head":{"label":"concord-consortium:plate-markers","ref":"plate-markers","sha":"7263bcae54f30403b36905d07998100ff766bacd","user":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":89474068,"node_id":"MDEwOlJlcG9zaXRvcnk4OTQ3NDA2OA==","name":"tectonic-explorer","full_name":"concord-consortium/tectonic-explorer","owner":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concord-consortium/tectonic-explorer","description":null,"fork":false,"url":"https://api.github.com/repos/concord-consortium/tectonic-explorer","forks_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/forks","keys_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/teams","hooks_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/events","assignees_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/tags","blobs_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/subscription","commits_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/merges","archive_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/downloads","issues_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/deployments","created_at":"2017-04-26T11:38:19Z","updated_at":"2018-06-08T11:38:16Z","pushed_at":"2018-06-08T21:20:39Z","git_url":"git://github.com/concord-consortium/tectonic-explorer.git","ssh_url":"git@github.com:concord-consortium/tectonic-explorer.git","clone_url":"https://github.com/concord-consortium/tectonic-explorer.git","svn_url":"https://github.com/concord-consortium/tectonic-explorer","homepage":null,"size":3510,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"concord-consortium:master","ref":"master","sha":"a3b97e73134b05b496d613d4cb21029e623448dd","user":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":89474068,"node_id":"MDEwOlJlcG9zaXRvcnk4OTQ3NDA2OA==","name":"tectonic-explorer","full_name":"concord-consortium/tectonic-explorer","owner":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concord-consortium/tectonic-explorer","description":null,"fork":false,"url":"https://api.github.com/repos/concord-consortium/tectonic-explorer","forks_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/forks","keys_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/teams","hooks_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/events","assignees_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/tags","blobs_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/subscription","commits_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/merges","archive_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/downloads","issues_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/tectonic-explorer/deployments","created_at":"2017-04-26T11:38:19Z","updated_at":"2018-06-08T11:38:16Z","pushed_at":"2018-06-08T21:20:39Z","git_url":"git://github.com/concord-consortium/tectonic-explorer.git","ssh_url":"git@github.com:concord-consortium/tectonic-explorer.git","clone_url":"https://github.com/concord-consortium/tectonic-explorer.git","svn_url":"https://github.com/concord-consortium/tectonic-explorer","homepage":null,"size":3510,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/33"},"html":{"href":"https://github.com/concord-consortium/tectonic-explorer/pull/33"},"issue":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/33"},"comments":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/concord-consortium/tectonic-explorer/statuses/7263bcae54f30403b36905d07998100ff766bacd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ekosmin"}}