{"action":"created","issue":{"url":"https://api.github.com/repos/ninja-build/ninja/issues/1479","repository_url":"https://api.github.com/repos/ninja-build/ninja","labels_url":"https://api.github.com/repos/ninja-build/ninja/issues/1479/labels{/name}","comments_url":"https://api.github.com/repos/ninja-build/ninja/issues/1479/comments","events_url":"https://api.github.com/repos/ninja-build/ninja/issues/1479/events","html_url":"https://github.com/ninja-build/ninja/pull/1479","id":369588659,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDk1MDk3","number":1479,"title":"Expand @rspfile to rspfile_contents in reported commands","user":{"login":"jon-turney","id":3497232,"node_id":"MDQ6VXNlcjM0OTcyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3497232?v=4","gravatar_id":"","url":"https://api.github.com/users/jon-turney","html_url":"https://github.com/jon-turney","followers_url":"https://api.github.com/users/jon-turney/followers","following_url":"https://api.github.com/users/jon-turney/following{/other_user}","gists_url":"https://api.github.com/users/jon-turney/gists{/gist_id}","starred_url":"https://api.github.com/users/jon-turney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon-turney/subscriptions","organizations_url":"https://api.github.com/users/jon-turney/orgs","repos_url":"https://api.github.com/users/jon-turney/repos","events_url":"https://api.github.com/users/jon-turney/events{/privacy}","received_events_url":"https://api.github.com/users/jon-turney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-12T14:58:39Z","updated_at":"2018-11-06T21:08:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ninja-build/ninja/pulls/1479","html_url":"https://github.com/ninja-build/ninja/pull/1479","diff_url":"https://github.com/ninja-build/ninja/pull/1479.diff","patch_url":"https://github.com/ninja-build/ninja/pull/1479.patch"},"body":"Move EvaluateCommandWithRspfile() to class Edge\r\nUse it in verbose logging of command\r\nUse it in logging of failed command\r\nTweak documentation"},"comment":{"url":"https://api.github.com/repos/ninja-build/ninja/issues/comments/436408964","html_url":"https://github.com/ninja-build/ninja/pull/1479#issuecomment-436408964","issue_url":"https://api.github.com/repos/ninja-build/ninja/issues/1479","id":436408964,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjQwODk2NA==","user":{"login":"jon-turney","id":3497232,"node_id":"MDQ6VXNlcjM0OTcyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3497232?v=4","gravatar_id":"","url":"https://api.github.com/users/jon-turney","html_url":"https://github.com/jon-turney","followers_url":"https://api.github.com/users/jon-turney/followers","following_url":"https://api.github.com/users/jon-turney/following{/other_user}","gists_url":"https://api.github.com/users/jon-turney/gists{/gist_id}","starred_url":"https://api.github.com/users/jon-turney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon-turney/subscriptions","organizations_url":"https://api.github.com/users/jon-turney/orgs","repos_url":"https://api.github.com/users/jon-turney/repos","events_url":"https://api.github.com/users/jon-turney/events{/privacy}","received_events_url":"https://api.github.com/users/jon-turney/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T21:08:15Z","updated_at":"2018-11-06T21:08:15Z","author_association":"NONE","body":"> Why did you move `EvaluateCommandWithRspfile` into `Edge`?\r\n\r\nI guess my thinking was something like:\r\n\r\n* Keeping it in ninja.cc, I would either have had to create a ninja.h, since one doesn't exist, or chosen some other header to put the prototype in.\r\n* It's unclear it really belongs in ninja.cc, since that seems to mainly contain code related to main()\r\n* Since it's just a wrapper around some other methods of class Edge, it seems to belong there.\r\n"}}
{"actor":{"display_login":"jon-turney"}}