{"action":"created","comment":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/comments/244996468","pull_request_review_id":189007008,"id":244996468,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk5NjQ2OA==","diff_hunk":"@@ -180,7 +180,7 @@ public static void setPreallocSize(long size) {\n      * @param serverStats used to update fsyncThresholdExceedCount\n      */\n     @Override\n-    public void setServerStats(ServerStats serverStats) {\n+    public synchronized void setServerStats(ServerStats serverStats) {","path":"zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java","position":5,"original_position":5,"commit_id":"a43cecf4158b786911a035659b1ae00b677a0094","original_commit_id":"e4f72f4e9ca5338d3dc5d16839672ea28d8f1b21","user":{"login":"eolivelli","id":9469110,"node_id":"MDQ6VXNlcjk0NjkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"body":"This is spotbugs error:\r\n`[ERROR] Inconsistent synchronization of org.apache.zookeeper.server.persistence.FileTxnLog.serverStats; locked 66% of time [org.apache.zookeeper.server.persistence.FileTxnLog, org.apache.zookeeper.server.persistence.FileTxnLog, org.apache.zookeeper.server.persistence.FileTxnLog] Unsynchronized access at FileTxnLog.java:[line 184]Synchronized access at FileTxnLog.java:[line 381]Synchronized access at FileTxnLog.java:[line 382] IS2_INCONSISTENT_SYNC\r\n`\r\n\r\nI think this change is safe","created_at":"2019-01-03T13:19:47Z","updated_at":"2019-01-03T13:19:47Z","html_url":"https://github.com/apache/zookeeper/pull/742#discussion_r244996468","pull_request_url":"https://api.github.com/repos/apache/zookeeper/pulls/742","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/comments/244996468"},"html":{"href":"https://github.com/apache/zookeeper/pull/742#discussion_r244996468"},"pull_request":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/742"}},"in_reply_to_id":244963646},"pull_request":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/742","id":240224063,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjI0MDYz","html_url":"https://github.com/apache/zookeeper/pull/742","diff_url":"https://github.com/apache/zookeeper/pull/742.diff","patch_url":"https://github.com/apache/zookeeper/pull/742.patch","issue_url":"https://api.github.com/repos/apache/zookeeper/issues/742","number":742,"state":"open","locked":false,"title":"ZOOKEEPER-3223: Configure Spotbugs","user":{"login":"eolivelli","id":9469110,"node_id":"MDQ6VXNlcjk0NjkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"body":"- add spotbugs configuration (default)\r\n- make build pass spotbugs","created_at":"2018-12-20T16:13:16Z","updated_at":"2019-01-03T13:19:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f54a6bbfd43a5a5a3a9833f3115280125261f00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/zookeeper/pulls/742/commits","review_comments_url":"https://api.github.com/repos/apache/zookeeper/pulls/742/comments","review_comment_url":"https://api.github.com/repos/apache/zookeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/zookeeper/issues/742/comments","statuses_url":"https://api.github.com/repos/apache/zookeeper/statuses/a43cecf4158b786911a035659b1ae00b677a0094","head":{"label":"eolivelli:fix/ZOOKEEPER-3223-spotbugs","ref":"fix/ZOOKEEPER-3223-spotbugs","sha":"a43cecf4158b786911a035659b1ae00b677a0094","user":{"login":"eolivelli","id":9469110,"node_id":"MDQ6VXNlcjk0NjkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"repo":{"id":61282955,"node_id":"MDEwOlJlcG9zaXRvcnk2MTI4Mjk1NQ==","name":"zookeeper","full_name":"eolivelli/zookeeper","private":false,"owner":{"login":"eolivelli","id":9469110,"node_id":"MDQ6VXNlcjk0NjkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eolivelli/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":true,"url":"https://api.github.com/repos/eolivelli/zookeeper","forks_url":"https://api.github.com/repos/eolivelli/zookeeper/forks","keys_url":"https://api.github.com/repos/eolivelli/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eolivelli/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eolivelli/zookeeper/teams","hooks_url":"https://api.github.com/repos/eolivelli/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/eolivelli/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/eolivelli/zookeeper/events","assignees_url":"https://api.github.com/repos/eolivelli/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/eolivelli/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/eolivelli/zookeeper/tags","blobs_url":"https://api.github.com/repos/eolivelli/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eolivelli/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eolivelli/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/eolivelli/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eolivelli/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/eolivelli/zookeeper/languages","stargazers_url":"https://api.github.com/repos/eolivelli/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/eolivelli/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/eolivelli/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/eolivelli/zookeeper/subscription","commits_url":"https://api.github.com/repos/eolivelli/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/eolivelli/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/eolivelli/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/eolivelli/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/eolivelli/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/eolivelli/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eolivelli/zookeeper/merges","archive_url":"https://api.github.com/repos/eolivelli/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eolivelli/zookeeper/downloads","issues_url":"https://api.github.com/repos/eolivelli/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/eolivelli/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/eolivelli/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/eolivelli/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eolivelli/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/eolivelli/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/eolivelli/zookeeper/deployments","created_at":"2016-06-16T10:10:53Z","updated_at":"2016-06-16T10:11:01Z","pushed_at":"2019-01-03T13:10:47Z","git_url":"git://github.com/eolivelli/zookeeper.git","ssh_url":"git@github.com:eolivelli/zookeeper.git","clone_url":"https://github.com/eolivelli/zookeeper.git","svn_url":"https://github.com/eolivelli/zookeeper","homepage":null,"size":33750,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:master","ref":"master","sha":"50aeb922a48ed07e48719f4def331b6ed4fcb4fb","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":160999,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5OTk=","name":"zookeeper","full_name":"apache/zookeeper","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":false,"url":"https://api.github.com/repos/apache/zookeeper","forks_url":"https://api.github.com/repos/apache/zookeeper/forks","keys_url":"https://api.github.com/repos/apache/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/zookeeper/teams","hooks_url":"https://api.github.com/repos/apache/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/zookeeper/events","assignees_url":"https://api.github.com/repos/apache/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/zookeeper/tags","blobs_url":"https://api.github.com/repos/apache/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/zookeeper/languages","stargazers_url":"https://api.github.com/repos/apache/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/zookeeper/subscription","commits_url":"https://api.github.com/repos/apache/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/zookeeper/merges","archive_url":"https://api.github.com/repos/apache/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/zookeeper/downloads","issues_url":"https://api.github.com/repos/apache/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/zookeeper/deployments","created_at":"2009-03-27T15:41:56Z","updated_at":"2019-01-03T11:42:25Z","pushed_at":"2019-01-03T13:10:49Z","git_url":"git://github.com/apache/zookeeper.git","ssh_url":"git@github.com:apache/zookeeper.git","clone_url":"https://github.com/apache/zookeeper.git","svn_url":"https://github.com/apache/zookeeper","homepage":null,"size":109468,"stargazers_count":5616,"watchers_count":5616,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3556,"mirror_url":null,"archived":false,"open_issues_count":175,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3556,"open_issues":175,"watchers":5616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/742"},"html":{"href":"https://github.com/apache/zookeeper/pull/742"},"issue":{"href":"https://api.github.com/repos/apache/zookeeper/issues/742"},"comments":{"href":"https://api.github.com/repos/apache/zookeeper/issues/742/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/742/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/742/commits"},"statuses":{"href":"https://api.github.com/repos/apache/zookeeper/statuses/a43cecf4158b786911a035659b1ae00b677a0094"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eolivelli"}}