{"action":"created","comment":{"url":"https://api.github.com/repos/noties/Markwon/pulls/comments/203450368","pull_request_review_id":138342199,"id":203450368,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ1MDM2OA==","diff_hunk":"@@ -368,8 +378,16 @@ public int getCodeBackgroundColor(@NonNull Paint paint, boolean multiline) {\n     }\n \n     public void applyHeadingTextStyle(@NonNull Paint paint, @IntRange(from = 1, to = 6) int level) {\n-        paint.setFakeBoldText(true);\n-        paint.setTextSize(paint.getTextSize() * HEADING_SIZES[level - 1]);\n+        if (headingTypeface == null) {\n+            paint.setFakeBoldText(true);\n+        } else {\n+            paint.setTypeface(headingTypeface);\n+        }\n+        if (headingTextSizes != null && headingTextSizes.length >= level) {","path":"library/src/main/java/ru/noties/markwon/spans/SpannableTheme.java","position":35,"original_position":35,"commit_id":"9bd5644150c02b72394b361c82dc28c042efe5f8","original_commit_id":"9bd5644150c02b72394b361c82dc28c042efe5f8","user":{"login":"edenman","id":1063557,"node_id":"MDQ6VXNlcjEwNjM1NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1063557?v=4","gravatar_id":"","url":"https://api.github.com/users/edenman","html_url":"https://github.com/edenman","followers_url":"https://api.github.com/users/edenman/followers","following_url":"https://api.github.com/users/edenman/following{/other_user}","gists_url":"https://api.github.com/users/edenman/gists{/gist_id}","starred_url":"https://api.github.com/users/edenman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenman/subscriptions","organizations_url":"https://api.github.com/users/edenman/orgs","repos_url":"https://api.github.com/users/edenman/repos","events_url":"https://api.github.com/users/edenman/events{/privacy}","received_events_url":"https://api.github.com/users/edenman/received_events","type":"User","site_admin":false},"body":"...I don't think this is correct.  If level = 6 and headingTextSizes.length = 6, the last index in the array will be 5.  when we index into it on the next line, we subtract one (6-1) = 5.  Unless I'm missing something?","created_at":"2018-07-18T16:42:59Z","updated_at":"2018-07-18T16:42:59Z","html_url":"https://github.com/noties/Markwon/pull/51#discussion_r203450368","pull_request_url":"https://api.github.com/repos/noties/Markwon/pulls/51","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/noties/Markwon/pulls/comments/203450368"},"html":{"href":"https://github.com/noties/Markwon/pull/51#discussion_r203450368"},"pull_request":{"href":"https://api.github.com/repos/noties/Markwon/pulls/51"}},"in_reply_to_id":203372032},"pull_request":{"url":"https://api.github.com/repos/noties/Markwon/pulls/51","id":202011317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDExMzE3","html_url":"https://github.com/noties/Markwon/pull/51","diff_url":"https://github.com/noties/Markwon/pull/51.diff","patch_url":"https://github.com/noties/Markwon/pull/51.patch","issue_url":"https://api.github.com/repos/noties/Markwon/issues/51","number":51,"state":"open","locked":false,"title":"Add headingTypeface, headingTextSizes to SpannableTheme","user":{"login":"edenman","id":1063557,"node_id":"MDQ6VXNlcjEwNjM1NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1063557?v=4","gravatar_id":"","url":"https://api.github.com/users/edenman","html_url":"https://github.com/edenman","followers_url":"https://api.github.com/users/edenman/followers","following_url":"https://api.github.com/users/edenman/following{/other_user}","gists_url":"https://api.github.com/users/edenman/gists{/gist_id}","starred_url":"https://api.github.com/users/edenman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenman/subscriptions","organizations_url":"https://api.github.com/users/edenman/orgs","repos_url":"https://api.github.com/users/edenman/repos","events_url":"https://api.github.com/users/edenman/events{/privacy}","received_events_url":"https://api.github.com/users/edenman/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-17T17:16:43Z","updated_at":"2018-07-18T16:42:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e1afc4f8ed6b4b9b48bafd83d2cfd0effe5e00d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/noties/Markwon/pulls/51/commits","review_comments_url":"https://api.github.com/repos/noties/Markwon/pulls/51/comments","review_comment_url":"https://api.github.com/repos/noties/Markwon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/noties/Markwon/issues/51/comments","statuses_url":"https://api.github.com/repos/noties/Markwon/statuses/9bd5644150c02b72394b361c82dc28c042efe5f8","head":{"label":"edenman:master","ref":"master","sha":"9bd5644150c02b72394b361c82dc28c042efe5f8","user":{"login":"edenman","id":1063557,"node_id":"MDQ6VXNlcjEwNjM1NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1063557?v=4","gravatar_id":"","url":"https://api.github.com/users/edenman","html_url":"https://github.com/edenman","followers_url":"https://api.github.com/users/edenman/followers","following_url":"https://api.github.com/users/edenman/following{/other_user}","gists_url":"https://api.github.com/users/edenman/gists{/gist_id}","starred_url":"https://api.github.com/users/edenman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenman/subscriptions","organizations_url":"https://api.github.com/users/edenman/orgs","repos_url":"https://api.github.com/users/edenman/repos","events_url":"https://api.github.com/users/edenman/events{/privacy}","received_events_url":"https://api.github.com/users/edenman/received_events","type":"User","site_admin":false},"repo":{"id":141309804,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMDk4MDQ=","name":"Markwon","full_name":"edenman/Markwon","owner":{"login":"edenman","id":1063557,"node_id":"MDQ6VXNlcjEwNjM1NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1063557?v=4","gravatar_id":"","url":"https://api.github.com/users/edenman","html_url":"https://github.com/edenman","followers_url":"https://api.github.com/users/edenman/followers","following_url":"https://api.github.com/users/edenman/following{/other_user}","gists_url":"https://api.github.com/users/edenman/gists{/gist_id}","starred_url":"https://api.github.com/users/edenman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenman/subscriptions","organizations_url":"https://api.github.com/users/edenman/orgs","repos_url":"https://api.github.com/users/edenman/repos","events_url":"https://api.github.com/users/edenman/events{/privacy}","received_events_url":"https://api.github.com/users/edenman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edenman/Markwon","description":"Android library for rendering markdown as system-native Spannables","fork":true,"url":"https://api.github.com/repos/edenman/Markwon","forks_url":"https://api.github.com/repos/edenman/Markwon/forks","keys_url":"https://api.github.com/repos/edenman/Markwon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edenman/Markwon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edenman/Markwon/teams","hooks_url":"https://api.github.com/repos/edenman/Markwon/hooks","issue_events_url":"https://api.github.com/repos/edenman/Markwon/issues/events{/number}","events_url":"https://api.github.com/repos/edenman/Markwon/events","assignees_url":"https://api.github.com/repos/edenman/Markwon/assignees{/user}","branches_url":"https://api.github.com/repos/edenman/Markwon/branches{/branch}","tags_url":"https://api.github.com/repos/edenman/Markwon/tags","blobs_url":"https://api.github.com/repos/edenman/Markwon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edenman/Markwon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edenman/Markwon/git/refs{/sha}","trees_url":"https://api.github.com/repos/edenman/Markwon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edenman/Markwon/statuses/{sha}","languages_url":"https://api.github.com/repos/edenman/Markwon/languages","stargazers_url":"https://api.github.com/repos/edenman/Markwon/stargazers","contributors_url":"https://api.github.com/repos/edenman/Markwon/contributors","subscribers_url":"https://api.github.com/repos/edenman/Markwon/subscribers","subscription_url":"https://api.github.com/repos/edenman/Markwon/subscription","commits_url":"https://api.github.com/repos/edenman/Markwon/commits{/sha}","git_commits_url":"https://api.github.com/repos/edenman/Markwon/git/commits{/sha}","comments_url":"https://api.github.com/repos/edenman/Markwon/comments{/number}","issue_comment_url":"https://api.github.com/repos/edenman/Markwon/issues/comments{/number}","contents_url":"https://api.github.com/repos/edenman/Markwon/contents/{+path}","compare_url":"https://api.github.com/repos/edenman/Markwon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edenman/Markwon/merges","archive_url":"https://api.github.com/repos/edenman/Markwon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edenman/Markwon/downloads","issues_url":"https://api.github.com/repos/edenman/Markwon/issues{/number}","pulls_url":"https://api.github.com/repos/edenman/Markwon/pulls{/number}","milestones_url":"https://api.github.com/repos/edenman/Markwon/milestones{/number}","notifications_url":"https://api.github.com/repos/edenman/Markwon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edenman/Markwon/labels{/name}","releases_url":"https://api.github.com/repos/edenman/Markwon/releases{/id}","deployments_url":"https://api.github.com/repos/edenman/Markwon/deployments","created_at":"2018-07-17T15:35:51Z","updated_at":"2018-07-17T17:11:27Z","pushed_at":"2018-07-17T17:11:25Z","git_url":"git://github.com/edenman/Markwon.git","ssh_url":"git@github.com:edenman/Markwon.git","clone_url":"https://github.com/edenman/Markwon.git","svn_url":"https://github.com/edenman/Markwon","homepage":null,"size":5528,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"noties:master","ref":"master","sha":"5ef985670a8614b9c6e2342b7c0146c7cd936a12","user":{"login":"noties","id":7278986,"node_id":"MDQ6VXNlcjcyNzg5ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/7278986?v=4","gravatar_id":"","url":"https://api.github.com/users/noties","html_url":"https://github.com/noties","followers_url":"https://api.github.com/users/noties/followers","following_url":"https://api.github.com/users/noties/following{/other_user}","gists_url":"https://api.github.com/users/noties/gists{/gist_id}","starred_url":"https://api.github.com/users/noties/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noties/subscriptions","organizations_url":"https://api.github.com/users/noties/orgs","repos_url":"https://api.github.com/users/noties/repos","events_url":"https://api.github.com/users/noties/events{/privacy}","received_events_url":"https://api.github.com/users/noties/received_events","type":"User","site_admin":false},"repo":{"id":91698982,"node_id":"MDEwOlJlcG9zaXRvcnk5MTY5ODk4Mg==","name":"Markwon","full_name":"noties/Markwon","owner":{"login":"noties","id":7278986,"node_id":"MDQ6VXNlcjcyNzg5ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/7278986?v=4","gravatar_id":"","url":"https://api.github.com/users/noties","html_url":"https://github.com/noties","followers_url":"https://api.github.com/users/noties/followers","following_url":"https://api.github.com/users/noties/following{/other_user}","gists_url":"https://api.github.com/users/noties/gists{/gist_id}","starred_url":"https://api.github.com/users/noties/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noties/subscriptions","organizations_url":"https://api.github.com/users/noties/orgs","repos_url":"https://api.github.com/users/noties/repos","events_url":"https://api.github.com/users/noties/events{/privacy}","received_events_url":"https://api.github.com/users/noties/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noties/Markwon","description":"Android library for rendering markdown as system-native Spannables","fork":false,"url":"https://api.github.com/repos/noties/Markwon","forks_url":"https://api.github.com/repos/noties/Markwon/forks","keys_url":"https://api.github.com/repos/noties/Markwon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noties/Markwon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noties/Markwon/teams","hooks_url":"https://api.github.com/repos/noties/Markwon/hooks","issue_events_url":"https://api.github.com/repos/noties/Markwon/issues/events{/number}","events_url":"https://api.github.com/repos/noties/Markwon/events","assignees_url":"https://api.github.com/repos/noties/Markwon/assignees{/user}","branches_url":"https://api.github.com/repos/noties/Markwon/branches{/branch}","tags_url":"https://api.github.com/repos/noties/Markwon/tags","blobs_url":"https://api.github.com/repos/noties/Markwon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noties/Markwon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noties/Markwon/git/refs{/sha}","trees_url":"https://api.github.com/repos/noties/Markwon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noties/Markwon/statuses/{sha}","languages_url":"https://api.github.com/repos/noties/Markwon/languages","stargazers_url":"https://api.github.com/repos/noties/Markwon/stargazers","contributors_url":"https://api.github.com/repos/noties/Markwon/contributors","subscribers_url":"https://api.github.com/repos/noties/Markwon/subscribers","subscription_url":"https://api.github.com/repos/noties/Markwon/subscription","commits_url":"https://api.github.com/repos/noties/Markwon/commits{/sha}","git_commits_url":"https://api.github.com/repos/noties/Markwon/git/commits{/sha}","comments_url":"https://api.github.com/repos/noties/Markwon/comments{/number}","issue_comment_url":"https://api.github.com/repos/noties/Markwon/issues/comments{/number}","contents_url":"https://api.github.com/repos/noties/Markwon/contents/{+path}","compare_url":"https://api.github.com/repos/noties/Markwon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noties/Markwon/merges","archive_url":"https://api.github.com/repos/noties/Markwon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noties/Markwon/downloads","issues_url":"https://api.github.com/repos/noties/Markwon/issues{/number}","pulls_url":"https://api.github.com/repos/noties/Markwon/pulls{/number}","milestones_url":"https://api.github.com/repos/noties/Markwon/milestones{/number}","notifications_url":"https://api.github.com/repos/noties/Markwon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noties/Markwon/labels{/name}","releases_url":"https://api.github.com/repos/noties/Markwon/releases{/id}","deployments_url":"https://api.github.com/repos/noties/Markwon/deployments","created_at":"2017-05-18T13:50:21Z","updated_at":"2018-07-18T15:23:03Z","pushed_at":"2018-07-17T17:16:44Z","git_url":"git://github.com/noties/Markwon.git","ssh_url":"git@github.com:noties/Markwon.git","clone_url":"https://github.com/noties/Markwon.git","svn_url":"https://github.com/noties/Markwon","homepage":null,"size":5521,"stargazers_count":405,"watchers_count":405,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":56,"open_issues":8,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/noties/Markwon/pulls/51"},"html":{"href":"https://github.com/noties/Markwon/pull/51"},"issue":{"href":"https://api.github.com/repos/noties/Markwon/issues/51"},"comments":{"href":"https://api.github.com/repos/noties/Markwon/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/noties/Markwon/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/noties/Markwon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/noties/Markwon/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/noties/Markwon/statuses/9bd5644150c02b72394b361c82dc28c042efe5f8"}},"author_association":"NONE"}}
{"actor":{"display_login":"edenman"}}