{"action":"created","issue":{"url":"https://api.github.com/repos/real-logic/artio/issues/187","repository_url":"https://api.github.com/repos/real-logic/artio","labels_url":"https://api.github.com/repos/real-logic/artio/issues/187/labels{/name}","comments_url":"https://api.github.com/repos/real-logic/artio/issues/187/comments","events_url":"https://api.github.com/repos/real-logic/artio/issues/187/events","html_url":"https://github.com/real-logic/artio/issues/187","id":374947340,"node_id":"MDU6SXNzdWUzNzQ5NDczNDA=","number":187,"title":"How about add a new parameter \"offset\"(default is 0)? so that we can pass an segment of an byte buffer.","user":{"login":"guoguanglei","id":6930374,"node_id":"MDQ6VXNlcjY5MzAzNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6930374?v=4","gravatar_id":"","url":"https://api.github.com/users/guoguanglei","html_url":"https://github.com/guoguanglei","followers_url":"https://api.github.com/users/guoguanglei/followers","following_url":"https://api.github.com/users/guoguanglei/following{/other_user}","gists_url":"https://api.github.com/users/guoguanglei/gists{/gist_id}","starred_url":"https://api.github.com/users/guoguanglei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guoguanglei/subscriptions","organizations_url":"https://api.github.com/users/guoguanglei/orgs","repos_url":"https://api.github.com/users/guoguanglei/repos","events_url":"https://api.github.com/users/guoguanglei/events{/privacy}","received_events_url":"https://api.github.com/users/guoguanglei/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-29T10:25:28Z","updated_at":"2018-10-31T03:33:50Z","closed_at":"2018-10-30T11:10:41Z","author_association":"NONE","body":"https://github.com/real-logic/artio/blob/37bbe9c4fc5553a645f5dbcc81c6fb9f64e14508/artio-codecs/src/main/java/uk/co/real_logic/artio/dictionary/generation/EncoderGenerator.java#L379"},"comment":{"url":"https://api.github.com/repos/real-logic/artio/issues/comments/434549468","html_url":"https://github.com/real-logic/artio/issues/187#issuecomment-434549468","issue_url":"https://api.github.com/repos/real-logic/artio/issues/187","id":434549468,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDU0OTQ2OA==","user":{"login":"guoguanglei","id":6930374,"node_id":"MDQ6VXNlcjY5MzAzNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6930374?v=4","gravatar_id":"","url":"https://api.github.com/users/guoguanglei","html_url":"https://github.com/guoguanglei","followers_url":"https://api.github.com/users/guoguanglei/followers","following_url":"https://api.github.com/users/guoguanglei/following{/other_user}","gists_url":"https://api.github.com/users/guoguanglei/gists{/gist_id}","starred_url":"https://api.github.com/users/guoguanglei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guoguanglei/subscriptions","organizations_url":"https://api.github.com/users/guoguanglei/orgs","repos_url":"https://api.github.com/users/guoguanglei/repos","events_url":"https://api.github.com/users/guoguanglei/events{/privacy}","received_events_url":"https://api.github.com/users/guoguanglei/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T03:33:50Z","updated_at":"2018-10-31T03:33:50Z","author_association":"NONE","body":"Hi, Richard\r\n\r\nActually we am expecting add a offset field to the encoder POJO to avoid the copy(see example below).\r\nSame logic to the AsciiSequenceView in the decoder POJO, we are expecting only copy when necessary in our callback.\r\nSo it make sense to us to provide an option to choose between AsciiSequenceView and char copying versions at the codec generation time. #188 \r\n\r\nTake \"symbol\" field in NewOrderSingleEncoder as an example:\r\n```Java\r\n    private byte[] symbol = new byte[1];\r\n\r\n    private int symbolOffset = 0;\r\n\r\n    private int symbolLength = 0;\r\n\r\n    public NewOrderSingleEncoder symbol(final byte[] value, final int offset, final int length)\r\n    {\r\n        symbol = value;\r\n        symbolOffset = offset;\r\n        symbolLength = length;\r\n        return this;\r\n    }\r\n```"}}
{"actor":{"display_login":"guoguanglei"}}