{"action":"created","comment":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/223944600","pull_request_review_id":163193685,"id":223944600,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzk0NDYwMA==","diff_hunk":"@@ -826,7 +826,7 @@ int PacketHandler::processUpdate(DNSPacket *p) {\n     if (rr->d_place == DNSResourceRecord::ANSWER) {\n       int res = checkUpdatePrerequisites(rr, &di);\n       if (res>0) {\n-        g_log<<Logger::Error<<msgPrefix<<\"Failed PreRequisites check, returning \"<<RCode::to_s(res)<<endl;\n+        g_log<<Logger::Error<<msgPrefix<<\"Failed PreRequisites check for \"<<rr->d_name.toLogString()<<\", returning \"<<RCode::to_s(res)<<endl;","path":"pdns/rfc2136handler.cc","position":5,"original_position":5,"commit_id":"8355527fc74bae99f33d2f8f7596958fc3eb25b7","original_commit_id":"8355527fc74bae99f33d2f8f7596958fc3eb25b7","user":{"login":"ahupowerdns","id":1223657,"node_id":"MDQ6VXNlcjEyMjM2NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1223657?v=4","gravatar_id":"","url":"https://api.github.com/users/ahupowerdns","html_url":"https://github.com/ahupowerdns","followers_url":"https://api.github.com/users/ahupowerdns/followers","following_url":"https://api.github.com/users/ahupowerdns/following{/other_user}","gists_url":"https://api.github.com/users/ahupowerdns/gists{/gist_id}","starred_url":"https://api.github.com/users/ahupowerdns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahupowerdns/subscriptions","organizations_url":"https://api.github.com/users/ahupowerdns/orgs","repos_url":"https://api.github.com/users/ahupowerdns/repos","events_url":"https://api.github.com/users/ahupowerdns/events{/privacy}","received_events_url":"https://api.github.com/users/ahupowerdns/received_events","type":"User","site_admin":false},"body":"the rest of the file does it in this style too - I'm not going to waste 0.25 kilowatthours of CI and build to fix this one line.","created_at":"2018-10-10T06:02:04Z","updated_at":"2018-10-10T06:02:04Z","html_url":"https://github.com/PowerDNS/pdns/pull/7046#discussion_r223944600","pull_request_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7046","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/223944600"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/7046#discussion_r223944600"},"pull_request":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7046"}},"in_reply_to_id":223738772},"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7046","id":221472458,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNDcyNDU4","html_url":"https://github.com/PowerDNS/pdns/pull/7046","diff_url":"https://github.com/PowerDNS/pdns/pull/7046.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/7046.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/7046","number":7046,"state":"open","locked":false,"title":"slightly improve rfc2136 error message on failed prerequisite: what name","user":{"login":"ahupowerdns","id":1223657,"node_id":"MDQ6VXNlcjEyMjM2NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1223657?v=4","gravatar_id":"","url":"https://api.github.com/users/ahupowerdns","html_url":"https://github.com/ahupowerdns","followers_url":"https://api.github.com/users/ahupowerdns/followers","following_url":"https://api.github.com/users/ahupowerdns/following{/other_user}","gists_url":"https://api.github.com/users/ahupowerdns/gists{/gist_id}","starred_url":"https://api.github.com/users/ahupowerdns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahupowerdns/subscriptions","organizations_url":"https://api.github.com/users/ahupowerdns/orgs","repos_url":"https://api.github.com/users/ahupowerdns/repos","events_url":"https://api.github.com/users/ahupowerdns/events{/privacy}","received_events_url":"https://api.github.com/users/ahupowerdns/received_events","type":"User","site_admin":false},"body":"### Short description\r\nOne of the PreReq error messages does not actually tell you the problem domain. Now it does.\r\n\r\n### Checklist\r\n<!-- please indicate if any of these things are done/included with this Pull Request. Not all boxes need to be checked for the Pull Request to be accepted -->\r\nI have:\r\n- [X] read the [CONTRIBUTING.md](https://github.com/PowerDNS/pdns/blob/master/CONTRIBUTING.md) document\r\n- [X] compiled this code\r\n- [ ] tested this code\r\n- [ ] included documentation (including possible behaviour changes)\r\n- [ ] documented the code\r\n- [ ] added or modified regression test(s)\r\n- [ ] added or modified unit test(s)\r\n- [ ] <!-- remove this line if your PR is against master --> checked that this code was merged to master\r\n","created_at":"2018-10-09T14:54:42Z","updated_at":"2018-10-10T06:02:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3af157b4ae2d75746f2d68cbe898d99edcca9a65","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":37445974,"node_id":"MDU6TGFiZWwzNzQ0NTk3NA==","url":"https://api.github.com/repos/PowerDNS/pdns/labels/auth","name":"auth","color":"eb6420","default":false},{"id":37446008,"node_id":"MDU6TGFiZWwzNzQ0NjAwOA==","url":"https://api.github.com/repos/PowerDNS/pdns/labels/enhancement","name":"enhancement","color":"cccccc","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7046/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/7046/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/7046/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/8355527fc74bae99f33d2f8f7596958fc3eb25b7","head":{"label":"ahupowerdns:dynupdate-log-improv","ref":"dynupdate-log-improv","sha":"8355527fc74bae99f33d2f8f7596958fc3eb25b7","user":{"login":"ahupowerdns","id":1223657,"node_id":"MDQ6VXNlcjEyMjM2NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1223657?v=4","gravatar_id":"","url":"https://api.github.com/users/ahupowerdns","html_url":"https://github.com/ahupowerdns","followers_url":"https://api.github.com/users/ahupowerdns/followers","following_url":"https://api.github.com/users/ahupowerdns/following{/other_user}","gists_url":"https://api.github.com/users/ahupowerdns/gists{/gist_id}","starred_url":"https://api.github.com/users/ahupowerdns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahupowerdns/subscriptions","organizations_url":"https://api.github.com/users/ahupowerdns/orgs","repos_url":"https://api.github.com/users/ahupowerdns/repos","events_url":"https://api.github.com/users/ahupowerdns/events{/privacy}","received_events_url":"https://api.github.com/users/ahupowerdns/received_events","type":"User","site_admin":false},"repo":{"id":9909238,"node_id":"MDEwOlJlcG9zaXRvcnk5OTA5MjM4","name":"pdns","full_name":"ahupowerdns/pdns","private":false,"owner":{"login":"ahupowerdns","id":1223657,"node_id":"MDQ6VXNlcjEyMjM2NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1223657?v=4","gravatar_id":"","url":"https://api.github.com/users/ahupowerdns","html_url":"https://github.com/ahupowerdns","followers_url":"https://api.github.com/users/ahupowerdns/followers","following_url":"https://api.github.com/users/ahupowerdns/following{/other_user}","gists_url":"https://api.github.com/users/ahupowerdns/gists{/gist_id}","starred_url":"https://api.github.com/users/ahupowerdns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahupowerdns/subscriptions","organizations_url":"https://api.github.com/users/ahupowerdns/orgs","repos_url":"https://api.github.com/users/ahupowerdns/repos","events_url":"https://api.github.com/users/ahupowerdns/events{/privacy}","received_events_url":"https://api.github.com/users/ahupowerdns/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ahupowerdns/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/ahupowerdns/pdns","forks_url":"https://api.github.com/repos/ahupowerdns/pdns/forks","keys_url":"https://api.github.com/repos/ahupowerdns/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahupowerdns/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahupowerdns/pdns/teams","hooks_url":"https://api.github.com/repos/ahupowerdns/pdns/hooks","issue_events_url":"https://api.github.com/repos/ahupowerdns/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/ahupowerdns/pdns/events","assignees_url":"https://api.github.com/repos/ahupowerdns/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/ahupowerdns/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/ahupowerdns/pdns/tags","blobs_url":"https://api.github.com/repos/ahupowerdns/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahupowerdns/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahupowerdns/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahupowerdns/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahupowerdns/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/ahupowerdns/pdns/languages","stargazers_url":"https://api.github.com/repos/ahupowerdns/pdns/stargazers","contributors_url":"https://api.github.com/repos/ahupowerdns/pdns/contributors","subscribers_url":"https://api.github.com/repos/ahupowerdns/pdns/subscribers","subscription_url":"https://api.github.com/repos/ahupowerdns/pdns/subscription","commits_url":"https://api.github.com/repos/ahupowerdns/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahupowerdns/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahupowerdns/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahupowerdns/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahupowerdns/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/ahupowerdns/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahupowerdns/pdns/merges","archive_url":"https://api.github.com/repos/ahupowerdns/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahupowerdns/pdns/downloads","issues_url":"https://api.github.com/repos/ahupowerdns/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/ahupowerdns/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/ahupowerdns/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/ahupowerdns/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahupowerdns/pdns/labels{/name}","releases_url":"https://api.github.com/repos/ahupowerdns/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/ahupowerdns/pdns/deployments","created_at":"2013-05-07T10:17:07Z","updated_at":"2018-08-27T11:12:17Z","pushed_at":"2018-10-09T14:53:55Z","git_url":"git://github.com/ahupowerdns/pdns.git","ssh_url":"git@github.com:ahupowerdns/pdns.git","clone_url":"https://github.com/ahupowerdns/pdns.git","svn_url":"https://github.com/ahupowerdns/pdns","homepage":null,"size":43074,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":0,"watchers":13,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"35278283520297b1740a48c5d695abd0505af470","user":{"login":"PowerDNS","id":1282630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODI2MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1282630?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"node_id":"MDEwOlJlcG9zaXRvcnk5NjkzNTM0","name":"pdns","full_name":"PowerDNS/pdns","private":false,"owner":{"login":"PowerDNS","id":1282630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODI2MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1282630?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/PowerDNS/pdns/deployments","created_at":"2013-04-26T11:16:49Z","updated_at":"2018-10-09T12:28:49Z","pushed_at":"2018-10-09T19:25:02Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":45211,"stargazers_count":1366,"watchers_count":1366,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":445,"mirror_url":null,"archived":false,"open_issues_count":651,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":445,"open_issues":651,"watchers":1366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7046"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/7046"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/7046"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/7046/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7046/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/7046/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/8355527fc74bae99f33d2f8f7596958fc3eb25b7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ahupowerdns"}}