{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-dubbo/issues/3133","repository_url":"https://api.github.com/repos/apache/incubator-dubbo","labels_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/3133/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/3133/comments","events_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/3133/events","html_url":"https://github.com/apache/incubator-dubbo/pull/3133","id":395795660,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMTY1MjUw","number":3133,"title":"Add some about registry javadoc and delete some useless code","user":{"login":"Leishunyu","id":29188508,"node_id":"MDQ6VXNlcjI5MTg4NTA4","avatar_url":"https://avatars3.githubusercontent.com/u/29188508?v=4","gravatar_id":"","url":"https://api.github.com/users/Leishunyu","html_url":"https://github.com/Leishunyu","followers_url":"https://api.github.com/users/Leishunyu/followers","following_url":"https://api.github.com/users/Leishunyu/following{/other_user}","gists_url":"https://api.github.com/users/Leishunyu/gists{/gist_id}","starred_url":"https://api.github.com/users/Leishunyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leishunyu/subscriptions","organizations_url":"https://api.github.com/users/Leishunyu/orgs","repos_url":"https://api.github.com/users/Leishunyu/repos","events_url":"https://api.github.com/users/Leishunyu/events{/privacy}","received_events_url":"https://api.github.com/users/Leishunyu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-04T03:08:33Z","updated_at":"2019-01-04T03:32:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-dubbo/pulls/3133","html_url":"https://github.com/apache/incubator-dubbo/pull/3133","diff_url":"https://github.com/apache/incubator-dubbo/pull/3133.diff","patch_url":"https://github.com/apache/incubator-dubbo/pull/3133.patch"},"body":"## What is the purpose of the change\r\n\r\nhttps://github.com/apache/incubator-dubbo/issues/2999\r\n## Brief changelog\r\n\r\nAdd some about registry javadoc and delete some useless code\r\n\r\n## Verifying this change\r\n\r\nAdd some about registry javadoc and delete some useless code\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.\r\n- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.\r\n- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.\r\n- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).\r\n- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.\r\n- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-dubbo/issues/comments/451345718","html_url":"https://github.com/apache/incubator-dubbo/pull/3133#issuecomment-451345718","issue_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/3133","id":451345718,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTM0NTcxOA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T03:32:41Z","updated_at":"2019-01-04T03:32:41Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3133?src=pr&el=h1) Report\n> Merging [#3133](https://codecov.io/gh/apache/incubator-dubbo/pull/3133?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/2147d90679bdaf56f515bc8bae08fcc301771022?src=pr&el=desc) will **increase** coverage by `0.03%`.\n> The diff coverage is `44.44%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3133?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #3133      +/-   ##\n============================================\n+ Coverage     63.59%   63.63%   +0.03%     \n  Complexity       75       75              \n============================================\n  Files           652      652              \n  Lines         28186    28184       -2     \n  Branches       4783     4781       -2     \n============================================\n+ Hits          17926    17934       +8     \n+ Misses         8005     7997       -8     \n+ Partials       2255     2253       -2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3133?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...ubbo/registry/support/AbstractRegistryFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnlGYWN0b3J5LmphdmE=) | `87.09% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...o/registry/zookeeper/ZookeeperRegistryFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS96b29rZWVwZXIvWm9va2VlcGVyUmVnaXN0cnlGYWN0b3J5LmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...he/dubbo/registry/zookeeper/ZookeeperRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS96b29rZWVwZXIvWm9va2VlcGVyUmVnaXN0cnkuamF2YQ==) | `65.51% <44.44%> (-0.47%)` | `0 <0> (ø)` | |\n| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | `0% <0%> (ø)` | |\n| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `72.5% <0%> (-1.67%)` | `0% <0%> (ø)` | |\n| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |\n| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `58.64% <0%> (+0.37%)` | `0% <0%> (ø)` | :arrow_down: |\n| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `82.33% <0%> (+0.75%)` | `0% <0%> (ø)` | :arrow_down: |\n| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `65.51% <0%> (+1.72%)` | `0% <0%> (ø)` | :arrow_down: |\n| [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `58.13% <0%> (+2.32%)` | `0% <0%> (ø)` | :arrow_down: |\n| ... and [3 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3133/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3133?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3133?src=pr&el=footer). Last update [2147d90...555e8dd](https://codecov.io/gh/apache/incubator-dubbo/pull/3133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}