{"action":"created","comment":{"url":"https://api.github.com/repos/aurelia/templating/pulls/comments/196285655","pull_request_review_id":129807575,"id":196285655,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjI4NTY1NQ==","diff_hunk":"@@ -38,7 +38,7 @@ export class BehaviorPropertyObserver {\n   setValue(newValue: any): void {\n     let oldValue = this.currentValue;\n \n-    if (oldValue !== newValue) {\n+    if (Object.is(newValue, oldValue)) {","path":"src/behavior-property-observer.js","position":null,"original_position":5,"commit_id":"b0366ab2f31f7853927228fe620671a47ecdec75","original_commit_id":"bf8ec9ac9580486af69bbf94f9742ccea521ad96","user":{"login":"bigopon","id":9994529,"node_id":"MDQ6VXNlcjk5OTQ1Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/9994529?v=4","gravatar_id":"","url":"https://api.github.com/users/bigopon","html_url":"https://github.com/bigopon","followers_url":"https://api.github.com/users/bigopon/followers","following_url":"https://api.github.com/users/bigopon/following{/other_user}","gists_url":"https://api.github.com/users/bigopon/gists{/gist_id}","starred_url":"https://api.github.com/users/bigopon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigopon/subscriptions","organizations_url":"https://api.github.com/users/bigopon/orgs","repos_url":"https://api.github.com/users/bigopon/repos","events_url":"https://api.github.com/users/bigopon/events{/privacy}","received_events_url":"https://api.github.com/users/bigopon/received_events","type":"User","site_admin":false},"body":"Yes, it's fixed. Thanks for catching that.","created_at":"2018-06-19T03:28:52Z","updated_at":"2018-06-19T03:28:52Z","html_url":"https://github.com/aurelia/templating/pull/598#discussion_r196285655","pull_request_url":"https://api.github.com/repos/aurelia/templating/pulls/598","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aurelia/templating/pulls/comments/196285655"},"html":{"href":"https://github.com/aurelia/templating/pull/598#discussion_r196285655"},"pull_request":{"href":"https://api.github.com/repos/aurelia/templating/pulls/598"}},"in_reply_to_id":196284656},"pull_request":{"url":"https://api.github.com/repos/aurelia/templating/pulls/598","id":164541374,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY0NTQxMzc0","html_url":"https://github.com/aurelia/templating/pull/598","diff_url":"https://github.com/aurelia/templating/pull/598.diff","patch_url":"https://github.com/aurelia/templating/pull/598.patch","issue_url":"https://api.github.com/repos/aurelia/templating/issues/598","number":598,"state":"open","locked":false,"title":"fix(BehaviorPropertyObserver): use Object.is() for comparison","user":{"login":"bigopon","id":9994529,"node_id":"MDQ6VXNlcjk5OTQ1Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/9994529?v=4","gravatar_id":"","url":"https://api.github.com/users/bigopon","html_url":"https://github.com/bigopon","followers_url":"https://api.github.com/users/bigopon/followers","following_url":"https://api.github.com/users/bigopon/following{/other_user}","gists_url":"https://api.github.com/users/bigopon/gists{/gist_id}","starred_url":"https://api.github.com/users/bigopon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigopon/subscriptions","organizations_url":"https://api.github.com/users/bigopon/orgs","repos_url":"https://api.github.com/users/bigopon/repos","events_url":"https://api.github.com/users/bigopon/events{/privacy}","received_events_url":"https://api.github.com/users/bigopon/received_events","type":"User","site_admin":false},"body":"* requires aurelia/polyfills#58\r\n* resolves aurelia/binding#613\r\n\r\nPerformance shouldn't take any hit with native `Object.is` implementation, app using polyfill of `Object.is` will. Overall won't be a big deal and Aurelia will be more reliable as comparison between `NaN`, `+0`, `-0`  will no longer an issue.","created_at":"2018-01-23T10:49:52Z","updated_at":"2018-06-19T03:28:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10dff812e1a5a49fd95ba7db2bb479f1366802a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aurelia/templating/pulls/598/commits","review_comments_url":"https://api.github.com/repos/aurelia/templating/pulls/598/comments","review_comment_url":"https://api.github.com/repos/aurelia/templating/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aurelia/templating/issues/598/comments","statuses_url":"https://api.github.com/repos/aurelia/templating/statuses/b0366ab2f31f7853927228fe620671a47ecdec75","head":{"label":"bigopon:fix-behavior-property-observer","ref":"fix-behavior-property-observer","sha":"b0366ab2f31f7853927228fe620671a47ecdec75","user":{"login":"bigopon","id":9994529,"node_id":"MDQ6VXNlcjk5OTQ1Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/9994529?v=4","gravatar_id":"","url":"https://api.github.com/users/bigopon","html_url":"https://github.com/bigopon","followers_url":"https://api.github.com/users/bigopon/followers","following_url":"https://api.github.com/users/bigopon/following{/other_user}","gists_url":"https://api.github.com/users/bigopon/gists{/gist_id}","starred_url":"https://api.github.com/users/bigopon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigopon/subscriptions","organizations_url":"https://api.github.com/users/bigopon/orgs","repos_url":"https://api.github.com/users/bigopon/repos","events_url":"https://api.github.com/users/bigopon/events{/privacy}","received_events_url":"https://api.github.com/users/bigopon/received_events","type":"User","site_admin":false},"repo":{"id":72926149,"node_id":"MDEwOlJlcG9zaXRvcnk3MjkyNjE0OQ==","name":"templating","full_name":"bigopon/templating","owner":{"login":"bigopon","id":9994529,"node_id":"MDQ6VXNlcjk5OTQ1Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/9994529?v=4","gravatar_id":"","url":"https://api.github.com/users/bigopon","html_url":"https://github.com/bigopon","followers_url":"https://api.github.com/users/bigopon/followers","following_url":"https://api.github.com/users/bigopon/following{/other_user}","gists_url":"https://api.github.com/users/bigopon/gists{/gist_id}","starred_url":"https://api.github.com/users/bigopon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigopon/subscriptions","organizations_url":"https://api.github.com/users/bigopon/orgs","repos_url":"https://api.github.com/users/bigopon/repos","events_url":"https://api.github.com/users/bigopon/events{/privacy}","received_events_url":"https://api.github.com/users/bigopon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bigopon/templating","description":"An extensible HTML templating engine supporting databinding, custom elements, attached behaviors and more.","fork":true,"url":"https://api.github.com/repos/bigopon/templating","forks_url":"https://api.github.com/repos/bigopon/templating/forks","keys_url":"https://api.github.com/repos/bigopon/templating/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigopon/templating/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigopon/templating/teams","hooks_url":"https://api.github.com/repos/bigopon/templating/hooks","issue_events_url":"https://api.github.com/repos/bigopon/templating/issues/events{/number}","events_url":"https://api.github.com/repos/bigopon/templating/events","assignees_url":"https://api.github.com/repos/bigopon/templating/assignees{/user}","branches_url":"https://api.github.com/repos/bigopon/templating/branches{/branch}","tags_url":"https://api.github.com/repos/bigopon/templating/tags","blobs_url":"https://api.github.com/repos/bigopon/templating/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigopon/templating/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigopon/templating/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigopon/templating/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigopon/templating/statuses/{sha}","languages_url":"https://api.github.com/repos/bigopon/templating/languages","stargazers_url":"https://api.github.com/repos/bigopon/templating/stargazers","contributors_url":"https://api.github.com/repos/bigopon/templating/contributors","subscribers_url":"https://api.github.com/repos/bigopon/templating/subscribers","subscription_url":"https://api.github.com/repos/bigopon/templating/subscription","commits_url":"https://api.github.com/repos/bigopon/templating/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigopon/templating/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigopon/templating/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigopon/templating/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigopon/templating/contents/{+path}","compare_url":"https://api.github.com/repos/bigopon/templating/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigopon/templating/merges","archive_url":"https://api.github.com/repos/bigopon/templating/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigopon/templating/downloads","issues_url":"https://api.github.com/repos/bigopon/templating/issues{/number}","pulls_url":"https://api.github.com/repos/bigopon/templating/pulls{/number}","milestones_url":"https://api.github.com/repos/bigopon/templating/milestones{/number}","notifications_url":"https://api.github.com/repos/bigopon/templating/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigopon/templating/labels{/name}","releases_url":"https://api.github.com/repos/bigopon/templating/releases{/id}","deployments_url":"https://api.github.com/repos/bigopon/templating/deployments","created_at":"2016-11-05T12:57:45Z","updated_at":"2018-05-29T09:07:05Z","pushed_at":"2018-06-19T03:27:56Z","git_url":"git://github.com/bigopon/templating.git","ssh_url":"git@github.com:bigopon/templating.git","clone_url":"https://github.com/bigopon/templating.git","svn_url":"https://github.com/bigopon/templating","homepage":null,"size":5542,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aurelia:master","ref":"master","sha":"64e73f57677c6c07c215b4a599e1c755ed5f9c49","user":{"login":"aurelia","id":9808864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MDg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9808864?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":27804716,"node_id":"MDEwOlJlcG9zaXRvcnkyNzgwNDcxNg==","name":"templating","full_name":"aurelia/templating","owner":{"login":"aurelia","id":9808864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MDg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9808864?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aurelia/templating","description":"An extensible HTML templating engine supporting databinding, custom elements, attached behaviors and more.","fork":false,"url":"https://api.github.com/repos/aurelia/templating","forks_url":"https://api.github.com/repos/aurelia/templating/forks","keys_url":"https://api.github.com/repos/aurelia/templating/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/templating/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/templating/teams","hooks_url":"https://api.github.com/repos/aurelia/templating/hooks","issue_events_url":"https://api.github.com/repos/aurelia/templating/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/templating/events","assignees_url":"https://api.github.com/repos/aurelia/templating/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/templating/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/templating/tags","blobs_url":"https://api.github.com/repos/aurelia/templating/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/templating/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/templating/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/templating/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/templating/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/templating/languages","stargazers_url":"https://api.github.com/repos/aurelia/templating/stargazers","contributors_url":"https://api.github.com/repos/aurelia/templating/contributors","subscribers_url":"https://api.github.com/repos/aurelia/templating/subscribers","subscription_url":"https://api.github.com/repos/aurelia/templating/subscription","commits_url":"https://api.github.com/repos/aurelia/templating/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/templating/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/templating/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/templating/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/templating/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/templating/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/templating/merges","archive_url":"https://api.github.com/repos/aurelia/templating/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/templating/downloads","issues_url":"https://api.github.com/repos/aurelia/templating/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/templating/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/templating/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/templating/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/templating/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/templating/releases{/id}","deployments_url":"https://api.github.com/repos/aurelia/templating/deployments","created_at":"2014-12-10T05:56:48Z","updated_at":"2018-06-05T23:58:58Z","pushed_at":"2018-06-19T03:27:56Z","git_url":"git://github.com/aurelia/templating.git","ssh_url":"git@github.com:aurelia/templating.git","clone_url":"https://github.com/aurelia/templating.git","svn_url":"https://github.com/aurelia/templating","homepage":null,"size":5703,"stargazers_count":111,"watchers_count":111,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":107,"open_issues":58,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aurelia/templating/pulls/598"},"html":{"href":"https://github.com/aurelia/templating/pull/598"},"issue":{"href":"https://api.github.com/repos/aurelia/templating/issues/598"},"comments":{"href":"https://api.github.com/repos/aurelia/templating/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/aurelia/templating/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/aurelia/templating/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aurelia/templating/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/aurelia/templating/statuses/b0366ab2f31f7853927228fe620671a47ecdec75"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bigopon"}}