{"action":"created","comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/comments/172919001","pull_request_review_id":102017767,"id":172919001,"diff_hunk":"@@ -84,20 +83,25 @@ private NewSyndesisExtensionProjectMetaData getProjectMetaData() {\n \t\tif (!locationPage.isInWorkspace()) {\n \t\t\tmetadata.setLocationPath(locationPage.getLocationPath());\n \t\t}\n-\t\tmetadata.setSyndesisExtensionConfig(getSyndesisExtension());\n-\t\tmetadata.setTemplate(new BasicSyndesisExtensionXmlProjectTemplate());\n+\t\t// TODO: remove after we got a logic to determine the springboot and camel versions\n+\t\textensionModel.setSpringBootVersion(\"1.5.8.RELEASE\");\n+\t\textensionModel.setCamelVersion(\"2.20.1\");\n+\t\t// end of TODO\n+\t\tmetadata.setSyndesisExtensionConfig(extensionModel);\n+\t\tif (extensionDetailsPage.isCustomConnector()) {\n+\t\t\t// custom connector template\n+\t\t\tmetadata.setTemplate(new CustomConnectorProjectTemplate());\n+\t\t} else if (extensionDetailsPage.isCamelRoute()) {\n+\t\t\t// custom step as camel route template\n+\t\t\tmetadata.setTemplate(new CustomStepAsCamelRouteProjectTemplate());\n+\t\t} else {\n+\t\t\t// custom step as java bean template","path":"syndesis/plugins/org.fusesource.ide.syndesis.extension.ui/src/org/fusesource/ide/syndesis/extensions/ui/wizards/SyndesisExtensionProjectWizard.java","position":54,"original_position":54,"commit_id":"53e1af1cdf3d12a92531042582c46819165543de","original_commit_id":"53e1af1cdf3d12a92531042582c46819165543de","user":{"login":"apupier","id":1105127,"avatar_url":"https://avatars2.githubusercontent.com/u/1105127?v=4","gravatar_id":"","url":"https://api.github.com/users/apupier","html_url":"https://github.com/apupier","followers_url":"https://api.github.com/users/apupier/followers","following_url":"https://api.github.com/users/apupier/following{/other_user}","gists_url":"https://api.github.com/users/apupier/gists{/gist_id}","starred_url":"https://api.github.com/users/apupier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apupier/subscriptions","organizations_url":"https://api.github.com/users/apupier/orgs","repos_url":"https://api.github.com/users/apupier/repos","events_url":"https://api.github.com/users/apupier/events{/privacy}","received_events_url":"https://api.github.com/users/apupier/received_events","type":"User","site_admin":false},"body":"I think this comment is not very useful as the class name is explicit enough","created_at":"2018-03-07T17:22:00Z","updated_at":"2018-03-07T17:48:23Z","html_url":"https://github.com/jbosstools/jbosstools-fuse/pull/1287#discussion_r172919001","pull_request_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/1287","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/comments/172919001"},"html":{"href":"https://github.com/jbosstools/jbosstools-fuse/pull/1287#discussion_r172919001"},"pull_request":{"href":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/1287"}}},"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/1287","id":171911368,"html_url":"https://github.com/jbosstools/jbosstools-fuse/pull/1287","diff_url":"https://github.com/jbosstools/jbosstools-fuse/pull/1287.diff","patch_url":"https://github.com/jbosstools/jbosstools-fuse/pull/1287.patch","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/issues/1287","number":1287,"state":"open","locked":false,"title":"FUSETOOLS-2834 - refactor Syndesis Extension wizard","user":{"login":"lhein","id":435853,"avatar_url":"https://avatars0.githubusercontent.com/u/435853?v=4","gravatar_id":"","url":"https://api.github.com/users/lhein","html_url":"https://github.com/lhein","followers_url":"https://api.github.com/users/lhein/followers","following_url":"https://api.github.com/users/lhein/following{/other_user}","gists_url":"https://api.github.com/users/lhein/gists{/gist_id}","starred_url":"https://api.github.com/users/lhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhein/subscriptions","organizations_url":"https://api.github.com/users/lhein/orgs","repos_url":"https://api.github.com/users/lhein/repos","events_url":"https://api.github.com/users/lhein/events{/privacy}","received_events_url":"https://api.github.com/users/lhein/received_events","type":"User","site_admin":false},"body":"also incorporates FUSETOOLS-2739 and FUSETOOLS-2779\r\n\r\nSigned-off-by: Lars Heinemann <lhein.smx@gmail.com>\r\n\r\n# Pull Request Checklist\r\n\r\nAfter this checklist is all checked or PR provides explanations for possible pass-through, please put the label \"Ready for review\" on the PR.\r\n\r\n\r\n## General\r\n\r\n- [x] Did you use the Jira Issue number in the commit comments?\r\n- [x] Did you set meaningful commit comments on each commit?\r\n- [x] Did you sign off all commits for this PR? (git commit -s -m \"jira issue number - your commit comment\")\r\n\r\n## Functional\r\n\r\n- [ ] Did the CI job report a successful build?\r\n- [ ] Is the non-happy path working, too?\r\n\r\n## Maintainability\r\n\r\n- [ ] Are all Sonar reported issues fixed or can they be ignored?\r\n- [ ] Is there no duplicated code?\r\n- [ ] Are method-/class-/variable-names meaningful?\r\n\r\n## Tests\r\n\r\n- [ ] Are there unit-tests?\r\n- [ ] Are there integration tests (or at least a jira to tackle these)?\r\n- [ ] Do we need a new UI test?\r\n\r\n## Legal\r\n\r\n- [x] Have you used the correct file header copyright comment?\r\n- [x] Have you used the correct year in the headers of new files?\r\n\r\n","created_at":"2018-02-28T10:24:45Z","updated_at":"2018-03-07T17:48:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbd4c993fe63b3ffb28835ecb4e5d86047263430","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":704525991,"url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/labels/READY%20FOR%20REVIEW","name":"READY FOR REVIEW","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/1287/commits","review_comments_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/1287/comments","review_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/issues/1287/comments","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/statuses/53e1af1cdf3d12a92531042582c46819165543de","head":{"label":"lhein:FUSETOOLS-2834","ref":"FUSETOOLS-2834","sha":"53e1af1cdf3d12a92531042582c46819165543de","user":{"login":"lhein","id":435853,"avatar_url":"https://avatars0.githubusercontent.com/u/435853?v=4","gravatar_id":"","url":"https://api.github.com/users/lhein","html_url":"https://github.com/lhein","followers_url":"https://api.github.com/users/lhein/followers","following_url":"https://api.github.com/users/lhein/following{/other_user}","gists_url":"https://api.github.com/users/lhein/gists{/gist_id}","starred_url":"https://api.github.com/users/lhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhein/subscriptions","organizations_url":"https://api.github.com/users/lhein/orgs","repos_url":"https://api.github.com/users/lhein/repos","events_url":"https://api.github.com/users/lhein/events{/privacy}","received_events_url":"https://api.github.com/users/lhein/received_events","type":"User","site_admin":false},"repo":{"id":117814483,"name":"jbosstools-fuse","full_name":"lhein/jbosstools-fuse","owner":{"login":"lhein","id":435853,"avatar_url":"https://avatars0.githubusercontent.com/u/435853?v=4","gravatar_id":"","url":"https://api.github.com/users/lhein","html_url":"https://github.com/lhein","followers_url":"https://api.github.com/users/lhein/followers","following_url":"https://api.github.com/users/lhein/following{/other_user}","gists_url":"https://api.github.com/users/lhein/gists{/gist_id}","starred_url":"https://api.github.com/users/lhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhein/subscriptions","organizations_url":"https://api.github.com/users/lhein/orgs","repos_url":"https://api.github.com/users/lhein/repos","events_url":"https://api.github.com/users/lhein/events{/privacy}","received_events_url":"https://api.github.com/users/lhein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lhein/jbosstools-fuse","description":"JBoss Camel Developer Tools","fork":true,"url":"https://api.github.com/repos/lhein/jbosstools-fuse","forks_url":"https://api.github.com/repos/lhein/jbosstools-fuse/forks","keys_url":"https://api.github.com/repos/lhein/jbosstools-fuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lhein/jbosstools-fuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lhein/jbosstools-fuse/teams","hooks_url":"https://api.github.com/repos/lhein/jbosstools-fuse/hooks","issue_events_url":"https://api.github.com/repos/lhein/jbosstools-fuse/issues/events{/number}","events_url":"https://api.github.com/repos/lhein/jbosstools-fuse/events","assignees_url":"https://api.github.com/repos/lhein/jbosstools-fuse/assignees{/user}","branches_url":"https://api.github.com/repos/lhein/jbosstools-fuse/branches{/branch}","tags_url":"https://api.github.com/repos/lhein/jbosstools-fuse/tags","blobs_url":"https://api.github.com/repos/lhein/jbosstools-fuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lhein/jbosstools-fuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lhein/jbosstools-fuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/lhein/jbosstools-fuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lhein/jbosstools-fuse/statuses/{sha}","languages_url":"https://api.github.com/repos/lhein/jbosstools-fuse/languages","stargazers_url":"https://api.github.com/repos/lhein/jbosstools-fuse/stargazers","contributors_url":"https://api.github.com/repos/lhein/jbosstools-fuse/contributors","subscribers_url":"https://api.github.com/repos/lhein/jbosstools-fuse/subscribers","subscription_url":"https://api.github.com/repos/lhein/jbosstools-fuse/subscription","commits_url":"https://api.github.com/repos/lhein/jbosstools-fuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/lhein/jbosstools-fuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/lhein/jbosstools-fuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/lhein/jbosstools-fuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/lhein/jbosstools-fuse/contents/{+path}","compare_url":"https://api.github.com/repos/lhein/jbosstools-fuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lhein/jbosstools-fuse/merges","archive_url":"https://api.github.com/repos/lhein/jbosstools-fuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lhein/jbosstools-fuse/downloads","issues_url":"https://api.github.com/repos/lhein/jbosstools-fuse/issues{/number}","pulls_url":"https://api.github.com/repos/lhein/jbosstools-fuse/pulls{/number}","milestones_url":"https://api.github.com/repos/lhein/jbosstools-fuse/milestones{/number}","notifications_url":"https://api.github.com/repos/lhein/jbosstools-fuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lhein/jbosstools-fuse/labels{/name}","releases_url":"https://api.github.com/repos/lhein/jbosstools-fuse/releases{/id}","deployments_url":"https://api.github.com/repos/lhein/jbosstools-fuse/deployments","created_at":"2018-01-17T09:29:14Z","updated_at":"2018-01-17T09:29:23Z","pushed_at":"2018-03-06T14:57:39Z","git_url":"git://github.com/lhein/jbosstools-fuse.git","ssh_url":"git@github.com:lhein/jbosstools-fuse.git","clone_url":"https://github.com/lhein/jbosstools-fuse.git","svn_url":"https://github.com/lhein/jbosstools-fuse","homepage":"http://tools.jboss.org/features/fusetools.html","size":183903,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbosstools:master","ref":"master","sha":"d9926624b8e13686fa48b76eff37ac46bbebdef6","user":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars3.githubusercontent.com/u/619871?v=4","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"repo":{"id":6250543,"name":"jbosstools-fuse","full_name":"jbosstools/jbosstools-fuse","owner":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars3.githubusercontent.com/u/619871?v=4","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbosstools/jbosstools-fuse","description":"JBoss Camel Developer Tools","fork":false,"url":"https://api.github.com/repos/jbosstools/jbosstools-fuse","forks_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/forks","keys_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/teams","hooks_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/hooks","issue_events_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/issues/events{/number}","events_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/events","assignees_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/assignees{/user}","branches_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/branches{/branch}","tags_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/tags","blobs_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/statuses/{sha}","languages_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/languages","stargazers_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/stargazers","contributors_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/contributors","subscribers_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/subscribers","subscription_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/subscription","commits_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/contents/{+path}","compare_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/merges","archive_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/downloads","issues_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/issues{/number}","pulls_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls{/number}","milestones_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/milestones{/number}","notifications_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/labels{/name}","releases_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/releases{/id}","deployments_url":"https://api.github.com/repos/jbosstools/jbosstools-fuse/deployments","created_at":"2012-10-16T19:45:49Z","updated_at":"2018-02-09T18:47:02Z","pushed_at":"2018-03-07T17:43:07Z","git_url":"git://github.com/jbosstools/jbosstools-fuse.git","ssh_url":"git@github.com:jbosstools/jbosstools-fuse.git","clone_url":"https://github.com/jbosstools/jbosstools-fuse.git","svn_url":"https://github.com/jbosstools/jbosstools-fuse","homepage":"http://tools.jboss.org/features/fusetools.html","size":183838,"stargazers_count":63,"watchers_count":63,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":92,"open_issues":20,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/1287"},"html":{"href":"https://github.com/jbosstools/jbosstools-fuse/pull/1287"},"issue":{"href":"https://api.github.com/repos/jbosstools/jbosstools-fuse/issues/1287"},"comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-fuse/issues/1287/comments"},"review_comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/1287/comments"},"review_comment":{"href":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jbosstools/jbosstools-fuse/pulls/1287/commits"},"statuses":{"href":"https://api.github.com/repos/jbosstools/jbosstools-fuse/statuses/53e1af1cdf3d12a92531042582c46819165543de"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apupier"}}