{"action":"created","issue":{"url":"https://api.github.com/repos/mendersoftware/mender/issues/294","repository_url":"https://api.github.com/repos/mendersoftware/mender","labels_url":"https://api.github.com/repos/mendersoftware/mender/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/mendersoftware/mender/issues/294/comments","events_url":"https://api.github.com/repos/mendersoftware/mender/issues/294/events","html_url":"https://github.com/mendersoftware/mender/pull/294","id":340622682,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwOTg5NDk1","number":294,"title":"Add check for canary value in U-Boot environment.","user":{"login":"kacf","id":4037094,"node_id":"MDQ6VXNlcjQwMzcwOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4037094?v=4","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-12T12:46:45Z","updated_at":"2018-07-16T07:07:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mendersoftware/mender/pulls/294","html_url":"https://github.com/mendersoftware/mender/pull/294","diff_url":"https://github.com/mendersoftware/mender/pull/294.diff","patch_url":"https://github.com/mendersoftware/mender/pull/294.patch"},"body":"The way it works is that we store the 'mender_check_saveenv_canary=1'\r\nvariable in the default U-Boot environment. We do not store the\r\ncorresponding 'mender_saveenv_canary=1' value in the default\r\nenvironment, but instead we write this during the boot process. When\r\nthe Mender client finds the former variable, it will look for the\r\nsecond value as well, and produce an error if it is not present. If\r\nthis happens it is an indication that the U-Boot boot loader and the\r\nuser space tools do not agree on the location of the environment. It\r\nwill also catch cases where mender_setup is not run.\r\n\r\nAlso reorganize the logging and error returning to include the error\r\nwhen returning higher up in the callstack, otherwise the resulting log\r\nentry is quite misleading.\r\n\r\nChangelog: Add automatic check for canary value in U-Boot environment\r\nto try to detect if there is a problem in the environment setup of\r\nU-Boot and/or the u-boot-fw-utils tools.\r\n\r\nSigned-off-by: Kristian Amlie <kristian.amlie@northern.tech>"},"comment":{"url":"https://api.github.com/repos/mendersoftware/mender/issues/comments/405163812","html_url":"https://github.com/mendersoftware/mender/pull/294#issuecomment-405163812","issue_url":"https://api.github.com/repos/mendersoftware/mender/issues/294","id":405163812,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTE2MzgxMg==","user":{"login":"oleorhagen","id":29454137,"node_id":"MDQ6VXNlcjI5NDU0MTM3","avatar_url":"https://avatars3.githubusercontent.com/u/29454137?v=4","gravatar_id":"","url":"https://api.github.com/users/oleorhagen","html_url":"https://github.com/oleorhagen","followers_url":"https://api.github.com/users/oleorhagen/followers","following_url":"https://api.github.com/users/oleorhagen/following{/other_user}","gists_url":"https://api.github.com/users/oleorhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/oleorhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleorhagen/subscriptions","organizations_url":"https://api.github.com/users/oleorhagen/orgs","repos_url":"https://api.github.com/users/oleorhagen/repos","events_url":"https://api.github.com/users/oleorhagen/events{/privacy}","received_events_url":"https://api.github.com/users/oleorhagen/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T07:07:25Z","updated_at":"2018-07-16T07:07:25Z","author_association":"CONTRIBUTOR","body":"Alrighty. Good to go then"}}
{"actor":{"display_login":"oleorhagen"}}