{"action":"created","issue":{"url":"https://api.github.com/repos/convox/rack/issues/2303","repository_url":"https://api.github.com/repos/convox/rack","labels_url":"https://api.github.com/repos/convox/rack/issues/2303/labels{/name}","comments_url":"https://api.github.com/repos/convox/rack/issues/2303/comments","events_url":"https://api.github.com/repos/convox/rack/issues/2303/events","html_url":"https://github.com/convox/rack/issues/2303","id":262937211,"number":2303,"title":"CLI: .env warning when inverting ignore mechanism","user":{"login":"eladidan","id":5042281,"avatar_url":"https://avatars0.githubusercontent.com/u/5042281?v=4","gravatar_id":"","url":"https://api.github.com/users/eladidan","html_url":"https://github.com/eladidan","followers_url":"https://api.github.com/users/eladidan/followers","following_url":"https://api.github.com/users/eladidan/following{/other_user}","gists_url":"https://api.github.com/users/eladidan/gists{/gist_id}","starred_url":"https://api.github.com/users/eladidan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladidan/subscriptions","organizations_url":"https://api.github.com/users/eladidan/orgs","repos_url":"https://api.github.com/users/eladidan/repos","events_url":"https://api.github.com/users/eladidan/events{/privacy}","received_events_url":"https://api.github.com/users/eladidan/received_events","type":"User","site_admin":false},"labels":[{"id":817428438,"url":"https://api.github.com/repos/convox/rack/labels/kind/bug","name":"kind/bug","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-04T21:30:51Z","updated_at":"2018-02-05T12:08:25Z","closed_at":null,"author_association":"NONE","body":"It's common practice to setup `.dockerignore` with the following pattern: \r\n```\r\n*\r\n.*\r\n!<path that should be included>\r\n!...\r\n```\r\n\r\nEssentially this ensures that all files are ignored by default unless explicitly included.\r\nWhen packaging docker this way however, we get the following warning from convox cli  when deploying:\r\n\r\n>WARNING: You have a .env file that is not in your .dockerignore, you may be leaking secrets\r\n\r\nDoes the `.env` actually end up in the tarball this way because convox doesn't parse the ignore file correctly or is the warning simply looking for an explicit `.env` ignore instead of verifying that it isn't in the tar?\r\nThe former is obviously more alarming but from testing with `convox start` it does not seem to be the case."},"comment":{"url":"https://api.github.com/repos/convox/rack/issues/comments/363066523","html_url":"https://github.com/convox/rack/issues/2303#issuecomment-363066523","issue_url":"https://api.github.com/repos/convox/rack/issues/2303","id":363066523,"user":{"login":"exalted","id":314398,"avatar_url":"https://avatars1.githubusercontent.com/u/314398?v=4","gravatar_id":"","url":"https://api.github.com/users/exalted","html_url":"https://github.com/exalted","followers_url":"https://api.github.com/users/exalted/followers","following_url":"https://api.github.com/users/exalted/following{/other_user}","gists_url":"https://api.github.com/users/exalted/gists{/gist_id}","starred_url":"https://api.github.com/users/exalted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exalted/subscriptions","organizations_url":"https://api.github.com/users/exalted/orgs","repos_url":"https://api.github.com/users/exalted/repos","events_url":"https://api.github.com/users/exalted/events{/privacy}","received_events_url":"https://api.github.com/users/exalted/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T12:08:25Z","updated_at":"2018-02-05T12:08:25Z","author_association":"NONE","body":"I think `convox build`, while uploading the tarball to your Rack, isn't working exactly as we expect; meaning its behavior is different than what `docker-compose build` reads from the current working directory.\r\n\r\nA simple `.dockerignore` file that contains:\r\n\r\n```\r\n*\r\n!docker-compose.yml\r\n!Dockerfile\r\n!foobar/app/\r\n```\r\n\r\nApparently will not \"upload\" `foobar/` (or `foobar/app/` for that matter), because right after the upload phase is over, here's the kind of error I get:\r\n\r\n```\r\nDeploying myapp\r\nCreating tarball... OK\r\nUploading:  19.53 MiB / 19.53 MiB [======================] 100.00% 28s\r\nStarting build... OK\r\nAuthenticating 824758182196.dkr.ecr.us-east-1.amazonaws.com: WARNING! Using --password via the CLI is insecure. Use --password-stdin.\r\nLogin Succeeded\r\n\r\nERROR: mkdir /tmp/034435876/foobar/app: no such file or directory\r\nERROR: myapp build failed\r\n```\r\n\r\nThis is prior to `Dockerfile` getting parsed & run, I believe. Not sure at this point what's being uploaded (see `19.53 MiB` above) at this point. Any way to \"debug\" this?"}}
{"actor":{"display_login":"exalted"}}