{"action":"created","comment":{"url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/comments/211084707","pull_request_review_id":147439932,"id":211084707,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA4NDcwNw==","diff_hunk":"@@ -200,20 +207,21 @@ publishing {\n     }\n }\n \n-String getProjectProperty(String propertyName)\n-{\n+String getProjectProperty(String propertyName) {\n     String property = \"\"\n-    if (hasProperty(propertyName))\n-    {\n+    if (hasProperty(propertyName)) {\n         property = this.properties[propertyName]\n     }\n     return property\n }\n \n-wrapper.gradleVersion = '4.6'\n+wrapper {","path":"build.gradle","position":150,"original_position":150,"commit_id":"49f3a9ac27f14cb776c59b70f15aba5713f82ac7","original_commit_id":"49f3a9ac27f14cb776c59b70f15aba5713f82ac7","user":{"login":"Almighty-Alpaca","id":15787444,"node_id":"MDQ6VXNlcjE1Nzg3NDQ0","avatar_url":"https://avatars0.githubusercontent.com/u/15787444?v=4","gravatar_id":"","url":"https://api.github.com/users/Almighty-Alpaca","html_url":"https://github.com/Almighty-Alpaca","followers_url":"https://api.github.com/users/Almighty-Alpaca/followers","following_url":"https://api.github.com/users/Almighty-Alpaca/following{/other_user}","gists_url":"https://api.github.com/users/Almighty-Alpaca/gists{/gist_id}","starred_url":"https://api.github.com/users/Almighty-Alpaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Almighty-Alpaca/subscriptions","organizations_url":"https://api.github.com/users/Almighty-Alpaca/orgs","repos_url":"https://api.github.com/users/Almighty-Alpaca/repos","events_url":"https://api.github.com/users/Almighty-Alpaca/events{/privacy}","received_events_url":"https://api.github.com/users/Almighty-Alpaca/received_events","type":"User","site_admin":false},"body":"Can we surround this with a check if the wrapper tasks exists?\r\n```java\r\nif (tasks.findByName('wrapper')) {\r\n    wrapper {\r\n        gradleVersion = '4.9'\r\n    }\r\n}\r\n```\r\nThe reason for this is that the wrapper tasks only exists on root projects in gradle. If you include JDA as a subproject (I have it as subproject for my test bot for example) even loading the project already fails with \r\n```Could not get unknown property 'wrapper' for project ':JDA' of type org.gradle.api.Project.```","created_at":"2018-08-18T19:57:52Z","updated_at":"2018-08-18T19:57:52Z","html_url":"https://github.com/DV8FromTheWorld/JDA/pull/674#discussion_r211084707","pull_request_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/674","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/comments/211084707"},"html":{"href":"https://github.com/DV8FromTheWorld/JDA/pull/674#discussion_r211084707"},"pull_request":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/674"}}},"pull_request":{"url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/674","id":184591744,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0NTkxNzQ0","html_url":"https://github.com/DV8FromTheWorld/JDA/pull/674","diff_url":"https://github.com/DV8FromTheWorld/JDA/pull/674.diff","patch_url":"https://github.com/DV8FromTheWorld/JDA/pull/674.patch","issue_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/674","number":674,"state":"open","locked":false,"title":"Improve gradle builds and debugging","user":{"login":"MinnDevelopment","id":18090140,"node_id":"MDQ6VXNlcjE4MDkwMTQw","avatar_url":"https://avatars3.githubusercontent.com/u/18090140?v=4","gravatar_id":"","url":"https://api.github.com/users/MinnDevelopment","html_url":"https://github.com/MinnDevelopment","followers_url":"https://api.github.com/users/MinnDevelopment/followers","following_url":"https://api.github.com/users/MinnDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/MinnDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/MinnDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinnDevelopment/subscriptions","organizations_url":"https://api.github.com/users/MinnDevelopment/orgs","repos_url":"https://api.github.com/users/MinnDevelopment/repos","events_url":"https://api.github.com/users/MinnDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/MinnDevelopment/received_events","type":"User","site_admin":false},"body":"[contributing]: https://github.com/DV8FromTheWorld/JDA/wiki/5%29-Contributing\r\n\r\n## Pull Request Etiquette\r\n\r\nThere are several guidelines you should follow in order for your\r\n  Pull Request to be merged.\r\n\r\n- [x] I have checked the PRs for upcoming features/bug fixes.\r\n- [x] I have read the [contributing guidelines][contributing].\r\n\r\n> It is sometimes better to include more changes in a single commit. \r\n  If you find yourself having an overwhelming amount of commits, you\r\n  can **rebase** your branch.\r\n\r\n## Description\r\n\r\n- incremental compilation\r\n- improved ABI stability\r\n- async stack traces in intellij debugging\r\n","created_at":"2018-04-27T11:07:56Z","updated_at":"2018-08-18T19:57:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55213dc5413f41f2898d180ba3f5544c3880c17d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":653685551,"node_id":"MDU6TGFiZWw2NTM2ODU1NTE=","url":"https://api.github.com/repos/DV8FromTheWorld/JDA/labels/status:%20completed","name":"status: completed","color":"fbca04","default":false},{"id":298760265,"node_id":"MDU6TGFiZWwyOTg3NjAyNjU=","url":"https://api.github.com/repos/DV8FromTheWorld/JDA/labels/type:%20enhancement","name":"type: enhancement","color":"84b6eb","default":false},{"id":750558264,"node_id":"MDU6TGFiZWw3NTA1NTgyNjQ=","url":"https://api.github.com/repos/DV8FromTheWorld/JDA/labels/type:%20proposal","name":"type: proposal","color":"fcaec3","default":false},{"id":792280003,"node_id":"MDU6TGFiZWw3OTIyODAwMDM=","url":"https://api.github.com/repos/DV8FromTheWorld/JDA/labels/version:%20revision","name":"version: revision","color":"a4fcf8","default":false}],"milestone":{"url":"https://api.github.com/repos/DV8FromTheWorld/JDA/milestones/14","html_url":"https://github.com/DV8FromTheWorld/JDA/milestone/14","labels_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/milestones/14/labels","id":3547076,"node_id":"MDk6TWlsZXN0b25lMzU0NzA3Ng==","number":14,"title":"3.8.0","description":"","creator":{"login":"MinnDevelopment","id":18090140,"node_id":"MDQ6VXNlcjE4MDkwMTQw","avatar_url":"https://avatars3.githubusercontent.com/u/18090140?v=4","gravatar_id":"","url":"https://api.github.com/users/MinnDevelopment","html_url":"https://github.com/MinnDevelopment","followers_url":"https://api.github.com/users/MinnDevelopment/followers","following_url":"https://api.github.com/users/MinnDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/MinnDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/MinnDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinnDevelopment/subscriptions","organizations_url":"https://api.github.com/users/MinnDevelopment/orgs","repos_url":"https://api.github.com/users/MinnDevelopment/repos","events_url":"https://api.github.com/users/MinnDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/MinnDevelopment/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":9,"state":"open","created_at":"2018-08-05T14:46:39Z","updated_at":"2018-08-18T16:15:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/674/commits","review_comments_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/674/comments","review_comment_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/674/comments","statuses_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/statuses/49f3a9ac27f14cb776c59b70f15aba5713f82ac7","head":{"label":"DV8FromTheWorld:patch-build-script","ref":"patch-build-script","sha":"49f3a9ac27f14cb776c59b70f15aba5713f82ac7","user":{"login":"DV8FromTheWorld","id":1479909,"node_id":"MDQ6VXNlcjE0Nzk5MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1479909?v=4","gravatar_id":"","url":"https://api.github.com/users/DV8FromTheWorld","html_url":"https://github.com/DV8FromTheWorld","followers_url":"https://api.github.com/users/DV8FromTheWorld/followers","following_url":"https://api.github.com/users/DV8FromTheWorld/following{/other_user}","gists_url":"https://api.github.com/users/DV8FromTheWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/DV8FromTheWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DV8FromTheWorld/subscriptions","organizations_url":"https://api.github.com/users/DV8FromTheWorld/orgs","repos_url":"https://api.github.com/users/DV8FromTheWorld/repos","events_url":"https://api.github.com/users/DV8FromTheWorld/events{/privacy}","received_events_url":"https://api.github.com/users/DV8FromTheWorld/received_events","type":"User","site_admin":false},"repo":{"id":47880207,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzg4MDIwNw==","name":"JDA","full_name":"DV8FromTheWorld/JDA","owner":{"login":"DV8FromTheWorld","id":1479909,"node_id":"MDQ6VXNlcjE0Nzk5MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1479909?v=4","gravatar_id":"","url":"https://api.github.com/users/DV8FromTheWorld","html_url":"https://github.com/DV8FromTheWorld","followers_url":"https://api.github.com/users/DV8FromTheWorld/followers","following_url":"https://api.github.com/users/DV8FromTheWorld/following{/other_user}","gists_url":"https://api.github.com/users/DV8FromTheWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/DV8FromTheWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DV8FromTheWorld/subscriptions","organizations_url":"https://api.github.com/users/DV8FromTheWorld/orgs","repos_url":"https://api.github.com/users/DV8FromTheWorld/repos","events_url":"https://api.github.com/users/DV8FromTheWorld/events{/privacy}","received_events_url":"https://api.github.com/users/DV8FromTheWorld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DV8FromTheWorld/JDA","description":"Java wrapper for the popular chat & VOIP service: Discord https://discordapp.com","fork":false,"url":"https://api.github.com/repos/DV8FromTheWorld/JDA","forks_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/forks","keys_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/teams","hooks_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/hooks","issue_events_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/events{/number}","events_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/events","assignees_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/assignees{/user}","branches_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/branches{/branch}","tags_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/tags","blobs_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/statuses/{sha}","languages_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/languages","stargazers_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/stargazers","contributors_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/contributors","subscribers_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/subscribers","subscription_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/subscription","commits_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/contents/{+path}","compare_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/merges","archive_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/downloads","issues_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues{/number}","pulls_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls{/number}","milestones_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/milestones{/number}","notifications_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/labels{/name}","releases_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/releases{/id}","deployments_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/deployments","created_at":"2015-12-12T13:57:32Z","updated_at":"2018-08-18T17:41:23Z","pushed_at":"2018-08-18T16:38:53Z","git_url":"git://github.com/DV8FromTheWorld/JDA.git","ssh_url":"git@github.com:DV8FromTheWorld/JDA.git","clone_url":"https://github.com/DV8FromTheWorld/JDA.git","svn_url":"https://github.com/DV8FromTheWorld/JDA","homepage":"","size":23053,"stargazers_count":669,"watchers_count":669,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":211,"open_issues":19,"watchers":669,"default_branch":"master"}},"base":{"label":"DV8FromTheWorld:development","ref":"development","sha":"0f309c6f314d3c19169fb4efb211da2b3bbc3199","user":{"login":"DV8FromTheWorld","id":1479909,"node_id":"MDQ6VXNlcjE0Nzk5MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1479909?v=4","gravatar_id":"","url":"https://api.github.com/users/DV8FromTheWorld","html_url":"https://github.com/DV8FromTheWorld","followers_url":"https://api.github.com/users/DV8FromTheWorld/followers","following_url":"https://api.github.com/users/DV8FromTheWorld/following{/other_user}","gists_url":"https://api.github.com/users/DV8FromTheWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/DV8FromTheWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DV8FromTheWorld/subscriptions","organizations_url":"https://api.github.com/users/DV8FromTheWorld/orgs","repos_url":"https://api.github.com/users/DV8FromTheWorld/repos","events_url":"https://api.github.com/users/DV8FromTheWorld/events{/privacy}","received_events_url":"https://api.github.com/users/DV8FromTheWorld/received_events","type":"User","site_admin":false},"repo":{"id":47880207,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzg4MDIwNw==","name":"JDA","full_name":"DV8FromTheWorld/JDA","owner":{"login":"DV8FromTheWorld","id":1479909,"node_id":"MDQ6VXNlcjE0Nzk5MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1479909?v=4","gravatar_id":"","url":"https://api.github.com/users/DV8FromTheWorld","html_url":"https://github.com/DV8FromTheWorld","followers_url":"https://api.github.com/users/DV8FromTheWorld/followers","following_url":"https://api.github.com/users/DV8FromTheWorld/following{/other_user}","gists_url":"https://api.github.com/users/DV8FromTheWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/DV8FromTheWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DV8FromTheWorld/subscriptions","organizations_url":"https://api.github.com/users/DV8FromTheWorld/orgs","repos_url":"https://api.github.com/users/DV8FromTheWorld/repos","events_url":"https://api.github.com/users/DV8FromTheWorld/events{/privacy}","received_events_url":"https://api.github.com/users/DV8FromTheWorld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DV8FromTheWorld/JDA","description":"Java wrapper for the popular chat & VOIP service: Discord https://discordapp.com","fork":false,"url":"https://api.github.com/repos/DV8FromTheWorld/JDA","forks_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/forks","keys_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/teams","hooks_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/hooks","issue_events_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/events{/number}","events_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/events","assignees_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/assignees{/user}","branches_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/branches{/branch}","tags_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/tags","blobs_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/statuses/{sha}","languages_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/languages","stargazers_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/stargazers","contributors_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/contributors","subscribers_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/subscribers","subscription_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/subscription","commits_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/contents/{+path}","compare_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/merges","archive_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/downloads","issues_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues{/number}","pulls_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls{/number}","milestones_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/milestones{/number}","notifications_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/labels{/name}","releases_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/releases{/id}","deployments_url":"https://api.github.com/repos/DV8FromTheWorld/JDA/deployments","created_at":"2015-12-12T13:57:32Z","updated_at":"2018-08-18T17:41:23Z","pushed_at":"2018-08-18T16:38:53Z","git_url":"git://github.com/DV8FromTheWorld/JDA.git","ssh_url":"git@github.com:DV8FromTheWorld/JDA.git","clone_url":"https://github.com/DV8FromTheWorld/JDA.git","svn_url":"https://github.com/DV8FromTheWorld/JDA","homepage":"","size":23053,"stargazers_count":669,"watchers_count":669,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":211,"open_issues":19,"watchers":669,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/674"},"html":{"href":"https://github.com/DV8FromTheWorld/JDA/pull/674"},"issue":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/674"},"comments":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/DV8FromTheWorld/JDA/statuses/49f3a9ac27f14cb776c59b70f15aba5713f82ac7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Almighty-Alpaca"}}