{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/comments/243374187","pull_request_review_id":187128287,"id":243374187,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzM3NDE4Nw==","diff_hunk":"@@ -177,7 +178,8 @@ pub mod outer_mod {\n             inner_mod_visible_fn();\n         }\n \n-        // This function is visible\n+        // This function is visible only within `inner_mod`,\n+        // which is the same as leaving it private","path":"src/visibility-and-privacy.md","position":24,"original_position":24,"commit_id":"e5b3fca64a30f22824fe3f20b457a50dca020e55","original_commit_id":"e5b3fca64a30f22824fe3f20b457a50dca020e55","user":{"login":"Centril","id":855702,"node_id":"MDQ6VXNlcjg1NTcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/855702?v=4","gravatar_id":"","url":"https://api.github.com/users/Centril","html_url":"https://github.com/Centril","followers_url":"https://api.github.com/users/Centril/followers","following_url":"https://api.github.com/users/Centril/following{/other_user}","gists_url":"https://api.github.com/users/Centril/gists{/gist_id}","starred_url":"https://api.github.com/users/Centril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Centril/subscriptions","organizations_url":"https://api.github.com/users/Centril/orgs","repos_url":"https://api.github.com/users/Centril/repos","events_url":"https://api.github.com/users/Centril/events{/privacy}","received_events_url":"https://api.github.com/users/Centril/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n        // which is the same as leaving it private.\r\n```","created_at":"2018-12-20T18:31:40Z","updated_at":"2018-12-20T18:32:14Z","html_url":"https://github.com/rust-lang-nursery/reference/pull/481#discussion_r243374187","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/481","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/comments/243374187"},"html":{"href":"https://github.com/rust-lang-nursery/reference/pull/481#discussion_r243374187"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/481"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/481","id":240249576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjQ5NTc2","html_url":"https://github.com/rust-lang-nursery/reference/pull/481","diff_url":"https://github.com/rust-lang-nursery/reference/pull/481.diff","patch_url":"https://github.com/rust-lang-nursery/reference/pull/481.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/reference/issues/481","number":481,"state":"open","locked":false,"title":"Clarify pub(restricted) a bit","user":{"login":"Speedy-Consoles","id":367283,"node_id":"MDQ6VXNlcjM2NzI4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/367283?v=4","gravatar_id":"","url":"https://api.github.com/users/Speedy-Consoles","html_url":"https://github.com/Speedy-Consoles","followers_url":"https://api.github.com/users/Speedy-Consoles/followers","following_url":"https://api.github.com/users/Speedy-Consoles/following{/other_user}","gists_url":"https://api.github.com/users/Speedy-Consoles/gists{/gist_id}","starred_url":"https://api.github.com/users/Speedy-Consoles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Speedy-Consoles/subscriptions","organizations_url":"https://api.github.com/users/Speedy-Consoles/orgs","repos_url":"https://api.github.com/users/Speedy-Consoles/repos","events_url":"https://api.github.com/users/Speedy-Consoles/events{/privacy}","received_events_url":"https://api.github.com/users/Speedy-Consoles/received_events","type":"User","site_admin":false},"body":"I had a bit of trouble understanding the pub(restricted) syntax. Hopefully i got it now. The two things i had problems with are:\r\n- 'pub(self)' and no 'pub' seem to be exactly the same, but the fact that it is not stated in the docs suggests them to be different.\r\n- 'pub(...)' never increases the visibility over 'pub', it just restricts it more. You can write 'pub(crate)' in a module that is not visible within the scope of the crate. Doing this isn't really useful, but the fact that it's possible may be a bit confusing.\r\n\r\nI suggest to add something to the documentation to clarify this a bit.","created_at":"2018-12-20T17:37:28Z","updated_at":"2018-12-20T18:32:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e575ffc0bfa73cfa563b99c25d6be97b4659e9b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/481/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/481/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/reference/issues/481/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/reference/statuses/e5b3fca64a30f22824fe3f20b457a50dca020e55","head":{"label":"Speedy-Consoles:master","ref":"master","sha":"e5b3fca64a30f22824fe3f20b457a50dca020e55","user":{"login":"Speedy-Consoles","id":367283,"node_id":"MDQ6VXNlcjM2NzI4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/367283?v=4","gravatar_id":"","url":"https://api.github.com/users/Speedy-Consoles","html_url":"https://github.com/Speedy-Consoles","followers_url":"https://api.github.com/users/Speedy-Consoles/followers","following_url":"https://api.github.com/users/Speedy-Consoles/following{/other_user}","gists_url":"https://api.github.com/users/Speedy-Consoles/gists{/gist_id}","starred_url":"https://api.github.com/users/Speedy-Consoles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Speedy-Consoles/subscriptions","organizations_url":"https://api.github.com/users/Speedy-Consoles/orgs","repos_url":"https://api.github.com/users/Speedy-Consoles/repos","events_url":"https://api.github.com/users/Speedy-Consoles/events{/privacy}","received_events_url":"https://api.github.com/users/Speedy-Consoles/received_events","type":"User","site_admin":false},"repo":{"id":162589016,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI1ODkwMTY=","name":"reference","full_name":"Speedy-Consoles/reference","private":false,"owner":{"login":"Speedy-Consoles","id":367283,"node_id":"MDQ6VXNlcjM2NzI4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/367283?v=4","gravatar_id":"","url":"https://api.github.com/users/Speedy-Consoles","html_url":"https://github.com/Speedy-Consoles","followers_url":"https://api.github.com/users/Speedy-Consoles/followers","following_url":"https://api.github.com/users/Speedy-Consoles/following{/other_user}","gists_url":"https://api.github.com/users/Speedy-Consoles/gists{/gist_id}","starred_url":"https://api.github.com/users/Speedy-Consoles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Speedy-Consoles/subscriptions","organizations_url":"https://api.github.com/users/Speedy-Consoles/orgs","repos_url":"https://api.github.com/users/Speedy-Consoles/repos","events_url":"https://api.github.com/users/Speedy-Consoles/events{/privacy}","received_events_url":"https://api.github.com/users/Speedy-Consoles/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Speedy-Consoles/reference","description":"The Rust Reference","fork":true,"url":"https://api.github.com/repos/Speedy-Consoles/reference","forks_url":"https://api.github.com/repos/Speedy-Consoles/reference/forks","keys_url":"https://api.github.com/repos/Speedy-Consoles/reference/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Speedy-Consoles/reference/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Speedy-Consoles/reference/teams","hooks_url":"https://api.github.com/repos/Speedy-Consoles/reference/hooks","issue_events_url":"https://api.github.com/repos/Speedy-Consoles/reference/issues/events{/number}","events_url":"https://api.github.com/repos/Speedy-Consoles/reference/events","assignees_url":"https://api.github.com/repos/Speedy-Consoles/reference/assignees{/user}","branches_url":"https://api.github.com/repos/Speedy-Consoles/reference/branches{/branch}","tags_url":"https://api.github.com/repos/Speedy-Consoles/reference/tags","blobs_url":"https://api.github.com/repos/Speedy-Consoles/reference/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Speedy-Consoles/reference/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Speedy-Consoles/reference/git/refs{/sha}","trees_url":"https://api.github.com/repos/Speedy-Consoles/reference/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Speedy-Consoles/reference/statuses/{sha}","languages_url":"https://api.github.com/repos/Speedy-Consoles/reference/languages","stargazers_url":"https://api.github.com/repos/Speedy-Consoles/reference/stargazers","contributors_url":"https://api.github.com/repos/Speedy-Consoles/reference/contributors","subscribers_url":"https://api.github.com/repos/Speedy-Consoles/reference/subscribers","subscription_url":"https://api.github.com/repos/Speedy-Consoles/reference/subscription","commits_url":"https://api.github.com/repos/Speedy-Consoles/reference/commits{/sha}","git_commits_url":"https://api.github.com/repos/Speedy-Consoles/reference/git/commits{/sha}","comments_url":"https://api.github.com/repos/Speedy-Consoles/reference/comments{/number}","issue_comment_url":"https://api.github.com/repos/Speedy-Consoles/reference/issues/comments{/number}","contents_url":"https://api.github.com/repos/Speedy-Consoles/reference/contents/{+path}","compare_url":"https://api.github.com/repos/Speedy-Consoles/reference/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Speedy-Consoles/reference/merges","archive_url":"https://api.github.com/repos/Speedy-Consoles/reference/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Speedy-Consoles/reference/downloads","issues_url":"https://api.github.com/repos/Speedy-Consoles/reference/issues{/number}","pulls_url":"https://api.github.com/repos/Speedy-Consoles/reference/pulls{/number}","milestones_url":"https://api.github.com/repos/Speedy-Consoles/reference/milestones{/number}","notifications_url":"https://api.github.com/repos/Speedy-Consoles/reference/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Speedy-Consoles/reference/labels{/name}","releases_url":"https://api.github.com/repos/Speedy-Consoles/reference/releases{/id}","deployments_url":"https://api.github.com/repos/Speedy-Consoles/reference/deployments","created_at":"2018-12-20T14:17:22Z","updated_at":"2018-12-20T16:31:35Z","pushed_at":"2018-12-20T16:31:33Z","git_url":"git://github.com/Speedy-Consoles/reference.git","ssh_url":"git@github.com:Speedy-Consoles/reference.git","clone_url":"https://github.com/Speedy-Consoles/reference.git","svn_url":"https://github.com/Speedy-Consoles/reference","homepage":"https://doc.rust-lang.org/nightly/reference/","size":2595,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"2a487bd7dabe5063c4860ecb216499feef08fb88","user":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":83575374,"node_id":"MDEwOlJlcG9zaXRvcnk4MzU3NTM3NA==","name":"reference","full_name":"rust-lang-nursery/reference","private":false,"owner":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang-nursery/reference","description":"The Rust Reference","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/reference","forks_url":"https://api.github.com/repos/rust-lang-nursery/reference/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/reference/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/reference/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/reference/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/reference/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/reference/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/reference/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/reference/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/reference/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/reference/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/reference/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/reference/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/reference/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/reference/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/reference/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/reference/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/reference/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/reference/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/reference/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/reference/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/reference/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/reference/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/reference/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/reference/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/reference/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/reference/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/reference/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/reference/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/reference/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/reference/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/reference/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/reference/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/reference/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/reference/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/reference/deployments","created_at":"2017-03-01T16:21:06Z","updated_at":"2018-12-17T08:12:34Z","pushed_at":"2018-12-20T17:37:28Z","git_url":"git://github.com/rust-lang-nursery/reference.git","ssh_url":"git@github.com:rust-lang-nursery/reference.git","clone_url":"https://github.com/rust-lang-nursery/reference.git","svn_url":"https://github.com/rust-lang-nursery/reference","homepage":"https://doc.rust-lang.org/nightly/reference/","size":2597,"stargazers_count":102,"watchers_count":102,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":95,"open_issues":75,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/481"},"html":{"href":"https://github.com/rust-lang-nursery/reference/pull/481"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/issues/481"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/issues/481/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/481/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/481/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/statuses/e5b3fca64a30f22824fe3f20b457a50dca020e55"}},"author_association":"NONE"}}
{"actor":{"display_login":"Centril"}}