{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/19188","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/19188/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/19188/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/19188/events","html_url":"https://github.com/dotnet/coreclr/pull/19188","id":345468228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjA0NTg0","number":19188,"title":"build-test - fix ilasm warnings caused by missing/incorrect extern assembly declarations","user":{"login":"4creators","id":801959,"node_id":"MDQ6VXNlcjgwMTk1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/801959?v=4","gravatar_id":"","url":"https://api.github.com/users/4creators","html_url":"https://github.com/4creators","followers_url":"https://api.github.com/users/4creators/followers","following_url":"https://api.github.com/users/4creators/following{/other_user}","gists_url":"https://api.github.com/users/4creators/gists{/gist_id}","starred_url":"https://api.github.com/users/4creators/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4creators/subscriptions","organizations_url":"https://api.github.com/users/4creators/orgs","repos_url":"https://api.github.com/users/4creators/repos","events_url":"https://api.github.com/users/4creators/events{/privacy}","received_events_url":"https://api.github.com/users/4creators/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-28T18:13:42Z","updated_at":"2018-07-30T17:50:19Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/19188","html_url":"https://github.com/dotnet/coreclr/pull/19188","diff_url":"https://github.com/dotnet/coreclr/pull/19188.diff","patch_url":"https://github.com/dotnet/coreclr/pull/19188.patch"},"body":"Fixes #14689\r\n\r\nWhile working on #19109 fixed all ilasm warnings for priority 0 and 1 builds.\r\n\r\nSince my editor is automatically enforcing .editorconfig coding style white space was fixed in all files which were edited (tabs -> spaces, no white space at the end of line)\r\n\r\nWill create separate issue to track not fixed #14689 warnings - MSB3268"},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/408951736","html_url":"https://github.com/dotnet/coreclr/pull/19188#issuecomment-408951736","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/19188","id":408951736,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODk1MTczNg==","user":{"login":"CarolEidt","id":2973870,"node_id":"MDQ6VXNlcjI5NzM4NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2973870?v=4","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T17:50:19Z","updated_at":"2018-07-30T17:50:19Z","author_association":"MEMBER","body":"I don't believe that we should need to put explicit `publickeytoken` specifications in the IL tests (or at least not for most of them). I wonder if these are here simply because the original IL was created from ildasm, and in many cases it should probably be using `.assembly extern BLAH { auto }`."}}
{"actor":{"display_login":"CarolEidt"}}