{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/recipes/pulls/comments/233143260","pull_request_review_id":174489211,"id":233143260,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE0MzI2MA==","diff_hunk":"@@ -5,10 +5,11 @@\n          xsi:noNamespaceSchemaLocation=\"http://schema.phpunit.de/6.5/phpunit.xsd\"\n          backupGlobals=\"false\"\n          colors=\"true\"\n-         bootstrap=\"tests/bootstrap.php\"\n+         bootstrap=\"bootstrap.php\"\n >\n     <php>\n         <ini name=\"error_reporting\" value=\"-1\" />\n+        <env name=\"APP_ENV\" value=\"test\" />","path":"phpunit/phpunit/4.7/phpunit.xml.dist","position":9,"original_position":9,"commit_id":"3dfd7ea05384e169359c92a55fccbbf5f27bb3e8","original_commit_id":"db32d166582b2bc89c770a355a974872b766c1f8","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"> APP_ENV is already set in bin/phpunit\r\n\r\nAPP_ENV is *explicitly* set to \"test\" in `bin/phpunit` - so that `.env.test` is loaded in both cases.\r\n*Not* adding this line is what would create the inconsistency, by not loading `.env.test` when using `vendor/bin/simple-phpunit` (or `vendor/bin/phpunit` btw if installed.)\r\n\r\nOr did I miss your case?","created_at":"2018-11-13T17:22:07Z","updated_at":"2018-11-13T17:22:07Z","html_url":"https://github.com/symfony/recipes/pull/491#discussion_r233143260","pull_request_url":"https://api.github.com/repos/symfony/recipes/pulls/491","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/recipes/pulls/comments/233143260"},"html":{"href":"https://github.com/symfony/recipes/pull/491#discussion_r233143260"},"pull_request":{"href":"https://api.github.com/repos/symfony/recipes/pulls/491"}},"in_reply_to_id":233127295},"pull_request":{"url":"https://api.github.com/repos/symfony/recipes/pulls/491","id":230268955,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjY4OTU1","html_url":"https://github.com/symfony/recipes/pull/491","diff_url":"https://github.com/symfony/recipes/pull/491.diff","patch_url":"https://github.com/symfony/recipes/pull/491.patch","issue_url":"https://api.github.com/repos/symfony/recipes/issues/491","number":491,"state":"open","locked":false,"title":"Move loading .env files to config/bootstrap.php","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| License       | MIT\r\n\r\nIn #481, we completely forgot about apps that *migrate* to flex.\r\n#481 relies on the Kernel being created at the same time as eg `bin/console`; but apps migrating to flex already have a Kernel, and it won't be updated automatically.\r\n\r\nHere is a radically simpler approach: let's factorize loading `.env` files in a new `bootstrap.php` file that is used as instead of `vendor/autoload.php` to bootstrap the app.","created_at":"2018-11-12T21:08:55Z","updated_at":"2018-11-13T17:22:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6c7ff8acb9783ff9c6df4cb49d2c73c731db3ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/recipes/pulls/491/commits","review_comments_url":"https://api.github.com/repos/symfony/recipes/pulls/491/comments","review_comment_url":"https://api.github.com/repos/symfony/recipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/recipes/issues/491/comments","statuses_url":"https://api.github.com/repos/symfony/recipes/statuses/3dfd7ea05384e169359c92a55fccbbf5f27bb3e8","head":{"label":"nicolas-grekas:config-bootstrap","ref":"config-bootstrap","sha":"3dfd7ea05384e169359c92a55fccbbf5f27bb3e8","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"repo":{"id":101063510,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEwNjM1MTA=","name":"recipes","full_name":"nicolas-grekas/recipes","private":false,"owner":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nicolas-grekas/recipes","description":"Symfony Recipes Repository","fork":true,"url":"https://api.github.com/repos/nicolas-grekas/recipes","forks_url":"https://api.github.com/repos/nicolas-grekas/recipes/forks","keys_url":"https://api.github.com/repos/nicolas-grekas/recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolas-grekas/recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolas-grekas/recipes/teams","hooks_url":"https://api.github.com/repos/nicolas-grekas/recipes/hooks","issue_events_url":"https://api.github.com/repos/nicolas-grekas/recipes/issues/events{/number}","events_url":"https://api.github.com/repos/nicolas-grekas/recipes/events","assignees_url":"https://api.github.com/repos/nicolas-grekas/recipes/assignees{/user}","branches_url":"https://api.github.com/repos/nicolas-grekas/recipes/branches{/branch}","tags_url":"https://api.github.com/repos/nicolas-grekas/recipes/tags","blobs_url":"https://api.github.com/repos/nicolas-grekas/recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolas-grekas/recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolas-grekas/recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolas-grekas/recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolas-grekas/recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolas-grekas/recipes/languages","stargazers_url":"https://api.github.com/repos/nicolas-grekas/recipes/stargazers","contributors_url":"https://api.github.com/repos/nicolas-grekas/recipes/contributors","subscribers_url":"https://api.github.com/repos/nicolas-grekas/recipes/subscribers","subscription_url":"https://api.github.com/repos/nicolas-grekas/recipes/subscription","commits_url":"https://api.github.com/repos/nicolas-grekas/recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolas-grekas/recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolas-grekas/recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolas-grekas/recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolas-grekas/recipes/contents/{+path}","compare_url":"https://api.github.com/repos/nicolas-grekas/recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolas-grekas/recipes/merges","archive_url":"https://api.github.com/repos/nicolas-grekas/recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolas-grekas/recipes/downloads","issues_url":"https://api.github.com/repos/nicolas-grekas/recipes/issues{/number}","pulls_url":"https://api.github.com/repos/nicolas-grekas/recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolas-grekas/recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolas-grekas/recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolas-grekas/recipes/labels{/name}","releases_url":"https://api.github.com/repos/nicolas-grekas/recipes/releases{/id}","deployments_url":"https://api.github.com/repos/nicolas-grekas/recipes/deployments","created_at":"2017-08-22T13:03:34Z","updated_at":"2018-11-12T17:24:22Z","pushed_at":"2018-11-13T17:18:13Z","git_url":"git://github.com/nicolas-grekas/recipes.git","ssh_url":"git@github.com:nicolas-grekas/recipes.git","clone_url":"https://github.com/nicolas-grekas/recipes.git","svn_url":"https://github.com/nicolas-grekas/recipes","homepage":"https://symfony.sh/","size":483,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"7c88accc3aa819de7b3d5f127d88fa0d5b499452","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":79607905,"node_id":"MDEwOlJlcG9zaXRvcnk3OTYwNzkwNQ==","name":"recipes","full_name":"symfony/recipes","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/recipes","description":"Symfony Recipes Repository","fork":false,"url":"https://api.github.com/repos/symfony/recipes","forks_url":"https://api.github.com/repos/symfony/recipes/forks","keys_url":"https://api.github.com/repos/symfony/recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/recipes/teams","hooks_url":"https://api.github.com/repos/symfony/recipes/hooks","issue_events_url":"https://api.github.com/repos/symfony/recipes/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/recipes/events","assignees_url":"https://api.github.com/repos/symfony/recipes/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/recipes/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/recipes/tags","blobs_url":"https://api.github.com/repos/symfony/recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/recipes/languages","stargazers_url":"https://api.github.com/repos/symfony/recipes/stargazers","contributors_url":"https://api.github.com/repos/symfony/recipes/contributors","subscribers_url":"https://api.github.com/repos/symfony/recipes/subscribers","subscription_url":"https://api.github.com/repos/symfony/recipes/subscription","commits_url":"https://api.github.com/repos/symfony/recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/recipes/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/recipes/merges","archive_url":"https://api.github.com/repos/symfony/recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/recipes/downloads","issues_url":"https://api.github.com/repos/symfony/recipes/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/recipes/labels{/name}","releases_url":"https://api.github.com/repos/symfony/recipes/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/recipes/deployments","created_at":"2017-01-20T22:59:16Z","updated_at":"2018-11-13T12:01:53Z","pushed_at":"2018-11-13T17:18:15Z","git_url":"git://github.com/symfony/recipes.git","ssh_url":"git@github.com:symfony/recipes.git","clone_url":"https://github.com/symfony/recipes.git","svn_url":"https://github.com/symfony/recipes","homepage":"https://flex.symfony.com/","size":496,"stargazers_count":535,"watchers_count":535,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":167,"open_issues":35,"watchers":535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/recipes/pulls/491"},"html":{"href":"https://github.com/symfony/recipes/pull/491"},"issue":{"href":"https://api.github.com/repos/symfony/recipes/issues/491"},"comments":{"href":"https://api.github.com/repos/symfony/recipes/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/recipes/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/recipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/recipes/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/recipes/statuses/3dfd7ea05384e169359c92a55fccbbf5f27bb3e8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nicolas-grekas"}}