{"action":"closed","number":96,"pull_request":{"url":"https://api.github.com/repos/isubit/iastate_theme/pulls/96","id":234361159,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzYxMTU5","html_url":"https://github.com/isubit/iastate_theme/pull/96","diff_url":"https://github.com/isubit/iastate_theme/pull/96.diff","patch_url":"https://github.com/isubit/iastate_theme/pull/96.patch","issue_url":"https://api.github.com/repos/isubit/iastate_theme/issues/96","number":96,"state":"closed","locked":false,"title":"D8ISUTHEME-87 Redesign delete confirm page","user":{"login":"sacarney","id":24654361,"node_id":"MDQ6VXNlcjI0NjU0MzYx","avatar_url":"https://avatars3.githubusercontent.com/u/24654361?v=4","gravatar_id":"","url":"https://api.github.com/users/sacarney","html_url":"https://github.com/sacarney","followers_url":"https://api.github.com/users/sacarney/followers","following_url":"https://api.github.com/users/sacarney/following{/other_user}","gists_url":"https://api.github.com/users/sacarney/gists{/gist_id}","starred_url":"https://api.github.com/users/sacarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sacarney/subscriptions","organizations_url":"https://api.github.com/users/sacarney/orgs","repos_url":"https://api.github.com/users/sacarney/repos","events_url":"https://api.github.com/users/sacarney/events{/privacy}","received_events_url":"https://api.github.com/users/sacarney/received_events","type":"User","site_admin":false},"body":"*Goal*\r\n- The current delete page (`node/%/delete`) was difficult to read and had the wrong colors for the buttons, making it a little unclear as to the purpose of the buttons. I wanted to make the page more deliberate and easier to use.\r\n\r\n*What I did*\r\n- Created the template for the confirmation page to wrap the page text in an alert\r\n- Updated the submit buttons template to apply the proper classes to delete buttons\r\n- Added css to manually style the cancel button which is actually a link\r\n- Added some additional useful classes to the body to tell whether you're on a node form page\r\n\r\n*To test*\r\n- Create a node, then try to delete it\r\n- Does the delete page have the warning in a red alert box, a red delete button, and a grey-outlined cancel button?\r\n- Can you keyboard navigate to the buttons?\r\n- Does it work on different content types?","created_at":"2018-11-28T17:22:13Z","updated_at":"2018-11-30T17:21:10Z","closed_at":"2018-11-30T17:21:10Z","merged_at":"2018-11-30T17:21:10Z","merge_commit_sha":"f56a03fca408265364fb6d5c96895e919fd4b52c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Kristi-Elmore","id":12431655,"node_id":"MDQ6VXNlcjEyNDMxNjU1","avatar_url":"https://avatars2.githubusercontent.com/u/12431655?v=4","gravatar_id":"","url":"https://api.github.com/users/Kristi-Elmore","html_url":"https://github.com/Kristi-Elmore","followers_url":"https://api.github.com/users/Kristi-Elmore/followers","following_url":"https://api.github.com/users/Kristi-Elmore/following{/other_user}","gists_url":"https://api.github.com/users/Kristi-Elmore/gists{/gist_id}","starred_url":"https://api.github.com/users/Kristi-Elmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kristi-Elmore/subscriptions","organizations_url":"https://api.github.com/users/Kristi-Elmore/orgs","repos_url":"https://api.github.com/users/Kristi-Elmore/repos","events_url":"https://api.github.com/users/Kristi-Elmore/events{/privacy}","received_events_url":"https://api.github.com/users/Kristi-Elmore/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/isubit/iastate_theme/pulls/96/commits","review_comments_url":"https://api.github.com/repos/isubit/iastate_theme/pulls/96/comments","review_comment_url":"https://api.github.com/repos/isubit/iastate_theme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/isubit/iastate_theme/issues/96/comments","statuses_url":"https://api.github.com/repos/isubit/iastate_theme/statuses/dc26e79409c94ac8aeaa852ae584a366e740d980","head":{"label":"isubit:D8ISUTHEME-87","ref":"D8ISUTHEME-87","sha":"dc26e79409c94ac8aeaa852ae584a366e740d980","user":{"login":"isubit","id":8230036,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyMzAwMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/8230036?v=4","gravatar_id":"","url":"https://api.github.com/users/isubit","html_url":"https://github.com/isubit","followers_url":"https://api.github.com/users/isubit/followers","following_url":"https://api.github.com/users/isubit/following{/other_user}","gists_url":"https://api.github.com/users/isubit/gists{/gist_id}","starred_url":"https://api.github.com/users/isubit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isubit/subscriptions","organizations_url":"https://api.github.com/users/isubit/orgs","repos_url":"https://api.github.com/users/isubit/repos","events_url":"https://api.github.com/users/isubit/events{/privacy}","received_events_url":"https://api.github.com/users/isubit/received_events","type":"Organization","site_admin":false},"repo":{"id":97489549,"node_id":"MDEwOlJlcG9zaXRvcnk5NzQ4OTU0OQ==","name":"iastate_theme","full_name":"isubit/iastate_theme","private":false,"owner":{"login":"isubit","id":8230036,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyMzAwMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/8230036?v=4","gravatar_id":"","url":"https://api.github.com/users/isubit","html_url":"https://github.com/isubit","followers_url":"https://api.github.com/users/isubit/followers","following_url":"https://api.github.com/users/isubit/following{/other_user}","gists_url":"https://api.github.com/users/isubit/gists{/gist_id}","starred_url":"https://api.github.com/users/isubit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isubit/subscriptions","organizations_url":"https://api.github.com/users/isubit/orgs","repos_url":"https://api.github.com/users/isubit/repos","events_url":"https://api.github.com/users/isubit/events{/privacy}","received_events_url":"https://api.github.com/users/isubit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/isubit/iastate_theme","description":"Drupal 8 Theme for Iowa State","fork":false,"url":"https://api.github.com/repos/isubit/iastate_theme","forks_url":"https://api.github.com/repos/isubit/iastate_theme/forks","keys_url":"https://api.github.com/repos/isubit/iastate_theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isubit/iastate_theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isubit/iastate_theme/teams","hooks_url":"https://api.github.com/repos/isubit/iastate_theme/hooks","issue_events_url":"https://api.github.com/repos/isubit/iastate_theme/issues/events{/number}","events_url":"https://api.github.com/repos/isubit/iastate_theme/events","assignees_url":"https://api.github.com/repos/isubit/iastate_theme/assignees{/user}","branches_url":"https://api.github.com/repos/isubit/iastate_theme/branches{/branch}","tags_url":"https://api.github.com/repos/isubit/iastate_theme/tags","blobs_url":"https://api.github.com/repos/isubit/iastate_theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isubit/iastate_theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isubit/iastate_theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/isubit/iastate_theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isubit/iastate_theme/statuses/{sha}","languages_url":"https://api.github.com/repos/isubit/iastate_theme/languages","stargazers_url":"https://api.github.com/repos/isubit/iastate_theme/stargazers","contributors_url":"https://api.github.com/repos/isubit/iastate_theme/contributors","subscribers_url":"https://api.github.com/repos/isubit/iastate_theme/subscribers","subscription_url":"https://api.github.com/repos/isubit/iastate_theme/subscription","commits_url":"https://api.github.com/repos/isubit/iastate_theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/isubit/iastate_theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/isubit/iastate_theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/isubit/iastate_theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/isubit/iastate_theme/contents/{+path}","compare_url":"https://api.github.com/repos/isubit/iastate_theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isubit/iastate_theme/merges","archive_url":"https://api.github.com/repos/isubit/iastate_theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isubit/iastate_theme/downloads","issues_url":"https://api.github.com/repos/isubit/iastate_theme/issues{/number}","pulls_url":"https://api.github.com/repos/isubit/iastate_theme/pulls{/number}","milestones_url":"https://api.github.com/repos/isubit/iastate_theme/milestones{/number}","notifications_url":"https://api.github.com/repos/isubit/iastate_theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isubit/iastate_theme/labels{/name}","releases_url":"https://api.github.com/repos/isubit/iastate_theme/releases{/id}","deployments_url":"https://api.github.com/repos/isubit/iastate_theme/deployments","created_at":"2017-07-17T15:05:49Z","updated_at":"2018-11-07T20:52:10Z","pushed_at":"2018-11-30T17:21:10Z","git_url":"git://github.com/isubit/iastate_theme.git","ssh_url":"git@github.com:isubit/iastate_theme.git","clone_url":"https://github.com/isubit/iastate_theme.git","svn_url":"https://github.com/isubit/iastate_theme","homepage":null,"size":412,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"isubit:development","ref":"development","sha":"0cd3ffbce238be9347e3a314733752597612e9fe","user":{"login":"isubit","id":8230036,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyMzAwMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/8230036?v=4","gravatar_id":"","url":"https://api.github.com/users/isubit","html_url":"https://github.com/isubit","followers_url":"https://api.github.com/users/isubit/followers","following_url":"https://api.github.com/users/isubit/following{/other_user}","gists_url":"https://api.github.com/users/isubit/gists{/gist_id}","starred_url":"https://api.github.com/users/isubit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isubit/subscriptions","organizations_url":"https://api.github.com/users/isubit/orgs","repos_url":"https://api.github.com/users/isubit/repos","events_url":"https://api.github.com/users/isubit/events{/privacy}","received_events_url":"https://api.github.com/users/isubit/received_events","type":"Organization","site_admin":false},"repo":{"id":97489549,"node_id":"MDEwOlJlcG9zaXRvcnk5NzQ4OTU0OQ==","name":"iastate_theme","full_name":"isubit/iastate_theme","private":false,"owner":{"login":"isubit","id":8230036,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyMzAwMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/8230036?v=4","gravatar_id":"","url":"https://api.github.com/users/isubit","html_url":"https://github.com/isubit","followers_url":"https://api.github.com/users/isubit/followers","following_url":"https://api.github.com/users/isubit/following{/other_user}","gists_url":"https://api.github.com/users/isubit/gists{/gist_id}","starred_url":"https://api.github.com/users/isubit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isubit/subscriptions","organizations_url":"https://api.github.com/users/isubit/orgs","repos_url":"https://api.github.com/users/isubit/repos","events_url":"https://api.github.com/users/isubit/events{/privacy}","received_events_url":"https://api.github.com/users/isubit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/isubit/iastate_theme","description":"Drupal 8 Theme for Iowa State","fork":false,"url":"https://api.github.com/repos/isubit/iastate_theme","forks_url":"https://api.github.com/repos/isubit/iastate_theme/forks","keys_url":"https://api.github.com/repos/isubit/iastate_theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isubit/iastate_theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isubit/iastate_theme/teams","hooks_url":"https://api.github.com/repos/isubit/iastate_theme/hooks","issue_events_url":"https://api.github.com/repos/isubit/iastate_theme/issues/events{/number}","events_url":"https://api.github.com/repos/isubit/iastate_theme/events","assignees_url":"https://api.github.com/repos/isubit/iastate_theme/assignees{/user}","branches_url":"https://api.github.com/repos/isubit/iastate_theme/branches{/branch}","tags_url":"https://api.github.com/repos/isubit/iastate_theme/tags","blobs_url":"https://api.github.com/repos/isubit/iastate_theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isubit/iastate_theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isubit/iastate_theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/isubit/iastate_theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isubit/iastate_theme/statuses/{sha}","languages_url":"https://api.github.com/repos/isubit/iastate_theme/languages","stargazers_url":"https://api.github.com/repos/isubit/iastate_theme/stargazers","contributors_url":"https://api.github.com/repos/isubit/iastate_theme/contributors","subscribers_url":"https://api.github.com/repos/isubit/iastate_theme/subscribers","subscription_url":"https://api.github.com/repos/isubit/iastate_theme/subscription","commits_url":"https://api.github.com/repos/isubit/iastate_theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/isubit/iastate_theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/isubit/iastate_theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/isubit/iastate_theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/isubit/iastate_theme/contents/{+path}","compare_url":"https://api.github.com/repos/isubit/iastate_theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isubit/iastate_theme/merges","archive_url":"https://api.github.com/repos/isubit/iastate_theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isubit/iastate_theme/downloads","issues_url":"https://api.github.com/repos/isubit/iastate_theme/issues{/number}","pulls_url":"https://api.github.com/repos/isubit/iastate_theme/pulls{/number}","milestones_url":"https://api.github.com/repos/isubit/iastate_theme/milestones{/number}","notifications_url":"https://api.github.com/repos/isubit/iastate_theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isubit/iastate_theme/labels{/name}","releases_url":"https://api.github.com/repos/isubit/iastate_theme/releases{/id}","deployments_url":"https://api.github.com/repos/isubit/iastate_theme/deployments","created_at":"2017-07-17T15:05:49Z","updated_at":"2018-11-07T20:52:10Z","pushed_at":"2018-11-30T17:21:10Z","git_url":"git://github.com/isubit/iastate_theme.git","ssh_url":"git@github.com:isubit/iastate_theme.git","clone_url":"https://github.com/isubit/iastate_theme.git","svn_url":"https://github.com/isubit/iastate_theme","homepage":null,"size":412,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/isubit/iastate_theme/pulls/96"},"html":{"href":"https://github.com/isubit/iastate_theme/pull/96"},"issue":{"href":"https://api.github.com/repos/isubit/iastate_theme/issues/96"},"comments":{"href":"https://api.github.com/repos/isubit/iastate_theme/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/isubit/iastate_theme/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/isubit/iastate_theme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/isubit/iastate_theme/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/isubit/iastate_theme/statuses/dc26e79409c94ac8aeaa852ae584a366e740d980"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jpilchisu","id":2048441,"node_id":"MDQ6VXNlcjIwNDg0NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/2048441?v=4","gravatar_id":"","url":"https://api.github.com/users/jpilchisu","html_url":"https://github.com/jpilchisu","followers_url":"https://api.github.com/users/jpilchisu/followers","following_url":"https://api.github.com/users/jpilchisu/following{/other_user}","gists_url":"https://api.github.com/users/jpilchisu/gists{/gist_id}","starred_url":"https://api.github.com/users/jpilchisu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpilchisu/subscriptions","organizations_url":"https://api.github.com/users/jpilchisu/orgs","repos_url":"https://api.github.com/users/jpilchisu/repos","events_url":"https://api.github.com/users/jpilchisu/events{/privacy}","received_events_url":"https://api.github.com/users/jpilchisu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":112,"deletions":1,"changed_files":5}}
{"actor":{"display_login":"jpilchisu"}}