{"action":"created","comment":{"url":"https://api.github.com/repos/netket/netket/pulls/comments/237211640","pull_request_review_id":179455842,"id":237211640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzIxMTY0MA==","diff_hunk":"@@ -47,34 +44,13 @@ class CustomGraph : public AbstractGraph {\n \n   std::vector<std::vector<int>> automorphisms_;\n \n-  bool isbipartite_;","path":"NetKet/Graph/custom_graph.hpp","position":19,"original_position":19,"commit_id":"7699918380dfaf4a92fdd2fce0eea24c2131a688","original_commit_id":"2675dc3eca13fc42abfb54cdec854c20b00edd42","user":{"login":"gcarleo","id":28149892,"node_id":"MDQ6VXNlcjI4MTQ5ODky","avatar_url":"https://avatars0.githubusercontent.com/u/28149892?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarleo","html_url":"https://github.com/gcarleo","followers_url":"https://api.github.com/users/gcarleo/followers","following_url":"https://api.github.com/users/gcarleo/following{/other_user}","gists_url":"https://api.github.com/users/gcarleo/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarleo/subscriptions","organizations_url":"https://api.github.com/users/gcarleo/orgs","repos_url":"https://api.github.com/users/gcarleo/repos","events_url":"https://api.github.com/users/gcarleo/events{/privacy}","received_events_url":"https://api.github.com/users/gcarleo/received_events","type":"User","site_admin":false},"body":"Then you need to store also adjacency matrices etc, if you don't want to compute them every time you call the corresponding method. Ideally you need a flag that stores the state of the computation and possibly avoids recomputing everything from scratch if already computed. ","created_at":"2018-11-28T18:42:20Z","updated_at":"2018-11-28T18:42:21Z","html_url":"https://github.com/netket/netket/pull/110#discussion_r237211640","pull_request_url":"https://api.github.com/repos/netket/netket/pulls/110","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/netket/netket/pulls/comments/237211640"},"html":{"href":"https://github.com/netket/netket/pull/110#discussion_r237211640"},"pull_request":{"href":"https://api.github.com/repos/netket/netket/pulls/110"}},"in_reply_to_id":237192829},"pull_request":{"url":"https://api.github.com/repos/netket/netket/pulls/110","id":232120215,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTIwMjE1","html_url":"https://github.com/netket/netket/pull/110","diff_url":"https://github.com/netket/netket/pull/110.diff","patch_url":"https://github.com/netket/netket/pull/110.patch","issue_url":"https://api.github.com/repos/netket/netket/issues/110","number":110,"state":"open","locked":false,"title":"WIP: Finishing up Python support for graphs","user":{"login":"twesterhout","id":14264576,"node_id":"MDQ6VXNlcjE0MjY0NTc2","avatar_url":"https://avatars3.githubusercontent.com/u/14264576?v=4","gravatar_id":"","url":"https://api.github.com/users/twesterhout","html_url":"https://github.com/twesterhout","followers_url":"https://api.github.com/users/twesterhout/followers","following_url":"https://api.github.com/users/twesterhout/following{/other_user}","gists_url":"https://api.github.com/users/twesterhout/gists{/gist_id}","starred_url":"https://api.github.com/users/twesterhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twesterhout/subscriptions","organizations_url":"https://api.github.com/users/twesterhout/orgs","repos_url":"https://api.github.com/users/twesterhout/repos","events_url":"https://api.github.com/users/twesterhout/events{/privacy}","received_events_url":"https://api.github.com/users/twesterhout/received_events","type":"User","site_admin":false},"body":"Should fix #101.","created_at":"2018-11-19T21:39:56Z","updated_at":"2018-11-28T18:42:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ae3423236a79d19dc252c294d295df74a7433ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/netket/netket/pulls/110/commits","review_comments_url":"https://api.github.com/repos/netket/netket/pulls/110/comments","review_comment_url":"https://api.github.com/repos/netket/netket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netket/netket/issues/110/comments","statuses_url":"https://api.github.com/repos/netket/netket/statuses/7699918380dfaf4a92fdd2fce0eea24c2131a688","head":{"label":"twesterhout:issue-101","ref":"issue-101","sha":"7699918380dfaf4a92fdd2fce0eea24c2131a688","user":{"login":"twesterhout","id":14264576,"node_id":"MDQ6VXNlcjE0MjY0NTc2","avatar_url":"https://avatars3.githubusercontent.com/u/14264576?v=4","gravatar_id":"","url":"https://api.github.com/users/twesterhout","html_url":"https://github.com/twesterhout","followers_url":"https://api.github.com/users/twesterhout/followers","following_url":"https://api.github.com/users/twesterhout/following{/other_user}","gists_url":"https://api.github.com/users/twesterhout/gists{/gist_id}","starred_url":"https://api.github.com/users/twesterhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twesterhout/subscriptions","organizations_url":"https://api.github.com/users/twesterhout/orgs","repos_url":"https://api.github.com/users/twesterhout/repos","events_url":"https://api.github.com/users/twesterhout/events{/privacy}","received_events_url":"https://api.github.com/users/twesterhout/received_events","type":"User","site_admin":false},"repo":{"id":134958364,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ5NTgzNjQ=","name":"netket","full_name":"twesterhout/netket","private":false,"owner":{"login":"twesterhout","id":14264576,"node_id":"MDQ6VXNlcjE0MjY0NTc2","avatar_url":"https://avatars3.githubusercontent.com/u/14264576?v=4","gravatar_id":"","url":"https://api.github.com/users/twesterhout","html_url":"https://github.com/twesterhout","followers_url":"https://api.github.com/users/twesterhout/followers","following_url":"https://api.github.com/users/twesterhout/following{/other_user}","gists_url":"https://api.github.com/users/twesterhout/gists{/gist_id}","starred_url":"https://api.github.com/users/twesterhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twesterhout/subscriptions","organizations_url":"https://api.github.com/users/twesterhout/orgs","repos_url":"https://api.github.com/users/twesterhout/repos","events_url":"https://api.github.com/users/twesterhout/events{/privacy}","received_events_url":"https://api.github.com/users/twesterhout/received_events","type":"User","site_admin":false},"html_url":"https://github.com/twesterhout/netket","description":"Machine learning algorithms for many-body quantum systems ","fork":true,"url":"https://api.github.com/repos/twesterhout/netket","forks_url":"https://api.github.com/repos/twesterhout/netket/forks","keys_url":"https://api.github.com/repos/twesterhout/netket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twesterhout/netket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twesterhout/netket/teams","hooks_url":"https://api.github.com/repos/twesterhout/netket/hooks","issue_events_url":"https://api.github.com/repos/twesterhout/netket/issues/events{/number}","events_url":"https://api.github.com/repos/twesterhout/netket/events","assignees_url":"https://api.github.com/repos/twesterhout/netket/assignees{/user}","branches_url":"https://api.github.com/repos/twesterhout/netket/branches{/branch}","tags_url":"https://api.github.com/repos/twesterhout/netket/tags","blobs_url":"https://api.github.com/repos/twesterhout/netket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twesterhout/netket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twesterhout/netket/git/refs{/sha}","trees_url":"https://api.github.com/repos/twesterhout/netket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twesterhout/netket/statuses/{sha}","languages_url":"https://api.github.com/repos/twesterhout/netket/languages","stargazers_url":"https://api.github.com/repos/twesterhout/netket/stargazers","contributors_url":"https://api.github.com/repos/twesterhout/netket/contributors","subscribers_url":"https://api.github.com/repos/twesterhout/netket/subscribers","subscription_url":"https://api.github.com/repos/twesterhout/netket/subscription","commits_url":"https://api.github.com/repos/twesterhout/netket/commits{/sha}","git_commits_url":"https://api.github.com/repos/twesterhout/netket/git/commits{/sha}","comments_url":"https://api.github.com/repos/twesterhout/netket/comments{/number}","issue_comment_url":"https://api.github.com/repos/twesterhout/netket/issues/comments{/number}","contents_url":"https://api.github.com/repos/twesterhout/netket/contents/{+path}","compare_url":"https://api.github.com/repos/twesterhout/netket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twesterhout/netket/merges","archive_url":"https://api.github.com/repos/twesterhout/netket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twesterhout/netket/downloads","issues_url":"https://api.github.com/repos/twesterhout/netket/issues{/number}","pulls_url":"https://api.github.com/repos/twesterhout/netket/pulls{/number}","milestones_url":"https://api.github.com/repos/twesterhout/netket/milestones{/number}","notifications_url":"https://api.github.com/repos/twesterhout/netket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twesterhout/netket/labels{/name}","releases_url":"https://api.github.com/repos/twesterhout/netket/releases{/id}","deployments_url":"https://api.github.com/repos/twesterhout/netket/deployments","created_at":"2018-05-26T12:12:12Z","updated_at":"2018-05-26T12:12:16Z","pushed_at":"2018-11-28T16:38:32Z","git_url":"git://github.com/twesterhout/netket.git","ssh_url":"git@github.com:twesterhout/netket.git","clone_url":"https://github.com/twesterhout/netket.git","svn_url":"https://github.com/twesterhout/netket","homepage":"https://www.netket.org","size":27108,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netket:v2.0","ref":"v2.0","sha":"a383788a150058a6d77c9c00a13a1310de5d5b64","user":{"login":"netket","id":38641916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjQxOTE2","avatar_url":"https://avatars2.githubusercontent.com/u/38641916?v=4","gravatar_id":"","url":"https://api.github.com/users/netket","html_url":"https://github.com/netket","followers_url":"https://api.github.com/users/netket/followers","following_url":"https://api.github.com/users/netket/following{/other_user}","gists_url":"https://api.github.com/users/netket/gists{/gist_id}","starred_url":"https://api.github.com/users/netket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netket/subscriptions","organizations_url":"https://api.github.com/users/netket/orgs","repos_url":"https://api.github.com/users/netket/repos","events_url":"https://api.github.com/users/netket/events{/privacy}","received_events_url":"https://api.github.com/users/netket/received_events","type":"Organization","site_admin":false},"repo":{"id":130741783,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3NDE3ODM=","name":"netket","full_name":"netket/netket","private":false,"owner":{"login":"netket","id":38641916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjQxOTE2","avatar_url":"https://avatars2.githubusercontent.com/u/38641916?v=4","gravatar_id":"","url":"https://api.github.com/users/netket","html_url":"https://github.com/netket","followers_url":"https://api.github.com/users/netket/followers","following_url":"https://api.github.com/users/netket/following{/other_user}","gists_url":"https://api.github.com/users/netket/gists{/gist_id}","starred_url":"https://api.github.com/users/netket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netket/subscriptions","organizations_url":"https://api.github.com/users/netket/orgs","repos_url":"https://api.github.com/users/netket/repos","events_url":"https://api.github.com/users/netket/events{/privacy}","received_events_url":"https://api.github.com/users/netket/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/netket/netket","description":"Machine learning algorithms for many-body quantum systems ","fork":false,"url":"https://api.github.com/repos/netket/netket","forks_url":"https://api.github.com/repos/netket/netket/forks","keys_url":"https://api.github.com/repos/netket/netket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netket/netket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netket/netket/teams","hooks_url":"https://api.github.com/repos/netket/netket/hooks","issue_events_url":"https://api.github.com/repos/netket/netket/issues/events{/number}","events_url":"https://api.github.com/repos/netket/netket/events","assignees_url":"https://api.github.com/repos/netket/netket/assignees{/user}","branches_url":"https://api.github.com/repos/netket/netket/branches{/branch}","tags_url":"https://api.github.com/repos/netket/netket/tags","blobs_url":"https://api.github.com/repos/netket/netket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netket/netket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netket/netket/git/refs{/sha}","trees_url":"https://api.github.com/repos/netket/netket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netket/netket/statuses/{sha}","languages_url":"https://api.github.com/repos/netket/netket/languages","stargazers_url":"https://api.github.com/repos/netket/netket/stargazers","contributors_url":"https://api.github.com/repos/netket/netket/contributors","subscribers_url":"https://api.github.com/repos/netket/netket/subscribers","subscription_url":"https://api.github.com/repos/netket/netket/subscription","commits_url":"https://api.github.com/repos/netket/netket/commits{/sha}","git_commits_url":"https://api.github.com/repos/netket/netket/git/commits{/sha}","comments_url":"https://api.github.com/repos/netket/netket/comments{/number}","issue_comment_url":"https://api.github.com/repos/netket/netket/issues/comments{/number}","contents_url":"https://api.github.com/repos/netket/netket/contents/{+path}","compare_url":"https://api.github.com/repos/netket/netket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netket/netket/merges","archive_url":"https://api.github.com/repos/netket/netket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netket/netket/downloads","issues_url":"https://api.github.com/repos/netket/netket/issues{/number}","pulls_url":"https://api.github.com/repos/netket/netket/pulls{/number}","milestones_url":"https://api.github.com/repos/netket/netket/milestones{/number}","notifications_url":"https://api.github.com/repos/netket/netket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netket/netket/labels{/name}","releases_url":"https://api.github.com/repos/netket/netket/releases{/id}","deployments_url":"https://api.github.com/repos/netket/netket/deployments","created_at":"2018-04-23T18:48:08Z","updated_at":"2018-11-28T09:59:34Z","pushed_at":"2018-11-28T16:38:34Z","git_url":"git://github.com/netket/netket.git","ssh_url":"git@github.com:netket/netket.git","clone_url":"https://github.com/netket/netket.git","svn_url":"https://github.com/netket/netket","homepage":"https://www.netket.org","size":27036,"stargazers_count":72,"watchers_count":72,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":27,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netket/netket/pulls/110"},"html":{"href":"https://github.com/netket/netket/pull/110"},"issue":{"href":"https://api.github.com/repos/netket/netket/issues/110"},"comments":{"href":"https://api.github.com/repos/netket/netket/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/netket/netket/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/netket/netket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netket/netket/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/netket/netket/statuses/7699918380dfaf4a92fdd2fce0eea24c2131a688"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gcarleo"}}