{"action":"closed","number":21711,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21711","id":199958748,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTU4NzQ4","html_url":"https://github.com/nodejs/node/pull/21711","diff_url":"https://github.com/nodejs/node/pull/21711.diff","patch_url":"https://github.com/nodejs/node/pull/21711.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/21711","number":21711,"state":"closed","locked":false,"title":"src: revert removal of SecureContext `_external` getter","user":{"login":"dyatlov","id":360998,"node_id":"MDQ6VXNlcjM2MDk5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/360998?v=4","gravatar_id":"","url":"https://api.github.com/users/dyatlov","html_url":"https://github.com/dyatlov","followers_url":"https://api.github.com/users/dyatlov/followers","following_url":"https://api.github.com/users/dyatlov/following{/other_user}","gists_url":"https://api.github.com/users/dyatlov/gists{/gist_id}","starred_url":"https://api.github.com/users/dyatlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dyatlov/subscriptions","organizations_url":"https://api.github.com/users/dyatlov/orgs","repos_url":"https://api.github.com/users/dyatlov/repos","events_url":"https://api.github.com/users/dyatlov/events{/privacy}","received_events_url":"https://api.github.com/users/dyatlov/received_events","type":"User","site_admin":false},"body":"This `_external` getter is essential for some libs to work:\r\nuWebSockets as an example.\r\n\r\nIt reverts this PR: https://github.com/nodejs/node/pull/20237\r\nUse case which that PR broke: https://github.com/uNetworking/uWebSockets-bindings/blob/master/nodejs/src/uws.js#L508\r\n\r\n##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-07-08T20:22:59Z","updated_at":"2018-10-12T04:13:16Z","closed_at":"2018-10-12T04:13:16Z","merged_at":null,"merge_commit_sha":"bc0bc760273e9ed627b471ad19b0b465c60dfb25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":754449534,"node_id":"MDU6TGFiZWw3NTQ0NDk1MzQ=","url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":155267357,"node_id":"MDU6TGFiZWwxNTUyNjczNTc=","url":"https://api.github.com/repos/nodejs/node/labels/crypto","name":"crypto","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/27","html_url":"https://github.com/nodejs/node/milestone/27","labels_url":"https://api.github.com/repos/nodejs/node/milestones/27/labels","id":2873513,"node_id":"MDk6TWlsZXN0b25lMjg3MzUxMw==","number":27,"title":"11.0.0","description":"","creator":{"login":"jasnell","id":439929,"node_id":"MDQ6VXNlcjQzOTkyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/439929?v=4","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":19,"state":"open","created_at":"2017-10-30T07:17:48Z","updated_at":"2018-10-12T04:13:16Z","due_on":"2018-10-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nodejs/node/pulls/21711/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/21711/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21711/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/27376a30e788d5dfc0fb92cf6e532eaed9b7175f","head":{"label":"hola:master","ref":"master","sha":"27376a30e788d5dfc0fb92cf6e532eaed9b7175f","user":{"login":"hola","id":3351854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTE4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3351854?v=4","gravatar_id":"","url":"https://api.github.com/users/hola","html_url":"https://github.com/hola","followers_url":"https://api.github.com/users/hola/followers","following_url":"https://api.github.com/users/hola/following{/other_user}","gists_url":"https://api.github.com/users/hola/gists{/gist_id}","starred_url":"https://api.github.com/users/hola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hola/subscriptions","organizations_url":"https://api.github.com/users/hola/orgs","repos_url":"https://api.github.com/users/hola/repos","events_url":"https://api.github.com/users/hola/events{/privacy}","received_events_url":"https://api.github.com/users/hola/received_events","type":"Organization","site_admin":false},"repo":{"id":140198888,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAxOTg4ODg=","name":"node","full_name":"hola/node","private":false,"owner":{"login":"hola","id":3351854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTE4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3351854?v=4","gravatar_id":"","url":"https://api.github.com/users/hola","html_url":"https://github.com/hola","followers_url":"https://api.github.com/users/hola/followers","following_url":"https://api.github.com/users/hola/following{/other_user}","gists_url":"https://api.github.com/users/hola/gists{/gist_id}","starred_url":"https://api.github.com/users/hola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hola/subscriptions","organizations_url":"https://api.github.com/users/hola/orgs","repos_url":"https://api.github.com/users/hola/repos","events_url":"https://api.github.com/users/hola/events{/privacy}","received_events_url":"https://api.github.com/users/hola/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hola/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/hola/node","forks_url":"https://api.github.com/repos/hola/node/forks","keys_url":"https://api.github.com/repos/hola/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hola/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hola/node/teams","hooks_url":"https://api.github.com/repos/hola/node/hooks","issue_events_url":"https://api.github.com/repos/hola/node/issues/events{/number}","events_url":"https://api.github.com/repos/hola/node/events","assignees_url":"https://api.github.com/repos/hola/node/assignees{/user}","branches_url":"https://api.github.com/repos/hola/node/branches{/branch}","tags_url":"https://api.github.com/repos/hola/node/tags","blobs_url":"https://api.github.com/repos/hola/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hola/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hola/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/hola/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hola/node/statuses/{sha}","languages_url":"https://api.github.com/repos/hola/node/languages","stargazers_url":"https://api.github.com/repos/hola/node/stargazers","contributors_url":"https://api.github.com/repos/hola/node/contributors","subscribers_url":"https://api.github.com/repos/hola/node/subscribers","subscription_url":"https://api.github.com/repos/hola/node/subscription","commits_url":"https://api.github.com/repos/hola/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/hola/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/hola/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/hola/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/hola/node/contents/{+path}","compare_url":"https://api.github.com/repos/hola/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hola/node/merges","archive_url":"https://api.github.com/repos/hola/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hola/node/downloads","issues_url":"https://api.github.com/repos/hola/node/issues{/number}","pulls_url":"https://api.github.com/repos/hola/node/pulls{/number}","milestones_url":"https://api.github.com/repos/hola/node/milestones{/number}","notifications_url":"https://api.github.com/repos/hola/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hola/node/labels{/name}","releases_url":"https://api.github.com/repos/hola/node/releases{/id}","deployments_url":"https://api.github.com/repos/hola/node/deployments","created_at":"2018-07-08T20:05:45Z","updated_at":"2018-10-09T14:55:51Z","pushed_at":"2018-10-09T14:54:29Z","git_url":"git://github.com/hola/node.git","ssh_url":"git@github.com:hola/node.git","clone_url":"https://github.com/hola/node.git","svn_url":"https://github.com/hola/node","homepage":"https://nodejs.org","size":417158,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"c65a523597ccdf2b3544244679dae581040cf52f","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-10-12T03:59:01Z","pushed_at":"2018-10-12T04:12:59Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":422778,"stargazers_count":54250,"watchers_count":54250,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11622,"mirror_url":null,"archived":false,"open_issues_count":910,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11622,"open_issues":910,"watchers":54250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/21711"},"html":{"href":"https://github.com/nodejs/node/pull/21711"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/21711"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/21711/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/21711/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/21711/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/27376a30e788d5dfc0fb92cf6e532eaed9b7175f"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":10,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":60,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"addaleax"}}