{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/165618919","pull_request_review_id":93589049,"id":165618919,"diff_hunk":"@@ -4,6 +4,24 @@\n # SPDX-License-Identifier: BSD-3-Clause\n #\n \n+ifeq (${ARM_ARCH_MAJOR},7)\n+# Qemu expects a BL32 boot stage.\n+NEED_BL32\t\t:=\tyes\n+# Qemu Cortex-A15 model does not implement the virtualization extention.\n+# For this reason, we cannot set ARM_CORTEX_A15=yes and must define all\n+# the ARMv7 build directives.\n+MARCH32_DIRECTIVE \t:= \t-mcpu=cortex-a15\n+$(eval $(call add_define,ARMV7_SUPPORTS_LARGE_PAGE_ADDRESSING))\n+$(eval $(call add_define,ARMV7_SUPPORTS_GENERIC_TIMER))\n+endif # ARMv7\n+\n+ifeq (${SPD},opteed)\n+add-lib-optee \t\t:= \tyes","path":"plat/qemu/platform.mk","position":null,"original_position":16,"commit_id":"f17dfdac7dd7a21ad70c836f9d4c8256ff6f4951","original_commit_id":"365b6a32f4c874158dcd03eda35194c82a7b00b4","user":{"login":"soby-mathew","id":6860836,"avatar_url":"https://avatars3.githubusercontent.com/u/6860836?v=4","gravatar_id":"","url":"https://api.github.com/users/soby-mathew","html_url":"https://github.com/soby-mathew","followers_url":"https://api.github.com/users/soby-mathew/followers","following_url":"https://api.github.com/users/soby-mathew/following{/other_user}","gists_url":"https://api.github.com/users/soby-mathew/gists{/gist_id}","starred_url":"https://api.github.com/users/soby-mathew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soby-mathew/subscriptions","organizations_url":"https://api.github.com/users/soby-mathew/orgs","repos_url":"https://api.github.com/users/soby-mathew/repos","events_url":"https://api.github.com/users/soby-mathew/events{/privacy}","received_events_url":"https://api.github.com/users/soby-mathew/received_events","type":"User","site_admin":false},"body":"OK.","created_at":"2018-02-02T11:12:12Z","updated_at":"2018-02-02T11:12:12Z","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1173#discussion_r165618919","pull_request_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1173","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/165618919"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1173#discussion_r165618919"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1173"}},"in_reply_to_id":165412744},"pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1173","id":155269628,"html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1173","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1173.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1173.patch","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1173","number":1173,"state":"open","locked":false,"title":"support to boot OP-TEE on AArch32/Armv7+example with Cortex-A15/Qemu","user":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"body":"These changes follow armv7 support changes (https://github.com/ARM-software/arm-trusted-firmware/pull/1145). They propose some support for booting OP-TEE bl32 images. The Qemu/Cortex-A15 is provided as example. Board b2260 (Cortex-a9) is planned, will be proposed later. ","created_at":"2017-11-29T07:45:22Z","updated_at":"2018-02-02T11:12:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4692587769356e00c4ef7dba615109a804eabdc7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1173/commits","review_comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1173/comments","review_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1173/comments","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/f17dfdac7dd7a21ad70c836f9d4c8256ff6f4951","head":{"label":"etienne-lms:armv7-qemu","ref":"armv7-qemu","sha":"f17dfdac7dd7a21ad70c836f9d4c8256ff6f4951","user":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"repo":{"id":67510018,"name":"arm-trusted-firmware","full_name":"etienne-lms/arm-trusted-firmware","owner":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etienne-lms/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":true,"url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware","forks_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/etienne-lms/arm-trusted-firmware/deployments","created_at":"2016-09-06T13:20:37Z","updated_at":"2016-09-06T13:20:40Z","pushed_at":"2018-02-02T10:14:06Z","git_url":"git://github.com/etienne-lms/arm-trusted-firmware.git","ssh_url":"git@github.com:etienne-lms/arm-trusted-firmware.git","clone_url":"https://github.com/etienne-lms/arm-trusted-firmware.git","svn_url":"https://github.com/etienne-lms/arm-trusted-firmware","homepage":null,"size":12063,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:integration","ref":"integration","sha":"c14d3dcd47952a1dd812bcbd40d9586a62c940c2","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":13740589,"name":"arm-trusted-firmware","full_name":"ARM-software/arm-trusted-firmware","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/arm-trusted-firmware","description":"Arm Trusted Firmware","fork":false,"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/deployments","created_at":"2013-10-21T11:39:00Z","updated_at":"2018-02-01T03:30:00Z","pushed_at":"2018-02-02T10:14:08Z","git_url":"git://github.com/ARM-software/arm-trusted-firmware.git","ssh_url":"git@github.com:ARM-software/arm-trusted-firmware.git","clone_url":"https://github.com/ARM-software/arm-trusted-firmware.git","svn_url":"https://github.com/ARM-software/arm-trusted-firmware","homepage":"","size":12220,"stargazers_count":495,"watchers_count":495,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":415,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":415,"open_issues":11,"watchers":495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1173"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1173"},"issue":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1173"},"comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1173/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1173/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1173/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/f17dfdac7dd7a21ad70c836f9d4c8256ff6f4951"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"soby-mathew"}}