{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/10266","repository_url":"https://api.github.com/repos/mozilla/pdf.js","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/10266/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/10266/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/10266/events","html_url":"https://github.com/mozilla/pdf.js/pull/10266","id":381986545,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODA1MTM2","number":10266,"title":"Upgrade to Gulp 4","user":{"login":"timvandermeij","id":1993262,"node_id":"MDQ6VXNlcjE5OTMyNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1993262?v=4","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"labels":[{"id":164432,"node_id":"MDU6TGFiZWwxNjQ0MzI=","url":"https://api.github.com/repos/mozilla/pdf.js/labels/1-other","name":"1-other","color":"DDDDDD","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-18T18:31:54Z","updated_at":"2018-11-26T23:03:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/10266","html_url":"https://github.com/mozilla/pdf.js/pull/10266","diff_url":"https://github.com/mozilla/pdf.js/pull/10266.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/10266.patch"},"body":"This required the following changes in the Gulpfile:\r\n\r\n- Defining a series of tasks is no longer done with arrays, but with the `gulp.series` function.\r\n- Getting all tasks must now be done through the task registry.\r\n- Tasks that don't return anything must call `done` upon completion.\r\n\r\nMoreover, this upgrade allows us to use the latest Node.js on Travis CI again.\r\n\r\nFixes most parts of #10177."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/441834066","html_url":"https://github.com/mozilla/pdf.js/pull/10266#issuecomment-441834066","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/10266","id":441834066,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTgzNDA2Ng==","user":{"login":"timvandermeij","id":1993262,"node_id":"MDQ6VXNlcjE5OTMyNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1993262?v=4","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"created_at":"2018-11-26T23:03:22Z","updated_at":"2018-11-26T23:03:22Z","author_association":"CONTRIBUTOR","body":"Hm, it looks like `gulp-cli`is correct then, but it somehow still uses Gulp 3.9.1 instead of Gulp 4. Looking at https://github.com/pattern-lab/edition-node-gulp/wiki/Updating-to-Gulp-4, perhaps it's a difference between the globally installed Gulp and a locally installed Gulp (CLI)?"}}
{"actor":{"display_login":"timvandermeij"}}