{"action":"created","issue":{"url":"https://api.github.com/repos/KnpLabs/snappy/issues/313","repository_url":"https://api.github.com/repos/KnpLabs/snappy","labels_url":"https://api.github.com/repos/KnpLabs/snappy/issues/313/labels{/name}","comments_url":"https://api.github.com/repos/KnpLabs/snappy/issues/313/comments","events_url":"https://api.github.com/repos/KnpLabs/snappy/issues/313/events","html_url":"https://github.com/KnpLabs/snappy/pull/313","id":324148215,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4ODMyODMw","number":313,"title":"Remove register_shutdown_function call","user":{"login":"exptom","id":4302032,"node_id":"MDQ6VXNlcjQzMDIwMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/4302032?v=4","gravatar_id":"","url":"https://api.github.com/users/exptom","html_url":"https://github.com/exptom","followers_url":"https://api.github.com/users/exptom/followers","following_url":"https://api.github.com/users/exptom/following{/other_user}","gists_url":"https://api.github.com/users/exptom/gists{/gist_id}","starred_url":"https://api.github.com/users/exptom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exptom/subscriptions","organizations_url":"https://api.github.com/users/exptom/orgs","repos_url":"https://api.github.com/users/exptom/repos","events_url":"https://api.github.com/users/exptom/events{/privacy}","received_events_url":"https://api.github.com/users/exptom/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-17T19:06:49Z","updated_at":"2018-12-07T15:11:27Z","closed_at":"2018-12-07T15:11:27Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/KnpLabs/snappy/pulls/313","html_url":"https://github.com/KnpLabs/snappy/pull/313","diff_url":"https://github.com/KnpLabs/snappy/pull/313.diff","patch_url":"https://github.com/KnpLabs/snappy/pull/313.patch"},"body":"The temporary files are never being deleted.\r\nRemoving the register_shutdown_function() resolves the issue and allows the tmp files to get deleted.\r\n\r\nThe destructor should be sufficient as it will always get called when the object is destroyed."},"comment":{"url":"https://api.github.com/repos/KnpLabs/snappy/issues/comments/445261942","html_url":"https://github.com/KnpLabs/snappy/pull/313#issuecomment-445261942","issue_url":"https://api.github.com/repos/KnpLabs/snappy/issues/313","id":445261942,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTI2MTk0Mg==","user":{"login":"NiR-","id":557933,"node_id":"MDQ6VXNlcjU1NzkzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/557933?v=4","gravatar_id":"","url":"https://api.github.com/users/NiR-","html_url":"https://github.com/NiR-","followers_url":"https://api.github.com/users/NiR-/followers","following_url":"https://api.github.com/users/NiR-/following{/other_user}","gists_url":"https://api.github.com/users/NiR-/gists{/gist_id}","starred_url":"https://api.github.com/users/NiR-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiR-/subscriptions","organizations_url":"https://api.github.com/users/NiR-/orgs","repos_url":"https://api.github.com/users/NiR-/repos","events_url":"https://api.github.com/users/NiR-/events{/privacy}","received_events_url":"https://api.github.com/users/NiR-/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T15:11:27Z","updated_at":"2018-12-07T15:11:27Z","author_association":"MEMBER","body":"@exptom We definitely need to keep `register_shutdown_function`. As you can on [this 3v4l.org example](https://3v4l.org/N0ARC), when an error is thrown, destructors aren't called."}}
{"actor":{"display_login":"NiR-"}}