{"action":"created","comment":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/comments/168927522","pull_request_review_id":97379913,"id":168927522,"diff_hunk":"@@ -96,11 +96,9 @@ function ethereumTransactionsCtrl ($scope, $uibModal, $state, Wallet, Ethereum,\n       case $scope.filterTypes[1]:\n         if (Ethereum.legacyAccount) return tx.getTxType([$scope.account, Ethereum.legacyAccount]) === 'sent';\n         else return tx.getTxType([$scope.account]) === 'sent';\n-        break;\n       case $scope.filterTypes[2]:\n         if (Ethereum.legacyAccount) return tx.getTxType([$scope.account, Ethereum.legacyAccount]) === 'received';\n         else return tx.getTxType([$scope.account]) === 'received';\n-        break;\n     }","path":"assets/js/controllers/transactions/transactionsEthereum.controller.js","position":9,"original_position":9,"commit_id":"0ffa7537774abc5fabcdd168cd4360ac52aaf65c","original_commit_id":"54bd90b1d5069087ec8662aa7cafc494cd428823","user":{"login":"schnogz","id":6364918,"avatar_url":"https://avatars0.githubusercontent.com/u/6364918?v=4","gravatar_id":"","url":"https://api.github.com/users/schnogz","html_url":"https://github.com/schnogz","followers_url":"https://api.github.com/users/schnogz/followers","following_url":"https://api.github.com/users/schnogz/following{/other_user}","gists_url":"https://api.github.com/users/schnogz/gists{/gist_id}","starred_url":"https://api.github.com/users/schnogz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnogz/subscriptions","organizations_url":"https://api.github.com/users/schnogz/orgs","repos_url":"https://api.github.com/users/schnogz/repos","events_url":"https://api.github.com/users/schnogz/events{/privacy}","received_events_url":"https://api.github.com/users/schnogz/received_events","type":"User","site_admin":false},"body":"That's correct.  It violates the `no-unreachable` rule.  `break` and `return` are synonymous inside a simple switch statement like this.  However, this may not always be the case if the switch statement is being ran inside some sort of an outer loop function.","created_at":"2018-02-17T17:26:17Z","updated_at":"2018-02-17T17:26:17Z","html_url":"https://github.com/blockchain/My-Wallet-V3-Frontend/pull/1460#discussion_r168927522","pull_request_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/1460","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/comments/168927522"},"html":{"href":"https://github.com/blockchain/My-Wallet-V3-Frontend/pull/1460#discussion_r168927522"},"pull_request":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/1460"}},"in_reply_to_id":168927128},"pull_request":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/1460","id":169723261,"html_url":"https://github.com/blockchain/My-Wallet-V3-Frontend/pull/1460","diff_url":"https://github.com/blockchain/My-Wallet-V3-Frontend/pull/1460.diff","patch_url":"https://github.com/blockchain/My-Wallet-V3-Frontend/pull/1460.patch","issue_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/issues/1460","number":1460,"state":"open","locked":false,"title":"ESLint reconfiguration","user":{"login":"schnogz","id":6364918,"avatar_url":"https://avatars0.githubusercontent.com/u/6364918?v=4","gravatar_id":"","url":"https://api.github.com/users/schnogz","html_url":"https://github.com/schnogz","followers_url":"https://api.github.com/users/schnogz/followers","following_url":"https://api.github.com/users/schnogz/following{/other_user}","gists_url":"https://api.github.com/users/schnogz/gists{/gist_id}","starred_url":"https://api.github.com/users/schnogz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnogz/subscriptions","organizations_url":"https://api.github.com/users/schnogz/orgs","repos_url":"https://api.github.com/users/schnogz/repos","events_url":"https://api.github.com/users/schnogz/events{/privacy}","received_events_url":"https://api.github.com/users/schnogz/received_events","type":"User","site_admin":false},"body":"I noticed that ESLint was not actually running during our TravisCI builds.  This upgrades ESLint to v4 and enables rules that restrict to the [JavaScript Standard Style](https://standardjs.com/).\r\n\r\nOther changes:\r\n- Fixed all code style violations\r\n- Added a NPM script to run the linter. i.e. `yarn lint` or `npm run lint`\r\n- Simplified `travis.yml` build file and removed the no longer needed `.eslintignore` file","created_at":"2018-02-16T20:53:56Z","updated_at":"2018-02-17T17:26:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"763a396fba35f36434bda55017e2d85e083af787","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/1460/commits","review_comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/1460/comments","review_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/issues/1460/comments","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/statuses/0ffa7537774abc5fabcdd168cd4360ac52aaf65c","head":{"label":"blockchain:eslint-reconfiguration","ref":"eslint-reconfiguration","sha":"0ffa7537774abc5fabcdd168cd4360ac52aaf65c","user":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":24322390,"name":"My-Wallet-V3-Frontend","full_name":"blockchain/My-Wallet-V3-Frontend","owner":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/My-Wallet-V3-Frontend","description":"Blockchain Wallet Frontend","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/deployments","created_at":"2014-09-22T09:28:04Z","updated_at":"2018-02-14T00:09:02Z","pushed_at":"2018-02-17T17:15:34Z","git_url":"git://github.com/blockchain/My-Wallet-V3-Frontend.git","ssh_url":"git@github.com:blockchain/My-Wallet-V3-Frontend.git","clone_url":"https://github.com/blockchain/My-Wallet-V3-Frontend.git","svn_url":"https://github.com/blockchain/My-Wallet-V3-Frontend","homepage":"https://blockchain.info/wallet","size":143339,"stargazers_count":132,"watchers_count":132,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":142,"open_issues":12,"watchers":132,"default_branch":"master"}},"base":{"label":"blockchain:v1.33-release","ref":"v1.33-release","sha":"cb377c39a85bc75488d8065013b597858fe33b40","user":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":24322390,"name":"My-Wallet-V3-Frontend","full_name":"blockchain/My-Wallet-V3-Frontend","owner":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/My-Wallet-V3-Frontend","description":"Blockchain Wallet Frontend","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/deployments","created_at":"2014-09-22T09:28:04Z","updated_at":"2018-02-14T00:09:02Z","pushed_at":"2018-02-17T17:15:34Z","git_url":"git://github.com/blockchain/My-Wallet-V3-Frontend.git","ssh_url":"git@github.com:blockchain/My-Wallet-V3-Frontend.git","clone_url":"https://github.com/blockchain/My-Wallet-V3-Frontend.git","svn_url":"https://github.com/blockchain/My-Wallet-V3-Frontend","homepage":"https://blockchain.info/wallet","size":143339,"stargazers_count":132,"watchers_count":132,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":142,"open_issues":12,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/1460"},"html":{"href":"https://github.com/blockchain/My-Wallet-V3-Frontend/pull/1460"},"issue":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/issues/1460"},"comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/issues/1460/comments"},"review_comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/1460/comments"},"review_comment":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/pulls/1460/commits"},"statuses":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3-Frontend/statuses/0ffa7537774abc5fabcdd168cd4360ac52aaf65c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"schnogz"}}