{"action":"opened","number":7907,"pull_request":{"url":"https://api.github.com/repos/vector-im/riot-web/pulls/7907","id":239578905,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTc4OTA1","html_url":"https://github.com/vector-im/riot-web/pull/7907","diff_url":"https://github.com/vector-im/riot-web/pull/7907.diff","patch_url":"https://github.com/vector-im/riot-web/pull/7907.patch","issue_url":"https://api.github.com/repos/vector-im/riot-web/issues/7907","number":7907,"state":"open","locked":false,"title":"Run the Desktop app in a sandbox","user":{"login":"dbkr","id":986903,"node_id":"MDQ6VXNlcjk4NjkwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/986903?v=4","gravatar_id":"","url":"https://api.github.com/users/dbkr","html_url":"https://github.com/dbkr","followers_url":"https://api.github.com/users/dbkr/followers","following_url":"https://api.github.com/users/dbkr/following{/other_user}","gists_url":"https://api.github.com/users/dbkr/gists{/gist_id}","starred_url":"https://api.github.com/users/dbkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbkr/subscriptions","organizations_url":"https://api.github.com/users/dbkr/orgs","repos_url":"https://api.github.com/users/dbkr/repos","events_url":"https://api.github.com/users/dbkr/events{/privacy}","received_events_url":"https://api.github.com/users/dbkr/received_events","type":"User","site_admin":false},"body":" * Turn off node integration in the electron renderer process\r\n * Enable the chromium sandbox to put the renderer into its own process\r\n * Expose just the ipc module with a preload script\r\n * Introduce a little IPC call wrapper so we can call into the\r\n   renderer process and await on the result.\r\n * Use this in a bunch of places we previously used direct calls\r\n   to electron modules.\r\n * Convert other uses of node, eg. use of process to derive the\r\n   platform (just look at the user agent)\r\n * Strip out the desktopCapturer integration which doesn't appear\r\n   to have ever worked (probably best to just wait until\r\n   getDisplayMedia() is available in chrome at this point:\r\n   https://github.com/vector-im/riot-web/issues/4880).","created_at":"2018-12-18T17:54:51Z","updated_at":"2018-12-18T17:54:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vector-im/riot-web/pulls/7907/commits","review_comments_url":"https://api.github.com/repos/vector-im/riot-web/pulls/7907/comments","review_comment_url":"https://api.github.com/repos/vector-im/riot-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vector-im/riot-web/issues/7907/comments","statuses_url":"https://api.github.com/repos/vector-im/riot-web/statuses/19f1489c9284171e5ea3e69121864697a4e97e8a","head":{"label":"vector-im:dbkr/electron_sandbox","ref":"dbkr/electron_sandbox","sha":"19f1489c9284171e5ea3e69121864697a4e97e8a","user":{"login":"vector-im","id":13446337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDQ2MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"repo":{"id":39487546,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ4NzU0Ng==","name":"riot-web","full_name":"vector-im/riot-web","private":false,"owner":{"login":"vector-im","id":13446337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDQ2MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vector-im/riot-web","description":"A glossy Matrix collaboration client for the web.","fork":false,"url":"https://api.github.com/repos/vector-im/riot-web","forks_url":"https://api.github.com/repos/vector-im/riot-web/forks","keys_url":"https://api.github.com/repos/vector-im/riot-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vector-im/riot-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vector-im/riot-web/teams","hooks_url":"https://api.github.com/repos/vector-im/riot-web/hooks","issue_events_url":"https://api.github.com/repos/vector-im/riot-web/issues/events{/number}","events_url":"https://api.github.com/repos/vector-im/riot-web/events","assignees_url":"https://api.github.com/repos/vector-im/riot-web/assignees{/user}","branches_url":"https://api.github.com/repos/vector-im/riot-web/branches{/branch}","tags_url":"https://api.github.com/repos/vector-im/riot-web/tags","blobs_url":"https://api.github.com/repos/vector-im/riot-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vector-im/riot-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vector-im/riot-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/vector-im/riot-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vector-im/riot-web/statuses/{sha}","languages_url":"https://api.github.com/repos/vector-im/riot-web/languages","stargazers_url":"https://api.github.com/repos/vector-im/riot-web/stargazers","contributors_url":"https://api.github.com/repos/vector-im/riot-web/contributors","subscribers_url":"https://api.github.com/repos/vector-im/riot-web/subscribers","subscription_url":"https://api.github.com/repos/vector-im/riot-web/subscription","commits_url":"https://api.github.com/repos/vector-im/riot-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/vector-im/riot-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/vector-im/riot-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/vector-im/riot-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/vector-im/riot-web/contents/{+path}","compare_url":"https://api.github.com/repos/vector-im/riot-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vector-im/riot-web/merges","archive_url":"https://api.github.com/repos/vector-im/riot-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vector-im/riot-web/downloads","issues_url":"https://api.github.com/repos/vector-im/riot-web/issues{/number}","pulls_url":"https://api.github.com/repos/vector-im/riot-web/pulls{/number}","milestones_url":"https://api.github.com/repos/vector-im/riot-web/milestones{/number}","notifications_url":"https://api.github.com/repos/vector-im/riot-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vector-im/riot-web/labels{/name}","releases_url":"https://api.github.com/repos/vector-im/riot-web/releases{/id}","deployments_url":"https://api.github.com/repos/vector-im/riot-web/deployments","created_at":"2015-07-22T05:32:15Z","updated_at":"2018-12-18T14:02:15Z","pushed_at":"2018-12-18T17:54:13Z","git_url":"git://github.com/vector-im/riot-web.git","ssh_url":"git@github.com:vector-im/riot-web.git","clone_url":"https://github.com/vector-im/riot-web.git","svn_url":"https://github.com/vector-im/riot-web","homepage":"http://riot.im","size":12691,"stargazers_count":2275,"watchers_count":2275,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":430,"mirror_url":null,"archived":false,"open_issues_count":3006,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":430,"open_issues":3006,"watchers":2275,"default_branch":"master"}},"base":{"label":"vector-im:develop","ref":"develop","sha":"17983c47d8e09ed17b7a0065b29061b281c6d3fc","user":{"login":"vector-im","id":13446337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDQ2MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"repo":{"id":39487546,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ4NzU0Ng==","name":"riot-web","full_name":"vector-im/riot-web","private":false,"owner":{"login":"vector-im","id":13446337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDQ2MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vector-im/riot-web","description":"A glossy Matrix collaboration client for the web.","fork":false,"url":"https://api.github.com/repos/vector-im/riot-web","forks_url":"https://api.github.com/repos/vector-im/riot-web/forks","keys_url":"https://api.github.com/repos/vector-im/riot-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vector-im/riot-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vector-im/riot-web/teams","hooks_url":"https://api.github.com/repos/vector-im/riot-web/hooks","issue_events_url":"https://api.github.com/repos/vector-im/riot-web/issues/events{/number}","events_url":"https://api.github.com/repos/vector-im/riot-web/events","assignees_url":"https://api.github.com/repos/vector-im/riot-web/assignees{/user}","branches_url":"https://api.github.com/repos/vector-im/riot-web/branches{/branch}","tags_url":"https://api.github.com/repos/vector-im/riot-web/tags","blobs_url":"https://api.github.com/repos/vector-im/riot-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vector-im/riot-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vector-im/riot-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/vector-im/riot-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vector-im/riot-web/statuses/{sha}","languages_url":"https://api.github.com/repos/vector-im/riot-web/languages","stargazers_url":"https://api.github.com/repos/vector-im/riot-web/stargazers","contributors_url":"https://api.github.com/repos/vector-im/riot-web/contributors","subscribers_url":"https://api.github.com/repos/vector-im/riot-web/subscribers","subscription_url":"https://api.github.com/repos/vector-im/riot-web/subscription","commits_url":"https://api.github.com/repos/vector-im/riot-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/vector-im/riot-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/vector-im/riot-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/vector-im/riot-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/vector-im/riot-web/contents/{+path}","compare_url":"https://api.github.com/repos/vector-im/riot-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vector-im/riot-web/merges","archive_url":"https://api.github.com/repos/vector-im/riot-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vector-im/riot-web/downloads","issues_url":"https://api.github.com/repos/vector-im/riot-web/issues{/number}","pulls_url":"https://api.github.com/repos/vector-im/riot-web/pulls{/number}","milestones_url":"https://api.github.com/repos/vector-im/riot-web/milestones{/number}","notifications_url":"https://api.github.com/repos/vector-im/riot-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vector-im/riot-web/labels{/name}","releases_url":"https://api.github.com/repos/vector-im/riot-web/releases{/id}","deployments_url":"https://api.github.com/repos/vector-im/riot-web/deployments","created_at":"2015-07-22T05:32:15Z","updated_at":"2018-12-18T14:02:15Z","pushed_at":"2018-12-18T17:54:13Z","git_url":"git://github.com/vector-im/riot-web.git","ssh_url":"git@github.com:vector-im/riot-web.git","clone_url":"https://github.com/vector-im/riot-web.git","svn_url":"https://github.com/vector-im/riot-web","homepage":"http://riot.im","size":12691,"stargazers_count":2275,"watchers_count":2275,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":430,"mirror_url":null,"archived":false,"open_issues_count":3006,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":430,"open_issues":3006,"watchers":2275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vector-im/riot-web/pulls/7907"},"html":{"href":"https://github.com/vector-im/riot-web/pull/7907"},"issue":{"href":"https://api.github.com/repos/vector-im/riot-web/issues/7907"},"comments":{"href":"https://api.github.com/repos/vector-im/riot-web/issues/7907/comments"},"review_comments":{"href":"https://api.github.com/repos/vector-im/riot-web/pulls/7907/comments"},"review_comment":{"href":"https://api.github.com/repos/vector-im/riot-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vector-im/riot-web/pulls/7907/commits"},"statuses":{"href":"https://api.github.com/repos/vector-im/riot-web/statuses/19f1489c9284171e5ea3e69121864697a4e97e8a"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":200,"deletions":146,"changed_files":7}}
{"actor":{"display_login":"dbkr"}}