{"action":"created","issue":{"url":"https://api.github.com/repos/rafaeldigenova/simple-bot-aspnet/issues/1","repository_url":"https://api.github.com/repos/rafaeldigenova/simple-bot-aspnet","labels_url":"https://api.github.com/repos/rafaeldigenova/simple-bot-aspnet/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/rafaeldigenova/simple-bot-aspnet/issues/1/comments","events_url":"https://api.github.com/repos/rafaeldigenova/simple-bot-aspnet/issues/1/events","html_url":"https://github.com/rafaeldigenova/simple-bot-aspnet/pull/1","id":304017041,"number":1,"title":"Add Criterios de correcao","user":{"login":"fcatae","id":7252609,"avatar_url":"https://avatars0.githubusercontent.com/u/7252609?v=4","gravatar_id":"","url":"https://api.github.com/users/fcatae","html_url":"https://github.com/fcatae","followers_url":"https://api.github.com/users/fcatae/followers","following_url":"https://api.github.com/users/fcatae/following{/other_user}","gists_url":"https://api.github.com/users/fcatae/gists{/gist_id}","starred_url":"https://api.github.com/users/fcatae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcatae/subscriptions","organizations_url":"https://api.github.com/users/fcatae/orgs","repos_url":"https://api.github.com/users/fcatae/repos","events_url":"https://api.github.com/users/fcatae/events{/privacy}","received_events_url":"https://api.github.com/users/fcatae/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-09T23:55:56Z","updated_at":"2018-03-11T17:49:30Z","closed_at":"2018-03-10T11:42:30Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rafaeldigenova/simple-bot-aspnet/pulls/1","html_url":"https://github.com/rafaeldigenova/simple-bot-aspnet/pull/1","diff_url":"https://github.com/rafaeldigenova/simple-bot-aspnet/pull/1.diff","patch_url":"https://github.com/rafaeldigenova/simple-bot-aspnet/pull/1.patch"},"body":"Problemas:\r\n- Interface \"IRepoBase<T>\" está vazia!!! O correto é usar uma interface comum para o SQL e MongoDB com métodos em comuns. \r\n- Evitar o uso de classes abstratas. No código, a única classe abstrata válida é \"Persistencia/RepoBase.cs\". As implementações de \"Persistencia.SQL.RepoBase\" e \"Persistencia.SQL.Memoria\" não precisam de classes abstratas.\r\n- Simplificar a assinatura da IRepoBase. Os métodos GetLazy e ReplaceOne possuem assinatura muito complexa. Prefira usar uma linguagem de domínio (ex: SalvarHistorico, SalvarPerfil, ConsultarPerfil).\r\n- Passar a connection string através do construtor ao invés do \"Configuracao.ConnectionStringSql\" \r\n\r\nTrabalho contém:\r\n- Acesso ao mongoDB (ok)\r\n- Acesso ao SQL (ok)\r\n- Uso INCORRETO do Pattern Repositório (-1.0 ponto)\r\n- (Extra) A construção do Persistencia.RepoBase ficou muito simples para estender os demais objetos.\r\n"},"comment":{"url":"https://api.github.com/repos/rafaeldigenova/simple-bot-aspnet/issues/comments/372134382","html_url":"https://github.com/rafaeldigenova/simple-bot-aspnet/pull/1#issuecomment-372134382","issue_url":"https://api.github.com/repos/rafaeldigenova/simple-bot-aspnet/issues/1","id":372134382,"user":{"login":"fcatae","id":7252609,"avatar_url":"https://avatars0.githubusercontent.com/u/7252609?v=4","gravatar_id":"","url":"https://api.github.com/users/fcatae","html_url":"https://github.com/fcatae","followers_url":"https://api.github.com/users/fcatae/followers","following_url":"https://api.github.com/users/fcatae/following{/other_user}","gists_url":"https://api.github.com/users/fcatae/gists{/gist_id}","starred_url":"https://api.github.com/users/fcatae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcatae/subscriptions","organizations_url":"https://api.github.com/users/fcatae/orgs","repos_url":"https://api.github.com/users/fcatae/repos","events_url":"https://api.github.com/users/fcatae/events{/privacy}","received_events_url":"https://api.github.com/users/fcatae/received_events","type":"User","site_admin":false},"created_at":"2018-03-11T17:49:30Z","updated_at":"2018-03-11T17:49:30Z","author_association":"NONE","body":"A correção está adequada.\r\n\r\nÚltimos comentários:\r\n- Assim como voce não deriva UserProfileRepoSQL do Dapper, evite derivar UserProfileRepo de RepoBase<UserProfile>. Ao invés disso, use o RepoBase como propriedade da classe ou então como variável local. \r\n- Métodos que retornam Task: use o sufixo \"Async\" nos métodos para facilitar a leitura.\r\n\r\nBom trabalho!"}}
{"actor":{"display_login":"fcatae"}}