{"action":"closed","number":2775,"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2775","id":240481268,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNDgxMjY4","html_url":"https://github.com/knative/serving/pull/2775","diff_url":"https://github.com/knative/serving/pull/2775.diff","patch_url":"https://github.com/knative/serving/pull/2775.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/2775","number":2775,"state":"closed","locked":false,"title":"Fix unsafe access in multiscaler.","user":{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},"body":"<!--\r\nRequest Prow to automatically lint any go code in this PR:\r\n\r\n/lint\r\n-->\r\n\r\nFixes #2774\r\n\r\nAccess to the watcher function needs to be guarded in a `nil` check, since it's not guaranteed to be set. I also added goroutine safety for good measure.\r\n\r\n**Release Note**\r\n\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-12-21T13:59:33Z","updated_at":"2018-12-21T14:35:36Z","closed_at":"2018-12-21T14:35:36Z","merged_at":"2018-12-21T14:35:36Z","merge_commit_sha":"16682823310024ef5bbb73624abb53ae5a65cb7f","assignee":{"login":"vvraskin","id":7526585,"node_id":"MDQ6VXNlcjc1MjY1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/7526585?v=4","gravatar_id":"","url":"https://api.github.com/users/vvraskin","html_url":"https://github.com/vvraskin","followers_url":"https://api.github.com/users/vvraskin/followers","following_url":"https://api.github.com/users/vvraskin/following{/other_user}","gists_url":"https://api.github.com/users/vvraskin/gists{/gist_id}","starred_url":"https://api.github.com/users/vvraskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvraskin/subscriptions","organizations_url":"https://api.github.com/users/vvraskin/orgs","repos_url":"https://api.github.com/users/vvraskin/repos","events_url":"https://api.github.com/users/vvraskin/events{/privacy}","received_events_url":"https://api.github.com/users/vvraskin/received_events","type":"User","site_admin":false},"assignees":[{"login":"vvraskin","id":7526585,"node_id":"MDQ6VXNlcjc1MjY1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/7526585?v=4","gravatar_id":"","url":"https://api.github.com/users/vvraskin","html_url":"https://github.com/vvraskin","followers_url":"https://api.github.com/users/vvraskin/followers","following_url":"https://api.github.com/users/vvraskin/following{/other_user}","gists_url":"https://api.github.com/users/vvraskin/gists{/gist_id}","starred_url":"https://api.github.com/users/vvraskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvraskin/subscriptions","organizations_url":"https://api.github.com/users/vvraskin/orgs","repos_url":"https://api.github.com/users/vvraskin/repos","events_url":"https://api.github.com/users/vvraskin/events{/privacy}","received_events_url":"https://api.github.com/users/vvraskin/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"josephburnett","id":1103629,"node_id":"MDQ6VXNlcjExMDM2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1103629?v=4","gravatar_id":"","url":"https://api.github.com/users/josephburnett","html_url":"https://github.com/josephburnett","followers_url":"https://api.github.com/users/josephburnett/followers","following_url":"https://api.github.com/users/josephburnett/following{/other_user}","gists_url":"https://api.github.com/users/josephburnett/gists{/gist_id}","starred_url":"https://api.github.com/users/josephburnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephburnett/subscriptions","organizations_url":"https://api.github.com/users/josephburnett/orgs","repos_url":"https://api.github.com/users/josephburnett/repos","events_url":"https://api.github.com/users/josephburnett/events{/privacy}","received_events_url":"https://api.github.com/users/josephburnett/received_events","type":"User","site_admin":false},{"login":"mdemirhan","id":4033879,"node_id":"MDQ6VXNlcjQwMzM4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/4033879?v=4","gravatar_id":"","url":"https://api.github.com/users/mdemirhan","html_url":"https://github.com/mdemirhan","followers_url":"https://api.github.com/users/mdemirhan/followers","following_url":"https://api.github.com/users/mdemirhan/following{/other_user}","gists_url":"https://api.github.com/users/mdemirhan/gists{/gist_id}","starred_url":"https://api.github.com/users/mdemirhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdemirhan/subscriptions","organizations_url":"https://api.github.com/users/mdemirhan/orgs","repos_url":"https://api.github.com/users/mdemirhan/repos","events_url":"https://api.github.com/users/mdemirhan/events{/privacy}","received_events_url":"https://api.github.com/users/mdemirhan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":873831452,"node_id":"MDU6TGFiZWw4NzM4MzE0NTI=","url":"https://api.github.com/repos/knative/serving/labels/approved","name":"approved","color":"ededed","default":false},{"id":864751607,"node_id":"MDU6TGFiZWw4NjQ3NTE2MDc=","url":"https://api.github.com/repos/knative/serving/labels/lgtm","name":"lgtm","color":"ededed","default":false},{"id":860818304,"node_id":"MDU6TGFiZWw4NjA4MTgzMDQ=","url":"https://api.github.com/repos/knative/serving/labels/size/S","name":"size/S","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/2775/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/2775/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/2775/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/fa47d42b1c33739f2eb5b50de63b8fea9fcc6889","head":{"label":"markusthoemmes:fix-multiscaler","ref":"fix-multiscaler","sha":"fa47d42b1c33739f2eb5b50de63b8fea9fcc6889","user":{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},"repo":{"id":143875522,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4NzU1MjI=","name":"knative-serving","full_name":"markusthoemmes/knative-serving","private":false,"owner":{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/markusthoemmes/knative-serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/markusthoemmes/knative-serving","forks_url":"https://api.github.com/repos/markusthoemmes/knative-serving/forks","keys_url":"https://api.github.com/repos/markusthoemmes/knative-serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markusthoemmes/knative-serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markusthoemmes/knative-serving/teams","hooks_url":"https://api.github.com/repos/markusthoemmes/knative-serving/hooks","issue_events_url":"https://api.github.com/repos/markusthoemmes/knative-serving/issues/events{/number}","events_url":"https://api.github.com/repos/markusthoemmes/knative-serving/events","assignees_url":"https://api.github.com/repos/markusthoemmes/knative-serving/assignees{/user}","branches_url":"https://api.github.com/repos/markusthoemmes/knative-serving/branches{/branch}","tags_url":"https://api.github.com/repos/markusthoemmes/knative-serving/tags","blobs_url":"https://api.github.com/repos/markusthoemmes/knative-serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markusthoemmes/knative-serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markusthoemmes/knative-serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/markusthoemmes/knative-serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markusthoemmes/knative-serving/statuses/{sha}","languages_url":"https://api.github.com/repos/markusthoemmes/knative-serving/languages","stargazers_url":"https://api.github.com/repos/markusthoemmes/knative-serving/stargazers","contributors_url":"https://api.github.com/repos/markusthoemmes/knative-serving/contributors","subscribers_url":"https://api.github.com/repos/markusthoemmes/knative-serving/subscribers","subscription_url":"https://api.github.com/repos/markusthoemmes/knative-serving/subscription","commits_url":"https://api.github.com/repos/markusthoemmes/knative-serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/markusthoemmes/knative-serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/markusthoemmes/knative-serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/markusthoemmes/knative-serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/markusthoemmes/knative-serving/contents/{+path}","compare_url":"https://api.github.com/repos/markusthoemmes/knative-serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markusthoemmes/knative-serving/merges","archive_url":"https://api.github.com/repos/markusthoemmes/knative-serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markusthoemmes/knative-serving/downloads","issues_url":"https://api.github.com/repos/markusthoemmes/knative-serving/issues{/number}","pulls_url":"https://api.github.com/repos/markusthoemmes/knative-serving/pulls{/number}","milestones_url":"https://api.github.com/repos/markusthoemmes/knative-serving/milestones{/number}","notifications_url":"https://api.github.com/repos/markusthoemmes/knative-serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markusthoemmes/knative-serving/labels{/name}","releases_url":"https://api.github.com/repos/markusthoemmes/knative-serving/releases{/id}","deployments_url":"https://api.github.com/repos/markusthoemmes/knative-serving/deployments","created_at":"2018-08-07T13:15:18Z","updated_at":"2018-12-17T08:17:36Z","pushed_at":"2018-12-21T14:01:55Z","git_url":"git://github.com/markusthoemmes/knative-serving.git","ssh_url":"git@github.com:markusthoemmes/knative-serving.git","clone_url":"https://github.com/markusthoemmes/knative-serving.git","svn_url":"https://github.com/markusthoemmes/knative-serving","homepage":"","size":30209,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"2169f9365919345177fa7237abf5f93ed76cf41e","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2018-12-21T14:23:32Z","pushed_at":"2018-12-21T14:35:36Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"","size":30039,"stargazers_count":1056,"watchers_count":1056,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":298,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":204,"open_issues":298,"watchers":1056,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/2775"},"html":{"href":"https://github.com/knative/serving/pull/2775"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/2775"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/2775/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/2775/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/2775/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/fa47d42b1c33739f2eb5b50de63b8fea9fcc6889"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":18,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"knative-prow-robot"}}