{"action":"created","issue":{"url":"https://api.github.com/repos/internetee/rest-whois/issues/85","repository_url":"https://api.github.com/repos/internetee/rest-whois","labels_url":"https://api.github.com/repos/internetee/rest-whois/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/internetee/rest-whois/issues/85/comments","events_url":"https://api.github.com/repos/internetee/rest-whois/issues/85/events","html_url":"https://github.com/internetee/rest-whois/issues/85","id":329341260,"node_id":"MDU6SXNzdWUzMjkzNDEyNjA=","number":85,"title":"Upgrade Rails to 5.0","user":{"login":"maciej-szlosarczyk","id":2331765,"node_id":"MDQ6VXNlcjIzMzE3NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2331765?v=4","gravatar_id":"","url":"https://api.github.com/users/maciej-szlosarczyk","html_url":"https://github.com/maciej-szlosarczyk","followers_url":"https://api.github.com/users/maciej-szlosarczyk/followers","following_url":"https://api.github.com/users/maciej-szlosarczyk/following{/other_user}","gists_url":"https://api.github.com/users/maciej-szlosarczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/maciej-szlosarczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciej-szlosarczyk/subscriptions","organizations_url":"https://api.github.com/users/maciej-szlosarczyk/orgs","repos_url":"https://api.github.com/users/maciej-szlosarczyk/repos","events_url":"https://api.github.com/users/maciej-szlosarczyk/events{/privacy}","received_events_url":"https://api.github.com/users/maciej-szlosarczyk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"vohmar","id":7734747,"node_id":"MDQ6VXNlcjc3MzQ3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7734747?v=4","gravatar_id":"","url":"https://api.github.com/users/vohmar","html_url":"https://github.com/vohmar","followers_url":"https://api.github.com/users/vohmar/followers","following_url":"https://api.github.com/users/vohmar/following{/other_user}","gists_url":"https://api.github.com/users/vohmar/gists{/gist_id}","starred_url":"https://api.github.com/users/vohmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vohmar/subscriptions","organizations_url":"https://api.github.com/users/vohmar/orgs","repos_url":"https://api.github.com/users/vohmar/repos","events_url":"https://api.github.com/users/vohmar/events{/privacy}","received_events_url":"https://api.github.com/users/vohmar/received_events","type":"User","site_admin":false},"assignees":[{"login":"vohmar","id":7734747,"node_id":"MDQ6VXNlcjc3MzQ3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7734747?v=4","gravatar_id":"","url":"https://api.github.com/users/vohmar","html_url":"https://github.com/vohmar","followers_url":"https://api.github.com/users/vohmar/followers","following_url":"https://api.github.com/users/vohmar/following{/other_user}","gists_url":"https://api.github.com/users/vohmar/gists{/gist_id}","starred_url":"https://api.github.com/users/vohmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vohmar/subscriptions","organizations_url":"https://api.github.com/users/vohmar/orgs","repos_url":"https://api.github.com/users/vohmar/repos","events_url":"https://api.github.com/users/vohmar/events{/privacy}","received_events_url":"https://api.github.com/users/vohmar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-06-05T07:56:09Z","updated_at":"2018-06-27T07:16:21Z","closed_at":"2018-06-27T07:16:21Z","author_association":"CONTRIBUTOR","body":"## Task list is still incomplete, but that's enough to get the test suite to run with limited success.\r\nAs a small project, this one can be our pilot for upgrade to Rails 5.x. Provisional upgrade task are:\r\n\r\n- [x] Remove `config.active_record.raise_in_transactional_callbacks = true`\r\n- [x] Rename `use_transactional_fixtures = true` to `use_transactional_tests = true`\r\n- [x] Fix occurences of ActionView::Template::Error: unable to convert unpermitted parameters to hash\r\n- [x] Fix keyword argument error in get method (`get '/v1/privatedomain.test', format: :json`)\r\n- [x] Create `ApplicationRecord` superclass\r\n- [x] Convert inheritance from `ActiveRecord::Base` to `ApplicationRecord`\r\n- [ ] Investigate secrets/encrypted secrets changes, as those are introduced in Rails 5.0, and then significantly changed in Rais 5.1"},"comment":{"url":"https://api.github.com/repos/internetee/rest-whois/issues/comments/400568071","html_url":"https://github.com/internetee/rest-whois/issues/85#issuecomment-400568071","issue_url":"https://api.github.com/repos/internetee/rest-whois/issues/85","id":400568071,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDU2ODA3MQ==","user":{"login":"vohmar","id":7734747,"node_id":"MDQ6VXNlcjc3MzQ3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7734747?v=4","gravatar_id":"","url":"https://api.github.com/users/vohmar","html_url":"https://github.com/vohmar","followers_url":"https://api.github.com/users/vohmar/followers","following_url":"https://api.github.com/users/vohmar/following{/other_user}","gists_url":"https://api.github.com/users/vohmar/gists{/gist_id}","starred_url":"https://api.github.com/users/vohmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vohmar/subscriptions","organizations_url":"https://api.github.com/users/vohmar/orgs","repos_url":"https://api.github.com/users/vohmar/repos","events_url":"https://api.github.com/users/vohmar/events{/privacy}","received_events_url":"https://api.github.com/users/vohmar/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T07:16:21Z","updated_at":"2018-06-27T07:16:21Z","author_association":"CONTRIBUTOR","body":"secret/encrypted secrets is for rails 5.2. As 5.0 is now in production I will close this one."}}
{"actor":{"display_login":"vohmar"}}