{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/6226","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/6226/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/6226/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/6226/events","html_url":"https://github.com/status-im/status-react/pull/6226","id":368329384,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTMyNTEw","number":6226,"title":"Always load messages referenced in responses","user":{"login":"janherich","id":1910609,"node_id":"MDQ6VXNlcjE5MTA2MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1910609?v=4","gravatar_id":"","url":"https://api.github.com/users/janherich","html_url":"https://github.com/janherich","followers_url":"https://api.github.com/users/janherich/followers","following_url":"https://api.github.com/users/janherich/following{/other_user}","gists_url":"https://api.github.com/users/janherich/gists{/gist_id}","starred_url":"https://api.github.com/users/janherich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janherich/subscriptions","organizations_url":"https://api.github.com/users/janherich/orgs","repos_url":"https://api.github.com/users/janherich/repos","events_url":"https://api.github.com/users/janherich/events{/privacy}","received_events_url":"https://api.github.com/users/janherich/received_events","type":"User","site_admin":false},"labels":[{"id":613726715,"node_id":"MDU6TGFiZWw2MTM3MjY3MTU=","url":"https://api.github.com/repos/status-im/status-react/labels/Tested%20-%20Issues","name":"Tested - Issues","color":"d93f0b","default":false},{"id":330296931,"node_id":"MDU6TGFiZWwzMzAyOTY5MzE=","url":"https://api.github.com/repos/status-im/status-react/labels/bug","name":"bug","color":"fc2929","default":true},{"id":782926578,"node_id":"MDU6TGFiZWw3ODI5MjY1Nzg=","url":"https://api.github.com/repos/status-im/status-react/labels/desktop","name":"desktop","color":"fcb099","default":false},{"id":946691481,"node_id":"MDU6TGFiZWw5NDY2OTE0ODE=","url":"https://api.github.com/repos/status-im/status-react/labels/mobile-app","name":"mobile-app","color":"f4e949","default":false}],"state":"open","locked":false,"assignee":{"login":"janherich","id":1910609,"node_id":"MDQ6VXNlcjE5MTA2MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1910609?v=4","gravatar_id":"","url":"https://api.github.com/users/janherich","html_url":"https://github.com/janherich","followers_url":"https://api.github.com/users/janherich/followers","following_url":"https://api.github.com/users/janherich/following{/other_user}","gists_url":"https://api.github.com/users/janherich/gists{/gist_id}","starred_url":"https://api.github.com/users/janherich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janherich/subscriptions","organizations_url":"https://api.github.com/users/janherich/orgs","repos_url":"https://api.github.com/users/janherich/repos","events_url":"https://api.github.com/users/janherich/events{/privacy}","received_events_url":"https://api.github.com/users/janherich/received_events","type":"User","site_admin":false},"assignees":[{"login":"janherich","id":1910609,"node_id":"MDQ6VXNlcjE5MTA2MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1910609?v=4","gravatar_id":"","url":"https://api.github.com/users/janherich","html_url":"https://github.com/janherich","followers_url":"https://api.github.com/users/janherich/followers","following_url":"https://api.github.com/users/janherich/following{/other_user}","gists_url":"https://api.github.com/users/janherich/gists{/gist_id}","starred_url":"https://api.github.com/users/janherich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janherich/subscriptions","organizations_url":"https://api.github.com/users/janherich/orgs","repos_url":"https://api.github.com/users/janherich/repos","events_url":"https://api.github.com/users/janherich/events{/privacy}","received_events_url":"https://api.github.com/users/janherich/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-10-09T18:02:19Z","updated_at":"2018-10-10T13:58:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/6226","html_url":"https://github.com/status-im/status-react/pull/6226","diff_url":"https://github.com/status-im/status-react/pull/6226.diff","patch_url":"https://github.com/status-im/status-react/pull/6226.patch"},"body":"[comment]: # (Please replace ... with your information. Remove < and >)\r\n[comment]: # (To auto-close issue on merge, please insert the related issue number after # i.e fixes #566)\r\n\r\nThere was a problem with partial loading of messages (pagination), when some message referenced reply not yet loaded, resulting in blank \"response to\" section.\r\nThis PR fixes it in a reasonable effective way, however we should seriously think about redoing our pagination altogether and getting rid of the fields like `:not-loaded-message-ids` and (added in this PR) `:referenced-messages` in favour of always holding all messages in the memory (should be feasible, needs proof) and modelling the rendered range by by `:range [from to]` properties in `app-db`.\r\n\r\n## Testing notes\r\n* Test that when app is open and not all messages are loaded from db, you can still see the the referenced messages in replies. The only exception is when those referenced messages are older then 24h, eq they are never fetched from mailserver.\r\n\r\nstatus: ready\r\n"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/428582595","html_url":"https://github.com/status-im/status-react/pull/6226#issuecomment-428582595","issue_url":"https://api.github.com/repos/status-im/status-react/issues/6226","id":428582595,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODU4MjU5NQ==","user":{"login":"janherich","id":1910609,"node_id":"MDQ6VXNlcjE5MTA2MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1910609?v=4","gravatar_id":"","url":"https://api.github.com/users/janherich","html_url":"https://github.com/janherich","followers_url":"https://api.github.com/users/janherich/followers","following_url":"https://api.github.com/users/janherich/following{/other_user}","gists_url":"https://api.github.com/users/janherich/gists{/gist_id}","starred_url":"https://api.github.com/users/janherich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janherich/subscriptions","organizations_url":"https://api.github.com/users/janherich/orgs","repos_url":"https://api.github.com/users/janherich/repos","events_url":"https://api.github.com/users/janherich/events{/privacy}","received_events_url":"https://api.github.com/users/janherich/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T13:58:59Z","updated_at":"2018-10-10T13:58:59Z","author_association":"MEMBER","body":"@churik I just spoke with @yenda and very soon we will fetch last 7 days worth of messages instead of 24h, which will mostly solve the original issue, as almost nobody will reply to message more then 7 days old."}}
{"actor":{"display_login":"janherich"}}