{"action":"created","comment":{"url":"https://api.github.com/repos/esp8266/Arduino/pulls/comments/198500375","pull_request_review_id":132439936,"id":198500375,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODUwMDM3NQ==","diff_hunk":"@@ -427,6 +428,17 @@ typedef enum {\n     MODEM_SLEEP_T\n } sleep_type_t;\n \n+typedef enum {\n+    MIN_SLEEP_T,\n+    MAX_SLEEP_T\n+} sleep_level_t;\n+\n+bool wifi_set_sleep_level(sleep_level_t level);\n+sleep_level_t wifi_get_sleep_level(void);\n+\n+bool wifi_set_listen_interval(uint8 interval);","path":"tools/sdk/include/user_interface.h","position":20,"original_position":20,"commit_id":"bfe530ceb9de8e23b52b313b470e7322779563fe","original_commit_id":"c47e328fdef28428703d44f8b5984eff26d9521f","user":{"login":"d-a-v","id":4800356,"node_id":"MDQ6VXNlcjQ4MDAzNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4800356?v=4","gravatar_id":"","url":"https://api.github.com/users/d-a-v","html_url":"https://github.com/d-a-v","followers_url":"https://api.github.com/users/d-a-v/followers","following_url":"https://api.github.com/users/d-a-v/following{/other_user}","gists_url":"https://api.github.com/users/d-a-v/gists{/gist_id}","starred_url":"https://api.github.com/users/d-a-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-a-v/subscriptions","organizations_url":"https://api.github.com/users/d-a-v/orgs","repos_url":"https://api.github.com/users/d-a-v/repos","events_url":"https://api.github.com/users/d-a-v/events{/privacy}","received_events_url":"https://api.github.com/users/d-a-v/received_events","type":"User","site_admin":false},"body":"No doc to my knowledge yet.","created_at":"2018-06-27T13:44:32Z","updated_at":"2018-06-27T13:44:32Z","html_url":"https://github.com/esp8266/Arduino/pull/4853#discussion_r198500375","pull_request_url":"https://api.github.com/repos/esp8266/Arduino/pulls/4853","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/comments/198500375"},"html":{"href":"https://github.com/esp8266/Arduino/pull/4853#discussion_r198500375"},"pull_request":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/4853"}},"in_reply_to_id":198365537},"pull_request":{"url":"https://api.github.com/repos/esp8266/Arduino/pulls/4853","id":197596574,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTk2NTc0","html_url":"https://github.com/esp8266/Arduino/pull/4853","diff_url":"https://github.com/esp8266/Arduino/pull/4853.diff","patch_url":"https://github.com/esp8266/Arduino/pull/4853.patch","issue_url":"https://api.github.com/repos/esp8266/Arduino/issues/4853","number":4853,"state":"open","locked":false,"title":"update to latest git version of nonos-sdk (SDK:3.0.0-dev(c0f7b44))","user":{"login":"d-a-v","id":4800356,"node_id":"MDQ6VXNlcjQ4MDAzNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4800356?v=4","gravatar_id":"","url":"https://api.github.com/users/d-a-v","html_url":"https://github.com/d-a-v","followers_url":"https://api.github.com/users/d-a-v/followers","following_url":"https://api.github.com/users/d-a-v/following{/other_user}","gists_url":"https://api.github.com/users/d-a-v/gists{/gist_id}","starred_url":"https://api.github.com/users/d-a-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-a-v/subscriptions","organizations_url":"https://api.github.com/users/d-a-v/orgs","repos_url":"https://api.github.com/users/d-a-v/repos","events_url":"https://api.github.com/users/d-a-v/events{/privacy}","received_events_url":"https://api.github.com/users/d-a-v/received_events","type":"User","site_admin":false},"body":"This PR reflects espressif/ESP8266_NONOS_SDK@89920dc (v2.2.0-28-g89920dc)\r\n* includes new syscalls `wifi_{get,set}_sleep_level()` and `wifi_{get,set}_listen_interval()` \r\n* API change: user must select between open/wep or WPA/WPA2\r\n\r\nNow open or wep network must be selected before connecting.\r\nThis is introduced by `struct station_config`.`open_and_wep_mode_disable` (this new entry was forgotten in the former PR). This value is currently set to true by default.\r\n\r\nOpened questions:\r\n* `open_and_wep_mode_disable` can be set to false if the password is empty (is an empty password is only allowed when using open APs ?)\r\n* Is there a way to detect a wep password that cannot be a wpa password ? In that case this new entry can be automagically set, otherwise we might need to introduce something like `WiFi.wepAllowed()`.\r\n* Should we get rid of unused libraries ?\r\n```\r\nlibgcc.a\r\nlibat.a\r\nlibupgrade.a\r\nlibjson.a\r\nlibssl.a\r\nlibdriver.a\r\nliblwip_536.a\r\nlibpwm.a\r\n```\r\n\r\n(former PR #4806 has links about unsolved eduroam issue)\r\n","created_at":"2018-06-27T01:55:50Z","updated_at":"2018-06-27T13:44:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63816d53e99ff7ddf355346ffb50eeaa96a2d1cc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"earlephilhower","id":11875,"node_id":"MDQ6VXNlcjExODc1","avatar_url":"https://avatars0.githubusercontent.com/u/11875?v=4","gravatar_id":"","url":"https://api.github.com/users/earlephilhower","html_url":"https://github.com/earlephilhower","followers_url":"https://api.github.com/users/earlephilhower/followers","following_url":"https://api.github.com/users/earlephilhower/following{/other_user}","gists_url":"https://api.github.com/users/earlephilhower/gists{/gist_id}","starred_url":"https://api.github.com/users/earlephilhower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earlephilhower/subscriptions","organizations_url":"https://api.github.com/users/earlephilhower/orgs","repos_url":"https://api.github.com/users/earlephilhower/repos","events_url":"https://api.github.com/users/earlephilhower/events{/privacy}","received_events_url":"https://api.github.com/users/earlephilhower/received_events","type":"User","site_admin":false},{"login":"igrr","id":4349050,"node_id":"MDQ6VXNlcjQzNDkwNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4349050?v=4","gravatar_id":"","url":"https://api.github.com/users/igrr","html_url":"https://github.com/igrr","followers_url":"https://api.github.com/users/igrr/followers","following_url":"https://api.github.com/users/igrr/following{/other_user}","gists_url":"https://api.github.com/users/igrr/gists{/gist_id}","starred_url":"https://api.github.com/users/igrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igrr/subscriptions","organizations_url":"https://api.github.com/users/igrr/orgs","repos_url":"https://api.github.com/users/igrr/repos","events_url":"https://api.github.com/users/igrr/events{/privacy}","received_events_url":"https://api.github.com/users/igrr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/esp8266/Arduino/pulls/4853/commits","review_comments_url":"https://api.github.com/repos/esp8266/Arduino/pulls/4853/comments","review_comment_url":"https://api.github.com/repos/esp8266/Arduino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esp8266/Arduino/issues/4853/comments","statuses_url":"https://api.github.com/repos/esp8266/Arduino/statuses/bfe530ceb9de8e23b52b313b470e7322779563fe","head":{"label":"d-a-v:fw","ref":"fw","sha":"bfe530ceb9de8e23b52b313b470e7322779563fe","user":{"login":"d-a-v","id":4800356,"node_id":"MDQ6VXNlcjQ4MDAzNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4800356?v=4","gravatar_id":"","url":"https://api.github.com/users/d-a-v","html_url":"https://github.com/d-a-v","followers_url":"https://api.github.com/users/d-a-v/followers","following_url":"https://api.github.com/users/d-a-v/following{/other_user}","gists_url":"https://api.github.com/users/d-a-v/gists{/gist_id}","starred_url":"https://api.github.com/users/d-a-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-a-v/subscriptions","organizations_url":"https://api.github.com/users/d-a-v/orgs","repos_url":"https://api.github.com/users/d-a-v/repos","events_url":"https://api.github.com/users/d-a-v/events{/privacy}","received_events_url":"https://api.github.com/users/d-a-v/received_events","type":"User","site_admin":false},"repo":{"id":84005789,"node_id":"MDEwOlJlcG9zaXRvcnk4NDAwNTc4OQ==","name":"Arduino","full_name":"d-a-v/Arduino","owner":{"login":"d-a-v","id":4800356,"node_id":"MDQ6VXNlcjQ4MDAzNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4800356?v=4","gravatar_id":"","url":"https://api.github.com/users/d-a-v","html_url":"https://github.com/d-a-v","followers_url":"https://api.github.com/users/d-a-v/followers","following_url":"https://api.github.com/users/d-a-v/following{/other_user}","gists_url":"https://api.github.com/users/d-a-v/gists{/gist_id}","starred_url":"https://api.github.com/users/d-a-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-a-v/subscriptions","organizations_url":"https://api.github.com/users/d-a-v/orgs","repos_url":"https://api.github.com/users/d-a-v/repos","events_url":"https://api.github.com/users/d-a-v/events{/privacy}","received_events_url":"https://api.github.com/users/d-a-v/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-a-v/Arduino","description":"ESP8266 core for Arduino","fork":true,"url":"https://api.github.com/repos/d-a-v/Arduino","forks_url":"https://api.github.com/repos/d-a-v/Arduino/forks","keys_url":"https://api.github.com/repos/d-a-v/Arduino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-a-v/Arduino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-a-v/Arduino/teams","hooks_url":"https://api.github.com/repos/d-a-v/Arduino/hooks","issue_events_url":"https://api.github.com/repos/d-a-v/Arduino/issues/events{/number}","events_url":"https://api.github.com/repos/d-a-v/Arduino/events","assignees_url":"https://api.github.com/repos/d-a-v/Arduino/assignees{/user}","branches_url":"https://api.github.com/repos/d-a-v/Arduino/branches{/branch}","tags_url":"https://api.github.com/repos/d-a-v/Arduino/tags","blobs_url":"https://api.github.com/repos/d-a-v/Arduino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-a-v/Arduino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-a-v/Arduino/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-a-v/Arduino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-a-v/Arduino/statuses/{sha}","languages_url":"https://api.github.com/repos/d-a-v/Arduino/languages","stargazers_url":"https://api.github.com/repos/d-a-v/Arduino/stargazers","contributors_url":"https://api.github.com/repos/d-a-v/Arduino/contributors","subscribers_url":"https://api.github.com/repos/d-a-v/Arduino/subscribers","subscription_url":"https://api.github.com/repos/d-a-v/Arduino/subscription","commits_url":"https://api.github.com/repos/d-a-v/Arduino/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-a-v/Arduino/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-a-v/Arduino/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-a-v/Arduino/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-a-v/Arduino/contents/{+path}","compare_url":"https://api.github.com/repos/d-a-v/Arduino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-a-v/Arduino/merges","archive_url":"https://api.github.com/repos/d-a-v/Arduino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-a-v/Arduino/downloads","issues_url":"https://api.github.com/repos/d-a-v/Arduino/issues{/number}","pulls_url":"https://api.github.com/repos/d-a-v/Arduino/pulls{/number}","milestones_url":"https://api.github.com/repos/d-a-v/Arduino/milestones{/number}","notifications_url":"https://api.github.com/repos/d-a-v/Arduino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-a-v/Arduino/labels{/name}","releases_url":"https://api.github.com/repos/d-a-v/Arduino/releases{/id}","deployments_url":"https://api.github.com/repos/d-a-v/Arduino/deployments","created_at":"2017-03-05T22:07:22Z","updated_at":"2018-03-07T14:47:03Z","pushed_at":"2018-06-27T13:35:31Z","git_url":"git://github.com/d-a-v/Arduino.git","ssh_url":"git@github.com:d-a-v/Arduino.git","clone_url":"https://github.com/d-a-v/Arduino.git","svn_url":"https://github.com/d-a-v/Arduino","homepage":"","size":47991,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"esp8266:master","ref":"master","sha":"641c5cdc61e5967c682a24e2df1c3b1765d60dab","user":{"login":"esp8266","id":8943775,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NDM3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8943775?v=4","gravatar_id":"","url":"https://api.github.com/users/esp8266","html_url":"https://github.com/esp8266","followers_url":"https://api.github.com/users/esp8266/followers","following_url":"https://api.github.com/users/esp8266/following{/other_user}","gists_url":"https://api.github.com/users/esp8266/gists{/gist_id}","starred_url":"https://api.github.com/users/esp8266/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esp8266/subscriptions","organizations_url":"https://api.github.com/users/esp8266/orgs","repos_url":"https://api.github.com/users/esp8266/repos","events_url":"https://api.github.com/users/esp8266/events{/privacy}","received_events_url":"https://api.github.com/users/esp8266/received_events","type":"Organization","site_admin":false},"repo":{"id":32969220,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk2OTIyMA==","name":"Arduino","full_name":"esp8266/Arduino","owner":{"login":"esp8266","id":8943775,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NDM3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8943775?v=4","gravatar_id":"","url":"https://api.github.com/users/esp8266","html_url":"https://github.com/esp8266","followers_url":"https://api.github.com/users/esp8266/followers","following_url":"https://api.github.com/users/esp8266/following{/other_user}","gists_url":"https://api.github.com/users/esp8266/gists{/gist_id}","starred_url":"https://api.github.com/users/esp8266/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esp8266/subscriptions","organizations_url":"https://api.github.com/users/esp8266/orgs","repos_url":"https://api.github.com/users/esp8266/repos","events_url":"https://api.github.com/users/esp8266/events{/privacy}","received_events_url":"https://api.github.com/users/esp8266/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esp8266/Arduino","description":"ESP8266 core for Arduino","fork":false,"url":"https://api.github.com/repos/esp8266/Arduino","forks_url":"https://api.github.com/repos/esp8266/Arduino/forks","keys_url":"https://api.github.com/repos/esp8266/Arduino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esp8266/Arduino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esp8266/Arduino/teams","hooks_url":"https://api.github.com/repos/esp8266/Arduino/hooks","issue_events_url":"https://api.github.com/repos/esp8266/Arduino/issues/events{/number}","events_url":"https://api.github.com/repos/esp8266/Arduino/events","assignees_url":"https://api.github.com/repos/esp8266/Arduino/assignees{/user}","branches_url":"https://api.github.com/repos/esp8266/Arduino/branches{/branch}","tags_url":"https://api.github.com/repos/esp8266/Arduino/tags","blobs_url":"https://api.github.com/repos/esp8266/Arduino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esp8266/Arduino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esp8266/Arduino/git/refs{/sha}","trees_url":"https://api.github.com/repos/esp8266/Arduino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esp8266/Arduino/statuses/{sha}","languages_url":"https://api.github.com/repos/esp8266/Arduino/languages","stargazers_url":"https://api.github.com/repos/esp8266/Arduino/stargazers","contributors_url":"https://api.github.com/repos/esp8266/Arduino/contributors","subscribers_url":"https://api.github.com/repos/esp8266/Arduino/subscribers","subscription_url":"https://api.github.com/repos/esp8266/Arduino/subscription","commits_url":"https://api.github.com/repos/esp8266/Arduino/commits{/sha}","git_commits_url":"https://api.github.com/repos/esp8266/Arduino/git/commits{/sha}","comments_url":"https://api.github.com/repos/esp8266/Arduino/comments{/number}","issue_comment_url":"https://api.github.com/repos/esp8266/Arduino/issues/comments{/number}","contents_url":"https://api.github.com/repos/esp8266/Arduino/contents/{+path}","compare_url":"https://api.github.com/repos/esp8266/Arduino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esp8266/Arduino/merges","archive_url":"https://api.github.com/repos/esp8266/Arduino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esp8266/Arduino/downloads","issues_url":"https://api.github.com/repos/esp8266/Arduino/issues{/number}","pulls_url":"https://api.github.com/repos/esp8266/Arduino/pulls{/number}","milestones_url":"https://api.github.com/repos/esp8266/Arduino/milestones{/number}","notifications_url":"https://api.github.com/repos/esp8266/Arduino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esp8266/Arduino/labels{/name}","releases_url":"https://api.github.com/repos/esp8266/Arduino/releases{/id}","deployments_url":"https://api.github.com/repos/esp8266/Arduino/deployments","created_at":"2015-03-27T05:22:06Z","updated_at":"2018-06-27T13:22:39Z","pushed_at":"2018-06-27T13:35:32Z","git_url":"git://github.com/esp8266/Arduino.git","ssh_url":"git@github.com:esp8266/Arduino.git","clone_url":"https://github.com/esp8266/Arduino.git","svn_url":"https://github.com/esp8266/Arduino","homepage":"","size":45481,"stargazers_count":7537,"watchers_count":7537,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4861,"mirror_url":null,"archived":false,"open_issues_count":624,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":4861,"open_issues":624,"watchers":7537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/4853"},"html":{"href":"https://github.com/esp8266/Arduino/pull/4853"},"issue":{"href":"https://api.github.com/repos/esp8266/Arduino/issues/4853"},"comments":{"href":"https://api.github.com/repos/esp8266/Arduino/issues/4853/comments"},"review_comments":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/4853/comments"},"review_comment":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/4853/commits"},"statuses":{"href":"https://api.github.com/repos/esp8266/Arduino/statuses/bfe530ceb9de8e23b52b313b470e7322779563fe"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"d-a-v"}}