{"action":"closed","number":90,"pull_request":{"url":"https://api.github.com/repos/gstroup/apimocker/pulls/90","id":179178208,"html_url":"https://github.com/gstroup/apimocker/pull/90","diff_url":"https://github.com/gstroup/apimocker/pull/90.diff","patch_url":"https://github.com/gstroup/apimocker/pull/90.patch","issue_url":"https://api.github.com/repos/gstroup/apimocker/issues/90","number":90,"state":"closed","locked":false,"title":"Remove url decoding when sending mockFile","user":{"login":"twalker","id":101895,"avatar_url":"https://avatars0.githubusercontent.com/u/101895?v=4","gravatar_id":"","url":"https://api.github.com/users/twalker","html_url":"https://github.com/twalker","followers_url":"https://api.github.com/users/twalker/followers","following_url":"https://api.github.com/users/twalker/following{/other_user}","gists_url":"https://api.github.com/users/twalker/gists{/gist_id}","starred_url":"https://api.github.com/users/twalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalker/subscriptions","organizations_url":"https://api.github.com/users/twalker/orgs","repos_url":"https://api.github.com/users/twalker/repos","events_url":"https://api.github.com/users/twalker/events{/privacy}","received_events_url":"https://api.github.com/users/twalker/received_events","type":"User","site_admin":false},"body":"The encoding of the `mockFile` path changed between v.0.5.1 and v1.01 in this commit:\r\nhttps://github.com/gstroup/apimocker/commit/a79387f295f158c25fc1a667b3a41dabb9168349\r\n\r\nDuring `sendResponse`, a raw path is used to check if the path exists, while a decoded path is used to send the file. Mock files with URL encoded characters in their name would be found, but result in an error when being sent.  \r\n\r\nFor example, a mock switching on a `latLng` querystring parameter with a  value including`,`:\r\n`/data/latLng47%2C-122.nearby.json`\r\nThe path will *not* be decoded to check the file exists--passing the `fs.exists` check. This was the previous, and expected behavior.\r\nBut a decoded path is then used to send the file:  \r\n`/data/latLng47,-122.nearby.json`.\r\n\r\nThis results in:\r\n```\r\nError: ENOENT: no such file or directory, stat '/data/latLng47,-122.3418.nearby.json'\r\n    at Error (native)\r\n```\r\n\r\nThis change removes the decoding when sending the file so the same path is used for both checking the existence of the file, and sending the file.","created_at":"2018-04-03T18:13:17Z","updated_at":"2018-04-06T21:08:37Z","closed_at":"2018-04-06T21:08:36Z","merged_at":"2018-04-06T21:08:36Z","merge_commit_sha":"f49a95596072e6ba99a1f504ad94716413f59380","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gstroup/apimocker/pulls/90/commits","review_comments_url":"https://api.github.com/repos/gstroup/apimocker/pulls/90/comments","review_comment_url":"https://api.github.com/repos/gstroup/apimocker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gstroup/apimocker/issues/90/comments","statuses_url":"https://api.github.com/repos/gstroup/apimocker/statuses/f49a95596072e6ba99a1f504ad94716413f59380","head":{"label":"twalker:bugfix-mockPath","ref":"bugfix-mockPath","sha":"f49a95596072e6ba99a1f504ad94716413f59380","user":{"login":"twalker","id":101895,"avatar_url":"https://avatars0.githubusercontent.com/u/101895?v=4","gravatar_id":"","url":"https://api.github.com/users/twalker","html_url":"https://github.com/twalker","followers_url":"https://api.github.com/users/twalker/followers","following_url":"https://api.github.com/users/twalker/following{/other_user}","gists_url":"https://api.github.com/users/twalker/gists{/gist_id}","starred_url":"https://api.github.com/users/twalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalker/subscriptions","organizations_url":"https://api.github.com/users/twalker/orgs","repos_url":"https://api.github.com/users/twalker/repos","events_url":"https://api.github.com/users/twalker/events{/privacy}","received_events_url":"https://api.github.com/users/twalker/received_events","type":"User","site_admin":false},"repo":{"id":127939099,"name":"apimocker","full_name":"twalker/apimocker","owner":{"login":"twalker","id":101895,"avatar_url":"https://avatars0.githubusercontent.com/u/101895?v=4","gravatar_id":"","url":"https://api.github.com/users/twalker","html_url":"https://github.com/twalker","followers_url":"https://api.github.com/users/twalker/followers","following_url":"https://api.github.com/users/twalker/following{/other_user}","gists_url":"https://api.github.com/users/twalker/gists{/gist_id}","starred_url":"https://api.github.com/users/twalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalker/subscriptions","organizations_url":"https://api.github.com/users/twalker/orgs","repos_url":"https://api.github.com/users/twalker/repos","events_url":"https://api.github.com/users/twalker/events{/privacy}","received_events_url":"https://api.github.com/users/twalker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twalker/apimocker","description":"node.js module to run a simple http server for mock service responses.","fork":true,"url":"https://api.github.com/repos/twalker/apimocker","forks_url":"https://api.github.com/repos/twalker/apimocker/forks","keys_url":"https://api.github.com/repos/twalker/apimocker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twalker/apimocker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twalker/apimocker/teams","hooks_url":"https://api.github.com/repos/twalker/apimocker/hooks","issue_events_url":"https://api.github.com/repos/twalker/apimocker/issues/events{/number}","events_url":"https://api.github.com/repos/twalker/apimocker/events","assignees_url":"https://api.github.com/repos/twalker/apimocker/assignees{/user}","branches_url":"https://api.github.com/repos/twalker/apimocker/branches{/branch}","tags_url":"https://api.github.com/repos/twalker/apimocker/tags","blobs_url":"https://api.github.com/repos/twalker/apimocker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twalker/apimocker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twalker/apimocker/git/refs{/sha}","trees_url":"https://api.github.com/repos/twalker/apimocker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twalker/apimocker/statuses/{sha}","languages_url":"https://api.github.com/repos/twalker/apimocker/languages","stargazers_url":"https://api.github.com/repos/twalker/apimocker/stargazers","contributors_url":"https://api.github.com/repos/twalker/apimocker/contributors","subscribers_url":"https://api.github.com/repos/twalker/apimocker/subscribers","subscription_url":"https://api.github.com/repos/twalker/apimocker/subscription","commits_url":"https://api.github.com/repos/twalker/apimocker/commits{/sha}","git_commits_url":"https://api.github.com/repos/twalker/apimocker/git/commits{/sha}","comments_url":"https://api.github.com/repos/twalker/apimocker/comments{/number}","issue_comment_url":"https://api.github.com/repos/twalker/apimocker/issues/comments{/number}","contents_url":"https://api.github.com/repos/twalker/apimocker/contents/{+path}","compare_url":"https://api.github.com/repos/twalker/apimocker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twalker/apimocker/merges","archive_url":"https://api.github.com/repos/twalker/apimocker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twalker/apimocker/downloads","issues_url":"https://api.github.com/repos/twalker/apimocker/issues{/number}","pulls_url":"https://api.github.com/repos/twalker/apimocker/pulls{/number}","milestones_url":"https://api.github.com/repos/twalker/apimocker/milestones{/number}","notifications_url":"https://api.github.com/repos/twalker/apimocker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twalker/apimocker/labels{/name}","releases_url":"https://api.github.com/repos/twalker/apimocker/releases{/id}","deployments_url":"https://api.github.com/repos/twalker/apimocker/deployments","created_at":"2018-04-03T16:47:15Z","updated_at":"2018-04-03T16:47:18Z","pushed_at":"2018-04-03T17:23:29Z","git_url":"git://github.com/twalker/apimocker.git","ssh_url":"git@github.com:twalker/apimocker.git","clone_url":"https://github.com/twalker/apimocker.git","svn_url":"https://github.com/twalker/apimocker","homepage":null,"size":252,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gstroup:master","ref":"master","sha":"2a208e7f337f12c00ca36902b1a1267d75176e79","user":{"login":"gstroup","id":431334,"avatar_url":"https://avatars1.githubusercontent.com/u/431334?v=4","gravatar_id":"","url":"https://api.github.com/users/gstroup","html_url":"https://github.com/gstroup","followers_url":"https://api.github.com/users/gstroup/followers","following_url":"https://api.github.com/users/gstroup/following{/other_user}","gists_url":"https://api.github.com/users/gstroup/gists{/gist_id}","starred_url":"https://api.github.com/users/gstroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gstroup/subscriptions","organizations_url":"https://api.github.com/users/gstroup/orgs","repos_url":"https://api.github.com/users/gstroup/repos","events_url":"https://api.github.com/users/gstroup/events{/privacy}","received_events_url":"https://api.github.com/users/gstroup/received_events","type":"User","site_admin":false},"repo":{"id":8103181,"name":"apimocker","full_name":"gstroup/apimocker","owner":{"login":"gstroup","id":431334,"avatar_url":"https://avatars1.githubusercontent.com/u/431334?v=4","gravatar_id":"","url":"https://api.github.com/users/gstroup","html_url":"https://github.com/gstroup","followers_url":"https://api.github.com/users/gstroup/followers","following_url":"https://api.github.com/users/gstroup/following{/other_user}","gists_url":"https://api.github.com/users/gstroup/gists{/gist_id}","starred_url":"https://api.github.com/users/gstroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gstroup/subscriptions","organizations_url":"https://api.github.com/users/gstroup/orgs","repos_url":"https://api.github.com/users/gstroup/repos","events_url":"https://api.github.com/users/gstroup/events{/privacy}","received_events_url":"https://api.github.com/users/gstroup/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gstroup/apimocker","description":"node.js module to run a simple http server for mock service responses.","fork":false,"url":"https://api.github.com/repos/gstroup/apimocker","forks_url":"https://api.github.com/repos/gstroup/apimocker/forks","keys_url":"https://api.github.com/repos/gstroup/apimocker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gstroup/apimocker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gstroup/apimocker/teams","hooks_url":"https://api.github.com/repos/gstroup/apimocker/hooks","issue_events_url":"https://api.github.com/repos/gstroup/apimocker/issues/events{/number}","events_url":"https://api.github.com/repos/gstroup/apimocker/events","assignees_url":"https://api.github.com/repos/gstroup/apimocker/assignees{/user}","branches_url":"https://api.github.com/repos/gstroup/apimocker/branches{/branch}","tags_url":"https://api.github.com/repos/gstroup/apimocker/tags","blobs_url":"https://api.github.com/repos/gstroup/apimocker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gstroup/apimocker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gstroup/apimocker/git/refs{/sha}","trees_url":"https://api.github.com/repos/gstroup/apimocker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gstroup/apimocker/statuses/{sha}","languages_url":"https://api.github.com/repos/gstroup/apimocker/languages","stargazers_url":"https://api.github.com/repos/gstroup/apimocker/stargazers","contributors_url":"https://api.github.com/repos/gstroup/apimocker/contributors","subscribers_url":"https://api.github.com/repos/gstroup/apimocker/subscribers","subscription_url":"https://api.github.com/repos/gstroup/apimocker/subscription","commits_url":"https://api.github.com/repos/gstroup/apimocker/commits{/sha}","git_commits_url":"https://api.github.com/repos/gstroup/apimocker/git/commits{/sha}","comments_url":"https://api.github.com/repos/gstroup/apimocker/comments{/number}","issue_comment_url":"https://api.github.com/repos/gstroup/apimocker/issues/comments{/number}","contents_url":"https://api.github.com/repos/gstroup/apimocker/contents/{+path}","compare_url":"https://api.github.com/repos/gstroup/apimocker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gstroup/apimocker/merges","archive_url":"https://api.github.com/repos/gstroup/apimocker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gstroup/apimocker/downloads","issues_url":"https://api.github.com/repos/gstroup/apimocker/issues{/number}","pulls_url":"https://api.github.com/repos/gstroup/apimocker/pulls{/number}","milestones_url":"https://api.github.com/repos/gstroup/apimocker/milestones{/number}","notifications_url":"https://api.github.com/repos/gstroup/apimocker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gstroup/apimocker/labels{/name}","releases_url":"https://api.github.com/repos/gstroup/apimocker/releases{/id}","deployments_url":"https://api.github.com/repos/gstroup/apimocker/deployments","created_at":"2013-02-08T23:06:25Z","updated_at":"2018-04-05T20:54:04Z","pushed_at":"2018-04-06T21:08:35Z","git_url":"git://github.com/gstroup/apimocker.git","ssh_url":"git@github.com:gstroup/apimocker.git","clone_url":"https://github.com/gstroup/apimocker.git","svn_url":"https://github.com/gstroup/apimocker","homepage":null,"size":280,"stargazers_count":231,"watchers_count":231,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":73,"open_issues":20,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gstroup/apimocker/pulls/90"},"html":{"href":"https://github.com/gstroup/apimocker/pull/90"},"issue":{"href":"https://api.github.com/repos/gstroup/apimocker/issues/90"},"comments":{"href":"https://api.github.com/repos/gstroup/apimocker/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/gstroup/apimocker/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/gstroup/apimocker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gstroup/apimocker/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/gstroup/apimocker/statuses/f49a95596072e6ba99a1f504ad94716413f59380"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gstroup","id":431334,"avatar_url":"https://avatars1.githubusercontent.com/u/431334?v=4","gravatar_id":"","url":"https://api.github.com/users/gstroup","html_url":"https://github.com/gstroup","followers_url":"https://api.github.com/users/gstroup/followers","following_url":"https://api.github.com/users/gstroup/following{/other_user}","gists_url":"https://api.github.com/users/gstroup/gists{/gist_id}","starred_url":"https://api.github.com/users/gstroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gstroup/subscriptions","organizations_url":"https://api.github.com/users/gstroup/orgs","repos_url":"https://api.github.com/users/gstroup/repos","events_url":"https://api.github.com/users/gstroup/events{/privacy}","received_events_url":"https://api.github.com/users/gstroup/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"gstroup"}}