{"action":"created","issue":{"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/2734","repository_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org","labels_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/2734/labels{/name}","comments_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/2734/comments","events_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/2734/events","html_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/2734","id":326572822,"number":2734,"title":"Auto responsive images","user":{"login":"jamesgorrie","id":31692,"avatar_url":"https://avatars3.githubusercontent.com/u/31692?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesgorrie","html_url":"https://github.com/jamesgorrie","followers_url":"https://api.github.com/users/jamesgorrie/followers","following_url":"https://api.github.com/users/jamesgorrie/following{/other_user}","gists_url":"https://api.github.com/users/jamesgorrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgorrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgorrie/subscriptions","organizations_url":"https://api.github.com/users/jamesgorrie/orgs","repos_url":"https://api.github.com/users/jamesgorrie/repos","events_url":"https://api.github.com/users/jamesgorrie/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgorrie/received_events","type":"User","site_admin":false},"labels":[{"id":540778350,"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/labels/feature","name":"feature","color":"5cb8bf","default":false},{"id":465372147,"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/labels/wip","name":"wip","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-25T15:37:46Z","updated_at":"2018-05-25T16:05:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/pulls/2734","html_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/2734","diff_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/2734.diff","patch_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/2734.patch"},"body":"## Who is this for?\r\nDevs putting images into the site.\r\nPeople getting the large images when devs forget to specify those sizes. \r\n\r\n## What is it doing for them?\r\nCurrently we have to permanently remember to put the very custom `sizesQueries` to the `UiImage`.\r\nAs we know the breakpoints and grid workings, we should be able to calculate these for the image.\r\n\r\nThere is a new `ResponsiveImage` component, and I have put it in the story book to battle the `UiImage`.\r\n\r\nCurrently, on the homepage, at desktop it's losing 1.4mb vs 1.2mb. Not much, but worth optimising for.\r\n\r\n\r\n# Thoughts\r\n\r\nIn the new `Grid` component, you might event be able to go through, get all the images, and apply those properties before render, removing even further the need to remember it. 🎷 ."},"comment":{"url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/comments/392105295","html_url":"https://github.com/wellcometrust/wellcomecollection.org/pull/2734#issuecomment-392105295","issue_url":"https://api.github.com/repos/wellcometrust/wellcomecollection.org/issues/2734","id":392105295,"user":{"login":"jamesgorrie","id":31692,"avatar_url":"https://avatars3.githubusercontent.com/u/31692?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesgorrie","html_url":"https://github.com/jamesgorrie","followers_url":"https://api.github.com/users/jamesgorrie/followers","following_url":"https://api.github.com/users/jamesgorrie/following{/other_user}","gists_url":"https://api.github.com/users/jamesgorrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgorrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgorrie/subscriptions","organizations_url":"https://api.github.com/users/jamesgorrie/orgs","repos_url":"https://api.github.com/users/jamesgorrie/repos","events_url":"https://api.github.com/users/jamesgorrie/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgorrie/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T16:05:23Z","updated_at":"2018-05-25T16:05:23Z","author_association":"CONTRIBUTOR","body":"Interestingly - it seems to be the same when using 1 image.\r\nLet's go through this on Tuesday."}}
{"actor":{"display_login":"jamesgorrie"}}