{"action":"created","comment":{"url":"https://api.github.com/repos/brave/brave-ios/pulls/comments/215258937","pull_request_review_id":152482046,"id":215258937,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTI1ODkzNw==","diff_hunk":"@@ -24,7 +24,7 @@ private extension TrayToBrowserAnimator {\n         guard let selectedTab = bvc.tabManager.selectedTab else { return }\n \n         let tabManager = bvc.tabManager\n-        let displayedTabs = selectedTab.isPrivate ? tabManager.privateTabs : tabManager.normalTabs\n+        let displayedTabs = tabManager.tabs(withType: selectedTab.type)","path":"Client/Frontend/Browser/BrowserTrayAnimators.swift","position":5,"original_position":5,"commit_id":"89b519e6ad75d4bd5a37c4e651fc02bbe9ae35e2","original_commit_id":"89b519e6ad75d4bd5a37c4e651fc02bbe9ae35e2","user":{"login":"tmancey","id":1188719,"node_id":"MDQ6VXNlcjExODg3MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1188719?v=4","gravatar_id":"","url":"https://api.github.com/users/tmancey","html_url":"https://github.com/tmancey","followers_url":"https://api.github.com/users/tmancey/followers","following_url":"https://api.github.com/users/tmancey/following{/other_user}","gists_url":"https://api.github.com/users/tmancey/gists{/gist_id}","starred_url":"https://api.github.com/users/tmancey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmancey/subscriptions","organizations_url":"https://api.github.com/users/tmancey/orgs","repos_url":"https://api.github.com/users/tmancey/repos","events_url":"https://api.github.com/users/tmancey/events{/privacy}","received_events_url":"https://api.github.com/users/tmancey/received_events","type":"User","site_admin":false},"body":"We have been discussing mixed tabs recently where we would not use a global isPrivate. I have made the minimum amount of changes to the codebase which will help hopefully move towards the mixed tab goal","created_at":"2018-09-05T13:01:12Z","updated_at":"2018-09-05T13:01:12Z","html_url":"https://github.com/brave/brave-ios/pull/209#discussion_r215258937","pull_request_url":"https://api.github.com/repos/brave/brave-ios/pulls/209","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/comments/215258937"},"html":{"href":"https://github.com/brave/brave-ios/pull/209#discussion_r215258937"},"pull_request":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/209"}},"in_reply_to_id":215224345},"pull_request":{"url":"https://api.github.com/repos/brave/brave-ios/pulls/209","id":212202646,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjAyNjQ2","html_url":"https://github.com/brave/brave-ios/pull/209","diff_url":"https://github.com/brave/brave-ios/pull/209.diff","patch_url":"https://github.com/brave/brave-ios/pull/209.patch","issue_url":"https://api.github.com/repos/brave/brave-ios/issues/209","number":209,"state":"open","locked":false,"title":"Fix #153, Fix #155: Data should not be persisted while private browsing","user":{"login":"tmancey","id":1188719,"node_id":"MDQ6VXNlcjExODg3MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1188719?v=4","gravatar_id":"","url":"https://api.github.com/users/tmancey","html_url":"https://github.com/tmancey","followers_url":"https://api.github.com/users/tmancey/followers","following_url":"https://api.github.com/users/tmancey/following{/other_user}","gists_url":"https://api.github.com/users/tmancey/gists{/gist_id}","starred_url":"https://api.github.com/users/tmancey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmancey/subscriptions","organizations_url":"https://api.github.com/users/tmancey/orgs","repos_url":"https://api.github.com/users/tmancey/repos","events_url":"https://api.github.com/users/tmancey/events{/privacy}","received_events_url":"https://api.github.com/users/tmancey/received_events","type":"User","site_admin":false},"body":"## Pull Request Checklist\r\n\r\n- [ ] My patch has gone through review and I have addressed review comments\r\n- [x] My patch has a standard commit message that looks like `Fix #123: This fixes the shattered coffee cup!`\r\n\r\n- [ ] I have updated the *Unit Tests* to cover new or changed functionality\r\n- [ ] I have updated the *UI Tests* to cover new or changed functionality\r\n- [x] I have marked the bug with `[needsuplift]`\r\n- [x] I have made sure that localizable strings use `NSLocalizableString()`\r\n\r\n## Screenshots\r\n\r\nIf your patch includes user interface changes that you would like to suggest or that you would like UX to look at, please include them here.\r\n\r\n## Notes for testing this patch\r\n\r\nPrivate browsing mode has been removed from `UIApplication` into it's own singleton as a temporary measure until we move to mixed tabs.\r\n\r\n`BraveWebView` is protected with PrivacyProtection so that data is not persisted while using private browsing mode. `BraveWebView` is a subclass of WKWebView and should be used instead of `WKWebView` so that cookies, disk and memory caches, and persistent data such as WebSQL, IndexedDB databases, and local storage are not persisted in private browsing mode.\r\n\r\n`WebImageCache` has been added with privacy protection and should replace calls to `SDWebImage` so that images are not persisted in private browsing mode.\r\n\r\nSingleton's for `WebImageCache` have been added for convenience as a temporary measure until we move to mixed tabs where we can then instantiate a sandboxed `WebImageCache` object for each tab.\r\n\r\nChanged browsing mode flag from a `Bool` to a `TabType` currently supporting `.regular` and `.private` browsing modes, so that `.tor` can be added at a future date.\r\n\r\nNOTES: Tabs have not been refactored and legacy code such as userinfo keys, i.e. changing of \"isPrivate\" to \"tabType\" have not been refactored.","created_at":"2018-08-30T20:33:46Z","updated_at":"2018-09-05T13:01:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccda5814df15dcc7b8d6cf5f1427fe04bcd393eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/brave-ios/pulls/209/commits","review_comments_url":"https://api.github.com/repos/brave/brave-ios/pulls/209/comments","review_comment_url":"https://api.github.com/repos/brave/brave-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/brave-ios/issues/209/comments","statuses_url":"https://api.github.com/repos/brave/brave-ios/statuses/89b519e6ad75d4bd5a37c4e651fc02bbe9ae35e2","head":{"label":"brave:fix-153","ref":"fix-153","sha":"89b519e6ad75d4bd5a37c4e651fc02bbe9ae35e2","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":113486284,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM0ODYyODQ=","name":"brave-ios","full_name":"brave/brave-ios","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/brave-ios","description":"Brave iOS Browser","fork":false,"url":"https://api.github.com/repos/brave/brave-ios","forks_url":"https://api.github.com/repos/brave/brave-ios/forks","keys_url":"https://api.github.com/repos/brave/brave-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-ios/teams","hooks_url":"https://api.github.com/repos/brave/brave-ios/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-ios/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-ios/events","assignees_url":"https://api.github.com/repos/brave/brave-ios/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-ios/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-ios/tags","blobs_url":"https://api.github.com/repos/brave/brave-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-ios/languages","stargazers_url":"https://api.github.com/repos/brave/brave-ios/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-ios/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-ios/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-ios/subscription","commits_url":"https://api.github.com/repos/brave/brave-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-ios/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-ios/merges","archive_url":"https://api.github.com/repos/brave/brave-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-ios/downloads","issues_url":"https://api.github.com/repos/brave/brave-ios/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-ios/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-ios/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-ios/deployments","created_at":"2017-12-07T18:42:00Z","updated_at":"2018-09-04T17:41:47Z","pushed_at":"2018-09-05T10:53:52Z","git_url":"git://github.com/brave/brave-ios.git","ssh_url":"git@github.com:brave/brave-ios.git","clone_url":"https://github.com/brave/brave-ios.git","svn_url":"https://github.com/brave/brave-ios","homepage":"https://www.brave.com","size":158403,"stargazers_count":13,"watchers_count":13,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":11,"open_issues":66,"watchers":13,"default_branch":"development"}},"base":{"label":"brave:development","ref":"development","sha":"283823ae1abff11a7aa7e80c9370775c3d020de0","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":113486284,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM0ODYyODQ=","name":"brave-ios","full_name":"brave/brave-ios","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/brave-ios","description":"Brave iOS Browser","fork":false,"url":"https://api.github.com/repos/brave/brave-ios","forks_url":"https://api.github.com/repos/brave/brave-ios/forks","keys_url":"https://api.github.com/repos/brave/brave-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-ios/teams","hooks_url":"https://api.github.com/repos/brave/brave-ios/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-ios/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-ios/events","assignees_url":"https://api.github.com/repos/brave/brave-ios/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-ios/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-ios/tags","blobs_url":"https://api.github.com/repos/brave/brave-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-ios/languages","stargazers_url":"https://api.github.com/repos/brave/brave-ios/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-ios/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-ios/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-ios/subscription","commits_url":"https://api.github.com/repos/brave/brave-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-ios/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-ios/merges","archive_url":"https://api.github.com/repos/brave/brave-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-ios/downloads","issues_url":"https://api.github.com/repos/brave/brave-ios/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-ios/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-ios/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-ios/deployments","created_at":"2017-12-07T18:42:00Z","updated_at":"2018-09-04T17:41:47Z","pushed_at":"2018-09-05T10:53:52Z","git_url":"git://github.com/brave/brave-ios.git","ssh_url":"git@github.com:brave/brave-ios.git","clone_url":"https://github.com/brave/brave-ios.git","svn_url":"https://github.com/brave/brave-ios","homepage":"https://www.brave.com","size":158403,"stargazers_count":13,"watchers_count":13,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":11,"open_issues":66,"watchers":13,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/209"},"html":{"href":"https://github.com/brave/brave-ios/pull/209"},"issue":{"href":"https://api.github.com/repos/brave/brave-ios/issues/209"},"comments":{"href":"https://api.github.com/repos/brave/brave-ios/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/brave-ios/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/brave/brave-ios/statuses/89b519e6ad75d4bd5a37c4e651fc02bbe9ae35e2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tmancey"}}