{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/comments/234035912","pull_request_review_id":175591123,"id":234035912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDAzNTkxMg==","diff_hunk":"@@ -1899,24 +1911,45 @@ def stub_delete_and_return(status, body)\n             end\n           end\n \n-          context 'when the broker did not declare support for plan upgrades' do\n-            let(:old_service_plan) { ServicePlan.make(:v2) }\n-\n+          context 'when the broker does not support plan upgrades on service level' do\n             before { service.update(plan_updateable: false) }\n \n-            it 'does not update the service plan in the database' do\n-              put \"/v2/service_instances/#{service_instance.guid}\", body\n-              expect(service_instance.reload.service_plan).to eq(old_service_plan)\n-            end\n+            context 'and the broker does not declare plan_updateable on plan level' do\n+              let(:old_service_plan) { ServicePlan.make(:v2) }\n \n-            it 'does not make an api call when the plan does not support upgrades' do\n-              put \"/v2/service_instances/#{service_instance.guid}\", body\n-              expect(a_request(:patch, service_broker_url)).to have_been_made.times(0)\n+              it 'does not update the service plan in the database' do\n+                put \"/v2/service_instances/#{service_instance.guid}\", body\n+                expect(service_instance.reload.service_plan).to eq(old_service_plan)","path":"spec/unit/controllers/services/service_instances_controller_spec.rb","position":41,"original_position":41,"commit_id":"5a17bc7937714b5fa41d8926dc7025ca3f5c1140","original_commit_id":"5a17bc7937714b5fa41d8926dc7025ca3f5c1140","user":{"login":"nrxus","id":2774084,"node_id":"MDQ6VXNlcjI3NzQwODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2774084?v=4","gravatar_id":"","url":"https://api.github.com/users/nrxus","html_url":"https://github.com/nrxus","followers_url":"https://api.github.com/users/nrxus/followers","following_url":"https://api.github.com/users/nrxus/following{/other_user}","gists_url":"https://api.github.com/users/nrxus/gists{/gist_id}","starred_url":"https://api.github.com/users/nrxus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrxus/subscriptions","organizations_url":"https://api.github.com/users/nrxus/orgs","repos_url":"https://api.github.com/users/nrxus/repos","events_url":"https://api.github.com/users/nrxus/events{/privacy}","received_events_url":"https://api.github.com/users/nrxus/received_events","type":"User","site_admin":false},"body":"Please assert on the expected status-code after every http request","created_at":"2018-11-15T22:43:04Z","updated_at":"2018-11-15T22:43:04Z","html_url":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1255#discussion_r234035912","pull_request_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/1255","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/comments/234035912"},"html":{"href":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1255#discussion_r234035912"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/1255"}}},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/1255","id":230893261,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwODkzMjYx","html_url":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1255","diff_url":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1255.diff","patch_url":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1255.patch","issue_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/1255","number":1255,"state":"open","locked":false,"title":"Support plan_updateable on plan level.","user":{"login":"AartiKriplani","id":418985,"node_id":"MDQ6VXNlcjQxODk4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/418985?v=4","gravatar_id":"","url":"https://api.github.com/users/AartiKriplani","html_url":"https://github.com/AartiKriplani","followers_url":"https://api.github.com/users/AartiKriplani/followers","following_url":"https://api.github.com/users/AartiKriplani/following{/other_user}","gists_url":"https://api.github.com/users/AartiKriplani/gists{/gist_id}","starred_url":"https://api.github.com/users/AartiKriplani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AartiKriplani/subscriptions","organizations_url":"https://api.github.com/users/AartiKriplani/orgs","repos_url":"https://api.github.com/users/AartiKriplani/repos","events_url":"https://api.github.com/users/AartiKriplani/events{/privacy}","received_events_url":"https://api.github.com/users/AartiKriplani/received_events","type":"User","site_admin":false},"body":"The latest version of the OSBAPI spec has a `plan_updateable` field\r\nfor each service plan object in the broker catalog. This PR adds the support\r\nfor the feature in CC. For more details https://www.pivotaltracker.com/story/show/161257412\r\n\r\n\r\nCo-authored-by: Niki Maslarski <nikolay.maslarski@sap.com>\r\nSigned-off-by: Georgi Lozev <georgi.lozev@sap.com>\r\nCo-authored-by: Georgi Lozev <georgi.lozev@sap.com>\r\n","created_at":"2018-11-14T16:13:15Z","updated_at":"2018-11-15T22:43:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4456d4af1d14f9c87828f6558d73f1cadf5846be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":996428759,"node_id":"MDU6TGFiZWw5OTY0Mjg3NTk=","url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/labels/sapi","name":"sapi","color":"84c43a","default":false},{"id":240264792,"node_id":"MDU6TGFiZWwyNDAyNjQ3OTI=","url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/labels/unscheduled","name":"unscheduled","color":"D9D9D9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/1255/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/1255/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/1255/comments","statuses_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/statuses/5a17bc7937714b5fa41d8926dc7025ca3f5c1140","head":{"label":"cloudfoundry-incubator:pr-support-plan-updatebale-at-plan-level-161257412","ref":"pr-support-plan-updatebale-at-plan-level-161257412","sha":"5a17bc7937714b5fa41d8926dc7025ca3f5c1140","user":{"login":"cloudfoundry-incubator","id":5680605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":103407713,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM0MDc3MTM=","name":"cloud_controller_ng_sapi","full_name":"cloudfoundry-incubator/cloud_controller_ng_sapi","private":false,"owner":{"login":"cloudfoundry-incubator","id":5680605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudfoundry-incubator/cloud_controller_ng_sapi","description":"Cloud Foundry Cloud Controller","fork":true,"url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi","forks_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/forks","keys_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/teams","hooks_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/events","assignees_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/tags","blobs_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/subscription","commits_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/merges","archive_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/downloads","issues_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry-incubator/cloud_controller_ng_sapi/deployments","created_at":"2017-09-13T14:06:49Z","updated_at":"2018-11-15T20:17:31Z","pushed_at":"2018-11-15T20:17:29Z","git_url":"git://github.com/cloudfoundry-incubator/cloud_controller_ng_sapi.git","ssh_url":"git@github.com:cloudfoundry-incubator/cloud_controller_ng_sapi.git","clone_url":"https://github.com/cloudfoundry-incubator/cloud_controller_ng_sapi.git","svn_url":"https://github.com/cloudfoundry-incubator/cloud_controller_ng_sapi","homepage":"","size":35927,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cloudfoundry:master","ref":"master","sha":"97b2c3b0a51dd22f20fcb57d87ad24562ac9aa5f","user":{"login":"cloudfoundry","id":621746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/621746?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":4743255,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQzMjU1","name":"cloud_controller_ng","full_name":"cloudfoundry/cloud_controller_ng","private":false,"owner":{"login":"cloudfoundry","id":621746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/621746?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudfoundry/cloud_controller_ng","description":"Cloud Foundry Cloud Controller","fork":false,"url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng","forks_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/forks","keys_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/teams","hooks_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/events","assignees_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/tags","blobs_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/subscription","commits_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/merges","archive_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/downloads","issues_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/deployments","created_at":"2012-06-21T19:14:32Z","updated_at":"2018-11-15T20:16:45Z","pushed_at":"2018-11-15T21:39:46Z","git_url":"git://github.com/cloudfoundry/cloud_controller_ng.git","ssh_url":"git@github.com:cloudfoundry/cloud_controller_ng.git","clone_url":"https://github.com/cloudfoundry/cloud_controller_ng.git","svn_url":"https://github.com/cloudfoundry/cloud_controller_ng","homepage":"","size":39863,"stargazers_count":131,"watchers_count":131,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":291,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":291,"open_issues":45,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/1255"},"html":{"href":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1255"},"issue":{"href":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/1255"},"comments":{"href":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/1255/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/1255/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/1255/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/statuses/5a17bc7937714b5fa41d8926dc7025ca3f5c1140"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nrxus"}}