{"action":"created","comment":{"url":"https://api.github.com/repos/alicevision/CCTag/pulls/comments/242937583","pull_request_review_id":186572409,"id":242937583,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjkzNzU4Mw==","diff_hunk":"@@ -109,18 +110,24 @@ if(CCTAG_WITH_CUDA)\n     # set(CUDA_NVCC_FLAGS_RELEASE \"${CUDA_NVCC_FLAGS_RELEASE};-G;-g;-DNDEBUG\")\n   endif()\n \n-  #set(CUDA_NVCC_FLAGS         \"${CUDA_NVCC_FLAGS};-gencode;arch=compute_20,code=sm_20\")\n-  #set(CUDA_NVCC_FLAGS         \"${CUDA_NVCC_FLAGS};-gencode;arch=compute_30,code=sm_30\")\n-  set(CUDA_NVCC_FLAGS         \"${CUDA_NVCC_FLAGS};-gencode;arch=compute_35,code=sm_35\")\n-  set(CUDA_NVCC_FLAGS         \"${CUDA_NVCC_FLAGS};-gencode;arch=compute_50,code=sm_50\")\n-  set(CUDA_NVCC_FLAGS         \"${CUDA_NVCC_FLAGS};-gencode;arch=compute_52,code=sm_52\")\n-  set(CUDA_NVCC_FLAGS         \"${CUDA_NVCC_FLAGS};-gencode=arch=compute_52,code=compute_52\")\n-\n-  if(NOT CUDA_VERSION VERSION_LESS 8.0) # cuda >= 8.0\n-    set(CUDA_NVCC_FLAGS         \"${CUDA_NVCC_FLAGS};-gencode=arch=compute_60,code=sm_60\")\n-    set(CUDA_NVCC_FLAGS         \"${CUDA_NVCC_FLAGS};-gencode=arch=compute_61,code=sm_61\")\n-    set(CUDA_NVCC_FLAGS         \"${CUDA_NVCC_FLAGS};-gencode=arch=compute_62,code=sm_62\")\n+  if(NOT CUDA_VERSION_MAJOR LESS 9)\n+    set(CCTAG_CUDA_CC_LIST_BASIC 30 32 35 37 50 52 53)\n+  else\n+    set(CCTAG_CUDA_CC_LIST_BASIC 30 32 35 37 50 52 53 60 61 62 70 71 72)","path":"CMakeLists.txt","position":26,"original_position":26,"commit_id":"34c95cdd9fdd396014d909ed176857eeb928724f","original_commit_id":"34c95cdd9fdd396014d909ed176857eeb928724f","user":{"login":"fabiencastan","id":153585,"node_id":"MDQ6VXNlcjE1MzU4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/153585?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false},"body":"This should not contain 30 and 32.\r\n","created_at":"2018-12-19T14:34:28Z","updated_at":"2018-12-19T14:34:29Z","html_url":"https://github.com/alicevision/CCTag/pull/95#discussion_r242937583","pull_request_url":"https://api.github.com/repos/alicevision/CCTag/pulls/95","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/alicevision/CCTag/pulls/comments/242937583"},"html":{"href":"https://github.com/alicevision/CCTag/pull/95#discussion_r242937583"},"pull_request":{"href":"https://api.github.com/repos/alicevision/CCTag/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/alicevision/CCTag/pulls/95","id":213831065,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODMxMDY1","html_url":"https://github.com/alicevision/CCTag/pull/95","diff_url":"https://github.com/alicevision/CCTag/pull/95.diff","patch_url":"https://github.com/alicevision/CCTag/pull/95.patch","issue_url":"https://api.github.com/repos/alicevision/CCTag/issues/95","number":95,"state":"open","locked":false,"title":"[cmake] CUDA gencode only for valid architectures, plus ccmake option","user":{"login":"griwodz","id":2108546,"node_id":"MDQ6VXNlcjIxMDg1NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2108546?v=4","gravatar_id":"","url":"https://api.github.com/users/griwodz","html_url":"https://github.com/griwodz","followers_url":"https://api.github.com/users/griwodz/followers","following_url":"https://api.github.com/users/griwodz/following{/other_user}","gists_url":"https://api.github.com/users/griwodz/gists{/gist_id}","starred_url":"https://api.github.com/users/griwodz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griwodz/subscriptions","organizations_url":"https://api.github.com/users/griwodz/orgs","repos_url":"https://api.github.com/users/griwodz/repos","events_url":"https://api.github.com/users/griwodz/events{/privacy}","received_events_url":"https://api.github.com/users/griwodz/received_events","type":"User","site_admin":false},"body":"**This is not well-tested !**\r\n\r\nHowever, the cmake code works in PopSift and AliceVision, it saves compile time and version trouble.\r\nI could imagine that the Eigen linking problem is due to a combination of CUDA 8 with code generation for compute capability 6x - that combination is not supported by NVidia.","created_at":"2018-09-07T06:43:43Z","updated_at":"2018-12-19T14:34:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"764cea71e20f90db69046c3338c199c8cb4547fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alicevision/CCTag/pulls/95/commits","review_comments_url":"https://api.github.com/repos/alicevision/CCTag/pulls/95/comments","review_comment_url":"https://api.github.com/repos/alicevision/CCTag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alicevision/CCTag/issues/95/comments","statuses_url":"https://api.github.com/repos/alicevision/CCTag/statuses/34c95cdd9fdd396014d909ed176857eeb928724f","head":{"label":"alicevision:dev_cmakeSelectCUDACC","ref":"dev_cmakeSelectCUDACC","sha":"34c95cdd9fdd396014d909ed176857eeb928724f","user":{"login":"alicevision","id":9333123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMzMxMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9333123?v=4","gravatar_id":"","url":"https://api.github.com/users/alicevision","html_url":"https://github.com/alicevision","followers_url":"https://api.github.com/users/alicevision/followers","following_url":"https://api.github.com/users/alicevision/following{/other_user}","gists_url":"https://api.github.com/users/alicevision/gists{/gist_id}","starred_url":"https://api.github.com/users/alicevision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicevision/subscriptions","organizations_url":"https://api.github.com/users/alicevision/orgs","repos_url":"https://api.github.com/users/alicevision/repos","events_url":"https://api.github.com/users/alicevision/events{/privacy}","received_events_url":"https://api.github.com/users/alicevision/received_events","type":"Organization","site_admin":false},"repo":{"id":31016854,"node_id":"MDEwOlJlcG9zaXRvcnkzMTAxNjg1NA==","name":"CCTag","full_name":"alicevision/CCTag","private":false,"owner":{"login":"alicevision","id":9333123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMzMxMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9333123?v=4","gravatar_id":"","url":"https://api.github.com/users/alicevision","html_url":"https://github.com/alicevision","followers_url":"https://api.github.com/users/alicevision/followers","following_url":"https://api.github.com/users/alicevision/following{/other_user}","gists_url":"https://api.github.com/users/alicevision/gists{/gist_id}","starred_url":"https://api.github.com/users/alicevision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicevision/subscriptions","organizations_url":"https://api.github.com/users/alicevision/orgs","repos_url":"https://api.github.com/users/alicevision/repos","events_url":"https://api.github.com/users/alicevision/events{/privacy}","received_events_url":"https://api.github.com/users/alicevision/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alicevision/CCTag","description":"Detection of CCTag markers made up of concentric circles.","fork":false,"url":"https://api.github.com/repos/alicevision/CCTag","forks_url":"https://api.github.com/repos/alicevision/CCTag/forks","keys_url":"https://api.github.com/repos/alicevision/CCTag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alicevision/CCTag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alicevision/CCTag/teams","hooks_url":"https://api.github.com/repos/alicevision/CCTag/hooks","issue_events_url":"https://api.github.com/repos/alicevision/CCTag/issues/events{/number}","events_url":"https://api.github.com/repos/alicevision/CCTag/events","assignees_url":"https://api.github.com/repos/alicevision/CCTag/assignees{/user}","branches_url":"https://api.github.com/repos/alicevision/CCTag/branches{/branch}","tags_url":"https://api.github.com/repos/alicevision/CCTag/tags","blobs_url":"https://api.github.com/repos/alicevision/CCTag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alicevision/CCTag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alicevision/CCTag/git/refs{/sha}","trees_url":"https://api.github.com/repos/alicevision/CCTag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alicevision/CCTag/statuses/{sha}","languages_url":"https://api.github.com/repos/alicevision/CCTag/languages","stargazers_url":"https://api.github.com/repos/alicevision/CCTag/stargazers","contributors_url":"https://api.github.com/repos/alicevision/CCTag/contributors","subscribers_url":"https://api.github.com/repos/alicevision/CCTag/subscribers","subscription_url":"https://api.github.com/repos/alicevision/CCTag/subscription","commits_url":"https://api.github.com/repos/alicevision/CCTag/commits{/sha}","git_commits_url":"https://api.github.com/repos/alicevision/CCTag/git/commits{/sha}","comments_url":"https://api.github.com/repos/alicevision/CCTag/comments{/number}","issue_comment_url":"https://api.github.com/repos/alicevision/CCTag/issues/comments{/number}","contents_url":"https://api.github.com/repos/alicevision/CCTag/contents/{+path}","compare_url":"https://api.github.com/repos/alicevision/CCTag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alicevision/CCTag/merges","archive_url":"https://api.github.com/repos/alicevision/CCTag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alicevision/CCTag/downloads","issues_url":"https://api.github.com/repos/alicevision/CCTag/issues{/number}","pulls_url":"https://api.github.com/repos/alicevision/CCTag/pulls{/number}","milestones_url":"https://api.github.com/repos/alicevision/CCTag/milestones{/number}","notifications_url":"https://api.github.com/repos/alicevision/CCTag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alicevision/CCTag/labels{/name}","releases_url":"https://api.github.com/repos/alicevision/CCTag/releases{/id}","deployments_url":"https://api.github.com/repos/alicevision/CCTag/deployments","created_at":"2015-02-19T13:41:26Z","updated_at":"2018-12-12T01:43:51Z","pushed_at":"2018-12-10T16:37:47Z","git_url":"git://github.com/alicevision/CCTag.git","ssh_url":"git@github.com:alicevision/CCTag.git","clone_url":"https://github.com/alicevision/CCTag.git","svn_url":"https://github.com/alicevision/CCTag","homepage":"http://alicevision.github.io","size":32327,"stargazers_count":62,"watchers_count":62,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":18,"open_issues":14,"watchers":62,"default_branch":"develop"}},"base":{"label":"alicevision:develop","ref":"develop","sha":"9e70d0f9fa2cb19177c1cdc412574497f9efcd3c","user":{"login":"alicevision","id":9333123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMzMxMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9333123?v=4","gravatar_id":"","url":"https://api.github.com/users/alicevision","html_url":"https://github.com/alicevision","followers_url":"https://api.github.com/users/alicevision/followers","following_url":"https://api.github.com/users/alicevision/following{/other_user}","gists_url":"https://api.github.com/users/alicevision/gists{/gist_id}","starred_url":"https://api.github.com/users/alicevision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicevision/subscriptions","organizations_url":"https://api.github.com/users/alicevision/orgs","repos_url":"https://api.github.com/users/alicevision/repos","events_url":"https://api.github.com/users/alicevision/events{/privacy}","received_events_url":"https://api.github.com/users/alicevision/received_events","type":"Organization","site_admin":false},"repo":{"id":31016854,"node_id":"MDEwOlJlcG9zaXRvcnkzMTAxNjg1NA==","name":"CCTag","full_name":"alicevision/CCTag","private":false,"owner":{"login":"alicevision","id":9333123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMzMxMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9333123?v=4","gravatar_id":"","url":"https://api.github.com/users/alicevision","html_url":"https://github.com/alicevision","followers_url":"https://api.github.com/users/alicevision/followers","following_url":"https://api.github.com/users/alicevision/following{/other_user}","gists_url":"https://api.github.com/users/alicevision/gists{/gist_id}","starred_url":"https://api.github.com/users/alicevision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicevision/subscriptions","organizations_url":"https://api.github.com/users/alicevision/orgs","repos_url":"https://api.github.com/users/alicevision/repos","events_url":"https://api.github.com/users/alicevision/events{/privacy}","received_events_url":"https://api.github.com/users/alicevision/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alicevision/CCTag","description":"Detection of CCTag markers made up of concentric circles.","fork":false,"url":"https://api.github.com/repos/alicevision/CCTag","forks_url":"https://api.github.com/repos/alicevision/CCTag/forks","keys_url":"https://api.github.com/repos/alicevision/CCTag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alicevision/CCTag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alicevision/CCTag/teams","hooks_url":"https://api.github.com/repos/alicevision/CCTag/hooks","issue_events_url":"https://api.github.com/repos/alicevision/CCTag/issues/events{/number}","events_url":"https://api.github.com/repos/alicevision/CCTag/events","assignees_url":"https://api.github.com/repos/alicevision/CCTag/assignees{/user}","branches_url":"https://api.github.com/repos/alicevision/CCTag/branches{/branch}","tags_url":"https://api.github.com/repos/alicevision/CCTag/tags","blobs_url":"https://api.github.com/repos/alicevision/CCTag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alicevision/CCTag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alicevision/CCTag/git/refs{/sha}","trees_url":"https://api.github.com/repos/alicevision/CCTag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alicevision/CCTag/statuses/{sha}","languages_url":"https://api.github.com/repos/alicevision/CCTag/languages","stargazers_url":"https://api.github.com/repos/alicevision/CCTag/stargazers","contributors_url":"https://api.github.com/repos/alicevision/CCTag/contributors","subscribers_url":"https://api.github.com/repos/alicevision/CCTag/subscribers","subscription_url":"https://api.github.com/repos/alicevision/CCTag/subscription","commits_url":"https://api.github.com/repos/alicevision/CCTag/commits{/sha}","git_commits_url":"https://api.github.com/repos/alicevision/CCTag/git/commits{/sha}","comments_url":"https://api.github.com/repos/alicevision/CCTag/comments{/number}","issue_comment_url":"https://api.github.com/repos/alicevision/CCTag/issues/comments{/number}","contents_url":"https://api.github.com/repos/alicevision/CCTag/contents/{+path}","compare_url":"https://api.github.com/repos/alicevision/CCTag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alicevision/CCTag/merges","archive_url":"https://api.github.com/repos/alicevision/CCTag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alicevision/CCTag/downloads","issues_url":"https://api.github.com/repos/alicevision/CCTag/issues{/number}","pulls_url":"https://api.github.com/repos/alicevision/CCTag/pulls{/number}","milestones_url":"https://api.github.com/repos/alicevision/CCTag/milestones{/number}","notifications_url":"https://api.github.com/repos/alicevision/CCTag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alicevision/CCTag/labels{/name}","releases_url":"https://api.github.com/repos/alicevision/CCTag/releases{/id}","deployments_url":"https://api.github.com/repos/alicevision/CCTag/deployments","created_at":"2015-02-19T13:41:26Z","updated_at":"2018-12-12T01:43:51Z","pushed_at":"2018-12-10T16:37:47Z","git_url":"git://github.com/alicevision/CCTag.git","ssh_url":"git@github.com:alicevision/CCTag.git","clone_url":"https://github.com/alicevision/CCTag.git","svn_url":"https://github.com/alicevision/CCTag","homepage":"http://alicevision.github.io","size":32327,"stargazers_count":62,"watchers_count":62,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":18,"open_issues":14,"watchers":62,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/alicevision/CCTag/pulls/95"},"html":{"href":"https://github.com/alicevision/CCTag/pull/95"},"issue":{"href":"https://api.github.com/repos/alicevision/CCTag/issues/95"},"comments":{"href":"https://api.github.com/repos/alicevision/CCTag/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/alicevision/CCTag/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/alicevision/CCTag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alicevision/CCTag/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/alicevision/CCTag/statuses/34c95cdd9fdd396014d909ed176857eeb928724f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fabiencastan"}}