{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/comments/212792085","pull_request_review_id":149501655,"id":212792085,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjc5MjA4NQ==","diff_hunk":"@@ -20,20 +20,28 @@\n namespace Confluent.Kafka\n {\n     /// <summary>\n-    ///     Represents the low and high watermark offsets of\n-    ///     a Kafka topic/partition.\n+    ///     Represents the low and high watermark offsets of a Kafka \n+    ///     topic/partition.\n     /// </summary>\n+    /// <remarks>\n+    ///     You can identify a partition that has not yet been written\n+    ///     to by checking if the high watermark equals 0.\n+    /// </remarks>\n     public class WatermarkOffsets\n     {\n         /// <summary>\n         ///     Initializes a new instance of the WatermarkOffsets class\n         ///     with the specified offsets.\n         /// </summary>\n         /// <param name=\"low\">\n-        ///     The offset of the earlist message in the topic/partition.\n+        ///     The offset of the earlist message in the topic/partition. If \n+        ///     no messages have been written to the topic, the low watermark","path":"src/Confluent.Kafka/WatermarkOffsets.cs","position":22,"original_position":22,"commit_id":"eaf9018f182f3bd7048e1c637211e87af7da7cb5","original_commit_id":"eaf9018f182f3bd7048e1c637211e87af7da7cb5","user":{"login":"edenhill","id":524990,"node_id":"MDQ6VXNlcjUyNDk5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/524990?v=4","gravatar_id":"","url":"https://api.github.com/users/edenhill","html_url":"https://github.com/edenhill","followers_url":"https://api.github.com/users/edenhill/followers","following_url":"https://api.github.com/users/edenhill/following{/other_user}","gists_url":"https://api.github.com/users/edenhill/gists{/gist_id}","starred_url":"https://api.github.com/users/edenhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenhill/subscriptions","organizations_url":"https://api.github.com/users/edenhill/orgs","repos_url":"https://api.github.com/users/edenhill/repos","events_url":"https://api.github.com/users/edenhill/events{/privacy}","received_events_url":"https://api.github.com/users/edenhill/received_events","type":"User","site_admin":false},"body":"you mean high","created_at":"2018-08-25T07:53:52Z","updated_at":"2018-08-25T07:56:29Z","html_url":"https://github.com/confluentinc/confluent-kafka-dotnet/pull/582#discussion_r212792085","pull_request_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/582","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/comments/212792085"},"html":{"href":"https://github.com/confluentinc/confluent-kafka-dotnet/pull/582#discussion_r212792085"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/582"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/582","id":206502577,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTAyNTc3","html_url":"https://github.com/confluentinc/confluent-kafka-dotnet/pull/582","diff_url":"https://github.com/confluentinc/confluent-kafka-dotnet/pull/582.diff","patch_url":"https://github.com/confluentinc/confluent-kafka-dotnet/pull/582.patch","issue_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/582","number":582,"state":"open","locked":false,"title":"1.0 API","user":{"login":"mhowlett","id":19174,"node_id":"MDQ6VXNlcjE5MTc0","avatar_url":"https://avatars2.githubusercontent.com/u/19174?v=4","gravatar_id":"","url":"https://api.github.com/users/mhowlett","html_url":"https://github.com/mhowlett","followers_url":"https://api.github.com/users/mhowlett/followers","following_url":"https://api.github.com/users/mhowlett/following{/other_user}","gists_url":"https://api.github.com/users/mhowlett/gists{/gist_id}","starred_url":"https://api.github.com/users/mhowlett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhowlett/subscriptions","organizations_url":"https://api.github.com/users/mhowlett/orgs","repos_url":"https://api.github.com/users/mhowlett/repos","events_url":"https://api.github.com/users/mhowlett/events{/privacy}","received_events_url":"https://api.github.com/users/mhowlett/received_events","type":"User","site_admin":false},"body":"@edenhill - it's about time we got this on master! have at it.","created_at":"2018-08-06T20:05:32Z","updated_at":"2018-08-25T07:56:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fd8b618b49e26b3cccc3d5dbf018c1d0fde4412","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/582/commits","review_comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/582/comments","review_comment_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/582/comments","statuses_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/statuses/eaf9018f182f3bd7048e1c637211e87af7da7cb5","head":{"label":"confluentinc:1.0-experimental","ref":"1.0-experimental","sha":"eaf9018f182f3bd7048e1c637211e87af7da7cb5","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":72554578,"node_id":"MDEwOlJlcG9zaXRvcnk3MjU1NDU3OA==","name":"confluent-kafka-dotnet","full_name":"confluentinc/confluent-kafka-dotnet","owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/confluent-kafka-dotnet","description":"Confluent's Apache Kafka .NET client","fork":false,"url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet","forks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/forks","keys_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/teams","hooks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/events","assignees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/tags","blobs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/languages","stargazers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/subscription","commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/merges","archive_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/downloads","issues_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/deployments","created_at":"2016-11-01T16:25:52Z","updated_at":"2018-08-24T22:08:48Z","pushed_at":"2018-08-24T21:48:44Z","git_url":"git://github.com/confluentinc/confluent-kafka-dotnet.git","ssh_url":"git@github.com:confluentinc/confluent-kafka-dotnet.git","clone_url":"https://github.com/confluentinc/confluent-kafka-dotnet.git","svn_url":"https://github.com/confluentinc/confluent-kafka-dotnet","homepage":"https://docs.confluent.io/current/clients/confluent-kafka-dotnet/api/Confluent.Kafka.html","size":1517,"stargazers_count":619,"watchers_count":619,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":188,"open_issues":54,"watchers":619,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"0a66d2697704d0351211d1fed63ebeb73d5ab2b1","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":72554578,"node_id":"MDEwOlJlcG9zaXRvcnk3MjU1NDU3OA==","name":"confluent-kafka-dotnet","full_name":"confluentinc/confluent-kafka-dotnet","owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/confluent-kafka-dotnet","description":"Confluent's Apache Kafka .NET client","fork":false,"url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet","forks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/forks","keys_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/teams","hooks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/events","assignees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/tags","blobs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/languages","stargazers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/subscription","commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/merges","archive_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/downloads","issues_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/deployments","created_at":"2016-11-01T16:25:52Z","updated_at":"2018-08-24T22:08:48Z","pushed_at":"2018-08-24T21:48:44Z","git_url":"git://github.com/confluentinc/confluent-kafka-dotnet.git","ssh_url":"git@github.com:confluentinc/confluent-kafka-dotnet.git","clone_url":"https://github.com/confluentinc/confluent-kafka-dotnet.git","svn_url":"https://github.com/confluentinc/confluent-kafka-dotnet","homepage":"https://docs.confluent.io/current/clients/confluent-kafka-dotnet/api/Confluent.Kafka.html","size":1517,"stargazers_count":619,"watchers_count":619,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":188,"open_issues":54,"watchers":619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/582"},"html":{"href":"https://github.com/confluentinc/confluent-kafka-dotnet/pull/582"},"issue":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/582"},"comments":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/582/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/582/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/582/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/statuses/eaf9018f182f3bd7048e1c637211e87af7da7cb5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"edenhill"}}