{"action":"created","comment":{"url":"https://api.github.com/repos/shravan97/PyTDF/pulls/comments/193774597","pull_request_review_id":126815554,"id":193774597,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mzc3NDU5Nw==","diff_hunk":"@@ -2,4 +2,22 @@\n from .Node import Node\n from .Proxy import Proxy\n from .Operation import Operation\n-from .CallableGenerator import CallableGenerator\n\\ No newline at end of file\n+from .CallableGenerator import CallableGenerator\n+from .backend import Local, Dist\n+\n+Proxy.backend = Local({})","path":"PyRDF/__init__.py","position":9,"original_position":9,"commit_id":"46c248f462b80aa4253b7250bf188d8a35fbad14","original_commit_id":"46c248f462b80aa4253b7250bf188d8a35fbad14","user":{"login":"shravan97","id":10980285,"node_id":"MDQ6VXNlcjEwOTgwMjg1","avatar_url":"https://avatars1.githubusercontent.com/u/10980285?v=4","gravatar_id":"","url":"https://api.github.com/users/shravan97","html_url":"https://github.com/shravan97","followers_url":"https://api.github.com/users/shravan97/followers","following_url":"https://api.github.com/users/shravan97/following{/other_user}","gists_url":"https://api.github.com/users/shravan97/gists{/gist_id}","starred_url":"https://api.github.com/users/shravan97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shravan97/subscriptions","organizations_url":"https://api.github.com/users/shravan97/orgs","repos_url":"https://api.github.com/users/shravan97/repos","events_url":"https://api.github.com/users/shravan97/events{/privacy}","received_events_url":"https://api.github.com/users/shravan97/received_events","type":"User","site_admin":false},"body":"@etejedor , sounds good. I'll make these changes 👍 ","created_at":"2018-06-07T14:48:03Z","updated_at":"2018-06-07T14:48:04Z","html_url":"https://github.com/shravan97/PyTDF/pull/17#discussion_r193774597","pull_request_url":"https://api.github.com/repos/shravan97/PyTDF/pulls/17","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/shravan97/PyTDF/pulls/comments/193774597"},"html":{"href":"https://github.com/shravan97/PyTDF/pull/17#discussion_r193774597"},"pull_request":{"href":"https://api.github.com/repos/shravan97/PyTDF/pulls/17"}},"in_reply_to_id":193768199},"pull_request":{"url":"https://api.github.com/repos/shravan97/PyTDF/pulls/17","id":193019244,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDE5MjQ0","html_url":"https://github.com/shravan97/PyTDF/pull/17","diff_url":"https://github.com/shravan97/PyTDF/pull/17.diff","patch_url":"https://github.com/shravan97/PyTDF/pull/17.patch","issue_url":"https://api.github.com/repos/shravan97/PyTDF/issues/17","number":17,"state":"open","locked":false,"title":"Add backend selection Interface with tests, Fixes #11","user":{"login":"shravan97","id":10980285,"node_id":"MDQ6VXNlcjEwOTgwMjg1","avatar_url":"https://avatars1.githubusercontent.com/u/10980285?v=4","gravatar_id":"","url":"https://api.github.com/users/shravan97","html_url":"https://github.com/shravan97","followers_url":"https://api.github.com/users/shravan97/followers","following_url":"https://api.github.com/users/shravan97/following{/other_user}","gists_url":"https://api.github.com/users/shravan97/gists{/gist_id}","starred_url":"https://api.github.com/users/shravan97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shravan97/subscriptions","organizations_url":"https://api.github.com/users/shravan97/orgs","repos_url":"https://api.github.com/users/shravan97/repos","events_url":"https://api.github.com/users/shravan97/events{/privacy}","received_events_url":"https://api.github.com/users/shravan97/received_events","type":"User","site_admin":false},"body":"Features in this PR : \r\n* Define the `use` function to let the user select appropriate backend with config\r\n* Define base class `Backend` class inside `Backend.py` \r\n* Implement `Local` child class and `Dist` child class\r\n* Introduce a new class member `backend`, which is set inside the `use` function \r\n* Call the `execute` function using the `Backend` class instance by passing an instance of `CallableGenerator`\r\n* Write tests for `use` function","created_at":"2018-06-06T13:47:12Z","updated_at":"2018-06-07T14:48:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4081ffcbce24aa4a0afd9a2a4ff4c6f7e7dd7b44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shravan97/PyTDF/pulls/17/commits","review_comments_url":"https://api.github.com/repos/shravan97/PyTDF/pulls/17/comments","review_comment_url":"https://api.github.com/repos/shravan97/PyTDF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shravan97/PyTDF/issues/17/comments","statuses_url":"https://api.github.com/repos/shravan97/PyTDF/statuses/46c248f462b80aa4253b7250bf188d8a35fbad14","head":{"label":"shravan97:backend_select1","ref":"backend_select1","sha":"46c248f462b80aa4253b7250bf188d8a35fbad14","user":{"login":"shravan97","id":10980285,"node_id":"MDQ6VXNlcjEwOTgwMjg1","avatar_url":"https://avatars1.githubusercontent.com/u/10980285?v=4","gravatar_id":"","url":"https://api.github.com/users/shravan97","html_url":"https://github.com/shravan97","followers_url":"https://api.github.com/users/shravan97/followers","following_url":"https://api.github.com/users/shravan97/following{/other_user}","gists_url":"https://api.github.com/users/shravan97/gists{/gist_id}","starred_url":"https://api.github.com/users/shravan97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shravan97/subscriptions","organizations_url":"https://api.github.com/users/shravan97/orgs","repos_url":"https://api.github.com/users/shravan97/repos","events_url":"https://api.github.com/users/shravan97/events{/privacy}","received_events_url":"https://api.github.com/users/shravan97/received_events","type":"User","site_admin":false},"repo":{"id":133717643,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM3MTc2NDM=","name":"PyTDF","full_name":"shravan97/PyTDF","owner":{"login":"shravan97","id":10980285,"node_id":"MDQ6VXNlcjEwOTgwMjg1","avatar_url":"https://avatars1.githubusercontent.com/u/10980285?v=4","gravatar_id":"","url":"https://api.github.com/users/shravan97","html_url":"https://github.com/shravan97","followers_url":"https://api.github.com/users/shravan97/followers","following_url":"https://api.github.com/users/shravan97/following{/other_user}","gists_url":"https://api.github.com/users/shravan97/gists{/gist_id}","starred_url":"https://api.github.com/users/shravan97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shravan97/subscriptions","organizations_url":"https://api.github.com/users/shravan97/orgs","repos_url":"https://api.github.com/users/shravan97/repos","events_url":"https://api.github.com/users/shravan97/events{/privacy}","received_events_url":"https://api.github.com/users/shravan97/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shravan97/PyTDF","description":"Python Library for doing TDataFrame Analysis","fork":false,"url":"https://api.github.com/repos/shravan97/PyTDF","forks_url":"https://api.github.com/repos/shravan97/PyTDF/forks","keys_url":"https://api.github.com/repos/shravan97/PyTDF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shravan97/PyTDF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shravan97/PyTDF/teams","hooks_url":"https://api.github.com/repos/shravan97/PyTDF/hooks","issue_events_url":"https://api.github.com/repos/shravan97/PyTDF/issues/events{/number}","events_url":"https://api.github.com/repos/shravan97/PyTDF/events","assignees_url":"https://api.github.com/repos/shravan97/PyTDF/assignees{/user}","branches_url":"https://api.github.com/repos/shravan97/PyTDF/branches{/branch}","tags_url":"https://api.github.com/repos/shravan97/PyTDF/tags","blobs_url":"https://api.github.com/repos/shravan97/PyTDF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shravan97/PyTDF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shravan97/PyTDF/git/refs{/sha}","trees_url":"https://api.github.com/repos/shravan97/PyTDF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shravan97/PyTDF/statuses/{sha}","languages_url":"https://api.github.com/repos/shravan97/PyTDF/languages","stargazers_url":"https://api.github.com/repos/shravan97/PyTDF/stargazers","contributors_url":"https://api.github.com/repos/shravan97/PyTDF/contributors","subscribers_url":"https://api.github.com/repos/shravan97/PyTDF/subscribers","subscription_url":"https://api.github.com/repos/shravan97/PyTDF/subscription","commits_url":"https://api.github.com/repos/shravan97/PyTDF/commits{/sha}","git_commits_url":"https://api.github.com/repos/shravan97/PyTDF/git/commits{/sha}","comments_url":"https://api.github.com/repos/shravan97/PyTDF/comments{/number}","issue_comment_url":"https://api.github.com/repos/shravan97/PyTDF/issues/comments{/number}","contents_url":"https://api.github.com/repos/shravan97/PyTDF/contents/{+path}","compare_url":"https://api.github.com/repos/shravan97/PyTDF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shravan97/PyTDF/merges","archive_url":"https://api.github.com/repos/shravan97/PyTDF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shravan97/PyTDF/downloads","issues_url":"https://api.github.com/repos/shravan97/PyTDF/issues{/number}","pulls_url":"https://api.github.com/repos/shravan97/PyTDF/pulls{/number}","milestones_url":"https://api.github.com/repos/shravan97/PyTDF/milestones{/number}","notifications_url":"https://api.github.com/repos/shravan97/PyTDF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shravan97/PyTDF/labels{/name}","releases_url":"https://api.github.com/repos/shravan97/PyTDF/releases{/id}","deployments_url":"https://api.github.com/repos/shravan97/PyTDF/deployments","created_at":"2018-05-16T20:08:04Z","updated_at":"2018-06-07T14:22:44Z","pushed_at":"2018-06-07T14:22:42Z","git_url":"git://github.com/shravan97/PyTDF.git","ssh_url":"git@github.com:shravan97/PyTDF.git","clone_url":"https://github.com/shravan97/PyTDF.git","svn_url":"https://github.com/shravan97/PyTDF","homepage":null,"size":73,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"shravan97:master","ref":"master","sha":"5cb1c061f3edaab67b745208970ceab7ec00d2c6","user":{"login":"shravan97","id":10980285,"node_id":"MDQ6VXNlcjEwOTgwMjg1","avatar_url":"https://avatars1.githubusercontent.com/u/10980285?v=4","gravatar_id":"","url":"https://api.github.com/users/shravan97","html_url":"https://github.com/shravan97","followers_url":"https://api.github.com/users/shravan97/followers","following_url":"https://api.github.com/users/shravan97/following{/other_user}","gists_url":"https://api.github.com/users/shravan97/gists{/gist_id}","starred_url":"https://api.github.com/users/shravan97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shravan97/subscriptions","organizations_url":"https://api.github.com/users/shravan97/orgs","repos_url":"https://api.github.com/users/shravan97/repos","events_url":"https://api.github.com/users/shravan97/events{/privacy}","received_events_url":"https://api.github.com/users/shravan97/received_events","type":"User","site_admin":false},"repo":{"id":133717643,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM3MTc2NDM=","name":"PyTDF","full_name":"shravan97/PyTDF","owner":{"login":"shravan97","id":10980285,"node_id":"MDQ6VXNlcjEwOTgwMjg1","avatar_url":"https://avatars1.githubusercontent.com/u/10980285?v=4","gravatar_id":"","url":"https://api.github.com/users/shravan97","html_url":"https://github.com/shravan97","followers_url":"https://api.github.com/users/shravan97/followers","following_url":"https://api.github.com/users/shravan97/following{/other_user}","gists_url":"https://api.github.com/users/shravan97/gists{/gist_id}","starred_url":"https://api.github.com/users/shravan97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shravan97/subscriptions","organizations_url":"https://api.github.com/users/shravan97/orgs","repos_url":"https://api.github.com/users/shravan97/repos","events_url":"https://api.github.com/users/shravan97/events{/privacy}","received_events_url":"https://api.github.com/users/shravan97/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shravan97/PyTDF","description":"Python Library for doing TDataFrame Analysis","fork":false,"url":"https://api.github.com/repos/shravan97/PyTDF","forks_url":"https://api.github.com/repos/shravan97/PyTDF/forks","keys_url":"https://api.github.com/repos/shravan97/PyTDF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shravan97/PyTDF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shravan97/PyTDF/teams","hooks_url":"https://api.github.com/repos/shravan97/PyTDF/hooks","issue_events_url":"https://api.github.com/repos/shravan97/PyTDF/issues/events{/number}","events_url":"https://api.github.com/repos/shravan97/PyTDF/events","assignees_url":"https://api.github.com/repos/shravan97/PyTDF/assignees{/user}","branches_url":"https://api.github.com/repos/shravan97/PyTDF/branches{/branch}","tags_url":"https://api.github.com/repos/shravan97/PyTDF/tags","blobs_url":"https://api.github.com/repos/shravan97/PyTDF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shravan97/PyTDF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shravan97/PyTDF/git/refs{/sha}","trees_url":"https://api.github.com/repos/shravan97/PyTDF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shravan97/PyTDF/statuses/{sha}","languages_url":"https://api.github.com/repos/shravan97/PyTDF/languages","stargazers_url":"https://api.github.com/repos/shravan97/PyTDF/stargazers","contributors_url":"https://api.github.com/repos/shravan97/PyTDF/contributors","subscribers_url":"https://api.github.com/repos/shravan97/PyTDF/subscribers","subscription_url":"https://api.github.com/repos/shravan97/PyTDF/subscription","commits_url":"https://api.github.com/repos/shravan97/PyTDF/commits{/sha}","git_commits_url":"https://api.github.com/repos/shravan97/PyTDF/git/commits{/sha}","comments_url":"https://api.github.com/repos/shravan97/PyTDF/comments{/number}","issue_comment_url":"https://api.github.com/repos/shravan97/PyTDF/issues/comments{/number}","contents_url":"https://api.github.com/repos/shravan97/PyTDF/contents/{+path}","compare_url":"https://api.github.com/repos/shravan97/PyTDF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shravan97/PyTDF/merges","archive_url":"https://api.github.com/repos/shravan97/PyTDF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shravan97/PyTDF/downloads","issues_url":"https://api.github.com/repos/shravan97/PyTDF/issues{/number}","pulls_url":"https://api.github.com/repos/shravan97/PyTDF/pulls{/number}","milestones_url":"https://api.github.com/repos/shravan97/PyTDF/milestones{/number}","notifications_url":"https://api.github.com/repos/shravan97/PyTDF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shravan97/PyTDF/labels{/name}","releases_url":"https://api.github.com/repos/shravan97/PyTDF/releases{/id}","deployments_url":"https://api.github.com/repos/shravan97/PyTDF/deployments","created_at":"2018-05-16T20:08:04Z","updated_at":"2018-06-07T14:22:44Z","pushed_at":"2018-06-07T14:22:42Z","git_url":"git://github.com/shravan97/PyTDF.git","ssh_url":"git@github.com:shravan97/PyTDF.git","clone_url":"https://github.com/shravan97/PyTDF.git","svn_url":"https://github.com/shravan97/PyTDF","homepage":null,"size":73,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shravan97/PyTDF/pulls/17"},"html":{"href":"https://github.com/shravan97/PyTDF/pull/17"},"issue":{"href":"https://api.github.com/repos/shravan97/PyTDF/issues/17"},"comments":{"href":"https://api.github.com/repos/shravan97/PyTDF/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/shravan97/PyTDF/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/shravan97/PyTDF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shravan97/PyTDF/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/shravan97/PyTDF/statuses/46c248f462b80aa4253b7250bf188d8a35fbad14"}},"author_association":"OWNER"}}
{"actor":{"display_login":"shravan97"}}