{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pontoon/pulls/comments/169821138","pull_request_review_id":98410570,"id":169821138,"diff_hunk":"@@ -0,0 +1 @@\n+{}","path":".cache/v/cache/lastfailed","position":1,"original_position":1,"commit_id":"0d38a8e6c4b9b687760058c4774636ea5a8fd02b","original_commit_id":"0d38a8e6c4b9b687760058c4774636ea5a8fd02b","user":{"login":"jotes","id":8784972,"avatar_url":"https://avatars2.githubusercontent.com/u/8784972?v=4","gravatar_id":"","url":"https://api.github.com/users/jotes","html_url":"https://github.com/jotes","followers_url":"https://api.github.com/users/jotes/followers","following_url":"https://api.github.com/users/jotes/following{/other_user}","gists_url":"https://api.github.com/users/jotes/gists{/gist_id}","starred_url":"https://api.github.com/users/jotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotes/subscriptions","organizations_url":"https://api.github.com/users/jotes/orgs","repos_url":"https://api.github.com/users/jotes/repos","events_url":"https://api.github.com/users/jotes/events{/privacy}","received_events_url":"https://api.github.com/users/jotes/received_events","type":"User","site_admin":false},"body":"I feel this particular file should be:\r\n* removed\r\n* `.cache` should be added to gitignore if any of our tools generate contents in such path","created_at":"2018-02-22T00:17:46Z","updated_at":"2018-02-22T00:54:29Z","html_url":"https://github.com/mozilla/pontoon/pull/864#discussion_r169821138","pull_request_url":"https://api.github.com/repos/mozilla/pontoon/pulls/864","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/comments/169821138"},"html":{"href":"https://github.com/mozilla/pontoon/pull/864#discussion_r169821138"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/864"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/pontoon/pulls/864","id":170537998,"html_url":"https://github.com/mozilla/pontoon/pull/864","diff_url":"https://github.com/mozilla/pontoon/pull/864.diff","patch_url":"https://github.com/mozilla/pontoon/pull/864.patch","issue_url":"https://api.github.com/repos/mozilla/pontoon/issues/864","number":864,"state":"open","locked":false,"title":"[WIP]Django1.11: Fixed pontoon/db/tests/test_lookups.py test failure.","user":{"login":"VishalCR7","id":24241258,"avatar_url":"https://avatars1.githubusercontent.com/u/24241258?v=4","gravatar_id":"","url":"https://api.github.com/users/VishalCR7","html_url":"https://github.com/VishalCR7","followers_url":"https://api.github.com/users/VishalCR7/followers","following_url":"https://api.github.com/users/VishalCR7/following{/other_user}","gists_url":"https://api.github.com/users/VishalCR7/gists{/gist_id}","starred_url":"https://api.github.com/users/VishalCR7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VishalCR7/subscriptions","organizations_url":"https://api.github.com/users/VishalCR7/orgs","repos_url":"https://api.github.com/users/VishalCR7/repos","events_url":"https://api.github.com/users/VishalCR7/events{/privacy}","received_events_url":"https://api.github.com/users/VishalCR7/received_events","type":"User","site_admin":false},"body":"Upon running the tests with django 1.11 installed the only failure was while running `./manage.py test` which showed the failure : \r\n`FAIL: pontoon.db.tests.test_lookups:TestIContainsCollationLookup.test_collation_query\r\n  vi +60 pontoon/db/tests/test_lookups.py  # test_collation_query\r\n    assert_true(query_sql.endswith('WHERE UPPER(\"base_entity\".\"string\"::text COLLATE \"C\") '\r\nAssertionError: False is not true`\r\n\r\nFailure reason : change in sql query in django1.11 from \r\n`SELECT \"base_entity\".\"id\", \"base_entity\".\"resource_id\", \"base_entity\".\"string\", \"base_entity\".\"string_plural\", \"base_entity\".\"key\", \"base_entity\".\"comment\", \"base_entity\".\"date_created\", \"base_entity\".\"order\", \"base_entity\".\"source\", \"base_entity\".\"obsolete\" FROM \"base_entity\" WHERE UPPER(\"base_entity\".\"string\"::text COLLATE \"C\") LIKE UPPER(%s COLLATE \"C\")`\r\n\r\nto \r\n`SELECT \"base_entity\".\"id\", \"base_entity\".\"resource_id\", \"base_entity\".\"string\", \"base_entity\".\"string_plural\", \"base_entity\".\"key\", \"base_entity\".\"comment\", \"base_entity\".\"date_created\", \"base_entity\".\"order\", \"base_entity\".\"source\", \"base_entity\".\"obsolete\" FROM \"base_entity\" WHERE UPPER(\"base_entity\".\"string\") LIKE UPPER(%s COLLATE \"C\")`\r\n\r\nI have fixed and confirmed from the documentation if it works without collate added to string and theoretically it should work but didn't get to test it as the collations and database were limited.\r\n","created_at":"2018-02-21T17:30:33Z","updated_at":"2018-02-22T00:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea5e8785204b83ce456373cdfd5f64efcb9bc730","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pontoon/pulls/864/commits","review_comments_url":"https://api.github.com/repos/mozilla/pontoon/pulls/864/comments","review_comment_url":"https://api.github.com/repos/mozilla/pontoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pontoon/issues/864/comments","statuses_url":"https://api.github.com/repos/mozilla/pontoon/statuses/0d38a8e6c4b9b687760058c4774636ea5a8fd02b","head":{"label":"VishalCR7:django-111","ref":"django-111","sha":"0d38a8e6c4b9b687760058c4774636ea5a8fd02b","user":{"login":"VishalCR7","id":24241258,"avatar_url":"https://avatars1.githubusercontent.com/u/24241258?v=4","gravatar_id":"","url":"https://api.github.com/users/VishalCR7","html_url":"https://github.com/VishalCR7","followers_url":"https://api.github.com/users/VishalCR7/followers","following_url":"https://api.github.com/users/VishalCR7/following{/other_user}","gists_url":"https://api.github.com/users/VishalCR7/gists{/gist_id}","starred_url":"https://api.github.com/users/VishalCR7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VishalCR7/subscriptions","organizations_url":"https://api.github.com/users/VishalCR7/orgs","repos_url":"https://api.github.com/users/VishalCR7/repos","events_url":"https://api.github.com/users/VishalCR7/events{/privacy}","received_events_url":"https://api.github.com/users/VishalCR7/received_events","type":"User","site_admin":false},"repo":{"id":118479458,"name":"pontoon","full_name":"VishalCR7/pontoon","owner":{"login":"VishalCR7","id":24241258,"avatar_url":"https://avatars1.githubusercontent.com/u/24241258?v=4","gravatar_id":"","url":"https://api.github.com/users/VishalCR7","html_url":"https://github.com/VishalCR7","followers_url":"https://api.github.com/users/VishalCR7/followers","following_url":"https://api.github.com/users/VishalCR7/following{/other_user}","gists_url":"https://api.github.com/users/VishalCR7/gists{/gist_id}","starred_url":"https://api.github.com/users/VishalCR7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VishalCR7/subscriptions","organizations_url":"https://api.github.com/users/VishalCR7/orgs","repos_url":"https://api.github.com/users/VishalCR7/repos","events_url":"https://api.github.com/users/VishalCR7/events{/privacy}","received_events_url":"https://api.github.com/users/VishalCR7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VishalCR7/pontoon","description":"Localization tool used at Mozilla","fork":true,"url":"https://api.github.com/repos/VishalCR7/pontoon","forks_url":"https://api.github.com/repos/VishalCR7/pontoon/forks","keys_url":"https://api.github.com/repos/VishalCR7/pontoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VishalCR7/pontoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VishalCR7/pontoon/teams","hooks_url":"https://api.github.com/repos/VishalCR7/pontoon/hooks","issue_events_url":"https://api.github.com/repos/VishalCR7/pontoon/issues/events{/number}","events_url":"https://api.github.com/repos/VishalCR7/pontoon/events","assignees_url":"https://api.github.com/repos/VishalCR7/pontoon/assignees{/user}","branches_url":"https://api.github.com/repos/VishalCR7/pontoon/branches{/branch}","tags_url":"https://api.github.com/repos/VishalCR7/pontoon/tags","blobs_url":"https://api.github.com/repos/VishalCR7/pontoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VishalCR7/pontoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VishalCR7/pontoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/VishalCR7/pontoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VishalCR7/pontoon/statuses/{sha}","languages_url":"https://api.github.com/repos/VishalCR7/pontoon/languages","stargazers_url":"https://api.github.com/repos/VishalCR7/pontoon/stargazers","contributors_url":"https://api.github.com/repos/VishalCR7/pontoon/contributors","subscribers_url":"https://api.github.com/repos/VishalCR7/pontoon/subscribers","subscription_url":"https://api.github.com/repos/VishalCR7/pontoon/subscription","commits_url":"https://api.github.com/repos/VishalCR7/pontoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/VishalCR7/pontoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/VishalCR7/pontoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/VishalCR7/pontoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/VishalCR7/pontoon/contents/{+path}","compare_url":"https://api.github.com/repos/VishalCR7/pontoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VishalCR7/pontoon/merges","archive_url":"https://api.github.com/repos/VishalCR7/pontoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VishalCR7/pontoon/downloads","issues_url":"https://api.github.com/repos/VishalCR7/pontoon/issues{/number}","pulls_url":"https://api.github.com/repos/VishalCR7/pontoon/pulls{/number}","milestones_url":"https://api.github.com/repos/VishalCR7/pontoon/milestones{/number}","notifications_url":"https://api.github.com/repos/VishalCR7/pontoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VishalCR7/pontoon/labels{/name}","releases_url":"https://api.github.com/repos/VishalCR7/pontoon/releases{/id}","deployments_url":"https://api.github.com/repos/VishalCR7/pontoon/deployments","created_at":"2018-01-22T15:58:04Z","updated_at":"2018-01-22T15:58:07Z","pushed_at":"2018-02-21T22:52:38Z","git_url":"git://github.com/VishalCR7/pontoon.git","ssh_url":"git@github.com:VishalCR7/pontoon.git","clone_url":"https://github.com/VishalCR7/pontoon.git","svn_url":"https://github.com/VishalCR7/pontoon","homepage":"https://pontoon.mozilla.org/","size":28957,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"4607f95d7153aeb3ea4caa44f5826fe4d4384e1e","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1385890,"name":"pontoon","full_name":"mozilla/pontoon","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pontoon","description":"Localization tool used at Mozilla","fork":false,"url":"https://api.github.com/repos/mozilla/pontoon","forks_url":"https://api.github.com/repos/mozilla/pontoon/forks","keys_url":"https://api.github.com/repos/mozilla/pontoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pontoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pontoon/teams","hooks_url":"https://api.github.com/repos/mozilla/pontoon/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pontoon/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pontoon/events","assignees_url":"https://api.github.com/repos/mozilla/pontoon/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pontoon/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pontoon/tags","blobs_url":"https://api.github.com/repos/mozilla/pontoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pontoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pontoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pontoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pontoon/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pontoon/languages","stargazers_url":"https://api.github.com/repos/mozilla/pontoon/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pontoon/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pontoon/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pontoon/subscription","commits_url":"https://api.github.com/repos/mozilla/pontoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pontoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pontoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pontoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pontoon/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pontoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pontoon/merges","archive_url":"https://api.github.com/repos/mozilla/pontoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pontoon/downloads","issues_url":"https://api.github.com/repos/mozilla/pontoon/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pontoon/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pontoon/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pontoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pontoon/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pontoon/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/pontoon/deployments","created_at":"2011-02-19T11:25:51Z","updated_at":"2018-02-20T21:23:20Z","pushed_at":"2018-02-21T17:30:34Z","git_url":"git://github.com/mozilla/pontoon.git","ssh_url":"git@github.com:mozilla/pontoon.git","clone_url":"https://github.com/mozilla/pontoon.git","svn_url":"https://github.com/mozilla/pontoon","homepage":"https://pontoon.mozilla.org/","size":22153,"stargazers_count":356,"watchers_count":356,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":108,"open_issues":19,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/864"},"html":{"href":"https://github.com/mozilla/pontoon/pull/864"},"issue":{"href":"https://api.github.com/repos/mozilla/pontoon/issues/864"},"comments":{"href":"https://api.github.com/repos/mozilla/pontoon/issues/864/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/864/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/864/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pontoon/statuses/0d38a8e6c4b9b687760058c4774636ea5a8fd02b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jotes"}}