{"action":"closed","number":63551,"pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/63551","id":218860099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4ODYwMDk5","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/63551","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/63551.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/63551.patch","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/63551","number":63551,"state":"closed","locked":false,"title":"LPS-83456 try 2","user":{"login":"arthurchan35","id":6461170,"node_id":"MDQ6VXNlcjY0NjExNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6461170?v=4","gravatar_id":"","url":"https://api.github.com/users/arthurchan35","html_url":"https://github.com/arthurchan35","followers_url":"https://api.github.com/users/arthurchan35/followers","following_url":"https://api.github.com/users/arthurchan35/following{/other_user}","gists_url":"https://api.github.com/users/arthurchan35/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurchan35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurchan35/subscriptions","organizations_url":"https://api.github.com/users/arthurchan35/orgs","repos_url":"https://api.github.com/users/arthurchan35/repos","events_url":"https://api.github.com/users/arthurchan35/events{/privacy}","received_events_url":"https://api.github.com/users/arthurchan35/received_events","type":"User","site_admin":false},"body":"From https://github.com/brianchandotcom/liferay-portal/pull/63522\r\n\r\nHi Brian,\r\nYou mentioned we want to throw generic PortalException. I am not sure you want it only in SettingsLocator* classes or everywhere.\r\nThis PR changes NoSuchPortletPreferencesException to PortalException  in all **SettingsLocator*** classes AND **portletPreferencesFactory*** classes..\r\n\r\nThe other PR(LPS-83456 try 1 https://github.com/brianchandotcom/liferay-portal/pull/63550) I sent to you does it only in **SettingsLocator*** classes","created_at":"2018-09-28T05:49:57Z","updated_at":"2018-10-01T03:27:36Z","closed_at":"2018-10-01T03:27:36Z","merged_at":null,"merge_commit_sha":"69fe7ff07141ede25a54f68f11894f7562e86ba6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":889167757,"node_id":"MDU6TGFiZWw4ODkxNjc3NTc=","url":"https://api.github.com/repos/brianchandotcom/liferay-portal/labels/ci:test:relevant%20-%20failure","name":"ci:test:relevant - failure","color":"fccdcc","default":false},{"id":867386954,"node_id":"MDU6TGFiZWw4NjczODY5NTQ=","url":"https://api.github.com/repos/brianchandotcom/liferay-portal/labels/ci:test:sf%20-%20success","name":"ci:test:sf - success","color":"c7e8cb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/63551/commits","review_comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/63551/comments","review_comment_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/63551/comments","statuses_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/8ed99a073de26bd43dd27d000923114a28b54415","head":{"label":"arthurchan35:LPS-83456-fix2","ref":"LPS-83456-fix2","sha":"8ed99a073de26bd43dd27d000923114a28b54415","user":{"login":"arthurchan35","id":6461170,"node_id":"MDQ6VXNlcjY0NjExNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6461170?v=4","gravatar_id":"","url":"https://api.github.com/users/arthurchan35","html_url":"https://github.com/arthurchan35","followers_url":"https://api.github.com/users/arthurchan35/followers","following_url":"https://api.github.com/users/arthurchan35/following{/other_user}","gists_url":"https://api.github.com/users/arthurchan35/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurchan35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurchan35/subscriptions","organizations_url":"https://api.github.com/users/arthurchan35/orgs","repos_url":"https://api.github.com/users/arthurchan35/repos","events_url":"https://api.github.com/users/arthurchan35/events{/privacy}","received_events_url":"https://api.github.com/users/arthurchan35/received_events","type":"User","site_admin":false},"repo":{"id":75140938,"node_id":"MDEwOlJlcG9zaXRvcnk3NTE0MDkzOA==","name":"liferay-portal","full_name":"arthurchan35/liferay-portal","private":false,"owner":{"login":"arthurchan35","id":6461170,"node_id":"MDQ6VXNlcjY0NjExNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6461170?v=4","gravatar_id":"","url":"https://api.github.com/users/arthurchan35","html_url":"https://github.com/arthurchan35","followers_url":"https://api.github.com/users/arthurchan35/followers","following_url":"https://api.github.com/users/arthurchan35/following{/other_user}","gists_url":"https://api.github.com/users/arthurchan35/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurchan35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurchan35/subscriptions","organizations_url":"https://api.github.com/users/arthurchan35/orgs","repos_url":"https://api.github.com/users/arthurchan35/repos","events_url":"https://api.github.com/users/arthurchan35/events{/privacy}","received_events_url":"https://api.github.com/users/arthurchan35/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arthurchan35/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/arthurchan35/liferay-portal","forks_url":"https://api.github.com/repos/arthurchan35/liferay-portal/forks","keys_url":"https://api.github.com/repos/arthurchan35/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arthurchan35/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arthurchan35/liferay-portal/teams","hooks_url":"https://api.github.com/repos/arthurchan35/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/arthurchan35/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/arthurchan35/liferay-portal/events","assignees_url":"https://api.github.com/repos/arthurchan35/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/arthurchan35/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/arthurchan35/liferay-portal/tags","blobs_url":"https://api.github.com/repos/arthurchan35/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arthurchan35/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arthurchan35/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/arthurchan35/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arthurchan35/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/arthurchan35/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/arthurchan35/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/arthurchan35/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/arthurchan35/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/arthurchan35/liferay-portal/subscription","commits_url":"https://api.github.com/repos/arthurchan35/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/arthurchan35/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/arthurchan35/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/arthurchan35/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/arthurchan35/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/arthurchan35/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arthurchan35/liferay-portal/merges","archive_url":"https://api.github.com/repos/arthurchan35/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arthurchan35/liferay-portal/downloads","issues_url":"https://api.github.com/repos/arthurchan35/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/arthurchan35/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/arthurchan35/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/arthurchan35/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arthurchan35/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/arthurchan35/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/arthurchan35/liferay-portal/deployments","created_at":"2016-11-30T02:02:05Z","updated_at":"2018-09-12T03:19:44Z","pushed_at":"2018-09-28T01:56:53Z","git_url":"git://github.com/arthurchan35/liferay-portal.git","ssh_url":"git@github.com:arthurchan35/liferay-portal.git","clone_url":"https://github.com/arthurchan35/liferay-portal.git","svn_url":"https://github.com/arthurchan35/liferay-portal","homepage":"http://liferay.com","size":12550265,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"brianchandotcom:master","ref":"master","sha":"03e288cc4f04cd40443a9cc02a9bb409c20a0797","user":{"login":"brianchandotcom","id":282080,"node_id":"MDQ6VXNlcjI4MjA4MA==","avatar_url":"https://avatars2.githubusercontent.com/u/282080?v=4","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"repo":{"id":1920851,"node_id":"MDEwOlJlcG9zaXRvcnkxOTIwODUx","name":"liferay-portal","full_name":"brianchandotcom/liferay-portal","private":false,"owner":{"login":"brianchandotcom","id":282080,"node_id":"MDQ6VXNlcjI4MjA4MA==","avatar_url":"https://avatars2.githubusercontent.com/u/282080?v=4","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"html_url":"https://github.com/brianchandotcom/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/brianchandotcom/liferay-portal","forks_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/forks","keys_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/teams","hooks_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/events","assignees_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/tags","blobs_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/subscription","commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/merges","archive_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/downloads","issues_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/deployments","created_at":"2011-06-19T21:37:56Z","updated_at":"2018-10-01T03:05:09Z","pushed_at":"2018-10-01T03:04:56Z","git_url":"git://github.com/brianchandotcom/liferay-portal.git","ssh_url":"git@github.com:brianchandotcom/liferay-portal.git","clone_url":"https://github.com/brianchandotcom/liferay-portal.git","svn_url":"https://github.com/brianchandotcom/liferay-portal","homepage":"http://liferay.com","size":12794245,"stargazers_count":37,"watchers_count":37,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":9,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/63551"},"html":{"href":"https://github.com/brianchandotcom/liferay-portal/pull/63551"},"issue":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/63551"},"comments":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/63551/comments"},"review_comments":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/63551/comments"},"review_comment":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/63551/commits"},"statuses":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/8ed99a073de26bd43dd27d000923114a28b54415"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":94,"deletions":63,"changed_files":6}}
{"actor":{"display_login":"brianchandotcom"}}