{"action":"created","issue":{"url":"https://api.github.com/repos/gramps-project/gramps/issues/700","repository_url":"https://api.github.com/repos/gramps-project/gramps","labels_url":"https://api.github.com/repos/gramps-project/gramps/issues/700/labels{/name}","comments_url":"https://api.github.com/repos/gramps-project/gramps/issues/700/comments","events_url":"https://api.github.com/repos/gramps-project/gramps/issues/700/events","html_url":"https://github.com/gramps-project/gramps/pull/700","id":378363515,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDg2NDQw","number":700,"title":"Allow filters/rules via plugin without fail on restart","user":{"login":"prculley","id":18122203,"node_id":"MDQ6VXNlcjE4MTIyMjAz","avatar_url":"https://avatars2.githubusercontent.com/u/18122203?v=4","gravatar_id":"","url":"https://api.github.com/users/prculley","html_url":"https://github.com/prculley","followers_url":"https://api.github.com/users/prculley/followers","following_url":"https://api.github.com/users/prculley/following{/other_user}","gists_url":"https://api.github.com/users/prculley/gists{/gist_id}","starred_url":"https://api.github.com/users/prculley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prculley/subscriptions","organizations_url":"https://api.github.com/users/prculley/orgs","repos_url":"https://api.github.com/users/prculley/repos","events_url":"https://api.github.com/users/prculley/events{/privacy}","received_events_url":"https://api.github.com/users/prculley/received_events","type":"User","site_admin":false},"labels":[{"id":163706671,"node_id":"MDU6TGFiZWwxNjM3MDY2NzE=","url":"https://api.github.com/repos/gramps-project/gramps/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/gramps-project/gramps/milestones/1","html_url":"https://github.com/gramps-project/gramps/milestone/1","labels_url":"https://api.github.com/repos/gramps-project/gramps/milestones/1/labels","id":2547113,"node_id":"MDk6TWlsZXN0b25lMjU0NzExMw==","number":1,"title":"v5.1","description":"Major release.","creator":{"login":"Nick-Hall","id":9042510,"node_id":"MDQ6VXNlcjkwNDI1MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9042510?v=4","gravatar_id":"","url":"https://api.github.com/users/Nick-Hall","html_url":"https://github.com/Nick-Hall","followers_url":"https://api.github.com/users/Nick-Hall/followers","following_url":"https://api.github.com/users/Nick-Hall/following{/other_user}","gists_url":"https://api.github.com/users/Nick-Hall/gists{/gist_id}","starred_url":"https://api.github.com/users/Nick-Hall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nick-Hall/subscriptions","organizations_url":"https://api.github.com/users/Nick-Hall/orgs","repos_url":"https://api.github.com/users/Nick-Hall/repos","events_url":"https://api.github.com/users/Nick-Hall/events{/privacy}","received_events_url":"https://api.github.com/users/Nick-Hall/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":20,"state":"open","created_at":"2017-05-28T18:05:40Z","updated_at":"2018-11-18T15:53:56Z","due_on":"2018-07-01T07:00:00Z","closed_at":null},"comments":4,"created_at":"2018-11-07T16:22:57Z","updated_at":"2018-11-20T08:06:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gramps-project/gramps/pulls/700","html_url":"https://github.com/gramps-project/gramps/pull/700","diff_url":"https://github.com/gramps-project/gramps/pull/700.diff","patch_url":"https://github.com/gramps-project/gramps/pull/700.patch"},"body":"In attempting to add a new filter or rule via an addon, I discovered that the added filter/rule would not work after the first restart after its first use.  In addition I would get a console error:\r\nERROR: Filter rule 'HasSourceParameter' in filter 'testit' not found!\r\nIn this case I had added the new rule 'HasSourceParameter' in the addon, and tried to use it in a custom source filter called 'testit'.\r\n\r\nIt turned out that the 'custom_filters.xml' file was being processed on startup before the plugins/addons were scanned, so the addon filter was not found.\r\n\r\nI'm calling this a bug because Gramps has long had the theoretical ability to add filters via addons, it was apparently never used before this.  And because I'd like to get some filter addons done before 5.1 timeframe ;-)"},"comment":{"url":"https://api.github.com/repos/gramps-project/gramps/issues/comments/440180036","html_url":"https://github.com/gramps-project/gramps/pull/700#issuecomment-440180036","issue_url":"https://api.github.com/repos/gramps-project/gramps/issues/700","id":440180036,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDE4MDAzNg==","user":{"login":"Nick-Hall","id":9042510,"node_id":"MDQ6VXNlcjkwNDI1MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9042510?v=4","gravatar_id":"","url":"https://api.github.com/users/Nick-Hall","html_url":"https://github.com/Nick-Hall","followers_url":"https://api.github.com/users/Nick-Hall/followers","following_url":"https://api.github.com/users/Nick-Hall/following{/other_user}","gists_url":"https://api.github.com/users/Nick-Hall/gists{/gist_id}","starred_url":"https://api.github.com/users/Nick-Hall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nick-Hall/subscriptions","organizations_url":"https://api.github.com/users/Nick-Hall/orgs","repos_url":"https://api.github.com/users/Nick-Hall/repos","events_url":"https://api.github.com/users/Nick-Hall/events{/privacy}","received_events_url":"https://api.github.com/users/Nick-Hall/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T08:06:21Z","updated_at":"2018-11-20T08:06:21Z","author_association":"MEMBER","body":"I really like this idea, but a neater approach would be to actually create a new RULE plugin type.  The GENERAL type is not really intended for this purpose."}}
{"actor":{"display_login":"Nick-Hall"}}