{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/222036587","pull_request_review_id":160829125,"id":222036587,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjAzNjU4Nw==","diff_hunk":"@@ -124,7 +124,7 @@ def get_version():\n     'pytz>=2018.3,<=2018.4',\n     'pyyaml>=3.12,<4.0.0',\n     'pyvcf>=0.6.8,<0.7.0',\n-    'typing>=3.6.0,<3.7.0',\n+    'typing>=3.6.0,<3.7.0; python_version < \"3.7.0\"',","path":"sdks/python/setup.py","position":5,"original_position":5,"commit_id":"ff5fe334fdb69152db9726f87f37d16477dbe5a5","original_commit_id":"ff5fe334fdb69152db9726f87f37d16477dbe5a5","user":{"login":"aaltay","id":696638,"node_id":"MDQ6VXNlcjY5NjYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/696638?v=4","gravatar_id":"","url":"https://api.github.com/users/aaltay","html_url":"https://github.com/aaltay","followers_url":"https://api.github.com/users/aaltay/followers","following_url":"https://api.github.com/users/aaltay/following{/other_user}","gists_url":"https://api.github.com/users/aaltay/gists{/gist_id}","starred_url":"https://api.github.com/users/aaltay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaltay/subscriptions","organizations_url":"https://api.github.com/users/aaltay/orgs","repos_url":"https://api.github.com/users/aaltay/repos","events_url":"https://api.github.com/users/aaltay/events{/privacy}","received_events_url":"https://api.github.com/users/aaltay/received_events","type":"User","site_admin":false},"body":"I was not aware of this usage. If this works, we can probably consolidate our  REQUIRED_PACKAGES_PY3_ONLY etc parts here as well.\r\n\r\n(Similarly we can use a single requirements base file for 2 different Docker files for py2 and py3)\r\n\r\n@tvalentyn ","created_at":"2018-10-02T17:11:59Z","updated_at":"2018-10-02T17:12:12Z","html_url":"https://github.com/apache/beam/pull/6543#discussion_r222036587","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/6543","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/222036587"},"html":{"href":"https://github.com/apache/beam/pull/6543#discussion_r222036587"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/6543"}}},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/6543","id":219716864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzE2ODY0","html_url":"https://github.com/apache/beam/pull/6543","diff_url":"https://github.com/apache/beam/pull/6543.diff","patch_url":"https://github.com/apache/beam/pull/6543.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/6543","number":6543,"state":"open","locked":false,"title":"[BEAM-5607] Set python_version of typing library < 3.7.0","user":{"login":"manuzhang","id":1191767,"node_id":"MDQ6VXNlcjExOTE3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1191767?v=4","gravatar_id":"","url":"https://api.github.com/users/manuzhang","html_url":"https://github.com/manuzhang","followers_url":"https://api.github.com/users/manuzhang/followers","following_url":"https://api.github.com/users/manuzhang/following{/other_user}","gists_url":"https://api.github.com/users/manuzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/manuzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuzhang/subscriptions","organizations_url":"https://api.github.com/users/manuzhang/orgs","repos_url":"https://api.github.com/users/manuzhang/repos","events_url":"https://api.github.com/users/manuzhang/events{/privacy}","received_events_url":"https://api.github.com/users/manuzhang/received_events","type":"User","site_admin":false},"body":"This PR sets maximum python version of typing library, which is no longer provisional in Python 3.7\r\n\r\n------------------------\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.\r\n - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\nIt will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.\r\n\r\nPost-Commit Tests Status (on master branch)\r\n------------------------------------------------------------------------------------------------\r\n\r\nLang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark\r\n--- | --- | --- | --- | --- | --- | --- | ---\r\nGo | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---\r\nJava | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)\r\nPython | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---\r\n\r\n\r\n\r\n\r\n","created_at":"2018-10-02T14:07:21Z","updated_at":"2018-10-02T17:12:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5c43a111f566f61700c8327e49ab906b186769c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/6543/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/6543/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/6543/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/ff5fe334fdb69152db9726f87f37d16477dbe5a5","head":{"label":"manuzhang:python3_typing","ref":"python3_typing","sha":"ff5fe334fdb69152db9726f87f37d16477dbe5a5","user":{"login":"manuzhang","id":1191767,"node_id":"MDQ6VXNlcjExOTE3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1191767?v=4","gravatar_id":"","url":"https://api.github.com/users/manuzhang","html_url":"https://github.com/manuzhang","followers_url":"https://api.github.com/users/manuzhang/followers","following_url":"https://api.github.com/users/manuzhang/following{/other_user}","gists_url":"https://api.github.com/users/manuzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/manuzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuzhang/subscriptions","organizations_url":"https://api.github.com/users/manuzhang/orgs","repos_url":"https://api.github.com/users/manuzhang/repos","events_url":"https://api.github.com/users/manuzhang/events{/privacy}","received_events_url":"https://api.github.com/users/manuzhang/received_events","type":"User","site_admin":false},"repo":{"id":53920873,"node_id":"MDEwOlJlcG9zaXRvcnk1MzkyMDg3Mw==","name":"beam","full_name":"manuzhang/beam","private":false,"owner":{"login":"manuzhang","id":1191767,"node_id":"MDQ6VXNlcjExOTE3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1191767?v=4","gravatar_id":"","url":"https://api.github.com/users/manuzhang","html_url":"https://github.com/manuzhang","followers_url":"https://api.github.com/users/manuzhang/followers","following_url":"https://api.github.com/users/manuzhang/following{/other_user}","gists_url":"https://api.github.com/users/manuzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/manuzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuzhang/subscriptions","organizations_url":"https://api.github.com/users/manuzhang/orgs","repos_url":"https://api.github.com/users/manuzhang/repos","events_url":"https://api.github.com/users/manuzhang/events{/privacy}","received_events_url":"https://api.github.com/users/manuzhang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/manuzhang/beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/manuzhang/beam","forks_url":"https://api.github.com/repos/manuzhang/beam/forks","keys_url":"https://api.github.com/repos/manuzhang/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manuzhang/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manuzhang/beam/teams","hooks_url":"https://api.github.com/repos/manuzhang/beam/hooks","issue_events_url":"https://api.github.com/repos/manuzhang/beam/issues/events{/number}","events_url":"https://api.github.com/repos/manuzhang/beam/events","assignees_url":"https://api.github.com/repos/manuzhang/beam/assignees{/user}","branches_url":"https://api.github.com/repos/manuzhang/beam/branches{/branch}","tags_url":"https://api.github.com/repos/manuzhang/beam/tags","blobs_url":"https://api.github.com/repos/manuzhang/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manuzhang/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manuzhang/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/manuzhang/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manuzhang/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/manuzhang/beam/languages","stargazers_url":"https://api.github.com/repos/manuzhang/beam/stargazers","contributors_url":"https://api.github.com/repos/manuzhang/beam/contributors","subscribers_url":"https://api.github.com/repos/manuzhang/beam/subscribers","subscription_url":"https://api.github.com/repos/manuzhang/beam/subscription","commits_url":"https://api.github.com/repos/manuzhang/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/manuzhang/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/manuzhang/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/manuzhang/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/manuzhang/beam/contents/{+path}","compare_url":"https://api.github.com/repos/manuzhang/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manuzhang/beam/merges","archive_url":"https://api.github.com/repos/manuzhang/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manuzhang/beam/downloads","issues_url":"https://api.github.com/repos/manuzhang/beam/issues{/number}","pulls_url":"https://api.github.com/repos/manuzhang/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/manuzhang/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/manuzhang/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manuzhang/beam/labels{/name}","releases_url":"https://api.github.com/repos/manuzhang/beam/releases{/id}","deployments_url":"https://api.github.com/repos/manuzhang/beam/deployments","created_at":"2016-03-15T06:36:52Z","updated_at":"2017-05-17T02:25:59Z","pushed_at":"2018-10-02T14:04:55Z","git_url":"git://github.com/manuzhang/beam.git","ssh_url":"git@github.com:manuzhang/beam.git","clone_url":"https://github.com/manuzhang/beam.git","svn_url":"https://github.com/manuzhang/beam","homepage":null,"size":99145,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0c91e0cbb1b50c42eb35623a0edc7ed2cba44ef3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-10-02T14:40:28Z","pushed_at":"2018-10-02T17:03:09Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"https://beam.apache.org","size":105690,"stargazers_count":2199,"watchers_count":2199,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1362,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1362,"open_issues":84,"watchers":2199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/6543"},"html":{"href":"https://github.com/apache/beam/pull/6543"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/6543"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/6543/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/6543/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/6543/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/ff5fe334fdb69152db9726f87f37d16477dbe5a5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aaltay"}}