{"action":"created","issue":{"url":"https://api.github.com/repos/pma/amqp/issues/95","repository_url":"https://api.github.com/repos/pma/amqp","labels_url":"https://api.github.com/repos/pma/amqp/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/pma/amqp/issues/95/comments","events_url":"https://api.github.com/repos/pma/amqp/issues/95/events","html_url":"https://github.com/pma/amqp/pull/95","id":326984321,"number":95,"title":"Dependency updates","user":{"login":"michaelklishin","id":1090,"avatar_url":"https://avatars3.githubusercontent.com/u/1090?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelklishin","html_url":"https://github.com/michaelklishin","followers_url":"https://api.github.com/users/michaelklishin/followers","following_url":"https://api.github.com/users/michaelklishin/following{/other_user}","gists_url":"https://api.github.com/users/michaelklishin/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelklishin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelklishin/subscriptions","organizations_url":"https://api.github.com/users/michaelklishin/orgs","repos_url":"https://api.github.com/users/michaelklishin/repos","events_url":"https://api.github.com/users/michaelklishin/events{/privacy}","received_events_url":"https://api.github.com/users/michaelklishin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-05-28T10:51:42Z","updated_at":"2018-05-30T15:22:44Z","closed_at":"2018-05-30T12:42:46Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pma/amqp/pulls/95","html_url":"https://github.com/pma/amqp/pull/95","diff_url":"https://github.com/pma/amqp/pull/95.diff","patch_url":"https://github.com/pma/amqp/pull/95.patch"},"body":"This updates dependency version requirements to cover all RabbitMQ 3.7.x releases. Besides better compatibility with RabbitMQ Erlang client and `rabbit_common` versions, this would allow team RabbitMQ use `1.0.x` versions of this library in rabbitmq-cli tests. Currently we are stuck at `0.2.x`."},"comment":{"url":"https://api.github.com/repos/pma/amqp/issues/comments/393204051","html_url":"https://github.com/pma/amqp/pull/95#issuecomment-393204051","issue_url":"https://api.github.com/repos/pma/amqp/issues/95","id":393204051,"user":{"login":"ono","id":46496,"avatar_url":"https://avatars2.githubusercontent.com/u/46496?v=4","gravatar_id":"","url":"https://api.github.com/users/ono","html_url":"https://github.com/ono","followers_url":"https://api.github.com/users/ono/followers","following_url":"https://api.github.com/users/ono/following{/other_user}","gists_url":"https://api.github.com/users/ono/gists{/gist_id}","starred_url":"https://api.github.com/users/ono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ono/subscriptions","organizations_url":"https://api.github.com/users/ono/orgs","repos_url":"https://api.github.com/users/ono/repos","events_url":"https://api.github.com/users/ono/events{/privacy}","received_events_url":"https://api.github.com/users/ono/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T15:22:44Z","updated_at":"2018-05-30T15:22:44Z","author_association":"COLLABORATOR","body":"`mix.lock` doesn't affect any projects using amqp. It is purely used amqp's maintenance point of view.\r\n\r\nSorry but what you are saying and this PR are not quite making sense. Let's clarify what you want to do here.\r\n\r\n#### If you want to use amqp_client 3.7.5 on your project\r\n\r\nNothing required on Elixir `amqp` library. If the user create a new project, the latest version of `3.7.x` will be picked automatically - thus `3.7.5` for now. If the user wants to update amqp_client on existing project, they can do `mix update amqp_client` and it will update to `3.7.5`.\r\n\r\nChanging mix.exs like the PR(`{:amqp_client, \"~> 3.7\"}`) results to update `3.8+` in the future. The minor version upgrade shouldn't be done implicitly.\r\n\r\n#### If amqp_client 3.7.3 and 3.7.4 has serious issues and all users should upgrade to 3.7.5\r\n\r\nIn that case, we should change the mix.exs with `{:amqp_client, \"~> 3.7.5\"}` and bump the version of this library. In that case, can you share the issues? I have briefly checked the release note on rabbitmq but could not find a strong reason to force the version in this project.\r\n\r\n\r\n...or is there something else?"}}
{"actor":{"display_login":"ono"}}