{"action":"created","comment":{"url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/comments/237833044","pull_request_review_id":180230164,"id":237833044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzgzMzA0NA==","diff_hunk":"@@ -0,0 +1,90 @@\n+const { h, Value, computed, when } = require('mutant')\n+\n+// NOTE - these are currently connect to mcss + state switching\n+const RECEIVED = 'received'\n+const REQUESTED = 'requested'\n+const RETURNED = 'returned'\n+\n+module.exports = function DarkCrystalShowFriend (opts) {","path":"views/others-shards/friend/show.js","position":8,"original_position":8,"commit_id":"2628228cc3144d7f55e8474ed83bcb7b3d058fb8","original_commit_id":"2628228cc3144d7f55e8474ed83bcb7b3d058fb8","user":{"login":"KGibb8","id":17786217,"node_id":"MDQ6VXNlcjE3Nzg2MjE3","avatar_url":"https://avatars2.githubusercontent.com/u/17786217?v=4","gravatar_id":"","url":"https://api.github.com/users/KGibb8","html_url":"https://github.com/KGibb8","followers_url":"https://api.github.com/users/KGibb8/followers","following_url":"https://api.github.com/users/KGibb8/following{/other_user}","gists_url":"https://api.github.com/users/KGibb8/gists{/gist_id}","starred_url":"https://api.github.com/users/KGibb8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KGibb8/subscriptions","organizations_url":"https://api.github.com/users/KGibb8/orgs","repos_url":"https://api.github.com/users/KGibb8/repos","events_url":"https://api.github.com/users/KGibb8/events{/privacy}","received_events_url":"https://api.github.com/users/KGibb8/received_events","type":"User","site_admin":false},"body":"Just want to make sure we don't get the names all mixed up! Here its declared as `DarkCrystalShowFriend` and its grabbed as `DarkCrystalFriendShow`. Its easier to search the code when we've got them standardised.\r\n\r\nIf I'm honest, I'd roll with keeping the file namespacing consistent, and would call this `OthersShardsFriendShow` or make a `FriendShow` component that's more 'dumb' and can be used in a similar manner in other sections of the app. For example I think some of the forwarding section is going to _look_ a bit similar while being in a different place. We could probably reuse these ideas.","created_at":"2018-11-30T11:42:30Z","updated_at":"2018-11-30T11:42:30Z","html_url":"https://github.com/blockades/patchbay-dark-crystal/pull/18#discussion_r237833044","pull_request_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/18","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/comments/237833044"},"html":{"href":"https://github.com/blockades/patchbay-dark-crystal/pull/18#discussion_r237833044"},"pull_request":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/18","id":234870422,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODcwNDIy","html_url":"https://github.com/blockades/patchbay-dark-crystal/pull/18","diff_url":"https://github.com/blockades/patchbay-dark-crystal/pull/18.diff","patch_url":"https://github.com/blockades/patchbay-dark-crystal/pull/18.patch","issue_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/18","number":18,"state":"open","locked":false,"title":"friends shards page v2","user":{"login":"mixmix","id":2665886,"node_id":"MDQ6VXNlcjI2NjU4ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/2665886?v=4","gravatar_id":"","url":"https://api.github.com/users/mixmix","html_url":"https://github.com/mixmix","followers_url":"https://api.github.com/users/mixmix/followers","following_url":"https://api.github.com/users/mixmix/following{/other_user}","gists_url":"https://api.github.com/users/mixmix/gists{/gist_id}","starred_url":"https://api.github.com/users/mixmix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixmix/subscriptions","organizations_url":"https://api.github.com/users/mixmix/orgs","repos_url":"https://api.github.com/users/mixmix/repos","events_url":"https://api.github.com/users/mixmix/events{/privacy}","received_events_url":"https://api.github.com/users/mixmix/received_events","type":"User","site_admin":false},"body":"Trello : https://trello.com/c/7g1rFpsb/46-collect-others-shards-by-peer\r\n\r\n**Purpose** : show a higher level overview of friends shards. The main design challenge was to be able to return all of a persons shards. \r\n\r\n**Solution**: I started with an overview of all shards, and enabled clicking into a single shard. This was a terrible idea so I made it that when you click on any shards you click into that particular friend and can see more in depth overview of all those shards. The view I built for this is minimal as this might be where @KGibb8 does some more work.\r\n\r\n![selection_188](https://user-images.githubusercontent.com/2665886/49269011-96c59300-f4c7-11e8-895b-bd473e402c37.jpg)\r\n_see a high level overview of your custodianship_\r\n\r\n![selection_187](https://user-images.githubusercontent.com/2665886/49269012-96c59300-f4c7-11e8-81dc-06835194c777.jpg)\r\n_see details and take actions (return requested shards, and later other things)_\r\n\r\n---\r\n\r\n**Not done:**\r\n- [ ] testing to ensure each view live updates\r\n  - [ ] on receiving a new shard\r\n  - [ ] on change of state of a shard (request comes in, or I've just returned it)\r\n- [ ] a message when you have no shards \r\n  - e.g. \"You haven't been sent any shards yet\"\r\n\r\nWould like feedback about whether we should get these done before merge into development or whether we should merge so kieran can do things more easily and make a card for mix (or someone) to do these","created_at":"2018-11-30T04:43:33Z","updated_at":"2018-11-30T11:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"807abf50b461e2e45d77214283c346fb3859a44a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/18/commits","review_comments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/18/comments","review_comment_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/18/comments","statuses_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/statuses/2628228cc3144d7f55e8474ed83bcb7b3d058fb8","head":{"label":"blockades:others_shards_v2","ref":"others_shards_v2","sha":"2628228cc3144d7f55e8474ed83bcb7b3d058fb8","user":{"login":"blockades","id":32723195,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIzMTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32723195?v=4","gravatar_id":"","url":"https://api.github.com/users/blockades","html_url":"https://github.com/blockades","followers_url":"https://api.github.com/users/blockades/followers","following_url":"https://api.github.com/users/blockades/following{/other_user}","gists_url":"https://api.github.com/users/blockades/gists{/gist_id}","starred_url":"https://api.github.com/users/blockades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockades/subscriptions","organizations_url":"https://api.github.com/users/blockades/orgs","repos_url":"https://api.github.com/users/blockades/repos","events_url":"https://api.github.com/users/blockades/events{/privacy}","received_events_url":"https://api.github.com/users/blockades/received_events","type":"Organization","site_admin":false},"repo":{"id":141201965,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyMDE5NjU=","name":"patchbay-dark-crystal","full_name":"blockades/patchbay-dark-crystal","private":false,"owner":{"login":"blockades","id":32723195,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIzMTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32723195?v=4","gravatar_id":"","url":"https://api.github.com/users/blockades","html_url":"https://github.com/blockades","followers_url":"https://api.github.com/users/blockades/followers","following_url":"https://api.github.com/users/blockades/following{/other_user}","gists_url":"https://api.github.com/users/blockades/gists{/gist_id}","starred_url":"https://api.github.com/users/blockades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockades/subscriptions","organizations_url":"https://api.github.com/users/blockades/orgs","repos_url":"https://api.github.com/users/blockades/repos","events_url":"https://api.github.com/users/blockades/events{/privacy}","received_events_url":"https://api.github.com/users/blockades/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/blockades/patchbay-dark-crystal","description":"A patchbay interface for dark-crystal (a scuttlebutt based secret sharing tool) ","fork":false,"url":"https://api.github.com/repos/blockades/patchbay-dark-crystal","forks_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/forks","keys_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/teams","hooks_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/hooks","issue_events_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/events{/number}","events_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/events","assignees_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/assignees{/user}","branches_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/branches{/branch}","tags_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/tags","blobs_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/languages","stargazers_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/stargazers","contributors_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/contributors","subscribers_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/subscribers","subscription_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/subscription","commits_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/contents/{+path}","compare_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/merges","archive_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/downloads","issues_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues{/number}","pulls_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/labels{/name}","releases_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/releases{/id}","deployments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/deployments","created_at":"2018-07-16T22:36:52Z","updated_at":"2018-11-24T15:36:49Z","pushed_at":"2018-11-30T04:52:45Z","git_url":"git://github.com/blockades/patchbay-dark-crystal.git","ssh_url":"git@github.com:blockades/patchbay-dark-crystal.git","clone_url":"https://github.com/blockades/patchbay-dark-crystal.git","svn_url":"https://github.com/blockades/patchbay-dark-crystal","homepage":"http://darkcrystal.pw","size":2687,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"base":{"label":"blockades:development","ref":"development","sha":"649f09ef90fd32cb3277d7d3067344a3c6d7106d","user":{"login":"blockades","id":32723195,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIzMTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32723195?v=4","gravatar_id":"","url":"https://api.github.com/users/blockades","html_url":"https://github.com/blockades","followers_url":"https://api.github.com/users/blockades/followers","following_url":"https://api.github.com/users/blockades/following{/other_user}","gists_url":"https://api.github.com/users/blockades/gists{/gist_id}","starred_url":"https://api.github.com/users/blockades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockades/subscriptions","organizations_url":"https://api.github.com/users/blockades/orgs","repos_url":"https://api.github.com/users/blockades/repos","events_url":"https://api.github.com/users/blockades/events{/privacy}","received_events_url":"https://api.github.com/users/blockades/received_events","type":"Organization","site_admin":false},"repo":{"id":141201965,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyMDE5NjU=","name":"patchbay-dark-crystal","full_name":"blockades/patchbay-dark-crystal","private":false,"owner":{"login":"blockades","id":32723195,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIzMTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32723195?v=4","gravatar_id":"","url":"https://api.github.com/users/blockades","html_url":"https://github.com/blockades","followers_url":"https://api.github.com/users/blockades/followers","following_url":"https://api.github.com/users/blockades/following{/other_user}","gists_url":"https://api.github.com/users/blockades/gists{/gist_id}","starred_url":"https://api.github.com/users/blockades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockades/subscriptions","organizations_url":"https://api.github.com/users/blockades/orgs","repos_url":"https://api.github.com/users/blockades/repos","events_url":"https://api.github.com/users/blockades/events{/privacy}","received_events_url":"https://api.github.com/users/blockades/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/blockades/patchbay-dark-crystal","description":"A patchbay interface for dark-crystal (a scuttlebutt based secret sharing tool) ","fork":false,"url":"https://api.github.com/repos/blockades/patchbay-dark-crystal","forks_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/forks","keys_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/teams","hooks_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/hooks","issue_events_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/events{/number}","events_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/events","assignees_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/assignees{/user}","branches_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/branches{/branch}","tags_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/tags","blobs_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/languages","stargazers_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/stargazers","contributors_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/contributors","subscribers_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/subscribers","subscription_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/subscription","commits_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/contents/{+path}","compare_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/merges","archive_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/downloads","issues_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues{/number}","pulls_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/labels{/name}","releases_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/releases{/id}","deployments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/deployments","created_at":"2018-07-16T22:36:52Z","updated_at":"2018-11-24T15:36:49Z","pushed_at":"2018-11-30T04:52:45Z","git_url":"git://github.com/blockades/patchbay-dark-crystal.git","ssh_url":"git@github.com:blockades/patchbay-dark-crystal.git","clone_url":"https://github.com/blockades/patchbay-dark-crystal.git","svn_url":"https://github.com/blockades/patchbay-dark-crystal","homepage":"http://darkcrystal.pw","size":2687,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/18"},"html":{"href":"https://github.com/blockades/patchbay-dark-crystal/pull/18"},"issue":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/18"},"comments":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/statuses/2628228cc3144d7f55e8474ed83bcb7b3d058fb8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"KGibb8"}}