{"action":"created","issue":{"url":"https://api.github.com/repos/woocommerce/woocommerce/issues/20273","repository_url":"https://api.github.com/repos/woocommerce/woocommerce","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/20273/labels{/name}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/20273/comments","events_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/20273/events","html_url":"https://github.com/woocommerce/woocommerce/pull/20273","id":326968588,"number":20273,"title":"Fix broken product import file uploads on windows","user":{"login":"kloon","id":271630,"avatar_url":"https://avatars1.githubusercontent.com/u/271630?v=4","gravatar_id":"","url":"https://api.github.com/users/kloon","html_url":"https://github.com/kloon","followers_url":"https://api.github.com/users/kloon/followers","following_url":"https://api.github.com/users/kloon/following{/other_user}","gists_url":"https://api.github.com/users/kloon/gists{/gist_id}","starred_url":"https://api.github.com/users/kloon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kloon/subscriptions","organizations_url":"https://api.github.com/users/kloon/orgs","repos_url":"https://api.github.com/users/kloon/repos","events_url":"https://api.github.com/users/kloon/events{/privacy}","received_events_url":"https://api.github.com/users/kloon/received_events","type":"User","site_admin":false},"labels":[{"id":33006752,"url":"https://api.github.com/repos/woocommerce/woocommerce/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/woocommerce/woocommerce/milestones/120","html_url":"https://github.com/woocommerce/woocommerce/milestone/120","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/milestones/120/labels","id":3370232,"number":120,"title":"3.4.1","description":"","creator":{"login":"mikejolley","id":90977,"avatar_url":"https://avatars2.githubusercontent.com/u/90977?v=4","gravatar_id":"","url":"https://api.github.com/users/mikejolley","html_url":"https://github.com/mikejolley","followers_url":"https://api.github.com/users/mikejolley/followers","following_url":"https://api.github.com/users/mikejolley/following{/other_user}","gists_url":"https://api.github.com/users/mikejolley/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejolley/subscriptions","organizations_url":"https://api.github.com/users/mikejolley/orgs","repos_url":"https://api.github.com/users/mikejolley/repos","events_url":"https://api.github.com/users/mikejolley/events{/privacy}","received_events_url":"https://api.github.com/users/mikejolley/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":28,"state":"open","created_at":"2018-05-23T21:39:00Z","updated_at":"2018-05-28T10:02:46Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-05-28T09:54:54Z","updated_at":"2018-05-28T18:12:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/20273","html_url":"https://github.com/woocommerce/woocommerce/pull/20273","diff_url":"https://github.com/woocommerce/woocommerce/pull/20273.diff","patch_url":"https://github.com/woocommerce/woocommerce/pull/20273.patch"},"body":"### All Submissions:\r\n\r\n* [x] Have you followed the [WooCommerce Contributing guideline](https://github.com/woocommerce/woocommerce/blob/master/.github/CONTRIBUTING.md)?\r\n* [x] Does your code follow the [WordPress' coding standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/)?\r\n* [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change?\r\n\r\n<!-- Mark completed items with an [x] -->\r\n\r\n<!-- You can erase any parts of this template not applicable to your Pull Request. -->\r\n\r\n### Changes proposed in this Pull Request:\r\nUse wc_clean and not wp_unslash when cleaning the filename and path before uploading. wp_unslash strips out windows path slashes.\r\n\r\n<!-- Describe the changes made to this Pull Request, and the reason for such changes. -->\r\n\r\nCloses #20268.\r\n\r\n### How to test the changes in this Pull Request:\r\n\r\n1. On a Windows-based server go to Products -> All Products -> Import\r\n2. Select the sample product file bundled with WooCommerce and click `Continue`\r\n3. Next step should load without any issues\r\n\r\n### Other information:\r\n\r\n* [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n* [ ] Have you written new tests for your changes, as applicable?\r\n* [x] Have you successfully ran tests with your changes locally?\r\n\r\n<!-- Mark completed items with an [x] -->\r\n\r\n### Changelog entry\r\n\r\n> Fix - Product imports on Windows-based servers.\r\n"},"comment":{"url":"https://api.github.com/repos/woocommerce/woocommerce/issues/comments/392581020","html_url":"https://github.com/woocommerce/woocommerce/pull/20273#issuecomment-392581020","issue_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/20273","id":392581020,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-05-28T18:12:35Z","updated_at":"2018-05-28T18:12:35Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/woocommerce/woocommerce/pull/20273?src=pr&el=h1) Report\n> Merging [#20273](https://codecov.io/gh/woocommerce/woocommerce/pull/20273?src=pr&el=desc) into [master](https://codecov.io/gh/woocommerce/woocommerce/commit/2ad9b00c9c2b55579eb3531cd5eb5d4f03622ab0?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/woocommerce/woocommerce/pull/20273/graphs/tree.svg?width=650&token=cbaMH3W5DX&height=150&src=pr)](https://codecov.io/gh/woocommerce/woocommerce/pull/20273?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##             master   #20273   +/-   ##\n=========================================\n  Coverage     39.07%   39.07%           \n  Complexity    13184    13184           \n=========================================\n  Files           356      356           \n  Lines         49644    49644           \n=========================================\n  Hits          19395    19395           \n  Misses        30249    30249\n```\n\n\n| [Impacted Files](https://codecov.io/gh/woocommerce/woocommerce/pull/20273?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...rters/class-wc-product-csv-importer-controller.php](https://codecov.io/gh/woocommerce/woocommerce/pull/20273/diff?src=pr&el=tree#diff-aW5jbHVkZXMvYWRtaW4vaW1wb3J0ZXJzL2NsYXNzLXdjLXByb2R1Y3QtY3N2LWltcG9ydGVyLWNvbnRyb2xsZXIucGhw) | `10.68% <0%> (ø)` | `62 <0> (ø)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/woocommerce/woocommerce/pull/20273?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/woocommerce/woocommerce/pull/20273?src=pr&el=footer). Last update [2ad9b00...4e40d79](https://codecov.io/gh/woocommerce/woocommerce/pull/20273?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}