{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/BuildTools/pulls/comments/233156745","pull_request_review_id":174505265,"id":233156745,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE1Njc0NQ==","diff_hunk":"@@ -1,25 +1,40 @@\n <Project>\n \n-  <PropertyGroup Condition=\"'$(MicrosoftBuildVersion)' == ''\">\n-    <!--\n-      The dependency versions here don't matter as long as the version is binary compatible with the version of MSBuild and NuGet\n-      already embedded in Microsoft.NET.Sdk. These are essentially reference assemblies.\n+  <Choose>\n+    <When Condition=\" '$(MSBuildRuntimeType)' == 'Core' \">\n \n-      Between MSBuild 15.6 and 15.8, the ref packages dropped .NET Standard 1.x suppport.\n-      Use the netstandard2.0 packages if possible, otherwise fallback to 15.6.\n-    -->\n-    <MicrosoftBuildVersion Condition=\"$(TargetFramework.StartsWith('netstandard1'))\">15.6.82</MicrosoftBuildVersion>\n-    <MicrosoftBuildVersion Condition=\"'$(MicrosoftBuildVersion)' == ''\">15.8.166</MicrosoftBuildVersion>\n-  </PropertyGroup>\n+      <PropertyGroup Condition=\"'$(MicrosoftBuildVersion)' == ''\">\n+        <!--\n+          The dependency versions here don't matter as long as the version is binary compatible with the version of MSBuild and NuGet\n+          already embedded in Microsoft.NET.Sdk. These are essentially reference assemblies.\n \n-  <ItemGroup Condition=\"'$(DisableImplicitFrameworkReferences)' != 'true'\">\n-    <!-- set as private assets all since we don't need this in the publish output folder -->\n-    <PackageReference Include=\"Microsoft.Build\" Version=\"$(MicrosoftBuildVersion)\" IsImplicitlyDefined=\"true\" PrivateAssets=\"All\" />\n-    <PackageReference Include=\"Microsoft.Build.Framework\" Version=\"$(MicrosoftBuildVersion)\" IsImplicitlyDefined=\"true\" PrivateAssets=\"All\" />\n-    <PackageReference Include=\"Microsoft.Build.Tasks.Core\" Version=\"$(MicrosoftBuildVersion)\" IsImplicitlyDefined=\"true\" PrivateAssets=\"All\" />\n-    <PackageReference Include=\"Microsoft.Build.Utilities.Core\" Version=\"$(MicrosoftBuildVersion)\" IsImplicitlyDefined=\"true\" PrivateAssets=\"All\" />\n-    <!-- because almost everyone ends up using JSON in repo tasks -->\n-    <PackageReference Include=\"Newtonsoft.Json\" Version=\"$(JsonInMSBuildVersion)\" IsImplicitlyDefined=\"true\" PrivateAssets=\"All\" />\n-  </ItemGroup>\n+          Between MSBuild 15.6 and 15.8, the ref packages dropped .NET Standard 1.x suppport.\n+          Use the netstandard2.0 packages if possible, otherwise fallback to 15.6.\n+        -->\n+        <MicrosoftBuildVersion Condition=\"$(TargetFramework.StartsWith('netstandard1'))\">15.6.82</MicrosoftBuildVersion>\n+        <MicrosoftBuildVersion Condition=\"'$(MicrosoftBuildVersion)' == ''\">15.8.166</MicrosoftBuildVersion>","path":"files/KoreBuild/msbuild/KoreBuild.RepoTasks.Sdk/Sdk/Sdk.targets","position":34,"original_position":34,"commit_id":"4315ca45aa35139b82b7ea46cd2268a281348050","original_commit_id":"34067d979a5b48411e83bb59fea120f4cd3baa4c","user":{"login":"natemcmaster","id":2696087,"node_id":"MDQ6VXNlcjI2OTYwODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"body":"Right, not a problem. The very-specific versions are due to the way MSBuild versions the packages they release to nuget.org.\r\n\r\n![image](https://user-images.githubusercontent.com/2696087/48432838-5fff2700-e72a-11e8-895e-b8e4003141d6.png)\r\n","created_at":"2018-11-13T17:56:26Z","updated_at":"2018-11-13T17:56:26Z","html_url":"https://github.com/aspnet/BuildTools/pull/869#discussion_r233156745","pull_request_url":"https://api.github.com/repos/aspnet/BuildTools/pulls/869","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/BuildTools/pulls/comments/233156745"},"html":{"href":"https://github.com/aspnet/BuildTools/pull/869#discussion_r233156745"},"pull_request":{"href":"https://api.github.com/repos/aspnet/BuildTools/pulls/869"}},"in_reply_to_id":232769616},"pull_request":{"url":"https://api.github.com/repos/aspnet/BuildTools/pulls/869","id":230227660,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjI3NjYw","html_url":"https://github.com/aspnet/BuildTools/pull/869","diff_url":"https://github.com/aspnet/BuildTools/pull/869.diff","patch_url":"https://github.com/aspnet/BuildTools/pull/869.patch","issue_url":"https://api.github.com/repos/aspnet/BuildTools/issues/869","number":869,"state":"open","locked":false,"title":"Support running KoreBuild on full msbuild","user":{"login":"natemcmaster","id":2696087,"node_id":"MDQ6VXNlcjI2OTYwODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"body":"These changes support using \"MSBuild.exe\" instead of \"dotnet msbuild\" when building a repo with KoreBuild.  The default still remains `dotnet msbuild`, so this is an opt-in change for repos.\r\n\r\n### Usage:\r\nIn korebuild.json, add the following:\r\n```json\r\n{\r\n  \"msbuildType\": \"full\"\r\n}\r\n```\r\n_This only applies to Windows builds._\r\n\r\n### Changes in this PR:\r\n* Remove unused tasks and targets (reduces what we had to port to .NET Framework)\r\n* Invoke VSWhere to find MSBuild.exe\r\n* Backport improvements to SourceLink and VSWhere tasks to reduce dependency on Json.Net\r\n\r\n### Motivations\r\n* One more step towards Arcade convergence (Arcade uses MSBuild.exe on Windows)\r\n* Mondo repo - ASP.NET Core has many projects which required full MSBuild.exe. This simplifies the build system so that we don't have to use `dotnet msbuild` to find and invoke a second MSBuild process. It also allows the build to use ProjectReference correctly.","created_at":"2018-11-12T18:25:12Z","updated_at":"2018-11-13T17:56:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"186b2f8391a0cacbe1d5bbc7ce555ae3bf52a034","assignee":null,"assignees":[],"requested_reviewers":[{"login":"muratg","id":1808428,"node_id":"MDQ6VXNlcjE4MDg0Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/1808428?v=4","gravatar_id":"","url":"https://api.github.com/users/muratg","html_url":"https://github.com/muratg","followers_url":"https://api.github.com/users/muratg/followers","following_url":"https://api.github.com/users/muratg/following{/other_user}","gists_url":"https://api.github.com/users/muratg/gists{/gist_id}","starred_url":"https://api.github.com/users/muratg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratg/subscriptions","organizations_url":"https://api.github.com/users/muratg/orgs","repos_url":"https://api.github.com/users/muratg/repos","events_url":"https://api.github.com/users/muratg/events{/privacy}","received_events_url":"https://api.github.com/users/muratg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/BuildTools/pulls/869/commits","review_comments_url":"https://api.github.com/repos/aspnet/BuildTools/pulls/869/comments","review_comment_url":"https://api.github.com/repos/aspnet/BuildTools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/BuildTools/issues/869/comments","statuses_url":"https://api.github.com/repos/aspnet/BuildTools/statuses/4315ca45aa35139b82b7ea46cd2268a281348050","head":{"label":"aspnet:namc/full-msbuild","ref":"namc/full-msbuild","sha":"4315ca45aa35139b82b7ea46cd2268a281348050","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":37751654,"node_id":"MDEwOlJlcG9zaXRvcnkzNzc1MTY1NA==","name":"BuildTools","full_name":"aspnet/BuildTools","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/BuildTools","description":"Infrastructure utilities used in the build system","fork":false,"url":"https://api.github.com/repos/aspnet/BuildTools","forks_url":"https://api.github.com/repos/aspnet/BuildTools/forks","keys_url":"https://api.github.com/repos/aspnet/BuildTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/BuildTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/BuildTools/teams","hooks_url":"https://api.github.com/repos/aspnet/BuildTools/hooks","issue_events_url":"https://api.github.com/repos/aspnet/BuildTools/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/BuildTools/events","assignees_url":"https://api.github.com/repos/aspnet/BuildTools/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/BuildTools/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/BuildTools/tags","blobs_url":"https://api.github.com/repos/aspnet/BuildTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/BuildTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/BuildTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/BuildTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/BuildTools/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/BuildTools/languages","stargazers_url":"https://api.github.com/repos/aspnet/BuildTools/stargazers","contributors_url":"https://api.github.com/repos/aspnet/BuildTools/contributors","subscribers_url":"https://api.github.com/repos/aspnet/BuildTools/subscribers","subscription_url":"https://api.github.com/repos/aspnet/BuildTools/subscription","commits_url":"https://api.github.com/repos/aspnet/BuildTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/BuildTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/BuildTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/BuildTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/BuildTools/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/BuildTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/BuildTools/merges","archive_url":"https://api.github.com/repos/aspnet/BuildTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/BuildTools/downloads","issues_url":"https://api.github.com/repos/aspnet/BuildTools/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/BuildTools/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/BuildTools/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/BuildTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/BuildTools/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/BuildTools/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/BuildTools/deployments","created_at":"2015-06-20T00:09:11Z","updated_at":"2018-11-13T01:47:45Z","pushed_at":"2018-11-13T17:56:13Z","git_url":"git://github.com/aspnet/BuildTools.git","ssh_url":"git@github.com:aspnet/BuildTools.git","clone_url":"https://github.com/aspnet/BuildTools.git","svn_url":"https://github.com/aspnet/BuildTools","homepage":"","size":3738,"stargazers_count":55,"watchers_count":55,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":16,"watchers":55,"default_branch":"master"}},"base":{"label":"aspnet:release/2.1","ref":"release/2.1","sha":"8d031079e81ea30446712d48f7e8e9539fb92907","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":37751654,"node_id":"MDEwOlJlcG9zaXRvcnkzNzc1MTY1NA==","name":"BuildTools","full_name":"aspnet/BuildTools","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/BuildTools","description":"Infrastructure utilities used in the build system","fork":false,"url":"https://api.github.com/repos/aspnet/BuildTools","forks_url":"https://api.github.com/repos/aspnet/BuildTools/forks","keys_url":"https://api.github.com/repos/aspnet/BuildTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/BuildTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/BuildTools/teams","hooks_url":"https://api.github.com/repos/aspnet/BuildTools/hooks","issue_events_url":"https://api.github.com/repos/aspnet/BuildTools/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/BuildTools/events","assignees_url":"https://api.github.com/repos/aspnet/BuildTools/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/BuildTools/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/BuildTools/tags","blobs_url":"https://api.github.com/repos/aspnet/BuildTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/BuildTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/BuildTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/BuildTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/BuildTools/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/BuildTools/languages","stargazers_url":"https://api.github.com/repos/aspnet/BuildTools/stargazers","contributors_url":"https://api.github.com/repos/aspnet/BuildTools/contributors","subscribers_url":"https://api.github.com/repos/aspnet/BuildTools/subscribers","subscription_url":"https://api.github.com/repos/aspnet/BuildTools/subscription","commits_url":"https://api.github.com/repos/aspnet/BuildTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/BuildTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/BuildTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/BuildTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/BuildTools/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/BuildTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/BuildTools/merges","archive_url":"https://api.github.com/repos/aspnet/BuildTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/BuildTools/downloads","issues_url":"https://api.github.com/repos/aspnet/BuildTools/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/BuildTools/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/BuildTools/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/BuildTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/BuildTools/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/BuildTools/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/BuildTools/deployments","created_at":"2015-06-20T00:09:11Z","updated_at":"2018-11-13T01:47:45Z","pushed_at":"2018-11-13T17:56:13Z","git_url":"git://github.com/aspnet/BuildTools.git","ssh_url":"git@github.com:aspnet/BuildTools.git","clone_url":"https://github.com/aspnet/BuildTools.git","svn_url":"https://github.com/aspnet/BuildTools","homepage":"","size":3738,"stargazers_count":55,"watchers_count":55,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":16,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/BuildTools/pulls/869"},"html":{"href":"https://github.com/aspnet/BuildTools/pull/869"},"issue":{"href":"https://api.github.com/repos/aspnet/BuildTools/issues/869"},"comments":{"href":"https://api.github.com/repos/aspnet/BuildTools/issues/869/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/BuildTools/pulls/869/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/BuildTools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/BuildTools/pulls/869/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/BuildTools/statuses/4315ca45aa35139b82b7ea46cd2268a281348050"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"natemcmaster"}}