{"action":"created","comment":{"url":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/comments/205373988","pull_request_review_id":140629001,"id":205373988,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTM3Mzk4OA==","diff_hunk":"@@ -0,0 +1,73 @@\n+/*\n+ * This file is part of otf2xx (https://github.com/tud-zih-energy/otf2xx)\n+ * otf2xx - A wrapper for the Open Trace Format 2 library\n+ *\n+ * Copyright (c) 2013-2018, Technische Universitaet Dresden, Germany\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *\n+ * * Redistributions of source code must retain the above copyright notice, this\n+ *   list of conditions and the following disclaimer.\n+ *\n+ * * Redistributions in binary form must reproduce the above copyright notice,\n+ *   this list of conditions and the following disclaimer in the documentation\n+ *   and/or other materials provided with the distribution.\n+ *\n+ * * Neither the name of the copyright holder nor the names of its\n+ *   contributors may be used to endorse or promote products derived from\n+ *   this software without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE\n+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE\n+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL\n+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR\n+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,\n+ * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ *\n+ */\n+\n+#include \"testHelpers.hpp\"\n+#include <otf2xx/otf2.hpp>\n+\n+int main()\n+{\n+    namespace def = otf2::definition;\n+    namespace common = otf2::common;\n+\n+    def::container<def::string> strings;\n+    strings.add_definition({ 0, \"0\" });\n+    strings.add_definition({ 1, \"1\" });\n+    strings.add_definition({ 2, \"2\" });\n+    strings.add_definition({ 3, \"3\" });\n+    strings.add_definition({ 4, \"4\" });\n+    strings.add_definition({ 5, \"5\" });\n+    strings.add_definition({ 6, \"6\" });\n+\n+    def::system_tree_node root_node(0, strings[0], strings[1]);\n+\n+    def::location_group lg(0, strings[2], def::location_group::location_group_type::process,\n+                           root_node);\n+\n+    def::location location(0, strings[3], lg, def::location::location_type::cpu_thread);\n+\n+    def::metric_class mClass(0, common::metric_occurence::strict, common::recorder_kind::abstract);\n+    def::metric_instance mInstance(0, mClass, location, location);\n+    def::metric_member mMember(0, strings[4], strings[5], common::metric_type::other,\n+                               common::metric_mode::accumulated_point, common::type::uint8,\n+                               common::base_type::binary, 0, strings[6]);\n+    mClass.add_member(mMember);\n+    TEST(mInstance.metric_class() == mClass);\n+\n+    otf2::event::metric ev(otf2::chrono::genesis(), mInstance);\n+\n+    TEST(!ev.has_metric_class());","path":"tests/metric_events.cpp","position":69,"original_position":69,"commit_id":"8e6a4e0e1f9d1d6f1c54acd84ed0dcc5c8b0b442","original_commit_id":"039bcb7d3cd360dbcc50630cc5af17980d131d4a","user":{"login":"bmario","id":130405,"node_id":"MDQ6VXNlcjEzMDQwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/130405?v=4","gravatar_id":"","url":"https://api.github.com/users/bmario","html_url":"https://github.com/bmario","followers_url":"https://api.github.com/users/bmario/followers","following_url":"https://api.github.com/users/bmario/following{/other_user}","gists_url":"https://api.github.com/users/bmario/gists{/gist_id}","starred_url":"https://api.github.com/users/bmario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmario/subscriptions","organizations_url":"https://api.github.com/users/bmario/orgs","repos_url":"https://api.github.com/users/bmario/repos","events_url":"https://api.github.com/users/bmario/events{/privacy}","received_events_url":"https://api.github.com/users/bmario/received_events","type":"User","site_admin":false},"body":"If you want that, please just add Catch2","created_at":"2018-07-26T08:39:27Z","updated_at":"2018-07-26T08:39:28Z","html_url":"https://github.com/tud-zih-energy/otf2xx/pull/19#discussion_r205373988","pull_request_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/19","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/comments/205373988"},"html":{"href":"https://github.com/tud-zih-energy/otf2xx/pull/19#discussion_r205373988"},"pull_request":{"href":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/19","id":204050054,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MDUwMDU0","html_url":"https://github.com/tud-zih-energy/otf2xx/pull/19","diff_url":"https://github.com/tud-zih-energy/otf2xx/pull/19.diff","patch_url":"https://github.com/tud-zih-energy/otf2xx/pull/19.patch","issue_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/issues/19","number":19,"state":"open","locked":false,"title":"Add test using metric class and metric instance","user":{"login":"Flamefire","id":309017,"node_id":"MDQ6VXNlcjMwOTAxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/309017?v=4","gravatar_id":"","url":"https://api.github.com/users/Flamefire","html_url":"https://github.com/Flamefire","followers_url":"https://api.github.com/users/Flamefire/followers","following_url":"https://api.github.com/users/Flamefire/following{/other_user}","gists_url":"https://api.github.com/users/Flamefire/gists{/gist_id}","starred_url":"https://api.github.com/users/Flamefire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flamefire/subscriptions","organizations_url":"https://api.github.com/users/Flamefire/orgs","repos_url":"https://api.github.com/users/Flamefire/repos","events_url":"https://api.github.com/users/Flamefire/events{/privacy}","received_events_url":"https://api.github.com/users/Flamefire/received_events","type":"User","site_admin":false},"body":"Also contains some changes to the `make_exception` functions as I'm using them for the tests.","created_at":"2018-07-26T07:22:23Z","updated_at":"2018-07-26T08:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b358e1becb6544bf987c8206077efb56056740c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/19/commits","review_comments_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/19/comments","review_comment_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/issues/19/comments","statuses_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/statuses/8e6a4e0e1f9d1d6f1c54acd84ed0dcc5c8b0b442","head":{"label":"Flamefire:metric_event_test","ref":"metric_event_test","sha":"8e6a4e0e1f9d1d6f1c54acd84ed0dcc5c8b0b442","user":{"login":"Flamefire","id":309017,"node_id":"MDQ6VXNlcjMwOTAxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/309017?v=4","gravatar_id":"","url":"https://api.github.com/users/Flamefire","html_url":"https://github.com/Flamefire","followers_url":"https://api.github.com/users/Flamefire/followers","following_url":"https://api.github.com/users/Flamefire/following{/other_user}","gists_url":"https://api.github.com/users/Flamefire/gists{/gist_id}","starred_url":"https://api.github.com/users/Flamefire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flamefire/subscriptions","organizations_url":"https://api.github.com/users/Flamefire/orgs","repos_url":"https://api.github.com/users/Flamefire/repos","events_url":"https://api.github.com/users/Flamefire/events{/privacy}","received_events_url":"https://api.github.com/users/Flamefire/received_events","type":"User","site_admin":false},"repo":{"id":141304444,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMDQ0NDQ=","name":"otf2xx","full_name":"Flamefire/otf2xx","owner":{"login":"Flamefire","id":309017,"node_id":"MDQ6VXNlcjMwOTAxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/309017?v=4","gravatar_id":"","url":"https://api.github.com/users/Flamefire","html_url":"https://github.com/Flamefire","followers_url":"https://api.github.com/users/Flamefire/followers","following_url":"https://api.github.com/users/Flamefire/following{/other_user}","gists_url":"https://api.github.com/users/Flamefire/gists{/gist_id}","starred_url":"https://api.github.com/users/Flamefire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flamefire/subscriptions","organizations_url":"https://api.github.com/users/Flamefire/orgs","repos_url":"https://api.github.com/users/Flamefire/repos","events_url":"https://api.github.com/users/Flamefire/events{/privacy}","received_events_url":"https://api.github.com/users/Flamefire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Flamefire/otf2xx","description":"C++ wrapper for Open Trace Format 2","fork":true,"url":"https://api.github.com/repos/Flamefire/otf2xx","forks_url":"https://api.github.com/repos/Flamefire/otf2xx/forks","keys_url":"https://api.github.com/repos/Flamefire/otf2xx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flamefire/otf2xx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flamefire/otf2xx/teams","hooks_url":"https://api.github.com/repos/Flamefire/otf2xx/hooks","issue_events_url":"https://api.github.com/repos/Flamefire/otf2xx/issues/events{/number}","events_url":"https://api.github.com/repos/Flamefire/otf2xx/events","assignees_url":"https://api.github.com/repos/Flamefire/otf2xx/assignees{/user}","branches_url":"https://api.github.com/repos/Flamefire/otf2xx/branches{/branch}","tags_url":"https://api.github.com/repos/Flamefire/otf2xx/tags","blobs_url":"https://api.github.com/repos/Flamefire/otf2xx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flamefire/otf2xx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flamefire/otf2xx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flamefire/otf2xx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flamefire/otf2xx/statuses/{sha}","languages_url":"https://api.github.com/repos/Flamefire/otf2xx/languages","stargazers_url":"https://api.github.com/repos/Flamefire/otf2xx/stargazers","contributors_url":"https://api.github.com/repos/Flamefire/otf2xx/contributors","subscribers_url":"https://api.github.com/repos/Flamefire/otf2xx/subscribers","subscription_url":"https://api.github.com/repos/Flamefire/otf2xx/subscription","commits_url":"https://api.github.com/repos/Flamefire/otf2xx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flamefire/otf2xx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flamefire/otf2xx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flamefire/otf2xx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flamefire/otf2xx/contents/{+path}","compare_url":"https://api.github.com/repos/Flamefire/otf2xx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flamefire/otf2xx/merges","archive_url":"https://api.github.com/repos/Flamefire/otf2xx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flamefire/otf2xx/downloads","issues_url":"https://api.github.com/repos/Flamefire/otf2xx/issues{/number}","pulls_url":"https://api.github.com/repos/Flamefire/otf2xx/pulls{/number}","milestones_url":"https://api.github.com/repos/Flamefire/otf2xx/milestones{/number}","notifications_url":"https://api.github.com/repos/Flamefire/otf2xx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flamefire/otf2xx/labels{/name}","releases_url":"https://api.github.com/repos/Flamefire/otf2xx/releases{/id}","deployments_url":"https://api.github.com/repos/Flamefire/otf2xx/deployments","created_at":"2018-07-17T14:53:25Z","updated_at":"2018-07-17T14:53:28Z","pushed_at":"2018-07-26T08:32:42Z","git_url":"git://github.com/Flamefire/otf2xx.git","ssh_url":"git@github.com:Flamefire/otf2xx.git","clone_url":"https://github.com/Flamefire/otf2xx.git","svn_url":"https://github.com/Flamefire/otf2xx","homepage":null,"size":357,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tud-zih-energy:master","ref":"master","sha":"9cca095c7ebf17fca92152f19dbca0d43136632e","user":{"login":"tud-zih-energy","id":14329082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzI5MDgy","avatar_url":"https://avatars2.githubusercontent.com/u/14329082?v=4","gravatar_id":"","url":"https://api.github.com/users/tud-zih-energy","html_url":"https://github.com/tud-zih-energy","followers_url":"https://api.github.com/users/tud-zih-energy/followers","following_url":"https://api.github.com/users/tud-zih-energy/following{/other_user}","gists_url":"https://api.github.com/users/tud-zih-energy/gists{/gist_id}","starred_url":"https://api.github.com/users/tud-zih-energy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tud-zih-energy/subscriptions","organizations_url":"https://api.github.com/users/tud-zih-energy/orgs","repos_url":"https://api.github.com/users/tud-zih-energy/repos","events_url":"https://api.github.com/users/tud-zih-energy/events{/privacy}","received_events_url":"https://api.github.com/users/tud-zih-energy/received_events","type":"Organization","site_admin":false},"repo":{"id":73084348,"node_id":"MDEwOlJlcG9zaXRvcnk3MzA4NDM0OA==","name":"otf2xx","full_name":"tud-zih-energy/otf2xx","owner":{"login":"tud-zih-energy","id":14329082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzI5MDgy","avatar_url":"https://avatars2.githubusercontent.com/u/14329082?v=4","gravatar_id":"","url":"https://api.github.com/users/tud-zih-energy","html_url":"https://github.com/tud-zih-energy","followers_url":"https://api.github.com/users/tud-zih-energy/followers","following_url":"https://api.github.com/users/tud-zih-energy/following{/other_user}","gists_url":"https://api.github.com/users/tud-zih-energy/gists{/gist_id}","starred_url":"https://api.github.com/users/tud-zih-energy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tud-zih-energy/subscriptions","organizations_url":"https://api.github.com/users/tud-zih-energy/orgs","repos_url":"https://api.github.com/users/tud-zih-energy/repos","events_url":"https://api.github.com/users/tud-zih-energy/events{/privacy}","received_events_url":"https://api.github.com/users/tud-zih-energy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tud-zih-energy/otf2xx","description":"C++ wrapper for Open Trace Format 2","fork":false,"url":"https://api.github.com/repos/tud-zih-energy/otf2xx","forks_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/forks","keys_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/teams","hooks_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/hooks","issue_events_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/issues/events{/number}","events_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/events","assignees_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/assignees{/user}","branches_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/branches{/branch}","tags_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/tags","blobs_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/git/refs{/sha}","trees_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/statuses/{sha}","languages_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/languages","stargazers_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/stargazers","contributors_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/contributors","subscribers_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/subscribers","subscription_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/subscription","commits_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/commits{/sha}","git_commits_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/git/commits{/sha}","comments_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/comments{/number}","issue_comment_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/issues/comments{/number}","contents_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/contents/{+path}","compare_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/merges","archive_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/downloads","issues_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/issues{/number}","pulls_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls{/number}","milestones_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/milestones{/number}","notifications_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/labels{/name}","releases_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/releases{/id}","deployments_url":"https://api.github.com/repos/tud-zih-energy/otf2xx/deployments","created_at":"2016-11-07T14:06:40Z","updated_at":"2018-07-25T12:05:44Z","pushed_at":"2018-07-26T08:32:43Z","git_url":"git://github.com/tud-zih-energy/otf2xx.git","ssh_url":"git@github.com:tud-zih-energy/otf2xx.git","clone_url":"https://github.com/tud-zih-energy/otf2xx.git","svn_url":"https://github.com/tud-zih-energy/otf2xx","homepage":null,"size":356,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":9,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/19"},"html":{"href":"https://github.com/tud-zih-energy/otf2xx/pull/19"},"issue":{"href":"https://api.github.com/repos/tud-zih-energy/otf2xx/issues/19"},"comments":{"href":"https://api.github.com/repos/tud-zih-energy/otf2xx/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tud-zih-energy/otf2xx/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/tud-zih-energy/otf2xx/statuses/8e6a4e0e1f9d1d6f1c54acd84ed0dcc5c8b0b442"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bmario"}}