{"action":"opened","number":2593,"pull_request":{"url":"https://api.github.com/repos/apache/ambari/pulls/2593","id":230188804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTg4ODA0","html_url":"https://github.com/apache/ambari/pull/2593","diff_url":"https://github.com/apache/ambari/pull/2593.diff","patch_url":"https://github.com/apache/ambari/pull/2593.patch","issue_url":"https://api.github.com/repos/apache/ambari/issues/2593","number":2593,"state":"open","locked":false,"title":"AMBARI-24879. kAdmin principal name is set on the GUI when enabling Kerberos with MIT KDC using a new variable replacement function","user":{"login":"smolnar82","id":34065904,"node_id":"MDQ6VXNlcjM0MDY1OTA0","avatar_url":"https://avatars3.githubusercontent.com/u/34065904?v=4","gravatar_id":"","url":"https://api.github.com/users/smolnar82","html_url":"https://github.com/smolnar82","followers_url":"https://api.github.com/users/smolnar82/followers","following_url":"https://api.github.com/users/smolnar82/following{/other_user}","gists_url":"https://api.github.com/users/smolnar82/gists{/gist_id}","starred_url":"https://api.github.com/users/smolnar82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smolnar82/subscriptions","organizations_url":"https://api.github.com/users/smolnar82/orgs","repos_url":"https://api.github.com/users/smolnar82/repos","events_url":"https://api.github.com/users/smolnar82/events{/privacy}","received_events_url":"https://api.github.com/users/smolnar82/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThe kadmin service principal name should be configurable for MIT KDC interactions. The current process assumes the kadmin service principal is `kadmin/FQDN_KADMIN_HOST`, but this could be different on some installations. For example, `kadmin/admin`.\r\n\r\nA new `kerberos-env` property should be added to allow a user to change the kadmin principal name - `kerberos-env/kadmin_principal_name`\r\n\r\nThe default value for the new property should be `kadmin/${admin_server_host|stripPort()}`.  To be able to do this, we have to create a new variable replacement function. For example, `stripPort`.\r\n\r\n**Note**: related stack change is going to be submitted separately.\r\n\r\n## How was this patch tested?\r\n\r\nExecuting JUnit tests locally in `ambari-server`:\r\n```\r\n[INFO] ------------------------------------------------------------------------\r\n[INFO] BUILD SUCCESS\r\n[INFO] ------------------------------------------------------------------------\r\n[INFO] Total time: 26:12 min\r\n[INFO] Finished at: 2018-11-12T16:43:44+01:00\r\n[INFO] Final Memory: 163M/1033M\r\n[INFO] ------------------------------------------------------------------------\r\n```\r\n\r\nIn addition to this I did an E2E testing within my vagrant environment where Kerberos was enabled using the new property (leave as the default and changing it to a custom value).\r\n\r\n<img width=\"1549\" alt=\"screen shot 2018-11-12 at 5 11 54 pm\" src=\"https://user-images.githubusercontent.com/34065904/48359834-1963eb00-e69e-11e8-9b05-38f5eb94a2d2.png\">\r\n","created_at":"2018-11-12T16:12:32Z","updated_at":"2018-11-12T16:12:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/ambari/pulls/2593/commits","review_comments_url":"https://api.github.com/repos/apache/ambari/pulls/2593/comments","review_comment_url":"https://api.github.com/repos/apache/ambari/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/ambari/issues/2593/comments","statuses_url":"https://api.github.com/repos/apache/ambari/statuses/815e0084d170f338ea539e8b58885d35cbad5740","head":{"label":"smolnar82:AMBARI-24879","ref":"AMBARI-24879","sha":"815e0084d170f338ea539e8b58885d35cbad5740","user":{"login":"smolnar82","id":34065904,"node_id":"MDQ6VXNlcjM0MDY1OTA0","avatar_url":"https://avatars3.githubusercontent.com/u/34065904?v=4","gravatar_id":"","url":"https://api.github.com/users/smolnar82","html_url":"https://github.com/smolnar82","followers_url":"https://api.github.com/users/smolnar82/followers","following_url":"https://api.github.com/users/smolnar82/following{/other_user}","gists_url":"https://api.github.com/users/smolnar82/gists{/gist_id}","starred_url":"https://api.github.com/users/smolnar82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smolnar82/subscriptions","organizations_url":"https://api.github.com/users/smolnar82/orgs","repos_url":"https://api.github.com/users/smolnar82/repos","events_url":"https://api.github.com/users/smolnar82/events{/privacy}","received_events_url":"https://api.github.com/users/smolnar82/received_events","type":"User","site_admin":false},"repo":{"id":116741551,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY3NDE1NTE=","name":"ambari","full_name":"smolnar82/ambari","private":false,"owner":{"login":"smolnar82","id":34065904,"node_id":"MDQ6VXNlcjM0MDY1OTA0","avatar_url":"https://avatars3.githubusercontent.com/u/34065904?v=4","gravatar_id":"","url":"https://api.github.com/users/smolnar82","html_url":"https://github.com/smolnar82","followers_url":"https://api.github.com/users/smolnar82/followers","following_url":"https://api.github.com/users/smolnar82/following{/other_user}","gists_url":"https://api.github.com/users/smolnar82/gists{/gist_id}","starred_url":"https://api.github.com/users/smolnar82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smolnar82/subscriptions","organizations_url":"https://api.github.com/users/smolnar82/orgs","repos_url":"https://api.github.com/users/smolnar82/repos","events_url":"https://api.github.com/users/smolnar82/events{/privacy}","received_events_url":"https://api.github.com/users/smolnar82/received_events","type":"User","site_admin":false},"html_url":"https://github.com/smolnar82/ambari","description":"Mirror of Apache Ambari","fork":true,"url":"https://api.github.com/repos/smolnar82/ambari","forks_url":"https://api.github.com/repos/smolnar82/ambari/forks","keys_url":"https://api.github.com/repos/smolnar82/ambari/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smolnar82/ambari/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smolnar82/ambari/teams","hooks_url":"https://api.github.com/repos/smolnar82/ambari/hooks","issue_events_url":"https://api.github.com/repos/smolnar82/ambari/issues/events{/number}","events_url":"https://api.github.com/repos/smolnar82/ambari/events","assignees_url":"https://api.github.com/repos/smolnar82/ambari/assignees{/user}","branches_url":"https://api.github.com/repos/smolnar82/ambari/branches{/branch}","tags_url":"https://api.github.com/repos/smolnar82/ambari/tags","blobs_url":"https://api.github.com/repos/smolnar82/ambari/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smolnar82/ambari/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smolnar82/ambari/git/refs{/sha}","trees_url":"https://api.github.com/repos/smolnar82/ambari/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smolnar82/ambari/statuses/{sha}","languages_url":"https://api.github.com/repos/smolnar82/ambari/languages","stargazers_url":"https://api.github.com/repos/smolnar82/ambari/stargazers","contributors_url":"https://api.github.com/repos/smolnar82/ambari/contributors","subscribers_url":"https://api.github.com/repos/smolnar82/ambari/subscribers","subscription_url":"https://api.github.com/repos/smolnar82/ambari/subscription","commits_url":"https://api.github.com/repos/smolnar82/ambari/commits{/sha}","git_commits_url":"https://api.github.com/repos/smolnar82/ambari/git/commits{/sha}","comments_url":"https://api.github.com/repos/smolnar82/ambari/comments{/number}","issue_comment_url":"https://api.github.com/repos/smolnar82/ambari/issues/comments{/number}","contents_url":"https://api.github.com/repos/smolnar82/ambari/contents/{+path}","compare_url":"https://api.github.com/repos/smolnar82/ambari/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smolnar82/ambari/merges","archive_url":"https://api.github.com/repos/smolnar82/ambari/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smolnar82/ambari/downloads","issues_url":"https://api.github.com/repos/smolnar82/ambari/issues{/number}","pulls_url":"https://api.github.com/repos/smolnar82/ambari/pulls{/number}","milestones_url":"https://api.github.com/repos/smolnar82/ambari/milestones{/number}","notifications_url":"https://api.github.com/repos/smolnar82/ambari/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smolnar82/ambari/labels{/name}","releases_url":"https://api.github.com/repos/smolnar82/ambari/releases{/id}","deployments_url":"https://api.github.com/repos/smolnar82/ambari/deployments","created_at":"2018-01-08T23:46:15Z","updated_at":"2018-11-12T15:17:12Z","pushed_at":"2018-11-12T16:05:55Z","git_url":"git://github.com/smolnar82/ambari.git","ssh_url":"git@github.com:smolnar82/ambari.git","clone_url":"https://github.com/smolnar82/ambari.git","svn_url":"https://github.com/smolnar82/ambari","homepage":null,"size":323668,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"4eee0f56d2fbfdfb0caace955339bc0c46a85a3c","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2442457,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQyNDU3","name":"ambari","full_name":"apache/ambari","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/ambari","description":"Mirror of Apache Ambari","fork":false,"url":"https://api.github.com/repos/apache/ambari","forks_url":"https://api.github.com/repos/apache/ambari/forks","keys_url":"https://api.github.com/repos/apache/ambari/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/ambari/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/ambari/teams","hooks_url":"https://api.github.com/repos/apache/ambari/hooks","issue_events_url":"https://api.github.com/repos/apache/ambari/issues/events{/number}","events_url":"https://api.github.com/repos/apache/ambari/events","assignees_url":"https://api.github.com/repos/apache/ambari/assignees{/user}","branches_url":"https://api.github.com/repos/apache/ambari/branches{/branch}","tags_url":"https://api.github.com/repos/apache/ambari/tags","blobs_url":"https://api.github.com/repos/apache/ambari/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/ambari/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/ambari/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/ambari/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/ambari/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/ambari/languages","stargazers_url":"https://api.github.com/repos/apache/ambari/stargazers","contributors_url":"https://api.github.com/repos/apache/ambari/contributors","subscribers_url":"https://api.github.com/repos/apache/ambari/subscribers","subscription_url":"https://api.github.com/repos/apache/ambari/subscription","commits_url":"https://api.github.com/repos/apache/ambari/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/ambari/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/ambari/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/ambari/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/ambari/contents/{+path}","compare_url":"https://api.github.com/repos/apache/ambari/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/ambari/merges","archive_url":"https://api.github.com/repos/apache/ambari/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/ambari/downloads","issues_url":"https://api.github.com/repos/apache/ambari/issues{/number}","pulls_url":"https://api.github.com/repos/apache/ambari/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/ambari/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/ambari/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/ambari/labels{/name}","releases_url":"https://api.github.com/repos/apache/ambari/releases{/id}","deployments_url":"https://api.github.com/repos/apache/ambari/deployments","created_at":"2011-09-23T07:00:08Z","updated_at":"2018-11-12T08:50:29Z","pushed_at":"2018-11-12T13:57:19Z","git_url":"git://github.com/apache/ambari.git","ssh_url":"git@github.com:apache/ambari.git","clone_url":"https://github.com/apache/ambari.git","svn_url":"https://github.com/apache/ambari","homepage":null,"size":337421,"stargazers_count":953,"watchers_count":953,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":966,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":966,"open_issues":14,"watchers":953,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/ambari/pulls/2593"},"html":{"href":"https://github.com/apache/ambari/pull/2593"},"issue":{"href":"https://api.github.com/repos/apache/ambari/issues/2593"},"comments":{"href":"https://api.github.com/repos/apache/ambari/issues/2593/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/ambari/pulls/2593/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/ambari/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/ambari/pulls/2593/commits"},"statuses":{"href":"https://api.github.com/repos/apache/ambari/statuses/815e0084d170f338ea539e8b58885d35cbad5740"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":60,"deletions":14,"changed_files":7}}
{"actor":{"display_login":"smolnar82"}}