{"action":"closed","number":142,"pull_request":{"url":"https://api.github.com/repos/sunchao/parquet-rs/pulls/142","id":207159996,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTU5OTk2","html_url":"https://github.com/sunchao/parquet-rs/pull/142","diff_url":"https://github.com/sunchao/parquet-rs/pull/142.diff","patch_url":"https://github.com/sunchao/parquet-rs/pull/142.patch","issue_url":"https://api.github.com/repos/sunchao/parquet-rs/issues/142","number":142,"state":"closed","locked":false,"title":"Generic reader","user":{"login":"gnieto","id":4637936,"node_id":"MDQ6VXNlcjQ2Mzc5MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4637936?v=4","gravatar_id":"","url":"https://api.github.com/users/gnieto","html_url":"https://github.com/gnieto","followers_url":"https://api.github.com/users/gnieto/followers","following_url":"https://api.github.com/users/gnieto/following{/other_user}","gists_url":"https://api.github.com/users/gnieto/gists{/gist_id}","starred_url":"https://api.github.com/users/gnieto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnieto/subscriptions","organizations_url":"https://api.github.com/users/gnieto/orgs","repos_url":"https://api.github.com/users/gnieto/repos","events_url":"https://api.github.com/users/gnieto/events{/privacy}","received_events_url":"https://api.github.com/users/gnieto/received_events","type":"User","site_admin":false},"body":"Generalized FileReader in order to allow multiple inner readers. This\r\nwill allow to be able to parse from an in-memory buffer, for example\r\n(via Cursor<&[u8]>, for example).\r\n\r\nNote that there are still some issues because of 'static lifetimes (I\r\nguess that it's still due to some type referencing `DataType`), which\r\nlimits a little bit how it may be used. For example, this example does\r\nnot work at the moment:\r\n\r\n```rust\r\n    let v = vec![0, 1, 2, 3];\r\n    let c = Cursor::new(v.as_ref());\r\n    let serialized = SerializedFileReader::new(c).unwrap();\r\n\r\n    // compiler refuses to compile due to `v does not life enough`\r\n    let iterator = serialized.get_row_iter(None).unwrap();\r\n```\r\n--- \r\n\r\nI've had to add some generic annotations. If you don't like it, I can Box it (but i think that it adds some usability issues).","created_at":"2018-08-08T22:55:33Z","updated_at":"2018-08-15T16:36:37Z","closed_at":"2018-08-15T16:36:37Z","merged_at":"2018-08-15T16:36:37Z","merge_commit_sha":"8827b634033b3690c9b19e6788b0b55b0b9514ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sunchao/parquet-rs/pulls/142/commits","review_comments_url":"https://api.github.com/repos/sunchao/parquet-rs/pulls/142/comments","review_comment_url":"https://api.github.com/repos/sunchao/parquet-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sunchao/parquet-rs/issues/142/comments","statuses_url":"https://api.github.com/repos/sunchao/parquet-rs/statuses/6513e5deebe6bd23f85c3b9188aa4ef3d8edd7f7","head":{"label":"gnieto:read4","ref":"read4","sha":"6513e5deebe6bd23f85c3b9188aa4ef3d8edd7f7","user":{"login":"gnieto","id":4637936,"node_id":"MDQ6VXNlcjQ2Mzc5MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4637936?v=4","gravatar_id":"","url":"https://api.github.com/users/gnieto","html_url":"https://github.com/gnieto","followers_url":"https://api.github.com/users/gnieto/followers","following_url":"https://api.github.com/users/gnieto/following{/other_user}","gists_url":"https://api.github.com/users/gnieto/gists{/gist_id}","starred_url":"https://api.github.com/users/gnieto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnieto/subscriptions","organizations_url":"https://api.github.com/users/gnieto/orgs","repos_url":"https://api.github.com/users/gnieto/repos","events_url":"https://api.github.com/users/gnieto/events{/privacy}","received_events_url":"https://api.github.com/users/gnieto/received_events","type":"User","site_admin":false},"repo":{"id":142503964,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI1MDM5NjQ=","name":"parquet-rs","full_name":"gnieto/parquet-rs","owner":{"login":"gnieto","id":4637936,"node_id":"MDQ6VXNlcjQ2Mzc5MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4637936?v=4","gravatar_id":"","url":"https://api.github.com/users/gnieto","html_url":"https://github.com/gnieto","followers_url":"https://api.github.com/users/gnieto/followers","following_url":"https://api.github.com/users/gnieto/following{/other_user}","gists_url":"https://api.github.com/users/gnieto/gists{/gist_id}","starred_url":"https://api.github.com/users/gnieto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnieto/subscriptions","organizations_url":"https://api.github.com/users/gnieto/orgs","repos_url":"https://api.github.com/users/gnieto/repos","events_url":"https://api.github.com/users/gnieto/events{/privacy}","received_events_url":"https://api.github.com/users/gnieto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gnieto/parquet-rs","description":"Apache Parquet implementation in Rust","fork":true,"url":"https://api.github.com/repos/gnieto/parquet-rs","forks_url":"https://api.github.com/repos/gnieto/parquet-rs/forks","keys_url":"https://api.github.com/repos/gnieto/parquet-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnieto/parquet-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnieto/parquet-rs/teams","hooks_url":"https://api.github.com/repos/gnieto/parquet-rs/hooks","issue_events_url":"https://api.github.com/repos/gnieto/parquet-rs/issues/events{/number}","events_url":"https://api.github.com/repos/gnieto/parquet-rs/events","assignees_url":"https://api.github.com/repos/gnieto/parquet-rs/assignees{/user}","branches_url":"https://api.github.com/repos/gnieto/parquet-rs/branches{/branch}","tags_url":"https://api.github.com/repos/gnieto/parquet-rs/tags","blobs_url":"https://api.github.com/repos/gnieto/parquet-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnieto/parquet-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnieto/parquet-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnieto/parquet-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnieto/parquet-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/gnieto/parquet-rs/languages","stargazers_url":"https://api.github.com/repos/gnieto/parquet-rs/stargazers","contributors_url":"https://api.github.com/repos/gnieto/parquet-rs/contributors","subscribers_url":"https://api.github.com/repos/gnieto/parquet-rs/subscribers","subscription_url":"https://api.github.com/repos/gnieto/parquet-rs/subscription","commits_url":"https://api.github.com/repos/gnieto/parquet-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnieto/parquet-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnieto/parquet-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnieto/parquet-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnieto/parquet-rs/contents/{+path}","compare_url":"https://api.github.com/repos/gnieto/parquet-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnieto/parquet-rs/merges","archive_url":"https://api.github.com/repos/gnieto/parquet-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnieto/parquet-rs/downloads","issues_url":"https://api.github.com/repos/gnieto/parquet-rs/issues{/number}","pulls_url":"https://api.github.com/repos/gnieto/parquet-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/gnieto/parquet-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/gnieto/parquet-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnieto/parquet-rs/labels{/name}","releases_url":"https://api.github.com/repos/gnieto/parquet-rs/releases{/id}","deployments_url":"https://api.github.com/repos/gnieto/parquet-rs/deployments","created_at":"2018-07-26T23:24:18Z","updated_at":"2018-07-26T23:24:20Z","pushed_at":"2018-08-09T18:53:03Z","git_url":"git://github.com/gnieto/parquet-rs.git","ssh_url":"git@github.com:gnieto/parquet-rs.git","clone_url":"https://github.com/gnieto/parquet-rs.git","svn_url":"https://github.com/gnieto/parquet-rs","homepage":"","size":2313,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sunchao:master","ref":"master","sha":"8efc63dd0d2a5c838261723c989815e55a7f06e2","user":{"login":"sunchao","id":506679,"node_id":"MDQ6VXNlcjUwNjY3OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/506679?v=4","gravatar_id":"","url":"https://api.github.com/users/sunchao","html_url":"https://github.com/sunchao","followers_url":"https://api.github.com/users/sunchao/followers","following_url":"https://api.github.com/users/sunchao/following{/other_user}","gists_url":"https://api.github.com/users/sunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/sunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunchao/subscriptions","organizations_url":"https://api.github.com/users/sunchao/orgs","repos_url":"https://api.github.com/users/sunchao/repos","events_url":"https://api.github.com/users/sunchao/events{/privacy}","received_events_url":"https://api.github.com/users/sunchao/received_events","type":"User","site_admin":false},"repo":{"id":69204003,"node_id":"MDEwOlJlcG9zaXRvcnk2OTIwNDAwMw==","name":"parquet-rs","full_name":"sunchao/parquet-rs","owner":{"login":"sunchao","id":506679,"node_id":"MDQ6VXNlcjUwNjY3OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/506679?v=4","gravatar_id":"","url":"https://api.github.com/users/sunchao","html_url":"https://github.com/sunchao","followers_url":"https://api.github.com/users/sunchao/followers","following_url":"https://api.github.com/users/sunchao/following{/other_user}","gists_url":"https://api.github.com/users/sunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/sunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunchao/subscriptions","organizations_url":"https://api.github.com/users/sunchao/orgs","repos_url":"https://api.github.com/users/sunchao/repos","events_url":"https://api.github.com/users/sunchao/events{/privacy}","received_events_url":"https://api.github.com/users/sunchao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sunchao/parquet-rs","description":"Apache Parquet implementation in Rust","fork":false,"url":"https://api.github.com/repos/sunchao/parquet-rs","forks_url":"https://api.github.com/repos/sunchao/parquet-rs/forks","keys_url":"https://api.github.com/repos/sunchao/parquet-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunchao/parquet-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunchao/parquet-rs/teams","hooks_url":"https://api.github.com/repos/sunchao/parquet-rs/hooks","issue_events_url":"https://api.github.com/repos/sunchao/parquet-rs/issues/events{/number}","events_url":"https://api.github.com/repos/sunchao/parquet-rs/events","assignees_url":"https://api.github.com/repos/sunchao/parquet-rs/assignees{/user}","branches_url":"https://api.github.com/repos/sunchao/parquet-rs/branches{/branch}","tags_url":"https://api.github.com/repos/sunchao/parquet-rs/tags","blobs_url":"https://api.github.com/repos/sunchao/parquet-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunchao/parquet-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunchao/parquet-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunchao/parquet-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunchao/parquet-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/sunchao/parquet-rs/languages","stargazers_url":"https://api.github.com/repos/sunchao/parquet-rs/stargazers","contributors_url":"https://api.github.com/repos/sunchao/parquet-rs/contributors","subscribers_url":"https://api.github.com/repos/sunchao/parquet-rs/subscribers","subscription_url":"https://api.github.com/repos/sunchao/parquet-rs/subscription","commits_url":"https://api.github.com/repos/sunchao/parquet-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunchao/parquet-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunchao/parquet-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunchao/parquet-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunchao/parquet-rs/contents/{+path}","compare_url":"https://api.github.com/repos/sunchao/parquet-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunchao/parquet-rs/merges","archive_url":"https://api.github.com/repos/sunchao/parquet-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunchao/parquet-rs/downloads","issues_url":"https://api.github.com/repos/sunchao/parquet-rs/issues{/number}","pulls_url":"https://api.github.com/repos/sunchao/parquet-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/sunchao/parquet-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/sunchao/parquet-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunchao/parquet-rs/labels{/name}","releases_url":"https://api.github.com/repos/sunchao/parquet-rs/releases{/id}","deployments_url":"https://api.github.com/repos/sunchao/parquet-rs/deployments","created_at":"2016-09-26T02:03:36Z","updated_at":"2018-08-14T05:34:10Z","pushed_at":"2018-08-15T16:36:37Z","git_url":"git://github.com/sunchao/parquet-rs.git","ssh_url":"git@github.com:sunchao/parquet-rs.git","clone_url":"https://github.com/sunchao/parquet-rs.git","svn_url":"https://github.com/sunchao/parquet-rs","homepage":"","size":2537,"stargazers_count":71,"watchers_count":71,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":15,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sunchao/parquet-rs/pulls/142"},"html":{"href":"https://github.com/sunchao/parquet-rs/pull/142"},"issue":{"href":"https://api.github.com/repos/sunchao/parquet-rs/issues/142"},"comments":{"href":"https://api.github.com/repos/sunchao/parquet-rs/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/sunchao/parquet-rs/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/sunchao/parquet-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sunchao/parquet-rs/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/sunchao/parquet-rs/statuses/6513e5deebe6bd23f85c3b9188aa4ef3d8edd7f7"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sunchao","id":506679,"node_id":"MDQ6VXNlcjUwNjY3OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/506679?v=4","gravatar_id":"","url":"https://api.github.com/users/sunchao","html_url":"https://github.com/sunchao","followers_url":"https://api.github.com/users/sunchao/followers","following_url":"https://api.github.com/users/sunchao/following{/other_user}","gists_url":"https://api.github.com/users/sunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/sunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunchao/subscriptions","organizations_url":"https://api.github.com/users/sunchao/orgs","repos_url":"https://api.github.com/users/sunchao/repos","events_url":"https://api.github.com/users/sunchao/events{/privacy}","received_events_url":"https://api.github.com/users/sunchao/received_events","type":"User","site_admin":false},"comments":4,"review_comments":13,"maintainer_can_modify":false,"commits":1,"additions":89,"deletions":29,"changed_files":2}}
{"actor":{"display_login":"sunchao"}}