{"action":"created","issue":{"url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/181","repository_url":"https://api.github.com/repos/dockstore/dockstore-ui2","labels_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/181/labels{/name}","comments_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/181/comments","events_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/181/events","html_url":"https://github.com/dockstore/dockstore-ui2/pull/181","id":291696302,"number":181,"title":"Feature/node upgrade","user":{"login":"garyluu","id":24548904,"avatar_url":"https://avatars3.githubusercontent.com/u/24548904?v=4","gravatar_id":"","url":"https://api.github.com/users/garyluu","html_url":"https://github.com/garyluu","followers_url":"https://api.github.com/users/garyluu/followers","following_url":"https://api.github.com/users/garyluu/following{/other_user}","gists_url":"https://api.github.com/users/garyluu/gists{/gist_id}","starred_url":"https://api.github.com/users/garyluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyluu/subscriptions","organizations_url":"https://api.github.com/users/garyluu/orgs","repos_url":"https://api.github.com/users/garyluu/repos","events_url":"https://api.github.com/users/garyluu/events{/privacy}","received_events_url":"https://api.github.com/users/garyluu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-01-25T19:58:05Z","updated_at":"2018-02-05T21:36:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dockstore/dockstore-ui2/pulls/181","html_url":"https://github.com/dockstore/dockstore-ui2/pull/181","diff_url":"https://github.com/dockstore/dockstore-ui2/pull/181.diff","patch_url":"https://github.com/dockstore/dockstore-ui2/pull/181.patch"},"body":"Originally trying to fix the npm econreset and cypress install issue on Travis.  Ended up:\r\n\r\n- Upgrading to the current node js LTS (v8.9.4) which updated npm to 5.6.0 to hopefully fix the npm econreset\r\n- Upgrade Cypress to the latest 1.4.1 because I encounter difficulties installing otherwise\r\n- Downgrade flexbox 2.0.0-beta.12 to 2.0.0-beta.9 because everything higher is supposed to require angular 5 (which I don't want go down that rabbit hole at this time)\r\n- removed npm-shrinkwrap in favor of package-lock.json because it's the general recommended one.  It also auto updates upon new npm package installs. https://www.reddit.com/r/javascript/comments/6dgnnq/npm_v500_released_save_by_default_lockfile_better/di3mjuk/  The dev deps are also in the lock file which is why it's larger than the old one.  Install the different type of deps with `npm i --prod`, `npm i --dev`, and `npm i`.  The lock file's packages will be used for whichever one is about to be installed.\r\n\r\n### Notes\r\n- Can't solve angular-tag-cloud-module 1.4.0 requiring an old angular version because the next angular-tag-cloud-module is 2.0.0 which jumps straight to requiring angular 5.  \r\n- https://github.com/npm/npm/issues/17979#issuecomment-332701215 shows how the new shrinkwrap works.  In short, when prod or other devs checkout the branch where package.json and package-lock.json are \"compatible\",  `npm i` will install the exact version of the packages listed in the lock file.  If they are not compatible, npm will install what's listed in the package.json and then update the lock file.\r\n- I had to run `npm dedupe` to modify the lock file again otherwise a bunch of deps of deps will conflict with each other\r\n- `npm install --prod` and `npm install` yields a slightly different package-lock.json due to angular/cli not liking being placed in deps instead of devDeps.  Using the package-lock.json from `npm install --prod` instead.  Can't move cli to devDeps because we need ng commands during production.  Can't install it outside of `npm install --prod` because it would still require an angular-cli in the package.json to link to things like the compiler-cli etc."},"comment":{"url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/comments/363229306","html_url":"https://github.com/dockstore/dockstore-ui2/pull/181#issuecomment-363229306","issue_url":"https://api.github.com/repos/dockstore/dockstore-ui2/issues/181","id":363229306,"user":{"login":"denis-yuen","id":1730679,"avatar_url":"https://avatars0.githubusercontent.com/u/1730679?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-yuen","html_url":"https://github.com/denis-yuen","followers_url":"https://api.github.com/users/denis-yuen/followers","following_url":"https://api.github.com/users/denis-yuen/following{/other_user}","gists_url":"https://api.github.com/users/denis-yuen/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-yuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-yuen/subscriptions","organizations_url":"https://api.github.com/users/denis-yuen/orgs","repos_url":"https://api.github.com/users/denis-yuen/repos","events_url":"https://api.github.com/users/denis-yuen/events{/privacy}","received_events_url":"https://api.github.com/users/denis-yuen/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T21:36:09Z","updated_at":"2018-02-05T21:36:09Z","author_association":"CONTRIBUTOR","body":"As discussed, we'll move ahead with NPM5"}}
{"actor":{"display_login":"denis-yuen"}}