{"action":"created","issue":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1504","repository_url":"https://api.github.com/repos/mattermost/mattermost-webapp","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1504/labels{/name}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1504/comments","events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1504/events","html_url":"https://github.com/mattermost/mattermost-webapp/pull/1504","id":346769200,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTUzNTU4","number":1504,"title":"MM-11450: Expose 'edit_others_posts' permission in permission schemes.","user":{"login":"mkraft","id":1149597,"node_id":"MDQ6VXNlcjExNDk1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1149597?v=4","gravatar_id":"","url":"https://api.github.com/users/mkraft","html_url":"https://github.com/mkraft","followers_url":"https://api.github.com/users/mkraft/followers","following_url":"https://api.github.com/users/mkraft/following{/other_user}","gists_url":"https://api.github.com/users/mkraft/gists{/gist_id}","starred_url":"https://api.github.com/users/mkraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkraft/subscriptions","organizations_url":"https://api.github.com/users/mkraft/orgs","repos_url":"https://api.github.com/users/mkraft/repos","events_url":"https://api.github.com/users/mkraft/events{/privacy}","received_events_url":"https://api.github.com/users/mkraft/received_events","type":"User","site_admin":false},"labels":[{"id":685999052,"node_id":"MDU6TGFiZWw2ODU5OTkwNTI=","url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/1:%20PM%20Review","name":"1: PM Review","color":"006b75","default":false},{"id":702532842,"node_id":"MDU6TGFiZWw3MDI1MzI4NDI=","url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/Setup%20Test%20Server","name":"Setup Test Server","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones/13","html_url":"https://github.com/mattermost/mattermost-webapp/milestone/13","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones/13/labels","id":3439045,"node_id":"MDk6TWlsZXN0b25lMzQzOTA0NQ==","number":13,"title":"v5.2.0","description":"","creator":{"login":"esethna","id":14333569,"node_id":"MDQ6VXNlcjE0MzMzNTY5","avatar_url":"https://avatars3.githubusercontent.com/u/14333569?v=4","gravatar_id":"","url":"https://api.github.com/users/esethna","html_url":"https://github.com/esethna","followers_url":"https://api.github.com/users/esethna/followers","following_url":"https://api.github.com/users/esethna/following{/other_user}","gists_url":"https://api.github.com/users/esethna/gists{/gist_id}","starred_url":"https://api.github.com/users/esethna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esethna/subscriptions","organizations_url":"https://api.github.com/users/esethna/orgs","repos_url":"https://api.github.com/users/esethna/repos","events_url":"https://api.github.com/users/esethna/events{/privacy}","received_events_url":"https://api.github.com/users/esethna/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":34,"state":"open","created_at":"2018-06-20T15:29:01Z","updated_at":"2018-08-02T16:25:36Z","due_on":"2018-08-16T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-08-01T21:06:45Z","updated_at":"2018-08-02T18:36:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1504","html_url":"https://github.com/mattermost/mattermost-webapp/pull/1504","diff_url":"https://github.com/mattermost/mattermost-webapp/pull/1504.diff","patch_url":"https://github.com/mattermost/mattermost-webapp/pull/1504.patch"},"body":"#### Summary\r\n\r\nExposes 'edit_others_posts' permission in the permission admin console. \r\n\r\nThe permission is by default part of the 'team admin' system scheme so without it exposed in the UI it's not known to users that the permission is granted to them by default.\r\n\r\nThe API is correctly rejecting edit requests if the permission doesn't exist and the mobile app is successfully hiding the edit button; users simply (understandably) didn't realize the permission was granted to team admins.\r\n\r\n#### Ticket Link\r\n[MM-11450](https://mattermost.atlassian.net/browse/MM-11450)\r\n\r\n#### Checklist\r\n- [x] Ran `make check-style` to check for style errors (required for all pull requests)\r\n- [x] Ran `make test` to ensure unit and component tests passed\r\n- [x] Added or updated unit tests (required for all new features)\r\n- [x] Has UI changes\r\n- [x] Includes text changes and localization file ([.../i18n/en.json](https://github.com/mattermost/mattermost-webapp/blob/master/i18n/en.json)) updates\r\n\r\n![screen shot 2018-08-01 at 5 05 18 pm](https://user-images.githubusercontent.com/1149597/43548893-1e11f8c8-95ad-11e8-9da0-7e3450f480fd.png)\r\n"},"comment":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/comments/410026225","html_url":"https://github.com/mattermost/mattermost-webapp/pull/1504#issuecomment-410026225","issue_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1504","id":410026225,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDAyNjIyNQ==","user":{"login":"mattermod","id":16344077,"node_id":"MDQ6VXNlcjE2MzQ0MDc3","avatar_url":"https://avatars1.githubusercontent.com/u/16344077?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermod","html_url":"https://github.com/mattermod","followers_url":"https://api.github.com/users/mattermod/followers","following_url":"https://api.github.com/users/mattermod/following{/other_user}","gists_url":"https://api.github.com/users/mattermod/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermod/subscriptions","organizations_url":"https://api.github.com/users/mattermod/orgs","repos_url":"https://api.github.com/users/mattermod/repos","events_url":"https://api.github.com/users/mattermod/events{/privacy}","received_events_url":"https://api.github.com/users/mattermod/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T18:36:26Z","updated_at":"2018-08-02T18:36:26Z","author_association":"NONE","body":"`Setup Test Server` label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch)."}}
{"actor":{"display_login":"mattermod"}}