{"push_id":2405730231,"size":1,"distinct_size":1,"ref":"refs/heads/matt/csl-2312","head":"7d12996bb966c36fdd8a60b485437cc4795d86fd","before":"4d790d5929a23ed9d5de29715a27b9f1f6851198","commits":[{"sha":"7d12996bb966c36fdd8a60b485437cc4795d86fd","author":{"name":"Edsko de Vries","email":"c3a3e5f142e17c9d769c9232e68ec916a72f85c3@well-typed.com"},"message":"Don't call QC's `generate`\n\nIn order to avoid generating arbitrary chains many times, we were using\n`beforeAll (generate ..)`, using QC's `generate :: Gen a -> IO a`. But this has\ntwo downsides: `hspec` won't tell us _which_ value was generated and, much more\nimportantly, it means that the tests are no longer reproducible; the `--seed`\ncommmand line argument to `hspec` won't affect this generator. I tried for a\nwhile to see if I could access `hspec`'s configuration but it doesn't appear to\nbe possible. However, the good news is that the invariant checking output is\nnow so much better that we don't need this workaround anymore; we can use\n`conjoin` as we originally did, but making sure that the invariant error\nmessage include sufficient information to figure out _which_ test failed.","distinct":true,"url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits/7d12996bb966c36fdd8a60b485437cc4795d86fd"}]}
{"actor":{"display_login":"edsko"}}