{"action":"created","comment":{"url":"https://api.github.com/repos/roblabla42/KFS/pulls/comments/241099477","pull_request_review_id":184286851,"id":241099477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTA5OTQ3Nw==","diff_hunk":"@@ -107,22 +119,16 @@ impl Window {\n         self.write_px(offset, color);\n     }\n \n-    pub fn get_fb(&mut self) -> &mut [u8] {\n+    /// Gets the underlying framebuffer\n+    pub fn get_fb(&mut self) -> &mut [Color] {\n         unsafe {\n-            self.buf.get_mut()\n+            slice::from_raw_parts_mut(self.buf.get_mut().as_ptr() as *mut Color, self.buf.len() / 4)\n         }\n     }\n \n-    /// Clears the whole screen\n+    /// Clears the whole window, making it black.\n     pub fn clear(&mut self) {\n         let fb = self.get_fb();\n-        for i in fb.iter_mut() { *i = 0x00; }\n-    }\n-}\n-\n-/// Some colors for the vbe\n-impl Color {\n-    pub fn rgb(r: u8, g: u8, b: u8) -> Color {\n-        Color {r, g, b }\n+        for i in fb.iter_mut() { *i = Color::rgb(0, 0, 0); }","path":"libuser/src/window.rs","position":132,"original_position":125,"commit_id":"86090948be5d5b9358cabfc5aedabb0702a44804","original_commit_id":"5c4ccee2e6ee3a9fd6c95fa16c5e653daf8cf84a","user":{"login":"roblabla","id":1069318,"node_id":"MDQ6VXNlcjEwNjkzMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1069318?v=4","gravatar_id":"","url":"https://api.github.com/users/roblabla","html_url":"https://github.com/roblabla","followers_url":"https://api.github.com/users/roblabla/followers","following_url":"https://api.github.com/users/roblabla/following{/other_user}","gists_url":"https://api.github.com/users/roblabla/gists{/gist_id}","starred_url":"https://api.github.com/users/roblabla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblabla/subscriptions","organizations_url":"https://api.github.com/users/roblabla/orgs","repos_url":"https://api.github.com/users/roblabla/repos","events_url":"https://api.github.com/users/roblabla/events{/privacy}","received_events_url":"https://api.github.com/users/roblabla/received_events","type":"User","site_admin":false},"body":"yes","created_at":"2018-12-12T16:57:52Z","updated_at":"2018-12-12T16:57:52Z","html_url":"https://github.com/roblabla42/KFS/pull/52#discussion_r241099477","pull_request_url":"https://api.github.com/repos/roblabla42/KFS/pulls/52","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/roblabla42/KFS/pulls/comments/241099477"},"html":{"href":"https://github.com/roblabla42/KFS/pull/52#discussion_r241099477"},"pull_request":{"href":"https://api.github.com/repos/roblabla42/KFS/pulls/52"}},"in_reply_to_id":241048677},"pull_request":{"url":"https://api.github.com/repos/roblabla42/KFS/pulls/52","id":235574453,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NTc0NDUz","html_url":"https://github.com/roblabla42/KFS/pull/52","diff_url":"https://github.com/roblabla42/KFS/pull/52.diff","patch_url":"https://github.com/roblabla42/KFS/pull/52.patch","issue_url":"https://api.github.com/repos/roblabla42/KFS/issues/52","number":52,"state":"open","locked":false,"title":"WIP Compositor","user":{"login":"roblabla","id":1069318,"node_id":"MDQ6VXNlcjEwNjkzMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1069318?v=4","gravatar_id":"","url":"https://api.github.com/users/roblabla","html_url":"https://github.com/roblabla","followers_url":"https://api.github.com/users/roblabla/followers","following_url":"https://api.github.com/users/roblabla/following{/other_user}","gists_url":"https://api.github.com/users/roblabla/gists{/gist_id}","starred_url":"https://api.github.com/users/roblabla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblabla/subscriptions","organizations_url":"https://api.github.com/users/roblabla/orgs","repos_url":"https://api.github.com/users/roblabla/repos","events_url":"https://api.github.com/users/roblabla/events{/privacy}","received_events_url":"https://api.github.com/users/roblabla/received_events","type":"User","site_admin":false},"body":"- Implement a compositor, named vi.\r\n- The clock uses it.\r\n- It's broken.\r\n\r\nFixes #40 ","created_at":"2018-12-03T20:02:13Z","updated_at":"2018-12-12T16:57:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7336cc3ac57d19ddf76569815230acedf2f2033","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/roblabla42/KFS/pulls/52/commits","review_comments_url":"https://api.github.com/repos/roblabla42/KFS/pulls/52/comments","review_comment_url":"https://api.github.com/repos/roblabla42/KFS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/roblabla42/KFS/issues/52/comments","statuses_url":"https://api.github.com/repos/roblabla42/KFS/statuses/86090948be5d5b9358cabfc5aedabb0702a44804","head":{"label":"roblabla:compositor","ref":"compositor","sha":"86090948be5d5b9358cabfc5aedabb0702a44804","user":{"login":"roblabla","id":1069318,"node_id":"MDQ6VXNlcjEwNjkzMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1069318?v=4","gravatar_id":"","url":"https://api.github.com/users/roblabla","html_url":"https://github.com/roblabla","followers_url":"https://api.github.com/users/roblabla/followers","following_url":"https://api.github.com/users/roblabla/following{/other_user}","gists_url":"https://api.github.com/users/roblabla/gists{/gist_id}","starred_url":"https://api.github.com/users/roblabla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblabla/subscriptions","organizations_url":"https://api.github.com/users/roblabla/orgs","repos_url":"https://api.github.com/users/roblabla/repos","events_url":"https://api.github.com/users/roblabla/events{/privacy}","received_events_url":"https://api.github.com/users/roblabla/received_events","type":"User","site_admin":false},"repo":{"id":158714488,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg3MTQ0ODg=","name":"KFS","full_name":"roblabla/KFS","private":false,"owner":{"login":"roblabla","id":1069318,"node_id":"MDQ6VXNlcjEwNjkzMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1069318?v=4","gravatar_id":"","url":"https://api.github.com/users/roblabla","html_url":"https://github.com/roblabla","followers_url":"https://api.github.com/users/roblabla/followers","following_url":"https://api.github.com/users/roblabla/following{/other_user}","gists_url":"https://api.github.com/users/roblabla/gists{/gist_id}","starred_url":"https://api.github.com/users/roblabla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblabla/subscriptions","organizations_url":"https://api.github.com/users/roblabla/orgs","repos_url":"https://api.github.com/users/roblabla/repos","events_url":"https://api.github.com/users/roblabla/events{/privacy}","received_events_url":"https://api.github.com/users/roblabla/received_events","type":"User","site_admin":false},"html_url":"https://github.com/roblabla/KFS","description":null,"fork":true,"url":"https://api.github.com/repos/roblabla/KFS","forks_url":"https://api.github.com/repos/roblabla/KFS/forks","keys_url":"https://api.github.com/repos/roblabla/KFS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roblabla/KFS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roblabla/KFS/teams","hooks_url":"https://api.github.com/repos/roblabla/KFS/hooks","issue_events_url":"https://api.github.com/repos/roblabla/KFS/issues/events{/number}","events_url":"https://api.github.com/repos/roblabla/KFS/events","assignees_url":"https://api.github.com/repos/roblabla/KFS/assignees{/user}","branches_url":"https://api.github.com/repos/roblabla/KFS/branches{/branch}","tags_url":"https://api.github.com/repos/roblabla/KFS/tags","blobs_url":"https://api.github.com/repos/roblabla/KFS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roblabla/KFS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roblabla/KFS/git/refs{/sha}","trees_url":"https://api.github.com/repos/roblabla/KFS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roblabla/KFS/statuses/{sha}","languages_url":"https://api.github.com/repos/roblabla/KFS/languages","stargazers_url":"https://api.github.com/repos/roblabla/KFS/stargazers","contributors_url":"https://api.github.com/repos/roblabla/KFS/contributors","subscribers_url":"https://api.github.com/repos/roblabla/KFS/subscribers","subscription_url":"https://api.github.com/repos/roblabla/KFS/subscription","commits_url":"https://api.github.com/repos/roblabla/KFS/commits{/sha}","git_commits_url":"https://api.github.com/repos/roblabla/KFS/git/commits{/sha}","comments_url":"https://api.github.com/repos/roblabla/KFS/comments{/number}","issue_comment_url":"https://api.github.com/repos/roblabla/KFS/issues/comments{/number}","contents_url":"https://api.github.com/repos/roblabla/KFS/contents/{+path}","compare_url":"https://api.github.com/repos/roblabla/KFS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roblabla/KFS/merges","archive_url":"https://api.github.com/repos/roblabla/KFS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roblabla/KFS/downloads","issues_url":"https://api.github.com/repos/roblabla/KFS/issues{/number}","pulls_url":"https://api.github.com/repos/roblabla/KFS/pulls{/number}","milestones_url":"https://api.github.com/repos/roblabla/KFS/milestones{/number}","notifications_url":"https://api.github.com/repos/roblabla/KFS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roblabla/KFS/labels{/name}","releases_url":"https://api.github.com/repos/roblabla/KFS/releases{/id}","deployments_url":"https://api.github.com/repos/roblabla/KFS/deployments","created_at":"2018-11-22T14:56:20Z","updated_at":"2018-11-22T14:56:22Z","pushed_at":"2018-12-12T16:22:23Z","git_url":"git://github.com/roblabla/KFS.git","ssh_url":"git@github.com:roblabla/KFS.git","clone_url":"https://github.com/roblabla/KFS.git","svn_url":"https://github.com/roblabla/KFS","homepage":null,"size":12177,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"roblabla42:master","ref":"master","sha":"6b25621391d61dfe0d228440a611c5c1dc0f8d64","user":{"login":"roblabla42","id":11092046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDkyMDQ2","avatar_url":"https://avatars3.githubusercontent.com/u/11092046?v=4","gravatar_id":"","url":"https://api.github.com/users/roblabla42","html_url":"https://github.com/roblabla42","followers_url":"https://api.github.com/users/roblabla42/followers","following_url":"https://api.github.com/users/roblabla42/following{/other_user}","gists_url":"https://api.github.com/users/roblabla42/gists{/gist_id}","starred_url":"https://api.github.com/users/roblabla42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblabla42/subscriptions","organizations_url":"https://api.github.com/users/roblabla42/orgs","repos_url":"https://api.github.com/users/roblabla42/repos","events_url":"https://api.github.com/users/roblabla42/events{/privacy}","received_events_url":"https://api.github.com/users/roblabla42/received_events","type":"Organization","site_admin":false},"repo":{"id":123312975,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzMTI5NzU=","name":"KFS","full_name":"roblabla42/KFS","private":false,"owner":{"login":"roblabla42","id":11092046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDkyMDQ2","avatar_url":"https://avatars3.githubusercontent.com/u/11092046?v=4","gravatar_id":"","url":"https://api.github.com/users/roblabla42","html_url":"https://github.com/roblabla42","followers_url":"https://api.github.com/users/roblabla42/followers","following_url":"https://api.github.com/users/roblabla42/following{/other_user}","gists_url":"https://api.github.com/users/roblabla42/gists{/gist_id}","starred_url":"https://api.github.com/users/roblabla42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblabla42/subscriptions","organizations_url":"https://api.github.com/users/roblabla42/orgs","repos_url":"https://api.github.com/users/roblabla42/repos","events_url":"https://api.github.com/users/roblabla42/events{/privacy}","received_events_url":"https://api.github.com/users/roblabla42/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/roblabla42/KFS","description":null,"fork":false,"url":"https://api.github.com/repos/roblabla42/KFS","forks_url":"https://api.github.com/repos/roblabla42/KFS/forks","keys_url":"https://api.github.com/repos/roblabla42/KFS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roblabla42/KFS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roblabla42/KFS/teams","hooks_url":"https://api.github.com/repos/roblabla42/KFS/hooks","issue_events_url":"https://api.github.com/repos/roblabla42/KFS/issues/events{/number}","events_url":"https://api.github.com/repos/roblabla42/KFS/events","assignees_url":"https://api.github.com/repos/roblabla42/KFS/assignees{/user}","branches_url":"https://api.github.com/repos/roblabla42/KFS/branches{/branch}","tags_url":"https://api.github.com/repos/roblabla42/KFS/tags","blobs_url":"https://api.github.com/repos/roblabla42/KFS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roblabla42/KFS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roblabla42/KFS/git/refs{/sha}","trees_url":"https://api.github.com/repos/roblabla42/KFS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roblabla42/KFS/statuses/{sha}","languages_url":"https://api.github.com/repos/roblabla42/KFS/languages","stargazers_url":"https://api.github.com/repos/roblabla42/KFS/stargazers","contributors_url":"https://api.github.com/repos/roblabla42/KFS/contributors","subscribers_url":"https://api.github.com/repos/roblabla42/KFS/subscribers","subscription_url":"https://api.github.com/repos/roblabla42/KFS/subscription","commits_url":"https://api.github.com/repos/roblabla42/KFS/commits{/sha}","git_commits_url":"https://api.github.com/repos/roblabla42/KFS/git/commits{/sha}","comments_url":"https://api.github.com/repos/roblabla42/KFS/comments{/number}","issue_comment_url":"https://api.github.com/repos/roblabla42/KFS/issues/comments{/number}","contents_url":"https://api.github.com/repos/roblabla42/KFS/contents/{+path}","compare_url":"https://api.github.com/repos/roblabla42/KFS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roblabla42/KFS/merges","archive_url":"https://api.github.com/repos/roblabla42/KFS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roblabla42/KFS/downloads","issues_url":"https://api.github.com/repos/roblabla42/KFS/issues{/number}","pulls_url":"https://api.github.com/repos/roblabla42/KFS/pulls{/number}","milestones_url":"https://api.github.com/repos/roblabla42/KFS/milestones{/number}","notifications_url":"https://api.github.com/repos/roblabla42/KFS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roblabla42/KFS/labels{/name}","releases_url":"https://api.github.com/repos/roblabla42/KFS/releases{/id}","deployments_url":"https://api.github.com/repos/roblabla42/KFS/deployments","created_at":"2018-02-28T16:40:04Z","updated_at":"2018-12-10T18:18:29Z","pushed_at":"2018-12-12T13:40:24Z","git_url":"git://github.com/roblabla42/KFS.git","ssh_url":"git@github.com:roblabla42/KFS.git","clone_url":"https://github.com/roblabla42/KFS.git","svn_url":"https://github.com/roblabla42/KFS","homepage":null,"size":12160,"stargazers_count":4,"watchers_count":4,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":29,"license":null,"forks":2,"open_issues":29,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/roblabla42/KFS/pulls/52"},"html":{"href":"https://github.com/roblabla42/KFS/pull/52"},"issue":{"href":"https://api.github.com/repos/roblabla42/KFS/issues/52"},"comments":{"href":"https://api.github.com/repos/roblabla42/KFS/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/roblabla42/KFS/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/roblabla42/KFS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/roblabla42/KFS/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/roblabla42/KFS/statuses/86090948be5d5b9358cabfc5aedabb0702a44804"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"roblabla"}}