{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/socorro/pulls/comments/166102568","pull_request_review_id":94131381,"id":166102568,"diff_hunk":"@@ -0,0 +1,18 @@\n+\"\"\"Default configuration values used by the FetchTransformSaveApp subclasses.\"\"\"\n+from configman.dotdict import DotDict\n+\n+\n+# Ignore non-config module members like DotDict\n+always_ignore_mismatches = True\n+\n+\n+# Crash storage source\n+source = DotDict({\n+    'crashstorage_class': 'socorro.external.fs.crashstorage.FSPermanentStorage',\n+})\n+\n+\n+# Crash storage destinations\n+destination = DotDict({\n+    'crashstorage_class': 'socorro.external.fs.crashstorage.FSPermanentStorage',\n+})","path":"socorro/app/fetch_transform_save_config.py","position":18,"original_position":18,"commit_id":"b5cc51218cd2428cce667df2687a29c0c2b56b31","original_commit_id":"0d6e1120a3fd616b2bdc982d163d5c394e774324","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars1.githubusercontent.com/u/820826?v=4","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"body":"Because the `klass_config` doesn't walk the MRE, this is all moot and won't come into play. We should nix this and make the values the default values for the config options.","created_at":"2018-02-05T20:29:06Z","updated_at":"2018-02-05T20:29:06Z","html_url":"https://github.com/mozilla-services/socorro/pull/4307#discussion_r166102568","pull_request_url":"https://api.github.com/repos/mozilla-services/socorro/pulls/4307","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/comments/166102568"},"html":{"href":"https://github.com/mozilla-services/socorro/pull/4307#discussion_r166102568"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/4307"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/socorro/pulls/4307","id":164718627,"html_url":"https://github.com/mozilla-services/socorro/pull/4307","diff_url":"https://github.com/mozilla-services/socorro/pull/4307.diff","patch_url":"https://github.com/mozilla-services/socorro/pull/4307.patch","issue_url":"https://api.github.com/repos/mozilla-services/socorro/issues/4307","number":4307,"state":"open","locked":false,"title":"Fix bug 1430860: Move destination config to python-based source.","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars1.githubusercontent.com/u/193106?v=4","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"body":"This is a WIP I wanna put up for feedback before starting to polish it up. It does two things.\r\n\r\n1. Changes the `destination.storage_classes` config value to `destination.storage_namespaces`. The old value was a list of classpaths that corresponded to numerically-based config namespaces (i.e. the first class in the list was passed config values from `destination.storage1`, the second got `destination.storage2`, etc.).\r\n\r\n   The new config now takes a list of namespace names, e.g. `postgres,s3,telemetry`. Each name is a crash storage location, and the name itself is used to lookup the config, e.g. `destination.postgres`, `destination.s3`, etc. This helps make editing, renaming, and reordering storages way less error-prone.\r\n2. Adds a new method for providing default config values. Any `SocorroApp` subclass can now define a class property `config_module`. It should be set to a string containing a python module (or class) path.\r\n\r\n   The module at the path specified will be imported and it's members will be used as configuration defaults. You can use DotDicts (and maybe any mapping? I haven't tested it yet.) to define nested config values. The end result is that any of the Socorro apps can define their own config defaults to replace `get_application_defaults` and `docker/*.env` files. \r\n\r\nThis PR focuses on the destination crash storage config mostly because it had nice properties for testing if this method worked. After landing this, we can gradually move config over to python modules, and eventually deprecate the other config methods.","created_at":"2018-01-23T23:30:37Z","updated_at":"2018-02-05T20:29:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd6b710d1705e900eea815dc23489a796a968c52","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/socorro/pulls/4307/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/socorro/pulls/4307/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/socorro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/socorro/issues/4307/comments","statuses_url":"https://api.github.com/repos/mozilla-services/socorro/statuses/b5cc51218cd2428cce667df2687a29c0c2b56b31","head":{"label":"Osmose:python-based-settings","ref":"python-based-settings","sha":"b5cc51218cd2428cce667df2687a29c0c2b56b31","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars1.githubusercontent.com/u/193106?v=4","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"repo":{"id":107184658,"name":"socorro","full_name":"Osmose/socorro","owner":{"login":"Osmose","id":193106,"avatar_url":"https://avatars1.githubusercontent.com/u/193106?v=4","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Osmose/socorro","description":"Socorro is a server to accept and process Breakpad crash reports. ","fork":true,"url":"https://api.github.com/repos/Osmose/socorro","forks_url":"https://api.github.com/repos/Osmose/socorro/forks","keys_url":"https://api.github.com/repos/Osmose/socorro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Osmose/socorro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Osmose/socorro/teams","hooks_url":"https://api.github.com/repos/Osmose/socorro/hooks","issue_events_url":"https://api.github.com/repos/Osmose/socorro/issues/events{/number}","events_url":"https://api.github.com/repos/Osmose/socorro/events","assignees_url":"https://api.github.com/repos/Osmose/socorro/assignees{/user}","branches_url":"https://api.github.com/repos/Osmose/socorro/branches{/branch}","tags_url":"https://api.github.com/repos/Osmose/socorro/tags","blobs_url":"https://api.github.com/repos/Osmose/socorro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Osmose/socorro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Osmose/socorro/git/refs{/sha}","trees_url":"https://api.github.com/repos/Osmose/socorro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Osmose/socorro/statuses/{sha}","languages_url":"https://api.github.com/repos/Osmose/socorro/languages","stargazers_url":"https://api.github.com/repos/Osmose/socorro/stargazers","contributors_url":"https://api.github.com/repos/Osmose/socorro/contributors","subscribers_url":"https://api.github.com/repos/Osmose/socorro/subscribers","subscription_url":"https://api.github.com/repos/Osmose/socorro/subscription","commits_url":"https://api.github.com/repos/Osmose/socorro/commits{/sha}","git_commits_url":"https://api.github.com/repos/Osmose/socorro/git/commits{/sha}","comments_url":"https://api.github.com/repos/Osmose/socorro/comments{/number}","issue_comment_url":"https://api.github.com/repos/Osmose/socorro/issues/comments{/number}","contents_url":"https://api.github.com/repos/Osmose/socorro/contents/{+path}","compare_url":"https://api.github.com/repos/Osmose/socorro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Osmose/socorro/merges","archive_url":"https://api.github.com/repos/Osmose/socorro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Osmose/socorro/downloads","issues_url":"https://api.github.com/repos/Osmose/socorro/issues{/number}","pulls_url":"https://api.github.com/repos/Osmose/socorro/pulls{/number}","milestones_url":"https://api.github.com/repos/Osmose/socorro/milestones{/number}","notifications_url":"https://api.github.com/repos/Osmose/socorro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Osmose/socorro/labels{/name}","releases_url":"https://api.github.com/repos/Osmose/socorro/releases{/id}","deployments_url":"https://api.github.com/repos/Osmose/socorro/deployments","created_at":"2017-10-16T21:25:10Z","updated_at":"2017-10-16T21:25:15Z","pushed_at":"2018-01-31T21:26:58Z","git_url":"git://github.com/Osmose/socorro.git","ssh_url":"git@github.com:Osmose/socorro.git","clone_url":"https://github.com/Osmose/socorro.git","svn_url":"https://github.com/Osmose/socorro","homepage":"https://wiki.mozilla.org/Socorro","size":171497,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"de4eb65b9bfd48481935047729ceb6d16744dcbb","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":2263742,"name":"socorro","full_name":"mozilla-services/socorro","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/socorro","description":"Socorro is a server to accept and process Breakpad crash reports. ","fork":false,"url":"https://api.github.com/repos/mozilla-services/socorro","forks_url":"https://api.github.com/repos/mozilla-services/socorro/forks","keys_url":"https://api.github.com/repos/mozilla-services/socorro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/socorro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/socorro/teams","hooks_url":"https://api.github.com/repos/mozilla-services/socorro/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/socorro/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/socorro/events","assignees_url":"https://api.github.com/repos/mozilla-services/socorro/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/socorro/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/socorro/tags","blobs_url":"https://api.github.com/repos/mozilla-services/socorro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/socorro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/socorro/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/socorro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/socorro/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/socorro/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/socorro/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/socorro/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/socorro/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/socorro/subscription","commits_url":"https://api.github.com/repos/mozilla-services/socorro/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/socorro/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/socorro/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/socorro/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/socorro/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/socorro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/socorro/merges","archive_url":"https://api.github.com/repos/mozilla-services/socorro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/socorro/downloads","issues_url":"https://api.github.com/repos/mozilla-services/socorro/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/socorro/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/socorro/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/socorro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/socorro/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/socorro/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/socorro/deployments","created_at":"2011-08-24T19:21:49Z","updated_at":"2018-02-03T03:41:33Z","pushed_at":"2018-02-05T17:17:12Z","git_url":"git://github.com/mozilla-services/socorro.git","ssh_url":"git@github.com:mozilla-services/socorro.git","clone_url":"https://github.com/mozilla-services/socorro.git","svn_url":"https://github.com/mozilla-services/socorro","homepage":"https://wiki.mozilla.org/Socorro","size":171539,"stargazers_count":398,"watchers_count":398,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":196,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":196,"open_issues":9,"watchers":398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/4307"},"html":{"href":"https://github.com/mozilla-services/socorro/pull/4307"},"issue":{"href":"https://api.github.com/repos/mozilla-services/socorro/issues/4307"},"comments":{"href":"https://api.github.com/repos/mozilla-services/socorro/issues/4307/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/4307/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/4307/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/socorro/statuses/b5cc51218cd2428cce667df2687a29c0c2b56b31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"willkg"}}