{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/20637","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/20637/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/20637/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/20637/events","html_url":"https://github.com/guardian/frontend/pull/20637","id":376945007,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDQxMzgx","number":20637,"title":" use thumbnail for media atom poster image when main media","user":{"login":"akash1810","id":836140,"node_id":"MDQ6VXNlcjgzNjE0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/836140?v=4","gravatar_id":"","url":"https://api.github.com/users/akash1810","html_url":"https://github.com/akash1810","followers_url":"https://api.github.com/users/akash1810/followers","following_url":"https://api.github.com/users/akash1810/following{/other_user}","gists_url":"https://api.github.com/users/akash1810/gists{/gist_id}","starred_url":"https://api.github.com/users/akash1810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akash1810/subscriptions","organizations_url":"https://api.github.com/users/akash1810/orgs","repos_url":"https://api.github.com/users/akash1810/repos","events_url":"https://api.github.com/users/akash1810/events{/privacy}","received_events_url":"https://api.github.com/users/akash1810/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-02T19:46:29Z","updated_at":"2018-11-06T14:46:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/20637","html_url":"https://github.com/guardian/frontend/pull/20637","diff_url":"https://github.com/guardian/frontend/pull/20637.diff","patch_url":"https://github.com/guardian/frontend/pull/20637.patch"},"body":"## What does this change?\r\nThis is a request from Editorial with the following use-case:\r\n- We have a match report video about player A vs player B and the thumbnail is A v B.\r\n- We then have an article about player A which isn't primarily about the match.\r\n- We want to embed the video in this article, however the thumbnail doesn't exactly match the tone of the article.\r\n- Use the article's thumbnail image instead, which is typically more relevant\r\n\r\nAlso removes the `YouTubePosterOverride` switch. It's always on, so no longer needed.\r\n\r\n## Screenshots\r\n(these don't exactly match the use-case described above...)\r\n\r\nFrom https://www.theguardian.com/football/2018/nov/04/kasper-schmeichel-cardiff-match-like-cup-final-leicester that's using this video - https://www.theguardian.com/football/video/2018/nov/04/leicester-city-players-attend-vichai-srivaddhanaprabhas-bangkok-funeral-video\r\n\r\n### Before\r\n![image](https://user-images.githubusercontent.com/836140/47990805-5cdbb980-e0e0-11e8-97aa-12a6d061c6df.png)\r\n\r\n### After\r\n![image](https://user-images.githubusercontent.com/836140/47990819-66652180-e0e0-11e8-9d55-555d93321446.png)\r\n\r\n## What is the value of this and can you measure success?\r\nSince moving to Atoms, the multimedia team have commented that they're reluctant to use videos in main media as it makes the content look stale. This is because an Atom only has 1 image.\r\n\r\nBefore Atoms, it was possible to set a different image for a video on each use. This change is bringing that functionality back.\r\n\r\n## Checklist\r\n- [x] Demo to Editorial\r\n- [ ] ???\r\n- [ ] Profit\r\n\r\n### Does this affect other platforms?\r\n\r\n- [ ] AMP <!-- AMP question? https://git.io/v9zIE -->\r\n- [x] Apps\r\n- [ ] Other (please specify)\r\n\r\n### Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?\r\n\r\n<!-- if there are versions of this content with the paid styling (teal and grey) then they will need to be checked -->\r\n<!-- content can be found here: https://www.theguardian.com/tone/advertisement-features -->\r\n\r\n- [x] No\r\n- [ ] Yes (please give details)\r\n\r\n### Does this change break ad-free?\r\n\r\n<!-- The scope for this includes, but is not limited to, ad-slots, page targeting, podcasts, rich links, outbrain, -->\r\n<!-- merchandising, page skins and paid-for content -->\r\n<!-- If there's any chance it could cause problems, please test it with an appropriate test user or add a new test -->\r\n<!-- scenario -->\r\n\r\n- [x] No\r\n- [ ] It did, but tests caught it and I fixed it\r\n- [ ] It did, but there was no test coverage so I added that then fixed it\r\n\r\n### Accessibility test checklist\r\n\r\n<!-- for changes that affect how a page appears in the browser -->\r\n\r\n- [x] [Tested with screen reader](https://accessibility.gutools.co.uk/testing/web/screen-readers/)\r\n- [x] [Navigable with keyboard](https://accessibility.gutools.co.uk/testing/web/keyboard-navigation/)\r\n- [x] [Colour contrast passed](https://accessibility.gutools.co.uk/testing/web/colour-contrast/)\r\n\r\n### Tested\r\n\r\n- [x] Locally\r\n- [x] On CODE (optional)\r\n\r\n<!-- AB test? https://git.io/v1V0x -->\r\n<!-- Does this PR meet the contributing guidelines? https://git.io/v1VEJ -->\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/436277299","html_url":"https://github.com/guardian/frontend/pull/20637#issuecomment-436277299","issue_url":"https://api.github.com/repos/guardian/frontend/issues/20637","id":436277299,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjI3NzI5OQ==","user":{"login":"akash1810","id":836140,"node_id":"MDQ6VXNlcjgzNjE0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/836140?v=4","gravatar_id":"","url":"https://api.github.com/users/akash1810","html_url":"https://github.com/akash1810","followers_url":"https://api.github.com/users/akash1810/followers","following_url":"https://api.github.com/users/akash1810/following{/other_user}","gists_url":"https://api.github.com/users/akash1810/gists{/gist_id}","starred_url":"https://api.github.com/users/akash1810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akash1810/subscriptions","organizations_url":"https://api.github.com/users/akash1810/orgs","repos_url":"https://api.github.com/users/akash1810/repos","events_url":"https://api.github.com/users/akash1810/events{/privacy}","received_events_url":"https://api.github.com/users/akash1810/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T14:46:03Z","updated_at":"2018-11-06T14:46:03Z","author_association":"MEMBER","body":"> removing the `YouTubePosterOverride` feature toggle is mixed in with the change here\r\n\r\nJust noticed that change is in its own commit. Can we be lazy and say that's good enough? If we want to add the switch back in, we can revert that commit... 🤞 🙏 \r\n\r\n> unclear what happens with `!playable` in `youtube.scala.html`\r\n\r\nThis looks to be the only use of this property - https://github.com/guardian/frontend/blob/master/common/app/views/fragments/items/facia_cards/contentCard.scala.html#L140. This is for Fronts - you can choose to disable inline video playback on fronts.\r\n\r\nI've tested it in DEV and the feature still works... so I'm not entirely this check was doing anything..."}}
{"actor":{"display_login":"akash1810"}}