{"action":"created","comment":{"url":"https://api.github.com/repos/redox-os/netstack/pulls/comments/167465594","pull_request_review_id":95686417,"id":167465594,"diff_hunk":"@@ -55,8 +57,8 @@ pub struct Smolnetd {\n impl Smolnetd {\n     const MAX_PACKET_SIZE: usize = 2048;\n     const SOCKET_BUFFER_SIZE: usize = 128; //packets\n-    const MIN_CHECK_TIMEOUT_MS: i64 = 10;\n-    const MAX_CHECK_TIMEOUT_MS: i64 = 500;\n+    const MIN_CHECK_TIMEOUT_MS: Duration = Duration { millis: 10 };\n+    const MAX_CHECK_TIMEOUT_MS: Duration = Duration { millis: 500 };","path":"src/smolnetd/scheme/mod.rs","position":42,"original_position":42,"commit_id":"a1680ea140e2a4d57e7952d7a238ca752b6af0d7","original_commit_id":"a1680ea140e2a4d57e7952d7a238ca752b6af0d7","user":{"login":"dlrobertson","id":7504153,"avatar_url":"https://avatars1.githubusercontent.com/u/7504153?v=4","gravatar_id":"","url":"https://api.github.com/users/dlrobertson","html_url":"https://github.com/dlrobertson","followers_url":"https://api.github.com/users/dlrobertson/followers","following_url":"https://api.github.com/users/dlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/dlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/dlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlrobertson/subscriptions","organizations_url":"https://api.github.com/users/dlrobertson/orgs","repos_url":"https://api.github.com/users/dlrobertson/repos","events_url":"https://api.github.com/users/dlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/dlrobertson/received_events","type":"User","site_admin":false},"body":":+1: Good idea","created_at":"2018-02-12T03:43:56Z","updated_at":"2018-02-12T03:43:56Z","html_url":"https://github.com/redox-os/netstack/pull/18#discussion_r167465594","pull_request_url":"https://api.github.com/repos/redox-os/netstack/pulls/18","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/redox-os/netstack/pulls/comments/167465594"},"html":{"href":"https://github.com/redox-os/netstack/pull/18#discussion_r167465594"},"pull_request":{"href":"https://api.github.com/repos/redox-os/netstack/pulls/18"}},"in_reply_to_id":167429081},"pull_request":{"url":"https://api.github.com/repos/redox-os/netstack/pulls/18","id":168423242,"html_url":"https://github.com/redox-os/netstack/pull/18","diff_url":"https://github.com/redox-os/netstack/pull/18.diff","patch_url":"https://github.com/redox-os/netstack/pull/18.patch","issue_url":"https://api.github.com/repos/redox-os/netstack/issues/18","number":18,"state":"open","locked":false,"title":"[WIP] Use smoltcp::time types instead of u64 timestamps","user":{"login":"dlrobertson","id":7504153,"avatar_url":"https://avatars1.githubusercontent.com/u/7504153?v=4","gravatar_id":"","url":"https://api.github.com/users/dlrobertson","html_url":"https://github.com/dlrobertson","followers_url":"https://api.github.com/users/dlrobertson/followers","following_url":"https://api.github.com/users/dlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/dlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/dlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlrobertson/subscriptions","organizations_url":"https://api.github.com/users/dlrobertson/orgs","repos_url":"https://api.github.com/users/dlrobertson/repos","events_url":"https://api.github.com/users/dlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/dlrobertson/received_events","type":"User","site_admin":false},"body":"smoltcp is moving towards using `time::Duration` and `time::Instant` instead\r\nof a `u64` timestamp.\r\n\r\nDependencies: m-labs/smoltcp#141","created_at":"2018-02-10T22:00:49Z","updated_at":"2018-02-12T03:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba2519234beafd61630d92cd55a2b694db7d4ac8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/redox-os/netstack/pulls/18/commits","review_comments_url":"https://api.github.com/repos/redox-os/netstack/pulls/18/comments","review_comment_url":"https://api.github.com/repos/redox-os/netstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redox-os/netstack/issues/18/comments","statuses_url":"https://api.github.com/repos/redox-os/netstack/statuses/a1680ea140e2a4d57e7952d7a238ca752b6af0d7","head":{"label":"dlrobertson:update_use_of_timestamp","ref":"update_use_of_timestamp","sha":"a1680ea140e2a4d57e7952d7a238ca752b6af0d7","user":{"login":"dlrobertson","id":7504153,"avatar_url":"https://avatars1.githubusercontent.com/u/7504153?v=4","gravatar_id":"","url":"https://api.github.com/users/dlrobertson","html_url":"https://github.com/dlrobertson","followers_url":"https://api.github.com/users/dlrobertson/followers","following_url":"https://api.github.com/users/dlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/dlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/dlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlrobertson/subscriptions","organizations_url":"https://api.github.com/users/dlrobertson/orgs","repos_url":"https://api.github.com/users/dlrobertson/repos","events_url":"https://api.github.com/users/dlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/dlrobertson/received_events","type":"User","site_admin":false},"repo":{"id":114936681,"name":"netstack","full_name":"dlrobertson/netstack","owner":{"login":"dlrobertson","id":7504153,"avatar_url":"https://avatars1.githubusercontent.com/u/7504153?v=4","gravatar_id":"","url":"https://api.github.com/users/dlrobertson","html_url":"https://github.com/dlrobertson","followers_url":"https://api.github.com/users/dlrobertson/followers","following_url":"https://api.github.com/users/dlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/dlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/dlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlrobertson/subscriptions","organizations_url":"https://api.github.com/users/dlrobertson/orgs","repos_url":"https://api.github.com/users/dlrobertson/repos","events_url":"https://api.github.com/users/dlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/dlrobertson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dlrobertson/netstack","description":"Redox OS network stack","fork":true,"url":"https://api.github.com/repos/dlrobertson/netstack","forks_url":"https://api.github.com/repos/dlrobertson/netstack/forks","keys_url":"https://api.github.com/repos/dlrobertson/netstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlrobertson/netstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlrobertson/netstack/teams","hooks_url":"https://api.github.com/repos/dlrobertson/netstack/hooks","issue_events_url":"https://api.github.com/repos/dlrobertson/netstack/issues/events{/number}","events_url":"https://api.github.com/repos/dlrobertson/netstack/events","assignees_url":"https://api.github.com/repos/dlrobertson/netstack/assignees{/user}","branches_url":"https://api.github.com/repos/dlrobertson/netstack/branches{/branch}","tags_url":"https://api.github.com/repos/dlrobertson/netstack/tags","blobs_url":"https://api.github.com/repos/dlrobertson/netstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlrobertson/netstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlrobertson/netstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlrobertson/netstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlrobertson/netstack/statuses/{sha}","languages_url":"https://api.github.com/repos/dlrobertson/netstack/languages","stargazers_url":"https://api.github.com/repos/dlrobertson/netstack/stargazers","contributors_url":"https://api.github.com/repos/dlrobertson/netstack/contributors","subscribers_url":"https://api.github.com/repos/dlrobertson/netstack/subscribers","subscription_url":"https://api.github.com/repos/dlrobertson/netstack/subscription","commits_url":"https://api.github.com/repos/dlrobertson/netstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlrobertson/netstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlrobertson/netstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlrobertson/netstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlrobertson/netstack/contents/{+path}","compare_url":"https://api.github.com/repos/dlrobertson/netstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlrobertson/netstack/merges","archive_url":"https://api.github.com/repos/dlrobertson/netstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlrobertson/netstack/downloads","issues_url":"https://api.github.com/repos/dlrobertson/netstack/issues{/number}","pulls_url":"https://api.github.com/repos/dlrobertson/netstack/pulls{/number}","milestones_url":"https://api.github.com/repos/dlrobertson/netstack/milestones{/number}","notifications_url":"https://api.github.com/repos/dlrobertson/netstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlrobertson/netstack/labels{/name}","releases_url":"https://api.github.com/repos/dlrobertson/netstack/releases{/id}","deployments_url":"https://api.github.com/repos/dlrobertson/netstack/deployments","created_at":"2017-12-20T22:23:44Z","updated_at":"2017-12-20T22:23:45Z","pushed_at":"2018-02-10T21:59:22Z","git_url":"git://github.com/dlrobertson/netstack.git","ssh_url":"git@github.com:dlrobertson/netstack.git","clone_url":"https://github.com/dlrobertson/netstack.git","svn_url":"https://github.com/dlrobertson/netstack","homepage":null,"size":169,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redox-os:master","ref":"master","sha":"ff93aabbe601d8a5d5fea82c6d3692d26b792f85","user":{"login":"redox-os","id":14909902,"avatar_url":"https://avatars3.githubusercontent.com/u/14909902?v=4","gravatar_id":"","url":"https://api.github.com/users/redox-os","html_url":"https://github.com/redox-os","followers_url":"https://api.github.com/users/redox-os/followers","following_url":"https://api.github.com/users/redox-os/following{/other_user}","gists_url":"https://api.github.com/users/redox-os/gists{/gist_id}","starred_url":"https://api.github.com/users/redox-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox-os/subscriptions","organizations_url":"https://api.github.com/users/redox-os/orgs","repos_url":"https://api.github.com/users/redox-os/repos","events_url":"https://api.github.com/users/redox-os/events{/privacy}","received_events_url":"https://api.github.com/users/redox-os/received_events","type":"Organization","site_admin":false},"repo":{"id":90816842,"name":"netstack","full_name":"redox-os/netstack","owner":{"login":"redox-os","id":14909902,"avatar_url":"https://avatars3.githubusercontent.com/u/14909902?v=4","gravatar_id":"","url":"https://api.github.com/users/redox-os","html_url":"https://github.com/redox-os","followers_url":"https://api.github.com/users/redox-os/followers","following_url":"https://api.github.com/users/redox-os/following{/other_user}","gists_url":"https://api.github.com/users/redox-os/gists{/gist_id}","starred_url":"https://api.github.com/users/redox-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox-os/subscriptions","organizations_url":"https://api.github.com/users/redox-os/orgs","repos_url":"https://api.github.com/users/redox-os/repos","events_url":"https://api.github.com/users/redox-os/events{/privacy}","received_events_url":"https://api.github.com/users/redox-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redox-os/netstack","description":"Redox OS network stack","fork":false,"url":"https://api.github.com/repos/redox-os/netstack","forks_url":"https://api.github.com/repos/redox-os/netstack/forks","keys_url":"https://api.github.com/repos/redox-os/netstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redox-os/netstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redox-os/netstack/teams","hooks_url":"https://api.github.com/repos/redox-os/netstack/hooks","issue_events_url":"https://api.github.com/repos/redox-os/netstack/issues/events{/number}","events_url":"https://api.github.com/repos/redox-os/netstack/events","assignees_url":"https://api.github.com/repos/redox-os/netstack/assignees{/user}","branches_url":"https://api.github.com/repos/redox-os/netstack/branches{/branch}","tags_url":"https://api.github.com/repos/redox-os/netstack/tags","blobs_url":"https://api.github.com/repos/redox-os/netstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redox-os/netstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redox-os/netstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/redox-os/netstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redox-os/netstack/statuses/{sha}","languages_url":"https://api.github.com/repos/redox-os/netstack/languages","stargazers_url":"https://api.github.com/repos/redox-os/netstack/stargazers","contributors_url":"https://api.github.com/repos/redox-os/netstack/contributors","subscribers_url":"https://api.github.com/repos/redox-os/netstack/subscribers","subscription_url":"https://api.github.com/repos/redox-os/netstack/subscription","commits_url":"https://api.github.com/repos/redox-os/netstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/redox-os/netstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/redox-os/netstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/redox-os/netstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/redox-os/netstack/contents/{+path}","compare_url":"https://api.github.com/repos/redox-os/netstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redox-os/netstack/merges","archive_url":"https://api.github.com/repos/redox-os/netstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redox-os/netstack/downloads","issues_url":"https://api.github.com/repos/redox-os/netstack/issues{/number}","pulls_url":"https://api.github.com/repos/redox-os/netstack/pulls{/number}","milestones_url":"https://api.github.com/repos/redox-os/netstack/milestones{/number}","notifications_url":"https://api.github.com/repos/redox-os/netstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redox-os/netstack/labels{/name}","releases_url":"https://api.github.com/repos/redox-os/netstack/releases{/id}","deployments_url":"https://api.github.com/repos/redox-os/netstack/deployments","created_at":"2017-05-10T03:26:48Z","updated_at":"2018-02-04T14:56:07Z","pushed_at":"2018-02-10T22:00:50Z","git_url":"git://github.com/redox-os/netstack.git","ssh_url":"git@github.com:redox-os/netstack.git","clone_url":"https://github.com/redox-os/netstack.git","svn_url":"https://github.com/redox-os/netstack","homepage":null,"size":175,"stargazers_count":17,"watchers_count":17,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":5,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redox-os/netstack/pulls/18"},"html":{"href":"https://github.com/redox-os/netstack/pull/18"},"issue":{"href":"https://api.github.com/repos/redox-os/netstack/issues/18"},"comments":{"href":"https://api.github.com/repos/redox-os/netstack/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/redox-os/netstack/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/redox-os/netstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redox-os/netstack/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/redox-os/netstack/statuses/a1680ea140e2a4d57e7952d7a238ca752b6af0d7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dlrobertson"}}