{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/vc-data-model/issues/141","repository_url":"https://api.github.com/repos/w3c/vc-data-model","labels_url":"https://api.github.com/repos/w3c/vc-data-model/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/w3c/vc-data-model/issues/141/comments","events_url":"https://api.github.com/repos/w3c/vc-data-model/issues/141/events","html_url":"https://github.com/w3c/vc-data-model/pull/141","id":308868273,"number":141,"title":"Modified data model and terms to remove ambiguity","user":{"login":"David-Chadwick","id":3651839,"avatar_url":"https://avatars0.githubusercontent.com/u/3651839?v=4","gravatar_id":"","url":"https://api.github.com/users/David-Chadwick","html_url":"https://github.com/David-Chadwick","followers_url":"https://api.github.com/users/David-Chadwick/followers","following_url":"https://api.github.com/users/David-Chadwick/following{/other_user}","gists_url":"https://api.github.com/users/David-Chadwick/gists{/gist_id}","starred_url":"https://api.github.com/users/David-Chadwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/David-Chadwick/subscriptions","organizations_url":"https://api.github.com/users/David-Chadwick/orgs","repos_url":"https://api.github.com/users/David-Chadwick/repos","events_url":"https://api.github.com/users/David-Chadwick/events{/privacy}","received_events_url":"https://api.github.com/users/David-Chadwick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-27T08:23:59Z","updated_at":"2018-03-28T21:45:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/w3c/vc-data-model/pulls/141","html_url":"https://github.com/w3c/vc-data-model/pull/141","diff_url":"https://github.com/w3c/vc-data-model/pull/141.diff","patch_url":"https://github.com/w3c/vc-data-model/pull/141.patch"},"body":"This PR tries to remove ambiguity from the data model and terms by doing the following things:\n\ni) makes sure that each JSON structure is clearly identified for what it is (i.e. verifiable credential or verifiable profile). A side benefit of this is that the type parameter can be simplified as it no longer needs to specify the base type.\n\nii) removed inconsistencies whereas sometimes a VC was called a credential and sometimes a verifiableCredential\n\niii) made the \"id\" property consistent in that it always comes first in a data type definition and always uniquely identifies that data type\n\niv) updated the terms to make it clear that a verifiable credential holds a set of claims, that each claim contains the properties of one subject, and that the subject can be different for each claim. Each subject has a unique subject id and each subject comprises a set of properties.\n\nv) that each credential status scheme is clearly identified in the credential status property, and each scheme is responsible for defining the contents of the status property\n\nvi) for verifiable profiles, added the holder id, and made it clear that the existing id is the profile id (consistent with i) above\n\nvii) for terms of use, changed the type into a unique type ID, and made the rest of the contents be dependent upon this type. Consequently new types of terms of use can be defined with different properties to the current examples.\n\nviii) turned evidence into a set, consistent with the existing text, with each element being identified by its unique scheme ID. The contents of the scheme properties are then determined by the scheme itself\n\nix) removed revocation and replaced with credential status\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n<a href=\"https://pr-preview.s3.amazonaws.com/David-Chadwick/vc-data-model/pull/141.html\" title=\"Last updated on Mar 27, 2018, 8:24 AM GMT (a572b09)\">Preview</a> | <a href=\"https://pr-preview.s3.amazonaws.com/w3c/vc-data-model/141/805722f...David-Chadwick:a572b09.html\" title=\"Last updated on Mar 27, 2018, 8:24 AM GMT (a572b09)\">Diff</a>"},"comment":{"url":"https://api.github.com/repos/w3c/vc-data-model/issues/comments/377047894","html_url":"https://github.com/w3c/vc-data-model/pull/141#issuecomment-377047894","issue_url":"https://api.github.com/repos/w3c/vc-data-model/issues/141","id":377047894,"user":{"login":"jandrieu","id":186831,"avatar_url":"https://avatars3.githubusercontent.com/u/186831?v=4","gravatar_id":"","url":"https://api.github.com/users/jandrieu","html_url":"https://github.com/jandrieu","followers_url":"https://api.github.com/users/jandrieu/followers","following_url":"https://api.github.com/users/jandrieu/following{/other_user}","gists_url":"https://api.github.com/users/jandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/jandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jandrieu/subscriptions","organizations_url":"https://api.github.com/users/jandrieu/orgs","repos_url":"https://api.github.com/users/jandrieu/repos","events_url":"https://api.github.com/users/jandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/jandrieu/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T21:45:32Z","updated_at":"2018-03-28T21:45:32Z","author_association":"CONTRIBUTOR","body":"@dlongley we have the same problem with claims within a credential. There is no way to say in a profile that claim X in credential Y is no longer accurate, e.g., if the address is no longer current but it's part of the credential.  Similarly there is no way for someone to witness a particular profile without asserting the underlying assertions. I.e., no way to say \"I affirm Joe presented profile X on such and such a date.\"  These missing ids make it hard to make claims about claims and claims about profiles. We do have usable ids for credentials, but not claims or profiles."}}
{"actor":{"display_login":"jandrieu"}}