{"action":"created","issue":{"url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/615","repository_url":"https://api.github.com/repos/wireapp/wire-ios-data-model","labels_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/615/labels{/name}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/615/comments","events_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/615/events","html_url":"https://github.com/wireapp/wire-ios-data-model/pull/615","id":385393552,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Mzc0NzE4","number":615,"title":"Respect read receipt settings when sending out read confirmations","user":{"login":"typfel","id":7156,"node_id":"MDQ6VXNlcjcxNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7156?v=4","gravatar_id":"","url":"https://api.github.com/users/typfel","html_url":"https://github.com/typfel","followers_url":"https://api.github.com/users/typfel/followers","following_url":"https://api.github.com/users/typfel/following{/other_user}","gists_url":"https://api.github.com/users/typfel/gists{/gist_id}","starred_url":"https://api.github.com/users/typfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typfel/subscriptions","organizations_url":"https://api.github.com/users/typfel/orgs","repos_url":"https://api.github.com/users/typfel/repos","events_url":"https://api.github.com/users/typfel/events{/privacy}","received_events_url":"https://api.github.com/users/typfel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-28T18:08:11Z","updated_at":"2018-11-28T18:19:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/615","html_url":"https://github.com/wireapp/wire-ios-data-model/pull/615","diff_url":"https://github.com/wireapp/wire-ios-data-model/pull/615.diff","patch_url":"https://github.com/wireapp/wire-ios-data-model/pull/615.patch"},"body":"## What's new in this PR?\r\n\r\n`confirmUnreadMessagesAsRead` will now respect the account wide read receipt setting in 1:1 conversations and inspect the `expectsReadConfirmation` on the message protobuf. \r\n\r\nIn group conversations read  confirmation are controlled by the new `expectsReadConfirmation` on the `Message` entity which should be set when inserting a message.\r\n\r\n## TODO\r\n\r\n- [ ] Write tests for `needsReadConfirmation`.\r\n- [ ] Set `expectsReadConfirmation` when inserting a message."},"comment":{"url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/comments/442551255","html_url":"https://github.com/wireapp/wire-ios-data-model/pull/615#issuecomment-442551255","issue_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/615","id":442551255,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjU1MTI1NQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T18:19:46Z","updated_at":"2018-11-28T18:19:46Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/wireapp/wire-ios-data-model/pull/615?src=pr&el=h1) Report\n> :exclamation: No coverage uploaded for pull request base (`feature/read-receipts@18c66b2`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).\n> The diff coverage is `34.14%`.\n\n\n```diff\n@@                   Coverage Diff                    @@\n##             feature/read-receipts     #615   +/-   ##\n========================================================\n  Coverage                         ?   84.02%           \n========================================================\n  Files                            ?      188           \n  Lines                            ?    10689           \n  Branches                         ?        0           \n========================================================\n  Hits                             ?     8981           \n  Misses                           ?     1708           \n  Partials                         ?        0\n```\n"}}
{"actor":{"display_login":"codecov-io"}}