{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/177429714","pull_request_review_id":107296993,"id":177429714,"diff_hunk":"@@ -43,291 +22,11 @@\n \n /* For i.MX 6UltraLite and 6ULL EVK board */\n #elif defined(CFG_MX6UL) || defined(CFG_MX6ULL)\n-#include <imx-regs.h>\n-\n-#ifdef CFG_WITH_PAGER\n-#error \"Pager not supported for platform mx6ulevk\"\n-#endif\n-#ifdef CFG_WITH_LPAE\n-#error \"LPAE not supported for now\"\n-#endif\n-\n-\n-#define CFG_TEE_CORE_NB_CORE\t\t1\n-\n-#define DDR_PHYS_START\t\t\tDRAM0_BASE\n-#define DDR_SIZE\t\t\tDRAM0_SIZE\n-\n-#define CFG_DDR_START\t\t\tDDR_PHYS_START\n-#define CFG_DDR_SIZE\t\t\tDDR_SIZE\n-\n-#ifndef CFG_DDR_TEETZ_RESERVED_START\n-#define CFG_DDR_TEETZ_RESERVED_START\t0x9E000000\n-#endif\n-\n-#define CFG_DDR_TEETZ_RESERVED_SIZE\t0x02000000\n-\n-#define CFG_PUB_RAM_SIZE\t(2 * 1024 * 1024)\n-\n-#define TZDRAM_BASE\t\t(CFG_DDR_TEETZ_RESERVED_START)\n-#define TZDRAM_SIZE\t\t(CFG_DDR_TEETZ_RESERVED_SIZE - \\\n-\t\t\t\t CFG_PUB_RAM_SIZE)\n-\n-#define CFG_SHMEM_START\t\t(CFG_DDR_TEETZ_RESERVED_START + \\\n-\t\t\t\t TZDRAM_SIZE)\n-/* Full GlobalPlatform test suite requires CFG_SHMEM_SIZE to be at least 2MB */\n-#define CFG_SHMEM_SIZE\t\tCFG_PUB_RAM_SIZE\n-\n-/*\n- * Everything is in TZDRAM.\n- * +------------------+\n- * |        | TEE_RAM |\n- * + TZDRAM +---------+\n- * |        | TA_RAM  |\n- * +--------+---------+\n- */\n-#define CFG_TEE_RAM_VA_SIZE\t(1024 * 1024)\n-#define CFG_TEE_RAM_PH_SIZE\tCFG_TEE_RAM_VA_SIZE\n-#define CFG_TEE_RAM_START\tTZDRAM_BASE\n-#define CFG_TA_RAM_START\tROUNDUP((TZDRAM_BASE + CFG_TEE_RAM_VA_SIZE), \\\n-\t\t\t\t\tCORE_MMU_DEVICE_SIZE)\n-#define CFG_TA_RAM_SIZE\t\tROUNDDOWN((TZDRAM_SIZE - CFG_TEE_RAM_VA_SIZE), \\\n-\t\t\t\t\t  CORE_MMU_DEVICE_SIZE)\n-#ifndef CFG_TEE_LOAD_ADDR\n-#define CFG_TEE_LOAD_ADDR\tCFG_TEE_RAM_START\n-#endif\n-\n-\n-#define CONSOLE_UART_BASE\t(UART1_BASE)\n-\n+#include <config/config_imx6ul.h>","path":"core/arch/arm/plat-imx/platform_config.h","position":91,"original_position":91,"commit_id":"6d8a9df04e5023eee6e7cd9212c3ee75fd4a19c7","original_commit_id":"5422285060fbca36ae21d5090736e0173a409b36","user":{"login":"sdininno","id":23036407,"avatar_url":"https://avatars3.githubusercontent.com/u/23036407?v=4","gravatar_id":"","url":"https://api.github.com/users/sdininno","html_url":"https://github.com/sdininno","followers_url":"https://api.github.com/users/sdininno/followers","following_url":"https://api.github.com/users/sdininno/following{/other_user}","gists_url":"https://api.github.com/users/sdininno/gists{/gist_id}","starred_url":"https://api.github.com/users/sdininno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdininno/subscriptions","organizations_url":"https://api.github.com/users/sdininno/orgs","repos_url":"https://api.github.com/users/sdininno/repos","events_url":"https://api.github.com/users/sdininno/events{/privacy}","received_events_url":"https://api.github.com/users/sdininno/received_events","type":"User","site_admin":false},"body":"sure , no problem.\r\nWe will rename the config_imx6sx.h and config_imx7.h to keep consistency then,\r\n","created_at":"2018-03-27T13:46:33Z","updated_at":"2018-03-27T13:46:33Z","html_url":"https://github.com/OP-TEE/optee_os/pull/2217#discussion_r177429714","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/177429714"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2217#discussion_r177429714"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217"}},"in_reply_to_id":177412603},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217","id":177726035,"html_url":"https://github.com/OP-TEE/optee_os/pull/2217","diff_url":"https://github.com/OP-TEE/optee_os/pull/2217.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/2217.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2217","number":2217,"state":"open","locked":false,"title":"Upstream i.MX SoC support (part1)","user":{"login":"sdininno","id":23036407,"avatar_url":"https://avatars3.githubusercontent.com/u/23036407?v=4","gravatar_id":"","url":"https://api.github.com/users/sdininno","html_url":"https://github.com/sdininno","followers_url":"https://api.github.com/users/sdininno/followers","following_url":"https://api.github.com/users/sdininno/following{/other_user}","gists_url":"https://api.github.com/users/sdininno/gists{/gist_id}","starred_url":"https://api.github.com/users/sdininno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdininno/subscriptions","organizations_url":"https://api.github.com/users/sdininno/orgs","repos_url":"https://api.github.com/users/sdininno/repos","events_url":"https://api.github.com/users/sdininno/events{/privacy}","received_events_url":"https://api.github.com/users/sdininno/received_events","type":"User","site_admin":false},"body":"This is the first part of the pull request #2216\r\n\r\nThis is a cleanup and reorganising the header file. It does not change the number of SoC or the feature supported.\r\n<!--\r\n    If you are new to submitting pull requests to OP-TEE, then please have a\r\n    look at the list below and tick them off before submitting the pull request.\r\n\r\n    1. Read our contribution guidelines:\r\n         documentation/github.md.\r\n\r\n    2. Read the contribution section in Notice.md and pay extra attention to the\r\n       \"Developer Certificate of Origin\" part:\r\n         https://github.com/OP-TEE/optee_os/blob/master/Notice.md#contributions.\r\n\r\n    3. You should run checkpatch preferably before submitting the pull request.\r\n\r\n    4. When everything has been reviewed, you will need to squash, rebase and\r\n       add tags like `Reviewed-by`, `Acked-by`, `Tested-by` etc.\r\n\r\n    NOTE: This comment will not be shown in the pull request, so no harm keeping\r\n    it, but feel free to remove it if you like.\r\n-->\r\n","created_at":"2018-03-27T12:37:20Z","updated_at":"2018-03-27T13:46:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2500da1206ef71fe237114d01fbe2b473d02e4b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2217/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/6d8a9df04e5023eee6e7cd9212c3ee75fd4a19c7","head":{"label":"sdininno:feature/upstream/part1","ref":"feature/upstream/part1","sha":"6d8a9df04e5023eee6e7cd9212c3ee75fd4a19c7","user":{"login":"sdininno","id":23036407,"avatar_url":"https://avatars3.githubusercontent.com/u/23036407?v=4","gravatar_id":"","url":"https://api.github.com/users/sdininno","html_url":"https://github.com/sdininno","followers_url":"https://api.github.com/users/sdininno/followers","following_url":"https://api.github.com/users/sdininno/following{/other_user}","gists_url":"https://api.github.com/users/sdininno/gists{/gist_id}","starred_url":"https://api.github.com/users/sdininno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdininno/subscriptions","organizations_url":"https://api.github.com/users/sdininno/orgs","repos_url":"https://api.github.com/users/sdininno/repos","events_url":"https://api.github.com/users/sdininno/events{/privacy}","received_events_url":"https://api.github.com/users/sdininno/received_events","type":"User","site_admin":false},"repo":{"id":126526749,"name":"optee_os","full_name":"sdininno/optee_os","owner":{"login":"sdininno","id":23036407,"avatar_url":"https://avatars3.githubusercontent.com/u/23036407?v=4","gravatar_id":"","url":"https://api.github.com/users/sdininno","html_url":"https://github.com/sdininno","followers_url":"https://api.github.com/users/sdininno/followers","following_url":"https://api.github.com/users/sdininno/following{/other_user}","gists_url":"https://api.github.com/users/sdininno/gists{/gist_id}","starred_url":"https://api.github.com/users/sdininno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdininno/subscriptions","organizations_url":"https://api.github.com/users/sdininno/orgs","repos_url":"https://api.github.com/users/sdininno/repos","events_url":"https://api.github.com/users/sdininno/events{/privacy}","received_events_url":"https://api.github.com/users/sdininno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdininno/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/sdininno/optee_os","forks_url":"https://api.github.com/repos/sdininno/optee_os/forks","keys_url":"https://api.github.com/repos/sdininno/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdininno/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdininno/optee_os/teams","hooks_url":"https://api.github.com/repos/sdininno/optee_os/hooks","issue_events_url":"https://api.github.com/repos/sdininno/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/sdininno/optee_os/events","assignees_url":"https://api.github.com/repos/sdininno/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/sdininno/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/sdininno/optee_os/tags","blobs_url":"https://api.github.com/repos/sdininno/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdininno/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdininno/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdininno/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdininno/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/sdininno/optee_os/languages","stargazers_url":"https://api.github.com/repos/sdininno/optee_os/stargazers","contributors_url":"https://api.github.com/repos/sdininno/optee_os/contributors","subscribers_url":"https://api.github.com/repos/sdininno/optee_os/subscribers","subscription_url":"https://api.github.com/repos/sdininno/optee_os/subscription","commits_url":"https://api.github.com/repos/sdininno/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdininno/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdininno/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdininno/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdininno/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/sdininno/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdininno/optee_os/merges","archive_url":"https://api.github.com/repos/sdininno/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdininno/optee_os/downloads","issues_url":"https://api.github.com/repos/sdininno/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/sdininno/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/sdininno/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/sdininno/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdininno/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/sdininno/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/sdininno/optee_os/deployments","created_at":"2018-03-23T18:49:50Z","updated_at":"2018-03-23T18:49:56Z","pushed_at":"2018-03-27T12:33:57Z","git_url":"git://github.com/sdininno/optee_os.git","ssh_url":"git@github.com:sdininno/optee_os.git","clone_url":"https://github.com/sdininno/optee_os.git","svn_url":"https://github.com/sdininno/optee_os","homepage":null,"size":12851,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"628a9a10ca369de28147b52b56e901bb2a0806f9","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_os/deployments","created_at":"2014-05-26T17:18:57Z","updated_at":"2018-03-27T07:12:04Z","pushed_at":"2018-03-27T13:31:43Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":12805,"stargazers_count":364,"watchers_count":364,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":320,"mirror_url":null,"archived":false,"open_issues_count":165,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":320,"open_issues":165,"watchers":364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2217"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2217"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2217/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2217/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/6d8a9df04e5023eee6e7cd9212c3ee75fd4a19c7"}},"author_association":"NONE"}}
{"actor":{"display_login":"sdininno"}}