{"action":"created","issue":{"url":"https://api.github.com/repos/byu-oit/android-byu-suite-v2/issues/563","repository_url":"https://api.github.com/repos/byu-oit/android-byu-suite-v2","labels_url":"https://api.github.com/repos/byu-oit/android-byu-suite-v2/issues/563/labels{/name}","comments_url":"https://api.github.com/repos/byu-oit/android-byu-suite-v2/issues/563/comments","events_url":"https://api.github.com/repos/byu-oit/android-byu-suite-v2/issues/563/events","html_url":"https://github.com/byu-oit/android-byu-suite-v2/pull/563","id":329990913,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTA4MTQ5","number":563,"title":"hotfix/loginError -> dev","user":{"login":"geogor37","id":25857966,"node_id":"MDQ6VXNlcjI1ODU3OTY2","avatar_url":"https://avatars1.githubusercontent.com/u/25857966?v=4","gravatar_id":"","url":"https://api.github.com/users/geogor37","html_url":"https://github.com/geogor37","followers_url":"https://api.github.com/users/geogor37/followers","following_url":"https://api.github.com/users/geogor37/following{/other_user}","gists_url":"https://api.github.com/users/geogor37/gists{/gist_id}","starred_url":"https://api.github.com/users/geogor37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geogor37/subscriptions","organizations_url":"https://api.github.com/users/geogor37/orgs","repos_url":"https://api.github.com/users/geogor37/repos","events_url":"https://api.github.com/users/geogor37/events{/privacy}","received_events_url":"https://api.github.com/users/geogor37/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-06-06T18:55:53Z","updated_at":"2018-06-19T18:39:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/byu-oit/android-byu-suite-v2/pulls/563","html_url":"https://github.com/byu-oit/android-byu-suite-v2/pull/563","diff_url":"https://github.com/byu-oit/android-byu-suite-v2/pull/563.diff","patch_url":"https://github.com/byu-oit/android-byu-suite-v2/pull/563.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/byu-oit/android-byu-suite-v2/563)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/byu-oit/android-byu-suite-v2/issues/comments/398502696","html_url":"https://github.com/byu-oit/android-byu-suite-v2/pull/563#issuecomment-398502696","issue_url":"https://api.github.com/repos/byu-oit/android-byu-suite-v2/issues/563","id":398502696,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODUwMjY5Ng==","user":{"login":"geogor37","id":25857966,"node_id":"MDQ6VXNlcjI1ODU3OTY2","avatar_url":"https://avatars1.githubusercontent.com/u/25857966?v=4","gravatar_id":"","url":"https://api.github.com/users/geogor37","html_url":"https://github.com/geogor37","followers_url":"https://api.github.com/users/geogor37/followers","following_url":"https://api.github.com/users/geogor37/following{/other_user}","gists_url":"https://api.github.com/users/geogor37/gists{/gist_id}","starred_url":"https://api.github.com/users/geogor37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geogor37/subscriptions","organizations_url":"https://api.github.com/users/geogor37/orgs","repos_url":"https://api.github.com/users/geogor37/repos","events_url":"https://api.github.com/users/geogor37/events{/privacy}","received_events_url":"https://api.github.com/users/geogor37/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T18:39:40Z","updated_at":"2018-06-19T18:39:40Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 15 of 17 files reviewed, 12 unresolved discussions (waiting on @romrell4 and @geogor37)\n\n---\n\n*[support/src/main/java/edu/byu/support/login/LoginCallback.kt, line 40 at r5](https://reviewable.io/reviews/byu-oit/android-byu-suite-v2/563#-LFKZyDI7qldIM2AXAoo:-LFOH_z-Bj9OQGgKXrIn:b5np20g) ([raw file](https://github.com/byu-oit/android-byu-suite-v2/blob/90a0e74484fa737858ee77defae1a46a8efd5ad0/support/src/main/java/edu/byu/support/login/LoginCallback.kt#L40)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\ncan We do it for all of them? Including the ones above?\n</blockquote></details>\n\nOh, right. Done.\n\n---\n\n*[support/src/main/java/edu/byu/support/login/LoginCallback.kt, line 36 at r6](https://reviewable.io/reviews/byu-oit/android-byu-suite-v2/563#-LFO-3MF2mUztlZDr_UW:-LFOHVx23HUabmHX_BIN:b-896fix) ([raw file](https://github.com/byu-oit/android-byu-suite-v2/blob/8e590ad52c6d0a7bae42fe30fb7a0dfd38f43684/support/src/main/java/edu/byu/support/login/LoginCallback.kt#L36)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nDeal. Add it to the Trello board\n</blockquote></details>\n\nDone.\n\n---\n\n*[support/src/main/java/edu/byu/support/retrofit/ByuCallback.java, line 78 at r3](https://reviewable.io/reviews/byu-oit/android-byu-suite-v2/563#-LF3ivZ_EszO1UvqykWh:-LFOK92u1XgQ2ioanf90:byhvrv5) ([raw file](https://github.com/byu-oit/android-byu-suite-v2/blob/7290832ff5dd6decfd9ccefb7e076504df9d0270/support/src/main/java/edu/byu/support/retrofit/ByuCallback.java#L78)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nAnytime in the app we explicitly handle a 4XX code differently\n</blockquote></details>\n\nThe only time we handle a 4XX code differently as far as retrying calls are concerned, is the one in MFC that you already knew about. There are only two other cases where we handle a 400 error differently and they both deal with UI stuff, such as changing the message that gets displayed to the user.\n\n---\n\n*[support/src/main/java/edu/byu/support/retrofit/ByuError.java, line 74 at r7](https://reviewable.io/reviews/byu-oit/android-byu-suite-v2/563#-LFOH3hG9Hglncf9ic8I:-LFOI9Zm2KJbcGguIFVl:b-896fix) ([raw file](https://github.com/byu-oit/android-byu-suite-v2/blob/3aa157e014c2472e19fab3dc39b73c2593135301/support/src/main/java/edu/byu/support/retrofit/ByuError.java#L74)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nEh. Remove\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/byu-oit/android-byu-suite-v2/563)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"geogor37"}}