{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/aulasoftwarelibre/iam/pulls/13","id":207815772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODE1Nzcy","html_url":"https://github.com/aulasoftwarelibre/iam/pull/13","diff_url":"https://github.com/aulasoftwarelibre/iam/pull/13.diff","patch_url":"https://github.com/aulasoftwarelibre/iam/pull/13.patch","issue_url":"https://api.github.com/repos/aulasoftwarelibre/iam/issues/13","number":13,"state":"closed","locked":false,"title":"Code refactorization","user":{"login":"sgomez","id":580701,"node_id":"MDQ6VXNlcjU4MDcwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/580701?v=4","gravatar_id":"","url":"https://api.github.com/users/sgomez","html_url":"https://github.com/sgomez","followers_url":"https://api.github.com/users/sgomez/followers","following_url":"https://api.github.com/users/sgomez/following{/other_user}","gists_url":"https://api.github.com/users/sgomez/gists{/gist_id}","starred_url":"https://api.github.com/users/sgomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgomez/subscriptions","organizations_url":"https://api.github.com/users/sgomez/orgs","repos_url":"https://api.github.com/users/sgomez/repos","events_url":"https://api.github.com/users/sgomez/events{/privacy}","received_events_url":"https://api.github.com/users/sgomez/received_events","type":"User","site_admin":false},"body":"The main functionality is done. We start to refactorize and clean code:\r\n\r\n### Scope\r\n\r\n* Changed the next value objects:\r\n  * Name by ScopeName\r\n  * ShortName by ScopeAlias\r\n* Removed queries\r\n* Added more features for API\r\n* Changed some ScopeViews calls:\r\n  * changed `findBy` prefix  by `of`\r\n* Restore CreateScope behaviuor: just for new instances\r\n* ScopeDataPersister checks if it is a POST or PUT request.\r\n* Consistency between `of` and `get` calls in repositories.\r\n`get` calls always launch exceptions if the entity is not found.\r\n\r\n### Role\r\n\r\n* Removed queries\r\n* Added more features\r\n* Changed RoleViews calls\r\n* Consistency in Repository calls\r\n\r\n### User\r\n\r\n* Removed queries\r\n* Changed RoleUser methods\r\n* Consistency in repository calls","created_at":"2018-08-12T11:00:46Z","updated_at":"2018-08-12T19:04:50Z","closed_at":"2018-08-12T19:04:50Z","merged_at":"2018-08-12T19:04:50Z","merge_commit_sha":"1f83c1d8e99622197193616525823b5a2e011c2c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aulasoftwarelibre/iam/pulls/13/commits","review_comments_url":"https://api.github.com/repos/aulasoftwarelibre/iam/pulls/13/comments","review_comment_url":"https://api.github.com/repos/aulasoftwarelibre/iam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aulasoftwarelibre/iam/issues/13/comments","statuses_url":"https://api.github.com/repos/aulasoftwarelibre/iam/statuses/9bca6a16f6ef8f967816183e8320052ca664abe7","head":{"label":"aulasoftwarelibre:feature/code-refactoring","ref":"feature/code-refactoring","sha":"9bca6a16f6ef8f967816183e8320052ca664abe7","user":{"login":"aulasoftwarelibre","id":446696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NjY5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/446696?v=4","gravatar_id":"","url":"https://api.github.com/users/aulasoftwarelibre","html_url":"https://github.com/aulasoftwarelibre","followers_url":"https://api.github.com/users/aulasoftwarelibre/followers","following_url":"https://api.github.com/users/aulasoftwarelibre/following{/other_user}","gists_url":"https://api.github.com/users/aulasoftwarelibre/gists{/gist_id}","starred_url":"https://api.github.com/users/aulasoftwarelibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aulasoftwarelibre/subscriptions","organizations_url":"https://api.github.com/users/aulasoftwarelibre/orgs","repos_url":"https://api.github.com/users/aulasoftwarelibre/repos","events_url":"https://api.github.com/users/aulasoftwarelibre/events{/privacy}","received_events_url":"https://api.github.com/users/aulasoftwarelibre/received_events","type":"Organization","site_admin":false},"repo":{"id":140600397,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2MDAzOTc=","name":"iam","full_name":"aulasoftwarelibre/iam","owner":{"login":"aulasoftwarelibre","id":446696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NjY5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/446696?v=4","gravatar_id":"","url":"https://api.github.com/users/aulasoftwarelibre","html_url":"https://github.com/aulasoftwarelibre","followers_url":"https://api.github.com/users/aulasoftwarelibre/followers","following_url":"https://api.github.com/users/aulasoftwarelibre/following{/other_user}","gists_url":"https://api.github.com/users/aulasoftwarelibre/gists{/gist_id}","starred_url":"https://api.github.com/users/aulasoftwarelibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aulasoftwarelibre/subscriptions","organizations_url":"https://api.github.com/users/aulasoftwarelibre/orgs","repos_url":"https://api.github.com/users/aulasoftwarelibre/repos","events_url":"https://api.github.com/users/aulasoftwarelibre/events{/privacy}","received_events_url":"https://api.github.com/users/aulasoftwarelibre/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aulasoftwarelibre/iam","description":"Identity and Access Management for DDD projects","fork":false,"url":"https://api.github.com/repos/aulasoftwarelibre/iam","forks_url":"https://api.github.com/repos/aulasoftwarelibre/iam/forks","keys_url":"https://api.github.com/repos/aulasoftwarelibre/iam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aulasoftwarelibre/iam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aulasoftwarelibre/iam/teams","hooks_url":"https://api.github.com/repos/aulasoftwarelibre/iam/hooks","issue_events_url":"https://api.github.com/repos/aulasoftwarelibre/iam/issues/events{/number}","events_url":"https://api.github.com/repos/aulasoftwarelibre/iam/events","assignees_url":"https://api.github.com/repos/aulasoftwarelibre/iam/assignees{/user}","branches_url":"https://api.github.com/repos/aulasoftwarelibre/iam/branches{/branch}","tags_url":"https://api.github.com/repos/aulasoftwarelibre/iam/tags","blobs_url":"https://api.github.com/repos/aulasoftwarelibre/iam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aulasoftwarelibre/iam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aulasoftwarelibre/iam/git/refs{/sha}","trees_url":"https://api.github.com/repos/aulasoftwarelibre/iam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aulasoftwarelibre/iam/statuses/{sha}","languages_url":"https://api.github.com/repos/aulasoftwarelibre/iam/languages","stargazers_url":"https://api.github.com/repos/aulasoftwarelibre/iam/stargazers","contributors_url":"https://api.github.com/repos/aulasoftwarelibre/iam/contributors","subscribers_url":"https://api.github.com/repos/aulasoftwarelibre/iam/subscribers","subscription_url":"https://api.github.com/repos/aulasoftwarelibre/iam/subscription","commits_url":"https://api.github.com/repos/aulasoftwarelibre/iam/commits{/sha}","git_commits_url":"https://api.github.com/repos/aulasoftwarelibre/iam/git/commits{/sha}","comments_url":"https://api.github.com/repos/aulasoftwarelibre/iam/comments{/number}","issue_comment_url":"https://api.github.com/repos/aulasoftwarelibre/iam/issues/comments{/number}","contents_url":"https://api.github.com/repos/aulasoftwarelibre/iam/contents/{+path}","compare_url":"https://api.github.com/repos/aulasoftwarelibre/iam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aulasoftwarelibre/iam/merges","archive_url":"https://api.github.com/repos/aulasoftwarelibre/iam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aulasoftwarelibre/iam/downloads","issues_url":"https://api.github.com/repos/aulasoftwarelibre/iam/issues{/number}","pulls_url":"https://api.github.com/repos/aulasoftwarelibre/iam/pulls{/number}","milestones_url":"https://api.github.com/repos/aulasoftwarelibre/iam/milestones{/number}","notifications_url":"https://api.github.com/repos/aulasoftwarelibre/iam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aulasoftwarelibre/iam/labels{/name}","releases_url":"https://api.github.com/repos/aulasoftwarelibre/iam/releases{/id}","deployments_url":"https://api.github.com/repos/aulasoftwarelibre/iam/deployments","created_at":"2018-07-11T16:15:03Z","updated_at":"2018-08-12T09:51:06Z","pushed_at":"2018-08-12T19:04:50Z","git_url":"git://github.com/aulasoftwarelibre/iam.git","ssh_url":"git@github.com:aulasoftwarelibre/iam.git","clone_url":"https://github.com/aulasoftwarelibre/iam.git","svn_url":"https://github.com/aulasoftwarelibre/iam","homepage":"","size":696,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":5,"default_branch":"develop"}},"base":{"label":"aulasoftwarelibre:develop","ref":"develop","sha":"acf0b0a3a213fbff53ad6db2e7d26b566b231817","user":{"login":"aulasoftwarelibre","id":446696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NjY5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/446696?v=4","gravatar_id":"","url":"https://api.github.com/users/aulasoftwarelibre","html_url":"https://github.com/aulasoftwarelibre","followers_url":"https://api.github.com/users/aulasoftwarelibre/followers","following_url":"https://api.github.com/users/aulasoftwarelibre/following{/other_user}","gists_url":"https://api.github.com/users/aulasoftwarelibre/gists{/gist_id}","starred_url":"https://api.github.com/users/aulasoftwarelibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aulasoftwarelibre/subscriptions","organizations_url":"https://api.github.com/users/aulasoftwarelibre/orgs","repos_url":"https://api.github.com/users/aulasoftwarelibre/repos","events_url":"https://api.github.com/users/aulasoftwarelibre/events{/privacy}","received_events_url":"https://api.github.com/users/aulasoftwarelibre/received_events","type":"Organization","site_admin":false},"repo":{"id":140600397,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2MDAzOTc=","name":"iam","full_name":"aulasoftwarelibre/iam","owner":{"login":"aulasoftwarelibre","id":446696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NjY5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/446696?v=4","gravatar_id":"","url":"https://api.github.com/users/aulasoftwarelibre","html_url":"https://github.com/aulasoftwarelibre","followers_url":"https://api.github.com/users/aulasoftwarelibre/followers","following_url":"https://api.github.com/users/aulasoftwarelibre/following{/other_user}","gists_url":"https://api.github.com/users/aulasoftwarelibre/gists{/gist_id}","starred_url":"https://api.github.com/users/aulasoftwarelibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aulasoftwarelibre/subscriptions","organizations_url":"https://api.github.com/users/aulasoftwarelibre/orgs","repos_url":"https://api.github.com/users/aulasoftwarelibre/repos","events_url":"https://api.github.com/users/aulasoftwarelibre/events{/privacy}","received_events_url":"https://api.github.com/users/aulasoftwarelibre/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aulasoftwarelibre/iam","description":"Identity and Access Management for DDD projects","fork":false,"url":"https://api.github.com/repos/aulasoftwarelibre/iam","forks_url":"https://api.github.com/repos/aulasoftwarelibre/iam/forks","keys_url":"https://api.github.com/repos/aulasoftwarelibre/iam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aulasoftwarelibre/iam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aulasoftwarelibre/iam/teams","hooks_url":"https://api.github.com/repos/aulasoftwarelibre/iam/hooks","issue_events_url":"https://api.github.com/repos/aulasoftwarelibre/iam/issues/events{/number}","events_url":"https://api.github.com/repos/aulasoftwarelibre/iam/events","assignees_url":"https://api.github.com/repos/aulasoftwarelibre/iam/assignees{/user}","branches_url":"https://api.github.com/repos/aulasoftwarelibre/iam/branches{/branch}","tags_url":"https://api.github.com/repos/aulasoftwarelibre/iam/tags","blobs_url":"https://api.github.com/repos/aulasoftwarelibre/iam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aulasoftwarelibre/iam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aulasoftwarelibre/iam/git/refs{/sha}","trees_url":"https://api.github.com/repos/aulasoftwarelibre/iam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aulasoftwarelibre/iam/statuses/{sha}","languages_url":"https://api.github.com/repos/aulasoftwarelibre/iam/languages","stargazers_url":"https://api.github.com/repos/aulasoftwarelibre/iam/stargazers","contributors_url":"https://api.github.com/repos/aulasoftwarelibre/iam/contributors","subscribers_url":"https://api.github.com/repos/aulasoftwarelibre/iam/subscribers","subscription_url":"https://api.github.com/repos/aulasoftwarelibre/iam/subscription","commits_url":"https://api.github.com/repos/aulasoftwarelibre/iam/commits{/sha}","git_commits_url":"https://api.github.com/repos/aulasoftwarelibre/iam/git/commits{/sha}","comments_url":"https://api.github.com/repos/aulasoftwarelibre/iam/comments{/number}","issue_comment_url":"https://api.github.com/repos/aulasoftwarelibre/iam/issues/comments{/number}","contents_url":"https://api.github.com/repos/aulasoftwarelibre/iam/contents/{+path}","compare_url":"https://api.github.com/repos/aulasoftwarelibre/iam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aulasoftwarelibre/iam/merges","archive_url":"https://api.github.com/repos/aulasoftwarelibre/iam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aulasoftwarelibre/iam/downloads","issues_url":"https://api.github.com/repos/aulasoftwarelibre/iam/issues{/number}","pulls_url":"https://api.github.com/repos/aulasoftwarelibre/iam/pulls{/number}","milestones_url":"https://api.github.com/repos/aulasoftwarelibre/iam/milestones{/number}","notifications_url":"https://api.github.com/repos/aulasoftwarelibre/iam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aulasoftwarelibre/iam/labels{/name}","releases_url":"https://api.github.com/repos/aulasoftwarelibre/iam/releases{/id}","deployments_url":"https://api.github.com/repos/aulasoftwarelibre/iam/deployments","created_at":"2018-07-11T16:15:03Z","updated_at":"2018-08-12T09:51:06Z","pushed_at":"2018-08-12T19:04:50Z","git_url":"git://github.com/aulasoftwarelibre/iam.git","ssh_url":"git@github.com:aulasoftwarelibre/iam.git","clone_url":"https://github.com/aulasoftwarelibre/iam.git","svn_url":"https://github.com/aulasoftwarelibre/iam","homepage":"","size":696,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/aulasoftwarelibre/iam/pulls/13"},"html":{"href":"https://github.com/aulasoftwarelibre/iam/pull/13"},"issue":{"href":"https://api.github.com/repos/aulasoftwarelibre/iam/issues/13"},"comments":{"href":"https://api.github.com/repos/aulasoftwarelibre/iam/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/aulasoftwarelibre/iam/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/aulasoftwarelibre/iam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aulasoftwarelibre/iam/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/aulasoftwarelibre/iam/statuses/9bca6a16f6ef8f967816183e8320052ca664abe7"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sgomez","id":580701,"node_id":"MDQ6VXNlcjU4MDcwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/580701?v=4","gravatar_id":"","url":"https://api.github.com/users/sgomez","html_url":"https://github.com/sgomez","followers_url":"https://api.github.com/users/sgomez/followers","following_url":"https://api.github.com/users/sgomez/following{/other_user}","gists_url":"https://api.github.com/users/sgomez/gists{/gist_id}","starred_url":"https://api.github.com/users/sgomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgomez/subscriptions","organizations_url":"https://api.github.com/users/sgomez/orgs","repos_url":"https://api.github.com/users/sgomez/repos","events_url":"https://api.github.com/users/sgomez/events{/privacy}","received_events_url":"https://api.github.com/users/sgomez/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":595,"deletions":1364,"changed_files":91}}
{"actor":{"display_login":"sgomez"}}