{"action":"created","issue":{"url":"https://api.github.com/repos/Ensembl/Bio-DB-HTS/issues/69","repository_url":"https://api.github.com/repos/Ensembl/Bio-DB-HTS","labels_url":"https://api.github.com/repos/Ensembl/Bio-DB-HTS/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/Ensembl/Bio-DB-HTS/issues/69/comments","events_url":"https://api.github.com/repos/Ensembl/Bio-DB-HTS/issues/69/events","html_url":"https://github.com/Ensembl/Bio-DB-HTS/pull/69","id":306879194,"number":69,"title":"Minor build improvements and warning fixes","user":{"login":"jmarshall","id":70921,"avatar_url":"https://avatars3.githubusercontent.com/u/70921?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarshall","html_url":"https://github.com/jmarshall","followers_url":"https://api.github.com/users/jmarshall/followers","following_url":"https://api.github.com/users/jmarshall/following{/other_user}","gists_url":"https://api.github.com/users/jmarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarshall/subscriptions","organizations_url":"https://api.github.com/users/jmarshall/orgs","repos_url":"https://api.github.com/users/jmarshall/repos","events_url":"https://api.github.com/users/jmarshall/events{/privacy}","received_events_url":"https://api.github.com/users/jmarshall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-20T14:03:32Z","updated_at":"2018-03-20T15:19:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Ensembl/Bio-DB-HTS/pulls/69","html_url":"https://github.com/Ensembl/Bio-DB-HTS/pull/69","diff_url":"https://github.com/Ensembl/Bio-DB-HTS/pull/69.diff","patch_url":"https://github.com/Ensembl/Bio-DB-HTS/pull/69.patch"},"body":"Some changes to _Build.PL_ so that it will recognise HTSlib directories containing only _libhts.so_ (thus without _libhts.a_, i.e., when you have built only the shared library).\r\n\r\nWarning fixes in the XS module code. With these patches, if you hack `-Wno-unused` into _Build.PL_:\r\n\r\n```diff\r\n         # Don't care about unused results from function calls\r\n+        '-Wno-unused',\r\n         '-Wno-unused-result',  ],\r\n```\r\n\r\nthen the XS and _.c_ code will compile without any warnings. Which makes it easier to see the warnings in your own new code. :smile:\r\n\r\nIf you don't add `-Wno-unused` as well, you get a lot of _unused variable_ warnings — notably for `packname`, which is universally unused."},"comment":{"url":"https://api.github.com/repos/Ensembl/Bio-DB-HTS/issues/comments/374637062","html_url":"https://github.com/Ensembl/Bio-DB-HTS/pull/69#issuecomment-374637062","issue_url":"https://api.github.com/repos/Ensembl/Bio-DB-HTS/issues/69","id":374637062,"user":{"login":"avullo","id":6085263,"avatar_url":"https://avatars0.githubusercontent.com/u/6085263?v=4","gravatar_id":"","url":"https://api.github.com/users/avullo","html_url":"https://github.com/avullo","followers_url":"https://api.github.com/users/avullo/followers","following_url":"https://api.github.com/users/avullo/following{/other_user}","gists_url":"https://api.github.com/users/avullo/gists{/gist_id}","starred_url":"https://api.github.com/users/avullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avullo/subscriptions","organizations_url":"https://api.github.com/users/avullo/orgs","repos_url":"https://api.github.com/users/avullo/repos","events_url":"https://api.github.com/users/avullo/events{/privacy}","received_events_url":"https://api.github.com/users/avullo/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T15:19:28Z","updated_at":"2018-03-20T15:19:28Z","author_association":"MEMBER","body":"I agree. You probably have $CXX set with some extra include flag?!"}}
{"actor":{"display_login":"avullo"}}