{"action":"created","issue":{"url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1046","repository_url":"https://api.github.com/repos/ethersphere/go-ethereum","labels_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1046/labels{/name}","comments_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1046/comments","events_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1046/events","html_url":"https://github.com/ethersphere/go-ethereum/issues/1046","id":387762625,"node_id":"MDU6SXNzdWUzODc3NjI2MjU=","number":1046,"title":"Add API to unsubscribe from a PSS subscription ","user":{"login":"PaulLeCam","id":790995,"node_id":"MDQ6VXNlcjc5MDk5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/790995?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulLeCam","html_url":"https://github.com/PaulLeCam","followers_url":"https://api.github.com/users/PaulLeCam/followers","following_url":"https://api.github.com/users/PaulLeCam/following{/other_user}","gists_url":"https://api.github.com/users/PaulLeCam/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulLeCam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulLeCam/subscriptions","organizations_url":"https://api.github.com/users/PaulLeCam/orgs","repos_url":"https://api.github.com/users/PaulLeCam/repos","events_url":"https://api.github.com/users/PaulLeCam/events{/privacy}","received_events_url":"https://api.github.com/users/PaulLeCam/received_events","type":"User","site_admin":false},"labels":[{"id":86320164,"node_id":"MDU6TGFiZWw4NjMyMDE2NA==","url":"https://api.github.com/repos/ethersphere/go-ethereum/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":777000422,"node_id":"MDU6TGFiZWw3NzcwMDA0MjI=","url":"https://api.github.com/repos/ethersphere/go-ethereum/labels/pss","name":"pss","color":"c7f968","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-05T13:43:09Z","updated_at":"2018-12-06T09:46:44Z","closed_at":null,"author_association":"NONE","body":"#### System information\r\n\r\nSwarm version: any\r\nOS & Version: any\r\n\r\n#### Expected behaviour\r\n\r\nA client could unsubscribe from a subscription created using `pss_subscribe`.\r\n\r\n#### Actual behaviour\r\n\r\nNo such API is exposed over JSON-RPC.\r\n\r\n#### Steps to reproduce the behaviour\r\n\r\nN/A\r\n\r\n#### Backtrace\r\n\r\nN/A\r\n"},"comment":{"url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/comments/444812031","html_url":"https://github.com/ethersphere/go-ethereum/issues/1046#issuecomment-444812031","issue_url":"https://api.github.com/repos/ethersphere/go-ethereum/issues/1046","id":444812031,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDgxMjAzMQ==","user":{"login":"nolash","id":9886925,"node_id":"MDQ6VXNlcjk4ODY5MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9886925?v=4","gravatar_id":"","url":"https://api.github.com/users/nolash","html_url":"https://github.com/nolash","followers_url":"https://api.github.com/users/nolash/followers","following_url":"https://api.github.com/users/nolash/following{/other_user}","gists_url":"https://api.github.com/users/nolash/gists{/gist_id}","starred_url":"https://api.github.com/users/nolash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolash/subscriptions","organizations_url":"https://api.github.com/users/nolash/orgs","repos_url":"https://api.github.com/users/nolash/repos","events_url":"https://api.github.com/users/nolash/events{/privacy}","received_events_url":"https://api.github.com/users/nolash/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T09:46:44Z","updated_at":"2018-12-06T09:46:44Z","author_association":"NONE","body":"The api code does not keep track of subscriptions. While the subscription and topic handlers get terminated when the rpc client closes, this is not available on socket calls.\r\n\r\nA refactor is needed to keep all subscriptions keyed with id which is returned on socket, and a method to terminate it. See eg. `eth/downloader/api.go` for an example."}}
{"actor":{"display_login":"nolash"}}