{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/212836024","pull_request_review_id":149547746,"id":212836024,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjgzNjAyNA==","diff_hunk":"@@ -239,56 +239,38 @@ def _generate_range(cls, start, end, periods, freq, tz=None,\n         start, end, _normalized = _maybe_normalize_endpoints(start, end,\n                                                              normalize)\n \n-        tz, inferred_tz = _infer_tz_from_endpoints(start, end, tz)\n+        tz, _ = _infer_tz_from_endpoints(start, end, tz)\n \n-        if hasattr(freq, 'delta') and freq != Day():\n-            # sub-Day Tick\n-            if inferred_tz is None and tz is not None:\n-                # naive dates\n-                if start is not None and start.tz is None:\n-                    start = start.tz_localize(tz, ambiguous=False)\n+        # Make sure start and end are timezone localized if:\n+        # 1) freq = a Timedelta-like frequency (Tick)\n+        # 2) freq = None i.e. generating a linspaced range\n+        if isinstance(freq, Tick) or freq is None:\n+            localize_args = {'tz': tz, 'ambiguous': False}\n+        else:\n+            localize_args = {'tz': None}\n \n-                if end is not None and end.tz is None:\n-                    end = end.tz_localize(tz, ambiguous=False)\n+        if tz is not None:\n+            # Localize the start and end arguments\n+            if start is not None and start.tz is None:\n+                start = start.tz_localize(**localize_args)\n \n-            if start and end:\n-                if start.tz is None and end.tz is not None:\n-                    start = start.tz_localize(end.tz, ambiguous=False)\n+            if end is not None and end.tz is None:\n+                end = end.tz_localize(**localize_args)\n \n-                if end.tz is None and start.tz is not None:\n-                    end = end.tz_localize(start.tz, ambiguous=False)\n+        if start and end:\n+            # Make sure start and end have the same tz\n+            start = _maybe_localize_point(start, start.tz, end.tz,\n+                                          localize_args)\n+            end = _maybe_localize_point(end, end.tz, start.tz, localize_args)\n \n+        if freq is not None:\n             if cls._use_cached_range(freq, _normalized, start, end):\n+                # Currently always False; never hit","path":"pandas/core/arrays/datetimes.py","position":53,"original_position":53,"commit_id":"815811eb81372c3a2c78158783db9573e84b85e7","original_commit_id":"815811eb81372c3a2c78158783db9573e84b85e7","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"body":"Are we expecting this to be hit in the near future?","created_at":"2018-08-26T19:08:36Z","updated_at":"2018-08-26T19:08:36Z","html_url":"https://github.com/pandas-dev/pandas/pull/22288#discussion_r212836024","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22288","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/212836024"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/22288#discussion_r212836024"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22288"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22288","id":207798528,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Nzk4NTI4","html_url":"https://github.com/pandas-dev/pandas/pull/22288","diff_url":"https://github.com/pandas-dev/pandas/pull/22288.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/22288.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22288","number":22288,"state":"open","locked":false,"title":"API: Add CalendarDay ('CD') offset","user":{"login":"mroeschke","id":10647082,"node_id":"MDQ6VXNlcjEwNjQ3MDgy","avatar_url":"https://avatars0.githubusercontent.com/u/10647082?v=4","gravatar_id":"","url":"https://api.github.com/users/mroeschke","html_url":"https://github.com/mroeschke","followers_url":"https://api.github.com/users/mroeschke/followers","following_url":"https://api.github.com/users/mroeschke/following{/other_user}","gists_url":"https://api.github.com/users/mroeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/mroeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroeschke/subscriptions","organizations_url":"https://api.github.com/users/mroeschke/orgs","repos_url":"https://api.github.com/users/mroeschke/repos","events_url":"https://api.github.com/users/mroeschke/events{/privacy}","received_events_url":"https://api.github.com/users/mroeschke/received_events","type":"User","site_admin":false},"body":"- [x] closes #22274\r\n- [x] tests added / passed\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [x] whatsnew entry\r\n\r\nAdds `CalendarDay` and `'CD'` offset and alias respectively and changes `Day` (`'D'`) in `date_range` to respect calendar day. \r\n\r\nWith regards to `CalendarDay` added tests for:\r\n- `CalendarDay` arithmetic with itself, datetimes, and timedeltas (which should raise)\r\n- `'CD'` with use in `date_range` and `timedelta_range` (which should raise)\r\n- resampling with `'CD'`\r\n\r\nAlso refactored `_generate_range ` for `date_range` since we no longer have to check for `Day`\r\n","created_at":"2018-08-12T00:26:27Z","updated_at":"2018-08-26T19:08:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c59e430e6c459b0e8208cba57fad38fa3d9cccd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":35818298,"node_id":"MDU6TGFiZWwzNTgxODI5OA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/API%20Design","name":"API Design","color":"AD7FA8","default":false},{"id":53181044,"node_id":"MDU6TGFiZWw1MzE4MTA0NA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Frequency","name":"Frequency","color":"0052cc","default":false}],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55","html_url":"https://github.com/pandas-dev/pandas/milestone/55","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/55/labels","id":3228419,"node_id":"MDk6TWlsZXN0b25lMzIyODQxOQ==","number":55,"title":"0.24.0","description":"","creator":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"open_issues":136,"closed_issues":553,"state":"open","created_at":"2018-03-29T12:00:12Z","updated_at":"2018-08-25T09:11:46Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22288/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22288/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22288/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/815811eb81372c3a2c78158783db9573e84b85e7","head":{"label":"mroeschke:calendarday_offset","ref":"calendarday_offset","sha":"815811eb81372c3a2c78158783db9573e84b85e7","user":{"login":"mroeschke","id":10647082,"node_id":"MDQ6VXNlcjEwNjQ3MDgy","avatar_url":"https://avatars0.githubusercontent.com/u/10647082?v=4","gravatar_id":"","url":"https://api.github.com/users/mroeschke","html_url":"https://github.com/mroeschke","followers_url":"https://api.github.com/users/mroeschke/followers","following_url":"https://api.github.com/users/mroeschke/following{/other_user}","gists_url":"https://api.github.com/users/mroeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/mroeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroeschke/subscriptions","organizations_url":"https://api.github.com/users/mroeschke/orgs","repos_url":"https://api.github.com/users/mroeschke/repos","events_url":"https://api.github.com/users/mroeschke/events{/privacy}","received_events_url":"https://api.github.com/users/mroeschke/received_events","type":"User","site_admin":false},"repo":{"id":71015224,"node_id":"MDEwOlJlcG9zaXRvcnk3MTAxNTIyNA==","name":"pandas","full_name":"mroeschke/pandas","owner":{"login":"mroeschke","id":10647082,"node_id":"MDQ6VXNlcjEwNjQ3MDgy","avatar_url":"https://avatars0.githubusercontent.com/u/10647082?v=4","gravatar_id":"","url":"https://api.github.com/users/mroeschke","html_url":"https://github.com/mroeschke","followers_url":"https://api.github.com/users/mroeschke/followers","following_url":"https://api.github.com/users/mroeschke/following{/other_user}","gists_url":"https://api.github.com/users/mroeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/mroeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroeschke/subscriptions","organizations_url":"https://api.github.com/users/mroeschke/orgs","repos_url":"https://api.github.com/users/mroeschke/repos","events_url":"https://api.github.com/users/mroeschke/events{/privacy}","received_events_url":"https://api.github.com/users/mroeschke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mroeschke/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/mroeschke/pandas","forks_url":"https://api.github.com/repos/mroeschke/pandas/forks","keys_url":"https://api.github.com/repos/mroeschke/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mroeschke/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mroeschke/pandas/teams","hooks_url":"https://api.github.com/repos/mroeschke/pandas/hooks","issue_events_url":"https://api.github.com/repos/mroeschke/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/mroeschke/pandas/events","assignees_url":"https://api.github.com/repos/mroeschke/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/mroeschke/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/mroeschke/pandas/tags","blobs_url":"https://api.github.com/repos/mroeschke/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mroeschke/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mroeschke/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/mroeschke/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mroeschke/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/mroeschke/pandas/languages","stargazers_url":"https://api.github.com/repos/mroeschke/pandas/stargazers","contributors_url":"https://api.github.com/repos/mroeschke/pandas/contributors","subscribers_url":"https://api.github.com/repos/mroeschke/pandas/subscribers","subscription_url":"https://api.github.com/repos/mroeschke/pandas/subscription","commits_url":"https://api.github.com/repos/mroeschke/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/mroeschke/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/mroeschke/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/mroeschke/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/mroeschke/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/mroeschke/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mroeschke/pandas/merges","archive_url":"https://api.github.com/repos/mroeschke/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mroeschke/pandas/downloads","issues_url":"https://api.github.com/repos/mroeschke/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/mroeschke/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/mroeschke/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/mroeschke/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mroeschke/pandas/labels{/name}","releases_url":"https://api.github.com/repos/mroeschke/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/mroeschke/pandas/deployments","created_at":"2016-10-15T21:46:32Z","updated_at":"2018-07-31T05:36:19Z","pushed_at":"2018-08-26T18:34:20Z","git_url":"git://github.com/mroeschke/pandas.git","ssh_url":"git@github.com:mroeschke/pandas.git","clone_url":"https://github.com/mroeschke/pandas.git","svn_url":"https://github.com/mroeschke/pandas","homepage":"http://pandas.pydata.org","size":128750,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"2be2ba570453ab09f0c8da46dfd8e1a179771fee","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-08-26T18:43:27Z","pushed_at":"2018-08-26T18:44:08Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":129914,"stargazers_count":15744,"watchers_count":15744,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6336,"mirror_url":null,"archived":false,"open_issues_count":2751,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6336,"open_issues":2751,"watchers":15744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22288"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/22288"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/22288"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/22288/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22288/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22288/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/815811eb81372c3a2c78158783db9573e84b85e7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jbrockmendel"}}