{"action":"created","issue":{"url":"https://api.github.com/repos/marktext/marktext/issues/197","repository_url":"https://api.github.com/repos/marktext/marktext","labels_url":"https://api.github.com/repos/marktext/marktext/issues/197/labels{/name}","comments_url":"https://api.github.com/repos/marktext/marktext/issues/197/comments","events_url":"https://api.github.com/repos/marktext/marktext/issues/197/events","html_url":"https://github.com/marktext/marktext/pull/197","id":316384883,"number":197,"title":"Line break","user":{"login":"Jocs","id":9712830,"avatar_url":"https://avatars0.githubusercontent.com/u/9712830?v=4","gravatar_id":"","url":"https://api.github.com/users/Jocs","html_url":"https://github.com/Jocs","followers_url":"https://api.github.com/users/Jocs/followers","following_url":"https://api.github.com/users/Jocs/following{/other_user}","gists_url":"https://api.github.com/users/Jocs/gists{/gist_id}","starred_url":"https://api.github.com/users/Jocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jocs/subscriptions","organizations_url":"https://api.github.com/users/Jocs/orgs","repos_url":"https://api.github.com/users/Jocs/repos","events_url":"https://api.github.com/users/Jocs/events{/privacy}","received_events_url":"https://api.github.com/users/Jocs/received_events","type":"User","site_admin":false},"labels":[{"id":877373799,"url":"https://api.github.com/repos/marktext/marktext/labels/editor%20core","name":"editor core","color":"092963","default":false},{"id":748113528,"url":"https://api.github.com/repos/marktext/marktext/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-20T19:28:27Z","updated_at":"2018-04-22T10:05:06Z","closed_at":"2018-04-22T05:17:46Z","author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/marktext/marktext/pulls/197","html_url":"https://github.com/marktext/marktext/pull/197","diff_url":"https://github.com/marktext/marktext/pull/197.diff","patch_url":"https://github.com/marktext/marktext/pull/197.patch"},"body":"| Q                | A\r\n| ---------------- | ---\r\n| Bug fix?         | yes\r\n| New feature?     | yes\r\n| BC breaks?       | no\r\n| Deprecations?    | no\r\n| New tests added? | not needed\r\n| Fixed tickets    | #106  #159 \r\n| License          | MIT\r\n\r\n### Description\r\n\r\nSupport `soft line break` and `hard line break`.\r\n\r\nYou can use `shift + enter` to insert a soft line break when cursor is in `p block`.\r\n\r\nAdd two more spaces to the end of soft line break will become hard line break, and a `arrow down` marker will show at end last of line.\r\n\r\n- [x] import markdown contains line break\r\n- [x] export markdown contains line break\r\n- [x] hard line break marker\r\n- [x] events: `backspace`, `enter`, `arrow down\\up\\left\\right`\r\n- [x] export html and pdf.\r\n- [x] support `<br />` tag and use `shift + enter` to insert `<br />` in table cell. \r\n\r\n--\r\n\r\n#### Please, don't submit `/dist` files with your PR!\r\n"},"comment":{"url":"https://api.github.com/repos/marktext/marktext/issues/comments/383369581","html_url":"https://github.com/marktext/marktext/pull/197#issuecomment-383369581","issue_url":"https://api.github.com/repos/marktext/marktext/issues/197","id":383369581,"user":{"login":"fxha","id":22716132,"avatar_url":"https://avatars1.githubusercontent.com/u/22716132?v=4","gravatar_id":"","url":"https://api.github.com/users/fxha","html_url":"https://github.com/fxha","followers_url":"https://api.github.com/users/fxha/followers","following_url":"https://api.github.com/users/fxha/following{/other_user}","gists_url":"https://api.github.com/users/fxha/gists{/gist_id}","starred_url":"https://api.github.com/users/fxha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxha/subscriptions","organizations_url":"https://api.github.com/users/fxha/orgs","repos_url":"https://api.github.com/users/fxha/repos","events_url":"https://api.github.com/users/fxha/events{/privacy}","received_events_url":"https://api.github.com/users/fxha/received_events","type":"User","site_admin":false},"created_at":"2018-04-22T10:05:06Z","updated_at":"2018-04-22T10:05:06Z","author_association":"MEMBER","body":"> I think this is a loose list, even though there is no space between the items, because one of the items directly contains two block-level elements with a blank line between them, but marked.js file parse it as tight list item.So we need to modify marked.js file.\r\n\r\nSorry it's my fault. It's a loose list and I fixed the problem with loose/tight list feature and if you remove `baz` from the list everything is works fine, but with `baz` not. Also I can't open an issue for this, because line-breaks are not pushed to master, but it seems to be marked.js problem.\r\n\r\n> So soft line break is just a space when export to HTML.\r\n\r\nOk, but then editor and exported HTML are inconsistent.\r\n\r\nEditor:\r\n\r\n![mt_6_editor](https://user-images.githubusercontent.com/22716132/39093753-eed18042-4624-11e8-8400-1077efa711c3.png)\r\n\r\n\r\nBrowser:\r\n\r\n![mt_6_browser](https://user-images.githubusercontent.com/22716132/39093754-f137573a-4624-11e8-891e-4b0ce70c6b99.png)\r\n"}}
{"actor":{"display_login":"fxha"}}