{"action":"created","issue":{"url":"https://api.github.com/repos/plk/biblatex/issues/790","repository_url":"https://api.github.com/repos/plk/biblatex","labels_url":"https://api.github.com/repos/plk/biblatex/issues/790/labels{/name}","comments_url":"https://api.github.com/repos/plk/biblatex/issues/790/comments","events_url":"https://api.github.com/repos/plk/biblatex/issues/790/events","html_url":"https://github.com/plk/biblatex/pull/790","id":355566687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDY0NDQ3","number":790,"title":"Estonian: added translations","user":{"login":"kristiank","id":1181113,"node_id":"MDQ6VXNlcjExODExMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1181113?v=4","gravatar_id":"","url":"https://api.github.com/users/kristiank","html_url":"https://github.com/kristiank","followers_url":"https://api.github.com/users/kristiank/followers","following_url":"https://api.github.com/users/kristiank/following{/other_user}","gists_url":"https://api.github.com/users/kristiank/gists{/gist_id}","starred_url":"https://api.github.com/users/kristiank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristiank/subscriptions","organizations_url":"https://api.github.com/users/kristiank/orgs","repos_url":"https://api.github.com/users/kristiank/repos","events_url":"https://api.github.com/users/kristiank/events{/privacy}","received_events_url":"https://api.github.com/users/kristiank/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-08-30T12:39:31Z","updated_at":"2018-09-01T11:13:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/plk/biblatex/pulls/790","html_url":"https://github.com/plk/biblatex/pull/790","diff_url":"https://github.com/plk/biblatex/pull/790.diff","patch_url":"https://github.com/plk/biblatex/pull/790.patch"},"body":"Added some missing translations and fixed some old translations.\r\n\r\nPlease check whether \\DeclareBibliographyStrings is well-formed, e.g. is the comma `,` allowed on line 582.\r\n\r\n```\r\n\\DeclareBibliographyStrings{%\r\n% ... snip ...\r\n  am               = {{AM}{AM}},\r\n  pm               = {{PM}{PM}},   % <---- is this comma supposed to be here?\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/plk/biblatex/issues/comments/417852182","html_url":"https://github.com/plk/biblatex/pull/790#issuecomment-417852182","issue_url":"https://api.github.com/repos/plk/biblatex/issues/790","id":417852182,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzg1MjE4Mg==","user":{"login":"moewew","id":6755835,"node_id":"MDQ6VXNlcjY3NTU4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6755835?v=4","gravatar_id":"","url":"https://api.github.com/users/moewew","html_url":"https://github.com/moewew","followers_url":"https://api.github.com/users/moewew/followers","following_url":"https://api.github.com/users/moewew/following{/other_user}","gists_url":"https://api.github.com/users/moewew/gists{/gist_id}","starred_url":"https://api.github.com/users/moewew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moewew/subscriptions","organizations_url":"https://api.github.com/users/moewew/orgs","repos_url":"https://api.github.com/users/moewew/repos","events_url":"https://api.github.com/users/moewew/events{/privacy}","received_events_url":"https://api.github.com/users/moewew/received_events","type":"User","site_admin":false},"created_at":"2018-09-01T11:13:38Z","updated_at":"2018-09-01T11:13:38Z","author_association":"COLLABORATOR","body":"There should be a space in `U\\adddotS`\r\n\r\n```\r\nU\\adddot S\r\n```\r\nor even simpler\r\n```\r\nU.S\r\n```\r\nbecause in this special case `\\adddot` has no real benefit over a literal `.` (this also holds for all situations where `\\adddot` is directly followed by a comma).\r\n\r\nYou will also never want to have\r\n```latex\r\n\\adddotspace,\r\n```\r\nas in `byeditortrin` and a few other strings. \r\n```\r\n.,\r\n```\r\nwould be enough there or\r\n```\r\n\\adddot,\r\n``` \r\nif you prefer that (again the first is simpler and is at no disadvantage compared to `\\adddot,` in these situations).\r\n\r\nThere might also be a problem with `\\lblx@lfromlang`/`\\lbx@sfromlang`.\r\n- If a work has been translated (and `origlanguage` is defined), then `\\lbx@lfronlang` holds the string `from [the] <language>` so that you can use it to build `translated from the <language> by ...`.\r\n- The macro `\\lbx@sfromlang` should be used in the short form of the string, the long form should use `\\lbx@lfromlang`. It seems that currently all strings use `\\lbx@lfromlang`.\r\n- I also noticed that the position of the macro with respect to `` is not consistent.\r\nWe have `t\\~{o}lkinud \\lbx@lfromlang` but `toimetanud, \\lbx@lfromlang t\\~{o}lkinud ja kommenteerinud` Unfortunately, the test file does not populate the macro.\r\n\r\nTake the modified example file from https://gist.github.com/moewew/78da26715a5c2b76b033c7f2dfd21d69 that pretends that a work has been translated from the French. You will want to check all strings that output the word \"prantsuse\"."}}
{"actor":{"display_login":"moewew"}}