{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/188046254","pull_request_review_id":119946839,"id":188046254,"diff_hunk":"@@ -674,15 +674,17 @@ defmodule String do\n   end\n \n   def upcase(string, :ascii) when is_binary(string) do\n-    for <<x <- string>>,\n-      do: if(x >= ?a and x <= ?z, do: <<x - 32>>, else: <<x>>),\n-      into: \"\"\n+    IO.iodata_to_binary(upcase_ascii(string))\n   end\n \n   def upcase(string, mode) when mode in @conditional_mappings do\n     String.Casing.upcase(string, [], mode)\n   end\n ","path":"lib/elixir/lib/string.ex","position":13,"original_position":13,"commit_id":"93a03a42a5a2cf43dd15dfadea07782426f3e5a8","original_commit_id":"93a03a42a5a2cf43dd15dfadea07782426f3e5a8","user":{"login":"tckb","id":939542,"avatar_url":"https://avatars2.githubusercontent.com/u/939542?v=4","gravatar_id":"","url":"https://api.github.com/users/tckb","html_url":"https://github.com/tckb","followers_url":"https://api.github.com/users/tckb/followers","following_url":"https://api.github.com/users/tckb/following{/other_user}","gists_url":"https://api.github.com/users/tckb/gists{/gist_id}","starred_url":"https://api.github.com/users/tckb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tckb/subscriptions","organizations_url":"https://api.github.com/users/tckb/orgs","repos_url":"https://api.github.com/users/tckb/repos","events_url":"https://api.github.com/users/tckb/events{/privacy}","received_events_url":"https://api.github.com/users/tckb/received_events","type":"User","site_admin":false},"body":"@eksperimental normally, yes -- but as per @josevalim  using `in` at this level will cause bootstrapping issues.","created_at":"2018-05-14T18:06:50Z","updated_at":"2018-05-14T18:06:50Z","html_url":"https://github.com/elixir-lang/elixir/pull/7680#discussion_r188046254","pull_request_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/7680","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/188046254"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/7680#discussion_r188046254"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/7680"}},"in_reply_to_id":188001174},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/7680","id":187623221,"html_url":"https://github.com/elixir-lang/elixir/pull/7680","diff_url":"https://github.com/elixir-lang/elixir/pull/7680.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/7680.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/7680","number":7680,"state":"open","locked":false,"title":"Added performant impl for string upcase/downcase `:ascii` mode.","user":{"login":"tckb","id":939542,"avatar_url":"https://avatars2.githubusercontent.com/u/939542?v=4","gravatar_id":"","url":"https://api.github.com/users/tckb","html_url":"https://github.com/tckb","followers_url":"https://api.github.com/users/tckb/followers","following_url":"https://api.github.com/users/tckb/following{/other_user}","gists_url":"https://api.github.com/users/tckb/gists{/gist_id}","starred_url":"https://api.github.com/users/tckb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tckb/subscriptions","organizations_url":"https://api.github.com/users/tckb/orgs","repos_url":"https://api.github.com/users/tckb/repos","events_url":"https://api.github.com/users/tckb/events{/privacy}","received_events_url":"https://api.github.com/users/tckb/received_events","type":"User","site_admin":false},"body":"the existing implementation with binary comprehensions turned out to be\r\n_far_ slower than the other modes.\r\n\r\nThe current implementation is >= 2.5X faster than the earlier implementation\r\n\r\n---\r\nthis PR is a consequence of the discussions in #7673\r\n\r\nPS: this is my first PR in elixir ","created_at":"2018-05-12T14:16:41Z","updated_at":"2018-05-14T18:06:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"514a6b04b604460293035a91501544166a3547fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/7680/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/7680/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/7680/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/93a03a42a5a2cf43dd15dfadea07782426f3e5a8","head":{"label":"tckb:master","ref":"master","sha":"93a03a42a5a2cf43dd15dfadea07782426f3e5a8","user":{"login":"tckb","id":939542,"avatar_url":"https://avatars2.githubusercontent.com/u/939542?v=4","gravatar_id":"","url":"https://api.github.com/users/tckb","html_url":"https://github.com/tckb","followers_url":"https://api.github.com/users/tckb/followers","following_url":"https://api.github.com/users/tckb/following{/other_user}","gists_url":"https://api.github.com/users/tckb/gists{/gist_id}","starred_url":"https://api.github.com/users/tckb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tckb/subscriptions","organizations_url":"https://api.github.com/users/tckb/orgs","repos_url":"https://api.github.com/users/tckb/repos","events_url":"https://api.github.com/users/tckb/events{/privacy}","received_events_url":"https://api.github.com/users/tckb/received_events","type":"User","site_admin":false},"repo":{"id":133132485,"name":"elixir","full_name":"tckb/elixir","owner":{"login":"tckb","id":939542,"avatar_url":"https://avatars2.githubusercontent.com/u/939542?v=4","gravatar_id":"","url":"https://api.github.com/users/tckb","html_url":"https://github.com/tckb","followers_url":"https://api.github.com/users/tckb/followers","following_url":"https://api.github.com/users/tckb/following{/other_user}","gists_url":"https://api.github.com/users/tckb/gists{/gist_id}","starred_url":"https://api.github.com/users/tckb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tckb/subscriptions","organizations_url":"https://api.github.com/users/tckb/orgs","repos_url":"https://api.github.com/users/tckb/repos","events_url":"https://api.github.com/users/tckb/events{/privacy}","received_events_url":"https://api.github.com/users/tckb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tckb/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":true,"url":"https://api.github.com/repos/tckb/elixir","forks_url":"https://api.github.com/repos/tckb/elixir/forks","keys_url":"https://api.github.com/repos/tckb/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tckb/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tckb/elixir/teams","hooks_url":"https://api.github.com/repos/tckb/elixir/hooks","issue_events_url":"https://api.github.com/repos/tckb/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/tckb/elixir/events","assignees_url":"https://api.github.com/repos/tckb/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/tckb/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/tckb/elixir/tags","blobs_url":"https://api.github.com/repos/tckb/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tckb/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tckb/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/tckb/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tckb/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/tckb/elixir/languages","stargazers_url":"https://api.github.com/repos/tckb/elixir/stargazers","contributors_url":"https://api.github.com/repos/tckb/elixir/contributors","subscribers_url":"https://api.github.com/repos/tckb/elixir/subscribers","subscription_url":"https://api.github.com/repos/tckb/elixir/subscription","commits_url":"https://api.github.com/repos/tckb/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/tckb/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/tckb/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/tckb/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/tckb/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/tckb/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tckb/elixir/merges","archive_url":"https://api.github.com/repos/tckb/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tckb/elixir/downloads","issues_url":"https://api.github.com/repos/tckb/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/tckb/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/tckb/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/tckb/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tckb/elixir/labels{/name}","releases_url":"https://api.github.com/repos/tckb/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/tckb/elixir/deployments","created_at":"2018-05-12T09:34:02Z","updated_at":"2018-05-14T15:21:37Z","pushed_at":"2018-05-14T15:21:35Z","git_url":"git://github.com/tckb/elixir.git","ssh_url":"git@github.com:tckb/elixir.git","clone_url":"https://github.com/tckb/elixir.git","svn_url":"https://github.com/tckb/elixir","homepage":"http://elixir-lang.org/","size":36517,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"f72dd0a0c4a1f086855d43db9a097703dc94051e","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars1.githubusercontent.com/u/1481354?v=4","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars1.githubusercontent.com/u/1481354?v=4","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-lang/elixir/deployments","created_at":"2011-01-09T08:43:57Z","updated_at":"2018-05-14T16:56:27Z","pushed_at":"2018-05-14T15:21:37Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"git@github.com:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":36512,"stargazers_count":12930,"watchers_count":12930,"language":"Elixir","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1886,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1886,"open_issues":34,"watchers":12930,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/7680"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/7680"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/7680"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/7680/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/7680/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/7680/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/93a03a42a5a2cf43dd15dfadea07782426f3e5a8"}},"author_association":"NONE"}}
{"actor":{"display_login":"tckb"}}