{"action":"closed","number":7640,"pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/7640","id":198886218,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODg2MjE4","html_url":"https://github.com/webpack/webpack/pull/7640","diff_url":"https://github.com/webpack/webpack/pull/7640.diff","patch_url":"https://github.com/webpack/webpack/pull/7640.patch","issue_url":"https://api.github.com/repos/webpack/webpack/issues/7640","number":7640,"state":"closed","locked":false,"title":"Rename parser and its helpers","user":{"login":"ooflorent","id":168498,"node_id":"MDQ6VXNlcjE2ODQ5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/168498?v=4","gravatar_id":"","url":"https://api.github.com/users/ooflorent","html_url":"https://github.com/ooflorent","followers_url":"https://api.github.com/users/ooflorent/followers","following_url":"https://api.github.com/users/ooflorent/following{/other_user}","gists_url":"https://api.github.com/users/ooflorent/gists{/gist_id}","starred_url":"https://api.github.com/users/ooflorent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooflorent/subscriptions","organizations_url":"https://api.github.com/users/ooflorent/orgs","repos_url":"https://api.github.com/users/ooflorent/repos","events_url":"https://api.github.com/users/ooflorent/events{/privacy}","received_events_url":"https://api.github.com/users/ooflorent/received_events","type":"User","site_admin":false},"body":"⚠️ Best reviewed with whitespaces ignored\r\n\r\n- Rename `Parser` into `JavascriptParser`\r\n- Rename `ParserHelpers` into `JavascriptParserHelpers`\r\n- Destructure helpers for _better_ readability\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\nrefactoring\r\n\r\n**Did you add tests for your changes?**\r\n\r\nalready tested\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\nyes\r\n\r\n**What needs to be documented once your changes are merged?**\r\n\r\n`Parser` is now `JavascriptParser`.\r\n","created_at":"2018-07-03T08:28:33Z","updated_at":"2018-07-04T07:18:40Z","closed_at":"2018-07-04T07:18:40Z","merged_at":"2018-07-04T07:18:40Z","merge_commit_sha":"58889c8a34a619baa1b950442b7d93564799be7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":572712741,"node_id":"MDU6TGFiZWw1NzI3MTI3NDE=","url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20CI-ok","name":"PR: CI-ok","color":"0e8a16","default":false},{"id":689140390,"node_id":"MDU6TGFiZWw2ODkxNDAzOTA=","url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20next","name":"PR: next","color":"8b32d3","default":false},{"id":575750680,"node_id":"MDU6TGFiZWw1NzU3NTA2ODA=","url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20reviewed-approved","name":"PR: reviewed-approved","color":"0e8a16","default":false},{"id":572838417,"node_id":"MDU6TGFiZWw1NzI4Mzg0MTc=","url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20tests-needed","name":"PR: tests-needed","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack/pulls/7640/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack/pulls/7640/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/7640/comments","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/a46517f8ff4d5c925ef6672501b5a89186666825","head":{"label":"webpack:refactor/rename_parser","ref":"refactor/rename_parser","sha":"a46517f8ff4d5c925ef6672501b5a89186666825","user":{"login":"webpack","id":2105791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"node_id":"MDEwOlJlcG9zaXRvcnkzNjc4NzMx","name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack/deployments","created_at":"2012-03-10T10:08:14Z","updated_at":"2018-07-04T07:16:17Z","pushed_at":"2018-07-04T07:18:40Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"git@github.com:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"https://webpack.js.org","size":15426,"stargazers_count":42181,"watchers_count":42181,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5301,"mirror_url":null,"archived":false,"open_issues_count":468,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5301,"open_issues":468,"watchers":42181,"default_branch":"master"}},"base":{"label":"webpack:next","ref":"next","sha":"fb149f54c03074989c66fbf439172b76c8fd785f","user":{"login":"webpack","id":2105791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"node_id":"MDEwOlJlcG9zaXRvcnkzNjc4NzMx","name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack/deployments","created_at":"2012-03-10T10:08:14Z","updated_at":"2018-07-04T07:16:17Z","pushed_at":"2018-07-04T07:18:40Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"git@github.com:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"https://webpack.js.org","size":15426,"stargazers_count":42181,"watchers_count":42181,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5301,"mirror_url":null,"archived":false,"open_issues_count":468,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5301,"open_issues":468,"watchers":42181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7640"},"html":{"href":"https://github.com/webpack/webpack/pull/7640"},"issue":{"href":"https://api.github.com/repos/webpack/webpack/issues/7640"},"comments":{"href":"https://api.github.com/repos/webpack/webpack/issues/7640/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7640/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7640/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack/statuses/a46517f8ff4d5c925ef6672501b5a89186666825"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sokra","id":1365881,"node_id":"MDQ6VXNlcjEzNjU4ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/1365881?v=4","gravatar_id":"","url":"https://api.github.com/users/sokra","html_url":"https://github.com/sokra","followers_url":"https://api.github.com/users/sokra/followers","following_url":"https://api.github.com/users/sokra/following{/other_user}","gists_url":"https://api.github.com/users/sokra/gists{/gist_id}","starred_url":"https://api.github.com/users/sokra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokra/subscriptions","organizations_url":"https://api.github.com/users/sokra/orgs","repos_url":"https://api.github.com/users/sokra/repos","events_url":"https://api.github.com/users/sokra/events{/privacy}","received_events_url":"https://api.github.com/users/sokra/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":4,"additions":525,"deletions":529,"changed_files":20}}
{"actor":{"display_login":"sokra"}}