{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dub-registry/pulls/comments/176956235","pull_request_review_id":106745130,"id":176956235,"diff_hunk":"@@ -87,20 +93,40 @@ block body\n \t\t\t\t\t\t\t|= depname\n \t\t\t\t\t\t|= \"- \" ~ sp[\"description\"].opt!string\n \n-\t\thr\n-\t\t- if (readmeContents.length)\n-\t\t\t.repositoryReadme.markdown-body\n-\t\t\t\t- import vibe.textfilter.markdown : MarkdownFlags, MarkdownSettings, filterMarkdown;\n-\t\t\t\t- scope msettings = new MarkdownSettings;\n-\t\t\t\t- msettings.flags = MarkdownFlags.backtickCodeBlocks|MarkdownFlags.noInlineHtml|MarkdownFlags.tables;\n-\t\t\t\t- msettings.headingBaseLevel = 2;\n-\t\t\t\t- msettings.urlFilter = &urlFilter;\n-\t\t\t\t!= filterMarkdown(readmeContents, msettings)\n+\t\t.subtabsHeader\n+\t\t\t- if (readmeContents.length)\n+\t\t\t\ta.tab(class=activeTab == \"info\" ? \"active\" : \"\", href=\"#{req.rootDir}packages/#{normalizedPackageName}?tab=info\") Info\n+\t\t\t- foreach (i, sample; sampleURLs)\n+\t\t\t\ta.tab(class=activeTab == \"sample_\"~i.to!string ? \"active\" : \"\", href=\"#{req.rootDir}packages/#{normalizedPackageName}?tab=sample_#{i}\")= sample\n+\t\t\ta.tab.external(href=\"http://#{normalizedPackageName}.dpldocs.info/\") Documentation\n+\t\t- bool renderedTabContent;\n+\t\t- if (activeTab == \"info\")\n+\t\t\t- if (readmeContents.length)\n+\t\t\t\t.repositoryReadme.markdown-body\n+\t\t\t\t\t- import vibe.textfilter.markdown : MarkdownFlags, MarkdownSettings, filterMarkdown;\n+\t\t\t\t\t- scope msettings = new MarkdownSettings;\n+\t\t\t\t\t- msettings.flags = MarkdownFlags.backtickCodeBlocks|MarkdownFlags.noInlineHtml|MarkdownFlags.tables;\n+\t\t\t\t\t- msettings.headingBaseLevel = 2;\n+\t\t\t\t\t- msettings.urlFilter = &urlFilter;\n+\t\t\t\t\t!= filterMarkdown(readmeContents, msettings)\n+\t\t\t- else\n+\t\t\t\t.repositoryReadme\n+\t\t\t- renderedTabContent = true;","path":"views/view_package.dt","position":87,"original_position":87,"commit_id":"b13b1137a402d9feac274aa6112d90e9d7596d4e","original_commit_id":"b13b1137a402d9feac274aa6112d90e9d7596d4e","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"Another tab we could add would be stats e.g. like this:\r\nhttps://github.com/dlang/dub-registry/issues/160","created_at":"2018-03-25T22:09:00Z","updated_at":"2018-03-25T22:09:17Z","html_url":"https://github.com/dlang/dub-registry/pull/302#discussion_r176956235","pull_request_url":"https://api.github.com/repos/dlang/dub-registry/pulls/302","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dlang/dub-registry/pulls/comments/176956235"},"html":{"href":"https://github.com/dlang/dub-registry/pull/302#discussion_r176956235"},"pull_request":{"href":"https://api.github.com/repos/dlang/dub-registry/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/dub-registry/pulls/302","id":177313334,"html_url":"https://github.com/dlang/dub-registry/pull/302","diff_url":"https://github.com/dlang/dub-registry/pull/302.diff","patch_url":"https://github.com/dlang/dub-registry/pull/302.patch","issue_url":"https://api.github.com/repos/dlang/dub-registry/issues/302","number":302,"state":"open","locked":false,"title":"package subtabs + doc link + more spacing + better readme","user":{"login":"WebFreak001","id":2035977,"avatar_url":"https://avatars0.githubusercontent.com/u/2035977?v=4","gravatar_id":"","url":"https://api.github.com/users/WebFreak001","html_url":"https://github.com/WebFreak001","followers_url":"https://api.github.com/users/WebFreak001/followers","following_url":"https://api.github.com/users/WebFreak001/following{/other_user}","gists_url":"https://api.github.com/users/WebFreak001/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFreak001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFreak001/subscriptions","organizations_url":"https://api.github.com/users/WebFreak001/orgs","repos_url":"https://api.github.com/users/WebFreak001/repos","events_url":"https://api.github.com/users/WebFreak001/events{/privacy}","received_events_url":"https://api.github.com/users/WebFreak001/received_events","type":"User","site_admin":false},"body":"readme is now detected from repo content instead of hardcoding README.md\r\nbitbucket api only tested using external debugging of http calls\r\ngitlab not tested at all due to missing api keys\r\ngithub works fine\r\nexternal documentation link to dpldocs.info (asked @adamdruppe for this)\r\nplanning support for sample file detection here (using repo content)\r\n\r\npart of #265, rewritten and optimized a bit\r\n\r\n![showing dub registry page in large](https://wfr.moe/fFK2X8.png)\r\n\r\n---\r\n\r\n![showing dub registry page in small](https://wfr.moe/fFKT10.png)\r\n\r\n---\r\n\r\n![showing dub registry page on mobile](https://wfr.moe/fFMyYs.png)","created_at":"2018-03-25T21:45:56Z","updated_at":"2018-03-25T22:09:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e3f6c3eb67ea3f3044546429f297395e34448e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dub-registry/pulls/302/commits","review_comments_url":"https://api.github.com/repos/dlang/dub-registry/pulls/302/comments","review_comment_url":"https://api.github.com/repos/dlang/dub-registry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dub-registry/issues/302/comments","statuses_url":"https://api.github.com/repos/dlang/dub-registry/statuses/b13b1137a402d9feac274aa6112d90e9d7596d4e","head":{"label":"WebFreak001:package-view-rework","ref":"package-view-rework","sha":"b13b1137a402d9feac274aa6112d90e9d7596d4e","user":{"login":"WebFreak001","id":2035977,"avatar_url":"https://avatars0.githubusercontent.com/u/2035977?v=4","gravatar_id":"","url":"https://api.github.com/users/WebFreak001","html_url":"https://github.com/WebFreak001","followers_url":"https://api.github.com/users/WebFreak001/followers","following_url":"https://api.github.com/users/WebFreak001/following{/other_user}","gists_url":"https://api.github.com/users/WebFreak001/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFreak001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFreak001/subscriptions","organizations_url":"https://api.github.com/users/WebFreak001/orgs","repos_url":"https://api.github.com/users/WebFreak001/repos","events_url":"https://api.github.com/users/WebFreak001/events{/privacy}","received_events_url":"https://api.github.com/users/WebFreak001/received_events","type":"User","site_admin":false},"repo":{"id":114040061,"name":"dub-registry","full_name":"WebFreak001/dub-registry","owner":{"login":"WebFreak001","id":2035977,"avatar_url":"https://avatars0.githubusercontent.com/u/2035977?v=4","gravatar_id":"","url":"https://api.github.com/users/WebFreak001","html_url":"https://github.com/WebFreak001","followers_url":"https://api.github.com/users/WebFreak001/followers","following_url":"https://api.github.com/users/WebFreak001/following{/other_user}","gists_url":"https://api.github.com/users/WebFreak001/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFreak001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFreak001/subscriptions","organizations_url":"https://api.github.com/users/WebFreak001/orgs","repos_url":"https://api.github.com/users/WebFreak001/repos","events_url":"https://api.github.com/users/WebFreak001/events{/privacy}","received_events_url":"https://api.github.com/users/WebFreak001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WebFreak001/dub-registry","description":"Online registry for dub packages","fork":true,"url":"https://api.github.com/repos/WebFreak001/dub-registry","forks_url":"https://api.github.com/repos/WebFreak001/dub-registry/forks","keys_url":"https://api.github.com/repos/WebFreak001/dub-registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebFreak001/dub-registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebFreak001/dub-registry/teams","hooks_url":"https://api.github.com/repos/WebFreak001/dub-registry/hooks","issue_events_url":"https://api.github.com/repos/WebFreak001/dub-registry/issues/events{/number}","events_url":"https://api.github.com/repos/WebFreak001/dub-registry/events","assignees_url":"https://api.github.com/repos/WebFreak001/dub-registry/assignees{/user}","branches_url":"https://api.github.com/repos/WebFreak001/dub-registry/branches{/branch}","tags_url":"https://api.github.com/repos/WebFreak001/dub-registry/tags","blobs_url":"https://api.github.com/repos/WebFreak001/dub-registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebFreak001/dub-registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebFreak001/dub-registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebFreak001/dub-registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebFreak001/dub-registry/statuses/{sha}","languages_url":"https://api.github.com/repos/WebFreak001/dub-registry/languages","stargazers_url":"https://api.github.com/repos/WebFreak001/dub-registry/stargazers","contributors_url":"https://api.github.com/repos/WebFreak001/dub-registry/contributors","subscribers_url":"https://api.github.com/repos/WebFreak001/dub-registry/subscribers","subscription_url":"https://api.github.com/repos/WebFreak001/dub-registry/subscription","commits_url":"https://api.github.com/repos/WebFreak001/dub-registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebFreak001/dub-registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebFreak001/dub-registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebFreak001/dub-registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebFreak001/dub-registry/contents/{+path}","compare_url":"https://api.github.com/repos/WebFreak001/dub-registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebFreak001/dub-registry/merges","archive_url":"https://api.github.com/repos/WebFreak001/dub-registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebFreak001/dub-registry/downloads","issues_url":"https://api.github.com/repos/WebFreak001/dub-registry/issues{/number}","pulls_url":"https://api.github.com/repos/WebFreak001/dub-registry/pulls{/number}","milestones_url":"https://api.github.com/repos/WebFreak001/dub-registry/milestones{/number}","notifications_url":"https://api.github.com/repos/WebFreak001/dub-registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebFreak001/dub-registry/labels{/name}","releases_url":"https://api.github.com/repos/WebFreak001/dub-registry/releases{/id}","deployments_url":"https://api.github.com/repos/WebFreak001/dub-registry/deployments","created_at":"2017-12-12T21:17:00Z","updated_at":"2018-03-23T19:04:08Z","pushed_at":"2018-03-25T21:43:01Z","git_url":"git://github.com/WebFreak001/dub-registry.git","ssh_url":"git@github.com:WebFreak001/dub-registry.git","clone_url":"https://github.com/WebFreak001/dub-registry.git","svn_url":"https://github.com/WebFreak001/dub-registry","homepage":null,"size":1216,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"6d0cb3b80b289eb42e2a1632267badfd34a7f867","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":6470690,"name":"dub-registry","full_name":"dlang/dub-registry","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dub-registry","description":"Online registry for dub packages","fork":false,"url":"https://api.github.com/repos/dlang/dub-registry","forks_url":"https://api.github.com/repos/dlang/dub-registry/forks","keys_url":"https://api.github.com/repos/dlang/dub-registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dub-registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dub-registry/teams","hooks_url":"https://api.github.com/repos/dlang/dub-registry/hooks","issue_events_url":"https://api.github.com/repos/dlang/dub-registry/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dub-registry/events","assignees_url":"https://api.github.com/repos/dlang/dub-registry/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dub-registry/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dub-registry/tags","blobs_url":"https://api.github.com/repos/dlang/dub-registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dub-registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dub-registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dub-registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dub-registry/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dub-registry/languages","stargazers_url":"https://api.github.com/repos/dlang/dub-registry/stargazers","contributors_url":"https://api.github.com/repos/dlang/dub-registry/contributors","subscribers_url":"https://api.github.com/repos/dlang/dub-registry/subscribers","subscription_url":"https://api.github.com/repos/dlang/dub-registry/subscription","commits_url":"https://api.github.com/repos/dlang/dub-registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dub-registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dub-registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dub-registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dub-registry/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dub-registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dub-registry/merges","archive_url":"https://api.github.com/repos/dlang/dub-registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dub-registry/downloads","issues_url":"https://api.github.com/repos/dlang/dub-registry/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dub-registry/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dub-registry/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dub-registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dub-registry/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dub-registry/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dub-registry/deployments","created_at":"2012-10-31T08:14:47Z","updated_at":"2018-03-24T18:06:57Z","pushed_at":"2018-03-25T21:45:57Z","git_url":"git://github.com/dlang/dub-registry.git","ssh_url":"git@github.com:dlang/dub-registry.git","clone_url":"https://github.com/dlang/dub-registry.git","svn_url":"https://github.com/dlang/dub-registry","homepage":null,"size":1175,"stargazers_count":43,"watchers_count":43,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":44,"open_issues":75,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dub-registry/pulls/302"},"html":{"href":"https://github.com/dlang/dub-registry/pull/302"},"issue":{"href":"https://api.github.com/repos/dlang/dub-registry/issues/302"},"comments":{"href":"https://api.github.com/repos/dlang/dub-registry/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dub-registry/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dub-registry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dub-registry/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dub-registry/statuses/b13b1137a402d9feac274aa6112d90e9d7596d4e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wilzbach"}}