{"action":"created","issue":{"url":"https://api.github.com/repos/librosa/librosa/issues/737","repository_url":"https://api.github.com/repos/librosa/librosa","labels_url":"https://api.github.com/repos/librosa/librosa/issues/737/labels{/name}","comments_url":"https://api.github.com/repos/librosa/librosa/issues/737/comments","events_url":"https://api.github.com/repos/librosa/librosa/issues/737/events","html_url":"https://github.com/librosa/librosa/issues/737","id":336475922,"node_id":"MDU6SXNzdWUzMzY0NzU5MjI=","number":737,"title":"Display axis decorators: seconds, ms","user":{"login":"bmcfee","id":1190540,"node_id":"MDQ6VXNlcjExOTA1NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1190540?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcfee","html_url":"https://github.com/bmcfee","followers_url":"https://api.github.com/users/bmcfee/followers","following_url":"https://api.github.com/users/bmcfee/following{/other_user}","gists_url":"https://api.github.com/users/bmcfee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfee/subscriptions","organizations_url":"https://api.github.com/users/bmcfee/orgs","repos_url":"https://api.github.com/users/bmcfee/repos","events_url":"https://api.github.com/users/bmcfee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfee/received_events","type":"User","site_admin":false},"labels":[{"id":247500515,"node_id":"MDU6TGFiZWwyNDc1MDA1MTU=","url":"https://api.github.com/repos/librosa/librosa/labels/API%20change","name":"API change","color":"0052cc","default":false},{"id":16995036,"node_id":"MDU6TGFiZWwxNjk5NTAzNg==","url":"https://api.github.com/repos/librosa/librosa/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":101594894,"node_id":"MDU6TGFiZWwxMDE1OTQ4OTQ=","url":"https://api.github.com/repos/librosa/librosa/labels/functionality","name":"functionality","color":"fbca04","default":false},{"id":226642895,"node_id":"MDU6TGFiZWwyMjY2NDI4OTU=","url":"https://api.github.com/repos/librosa/librosa/labels/good%20for%20beginners","name":"good for beginners","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/librosa/librosa/milestones/17","html_url":"https://github.com/librosa/librosa/milestone/17","labels_url":"https://api.github.com/repos/librosa/librosa/milestones/17/labels","id":3544565,"node_id":"MDk6TWlsZXN0b25lMzU0NDU2NQ==","number":17,"title":"0.6.3","description":null,"creator":{"login":"bmcfee","id":1190540,"node_id":"MDQ6VXNlcjExOTA1NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1190540?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcfee","html_url":"https://github.com/bmcfee","followers_url":"https://api.github.com/users/bmcfee/followers","following_url":"https://api.github.com/users/bmcfee/following{/other_user}","gists_url":"https://api.github.com/users/bmcfee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfee/subscriptions","organizations_url":"https://api.github.com/users/bmcfee/orgs","repos_url":"https://api.github.com/users/bmcfee/repos","events_url":"https://api.github.com/users/bmcfee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfee/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2018-08-03T13:21:19Z","updated_at":"2018-08-07T14:07:27Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2018-06-28T05:18:02Z","updated_at":"2018-08-11T14:49:05Z","closed_at":null,"author_association":"MEMBER","body":"#### Description\r\n\r\nWe currently support two temporal decoration modes: `time` and `lag`.  These modes use seconds as the underlying data representation, and the `TimeFormatter` object adaptively scales the units to an appropriate resolution given the display range.\r\n\r\nIt would be good to be able to override this, and display in fixed units.  This could be easily done by adding a couple of new modes:\r\n\r\n- `seconds`: always use seconds\r\n- `ms`: always use milliseconds\r\n- `lag_seconds`: always use seconds (including negative for lag)\r\n- `lag_ms`: as above, but for milliseconds.\r\n\r\nImplementing this is simply a matter of adding some control logic to the `TimeFormatter`, and adjusting the automatic axis labels to `Time (s)` or `Time (ms)` accordingly."},"comment":{"url":"https://api.github.com/repos/librosa/librosa/issues/comments/412279887","html_url":"https://github.com/librosa/librosa/issues/737#issuecomment-412279887","issue_url":"https://api.github.com/repos/librosa/librosa/issues/737","id":412279887,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjI3OTg4Nw==","user":{"login":"kyungyunlee","id":19829532,"node_id":"MDQ6VXNlcjE5ODI5NTMy","avatar_url":"https://avatars2.githubusercontent.com/u/19829532?v=4","gravatar_id":"","url":"https://api.github.com/users/kyungyunlee","html_url":"https://github.com/kyungyunlee","followers_url":"https://api.github.com/users/kyungyunlee/followers","following_url":"https://api.github.com/users/kyungyunlee/following{/other_user}","gists_url":"https://api.github.com/users/kyungyunlee/gists{/gist_id}","starred_url":"https://api.github.com/users/kyungyunlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyungyunlee/subscriptions","organizations_url":"https://api.github.com/users/kyungyunlee/orgs","repos_url":"https://api.github.com/users/kyungyunlee/repos","events_url":"https://api.github.com/users/kyungyunlee/events{/privacy}","received_events_url":"https://api.github.com/users/kyungyunlee/received_events","type":"User","site_admin":false},"created_at":"2018-08-11T14:49:05Z","updated_at":"2018-08-11T14:49:05Z","author_association":"NONE","body":"Yeah I agree, it's true that plotting such a few samples is not common. \r\nAnd I might take my word back....just keeping the minimum unit to `s`, not `ms` as I suggested, seems to be better for now, because `TimeFormatter` class is used in `specshow` and `waveplot` as well. \r\nI tried using `ms` for plotting under 1 second spectrogram (shown below),  but it looks like keeping `s` is better here. \r\n\r\n![image](https://user-images.githubusercontent.com/19829532/43992782-66388a7c-9dbe-11e8-9d9e-6c8240aaee94.png)\r\n\r\n![image](https://user-images.githubusercontent.com/19829532/43992788-8352cd84-9dbe-11e8-81f4-ddce57b4a0b4.png)\r\n\r\nI agree that sticking to seconds as much as possible and keeping things not too complicated is the way to go. \r\n\r\nWhen the referenced \"sample plotting\" function is implemented, we can consider adding `ms` as the minimum unit only for that sample plotting function but probably not `specshow`. \r\n\r\nBeside this problem, I think most things are clear. Any other thoughts?  :) \r\n"}}
{"actor":{"display_login":"kyungyunlee"}}