{"action":"created","comment":{"url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/comments/216224939","pull_request_review_id":153656059,"id":216224939,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjIyNDkzOQ==","diff_hunk":"@@ -92,14 +92,9 @@ def create_lane(map, id):\n \n \n fpath = sys.argv[1]\n-f = open(fpath, 'r')\n-points = []\n-for line in f:\n-    line = line.replace(\"\\n\", '')\n-    data = line.split(',')\n-    x = float(data[0])\n-    y = float(data[1])\n-    points.append((x, y))\n+with open(fpath, 'r') as f:","path":"modules/tools/map_gen/map_gen.py","position":12,"original_position":12,"commit_id":"d9c92c00033e184edce54b24eabc9aa87faef318","original_commit_id":"83bd04e03cb3ddb625cb8f6570fa34b546df4fe6","user":{"login":"lianglia-apollo","id":29311964,"node_id":"MDQ6VXNlcjI5MzExOTY0","avatar_url":"https://avatars2.githubusercontent.com/u/29311964?v=4","gravatar_id":"","url":"https://api.github.com/users/lianglia-apollo","html_url":"https://github.com/lianglia-apollo","followers_url":"https://api.github.com/users/lianglia-apollo/followers","following_url":"https://api.github.com/users/lianglia-apollo/following{/other_user}","gists_url":"https://api.github.com/users/lianglia-apollo/gists{/gist_id}","starred_url":"https://api.github.com/users/lianglia-apollo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lianglia-apollo/subscriptions","organizations_url":"https://api.github.com/users/lianglia-apollo/orgs","repos_url":"https://api.github.com/users/lianglia-apollo/repos","events_url":"https://api.github.com/users/lianglia-apollo/events{/privacy}","received_events_url":"https://api.github.com/users/lianglia-apollo/received_events","type":"User","site_admin":false},"body":"Thanks!","created_at":"2018-09-10T07:45:48Z","updated_at":"2018-09-10T07:45:48Z","html_url":"https://github.com/ApolloAuto/apollo/pull/5722#discussion_r216224939","pull_request_url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/5722","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/comments/216224939"},"html":{"href":"https://github.com/ApolloAuto/apollo/pull/5722#discussion_r216224939"},"pull_request":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/5722"}},"in_reply_to_id":216217381},"pull_request":{"url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/5722","id":214215634,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MjE1NjM0","html_url":"https://github.com/ApolloAuto/apollo/pull/5722","diff_url":"https://github.com/ApolloAuto/apollo/pull/5722.diff","patch_url":"https://github.com/ApolloAuto/apollo/pull/5722.patch","issue_url":"https://api.github.com/repos/ApolloAuto/apollo/issues/5722","number":5722,"state":"open","locked":false,"title":"Tools/map_gen: Use list comprehension to replace multi line for loop.","user":{"login":"redfuture","id":1274542,"node_id":"MDQ6VXNlcjEyNzQ1NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1274542?v=4","gravatar_id":"","url":"https://api.github.com/users/redfuture","html_url":"https://github.com/redfuture","followers_url":"https://api.github.com/users/redfuture/followers","following_url":"https://api.github.com/users/redfuture/following{/other_user}","gists_url":"https://api.github.com/users/redfuture/gists{/gist_id}","starred_url":"https://api.github.com/users/redfuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redfuture/subscriptions","organizations_url":"https://api.github.com/users/redfuture/orgs","repos_url":"https://api.github.com/users/redfuture/repos","events_url":"https://api.github.com/users/redfuture/events{/privacy}","received_events_url":"https://api.github.com/users/redfuture/received_events","type":"User","site_admin":false},"body":"In the old code it's missing f.close when using open.This patch use\r\nwith statement when open file.","created_at":"2018-09-10T07:01:49Z","updated_at":"2018-09-10T07:45:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cd050d075286afd29b061be51bfa4e8d627aca1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/5722/commits","review_comments_url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/5722/comments","review_comment_url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ApolloAuto/apollo/issues/5722/comments","statuses_url":"https://api.github.com/repos/ApolloAuto/apollo/statuses/d9c92c00033e184edce54b24eabc9aa87faef318","head":{"label":"redfuture:master-dev5","ref":"master-dev5","sha":"d9c92c00033e184edce54b24eabc9aa87faef318","user":{"login":"redfuture","id":1274542,"node_id":"MDQ6VXNlcjEyNzQ1NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1274542?v=4","gravatar_id":"","url":"https://api.github.com/users/redfuture","html_url":"https://github.com/redfuture","followers_url":"https://api.github.com/users/redfuture/followers","following_url":"https://api.github.com/users/redfuture/following{/other_user}","gists_url":"https://api.github.com/users/redfuture/gists{/gist_id}","starred_url":"https://api.github.com/users/redfuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redfuture/subscriptions","organizations_url":"https://api.github.com/users/redfuture/orgs","repos_url":"https://api.github.com/users/redfuture/repos","events_url":"https://api.github.com/users/redfuture/events{/privacy}","received_events_url":"https://api.github.com/users/redfuture/received_events","type":"User","site_admin":false},"repo":{"id":146281643,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYyODE2NDM=","name":"apollo","full_name":"redfuture/apollo","owner":{"login":"redfuture","id":1274542,"node_id":"MDQ6VXNlcjEyNzQ1NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1274542?v=4","gravatar_id":"","url":"https://api.github.com/users/redfuture","html_url":"https://github.com/redfuture","followers_url":"https://api.github.com/users/redfuture/followers","following_url":"https://api.github.com/users/redfuture/following{/other_user}","gists_url":"https://api.github.com/users/redfuture/gists{/gist_id}","starred_url":"https://api.github.com/users/redfuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redfuture/subscriptions","organizations_url":"https://api.github.com/users/redfuture/orgs","repos_url":"https://api.github.com/users/redfuture/repos","events_url":"https://api.github.com/users/redfuture/events{/privacy}","received_events_url":"https://api.github.com/users/redfuture/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/redfuture/apollo","description":"An open autonomous driving platform","fork":true,"url":"https://api.github.com/repos/redfuture/apollo","forks_url":"https://api.github.com/repos/redfuture/apollo/forks","keys_url":"https://api.github.com/repos/redfuture/apollo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redfuture/apollo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redfuture/apollo/teams","hooks_url":"https://api.github.com/repos/redfuture/apollo/hooks","issue_events_url":"https://api.github.com/repos/redfuture/apollo/issues/events{/number}","events_url":"https://api.github.com/repos/redfuture/apollo/events","assignees_url":"https://api.github.com/repos/redfuture/apollo/assignees{/user}","branches_url":"https://api.github.com/repos/redfuture/apollo/branches{/branch}","tags_url":"https://api.github.com/repos/redfuture/apollo/tags","blobs_url":"https://api.github.com/repos/redfuture/apollo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redfuture/apollo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redfuture/apollo/git/refs{/sha}","trees_url":"https://api.github.com/repos/redfuture/apollo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redfuture/apollo/statuses/{sha}","languages_url":"https://api.github.com/repos/redfuture/apollo/languages","stargazers_url":"https://api.github.com/repos/redfuture/apollo/stargazers","contributors_url":"https://api.github.com/repos/redfuture/apollo/contributors","subscribers_url":"https://api.github.com/repos/redfuture/apollo/subscribers","subscription_url":"https://api.github.com/repos/redfuture/apollo/subscription","commits_url":"https://api.github.com/repos/redfuture/apollo/commits{/sha}","git_commits_url":"https://api.github.com/repos/redfuture/apollo/git/commits{/sha}","comments_url":"https://api.github.com/repos/redfuture/apollo/comments{/number}","issue_comment_url":"https://api.github.com/repos/redfuture/apollo/issues/comments{/number}","contents_url":"https://api.github.com/repos/redfuture/apollo/contents/{+path}","compare_url":"https://api.github.com/repos/redfuture/apollo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redfuture/apollo/merges","archive_url":"https://api.github.com/repos/redfuture/apollo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redfuture/apollo/downloads","issues_url":"https://api.github.com/repos/redfuture/apollo/issues{/number}","pulls_url":"https://api.github.com/repos/redfuture/apollo/pulls{/number}","milestones_url":"https://api.github.com/repos/redfuture/apollo/milestones{/number}","notifications_url":"https://api.github.com/repos/redfuture/apollo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redfuture/apollo/labels{/name}","releases_url":"https://api.github.com/repos/redfuture/apollo/releases{/id}","deployments_url":"https://api.github.com/repos/redfuture/apollo/deployments","created_at":"2018-08-27T10:18:44Z","updated_at":"2018-09-07T07:26:42Z","pushed_at":"2018-09-10T07:42:47Z","git_url":"git://github.com/redfuture/apollo.git","ssh_url":"git@github.com:redfuture/apollo.git","clone_url":"https://github.com/redfuture/apollo.git","svn_url":"https://github.com/redfuture/apollo","homepage":null,"size":448488,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ApolloAuto:master","ref":"master","sha":"d839276aa61cb7b0d71745ef955feef809a099cf","user":{"login":"ApolloAuto","id":28768304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzY4MzA0","avatar_url":"https://avatars1.githubusercontent.com/u/28768304?v=4","gravatar_id":"","url":"https://api.github.com/users/ApolloAuto","html_url":"https://github.com/ApolloAuto","followers_url":"https://api.github.com/users/ApolloAuto/followers","following_url":"https://api.github.com/users/ApolloAuto/following{/other_user}","gists_url":"https://api.github.com/users/ApolloAuto/gists{/gist_id}","starred_url":"https://api.github.com/users/ApolloAuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApolloAuto/subscriptions","organizations_url":"https://api.github.com/users/ApolloAuto/orgs","repos_url":"https://api.github.com/users/ApolloAuto/repos","events_url":"https://api.github.com/users/ApolloAuto/events{/privacy}","received_events_url":"https://api.github.com/users/ApolloAuto/received_events","type":"Organization","site_admin":false},"repo":{"id":96246170,"node_id":"MDEwOlJlcG9zaXRvcnk5NjI0NjE3MA==","name":"apollo","full_name":"ApolloAuto/apollo","owner":{"login":"ApolloAuto","id":28768304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzY4MzA0","avatar_url":"https://avatars1.githubusercontent.com/u/28768304?v=4","gravatar_id":"","url":"https://api.github.com/users/ApolloAuto","html_url":"https://github.com/ApolloAuto","followers_url":"https://api.github.com/users/ApolloAuto/followers","following_url":"https://api.github.com/users/ApolloAuto/following{/other_user}","gists_url":"https://api.github.com/users/ApolloAuto/gists{/gist_id}","starred_url":"https://api.github.com/users/ApolloAuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApolloAuto/subscriptions","organizations_url":"https://api.github.com/users/ApolloAuto/orgs","repos_url":"https://api.github.com/users/ApolloAuto/repos","events_url":"https://api.github.com/users/ApolloAuto/events{/privacy}","received_events_url":"https://api.github.com/users/ApolloAuto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ApolloAuto/apollo","description":"An open autonomous driving platform","fork":false,"url":"https://api.github.com/repos/ApolloAuto/apollo","forks_url":"https://api.github.com/repos/ApolloAuto/apollo/forks","keys_url":"https://api.github.com/repos/ApolloAuto/apollo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ApolloAuto/apollo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ApolloAuto/apollo/teams","hooks_url":"https://api.github.com/repos/ApolloAuto/apollo/hooks","issue_events_url":"https://api.github.com/repos/ApolloAuto/apollo/issues/events{/number}","events_url":"https://api.github.com/repos/ApolloAuto/apollo/events","assignees_url":"https://api.github.com/repos/ApolloAuto/apollo/assignees{/user}","branches_url":"https://api.github.com/repos/ApolloAuto/apollo/branches{/branch}","tags_url":"https://api.github.com/repos/ApolloAuto/apollo/tags","blobs_url":"https://api.github.com/repos/ApolloAuto/apollo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ApolloAuto/apollo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ApolloAuto/apollo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ApolloAuto/apollo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ApolloAuto/apollo/statuses/{sha}","languages_url":"https://api.github.com/repos/ApolloAuto/apollo/languages","stargazers_url":"https://api.github.com/repos/ApolloAuto/apollo/stargazers","contributors_url":"https://api.github.com/repos/ApolloAuto/apollo/contributors","subscribers_url":"https://api.github.com/repos/ApolloAuto/apollo/subscribers","subscription_url":"https://api.github.com/repos/ApolloAuto/apollo/subscription","commits_url":"https://api.github.com/repos/ApolloAuto/apollo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ApolloAuto/apollo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ApolloAuto/apollo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ApolloAuto/apollo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ApolloAuto/apollo/contents/{+path}","compare_url":"https://api.github.com/repos/ApolloAuto/apollo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ApolloAuto/apollo/merges","archive_url":"https://api.github.com/repos/ApolloAuto/apollo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ApolloAuto/apollo/downloads","issues_url":"https://api.github.com/repos/ApolloAuto/apollo/issues{/number}","pulls_url":"https://api.github.com/repos/ApolloAuto/apollo/pulls{/number}","milestones_url":"https://api.github.com/repos/ApolloAuto/apollo/milestones{/number}","notifications_url":"https://api.github.com/repos/ApolloAuto/apollo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ApolloAuto/apollo/labels{/name}","releases_url":"https://api.github.com/repos/ApolloAuto/apollo/releases{/id}","deployments_url":"https://api.github.com/repos/ApolloAuto/apollo/deployments","created_at":"2017-07-04T19:03:31Z","updated_at":"2018-09-10T06:55:00Z","pushed_at":"2018-09-10T07:43:31Z","git_url":"git://github.com/ApolloAuto/apollo.git","ssh_url":"git@github.com:ApolloAuto/apollo.git","clone_url":"https://github.com/ApolloAuto/apollo.git","svn_url":"https://github.com/ApolloAuto/apollo","homepage":null,"size":449010,"stargazers_count":10910,"watchers_count":10910,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2964,"mirror_url":null,"archived":false,"open_issues_count":249,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2964,"open_issues":249,"watchers":10910,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/5722"},"html":{"href":"https://github.com/ApolloAuto/apollo/pull/5722"},"issue":{"href":"https://api.github.com/repos/ApolloAuto/apollo/issues/5722"},"comments":{"href":"https://api.github.com/repos/ApolloAuto/apollo/issues/5722/comments"},"review_comments":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/5722/comments"},"review_comment":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/5722/commits"},"statuses":{"href":"https://api.github.com/repos/ApolloAuto/apollo/statuses/d9c92c00033e184edce54b24eabc9aa87faef318"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lianglia-apollo"}}