{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/pepabo/go-netapp/pulls/17","id":217532788,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTMyNzg4","html_url":"https://github.com/pepabo/go-netapp/pull/17","diff_url":"https://github.com/pepabo/go-netapp/pull/17.diff","patch_url":"https://github.com/pepabo/go-netapp/pull/17.patch","issue_url":"https://api.github.com/repos/pepabo/go-netapp/issues/17","number":17,"state":"closed","locked":false,"title":"Add Qos Policy tests","user":{"login":"smazurov","id":21636,"node_id":"MDQ6VXNlcjIxNjM2","avatar_url":"https://avatars2.githubusercontent.com/u/21636?v=4","gravatar_id":"","url":"https://api.github.com/users/smazurov","html_url":"https://github.com/smazurov","followers_url":"https://api.github.com/users/smazurov/followers","following_url":"https://api.github.com/users/smazurov/following{/other_user}","gists_url":"https://api.github.com/users/smazurov/gists{/gist_id}","starred_url":"https://api.github.com/users/smazurov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smazurov/subscriptions","organizations_url":"https://api.github.com/users/smazurov/orgs","repos_url":"https://api.github.com/users/smazurov/repos","events_url":"https://api.github.com/users/smazurov/events{/privacy}","received_events_url":"https://api.github.com/users/smazurov/received_events","type":"User","site_admin":false},"body":"Added some http req mocking so we can be sure marshaling/unmarshalling works correctly. I added a travis file as well, but its up to you guys to modify it to do what you want it to do.\r\n\r\nAlso:\r\n\r\n- reordered methods to better fit CRUD in `qos-policy`\r\n- made all `VolumeSpaceAtrributes` fields `omitempty`\r\n- added some early http error transformation\r\n- added editorconfig file for xml files.\r\n\r\nNote: im using a [diff library](https://github.com/andreyvit/diff) to better show xml file differences, so in order to run tests you need to do `go get -t ./netapp`","created_at":"2018-09-23T21:40:05Z","updated_at":"2018-09-23T21:41:59Z","closed_at":"2018-09-23T21:41:59Z","merged_at":null,"merge_commit_sha":"db7e5450d247267140839479be833533402eed5d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pepabo/go-netapp/pulls/17/commits","review_comments_url":"https://api.github.com/repos/pepabo/go-netapp/pulls/17/comments","review_comment_url":"https://api.github.com/repos/pepabo/go-netapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pepabo/go-netapp/issues/17/comments","statuses_url":"https://api.github.com/repos/pepabo/go-netapp/statuses/0fca7cfbb1d7676f1272cd052b01e73d261948a7","head":{"label":"factioninc:add-tests","ref":"add-tests","sha":"0fca7cfbb1d7676f1272cd052b01e73d261948a7","user":{"login":"factioninc","id":29551615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTUxNjE1","avatar_url":"https://avatars0.githubusercontent.com/u/29551615?v=4","gravatar_id":"","url":"https://api.github.com/users/factioninc","html_url":"https://github.com/factioninc","followers_url":"https://api.github.com/users/factioninc/followers","following_url":"https://api.github.com/users/factioninc/following{/other_user}","gists_url":"https://api.github.com/users/factioninc/gists{/gist_id}","starred_url":"https://api.github.com/users/factioninc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/factioninc/subscriptions","organizations_url":"https://api.github.com/users/factioninc/orgs","repos_url":"https://api.github.com/users/factioninc/repos","events_url":"https://api.github.com/users/factioninc/events{/privacy}","received_events_url":"https://api.github.com/users/factioninc/received_events","type":"Organization","site_admin":false},"repo":{"id":148542157,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1NDIxNTc=","name":"go-netapp","full_name":"factioninc/go-netapp","private":false,"owner":{"login":"factioninc","id":29551615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTUxNjE1","avatar_url":"https://avatars0.githubusercontent.com/u/29551615?v=4","gravatar_id":"","url":"https://api.github.com/users/factioninc","html_url":"https://github.com/factioninc","followers_url":"https://api.github.com/users/factioninc/followers","following_url":"https://api.github.com/users/factioninc/following{/other_user}","gists_url":"https://api.github.com/users/factioninc/gists{/gist_id}","starred_url":"https://api.github.com/users/factioninc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/factioninc/subscriptions","organizations_url":"https://api.github.com/users/factioninc/orgs","repos_url":"https://api.github.com/users/factioninc/repos","events_url":"https://api.github.com/users/factioninc/events{/privacy}","received_events_url":"https://api.github.com/users/factioninc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/factioninc/go-netapp","description":"golang's netapp client","fork":true,"url":"https://api.github.com/repos/factioninc/go-netapp","forks_url":"https://api.github.com/repos/factioninc/go-netapp/forks","keys_url":"https://api.github.com/repos/factioninc/go-netapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/factioninc/go-netapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/factioninc/go-netapp/teams","hooks_url":"https://api.github.com/repos/factioninc/go-netapp/hooks","issue_events_url":"https://api.github.com/repos/factioninc/go-netapp/issues/events{/number}","events_url":"https://api.github.com/repos/factioninc/go-netapp/events","assignees_url":"https://api.github.com/repos/factioninc/go-netapp/assignees{/user}","branches_url":"https://api.github.com/repos/factioninc/go-netapp/branches{/branch}","tags_url":"https://api.github.com/repos/factioninc/go-netapp/tags","blobs_url":"https://api.github.com/repos/factioninc/go-netapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/factioninc/go-netapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/factioninc/go-netapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/factioninc/go-netapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/factioninc/go-netapp/statuses/{sha}","languages_url":"https://api.github.com/repos/factioninc/go-netapp/languages","stargazers_url":"https://api.github.com/repos/factioninc/go-netapp/stargazers","contributors_url":"https://api.github.com/repos/factioninc/go-netapp/contributors","subscribers_url":"https://api.github.com/repos/factioninc/go-netapp/subscribers","subscription_url":"https://api.github.com/repos/factioninc/go-netapp/subscription","commits_url":"https://api.github.com/repos/factioninc/go-netapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/factioninc/go-netapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/factioninc/go-netapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/factioninc/go-netapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/factioninc/go-netapp/contents/{+path}","compare_url":"https://api.github.com/repos/factioninc/go-netapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/factioninc/go-netapp/merges","archive_url":"https://api.github.com/repos/factioninc/go-netapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/factioninc/go-netapp/downloads","issues_url":"https://api.github.com/repos/factioninc/go-netapp/issues{/number}","pulls_url":"https://api.github.com/repos/factioninc/go-netapp/pulls{/number}","milestones_url":"https://api.github.com/repos/factioninc/go-netapp/milestones{/number}","notifications_url":"https://api.github.com/repos/factioninc/go-netapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/factioninc/go-netapp/labels{/name}","releases_url":"https://api.github.com/repos/factioninc/go-netapp/releases{/id}","deployments_url":"https://api.github.com/repos/factioninc/go-netapp/deployments","created_at":"2018-09-12T21:06:26Z","updated_at":"2018-09-12T21:06:28Z","pushed_at":"2018-09-23T21:41:58Z","git_url":"git://github.com/factioninc/go-netapp.git","ssh_url":"git@github.com:factioninc/go-netapp.git","clone_url":"https://github.com/factioninc/go-netapp.git","svn_url":"https://github.com/factioninc/go-netapp","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"faction"}},"base":{"label":"pepabo:master","ref":"master","sha":"e15333d4360a1d51bb00711868963e735e2a647d","user":{"login":"pepabo","id":1708980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDg5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1708980?v=4","gravatar_id":"","url":"https://api.github.com/users/pepabo","html_url":"https://github.com/pepabo","followers_url":"https://api.github.com/users/pepabo/followers","following_url":"https://api.github.com/users/pepabo/following{/other_user}","gists_url":"https://api.github.com/users/pepabo/gists{/gist_id}","starred_url":"https://api.github.com/users/pepabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepabo/subscriptions","organizations_url":"https://api.github.com/users/pepabo/orgs","repos_url":"https://api.github.com/users/pepabo/repos","events_url":"https://api.github.com/users/pepabo/events{/privacy}","received_events_url":"https://api.github.com/users/pepabo/received_events","type":"Organization","site_admin":false},"repo":{"id":105720602,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU3MjA2MDI=","name":"go-netapp","full_name":"pepabo/go-netapp","private":false,"owner":{"login":"pepabo","id":1708980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDg5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1708980?v=4","gravatar_id":"","url":"https://api.github.com/users/pepabo","html_url":"https://github.com/pepabo","followers_url":"https://api.github.com/users/pepabo/followers","following_url":"https://api.github.com/users/pepabo/following{/other_user}","gists_url":"https://api.github.com/users/pepabo/gists{/gist_id}","starred_url":"https://api.github.com/users/pepabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepabo/subscriptions","organizations_url":"https://api.github.com/users/pepabo/orgs","repos_url":"https://api.github.com/users/pepabo/repos","events_url":"https://api.github.com/users/pepabo/events{/privacy}","received_events_url":"https://api.github.com/users/pepabo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pepabo/go-netapp","description":"golang's netapp client","fork":false,"url":"https://api.github.com/repos/pepabo/go-netapp","forks_url":"https://api.github.com/repos/pepabo/go-netapp/forks","keys_url":"https://api.github.com/repos/pepabo/go-netapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pepabo/go-netapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pepabo/go-netapp/teams","hooks_url":"https://api.github.com/repos/pepabo/go-netapp/hooks","issue_events_url":"https://api.github.com/repos/pepabo/go-netapp/issues/events{/number}","events_url":"https://api.github.com/repos/pepabo/go-netapp/events","assignees_url":"https://api.github.com/repos/pepabo/go-netapp/assignees{/user}","branches_url":"https://api.github.com/repos/pepabo/go-netapp/branches{/branch}","tags_url":"https://api.github.com/repos/pepabo/go-netapp/tags","blobs_url":"https://api.github.com/repos/pepabo/go-netapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pepabo/go-netapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pepabo/go-netapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pepabo/go-netapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pepabo/go-netapp/statuses/{sha}","languages_url":"https://api.github.com/repos/pepabo/go-netapp/languages","stargazers_url":"https://api.github.com/repos/pepabo/go-netapp/stargazers","contributors_url":"https://api.github.com/repos/pepabo/go-netapp/contributors","subscribers_url":"https://api.github.com/repos/pepabo/go-netapp/subscribers","subscription_url":"https://api.github.com/repos/pepabo/go-netapp/subscription","commits_url":"https://api.github.com/repos/pepabo/go-netapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pepabo/go-netapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pepabo/go-netapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pepabo/go-netapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/pepabo/go-netapp/contents/{+path}","compare_url":"https://api.github.com/repos/pepabo/go-netapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pepabo/go-netapp/merges","archive_url":"https://api.github.com/repos/pepabo/go-netapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pepabo/go-netapp/downloads","issues_url":"https://api.github.com/repos/pepabo/go-netapp/issues{/number}","pulls_url":"https://api.github.com/repos/pepabo/go-netapp/pulls{/number}","milestones_url":"https://api.github.com/repos/pepabo/go-netapp/milestones{/number}","notifications_url":"https://api.github.com/repos/pepabo/go-netapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pepabo/go-netapp/labels{/name}","releases_url":"https://api.github.com/repos/pepabo/go-netapp/releases{/id}","deployments_url":"https://api.github.com/repos/pepabo/go-netapp/deployments","created_at":"2017-10-04T01:21:02Z","updated_at":"2018-09-20T17:04:29Z","pushed_at":"2018-09-23T21:40:05Z","git_url":"git://github.com/pepabo/go-netapp.git","ssh_url":"git@github.com:pepabo/go-netapp.git","clone_url":"https://github.com/pepabo/go-netapp.git","svn_url":"https://github.com/pepabo/go-netapp","homepage":null,"size":56,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":0,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pepabo/go-netapp/pulls/17"},"html":{"href":"https://github.com/pepabo/go-netapp/pull/17"},"issue":{"href":"https://api.github.com/repos/pepabo/go-netapp/issues/17"},"comments":{"href":"https://api.github.com/repos/pepabo/go-netapp/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/pepabo/go-netapp/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/pepabo/go-netapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pepabo/go-netapp/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/pepabo/go-netapp/statuses/0fca7cfbb1d7676f1272cd052b01e73d261948a7"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":436,"deletions":35,"changed_files":27}}
{"actor":{"display_login":"smazurov"}}