{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/47036","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/47036/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47036/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/47036/events","html_url":"https://github.com/saltstack/salt/issues/47036","id":313807153,"number":47036,"title":"windows pkg.latest full_name issue 2018.3.0","user":{"login":"jeremylarose","id":24782461,"avatar_url":"https://avatars3.githubusercontent.com/u/24782461?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremylarose","html_url":"https://github.com/jeremylarose","followers_url":"https://api.github.com/users/jeremylarose/followers","following_url":"https://api.github.com/users/jeremylarose/following{/other_user}","gists_url":"https://api.github.com/users/jeremylarose/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremylarose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremylarose/subscriptions","organizations_url":"https://api.github.com/users/jeremylarose/orgs","repos_url":"https://api.github.com/users/jeremylarose/repos","events_url":"https://api.github.com/users/jeremylarose/events{/privacy}","received_events_url":"https://api.github.com/users/jeremylarose/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-12T16:47:17Z","updated_at":"2018-04-13T07:37:14Z","closed_at":null,"author_association":"NONE","body":"### Description of Issue/Question\r\nI haven't seen this with any other software yet, but if \"Adobe Flash Player 29 PPAPI\" or \"Adobe Flash Player 29 NPAPI\" is already installed on the system (ex: upgrading 29.0.0.113 to .140) and set as the \"full_name\" and pkg.latest is used in a state, it fails without downloading the pkg to the minion (\"Package flash failed to update.\").  If you change the full_name to anything else (ex: Adobe Flash Player 29 WHATEVER), it works.  Also, pkg.installed with version=latest works just fine, so i'm using that for flash right now.  This isn't a critcal issue, and I already have a work around, just bringing it up, since it affected every windows 10 or windows 7 machine I tried.\r\n\r\n### Setup\r\nrepo flash.sls...\r\nflash:\r\n  '29.0.0.140':\r\n    full_name: 'Adobe Flash Player 29 PPAPI'\r\n    installer: 'salt://win/repo-ng/files/AdobeFlashPlayer-29.0.0.140.exe'\r\n    uninstaller: 'salt://win/repo-ng/files/flash_remove.exe'\r\n    msiexec: False\r\n    locale: en_US\r\n    reboot: False\r\n\r\nstate sls that DOESN'T work...\r\nflash_update:\r\n  pkg.latest:\r\n    - name: flash\r\n    - onlyif:\r\n      - 'if not exist \"%SYSTEMROOT%\\{{ systemfolder }}\\Macromed\\Flash\\FlashPlayerUpdateService.exe\" MD; 2>NUL'\r\n\r\nstate sls that DOES work....\r\nflash_update:\r\n  pkg.installed:\r\n    - name: flash\r\n    - version: latest\r\n    - onlyif:\r\n      - 'if not exist \"%SYSTEMROOT%\\{{ systemfolder }}\\Macromed\\Flash\\FlashPlayerUpdateService.exe\" MD; 2>NUL'\r\n\r\n### Steps to Reproduce Issue\r\nstate.apply debug output...\r\n\r\n[INFO    ] Running state [flash] at time 12:23:34.898000\r\n[INFO    ] Executing state pkg.latest for [flash]\r\n[DEBUG   ] Could not LazyLoad pkg.mod_run_check: 'pkg.mod_run_check' is not available.\r\n[INFO    ] Executing command 'if not exist \"%SYSTEMROOT%\\SysWOW64\\Macromed\\Flash\\FlashPlayerUpdateService.exe\" MD; 2>NUL\r\n[DEBUG   ] output:\r\n[DEBUG   ] Last command return code: 0\r\n[DEBUG   ] Could not LazyLoad pkg.resolve_capabilities: 'pkg.resolve_capabilities' is not available.\r\n[DEBUG   ] Using existing pkg metadata db for saltenv 'base' (age is 0:00:02.700737)\r\n[DEBUG   ] Latest installed version of flash is 29.0.0.113\r\n[DEBUG   ] Latest available version of package flash is 29.0.0.140\r\n[DEBUG   ] Upgrade of flash from 29.0.0.113 to 29.0.0.140 is available\r\n[DEBUG   ] Using existing pkg metadata db for saltenv 'base' (age is 0:00:02.759737)\r\n[DEBUG   ] Could not LazyLoad pkg.normalize_name: 'pkg.normalize_name' is not available.\r\n[DEBUG   ] Using existing pkg metadata db for saltenv 'base' (age is 0:00:02.821737)\r\n**[DEBUG   ] A version (None) already installed for package flash**\r\n[DEBUG   ] Using existing pkg metadata db for saltenv 'base' (age is 0:00:02.874737)\r\n[ERROR   ] Package flash failed to update.\r\n\r\n### Versions Report\r\nminion\r\nSalt Version:\r\n           Salt: 2018.3.0\r\nDependency Versions:\r\n           cffi: 1.10.0\r\n       cherrypy: 10.2.1\r\n       dateutil: 2.6.1\r\n      docker-py: Not Installed\r\n          gitdb: 2.0.3\r\n      gitpython: 2.1.7\r\n          ioflo: Not Installed\r\n         Jinja2: 2.10\r\n        libgit2: Not Installed\r\n        libnacl: 1.6.1\r\n       M2Crypto: Not Installed\r\n           Mako: 1.0.7\r\n   msgpack-pure: Not Installed\r\n msgpack-python: 0.4.8\r\n   mysql-python: Not Installed\r\n      pycparser: 2.18\r\n       pycrypto: 2.6.1\r\n   pycryptodome: Not Installed\r\n         pygit2: Not Installed\r\n         Python: 2.7.14 (v2.7.14:84471935ed, Sep 16 2017, 20:25:58) [MSC v.1500 64 bit (AMD64)]\r\n   python-gnupg: 0.4.1\r\n         PyYAML: 3.12\r\n          PyZMQ: 16.0.3\r\n           RAET: Not Installed\r\n          smmap: 2.0.3\r\n        timelib: 0.2.4\r\n        Tornado: 4.5.2\r\n            ZMQ: 4.1.6\r\nSystem Versions:\r\n           dist:\r\n         locale: cp1252\r\n        machine: AMD64\r\n        release: 10\r\n         system: Windows\r\n        version: 10 10.0.15063  Multiprocessor Free\r\n\r\nmaster... \r\nSalt Version:\r\n           Salt: 2018.3.0\r\nDependency Versions:\r\n           cffi: Not Installed\r\n       cherrypy: 3.5.0\r\n       dateutil: 2.4.2\r\n      docker-py: Not Installed\r\n          gitdb: 0.6.4\r\n      gitpython: 1.0.1\r\n          ioflo: Not Installed\r\n         Jinja2: 2.8\r\n        libgit2: Not Installed\r\n        libnacl: Not Installed\r\n       M2Crypto: Not Installed\r\n           Mako: 1.0.3\r\n   msgpack-pure: Not Installed\r\n msgpack-python: 0.4.6\r\n   mysql-python: Not Installed\r\n      pycparser: Not Installed\r\n       pycrypto: 2.6.1\r\n   pycryptodome: Not Installed\r\n         pygit2: Not Installed\r\n         Python: 2.7.12 (default, Dec  4 2017, 14:50:18)\r\n   python-gnupg: Not Installed\r\n         PyYAML: 3.11\r\n          PyZMQ: 15.2.0\r\n           RAET: Not Installed\r\n          smmap: 0.9.0\r\n        timelib: Not Installed\r\n        Tornado: 4.2.1\r\n            ZMQ: 4.1.4\r\nSystem Versions:\r\n           dist: Ubuntu 16.04 xenial\r\n         locale: UTF-8\r\n        machine: x86_64\r\n        release: 4.4.0-119-generic\r\n         system: Linux\r\n        version: Ubuntu 16.04 xenial"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/381051118","html_url":"https://github.com/saltstack/salt/issues/47036#issuecomment-381051118","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47036","id":381051118,"user":{"login":"damon-atkins","id":9368124,"avatar_url":"https://avatars1.githubusercontent.com/u/9368124?v=4","gravatar_id":"","url":"https://api.github.com/users/damon-atkins","html_url":"https://github.com/damon-atkins","followers_url":"https://api.github.com/users/damon-atkins/followers","following_url":"https://api.github.com/users/damon-atkins/following{/other_user}","gists_url":"https://api.github.com/users/damon-atkins/gists{/gist_id}","starred_url":"https://api.github.com/users/damon-atkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damon-atkins/subscriptions","organizations_url":"https://api.github.com/users/damon-atkins/orgs","repos_url":"https://api.github.com/users/damon-atkins/repos","events_url":"https://api.github.com/users/damon-atkins/events{/privacy}","received_events_url":"https://api.github.com/users/damon-atkins/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T07:37:14Z","updated_at":"2018-04-13T07:37:14Z","author_association":"CONTRIBUTOR","body":"if you provide a version '29.0.0.140' latest checks the highest version is installed.  Should not need the onlyif.\r\n\r\npkg.installed with no version number will install the latest if no version is installed at all. And will never \r\nupgrade it or down grade it. Again should not need the onlyif.\r\n\r\nIf the software comes with a helper to perform self upgrades then you should use 'lastest' the flash.sls for the version string. \r\n\r\nuninstaller can be a local binary.\r\n\r\nYou will find this in the release notes which will dump some for information out for you see what is going on. Note salt itself does not use this code yet, but it prints a lot of useful information.\r\n```\r\nchcp 65001\r\nc:\\salt\\bin\\python.exe c:\\salt\\bin\\lib\\site-packages\\salt\\utils\\pkg\\win.py\r\nc:\\salt\\bin\\python.exe c:\\salt\\bin\\lib\\site-packages\\salt\\utils\\pkg\\win.py detail system\r\n```\r\n"}}
{"actor":{"display_login":"damon-atkins"}}