{"action":"created","comment":{"url":"https://api.github.com/repos/ianyh/Amethyst/pulls/comments/236022410","pull_request_review_id":178029119,"id":236022410,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjAyMjQxMA==","diff_hunk":"@@ -306,6 +306,51 @@ final class UserConfigurationTests: QuickSpec {\n                 \n                 expect(configuration.runningApplication(bundleIdentifiable, shouldFloatWindowWithTitle: title)).to(beFalse())\n             }\n+\n+            context(\"as whitelist\") {\n+                it(\"does not float for a matching window title\") {\n+                    let storage = TestConfigurationStorage()\n+                    let configuration = UserConfiguration(storage: storage)\n+                    let floatingBundle = FloatingBundle(id: \"test.test.Test\", windowTitles: [\"test\"])\n+                    \n+                    storage.set(false, forKey: .floatingBundleIdentifiersIsBlacklist)\n+                    configuration.setFloatingBundles([floatingBundle])\n+                    ","path":"AmethystTests/Configuration/UserConfigurationTests.swift","position":13,"original_position":13,"commit_id":"07bfcad5a23c0e972eefe59681e450ced749c8ee","original_commit_id":"07bfcad5a23c0e972eefe59681e450ced749c8ee","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)","created_at":"2018-11-23T22:04:25Z","updated_at":"2018-11-23T22:04:25Z","html_url":"https://github.com/ianyh/Amethyst/pull/766#discussion_r236022410","pull_request_url":"https://api.github.com/repos/ianyh/Amethyst/pulls/766","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ianyh/Amethyst/pulls/comments/236022410"},"html":{"href":"https://github.com/ianyh/Amethyst/pull/766#discussion_r236022410"},"pull_request":{"href":"https://api.github.com/repos/ianyh/Amethyst/pulls/766"}}},"pull_request":{"url":"https://api.github.com/repos/ianyh/Amethyst/pulls/766","id":233284154,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjg0MTU0","html_url":"https://github.com/ianyh/Amethyst/pull/766","diff_url":"https://github.com/ianyh/Amethyst/pull/766.diff","patch_url":"https://github.com/ianyh/Amethyst/pull/766.patch","issue_url":"https://api.github.com/repos/ianyh/Amethyst/issues/766","number":766,"state":"open","locked":false,"title":"Correct the logic for whitelisting","user":{"login":"ianyh","id":212270,"node_id":"MDQ6VXNlcjIxMjI3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/212270?v=4","gravatar_id":"","url":"https://api.github.com/users/ianyh","html_url":"https://github.com/ianyh","followers_url":"https://api.github.com/users/ianyh/followers","following_url":"https://api.github.com/users/ianyh/following{/other_user}","gists_url":"https://api.github.com/users/ianyh/gists{/gist_id}","starred_url":"https://api.github.com/users/ianyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianyh/subscriptions","organizations_url":"https://api.github.com/users/ianyh/orgs","repos_url":"https://api.github.com/users/ianyh/repos","events_url":"https://api.github.com/users/ianyh/events{/privacy}","received_events_url":"https://api.github.com/users/ianyh/received_events","type":"User","site_admin":false},"body":"Fixes #758","created_at":"2018-11-23T22:04:16Z","updated_at":"2018-11-23T22:04:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"420be7b7fc54b7c23b8f6e7c2b29014cc7c514ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ianyh/Amethyst/pulls/766/commits","review_comments_url":"https://api.github.com/repos/ianyh/Amethyst/pulls/766/comments","review_comment_url":"https://api.github.com/repos/ianyh/Amethyst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ianyh/Amethyst/issues/766/comments","statuses_url":"https://api.github.com/repos/ianyh/Amethyst/statuses/07bfcad5a23c0e972eefe59681e450ced749c8ee","head":{"label":"ianyh:whitelist-fix","ref":"whitelist-fix","sha":"07bfcad5a23c0e972eefe59681e450ced749c8ee","user":{"login":"ianyh","id":212270,"node_id":"MDQ6VXNlcjIxMjI3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/212270?v=4","gravatar_id":"","url":"https://api.github.com/users/ianyh","html_url":"https://github.com/ianyh","followers_url":"https://api.github.com/users/ianyh/followers","following_url":"https://api.github.com/users/ianyh/following{/other_user}","gists_url":"https://api.github.com/users/ianyh/gists{/gist_id}","starred_url":"https://api.github.com/users/ianyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianyh/subscriptions","organizations_url":"https://api.github.com/users/ianyh/orgs","repos_url":"https://api.github.com/users/ianyh/repos","events_url":"https://api.github.com/users/ianyh/events{/privacy}","received_events_url":"https://api.github.com/users/ianyh/received_events","type":"User","site_admin":false},"repo":{"id":10115880,"node_id":"MDEwOlJlcG9zaXRvcnkxMDExNTg4MA==","name":"Amethyst","full_name":"ianyh/Amethyst","private":false,"owner":{"login":"ianyh","id":212270,"node_id":"MDQ6VXNlcjIxMjI3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/212270?v=4","gravatar_id":"","url":"https://api.github.com/users/ianyh","html_url":"https://github.com/ianyh","followers_url":"https://api.github.com/users/ianyh/followers","following_url":"https://api.github.com/users/ianyh/following{/other_user}","gists_url":"https://api.github.com/users/ianyh/gists{/gist_id}","starred_url":"https://api.github.com/users/ianyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianyh/subscriptions","organizations_url":"https://api.github.com/users/ianyh/orgs","repos_url":"https://api.github.com/users/ianyh/repos","events_url":"https://api.github.com/users/ianyh/events{/privacy}","received_events_url":"https://api.github.com/users/ianyh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ianyh/Amethyst","description":"Automatic tiling window manager for macOS à la xmonad.","fork":false,"url":"https://api.github.com/repos/ianyh/Amethyst","forks_url":"https://api.github.com/repos/ianyh/Amethyst/forks","keys_url":"https://api.github.com/repos/ianyh/Amethyst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianyh/Amethyst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianyh/Amethyst/teams","hooks_url":"https://api.github.com/repos/ianyh/Amethyst/hooks","issue_events_url":"https://api.github.com/repos/ianyh/Amethyst/issues/events{/number}","events_url":"https://api.github.com/repos/ianyh/Amethyst/events","assignees_url":"https://api.github.com/repos/ianyh/Amethyst/assignees{/user}","branches_url":"https://api.github.com/repos/ianyh/Amethyst/branches{/branch}","tags_url":"https://api.github.com/repos/ianyh/Amethyst/tags","blobs_url":"https://api.github.com/repos/ianyh/Amethyst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianyh/Amethyst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianyh/Amethyst/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianyh/Amethyst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianyh/Amethyst/statuses/{sha}","languages_url":"https://api.github.com/repos/ianyh/Amethyst/languages","stargazers_url":"https://api.github.com/repos/ianyh/Amethyst/stargazers","contributors_url":"https://api.github.com/repos/ianyh/Amethyst/contributors","subscribers_url":"https://api.github.com/repos/ianyh/Amethyst/subscribers","subscription_url":"https://api.github.com/repos/ianyh/Amethyst/subscription","commits_url":"https://api.github.com/repos/ianyh/Amethyst/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianyh/Amethyst/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianyh/Amethyst/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianyh/Amethyst/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianyh/Amethyst/contents/{+path}","compare_url":"https://api.github.com/repos/ianyh/Amethyst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianyh/Amethyst/merges","archive_url":"https://api.github.com/repos/ianyh/Amethyst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianyh/Amethyst/downloads","issues_url":"https://api.github.com/repos/ianyh/Amethyst/issues{/number}","pulls_url":"https://api.github.com/repos/ianyh/Amethyst/pulls{/number}","milestones_url":"https://api.github.com/repos/ianyh/Amethyst/milestones{/number}","notifications_url":"https://api.github.com/repos/ianyh/Amethyst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianyh/Amethyst/labels{/name}","releases_url":"https://api.github.com/repos/ianyh/Amethyst/releases{/id}","deployments_url":"https://api.github.com/repos/ianyh/Amethyst/deployments","created_at":"2013-05-17T04:15:55Z","updated_at":"2018-11-23T17:40:20Z","pushed_at":"2018-11-23T22:04:17Z","git_url":"git://github.com/ianyh/Amethyst.git","ssh_url":"git@github.com:ianyh/Amethyst.git","clone_url":"https://github.com/ianyh/Amethyst.git","svn_url":"https://github.com/ianyh/Amethyst","homepage":"https://ianyh.com/amethyst/","size":23169,"stargazers_count":5403,"watchers_count":5403,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":210,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":210,"open_issues":133,"watchers":5403,"default_branch":"development"}},"base":{"label":"ianyh:0.12.2","ref":"0.12.2","sha":"3e98a104b2c96db81bd4e5d939d94ca9ae574982","user":{"login":"ianyh","id":212270,"node_id":"MDQ6VXNlcjIxMjI3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/212270?v=4","gravatar_id":"","url":"https://api.github.com/users/ianyh","html_url":"https://github.com/ianyh","followers_url":"https://api.github.com/users/ianyh/followers","following_url":"https://api.github.com/users/ianyh/following{/other_user}","gists_url":"https://api.github.com/users/ianyh/gists{/gist_id}","starred_url":"https://api.github.com/users/ianyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianyh/subscriptions","organizations_url":"https://api.github.com/users/ianyh/orgs","repos_url":"https://api.github.com/users/ianyh/repos","events_url":"https://api.github.com/users/ianyh/events{/privacy}","received_events_url":"https://api.github.com/users/ianyh/received_events","type":"User","site_admin":false},"repo":{"id":10115880,"node_id":"MDEwOlJlcG9zaXRvcnkxMDExNTg4MA==","name":"Amethyst","full_name":"ianyh/Amethyst","private":false,"owner":{"login":"ianyh","id":212270,"node_id":"MDQ6VXNlcjIxMjI3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/212270?v=4","gravatar_id":"","url":"https://api.github.com/users/ianyh","html_url":"https://github.com/ianyh","followers_url":"https://api.github.com/users/ianyh/followers","following_url":"https://api.github.com/users/ianyh/following{/other_user}","gists_url":"https://api.github.com/users/ianyh/gists{/gist_id}","starred_url":"https://api.github.com/users/ianyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianyh/subscriptions","organizations_url":"https://api.github.com/users/ianyh/orgs","repos_url":"https://api.github.com/users/ianyh/repos","events_url":"https://api.github.com/users/ianyh/events{/privacy}","received_events_url":"https://api.github.com/users/ianyh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ianyh/Amethyst","description":"Automatic tiling window manager for macOS à la xmonad.","fork":false,"url":"https://api.github.com/repos/ianyh/Amethyst","forks_url":"https://api.github.com/repos/ianyh/Amethyst/forks","keys_url":"https://api.github.com/repos/ianyh/Amethyst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianyh/Amethyst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianyh/Amethyst/teams","hooks_url":"https://api.github.com/repos/ianyh/Amethyst/hooks","issue_events_url":"https://api.github.com/repos/ianyh/Amethyst/issues/events{/number}","events_url":"https://api.github.com/repos/ianyh/Amethyst/events","assignees_url":"https://api.github.com/repos/ianyh/Amethyst/assignees{/user}","branches_url":"https://api.github.com/repos/ianyh/Amethyst/branches{/branch}","tags_url":"https://api.github.com/repos/ianyh/Amethyst/tags","blobs_url":"https://api.github.com/repos/ianyh/Amethyst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianyh/Amethyst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianyh/Amethyst/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianyh/Amethyst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianyh/Amethyst/statuses/{sha}","languages_url":"https://api.github.com/repos/ianyh/Amethyst/languages","stargazers_url":"https://api.github.com/repos/ianyh/Amethyst/stargazers","contributors_url":"https://api.github.com/repos/ianyh/Amethyst/contributors","subscribers_url":"https://api.github.com/repos/ianyh/Amethyst/subscribers","subscription_url":"https://api.github.com/repos/ianyh/Amethyst/subscription","commits_url":"https://api.github.com/repos/ianyh/Amethyst/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianyh/Amethyst/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianyh/Amethyst/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianyh/Amethyst/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianyh/Amethyst/contents/{+path}","compare_url":"https://api.github.com/repos/ianyh/Amethyst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianyh/Amethyst/merges","archive_url":"https://api.github.com/repos/ianyh/Amethyst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianyh/Amethyst/downloads","issues_url":"https://api.github.com/repos/ianyh/Amethyst/issues{/number}","pulls_url":"https://api.github.com/repos/ianyh/Amethyst/pulls{/number}","milestones_url":"https://api.github.com/repos/ianyh/Amethyst/milestones{/number}","notifications_url":"https://api.github.com/repos/ianyh/Amethyst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianyh/Amethyst/labels{/name}","releases_url":"https://api.github.com/repos/ianyh/Amethyst/releases{/id}","deployments_url":"https://api.github.com/repos/ianyh/Amethyst/deployments","created_at":"2013-05-17T04:15:55Z","updated_at":"2018-11-23T17:40:20Z","pushed_at":"2018-11-23T22:04:17Z","git_url":"git://github.com/ianyh/Amethyst.git","ssh_url":"git@github.com:ianyh/Amethyst.git","clone_url":"https://github.com/ianyh/Amethyst.git","svn_url":"https://github.com/ianyh/Amethyst","homepage":"https://ianyh.com/amethyst/","size":23169,"stargazers_count":5403,"watchers_count":5403,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":210,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":210,"open_issues":133,"watchers":5403,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ianyh/Amethyst/pulls/766"},"html":{"href":"https://github.com/ianyh/Amethyst/pull/766"},"issue":{"href":"https://api.github.com/repos/ianyh/Amethyst/issues/766"},"comments":{"href":"https://api.github.com/repos/ianyh/Amethyst/issues/766/comments"},"review_comments":{"href":"https://api.github.com/repos/ianyh/Amethyst/pulls/766/comments"},"review_comment":{"href":"https://api.github.com/repos/ianyh/Amethyst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ianyh/Amethyst/pulls/766/commits"},"statuses":{"href":"https://api.github.com/repos/ianyh/Amethyst/statuses/07bfcad5a23c0e972eefe59681e450ced749c8ee"}},"author_association":"OWNER"}}
{"actor":{"display_login":"houndci-bot"}}