{"action":"created","issue":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/426","repository_url":"https://api.github.com/repos/kubeflow/kubeflow","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/426/labels{/name}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/426/comments","events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/426/events","html_url":"https://github.com/kubeflow/kubeflow/pull/426","id":305291567,"number":426,"title":"Inherit namespace from ksonnet environment","user":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"labels":[{"id":796399084,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/L","name":"size/L","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-03-14T19:07:45Z","updated_at":"2018-03-19T19:28:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/426","html_url":"https://github.com/kubeflow/kubeflow/pull/426","diff_url":"https://github.com/kubeflow/kubeflow/pull/426.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/426.patch"},"body":"Now that ksonnet makes `env` available in it's components, we can\nleverate that to use the environment's namespace instead of hardcoding a\ndefault namespace in the component parameters.\n\nSo now the behaviour is that when components are generated from\nprototypes, we default to using the environment's namespace. If the user\nhas overridden namespace as a parameter, that will get used for the\ncomponent.\n\nTested by deploying kubeflow-core and tf-serving to a new k8s cluster\n\nFixes https://github.com/kubeflow/kubeflow/issues/43\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/426)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments/374339174","html_url":"https://github.com/kubeflow/kubeflow/pull/426#issuecomment-374339174","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/426","id":374339174,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T19:28:49Z","updated_at":"2018-03-19T19:28:49Z","author_association":"COLLABORATOR","body":"@ankushagarwal: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nkubeflow-presubmit | e838b9fd4b4871aedfa6c986315cc900b3eb07a9 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kubeflow_kubeflow/426/kubeflow-presubmit/698/) | `/test kubeflow-presubmit`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/kubeflow_kubeflow/426). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/ankushagarwal). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubeflow/kubeflow/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}