{"action":"created","issue":{"url":"https://api.github.com/repos/projectfluent/fluent.js/issues/285","repository_url":"https://api.github.com/repos/projectfluent/fluent.js","labels_url":"https://api.github.com/repos/projectfluent/fluent.js/issues/285/labels{/name}","comments_url":"https://api.github.com/repos/projectfluent/fluent.js/issues/285/comments","events_url":"https://api.github.com/repos/projectfluent/fluent.js/issues/285/events","html_url":"https://github.com/projectfluent/fluent.js/issues/285","id":362471833,"node_id":"MDU6SXNzdWUzNjI0NzE4MzM=","number":285,"title":"Allow <Localized> to wrap a text node?","user":{"login":"birtles","id":1232595,"node_id":"MDQ6VXNlcjEyMzI1OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1232595?v=4","gravatar_id":"","url":"https://api.github.com/users/birtles","html_url":"https://github.com/birtles","followers_url":"https://api.github.com/users/birtles/followers","following_url":"https://api.github.com/users/birtles/following{/other_user}","gists_url":"https://api.github.com/users/birtles/gists{/gist_id}","starred_url":"https://api.github.com/users/birtles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birtles/subscriptions","organizations_url":"https://api.github.com/users/birtles/orgs","repos_url":"https://api.github.com/users/birtles/repos","events_url":"https://api.github.com/users/birtles/events{/privacy}","received_events_url":"https://api.github.com/users/birtles/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-21T06:28:52Z","updated_at":"2018-09-24T15:34:03Z","closed_at":"2018-09-24T15:34:03Z","author_association":"NONE","body":"This might be a silly request, I'm not familiar with fluent-react and haven't really thought it through, but would it make sense to allow `<Localized>` to wrap a text node instead of just a React element?\r\n\r\nI notice Localized currently uses React's [`children.only`](https://github.com/projectfluent/fluent.js/blob/f0eb0983bacccdf59086215e856e1181c8be70fc/fluent-react/src/localized.js#L83) which requires a single React _element_ child.\r\n\r\nWe're using fluent-react in the rewrite of Firefox's remote debugging and noticed we had to add extra `<span>` elements so I went to investigate why. I suppose supporting text nodes would add extra complexity to the `render()` method of `Localized` but I thought I would ask anyway."},"comment":{"url":"https://api.github.com/repos/projectfluent/fluent.js/issues/comments/424018809","html_url":"https://github.com/projectfluent/fluent.js/issues/285#issuecomment-424018809","issue_url":"https://api.github.com/repos/projectfluent/fluent.js/issues/285","id":424018809,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDAxODgwOQ==","user":{"login":"stasm","id":265818,"node_id":"MDQ6VXNlcjI2NTgxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/265818?v=4","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T15:34:03Z","updated_at":"2018-09-24T15:34:03Z","author_association":"MEMBER","body":"#230 fixed this; closing. I'll publish a new release of `fluent-react` this week."}}
{"actor":{"display_login":"stasm"}}