{"action":"created","comment":{"url":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments/182188824","pull_request_review_id":112946389,"id":182188824,"diff_hunk":"@@ -52,6 +52,15 @@\n /* Module pre-compile time settings.                                         */\n /*===========================================================================*/\n \n+/* dRonin: This if fixed upstream apparently, remove on upgrade to 18.x. */","path":"flight/PiOS/Common/Libraries/ChibiOS/os/common/startup/ARMCMx/compilers/GCC/crt0_v7m.S","position":null,"original_position":4,"commit_id":"69fad6a3994ec21ec27d8501238c8daf2b1b18b6","original_commit_id":"69fad6a3994ec21ec27d8501238c8daf2b1b18b6","user":{"login":"tracernz","id":9995998,"avatar_url":"https://avatars1.githubusercontent.com/u/9995998?v=4","gravatar_id":"","url":"https://api.github.com/users/tracernz","html_url":"https://github.com/tracernz","followers_url":"https://api.github.com/users/tracernz/followers","following_url":"https://api.github.com/users/tracernz/following{/other_user}","gists_url":"https://api.github.com/users/tracernz/gists{/gist_id}","starred_url":"https://api.github.com/users/tracernz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tracernz/subscriptions","organizations_url":"https://api.github.com/users/tracernz/orgs","repos_url":"https://api.github.com/users/tracernz/repos","events_url":"https://api.github.com/users/tracernz/events{/privacy}","received_events_url":"https://api.github.com/users/tracernz/received_events","type":"User","site_admin":false},"body":"Can never be fixed because we will always have old bootloaders around.","created_at":"2018-04-17T18:51:52Z","updated_at":"2018-04-17T18:51:52Z","html_url":"https://github.com/d-ronin/dRonin/pull/2025#discussion_r182188824","pull_request_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/2025","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments/182188824"},"html":{"href":"https://github.com/d-ronin/dRonin/pull/2025#discussion_r182188824"},"pull_request":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/2025"}}},"pull_request":{"url":"https://api.github.com/repos/d-ronin/dRonin/pulls/2025","id":161407019,"html_url":"https://github.com/d-ronin/dRonin/pull/2025","diff_url":"https://github.com/d-ronin/dRonin/pull/2025.diff","patch_url":"https://github.com/d-ronin/dRonin/pull/2025.patch","issue_url":"https://api.github.com/repos/d-ronin/dRonin/issues/2025","number":2025,"state":"open","locked":false,"title":"Upgrade to ChibiOS 17.6.3","user":{"login":"glowtape","id":4010813,"avatar_url":"https://avatars0.githubusercontent.com/u/4010813?v=4","gravatar_id":"","url":"https://api.github.com/users/glowtape","html_url":"https://github.com/glowtape","followers_url":"https://api.github.com/users/glowtape/followers","following_url":"https://api.github.com/users/glowtape/following{/other_user}","gists_url":"https://api.github.com/users/glowtape/gists{/gist_id}","starred_url":"https://api.github.com/users/glowtape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glowtape/subscriptions","organizations_url":"https://api.github.com/users/glowtape/orgs","repos_url":"https://api.github.com/users/glowtape/repos","events_url":"https://api.github.com/users/glowtape/events{/privacy}","received_events_url":"https://api.github.com/users/glowtape/received_events","type":"User","site_admin":false},"body":"Posting this for first comments, whenever someone's bored. Or if someone wants to compile and test this.\r\n\r\nCurrently all F4 targets compile, except BrainRE1, where the newer HAL complains about some PLL stuff.  Seems some mcuconf.h values aren't considered correct (anymore).\r\n\r\n_C:/Dev/Chibi/dRonin/flight/PiOS/Common/Libraries/ChibiOS/os/hal/ports/STM32/STM32F4xx/hal_lld.h:1647:2: error: #error \"STM32_PLLI2SVCO outside acceptable range (STM32_PLLVCO_MIN...STM32_PLLVCO_MAX)\"\r\nC:/Dev/Chibi/dRonin/flight/PiOS/Common/Libraries/ChibiOS/os/hal/ports/STM32/STM32F4xx/hal_lld.h:1772:2: error: #error \"STM32_PLLSAIVCO outside acceptable range (STM32_PLLVCO_MIN...STM32_PLLVCO_MAX)\"_\r\n\r\nBenchtested on Seppuku, Revolution and OG Brain. They seem to last a while without rebooting, so I guess things are probably OK.\r\n\r\nQuick memory check on the Revo, it loses 2124 bytes on the heap, gains 56 bytes on the fast heap. Former is probably additional code and memcore. Latter is due to the mainthread stuff from old ChibiOS disappearing, which sat in CCM. I cant force the new struct, that contains that, the readylists and so on, into CCM, though. Probably due to the extremely unique name of \"ch\".\r\n\r\nI bet the loss of heap is probably going to cause grief for me, trying to get SPRF3E to link.","created_at":"2018-01-05T19:11:24Z","updated_at":"2018-04-17T18:51:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"623aeefcdbd6f749b110ee90d40c3371b831e2c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":293028114,"url":"https://api.github.com/repos/d-ronin/dRonin/labels/code-cleanup%20%F0%9F%98%8D","name":"code-cleanup 😍","color":"f7c6c7","default":false},{"id":291725353,"url":"https://api.github.com/repos/d-ronin/dRonin/labels/difficulty/high","name":"difficulty/high","color":"fef2c0","default":false},{"id":291868063,"url":"https://api.github.com/repos/d-ronin/dRonin/labels/flight","name":"flight","color":"fbca04","default":false},{"id":313861096,"url":"https://api.github.com/repos/d-ronin/dRonin/labels/flight/pios","name":"flight/pios","color":"207de5","default":false},{"id":268685912,"url":"https://api.github.com/repos/d-ronin/dRonin/labels/status/work-in-progress","name":"status/work-in-progress","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/d-ronin/dRonin/milestones/8","html_url":"https://github.com/d-ronin/dRonin/milestone/8","labels_url":"https://api.github.com/repos/d-ronin/dRonin/milestones/8/labels","id":2592674,"number":8,"title":"Inconceivable","description":"","creator":{"login":"tracernz","id":9995998,"avatar_url":"https://avatars1.githubusercontent.com/u/9995998?v=4","gravatar_id":"","url":"https://api.github.com/users/tracernz","html_url":"https://github.com/tracernz","followers_url":"https://api.github.com/users/tracernz/followers","following_url":"https://api.github.com/users/tracernz/following{/other_user}","gists_url":"https://api.github.com/users/tracernz/gists{/gist_id}","starred_url":"https://api.github.com/users/tracernz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tracernz/subscriptions","organizations_url":"https://api.github.com/users/tracernz/orgs","repos_url":"https://api.github.com/users/tracernz/repos","events_url":"https://api.github.com/users/tracernz/events{/privacy}","received_events_url":"https://api.github.com/users/tracernz/received_events","type":"User","site_admin":false},"open_issues":70,"closed_issues":109,"state":"open","created_at":"2017-06-20T04:33:58Z","updated_at":"2018-04-17T15:58:43Z","due_on":"2018-05-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/2025/commits","review_comments_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/2025/comments","review_comment_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/issues/2025/comments","statuses_url":"https://api.github.com/repos/d-ronin/dRonin/statuses/69fad6a3994ec21ec27d8501238c8daf2b1b18b6","head":{"label":"glowtape:glowtape-chibios17","ref":"glowtape-chibios17","sha":"69fad6a3994ec21ec27d8501238c8daf2b1b18b6","user":{"login":"glowtape","id":4010813,"avatar_url":"https://avatars0.githubusercontent.com/u/4010813?v=4","gravatar_id":"","url":"https://api.github.com/users/glowtape","html_url":"https://github.com/glowtape","followers_url":"https://api.github.com/users/glowtape/followers","following_url":"https://api.github.com/users/glowtape/following{/other_user}","gists_url":"https://api.github.com/users/glowtape/gists{/gist_id}","starred_url":"https://api.github.com/users/glowtape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glowtape/subscriptions","organizations_url":"https://api.github.com/users/glowtape/orgs","repos_url":"https://api.github.com/users/glowtape/repos","events_url":"https://api.github.com/users/glowtape/events{/privacy}","received_events_url":"https://api.github.com/users/glowtape/received_events","type":"User","site_admin":false},"repo":{"id":64550362,"name":"dRonin","full_name":"glowtape/dRonin","owner":{"login":"glowtape","id":4010813,"avatar_url":"https://avatars0.githubusercontent.com/u/4010813?v=4","gravatar_id":"","url":"https://api.github.com/users/glowtape","html_url":"https://github.com/glowtape","followers_url":"https://api.github.com/users/glowtape/followers","following_url":"https://api.github.com/users/glowtape/following{/other_user}","gists_url":"https://api.github.com/users/glowtape/gists{/gist_id}","starred_url":"https://api.github.com/users/glowtape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glowtape/subscriptions","organizations_url":"https://api.github.com/users/glowtape/orgs","repos_url":"https://api.github.com/users/glowtape/repos","events_url":"https://api.github.com/users/glowtape/events{/privacy}","received_events_url":"https://api.github.com/users/glowtape/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glowtape/dRonin","description":"The dRonin flight controller software.","fork":true,"url":"https://api.github.com/repos/glowtape/dRonin","forks_url":"https://api.github.com/repos/glowtape/dRonin/forks","keys_url":"https://api.github.com/repos/glowtape/dRonin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glowtape/dRonin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glowtape/dRonin/teams","hooks_url":"https://api.github.com/repos/glowtape/dRonin/hooks","issue_events_url":"https://api.github.com/repos/glowtape/dRonin/issues/events{/number}","events_url":"https://api.github.com/repos/glowtape/dRonin/events","assignees_url":"https://api.github.com/repos/glowtape/dRonin/assignees{/user}","branches_url":"https://api.github.com/repos/glowtape/dRonin/branches{/branch}","tags_url":"https://api.github.com/repos/glowtape/dRonin/tags","blobs_url":"https://api.github.com/repos/glowtape/dRonin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glowtape/dRonin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glowtape/dRonin/git/refs{/sha}","trees_url":"https://api.github.com/repos/glowtape/dRonin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glowtape/dRonin/statuses/{sha}","languages_url":"https://api.github.com/repos/glowtape/dRonin/languages","stargazers_url":"https://api.github.com/repos/glowtape/dRonin/stargazers","contributors_url":"https://api.github.com/repos/glowtape/dRonin/contributors","subscribers_url":"https://api.github.com/repos/glowtape/dRonin/subscribers","subscription_url":"https://api.github.com/repos/glowtape/dRonin/subscription","commits_url":"https://api.github.com/repos/glowtape/dRonin/commits{/sha}","git_commits_url":"https://api.github.com/repos/glowtape/dRonin/git/commits{/sha}","comments_url":"https://api.github.com/repos/glowtape/dRonin/comments{/number}","issue_comment_url":"https://api.github.com/repos/glowtape/dRonin/issues/comments{/number}","contents_url":"https://api.github.com/repos/glowtape/dRonin/contents/{+path}","compare_url":"https://api.github.com/repos/glowtape/dRonin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glowtape/dRonin/merges","archive_url":"https://api.github.com/repos/glowtape/dRonin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glowtape/dRonin/downloads","issues_url":"https://api.github.com/repos/glowtape/dRonin/issues{/number}","pulls_url":"https://api.github.com/repos/glowtape/dRonin/pulls{/number}","milestones_url":"https://api.github.com/repos/glowtape/dRonin/milestones{/number}","notifications_url":"https://api.github.com/repos/glowtape/dRonin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glowtape/dRonin/labels{/name}","releases_url":"https://api.github.com/repos/glowtape/dRonin/releases{/id}","deployments_url":"https://api.github.com/repos/glowtape/dRonin/deployments","created_at":"2016-07-30T15:22:56Z","updated_at":"2018-04-14T16:12:18Z","pushed_at":"2018-04-17T18:32:04Z","git_url":"git://github.com/glowtape/dRonin.git","ssh_url":"git@github.com:glowtape/dRonin.git","clone_url":"https://github.com/glowtape/dRonin.git","svn_url":"https://github.com/glowtape/dRonin","homepage":"http://dronin.org","size":262148,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"d-ronin:next","ref":"next","sha":"cd7a75d880e031c72106747d779fb352bf645203","user":{"login":"d-ronin","id":14959302,"avatar_url":"https://avatars2.githubusercontent.com/u/14959302?v=4","gravatar_id":"","url":"https://api.github.com/users/d-ronin","html_url":"https://github.com/d-ronin","followers_url":"https://api.github.com/users/d-ronin/followers","following_url":"https://api.github.com/users/d-ronin/following{/other_user}","gists_url":"https://api.github.com/users/d-ronin/gists{/gist_id}","starred_url":"https://api.github.com/users/d-ronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-ronin/subscriptions","organizations_url":"https://api.github.com/users/d-ronin/orgs","repos_url":"https://api.github.com/users/d-ronin/repos","events_url":"https://api.github.com/users/d-ronin/events{/privacy}","received_events_url":"https://api.github.com/users/d-ronin/received_events","type":"Organization","site_admin":false},"repo":{"id":43620723,"name":"dRonin","full_name":"d-ronin/dRonin","owner":{"login":"d-ronin","id":14959302,"avatar_url":"https://avatars2.githubusercontent.com/u/14959302?v=4","gravatar_id":"","url":"https://api.github.com/users/d-ronin","html_url":"https://github.com/d-ronin","followers_url":"https://api.github.com/users/d-ronin/followers","following_url":"https://api.github.com/users/d-ronin/following{/other_user}","gists_url":"https://api.github.com/users/d-ronin/gists{/gist_id}","starred_url":"https://api.github.com/users/d-ronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-ronin/subscriptions","organizations_url":"https://api.github.com/users/d-ronin/orgs","repos_url":"https://api.github.com/users/d-ronin/repos","events_url":"https://api.github.com/users/d-ronin/events{/privacy}","received_events_url":"https://api.github.com/users/d-ronin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d-ronin/dRonin","description":"The dRonin flight controller software.","fork":false,"url":"https://api.github.com/repos/d-ronin/dRonin","forks_url":"https://api.github.com/repos/d-ronin/dRonin/forks","keys_url":"https://api.github.com/repos/d-ronin/dRonin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-ronin/dRonin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-ronin/dRonin/teams","hooks_url":"https://api.github.com/repos/d-ronin/dRonin/hooks","issue_events_url":"https://api.github.com/repos/d-ronin/dRonin/issues/events{/number}","events_url":"https://api.github.com/repos/d-ronin/dRonin/events","assignees_url":"https://api.github.com/repos/d-ronin/dRonin/assignees{/user}","branches_url":"https://api.github.com/repos/d-ronin/dRonin/branches{/branch}","tags_url":"https://api.github.com/repos/d-ronin/dRonin/tags","blobs_url":"https://api.github.com/repos/d-ronin/dRonin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-ronin/dRonin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-ronin/dRonin/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-ronin/dRonin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-ronin/dRonin/statuses/{sha}","languages_url":"https://api.github.com/repos/d-ronin/dRonin/languages","stargazers_url":"https://api.github.com/repos/d-ronin/dRonin/stargazers","contributors_url":"https://api.github.com/repos/d-ronin/dRonin/contributors","subscribers_url":"https://api.github.com/repos/d-ronin/dRonin/subscribers","subscription_url":"https://api.github.com/repos/d-ronin/dRonin/subscription","commits_url":"https://api.github.com/repos/d-ronin/dRonin/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-ronin/dRonin/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-ronin/dRonin/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-ronin/dRonin/contents/{+path}","compare_url":"https://api.github.com/repos/d-ronin/dRonin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-ronin/dRonin/merges","archive_url":"https://api.github.com/repos/d-ronin/dRonin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-ronin/dRonin/downloads","issues_url":"https://api.github.com/repos/d-ronin/dRonin/issues{/number}","pulls_url":"https://api.github.com/repos/d-ronin/dRonin/pulls{/number}","milestones_url":"https://api.github.com/repos/d-ronin/dRonin/milestones{/number}","notifications_url":"https://api.github.com/repos/d-ronin/dRonin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-ronin/dRonin/labels{/name}","releases_url":"https://api.github.com/repos/d-ronin/dRonin/releases{/id}","deployments_url":"https://api.github.com/repos/d-ronin/dRonin/deployments","created_at":"2015-10-04T01:13:04Z","updated_at":"2018-04-16T07:48:27Z","pushed_at":"2018-04-17T18:32:06Z","git_url":"git://github.com/d-ronin/dRonin.git","ssh_url":"git@github.com:d-ronin/dRonin.git","clone_url":"https://github.com/d-ronin/dRonin.git","svn_url":"https://github.com/d-ronin/dRonin","homepage":"http://dronin.org","size":258629,"stargazers_count":169,"watchers_count":169,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":121,"open_issues":123,"watchers":169,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/2025"},"html":{"href":"https://github.com/d-ronin/dRonin/pull/2025"},"issue":{"href":"https://api.github.com/repos/d-ronin/dRonin/issues/2025"},"comments":{"href":"https://api.github.com/repos/d-ronin/dRonin/issues/2025/comments"},"review_comments":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/2025/comments"},"review_comment":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/2025/commits"},"statuses":{"href":"https://api.github.com/repos/d-ronin/dRonin/statuses/69fad6a3994ec21ec27d8501238c8daf2b1b18b6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tracernz"}}