{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1340","repository_url":"https://api.github.com/repos/bazelbuild/rules_go","labels_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1340/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1340/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1340/events","html_url":"https://github.com/bazelbuild/rules_go/pull/1340","id":298989133,"number":1340,"title":"Various fixes and changes","user":{"login":"steeve","id":137467,"avatar_url":"https://avatars3.githubusercontent.com/u/137467?v=4","gravatar_id":"","url":"https://api.github.com/users/steeve","html_url":"https://github.com/steeve","followers_url":"https://api.github.com/users/steeve/followers","following_url":"https://api.github.com/users/steeve/following{/other_user}","gists_url":"https://api.github.com/users/steeve/gists{/gist_id}","starred_url":"https://api.github.com/users/steeve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steeve/subscriptions","organizations_url":"https://api.github.com/users/steeve/orgs","repos_url":"https://api.github.com/users/steeve/repos","events_url":"https://api.github.com/users/steeve/events{/privacy}","received_events_url":"https://api.github.com/users/steeve/received_events","type":"User","site_admin":false},"labels":[{"id":342134185,"url":"https://api.github.com/repos/bazelbuild/rules_go/labels/cla:%20no","name":"cla: no","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"jayconrod","id":164791,"avatar_url":"https://avatars3.githubusercontent.com/u/164791?v=4","gravatar_id":"","url":"https://api.github.com/users/jayconrod","html_url":"https://github.com/jayconrod","followers_url":"https://api.github.com/users/jayconrod/followers","following_url":"https://api.github.com/users/jayconrod/following{/other_user}","gists_url":"https://api.github.com/users/jayconrod/gists{/gist_id}","starred_url":"https://api.github.com/users/jayconrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayconrod/subscriptions","organizations_url":"https://api.github.com/users/jayconrod/orgs","repos_url":"https://api.github.com/users/jayconrod/repos","events_url":"https://api.github.com/users/jayconrod/events{/privacy}","received_events_url":"https://api.github.com/users/jayconrod/received_events","type":"User","site_admin":false},"assignees":[{"login":"jayconrod","id":164791,"avatar_url":"https://avatars3.githubusercontent.com/u/164791?v=4","gravatar_id":"","url":"https://api.github.com/users/jayconrod","html_url":"https://github.com/jayconrod","followers_url":"https://api.github.com/users/jayconrod/followers","following_url":"https://api.github.com/users/jayconrod/following{/other_user}","gists_url":"https://api.github.com/users/jayconrod/gists{/gist_id}","starred_url":"https://api.github.com/users/jayconrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayconrod/subscriptions","organizations_url":"https://api.github.com/users/jayconrod/orgs","repos_url":"https://api.github.com/users/jayconrod/repos","events_url":"https://api.github.com/users/jayconrod/events{/privacy}","received_events_url":"https://api.github.com/users/jayconrod/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-02-21T14:23:36Z","updated_at":"2018-02-28T13:26:19Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1340","html_url":"https://github.com/bazelbuild/rules_go/pull/1340","diff_url":"https://github.com/bazelbuild/rules_go/pull/1340.diff","patch_url":"https://github.com/bazelbuild/rules_go/pull/1340.patch"},"body":"This PR is a mix of various changes and fixes we've made on https://github.com/znly/rules_go that I think are upstream-able first. Of course we can split and shrink if you guys want.\r\n\r\nHere goes:\r\n36bc7cc: Add runfiles to GoArchiveData and use them in the GoPath\r\nSome binaries (such as https://github.com/golang/mobile/tree/master/cmd/gobind) rely on runtime files to be in the `GOPATH`\r\n\r\n060c171: Expose GoPath provider\r\nTitle says it all. Useful for custom rules.\r\n\r\nf59a93d: Add tags and environment to go_context\r\nTitle says it all.\r\n\r\ne4a157e: Expose GoSource provider\r\nTitle says it all. Useful for custom rules.\r\n\r\n7d1d956: Make the Go environment an update of the OS environment\r\nThis ensures that the Go environment also has the OS environment keys.\r\n\r\nf789bcd: Propagate build tags when `go install`ing `stdlib`\r\n`std` has a few tags here and there (for instance `crypto/x509` needs the `ios` tag to build on `darwin_arm64`). This makes sure they are propagated.\r\n\r\n93ce009: Make stdlib building depend on `CROSSTOOL` (for `runtime/cgo`)\r\n`runtime/cgo` needs the C compiler, and it's not declared as a dependency. As a result, when using a different `CROSSTOOL` (such as Android), it will fail to find the compiler (`clang`).\r\n\r\naad1ce3: extras/bindata: make it executable and run on host\r\nNeeded to use cross compilation (via `--platforms`) and bindata."},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_go/issues/comments/369238362","html_url":"https://github.com/bazelbuild/rules_go/pull/1340#issuecomment-369238362","issue_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1340","id":369238362,"user":{"login":"steeve","id":137467,"avatar_url":"https://avatars3.githubusercontent.com/u/137467?v=4","gravatar_id":"","url":"https://api.github.com/users/steeve","html_url":"https://github.com/steeve","followers_url":"https://api.github.com/users/steeve/followers","following_url":"https://api.github.com/users/steeve/following{/other_user}","gists_url":"https://api.github.com/users/steeve/gists{/gist_id}","starred_url":"https://api.github.com/users/steeve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steeve/subscriptions","organizations_url":"https://api.github.com/users/steeve/orgs","repos_url":"https://api.github.com/users/steeve/repos","events_url":"https://api.github.com/users/steeve/events{/privacy}","received_events_url":"https://api.github.com/users/steeve/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T13:26:19Z","updated_at":"2018-02-28T13:26:19Z","author_association":"NONE","body":"I've updated the branch with your suggestions in https://github.com/bazelbuild/rules_go/pull/1340/commits/840fda363fd78b2e982051320a83777481099a73 and https://github.com/bazelbuild/rules_go/pull/1340/commits/5cda48b4b942651580274674f1e2f178db02b312, so far so good"}}
{"actor":{"display_login":"steeve"}}