{"action":"created","comment":{"url":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/comments/172043209","pull_request_review_id":101000639,"id":172043209,"diff_hunk":"@@ -2,6 +2,8 @@\n \n RSpec.describe HomePageController, type: :controller do\n   describe 'GET show' do\n+    login_user\n+\n     it 'has a 200 status code' do\n       get :show\n       expect(response.status).to eq(200)","path":"spec/controllers/home_page_controller_spec.rb","position":8,"original_position":8,"commit_id":"a2b99874e6a468a30d4e3692952dda8b5f70801f","original_commit_id":"635a30cd852f84adc4c3dc71e28ac85e0c727651","user":{"login":"sinpai","id":4716237,"avatar_url":"https://avatars3.githubusercontent.com/u/4716237?v=4","gravatar_id":"","url":"https://api.github.com/users/sinpai","html_url":"https://github.com/sinpai","followers_url":"https://api.github.com/users/sinpai/followers","following_url":"https://api.github.com/users/sinpai/following{/other_user}","gists_url":"https://api.github.com/users/sinpai/gists{/gist_id}","starred_url":"https://api.github.com/users/sinpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinpai/subscriptions","organizations_url":"https://api.github.com/users/sinpai/orgs","repos_url":"https://api.github.com/users/sinpai/repos","events_url":"https://api.github.com/users/sinpai/events{/privacy}","received_events_url":"https://api.github.com/users/sinpai/received_events","type":"User","site_admin":false},"body":"In my case, there is a redirect to a login page, which will give 302 http status. I've implemented test using native `expect(response).to redirect_to(new_user_session_path)` handler for such a case.","created_at":"2018-03-04T10:02:52Z","updated_at":"2018-03-04T10:02:52Z","html_url":"https://github.com/sinpai/datarockets-finance-app/pull/3#discussion_r172043209","pull_request_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/comments/172043209"},"html":{"href":"https://github.com/sinpai/datarockets-finance-app/pull/3#discussion_r172043209"},"pull_request":{"href":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/3"}},"in_reply_to_id":171559324},"pull_request":{"url":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/3","id":171596096,"html_url":"https://github.com/sinpai/datarockets-finance-app/pull/3","diff_url":"https://github.com/sinpai/datarockets-finance-app/pull/3.diff","patch_url":"https://github.com/sinpai/datarockets-finance-app/pull/3.patch","issue_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/issues/3","number":3,"state":"open","locked":false,"title":"Module 2 - Redirection to login and smtp configurations","user":{"login":"sinpai","id":4716237,"avatar_url":"https://avatars3.githubusercontent.com/u/4716237?v=4","gravatar_id":"","url":"https://api.github.com/users/sinpai","html_url":"https://github.com/sinpai","followers_url":"https://api.github.com/users/sinpai/followers","following_url":"https://api.github.com/users/sinpai/following{/other_user}","gists_url":"https://api.github.com/users/sinpai/gists{/gist_id}","starred_url":"https://api.github.com/users/sinpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinpai/subscriptions","organizations_url":"https://api.github.com/users/sinpai/orgs","repos_url":"https://api.github.com/users/sinpai/repos","events_url":"https://api.github.com/users/sinpai/events{/privacy}","received_events_url":"https://api.github.com/users/sinpai/received_events","type":"User","site_admin":false},"body":"Things has been done in this PR:\r\n* Smtp server has been configured for production environment\r\n* Letter_opener catches emails on development environment\r\n* Redirect has been added to login page if user isn't authorized\r\n* Link to herokuapp has been added in README","created_at":"2018-02-27T08:45:18Z","updated_at":"2018-03-04T10:02:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac6150b00d17e4b084aa730e194ead92055ba38a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":855393441,"url":"https://api.github.com/repos/sinpai/datarockets-finance-app/labels/Module%202","name":"Module 2","color":"39B5D8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/3/commits","review_comments_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/3/comments","review_comment_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/issues/3/comments","statuses_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/statuses/a2b99874e6a468a30d4e3692952dda8b5f70801f","head":{"label":"sinpai:module-2/redirections-and-smtp","ref":"module-2/redirections-and-smtp","sha":"a2b99874e6a468a30d4e3692952dda8b5f70801f","user":{"login":"sinpai","id":4716237,"avatar_url":"https://avatars3.githubusercontent.com/u/4716237?v=4","gravatar_id":"","url":"https://api.github.com/users/sinpai","html_url":"https://github.com/sinpai","followers_url":"https://api.github.com/users/sinpai/followers","following_url":"https://api.github.com/users/sinpai/following{/other_user}","gists_url":"https://api.github.com/users/sinpai/gists{/gist_id}","starred_url":"https://api.github.com/users/sinpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinpai/subscriptions","organizations_url":"https://api.github.com/users/sinpai/orgs","repos_url":"https://api.github.com/users/sinpai/repos","events_url":"https://api.github.com/users/sinpai/events{/privacy}","received_events_url":"https://api.github.com/users/sinpai/received_events","type":"User","site_admin":false},"repo":{"id":122171597,"name":"datarockets-finance-app","full_name":"sinpai/datarockets-finance-app","owner":{"login":"sinpai","id":4716237,"avatar_url":"https://avatars3.githubusercontent.com/u/4716237?v=4","gravatar_id":"","url":"https://api.github.com/users/sinpai","html_url":"https://github.com/sinpai","followers_url":"https://api.github.com/users/sinpai/followers","following_url":"https://api.github.com/users/sinpai/following{/other_user}","gists_url":"https://api.github.com/users/sinpai/gists{/gist_id}","starred_url":"https://api.github.com/users/sinpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinpai/subscriptions","organizations_url":"https://api.github.com/users/sinpai/orgs","repos_url":"https://api.github.com/users/sinpai/repos","events_url":"https://api.github.com/users/sinpai/events{/privacy}","received_events_url":"https://api.github.com/users/sinpai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sinpai/datarockets-finance-app","description":null,"fork":false,"url":"https://api.github.com/repos/sinpai/datarockets-finance-app","forks_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/forks","keys_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/teams","hooks_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/hooks","issue_events_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/issues/events{/number}","events_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/events","assignees_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/assignees{/user}","branches_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/branches{/branch}","tags_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/tags","blobs_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/statuses/{sha}","languages_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/languages","stargazers_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/stargazers","contributors_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/contributors","subscribers_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/subscribers","subscription_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/subscription","commits_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/contents/{+path}","compare_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/merges","archive_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/downloads","issues_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/issues{/number}","pulls_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls{/number}","milestones_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/milestones{/number}","notifications_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/labels{/name}","releases_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/releases{/id}","deployments_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/deployments","created_at":"2018-02-20T08:20:04Z","updated_at":"2018-02-20T08:21:17Z","pushed_at":"2018-03-04T09:10:40Z","git_url":"git://github.com/sinpai/datarockets-finance-app.git","ssh_url":"git@github.com:sinpai/datarockets-finance-app.git","clone_url":"https://github.com/sinpai/datarockets-finance-app.git","svn_url":"https://github.com/sinpai/datarockets-finance-app","homepage":null,"size":261,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"sinpai:module-2/devise-install","ref":"module-2/devise-install","sha":"6239c1df211449b1eecd69d07f8bbbb2a9dadcdf","user":{"login":"sinpai","id":4716237,"avatar_url":"https://avatars3.githubusercontent.com/u/4716237?v=4","gravatar_id":"","url":"https://api.github.com/users/sinpai","html_url":"https://github.com/sinpai","followers_url":"https://api.github.com/users/sinpai/followers","following_url":"https://api.github.com/users/sinpai/following{/other_user}","gists_url":"https://api.github.com/users/sinpai/gists{/gist_id}","starred_url":"https://api.github.com/users/sinpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinpai/subscriptions","organizations_url":"https://api.github.com/users/sinpai/orgs","repos_url":"https://api.github.com/users/sinpai/repos","events_url":"https://api.github.com/users/sinpai/events{/privacy}","received_events_url":"https://api.github.com/users/sinpai/received_events","type":"User","site_admin":false},"repo":{"id":122171597,"name":"datarockets-finance-app","full_name":"sinpai/datarockets-finance-app","owner":{"login":"sinpai","id":4716237,"avatar_url":"https://avatars3.githubusercontent.com/u/4716237?v=4","gravatar_id":"","url":"https://api.github.com/users/sinpai","html_url":"https://github.com/sinpai","followers_url":"https://api.github.com/users/sinpai/followers","following_url":"https://api.github.com/users/sinpai/following{/other_user}","gists_url":"https://api.github.com/users/sinpai/gists{/gist_id}","starred_url":"https://api.github.com/users/sinpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinpai/subscriptions","organizations_url":"https://api.github.com/users/sinpai/orgs","repos_url":"https://api.github.com/users/sinpai/repos","events_url":"https://api.github.com/users/sinpai/events{/privacy}","received_events_url":"https://api.github.com/users/sinpai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sinpai/datarockets-finance-app","description":null,"fork":false,"url":"https://api.github.com/repos/sinpai/datarockets-finance-app","forks_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/forks","keys_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/teams","hooks_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/hooks","issue_events_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/issues/events{/number}","events_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/events","assignees_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/assignees{/user}","branches_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/branches{/branch}","tags_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/tags","blobs_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/statuses/{sha}","languages_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/languages","stargazers_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/stargazers","contributors_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/contributors","subscribers_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/subscribers","subscription_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/subscription","commits_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/contents/{+path}","compare_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/merges","archive_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/downloads","issues_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/issues{/number}","pulls_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls{/number}","milestones_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/milestones{/number}","notifications_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/labels{/name}","releases_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/releases{/id}","deployments_url":"https://api.github.com/repos/sinpai/datarockets-finance-app/deployments","created_at":"2018-02-20T08:20:04Z","updated_at":"2018-02-20T08:21:17Z","pushed_at":"2018-03-04T09:10:40Z","git_url":"git://github.com/sinpai/datarockets-finance-app.git","ssh_url":"git@github.com:sinpai/datarockets-finance-app.git","clone_url":"https://github.com/sinpai/datarockets-finance-app.git","svn_url":"https://github.com/sinpai/datarockets-finance-app","homepage":null,"size":261,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/3"},"html":{"href":"https://github.com/sinpai/datarockets-finance-app/pull/3"},"issue":{"href":"https://api.github.com/repos/sinpai/datarockets-finance-app/issues/3"},"comments":{"href":"https://api.github.com/repos/sinpai/datarockets-finance-app/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinpai/datarockets-finance-app/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/sinpai/datarockets-finance-app/statuses/a2b99874e6a468a30d4e3692952dda8b5f70801f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"sinpai"}}