{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/28459","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/28459/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/28459/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/28459/events","html_url":"https://github.com/elastic/elasticsearch/pull/28459","id":293211953,"number":28459,"title":"Search option terminate_after does not handle post_filters and aggregations correctly","user":{"login":"jimczi","id":15977469,"avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"labels":[{"id":146832564,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Search","name":":Search","color":"009800","default":false},{"id":23173,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/bug","name":"bug","color":"9e2c2c","default":true},{"id":753477051,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.3.0","name":"v6.3.0","color":"DDDDDD","default":false},{"id":484855464,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-01-31T15:58:23Z","updated_at":"2018-02-02T15:43:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/28459","html_url":"https://github.com/elastic/elasticsearch/pull/28459","diff_url":"https://github.com/elastic/elasticsearch/pull/28459.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/28459.patch"},"body":"This change fixes the handling of the `terminate_after` option when post_filters (or min_score) are used.\r\n`post_filter` should be applied before `terminate_after` in order to terminate the query when enough document are accepted by the filters.\r\nThis commit also changes the type of exception thrown by `terminate_after` in order to ensure that multi collectors (aggregations) do not try to continue the collection when enough documents have been collected.\r\n\r\nCloses #28411"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/362621495","html_url":"https://github.com/elastic/elasticsearch/pull/28459#issuecomment-362621495","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/28459","id":362621495,"user":{"login":"jimczi","id":15977469,"avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T15:43:13Z","updated_at":"2018-02-02T15:43:13Z","author_association":"CONTRIBUTOR","body":"@colings86 I added a note regarding the usage of `terminate_after` with `post_filter` and aggs. Can you take a look ?"}}
{"actor":{"display_login":"jimczi"}}