{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/241549007","pull_request_review_id":184852190,"id":241549007,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTU0OTAwNw==","diff_hunk":"@@ -966,6 +966,11 @@ Unix signals\n \n    Set *callback* as the handler for the *signum* signal.\n \n+   The callback will be invoked in the thread that runs *loop*, along with","path":"Doc/library/asyncio-eventloop.rst","position":4,"original_position":4,"commit_id":"ed6d891633dd5f8c80c236e0f8e5f3c6cdc9e3ed","original_commit_id":"ed6d891633dd5f8c80c236e0f8e5f3c6cdc9e3ed","user":{"login":"1st1","id":239003,"node_id":"MDQ6VXNlcjIzOTAwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/239003?v=4","gravatar_id":"","url":"https://api.github.com/users/1st1","html_url":"https://github.com/1st1","followers_url":"https://api.github.com/users/1st1/followers","following_url":"https://api.github.com/users/1st1/following{/other_user}","gists_url":"https://api.github.com/users/1st1/gists{/gist_id}","starred_url":"https://api.github.com/users/1st1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1st1/subscriptions","organizations_url":"https://api.github.com/users/1st1/orgs","repos_url":"https://api.github.com/users/1st1/repos","events_url":"https://api.github.com/users/1st1/events{/privacy}","received_events_url":"https://api.github.com/users/1st1/received_events","type":"User","site_admin":false},"body":"> Is the second part really true?\r\n\r\nNo.  It will probably work alright if you have just one loop.  But what if you have two?  You set up signal handlers for both of them while in the main thread, if those signals overlap then the first loop won't receive them.\r\n\r\nFrankly, the current signals support in asyncio is far from ideal.  That's why I'd like to focus the docs on what's actually proven to work correctly.","created_at":"2018-12-13T20:22:56Z","updated_at":"2018-12-13T20:22:57Z","html_url":"https://github.com/python/cpython/pull/11145#discussion_r241549007","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/11145","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/241549007"},"html":{"href":"https://github.com/python/cpython/pull/11145#discussion_r241549007"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/11145"}},"in_reply_to_id":241541650},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/11145","id":238511717,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTExNzE3","html_url":"https://github.com/python/cpython/pull/11145","diff_url":"https://github.com/python/cpython/pull/11145.diff","patch_url":"https://github.com/python/cpython/pull/11145.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/11145","number":11145,"state":"open","locked":false,"title":"bpo-35465: Document _UnixSelectorEventLoop.add_signal_handler.","user":{"login":"hniksic","id":1078190,"node_id":"MDQ6VXNlcjEwNzgxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1078190?v=4","gravatar_id":"","url":"https://api.github.com/users/hniksic","html_url":"https://github.com/hniksic","followers_url":"https://api.github.com/users/hniksic/followers","following_url":"https://api.github.com/users/hniksic/following{/other_user}","gists_url":"https://api.github.com/users/hniksic/gists{/gist_id}","starred_url":"https://api.github.com/users/hniksic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hniksic/subscriptions","organizations_url":"https://api.github.com/users/hniksic/orgs","repos_url":"https://api.github.com/users/hniksic/repos","events_url":"https://api.github.com/users/hniksic/events{/privacy}","received_events_url":"https://api.github.com/users/hniksic/received_events","type":"User","site_admin":false},"body":"\n\n<!-- issue-number: [bpo-35465](https://bugs.python.org/issue35465) -->\nhttps://bugs.python.org/issue35465\n<!-- /issue-number -->\n","created_at":"2018-12-13T19:54:16Z","updated_at":"2018-12-13T20:22:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8eba9546d8439c60fc04884dd4a831eeec26d32","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asvetlov","id":356399,"node_id":"MDQ6VXNlcjM1NjM5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/356399?v=4","gravatar_id":"","url":"https://api.github.com/users/asvetlov","html_url":"https://github.com/asvetlov","followers_url":"https://api.github.com/users/asvetlov/followers","following_url":"https://api.github.com/users/asvetlov/following{/other_user}","gists_url":"https://api.github.com/users/asvetlov/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlov/subscriptions","organizations_url":"https://api.github.com/users/asvetlov/orgs","repos_url":"https://api.github.com/users/asvetlov/repos","events_url":"https://api.github.com/users/asvetlov/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":536945571,"node_id":"MDU6TGFiZWw1MzY5NDU1NzE=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20not%20signed","name":"CLA not signed","color":"b60205","default":false},{"id":666979922,"node_id":"MDU6TGFiZWw2NjY5Nzk5MjI=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20changes","name":"awaiting changes","color":"fbca04","default":false},{"id":538516109,"node_id":"MDU6TGFiZWw1Mzg1MTYxMDk=","url":"https://api.github.com/repos/python/cpython/labels/type-documentation","name":"type-documentation","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/11145/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/11145/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/11145/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/ed6d891633dd5f8c80c236e0f8e5f3c6cdc9e3ed","head":{"label":"hniksic:bpo-35465","ref":"bpo-35465","sha":"ed6d891633dd5f8c80c236e0f8e5f3c6cdc9e3ed","user":{"login":"hniksic","id":1078190,"node_id":"MDQ6VXNlcjEwNzgxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1078190?v=4","gravatar_id":"","url":"https://api.github.com/users/hniksic","html_url":"https://github.com/hniksic","followers_url":"https://api.github.com/users/hniksic/followers","following_url":"https://api.github.com/users/hniksic/following{/other_user}","gists_url":"https://api.github.com/users/hniksic/gists{/gist_id}","starred_url":"https://api.github.com/users/hniksic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hniksic/subscriptions","organizations_url":"https://api.github.com/users/hniksic/orgs","repos_url":"https://api.github.com/users/hniksic/repos","events_url":"https://api.github.com/users/hniksic/events{/privacy}","received_events_url":"https://api.github.com/users/hniksic/received_events","type":"User","site_admin":false},"repo":{"id":161687115,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE2ODcxMTU=","name":"cpython","full_name":"hniksic/cpython","private":false,"owner":{"login":"hniksic","id":1078190,"node_id":"MDQ6VXNlcjEwNzgxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1078190?v=4","gravatar_id":"","url":"https://api.github.com/users/hniksic","html_url":"https://github.com/hniksic","followers_url":"https://api.github.com/users/hniksic/followers","following_url":"https://api.github.com/users/hniksic/following{/other_user}","gists_url":"https://api.github.com/users/hniksic/gists{/gist_id}","starred_url":"https://api.github.com/users/hniksic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hniksic/subscriptions","organizations_url":"https://api.github.com/users/hniksic/orgs","repos_url":"https://api.github.com/users/hniksic/repos","events_url":"https://api.github.com/users/hniksic/events{/privacy}","received_events_url":"https://api.github.com/users/hniksic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hniksic/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/hniksic/cpython","forks_url":"https://api.github.com/repos/hniksic/cpython/forks","keys_url":"https://api.github.com/repos/hniksic/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hniksic/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hniksic/cpython/teams","hooks_url":"https://api.github.com/repos/hniksic/cpython/hooks","issue_events_url":"https://api.github.com/repos/hniksic/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/hniksic/cpython/events","assignees_url":"https://api.github.com/repos/hniksic/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/hniksic/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/hniksic/cpython/tags","blobs_url":"https://api.github.com/repos/hniksic/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hniksic/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hniksic/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/hniksic/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hniksic/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/hniksic/cpython/languages","stargazers_url":"https://api.github.com/repos/hniksic/cpython/stargazers","contributors_url":"https://api.github.com/repos/hniksic/cpython/contributors","subscribers_url":"https://api.github.com/repos/hniksic/cpython/subscribers","subscription_url":"https://api.github.com/repos/hniksic/cpython/subscription","commits_url":"https://api.github.com/repos/hniksic/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/hniksic/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/hniksic/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/hniksic/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/hniksic/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/hniksic/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hniksic/cpython/merges","archive_url":"https://api.github.com/repos/hniksic/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hniksic/cpython/downloads","issues_url":"https://api.github.com/repos/hniksic/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/hniksic/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/hniksic/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/hniksic/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hniksic/cpython/labels{/name}","releases_url":"https://api.github.com/repos/hniksic/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/hniksic/cpython/deployments","created_at":"2018-12-13T19:44:02Z","updated_at":"2018-12-13T19:44:29Z","pushed_at":"2018-12-13T19:53:13Z","git_url":"git://github.com/hniksic/cpython.git","ssh_url":"git@github.com:hniksic/cpython.git","clone_url":"https://github.com/hniksic/cpython.git","svn_url":"https://github.com/hniksic/cpython","homepage":"https://www.python.org/","size":261925,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"08c2ba0717089662132af69bf5948d82277a8a69","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU5ODk2MQ==","name":"cpython","full_name":"python/cpython","private":false,"owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-12-13T19:47:54Z","pushed_at":"2018-12-13T19:54:17Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":261925,"stargazers_count":21358,"watchers_count":21358,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7951,"mirror_url":null,"archived":false,"open_issues_count":964,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7951,"open_issues":964,"watchers":21358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/11145"},"html":{"href":"https://github.com/python/cpython/pull/11145"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/11145"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/11145/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/11145/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/11145/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/ed6d891633dd5f8c80c236e0f8e5f3c6cdc9e3ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"1st1"}}