{"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/182156498","pull_request_review_id":112907151,"id":182156498,"diff_hunk":"@@ -417,7 +420,7 @@\n                  note: {noteable_id: assignment.id,\n                         notes_message: @message}}\n         expect(assigns :note).not_to be_nil\n-        expect(flash[:success]).to eq [I18n.t('notes.create.success')]\n+        expect(flash[:success].map { |f| extract_text f }).to eq [I18n.t('notes.create.success')].map { |f| extract_text f }","path":"spec/controllers/notes_controller_spec.rb","position":23,"original_position":89,"commit_id":"8fa34bc1547350d7e94875f7bbc4ce36696c3b4f","original_commit_id":"8fa34bc1547350d7e94875f7bbc4ce36696c3b4f","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Lint/AmbiguousBlockAssociation: Parenthesize the param [I18n.t('notes.create.success')].map { |f| extract_text f } to make sure that the block will be associated with the [I18n.t('notes.create.success')].map method call.<br>Metrics/LineLength: Line is too long. [124/120]","created_at":"2018-04-17T17:04:26Z","updated_at":"2018-04-17T17:04:27Z","html_url":"https://github.com/MarkUsProject/Markus/pull/3337#discussion_r182156498","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3337","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/182156498"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/3337#discussion_r182156498"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3337"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3337","id":181604410,"html_url":"https://github.com/MarkUsProject/Markus/pull/3337","diff_url":"https://github.com/MarkUsProject/Markus/pull/3337.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/3337.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/3337","number":3337,"state":"open","locked":false,"title":"Empty file upload warning and flash_message rewrite","user":{"login":"mishaschwartz","id":4380924,"avatar_url":"https://avatars2.githubusercontent.com/u/4380924?v=4","gravatar_id":"","url":"https://api.github.com/users/mishaschwartz","html_url":"https://github.com/mishaschwartz","followers_url":"https://api.github.com/users/mishaschwartz/followers","following_url":"https://api.github.com/users/mishaschwartz/following{/other_user}","gists_url":"https://api.github.com/users/mishaschwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/mishaschwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishaschwartz/subscriptions","organizations_url":"https://api.github.com/users/mishaschwartz/orgs","repos_url":"https://api.github.com/users/mishaschwartz/repos","events_url":"https://api.github.com/users/mishaschwartz/events{/privacy}","received_events_url":"https://api.github.com/users/mishaschwartz/received_events","type":"User","site_admin":false},"body":"- Warn students if they upload an empty file\r\n- Update to the flash_message function so that it can render partial html pages as well as just strings. \r\n- Update to the submission_controller so that it now uses the assignment_content layout","created_at":"2018-04-13T21:54:32Z","updated_at":"2018-04-17T17:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c71f08b6cd1f02517d1279ca64607052d89973f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3337/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3337/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/3337/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/8fa34bc1547350d7e94875f7bbc4ce36696c3b4f","head":{"label":"mishaschwartz:empty-file-upload","ref":"empty-file-upload","sha":"8fa34bc1547350d7e94875f7bbc4ce36696c3b4f","user":{"login":"mishaschwartz","id":4380924,"avatar_url":"https://avatars2.githubusercontent.com/u/4380924?v=4","gravatar_id":"","url":"https://api.github.com/users/mishaschwartz","html_url":"https://github.com/mishaschwartz","followers_url":"https://api.github.com/users/mishaschwartz/followers","following_url":"https://api.github.com/users/mishaschwartz/following{/other_user}","gists_url":"https://api.github.com/users/mishaschwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/mishaschwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishaschwartz/subscriptions","organizations_url":"https://api.github.com/users/mishaschwartz/orgs","repos_url":"https://api.github.com/users/mishaschwartz/repos","events_url":"https://api.github.com/users/mishaschwartz/events{/privacy}","received_events_url":"https://api.github.com/users/mishaschwartz/received_events","type":"User","site_admin":false},"repo":{"id":120653567,"name":"Markus","full_name":"mishaschwartz/Markus","owner":{"login":"mishaschwartz","id":4380924,"avatar_url":"https://avatars2.githubusercontent.com/u/4380924?v=4","gravatar_id":"","url":"https://api.github.com/users/mishaschwartz","html_url":"https://github.com/mishaschwartz","followers_url":"https://api.github.com/users/mishaschwartz/followers","following_url":"https://api.github.com/users/mishaschwartz/following{/other_user}","gists_url":"https://api.github.com/users/mishaschwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/mishaschwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishaschwartz/subscriptions","organizations_url":"https://api.github.com/users/mishaschwartz/orgs","repos_url":"https://api.github.com/users/mishaschwartz/repos","events_url":"https://api.github.com/users/mishaschwartz/events{/privacy}","received_events_url":"https://api.github.com/users/mishaschwartz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mishaschwartz/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/mishaschwartz/Markus","forks_url":"https://api.github.com/repos/mishaschwartz/Markus/forks","keys_url":"https://api.github.com/repos/mishaschwartz/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mishaschwartz/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mishaschwartz/Markus/teams","hooks_url":"https://api.github.com/repos/mishaschwartz/Markus/hooks","issue_events_url":"https://api.github.com/repos/mishaschwartz/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/mishaschwartz/Markus/events","assignees_url":"https://api.github.com/repos/mishaschwartz/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/mishaschwartz/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/mishaschwartz/Markus/tags","blobs_url":"https://api.github.com/repos/mishaschwartz/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mishaschwartz/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mishaschwartz/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/mishaschwartz/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mishaschwartz/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/mishaschwartz/Markus/languages","stargazers_url":"https://api.github.com/repos/mishaschwartz/Markus/stargazers","contributors_url":"https://api.github.com/repos/mishaschwartz/Markus/contributors","subscribers_url":"https://api.github.com/repos/mishaschwartz/Markus/subscribers","subscription_url":"https://api.github.com/repos/mishaschwartz/Markus/subscription","commits_url":"https://api.github.com/repos/mishaschwartz/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/mishaschwartz/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/mishaschwartz/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/mishaschwartz/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/mishaschwartz/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/mishaschwartz/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mishaschwartz/Markus/merges","archive_url":"https://api.github.com/repos/mishaschwartz/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mishaschwartz/Markus/downloads","issues_url":"https://api.github.com/repos/mishaschwartz/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/mishaschwartz/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/mishaschwartz/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/mishaschwartz/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mishaschwartz/Markus/labels{/name}","releases_url":"https://api.github.com/repos/mishaschwartz/Markus/releases{/id}","deployments_url":"https://api.github.com/repos/mishaschwartz/Markus/deployments","created_at":"2018-02-07T18:22:07Z","updated_at":"2018-02-07T18:22:17Z","pushed_at":"2018-04-17T17:04:02Z","git_url":"git://github.com/mishaschwartz/Markus.git","ssh_url":"git@github.com:mishaschwartz/Markus.git","clone_url":"https://github.com/mishaschwartz/Markus.git","svn_url":"https://github.com/mishaschwartz/Markus","homepage":"http://www.markusproject.org","size":114409,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"328cceb0d0e3a5d58050fd24dc210ca10fdb401d","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars1.githubusercontent.com/u/415874?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars1.githubusercontent.com/u/415874?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","deployments_url":"https://api.github.com/repos/MarkUsProject/Markus/deployments","created_at":"2010-09-26T16:18:08Z","updated_at":"2018-04-15T22:55:19Z","pushed_at":"2018-04-17T17:04:05Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":114252,"stargazers_count":169,"watchers_count":169,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":191,"open_issues":96,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3337"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/3337"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/3337"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/3337/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3337/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/3337/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/8fa34bc1547350d7e94875f7bbc4ce36696c3b4f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}