{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/225797514","pull_request_review_id":165476051,"id":225797514,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTc5NzUxNA==","diff_hunk":"@@ -1,10 +1,12 @@\n-error[E0080]: this constant likely exhibits undefined behavior\n+error: this constant cannot be used\n   --> $DIR/ub-uninhabit.rs:18:1\n    |\n LL | const BAD_BAD_BAD: Bar = unsafe { mem::transmute(()) };\n-   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a value of an uninhabited type\n+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------^^^\n+   |                                   |\n+   |                                   entered unreachable code\n    |\n-   = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior\n+   = note: #[deny(const_err)] on by default","path":"src/test/ui/consts/const-eval/ub-uninhabit.stderr","position":12,"original_position":12,"commit_id":"7e14ffb3622848d8cd481482f943dec235afb797","original_commit_id":"7e14ffb3622848d8cd481482f943dec235afb797","user":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"body":"This is odd though -- so having a more precise analysis downgrades this from a hard error on an err-by-default lint? Cc @oli-obk ","created_at":"2018-10-17T06:50:33Z","updated_at":"2018-10-17T06:50:33Z","html_url":"https://github.com/rust-lang/rust/pull/54125#discussion_r225797514","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/54125","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/225797514"},"html":{"href":"https://github.com/rust-lang/rust/pull/54125#discussion_r225797514"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54125"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/54125","id":214609483,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NjA5NDgz","html_url":"https://github.com/rust-lang/rust/pull/54125","diff_url":"https://github.com/rust-lang/rust/pull/54125.diff","patch_url":"https://github.com/rust-lang/rust/pull/54125.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/54125","number":54125,"state":"open","locked":false,"title":"Less conservative uninhabitedness check","user":{"login":"varkor","id":3943692,"node_id":"MDQ6VXNlcjM5NDM2OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3943692?v=4","gravatar_id":"","url":"https://api.github.com/users/varkor","html_url":"https://github.com/varkor","followers_url":"https://api.github.com/users/varkor/followers","following_url":"https://api.github.com/users/varkor/following{/other_user}","gists_url":"https://api.github.com/users/varkor/gists{/gist_id}","starred_url":"https://api.github.com/users/varkor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varkor/subscriptions","organizations_url":"https://api.github.com/users/varkor/orgs","repos_url":"https://api.github.com/users/varkor/repos","events_url":"https://api.github.com/users/varkor/events{/privacy}","received_events_url":"https://api.github.com/users/varkor/received_events","type":"User","site_admin":false},"body":"Extends the uninhabitedness check to structs, non-empty enums, tuples and arrays.\r\n\r\nPulled out of #47291 and #50262.\r\n\r\nFixes https://github.com/rust-lang/rust/issues/54586.\r\n\r\nr? @nikomatsakis ","created_at":"2018-09-11T12:05:36Z","updated_at":"2018-10-17T06:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceef301fd804a7ed35a70dde4f95d5551e79c7ef","assignee":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583436937,"node_id":"MDU6TGFiZWw1ODM0MzY5Mzc=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-author","name":"S-waiting-on-author","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/54125/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/54125/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/54125/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/7e14ffb3622848d8cd481482f943dec235afb797","head":{"label":"varkor:less-conservative-uninhabitedness-check","ref":"less-conservative-uninhabitedness-check","sha":"7e14ffb3622848d8cd481482f943dec235afb797","user":{"login":"varkor","id":3943692,"node_id":"MDQ6VXNlcjM5NDM2OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3943692?v=4","gravatar_id":"","url":"https://api.github.com/users/varkor","html_url":"https://github.com/varkor","followers_url":"https://api.github.com/users/varkor/followers","following_url":"https://api.github.com/users/varkor/following{/other_user}","gists_url":"https://api.github.com/users/varkor/gists{/gist_id}","starred_url":"https://api.github.com/users/varkor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varkor/subscriptions","organizations_url":"https://api.github.com/users/varkor/orgs","repos_url":"https://api.github.com/users/varkor/repos","events_url":"https://api.github.com/users/varkor/events{/privacy}","received_events_url":"https://api.github.com/users/varkor/received_events","type":"User","site_admin":false},"repo":{"id":106295063,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYyOTUwNjM=","name":"rust","full_name":"varkor/rust","private":false,"owner":{"login":"varkor","id":3943692,"node_id":"MDQ6VXNlcjM5NDM2OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3943692?v=4","gravatar_id":"","url":"https://api.github.com/users/varkor","html_url":"https://github.com/varkor","followers_url":"https://api.github.com/users/varkor/followers","following_url":"https://api.github.com/users/varkor/following{/other_user}","gists_url":"https://api.github.com/users/varkor/gists{/gist_id}","starred_url":"https://api.github.com/users/varkor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varkor/subscriptions","organizations_url":"https://api.github.com/users/varkor/orgs","repos_url":"https://api.github.com/users/varkor/repos","events_url":"https://api.github.com/users/varkor/events{/privacy}","received_events_url":"https://api.github.com/users/varkor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/varkor/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/varkor/rust","forks_url":"https://api.github.com/repos/varkor/rust/forks","keys_url":"https://api.github.com/repos/varkor/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/varkor/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/varkor/rust/teams","hooks_url":"https://api.github.com/repos/varkor/rust/hooks","issue_events_url":"https://api.github.com/repos/varkor/rust/issues/events{/number}","events_url":"https://api.github.com/repos/varkor/rust/events","assignees_url":"https://api.github.com/repos/varkor/rust/assignees{/user}","branches_url":"https://api.github.com/repos/varkor/rust/branches{/branch}","tags_url":"https://api.github.com/repos/varkor/rust/tags","blobs_url":"https://api.github.com/repos/varkor/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/varkor/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/varkor/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/varkor/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/varkor/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/varkor/rust/languages","stargazers_url":"https://api.github.com/repos/varkor/rust/stargazers","contributors_url":"https://api.github.com/repos/varkor/rust/contributors","subscribers_url":"https://api.github.com/repos/varkor/rust/subscribers","subscription_url":"https://api.github.com/repos/varkor/rust/subscription","commits_url":"https://api.github.com/repos/varkor/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/varkor/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/varkor/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/varkor/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/varkor/rust/contents/{+path}","compare_url":"https://api.github.com/repos/varkor/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/varkor/rust/merges","archive_url":"https://api.github.com/repos/varkor/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/varkor/rust/downloads","issues_url":"https://api.github.com/repos/varkor/rust/issues{/number}","pulls_url":"https://api.github.com/repos/varkor/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/varkor/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/varkor/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/varkor/rust/labels{/name}","releases_url":"https://api.github.com/repos/varkor/rust/releases{/id}","deployments_url":"https://api.github.com/repos/varkor/rust/deployments","created_at":"2017-10-09T14:34:36Z","updated_at":"2018-10-16T13:56:19Z","pushed_at":"2018-10-16T22:49:02Z","git_url":"git://github.com/varkor/rust.git","ssh_url":"git@github.com:varkor/rust.git","clone_url":"https://github.com/varkor/rust.git","svn_url":"https://github.com/varkor/rust","homepage":"https://www.rust-lang.org","size":398117,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"8a7048b72b7e9499dfae3f946baa92fc9e62a6b8","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-10-17T05:49:35Z","pushed_at":"2018-10-17T06:42:23Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":398197,"stargazers_count":31176,"watchers_count":31176,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5236,"mirror_url":null,"archived":false,"open_issues_count":4467,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5236,"open_issues":4467,"watchers":31176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54125"},"html":{"href":"https://github.com/rust-lang/rust/pull/54125"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/54125"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/54125/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54125/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54125/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/7e14ffb3622848d8cd481482f943dec235afb797"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RalfJung"}}