{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/56595","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/56595/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/56595/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/56595/events","html_url":"https://github.com/rust-lang/rust/pull/56595","id":388684213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODkxMTIz","number":56595,"title":"[WIP] Add clippy and fix commands to x.py","user":{"login":"ljedrz","id":3750347,"node_id":"MDQ6VXNlcjM3NTAzNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3750347?v=4","gravatar_id":"","url":"https://api.github.com/users/ljedrz","html_url":"https://github.com/ljedrz","followers_url":"https://api.github.com/users/ljedrz/followers","following_url":"https://api.github.com/users/ljedrz/following{/other_user}","gists_url":"https://api.github.com/users/ljedrz/gists{/gist_id}","starred_url":"https://api.github.com/users/ljedrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljedrz/subscriptions","organizations_url":"https://api.github.com/users/ljedrz/orgs","repos_url":"https://api.github.com/users/ljedrz/repos","events_url":"https://api.github.com/users/ljedrz/events{/privacy}","received_events_url":"https://api.github.com/users/ljedrz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-12-07T14:48:22Z","updated_at":"2018-12-07T14:48:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/56595","html_url":"https://github.com/rust-lang/rust/pull/56595","diff_url":"https://github.com/rust-lang/rust/pull/56595.diff","patch_url":"https://github.com/rust-lang/rust/pull/56595.patch"},"body":"Since they are kind of similar in nature, I have used the same approach as for `cargo check`. At least some of the boilerplate could probably be shared, but I'd prefer to gather some feedback before I decide to merge them more aggressively.\r\n\r\nThis works reasonably well for `clippy`; with `-A clippy::all` and some extra `#![feature(rustc_private)]`s almost the whole codebase can be processed. There are some concerns, though:\r\n- unlike `check`, in order to be able to traverse all the crates, some of them need to be marked with the `#![feature(rustc_private)]` attribute\r\n- `-W clippy::all` breaks on any error. Is there a way to produce errors but not have them break the progress?\r\n- I'm not sure how to redirect the errors in a way that would show colors; for now I was able to de-jsonize and print them (something not needed for `check`)\r\n\r\n`cargo fix` is much more stubborn; it refuses to acknowledge crates like `core` and `std`, so it doesn't progress much at all.\r\n\r\nSince this is a bit more tricky than I have envisioned, I need some guidance:\r\n- is this the right approach or am I doing something very wrong ^^?\r\n- why are the extra `rustc_private` features necessary? I was hoping for the same treatment as `check`\r\n- are changes in `clippy` and `cargo fix` needed e.g. in order to produce errors in the same manner as `check` or did I miss something?\r\n- do we need this level of file granularity (e.g. for futureproofing) or can `check`, `clippy` and `fix` files be condensed?\r\n\r\nCc @alexcrichton, @zackmdavis "},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/445254697","html_url":"https://github.com/rust-lang/rust/pull/56595#issuecomment-445254697","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/56595","id":445254697,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTI1NDY5Nw==","user":{"login":"rust-highfive","id":7378925,"node_id":"MDQ6VXNlcjczNzg5MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7378925?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-highfive","html_url":"https://github.com/rust-highfive","followers_url":"https://api.github.com/users/rust-highfive/followers","following_url":"https://api.github.com/users/rust-highfive/following{/other_user}","gists_url":"https://api.github.com/users/rust-highfive/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-highfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-highfive/subscriptions","organizations_url":"https://api.github.com/users/rust-highfive/orgs","repos_url":"https://api.github.com/users/rust-highfive/repos","events_url":"https://api.github.com/users/rust-highfive/events{/privacy}","received_events_url":"https://api.github.com/users/rust-highfive/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T14:48:33Z","updated_at":"2018-12-07T14:48:33Z","author_association":"COLLABORATOR","body":"r? @nikomatsakis\n\n(rust_highfive has picked a reviewer for you, use r? to override)"}}
{"actor":{"display_login":"rust-highfive"}}