{"action":"closed","issue":{"url":"https://api.github.com/repos/weechat/weechat/issues/1145","repository_url":"https://api.github.com/repos/weechat/weechat","labels_url":"https://api.github.com/repos/weechat/weechat/issues/1145/labels{/name}","comments_url":"https://api.github.com/repos/weechat/weechat/issues/1145/comments","events_url":"https://api.github.com/repos/weechat/weechat/issues/1145/events","html_url":"https://github.com/weechat/weechat/issues/1145","id":295699104,"number":1145,"title":"Make logger fsync log files when flushing","user":{"login":"autrilla","id":2260567,"avatar_url":"https://avatars3.githubusercontent.com/u/2260567?v=4","gravatar_id":"","url":"https://api.github.com/users/autrilla","html_url":"https://github.com/autrilla","followers_url":"https://api.github.com/users/autrilla/followers","following_url":"https://api.github.com/users/autrilla/following{/other_user}","gists_url":"https://api.github.com/users/autrilla/gists{/gist_id}","starred_url":"https://api.github.com/users/autrilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autrilla/subscriptions","organizations_url":"https://api.github.com/users/autrilla/orgs","repos_url":"https://api.github.com/users/autrilla/repos","events_url":"https://api.github.com/users/autrilla/events{/privacy}","received_events_url":"https://api.github.com/users/autrilla/received_events","type":"User","site_admin":false},"labels":[{"id":83724885,"url":"https://api.github.com/repos/weechat/weechat/labels/enhancement","name":"enhancement","color":"409de5","default":true},{"id":293527374,"url":"https://api.github.com/repos/weechat/weechat/labels/in%20progress","name":"in progress","color":"efc6c6","default":false}],"state":"closed","locked":false,"assignee":{"login":"flashcode","id":1776783,"avatar_url":"https://avatars3.githubusercontent.com/u/1776783?v=4","gravatar_id":"","url":"https://api.github.com/users/flashcode","html_url":"https://github.com/flashcode","followers_url":"https://api.github.com/users/flashcode/followers","following_url":"https://api.github.com/users/flashcode/following{/other_user}","gists_url":"https://api.github.com/users/flashcode/gists{/gist_id}","starred_url":"https://api.github.com/users/flashcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flashcode/subscriptions","organizations_url":"https://api.github.com/users/flashcode/orgs","repos_url":"https://api.github.com/users/flashcode/repos","events_url":"https://api.github.com/users/flashcode/events{/privacy}","received_events_url":"https://api.github.com/users/flashcode/received_events","type":"User","site_admin":false},"assignees":[{"login":"flashcode","id":1776783,"avatar_url":"https://avatars3.githubusercontent.com/u/1776783?v=4","gravatar_id":"","url":"https://api.github.com/users/flashcode","html_url":"https://github.com/flashcode","followers_url":"https://api.github.com/users/flashcode/followers","following_url":"https://api.github.com/users/flashcode/following{/other_user}","gists_url":"https://api.github.com/users/flashcode/gists{/gist_id}","starred_url":"https://api.github.com/users/flashcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flashcode/subscriptions","organizations_url":"https://api.github.com/users/flashcode/orgs","repos_url":"https://api.github.com/users/flashcode/repos","events_url":"https://api.github.com/users/flashcode/events{/privacy}","received_events_url":"https://api.github.com/users/flashcode/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-02-08T23:11:55Z","updated_at":"2018-02-10T07:24:25Z","closed_at":"2018-02-10T07:24:25Z","author_association":"NONE","body":"Currently weechat calls fflush (https://github.com/weechat/weechat/blob/master/src/plugins/logger/logger.c#L608 and https://github.com/weechat/weechat/blob/master/src/plugins/logger/logger.c#L846) when flushing the log files. However, this can cause the files to never end up on disk (or whatever storage medium). In my particular case, I've tried to set up `gcsfuse` to store all my weechat configuration and logs on Google Cloud Storage, and the files are not transferred to GCS until either weechat is closed (and therefore so are the log files) or I manually run sync or fsync. It would be nice for the log files to be synced to the underlying physical storage whenever the logger flush timer runs. Would this change be acceptable?\r\n\r\nI'm not sure whether this should be considered a bug or a feature request."}}
{"actor":{"display_login":"flashcode"}}