{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-vm/pulls/comments/232621804","pull_request_review_id":173853862,"id":232621804,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjYyMTgwNA==","diff_hunk":"@@ -402,51 +378,24 @@ def LXCDialog\n       common_vm_packages = []\n \n       result = true\n-      if isOpenSuse == true\n-        if install_vm == true\n-          common_vm_packages = [\"libvirt-client\", \"vm-install\", \"virt-install\"]\n-        end\n-\n-        packages = [\"patterns-server-xen_server\"] if install_xen_server\n-        if isTumbleweed\n-          packages = packages + [\"xen-tools\", \"xen-libs\", \"libvirt-daemon-xen\", \"libvirt-daemon-config-network\", \"tigervnc\", \"virt-manager\"] if install_xen_tools\n-        else\n-          packages = [\"patterns-server-xen_tools\"] if install_xen_tools\n-        end\n-\n-        packages = packages + [\"patterns-server-kvm_server\"] if install_kvm_server\n-        if isTumbleweed\n-          packages = packages + [\"libvirt-daemon-qemu\", \"libvirt-daemon-config-network\", \"tigervnc\", \"virt-manager\"] if install_kvm_tools\n-        else\n-          packages = [\"patterns-server-kvm_tools\"] if install_kvm_tools\n-        end\n-        packages = packages + [\"libvirt-daemon-lxc\", \"libvirt-daemon-config-network\"] if install_lxc\n-        result = Package.DoInstall(common_vm_packages + packages)\n+      if install_lxc\n+        packages = [\"libvirt-daemon-lxc\", \"libvirt-daemon-config-network\"]\n+        result = Package.DoInstall(packages)\n         if result == false\n-          Report.Error(_(\"Package installation failed\\n\"))\n+          Report.Error(_(\"Package installation failed for lxc\\n\"))\n           return false\n         end\n-      else\n-        if install_lxc\n-          packages = [\"libvirt-daemon-lxc\", \"libvirt-daemon-config-network\"]\n-          result = Package.DoInstall(packages)\n-          if result == false\n-            Report.Error(_(\"Package installation failed for lxc\\n\"))\n-            return false\n-          end\n-        end\n-        if isSLES\n-          packages = packages + [\"patterns-server-xen_server\"] if install_xen_server\n-          packages = packages + [\"patterns-server-xen_tools\"] if install_xen_tools\n-          packages = packages + [\"patterns-server-kvm_server\"] if install_kvm_server\n-          packages = packages + [\"patterns-server-kvm_tools\"] if install_kvm_tools\n-          packages = installGUIComponents(packages)\n-          result = Package.DoInstall(packages)\n-          if result == false\n-            Report.Error(_(\"Package installation failed for sles patterns\\n\"))\n-            return false\n-          end\n-        end\n+      end\n+\n+      packages = packages + [\"patterns-server-xen_server\"] if install_xen_server\n+      packages = packages + [\"patterns-server-xen_tools\"] if install_xen_tools\n+      packages = packages + [\"patterns-server-kvm_server\"] if install_kvm_server\n+      packages = packages + [\"patterns-server-kvm_tools\"] if install_kvm_tools\n+      packages = installGUIComponents(packages)\n+      result = Package.DoInstall(packages)\n+      if result == false","path":"src/modules/VirtConfig.rb","position":101,"original_position":101,"commit_id":"2a5a33dcd5b998cf86fd95971abd3695adef8f17","original_commit_id":"2a5a33dcd5b998cf86fd95971abd3695adef8f17","user":{"login":"lslezak","id":907998,"node_id":"MDQ6VXNlcjkwNzk5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/907998?v=4","gravatar_id":"","url":"https://api.github.com/users/lslezak","html_url":"https://github.com/lslezak","followers_url":"https://api.github.com/users/lslezak/followers","following_url":"https://api.github.com/users/lslezak/following{/other_user}","gists_url":"https://api.github.com/users/lslezak/gists{/gist_id}","starred_url":"https://api.github.com/users/lslezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lslezak/subscriptions","organizations_url":"https://api.github.com/users/lslezak/orgs","repos_url":"https://api.github.com/users/lslezak/repos","events_url":"https://api.github.com/users/lslezak/events{/privacy}","received_events_url":"https://api.github.com/users/lslezak/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n      unless result\r\n```","created_at":"2018-11-12T11:23:47Z","updated_at":"2018-11-12T11:35:24Z","html_url":"https://github.com/yast/yast-vm/pull/36#discussion_r232621804","pull_request_url":"https://api.github.com/repos/yast/yast-vm/pulls/36","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-vm/pulls/comments/232621804"},"html":{"href":"https://github.com/yast/yast-vm/pull/36#discussion_r232621804"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-vm/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-vm/pulls/36","id":227376474,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Mzc2NDc0","html_url":"https://github.com/yast/yast-vm/pull/36","diff_url":"https://github.com/yast/yast-vm/pull/36.diff","patch_url":"https://github.com/yast/yast-vm/pull/36.patch","issue_url":"https://api.github.com/repos/yast/yast-vm/issues/36","number":36,"state":"open","locked":false,"title":"bsc#1109832 - libvirt-daemon-config-network not installed by yast","user":{"login":"charlesa","id":1752521,"node_id":"MDQ6VXNlcjE3NTI1MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1752521?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesa","html_url":"https://github.com/charlesa","followers_url":"https://api.github.com/users/charlesa/followers","following_url":"https://api.github.com/users/charlesa/following{/other_user}","gists_url":"https://api.github.com/users/charlesa/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesa/subscriptions","organizations_url":"https://api.github.com/users/charlesa/orgs","repos_url":"https://api.github.com/users/charlesa/repos","events_url":"https://api.github.com/users/charlesa/events{/privacy}","received_events_url":"https://api.github.com/users/charlesa/received_events","type":"User","site_admin":false},"body":"vm. Tumbleweed is now getting the '_tools' patterns for xen and\r\nkvm that are already found on SLE. This allows the removal of\r\nsome openSUSE and Tumbleweed conditional code.","created_at":"2018-10-31T17:26:00Z","updated_at":"2018-11-12T11:35:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dab77dc35a38df8bdf6478a2219936b7fa047276","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jreidinger","id":478871,"node_id":"MDQ6VXNlcjQ3ODg3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/478871?v=4","gravatar_id":"","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},{"login":"schubi2","id":909986,"node_id":"MDQ6VXNlcjkwOTk4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/909986?v=4","gravatar_id":"","url":"https://api.github.com/users/schubi2","html_url":"https://github.com/schubi2","followers_url":"https://api.github.com/users/schubi2/followers","following_url":"https://api.github.com/users/schubi2/following{/other_user}","gists_url":"https://api.github.com/users/schubi2/gists{/gist_id}","starred_url":"https://api.github.com/users/schubi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schubi2/subscriptions","organizations_url":"https://api.github.com/users/schubi2/orgs","repos_url":"https://api.github.com/users/schubi2/repos","events_url":"https://api.github.com/users/schubi2/events{/privacy}","received_events_url":"https://api.github.com/users/schubi2/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-vm/pulls/36/commits","review_comments_url":"https://api.github.com/repos/yast/yast-vm/pulls/36/comments","review_comment_url":"https://api.github.com/repos/yast/yast-vm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-vm/issues/36/comments","statuses_url":"https://api.github.com/repos/yast/yast-vm/statuses/2a5a33dcd5b998cf86fd95971abd3695adef8f17","head":{"label":"yast:bsc#1109832","ref":"bsc#1109832","sha":"2a5a33dcd5b998cf86fd95971abd3695adef8f17","user":{"login":"yast","id":909990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwOTk5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368239,"node_id":"MDEwOlJlcG9zaXRvcnk0MzY4MjM5","name":"yast-vm","full_name":"yast/yast-vm","private":false,"owner":{"login":"yast","id":909990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwOTk5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yast/yast-vm","description":"YaST module vm","fork":false,"url":"https://api.github.com/repos/yast/yast-vm","forks_url":"https://api.github.com/repos/yast/yast-vm/forks","keys_url":"https://api.github.com/repos/yast/yast-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-vm/teams","hooks_url":"https://api.github.com/repos/yast/yast-vm/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-vm/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-vm/events","assignees_url":"https://api.github.com/repos/yast/yast-vm/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-vm/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-vm/tags","blobs_url":"https://api.github.com/repos/yast/yast-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-vm/languages","stargazers_url":"https://api.github.com/repos/yast/yast-vm/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-vm/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-vm/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-vm/subscription","commits_url":"https://api.github.com/repos/yast/yast-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-vm/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-vm/merges","archive_url":"https://api.github.com/repos/yast/yast-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-vm/downloads","issues_url":"https://api.github.com/repos/yast/yast-vm/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-vm/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-vm/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-vm/deployments","created_at":"2012-05-18T10:27:12Z","updated_at":"2018-08-22T08:04:06Z","pushed_at":"2018-10-31T17:26:01Z","git_url":"git://github.com/yast/yast-vm.git","ssh_url":"git@github.com:yast/yast-vm.git","clone_url":"https://github.com/yast/yast-vm.git","svn_url":"https://github.com/yast/yast-vm","homepage":"http://en.opensuse.org/Portal:YaST","size":872,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":8,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"4899dd216c9eeb5b56ffe239a0bb6a76d4269647","user":{"login":"yast","id":909990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwOTk5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368239,"node_id":"MDEwOlJlcG9zaXRvcnk0MzY4MjM5","name":"yast-vm","full_name":"yast/yast-vm","private":false,"owner":{"login":"yast","id":909990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwOTk5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yast/yast-vm","description":"YaST module vm","fork":false,"url":"https://api.github.com/repos/yast/yast-vm","forks_url":"https://api.github.com/repos/yast/yast-vm/forks","keys_url":"https://api.github.com/repos/yast/yast-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-vm/teams","hooks_url":"https://api.github.com/repos/yast/yast-vm/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-vm/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-vm/events","assignees_url":"https://api.github.com/repos/yast/yast-vm/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-vm/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-vm/tags","blobs_url":"https://api.github.com/repos/yast/yast-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-vm/languages","stargazers_url":"https://api.github.com/repos/yast/yast-vm/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-vm/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-vm/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-vm/subscription","commits_url":"https://api.github.com/repos/yast/yast-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-vm/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-vm/merges","archive_url":"https://api.github.com/repos/yast/yast-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-vm/downloads","issues_url":"https://api.github.com/repos/yast/yast-vm/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-vm/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-vm/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-vm/deployments","created_at":"2012-05-18T10:27:12Z","updated_at":"2018-08-22T08:04:06Z","pushed_at":"2018-10-31T17:26:01Z","git_url":"git://github.com/yast/yast-vm.git","ssh_url":"git@github.com:yast/yast-vm.git","clone_url":"https://github.com/yast/yast-vm.git","svn_url":"https://github.com/yast/yast-vm","homepage":"http://en.opensuse.org/Portal:YaST","size":872,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":8,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-vm/pulls/36"},"html":{"href":"https://github.com/yast/yast-vm/pull/36"},"issue":{"href":"https://api.github.com/repos/yast/yast-vm/issues/36"},"comments":{"href":"https://api.github.com/repos/yast/yast-vm/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-vm/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-vm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-vm/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-vm/statuses/2a5a33dcd5b998cf86fd95971abd3695adef8f17"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lslezak"}}