{"action":"created","issue":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1577","repository_url":"https://api.github.com/repos/smartdevicelink/sdl_core","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1577/labels{/name}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1577/comments","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1577/events","html_url":"https://github.com/smartdevicelink/sdl_core/issues/1577","id":232856956,"number":1577,"title":"CreateInteractionChoiceSet: incorrect result code in case of duplicated \"menuName\"","user":{"login":"DrachenkoAnastasiia","id":23258028,"avatar_url":"https://avatars3.githubusercontent.com/u/23258028?v=4","gravatar_id":"","url":"https://api.github.com/users/DrachenkoAnastasiia","html_url":"https://github.com/DrachenkoAnastasiia","followers_url":"https://api.github.com/users/DrachenkoAnastasiia/followers","following_url":"https://api.github.com/users/DrachenkoAnastasiia/following{/other_user}","gists_url":"https://api.github.com/users/DrachenkoAnastasiia/gists{/gist_id}","starred_url":"https://api.github.com/users/DrachenkoAnastasiia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrachenkoAnastasiia/subscriptions","organizations_url":"https://api.github.com/users/DrachenkoAnastasiia/orgs","repos_url":"https://api.github.com/users/DrachenkoAnastasiia/repos","events_url":"https://api.github.com/users/DrachenkoAnastasiia/events{/privacy}","received_events_url":"https://api.github.com/users/DrachenkoAnastasiia/received_events","type":"User","site_admin":false},"labels":[{"id":134333892,"url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels/Bug","name":"Bug","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-01T12:04:15Z","updated_at":"2018-03-08T20:25:23Z","closed_at":null,"author_association":"NONE","body":"## Occurrence\r\nAlways\r\n\r\n## Preconditions\r\n1. SDL is built with Proprietary flag.\r\n2. SDL and HMI are started. First ignition cycle.\r\n3. Connect device\r\n4. Register new application.\r\n5. Put icon.png file using PutFile RPC\r\n\r\n## Steps to reproduce\r\n1. Activate application.\r\n2. Send CreateInteractionChoiceSet RPC with duplicated menuName within a choiceSet.\r\n\r\n## Actual result\r\nSDL->App: \"resultCode: GENERIC_ERROR_NAME, success: false\".\r\n\r\n## Expected result\r\nSDL->App: \"resultCode: DUPLICATE_NAME, success: false\".\r\n\r\n# Environment\r\nSDL: https://github.com/LuxoftAKutsan/sdl_core/tree/integration/4.3.1 (35344c8)\r\nATF: https://github.com/smartdevicelink/sdl_atf/tree/develop (fe002fb)\r\nATF Scripts: https://github.com/smartdevicelink/sdl_atf_test_scripts/tree/develop (4ba374c)\r\nOS: Ubuntu 14.04 LTS x64\r\n\r\n# Attachments\r\n[SDLOPEN-2432.zip](https://github.com/smartdevicelink/sdl_core/files/1044641/SDLOPEN-2432.zip)\r\n\r\n# Expected delivery   \r\n- [ ] Source code updates \r\n- [ ] Code comments \r\n- [ ] UTs add/update \r\n- [ ] ATF tests add/update ***(not required)***  \r\n- [x] Manual tests ***(not required)*** \r\n- [x] Add/update CI plans/jobs ***(not required)***  \r\n- [x] SDD updates ***(not required)***  \r\n- [x] Guidelines update ([sdl_core_guides](https://github.com/smartdevicelink/sdl_core_guides)) ***(not required)***  \r\n- [x] Guidelines update ([sdl_hmi_integration_guidelines](https://github.com/smartdevicelink/sdl_hmi_integration_guidelines))  ***(not required)***"},"comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments/371613130","html_url":"https://github.com/smartdevicelink/sdl_core/issues/1577#issuecomment-371613130","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1577","id":371613130,"user":{"login":"jacobkeeler","id":10549248,"avatar_url":"https://avatars2.githubusercontent.com/u/10549248?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobkeeler","html_url":"https://github.com/jacobkeeler","followers_url":"https://api.github.com/users/jacobkeeler/followers","following_url":"https://api.github.com/users/jacobkeeler/following{/other_user}","gists_url":"https://api.github.com/users/jacobkeeler/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobkeeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobkeeler/subscriptions","organizations_url":"https://api.github.com/users/jacobkeeler/orgs","repos_url":"https://api.github.com/users/jacobkeeler/repos","events_url":"https://api.github.com/users/jacobkeeler/events{/privacy}","received_events_url":"https://api.github.com/users/jacobkeeler/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T20:25:23Z","updated_at":"2018-03-08T20:25:23Z","author_association":"CONTRIBUTOR","body":"Tested on master, `DUPLICATE_NAME` is received for any case where there is a duplicate name in `vrCommands`, but a `SUCCESS` response is received if two `menuName` fields are the same. It appears that there is no check for duplicates with `menuName`."}}
{"actor":{"display_login":"jacobkeeler"}}