{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/ripple-lib/issues/911","repository_url":"https://api.github.com/repos/ripple/ripple-lib","labels_url":"https://api.github.com/repos/ripple/ripple-lib/issues/911/labels{/name}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/issues/911/comments","events_url":"https://api.github.com/repos/ripple/ripple-lib/issues/911/events","html_url":"https://github.com/ripple/ripple-lib/issues/911","id":335102655,"node_id":"MDU6SXNzdWUzMzUxMDI2NTU=","number":911,"title":"fee format when using maxFee","user":{"login":"elmurci","id":3902198,"node_id":"MDQ6VXNlcjM5MDIxOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3902198?v=4","gravatar_id":"","url":"https://api.github.com/users/elmurci","html_url":"https://github.com/elmurci","followers_url":"https://api.github.com/users/elmurci/followers","following_url":"https://api.github.com/users/elmurci/following{/other_user}","gists_url":"https://api.github.com/users/elmurci/gists{/gist_id}","starred_url":"https://api.github.com/users/elmurci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmurci/subscriptions","organizations_url":"https://api.github.com/users/elmurci/orgs","repos_url":"https://api.github.com/users/elmurci/repos","events_url":"https://api.github.com/users/elmurci/events{/privacy}","received_events_url":"https://api.github.com/users/elmurci/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-23T13:57:37Z","updated_at":"2018-06-26T08:10:11Z","closed_at":null,"author_association":"NONE","body":"Not sure if this is actually a bug as the field `maxFee` in the Transaction Instructions is now deprecated.\r\nBut it is surely a backwards compatibility issue.\r\n\r\nI have seen that if you specify a `maxFee` value and don't make use of the `maxFeeXRP` field in the constructor (like in the old days) you get random validation errors as the calculated fee is not properly formatted:\r\n\r\n`[ValidationError(xrpToDrops: value '0.0064895625' has too many decimal places.)]`"},"comment":{"url":"https://api.github.com/repos/ripple/ripple-lib/issues/comments/400219791","html_url":"https://github.com/ripple/ripple-lib/issues/911#issuecomment-400219791","issue_url":"https://api.github.com/repos/ripple/ripple-lib/issues/911","id":400219791,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDIxOTc5MQ==","user":{"login":"intelliot","id":81505,"node_id":"MDQ6VXNlcjgxNTA1","avatar_url":"https://avatars3.githubusercontent.com/u/81505?v=4","gravatar_id":"","url":"https://api.github.com/users/intelliot","html_url":"https://github.com/intelliot","followers_url":"https://api.github.com/users/intelliot/followers","following_url":"https://api.github.com/users/intelliot/following{/other_user}","gists_url":"https://api.github.com/users/intelliot/gists{/gist_id}","starred_url":"https://api.github.com/users/intelliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelliot/subscriptions","organizations_url":"https://api.github.com/users/intelliot/orgs","repos_url":"https://api.github.com/users/intelliot/repos","events_url":"https://api.github.com/users/intelliot/events{/privacy}","received_events_url":"https://api.github.com/users/intelliot/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T08:10:11Z","updated_at":"2018-06-26T08:10:11Z","author_association":"MEMBER","body":"Good catch! I opened a PR which should fix this.\r\n\r\nAlternatively, if we want the old behavior back, https://github.com/ripple/ripple-lib/pull/907 would do that."}}
{"actor":{"display_login":"intelliot"}}