{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang-nursery/docs.rs/issues/240","repository_url":"https://api.github.com/repos/rust-lang-nursery/docs.rs","labels_url":"https://api.github.com/repos/rust-lang-nursery/docs.rs/issues/240/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang-nursery/docs.rs/issues/240/comments","events_url":"https://api.github.com/repos/rust-lang-nursery/docs.rs/issues/240/events","html_url":"https://github.com/rust-lang-nursery/docs.rs/pull/240","id":365632953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTA4MDU4","number":240,"title":"Don't override the user's fonts","user":{"login":"jonhoo","id":176295,"node_id":"MDQ6VXNlcjE3NjI5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/176295?v=4","gravatar_id":"","url":"https://api.github.com/users/jonhoo","html_url":"https://github.com/jonhoo","followers_url":"https://api.github.com/users/jonhoo/followers","following_url":"https://api.github.com/users/jonhoo/following{/other_user}","gists_url":"https://api.github.com/users/jonhoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhoo/subscriptions","organizations_url":"https://api.github.com/users/jonhoo/orgs","repos_url":"https://api.github.com/users/jonhoo/repos","events_url":"https://api.github.com/users/jonhoo/events{/privacy}","received_events_url":"https://api.github.com/users/jonhoo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-01T20:38:03Z","updated_at":"2018-10-26T15:05:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/docs.rs/pulls/240","html_url":"https://github.com/rust-lang-nursery/docs.rs/pull/240","diff_url":"https://github.com/rust-lang-nursery/docs.rs/pull/240.diff","patch_url":"https://github.com/rust-lang-nursery/docs.rs/pull/240.patch"},"body":"This patch is similar in spirit to rust-lang/blog.rust-lang.org#263, though it's also less invasive; it removes the specific font overrides in style.css so that the browser will use the user's configured fonts.\r\n\r\nThe net result of the change is that the page will look less \"uniform\" across different browsers, OSes, and devices, but the overall aesthetic should be preserved. It also means that user preferences are respected, and that legibility is improved for users with particular font needs, or on platforms that sometimes gets confused about how to render fonts nicely (ehrm, Linux)."},"comment":{"url":"https://api.github.com/repos/rust-lang-nursery/docs.rs/issues/comments/433439650","html_url":"https://github.com/rust-lang-nursery/docs.rs/pull/240#issuecomment-433439650","issue_url":"https://api.github.com/repos/rust-lang-nursery/docs.rs/issues/240","id":433439650,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzQzOTY1MA==","user":{"login":"jonhoo","id":176295,"node_id":"MDQ6VXNlcjE3NjI5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/176295?v=4","gravatar_id":"","url":"https://api.github.com/users/jonhoo","html_url":"https://github.com/jonhoo","followers_url":"https://api.github.com/users/jonhoo/followers","following_url":"https://api.github.com/users/jonhoo/following{/other_user}","gists_url":"https://api.github.com/users/jonhoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhoo/subscriptions","organizations_url":"https://api.github.com/users/jonhoo/orgs","repos_url":"https://api.github.com/users/jonhoo/repos","events_url":"https://api.github.com/users/jonhoo/events{/privacy}","received_events_url":"https://api.github.com/users/jonhoo/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T15:05:22Z","updated_at":"2018-10-26T15:05:22Z","author_association":"CONTRIBUTOR","body":"In that case, I think the font list should at least be changed like this:\r\n```diff\r\n-$font-family-sans: \"Fira Sans\", \"Helvetica Neue\", Helvetica, Arial, sans-serif;\r\n-$font-family-serif: \"Source Serif Pro\",Georgia,Times,\"Times New Roman\",serif;\r\n-$font-family-mono: \"Source Code Pro\", Menlo, Monaco, Consolas, \"DejaVu Sans Mono\", Inconsolata, monospace;\r\n+$font-family-sans: \"Fira Sans\", sans-serif;\r\n+$font-family-serif: \"Source Serif Pro\",serif;\r\n+$font-family-mono: \"Source Code Pro\", monospace;\r\n```\r\nThe intermediate fonts can be quite ugly on Linux machines :)"}}
{"actor":{"display_login":"jonhoo"}}