{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/16145","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/16145/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/16145/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/16145/events","html_url":"https://github.com/magento/magento2/pull/16145","id":332563098,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDE2ODI5","number":16145,"title":"Insecure 'uniqid(...)' usage (Insufficient Entropy Vulnerability)","user":{"login":"lfluvisotto","id":535626,"node_id":"MDQ6VXNlcjUzNTYyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/535626?v=4","gravatar_id":"","url":"https://api.github.com/users/lfluvisotto","html_url":"https://github.com/lfluvisotto","followers_url":"https://api.github.com/users/lfluvisotto/followers","following_url":"https://api.github.com/users/lfluvisotto/following{/other_user}","gists_url":"https://api.github.com/users/lfluvisotto/gists{/gist_id}","starred_url":"https://api.github.com/users/lfluvisotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfluvisotto/subscriptions","organizations_url":"https://api.github.com/users/lfluvisotto/orgs","repos_url":"https://api.github.com/users/lfluvisotto/repos","events_url":"https://api.github.com/users/lfluvisotto/events{/privacy}","received_events_url":"https://api.github.com/users/lfluvisotto/received_events","type":"User","site_admin":false},"labels":[{"id":703232382,"node_id":"MDU6TGFiZWw3MDMyMzIzODI=","url":"https://api.github.com/repos/magento/magento2/labels/2.2-develop","name":"2.2-develop","color":"fbca04","default":false},{"id":394366531,"node_id":"MDU6TGFiZWwzOTQzNjY1MzE=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Frontend","name":"Area: Frontend","color":"1d76db","default":false},{"id":962061876,"node_id":"MDU6TGFiZWw5NjIwNjE4NzY=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20multiple","name":"Component: multiple","color":"7fb703","default":false},{"id":29009799,"node_id":"MDU6TGFiZWwyOTAwOTc5OQ==","url":"https://api.github.com/repos/magento/magento2/labels/improvement","name":"improvement","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"assignees":[{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-06-14T21:01:15Z","updated_at":"2018-06-14T21:08:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/16145","html_url":"https://github.com/magento/magento2/pull/16145","diff_url":"https://github.com/magento/magento2/pull/16145.diff","patch_url":"https://github.com/magento/magento2/pull/16145.patch"},"body":"### Description\r\nInsecure 'uniqid(...)' usage (Insufficient Entropy Vulnerability)\r\n\r\nMore information, see documentation:\r\n\r\nhttp://php.net/manual/en/function.uniqid.php\r\n\r\nmore_entropy (parameter): If set to TRUE, uniqid() will add additional entropy (using the combined linear congruential generator) at the end of the return value, which increases the likelihood that the result will be unique.\r\n\r\nhttp://phpsecurity.readthedocs.io/en/latest/Insufficient-Entropy-For-Random-Values.html"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/397439041","html_url":"https://github.com/magento/magento2/pull/16145#issuecomment-397439041","issue_url":"https://api.github.com/repos/magento/magento2/issues/16145","id":397439041,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzQzOTA0MQ==","user":{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T21:08:59Z","updated_at":"2018-06-14T21:08:59Z","author_association":"CONTRIBUTOR","body":"@lfluvisotto I've checked all the occurrences and didn't spot any of\r\n\r\n```\r\nRandom values are important for a wide variety of use cases.\r\n\r\nTo randomly select options from a pool or range of known options.\r\nTo generate initialisation vectors for encryption.\r\nTo generate unguessable tokens or nonces for authorisation purposes.\r\nTo generate unique identifiers like Session IDs.\r\n```"}}
{"actor":{"display_login":"orlangur"}}