{"action":"created","comment":{"url":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/comments/201149122","pull_request_review_id":135595050,"id":201149122,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTE0OTEyMg==","diff_hunk":"@@ -9,7 +9,7 @@\n     @Test\n     public void testMissingPlaceholdersAdded()\n     {\n-        TranslatableComponent testComponent = new TranslatableComponent( \"Test string with %s placeholders: %s\", \"2\", \"aoeu\" );\n+        TranslatableComponent testComponent = new TranslatableComponent( \"Test string with %s placeholders: %s\", 2, \"aoeu\" );","path":"chat/src/test/java/net/md_5/bungee/api/chat/TranslatableComponentTest.java","position":5,"original_position":5,"commit_id":"8ea687c9ca514fcc2b9e38dc6772b4867328923e","original_commit_id":"8ea687c9ca514fcc2b9e38dc6772b4867328923e","user":{"login":"SimonOrJ","id":13530989,"node_id":"MDQ6VXNlcjEzNTMwOTg5","avatar_url":"https://avatars0.githubusercontent.com/u/13530989?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonOrJ","html_url":"https://github.com/SimonOrJ","followers_url":"https://api.github.com/users/SimonOrJ/followers","following_url":"https://api.github.com/users/SimonOrJ/following{/other_user}","gists_url":"https://api.github.com/users/SimonOrJ/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonOrJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonOrJ/subscriptions","organizations_url":"https://api.github.com/users/SimonOrJ/orgs","repos_url":"https://api.github.com/users/SimonOrJ/repos","events_url":"https://api.github.com/users/SimonOrJ/events{/privacy}","received_events_url":"https://api.github.com/users/SimonOrJ/received_events","type":"User","site_admin":false},"body":"[Mojang uses %s for all placeholders](https://github.com/SpigotMC/BungeeCord/blob/master/chat/src/main/resources/mojang-translations/en_US.properties#L2092) regardless of what the variable type is, and it seems TextComponent only accepts string inputs (or inputs cast as string), so that should work.","created_at":"2018-07-09T21:13:57Z","updated_at":"2018-07-09T21:13:58Z","html_url":"https://github.com/SpigotMC/BungeeCord/pull/2457#discussion_r201149122","pull_request_url":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/2457","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/comments/201149122"},"html":{"href":"https://github.com/SpigotMC/BungeeCord/pull/2457#discussion_r201149122"},"pull_request":{"href":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/2457"}},"in_reply_to_id":200961478},"pull_request":{"url":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/2457","id":200022172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDIyMTcy","html_url":"https://github.com/SpigotMC/BungeeCord/pull/2457","diff_url":"https://github.com/SpigotMC/BungeeCord/pull/2457.diff","patch_url":"https://github.com/SpigotMC/BungeeCord/pull/2457.patch","issue_url":"https://api.github.com/repos/SpigotMC/BungeeCord/issues/2457","number":2457,"state":"open","locked":false,"title":"TranslatableComponent: Allow objects in `with` to be translated into a string","user":{"login":"SimonOrJ","id":13530989,"node_id":"MDQ6VXNlcjEzNTMwOTg5","avatar_url":"https://avatars0.githubusercontent.com/u/13530989?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonOrJ","html_url":"https://github.com/SimonOrJ","followers_url":"https://api.github.com/users/SimonOrJ/followers","following_url":"https://api.github.com/users/SimonOrJ/following{/other_user}","gists_url":"https://api.github.com/users/SimonOrJ/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonOrJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonOrJ/subscriptions","organizations_url":"https://api.github.com/users/SimonOrJ/orgs","repos_url":"https://api.github.com/users/SimonOrJ/repos","events_url":"https://api.github.com/users/SimonOrJ/events{/privacy}","received_events_url":"https://api.github.com/users/SimonOrJ/received_events","type":"User","site_admin":false},"body":"This should allow for integer, float, etc. to be added to \"with\" parameter.  This should allow `int` or any primitive variables to be cast into string without raising any exception.\r\n\r\nIn addition, I modified the test to test such case.\r\n","created_at":"2018-07-09T08:12:57Z","updated_at":"2018-07-09T21:13:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6b7cd2f8417672faf8b1ba1b856383ec0fdd1fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/2457/commits","review_comments_url":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/2457/comments","review_comment_url":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpigotMC/BungeeCord/issues/2457/comments","statuses_url":"https://api.github.com/repos/SpigotMC/BungeeCord/statuses/8ea687c9ca514fcc2b9e38dc6772b4867328923e","head":{"label":"SimonOrJ:translatable/with","ref":"translatable/with","sha":"8ea687c9ca514fcc2b9e38dc6772b4867328923e","user":{"login":"SimonOrJ","id":13530989,"node_id":"MDQ6VXNlcjEzNTMwOTg5","avatar_url":"https://avatars0.githubusercontent.com/u/13530989?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonOrJ","html_url":"https://github.com/SimonOrJ","followers_url":"https://api.github.com/users/SimonOrJ/followers","following_url":"https://api.github.com/users/SimonOrJ/following{/other_user}","gists_url":"https://api.github.com/users/SimonOrJ/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonOrJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonOrJ/subscriptions","organizations_url":"https://api.github.com/users/SimonOrJ/orgs","repos_url":"https://api.github.com/users/SimonOrJ/repos","events_url":"https://api.github.com/users/SimonOrJ/events{/privacy}","received_events_url":"https://api.github.com/users/SimonOrJ/received_events","type":"User","site_admin":false},"repo":{"id":140244803,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyNDQ4MDM=","name":"BungeeCord","full_name":"SimonOrJ/BungeeCord","owner":{"login":"SimonOrJ","id":13530989,"node_id":"MDQ6VXNlcjEzNTMwOTg5","avatar_url":"https://avatars0.githubusercontent.com/u/13530989?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonOrJ","html_url":"https://github.com/SimonOrJ","followers_url":"https://api.github.com/users/SimonOrJ/followers","following_url":"https://api.github.com/users/SimonOrJ/following{/other_user}","gists_url":"https://api.github.com/users/SimonOrJ/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonOrJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonOrJ/subscriptions","organizations_url":"https://api.github.com/users/SimonOrJ/orgs","repos_url":"https://api.github.com/users/SimonOrJ/repos","events_url":"https://api.github.com/users/SimonOrJ/events{/privacy}","received_events_url":"https://api.github.com/users/SimonOrJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimonOrJ/BungeeCord","description":"BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers.","fork":true,"url":"https://api.github.com/repos/SimonOrJ/BungeeCord","forks_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/forks","keys_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/teams","hooks_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/hooks","issue_events_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/issues/events{/number}","events_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/events","assignees_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/assignees{/user}","branches_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/branches{/branch}","tags_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/tags","blobs_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/statuses/{sha}","languages_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/languages","stargazers_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/stargazers","contributors_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/contributors","subscribers_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/subscribers","subscription_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/subscription","commits_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/contents/{+path}","compare_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/merges","archive_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/downloads","issues_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/issues{/number}","pulls_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/pulls{/number}","milestones_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/milestones{/number}","notifications_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/labels{/name}","releases_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/releases{/id}","deployments_url":"https://api.github.com/repos/SimonOrJ/BungeeCord/deployments","created_at":"2018-07-09T07:05:14Z","updated_at":"2018-07-09T07:05:16Z","pushed_at":"2018-07-09T07:20:21Z","git_url":"git://github.com/SimonOrJ/BungeeCord.git","ssh_url":"git@github.com:SimonOrJ/BungeeCord.git","clone_url":"https://github.com/SimonOrJ/BungeeCord.git","svn_url":"https://github.com/SimonOrJ/BungeeCord","homepage":"https://www.spigotmc.org/go/bungeecord","size":3144,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpigotMC:master","ref":"master","sha":"fa542c70df4c797be510bfd36327181348f0f2bf","user":{"login":"SpigotMC","id":4350249,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTAyNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4350249?v=4","gravatar_id":"","url":"https://api.github.com/users/SpigotMC","html_url":"https://github.com/SpigotMC","followers_url":"https://api.github.com/users/SpigotMC/followers","following_url":"https://api.github.com/users/SpigotMC/following{/other_user}","gists_url":"https://api.github.com/users/SpigotMC/gists{/gist_id}","starred_url":"https://api.github.com/users/SpigotMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpigotMC/subscriptions","organizations_url":"https://api.github.com/users/SpigotMC/orgs","repos_url":"https://api.github.com/users/SpigotMC/repos","events_url":"https://api.github.com/users/SpigotMC/events{/privacy}","received_events_url":"https://api.github.com/users/SpigotMC/received_events","type":"Organization","site_admin":false},"repo":{"id":6084210,"node_id":"MDEwOlJlcG9zaXRvcnk2MDg0MjEw","name":"BungeeCord","full_name":"SpigotMC/BungeeCord","owner":{"login":"SpigotMC","id":4350249,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTAyNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4350249?v=4","gravatar_id":"","url":"https://api.github.com/users/SpigotMC","html_url":"https://github.com/SpigotMC","followers_url":"https://api.github.com/users/SpigotMC/followers","following_url":"https://api.github.com/users/SpigotMC/following{/other_user}","gists_url":"https://api.github.com/users/SpigotMC/gists{/gist_id}","starred_url":"https://api.github.com/users/SpigotMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpigotMC/subscriptions","organizations_url":"https://api.github.com/users/SpigotMC/orgs","repos_url":"https://api.github.com/users/SpigotMC/repos","events_url":"https://api.github.com/users/SpigotMC/events{/privacy}","received_events_url":"https://api.github.com/users/SpigotMC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpigotMC/BungeeCord","description":"BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers.","fork":false,"url":"https://api.github.com/repos/SpigotMC/BungeeCord","forks_url":"https://api.github.com/repos/SpigotMC/BungeeCord/forks","keys_url":"https://api.github.com/repos/SpigotMC/BungeeCord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpigotMC/BungeeCord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpigotMC/BungeeCord/teams","hooks_url":"https://api.github.com/repos/SpigotMC/BungeeCord/hooks","issue_events_url":"https://api.github.com/repos/SpigotMC/BungeeCord/issues/events{/number}","events_url":"https://api.github.com/repos/SpigotMC/BungeeCord/events","assignees_url":"https://api.github.com/repos/SpigotMC/BungeeCord/assignees{/user}","branches_url":"https://api.github.com/repos/SpigotMC/BungeeCord/branches{/branch}","tags_url":"https://api.github.com/repos/SpigotMC/BungeeCord/tags","blobs_url":"https://api.github.com/repos/SpigotMC/BungeeCord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpigotMC/BungeeCord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpigotMC/BungeeCord/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpigotMC/BungeeCord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpigotMC/BungeeCord/statuses/{sha}","languages_url":"https://api.github.com/repos/SpigotMC/BungeeCord/languages","stargazers_url":"https://api.github.com/repos/SpigotMC/BungeeCord/stargazers","contributors_url":"https://api.github.com/repos/SpigotMC/BungeeCord/contributors","subscribers_url":"https://api.github.com/repos/SpigotMC/BungeeCord/subscribers","subscription_url":"https://api.github.com/repos/SpigotMC/BungeeCord/subscription","commits_url":"https://api.github.com/repos/SpigotMC/BungeeCord/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpigotMC/BungeeCord/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpigotMC/BungeeCord/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpigotMC/BungeeCord/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpigotMC/BungeeCord/contents/{+path}","compare_url":"https://api.github.com/repos/SpigotMC/BungeeCord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpigotMC/BungeeCord/merges","archive_url":"https://api.github.com/repos/SpigotMC/BungeeCord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpigotMC/BungeeCord/downloads","issues_url":"https://api.github.com/repos/SpigotMC/BungeeCord/issues{/number}","pulls_url":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls{/number}","milestones_url":"https://api.github.com/repos/SpigotMC/BungeeCord/milestones{/number}","notifications_url":"https://api.github.com/repos/SpigotMC/BungeeCord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpigotMC/BungeeCord/labels{/name}","releases_url":"https://api.github.com/repos/SpigotMC/BungeeCord/releases{/id}","deployments_url":"https://api.github.com/repos/SpigotMC/BungeeCord/deployments","created_at":"2012-10-05T01:01:56Z","updated_at":"2018-07-09T13:18:22Z","pushed_at":"2018-07-09T20:29:48Z","git_url":"git://github.com/SpigotMC/BungeeCord.git","ssh_url":"git@github.com:SpigotMC/BungeeCord.git","clone_url":"https://github.com/SpigotMC/BungeeCord.git","svn_url":"https://github.com/SpigotMC/BungeeCord","homepage":"https://www.spigotmc.org/go/bungeecord","size":3143,"stargazers_count":619,"watchers_count":619,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":779,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":779,"open_issues":128,"watchers":619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/2457"},"html":{"href":"https://github.com/SpigotMC/BungeeCord/pull/2457"},"issue":{"href":"https://api.github.com/repos/SpigotMC/BungeeCord/issues/2457"},"comments":{"href":"https://api.github.com/repos/SpigotMC/BungeeCord/issues/2457/comments"},"review_comments":{"href":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/2457/comments"},"review_comment":{"href":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpigotMC/BungeeCord/pulls/2457/commits"},"statuses":{"href":"https://api.github.com/repos/SpigotMC/BungeeCord/statuses/8ea687c9ca514fcc2b9e38dc6772b4867328923e"}},"author_association":"NONE"}}
{"actor":{"display_login":"SimonOrJ"}}