{"action":"opened","number":225,"pull_request":{"url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/pulls/225","id":201511808,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTExODA4","html_url":"https://github.com/Krzysztof-Cieslak/vscode-elm/pull/225","diff_url":"https://github.com/Krzysztof-Cieslak/vscode-elm/pull/225.diff","patch_url":"https://github.com/Krzysztof-Cieslak/vscode-elm/pull/225.patch","issue_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/issues/225","number":225,"state":"open","locked":false,"title":"Refactoring diagnostic init for VS Live Share","user":{"login":"lostintangent","id":116461,"node_id":"MDQ6VXNlcjExNjQ2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/116461?v=4","gravatar_id":"","url":"https://api.github.com/users/lostintangent","html_url":"https://github.com/lostintangent","followers_url":"https://api.github.com/users/lostintangent/followers","following_url":"https://api.github.com/users/lostintangent/following{/other_user}","gists_url":"https://api.github.com/users/lostintangent/gists{/gist_id}","starred_url":"https://api.github.com/users/lostintangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostintangent/subscriptions","organizations_url":"https://api.github.com/users/lostintangent/orgs","repos_url":"https://api.github.com/users/lostintangent/repos","events_url":"https://api.github.com/users/lostintangent/events{/privacy}","received_events_url":"https://api.github.com/users/lostintangent/received_events","type":"User","site_admin":false},"body":"We (the [VS Live Share](aka.ms/vsls) team) had a user [report an issue](https://github.com/MicrosoftDocs/live-share/issues/442#issuecomment-404366305), where Elm errors would get shared with guests in a Live Share session, but they wouldn't go away after being resolved (e.g. you fix the issue and save the document). After investigating it, it appears to be because the Elm extension re-creates the `DiagnosticCollection` on every lint run (as opposed to updating a single instance), and therefore, Live Share wasn't seeing the old errors going away.\r\n\r\nThis is likely a bug in VS Code, that I'll file separately. However, this fix resolves the issue immediately, and in general, seems like a reasonable refactoring anyways. Elm is an important language for VS Live Share, so this is definitely an issue we'd like to correct, and make sure co-editing/pair programming is great!\r\n\r\n// CC @Krzysztof-Cieslak ","created_at":"2018-07-15T19:30:16Z","updated_at":"2018-07-15T19:30:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/pulls/225/commits","review_comments_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/pulls/225/comments","review_comment_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/issues/225/comments","statuses_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/statuses/a8f717fb7d8644173176123379fb68f44245c919","head":{"label":"lostintangent:master","ref":"master","sha":"a8f717fb7d8644173176123379fb68f44245c919","user":{"login":"lostintangent","id":116461,"node_id":"MDQ6VXNlcjExNjQ2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/116461?v=4","gravatar_id":"","url":"https://api.github.com/users/lostintangent","html_url":"https://github.com/lostintangent","followers_url":"https://api.github.com/users/lostintangent/followers","following_url":"https://api.github.com/users/lostintangent/following{/other_user}","gists_url":"https://api.github.com/users/lostintangent/gists{/gist_id}","starred_url":"https://api.github.com/users/lostintangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostintangent/subscriptions","organizations_url":"https://api.github.com/users/lostintangent/orgs","repos_url":"https://api.github.com/users/lostintangent/repos","events_url":"https://api.github.com/users/lostintangent/events{/privacy}","received_events_url":"https://api.github.com/users/lostintangent/received_events","type":"User","site_admin":false},"repo":{"id":141051566,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEwNTE1NjY=","name":"vscode-elm","full_name":"lostintangent/vscode-elm","owner":{"login":"lostintangent","id":116461,"node_id":"MDQ6VXNlcjExNjQ2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/116461?v=4","gravatar_id":"","url":"https://api.github.com/users/lostintangent","html_url":"https://github.com/lostintangent","followers_url":"https://api.github.com/users/lostintangent/followers","following_url":"https://api.github.com/users/lostintangent/following{/other_user}","gists_url":"https://api.github.com/users/lostintangent/gists{/gist_id}","starred_url":"https://api.github.com/users/lostintangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostintangent/subscriptions","organizations_url":"https://api.github.com/users/lostintangent/orgs","repos_url":"https://api.github.com/users/lostintangent/repos","events_url":"https://api.github.com/users/lostintangent/events{/privacy}","received_events_url":"https://api.github.com/users/lostintangent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lostintangent/vscode-elm","description":"Elm Language Support for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/lostintangent/vscode-elm","forks_url":"https://api.github.com/repos/lostintangent/vscode-elm/forks","keys_url":"https://api.github.com/repos/lostintangent/vscode-elm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lostintangent/vscode-elm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lostintangent/vscode-elm/teams","hooks_url":"https://api.github.com/repos/lostintangent/vscode-elm/hooks","issue_events_url":"https://api.github.com/repos/lostintangent/vscode-elm/issues/events{/number}","events_url":"https://api.github.com/repos/lostintangent/vscode-elm/events","assignees_url":"https://api.github.com/repos/lostintangent/vscode-elm/assignees{/user}","branches_url":"https://api.github.com/repos/lostintangent/vscode-elm/branches{/branch}","tags_url":"https://api.github.com/repos/lostintangent/vscode-elm/tags","blobs_url":"https://api.github.com/repos/lostintangent/vscode-elm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lostintangent/vscode-elm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lostintangent/vscode-elm/git/refs{/sha}","trees_url":"https://api.github.com/repos/lostintangent/vscode-elm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lostintangent/vscode-elm/statuses/{sha}","languages_url":"https://api.github.com/repos/lostintangent/vscode-elm/languages","stargazers_url":"https://api.github.com/repos/lostintangent/vscode-elm/stargazers","contributors_url":"https://api.github.com/repos/lostintangent/vscode-elm/contributors","subscribers_url":"https://api.github.com/repos/lostintangent/vscode-elm/subscribers","subscription_url":"https://api.github.com/repos/lostintangent/vscode-elm/subscription","commits_url":"https://api.github.com/repos/lostintangent/vscode-elm/commits{/sha}","git_commits_url":"https://api.github.com/repos/lostintangent/vscode-elm/git/commits{/sha}","comments_url":"https://api.github.com/repos/lostintangent/vscode-elm/comments{/number}","issue_comment_url":"https://api.github.com/repos/lostintangent/vscode-elm/issues/comments{/number}","contents_url":"https://api.github.com/repos/lostintangent/vscode-elm/contents/{+path}","compare_url":"https://api.github.com/repos/lostintangent/vscode-elm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lostintangent/vscode-elm/merges","archive_url":"https://api.github.com/repos/lostintangent/vscode-elm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lostintangent/vscode-elm/downloads","issues_url":"https://api.github.com/repos/lostintangent/vscode-elm/issues{/number}","pulls_url":"https://api.github.com/repos/lostintangent/vscode-elm/pulls{/number}","milestones_url":"https://api.github.com/repos/lostintangent/vscode-elm/milestones{/number}","notifications_url":"https://api.github.com/repos/lostintangent/vscode-elm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lostintangent/vscode-elm/labels{/name}","releases_url":"https://api.github.com/repos/lostintangent/vscode-elm/releases{/id}","deployments_url":"https://api.github.com/repos/lostintangent/vscode-elm/deployments","created_at":"2018-07-15T19:09:04Z","updated_at":"2018-07-15T19:25:10Z","pushed_at":"2018-07-15T19:25:09Z","git_url":"git://github.com/lostintangent/vscode-elm.git","ssh_url":"git@github.com:lostintangent/vscode-elm.git","clone_url":"https://github.com/lostintangent/vscode-elm.git","svn_url":"https://github.com/lostintangent/vscode-elm","homepage":"https://marketplace.visualstudio.com/items/sbrink.elm","size":3443,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Krzysztof-Cieslak:master","ref":"master","sha":"60fb768ab321da53806f9b573947fedb9687ea18","user":{"login":"Krzysztof-Cieslak","id":5427083,"node_id":"MDQ6VXNlcjU0MjcwODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5427083?v=4","gravatar_id":"","url":"https://api.github.com/users/Krzysztof-Cieslak","html_url":"https://github.com/Krzysztof-Cieslak","followers_url":"https://api.github.com/users/Krzysztof-Cieslak/followers","following_url":"https://api.github.com/users/Krzysztof-Cieslak/following{/other_user}","gists_url":"https://api.github.com/users/Krzysztof-Cieslak/gists{/gist_id}","starred_url":"https://api.github.com/users/Krzysztof-Cieslak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Krzysztof-Cieslak/subscriptions","organizations_url":"https://api.github.com/users/Krzysztof-Cieslak/orgs","repos_url":"https://api.github.com/users/Krzysztof-Cieslak/repos","events_url":"https://api.github.com/users/Krzysztof-Cieslak/events{/privacy}","received_events_url":"https://api.github.com/users/Krzysztof-Cieslak/received_events","type":"User","site_admin":false},"repo":{"id":46659760,"node_id":"MDEwOlJlcG9zaXRvcnk0NjY1OTc2MA==","name":"vscode-elm","full_name":"Krzysztof-Cieslak/vscode-elm","owner":{"login":"Krzysztof-Cieslak","id":5427083,"node_id":"MDQ6VXNlcjU0MjcwODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5427083?v=4","gravatar_id":"","url":"https://api.github.com/users/Krzysztof-Cieslak","html_url":"https://github.com/Krzysztof-Cieslak","followers_url":"https://api.github.com/users/Krzysztof-Cieslak/followers","following_url":"https://api.github.com/users/Krzysztof-Cieslak/following{/other_user}","gists_url":"https://api.github.com/users/Krzysztof-Cieslak/gists{/gist_id}","starred_url":"https://api.github.com/users/Krzysztof-Cieslak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Krzysztof-Cieslak/subscriptions","organizations_url":"https://api.github.com/users/Krzysztof-Cieslak/orgs","repos_url":"https://api.github.com/users/Krzysztof-Cieslak/repos","events_url":"https://api.github.com/users/Krzysztof-Cieslak/events{/privacy}","received_events_url":"https://api.github.com/users/Krzysztof-Cieslak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Krzysztof-Cieslak/vscode-elm","description":"Elm Language Support for Visual Studio Code","fork":false,"url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm","forks_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/forks","keys_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/teams","hooks_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/hooks","issue_events_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/issues/events{/number}","events_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/events","assignees_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/assignees{/user}","branches_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/branches{/branch}","tags_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/tags","blobs_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/statuses/{sha}","languages_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/languages","stargazers_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/stargazers","contributors_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/contributors","subscribers_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/subscribers","subscription_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/subscription","commits_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/contents/{+path}","compare_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/merges","archive_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/downloads","issues_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/issues{/number}","pulls_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/pulls{/number}","milestones_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/milestones{/number}","notifications_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/labels{/name}","releases_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/releases{/id}","deployments_url":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/deployments","created_at":"2015-11-22T12:31:10Z","updated_at":"2018-07-04T16:17:50Z","pushed_at":"2018-06-27T14:58:41Z","git_url":"git://github.com/Krzysztof-Cieslak/vscode-elm.git","ssh_url":"git@github.com:Krzysztof-Cieslak/vscode-elm.git","clone_url":"https://github.com/Krzysztof-Cieslak/vscode-elm.git","svn_url":"https://github.com/Krzysztof-Cieslak/vscode-elm","homepage":"https://marketplace.visualstudio.com/items/sbrink.elm","size":3443,"stargazers_count":329,"watchers_count":329,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":70,"open_issues":29,"watchers":329,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/pulls/225"},"html":{"href":"https://github.com/Krzysztof-Cieslak/vscode-elm/pull/225"},"issue":{"href":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/issues/225"},"comments":{"href":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/Krzysztof-Cieslak/vscode-elm/statuses/a8f717fb7d8644173176123379fb68f44245c919"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"lostintangent"}}