{"action":"created","issue":{"url":"https://api.github.com/repos/rchain/rchain/issues/758","repository_url":"https://api.github.com/repos/rchain/rchain","labels_url":"https://api.github.com/repos/rchain/rchain/issues/758/labels{/name}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/758/comments","events_url":"https://api.github.com/repos/rchain/rchain/issues/758/events","html_url":"https://github.com/rchain/rchain/pull/758","id":325213999,"number":758,"title":"Add certificate start option, check certificate and use as node name","user":{"login":"sebtomba","id":6872800,"avatar_url":"https://avatars3.githubusercontent.com/u/6872800?v=4","gravatar_id":"","url":"https://api.github.com/users/sebtomba","html_url":"https://github.com/sebtomba","followers_url":"https://api.github.com/users/sebtomba/followers","following_url":"https://api.github.com/users/sebtomba/following{/other_user}","gists_url":"https://api.github.com/users/sebtomba/gists{/gist_id}","starred_url":"https://api.github.com/users/sebtomba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebtomba/subscriptions","organizations_url":"https://api.github.com/users/sebtomba/orgs","repos_url":"https://api.github.com/users/sebtomba/repos","events_url":"https://api.github.com/users/sebtomba/events{/privacy}","received_events_url":"https://api.github.com/users/sebtomba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-22T09:36:09Z","updated_at":"2018-05-25T11:02:24Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/758","html_url":"https://github.com/rchain/rchain/pull/758","diff_url":"https://github.com/rchain/rchain/pull/758.diff","patch_url":"https://github.com/rchain/rchain/pull/758.patch"},"body":"## Overview\r\nRemoving name start option in favor of a certificate option. The certificate gets checked (X.509 and secp256k1) and then a blockchain public address (Ethereum compatible) is generated from the public key. The public address is then part of the node address.\r\n\r\n### Does this PR relate to an RChain JIRA issue? \r\nhttps://rchain.atlassian.net/browse/CORE-449\r\n\r\n### Complete this checklist before you submit the PR\r\n- [x] This PR contains no more than 200 lines of code, excluding test code.\r\n- [x] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [x] You have someone in mind to assign for review. Make this assignment after submitting the PR.\r\n\r\n### Notes\r\nFrom this point on a X.509 PEM certificate (secp256k1) is **required** to run a node!"},"comment":{"url":"https://api.github.com/repos/rchain/rchain/issues/comments/392018880","html_url":"https://github.com/rchain/rchain/pull/758#issuecomment-392018880","issue_url":"https://api.github.com/repos/rchain/rchain/issues/758","id":392018880,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-05-25T11:02:24Z","updated_at":"2018-05-25T11:02:24Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/rchain/rchain/pull/758?src=pr&el=h1) Report\n> Merging [#758](https://codecov.io/gh/rchain/rchain/pull/758?src=pr&el=desc) into [dev](https://codecov.io/gh/rchain/rchain/commit/e40a923a188e66c9f497d2506aea7a264e4f731a?src=pr&el=desc) will **decrease** coverage by `0.34%`.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/rchain/rchain/pull/758/graphs/tree.svg?height=150&width=650&token=MnvcTlDgD0&src=pr)](https://codecov.io/gh/rchain/rchain/pull/758?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##              dev     #758      +/-   ##\n==========================================\n- Coverage   54.15%   53.81%   -0.35%     \n==========================================\n  Files         102      103       +1     \n  Lines        4784     4815      +31     \n  Branches      221      217       -4     \n==========================================\n  Hits         2591     2591              \n- Misses       2193     2224      +31\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #comm | `42.45% <ø> (ø)` | :arrow_up: |\n| #crypto | `87.87% <ø> (ø)` | :arrow_up: |\n| #node | `0% <0%> (ø)` | :arrow_up: |\n| #rholang | `70.17% <ø> (ø)` | :arrow_up: |\n| #roscala | `61.87% <ø> (ø)` | :arrow_up: |\n\n| [Impacted Files](https://codecov.io/gh/rchain/rchain/pull/758?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [node/src/main/scala/coop/rchain/node/node.scala](https://codecov.io/gh/rchain/rchain/pull/758/diff?src=pr&el=tree#diff-bm9kZS9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9ub2RlL25vZGUuc2NhbGE=) | `0% <ø> (ø)` | :arrow_up: |\n| [node/src/main/scala/coop/rchain/node/Main.scala](https://codecov.io/gh/rchain/rchain/pull/758/diff?src=pr&el=tree#diff-bm9kZS9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9ub2RlL01haW4uc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: |\n| [...ain/scala/coop/rchain/node/CertificateHelper.scala](https://codecov.io/gh/rchain/rchain/pull/758/diff?src=pr&el=tree#diff-bm9kZS9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9ub2RlL0NlcnRpZmljYXRlSGVscGVyLnNjYWxh) | `0% <0%> (ø)` | |\n| [node/src/main/scala/coop/rchain/node/conf.scala](https://codecov.io/gh/rchain/rchain/pull/758/diff?src=pr&el=tree#diff-bm9kZS9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9ub2RlL2NvbmYuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/rchain/rchain/pull/758?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/rchain/rchain/pull/758?src=pr&el=footer). Last update [e40a923...9d0e1d2](https://codecov.io/gh/rchain/rchain/pull/758?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}