{"action":"created","comment":{"url":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/comments/240793828","pull_request_review_id":183899201,"id":240793828,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDc5MzgyOA==","diff_hunk":"@@ -140,7 +138,7 @@ private static Project deleteProject(Request req, Response res) {\n         Project project = requestProjectById(req, \"manage\");\n         boolean successfullyDeleted = project.delete();\n         if (!successfullyDeleted) {\n-            haltWithMessage(req, 400, \"Did not delete project.\");\n+            haltWithMessage(req, 500, \"Did not delete project.\", new Exception(\"Delete unsuccessful\"));","path":"src/main/java/com/conveyal/datatools/manager/controllers/api/ProjectController.java","position":49,"original_position":49,"commit_id":"28288340e9f0d6e9bea364584d6a63af628cd721","original_commit_id":"28288340e9f0d6e9bea364584d6a63af628cd721","user":{"login":"landonreed","id":2370911,"node_id":"MDQ6VXNlcjIzNzA5MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2370911?v=4","gravatar_id":"","url":"https://api.github.com/users/landonreed","html_url":"https://github.com/landonreed","followers_url":"https://api.github.com/users/landonreed/followers","following_url":"https://api.github.com/users/landonreed/following{/other_user}","gists_url":"https://api.github.com/users/landonreed/gists{/gist_id}","starred_url":"https://api.github.com/users/landonreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landonreed/subscriptions","organizations_url":"https://api.github.com/users/landonreed/orgs","repos_url":"https://api.github.com/users/landonreed/repos","events_url":"https://api.github.com/users/landonreed/events{/privacy}","received_events_url":"https://api.github.com/users/landonreed/received_events","type":"User","site_admin":false},"body":"It doesn't seem great to be just creating arbitrary exceptions here that are not really tied back to the \"failing\" code. Do we gain anything by having a bugsnag report that points back here?","created_at":"2018-12-11T21:16:46Z","updated_at":"2018-12-11T21:24:08Z","html_url":"https://github.com/catalogueglobal/datatools-server/pull/108#discussion_r240793828","pull_request_url":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/108","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/comments/240793828"},"html":{"href":"https://github.com/catalogueglobal/datatools-server/pull/108#discussion_r240793828"},"pull_request":{"href":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/108","id":206527561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTI3NTYx","html_url":"https://github.com/catalogueglobal/datatools-server/pull/108","diff_url":"https://github.com/catalogueglobal/datatools-server/pull/108.diff","patch_url":"https://github.com/catalogueglobal/datatools-server/pull/108.patch","issue_url":"https://api.github.com/repos/catalogueglobal/datatools-server/issues/108","number":108,"state":"open","locked":false,"title":"Create Bugsnag reports when errors are encountered","user":{"login":"evansiroky","id":3112493,"node_id":"MDQ6VXNlcjMxMTI0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3112493?v=4","gravatar_id":"","url":"https://api.github.com/users/evansiroky","html_url":"https://github.com/evansiroky","followers_url":"https://api.github.com/users/evansiroky/followers","following_url":"https://api.github.com/users/evansiroky/following{/other_user}","gists_url":"https://api.github.com/users/evansiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/evansiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansiroky/subscriptions","organizations_url":"https://api.github.com/users/evansiroky/orgs","repos_url":"https://api.github.com/users/evansiroky/repos","events_url":"https://api.github.com/users/evansiroky/events{/privacy}","received_events_url":"https://api.github.com/users/evansiroky/received_events","type":"User","site_admin":false},"body":"The goal of this PR is to try to catch all possible halt-inducing exceptions that result in an HTTP >= 500 error and create Bugsnag reports from the exception.","created_at":"2018-08-06T21:56:54Z","updated_at":"2018-12-11T21:24:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"949a6e501f2fa719882251cab448e75a3e93ac7d","assignee":{"login":"landonreed","id":2370911,"node_id":"MDQ6VXNlcjIzNzA5MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2370911?v=4","gravatar_id":"","url":"https://api.github.com/users/landonreed","html_url":"https://github.com/landonreed","followers_url":"https://api.github.com/users/landonreed/followers","following_url":"https://api.github.com/users/landonreed/following{/other_user}","gists_url":"https://api.github.com/users/landonreed/gists{/gist_id}","starred_url":"https://api.github.com/users/landonreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landonreed/subscriptions","organizations_url":"https://api.github.com/users/landonreed/orgs","repos_url":"https://api.github.com/users/landonreed/repos","events_url":"https://api.github.com/users/landonreed/events{/privacy}","received_events_url":"https://api.github.com/users/landonreed/received_events","type":"User","site_admin":false},"assignees":[{"login":"landonreed","id":2370911,"node_id":"MDQ6VXNlcjIzNzA5MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2370911?v=4","gravatar_id":"","url":"https://api.github.com/users/landonreed","html_url":"https://github.com/landonreed","followers_url":"https://api.github.com/users/landonreed/followers","following_url":"https://api.github.com/users/landonreed/following{/other_user}","gists_url":"https://api.github.com/users/landonreed/gists{/gist_id}","starred_url":"https://api.github.com/users/landonreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landonreed/subscriptions","organizations_url":"https://api.github.com/users/landonreed/orgs","repos_url":"https://api.github.com/users/landonreed/repos","events_url":"https://api.github.com/users/landonreed/events{/privacy}","received_events_url":"https://api.github.com/users/landonreed/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/108/commits","review_comments_url":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/108/comments","review_comment_url":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/catalogueglobal/datatools-server/issues/108/comments","statuses_url":"https://api.github.com/repos/catalogueglobal/datatools-server/statuses/28288340e9f0d6e9bea364584d6a63af628cd721","head":{"label":"catalogueglobal:error-logging","ref":"error-logging","sha":"28288340e9f0d6e9bea364584d6a63af628cd721","user":{"login":"catalogueglobal","id":22768964,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzY4OTY0","avatar_url":"https://avatars2.githubusercontent.com/u/22768964?v=4","gravatar_id":"","url":"https://api.github.com/users/catalogueglobal","html_url":"https://github.com/catalogueglobal","followers_url":"https://api.github.com/users/catalogueglobal/followers","following_url":"https://api.github.com/users/catalogueglobal/following{/other_user}","gists_url":"https://api.github.com/users/catalogueglobal/gists{/gist_id}","starred_url":"https://api.github.com/users/catalogueglobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalogueglobal/subscriptions","organizations_url":"https://api.github.com/users/catalogueglobal/orgs","repos_url":"https://api.github.com/users/catalogueglobal/repos","events_url":"https://api.github.com/users/catalogueglobal/events{/privacy}","received_events_url":"https://api.github.com/users/catalogueglobal/received_events","type":"Organization","site_admin":false},"repo":{"id":84188481,"node_id":"MDEwOlJlcG9zaXRvcnk4NDE4ODQ4MQ==","name":"datatools-server","full_name":"catalogueglobal/datatools-server","private":false,"owner":{"login":"catalogueglobal","id":22768964,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzY4OTY0","avatar_url":"https://avatars2.githubusercontent.com/u/22768964?v=4","gravatar_id":"","url":"https://api.github.com/users/catalogueglobal","html_url":"https://github.com/catalogueglobal","followers_url":"https://api.github.com/users/catalogueglobal/followers","following_url":"https://api.github.com/users/catalogueglobal/following{/other_user}","gists_url":"https://api.github.com/users/catalogueglobal/gists{/gist_id}","starred_url":"https://api.github.com/users/catalogueglobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalogueglobal/subscriptions","organizations_url":"https://api.github.com/users/catalogueglobal/orgs","repos_url":"https://api.github.com/users/catalogueglobal/repos","events_url":"https://api.github.com/users/catalogueglobal/events{/privacy}","received_events_url":"https://api.github.com/users/catalogueglobal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catalogueglobal/datatools-server","description":"Server for Conveyal's GTFS data management platform. NOTE: Active development has returned to https://github.com/conveyal/datatools-server","fork":true,"url":"https://api.github.com/repos/catalogueglobal/datatools-server","forks_url":"https://api.github.com/repos/catalogueglobal/datatools-server/forks","keys_url":"https://api.github.com/repos/catalogueglobal/datatools-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catalogueglobal/datatools-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catalogueglobal/datatools-server/teams","hooks_url":"https://api.github.com/repos/catalogueglobal/datatools-server/hooks","issue_events_url":"https://api.github.com/repos/catalogueglobal/datatools-server/issues/events{/number}","events_url":"https://api.github.com/repos/catalogueglobal/datatools-server/events","assignees_url":"https://api.github.com/repos/catalogueglobal/datatools-server/assignees{/user}","branches_url":"https://api.github.com/repos/catalogueglobal/datatools-server/branches{/branch}","tags_url":"https://api.github.com/repos/catalogueglobal/datatools-server/tags","blobs_url":"https://api.github.com/repos/catalogueglobal/datatools-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catalogueglobal/datatools-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catalogueglobal/datatools-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/catalogueglobal/datatools-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catalogueglobal/datatools-server/statuses/{sha}","languages_url":"https://api.github.com/repos/catalogueglobal/datatools-server/languages","stargazers_url":"https://api.github.com/repos/catalogueglobal/datatools-server/stargazers","contributors_url":"https://api.github.com/repos/catalogueglobal/datatools-server/contributors","subscribers_url":"https://api.github.com/repos/catalogueglobal/datatools-server/subscribers","subscription_url":"https://api.github.com/repos/catalogueglobal/datatools-server/subscription","commits_url":"https://api.github.com/repos/catalogueglobal/datatools-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/catalogueglobal/datatools-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/catalogueglobal/datatools-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/catalogueglobal/datatools-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/catalogueglobal/datatools-server/contents/{+path}","compare_url":"https://api.github.com/repos/catalogueglobal/datatools-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catalogueglobal/datatools-server/merges","archive_url":"https://api.github.com/repos/catalogueglobal/datatools-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catalogueglobal/datatools-server/downloads","issues_url":"https://api.github.com/repos/catalogueglobal/datatools-server/issues{/number}","pulls_url":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls{/number}","milestones_url":"https://api.github.com/repos/catalogueglobal/datatools-server/milestones{/number}","notifications_url":"https://api.github.com/repos/catalogueglobal/datatools-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catalogueglobal/datatools-server/labels{/name}","releases_url":"https://api.github.com/repos/catalogueglobal/datatools-server/releases{/id}","deployments_url":"https://api.github.com/repos/catalogueglobal/datatools-server/deployments","created_at":"2017-03-07T10:52:35Z","updated_at":"2018-12-11T20:03:07Z","pushed_at":"2018-12-11T20:03:04Z","git_url":"git://github.com/catalogueglobal/datatools-server.git","ssh_url":"git@github.com:catalogueglobal/datatools-server.git","clone_url":"https://github.com/catalogueglobal/datatools-server.git","svn_url":"https://github.com/catalogueglobal/datatools-server","homepage":"","size":2364,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":27,"watchers":12,"default_branch":"dev"}},"base":{"label":"catalogueglobal:dev","ref":"dev","sha":"1db34f2594dc622961c87796177e4299397ec8de","user":{"login":"catalogueglobal","id":22768964,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzY4OTY0","avatar_url":"https://avatars2.githubusercontent.com/u/22768964?v=4","gravatar_id":"","url":"https://api.github.com/users/catalogueglobal","html_url":"https://github.com/catalogueglobal","followers_url":"https://api.github.com/users/catalogueglobal/followers","following_url":"https://api.github.com/users/catalogueglobal/following{/other_user}","gists_url":"https://api.github.com/users/catalogueglobal/gists{/gist_id}","starred_url":"https://api.github.com/users/catalogueglobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalogueglobal/subscriptions","organizations_url":"https://api.github.com/users/catalogueglobal/orgs","repos_url":"https://api.github.com/users/catalogueglobal/repos","events_url":"https://api.github.com/users/catalogueglobal/events{/privacy}","received_events_url":"https://api.github.com/users/catalogueglobal/received_events","type":"Organization","site_admin":false},"repo":{"id":84188481,"node_id":"MDEwOlJlcG9zaXRvcnk4NDE4ODQ4MQ==","name":"datatools-server","full_name":"catalogueglobal/datatools-server","private":false,"owner":{"login":"catalogueglobal","id":22768964,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzY4OTY0","avatar_url":"https://avatars2.githubusercontent.com/u/22768964?v=4","gravatar_id":"","url":"https://api.github.com/users/catalogueglobal","html_url":"https://github.com/catalogueglobal","followers_url":"https://api.github.com/users/catalogueglobal/followers","following_url":"https://api.github.com/users/catalogueglobal/following{/other_user}","gists_url":"https://api.github.com/users/catalogueglobal/gists{/gist_id}","starred_url":"https://api.github.com/users/catalogueglobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalogueglobal/subscriptions","organizations_url":"https://api.github.com/users/catalogueglobal/orgs","repos_url":"https://api.github.com/users/catalogueglobal/repos","events_url":"https://api.github.com/users/catalogueglobal/events{/privacy}","received_events_url":"https://api.github.com/users/catalogueglobal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catalogueglobal/datatools-server","description":"Server for Conveyal's GTFS data management platform. NOTE: Active development has returned to https://github.com/conveyal/datatools-server","fork":true,"url":"https://api.github.com/repos/catalogueglobal/datatools-server","forks_url":"https://api.github.com/repos/catalogueglobal/datatools-server/forks","keys_url":"https://api.github.com/repos/catalogueglobal/datatools-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catalogueglobal/datatools-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catalogueglobal/datatools-server/teams","hooks_url":"https://api.github.com/repos/catalogueglobal/datatools-server/hooks","issue_events_url":"https://api.github.com/repos/catalogueglobal/datatools-server/issues/events{/number}","events_url":"https://api.github.com/repos/catalogueglobal/datatools-server/events","assignees_url":"https://api.github.com/repos/catalogueglobal/datatools-server/assignees{/user}","branches_url":"https://api.github.com/repos/catalogueglobal/datatools-server/branches{/branch}","tags_url":"https://api.github.com/repos/catalogueglobal/datatools-server/tags","blobs_url":"https://api.github.com/repos/catalogueglobal/datatools-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catalogueglobal/datatools-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catalogueglobal/datatools-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/catalogueglobal/datatools-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catalogueglobal/datatools-server/statuses/{sha}","languages_url":"https://api.github.com/repos/catalogueglobal/datatools-server/languages","stargazers_url":"https://api.github.com/repos/catalogueglobal/datatools-server/stargazers","contributors_url":"https://api.github.com/repos/catalogueglobal/datatools-server/contributors","subscribers_url":"https://api.github.com/repos/catalogueglobal/datatools-server/subscribers","subscription_url":"https://api.github.com/repos/catalogueglobal/datatools-server/subscription","commits_url":"https://api.github.com/repos/catalogueglobal/datatools-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/catalogueglobal/datatools-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/catalogueglobal/datatools-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/catalogueglobal/datatools-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/catalogueglobal/datatools-server/contents/{+path}","compare_url":"https://api.github.com/repos/catalogueglobal/datatools-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catalogueglobal/datatools-server/merges","archive_url":"https://api.github.com/repos/catalogueglobal/datatools-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catalogueglobal/datatools-server/downloads","issues_url":"https://api.github.com/repos/catalogueglobal/datatools-server/issues{/number}","pulls_url":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls{/number}","milestones_url":"https://api.github.com/repos/catalogueglobal/datatools-server/milestones{/number}","notifications_url":"https://api.github.com/repos/catalogueglobal/datatools-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catalogueglobal/datatools-server/labels{/name}","releases_url":"https://api.github.com/repos/catalogueglobal/datatools-server/releases{/id}","deployments_url":"https://api.github.com/repos/catalogueglobal/datatools-server/deployments","created_at":"2017-03-07T10:52:35Z","updated_at":"2018-12-11T20:03:07Z","pushed_at":"2018-12-11T20:03:04Z","git_url":"git://github.com/catalogueglobal/datatools-server.git","ssh_url":"git@github.com:catalogueglobal/datatools-server.git","clone_url":"https://github.com/catalogueglobal/datatools-server.git","svn_url":"https://github.com/catalogueglobal/datatools-server","homepage":"","size":2364,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":27,"watchers":12,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/108"},"html":{"href":"https://github.com/catalogueglobal/datatools-server/pull/108"},"issue":{"href":"https://api.github.com/repos/catalogueglobal/datatools-server/issues/108"},"comments":{"href":"https://api.github.com/repos/catalogueglobal/datatools-server/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/catalogueglobal/datatools-server/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/catalogueglobal/datatools-server/statuses/28288340e9f0d6e9bea364584d6a63af628cd721"}},"author_association":"NONE"}}
{"actor":{"display_login":"landonreed"}}