{"action":"created","comment":{"url":"https://api.github.com/repos/passport-next/passport/pulls/comments/218066979","pull_request_review_id":155921447,"id":218066979,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODA2Njk3OQ==","diff_hunk":"@@ -245,51 +252,54 @@ Authenticator.prototype.sessionManager = function(mgr) {\n  *\n  * @api public\n  */\n-Authenticator.prototype.serializeUser = function(fn, req, done) {\n+\n+// eslint-disable-next-line consistent-return\n+Authenticator.prototype.serializeUser = function serializeUser(fn, req, done) {\n   if (typeof fn === 'function') {\n     return this._serializers.push(fn);\n   }\n-  \n+\n   // private implementation that traverses the chain of serializers, attempting\n   // to serialize a user\n-  var user = fn;\n+  const user = fn;\n \n   // For backwards compatibility\n   if (typeof req === 'function') {\n     done = req;\n     req = undefined;\n   }\n-  \n-  var stack = this._serializers;\n+\n+  const stack = this._serializers;\n+  // eslint-disable-next-line consistent-return","path":"lib/authenticator.js","position":154,"original_position":154,"commit_id":"d53ff7df95a11e7241e35dcf7d139a03fc74d5d5","original_commit_id":"d53ff7df95a11e7241e35dcf7d139a03fc74d5d5","user":{"login":"guyellis","id":2047725,"node_id":"MDQ6VXNlcjIwNDc3MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2047725?v=4","gravatar_id":"","url":"https://api.github.com/users/guyellis","html_url":"https://github.com/guyellis","followers_url":"https://api.github.com/users/guyellis/followers","following_url":"https://api.github.com/users/guyellis/following{/other_user}","gists_url":"https://api.github.com/users/guyellis/gists{/gist_id}","starred_url":"https://api.github.com/users/guyellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyellis/subscriptions","organizations_url":"https://api.github.com/users/guyellis/orgs","repos_url":"https://api.github.com/users/guyellis/repos","events_url":"https://api.github.com/users/guyellis/events{/privacy}","received_events_url":"https://api.github.com/users/guyellis/received_events","type":"User","site_admin":false},"body":"If you `return` lines 274, 295, 297 you can get rid of the lint disable for `consistent-return` here and the one above it.","created_at":"2018-09-17T13:26:35Z","updated_at":"2018-09-17T13:51:07Z","html_url":"https://github.com/passport-next/passport/pull/10#discussion_r218066979","pull_request_url":"https://api.github.com/repos/passport-next/passport/pulls/10","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/passport-next/passport/pulls/comments/218066979"},"html":{"href":"https://github.com/passport-next/passport/pull/10#discussion_r218066979"},"pull_request":{"href":"https://api.github.com/repos/passport-next/passport/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/passport-next/passport/pulls/10","id":215887134,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODg3MTM0","html_url":"https://github.com/passport-next/passport/pull/10","diff_url":"https://github.com/passport-next/passport/pull/10.diff","patch_url":"https://github.com/passport-next/passport/pull/10.patch","issue_url":"https://api.github.com/repos/passport-next/passport/issues/10","number":10,"state":"open","locked":false,"title":"Added eslint configuration and fixed lint errors","user":{"login":"idurotola","id":8592741,"node_id":"MDQ6VXNlcjg1OTI3NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8592741?v=4","gravatar_id":"","url":"https://api.github.com/users/idurotola","html_url":"https://github.com/idurotola","followers_url":"https://api.github.com/users/idurotola/followers","following_url":"https://api.github.com/users/idurotola/following{/other_user}","gists_url":"https://api.github.com/users/idurotola/gists{/gist_id}","starred_url":"https://api.github.com/users/idurotola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idurotola/subscriptions","organizations_url":"https://api.github.com/users/idurotola/orgs","repos_url":"https://api.github.com/users/idurotola/repos","events_url":"https://api.github.com/users/idurotola/events{/privacy}","received_events_url":"https://api.github.com/users/idurotola/received_events","type":"User","site_admin":false},"body":"\r\n- [x] I have read the [CONTRIBUTING](https://github.com/jaredhanson/passport/blob/master/CONTRIBUTING.md) guidelines.\r\n- [x] I have added test cases which verify the correct operation of this feature or patch.\r\n- [x] I have added documentation pertaining to this feature or patch.\r\n- [x] The automated test suite (`$ make test`) executes successfully.\r\n- [x] The automated code linting (`$ make lint`) executes successfully.\r\n","created_at":"2018-09-17T06:55:35Z","updated_at":"2018-09-17T13:51:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc07e59f6bdf9780bb42e6ad17c7092612cac613","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/passport-next/passport/pulls/10/commits","review_comments_url":"https://api.github.com/repos/passport-next/passport/pulls/10/comments","review_comment_url":"https://api.github.com/repos/passport-next/passport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/passport-next/passport/issues/10/comments","statuses_url":"https://api.github.com/repos/passport-next/passport/statuses/d53ff7df95a11e7241e35dcf7d139a03fc74d5d5","head":{"label":"passport-next:Add-eslint-configuration","ref":"Add-eslint-configuration","sha":"d53ff7df95a11e7241e35dcf7d139a03fc74d5d5","user":{"login":"passport-next","id":40698500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjk4NTAw","avatar_url":"https://avatars1.githubusercontent.com/u/40698500?v=4","gravatar_id":"","url":"https://api.github.com/users/passport-next","html_url":"https://github.com/passport-next","followers_url":"https://api.github.com/users/passport-next/followers","following_url":"https://api.github.com/users/passport-next/following{/other_user}","gists_url":"https://api.github.com/users/passport-next/gists{/gist_id}","starred_url":"https://api.github.com/users/passport-next/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/passport-next/subscriptions","organizations_url":"https://api.github.com/users/passport-next/orgs","repos_url":"https://api.github.com/users/passport-next/repos","events_url":"https://api.github.com/users/passport-next/events{/privacy}","received_events_url":"https://api.github.com/users/passport-next/received_events","type":"Organization","site_admin":false},"repo":{"id":139170662,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxNzA2NjI=","name":"passport","full_name":"passport-next/passport","private":false,"owner":{"login":"passport-next","id":40698500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjk4NTAw","avatar_url":"https://avatars1.githubusercontent.com/u/40698500?v=4","gravatar_id":"","url":"https://api.github.com/users/passport-next","html_url":"https://github.com/passport-next","followers_url":"https://api.github.com/users/passport-next/followers","following_url":"https://api.github.com/users/passport-next/following{/other_user}","gists_url":"https://api.github.com/users/passport-next/gists{/gist_id}","starred_url":"https://api.github.com/users/passport-next/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/passport-next/subscriptions","organizations_url":"https://api.github.com/users/passport-next/orgs","repos_url":"https://api.github.com/users/passport-next/repos","events_url":"https://api.github.com/users/passport-next/events{/privacy}","received_events_url":"https://api.github.com/users/passport-next/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/passport-next/passport","description":"Simple, unobtrusive authentication for Node.js.","fork":true,"url":"https://api.github.com/repos/passport-next/passport","forks_url":"https://api.github.com/repos/passport-next/passport/forks","keys_url":"https://api.github.com/repos/passport-next/passport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/passport-next/passport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/passport-next/passport/teams","hooks_url":"https://api.github.com/repos/passport-next/passport/hooks","issue_events_url":"https://api.github.com/repos/passport-next/passport/issues/events{/number}","events_url":"https://api.github.com/repos/passport-next/passport/events","assignees_url":"https://api.github.com/repos/passport-next/passport/assignees{/user}","branches_url":"https://api.github.com/repos/passport-next/passport/branches{/branch}","tags_url":"https://api.github.com/repos/passport-next/passport/tags","blobs_url":"https://api.github.com/repos/passport-next/passport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/passport-next/passport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/passport-next/passport/git/refs{/sha}","trees_url":"https://api.github.com/repos/passport-next/passport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/passport-next/passport/statuses/{sha}","languages_url":"https://api.github.com/repos/passport-next/passport/languages","stargazers_url":"https://api.github.com/repos/passport-next/passport/stargazers","contributors_url":"https://api.github.com/repos/passport-next/passport/contributors","subscribers_url":"https://api.github.com/repos/passport-next/passport/subscribers","subscription_url":"https://api.github.com/repos/passport-next/passport/subscription","commits_url":"https://api.github.com/repos/passport-next/passport/commits{/sha}","git_commits_url":"https://api.github.com/repos/passport-next/passport/git/commits{/sha}","comments_url":"https://api.github.com/repos/passport-next/passport/comments{/number}","issue_comment_url":"https://api.github.com/repos/passport-next/passport/issues/comments{/number}","contents_url":"https://api.github.com/repos/passport-next/passport/contents/{+path}","compare_url":"https://api.github.com/repos/passport-next/passport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/passport-next/passport/merges","archive_url":"https://api.github.com/repos/passport-next/passport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/passport-next/passport/downloads","issues_url":"https://api.github.com/repos/passport-next/passport/issues{/number}","pulls_url":"https://api.github.com/repos/passport-next/passport/pulls{/number}","milestones_url":"https://api.github.com/repos/passport-next/passport/milestones{/number}","notifications_url":"https://api.github.com/repos/passport-next/passport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/passport-next/passport/labels{/name}","releases_url":"https://api.github.com/repos/passport-next/passport/releases{/id}","deployments_url":"https://api.github.com/repos/passport-next/passport/deployments","created_at":"2018-06-29T16:11:10Z","updated_at":"2018-09-14T07:47:36Z","pushed_at":"2018-09-17T06:55:36Z","git_url":"git://github.com/passport-next/passport.git","ssh_url":"git@github.com:passport-next/passport.git","clone_url":"https://github.com/passport-next/passport.git","svn_url":"https://github.com/passport-next/passport","homepage":"http://www.passportjs.org","size":458,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"passport-next:master","ref":"master","sha":"424905b980d3bd4c1d8d58f0970274f0ed771340","user":{"login":"passport-next","id":40698500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjk4NTAw","avatar_url":"https://avatars1.githubusercontent.com/u/40698500?v=4","gravatar_id":"","url":"https://api.github.com/users/passport-next","html_url":"https://github.com/passport-next","followers_url":"https://api.github.com/users/passport-next/followers","following_url":"https://api.github.com/users/passport-next/following{/other_user}","gists_url":"https://api.github.com/users/passport-next/gists{/gist_id}","starred_url":"https://api.github.com/users/passport-next/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/passport-next/subscriptions","organizations_url":"https://api.github.com/users/passport-next/orgs","repos_url":"https://api.github.com/users/passport-next/repos","events_url":"https://api.github.com/users/passport-next/events{/privacy}","received_events_url":"https://api.github.com/users/passport-next/received_events","type":"Organization","site_admin":false},"repo":{"id":139170662,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxNzA2NjI=","name":"passport","full_name":"passport-next/passport","private":false,"owner":{"login":"passport-next","id":40698500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjk4NTAw","avatar_url":"https://avatars1.githubusercontent.com/u/40698500?v=4","gravatar_id":"","url":"https://api.github.com/users/passport-next","html_url":"https://github.com/passport-next","followers_url":"https://api.github.com/users/passport-next/followers","following_url":"https://api.github.com/users/passport-next/following{/other_user}","gists_url":"https://api.github.com/users/passport-next/gists{/gist_id}","starred_url":"https://api.github.com/users/passport-next/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/passport-next/subscriptions","organizations_url":"https://api.github.com/users/passport-next/orgs","repos_url":"https://api.github.com/users/passport-next/repos","events_url":"https://api.github.com/users/passport-next/events{/privacy}","received_events_url":"https://api.github.com/users/passport-next/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/passport-next/passport","description":"Simple, unobtrusive authentication for Node.js.","fork":true,"url":"https://api.github.com/repos/passport-next/passport","forks_url":"https://api.github.com/repos/passport-next/passport/forks","keys_url":"https://api.github.com/repos/passport-next/passport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/passport-next/passport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/passport-next/passport/teams","hooks_url":"https://api.github.com/repos/passport-next/passport/hooks","issue_events_url":"https://api.github.com/repos/passport-next/passport/issues/events{/number}","events_url":"https://api.github.com/repos/passport-next/passport/events","assignees_url":"https://api.github.com/repos/passport-next/passport/assignees{/user}","branches_url":"https://api.github.com/repos/passport-next/passport/branches{/branch}","tags_url":"https://api.github.com/repos/passport-next/passport/tags","blobs_url":"https://api.github.com/repos/passport-next/passport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/passport-next/passport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/passport-next/passport/git/refs{/sha}","trees_url":"https://api.github.com/repos/passport-next/passport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/passport-next/passport/statuses/{sha}","languages_url":"https://api.github.com/repos/passport-next/passport/languages","stargazers_url":"https://api.github.com/repos/passport-next/passport/stargazers","contributors_url":"https://api.github.com/repos/passport-next/passport/contributors","subscribers_url":"https://api.github.com/repos/passport-next/passport/subscribers","subscription_url":"https://api.github.com/repos/passport-next/passport/subscription","commits_url":"https://api.github.com/repos/passport-next/passport/commits{/sha}","git_commits_url":"https://api.github.com/repos/passport-next/passport/git/commits{/sha}","comments_url":"https://api.github.com/repos/passport-next/passport/comments{/number}","issue_comment_url":"https://api.github.com/repos/passport-next/passport/issues/comments{/number}","contents_url":"https://api.github.com/repos/passport-next/passport/contents/{+path}","compare_url":"https://api.github.com/repos/passport-next/passport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/passport-next/passport/merges","archive_url":"https://api.github.com/repos/passport-next/passport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/passport-next/passport/downloads","issues_url":"https://api.github.com/repos/passport-next/passport/issues{/number}","pulls_url":"https://api.github.com/repos/passport-next/passport/pulls{/number}","milestones_url":"https://api.github.com/repos/passport-next/passport/milestones{/number}","notifications_url":"https://api.github.com/repos/passport-next/passport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/passport-next/passport/labels{/name}","releases_url":"https://api.github.com/repos/passport-next/passport/releases{/id}","deployments_url":"https://api.github.com/repos/passport-next/passport/deployments","created_at":"2018-06-29T16:11:10Z","updated_at":"2018-09-14T07:47:36Z","pushed_at":"2018-09-17T06:55:36Z","git_url":"git://github.com/passport-next/passport.git","ssh_url":"git@github.com:passport-next/passport.git","clone_url":"https://github.com/passport-next/passport.git","svn_url":"https://github.com/passport-next/passport","homepage":"http://www.passportjs.org","size":458,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/passport-next/passport/pulls/10"},"html":{"href":"https://github.com/passport-next/passport/pull/10"},"issue":{"href":"https://api.github.com/repos/passport-next/passport/issues/10"},"comments":{"href":"https://api.github.com/repos/passport-next/passport/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/passport-next/passport/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/passport-next/passport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/passport-next/passport/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/passport-next/passport/statuses/d53ff7df95a11e7241e35dcf7d139a03fc74d5d5"}},"author_association":"NONE"}}
{"actor":{"display_login":"guyellis"}}