{"push_id":2308146029,"size":2,"distinct_size":2,"ref":"refs/heads/stable/ocata","head":"5853222281c8ee6b2dd2e70caf91c5d735abae64","before":"a20ac620d2bd68b73089f9b85d9d1961b12185c2","commits":[{"sha":"b9f9e0912101f28d4a3706b16f194b4f17ae60c2","author":{"name":"melanie witt","email":"ee97f71ca31364b3e27004ca8e4075a69ad0425b@gmail.com"},"message":"Don't wait for vif plug events during _hard_reboot\n\nOriginally, in change Id188d48609f3d22d14e16c7f6114291d547a8986 we\nadded a re-initialization of volumes, encryptors, and vifs to hard\nreboot. When creating the libvirt domain and network, we were waiting\nfor vif plug events from neutron when we replugged the vifs. Then, we\nstarted seeing timeouts in the linuxbridge gate job because compute\nwas timing out waiting for plug events from neutron during a hard\nreboot.\n\nIt turns out that the behavior of neutron plug events depends on what\nvif type we're using and we're also using a stale network info_cache\nthroughout the hard reboot code path, so we can't be 100% sure we know\nwhich vifs to wait for plug events from anyway. We coincidentally get\nsome info_cache refreshes from network-changed events from neutron,\nbut we shouldn't rely on that.\n\nIdeally, we could do something like wait for an unplug event after we\nunplug the vif, then refresh the network_info cache, then wait for the\nplug event. BUT, in the case of the os-vif linuxbridge unplug method,\nit is a no-op, so I don't think we could expect to get an unplug\nevent for it (and we don't see any network-vif-unplugged events sent\nin the q-svc log for the linuxbridge job during a hard reboot).\n\nConflicts:\n        nova/tests/unit/virt/libvirt/test_driver.py\n        nova/virt/libvirt/driver.py\n\nNOTE(lyarwood): As with the stable/ocata version of\nId188d48609f3d22d14e16c7f6114291d547a8986 these conflicts are caused by\n_create_domain_and_network using an additional disk_info argument in O.\n\nCloses-Bug: #1744361\n\nChange-Id: Ib0cf5d55750f13d0499a570f14024dca551ed4d4\n(cherry picked from commit 236bb54493385bcfe2034e8b0fd7a387fa66635a)\n(cherry picked from commit 83ffc76edd360929925fc4bb66e5dcbf8254a30e)","distinct":true,"url":"https://api.github.com/repos/openstack/nova/commits/b9f9e0912101f28d4a3706b16f194b4f17ae60c2"},{"sha":"5853222281c8ee6b2dd2e70caf91c5d735abae64","author":{"name":"Zuul","email":"b5147e09c50e2df98187d616e488bd7083ad47b4@review.openstack.org"},"message":"Merge \"Don't wait for vif plug events during _hard_reboot\" into stable/ocata","distinct":true,"url":"https://api.github.com/repos/openstack/nova/commits/5853222281c8ee6b2dd2e70caf91c5d735abae64"}]}
{"actor":{"display_login":"openstack-gerrit"}}