{"action":"created","issue":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/250","repository_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver","labels_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/250/labels{/name}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/250/comments","events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/250/events","html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/250","id":389524297,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDk1NjU2","number":250,"title":"fix crash on IRC notice with non-ascii characters","user":{"login":"undeath","id":1469278,"node_id":"MDQ6VXNlcjE0NjkyNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1469278?v=4","gravatar_id":"","url":"https://api.github.com/users/undeath","html_url":"https://github.com/undeath","followers_url":"https://api.github.com/users/undeath/followers","following_url":"https://api.github.com/users/undeath/following{/other_user}","gists_url":"https://api.github.com/users/undeath/gists{/gist_id}","starred_url":"https://api.github.com/users/undeath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undeath/subscriptions","organizations_url":"https://api.github.com/users/undeath/orgs","repos_url":"https://api.github.com/users/undeath/repos","events_url":"https://api.github.com/users/undeath/events{/privacy}","received_events_url":"https://api.github.com/users/undeath/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-10T22:59:53Z","updated_at":"2018-12-15T20:34:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/pulls/250","html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/250","diff_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/250.diff","patch_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/250.patch"},"body":"When receiving a notice on IRC that includes common formatting codes bytes or other non-ascii characters the daemon will crash.\r\n\r\ncrash trace:\r\n\r\n\tUnhandled Error\r\n\tTraceback (most recent call last):\r\n\t  File \"/lib/python2.7/site-packages/twisted/protocols/policies.py\", line 120, in dataReceived\r\n\t    self.wrappedProtocol.dataReceived(data)\r\n\t  File \"/lib/python2.7/site-packages/twisted/words/protocols/irc.py\", line 2631, in dataReceived\r\n\t    basic.LineReceiver.dataReceived(self, data)\r\n\t  File \"/lib/python2.7/site-packages/twisted/protocols/basic.py\", line 572, in dataReceived\r\n\t    why = self.lineReceived(line)\r\n\t  File \"/lib/python2.7/site-packages/twisted/words/protocols/irc.py\", line 2644, in lineReceived\r\n\t    self.handleCommand(command, prefix, params)\r\n\t--- <exception caught here> ---\r\n\t  File \"/lib/python2.7/site-packages/twisted/words/protocols/irc.py\", line 2699, in handleCommand\r\n\t    method(prefix, params)\r\n\t  File \"/lib/python2.7/site-packages/twisted/words/protocols/irc.py\", line 2076, in irc_NOTICE\r\n\t    self.noticed(user, channel, message)\r\n\t  File \"jmdaemon/jmdaemon/irc.py\", line 405, in noticed\r\n\t    wlog('(unhandled) noticed: ', user, channel, message)\r\n\t  File \"jmdaemon/jmdaemon/irc.py\", line 26, in wlog\r\n\t    msg = \" \".join([str(a) for a in x])\r\n\t  File \"/lib/python2.7/site-packages/future/types/newstr.py\", line 102, in __new__\r\n\t    return super(newstr, cls).__new__(cls, value)\r\n\texceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 60: ordinal not in range(128)"},"comment":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/comments/447596082","html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/250#issuecomment-447596082","issue_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/250","id":447596082,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzU5NjA4Mg==","user":{"login":"undeath","id":1469278,"node_id":"MDQ6VXNlcjE0NjkyNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1469278?v=4","gravatar_id":"","url":"https://api.github.com/users/undeath","html_url":"https://github.com/undeath","followers_url":"https://api.github.com/users/undeath/followers","following_url":"https://api.github.com/users/undeath/following{/other_user}","gists_url":"https://api.github.com/users/undeath/gists{/gist_id}","starred_url":"https://api.github.com/users/undeath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undeath/subscriptions","organizations_url":"https://api.github.com/users/undeath/orgs","repos_url":"https://api.github.com/users/undeath/repos","events_url":"https://api.github.com/users/undeath/events{/privacy}","received_events_url":"https://api.github.com/users/undeath/received_events","type":"User","site_admin":false},"created_at":"2018-12-15T20:34:42Z","updated_at":"2018-12-15T20:34:42Z","author_association":"CONTRIBUTOR","body":"I'm not 100% sure if this is needed or was a problem with the particular commit I was running. It should, in the worst case, only bloat the code a bit, so merging will not break anything."}}
{"actor":{"display_login":"undeath"}}