{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/223138005","pull_request_review_id":162202842,"id":223138005,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzEzODAwNQ==","diff_hunk":"@@ -16,36 +16,38 @@\n #define dout_subsys ceph_subsys_rgw\n \n \n-int RGWServices_Shared::init(CephContext *cct,\n-                             bool have_cache)\n+RGWServices_Def::RGWServices_Def() = default;\n+RGWServices_Def::~RGWServices_Def() = default;\n+\n+int RGWServices_Def::init(CephContext *cct,\n+\t\t\t  bool have_cache)\n {\n-  finisher = std::make_shared<RGWSI_Finisher>(cct);\n-  notify = std::make_shared<RGWSI_Notify>(cct);\n-  rados = std::make_shared<RGWSI_RADOS>(cct);\n-  zone = std::make_shared<RGWSI_Zone>(cct);\n-  zone_utils = std::make_shared<RGWSI_ZoneUtils>(cct);\n-  quota = std::make_shared<RGWSI_Quota>(cct);\n-  sync_modules = std::make_shared<RGWSI_SyncModules>(cct);\n-  sysobj = std::make_shared<RGWSI_SysObj>(cct);\n-  sysobj_core = std::make_shared<RGWSI_SysObj_Core>(cct);\n+  finisher = std::make_unique<RGWSI_Finisher>(cct);","path":"src/rgw/rgw_service.cc","position":25,"original_position":21,"commit_id":"b0b9a4a8055915f9940bb4fafbc52c85be2badf0","original_commit_id":"b0b9a4a8055915f9940bb4fafbc52c85be2badf0","user":{"login":"mattbenjamin","id":301287,"node_id":"MDQ6VXNlcjMwMTI4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/301287?v=4","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false},"body":"yay","created_at":"2018-10-05T21:02:23Z","updated_at":"2018-10-05T21:04:02Z","html_url":"https://github.com/ceph/ceph/pull/24014#discussion_r223138005","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/24014","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/223138005"},"html":{"href":"https://github.com/ceph/ceph/pull/24014#discussion_r223138005"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24014"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/24014","id":214358057,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzU4MDU3","html_url":"https://github.com/ceph/ceph/pull/24014","diff_url":"https://github.com/ceph/ceph/pull/24014.diff","patch_url":"https://github.com/ceph/ceph/pull/24014.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/24014","number":24014,"state":"open","locked":false,"title":"[DNM] rgw: initial RGWRados refactoring work","user":{"login":"yehudasa","id":1036377,"node_id":"MDQ6VXNlcjEwMzYzNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1036377?v=4","gravatar_id":"","url":"https://api.github.com/users/yehudasa","html_url":"https://github.com/yehudasa","followers_url":"https://api.github.com/users/yehudasa/followers","following_url":"https://api.github.com/users/yehudasa/following{/other_user}","gists_url":"https://api.github.com/users/yehudasa/gists{/gist_id}","starred_url":"https://api.github.com/users/yehudasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yehudasa/subscriptions","organizations_url":"https://api.github.com/users/yehudasa/orgs","repos_url":"https://api.github.com/users/yehudasa/repos","events_url":"https://api.github.com/users/yehudasa/events{/privacy}","received_events_url":"https://api.github.com/users/yehudasa/received_events","type":"User","site_admin":false},"body":"First step in a major refactoring work that breaks down RGWRados into different \"services\". The services are instantiated via a service registry and can define some dependency between them. Currently RGWRados is a container to such services: `zone`, `sysobj`, `cache`, `quota`, etc.\r\nThe new system objects service has a `sysobj_core` service that it uses for the core operations. A cache service can extend this service. There is also the `rados` service that is being used. The sysobj service provides new system objects access api, and it should supersede all other similar apis (future work should include this cleanup).\r\nThe more interesting next step in this cleanup work would be to move the rgw data objects access into its own set of services, and provide different backend implementations. This will be used for tiering work.\r\n\r\nDNM: only lightly tested, and considering the size of the change, things likely broke.\r\n","created_at":"2018-09-10T15:39:03Z","updated_at":"2018-10-05T21:04:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f6b81c7e3917230f86b3476776e7615db2c20f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":144329618,"node_id":"MDU6TGFiZWwxNDQzMjk2MTg=","url":"https://api.github.com/repos/ceph/ceph/labels/rgw","name":"rgw","color":"00ffe4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/24014/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/24014/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/24014/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/b0b9a4a8055915f9940bb4fafbc52c85be2badf0","head":{"label":"yehudasa:wip-rgw-svc-2","ref":"wip-rgw-svc-2","sha":"b0b9a4a8055915f9940bb4fafbc52c85be2badf0","user":{"login":"yehudasa","id":1036377,"node_id":"MDQ6VXNlcjEwMzYzNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1036377?v=4","gravatar_id":"","url":"https://api.github.com/users/yehudasa","html_url":"https://github.com/yehudasa","followers_url":"https://api.github.com/users/yehudasa/followers","following_url":"https://api.github.com/users/yehudasa/following{/other_user}","gists_url":"https://api.github.com/users/yehudasa/gists{/gist_id}","starred_url":"https://api.github.com/users/yehudasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yehudasa/subscriptions","organizations_url":"https://api.github.com/users/yehudasa/orgs","repos_url":"https://api.github.com/users/yehudasa/repos","events_url":"https://api.github.com/users/yehudasa/events{/privacy}","received_events_url":"https://api.github.com/users/yehudasa/received_events","type":"User","site_admin":false},"repo":{"id":7942703,"node_id":"MDEwOlJlcG9zaXRvcnk3OTQyNzAz","name":"ceph","full_name":"yehudasa/ceph","private":false,"owner":{"login":"yehudasa","id":1036377,"node_id":"MDQ6VXNlcjEwMzYzNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1036377?v=4","gravatar_id":"","url":"https://api.github.com/users/yehudasa","html_url":"https://github.com/yehudasa","followers_url":"https://api.github.com/users/yehudasa/followers","following_url":"https://api.github.com/users/yehudasa/following{/other_user}","gists_url":"https://api.github.com/users/yehudasa/gists{/gist_id}","starred_url":"https://api.github.com/users/yehudasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yehudasa/subscriptions","organizations_url":"https://api.github.com/users/yehudasa/orgs","repos_url":"https://api.github.com/users/yehudasa/repos","events_url":"https://api.github.com/users/yehudasa/events{/privacy}","received_events_url":"https://api.github.com/users/yehudasa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yehudasa/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/yehudasa/ceph","forks_url":"https://api.github.com/repos/yehudasa/ceph/forks","keys_url":"https://api.github.com/repos/yehudasa/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yehudasa/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yehudasa/ceph/teams","hooks_url":"https://api.github.com/repos/yehudasa/ceph/hooks","issue_events_url":"https://api.github.com/repos/yehudasa/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/yehudasa/ceph/events","assignees_url":"https://api.github.com/repos/yehudasa/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/yehudasa/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/yehudasa/ceph/tags","blobs_url":"https://api.github.com/repos/yehudasa/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yehudasa/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yehudasa/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/yehudasa/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yehudasa/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/yehudasa/ceph/languages","stargazers_url":"https://api.github.com/repos/yehudasa/ceph/stargazers","contributors_url":"https://api.github.com/repos/yehudasa/ceph/contributors","subscribers_url":"https://api.github.com/repos/yehudasa/ceph/subscribers","subscription_url":"https://api.github.com/repos/yehudasa/ceph/subscription","commits_url":"https://api.github.com/repos/yehudasa/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/yehudasa/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/yehudasa/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/yehudasa/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/yehudasa/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/yehudasa/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yehudasa/ceph/merges","archive_url":"https://api.github.com/repos/yehudasa/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yehudasa/ceph/downloads","issues_url":"https://api.github.com/repos/yehudasa/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/yehudasa/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/yehudasa/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/yehudasa/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yehudasa/ceph/labels{/name}","releases_url":"https://api.github.com/repos/yehudasa/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/yehudasa/ceph/deployments","created_at":"2013-01-31T18:30:02Z","updated_at":"2018-01-22T18:43:50Z","pushed_at":"2018-10-05T20:53:35Z","git_url":"git://github.com/yehudasa/ceph.git","ssh_url":"git@github.com:yehudasa/ceph.git","clone_url":"https://github.com/yehudasa/ceph.git","svn_url":"https://github.com/yehudasa/ceph","homepage":"http://ceph.com","size":299324,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"864594f473da1f04c476eb27073a8c2ea735a982","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-10-05T17:18:52Z","pushed_at":"2018-10-05T20:57:45Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":316548,"stargazers_count":5134,"watchers_count":5134,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2672,"mirror_url":null,"archived":false,"open_issues_count":741,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2672,"open_issues":741,"watchers":5134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24014"},"html":{"href":"https://github.com/ceph/ceph/pull/24014"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/24014"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/24014/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24014/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24014/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/b0b9a4a8055915f9940bb4fafbc52c85be2badf0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mattbenjamin"}}