{"action":"created","comment":{"url":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/comments/216033257","pull_request_review_id":153436227,"id":216033257,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjAzMzI1Nw==","diff_hunk":"@@ -143,7 +143,15 @@ def does_interval_narrow((x1, y1), (x2, y2)):\n     \"\"\"Return True if the second interval is narrower than the first.\"\"\"\n \n     assert y1 >= x1 and y2 >= x2\n-    ratio = float(y2 - x2) / float(y1 - x1)\n+    # Sometimes there is no variation in a dataset (more likely for steady iter\n+    # than steady perf, for obvious reasons). So, we check for special cases,\n+    # rather than causing a divide by zero.\n+    diff1, diff2 = y1 - x1, y2 - x2\n+    if diff1 == 0 and diff2 > 0:","path":"bin/diff_results","position":9,"original_position":9,"commit_id":"40e33bbdd0fca2d84b6c80a79ce0ba9dd96a5596","original_commit_id":"40e33bbdd0fca2d84b6c80a79ce0ba9dd96a5596","user":{"login":"ltratt","id":20318,"node_id":"MDQ6VXNlcjIwMzE4","avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"body":"If `diff1 == 0 and diff2 == 0` I think you can still hit a divide by zero?","created_at":"2018-09-07T17:33:09Z","updated_at":"2018-09-07T17:33:09Z","html_url":"https://github.com/softdevteam/warmup_stats/pull/82#discussion_r216033257","pull_request_url":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/82","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/comments/216033257"},"html":{"href":"https://github.com/softdevteam/warmup_stats/pull/82#discussion_r216033257"},"pull_request":{"href":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/82","id":213976175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTc2MTc1","html_url":"https://github.com/softdevteam/warmup_stats/pull/82","diff_url":"https://github.com/softdevteam/warmup_stats/pull/82.diff","patch_url":"https://github.com/softdevteam/warmup_stats/pull/82.patch","issue_url":"https://api.github.com/repos/softdevteam/warmup_stats/issues/82","number":82,"state":"open","locked":false,"title":"Fix a divide by zero.","user":{"login":"snim2","id":97674,"node_id":"MDQ6VXNlcjk3Njc0","avatar_url":"https://avatars2.githubusercontent.com/u/97674?v=4","gravatar_id":"","url":"https://api.github.com/users/snim2","html_url":"https://github.com/snim2","followers_url":"https://api.github.com/users/snim2/followers","following_url":"https://api.github.com/users/snim2/following{/other_user}","gists_url":"https://api.github.com/users/snim2/gists{/gist_id}","starred_url":"https://api.github.com/users/snim2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snim2/subscriptions","organizations_url":"https://api.github.com/users/snim2/orgs","repos_url":"https://api.github.com/users/snim2/repos","events_url":"https://api.github.com/users/snim2/events{/privacy}","received_events_url":"https://api.github.com/users/snim2/received_events","type":"User","site_admin":false},"body":"Sometimes the steady iter data of a vm/benchmark pair will have no variation, leading to a divide by zero in the diffing code. This commit fixes that by checking for this special case.\r\n\r\nWe also remove some code duplication.","created_at":"2018-09-07T16:13:44Z","updated_at":"2018-09-07T17:33:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e96d243b99f737a57425804cfe77e3ff2916e52","assignee":{"login":"ltratt","id":20318,"node_id":"MDQ6VXNlcjIwMzE4","avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltratt","id":20318,"node_id":"MDQ6VXNlcjIwMzE4","avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},{"login":"fsfod","id":241431,"node_id":"MDQ6VXNlcjI0MTQzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/241431?v=4","gravatar_id":"","url":"https://api.github.com/users/fsfod","html_url":"https://github.com/fsfod","followers_url":"https://api.github.com/users/fsfod/followers","following_url":"https://api.github.com/users/fsfod/following{/other_user}","gists_url":"https://api.github.com/users/fsfod/gists{/gist_id}","starred_url":"https://api.github.com/users/fsfod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsfod/subscriptions","organizations_url":"https://api.github.com/users/fsfod/orgs","repos_url":"https://api.github.com/users/fsfod/repos","events_url":"https://api.github.com/users/fsfod/events{/privacy}","received_events_url":"https://api.github.com/users/fsfod/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/82/commits","review_comments_url":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/82/comments","review_comment_url":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softdevteam/warmup_stats/issues/82/comments","statuses_url":"https://api.github.com/repos/softdevteam/warmup_stats/statuses/40e33bbdd0fca2d84b6c80a79ce0ba9dd96a5596","head":{"label":"softdevteam:fix-div-by-zero","ref":"fix-div-by-zero","sha":"40e33bbdd0fca2d84b6c80a79ce0ba9dd96a5596","user":{"login":"softdevteam","id":10271085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjcxMDg1","avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":106446975,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NDY5NzU=","name":"warmup_stats","full_name":"softdevteam/warmup_stats","owner":{"login":"softdevteam","id":10271085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjcxMDg1","avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/warmup_stats","description":"A VM performance data analysis system","fork":false,"url":"https://api.github.com/repos/softdevteam/warmup_stats","forks_url":"https://api.github.com/repos/softdevteam/warmup_stats/forks","keys_url":"https://api.github.com/repos/softdevteam/warmup_stats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/warmup_stats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/warmup_stats/teams","hooks_url":"https://api.github.com/repos/softdevteam/warmup_stats/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/warmup_stats/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/warmup_stats/events","assignees_url":"https://api.github.com/repos/softdevteam/warmup_stats/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/warmup_stats/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/warmup_stats/tags","blobs_url":"https://api.github.com/repos/softdevteam/warmup_stats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/warmup_stats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/warmup_stats/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/warmup_stats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/warmup_stats/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/warmup_stats/languages","stargazers_url":"https://api.github.com/repos/softdevteam/warmup_stats/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/warmup_stats/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/warmup_stats/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/warmup_stats/subscription","commits_url":"https://api.github.com/repos/softdevteam/warmup_stats/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/warmup_stats/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/warmup_stats/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/warmup_stats/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/warmup_stats/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/warmup_stats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/warmup_stats/merges","archive_url":"https://api.github.com/repos/softdevteam/warmup_stats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/warmup_stats/downloads","issues_url":"https://api.github.com/repos/softdevteam/warmup_stats/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/warmup_stats/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/warmup_stats/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/warmup_stats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/warmup_stats/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/warmup_stats/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/warmup_stats/deployments","created_at":"2017-10-10T17:08:02Z","updated_at":"2018-08-22T21:43:57Z","pushed_at":"2018-09-07T16:13:44Z","git_url":"git://github.com/softdevteam/warmup_stats.git","ssh_url":"git@github.com:softdevteam/warmup_stats.git","clone_url":"https://github.com/softdevteam/warmup_stats.git","svn_url":"https://github.com/softdevteam/warmup_stats","homepage":null,"size":574,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":3,"open_issues":9,"watchers":4,"default_branch":"master"}},"base":{"label":"softdevteam:master","ref":"master","sha":"d09122fababc2eeae8a92121196431f52da724fc","user":{"login":"softdevteam","id":10271085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjcxMDg1","avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":106446975,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NDY5NzU=","name":"warmup_stats","full_name":"softdevteam/warmup_stats","owner":{"login":"softdevteam","id":10271085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjcxMDg1","avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/warmup_stats","description":"A VM performance data analysis system","fork":false,"url":"https://api.github.com/repos/softdevteam/warmup_stats","forks_url":"https://api.github.com/repos/softdevteam/warmup_stats/forks","keys_url":"https://api.github.com/repos/softdevteam/warmup_stats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/warmup_stats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/warmup_stats/teams","hooks_url":"https://api.github.com/repos/softdevteam/warmup_stats/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/warmup_stats/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/warmup_stats/events","assignees_url":"https://api.github.com/repos/softdevteam/warmup_stats/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/warmup_stats/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/warmup_stats/tags","blobs_url":"https://api.github.com/repos/softdevteam/warmup_stats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/warmup_stats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/warmup_stats/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/warmup_stats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/warmup_stats/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/warmup_stats/languages","stargazers_url":"https://api.github.com/repos/softdevteam/warmup_stats/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/warmup_stats/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/warmup_stats/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/warmup_stats/subscription","commits_url":"https://api.github.com/repos/softdevteam/warmup_stats/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/warmup_stats/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/warmup_stats/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/warmup_stats/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/warmup_stats/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/warmup_stats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/warmup_stats/merges","archive_url":"https://api.github.com/repos/softdevteam/warmup_stats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/warmup_stats/downloads","issues_url":"https://api.github.com/repos/softdevteam/warmup_stats/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/warmup_stats/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/warmup_stats/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/warmup_stats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/warmup_stats/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/warmup_stats/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/warmup_stats/deployments","created_at":"2017-10-10T17:08:02Z","updated_at":"2018-08-22T21:43:57Z","pushed_at":"2018-09-07T16:13:44Z","git_url":"git://github.com/softdevteam/warmup_stats.git","ssh_url":"git@github.com:softdevteam/warmup_stats.git","clone_url":"https://github.com/softdevteam/warmup_stats.git","svn_url":"https://github.com/softdevteam/warmup_stats","homepage":null,"size":574,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":3,"open_issues":9,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/82"},"html":{"href":"https://github.com/softdevteam/warmup_stats/pull/82"},"issue":{"href":"https://api.github.com/repos/softdevteam/warmup_stats/issues/82"},"comments":{"href":"https://api.github.com/repos/softdevteam/warmup_stats/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softdevteam/warmup_stats/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/softdevteam/warmup_stats/statuses/40e33bbdd0fca2d84b6c80a79ce0ba9dd96a5596"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ltratt"}}