{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/1220","repository_url":"https://api.github.com/repos/vufind-org/vufind","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/1220/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/1220/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/1220/events","html_url":"https://github.com/vufind-org/vufind/pull/1220","id":343672123,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjQ5Mzkw","number":1220,"title":"Index ini full path warnings","user":{"login":"ConorSheehan1","id":16896053,"node_id":"MDQ6VXNlcjE2ODk2MDUz","avatar_url":"https://avatars3.githubusercontent.com/u/16896053?v=4","gravatar_id":"","url":"https://api.github.com/users/ConorSheehan1","html_url":"https://github.com/ConorSheehan1","followers_url":"https://api.github.com/users/ConorSheehan1/followers","following_url":"https://api.github.com/users/ConorSheehan1/following{/other_user}","gists_url":"https://api.github.com/users/ConorSheehan1/gists{/gist_id}","starred_url":"https://api.github.com/users/ConorSheehan1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConorSheehan1/subscriptions","organizations_url":"https://api.github.com/users/ConorSheehan1/orgs","repos_url":"https://api.github.com/users/ConorSheehan1/repos","events_url":"https://api.github.com/users/ConorSheehan1/events{/privacy}","received_events_url":"https://api.github.com/users/ConorSheehan1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-07-23T15:04:11Z","updated_at":"2018-07-25T18:09:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/1220","html_url":"https://github.com/vufind-org/vufind/pull/1220","diff_url":"https://github.com/vufind-org/vufind/pull/1220.diff","patch_url":"https://github.com/vufind-org/vufind/pull/1220.patch"},"body":"I ran into an issue where I wasn't able to load a config file when running `import-marc.sh`.\r\n`ERROR [RecordIndexer-Thread-0] (ConfigManager.java:233) - Unable to access fulltext.ini`\r\n\r\nAfter some digging I was able to change `ConfigManager.java loadConfigFile` to display the full path \r\n`ERROR [RecordIndexer-Thread-0] (ConfigManager.java:233) - Unable to access /media/share/vufind_origin/../web/conf/fulltext.ini`\r\n\r\nIt turns out my problem was that I need to run import-marc.sh as root, and although I had `VUFIND_LOCAL_DIR` and `VUFIND_HOME` set for the current user, I didn't have them set for root. \r\n\r\nWould it make sense to set the default value for `VUFIND_HOME` to `/usr/local/vufind` and display the full path when a config file fails to load?\r\n\r\nI understand that some of this is for backwards compatibility with older versions, but I figured I'd open this anyway and see what you all think.\r\n\r\nThanks,\r\nConor\r\n\r\nTODO\r\n\r\n- [x] Make Windows .bat match Linux .sh functionality.\r\n"},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/407845847","html_url":"https://github.com/vufind-org/vufind/pull/1220#issuecomment-407845847","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/1220","id":407845847,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzg0NTg0Nw==","user":{"login":"demiankatz","id":309069,"node_id":"MDQ6VXNlcjMwOTA2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/309069?v=4","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T18:09:54Z","updated_at":"2018-07-25T18:09:54Z","author_association":"MEMBER","body":"@ConorSheehan1, I made a few adjustments, and the Windows .bat is now working very similarly to the Linux .sh. (I opted to move the logic into import-marc.bat instead of creating a default env.bat, because I thought this approach would create less version control confusion, and also gives us the opportunity to remind the user to run the installer).\r\n\r\nJust one last question: how important is it to you that we include the full configuration path in the loadConfigFile error message? I'm concerned that if `findConfigFile(filename)` is the reason we end up in the `catch (Throwable e)` block, we'll just end up rethrowing the exception when we try to look up the full path. I think we might need a nested try..catch to cover this edge case... but if it's not a vitally important enhancement, maybe it's simpler to live without it at this stage. What do you think?"}}
{"actor":{"display_login":"demiankatz"}}