{"action":"created","comment":{"url":"https://api.github.com/repos/abrt/retrace-server/pulls/comments/166591895","pull_request_review_id":94677045,"id":166591895,"diff_hunk":"@@ -477,66 +472,92 @@ def is_package_known(package_nvr, arch, releaseid=None):\n \n     return any([os.path.isfile(f) for f in candidates])\n \n-# tricky\n-# crash is not able to process the vmcore from different arch\n-# (not even x86_64 and x86). In addition, there are several\n-# types of vmcores: running 'file' command on el5- vmcore results\n-# into an expected description (x86-64 or 80386 coredump), while\n-# el6+ vmcores are just proclaimed 'data'. Another thing is that\n-# the OSRELEASE in the vmcore sometimes contains architecture\n-# and sometimes it does not.\n+\n+#\n+# In real-world testing, approximately 60% of the time the kernel\n+# version of a vmcore can be identified with the crash tool.\n+# In the other 40% of the time, we must use some other method.\n+#\n+# The below function contains a couple regex searches that work\n+# across a wide variety of vmcore formats and kernel versions.\n+# We do not attempt to identify the file type since this is often not\n+# reliable, but we assume the version information exists in some form\n+# in the first portion of the file.  Testing has indicated that we do\n+# not need to scan the entire file but can rely on a small portion\n+# at the start of the file, which helps preserve useful pages in the\n+# OS page cache.\n+#\n+# The following regex's are used for the 40% scenario\n+# 1. Look for 'OSRELEASE='.  For example:\n+# OSRELEASE=2.6.18-406.el5\n+# NOTE: We can get \"OSRELEASE=%\" so we disallow the '%' character after the '='\n+OSRELEASE_VAR_PARSER = re.compile(\"OSRELEASE=([^%][^\\x00\\s\\n\\r]+)\")","path":"src/retrace/retrace.py","position":52,"original_position":52,"commit_id":"a8dd517601c385dc1b34c203eb6b5d1193e7e9e6","original_commit_id":"a8dd517601c385dc1b34c203eb6b5d1193e7e9e6","user":{"login":"DaveWysochanskiRH","id":17653883,"avatar_url":"https://avatars1.githubusercontent.com/u/17653883?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveWysochanskiRH","html_url":"https://github.com/DaveWysochanskiRH","followers_url":"https://api.github.com/users/DaveWysochanskiRH/followers","following_url":"https://api.github.com/users/DaveWysochanskiRH/following{/other_user}","gists_url":"https://api.github.com/users/DaveWysochanskiRH/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveWysochanskiRH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveWysochanskiRH/subscriptions","organizations_url":"https://api.github.com/users/DaveWysochanskiRH/orgs","repos_url":"https://api.github.com/users/DaveWysochanskiRH/repos","events_url":"https://api.github.com/users/DaveWysochanskiRH/events{/privacy}","received_events_url":"https://api.github.com/users/DaveWysochanskiRH/received_events","type":"User","site_admin":false},"body":"ok yeah that sounds good","created_at":"2018-02-07T11:36:40Z","updated_at":"2018-02-07T11:36:40Z","html_url":"https://github.com/abrt/retrace-server/pull/174#discussion_r166591895","pull_request_url":"https://api.github.com/repos/abrt/retrace-server/pulls/174","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/abrt/retrace-server/pulls/comments/166591895"},"html":{"href":"https://github.com/abrt/retrace-server/pull/174#discussion_r166591895"},"pull_request":{"href":"https://api.github.com/repos/abrt/retrace-server/pulls/174"}},"in_reply_to_id":166212545},"pull_request":{"url":"https://api.github.com/repos/abrt/retrace-server/pulls/174","id":166889339,"html_url":"https://github.com/abrt/retrace-server/pull/174","diff_url":"https://github.com/abrt/retrace-server/pull/174.diff","patch_url":"https://github.com/abrt/retrace-server/pull/174.patch","issue_url":"https://api.github.com/repos/abrt/retrace-server/issues/174","number":174,"state":"open","locked":false,"title":"Rhbz1535592 rhbz1440381 kernelver parser bz1540253 crash osrelease spin final","user":{"login":"DaveWysochanskiRH","id":17653883,"avatar_url":"https://avatars1.githubusercontent.com/u/17653883?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveWysochanskiRH","html_url":"https://github.com/DaveWysochanskiRH","followers_url":"https://api.github.com/users/DaveWysochanskiRH/followers","following_url":"https://api.github.com/users/DaveWysochanskiRH/following{/other_user}","gists_url":"https://api.github.com/users/DaveWysochanskiRH/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveWysochanskiRH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveWysochanskiRH/subscriptions","organizations_url":"https://api.github.com/users/DaveWysochanskiRH/orgs","repos_url":"https://api.github.com/users/DaveWysochanskiRH/repos","events_url":"https://api.github.com/users/DaveWysochanskiRH/events{/privacy}","received_events_url":"https://api.github.com/users/DaveWysochanskiRH/received_events","type":"User","site_admin":false},"body":"These two patches fix a few bugs in the get_kernel_release() function which detects the kernel version from a vmcore.  It is a critical function so I went through a number of iterations and performed significant testing.\r\n\r\nThe testing showed there were no regressions in kernel detection on a few thousand production vmcores.  In addition I have these two patches running now on our development retrace-server which also has a auto-submit script and it is currently mirroring the vmcores that come in to production.  So far I've seen no regressions there in the new vmcores vs production.\r\n\r\nI request review and pull of these patches as soon as reasonable.  I would like to schedule an update to the production retrace-server with these patches as well as most all of the latest upstream code.\r\n\r\nThanks.","created_at":"2018-02-02T19:53:30Z","updated_at":"2018-02-07T11:36:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"623bccd605b3a9416f53d8825b88595384771b4e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/abrt/retrace-server/pulls/174/commits","review_comments_url":"https://api.github.com/repos/abrt/retrace-server/pulls/174/comments","review_comment_url":"https://api.github.com/repos/abrt/retrace-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/abrt/retrace-server/issues/174/comments","statuses_url":"https://api.github.com/repos/abrt/retrace-server/statuses/a8dd517601c385dc1b34c203eb6b5d1193e7e9e6","head":{"label":"DaveWysochanskiRH:rhbz1535592-rhbz1440381-kernelver-parser-bz1540253-crash-osrelease-spin-final","ref":"rhbz1535592-rhbz1440381-kernelver-parser-bz1540253-crash-osrelease-spin-final","sha":"a8dd517601c385dc1b34c203eb6b5d1193e7e9e6","user":{"login":"DaveWysochanskiRH","id":17653883,"avatar_url":"https://avatars1.githubusercontent.com/u/17653883?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveWysochanskiRH","html_url":"https://github.com/DaveWysochanskiRH","followers_url":"https://api.github.com/users/DaveWysochanskiRH/followers","following_url":"https://api.github.com/users/DaveWysochanskiRH/following{/other_user}","gists_url":"https://api.github.com/users/DaveWysochanskiRH/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveWysochanskiRH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveWysochanskiRH/subscriptions","organizations_url":"https://api.github.com/users/DaveWysochanskiRH/orgs","repos_url":"https://api.github.com/users/DaveWysochanskiRH/repos","events_url":"https://api.github.com/users/DaveWysochanskiRH/events{/privacy}","received_events_url":"https://api.github.com/users/DaveWysochanskiRH/received_events","type":"User","site_admin":false},"repo":{"id":53161561,"name":"retrace-server","full_name":"DaveWysochanskiRH/retrace-server","owner":{"login":"DaveWysochanskiRH","id":17653883,"avatar_url":"https://avatars1.githubusercontent.com/u/17653883?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveWysochanskiRH","html_url":"https://github.com/DaveWysochanskiRH","followers_url":"https://api.github.com/users/DaveWysochanskiRH/followers","following_url":"https://api.github.com/users/DaveWysochanskiRH/following{/other_user}","gists_url":"https://api.github.com/users/DaveWysochanskiRH/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveWysochanskiRH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveWysochanskiRH/subscriptions","organizations_url":"https://api.github.com/users/DaveWysochanskiRH/orgs","repos_url":"https://api.github.com/users/DaveWysochanskiRH/repos","events_url":"https://api.github.com/users/DaveWysochanskiRH/events{/privacy}","received_events_url":"https://api.github.com/users/DaveWysochanskiRH/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaveWysochanskiRH/retrace-server","description":"Application for remote coredump analysis","fork":true,"url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server","forks_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/forks","keys_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/teams","hooks_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/hooks","issue_events_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/issues/events{/number}","events_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/events","assignees_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/assignees{/user}","branches_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/branches{/branch}","tags_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/tags","blobs_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/statuses/{sha}","languages_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/languages","stargazers_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/stargazers","contributors_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/contributors","subscribers_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/subscribers","subscription_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/subscription","commits_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/contents/{+path}","compare_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/merges","archive_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/downloads","issues_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/issues{/number}","pulls_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/pulls{/number}","milestones_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/milestones{/number}","notifications_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/labels{/name}","releases_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/releases{/id}","deployments_url":"https://api.github.com/repos/DaveWysochanskiRH/retrace-server/deployments","created_at":"2016-03-04T19:51:33Z","updated_at":"2016-03-04T19:51:34Z","pushed_at":"2018-02-02T19:48:51Z","git_url":"git://github.com/DaveWysochanskiRH/retrace-server.git","ssh_url":"git@github.com:DaveWysochanskiRH/retrace-server.git","clone_url":"https://github.com/DaveWysochanskiRH/retrace-server.git","svn_url":"https://github.com/DaveWysochanskiRH/retrace-server","homepage":null,"size":592,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"abrt:master","ref":"master","sha":"2f08f9fc4df557c29f7fa3c7bc70b93b567e8940","user":{"login":"abrt","id":3449403,"avatar_url":"https://avatars0.githubusercontent.com/u/3449403?v=4","gravatar_id":"","url":"https://api.github.com/users/abrt","html_url":"https://github.com/abrt","followers_url":"https://api.github.com/users/abrt/followers","following_url":"https://api.github.com/users/abrt/following{/other_user}","gists_url":"https://api.github.com/users/abrt/gists{/gist_id}","starred_url":"https://api.github.com/users/abrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrt/subscriptions","organizations_url":"https://api.github.com/users/abrt/orgs","repos_url":"https://api.github.com/users/abrt/repos","events_url":"https://api.github.com/users/abrt/events{/privacy}","received_events_url":"https://api.github.com/users/abrt/received_events","type":"Organization","site_admin":false},"repo":{"id":7959875,"name":"retrace-server","full_name":"abrt/retrace-server","owner":{"login":"abrt","id":3449403,"avatar_url":"https://avatars0.githubusercontent.com/u/3449403?v=4","gravatar_id":"","url":"https://api.github.com/users/abrt","html_url":"https://github.com/abrt","followers_url":"https://api.github.com/users/abrt/followers","following_url":"https://api.github.com/users/abrt/following{/other_user}","gists_url":"https://api.github.com/users/abrt/gists{/gist_id}","starred_url":"https://api.github.com/users/abrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrt/subscriptions","organizations_url":"https://api.github.com/users/abrt/orgs","repos_url":"https://api.github.com/users/abrt/repos","events_url":"https://api.github.com/users/abrt/events{/privacy}","received_events_url":"https://api.github.com/users/abrt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/abrt/retrace-server","description":"Application for remote coredump analysis","fork":false,"url":"https://api.github.com/repos/abrt/retrace-server","forks_url":"https://api.github.com/repos/abrt/retrace-server/forks","keys_url":"https://api.github.com/repos/abrt/retrace-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abrt/retrace-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abrt/retrace-server/teams","hooks_url":"https://api.github.com/repos/abrt/retrace-server/hooks","issue_events_url":"https://api.github.com/repos/abrt/retrace-server/issues/events{/number}","events_url":"https://api.github.com/repos/abrt/retrace-server/events","assignees_url":"https://api.github.com/repos/abrt/retrace-server/assignees{/user}","branches_url":"https://api.github.com/repos/abrt/retrace-server/branches{/branch}","tags_url":"https://api.github.com/repos/abrt/retrace-server/tags","blobs_url":"https://api.github.com/repos/abrt/retrace-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abrt/retrace-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abrt/retrace-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/abrt/retrace-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abrt/retrace-server/statuses/{sha}","languages_url":"https://api.github.com/repos/abrt/retrace-server/languages","stargazers_url":"https://api.github.com/repos/abrt/retrace-server/stargazers","contributors_url":"https://api.github.com/repos/abrt/retrace-server/contributors","subscribers_url":"https://api.github.com/repos/abrt/retrace-server/subscribers","subscription_url":"https://api.github.com/repos/abrt/retrace-server/subscription","commits_url":"https://api.github.com/repos/abrt/retrace-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/abrt/retrace-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/abrt/retrace-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/abrt/retrace-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/abrt/retrace-server/contents/{+path}","compare_url":"https://api.github.com/repos/abrt/retrace-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abrt/retrace-server/merges","archive_url":"https://api.github.com/repos/abrt/retrace-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abrt/retrace-server/downloads","issues_url":"https://api.github.com/repos/abrt/retrace-server/issues{/number}","pulls_url":"https://api.github.com/repos/abrt/retrace-server/pulls{/number}","milestones_url":"https://api.github.com/repos/abrt/retrace-server/milestones{/number}","notifications_url":"https://api.github.com/repos/abrt/retrace-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abrt/retrace-server/labels{/name}","releases_url":"https://api.github.com/repos/abrt/retrace-server/releases{/id}","deployments_url":"https://api.github.com/repos/abrt/retrace-server/deployments","created_at":"2013-02-01T14:52:00Z","updated_at":"2018-01-29T13:24:38Z","pushed_at":"2018-02-07T11:04:24Z","git_url":"git://github.com/abrt/retrace-server.git","ssh_url":"git@github.com:abrt/retrace-server.git","clone_url":"https://github.com/abrt/retrace-server.git","svn_url":"https://github.com/abrt/retrace-server","homepage":null,"size":584,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":18,"open_issues":17,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abrt/retrace-server/pulls/174"},"html":{"href":"https://github.com/abrt/retrace-server/pull/174"},"issue":{"href":"https://api.github.com/repos/abrt/retrace-server/issues/174"},"comments":{"href":"https://api.github.com/repos/abrt/retrace-server/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/abrt/retrace-server/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/abrt/retrace-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/abrt/retrace-server/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/abrt/retrace-server/statuses/a8dd517601c385dc1b34c203eb6b5d1193e7e9e6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DaveWysochanskiRH"}}