{"action":"created","comment":{"url":"https://api.github.com/repos/gigya/microdot/pulls/comments/169009614","pull_request_review_id":97455958,"id":169009614,"diff_hunk":"@@ -56,13 +64,25 @@ public void TearDown()\n         }\n \n         private void SetupServiceMock()\n-        {\n+        {             \n             _serviceMock = Substitute.For<ICachingTestService>();\n             _serviceMock.CallService().Returns(_ => Task.FromResult(_serviceResult));\n+            _serviceMock.CallRevocableService(Arg.Any<string>()).Returns(async s =>\n+            {\n+                var result = _serviceResult;\n+                await Task.Delay(_revockDelay);","path":"tests/Gigya.Microdot.UnitTests/Caching/CachingProxyTests.cs","position":64,"original_position":64,"commit_id":"2092c3f7f935622d2449297dbe9e155bb4a6495b","original_commit_id":"2092c3f7f935622d2449297dbe9e155bb4a6495b","user":{"login":"bronsh","id":20515114,"avatar_url":"https://avatars1.githubusercontent.com/u/20515114?v=4","gravatar_id":"","url":"https://api.github.com/users/bronsh","html_url":"https://github.com/bronsh","followers_url":"https://api.github.com/users/bronsh/followers","following_url":"https://api.github.com/users/bronsh/following{/other_user}","gists_url":"https://api.github.com/users/bronsh/gists{/gist_id}","starred_url":"https://api.github.com/users/bronsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bronsh/subscriptions","organizations_url":"https://api.github.com/users/bronsh/orgs","repos_url":"https://api.github.com/users/bronsh/repos","events_url":"https://api.github.com/users/bronsh/events{/privacy}","received_events_url":"https://api.github.com/users/bronsh/received_events","type":"User","site_admin":false},"body":"use a TaskCompletionSource istead of using static delays","created_at":"2018-02-19T08:32:15Z","updated_at":"2018-02-19T08:37:04Z","html_url":"https://github.com/gigya/microdot/pull/133#discussion_r169009614","pull_request_url":"https://api.github.com/repos/gigya/microdot/pulls/133","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gigya/microdot/pulls/comments/169009614"},"html":{"href":"https://github.com/gigya/microdot/pull/133#discussion_r169009614"},"pull_request":{"href":"https://api.github.com/repos/gigya/microdot/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/gigya/microdot/pulls/133","id":169892977,"html_url":"https://github.com/gigya/microdot/pull/133","diff_url":"https://github.com/gigya/microdot/pull/133.diff","patch_url":"https://github.com/gigya/microdot/pull/133.patch","issue_url":"https://api.github.com/repos/gigya/microdot/issues/133","number":133,"state":"open","locked":false,"title":"Add more unit test for revoking","user":{"login":"EranOfer","id":13414515,"avatar_url":"https://avatars3.githubusercontent.com/u/13414515?v=4","gravatar_id":"","url":"https://api.github.com/users/EranOfer","html_url":"https://github.com/EranOfer","followers_url":"https://api.github.com/users/EranOfer/followers","following_url":"https://api.github.com/users/EranOfer/following{/other_user}","gists_url":"https://api.github.com/users/EranOfer/gists{/gist_id}","starred_url":"https://api.github.com/users/EranOfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EranOfer/subscriptions","organizations_url":"https://api.github.com/users/EranOfer/orgs","repos_url":"https://api.github.com/users/EranOfer/repos","events_url":"https://api.github.com/users/EranOfer/events{/privacy}","received_events_url":"https://api.github.com/users/EranOfer/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-19T07:24:41Z","updated_at":"2018-02-19T08:37:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fe850012a0757172f270d4a3eec2b61ded4527c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gigya/microdot/pulls/133/commits","review_comments_url":"https://api.github.com/repos/gigya/microdot/pulls/133/comments","review_comment_url":"https://api.github.com/repos/gigya/microdot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gigya/microdot/issues/133/comments","statuses_url":"https://api.github.com/repos/gigya/microdot/statuses/2092c3f7f935622d2449297dbe9e155bb4a6495b","head":{"label":"gigya:feature/revokeTest","ref":"feature/revokeTest","sha":"2092c3f7f935622d2449297dbe9e155bb4a6495b","user":{"login":"gigya","id":3179803,"avatar_url":"https://avatars1.githubusercontent.com/u/3179803?v=4","gravatar_id":"","url":"https://api.github.com/users/gigya","html_url":"https://github.com/gigya","followers_url":"https://api.github.com/users/gigya/followers","following_url":"https://api.github.com/users/gigya/following{/other_user}","gists_url":"https://api.github.com/users/gigya/gists{/gist_id}","starred_url":"https://api.github.com/users/gigya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigya/subscriptions","organizations_url":"https://api.github.com/users/gigya/orgs","repos_url":"https://api.github.com/users/gigya/repos","events_url":"https://api.github.com/users/gigya/events{/privacy}","received_events_url":"https://api.github.com/users/gigya/received_events","type":"Organization","site_admin":false},"repo":{"id":89123929,"name":"microdot","full_name":"gigya/microdot","owner":{"login":"gigya","id":3179803,"avatar_url":"https://avatars1.githubusercontent.com/u/3179803?v=4","gravatar_id":"","url":"https://api.github.com/users/gigya","html_url":"https://github.com/gigya","followers_url":"https://api.github.com/users/gigya/followers","following_url":"https://api.github.com/users/gigya/following{/other_user}","gists_url":"https://api.github.com/users/gigya/gists{/gist_id}","starred_url":"https://api.github.com/users/gigya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigya/subscriptions","organizations_url":"https://api.github.com/users/gigya/orgs","repos_url":"https://api.github.com/users/gigya/repos","events_url":"https://api.github.com/users/gigya/events{/privacy}","received_events_url":"https://api.github.com/users/gigya/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gigya/microdot","description":"Microdot: An open source .NET microservices framework","fork":false,"url":"https://api.github.com/repos/gigya/microdot","forks_url":"https://api.github.com/repos/gigya/microdot/forks","keys_url":"https://api.github.com/repos/gigya/microdot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gigya/microdot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gigya/microdot/teams","hooks_url":"https://api.github.com/repos/gigya/microdot/hooks","issue_events_url":"https://api.github.com/repos/gigya/microdot/issues/events{/number}","events_url":"https://api.github.com/repos/gigya/microdot/events","assignees_url":"https://api.github.com/repos/gigya/microdot/assignees{/user}","branches_url":"https://api.github.com/repos/gigya/microdot/branches{/branch}","tags_url":"https://api.github.com/repos/gigya/microdot/tags","blobs_url":"https://api.github.com/repos/gigya/microdot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gigya/microdot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gigya/microdot/git/refs{/sha}","trees_url":"https://api.github.com/repos/gigya/microdot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gigya/microdot/statuses/{sha}","languages_url":"https://api.github.com/repos/gigya/microdot/languages","stargazers_url":"https://api.github.com/repos/gigya/microdot/stargazers","contributors_url":"https://api.github.com/repos/gigya/microdot/contributors","subscribers_url":"https://api.github.com/repos/gigya/microdot/subscribers","subscription_url":"https://api.github.com/repos/gigya/microdot/subscription","commits_url":"https://api.github.com/repos/gigya/microdot/commits{/sha}","git_commits_url":"https://api.github.com/repos/gigya/microdot/git/commits{/sha}","comments_url":"https://api.github.com/repos/gigya/microdot/comments{/number}","issue_comment_url":"https://api.github.com/repos/gigya/microdot/issues/comments{/number}","contents_url":"https://api.github.com/repos/gigya/microdot/contents/{+path}","compare_url":"https://api.github.com/repos/gigya/microdot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gigya/microdot/merges","archive_url":"https://api.github.com/repos/gigya/microdot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gigya/microdot/downloads","issues_url":"https://api.github.com/repos/gigya/microdot/issues{/number}","pulls_url":"https://api.github.com/repos/gigya/microdot/pulls{/number}","milestones_url":"https://api.github.com/repos/gigya/microdot/milestones{/number}","notifications_url":"https://api.github.com/repos/gigya/microdot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gigya/microdot/labels{/name}","releases_url":"https://api.github.com/repos/gigya/microdot/releases{/id}","deployments_url":"https://api.github.com/repos/gigya/microdot/deployments","created_at":"2017-04-23T07:10:26Z","updated_at":"2018-02-18T19:29:36Z","pushed_at":"2018-02-19T07:24:42Z","git_url":"git://github.com/gigya/microdot.git","ssh_url":"git@github.com:gigya/microdot.git","clone_url":"https://github.com/gigya/microdot.git","svn_url":"https://github.com/gigya/microdot","homepage":"","size":948,"stargazers_count":510,"watchers_count":510,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":82,"open_issues":8,"watchers":510,"default_branch":"develop"}},"base":{"label":"gigya:develop","ref":"develop","sha":"827e3e4cb02d202c52c76089caca75c06a592b5f","user":{"login":"gigya","id":3179803,"avatar_url":"https://avatars1.githubusercontent.com/u/3179803?v=4","gravatar_id":"","url":"https://api.github.com/users/gigya","html_url":"https://github.com/gigya","followers_url":"https://api.github.com/users/gigya/followers","following_url":"https://api.github.com/users/gigya/following{/other_user}","gists_url":"https://api.github.com/users/gigya/gists{/gist_id}","starred_url":"https://api.github.com/users/gigya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigya/subscriptions","organizations_url":"https://api.github.com/users/gigya/orgs","repos_url":"https://api.github.com/users/gigya/repos","events_url":"https://api.github.com/users/gigya/events{/privacy}","received_events_url":"https://api.github.com/users/gigya/received_events","type":"Organization","site_admin":false},"repo":{"id":89123929,"name":"microdot","full_name":"gigya/microdot","owner":{"login":"gigya","id":3179803,"avatar_url":"https://avatars1.githubusercontent.com/u/3179803?v=4","gravatar_id":"","url":"https://api.github.com/users/gigya","html_url":"https://github.com/gigya","followers_url":"https://api.github.com/users/gigya/followers","following_url":"https://api.github.com/users/gigya/following{/other_user}","gists_url":"https://api.github.com/users/gigya/gists{/gist_id}","starred_url":"https://api.github.com/users/gigya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigya/subscriptions","organizations_url":"https://api.github.com/users/gigya/orgs","repos_url":"https://api.github.com/users/gigya/repos","events_url":"https://api.github.com/users/gigya/events{/privacy}","received_events_url":"https://api.github.com/users/gigya/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gigya/microdot","description":"Microdot: An open source .NET microservices framework","fork":false,"url":"https://api.github.com/repos/gigya/microdot","forks_url":"https://api.github.com/repos/gigya/microdot/forks","keys_url":"https://api.github.com/repos/gigya/microdot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gigya/microdot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gigya/microdot/teams","hooks_url":"https://api.github.com/repos/gigya/microdot/hooks","issue_events_url":"https://api.github.com/repos/gigya/microdot/issues/events{/number}","events_url":"https://api.github.com/repos/gigya/microdot/events","assignees_url":"https://api.github.com/repos/gigya/microdot/assignees{/user}","branches_url":"https://api.github.com/repos/gigya/microdot/branches{/branch}","tags_url":"https://api.github.com/repos/gigya/microdot/tags","blobs_url":"https://api.github.com/repos/gigya/microdot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gigya/microdot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gigya/microdot/git/refs{/sha}","trees_url":"https://api.github.com/repos/gigya/microdot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gigya/microdot/statuses/{sha}","languages_url":"https://api.github.com/repos/gigya/microdot/languages","stargazers_url":"https://api.github.com/repos/gigya/microdot/stargazers","contributors_url":"https://api.github.com/repos/gigya/microdot/contributors","subscribers_url":"https://api.github.com/repos/gigya/microdot/subscribers","subscription_url":"https://api.github.com/repos/gigya/microdot/subscription","commits_url":"https://api.github.com/repos/gigya/microdot/commits{/sha}","git_commits_url":"https://api.github.com/repos/gigya/microdot/git/commits{/sha}","comments_url":"https://api.github.com/repos/gigya/microdot/comments{/number}","issue_comment_url":"https://api.github.com/repos/gigya/microdot/issues/comments{/number}","contents_url":"https://api.github.com/repos/gigya/microdot/contents/{+path}","compare_url":"https://api.github.com/repos/gigya/microdot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gigya/microdot/merges","archive_url":"https://api.github.com/repos/gigya/microdot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gigya/microdot/downloads","issues_url":"https://api.github.com/repos/gigya/microdot/issues{/number}","pulls_url":"https://api.github.com/repos/gigya/microdot/pulls{/number}","milestones_url":"https://api.github.com/repos/gigya/microdot/milestones{/number}","notifications_url":"https://api.github.com/repos/gigya/microdot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gigya/microdot/labels{/name}","releases_url":"https://api.github.com/repos/gigya/microdot/releases{/id}","deployments_url":"https://api.github.com/repos/gigya/microdot/deployments","created_at":"2017-04-23T07:10:26Z","updated_at":"2018-02-18T19:29:36Z","pushed_at":"2018-02-19T07:24:42Z","git_url":"git://github.com/gigya/microdot.git","ssh_url":"git@github.com:gigya/microdot.git","clone_url":"https://github.com/gigya/microdot.git","svn_url":"https://github.com/gigya/microdot","homepage":"","size":948,"stargazers_count":510,"watchers_count":510,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":82,"open_issues":8,"watchers":510,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gigya/microdot/pulls/133"},"html":{"href":"https://github.com/gigya/microdot/pull/133"},"issue":{"href":"https://api.github.com/repos/gigya/microdot/issues/133"},"comments":{"href":"https://api.github.com/repos/gigya/microdot/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/gigya/microdot/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/gigya/microdot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gigya/microdot/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/gigya/microdot/statuses/2092c3f7f935622d2449297dbe9e155bb4a6495b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bronsh"}}