{"action":"created","issue":{"url":"https://api.github.com/repos/vmware/clarity/issues/2708","repository_url":"https://api.github.com/repos/vmware/clarity","labels_url":"https://api.github.com/repos/vmware/clarity/issues/2708/labels{/name}","comments_url":"https://api.github.com/repos/vmware/clarity/issues/2708/comments","events_url":"https://api.github.com/repos/vmware/clarity/issues/2708/events","html_url":"https://github.com/vmware/clarity/pull/2708","id":367448012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODgwNTU5","number":2708,"title":"[WEB] Unset max-height on pre of code-snippet","user":{"login":"imcotton","id":149541,"node_id":"MDQ6VXNlcjE0OTU0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/149541?v=4","gravatar_id":"","url":"https://api.github.com/users/imcotton","html_url":"https://github.com/imcotton","followers_url":"https://api.github.com/users/imcotton/followers","following_url":"https://api.github.com/users/imcotton/following{/other_user}","gists_url":"https://api.github.com/users/imcotton/gists{/gist_id}","starred_url":"https://api.github.com/users/imcotton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imcotton/subscriptions","organizations_url":"https://api.github.com/users/imcotton/orgs","repos_url":"https://api.github.com/users/imcotton/repos","events_url":"https://api.github.com/users/imcotton/events{/privacy}","received_events_url":"https://api.github.com/users/imcotton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-06T11:17:05Z","updated_at":"2018-10-09T10:30:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vmware/clarity/pulls/2708","html_url":"https://github.com/vmware/clarity/pull/2708","diff_url":"https://github.com/vmware/clarity/pull/2708.diff","patch_url":"https://github.com/vmware/clarity/pull/2708.patch"},"body":"It's too often that default `pre { max-height: 15rem }` gets in the way while reading sample code on the doc site, given that other sites (e.g. MDN / Bootstrap / Angular.io) would just show code snippet in full-size, suggest to take out the squeezing to make it more readable."},"comment":{"url":"https://api.github.com/repos/vmware/clarity/issues/comments/428142418","html_url":"https://github.com/vmware/clarity/pull/2708#issuecomment-428142418","issue_url":"https://api.github.com/repos/vmware/clarity/issues/2708","id":428142418,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODE0MjQxOA==","user":{"login":"imcotton","id":149541,"node_id":"MDQ6VXNlcjE0OTU0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/149541?v=4","gravatar_id":"","url":"https://api.github.com/users/imcotton","html_url":"https://github.com/imcotton","followers_url":"https://api.github.com/users/imcotton/followers","following_url":"https://api.github.com/users/imcotton/following{/other_user}","gists_url":"https://api.github.com/users/imcotton/gists{/gist_id}","starred_url":"https://api.github.com/users/imcotton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imcotton/subscriptions","organizations_url":"https://api.github.com/users/imcotton/orgs","repos_url":"https://api.github.com/users/imcotton/repos","events_url":"https://api.github.com/users/imcotton/events{/privacy}","received_events_url":"https://api.github.com/users/imcotton/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T10:30:46Z","updated_at":"2018-10-09T10:30:46Z","author_association":"CONTRIBUTOR","body":"After reading issue **1138**, it's more likely a UX adjustment on CSS level of `<pre>` tag, to that I'm not the expert and will wait on its development indeed.\r\n\r\nThe changing I'm proposing here only alter to `clr-code-snippet` component which to being used on the doc site only, so it has no impact on Clarity as a whole, but brings readability to the doc site immediately I think."}}
{"actor":{"display_login":"imcotton"}}