{"action":"closed","number":967,"pull_request":{"url":"https://api.github.com/repos/fastai/fastai/pulls/967","id":225563012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTYzMDEy","html_url":"https://github.com/fastai/fastai/pull/967","diff_url":"https://github.com/fastai/fastai/pull/967.diff","patch_url":"https://github.com/fastai/fastai/pull/967.patch","issue_url":"https://api.github.com/repos/fastai/fastai/issues/967","number":967,"state":"closed","locked":false,"title":"Fix ML1 course, lesson4, error on plot_pdp","user":{"login":"newvicklee","id":7368628,"node_id":"MDQ6VXNlcjczNjg2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/7368628?v=4","gravatar_id":"","url":"https://api.github.com/users/newvicklee","html_url":"https://github.com/newvicklee","followers_url":"https://api.github.com/users/newvicklee/followers","following_url":"https://api.github.com/users/newvicklee/following{/other_user}","gists_url":"https://api.github.com/users/newvicklee/gists{/gist_id}","starred_url":"https://api.github.com/users/newvicklee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newvicklee/subscriptions","organizations_url":"https://api.github.com/users/newvicklee/orgs","repos_url":"https://api.github.com/users/newvicklee/repos","events_url":"https://api.github.com/users/newvicklee/events{/privacy}","received_events_url":"https://api.github.com/users/newvicklee/received_events","type":"User","site_admin":false},"body":"In ML1, lesson 4, the code for the function plot_pdp has an error if it's run as is: TypeError: pdp_isolate() missing 1 required positional argument: ‘feature’\r\nSee this discussion on the forums: https://forums.fast.ai/t/error-when-i-try-to-create-plot-in-ml-lesson-4/24697\r\n\r\npdp_isolate takes an additional required positional argument: https://github.com/SauceCat/PDPbox/blob/master/pdpbox/pdp.py#L68","created_at":"2018-10-24T21:55:14Z","updated_at":"2018-10-25T03:45:42Z","closed_at":"2018-10-25T03:45:41Z","merged_at":"2018-10-25T03:45:41Z","merge_commit_sha":"f7df051c3652218e6b99f050372fb9c71b83388d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastai/fastai/pulls/967/commits","review_comments_url":"https://api.github.com/repos/fastai/fastai/pulls/967/comments","review_comment_url":"https://api.github.com/repos/fastai/fastai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastai/fastai/issues/967/comments","statuses_url":"https://api.github.com/repos/fastai/fastai/statuses/a1b51523ac8689ba6082d61c5a56a8b7af7547ba","head":{"label":"newvicklee:fix/ml1_lesson4_pdp","ref":"fix/ml1_lesson4_pdp","sha":"a1b51523ac8689ba6082d61c5a56a8b7af7547ba","user":{"login":"newvicklee","id":7368628,"node_id":"MDQ6VXNlcjczNjg2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/7368628?v=4","gravatar_id":"","url":"https://api.github.com/users/newvicklee","html_url":"https://github.com/newvicklee","followers_url":"https://api.github.com/users/newvicklee/followers","following_url":"https://api.github.com/users/newvicklee/following{/other_user}","gists_url":"https://api.github.com/users/newvicklee/gists{/gist_id}","starred_url":"https://api.github.com/users/newvicklee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newvicklee/subscriptions","organizations_url":"https://api.github.com/users/newvicklee/orgs","repos_url":"https://api.github.com/users/newvicklee/repos","events_url":"https://api.github.com/users/newvicklee/events{/privacy}","received_events_url":"https://api.github.com/users/newvicklee/received_events","type":"User","site_admin":false},"repo":{"id":154572186,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1NzIxODY=","name":"fastai","full_name":"newvicklee/fastai","private":false,"owner":{"login":"newvicklee","id":7368628,"node_id":"MDQ6VXNlcjczNjg2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/7368628?v=4","gravatar_id":"","url":"https://api.github.com/users/newvicklee","html_url":"https://github.com/newvicklee","followers_url":"https://api.github.com/users/newvicklee/followers","following_url":"https://api.github.com/users/newvicklee/following{/other_user}","gists_url":"https://api.github.com/users/newvicklee/gists{/gist_id}","starred_url":"https://api.github.com/users/newvicklee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newvicklee/subscriptions","organizations_url":"https://api.github.com/users/newvicklee/orgs","repos_url":"https://api.github.com/users/newvicklee/repos","events_url":"https://api.github.com/users/newvicklee/events{/privacy}","received_events_url":"https://api.github.com/users/newvicklee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/newvicklee/fastai","description":"The fastai deep learning library, plus lessons and and tutorials","fork":true,"url":"https://api.github.com/repos/newvicklee/fastai","forks_url":"https://api.github.com/repos/newvicklee/fastai/forks","keys_url":"https://api.github.com/repos/newvicklee/fastai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newvicklee/fastai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newvicklee/fastai/teams","hooks_url":"https://api.github.com/repos/newvicklee/fastai/hooks","issue_events_url":"https://api.github.com/repos/newvicklee/fastai/issues/events{/number}","events_url":"https://api.github.com/repos/newvicklee/fastai/events","assignees_url":"https://api.github.com/repos/newvicklee/fastai/assignees{/user}","branches_url":"https://api.github.com/repos/newvicklee/fastai/branches{/branch}","tags_url":"https://api.github.com/repos/newvicklee/fastai/tags","blobs_url":"https://api.github.com/repos/newvicklee/fastai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newvicklee/fastai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newvicklee/fastai/git/refs{/sha}","trees_url":"https://api.github.com/repos/newvicklee/fastai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newvicklee/fastai/statuses/{sha}","languages_url":"https://api.github.com/repos/newvicklee/fastai/languages","stargazers_url":"https://api.github.com/repos/newvicklee/fastai/stargazers","contributors_url":"https://api.github.com/repos/newvicklee/fastai/contributors","subscribers_url":"https://api.github.com/repos/newvicklee/fastai/subscribers","subscription_url":"https://api.github.com/repos/newvicklee/fastai/subscription","commits_url":"https://api.github.com/repos/newvicklee/fastai/commits{/sha}","git_commits_url":"https://api.github.com/repos/newvicklee/fastai/git/commits{/sha}","comments_url":"https://api.github.com/repos/newvicklee/fastai/comments{/number}","issue_comment_url":"https://api.github.com/repos/newvicklee/fastai/issues/comments{/number}","contents_url":"https://api.github.com/repos/newvicklee/fastai/contents/{+path}","compare_url":"https://api.github.com/repos/newvicklee/fastai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newvicklee/fastai/merges","archive_url":"https://api.github.com/repos/newvicklee/fastai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newvicklee/fastai/downloads","issues_url":"https://api.github.com/repos/newvicklee/fastai/issues{/number}","pulls_url":"https://api.github.com/repos/newvicklee/fastai/pulls{/number}","milestones_url":"https://api.github.com/repos/newvicklee/fastai/milestones{/number}","notifications_url":"https://api.github.com/repos/newvicklee/fastai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newvicklee/fastai/labels{/name}","releases_url":"https://api.github.com/repos/newvicklee/fastai/releases{/id}","deployments_url":"https://api.github.com/repos/newvicklee/fastai/deployments","created_at":"2018-10-24T21:34:00Z","updated_at":"2018-10-24T21:40:29Z","pushed_at":"2018-10-24T21:52:22Z","git_url":"git://github.com/newvicklee/fastai.git","ssh_url":"git@github.com:newvicklee/fastai.git","clone_url":"https://github.com/newvicklee/fastai.git","svn_url":"https://github.com/newvicklee/fastai","homepage":"http://docs.fast.ai","size":210626,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastai:master","ref":"master","sha":"5da5089f9f7f57276f269ee7c93de66e4f89ea0c","user":{"login":"fastai","id":20547620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTQ3NjIw","avatar_url":"https://avatars3.githubusercontent.com/u/20547620?v=4","gravatar_id":"","url":"https://api.github.com/users/fastai","html_url":"https://github.com/fastai","followers_url":"https://api.github.com/users/fastai/followers","following_url":"https://api.github.com/users/fastai/following{/other_user}","gists_url":"https://api.github.com/users/fastai/gists{/gist_id}","starred_url":"https://api.github.com/users/fastai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastai/subscriptions","organizations_url":"https://api.github.com/users/fastai/orgs","repos_url":"https://api.github.com/users/fastai/repos","events_url":"https://api.github.com/users/fastai/events{/privacy}","received_events_url":"https://api.github.com/users/fastai/received_events","type":"Organization","site_admin":false},"repo":{"id":102973646,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5NzM2NDY=","name":"fastai","full_name":"fastai/fastai","private":false,"owner":{"login":"fastai","id":20547620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTQ3NjIw","avatar_url":"https://avatars3.githubusercontent.com/u/20547620?v=4","gravatar_id":"","url":"https://api.github.com/users/fastai","html_url":"https://github.com/fastai","followers_url":"https://api.github.com/users/fastai/followers","following_url":"https://api.github.com/users/fastai/following{/other_user}","gists_url":"https://api.github.com/users/fastai/gists{/gist_id}","starred_url":"https://api.github.com/users/fastai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastai/subscriptions","organizations_url":"https://api.github.com/users/fastai/orgs","repos_url":"https://api.github.com/users/fastai/repos","events_url":"https://api.github.com/users/fastai/events{/privacy}","received_events_url":"https://api.github.com/users/fastai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fastai/fastai","description":"The fastai deep learning library, plus lessons and and tutorials","fork":false,"url":"https://api.github.com/repos/fastai/fastai","forks_url":"https://api.github.com/repos/fastai/fastai/forks","keys_url":"https://api.github.com/repos/fastai/fastai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastai/fastai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastai/fastai/teams","hooks_url":"https://api.github.com/repos/fastai/fastai/hooks","issue_events_url":"https://api.github.com/repos/fastai/fastai/issues/events{/number}","events_url":"https://api.github.com/repos/fastai/fastai/events","assignees_url":"https://api.github.com/repos/fastai/fastai/assignees{/user}","branches_url":"https://api.github.com/repos/fastai/fastai/branches{/branch}","tags_url":"https://api.github.com/repos/fastai/fastai/tags","blobs_url":"https://api.github.com/repos/fastai/fastai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastai/fastai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastai/fastai/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastai/fastai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastai/fastai/statuses/{sha}","languages_url":"https://api.github.com/repos/fastai/fastai/languages","stargazers_url":"https://api.github.com/repos/fastai/fastai/stargazers","contributors_url":"https://api.github.com/repos/fastai/fastai/contributors","subscribers_url":"https://api.github.com/repos/fastai/fastai/subscribers","subscription_url":"https://api.github.com/repos/fastai/fastai/subscription","commits_url":"https://api.github.com/repos/fastai/fastai/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastai/fastai/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastai/fastai/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastai/fastai/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastai/fastai/contents/{+path}","compare_url":"https://api.github.com/repos/fastai/fastai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastai/fastai/merges","archive_url":"https://api.github.com/repos/fastai/fastai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastai/fastai/downloads","issues_url":"https://api.github.com/repos/fastai/fastai/issues{/number}","pulls_url":"https://api.github.com/repos/fastai/fastai/pulls{/number}","milestones_url":"https://api.github.com/repos/fastai/fastai/milestones{/number}","notifications_url":"https://api.github.com/repos/fastai/fastai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastai/fastai/labels{/name}","releases_url":"https://api.github.com/repos/fastai/fastai/releases{/id}","deployments_url":"https://api.github.com/repos/fastai/fastai/deployments","created_at":"2017-09-09T17:43:36Z","updated_at":"2018-10-25T03:36:31Z","pushed_at":"2018-10-25T03:45:41Z","git_url":"git://github.com/fastai/fastai.git","ssh_url":"git@github.com:fastai/fastai.git","clone_url":"https://github.com/fastai/fastai.git","svn_url":"https://github.com/fastai/fastai","homepage":"http://docs.fast.ai","size":210653,"stargazers_count":8963,"watchers_count":8963,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3133,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3133,"open_issues":6,"watchers":8963,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastai/fastai/pulls/967"},"html":{"href":"https://github.com/fastai/fastai/pull/967"},"issue":{"href":"https://api.github.com/repos/fastai/fastai/issues/967"},"comments":{"href":"https://api.github.com/repos/fastai/fastai/issues/967/comments"},"review_comments":{"href":"https://api.github.com/repos/fastai/fastai/pulls/967/comments"},"review_comment":{"href":"https://api.github.com/repos/fastai/fastai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastai/fastai/pulls/967/commits"},"statuses":{"href":"https://api.github.com/repos/fastai/fastai/statuses/a1b51523ac8689ba6082d61c5a56a8b7af7547ba"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jph00","id":346999,"node_id":"MDQ6VXNlcjM0Njk5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/346999?v=4","gravatar_id":"","url":"https://api.github.com/users/jph00","html_url":"https://github.com/jph00","followers_url":"https://api.github.com/users/jph00/followers","following_url":"https://api.github.com/users/jph00/following{/other_user}","gists_url":"https://api.github.com/users/jph00/gists{/gist_id}","starred_url":"https://api.github.com/users/jph00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jph00/subscriptions","organizations_url":"https://api.github.com/users/jph00/orgs","repos_url":"https://api.github.com/users/jph00/repos","events_url":"https://api.github.com/users/jph00/events{/privacy}","received_events_url":"https://api.github.com/users/jph00/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"jph00"}}