{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/191211627","pull_request_review_id":123741296,"id":191211627,"diff_hunk":"@@ -896,6 +898,10 @@ public static JobGraph getJobGraph(Configuration flinkConfig, FlinkPlan optPlan,\n \t\t\tjob = gen.compileJobGraph((OptimizedPlan) optPlan);\n \t\t}\n \n+\t\t//  if we disable checkpoint and do not set restart strategy, Restart strategy will be set as in flink-conf.yaml\n+\t\t//  in flip6, jobmaster do not set this conf, so we have set this conf here.","path":"flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java","position":14,"original_position":14,"commit_id":"ce21b04a21d6a177f243b9e595e075601099b09d","original_commit_id":"ce21b04a21d6a177f243b9e595e075601099b09d","user":{"login":"yuqi1129","id":15794564,"avatar_url":"https://avatars3.githubusercontent.com/u/15794564?v=4","gravatar_id":"","url":"https://api.github.com/users/yuqi1129","html_url":"https://github.com/yuqi1129","followers_url":"https://api.github.com/users/yuqi1129/followers","following_url":"https://api.github.com/users/yuqi1129/following{/other_user}","gists_url":"https://api.github.com/users/yuqi1129/gists{/gist_id}","starred_url":"https://api.github.com/users/yuqi1129/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuqi1129/subscriptions","organizations_url":"https://api.github.com/users/yuqi1129/orgs","repos_url":"https://api.github.com/users/yuqi1129/repos","events_url":"https://api.github.com/users/yuqi1129/events{/privacy}","received_events_url":"https://api.github.com/users/yuqi1129/received_events","type":"User","site_admin":false},"body":"You are right, I omit this point, sorry","created_at":"2018-05-28T13:49:16Z","updated_at":"2018-05-28T13:49:16Z","html_url":"https://github.com/apache/flink/pull/5846#discussion_r191211627","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/5846","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/191211627"},"html":{"href":"https://github.com/apache/flink/pull/5846#discussion_r191211627"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/5846"}},"in_reply_to_id":191133308},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/5846","id":181633233,"html_url":"https://github.com/apache/flink/pull/5846","diff_url":"https://github.com/apache/flink/pull/5846.diff","patch_url":"https://github.com/apache/flink/pull/5846.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/5846","number":5846,"state":"open","locked":false,"title":"[FLINK-9143] [client] Restart strategy defined in flink-conf.yaml is ignored","user":{"login":"yuqi1129","id":15794564,"avatar_url":"https://avatars3.githubusercontent.com/u/15794564?v=4","gravatar_id":"","url":"https://api.github.com/users/yuqi1129","html_url":"https://github.com/yuqi1129","followers_url":"https://api.github.com/users/yuqi1129/followers","following_url":"https://api.github.com/users/yuqi1129/following{/other_user}","gists_url":"https://api.github.com/users/yuqi1129/gists{/gist_id}","starred_url":"https://api.github.com/users/yuqi1129/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuqi1129/subscriptions","organizations_url":"https://api.github.com/users/yuqi1129/orgs","repos_url":"https://api.github.com/users/yuqi1129/repos","events_url":"https://api.github.com/users/yuqi1129/events{/privacy}","received_events_url":"https://api.github.com/users/yuqi1129/received_events","type":"User","site_admin":false},"body":"\r\n## What is the purpose of the change\r\n\r\nThis change is to fix the bug that if restart strategy was not specifically set in user code, flink will not use default strategy set in flink-conf.yaml in flip6 mode. \r\n## Brief change log\r\n\r\n  - In `ClusterClient.getJobGraph`, if no strategy was set in user code, we set strategy strategy just as flink-conf.yaml do \r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows:\r\n\r\n  - Add `ClusterClientTest.testgetJobGraph` \r\n -  Add `FailureRateRestartStrategyTest.testFailureRateRestartStrategyConf` and `FixedDelayRestartStrategyTest.testFixedRestartStrategyConf`\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n  - The serializers: (no)\r\n  - The runtime per-record code paths (performance sensitive): (no)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n  - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (no)","created_at":"2018-04-14T06:22:25Z","updated_at":"2018-05-28T13:49:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15d5dc2e1304da114a14cbdebfd5e8b63824a978","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/5846/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/5846/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/5846/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/ce21b04a21d6a177f243b9e595e075601099b09d","head":{"label":"yuqi1129:confproblem","ref":"confproblem","sha":"ce21b04a21d6a177f243b9e595e075601099b09d","user":{"login":"yuqi1129","id":15794564,"avatar_url":"https://avatars3.githubusercontent.com/u/15794564?v=4","gravatar_id":"","url":"https://api.github.com/users/yuqi1129","html_url":"https://github.com/yuqi1129","followers_url":"https://api.github.com/users/yuqi1129/followers","following_url":"https://api.github.com/users/yuqi1129/following{/other_user}","gists_url":"https://api.github.com/users/yuqi1129/gists{/gist_id}","starred_url":"https://api.github.com/users/yuqi1129/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuqi1129/subscriptions","organizations_url":"https://api.github.com/users/yuqi1129/orgs","repos_url":"https://api.github.com/users/yuqi1129/repos","events_url":"https://api.github.com/users/yuqi1129/events{/privacy}","received_events_url":"https://api.github.com/users/yuqi1129/received_events","type":"User","site_admin":false},"repo":{"id":97899873,"name":"flink","full_name":"yuqi1129/flink","owner":{"login":"yuqi1129","id":15794564,"avatar_url":"https://avatars3.githubusercontent.com/u/15794564?v=4","gravatar_id":"","url":"https://api.github.com/users/yuqi1129","html_url":"https://github.com/yuqi1129","followers_url":"https://api.github.com/users/yuqi1129/followers","following_url":"https://api.github.com/users/yuqi1129/following{/other_user}","gists_url":"https://api.github.com/users/yuqi1129/gists{/gist_id}","starred_url":"https://api.github.com/users/yuqi1129/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuqi1129/subscriptions","organizations_url":"https://api.github.com/users/yuqi1129/orgs","repos_url":"https://api.github.com/users/yuqi1129/repos","events_url":"https://api.github.com/users/yuqi1129/events{/privacy}","received_events_url":"https://api.github.com/users/yuqi1129/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuqi1129/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/yuqi1129/flink","forks_url":"https://api.github.com/repos/yuqi1129/flink/forks","keys_url":"https://api.github.com/repos/yuqi1129/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuqi1129/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuqi1129/flink/teams","hooks_url":"https://api.github.com/repos/yuqi1129/flink/hooks","issue_events_url":"https://api.github.com/repos/yuqi1129/flink/issues/events{/number}","events_url":"https://api.github.com/repos/yuqi1129/flink/events","assignees_url":"https://api.github.com/repos/yuqi1129/flink/assignees{/user}","branches_url":"https://api.github.com/repos/yuqi1129/flink/branches{/branch}","tags_url":"https://api.github.com/repos/yuqi1129/flink/tags","blobs_url":"https://api.github.com/repos/yuqi1129/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuqi1129/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuqi1129/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuqi1129/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuqi1129/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/yuqi1129/flink/languages","stargazers_url":"https://api.github.com/repos/yuqi1129/flink/stargazers","contributors_url":"https://api.github.com/repos/yuqi1129/flink/contributors","subscribers_url":"https://api.github.com/repos/yuqi1129/flink/subscribers","subscription_url":"https://api.github.com/repos/yuqi1129/flink/subscription","commits_url":"https://api.github.com/repos/yuqi1129/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuqi1129/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuqi1129/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuqi1129/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuqi1129/flink/contents/{+path}","compare_url":"https://api.github.com/repos/yuqi1129/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuqi1129/flink/merges","archive_url":"https://api.github.com/repos/yuqi1129/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuqi1129/flink/downloads","issues_url":"https://api.github.com/repos/yuqi1129/flink/issues{/number}","pulls_url":"https://api.github.com/repos/yuqi1129/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/yuqi1129/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/yuqi1129/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuqi1129/flink/labels{/name}","releases_url":"https://api.github.com/repos/yuqi1129/flink/releases{/id}","deployments_url":"https://api.github.com/repos/yuqi1129/flink/deployments","created_at":"2017-07-21T02:59:42Z","updated_at":"2017-07-21T03:00:04Z","pushed_at":"2018-05-26T14:44:15Z","git_url":"git://github.com/yuqi1129/flink.git","ssh_url":"git@github.com:yuqi1129/flink.git","clone_url":"https://github.com/yuqi1129/flink.git","svn_url":"https://github.com/yuqi1129/flink","homepage":null,"size":154201,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"fc679f49d6806cddad75b3eda1c8da2a7e2d46c9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-05-28T13:09:40Z","pushed_at":"2018-05-28T13:15:43Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":156403,"stargazers_count":3750,"watchers_count":3750,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2550,"mirror_url":null,"archived":false,"open_issues_count":342,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2550,"open_issues":342,"watchers":3750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/5846"},"html":{"href":"https://github.com/apache/flink/pull/5846"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/5846"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/5846/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/5846/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/5846/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/ce21b04a21d6a177f243b9e595e075601099b09d"}},"author_association":"NONE"}}
{"actor":{"display_login":"yuqi1129"}}