{"action":"created","comment":{"url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/comments/243732429","pull_request_review_id":187587261,"id":243732429,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzczMjQyOQ==","diff_hunk":"@@ -25,6 +24,21 @@ class InternalModule extends InternalModule_parent\n     protected $stateFine = true;\n     protected $checked = false;\n \n+    const METADATA_NOT_IN_DB = 0;\n+    const OK = 1;\n+    const DB_HAS_WRONG_DATA = -1;\n+    const MODULE_FILE_NOT_FOUND = -2;\n+    const SHOP_FILE_NOT_FOUND = -3;\n+\n+    protected function getAutoloader(){\n+        if (Registry::instanceExists('autoloader')){","path":"Core/InternalModule.php","position":19,"original_position":19,"commit_id":"c6234db9fa760c86badd00567cecf56f68118bff","original_commit_id":"c6234db9fa760c86badd00567cecf56f68118bff","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Avoid using static access to class '\\OxidEsales\\Eshop\\Core\\Registry' in method 'getAutoloader'.](https://app.codacy.com/app/keywan.ghadami/oxid-module-internals/pullRequest?prid=2648033)","created_at":"2018-12-22T10:02:56Z","updated_at":"2018-12-22T10:02:56Z","html_url":"https://github.com/OXIDprojects/oxid-module-internals/pull/36#discussion_r243732429","pull_request_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/36","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/comments/243732429"},"html":{"href":"https://github.com/OXIDprojects/oxid-module-internals/pull/36#discussion_r243732429"},"pull_request":{"href":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/36","id":234522160,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTIyMTYw","html_url":"https://github.com/OXIDprojects/oxid-module-internals/pull/36","diff_url":"https://github.com/OXIDprojects/oxid-module-internals/pull/36.diff","patch_url":"https://github.com/OXIDprojects/oxid-module-internals/pull/36.patch","issue_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/issues/36","number":36,"state":"open","locked":false,"title":"WIP: using well named const values ","user":{"login":"keywan-ghadami-oxid","id":7767623,"node_id":"MDQ6VXNlcjc3Njc2MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/7767623?v=4","gravatar_id":"","url":"https://api.github.com/users/keywan-ghadami-oxid","html_url":"https://github.com/keywan-ghadami-oxid","followers_url":"https://api.github.com/users/keywan-ghadami-oxid/followers","following_url":"https://api.github.com/users/keywan-ghadami-oxid/following{/other_user}","gists_url":"https://api.github.com/users/keywan-ghadami-oxid/gists{/gist_id}","starred_url":"https://api.github.com/users/keywan-ghadami-oxid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keywan-ghadami-oxid/subscriptions","organizations_url":"https://api.github.com/users/keywan-ghadami-oxid/orgs","repos_url":"https://api.github.com/users/keywan-ghadami-oxid/repos","events_url":"https://api.github.com/users/keywan-ghadami-oxid/events{/privacy}","received_events_url":"https://api.github.com/users/keywan-ghadami-oxid/received_events","type":"User","site_admin":false},"body":"instead of integers to make code readable\r\navoid loading composer autoloader multiple times (reuse of code and performance)","created_at":"2018-11-29T06:24:17Z","updated_at":"2018-12-22T10:02:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"337ec32588f81e17b934002ab296cbfcdbed6f3b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/36/commits","review_comments_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/36/comments","review_comment_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/issues/36/comments","statuses_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/statuses/c6234db9fa760c86badd00567cecf56f68118bff","head":{"label":"OXIDprojects:refactoring-const-autoloader","ref":"refactoring-const-autoloader","sha":"c6234db9fa760c86badd00567cecf56f68118bff","user":{"login":"OXIDprojects","id":1338074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzgwNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1338074?v=4","gravatar_id":"","url":"https://api.github.com/users/OXIDprojects","html_url":"https://github.com/OXIDprojects","followers_url":"https://api.github.com/users/OXIDprojects/followers","following_url":"https://api.github.com/users/OXIDprojects/following{/other_user}","gists_url":"https://api.github.com/users/OXIDprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/OXIDprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXIDprojects/subscriptions","organizations_url":"https://api.github.com/users/OXIDprojects/orgs","repos_url":"https://api.github.com/users/OXIDprojects/repos","events_url":"https://api.github.com/users/OXIDprojects/events{/privacy}","received_events_url":"https://api.github.com/users/OXIDprojects/received_events","type":"Organization","site_admin":false},"repo":{"id":6670463,"node_id":"MDEwOlJlcG9zaXRvcnk2NjcwNDYz","name":"oxid-module-internals","full_name":"OXIDprojects/oxid-module-internals","private":false,"owner":{"login":"OXIDprojects","id":1338074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzgwNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1338074?v=4","gravatar_id":"","url":"https://api.github.com/users/OXIDprojects","html_url":"https://github.com/OXIDprojects","followers_url":"https://api.github.com/users/OXIDprojects/followers","following_url":"https://api.github.com/users/OXIDprojects/following{/other_user}","gists_url":"https://api.github.com/users/OXIDprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/OXIDprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXIDprojects/subscriptions","organizations_url":"https://api.github.com/users/OXIDprojects/orgs","repos_url":"https://api.github.com/users/OXIDprojects/repos","events_url":"https://api.github.com/users/OXIDprojects/events{/privacy}","received_events_url":"https://api.github.com/users/OXIDprojects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OXIDprojects/oxid-module-internals","description":"OXID eShop module system helper tools","fork":false,"url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals","forks_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/forks","keys_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/teams","hooks_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/hooks","issue_events_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/issues/events{/number}","events_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/events","assignees_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/assignees{/user}","branches_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/branches{/branch}","tags_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/tags","blobs_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/git/refs{/sha}","trees_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/statuses/{sha}","languages_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/languages","stargazers_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/stargazers","contributors_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/contributors","subscribers_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/subscribers","subscription_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/subscription","commits_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/commits{/sha}","git_commits_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/git/commits{/sha}","comments_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/comments{/number}","issue_comment_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/issues/comments{/number}","contents_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/contents/{+path}","compare_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/merges","archive_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/downloads","issues_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/issues{/number}","pulls_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls{/number}","milestones_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/milestones{/number}","notifications_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/labels{/name}","releases_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/releases{/id}","deployments_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/deployments","created_at":"2012-11-13T12:38:38Z","updated_at":"2018-12-22T09:52:46Z","pushed_at":"2018-12-22T10:00:40Z","git_url":"git://github.com/OXIDprojects/oxid-module-internals.git","ssh_url":"git@github.com:OXIDprojects/oxid-module-internals.git","clone_url":"https://github.com/OXIDprojects/oxid-module-internals.git","svn_url":"https://github.com/OXIDprojects/oxid-module-internals","homepage":null,"size":380,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":6,"open_issues":7,"watchers":8,"default_branch":"master"}},"base":{"label":"OXIDprojects:master","ref":"master","sha":"ce15721b74473af1c016ec00544b2f52b8f84044","user":{"login":"OXIDprojects","id":1338074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzgwNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1338074?v=4","gravatar_id":"","url":"https://api.github.com/users/OXIDprojects","html_url":"https://github.com/OXIDprojects","followers_url":"https://api.github.com/users/OXIDprojects/followers","following_url":"https://api.github.com/users/OXIDprojects/following{/other_user}","gists_url":"https://api.github.com/users/OXIDprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/OXIDprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXIDprojects/subscriptions","organizations_url":"https://api.github.com/users/OXIDprojects/orgs","repos_url":"https://api.github.com/users/OXIDprojects/repos","events_url":"https://api.github.com/users/OXIDprojects/events{/privacy}","received_events_url":"https://api.github.com/users/OXIDprojects/received_events","type":"Organization","site_admin":false},"repo":{"id":6670463,"node_id":"MDEwOlJlcG9zaXRvcnk2NjcwNDYz","name":"oxid-module-internals","full_name":"OXIDprojects/oxid-module-internals","private":false,"owner":{"login":"OXIDprojects","id":1338074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzgwNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1338074?v=4","gravatar_id":"","url":"https://api.github.com/users/OXIDprojects","html_url":"https://github.com/OXIDprojects","followers_url":"https://api.github.com/users/OXIDprojects/followers","following_url":"https://api.github.com/users/OXIDprojects/following{/other_user}","gists_url":"https://api.github.com/users/OXIDprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/OXIDprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXIDprojects/subscriptions","organizations_url":"https://api.github.com/users/OXIDprojects/orgs","repos_url":"https://api.github.com/users/OXIDprojects/repos","events_url":"https://api.github.com/users/OXIDprojects/events{/privacy}","received_events_url":"https://api.github.com/users/OXIDprojects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OXIDprojects/oxid-module-internals","description":"OXID eShop module system helper tools","fork":false,"url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals","forks_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/forks","keys_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/teams","hooks_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/hooks","issue_events_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/issues/events{/number}","events_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/events","assignees_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/assignees{/user}","branches_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/branches{/branch}","tags_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/tags","blobs_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/git/refs{/sha}","trees_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/statuses/{sha}","languages_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/languages","stargazers_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/stargazers","contributors_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/contributors","subscribers_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/subscribers","subscription_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/subscription","commits_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/commits{/sha}","git_commits_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/git/commits{/sha}","comments_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/comments{/number}","issue_comment_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/issues/comments{/number}","contents_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/contents/{+path}","compare_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/merges","archive_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/downloads","issues_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/issues{/number}","pulls_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls{/number}","milestones_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/milestones{/number}","notifications_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/labels{/name}","releases_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/releases{/id}","deployments_url":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/deployments","created_at":"2012-11-13T12:38:38Z","updated_at":"2018-12-22T09:52:46Z","pushed_at":"2018-12-22T10:00:40Z","git_url":"git://github.com/OXIDprojects/oxid-module-internals.git","ssh_url":"git@github.com:OXIDprojects/oxid-module-internals.git","clone_url":"https://github.com/OXIDprojects/oxid-module-internals.git","svn_url":"https://github.com/OXIDprojects/oxid-module-internals","homepage":null,"size":380,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":6,"open_issues":7,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/36"},"html":{"href":"https://github.com/OXIDprojects/oxid-module-internals/pull/36"},"issue":{"href":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/issues/36"},"comments":{"href":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/OXIDprojects/oxid-module-internals/statuses/c6234db9fa760c86badd00567cecf56f68118bff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codacy-bot"}}