{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/dispatch/pulls/comments/165234241","pull_request_review_id":93138740,"id":165234241,"diff_hunk":"@@ -0,0 +1,34 @@\n+{{- if .Values.ingress.enabled -}}\n+{{- $tls := default .Values.global.tls .Values.ingress.tls -}}\n+apiVersion: extensions/v1beta1\n+kind: Ingress\n+metadata:\n+  name: {{ template \"fullname\" . }}\n+  labels:\n+    app: {{ template \"name\" . }}\n+    chart: {{ .Chart.Name }}-{{ .Chart.Version | replace \"+\" \"_\" }}\n+    release: {{ .Release.Name }}\n+    heritage: {{ .Release.Service }}\n+  annotations:\n+    kubernetes.io/ingress.class: nginx\n+    ingress.kubernetes.io/auth-signin: https://$host/oauth2/start\n+    ingress.kubernetes.io/auth-url: http://{{ .Release.Name }}-oauth2-proxy.{{ .Release.Namespace }}.svc.cluster.local/oauth2/auth\n+    {{- range $key, $value := .Values.ingress.annotations }}\n+      {{ $key }}: {{ $value | quote }}\n+    {{- end }}\n+spec:\n+  rules:\n+    - host: {{ default .Values.global.host .Values.ingress.host }}","path":"charts/dispatch/charts/application-manager/templates/ingress.yaml","position":21,"original_position":21,"commit_id":"44ec61c333359707fff1b688b58acca68b9216e9","original_commit_id":"44ec61c333359707fff1b688b58acca68b9216e9","user":{"login":"neosab","id":1743810,"avatar_url":"https://avatars3.githubusercontent.com/u/1743810?v=4","gravatar_id":"","url":"https://api.github.com/users/neosab","html_url":"https://github.com/neosab","followers_url":"https://api.github.com/users/neosab/followers","following_url":"https://api.github.com/users/neosab/following{/other_user}","gists_url":"https://api.github.com/users/neosab/gists{/gist_id}","starred_url":"https://api.github.com/users/neosab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neosab/subscriptions","organizations_url":"https://api.github.com/users/neosab/orgs","repos_url":"https://api.github.com/users/neosab/repos","events_url":"https://api.github.com/users/neosab/events{/privacy}","received_events_url":"https://api.github.com/users/neosab/received_events","type":"User","site_admin":false},"body":"Can you add this check here:- \r\n      ```\r\n{{- if $ingress_host }}\r\nhost: {{ $ingress_host }}\r\n{{- end -}}\r\n```","created_at":"2018-02-01T00:59:57Z","updated_at":"2018-02-01T00:59:57Z","html_url":"https://github.com/vmware/dispatch/pull/143#discussion_r165234241","pull_request_url":"https://api.github.com/repos/vmware/dispatch/pulls/143","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/comments/165234241"},"html":{"href":"https://github.com/vmware/dispatch/pull/143#discussion_r165234241"},"pull_request":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/dispatch/pulls/143","id":165463372,"html_url":"https://github.com/vmware/dispatch/pull/143","diff_url":"https://github.com/vmware/dispatch/pull/143.diff","patch_url":"https://github.com/vmware/dispatch/pull/143.patch","issue_url":"https://api.github.com/repos/vmware/dispatch/issues/143","number":143,"state":"open","locked":false,"title":"initial code - application-manager","user":{"login":"seanhuxy","id":7037564,"avatar_url":"https://avatars2.githubusercontent.com/u/7037564?v=4","gravatar_id":"","url":"https://api.github.com/users/seanhuxy","html_url":"https://github.com/seanhuxy","followers_url":"https://api.github.com/users/seanhuxy/followers","following_url":"https://api.github.com/users/seanhuxy/following{/other_user}","gists_url":"https://api.github.com/users/seanhuxy/gists{/gist_id}","starred_url":"https://api.github.com/users/seanhuxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanhuxy/subscriptions","organizations_url":"https://api.github.com/users/seanhuxy/orgs","repos_url":"https://api.github.com/users/seanhuxy/repos","events_url":"https://api.github.com/users/seanhuxy/events{/privacy}","received_events_url":"https://api.github.com/users/seanhuxy/received_events","type":"User","site_admin":false},"body":"fixes https://github.com/vmware/dispatch/issues/90","created_at":"2018-01-26T21:20:37Z","updated_at":"2018-02-01T00:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce8f412dbd9d1bfa3aa0a5bda43440df754e2002","assignee":null,"assignees":[],"requested_reviewers":[{"login":"imikushin","id":931932,"avatar_url":"https://avatars3.githubusercontent.com/u/931932?v=4","gravatar_id":"","url":"https://api.github.com/users/imikushin","html_url":"https://github.com/imikushin","followers_url":"https://api.github.com/users/imikushin/followers","following_url":"https://api.github.com/users/imikushin/following{/other_user}","gists_url":"https://api.github.com/users/imikushin/gists{/gist_id}","starred_url":"https://api.github.com/users/imikushin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imikushin/subscriptions","organizations_url":"https://api.github.com/users/imikushin/orgs","repos_url":"https://api.github.com/users/imikushin/repos","events_url":"https://api.github.com/users/imikushin/events{/privacy}","received_events_url":"https://api.github.com/users/imikushin/received_events","type":"User","site_admin":false},{"login":"kars7e","id":1920092,"avatar_url":"https://avatars3.githubusercontent.com/u/1920092?v=4","gravatar_id":"","url":"https://api.github.com/users/kars7e","html_url":"https://github.com/kars7e","followers_url":"https://api.github.com/users/kars7e/followers","following_url":"https://api.github.com/users/kars7e/following{/other_user}","gists_url":"https://api.github.com/users/kars7e/gists{/gist_id}","starred_url":"https://api.github.com/users/kars7e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kars7e/subscriptions","organizations_url":"https://api.github.com/users/kars7e/orgs","repos_url":"https://api.github.com/users/kars7e/repos","events_url":"https://api.github.com/users/kars7e/events{/privacy}","received_events_url":"https://api.github.com/users/kars7e/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/dispatch/pulls/143/commits","review_comments_url":"https://api.github.com/repos/vmware/dispatch/pulls/143/comments","review_comment_url":"https://api.github.com/repos/vmware/dispatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/dispatch/issues/143/comments","statuses_url":"https://api.github.com/repos/vmware/dispatch/statuses/44ec61c333359707fff1b688b58acca68b9216e9","head":{"label":"seanhuxy:application-code","ref":"application-code","sha":"44ec61c333359707fff1b688b58acca68b9216e9","user":{"login":"seanhuxy","id":7037564,"avatar_url":"https://avatars2.githubusercontent.com/u/7037564?v=4","gravatar_id":"","url":"https://api.github.com/users/seanhuxy","html_url":"https://github.com/seanhuxy","followers_url":"https://api.github.com/users/seanhuxy/followers","following_url":"https://api.github.com/users/seanhuxy/following{/other_user}","gists_url":"https://api.github.com/users/seanhuxy/gists{/gist_id}","starred_url":"https://api.github.com/users/seanhuxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanhuxy/subscriptions","organizations_url":"https://api.github.com/users/seanhuxy/orgs","repos_url":"https://api.github.com/users/seanhuxy/repos","events_url":"https://api.github.com/users/seanhuxy/events{/privacy}","received_events_url":"https://api.github.com/users/seanhuxy/received_events","type":"User","site_admin":false},"repo":{"id":115066540,"name":"dispatch","full_name":"seanhuxy/dispatch","owner":{"login":"seanhuxy","id":7037564,"avatar_url":"https://avatars2.githubusercontent.com/u/7037564?v=4","gravatar_id":"","url":"https://api.github.com/users/seanhuxy","html_url":"https://github.com/seanhuxy","followers_url":"https://api.github.com/users/seanhuxy/followers","following_url":"https://api.github.com/users/seanhuxy/following{/other_user}","gists_url":"https://api.github.com/users/seanhuxy/gists{/gist_id}","starred_url":"https://api.github.com/users/seanhuxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanhuxy/subscriptions","organizations_url":"https://api.github.com/users/seanhuxy/orgs","repos_url":"https://api.github.com/users/seanhuxy/repos","events_url":"https://api.github.com/users/seanhuxy/events{/privacy}","received_events_url":"https://api.github.com/users/seanhuxy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seanhuxy/dispatch","description":"Dispatch is a framework for deploying and managing serverless style applications.","fork":true,"url":"https://api.github.com/repos/seanhuxy/dispatch","forks_url":"https://api.github.com/repos/seanhuxy/dispatch/forks","keys_url":"https://api.github.com/repos/seanhuxy/dispatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seanhuxy/dispatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seanhuxy/dispatch/teams","hooks_url":"https://api.github.com/repos/seanhuxy/dispatch/hooks","issue_events_url":"https://api.github.com/repos/seanhuxy/dispatch/issues/events{/number}","events_url":"https://api.github.com/repos/seanhuxy/dispatch/events","assignees_url":"https://api.github.com/repos/seanhuxy/dispatch/assignees{/user}","branches_url":"https://api.github.com/repos/seanhuxy/dispatch/branches{/branch}","tags_url":"https://api.github.com/repos/seanhuxy/dispatch/tags","blobs_url":"https://api.github.com/repos/seanhuxy/dispatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seanhuxy/dispatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seanhuxy/dispatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/seanhuxy/dispatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seanhuxy/dispatch/statuses/{sha}","languages_url":"https://api.github.com/repos/seanhuxy/dispatch/languages","stargazers_url":"https://api.github.com/repos/seanhuxy/dispatch/stargazers","contributors_url":"https://api.github.com/repos/seanhuxy/dispatch/contributors","subscribers_url":"https://api.github.com/repos/seanhuxy/dispatch/subscribers","subscription_url":"https://api.github.com/repos/seanhuxy/dispatch/subscription","commits_url":"https://api.github.com/repos/seanhuxy/dispatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/seanhuxy/dispatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/seanhuxy/dispatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/seanhuxy/dispatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/seanhuxy/dispatch/contents/{+path}","compare_url":"https://api.github.com/repos/seanhuxy/dispatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seanhuxy/dispatch/merges","archive_url":"https://api.github.com/repos/seanhuxy/dispatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seanhuxy/dispatch/downloads","issues_url":"https://api.github.com/repos/seanhuxy/dispatch/issues{/number}","pulls_url":"https://api.github.com/repos/seanhuxy/dispatch/pulls{/number}","milestones_url":"https://api.github.com/repos/seanhuxy/dispatch/milestones{/number}","notifications_url":"https://api.github.com/repos/seanhuxy/dispatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seanhuxy/dispatch/labels{/name}","releases_url":"https://api.github.com/repos/seanhuxy/dispatch/releases{/id}","deployments_url":"https://api.github.com/repos/seanhuxy/dispatch/deployments","created_at":"2017-12-22T02:14:38Z","updated_at":"2017-12-22T02:14:40Z","pushed_at":"2018-02-01T00:34:54Z","git_url":"git://github.com/seanhuxy/dispatch.git","ssh_url":"git@github.com:seanhuxy/dispatch.git","clone_url":"https://github.com/seanhuxy/dispatch.git","svn_url":"https://github.com/seanhuxy/dispatch","homepage":"","size":6738,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"6da8596d0dad5937b43fd4d757f8a331598d22c7","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":113911425,"name":"dispatch","full_name":"vmware/dispatch","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/dispatch","description":"Dispatch is a framework for deploying and managing serverless style applications.","fork":false,"url":"https://api.github.com/repos/vmware/dispatch","forks_url":"https://api.github.com/repos/vmware/dispatch/forks","keys_url":"https://api.github.com/repos/vmware/dispatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/dispatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/dispatch/teams","hooks_url":"https://api.github.com/repos/vmware/dispatch/hooks","issue_events_url":"https://api.github.com/repos/vmware/dispatch/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/dispatch/events","assignees_url":"https://api.github.com/repos/vmware/dispatch/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/dispatch/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/dispatch/tags","blobs_url":"https://api.github.com/repos/vmware/dispatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/dispatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/dispatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/dispatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/dispatch/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/dispatch/languages","stargazers_url":"https://api.github.com/repos/vmware/dispatch/stargazers","contributors_url":"https://api.github.com/repos/vmware/dispatch/contributors","subscribers_url":"https://api.github.com/repos/vmware/dispatch/subscribers","subscription_url":"https://api.github.com/repos/vmware/dispatch/subscription","commits_url":"https://api.github.com/repos/vmware/dispatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/dispatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/dispatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/dispatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/dispatch/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/dispatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/dispatch/merges","archive_url":"https://api.github.com/repos/vmware/dispatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/dispatch/downloads","issues_url":"https://api.github.com/repos/vmware/dispatch/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/dispatch/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/dispatch/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/dispatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/dispatch/labels{/name}","releases_url":"https://api.github.com/repos/vmware/dispatch/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/dispatch/deployments","created_at":"2017-12-11T21:39:57Z","updated_at":"2018-01-31T15:56:31Z","pushed_at":"2018-02-01T00:45:27Z","git_url":"git://github.com/vmware/dispatch.git","ssh_url":"git@github.com:vmware/dispatch.git","clone_url":"https://github.com/vmware/dispatch.git","svn_url":"https://github.com/vmware/dispatch","homepage":"","size":6664,"stargazers_count":234,"watchers_count":234,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":19,"open_issues":62,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/143"},"html":{"href":"https://github.com/vmware/dispatch/pull/143"},"issue":{"href":"https://api.github.com/repos/vmware/dispatch/issues/143"},"comments":{"href":"https://api.github.com/repos/vmware/dispatch/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/dispatch/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/dispatch/statuses/44ec61c333359707fff1b688b58acca68b9216e9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"neosab"}}