{"action":"created","issue":{"url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1415","repository_url":"https://api.github.com/repos/rhinstaller/anaconda","labels_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1415/labels{/name}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1415/comments","events_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1415/events","html_url":"https://github.com/rhinstaller/anaconda/pull/1415","id":311569296,"number":1415,"title":"Move install time dependencies to a metapackage","user":{"login":"M4rtinK","id":829558,"avatar_url":"https://avatars3.githubusercontent.com/u/829558?v=4","gravatar_id":"","url":"https://api.github.com/users/M4rtinK","html_url":"https://github.com/M4rtinK","followers_url":"https://api.github.com/users/M4rtinK/followers","following_url":"https://api.github.com/users/M4rtinK/following{/other_user}","gists_url":"https://api.github.com/users/M4rtinK/gists{/gist_id}","starred_url":"https://api.github.com/users/M4rtinK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M4rtinK/subscriptions","organizations_url":"https://api.github.com/users/M4rtinK/orgs","repos_url":"https://api.github.com/users/M4rtinK/repos","events_url":"https://api.github.com/users/M4rtinK/events{/privacy}","received_events_url":"https://api.github.com/users/M4rtinK/received_events","type":"User","site_admin":false},"labels":[{"id":851679102,"url":"https://api.github.com/repos/rhinstaller/anaconda/labels/f28","name":"f28","color":"f4e581","default":false},{"id":196499629,"url":"https://api.github.com/repos/rhinstaller/anaconda/labels/master","name":"master","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-05T11:15:43Z","updated_at":"2018-04-11T19:18:36Z","closed_at":"2018-04-09T18:37:38Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/1415","html_url":"https://github.com/rhinstaller/anaconda/pull/1415","diff_url":"https://github.com/rhinstaller/anaconda/pull/1415.diff","patch_url":"https://github.com/rhinstaller/anaconda/pull/1415.patch"},"body":"Move dependencies that Anaconda needs only in the installation\r\nenvironment (live/netinst/DVD) to a metapackage.\r\nThis way we can exclude the dependencies when they are not needed\r\n(Initial Setup, dirinstall) while still being able to elegantly\r\npull them to the install images via Lorax templates and image\r\nkickstarts.\r\n\r\nDependencies moved to anaconda-install-env-deps:\r\n* libblockdev-plugins-all\r\n* realmd - realm join happens at install time only\r\n* isomd5sum - definitely needed at install time only\r\n* createrepo_c - needed for driver disks, install time only\r\n* fcoe-utils - install time fcoe handling\r\n* hfsplus-tools - Mac storage resize support\r\n* kexec-tools - install time kexec support\r\n\r\nDependencies moved from the Lorax template:\r\n* tmux - runs install time status screens\r\n* gdb - install time debugging\r\n\r\nDependencies added:\r\n* udisks2-iscsi - see rhbz#1561047 for details\r\n\r\nDependencies dropped:\r\n* parted - no longer directly called, we use the Python bindings\r\n* python3-iscsi-initiator-utils - no longer used by Anaconda"},"comment":{"url":"https://api.github.com/repos/rhinstaller/anaconda/issues/comments/380565916","html_url":"https://github.com/rhinstaller/anaconda/pull/1415#issuecomment-380565916","issue_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1415","id":380565916,"user":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars1.githubusercontent.com/u/916551?v=4","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T19:18:36Z","updated_at":"2018-04-11T19:18:36Z","author_association":"CONTRIBUTOR","body":"I'm honestly a bit worried about this going into F28 between Beta and Final. It's a fairly disruptive change and I'm afraid it hasn't been comprehensively planned out.\r\n\r\nI just thought to look around for places which currently assume just installing 'anaconda' is sufficient, which have not yet been touched in relation to this change, and I see two just in Pungi:\r\n\r\n* https://pagure.io/pungi/blob/master/f/pungi/phases/buildinstall.py#_441\r\n* https://pagure.io/pungi/blob/master/f/pungi/phases/createiso.py#_204\r\n\r\nThose obviously need fixing, but I'm not at all sure that's the *only* problem we're going to expose here. This really seems more like Rawhide than F28 material to me."}}
{"actor":{"display_login":"AdamWill"}}