{"action":"created","issue":{"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1468","repository_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons","labels_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1468/labels{/name}","comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1468/comments","events_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1468/events","html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1468","id":353809108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzU5MDc1","number":1468,"title":"#1467 - Versioned ClientLibs cause WARN log messages on AEM 6.3 (#1467)","user":{"login":"jsedding","id":797695,"node_id":"MDQ6VXNlcjc5NzY5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/797695?v=4","gravatar_id":"","url":"https://api.github.com/users/jsedding","html_url":"https://github.com/jsedding","followers_url":"https://api.github.com/users/jsedding/followers","following_url":"https://api.github.com/users/jsedding/following{/other_user}","gists_url":"https://api.github.com/users/jsedding/gists{/gist_id}","starred_url":"https://api.github.com/users/jsedding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsedding/subscriptions","organizations_url":"https://api.github.com/users/jsedding/orgs","repos_url":"https://api.github.com/users/jsedding/repos","events_url":"https://api.github.com/users/jsedding/events{/privacy}","received_events_url":"https://api.github.com/users/jsedding/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-24T14:35:00Z","updated_at":"2018-08-30T08:17:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1468","html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1468","diff_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1468.diff","patch_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1468.patch"},"body":"Avoids the documented warnings for proxied clientlibs by checking whether the respective clientlib exists using the method `HtmlLibraryManage#getLibraries()` before loading the HtmlLibrary as before."},"comment":{"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/comments/417232068","html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1468#issuecomment-417232068","issue_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1468","id":417232068,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzIzMjA2OA==","user":{"login":"jsedding","id":797695,"node_id":"MDQ6VXNlcjc5NzY5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/797695?v=4","gravatar_id":"","url":"https://api.github.com/users/jsedding","html_url":"https://github.com/jsedding","followers_url":"https://api.github.com/users/jsedding/followers","following_url":"https://api.github.com/users/jsedding/following{/other_user}","gists_url":"https://api.github.com/users/jsedding/gists{/gist_id}","starred_url":"https://api.github.com/users/jsedding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsedding/subscriptions","organizations_url":"https://api.github.com/users/jsedding/orgs","repos_url":"https://api.github.com/users/jsedding/repos","events_url":"https://api.github.com/users/jsedding/events{/privacy}","received_events_url":"https://api.github.com/users/jsedding/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T08:17:58Z","updated_at":"2018-08-30T08:17:58Z","author_association":"NONE","body":"@justinedelson not so much, because the search paths loop only has two iterations (in a standard setup). So the cost would be cut in half. Now the rewriter may rewrite e.g. 10 clientlibs per rendered HTML page, thus incurring the cost of copying the map 10 instead of 20 times.\r\n\r\nWith the previous solution the cost of copying the map is never incurred, thus we would still have a significant overhead. With a cache, we would get (almost) on par with the previous solution. For a system with no changes to clientlibs (i.e. normal publish) the cost would be incurred once.\r\n\r\nOf course cache invalidation increases complexity somewhat. So there's a trade off.\r\n"}}
{"actor":{"display_login":"jsedding"}}