{"action":"created","issue":{"url":"https://api.github.com/repos/pingcap/tidb/issues/7652","repository_url":"https://api.github.com/repos/pingcap/tidb","labels_url":"https://api.github.com/repos/pingcap/tidb/issues/7652/labels{/name}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/7652/comments","events_url":"https://api.github.com/repos/pingcap/tidb/issues/7652/events","html_url":"https://github.com/pingcap/tidb/issues/7652","id":358449498,"node_id":"MDU6SXNzdWUzNTg0NDk0OTg=","number":7652,"title":"Inappropriate handle empty value in load data","user":{"login":"ssnijik","id":3711535,"node_id":"MDQ6VXNlcjM3MTE1MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3711535?v=4","gravatar_id":"","url":"https://api.github.com/users/ssnijik","html_url":"https://github.com/ssnijik","followers_url":"https://api.github.com/users/ssnijik/followers","following_url":"https://api.github.com/users/ssnijik/following{/other_user}","gists_url":"https://api.github.com/users/ssnijik/gists{/gist_id}","starred_url":"https://api.github.com/users/ssnijik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssnijik/subscriptions","organizations_url":"https://api.github.com/users/ssnijik/orgs","repos_url":"https://api.github.com/users/ssnijik/repos","events_url":"https://api.github.com/users/ssnijik/events{/privacy}","received_events_url":"https://api.github.com/users/ssnijik/received_events","type":"User","site_admin":false},"labels":[{"id":256872091,"node_id":"MDU6TGFiZWwyNTY4NzIwOTE=","url":"https://api.github.com/repos/pingcap/tidb/labels/question","name":"question","color":"fbca04","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-09-10T02:57:49Z","updated_at":"2018-09-12T02:37:55Z","closed_at":null,"author_association":"NONE","body":"## Bug Report\r\n\r\nPlease answer these questions before submitting your issue. Thanks!\r\n\r\n1. What did you do?\r\nIf possible, provide a recipe for reproducing the error.\r\nWhen loading data(csv) into tidb, if numeric field(integer, double, ...) is empty, it will raise an error from function StrToFloat.\r\n\r\n2. What did you expect to see?\r\nI try to insert following record into table(decimal(18,0),varchar(64),tinyint,smallint,double,double,double,double,char(1),int,double,char(1),char(1),char(1),char(1))\r\n`123456789,xyzxyz,1,-99,,,,,N,,,N,N,N,N`\r\nI think it will be insert into table correctly\r\n\r\n3. What did you see instead?\r\nError is raised from function StrToFloat. Since almost every record raise such an error log, log is filled with tons of the same error.\r\n\r\n> 2018/09/07 00:44:50.440 write.go:712: [warning] ignore err:[types:1265]Data Truncated\r\n> /home/jenkins/workspace/build_tidb_2.0/go/src/github.com/pingcap/tidb/types/convert.go:421: \r\n> /home/jenkins/workspace/build_tidb_2.0/go/src/github.com/pingcap/tidb/types/convert.go:321: \r\n> /home/jenkins/workspace/build_tidb_2.0/go/src/github.com/pingcap/tidb/types/datum.go:742: \r\n> /home/jenkins/workspace/build_tidb_2.0/go/src/github.com/pingcap/tidb/table/column.go:154:\r\n\r\nIf i change record to following style, everything goes fine.\r\n`123456789,xyzxyz,1,-99,0,0,0,0,N,0,0,N,N,N,N`\r\n\r\n4. What version of TiDB are you using (`tidb-server -V` or run `select tidb_version();` on TiDB)?\r\nRelease Version: v2.0.0\r\nGit Commit Hash: 637e130e6a9ba2e54e158131c0466233db39a60e\r\nGit Branch: release-2.0\r\nUTC Build Time: 2018-04-27 11:43:00\r\nGoVersion: go version go1.10 linux/amd64\r\nTiKV Min Version: 2.0.0-rc.4.1 |\r\n\r\nIt'll be appreciated if you can also answer the following questions:\r\n1. Is there any schdule for new data importing tool **lighting**?\r\n2. What's the most effect way to import data for now, **load data** or **batch insert**? I tried both, but both of them are too slow for me. \r\n"},"comment":{"url":"https://api.github.com/repos/pingcap/tidb/issues/comments/420492422","html_url":"https://github.com/pingcap/tidb/issues/7652#issuecomment-420492422","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/7652","id":420492422,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDQ5MjQyMg==","user":{"login":"kennytm","id":103023,"node_id":"MDQ6VXNlcjEwMzAyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/103023?v=4","gravatar_id":"","url":"https://api.github.com/users/kennytm","html_url":"https://github.com/kennytm","followers_url":"https://api.github.com/users/kennytm/followers","following_url":"https://api.github.com/users/kennytm/following{/other_user}","gists_url":"https://api.github.com/users/kennytm/gists{/gist_id}","starred_url":"https://api.github.com/users/kennytm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennytm/subscriptions","organizations_url":"https://api.github.com/users/kennytm/orgs","repos_url":"https://api.github.com/users/kennytm/repos","events_url":"https://api.github.com/users/kennytm/events{/privacy}","received_events_url":"https://api.github.com/users/kennytm/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T02:37:55Z","updated_at":"2018-09-12T02:37:55Z","author_association":"MEMBER","body":"@ssnijik We plan to release the first version by October. We'll post further info when it's ready 🙂."}}
{"actor":{"display_login":"kennytm"}}