{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/web-ui/pulls/comments/229668961","pull_request_review_id":170220103,"id":229668961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTY2ODk2MQ==","diff_hunk":"@@ -1,11 +1,21 @@\n import * as _ from 'lodash-es';\n import React, { Component, Fragment } from 'react';\n+import { connect } from 'react-redux';\n \n import { ListHeader, ColHead, List, ListPage, ResourceRow, DetailsPage } from './factory/okdfactory';\n import { breadcrumbsForOwnerRefs, Firehose, ResourceLink, navFactory, ResourceCog, Cog } from './utils/okdutils';\n-import { VirtualMachineInstanceModel, VirtualMachineModel, PodModel, NamespaceModel, TemplateModel, NetworkAttachmentDefinitionModel } from '../models';\n+import {\n+  VirtualMachineInstanceModel,\n+  VirtualMachineModel,\n+  PodModel,\n+  NamespaceModel,\n+  TemplateModel,\n+  NetworkAttachmentDefinitionModel,\n+  StorageClassModel,\n+  PersistentVolumeClaimModel\n+} from '../models';\n import { k8sCreate, actions } from '../module/okdk8s';\n-import { connect } from 'react-redux';\n+import { units } from '../../components/utils/units';","path":"frontend/public/kubevirt/components/vm.jsx","position":20,"original_position":20,"commit_id":"5110281f1008367b0c7ef60dfe9cad0bbbdd60df","original_commit_id":"5110281f1008367b0c7ef60dfe9cad0bbbdd60df","user":{"login":"mareklibra","id":17194943,"node_id":"MDQ6VXNlcjE3MTk0OTQz","avatar_url":"https://avatars2.githubusercontent.com/u/17194943?v=4","gravatar_id":"","url":"https://api.github.com/users/mareklibra","html_url":"https://github.com/mareklibra","followers_url":"https://api.github.com/users/mareklibra/followers","following_url":"https://api.github.com/users/mareklibra/following{/other_user}","gists_url":"https://api.github.com/users/mareklibra/gists{/gist_id}","starred_url":"https://api.github.com/users/mareklibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareklibra/subscriptions","organizations_url":"https://api.github.com/users/mareklibra/orgs","repos_url":"https://api.github.com/users/mareklibra/repos","events_url":"https://api.github.com/users/mareklibra/events{/privacy}","received_events_url":"https://api.github.com/users/mareklibra/received_events","type":"User","site_admin":false},"body":"Please use `frontend/public/kubevirt/components/utils/okdutils.tsx` as the reference is already indirected there.","created_at":"2018-10-31T12:16:07Z","updated_at":"2018-10-31T12:16:22Z","html_url":"https://github.com/kubevirt/web-ui/pull/46#discussion_r229668961","pull_request_url":"https://api.github.com/repos/kubevirt/web-ui/pulls/46","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/web-ui/pulls/comments/229668961"},"html":{"href":"https://github.com/kubevirt/web-ui/pull/46#discussion_r229668961"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/web-ui/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/web-ui/pulls/46","id":223948028,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTQ4MDI4","html_url":"https://github.com/kubevirt/web-ui/pull/46","diff_url":"https://github.com/kubevirt/web-ui/pull/46.diff","patch_url":"https://github.com/kubevirt/web-ui/pull/46.patch","issue_url":"https://api.github.com/repos/kubevirt/web-ui/issues/46","number":46,"state":"open","locked":false,"title":"add DisksTab to CreateVmWizard","user":{"login":"suomiy","id":3648838,"node_id":"MDQ6VXNlcjM2NDg4Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/3648838?v=4","gravatar_id":"","url":"https://api.github.com/users/suomiy","html_url":"https://github.com/suomiy","followers_url":"https://api.github.com/users/suomiy/followers","following_url":"https://api.github.com/users/suomiy/following{/other_user}","gists_url":"https://api.github.com/users/suomiy/gists{/gist_id}","starred_url":"https://api.github.com/users/suomiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suomiy/subscriptions","organizations_url":"https://api.github.com/users/suomiy/orgs","repos_url":"https://api.github.com/users/suomiy/repos","events_url":"https://api.github.com/users/suomiy/events{/privacy}","received_events_url":"https://api.github.com/users/suomiy/received_events","type":"User","site_admin":false},"body":"depends on https://github.com/kubevirt/web-ui-components/pull/10\r\n\r\nstyles fix is located in: https://github.com/suomiy/console/commits/disks-tab-integration-styles","created_at":"2018-10-18T13:03:52Z","updated_at":"2018-10-31T12:16:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3424c57f3062e1d979af33f4aea1884befaed956","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1080281605,"node_id":"MDU6TGFiZWwxMDgwMjgxNjA1","url":"https://api.github.com/repos/kubevirt/web-ui/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/web-ui/pulls/46/commits","review_comments_url":"https://api.github.com/repos/kubevirt/web-ui/pulls/46/comments","review_comment_url":"https://api.github.com/repos/kubevirt/web-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/web-ui/issues/46/comments","statuses_url":"https://api.github.com/repos/kubevirt/web-ui/statuses/5110281f1008367b0c7ef60dfe9cad0bbbdd60df","head":{"label":"suomiy:disks-tab-integration","ref":"disks-tab-integration","sha":"5110281f1008367b0c7ef60dfe9cad0bbbdd60df","user":{"login":"suomiy","id":3648838,"node_id":"MDQ6VXNlcjM2NDg4Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/3648838?v=4","gravatar_id":"","url":"https://api.github.com/users/suomiy","html_url":"https://github.com/suomiy","followers_url":"https://api.github.com/users/suomiy/followers","following_url":"https://api.github.com/users/suomiy/following{/other_user}","gists_url":"https://api.github.com/users/suomiy/gists{/gist_id}","starred_url":"https://api.github.com/users/suomiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suomiy/subscriptions","organizations_url":"https://api.github.com/users/suomiy/orgs","repos_url":"https://api.github.com/users/suomiy/repos","events_url":"https://api.github.com/users/suomiy/events{/privacy}","received_events_url":"https://api.github.com/users/suomiy/received_events","type":"User","site_admin":false},"repo":{"id":142444116,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0NDQxMTY=","name":"console","full_name":"suomiy/console","private":false,"owner":{"login":"suomiy","id":3648838,"node_id":"MDQ6VXNlcjM2NDg4Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/3648838?v=4","gravatar_id":"","url":"https://api.github.com/users/suomiy","html_url":"https://github.com/suomiy","followers_url":"https://api.github.com/users/suomiy/followers","following_url":"https://api.github.com/users/suomiy/following{/other_user}","gists_url":"https://api.github.com/users/suomiy/gists{/gist_id}","starred_url":"https://api.github.com/users/suomiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suomiy/subscriptions","organizations_url":"https://api.github.com/users/suomiy/orgs","repos_url":"https://api.github.com/users/suomiy/repos","events_url":"https://api.github.com/users/suomiy/events{/privacy}","received_events_url":"https://api.github.com/users/suomiy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/suomiy/console","description":"OpenShift Cluster Console UI","fork":true,"url":"https://api.github.com/repos/suomiy/console","forks_url":"https://api.github.com/repos/suomiy/console/forks","keys_url":"https://api.github.com/repos/suomiy/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suomiy/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suomiy/console/teams","hooks_url":"https://api.github.com/repos/suomiy/console/hooks","issue_events_url":"https://api.github.com/repos/suomiy/console/issues/events{/number}","events_url":"https://api.github.com/repos/suomiy/console/events","assignees_url":"https://api.github.com/repos/suomiy/console/assignees{/user}","branches_url":"https://api.github.com/repos/suomiy/console/branches{/branch}","tags_url":"https://api.github.com/repos/suomiy/console/tags","blobs_url":"https://api.github.com/repos/suomiy/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suomiy/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suomiy/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/suomiy/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suomiy/console/statuses/{sha}","languages_url":"https://api.github.com/repos/suomiy/console/languages","stargazers_url":"https://api.github.com/repos/suomiy/console/stargazers","contributors_url":"https://api.github.com/repos/suomiy/console/contributors","subscribers_url":"https://api.github.com/repos/suomiy/console/subscribers","subscription_url":"https://api.github.com/repos/suomiy/console/subscription","commits_url":"https://api.github.com/repos/suomiy/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/suomiy/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/suomiy/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/suomiy/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/suomiy/console/contents/{+path}","compare_url":"https://api.github.com/repos/suomiy/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suomiy/console/merges","archive_url":"https://api.github.com/repos/suomiy/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suomiy/console/downloads","issues_url":"https://api.github.com/repos/suomiy/console/issues{/number}","pulls_url":"https://api.github.com/repos/suomiy/console/pulls{/number}","milestones_url":"https://api.github.com/repos/suomiy/console/milestones{/number}","notifications_url":"https://api.github.com/repos/suomiy/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suomiy/console/labels{/name}","releases_url":"https://api.github.com/repos/suomiy/console/releases{/id}","deployments_url":"https://api.github.com/repos/suomiy/console/deployments","created_at":"2018-07-26T13:22:35Z","updated_at":"2018-07-26T13:22:38Z","pushed_at":"2018-10-19T21:08:56Z","git_url":"git://github.com/suomiy/console.git","ssh_url":"git@github.com:suomiy/console.git","clone_url":"https://github.com/suomiy/console.git","svn_url":"https://github.com/suomiy/console","homepage":"https://www.openshift.org","size":88648,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"71516df61c6e1e676ccf645a1d839281ff1c5ed8","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":148635837,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2MzU4Mzc=","name":"web-ui","full_name":"kubevirt/web-ui","private":false,"owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubevirt/web-ui","description":"OpenShift Cluster Console UI","fork":true,"url":"https://api.github.com/repos/kubevirt/web-ui","forks_url":"https://api.github.com/repos/kubevirt/web-ui/forks","keys_url":"https://api.github.com/repos/kubevirt/web-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/web-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/web-ui/teams","hooks_url":"https://api.github.com/repos/kubevirt/web-ui/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/web-ui/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/web-ui/events","assignees_url":"https://api.github.com/repos/kubevirt/web-ui/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/web-ui/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/web-ui/tags","blobs_url":"https://api.github.com/repos/kubevirt/web-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/web-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/web-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/web-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/web-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/web-ui/languages","stargazers_url":"https://api.github.com/repos/kubevirt/web-ui/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/web-ui/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/web-ui/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/web-ui/subscription","commits_url":"https://api.github.com/repos/kubevirt/web-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/web-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/web-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/web-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/web-ui/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/web-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/web-ui/merges","archive_url":"https://api.github.com/repos/kubevirt/web-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/web-ui/downloads","issues_url":"https://api.github.com/repos/kubevirt/web-ui/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/web-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/web-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/web-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/web-ui/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/web-ui/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/web-ui/deployments","created_at":"2018-09-13T12:41:18Z","updated_at":"2018-10-31T11:32:42Z","pushed_at":"2018-10-31T11:32:40Z","git_url":"git://github.com/kubevirt/web-ui.git","ssh_url":"git@github.com:kubevirt/web-ui.git","clone_url":"https://github.com/kubevirt/web-ui.git","svn_url":"https://github.com/kubevirt/web-ui","homepage":"https://www.openshift.org","size":88943,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/web-ui/pulls/46"},"html":{"href":"https://github.com/kubevirt/web-ui/pull/46"},"issue":{"href":"https://api.github.com/repos/kubevirt/web-ui/issues/46"},"comments":{"href":"https://api.github.com/repos/kubevirt/web-ui/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/web-ui/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/web-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/web-ui/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/web-ui/statuses/5110281f1008367b0c7ef60dfe9cad0bbbdd60df"}},"author_association":"NONE"}}
{"actor":{"display_login":"mareklibra"}}