{"action":"created","issue":{"url":"https://api.github.com/repos/xxsds/sdsl-lite/issues/44","repository_url":"https://api.github.com/repos/xxsds/sdsl-lite","labels_url":"https://api.github.com/repos/xxsds/sdsl-lite/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/xxsds/sdsl-lite/issues/44/comments","events_url":"https://api.github.com/repos/xxsds/sdsl-lite/issues/44/events","html_url":"https://github.com/xxsds/sdsl-lite/pull/44","id":341264712,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDY3MzUz","number":44,"title":"CMake and CTest refactoring","user":{"login":"cpockrandt","id":7328307,"node_id":"MDQ6VXNlcjczMjgzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7328307?v=4","gravatar_id":"","url":"https://api.github.com/users/cpockrandt","html_url":"https://github.com/cpockrandt","followers_url":"https://api.github.com/users/cpockrandt/followers","following_url":"https://api.github.com/users/cpockrandt/following{/other_user}","gists_url":"https://api.github.com/users/cpockrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/cpockrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpockrandt/subscriptions","organizations_url":"https://api.github.com/users/cpockrandt/orgs","repos_url":"https://api.github.com/users/cpockrandt/repos","events_url":"https://api.github.com/users/cpockrandt/events{/privacy}","received_events_url":"https://api.github.com/users/cpockrandt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-14T20:15:19Z","updated_at":"2018-07-16T14:14:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/xxsds/sdsl-lite/pulls/44","html_url":"https://github.com/xxsds/sdsl-lite/pull/44","diff_url":"https://github.com/xxsds/sdsl-lite/pull/44.diff","patch_url":"https://github.com/xxsds/sdsl-lite/pull/44.patch"},"body":"This is a draft adressing some of the changes discussed in #39. I included commits from the open PR #40 for now to avoid errors on Travis.\r\n\r\n@h-2 Could you start reviewing this? Feel free to comment on the open **TODOs**:\r\n\r\n* remove install.sh and include installing header files into cmake\r\n* redesigning CMakeLists.txt: should there be a cmake in the root directory or just one each in test/ tutorial/ and eamples/ ?\r\n* We have to fix some failing debug tests (some assertions are not met, see [Travis](https://travis-ci.org/cpockrandt/sdsl-lite/jobs/403962872)). Could you look into this @mpetri? I'm not familiar with the code to see whether the test case is wrong or the assertion in the code. It's nothing serious I think, just an edge case in the child() method of compressed suffix trees\r\n* writing test cases for in-memory usage and remove all other *-im test cases\r\n* there was something with LLVM in .travis.yml that I didn't really understood"},"comment":{"url":"https://api.github.com/repos/xxsds/sdsl-lite/issues/comments/405261528","html_url":"https://github.com/xxsds/sdsl-lite/pull/44#issuecomment-405261528","issue_url":"https://api.github.com/repos/xxsds/sdsl-lite/issues/44","id":405261528,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTI2MTUyOA==","user":{"login":"h-2","id":2996863,"node_id":"MDQ6VXNlcjI5OTY4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2996863?v=4","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T14:14:11Z","updated_at":"2018-07-16T14:14:11Z","author_association":"NONE","body":"In general this looks ok to me, but I don't know coding conventions in the SDSL. I would also argue for keeping one clang instance in the CI.\r\nHas there been a decision, yet, to keep/drop support for GCC4.9? I would strongly argue for dropping it, because of general buggy-ness with C++11/14 things, and also because I am preparing a PR for serialisation support through cereal and it is just so much easier to integrate if I can use `__has_include` which is not available before GCC5. What are your thoughts @mpetri and @simongog ?\r\nDebian stable comes with GCC5 by default and both of the last two Ubuntu long-term-support releases (16.04 and 18.04) have GCC>=5 available, I think it's a fair assumption that that covers almost everybody :wink: "}}
{"actor":{"display_login":"h-2"}}