{"action":"closed","number":142,"pull_request":{"url":"https://api.github.com/repos/buildit/gravity-ui-sass/pulls/142","id":190041379,"html_url":"https://github.com/buildit/gravity-ui-sass/pull/142","diff_url":"https://github.com/buildit/gravity-ui-sass/pull/142.diff","patch_url":"https://github.com/buildit/gravity-ui-sass/pull/142.patch","issue_url":"https://api.github.com/repos/buildit/gravity-ui-sass/issues/142","number":142,"state":"closed","locked":false,"title":"Separated toggle-menu button from nav-menu","user":{"login":"james-nash","id":16718916,"avatar_url":"https://avatars1.githubusercontent.com/u/16718916?v=4","gravatar_id":"","url":"https://api.github.com/users/james-nash","html_url":"https://github.com/james-nash","followers_url":"https://api.github.com/users/james-nash/followers","following_url":"https://api.github.com/users/james-nash/following{/other_user}","gists_url":"https://api.github.com/users/james-nash/gists{/gist_id}","starred_url":"https://api.github.com/users/james-nash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-nash/subscriptions","organizations_url":"https://api.github.com/users/james-nash/orgs","repos_url":"https://api.github.com/users/james-nash/repos","events_url":"https://api.github.com/users/james-nash/events{/privacy}","received_events_url":"https://api.github.com/users/james-nash/received_events","type":"User","site_admin":false},"body":"Closes #131\r\n\r\nThis PR splits out the `toggle-menu` button from the `nav-menu` component, so that when the menu is viewed by itself in the pattern library, it is always visible.\r\n\r\nSome of the associated CSS has been shuffled around a bit and simplified as well.\r\n\r\n\r\n### Overall Approach\r\n\r\n- [x] The code is written with a _content-first_ and _mobile-first_ approach.\r\n- [x] The code has been tested across the major desktop browsers (Chrome, Firefox, Edge, Safari) and mobile browsers (Chrome, Samsung Internet, Safari) to work consistently.\r\n- [x] The code should _degrade gracefully_ on older browsers (please provide an example on how this is the case).\r\n\r\n### Files\r\n\r\n#### JSON\r\n\r\n- [x] Variables are not passed to patterns, unless the pattern requires so.\r\n- [x] All variables are used and defined in the main `_data.json` file.\r\n- [x] Overridden variables appear mostly in `pages`.\r\n\r\n#### Patterns/templates\r\n\r\n- [x] The patterns are devoid of any actual copy, the copy belongs to JSON files (see above).\r\n- [x] The patterns follow the [10 principles of inclusive web design](https://www.designprinciplesftw.com/collections/the-ten-principles-of-inclusive-web-design) which Gravity adheres to.\r\n- [x] The patterns have been tested within their intended use and in isolation \r\n- [x] The patterns should be styled _context-free_ (see above), e.g. no vertical margins should be set, the container should take care of that.\r\n\r\n#### SASS\r\n\r\n- [x] The SASS (and related pattern files) follow the [naming conventions](/docs/naming-conventions.md), architecture and structure outlined in the documentation.\r\n\r\n#### Other (images)\r\n\r\n- [x] The images have been added to Gravity only if specifically needed, otherwise they should belong to PatternLab itself (there are some live examples in the code base).\r\n- [x] Documentation for any new feature and functionality has been added.\r\n- [x] The `CHANGELOG.md` has been updated.\r\n","created_at":"2018-05-23T16:52:47Z","updated_at":"2018-05-29T11:08:48Z","closed_at":"2018-05-29T11:08:48Z","merged_at":"2018-05-29T11:08:48Z","merge_commit_sha":"155da7c9b6a3b810f5999961b3eb8f077d1dad68","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":628138887,"url":"https://api.github.com/repos/buildit/gravity-ui-sass/labels/enhancement","name":"enhancement","color":"287A95","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/buildit/gravity-ui-sass/pulls/142/commits","review_comments_url":"https://api.github.com/repos/buildit/gravity-ui-sass/pulls/142/comments","review_comment_url":"https://api.github.com/repos/buildit/gravity-ui-sass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildit/gravity-ui-sass/issues/142/comments","statuses_url":"https://api.github.com/repos/buildit/gravity-ui-sass/statuses/219c52d819bdc45743deeaf601282f292eaf8fc1","head":{"label":"buildit:131-tidy-up-nav-menu","ref":"131-tidy-up-nav-menu","sha":"219c52d819bdc45743deeaf601282f292eaf8fc1","user":{"login":"buildit","id":17282100,"avatar_url":"https://avatars0.githubusercontent.com/u/17282100?v=4","gravatar_id":"","url":"https://api.github.com/users/buildit","html_url":"https://github.com/buildit","followers_url":"https://api.github.com/users/buildit/followers","following_url":"https://api.github.com/users/buildit/following{/other_user}","gists_url":"https://api.github.com/users/buildit/gists{/gist_id}","starred_url":"https://api.github.com/users/buildit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildit/subscriptions","organizations_url":"https://api.github.com/users/buildit/orgs","repos_url":"https://api.github.com/users/buildit/repos","events_url":"https://api.github.com/users/buildit/events{/privacy}","received_events_url":"https://api.github.com/users/buildit/received_events","type":"Organization","site_admin":false},"repo":{"id":94554467,"name":"gravity-ui-sass","full_name":"buildit/gravity-ui-sass","owner":{"login":"buildit","id":17282100,"avatar_url":"https://avatars0.githubusercontent.com/u/17282100?v=4","gravatar_id":"","url":"https://api.github.com/users/buildit","html_url":"https://github.com/buildit","followers_url":"https://api.github.com/users/buildit/followers","following_url":"https://api.github.com/users/buildit/following{/other_user}","gists_url":"https://api.github.com/users/buildit/gists{/gist_id}","starred_url":"https://api.github.com/users/buildit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildit/subscriptions","organizations_url":"https://api.github.com/users/buildit/orgs","repos_url":"https://api.github.com/users/buildit/repos","events_url":"https://api.github.com/users/buildit/events{/privacy}","received_events_url":"https://api.github.com/users/buildit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildit/gravity-ui-sass","description":"A SASS UI library from Buildit's Gravity design system","fork":false,"url":"https://api.github.com/repos/buildit/gravity-ui-sass","forks_url":"https://api.github.com/repos/buildit/gravity-ui-sass/forks","keys_url":"https://api.github.com/repos/buildit/gravity-ui-sass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildit/gravity-ui-sass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildit/gravity-ui-sass/teams","hooks_url":"https://api.github.com/repos/buildit/gravity-ui-sass/hooks","issue_events_url":"https://api.github.com/repos/buildit/gravity-ui-sass/issues/events{/number}","events_url":"https://api.github.com/repos/buildit/gravity-ui-sass/events","assignees_url":"https://api.github.com/repos/buildit/gravity-ui-sass/assignees{/user}","branches_url":"https://api.github.com/repos/buildit/gravity-ui-sass/branches{/branch}","tags_url":"https://api.github.com/repos/buildit/gravity-ui-sass/tags","blobs_url":"https://api.github.com/repos/buildit/gravity-ui-sass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildit/gravity-ui-sass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildit/gravity-ui-sass/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildit/gravity-ui-sass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildit/gravity-ui-sass/statuses/{sha}","languages_url":"https://api.github.com/repos/buildit/gravity-ui-sass/languages","stargazers_url":"https://api.github.com/repos/buildit/gravity-ui-sass/stargazers","contributors_url":"https://api.github.com/repos/buildit/gravity-ui-sass/contributors","subscribers_url":"https://api.github.com/repos/buildit/gravity-ui-sass/subscribers","subscription_url":"https://api.github.com/repos/buildit/gravity-ui-sass/subscription","commits_url":"https://api.github.com/repos/buildit/gravity-ui-sass/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildit/gravity-ui-sass/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildit/gravity-ui-sass/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildit/gravity-ui-sass/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildit/gravity-ui-sass/contents/{+path}","compare_url":"https://api.github.com/repos/buildit/gravity-ui-sass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildit/gravity-ui-sass/merges","archive_url":"https://api.github.com/repos/buildit/gravity-ui-sass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildit/gravity-ui-sass/downloads","issues_url":"https://api.github.com/repos/buildit/gravity-ui-sass/issues{/number}","pulls_url":"https://api.github.com/repos/buildit/gravity-ui-sass/pulls{/number}","milestones_url":"https://api.github.com/repos/buildit/gravity-ui-sass/milestones{/number}","notifications_url":"https://api.github.com/repos/buildit/gravity-ui-sass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildit/gravity-ui-sass/labels{/name}","releases_url":"https://api.github.com/repos/buildit/gravity-ui-sass/releases{/id}","deployments_url":"https://api.github.com/repos/buildit/gravity-ui-sass/deployments","created_at":"2017-06-16T14:57:36Z","updated_at":"2018-05-25T08:46:14Z","pushed_at":"2018-05-29T11:08:48Z","git_url":"git://github.com/buildit/gravity-ui-sass.git","ssh_url":"git@github.com:buildit/gravity-ui-sass.git","clone_url":"https://github.com/buildit/gravity-ui-sass.git","svn_url":"https://github.com/buildit/gravity-ui-sass","homepage":"http://style.buildit.digital/","size":6299,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":15,"watchers":6,"default_branch":"develop"}},"base":{"label":"buildit:develop","ref":"develop","sha":"af09210747bdd0cf622ddce42cc3ad9497e0d4b6","user":{"login":"buildit","id":17282100,"avatar_url":"https://avatars0.githubusercontent.com/u/17282100?v=4","gravatar_id":"","url":"https://api.github.com/users/buildit","html_url":"https://github.com/buildit","followers_url":"https://api.github.com/users/buildit/followers","following_url":"https://api.github.com/users/buildit/following{/other_user}","gists_url":"https://api.github.com/users/buildit/gists{/gist_id}","starred_url":"https://api.github.com/users/buildit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildit/subscriptions","organizations_url":"https://api.github.com/users/buildit/orgs","repos_url":"https://api.github.com/users/buildit/repos","events_url":"https://api.github.com/users/buildit/events{/privacy}","received_events_url":"https://api.github.com/users/buildit/received_events","type":"Organization","site_admin":false},"repo":{"id":94554467,"name":"gravity-ui-sass","full_name":"buildit/gravity-ui-sass","owner":{"login":"buildit","id":17282100,"avatar_url":"https://avatars0.githubusercontent.com/u/17282100?v=4","gravatar_id":"","url":"https://api.github.com/users/buildit","html_url":"https://github.com/buildit","followers_url":"https://api.github.com/users/buildit/followers","following_url":"https://api.github.com/users/buildit/following{/other_user}","gists_url":"https://api.github.com/users/buildit/gists{/gist_id}","starred_url":"https://api.github.com/users/buildit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildit/subscriptions","organizations_url":"https://api.github.com/users/buildit/orgs","repos_url":"https://api.github.com/users/buildit/repos","events_url":"https://api.github.com/users/buildit/events{/privacy}","received_events_url":"https://api.github.com/users/buildit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildit/gravity-ui-sass","description":"A SASS UI library from Buildit's Gravity design system","fork":false,"url":"https://api.github.com/repos/buildit/gravity-ui-sass","forks_url":"https://api.github.com/repos/buildit/gravity-ui-sass/forks","keys_url":"https://api.github.com/repos/buildit/gravity-ui-sass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildit/gravity-ui-sass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildit/gravity-ui-sass/teams","hooks_url":"https://api.github.com/repos/buildit/gravity-ui-sass/hooks","issue_events_url":"https://api.github.com/repos/buildit/gravity-ui-sass/issues/events{/number}","events_url":"https://api.github.com/repos/buildit/gravity-ui-sass/events","assignees_url":"https://api.github.com/repos/buildit/gravity-ui-sass/assignees{/user}","branches_url":"https://api.github.com/repos/buildit/gravity-ui-sass/branches{/branch}","tags_url":"https://api.github.com/repos/buildit/gravity-ui-sass/tags","blobs_url":"https://api.github.com/repos/buildit/gravity-ui-sass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildit/gravity-ui-sass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildit/gravity-ui-sass/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildit/gravity-ui-sass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildit/gravity-ui-sass/statuses/{sha}","languages_url":"https://api.github.com/repos/buildit/gravity-ui-sass/languages","stargazers_url":"https://api.github.com/repos/buildit/gravity-ui-sass/stargazers","contributors_url":"https://api.github.com/repos/buildit/gravity-ui-sass/contributors","subscribers_url":"https://api.github.com/repos/buildit/gravity-ui-sass/subscribers","subscription_url":"https://api.github.com/repos/buildit/gravity-ui-sass/subscription","commits_url":"https://api.github.com/repos/buildit/gravity-ui-sass/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildit/gravity-ui-sass/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildit/gravity-ui-sass/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildit/gravity-ui-sass/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildit/gravity-ui-sass/contents/{+path}","compare_url":"https://api.github.com/repos/buildit/gravity-ui-sass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildit/gravity-ui-sass/merges","archive_url":"https://api.github.com/repos/buildit/gravity-ui-sass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildit/gravity-ui-sass/downloads","issues_url":"https://api.github.com/repos/buildit/gravity-ui-sass/issues{/number}","pulls_url":"https://api.github.com/repos/buildit/gravity-ui-sass/pulls{/number}","milestones_url":"https://api.github.com/repos/buildit/gravity-ui-sass/milestones{/number}","notifications_url":"https://api.github.com/repos/buildit/gravity-ui-sass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildit/gravity-ui-sass/labels{/name}","releases_url":"https://api.github.com/repos/buildit/gravity-ui-sass/releases{/id}","deployments_url":"https://api.github.com/repos/buildit/gravity-ui-sass/deployments","created_at":"2017-06-16T14:57:36Z","updated_at":"2018-05-25T08:46:14Z","pushed_at":"2018-05-29T11:08:48Z","git_url":"git://github.com/buildit/gravity-ui-sass.git","ssh_url":"git@github.com:buildit/gravity-ui-sass.git","clone_url":"https://github.com/buildit/gravity-ui-sass.git","svn_url":"https://github.com/buildit/gravity-ui-sass","homepage":"http://style.buildit.digital/","size":6299,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":15,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/buildit/gravity-ui-sass/pulls/142"},"html":{"href":"https://github.com/buildit/gravity-ui-sass/pull/142"},"issue":{"href":"https://api.github.com/repos/buildit/gravity-ui-sass/issues/142"},"comments":{"href":"https://api.github.com/repos/buildit/gravity-ui-sass/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/buildit/gravity-ui-sass/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/buildit/gravity-ui-sass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildit/gravity-ui-sass/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/buildit/gravity-ui-sass/statuses/219c52d819bdc45743deeaf601282f292eaf8fc1"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"danbull","id":4202934,"avatar_url":"https://avatars0.githubusercontent.com/u/4202934?v=4","gravatar_id":"","url":"https://api.github.com/users/danbull","html_url":"https://github.com/danbull","followers_url":"https://api.github.com/users/danbull/followers","following_url":"https://api.github.com/users/danbull/following{/other_user}","gists_url":"https://api.github.com/users/danbull/gists{/gist_id}","starred_url":"https://api.github.com/users/danbull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbull/subscriptions","organizations_url":"https://api.github.com/users/danbull/orgs","repos_url":"https://api.github.com/users/danbull/repos","events_url":"https://api.github.com/users/danbull/events{/privacy}","received_events_url":"https://api.github.com/users/danbull/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":23,"deletions":16,"changed_files":5}}
{"actor":{"display_login":"danbull"}}