{"push_id":2774345590,"size":6,"distinct_size":6,"ref":"refs/heads/new-resource-loader","head":"9a9629cca9a806add2c5044ae3e9587431b4a633","before":"e6e37a07ee6bf428f6cee5be1a01d6457300257e","commits":[{"sha":"c8d471679d2bd4b915e7c14287f07c6b2f9e5565","author":{"name":"Domenic Denicola","email":"3c363836cf4e16666669a25da280a1865c2d2874@domenic.me"},"message":"Port tests to use the new API exclusively\n\nSome tests were deleted when they were very old API specific, or were sure to be covered elsewhere (e.g. in web platform tests).\n\nAlso removes the defineGetter utility.","distinct":true,"url":"https://api.github.com/repos/sarvaje/jsdom/commits/c8d471679d2bd4b915e7c14287f07c6b2f9e5565"},{"sha":"fdfbd653368f4f0e91d66151b1843ed6a65b9aa7","author":{"name":"Domenic Denicola","email":"3c363836cf4e16666669a25da280a1865c2d2874@domenic.me"},"message":"Remove the old API!\n\nThere remains cleanups we can do now that the old API is gone; those will happen in further commits.","distinct":true,"url":"https://api.github.com/repos/sarvaje/jsdom/commits/fdfbd653368f4f0e91d66151b1843ed6a65b9aa7"},{"sha":"24a76ce64075ad0c41ff64b79f16914829061c63","author":{"name":"Domenic Denicola","email":"3c363836cf4e16666669a25da280a1865c2d2874@domenic.me"},"message":"Remove \"document features\" infrastructure\n\nThis very old way of controlling resource fetching and evaluation is no longer needed.","distinct":true,"url":"https://api.github.com/repos/sarvaje/jsdom/commits/24a76ce64075ad0c41ff64b79f16914829061c63"},{"sha":"d10f062542dd08c915644a532870eb0e1231f4a1","author":{"name":"Domenic Denicola","email":"3c363836cf4e16666669a25da280a1865c2d2874@domenic.me"},"message":"Test that requests are not made for unusable resources\n\nThese tests already pass, as the logic is embedded in the <script> and <img> element implementations already; it is not a function of the resource loader.","distinct":true,"url":"https://api.github.com/repos/sarvaje/jsdom/commits/d10f062542dd08c915644a532870eb0e1231f4a1"},{"sha":"a3888ab06f69fcf664983a59364b7feb08bdff69","author":{"name":"Domenic Denicola","email":"3c363836cf4e16666669a25da280a1865c2d2874@domenic.me"},"message":"Re-do how API options are handled\n\n* Resource-loading options are set by passing them to the ResourceLoader constructor, not to the JSDOM constructor. In particular userAgent, which used to be in the JSDOM constructor in v11, moves to ResourceLoader. (The others were only added to the JSDOM constructor in recent commits.)\n* Cut down on the resource loading customizability for now. Only strictSSL, proxy, and userAgent are supported; no agent customization, since it turns out that is pretty weird and broken.\n* Make JSDOM.fromURL use the resource loader, if one is supplied.\n* Make it more explicit which options ResourceLoader.prototype.fetch and PerDocumentResourceLoader.prototype.fetch take (not many).\n* Remove some old options-passing that was only to support old API functionality.\n\nNote that for now XMLHttpRequest does not use the resource loader; it never has, but it should in the future. In the meantime we continue the janky pattern of copying over a few options into those request() calls specifically.\n\nAlso note that the keep-alive connection stuff appears to have been broken for a while (the test which was supposed to be testing that only a single connection was made, in fact tested that at least one connection was made). So, we delete those tests, as part of the reduction in flexibility mentioned above. If we reintroduce that flexiblity then we'll write better tests.","distinct":true,"url":"https://api.github.com/repos/sarvaje/jsdom/commits/a3888ab06f69fcf664983a59364b7feb08bdff69"},{"sha":"9a9629cca9a806add2c5044ae3e9587431b4a633","author":{"name":"Domenic Denicola","email":"3c363836cf4e16666669a25da280a1865c2d2874@domenic.me"},"message":"Document the new resource loader","distinct":true,"url":"https://api.github.com/repos/sarvaje/jsdom/commits/9a9629cca9a806add2c5044ae3e9587431b4a633"}]}
{"actor":{"display_login":"domenic"}}