{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/201653307","pull_request_review_id":136194772,"id":201653307,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTY1MzMwNw==","diff_hunk":"@@ -20,20 +20,7 @@\n var ExplorationEditorPage = require(\n   '../protractor_utils/ExplorationEditorPage.js');\n var until = protractor.ExpectedConditions;","path":"core/tests/protractor_utils/general.js","position":3,"original_position":3,"commit_id":"d9ec5612a221cf78484a210bb033881b79464102","original_commit_id":"d9ec5612a221cf78484a210bb033881b79464102","user":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"body":"`var until` can be removed here since it should be unused!","created_at":"2018-07-11T11:20:10Z","updated_at":"2018-07-11T11:20:10Z","html_url":"https://github.com/oppia/oppia/pull/5258#discussion_r201653307","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/5258","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/201653307"},"html":{"href":"https://github.com/oppia/oppia/pull/5258#discussion_r201653307"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5258"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5258","id":200638405,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjM4NDA1","html_url":"https://github.com/oppia/oppia/pull/5258","diff_url":"https://github.com/oppia/oppia/pull/5258.diff","patch_url":"https://github.com/oppia/oppia/pull/5258.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5258","number":5258,"state":"open","locked":false,"title":"Some initial changes to use the new waitFor utility.","user":{"login":"seanlip","id":10575562,"node_id":"MDQ6VXNlcjEwNTc1NTYy","avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"body":"Hi @hoangviet1993 -- I'm not 100% sure if tests will pass yet, so feel free to wait till they do before reviewing if you like. But I thought I'd have a go at simplifying the waitFor stuff (and doing some minor fixups as I go along).","created_at":"2018-07-11T09:27:32Z","updated_at":"2018-07-11T11:20:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4fbfc4e93773ef132d58a94554839972b3fe2b8","assignee":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"assignees":[{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/5258/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/5258/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5258/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/d9ec5612a221cf78484a210bb033881b79464102","head":{"label":"oppia:waitfor","ref":"waitfor","sha":"d9ec5612a221cf78484a210bb033881b79464102","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-07-11T08:13:11Z","pushed_at":"2018-07-11T11:13:21Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":105183,"stargazers_count":684,"watchers_count":684,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":649,"mirror_url":null,"archived":false,"open_issues_count":328,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":649,"open_issues":328,"watchers":684,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"aae4e7aa2f25a6545b030b20341b71853144d96e","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-07-11T08:13:11Z","pushed_at":"2018-07-11T11:13:21Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":105183,"stargazers_count":684,"watchers_count":684,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":649,"mirror_url":null,"archived":false,"open_issues_count":328,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":649,"open_issues":328,"watchers":684,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5258"},"html":{"href":"https://github.com/oppia/oppia/pull/5258"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/5258"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/5258/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5258/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5258/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/d9ec5612a221cf78484a210bb033881b79464102"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hoangviet1993"}}