{"action":"created","issue":{"url":"https://api.github.com/repos/mpv-player/mpv/issues/4833","repository_url":"https://api.github.com/repos/mpv-player/mpv","labels_url":"https://api.github.com/repos/mpv-player/mpv/issues/4833/labels{/name}","comments_url":"https://api.github.com/repos/mpv-player/mpv/issues/4833/comments","events_url":"https://api.github.com/repos/mpv-player/mpv/issues/4833/events","html_url":"https://github.com/mpv-player/mpv/pull/4833","id":255067575,"number":4833,"title":"macOS opengl-cb backend","user":{"login":"Akemi","id":680386,"avatar_url":"https://avatars0.githubusercontent.com/u/680386?v=4","gravatar_id":"","url":"https://api.github.com/users/Akemi","html_url":"https://github.com/Akemi","followers_url":"https://api.github.com/users/Akemi/followers","following_url":"https://api.github.com/users/Akemi/following{/other_user}","gists_url":"https://api.github.com/users/Akemi/gists{/gist_id}","starred_url":"https://api.github.com/users/Akemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akemi/subscriptions","organizations_url":"https://api.github.com/users/Akemi/orgs","repos_url":"https://api.github.com/users/Akemi/repos","events_url":"https://api.github.com/users/Akemi/events{/privacy}","received_events_url":"https://api.github.com/users/Akemi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":92,"created_at":"2017-09-04T15:07:38Z","updated_at":"2018-02-12T12:50:14Z","closed_at":"2018-02-12T12:49:17Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/4833","html_url":"https://github.com/mpv-player/mpv/pull/4833","diff_url":"https://github.com/mpv-player/mpv/pull/4833.diff","patch_url":"https://github.com/mpv-player/mpv/pull/4833.patch"},"body":"this is a WIP and attempts to fix various annoying macOS bugs and the very long standing fullscreen regression completely. it still needs testing and some fix-ups.\r\n\r\nthis will definitely fix: #5478, #5393, #5152, #5151, #4615, #4476, #3746, #3739, #2392, #2217\r\nand possibly fixes: #3978\r\n\r\nfeel free to test and report unknown bugs. for now one just needs to set `--vo=opengl-cb`, ~~though if the mpv core is too fast you might get a \"No context set.\" error.~~\r\n\r\nthere are a few things to do where i don't know how to solve them yet and i might need some help.\r\nTODO cocoa-cb:\r\n- ~~proper cocoa-cb init routine, (--no-config --vo=opengl-cb fails since no context yet)~~\r\n- ~~cocoa-cb vo option or comparable~~ (just compile time flag, uses vo=opengl-cb)\r\n- ~~doesn't draw when minimised, off screen, different space etc.~~\r\n- ~~get a hide (and unhide) event for windowless playback~~\r\n- ~~remove \"[opengl-cb] icc-profile-auto is not available with opengl-cb\" warning in an acceptable way~~\r\n- ~~change lux scale~~ (db0fb3c48b12f09170231fccd2c91687d9ce21db)\r\n- ~~remove \"Taking screenshot failed.\" warning, appears on screenshot (window), not too happy with the window screenshot code~~\r\n- ~~on shutdown wait for animations to finish~~\r\n- ~~[performance data buggy](https://github.com/mpv-player/mpv/issues/4615#issuecomment-326738862)~~\r\n- ~~ICC profile switching leads to [flicker](https://0x0.st/74V.mov) in some cases (with icc-profile-auto=no, most likely an Apple bug)~~\r\n\r\nTODO Build:\r\n- ~~flag to deactivate cocoa-cb~~\r\n- ~~dynamic developer path for static_swift~~\r\n- ~~set build target min system requirements~~\r\n\r\nthings i will fix soonish:\r\n- ~~fullscreen animation stretches video to target aspect ratio~~\r\n- ~~crashes on video stream switch to no-video (related to \"hide and unhide event for windowless\")~~\r\n- ~~implement none-native fs~~\r\n- ~~add license headers~~\r\n- ~~(deactivate the early flush on macOS)~~\r\n\r\nTODO misc:\r\n- ~~add a deprecation warning for the old opengl cocoa backend?~~"},"comment":{"url":"https://api.github.com/repos/mpv-player/mpv/issues/comments/364913576","html_url":"https://github.com/mpv-player/mpv/pull/4833#issuecomment-364913576","issue_url":"https://api.github.com/repos/mpv-player/mpv/issues/4833","id":364913576,"user":{"login":"kevmitch","id":116549,"avatar_url":"https://avatars1.githubusercontent.com/u/116549?v=4","gravatar_id":"","url":"https://api.github.com/users/kevmitch","html_url":"https://github.com/kevmitch","followers_url":"https://api.github.com/users/kevmitch/followers","following_url":"https://api.github.com/users/kevmitch/following{/other_user}","gists_url":"https://api.github.com/users/kevmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/kevmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevmitch/subscriptions","organizations_url":"https://api.github.com/users/kevmitch/orgs","repos_url":"https://api.github.com/users/kevmitch/repos","events_url":"https://api.github.com/users/kevmitch/events{/privacy}","received_events_url":"https://api.github.com/users/kevmitch/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T12:50:14Z","updated_at":"2018-02-12T12:50:14Z","author_association":"MEMBER","body":"If ever this emoji was justified."}}
{"actor":{"display_login":"kevmitch"}}