{"action":"created","comment":{"url":"https://api.github.com/repos/tableau/server-client-python/pulls/comments/199655605","pull_request_review_id":133816950,"id":199655605,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTY1NTYwNQ==","diff_hunk":"@@ -190,6 +194,12 @@ def publish(self, datasource_item, file_path, mode, connection_credentials=None)\n                                                                               file_contents,\n                                                                               connection_credentials)\n         server_response = self.post_request(url, xml_request, content_type)\n-        new_datasource = DatasourceItem.from_response(server_response.content, self.parent_srv.namespace)[0]\n-        logger.info('Published {0} (ID: {1})'.format(filename, new_datasource.id))\n-        return new_datasource\n+\n+        if as_job:","path":"tableauserverclient/server/endpoint/datasources_endpoint.py","position":28,"original_position":28,"commit_id":"1fcdc12f045876333faa21c24347e975926f80f2","original_commit_id":"1fcdc12f045876333faa21c24347e975926f80f2","user":{"login":"t8y8","id":4370533,"node_id":"MDQ6VXNlcjQzNzA1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/4370533?v=4","gravatar_id":"","url":"https://api.github.com/users/t8y8","html_url":"https://github.com/t8y8","followers_url":"https://api.github.com/users/t8y8/followers","following_url":"https://api.github.com/users/t8y8/following{/other_user}","gists_url":"https://api.github.com/users/t8y8/gists{/gist_id}","starred_url":"https://api.github.com/users/t8y8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t8y8/subscriptions","organizations_url":"https://api.github.com/users/t8y8/orgs","repos_url":"https://api.github.com/users/t8y8/repos","events_url":"https://api.github.com/users/t8y8/events{/privacy}","received_events_url":"https://api.github.com/users/t8y8/received_events","type":"User","site_admin":false},"body":"This can come as a second PR but it'd be great if we actually tracked the progress of the job, or at least optionally tracked the progress of the job, and printed or reported it somehow.","created_at":"2018-07-03T00:26:32Z","updated_at":"2018-07-03T00:35:36Z","html_url":"https://github.com/tableau/server-client-python/pull/311#discussion_r199655605","pull_request_url":"https://api.github.com/repos/tableau/server-client-python/pulls/311","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/comments/199655605"},"html":{"href":"https://github.com/tableau/server-client-python/pull/311#discussion_r199655605"},"pull_request":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/311"}}},"pull_request":{"url":"https://api.github.com/repos/tableau/server-client-python/pulls/311","id":198452874,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDUyODc0","html_url":"https://github.com/tableau/server-client-python/pull/311","diff_url":"https://github.com/tableau/server-client-python/pull/311.diff","patch_url":"https://github.com/tableau/server-client-python/pull/311.patch","issue_url":"https://api.github.com/repos/tableau/server-client-python/issues/311","number":311,"state":"open","locked":false,"title":"Added support for asynchronous publishing on workbook and datasource endpoints","user":{"login":"gaoang2148","id":1755965,"node_id":"MDQ6VXNlcjE3NTU5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1755965?v=4","gravatar_id":"","url":"https://api.github.com/users/gaoang2148","html_url":"https://github.com/gaoang2148","followers_url":"https://api.github.com/users/gaoang2148/followers","following_url":"https://api.github.com/users/gaoang2148/following{/other_user}","gists_url":"https://api.github.com/users/gaoang2148/gists{/gist_id}","starred_url":"https://api.github.com/users/gaoang2148/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaoang2148/subscriptions","organizations_url":"https://api.github.com/users/gaoang2148/orgs","repos_url":"https://api.github.com/users/gaoang2148/repos","events_url":"https://api.github.com/users/gaoang2148/events{/privacy}","received_events_url":"https://api.github.com/users/gaoang2148/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-30T01:23:20Z","updated_at":"2018-07-03T00:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e87c3e91eb364212b22ffe7d4dd44678c4454453","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shinchris","id":10054801,"node_id":"MDQ6VXNlcjEwMDU0ODAx","avatar_url":"https://avatars1.githubusercontent.com/u/10054801?v=4","gravatar_id":"","url":"https://api.github.com/users/shinchris","html_url":"https://github.com/shinchris","followers_url":"https://api.github.com/users/shinchris/followers","following_url":"https://api.github.com/users/shinchris/following{/other_user}","gists_url":"https://api.github.com/users/shinchris/gists{/gist_id}","starred_url":"https://api.github.com/users/shinchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinchris/subscriptions","organizations_url":"https://api.github.com/users/shinchris/orgs","repos_url":"https://api.github.com/users/shinchris/repos","events_url":"https://api.github.com/users/shinchris/events{/privacy}","received_events_url":"https://api.github.com/users/shinchris/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tableau/server-client-python/pulls/311/commits","review_comments_url":"https://api.github.com/repos/tableau/server-client-python/pulls/311/comments","review_comment_url":"https://api.github.com/repos/tableau/server-client-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tableau/server-client-python/issues/311/comments","statuses_url":"https://api.github.com/repos/tableau/server-client-python/statuses/1fcdc12f045876333faa21c24347e975926f80f2","head":{"label":"tableau:async-publishing","ref":"async-publishing","sha":"1fcdc12f045876333faa21c24347e975926f80f2","user":{"login":"tableau","id":828667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODY2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/828667?v=4","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"repo":{"id":62177327,"node_id":"MDEwOlJlcG9zaXRvcnk2MjE3NzMyNw==","name":"server-client-python","full_name":"tableau/server-client-python","owner":{"login":"tableau","id":828667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODY2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/828667?v=4","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tableau/server-client-python","description":"A Python library for the Tableau Server REST API","fork":false,"url":"https://api.github.com/repos/tableau/server-client-python","forks_url":"https://api.github.com/repos/tableau/server-client-python/forks","keys_url":"https://api.github.com/repos/tableau/server-client-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tableau/server-client-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tableau/server-client-python/teams","hooks_url":"https://api.github.com/repos/tableau/server-client-python/hooks","issue_events_url":"https://api.github.com/repos/tableau/server-client-python/issues/events{/number}","events_url":"https://api.github.com/repos/tableau/server-client-python/events","assignees_url":"https://api.github.com/repos/tableau/server-client-python/assignees{/user}","branches_url":"https://api.github.com/repos/tableau/server-client-python/branches{/branch}","tags_url":"https://api.github.com/repos/tableau/server-client-python/tags","blobs_url":"https://api.github.com/repos/tableau/server-client-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tableau/server-client-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tableau/server-client-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/tableau/server-client-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tableau/server-client-python/statuses/{sha}","languages_url":"https://api.github.com/repos/tableau/server-client-python/languages","stargazers_url":"https://api.github.com/repos/tableau/server-client-python/stargazers","contributors_url":"https://api.github.com/repos/tableau/server-client-python/contributors","subscribers_url":"https://api.github.com/repos/tableau/server-client-python/subscribers","subscription_url":"https://api.github.com/repos/tableau/server-client-python/subscription","commits_url":"https://api.github.com/repos/tableau/server-client-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/tableau/server-client-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/tableau/server-client-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/tableau/server-client-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/tableau/server-client-python/contents/{+path}","compare_url":"https://api.github.com/repos/tableau/server-client-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tableau/server-client-python/merges","archive_url":"https://api.github.com/repos/tableau/server-client-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tableau/server-client-python/downloads","issues_url":"https://api.github.com/repos/tableau/server-client-python/issues{/number}","pulls_url":"https://api.github.com/repos/tableau/server-client-python/pulls{/number}","milestones_url":"https://api.github.com/repos/tableau/server-client-python/milestones{/number}","notifications_url":"https://api.github.com/repos/tableau/server-client-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tableau/server-client-python/labels{/name}","releases_url":"https://api.github.com/repos/tableau/server-client-python/releases{/id}","deployments_url":"https://api.github.com/repos/tableau/server-client-python/deployments","created_at":"2016-06-28T22:05:32Z","updated_at":"2018-06-28T16:47:56Z","pushed_at":"2018-07-02T16:17:56Z","git_url":"git://github.com/tableau/server-client-python.git","ssh_url":"git@github.com:tableau/server-client-python.git","clone_url":"https://github.com/tableau/server-client-python.git","svn_url":"https://github.com/tableau/server-client-python","homepage":"https://tableau.github.io/server-client-python","size":981,"stargazers_count":115,"watchers_count":115,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":81,"open_issues":52,"watchers":115,"default_branch":"master"}},"base":{"label":"tableau:master","ref":"master","sha":"3fe62c98a8ff866d93a1cacb564c43280274a5c8","user":{"login":"tableau","id":828667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODY2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/828667?v=4","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"repo":{"id":62177327,"node_id":"MDEwOlJlcG9zaXRvcnk2MjE3NzMyNw==","name":"server-client-python","full_name":"tableau/server-client-python","owner":{"login":"tableau","id":828667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODY2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/828667?v=4","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tableau/server-client-python","description":"A Python library for the Tableau Server REST API","fork":false,"url":"https://api.github.com/repos/tableau/server-client-python","forks_url":"https://api.github.com/repos/tableau/server-client-python/forks","keys_url":"https://api.github.com/repos/tableau/server-client-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tableau/server-client-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tableau/server-client-python/teams","hooks_url":"https://api.github.com/repos/tableau/server-client-python/hooks","issue_events_url":"https://api.github.com/repos/tableau/server-client-python/issues/events{/number}","events_url":"https://api.github.com/repos/tableau/server-client-python/events","assignees_url":"https://api.github.com/repos/tableau/server-client-python/assignees{/user}","branches_url":"https://api.github.com/repos/tableau/server-client-python/branches{/branch}","tags_url":"https://api.github.com/repos/tableau/server-client-python/tags","blobs_url":"https://api.github.com/repos/tableau/server-client-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tableau/server-client-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tableau/server-client-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/tableau/server-client-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tableau/server-client-python/statuses/{sha}","languages_url":"https://api.github.com/repos/tableau/server-client-python/languages","stargazers_url":"https://api.github.com/repos/tableau/server-client-python/stargazers","contributors_url":"https://api.github.com/repos/tableau/server-client-python/contributors","subscribers_url":"https://api.github.com/repos/tableau/server-client-python/subscribers","subscription_url":"https://api.github.com/repos/tableau/server-client-python/subscription","commits_url":"https://api.github.com/repos/tableau/server-client-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/tableau/server-client-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/tableau/server-client-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/tableau/server-client-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/tableau/server-client-python/contents/{+path}","compare_url":"https://api.github.com/repos/tableau/server-client-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tableau/server-client-python/merges","archive_url":"https://api.github.com/repos/tableau/server-client-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tableau/server-client-python/downloads","issues_url":"https://api.github.com/repos/tableau/server-client-python/issues{/number}","pulls_url":"https://api.github.com/repos/tableau/server-client-python/pulls{/number}","milestones_url":"https://api.github.com/repos/tableau/server-client-python/milestones{/number}","notifications_url":"https://api.github.com/repos/tableau/server-client-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tableau/server-client-python/labels{/name}","releases_url":"https://api.github.com/repos/tableau/server-client-python/releases{/id}","deployments_url":"https://api.github.com/repos/tableau/server-client-python/deployments","created_at":"2016-06-28T22:05:32Z","updated_at":"2018-06-28T16:47:56Z","pushed_at":"2018-07-02T16:17:56Z","git_url":"git://github.com/tableau/server-client-python.git","ssh_url":"git@github.com:tableau/server-client-python.git","clone_url":"https://github.com/tableau/server-client-python.git","svn_url":"https://github.com/tableau/server-client-python","homepage":"https://tableau.github.io/server-client-python","size":981,"stargazers_count":115,"watchers_count":115,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":81,"open_issues":52,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/311"},"html":{"href":"https://github.com/tableau/server-client-python/pull/311"},"issue":{"href":"https://api.github.com/repos/tableau/server-client-python/issues/311"},"comments":{"href":"https://api.github.com/repos/tableau/server-client-python/issues/311/comments"},"review_comments":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/311/comments"},"review_comment":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/311/commits"},"statuses":{"href":"https://api.github.com/repos/tableau/server-client-python/statuses/1fcdc12f045876333faa21c24347e975926f80f2"}},"author_association":"NONE"}}
{"actor":{"display_login":"t8y8"}}