{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/171190863","pull_request_review_id":99998703,"id":171190863,"diff_hunk":"@@ -0,0 +1,60 @@\n+=pod\n+\n+=head1 NAME\n+\n+SSL_CTX_set_tls_cookie_generate_cb,\n+SSL_CTX_set_tls_cookie_verify_cb\n+- Callback functions for stateless TLS1.3 cookies\n+\n+=head1 SYNOPSIS\n+\n+ #include <openssl/ssl.h>\n+\n+ void SSL_CTX_set_tls_cookie_generate_cb(SSL_CTX *ctx,\n+                                         int (*gen_tls_cookie_cb) (SSL *ssl,\n+                                                                   unsigned char\n+                                                                   *cookie,\n+                                                                   unsigned int\n+                                                                   *cookie_len));\n+ void SSL_CTX_set_tls_cookie_verify_cb(SSL_CTX *ctx,\n+                                       int (*verify_tls_cookie_cb) (SSL *ssl,\n+                                                                    const unsigned char\n+                                                                    *cookie,\n+                                                                    unsigned int\n+                                                                    cookie_len));\n+\n+=head1 DESCRIPTION\n+\n+SSL_CTX_set_cookie_generate_cb() sets the callback used by L<SSL_stateless(3)>\n+to generate the application-controlled portion of the cookie provided to clients\n+in the HelloRetryRequest transmitted as a response to a ClientHello with a\n+missing or invalid cookie. gen_tls_cookie_cb() must write at most\n+SSL_COOKIE_LENGTH bytes into B<cookie>, and must write the number of bytes\n+written to B<cookie_len>. If a cookie cannot be generated, a zero return value\n+can be used to abort the handshake.\n+\n+SSL_CTX_set_cookie_verify_cb() sets the callback used by L<SSL_stateless(3)> to\n+determine whether the application-controlled portion of a ClientHello cookie is\n+valid. A nonzero return value from app_verify_cookie_cb() communicates that the\n+cookie is valid. The integrity of the entire cookie, including the\n+application-controlled portion, is automatically verified using a HMAC before","path":"doc/man3/SSL_CTX_set_tls_cookie_generate_cb.pod","position":40,"original_position":40,"commit_id":"1ed8928b143306537e9239e718cd372395ca67f4","original_commit_id":"6aed55776fbfe2633207078b7ff2a17179ef9795","user":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars0.githubusercontent.com/u/7422273?v=4","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"body":"Well I would argue that you are using HMAC here to refer to the name of an algorithm, not a specific (singular) code that that algorithm generates. But I don't care enough about this to hold up the review, so I'll approve this PR.","created_at":"2018-02-28T09:52:16Z","updated_at":"2018-02-28T09:52:36Z","html_url":"https://github.com/openssl/openssl/pull/5463#discussion_r171190863","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/5463","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/171190863"},"html":{"href":"https://github.com/openssl/openssl/pull/5463#discussion_r171190863"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/5463"}},"in_reply_to_id":170864038},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/5463","id":171272445,"html_url":"https://github.com/openssl/openssl/pull/5463","diff_url":"https://github.com/openssl/openssl/pull/5463.diff","patch_url":"https://github.com/openssl/openssl/pull/5463.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/5463","number":5463,"state":"open","locked":false,"title":"Introduce SSL_CTX_set_tls_cookie_{generate,verify}_cb","user":{"login":"Ralith","id":104558,"avatar_url":"https://avatars2.githubusercontent.com/u/104558?v=4","gravatar_id":"","url":"https://api.github.com/users/Ralith","html_url":"https://github.com/Ralith","followers_url":"https://api.github.com/users/Ralith/followers","following_url":"https://api.github.com/users/Ralith/following{/other_user}","gists_url":"https://api.github.com/users/Ralith/gists{/gist_id}","starred_url":"https://api.github.com/users/Ralith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ralith/subscriptions","organizations_url":"https://api.github.com/users/Ralith/orgs","repos_url":"https://api.github.com/users/Ralith/repos","events_url":"https://api.github.com/users/Ralith/events{/privacy}","received_events_url":"https://api.github.com/users/Ralith/received_events","type":"User","site_admin":false},"body":"This documents the current semantics of the application cookie generate/verify callbacks used for TLS1.3 and DTLS stateless handshakes. Please review carefully for style, as I haven't done this before.\r\n\r\nCC @mattcaswell\r\n","created_at":"2018-02-26T02:58:20Z","updated_at":"2018-02-28T09:52:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1626a7115ba1d3fb3e6ff58f80504148bcac1a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/5463/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/5463/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/5463/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/1ed8928b143306537e9239e718cd372395ca67f4","head":{"label":"Ralith:cookie-cb-docs","ref":"cookie-cb-docs","sha":"1ed8928b143306537e9239e718cd372395ca67f4","user":{"login":"Ralith","id":104558,"avatar_url":"https://avatars2.githubusercontent.com/u/104558?v=4","gravatar_id":"","url":"https://api.github.com/users/Ralith","html_url":"https://github.com/Ralith","followers_url":"https://api.github.com/users/Ralith/followers","following_url":"https://api.github.com/users/Ralith/following{/other_user}","gists_url":"https://api.github.com/users/Ralith/gists{/gist_id}","starred_url":"https://api.github.com/users/Ralith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ralith/subscriptions","organizations_url":"https://api.github.com/users/Ralith/orgs","repos_url":"https://api.github.com/users/Ralith/repos","events_url":"https://api.github.com/users/Ralith/events{/privacy}","received_events_url":"https://api.github.com/users/Ralith/received_events","type":"User","site_admin":false},"repo":{"id":121057278,"name":"openssl","full_name":"Ralith/openssl","owner":{"login":"Ralith","id":104558,"avatar_url":"https://avatars2.githubusercontent.com/u/104558?v=4","gravatar_id":"","url":"https://api.github.com/users/Ralith","html_url":"https://github.com/Ralith","followers_url":"https://api.github.com/users/Ralith/followers","following_url":"https://api.github.com/users/Ralith/following{/other_user}","gists_url":"https://api.github.com/users/Ralith/gists{/gist_id}","starred_url":"https://api.github.com/users/Ralith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ralith/subscriptions","organizations_url":"https://api.github.com/users/Ralith/orgs","repos_url":"https://api.github.com/users/Ralith/repos","events_url":"https://api.github.com/users/Ralith/events{/privacy}","received_events_url":"https://api.github.com/users/Ralith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ralith/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/Ralith/openssl","forks_url":"https://api.github.com/repos/Ralith/openssl/forks","keys_url":"https://api.github.com/repos/Ralith/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ralith/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ralith/openssl/teams","hooks_url":"https://api.github.com/repos/Ralith/openssl/hooks","issue_events_url":"https://api.github.com/repos/Ralith/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/Ralith/openssl/events","assignees_url":"https://api.github.com/repos/Ralith/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/Ralith/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/Ralith/openssl/tags","blobs_url":"https://api.github.com/repos/Ralith/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ralith/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ralith/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ralith/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ralith/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/Ralith/openssl/languages","stargazers_url":"https://api.github.com/repos/Ralith/openssl/stargazers","contributors_url":"https://api.github.com/repos/Ralith/openssl/contributors","subscribers_url":"https://api.github.com/repos/Ralith/openssl/subscribers","subscription_url":"https://api.github.com/repos/Ralith/openssl/subscription","commits_url":"https://api.github.com/repos/Ralith/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ralith/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ralith/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ralith/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ralith/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/Ralith/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ralith/openssl/merges","archive_url":"https://api.github.com/repos/Ralith/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ralith/openssl/downloads","issues_url":"https://api.github.com/repos/Ralith/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/Ralith/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/Ralith/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/Ralith/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ralith/openssl/labels{/name}","releases_url":"https://api.github.com/repos/Ralith/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/Ralith/openssl/deployments","created_at":"2018-02-10T21:47:45Z","updated_at":"2018-02-10T21:48:05Z","pushed_at":"2018-02-28T03:07:52Z","git_url":"git://github.com/Ralith/openssl.git","ssh_url":"git@github.com:Ralith/openssl.git","clone_url":"https://github.com/Ralith/openssl.git","svn_url":"https://github.com/Ralith/openssl","homepage":"https://www.openssl.org","size":140764,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"8a5d8bc4bc1e835b62d988ad63454540be83d862","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-02-28T09:05:46Z","pushed_at":"2018-02-28T06:58:56Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":141028,"stargazers_count":6467,"watchers_count":6467,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3210,"mirror_url":null,"archived":false,"open_issues_count":432,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3210,"open_issues":432,"watchers":6467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/5463"},"html":{"href":"https://github.com/openssl/openssl/pull/5463"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/5463"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/5463/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/5463/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/5463/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/1ed8928b143306537e9239e718cd372395ca67f4"}},"author_association":"NONE"}}
{"actor":{"display_login":"mattcaswell"}}