{"action":"created","issue":{"url":"https://api.github.com/repos/getredash/redash/issues/2949","repository_url":"https://api.github.com/repos/getredash/redash","labels_url":"https://api.github.com/repos/getredash/redash/issues/2949/labels{/name}","comments_url":"https://api.github.com/repos/getredash/redash/issues/2949/comments","events_url":"https://api.github.com/repos/getredash/redash/issues/2949/events","html_url":"https://github.com/getredash/redash/pull/2949","id":369964937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzU3NDMy","number":2949,"title":"Port toggle to hide tables configurable substring (e.g. versioned tables)","user":{"login":"alison985","id":1840865,"node_id":"MDQ6VXNlcjE4NDA4NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1840865?v=4","gravatar_id":"","url":"https://api.github.com/users/alison985","html_url":"https://github.com/alison985","followers_url":"https://api.github.com/users/alison985/followers","following_url":"https://api.github.com/users/alison985/following{/other_user}","gists_url":"https://api.github.com/users/alison985/gists{/gist_id}","starred_url":"https://api.github.com/users/alison985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alison985/subscriptions","organizations_url":"https://api.github.com/users/alison985/orgs","repos_url":"https://api.github.com/users/alison985/repos","events_url":"https://api.github.com/users/alison985/events{/privacy}","received_events_url":"https://api.github.com/users/alison985/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-15T01:09:12Z","updated_at":"2018-10-15T16:45:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/getredash/redash/pulls/2949","html_url":"https://github.com/getredash/redash/pull/2949","diff_url":"https://github.com/getredash/redash/pull/2949.diff","patch_url":"https://github.com/getredash/redash/pull/2949.patch"},"body":"This ports Mozilla [Issue 31](https://github.com/mozilla/redash/issues/31) and [Issue 130](https://github.com/mozilla/redash/issues/130) as requested in Mozilla [Issue 584](https://github.com/mozilla/redash/issues/584).\r\n\r\nHere's what the toggle button looks like in the schema browser (if one is specified in the data source config).\r\n![screenshot 2018-10-14 20 04 50](https://user-images.githubusercontent.com/1840865/46924699-e241e180-cfec-11e8-8714-5a1f14e3252d.png)\r\nAnd toggled on:\r\n![screenshot 2018-10-14 20 04 56](https://user-images.githubusercontent.com/1840865/46924706-e837c280-cfec-11e8-8e4a-949e0c9a358f.png)\r\nAnd the taggle string input on a datasource config page:\r\n![screenshot 2018-10-14 20 05 02](https://user-images.githubusercontent.com/1840865/46924718-f4bc1b00-cfec-11e8-8637-83611eb6e3de.png)\r\n"},"comment":{"url":"https://api.github.com/repos/getredash/redash/issues/comments/429927951","html_url":"https://github.com/getredash/redash/pull/2949#issuecomment-429927951","issue_url":"https://api.github.com/repos/getredash/redash/issues/2949","id":429927951,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTkyNzk1MQ==","user":{"login":"kocsmy","id":2378022,"node_id":"MDQ6VXNlcjIzNzgwMjI=","avatar_url":"https://avatars2.githubusercontent.com/u/2378022?v=4","gravatar_id":"","url":"https://api.github.com/users/kocsmy","html_url":"https://github.com/kocsmy","followers_url":"https://api.github.com/users/kocsmy/followers","following_url":"https://api.github.com/users/kocsmy/following{/other_user}","gists_url":"https://api.github.com/users/kocsmy/gists{/gist_id}","starred_url":"https://api.github.com/users/kocsmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocsmy/subscriptions","organizations_url":"https://api.github.com/users/kocsmy/orgs","repos_url":"https://api.github.com/users/kocsmy/repos","events_url":"https://api.github.com/users/kocsmy/events{/privacy}","received_events_url":"https://api.github.com/users/kocsmy/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T16:45:12Z","updated_at":"2018-10-15T16:45:12Z","author_association":"COLLABORATOR","body":"Thanks for the PR, @alison985 if you don't mind, I want to add some comments:\r\n- I know this is the result of bad switch icon design but we have 2 exactly same looking button with very different functionality (single button vs toggle button).\r\n- The icon itself does not imply what is this for. Is this really the best place to put this icon? Can we maybe put it somewhere else? Maybe add this as an option for the data source? \r\n- (There's a missing 5px margin between the 2 icons)"}}
{"actor":{"display_login":"kocsmy"}}