{"action":"created","comment":{"url":"https://api.github.com/repos/newsuk/times-components/pulls/comments/213619700","pull_request_review_id":150491626,"id":213619700,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzYxOTcwMA==","diff_hunk":"@@ -0,0 +1,55 @@\n+/* eslint-disable no-console */\n+\n+const { introspectionQuery } = require(\"graphql\");","path":"packages/schema/fetch-gql-schema.js","position":3,"original_position":3,"commit_id":"5fccd4c6f56fd5dfc47faa6cd7bf9cbd239753bf","original_commit_id":"5fccd4c6f56fd5dfc47faa6cd7bf9cbd239753bf","user":{"login":"colincclark","id":5456015,"node_id":"MDQ6VXNlcjU0NTYwMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5456015?v=4","gravatar_id":"","url":"https://api.github.com/users/colincclark","html_url":"https://github.com/colincclark","followers_url":"https://api.github.com/users/colincclark/followers","following_url":"https://api.github.com/users/colincclark/following{/other_user}","gists_url":"https://api.github.com/users/colincclark/gists{/gist_id}","starred_url":"https://api.github.com/users/colincclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colincclark/subscriptions","organizations_url":"https://api.github.com/users/colincclark/orgs","repos_url":"https://api.github.com/users/colincclark/repos","events_url":"https://api.github.com/users/colincclark/events{/privacy}","received_events_url":"https://api.github.com/users/colincclark/received_events","type":"User","site_admin":false},"body":"I think this package deserves to have some tests","created_at":"2018-08-29T10:10:25Z","updated_at":"2018-08-29T10:16:05Z","html_url":"https://github.com/newsuk/times-components/pull/1273#discussion_r213619700","pull_request_url":"https://api.github.com/repos/newsuk/times-components/pulls/1273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/comments/213619700"},"html":{"href":"https://github.com/newsuk/times-components/pull/1273#discussion_r213619700"},"pull_request":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1273"}}},"pull_request":{"url":"https://api.github.com/repos/newsuk/times-components/pulls/1273","id":211503506,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTAzNTA2","html_url":"https://github.com/newsuk/times-components/pull/1273","diff_url":"https://github.com/newsuk/times-components/pull/1273.diff","patch_url":"https://github.com/newsuk/times-components/pull/1273.patch","issue_url":"https://api.github.com/repos/newsuk/times-components/issues/1273","number":1273,"state":"open","locked":false,"title":"feat: add ssr package","user":{"login":"craigbilner","id":12942968,"node_id":"MDQ6VXNlcjEyOTQyOTY4","avatar_url":"https://avatars2.githubusercontent.com/u/12942968?v=4","gravatar_id":"","url":"https://api.github.com/users/craigbilner","html_url":"https://github.com/craigbilner","followers_url":"https://api.github.com/users/craigbilner/followers","following_url":"https://api.github.com/users/craigbilner/following{/other_user}","gists_url":"https://api.github.com/users/craigbilner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigbilner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigbilner/subscriptions","organizations_url":"https://api.github.com/users/craigbilner/orgs","repos_url":"https://api.github.com/users/craigbilner/repos","events_url":"https://api.github.com/users/craigbilner/events{/privacy}","received_events_url":"https://api.github.com/users/craigbilner/received_events","type":"User","site_admin":false},"body":"* feat: made schema and fragment-matcher \"live\" to pick up on bad queries sooner. This will be even more important when the mocking PR drops to also fail tests and stories. This might be a bit disruptive (or hugely beneficial?) so might have to see \"how it goes\"\r\n\r\n* feat: add SSR package. Not published, dev only feature to test our SSR. Also provides example code for a basic SSR implementation of the components and client-side bundling. Could be shared/published in the future for use by render/others.\r\n\r\n* refactor: move schema and fragment matcher into their own package for maintainability and to optimise the bundle. We're currently shipping the whole of the `schema.json` in our client bundle but don't need it.\r\n\r\n* refactor: move the timers to `test-utils` which didn't exist when they were created\r\n\r\n* chore: upgrade `node-fetch`\r\n\r\n* chore: eslint needs to treat `webpack` as a dev dep\r\n\r\n* chore: add missing `webpack-configurator` dep","created_at":"2018-08-28T17:43:05Z","updated_at":"2018-08-29T10:16:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4937d58bc2ad1f340cf85c33c5aa0a3ae4b1871f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/newsuk/times-components/pulls/1273/commits","review_comments_url":"https://api.github.com/repos/newsuk/times-components/pulls/1273/comments","review_comment_url":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/newsuk/times-components/issues/1273/comments","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/5fccd4c6f56fd5dfc47faa6cd7bf9cbd239753bf","head":{"label":"newsuk:feat/add-ssr","ref":"feat/add-ssr","sha":"5fccd4c6f56fd5dfc47faa6cd7bf9cbd239753bf","user":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE1MTExMA==","name":"times-components","full_name":"newsuk/times-components","owner":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2018-08-29T09:30:26Z","pushed_at":"2018-08-29T09:59:36Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"http://components.thetimes.co.uk","size":58608,"stargazers_count":98,"watchers_count":98,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":14,"open_issues":33,"watchers":98,"default_branch":"master"}},"base":{"label":"newsuk:master","ref":"master","sha":"2ec4e763b6b547067e17bc1681b6f8f283807c73","user":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE1MTExMA==","name":"times-components","full_name":"newsuk/times-components","owner":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2018-08-29T09:30:26Z","pushed_at":"2018-08-29T09:59:36Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"http://components.thetimes.co.uk","size":58608,"stargazers_count":98,"watchers_count":98,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":14,"open_issues":33,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1273"},"html":{"href":"https://github.com/newsuk/times-components/pull/1273"},"issue":{"href":"https://api.github.com/repos/newsuk/times-components/issues/1273"},"comments":{"href":"https://api.github.com/repos/newsuk/times-components/issues/1273/comments"},"review_comments":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1273/comments"},"review_comment":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1273/commits"},"statuses":{"href":"https://api.github.com/repos/newsuk/times-components/statuses/5fccd4c6f56fd5dfc47faa6cd7bf9cbd239753bf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"colincclark"}}