{"action":"created","comment":{"url":"https://api.github.com/repos/linux-system-roles/logging/pulls/comments/229899559","pull_request_review_id":170510142,"id":229899559,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTg5OTU1OQ==","diff_hunk":"@@ -1,41 +1,47 @@\n ---\n-- name: Install/Update required packages\n+- name: Install/Update required basic packages\n   yum:\n-    name: '{{ item }}'\n+    name: '{{rsyslog_base_packages|flatten + rsyslog_packages|flatten}}'\n     state: 'latest'\n-  with_flattened:\n-    - '{{ rsyslog__base_packages }}'\n-    - '{{ rsyslog__viaq_prereq_packages if rsyslog__viaq|bool else [] }}'\n-    - '{{ rsyslog__viaq_packages if rsyslog__viaq|bool else [] }}'\n-    - '{{ rsyslog__tls_packages if rsyslog__pki|bool else [] }}'\n-    - '{{ rsyslog__packages }}'\n-  when: rsyslog__enabled|bool and not use_rsyslog_image|default(False)|bool\n+  when: rsyslog_enabled|bool and not use_rsyslog_image|default(False)|bool\n+\n+- name: Install/Update required pki packages\n+  yum:\n+    name: '{{rsyslog_tls_packages|flatten}}'\n+    state: 'latest'\n+  when: rsyslog_enabled|bool and rsyslog_pki|bool and not use_rsyslog_image|default(False)|bool\n+\n+- name: Install/Update required viaq packages\n+  yum:\n+    name: '{{rsyslog_viaq_prereq_packages|flatten + rsyslog_viaq_packages|flatten}}'\n+    state: 'latest'\n+  when: rsyslog_enabled|bool and rsyslog_viaq|bool and not use_rsyslog_image|default(False)|bool","path":"roles/rsyslog/tasks/main.yaml","position":27,"original_position":27,"commit_id":"23073fce2606b54270e7e9041d9c7e74e82fa97a","original_commit_id":"23073fce2606b54270e7e9041d9c7e74e82fa97a","user":{"login":"nhosoi","id":938485,"node_id":"MDQ6VXNlcjkzODQ4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/938485?v=4","gravatar_id":"","url":"https://api.github.com/users/nhosoi","html_url":"https://github.com/nhosoi","followers_url":"https://api.github.com/users/nhosoi/followers","following_url":"https://api.github.com/users/nhosoi/following{/other_user}","gists_url":"https://api.github.com/users/nhosoi/gists{/gist_id}","starred_url":"https://api.github.com/users/nhosoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhosoi/subscriptions","organizations_url":"https://api.github.com/users/nhosoi/orgs","repos_url":"https://api.github.com/users/nhosoi/repos","events_url":"https://api.github.com/users/nhosoi/events{/privacy}","received_events_url":"https://api.github.com/users/nhosoi/received_events","type":"User","site_admin":false},"body":"@sradco , I could not replace it with one task as you suggested (conditions with \"rsyslog_viaq|bool\" and \"rsyslog_pki|bool\" are not allowed in {{ ... }}.   Hope this is acceptable...","created_at":"2018-10-31T23:22:01Z","updated_at":"2018-10-31T23:22:01Z","html_url":"https://github.com/linux-system-roles/logging/pull/20#discussion_r229899559","pull_request_url":"https://api.github.com/repos/linux-system-roles/logging/pulls/20","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/linux-system-roles/logging/pulls/comments/229899559"},"html":{"href":"https://github.com/linux-system-roles/logging/pull/20#discussion_r229899559"},"pull_request":{"href":"https://api.github.com/repos/linux-system-roles/logging/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/linux-system-roles/logging/pulls/20","id":226791281,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzkxMjgx","html_url":"https://github.com/linux-system-roles/logging/pull/20","diff_url":"https://github.com/linux-system-roles/logging/pull/20.diff","patch_url":"https://github.com/linux-system-roles/logging/pull/20.patch","issue_url":"https://api.github.com/repos/linux-system-roles/logging/issues/20","number":20,"state":"open","locked":false,"title":"Updating the rsyslog roles based on the reviews by @sradco","user":{"login":"nhosoi","id":938485,"node_id":"MDQ6VXNlcjkzODQ4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/938485?v=4","gravatar_id":"","url":"https://api.github.com/users/nhosoi","html_url":"https://github.com/nhosoi","followers_url":"https://api.github.com/users/nhosoi/followers","following_url":"https://api.github.com/users/nhosoi/following{/other_user}","gists_url":"https://api.github.com/users/nhosoi/gists{/gist_id}","starred_url":"https://api.github.com/users/nhosoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhosoi/subscriptions","organizations_url":"https://api.github.com/users/nhosoi/orgs","repos_url":"https://api.github.com/users/nhosoi/repos","events_url":"https://api.github.com/users/nhosoi/events{/privacy}","received_events_url":"https://api.github.com/users/nhosoi/received_events","type":"User","site_admin":false},"body":"1. Fixing \"DEPRECATION WARNING\" from the TASK \"Install/Update required packages\"\r\n    Avoid using loop, devide each package array and assign it to its own task.\r\n    (Unfortunately, it made the code uglier...)\r\n\r\n2. Defining rsyslog_purge_original_conf to manage pre-existing config files to keep or purge.\r\n\r\n3. Adding 'libselinux-python' to rsyslog_base_packages to avoid the installation\r\n    failure due to the missing package.  \r\n    (Not sure this is the right package to be in the list.)\r\n\r\n4. Replacing rsyslog__ with rsyslog_","created_at":"2018-10-30T04:50:05Z","updated_at":"2018-10-31T23:22:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d065047924e4e4e3cae5b42ba292130f07d1339","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linux-system-roles/logging/pulls/20/commits","review_comments_url":"https://api.github.com/repos/linux-system-roles/logging/pulls/20/comments","review_comment_url":"https://api.github.com/repos/linux-system-roles/logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linux-system-roles/logging/issues/20/comments","statuses_url":"https://api.github.com/repos/linux-system-roles/logging/statuses/23073fce2606b54270e7e9041d9c7e74e82fa97a","head":{"label":"nhosoi:working","ref":"working","sha":"23073fce2606b54270e7e9041d9c7e74e82fa97a","user":{"login":"nhosoi","id":938485,"node_id":"MDQ6VXNlcjkzODQ4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/938485?v=4","gravatar_id":"","url":"https://api.github.com/users/nhosoi","html_url":"https://github.com/nhosoi","followers_url":"https://api.github.com/users/nhosoi/followers","following_url":"https://api.github.com/users/nhosoi/following{/other_user}","gists_url":"https://api.github.com/users/nhosoi/gists{/gist_id}","starred_url":"https://api.github.com/users/nhosoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhosoi/subscriptions","organizations_url":"https://api.github.com/users/nhosoi/orgs","repos_url":"https://api.github.com/users/nhosoi/repos","events_url":"https://api.github.com/users/nhosoi/events{/privacy}","received_events_url":"https://api.github.com/users/nhosoi/received_events","type":"User","site_admin":false},"repo":{"id":148842143,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg4NDIxNDM=","name":"logging","full_name":"nhosoi/logging","private":false,"owner":{"login":"nhosoi","id":938485,"node_id":"MDQ6VXNlcjkzODQ4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/938485?v=4","gravatar_id":"","url":"https://api.github.com/users/nhosoi","html_url":"https://github.com/nhosoi","followers_url":"https://api.github.com/users/nhosoi/followers","following_url":"https://api.github.com/users/nhosoi/following{/other_user}","gists_url":"https://api.github.com/users/nhosoi/gists{/gist_id}","starred_url":"https://api.github.com/users/nhosoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhosoi/subscriptions","organizations_url":"https://api.github.com/users/nhosoi/orgs","repos_url":"https://api.github.com/users/nhosoi/repos","events_url":"https://api.github.com/users/nhosoi/events{/privacy}","received_events_url":"https://api.github.com/users/nhosoi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nhosoi/logging","description":"An ansible role which configures logging.","fork":true,"url":"https://api.github.com/repos/nhosoi/logging","forks_url":"https://api.github.com/repos/nhosoi/logging/forks","keys_url":"https://api.github.com/repos/nhosoi/logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhosoi/logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhosoi/logging/teams","hooks_url":"https://api.github.com/repos/nhosoi/logging/hooks","issue_events_url":"https://api.github.com/repos/nhosoi/logging/issues/events{/number}","events_url":"https://api.github.com/repos/nhosoi/logging/events","assignees_url":"https://api.github.com/repos/nhosoi/logging/assignees{/user}","branches_url":"https://api.github.com/repos/nhosoi/logging/branches{/branch}","tags_url":"https://api.github.com/repos/nhosoi/logging/tags","blobs_url":"https://api.github.com/repos/nhosoi/logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhosoi/logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhosoi/logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhosoi/logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhosoi/logging/statuses/{sha}","languages_url":"https://api.github.com/repos/nhosoi/logging/languages","stargazers_url":"https://api.github.com/repos/nhosoi/logging/stargazers","contributors_url":"https://api.github.com/repos/nhosoi/logging/contributors","subscribers_url":"https://api.github.com/repos/nhosoi/logging/subscribers","subscription_url":"https://api.github.com/repos/nhosoi/logging/subscription","commits_url":"https://api.github.com/repos/nhosoi/logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhosoi/logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhosoi/logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhosoi/logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhosoi/logging/contents/{+path}","compare_url":"https://api.github.com/repos/nhosoi/logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhosoi/logging/merges","archive_url":"https://api.github.com/repos/nhosoi/logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhosoi/logging/downloads","issues_url":"https://api.github.com/repos/nhosoi/logging/issues{/number}","pulls_url":"https://api.github.com/repos/nhosoi/logging/pulls{/number}","milestones_url":"https://api.github.com/repos/nhosoi/logging/milestones{/number}","notifications_url":"https://api.github.com/repos/nhosoi/logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhosoi/logging/labels{/name}","releases_url":"https://api.github.com/repos/nhosoi/logging/releases{/id}","deployments_url":"https://api.github.com/repos/nhosoi/logging/deployments","created_at":"2018-09-14T21:10:05Z","updated_at":"2018-09-14T21:10:07Z","pushed_at":"2018-10-31T23:13:57Z","git_url":"git://github.com/nhosoi/logging.git","ssh_url":"git@github.com:nhosoi/logging.git","clone_url":"https://github.com/nhosoi/logging.git","svn_url":"https://github.com/nhosoi/logging","homepage":null,"size":72,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linux-system-roles:master","ref":"master","sha":"9e933ce0c1ce26b0022886a6195610ecb86281a0","user":{"login":"linux-system-roles","id":28014670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MDE0Njcw","avatar_url":"https://avatars1.githubusercontent.com/u/28014670?v=4","gravatar_id":"","url":"https://api.github.com/users/linux-system-roles","html_url":"https://github.com/linux-system-roles","followers_url":"https://api.github.com/users/linux-system-roles/followers","following_url":"https://api.github.com/users/linux-system-roles/following{/other_user}","gists_url":"https://api.github.com/users/linux-system-roles/gists{/gist_id}","starred_url":"https://api.github.com/users/linux-system-roles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linux-system-roles/subscriptions","organizations_url":"https://api.github.com/users/linux-system-roles/orgs","repos_url":"https://api.github.com/users/linux-system-roles/repos","events_url":"https://api.github.com/users/linux-system-roles/events{/privacy}","received_events_url":"https://api.github.com/users/linux-system-roles/received_events","type":"Organization","site_admin":false},"repo":{"id":137203581,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMDM1ODE=","name":"logging","full_name":"linux-system-roles/logging","private":false,"owner":{"login":"linux-system-roles","id":28014670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MDE0Njcw","avatar_url":"https://avatars1.githubusercontent.com/u/28014670?v=4","gravatar_id":"","url":"https://api.github.com/users/linux-system-roles","html_url":"https://github.com/linux-system-roles","followers_url":"https://api.github.com/users/linux-system-roles/followers","following_url":"https://api.github.com/users/linux-system-roles/following{/other_user}","gists_url":"https://api.github.com/users/linux-system-roles/gists{/gist_id}","starred_url":"https://api.github.com/users/linux-system-roles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linux-system-roles/subscriptions","organizations_url":"https://api.github.com/users/linux-system-roles/orgs","repos_url":"https://api.github.com/users/linux-system-roles/repos","events_url":"https://api.github.com/users/linux-system-roles/events{/privacy}","received_events_url":"https://api.github.com/users/linux-system-roles/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linux-system-roles/logging","description":"An ansible role which configures logging.","fork":false,"url":"https://api.github.com/repos/linux-system-roles/logging","forks_url":"https://api.github.com/repos/linux-system-roles/logging/forks","keys_url":"https://api.github.com/repos/linux-system-roles/logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linux-system-roles/logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linux-system-roles/logging/teams","hooks_url":"https://api.github.com/repos/linux-system-roles/logging/hooks","issue_events_url":"https://api.github.com/repos/linux-system-roles/logging/issues/events{/number}","events_url":"https://api.github.com/repos/linux-system-roles/logging/events","assignees_url":"https://api.github.com/repos/linux-system-roles/logging/assignees{/user}","branches_url":"https://api.github.com/repos/linux-system-roles/logging/branches{/branch}","tags_url":"https://api.github.com/repos/linux-system-roles/logging/tags","blobs_url":"https://api.github.com/repos/linux-system-roles/logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linux-system-roles/logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linux-system-roles/logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/linux-system-roles/logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linux-system-roles/logging/statuses/{sha}","languages_url":"https://api.github.com/repos/linux-system-roles/logging/languages","stargazers_url":"https://api.github.com/repos/linux-system-roles/logging/stargazers","contributors_url":"https://api.github.com/repos/linux-system-roles/logging/contributors","subscribers_url":"https://api.github.com/repos/linux-system-roles/logging/subscribers","subscription_url":"https://api.github.com/repos/linux-system-roles/logging/subscription","commits_url":"https://api.github.com/repos/linux-system-roles/logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/linux-system-roles/logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/linux-system-roles/logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/linux-system-roles/logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/linux-system-roles/logging/contents/{+path}","compare_url":"https://api.github.com/repos/linux-system-roles/logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linux-system-roles/logging/merges","archive_url":"https://api.github.com/repos/linux-system-roles/logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linux-system-roles/logging/downloads","issues_url":"https://api.github.com/repos/linux-system-roles/logging/issues{/number}","pulls_url":"https://api.github.com/repos/linux-system-roles/logging/pulls{/number}","milestones_url":"https://api.github.com/repos/linux-system-roles/logging/milestones{/number}","notifications_url":"https://api.github.com/repos/linux-system-roles/logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linux-system-roles/logging/labels{/name}","releases_url":"https://api.github.com/repos/linux-system-roles/logging/releases{/id}","deployments_url":"https://api.github.com/repos/linux-system-roles/logging/deployments","created_at":"2018-06-13T11:00:11Z","updated_at":"2018-10-28T13:36:12Z","pushed_at":"2018-10-31T23:13:58Z","git_url":"git://github.com/linux-system-roles/logging.git","ssh_url":"git@github.com:linux-system-roles/logging.git","clone_url":"https://github.com/linux-system-roles/logging.git","svn_url":"https://github.com/linux-system-roles/logging","homepage":null,"size":67,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linux-system-roles/logging/pulls/20"},"html":{"href":"https://github.com/linux-system-roles/logging/pull/20"},"issue":{"href":"https://api.github.com/repos/linux-system-roles/logging/issues/20"},"comments":{"href":"https://api.github.com/repos/linux-system-roles/logging/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/linux-system-roles/logging/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/linux-system-roles/logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linux-system-roles/logging/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/linux-system-roles/logging/statuses/23073fce2606b54270e7e9041d9c7e74e82fa97a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nhosoi"}}