{"action":"created","comment":{"url":"https://api.github.com/repos/pika/pika/pulls/comments/193918579","pull_request_review_id":126992500,"id":193918579,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzkxODU3OQ==","diff_hunk":"@@ -397,7 +310,7 @@ def _adapter_get_write_buffer_size(self):\n         \"\"\"Implement pure virtual\n         :py:ref:meth:`pika.connection.Connection._adapter_emit_data()` method.\n \n-        TODO: this method only belongs in SelectConnection, none others needs it\n+        TODO: this method only belongs in SelectConnection, no others need it","path":"pika/adapters/twisted_connection.py","position":148,"original_position":148,"commit_id":"7440a1f5163dfe118271c95b58e6e6fbb56b6e68","original_commit_id":"7440a1f5163dfe118271c95b58e6e6fbb56b6e68","user":{"login":"lukebakken","id":514926,"node_id":"MDQ6VXNlcjUxNDkyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false},"body":"Hmm, I don't see an implementation of `_adapter_get_write_buffer_size` in `SelectConnection` ... @vitaly-krugl is that something that should be there?","created_at":"2018-06-07T23:38:50Z","updated_at":"2018-06-07T23:38:50Z","html_url":"https://github.com/pika/pika/pull/1069#discussion_r193918579","pull_request_url":"https://api.github.com/repos/pika/pika/pulls/1069","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pika/pika/pulls/comments/193918579"},"html":{"href":"https://github.com/pika/pika/pull/1069#discussion_r193918579"},"pull_request":{"href":"https://api.github.com/repos/pika/pika/pulls/1069"}}},"pull_request":{"url":"https://api.github.com/repos/pika/pika/pulls/1069","id":193447168,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDQ3MTY4","html_url":"https://github.com/pika/pika/pull/1069","diff_url":"https://github.com/pika/pika/pull/1069.diff","patch_url":"https://github.com/pika/pika/pull/1069.patch","issue_url":"https://api.github.com/repos/pika/pika/issues/1069","number":1069,"state":"open","locked":false,"title":"Add tests for the Twisted adapter","user":{"login":"abompard","id":95780,"node_id":"MDQ6VXNlcjk1Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/95780?v=4","gravatar_id":"","url":"https://api.github.com/users/abompard","html_url":"https://github.com/abompard","followers_url":"https://api.github.com/users/abompard/followers","following_url":"https://api.github.com/users/abompard/following{/other_user}","gists_url":"https://api.github.com/users/abompard/gists{/gist_id}","starred_url":"https://api.github.com/users/abompard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abompard/subscriptions","organizations_url":"https://api.github.com/users/abompard/orgs","repos_url":"https://api.github.com/users/abompard/repos","events_url":"https://api.github.com/users/abompard/events{/privacy}","received_events_url":"https://api.github.com/users/abompard/received_events","type":"User","site_admin":false},"body":"This commit does not add test to the `TwistedConnection`, only to the `TwistedProtocolConnection`. I think that the `TwistedConnection` can be deprecated and/or dropped, because is uses the blocking `socket` module and that's discouraged in Twisted.\r\nWhen those pieces are removed, the tests coverage is almost 100% (only the `NotImplementedError`s are uncovered).\r\n\r\nThe commit also fixes a couple bugs in the Twisted adapter that likely come from evolving code in the rest of the project.\r\n\r\nFixes #615, #1031","created_at":"2018-06-07T21:05:27Z","updated_at":"2018-06-07T23:38:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cd1cc7ba07b4e95da6bab89995dc0fcadb18d65","assignee":{"login":"lukebakken","id":514926,"node_id":"MDQ6VXNlcjUxNDkyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false},"assignees":[{"login":"lukebakken","id":514926,"node_id":"MDQ6VXNlcjUxNDkyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":37632,"node_id":"MDU6TGFiZWwzNzYzMg==","url":"https://api.github.com/repos/pika/pika/labels/Enhancement","name":"Enhancement","color":"02d7e1","default":false}],"milestone":{"url":"https://api.github.com/repos/pika/pika/milestones/8","html_url":"https://github.com/pika/pika/milestone/8","labels_url":"https://api.github.com/repos/pika/pika/milestones/8/labels","id":2664000,"node_id":"MDk6TWlsZXN0b25lMjY2NDAwMA==","number":8,"title":"1.0.0","description":"","creator":{"login":"lukebakken","id":514926,"node_id":"MDQ6VXNlcjUxNDkyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/514926?v=4","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":83,"state":"open","created_at":"2017-07-26T21:40:33Z","updated_at":"2018-06-07T22:59:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pika/pika/pulls/1069/commits","review_comments_url":"https://api.github.com/repos/pika/pika/pulls/1069/comments","review_comment_url":"https://api.github.com/repos/pika/pika/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pika/pika/issues/1069/comments","statuses_url":"https://api.github.com/repos/pika/pika/statuses/7440a1f5163dfe118271c95b58e6e6fbb56b6e68","head":{"label":"abompard:twisted-tests","ref":"twisted-tests","sha":"7440a1f5163dfe118271c95b58e6e6fbb56b6e68","user":{"login":"abompard","id":95780,"node_id":"MDQ6VXNlcjk1Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/95780?v=4","gravatar_id":"","url":"https://api.github.com/users/abompard","html_url":"https://github.com/abompard","followers_url":"https://api.github.com/users/abompard/followers","following_url":"https://api.github.com/users/abompard/following{/other_user}","gists_url":"https://api.github.com/users/abompard/gists{/gist_id}","starred_url":"https://api.github.com/users/abompard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abompard/subscriptions","organizations_url":"https://api.github.com/users/abompard/orgs","repos_url":"https://api.github.com/users/abompard/repos","events_url":"https://api.github.com/users/abompard/events{/privacy}","received_events_url":"https://api.github.com/users/abompard/received_events","type":"User","site_admin":false},"repo":{"id":136282430,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyODI0MzA=","name":"pika","full_name":"abompard/pika","owner":{"login":"abompard","id":95780,"node_id":"MDQ6VXNlcjk1Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/95780?v=4","gravatar_id":"","url":"https://api.github.com/users/abompard","html_url":"https://github.com/abompard","followers_url":"https://api.github.com/users/abompard/followers","following_url":"https://api.github.com/users/abompard/following{/other_user}","gists_url":"https://api.github.com/users/abompard/gists{/gist_id}","starred_url":"https://api.github.com/users/abompard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abompard/subscriptions","organizations_url":"https://api.github.com/users/abompard/orgs","repos_url":"https://api.github.com/users/abompard/repos","events_url":"https://api.github.com/users/abompard/events{/privacy}","received_events_url":"https://api.github.com/users/abompard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abompard/pika","description":"Pure Python RabbitMQ/AMQP 0-9-1 client library","fork":true,"url":"https://api.github.com/repos/abompard/pika","forks_url":"https://api.github.com/repos/abompard/pika/forks","keys_url":"https://api.github.com/repos/abompard/pika/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abompard/pika/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abompard/pika/teams","hooks_url":"https://api.github.com/repos/abompard/pika/hooks","issue_events_url":"https://api.github.com/repos/abompard/pika/issues/events{/number}","events_url":"https://api.github.com/repos/abompard/pika/events","assignees_url":"https://api.github.com/repos/abompard/pika/assignees{/user}","branches_url":"https://api.github.com/repos/abompard/pika/branches{/branch}","tags_url":"https://api.github.com/repos/abompard/pika/tags","blobs_url":"https://api.github.com/repos/abompard/pika/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abompard/pika/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abompard/pika/git/refs{/sha}","trees_url":"https://api.github.com/repos/abompard/pika/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abompard/pika/statuses/{sha}","languages_url":"https://api.github.com/repos/abompard/pika/languages","stargazers_url":"https://api.github.com/repos/abompard/pika/stargazers","contributors_url":"https://api.github.com/repos/abompard/pika/contributors","subscribers_url":"https://api.github.com/repos/abompard/pika/subscribers","subscription_url":"https://api.github.com/repos/abompard/pika/subscription","commits_url":"https://api.github.com/repos/abompard/pika/commits{/sha}","git_commits_url":"https://api.github.com/repos/abompard/pika/git/commits{/sha}","comments_url":"https://api.github.com/repos/abompard/pika/comments{/number}","issue_comment_url":"https://api.github.com/repos/abompard/pika/issues/comments{/number}","contents_url":"https://api.github.com/repos/abompard/pika/contents/{+path}","compare_url":"https://api.github.com/repos/abompard/pika/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abompard/pika/merges","archive_url":"https://api.github.com/repos/abompard/pika/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abompard/pika/downloads","issues_url":"https://api.github.com/repos/abompard/pika/issues{/number}","pulls_url":"https://api.github.com/repos/abompard/pika/pulls{/number}","milestones_url":"https://api.github.com/repos/abompard/pika/milestones{/number}","notifications_url":"https://api.github.com/repos/abompard/pika/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abompard/pika/labels{/name}","releases_url":"https://api.github.com/repos/abompard/pika/releases{/id}","deployments_url":"https://api.github.com/repos/abompard/pika/deployments","created_at":"2018-06-06T06:26:46Z","updated_at":"2018-06-06T06:26:49Z","pushed_at":"2018-06-07T23:36:05Z","git_url":"git://github.com/abompard/pika.git","ssh_url":"git@github.com:abompard/pika.git","clone_url":"https://github.com/abompard/pika.git","svn_url":"https://github.com/abompard/pika","homepage":"https://pika.readthedocs.io","size":6546,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pika:master","ref":"master","sha":"a320aa82574bd46dbec911611015a1c75b0f5cdc","user":{"login":"pika","id":660428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MDQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/660428?v=4","gravatar_id":"","url":"https://api.github.com/users/pika","html_url":"https://github.com/pika","followers_url":"https://api.github.com/users/pika/followers","following_url":"https://api.github.com/users/pika/following{/other_user}","gists_url":"https://api.github.com/users/pika/gists{/gist_id}","starred_url":"https://api.github.com/users/pika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pika/subscriptions","organizations_url":"https://api.github.com/users/pika/orgs","repos_url":"https://api.github.com/users/pika/repos","events_url":"https://api.github.com/users/pika/events{/privacy}","received_events_url":"https://api.github.com/users/pika/received_events","type":"Organization","site_admin":false},"repo":{"id":342869,"node_id":"MDEwOlJlcG9zaXRvcnkzNDI4Njk=","name":"pika","full_name":"pika/pika","owner":{"login":"pika","id":660428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MDQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/660428?v=4","gravatar_id":"","url":"https://api.github.com/users/pika","html_url":"https://github.com/pika","followers_url":"https://api.github.com/users/pika/followers","following_url":"https://api.github.com/users/pika/following{/other_user}","gists_url":"https://api.github.com/users/pika/gists{/gist_id}","starred_url":"https://api.github.com/users/pika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pika/subscriptions","organizations_url":"https://api.github.com/users/pika/orgs","repos_url":"https://api.github.com/users/pika/repos","events_url":"https://api.github.com/users/pika/events{/privacy}","received_events_url":"https://api.github.com/users/pika/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pika/pika","description":"Pure Python RabbitMQ/AMQP 0-9-1 client library","fork":false,"url":"https://api.github.com/repos/pika/pika","forks_url":"https://api.github.com/repos/pika/pika/forks","keys_url":"https://api.github.com/repos/pika/pika/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pika/pika/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pika/pika/teams","hooks_url":"https://api.github.com/repos/pika/pika/hooks","issue_events_url":"https://api.github.com/repos/pika/pika/issues/events{/number}","events_url":"https://api.github.com/repos/pika/pika/events","assignees_url":"https://api.github.com/repos/pika/pika/assignees{/user}","branches_url":"https://api.github.com/repos/pika/pika/branches{/branch}","tags_url":"https://api.github.com/repos/pika/pika/tags","blobs_url":"https://api.github.com/repos/pika/pika/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pika/pika/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pika/pika/git/refs{/sha}","trees_url":"https://api.github.com/repos/pika/pika/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pika/pika/statuses/{sha}","languages_url":"https://api.github.com/repos/pika/pika/languages","stargazers_url":"https://api.github.com/repos/pika/pika/stargazers","contributors_url":"https://api.github.com/repos/pika/pika/contributors","subscribers_url":"https://api.github.com/repos/pika/pika/subscribers","subscription_url":"https://api.github.com/repos/pika/pika/subscription","commits_url":"https://api.github.com/repos/pika/pika/commits{/sha}","git_commits_url":"https://api.github.com/repos/pika/pika/git/commits{/sha}","comments_url":"https://api.github.com/repos/pika/pika/comments{/number}","issue_comment_url":"https://api.github.com/repos/pika/pika/issues/comments{/number}","contents_url":"https://api.github.com/repos/pika/pika/contents/{+path}","compare_url":"https://api.github.com/repos/pika/pika/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pika/pika/merges","archive_url":"https://api.github.com/repos/pika/pika/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pika/pika/downloads","issues_url":"https://api.github.com/repos/pika/pika/issues{/number}","pulls_url":"https://api.github.com/repos/pika/pika/pulls{/number}","milestones_url":"https://api.github.com/repos/pika/pika/milestones{/number}","notifications_url":"https://api.github.com/repos/pika/pika/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pika/pika/labels{/name}","releases_url":"https://api.github.com/repos/pika/pika/releases{/id}","deployments_url":"https://api.github.com/repos/pika/pika/deployments","created_at":"2009-10-19T23:22:02Z","updated_at":"2018-06-07T14:40:53Z","pushed_at":"2018-06-07T23:36:06Z","git_url":"git://github.com/pika/pika.git","ssh_url":"git@github.com:pika/pika.git","clone_url":"https://github.com/pika/pika.git","svn_url":"https://github.com/pika/pika","homepage":"https://pika.readthedocs.io","size":6573,"stargazers_count":1637,"watchers_count":1637,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":501,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":501,"open_issues":19,"watchers":1637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pika/pika/pulls/1069"},"html":{"href":"https://github.com/pika/pika/pull/1069"},"issue":{"href":"https://api.github.com/repos/pika/pika/issues/1069"},"comments":{"href":"https://api.github.com/repos/pika/pika/issues/1069/comments"},"review_comments":{"href":"https://api.github.com/repos/pika/pika/pulls/1069/comments"},"review_comment":{"href":"https://api.github.com/repos/pika/pika/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pika/pika/pulls/1069/commits"},"statuses":{"href":"https://api.github.com/repos/pika/pika/statuses/7440a1f5163dfe118271c95b58e6e6fbb56b6e68"}},"author_association":"NONE"}}
{"actor":{"display_login":"lukebakken"}}