{"action":"closed","number":61,"pull_request":{"url":"https://api.github.com/repos/go-openapi/spec/pulls/61","id":168941902,"html_url":"https://github.com/go-openapi/spec/pull/61","diff_url":"https://github.com/go-openapi/spec/pull/61.diff","patch_url":"https://github.com/go-openapi/spec/pull/61.patch","issue_url":"https://api.github.com/repos/go-openapi/spec/issues/61","number":61,"state":"closed","locked":false,"title":"improve performance of schema deserialize","user":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars3.githubusercontent.com/u/1787169?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"body":"and add some benchmarks. This is a bottleneck for the kubernetes unit tests.\r\nThe fix works by caching the deserialization of the full schema into a\r\nmap. We were doing this three times. Now we only do it once.\r\n\r\nBefore:\r\n```    \r\n    BenchmarkSchemaUnmarshal-12\r\n            50000            321498 ns/op           86325 B/op       1400 allocs/op\r\n```\r\n\r\nAfter:\r\n\r\n```    \r\n    BenchmarkSchemaUnmarshal-12\r\n           100000            131877 ns/op           46183 B/op        535 allocs/op\r\n```\r\n\r\n@mbohlool ","created_at":"2018-02-13T20:00:56Z","updated_at":"2018-02-13T23:25:51Z","closed_at":"2018-02-13T23:25:51Z","merged_at":"2018-02-13T23:25:51Z","merge_commit_sha":"1de3e0542de65ad8d75452a595886fdd0befb363","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-openapi/spec/pulls/61/commits","review_comments_url":"https://api.github.com/repos/go-openapi/spec/pulls/61/comments","review_comment_url":"https://api.github.com/repos/go-openapi/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-openapi/spec/issues/61/comments","statuses_url":"https://api.github.com/repos/go-openapi/spec/statuses/bc104a1bf99f061d43f9b74b1d33dcd2f455c793","head":{"label":"mikedanese:speedup","ref":"speedup","sha":"bc104a1bf99f061d43f9b74b1d33dcd2f455c793","user":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars3.githubusercontent.com/u/1787169?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"repo":{"id":121429718,"name":"spec-1","full_name":"mikedanese/spec-1","owner":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars3.githubusercontent.com/u/1787169?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikedanese/spec-1","description":"openapi specification object model","fork":true,"url":"https://api.github.com/repos/mikedanese/spec-1","forks_url":"https://api.github.com/repos/mikedanese/spec-1/forks","keys_url":"https://api.github.com/repos/mikedanese/spec-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikedanese/spec-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikedanese/spec-1/teams","hooks_url":"https://api.github.com/repos/mikedanese/spec-1/hooks","issue_events_url":"https://api.github.com/repos/mikedanese/spec-1/issues/events{/number}","events_url":"https://api.github.com/repos/mikedanese/spec-1/events","assignees_url":"https://api.github.com/repos/mikedanese/spec-1/assignees{/user}","branches_url":"https://api.github.com/repos/mikedanese/spec-1/branches{/branch}","tags_url":"https://api.github.com/repos/mikedanese/spec-1/tags","blobs_url":"https://api.github.com/repos/mikedanese/spec-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikedanese/spec-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikedanese/spec-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikedanese/spec-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikedanese/spec-1/statuses/{sha}","languages_url":"https://api.github.com/repos/mikedanese/spec-1/languages","stargazers_url":"https://api.github.com/repos/mikedanese/spec-1/stargazers","contributors_url":"https://api.github.com/repos/mikedanese/spec-1/contributors","subscribers_url":"https://api.github.com/repos/mikedanese/spec-1/subscribers","subscription_url":"https://api.github.com/repos/mikedanese/spec-1/subscription","commits_url":"https://api.github.com/repos/mikedanese/spec-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikedanese/spec-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikedanese/spec-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikedanese/spec-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikedanese/spec-1/contents/{+path}","compare_url":"https://api.github.com/repos/mikedanese/spec-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikedanese/spec-1/merges","archive_url":"https://api.github.com/repos/mikedanese/spec-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikedanese/spec-1/downloads","issues_url":"https://api.github.com/repos/mikedanese/spec-1/issues{/number}","pulls_url":"https://api.github.com/repos/mikedanese/spec-1/pulls{/number}","milestones_url":"https://api.github.com/repos/mikedanese/spec-1/milestones{/number}","notifications_url":"https://api.github.com/repos/mikedanese/spec-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikedanese/spec-1/labels{/name}","releases_url":"https://api.github.com/repos/mikedanese/spec-1/releases{/id}","deployments_url":"https://api.github.com/repos/mikedanese/spec-1/deployments","created_at":"2018-02-13T19:59:00Z","updated_at":"2018-02-13T19:59:03Z","pushed_at":"2018-02-13T21:11:59Z","git_url":"git://github.com/mikedanese/spec-1.git","ssh_url":"git@github.com:mikedanese/spec-1.git","clone_url":"https://github.com/mikedanese/spec-1.git","svn_url":"https://github.com/mikedanese/spec-1","homepage":null,"size":3316,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-openapi:master","ref":"master","sha":"a7c696777f29fd0998254e1bceb37275f0cc59b6","user":{"login":"go-openapi","id":15724843,"avatar_url":"https://avatars1.githubusercontent.com/u/15724843?v=4","gravatar_id":"","url":"https://api.github.com/users/go-openapi","html_url":"https://github.com/go-openapi","followers_url":"https://api.github.com/users/go-openapi/followers","following_url":"https://api.github.com/users/go-openapi/following{/other_user}","gists_url":"https://api.github.com/users/go-openapi/gists{/gist_id}","starred_url":"https://api.github.com/users/go-openapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-openapi/subscriptions","organizations_url":"https://api.github.com/users/go-openapi/orgs","repos_url":"https://api.github.com/users/go-openapi/repos","events_url":"https://api.github.com/users/go-openapi/events{/privacy}","received_events_url":"https://api.github.com/users/go-openapi/received_events","type":"Organization","site_admin":false},"repo":{"id":56421126,"name":"spec","full_name":"go-openapi/spec","owner":{"login":"go-openapi","id":15724843,"avatar_url":"https://avatars1.githubusercontent.com/u/15724843?v=4","gravatar_id":"","url":"https://api.github.com/users/go-openapi","html_url":"https://github.com/go-openapi","followers_url":"https://api.github.com/users/go-openapi/followers","following_url":"https://api.github.com/users/go-openapi/following{/other_user}","gists_url":"https://api.github.com/users/go-openapi/gists{/gist_id}","starred_url":"https://api.github.com/users/go-openapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-openapi/subscriptions","organizations_url":"https://api.github.com/users/go-openapi/orgs","repos_url":"https://api.github.com/users/go-openapi/repos","events_url":"https://api.github.com/users/go-openapi/events{/privacy}","received_events_url":"https://api.github.com/users/go-openapi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-openapi/spec","description":"openapi specification object model","fork":false,"url":"https://api.github.com/repos/go-openapi/spec","forks_url":"https://api.github.com/repos/go-openapi/spec/forks","keys_url":"https://api.github.com/repos/go-openapi/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-openapi/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-openapi/spec/teams","hooks_url":"https://api.github.com/repos/go-openapi/spec/hooks","issue_events_url":"https://api.github.com/repos/go-openapi/spec/issues/events{/number}","events_url":"https://api.github.com/repos/go-openapi/spec/events","assignees_url":"https://api.github.com/repos/go-openapi/spec/assignees{/user}","branches_url":"https://api.github.com/repos/go-openapi/spec/branches{/branch}","tags_url":"https://api.github.com/repos/go-openapi/spec/tags","blobs_url":"https://api.github.com/repos/go-openapi/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-openapi/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-openapi/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-openapi/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-openapi/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/go-openapi/spec/languages","stargazers_url":"https://api.github.com/repos/go-openapi/spec/stargazers","contributors_url":"https://api.github.com/repos/go-openapi/spec/contributors","subscribers_url":"https://api.github.com/repos/go-openapi/spec/subscribers","subscription_url":"https://api.github.com/repos/go-openapi/spec/subscription","commits_url":"https://api.github.com/repos/go-openapi/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-openapi/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-openapi/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-openapi/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-openapi/spec/contents/{+path}","compare_url":"https://api.github.com/repos/go-openapi/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-openapi/spec/merges","archive_url":"https://api.github.com/repos/go-openapi/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-openapi/spec/downloads","issues_url":"https://api.github.com/repos/go-openapi/spec/issues{/number}","pulls_url":"https://api.github.com/repos/go-openapi/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/go-openapi/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/go-openapi/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-openapi/spec/labels{/name}","releases_url":"https://api.github.com/repos/go-openapi/spec/releases{/id}","deployments_url":"https://api.github.com/repos/go-openapi/spec/deployments","created_at":"2016-04-17T05:48:22Z","updated_at":"2018-02-08T20:23:03Z","pushed_at":"2018-02-13T23:25:51Z","git_url":"git://github.com/go-openapi/spec.git","ssh_url":"git@github.com:go-openapi/spec.git","clone_url":"https://github.com/go-openapi/spec.git","svn_url":"https://github.com/go-openapi/spec","homepage":null,"size":3330,"stargazers_count":82,"watchers_count":82,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":34,"open_issues":8,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-openapi/spec/pulls/61"},"html":{"href":"https://github.com/go-openapi/spec/pull/61"},"issue":{"href":"https://api.github.com/repos/go-openapi/spec/issues/61"},"comments":{"href":"https://api.github.com/repos/go-openapi/spec/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/go-openapi/spec/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/go-openapi/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-openapi/spec/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/go-openapi/spec/statuses/bc104a1bf99f061d43f9b74b1d33dcd2f455c793"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"casualjim","id":456109,"avatar_url":"https://avatars0.githubusercontent.com/u/456109?v=4","gravatar_id":"","url":"https://api.github.com/users/casualjim","html_url":"https://github.com/casualjim","followers_url":"https://api.github.com/users/casualjim/followers","following_url":"https://api.github.com/users/casualjim/following{/other_user}","gists_url":"https://api.github.com/users/casualjim/gists{/gist_id}","starred_url":"https://api.github.com/users/casualjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casualjim/subscriptions","organizations_url":"https://api.github.com/users/casualjim/orgs","repos_url":"https://api.github.com/users/casualjim/repos","events_url":"https://api.github.com/users/casualjim/events{/privacy}","received_events_url":"https://api.github.com/users/casualjim/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":10,"changed_files":3}}
{"actor":{"display_login":"casualjim"}}