{"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-server/pulls/comments/174011147","pull_request_review_id":103291583,"id":174011147,"diff_hunk":"@@ -139,30 +139,18 @@ static void free_key_and_col_info (KEY_AND_COL_INFO* kc_info) {\n }\n \n \n-uchar* TOKUDB_SHARE::hash_get_key(\n-    TOKUDB_SHARE* share,\n-    size_t* length,\n-    TOKUDB_UNUSED(my_bool not_used)) {\n-\n-    *length = share->_full_table_name.length();\n-    return (uchar *) share->_full_table_name.c_ptr();\n-}\n-void TOKUDB_SHARE::hash_free_element(TOKUDB_SHARE* share) {\n-    share->destroy();\n-    delete share;\n-}\n void TOKUDB_SHARE::static_init() {\n-    my_hash_init(\n-        &_open_tables,\n-        table_alias_charset,\n-        32,\n-        0,\n-        0,\n-        (my_hash_get_key)hash_get_key,\n-        (my_hash_free_key)hash_free_element, 0);\n+    assert_always(_open_tables.size() == 0);\n }\n void TOKUDB_SHARE::static_destroy() {\n-    my_hash_free(&_open_tables);\n+    for (auto it = _open_tables.cbegin(); it != _open_tables.cend(); it++) {\n+        TOKUDB_TRACE(\"_open_tables %s %p\", it->first.c_str(), it->second);\n+        TOKUDB_SHARE* share = it->second;\n+        share->destroy();\n+        delete share;\n+    }\n+    _open_tables.clear();\n+    assert_always(_open_tables.size() == 0);","path":"storage/tokudb/ha_tokudb.cc","position":45,"original_position":45,"commit_id":"1416ff5749dbfdb013fd1bd34fed2c6b9bb625e4","original_commit_id":"1416ff5749dbfdb013fd1bd34fed2c6b9bb625e4","user":{"login":"laurynas-biveinis","id":58894,"avatar_url":"https://avatars3.githubusercontent.com/u/58894?v=4","gravatar_id":"","url":"https://api.github.com/users/laurynas-biveinis","html_url":"https://github.com/laurynas-biveinis","followers_url":"https://api.github.com/users/laurynas-biveinis/followers","following_url":"https://api.github.com/users/laurynas-biveinis/following{/other_user}","gists_url":"https://api.github.com/users/laurynas-biveinis/gists{/gist_id}","starred_url":"https://api.github.com/users/laurynas-biveinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurynas-biveinis/subscriptions","organizations_url":"https://api.github.com/users/laurynas-biveinis/orgs","repos_url":"https://api.github.com/users/laurynas-biveinis/repos","events_url":"https://api.github.com/users/laurynas-biveinis/events{/privacy}","received_events_url":"https://api.github.com/users/laurynas-biveinis/received_events","type":"User","site_admin":false},"body":"I wouldn't bother with this assert right after clear call, but if it's there, it can stay","created_at":"2018-03-13T03:57:53Z","updated_at":"2018-03-13T03:59:20Z","html_url":"https://github.com/percona/percona-server/pull/2219#discussion_r174011147","pull_request_url":"https://api.github.com/repos/percona/percona-server/pulls/2219","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments/174011147"},"html":{"href":"https://github.com/percona/percona-server/pull/2219#discussion_r174011147"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2219"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/2219","id":173535747,"html_url":"https://github.com/percona/percona-server/pull/2219","diff_url":"https://github.com/percona/percona-server/pull/2219.diff","patch_url":"https://github.com/percona/percona-server/pull/2219.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/2219","number":2219,"state":"open","locked":false,"title":"TDB-114 : pre-8.0 : Change use of MySQL HASH to unordered_map","user":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars2.githubusercontent.com/u/5247783?v=4","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"body":"- Harmless change that changes the container of currently opened TOKUDB_SHARE\r\n  instances from themysql HASH to std::unordered_map to prep for the coming 8.0\r\n  change that alters the API to the HASH in ways we just don't want to deal\r\n  with.","created_at":"2018-03-07T18:27:10Z","updated_at":"2018-03-13T03:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1fba7382dd5418e583596e5501d57a059b554d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/2219/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/2219/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/2219/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/1416ff5749dbfdb013fd1bd34fed2c6b9bb625e4","head":{"label":"georgelorchpercona:ps-5.6-TDB-114","ref":"ps-5.6-TDB-114","sha":"1416ff5749dbfdb013fd1bd34fed2c6b9bb625e4","user":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars2.githubusercontent.com/u/5247783?v=4","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"repo":{"id":32110095,"name":"percona-server","full_name":"georgelorchpercona/percona-server","owner":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars2.githubusercontent.com/u/5247783?v=4","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/georgelorchpercona/percona-server","description":null,"fork":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server","forks_url":"https://api.github.com/repos/georgelorchpercona/percona-server/forks","keys_url":"https://api.github.com/repos/georgelorchpercona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgelorchpercona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgelorchpercona/percona-server/teams","hooks_url":"https://api.github.com/repos/georgelorchpercona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/georgelorchpercona/percona-server/events","assignees_url":"https://api.github.com/repos/georgelorchpercona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/georgelorchpercona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/georgelorchpercona/percona-server/tags","blobs_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgelorchpercona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/georgelorchpercona/percona-server/languages","stargazers_url":"https://api.github.com/repos/georgelorchpercona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/georgelorchpercona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/georgelorchpercona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/georgelorchpercona/percona-server/subscription","commits_url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgelorchpercona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/georgelorchpercona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/georgelorchpercona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgelorchpercona/percona-server/merges","archive_url":"https://api.github.com/repos/georgelorchpercona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgelorchpercona/percona-server/downloads","issues_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/georgelorchpercona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/georgelorchpercona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/georgelorchpercona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgelorchpercona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/georgelorchpercona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/georgelorchpercona/percona-server/deployments","created_at":"2015-03-12T23:58:07Z","updated_at":"2017-03-06T16:05:12Z","pushed_at":"2018-03-12T23:11:31Z","git_url":"git://github.com/georgelorchpercona/percona-server.git","ssh_url":"git@github.com:georgelorchpercona/percona-server.git","clone_url":"https://github.com/georgelorchpercona/percona-server.git","svn_url":"https://github.com/georgelorchpercona/percona-server","homepage":null,"size":584351,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":0,"default_branch":"5.7"}},"base":{"label":"percona:5.6","ref":"5.6","sha":"c135bbd9970557a22119a303724e5c37fb070c58","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"Percona Server","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-server/deployments","created_at":"2015-02-13T11:32:01Z","updated_at":"2018-03-13T03:43:24Z","pushed_at":"2018-03-12T21:30:56Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"git@github.com:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":584608,"stargazers_count":409,"watchers_count":409,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":171,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":171,"open_issues":43,"watchers":409,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2219"},"html":{"href":"https://github.com/percona/percona-server/pull/2219"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/2219"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/2219/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2219/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2219/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/1416ff5749dbfdb013fd1bd34fed2c6b9bb625e4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"laurynas-biveinis"}}