{"action":"created","issue":{"url":"https://api.github.com/repos/swaywm/sway/issues/2762","repository_url":"https://api.github.com/repos/swaywm/sway","labels_url":"https://api.github.com/repos/swaywm/sway/issues/2762/labels{/name}","comments_url":"https://api.github.com/repos/swaywm/sway/issues/2762/comments","events_url":"https://api.github.com/repos/swaywm/sway/issues/2762/events","html_url":"https://github.com/swaywm/sway/pull/2762","id":366794951,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMzgwODEy","number":2762,"title":"Don't schedule unnecessary output frames, and simplify damage functions","user":{"login":"RyanDwyer","id":2436833,"node_id":"MDQ6VXNlcjI0MzY4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2436833?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanDwyer","html_url":"https://github.com/RyanDwyer","followers_url":"https://api.github.com/users/RyanDwyer/followers","following_url":"https://api.github.com/users/RyanDwyer/following{/other_user}","gists_url":"https://api.github.com/users/RyanDwyer/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanDwyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanDwyer/subscriptions","organizations_url":"https://api.github.com/users/RyanDwyer/orgs","repos_url":"https://api.github.com/users/RyanDwyer/repos","events_url":"https://api.github.com/users/RyanDwyer/events{/privacy}","received_events_url":"https://api.github.com/users/RyanDwyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-04T13:39:28Z","updated_at":"2018-10-04T13:49:02Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/swaywm/sway/pulls/2762","html_url":"https://github.com/swaywm/sway/pull/2762","diff_url":"https://github.com/swaywm/sway/pull/2762.diff","patch_url":"https://github.com/swaywm/sway/pull/2762.patch"},"body":"The `whole` argument has been removed from `damage_surface_iterator` because it was never used. As this function now only deals with partial damaging, it's been changed to return early if there is no damage and avoids scheduling a frame unnecessarily.\r\n\r\nWith the removal of the `whole` argument, `output_damage_from_view` just called `output_damage_view` with the same arguments, so I've combined these into the one function and renamed it to `output_damage_view_surfaces`.\r\n\r\nLastly, `output_damage_whole_container_iterator` is now removed as it was never used. `output_damage_whole_container` just damages the container including decorations and doesn't care about surfaces.\r\n\r\nProbably closes #2748, but I'd like to see before and after metrics..."},"comment":{"url":"https://api.github.com/repos/swaywm/sway/issues/comments/427025848","html_url":"https://github.com/swaywm/sway/pull/2762#issuecomment-427025848","issue_url":"https://api.github.com/repos/swaywm/sway/issues/2762","id":427025848,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzAyNTg0OA==","user":{"login":"emersion","id":506932,"node_id":"MDQ6VXNlcjUwNjkzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/506932?v=4","gravatar_id":"","url":"https://api.github.com/users/emersion","html_url":"https://github.com/emersion","followers_url":"https://api.github.com/users/emersion/followers","following_url":"https://api.github.com/users/emersion/following{/other_user}","gists_url":"https://api.github.com/users/emersion/gists{/gist_id}","starred_url":"https://api.github.com/users/emersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emersion/subscriptions","organizations_url":"https://api.github.com/users/emersion/orgs","repos_url":"https://api.github.com/users/emersion/repos","events_url":"https://api.github.com/users/emersion/events{/privacy}","received_events_url":"https://api.github.com/users/emersion/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T13:49:02Z","updated_at":"2018-10-04T13:49:02Z","author_association":"MEMBER","body":">therefore calling damage_surface_iterator with each surface\r\n\r\nI mean, it should damage the whole surfaces, it shouldn't take the damage from the surfaces. So we need `whole`."}}
{"actor":{"display_login":"emersion"}}