{"action":"created","issue":{"url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1875","repository_url":"https://api.github.com/repos/ianstormtaylor/slate","labels_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1875/labels{/name}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1875/comments","events_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1875/events","html_url":"https://github.com/ianstormtaylor/slate/pull/1875","id":328877974,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjc3MTM5","number":1875,"title":"Insert text normalize","user":{"login":"isubasti","id":18670101,"node_id":"MDQ6VXNlcjE4NjcwMTAx","avatar_url":"https://avatars0.githubusercontent.com/u/18670101?v=4","gravatar_id":"","url":"https://api.github.com/users/isubasti","html_url":"https://github.com/isubasti","followers_url":"https://api.github.com/users/isubasti/followers","following_url":"https://api.github.com/users/isubasti/following{/other_user}","gists_url":"https://api.github.com/users/isubasti/gists{/gist_id}","starred_url":"https://api.github.com/users/isubasti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isubasti/subscriptions","organizations_url":"https://api.github.com/users/isubasti/orgs","repos_url":"https://api.github.com/users/isubasti/repos","events_url":"https://api.github.com/users/isubasti/events{/privacy}","received_events_url":"https://api.github.com/users/isubasti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-04T00:46:03Z","updated_at":"2018-06-05T13:37:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1875","html_url":"https://github.com/ianstormtaylor/slate/pull/1875","diff_url":"https://github.com/ianstormtaylor/slate/pull/1875.diff","patch_url":"https://github.com/ianstormtaylor/slate/pull/1875.patch"},"body":"#### Is this adding or improving a _feature_ or fixing a _bug_?\r\nFixing a bug\r\n\r\n#### Curent Behaviour\r\n![inserttext not normalized mov](https://user-images.githubusercontent.com/18670101/40893152-b5fed202-67e3-11e8-8758-c8f35f899781.gif)\r\n\r\n\r\n<!-- \r\nIf you have a question, ask it in our Slack channel instead:\r\n\r\nhttps://slate-slack.herokuapp.com/\r\n-->\r\n\r\n#### What's the new behavior?\r\n![inserttext fix normalization mov](https://user-images.githubusercontent.com/18670101/40893153-bd86f59a-67e3-11e8-80df-2b88f4c0f636.gif)\r\n\r\n\r\n<!-- \r\nPlease include at least one of the following: \r\n\r\n- A GIF showing the new behavior in action.\r\n- A code sample showing the new API in action.\r\n- A description of how the new behavior works.\r\n\r\nIf you don't include one of these, there's a very good chance your pull request will take longer to review. Thank you!\r\n-->\r\n\r\n#### How does this change work?\r\npreviously the *PERF* normalization check isn't checking the right thing and also text that has marks that potentially needs to be normalized due to schema isn't normalized as well.This change is basically fix the *PERF* check and putting the correct normalization flag when needed.\r\n\r\n<!-- \r\nIf your change is non-trivial, please include a short description of how the new logic works, and why you decided to solve it the way you did. This is incredibly helpful so that reviewers don't have to guess based on the code.\r\n-->\r\n\r\n#### Have you checked that...?\r\n\r\n<!-- \r\nPlease run through this checklist for your pull request: \r\n-->\r\n\r\n* [x] The new code matches the existing patterns and styles.\r\n* [x] The tests pass with `yarn test`.\r\n* [x] The linter passes with `yarn lint`. (Fix errors with `yarn prettier`.)\r\n* [x] The relevant examples still work. (Run examples with `yarn watch`.)\r\n\r\n### Does this fix any issues or need any specific reviewers?\r\n\r\nFixes: #1792 \r\n\r\nReviewers: @ianstormtaylor \r\n"},"comment":{"url":"https://api.github.com/repos/ianstormtaylor/slate/issues/comments/394711826","html_url":"https://github.com/ianstormtaylor/slate/pull/1875#issuecomment-394711826","issue_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1875","id":394711826,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDcxMTgyNg==","user":{"login":"isubasti","id":18670101,"node_id":"MDQ6VXNlcjE4NjcwMTAx","avatar_url":"https://avatars0.githubusercontent.com/u/18670101?v=4","gravatar_id":"","url":"https://api.github.com/users/isubasti","html_url":"https://github.com/isubasti","followers_url":"https://api.github.com/users/isubasti/followers","following_url":"https://api.github.com/users/isubasti/following{/other_user}","gists_url":"https://api.github.com/users/isubasti/gists{/gist_id}","starred_url":"https://api.github.com/users/isubasti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isubasti/subscriptions","organizations_url":"https://api.github.com/users/isubasti/orgs","repos_url":"https://api.github.com/users/isubasti/repos","events_url":"https://api.github.com/users/isubasti/events{/privacy}","received_events_url":"https://api.github.com/users/isubasti/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T13:37:27Z","updated_at":"2018-06-05T13:37:27Z","author_association":"CONTRIBUTOR","body":"@gggdomi thanks for the linked PR, I think I know how to fix the test. Will get to it on the weekend"}}
{"actor":{"display_login":"isubasti"}}