{"action":"created","issue":{"url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/1683","repository_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto","labels_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/1683/labels{/name}","comments_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/1683/comments","events_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/1683/events","html_url":"https://github.com/MyCryptoHQ/MyCrypto/pull/1683","id":318115230,"number":1683,"title":"Allow Network Change Offline","user":{"login":"wbobeirne","id":649992,"avatar_url":"https://avatars0.githubusercontent.com/u/649992?v=4","gravatar_id":"","url":"https://api.github.com/users/wbobeirne","html_url":"https://github.com/wbobeirne","followers_url":"https://api.github.com/users/wbobeirne/followers","following_url":"https://api.github.com/users/wbobeirne/following{/other_user}","gists_url":"https://api.github.com/users/wbobeirne/gists{/gist_id}","starred_url":"https://api.github.com/users/wbobeirne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbobeirne/subscriptions","organizations_url":"https://api.github.com/users/wbobeirne/orgs","repos_url":"https://api.github.com/users/wbobeirne/repos","events_url":"https://api.github.com/users/wbobeirne/events{/privacy}","received_events_url":"https://api.github.com/users/wbobeirne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-26T16:54:07Z","updated_at":"2018-04-27T03:55:20Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/pulls/1683","html_url":"https://github.com/MyCryptoHQ/MyCrypto/pull/1683","diff_url":"https://github.com/MyCryptoHQ/MyCrypto/pull/1683.diff","patch_url":"https://github.com/MyCryptoHQ/MyCrypto/pull/1683.patch"},"body":"Closes #1681\r\n\r\n### Description\r\n\r\nI think this is a fair compromise between the UX of not letting users switch to nodes that won't connect vs allowing users to switch to other networks when offline. Allows a user to switch without fail if they're currently offline. Still attempts to fetch a block and get them back online, even if offline though.\r\n\r\nHowever, maybe the UX tradeoff isn't worth it, and we should just let users switch to offline nodes no matter what. I'm definitely open to that discussion!\r\n\r\n### Steps to Test\r\n\r\n1. Load the page and make sure you're connected to a network\r\n2. Attempt to switch to another node, make sure that works\r\n3. Set yourself offline, and quickly switch to another node (Simulating connecting to an \"offline node\"), confirm it doesn't allow you to connect\r\n4. Get yourself into the offline state (triggered by causing a node request, e.g. balance)\r\n5. Attempt to switch to another node again, confirm it allows you to connect"},"comment":{"url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/comments/384856634","html_url":"https://github.com/MyCryptoHQ/MyCrypto/pull/1683#issuecomment-384856634","issue_url":"https://api.github.com/repos/MyCryptoHQ/MyCrypto/issues/1683","id":384856634,"user":{"login":"dternyak","id":7861465,"avatar_url":"https://avatars2.githubusercontent.com/u/7861465?v=4","gravatar_id":"","url":"https://api.github.com/users/dternyak","html_url":"https://github.com/dternyak","followers_url":"https://api.github.com/users/dternyak/followers","following_url":"https://api.github.com/users/dternyak/following{/other_user}","gists_url":"https://api.github.com/users/dternyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dternyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dternyak/subscriptions","organizations_url":"https://api.github.com/users/dternyak/orgs","repos_url":"https://api.github.com/users/dternyak/repos","events_url":"https://api.github.com/users/dternyak/events{/privacy}","received_events_url":"https://api.github.com/users/dternyak/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T03:55:20Z","updated_at":"2018-04-27T03:55:20Z","author_association":"CONTRIBUTOR","body":"👍 I think the UX is optimal in that online users will still get notifications about offline nodes, but offline users can switch without delay."}}
{"actor":{"display_login":"dternyak"}}