{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/202456953","pull_request_review_id":137169976,"id":202456953,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ1Njk1Mw==","diff_hunk":"@@ -562,34 +626,109 @@ class RenderListWheelViewport\n       perspective: _perspective,\n     );\n \n-    context.pushTransform(\n-      // Text with TransformLayers and no cullRects currently have an issue rendering\n-      // https://github.com/flutter/flutter/issues/14224.\n-      false,\n-      offset,\n-      _centerOriginTransform(transform),\n-      // Pre-transform painting function.\n-      (PaintingContext context, Offset offset) {\n-        context.paintChild(\n-          child,\n-          offset + new Offset(\n-            untransformedPaintingCoordinates.dx,\n-            // Paint everything in the center (e.g. angle = 0), then transform.\n-            -_topScrollMarginExtent,\n-          ),\n-        );\n-      },\n-    );\n+    void _paintCylindrically(PaintingContext context, Offset offset) {","path":"packages/flutter/lib/src/rendering/list_wheel_viewport.dart","position":114,"original_position":114,"commit_id":"693677bb98aa58dd05097ba3a275cf0b3da03080","original_commit_id":"693677bb98aa58dd05097ba3a275cf0b3da03080","user":{"login":"doxuanviet1996","id":9079172,"node_id":"MDQ6VXNlcjkwNzkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/9079172?v=4","gravatar_id":"","url":"https://api.github.com/users/doxuanviet1996","html_url":"https://github.com/doxuanviet1996","followers_url":"https://api.github.com/users/doxuanviet1996/followers","following_url":"https://api.github.com/users/doxuanviet1996/following{/other_user}","gists_url":"https://api.github.com/users/doxuanviet1996/gists{/gist_id}","starred_url":"https://api.github.com/users/doxuanviet1996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doxuanviet1996/subscriptions","organizations_url":"https://api.github.com/users/doxuanviet1996/orgs","repos_url":"https://api.github.com/users/doxuanviet1996/repos","events_url":"https://api.github.com/users/doxuanviet1996/events{/privacy}","received_events_url":"https://api.github.com/users/doxuanviet1996/received_events","type":"User","site_admin":false},"body":"Leaving the function outside means I have to pass more arguments to it. Please review after I update the code.","created_at":"2018-07-13T19:56:15Z","updated_at":"2018-07-13T19:56:16Z","html_url":"https://github.com/flutter/flutter/pull/19284#discussion_r202456953","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/19284","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/202456953"},"html":{"href":"https://github.com/flutter/flutter/pull/19284#discussion_r202456953"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/19284"}},"in_reply_to_id":202215766},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/19284","id":200849663,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODQ5NjYz","html_url":"https://github.com/flutter/flutter/pull/19284","diff_url":"https://github.com/flutter/flutter/pull/19284.diff","patch_url":"https://github.com/flutter/flutter/pull/19284.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/19284","number":19284,"state":"open","locked":false,"title":"Adding multicolumn cupertino picker to the Gallery.","user":{"login":"doxuanviet1996","id":9079172,"node_id":"MDQ6VXNlcjkwNzkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/9079172?v=4","gravatar_id":"","url":"https://api.github.com/users/doxuanviet1996","html_url":"https://github.com/doxuanviet1996","followers_url":"https://api.github.com/users/doxuanviet1996/followers","following_url":"https://api.github.com/users/doxuanviet1996/following{/other_user}","gists_url":"https://api.github.com/users/doxuanviet1996/gists{/gist_id}","starred_url":"https://api.github.com/users/doxuanviet1996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doxuanviet1996/subscriptions","organizations_url":"https://api.github.com/users/doxuanviet1996/orgs","repos_url":"https://api.github.com/users/doxuanviet1996/repos","events_url":"https://api.github.com/users/doxuanviet1996/events{/privacy}","received_events_url":"https://api.github.com/users/doxuanviet1996/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-11T23:11:05Z","updated_at":"2018-07-13T19:56:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55e5042b983ec21ddd3d74f2298ff401be4d8c05","assignee":null,"assignees":[],"requested_reviewers":[{"login":"DaveShuckerow","id":14947366,"node_id":"MDQ6VXNlcjE0OTQ3MzY2","avatar_url":"https://avatars2.githubusercontent.com/u/14947366?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveShuckerow","html_url":"https://github.com/DaveShuckerow","followers_url":"https://api.github.com/users/DaveShuckerow/followers","following_url":"https://api.github.com/users/DaveShuckerow/following{/other_user}","gists_url":"https://api.github.com/users/DaveShuckerow/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveShuckerow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveShuckerow/subscriptions","organizations_url":"https://api.github.com/users/DaveShuckerow/orgs","repos_url":"https://api.github.com/users/DaveShuckerow/repos","events_url":"https://api.github.com/users/DaveShuckerow/events{/privacy}","received_events_url":"https://api.github.com/users/DaveShuckerow/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/19284/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/19284/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/19284/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/693677bb98aa58dd05097ba3a275cf0b3da03080","head":{"label":"doxuanviet1996:master","ref":"master","sha":"693677bb98aa58dd05097ba3a275cf0b3da03080","user":{"login":"doxuanviet1996","id":9079172,"node_id":"MDQ6VXNlcjkwNzkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/9079172?v=4","gravatar_id":"","url":"https://api.github.com/users/doxuanviet1996","html_url":"https://github.com/doxuanviet1996","followers_url":"https://api.github.com/users/doxuanviet1996/followers","following_url":"https://api.github.com/users/doxuanviet1996/following{/other_user}","gists_url":"https://api.github.com/users/doxuanviet1996/gists{/gist_id}","starred_url":"https://api.github.com/users/doxuanviet1996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doxuanviet1996/subscriptions","organizations_url":"https://api.github.com/users/doxuanviet1996/orgs","repos_url":"https://api.github.com/users/doxuanviet1996/repos","events_url":"https://api.github.com/users/doxuanviet1996/events{/privacy}","received_events_url":"https://api.github.com/users/doxuanviet1996/received_events","type":"User","site_admin":false},"repo":{"id":140634727,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2MzQ3Mjc=","name":"flutter","full_name":"doxuanviet1996/flutter","owner":{"login":"doxuanviet1996","id":9079172,"node_id":"MDQ6VXNlcjkwNzkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/9079172?v=4","gravatar_id":"","url":"https://api.github.com/users/doxuanviet1996","html_url":"https://github.com/doxuanviet1996","followers_url":"https://api.github.com/users/doxuanviet1996/followers","following_url":"https://api.github.com/users/doxuanviet1996/following{/other_user}","gists_url":"https://api.github.com/users/doxuanviet1996/gists{/gist_id}","starred_url":"https://api.github.com/users/doxuanviet1996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doxuanviet1996/subscriptions","organizations_url":"https://api.github.com/users/doxuanviet1996/orgs","repos_url":"https://api.github.com/users/doxuanviet1996/repos","events_url":"https://api.github.com/users/doxuanviet1996/events{/privacy}","received_events_url":"https://api.github.com/users/doxuanviet1996/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doxuanviet1996/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/doxuanviet1996/flutter","forks_url":"https://api.github.com/repos/doxuanviet1996/flutter/forks","keys_url":"https://api.github.com/repos/doxuanviet1996/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doxuanviet1996/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doxuanviet1996/flutter/teams","hooks_url":"https://api.github.com/repos/doxuanviet1996/flutter/hooks","issue_events_url":"https://api.github.com/repos/doxuanviet1996/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/doxuanviet1996/flutter/events","assignees_url":"https://api.github.com/repos/doxuanviet1996/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/doxuanviet1996/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/doxuanviet1996/flutter/tags","blobs_url":"https://api.github.com/repos/doxuanviet1996/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doxuanviet1996/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doxuanviet1996/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/doxuanviet1996/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doxuanviet1996/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/doxuanviet1996/flutter/languages","stargazers_url":"https://api.github.com/repos/doxuanviet1996/flutter/stargazers","contributors_url":"https://api.github.com/repos/doxuanviet1996/flutter/contributors","subscribers_url":"https://api.github.com/repos/doxuanviet1996/flutter/subscribers","subscription_url":"https://api.github.com/repos/doxuanviet1996/flutter/subscription","commits_url":"https://api.github.com/repos/doxuanviet1996/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/doxuanviet1996/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/doxuanviet1996/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/doxuanviet1996/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/doxuanviet1996/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/doxuanviet1996/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doxuanviet1996/flutter/merges","archive_url":"https://api.github.com/repos/doxuanviet1996/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doxuanviet1996/flutter/downloads","issues_url":"https://api.github.com/repos/doxuanviet1996/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/doxuanviet1996/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/doxuanviet1996/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/doxuanviet1996/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doxuanviet1996/flutter/labels{/name}","releases_url":"https://api.github.com/repos/doxuanviet1996/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/doxuanviet1996/flutter/deployments","created_at":"2018-07-11T22:45:58Z","updated_at":"2018-07-12T23:20:43Z","pushed_at":"2018-07-12T23:20:40Z","git_url":"git://github.com/doxuanviet1996/flutter.git","ssh_url":"git@github.com:doxuanviet1996/flutter.git","clone_url":"https://github.com/doxuanviet1996/flutter.git","svn_url":"https://github.com/doxuanviet1996/flutter","homepage":"https://flutter.io","size":41202,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"7ebf2728dc9173ad63a41aaa4c13e1fcafa51d4a","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-07-13T18:39:32Z","pushed_at":"2018-07-13T19:50:15Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":41211,"stargazers_count":32240,"watchers_count":32240,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2930,"mirror_url":null,"archived":false,"open_issues_count":3551,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2930,"open_issues":3551,"watchers":32240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/19284"},"html":{"href":"https://github.com/flutter/flutter/pull/19284"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/19284"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/19284/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/19284/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/19284/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/693677bb98aa58dd05097ba3a275cf0b3da03080"}},"author_association":"NONE"}}
{"actor":{"display_login":"doxuanviet1996"}}