{"action":"created","comment":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/comments/209898827","pull_request_review_id":145998987,"id":209898827,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTg5ODgyNw==","diff_hunk":"@@ -98,95 +109,119 @@ if [[ \"$CONFIRM\" != \"y\" ]]; then\n     exit 1\n fi\n \n-# Make a new detached HEAD\n git checkout \"$BRANCH\"\n git pull\n-git checkout --detach\n-\n-# Edit package.json to the right version (see\n-# http://stackoverflow.com/a/22084103 for why we need the .bak file to make\n-# this mac & linux compatible)\n-sed -i.bak -E 's|\"version\": \"[^\"]+\",|\"version\": \"'$VERSION'\",|' package.json\n-rm -f package.json.bak\n-\n-# Build generated files and add them to the repository\n-git clean -fdx dist\n-yarn dist\n-sed -i.bak -E '/^\\/dist\\/$/d' .gitignore\n-rm -f .gitignore.bak\n-git add .gitignore dist/\n-\n-# Edit docs to use CSS from CDN\n-grep -l '{@stylesheet: katex.min.css}' docs/*.md | xargs sed -i.bak \\\n-    's|{@stylesheet: katex.min.css}|<link rel=\"stylesheet\" href=\"https://cdn.jsdelivr.net/npm/katex@./dist/katex.min.css\" integrity=\"sha384-katex.min.css\" crossorigin=\"anonymous\"/>|'\n-\n-# Update the version number in CDN URLs included in the README and the documentation,\n-# and regenerate the Subresource Integrity hash for these files.\n-node update-sri.js \"${VERSION}\" README.md contrib/*/README.md dist/README.md \\\n-    docs/*.md docs/*.md.bak website/pages/index.html\n-\n-# Generate a new version of the docs and publish the website\n-pushd website\n-yarn run version \"${VERSION}\"\n-\n-# Restore docs to use local built CSS\n-for file in ../docs/*.md.bak; do\n-    mv -f \"$file\" \"${file%.bak}\"\n-done\n \n-USE_SSH=true yarn publish-gh-pages\n-popd\n+if [[ $BRANCH != \"master\" ]]; then\n+    # Build generated files\n+    yarn build","path":"release.sh","position":116,"original_position":116,"commit_id":"bd92a449a1efc90eed7b0d114fcc44998c068bdb","original_commit_id":"bd92a449a1efc90eed7b0d114fcc44998c068bdb","user":{"login":"ylemkimon","id":888148,"node_id":"MDQ6VXNlcjg4ODE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/888148?v=4","gravatar_id":"","url":"https://api.github.com/users/ylemkimon","html_url":"https://github.com/ylemkimon","followers_url":"https://api.github.com/users/ylemkimon/followers","following_url":"https://api.github.com/users/ylemkimon/following{/other_user}","gists_url":"https://api.github.com/users/ylemkimon/gists{/gist_id}","starred_url":"https://api.github.com/users/ylemkimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylemkimon/subscriptions","organizations_url":"https://api.github.com/users/ylemkimon/orgs","repos_url":"https://api.github.com/users/ylemkimon/repos","events_url":"https://api.github.com/users/ylemkimon/events{/privacy}","received_events_url":"https://api.github.com/users/ylemkimon/received_events","type":"User","site_admin":false},"body":"@edemaine `set -e -o pipefail` is set and the script will fail if any command returns non-zero.","created_at":"2018-08-14T10:13:03Z","updated_at":"2018-08-14T10:13:03Z","html_url":"https://github.com/Khan/KaTeX/pull/1603#discussion_r209898827","pull_request_url":"https://api.github.com/repos/Khan/KaTeX/pulls/1603","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/comments/209898827"},"html":{"href":"https://github.com/Khan/KaTeX/pull/1603#discussion_r209898827"},"pull_request":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/1603"}},"in_reply_to_id":209891859},"pull_request":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/1603","id":207824555,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODI0NTU1","html_url":"https://github.com/Khan/KaTeX/pull/1603","diff_url":"https://github.com/Khan/KaTeX/pull/1603.diff","patch_url":"https://github.com/Khan/KaTeX/pull/1603.patch","issue_url":"https://api.github.com/repos/Khan/KaTeX/issues/1603","number":1603,"state":"open","locked":false,"title":"Update release script to use pull request","user":{"login":"ylemkimon","id":888148,"node_id":"MDQ6VXNlcjg4ODE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/888148?v=4","gravatar_id":"","url":"https://api.github.com/users/ylemkimon","html_url":"https://github.com/ylemkimon","followers_url":"https://api.github.com/users/ylemkimon/followers","following_url":"https://api.github.com/users/ylemkimon/following{/other_user}","gists_url":"https://api.github.com/users/ylemkimon/gists{/gist_id}","starred_url":"https://api.github.com/users/ylemkimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylemkimon/subscriptions","organizations_url":"https://api.github.com/users/ylemkimon/orgs","repos_url":"https://api.github.com/users/ylemkimon/repos","events_url":"https://api.github.com/users/ylemkimon/events{/privacy}","received_events_url":"https://api.github.com/users/ylemkimon/received_events","type":"User","site_admin":false},"body":"Fixes #1428\r\n\r\nNew release process consists of two steps:\r\n\r\n* Release (`./release.sh <VERSION_TO_RELEASE> [NEXT_VERSION]`)\r\n  * Make a release branch(`v<VERSION_TO_RELEASE>-release`)\r\n  * Build generated files\r\n  * Edit package.json to the next version\r\n  * Edit docs to use CSS from CDN\r\n  * Update the version number in the README and the documentation, and regenerate the SRI hash\r\n  * Generate a new version of the docs\r\n  * Make a commit and push\r\n  * **[manual]** Open a pull request\r\n\r\nIf KaTeX codes get changed during PR review, update SRI hashes by `./release.sh <VERSION_TO_RELEASE>` on the generated release branch.\r\n\r\nAfter the PR gets merged:\r\n* Publish (`./release.sh -p <VERSION_TO_RELEASE>`)\r\n  * Make a new detached HEAD\r\n  * Edit package.json to the release version\r\n  * Build generated files\r\n  * Make the commit and tag, and push them\r\n  * Publish to NPM and GitHub pages\r\n  * **[manual]** Create a GitHub release","created_at":"2018-08-12T14:43:47Z","updated_at":"2018-08-14T10:13:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"372ae290bdbaa021619ab81fc48b056516711976","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kevinbarabash","id":1044413,"node_id":"MDQ6VXNlcjEwNDQ0MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1044413?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinbarabash","html_url":"https://github.com/kevinbarabash","followers_url":"https://api.github.com/users/kevinbarabash/followers","following_url":"https://api.github.com/users/kevinbarabash/following{/other_user}","gists_url":"https://api.github.com/users/kevinbarabash/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbarabash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbarabash/subscriptions","organizations_url":"https://api.github.com/users/kevinbarabash/orgs","repos_url":"https://api.github.com/users/kevinbarabash/repos","events_url":"https://api.github.com/users/kevinbarabash/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbarabash/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Khan/KaTeX/pulls/1603/commits","review_comments_url":"https://api.github.com/repos/Khan/KaTeX/pulls/1603/comments","review_comment_url":"https://api.github.com/repos/Khan/KaTeX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Khan/KaTeX/issues/1603/comments","statuses_url":"https://api.github.com/repos/Khan/KaTeX/statuses/bd92a449a1efc90eed7b0d114fcc44998c068bdb","head":{"label":"ylemkimon:release-script","ref":"release-script","sha":"bd92a449a1efc90eed7b0d114fcc44998c068bdb","user":{"login":"ylemkimon","id":888148,"node_id":"MDQ6VXNlcjg4ODE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/888148?v=4","gravatar_id":"","url":"https://api.github.com/users/ylemkimon","html_url":"https://github.com/ylemkimon","followers_url":"https://api.github.com/users/ylemkimon/followers","following_url":"https://api.github.com/users/ylemkimon/following{/other_user}","gists_url":"https://api.github.com/users/ylemkimon/gists{/gist_id}","starred_url":"https://api.github.com/users/ylemkimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylemkimon/subscriptions","organizations_url":"https://api.github.com/users/ylemkimon/orgs","repos_url":"https://api.github.com/users/ylemkimon/repos","events_url":"https://api.github.com/users/ylemkimon/events{/privacy}","received_events_url":"https://api.github.com/users/ylemkimon/received_events","type":"User","site_admin":false},"repo":{"id":108306065,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzMDYwNjU=","name":"KaTeX","full_name":"ylemkimon/KaTeX","owner":{"login":"ylemkimon","id":888148,"node_id":"MDQ6VXNlcjg4ODE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/888148?v=4","gravatar_id":"","url":"https://api.github.com/users/ylemkimon","html_url":"https://github.com/ylemkimon","followers_url":"https://api.github.com/users/ylemkimon/followers","following_url":"https://api.github.com/users/ylemkimon/following{/other_user}","gists_url":"https://api.github.com/users/ylemkimon/gists{/gist_id}","starred_url":"https://api.github.com/users/ylemkimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylemkimon/subscriptions","organizations_url":"https://api.github.com/users/ylemkimon/orgs","repos_url":"https://api.github.com/users/ylemkimon/repos","events_url":"https://api.github.com/users/ylemkimon/events{/privacy}","received_events_url":"https://api.github.com/users/ylemkimon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ylemkimon/KaTeX","description":"Fast math typesetting for the web.","fork":true,"url":"https://api.github.com/repos/ylemkimon/KaTeX","forks_url":"https://api.github.com/repos/ylemkimon/KaTeX/forks","keys_url":"https://api.github.com/repos/ylemkimon/KaTeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ylemkimon/KaTeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ylemkimon/KaTeX/teams","hooks_url":"https://api.github.com/repos/ylemkimon/KaTeX/hooks","issue_events_url":"https://api.github.com/repos/ylemkimon/KaTeX/issues/events{/number}","events_url":"https://api.github.com/repos/ylemkimon/KaTeX/events","assignees_url":"https://api.github.com/repos/ylemkimon/KaTeX/assignees{/user}","branches_url":"https://api.github.com/repos/ylemkimon/KaTeX/branches{/branch}","tags_url":"https://api.github.com/repos/ylemkimon/KaTeX/tags","blobs_url":"https://api.github.com/repos/ylemkimon/KaTeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ylemkimon/KaTeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ylemkimon/KaTeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/ylemkimon/KaTeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ylemkimon/KaTeX/statuses/{sha}","languages_url":"https://api.github.com/repos/ylemkimon/KaTeX/languages","stargazers_url":"https://api.github.com/repos/ylemkimon/KaTeX/stargazers","contributors_url":"https://api.github.com/repos/ylemkimon/KaTeX/contributors","subscribers_url":"https://api.github.com/repos/ylemkimon/KaTeX/subscribers","subscription_url":"https://api.github.com/repos/ylemkimon/KaTeX/subscription","commits_url":"https://api.github.com/repos/ylemkimon/KaTeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/ylemkimon/KaTeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/ylemkimon/KaTeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/ylemkimon/KaTeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/ylemkimon/KaTeX/contents/{+path}","compare_url":"https://api.github.com/repos/ylemkimon/KaTeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ylemkimon/KaTeX/merges","archive_url":"https://api.github.com/repos/ylemkimon/KaTeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ylemkimon/KaTeX/downloads","issues_url":"https://api.github.com/repos/ylemkimon/KaTeX/issues{/number}","pulls_url":"https://api.github.com/repos/ylemkimon/KaTeX/pulls{/number}","milestones_url":"https://api.github.com/repos/ylemkimon/KaTeX/milestones{/number}","notifications_url":"https://api.github.com/repos/ylemkimon/KaTeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ylemkimon/KaTeX/labels{/name}","releases_url":"https://api.github.com/repos/ylemkimon/KaTeX/releases{/id}","deployments_url":"https://api.github.com/repos/ylemkimon/KaTeX/deployments","created_at":"2017-10-25T17:59:21Z","updated_at":"2018-08-11T14:41:47Z","pushed_at":"2018-08-14T04:52:29Z","git_url":"git://github.com/ylemkimon/KaTeX.git","ssh_url":"git@github.com:ylemkimon/KaTeX.git","clone_url":"https://github.com/ylemkimon/KaTeX.git","svn_url":"https://github.com/ylemkimon/KaTeX","homepage":"https://khan.github.io/KaTeX/","size":27101,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Khan:master","ref":"master","sha":"51bf3fa6f51f566fdf6c6f1ee900e7f986014a80","user":{"login":"Khan","id":15455,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDU1","avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":11195700,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE5NTcwMA==","name":"KaTeX","full_name":"Khan/KaTeX","owner":{"login":"Khan","id":15455,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDU1","avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/KaTeX","description":"Fast math typesetting for the web.","fork":false,"url":"https://api.github.com/repos/Khan/KaTeX","forks_url":"https://api.github.com/repos/Khan/KaTeX/forks","keys_url":"https://api.github.com/repos/Khan/KaTeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/KaTeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/KaTeX/teams","hooks_url":"https://api.github.com/repos/Khan/KaTeX/hooks","issue_events_url":"https://api.github.com/repos/Khan/KaTeX/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/KaTeX/events","assignees_url":"https://api.github.com/repos/Khan/KaTeX/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/KaTeX/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/KaTeX/tags","blobs_url":"https://api.github.com/repos/Khan/KaTeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/KaTeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/KaTeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/KaTeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/KaTeX/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/KaTeX/languages","stargazers_url":"https://api.github.com/repos/Khan/KaTeX/stargazers","contributors_url":"https://api.github.com/repos/Khan/KaTeX/contributors","subscribers_url":"https://api.github.com/repos/Khan/KaTeX/subscribers","subscription_url":"https://api.github.com/repos/Khan/KaTeX/subscription","commits_url":"https://api.github.com/repos/Khan/KaTeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/KaTeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/KaTeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/KaTeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/Khan/KaTeX/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/KaTeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/KaTeX/merges","archive_url":"https://api.github.com/repos/Khan/KaTeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/KaTeX/downloads","issues_url":"https://api.github.com/repos/Khan/KaTeX/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/KaTeX/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/KaTeX/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/KaTeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/KaTeX/labels{/name}","releases_url":"https://api.github.com/repos/Khan/KaTeX/releases{/id}","deployments_url":"https://api.github.com/repos/Khan/KaTeX/deployments","created_at":"2013-07-05T09:01:54Z","updated_at":"2018-08-14T09:41:38Z","pushed_at":"2018-08-14T08:20:10Z","git_url":"git://github.com/Khan/KaTeX.git","ssh_url":"git@github.com:Khan/KaTeX.git","clone_url":"https://github.com/Khan/KaTeX.git","svn_url":"https://github.com/Khan/KaTeX","homepage":"https://khan.github.io/KaTeX/","size":30215,"stargazers_count":8703,"watchers_count":8703,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":595,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":595,"open_issues":167,"watchers":8703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/1603"},"html":{"href":"https://github.com/Khan/KaTeX/pull/1603"},"issue":{"href":"https://api.github.com/repos/Khan/KaTeX/issues/1603"},"comments":{"href":"https://api.github.com/repos/Khan/KaTeX/issues/1603/comments"},"review_comments":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/1603/comments"},"review_comment":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/1603/commits"},"statuses":{"href":"https://api.github.com/repos/Khan/KaTeX/statuses/bd92a449a1efc90eed7b0d114fcc44998c068bdb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ylemkimon"}}