{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/166708027","pull_request_review_id":94809233,"id":166708027,"diff_hunk":"@@ -421,33 +424,50 @@ std::string expr2ct::convert_rec(\n   else if(src.id()==ID_c_enum_tag)\n   {\n     const c_enum_tag_typet &c_enum_tag_type=to_c_enum_tag_type(src);\n-    const symbolt &symbol=ns.lookup(c_enum_tag_type);\n     std::string result=q+\"enum\";\n-    result+=\" \"+id2string(symbol.base_name);\n+    if(ns)\n+    {\n+      const symbolt &symbol = ns->get().lookup(c_enum_tag_type);\n+      result += \" \" + id2string(symbol.base_name);\n+    }\n+    else\n+      result += \" \" + id2string(c_enum_tag_type.get(ID_identifier));\n     result+=d;\n     return result;\n   }\n   else if(src.id()==ID_pointer)\n   {\n     c_qualifierst sub_qualifiers;\n     sub_qualifiers.read(src.subtype());\n-    const typet &subtype_followed=ns.follow(src.subtype());","path":"src/ansi-c/expr2c.cpp","position":94,"original_position":94,"commit_id":"01b334bd80ec372c1a9bc7964dd9eb0d1e86c898","original_commit_id":"01b334bd80ec372c1a9bc7964dd9eb0d1e86c898","user":{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars3.githubusercontent.com/u/1144736?v=4","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},"body":"This `ns.follow` is actually unnecessary as none of the cases considered below would result in a symbol type. (This was different some time in the past, but now is restricted to structs.)","created_at":"2018-02-07T18:18:40Z","updated_at":"2018-02-07T18:37:46Z","html_url":"https://github.com/diffblue/cbmc/pull/1809#discussion_r166708027","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1809","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/166708027"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1809#discussion_r166708027"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1809"}}},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/1809","id":167731291,"html_url":"https://github.com/diffblue/cbmc/pull/1809","diff_url":"https://github.com/diffblue/cbmc/pull/1809.diff","patch_url":"https://github.com/diffblue/cbmc/pull/1809.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/1809","number":1809,"state":"open","locked":false,"title":"Fix printing of annotations (and much else) using --show-parse-tree","user":{"login":"NathanJPhillips","id":1928141,"avatar_url":"https://avatars0.githubusercontent.com/u/1928141?v=4","gravatar_id":"","url":"https://api.github.com/users/NathanJPhillips","html_url":"https://github.com/NathanJPhillips","followers_url":"https://api.github.com/users/NathanJPhillips/followers","following_url":"https://api.github.com/users/NathanJPhillips/following{/other_user}","gists_url":"https://api.github.com/users/NathanJPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanJPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanJPhillips/subscriptions","organizations_url":"https://api.github.com/users/NathanJPhillips/orgs","repos_url":"https://api.github.com/users/NathanJPhillips/repos","events_url":"https://api.github.com/users/NathanJPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/NathanJPhillips/received_events","type":"User","site_admin":false},"body":"This is done before the programme is converted so there is no symbol table to pass to expr2java/type2java\r\nAllow expr2ct and expr2javat to work in the absence of a symbol table","created_at":"2018-02-07T15:52:45Z","updated_at":"2018-02-07T18:37:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61a9b000e0f6028d0f80d6119b9ad09312fe528d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cesaro","id":143977,"avatar_url":"https://avatars1.githubusercontent.com/u/143977?v=4","gravatar_id":"","url":"https://api.github.com/users/cesaro","html_url":"https://github.com/cesaro","followers_url":"https://api.github.com/users/cesaro/followers","following_url":"https://api.github.com/users/cesaro/following{/other_user}","gists_url":"https://api.github.com/users/cesaro/gists{/gist_id}","starred_url":"https://api.github.com/users/cesaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesaro/subscriptions","organizations_url":"https://api.github.com/users/cesaro/orgs","repos_url":"https://api.github.com/users/cesaro/repos","events_url":"https://api.github.com/users/cesaro/events{/privacy}","received_events_url":"https://api.github.com/users/cesaro/received_events","type":"User","site_admin":false},{"login":"smowton","id":283483,"avatar_url":"https://avatars3.githubusercontent.com/u/283483?v=4","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},{"login":"kroening","id":1830565,"avatar_url":"https://avatars0.githubusercontent.com/u/1830565?v=4","gravatar_id":"","url":"https://api.github.com/users/kroening","html_url":"https://github.com/kroening","followers_url":"https://api.github.com/users/kroening/followers","following_url":"https://api.github.com/users/kroening/following{/other_user}","gists_url":"https://api.github.com/users/kroening/gists{/gist_id}","starred_url":"https://api.github.com/users/kroening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroening/subscriptions","organizations_url":"https://api.github.com/users/kroening/orgs","repos_url":"https://api.github.com/users/kroening/repos","events_url":"https://api.github.com/users/kroening/events{/privacy}","received_events_url":"https://api.github.com/users/kroening/received_events","type":"User","site_admin":false},{"login":"mgudemann","id":2590540,"avatar_url":"https://avatars0.githubusercontent.com/u/2590540?v=4","gravatar_id":"","url":"https://api.github.com/users/mgudemann","html_url":"https://github.com/mgudemann","followers_url":"https://api.github.com/users/mgudemann/followers","following_url":"https://api.github.com/users/mgudemann/following{/other_user}","gists_url":"https://api.github.com/users/mgudemann/gists{/gist_id}","starred_url":"https://api.github.com/users/mgudemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgudemann/subscriptions","organizations_url":"https://api.github.com/users/mgudemann/orgs","repos_url":"https://api.github.com/users/mgudemann/repos","events_url":"https://api.github.com/users/mgudemann/events{/privacy}","received_events_url":"https://api.github.com/users/mgudemann/received_events","type":"User","site_admin":false},{"login":"peterschrammel","id":4222448,"avatar_url":"https://avatars3.githubusercontent.com/u/4222448?v=4","gravatar_id":"","url":"https://api.github.com/users/peterschrammel","html_url":"https://github.com/peterschrammel","followers_url":"https://api.github.com/users/peterschrammel/followers","following_url":"https://api.github.com/users/peterschrammel/following{/other_user}","gists_url":"https://api.github.com/users/peterschrammel/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschrammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschrammel/subscriptions","organizations_url":"https://api.github.com/users/peterschrammel/orgs","repos_url":"https://api.github.com/users/peterschrammel/repos","events_url":"https://api.github.com/users/peterschrammel/events{/privacy}","received_events_url":"https://api.github.com/users/peterschrammel/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1809/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1809/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/1809/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/01b334bd80ec372c1a9bc7964dd9eb0d1e86c898","head":{"label":"NathanJPhillips:bugfix/show-parse-tree","ref":"bugfix/show-parse-tree","sha":"01b334bd80ec372c1a9bc7964dd9eb0d1e86c898","user":{"login":"NathanJPhillips","id":1928141,"avatar_url":"https://avatars0.githubusercontent.com/u/1928141?v=4","gravatar_id":"","url":"https://api.github.com/users/NathanJPhillips","html_url":"https://github.com/NathanJPhillips","followers_url":"https://api.github.com/users/NathanJPhillips/followers","following_url":"https://api.github.com/users/NathanJPhillips/following{/other_user}","gists_url":"https://api.github.com/users/NathanJPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanJPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanJPhillips/subscriptions","organizations_url":"https://api.github.com/users/NathanJPhillips/orgs","repos_url":"https://api.github.com/users/NathanJPhillips/repos","events_url":"https://api.github.com/users/NathanJPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/NathanJPhillips/received_events","type":"User","site_admin":false},"repo":{"id":78628214,"name":"cbmc","full_name":"NathanJPhillips/cbmc","owner":{"login":"NathanJPhillips","id":1928141,"avatar_url":"https://avatars0.githubusercontent.com/u/1928141?v=4","gravatar_id":"","url":"https://api.github.com/users/NathanJPhillips","html_url":"https://github.com/NathanJPhillips","followers_url":"https://api.github.com/users/NathanJPhillips/followers","following_url":"https://api.github.com/users/NathanJPhillips/following{/other_user}","gists_url":"https://api.github.com/users/NathanJPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanJPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanJPhillips/subscriptions","organizations_url":"https://api.github.com/users/NathanJPhillips/orgs","repos_url":"https://api.github.com/users/NathanJPhillips/repos","events_url":"https://api.github.com/users/NathanJPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/NathanJPhillips/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NathanJPhillips/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/NathanJPhillips/cbmc","forks_url":"https://api.github.com/repos/NathanJPhillips/cbmc/forks","keys_url":"https://api.github.com/repos/NathanJPhillips/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NathanJPhillips/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NathanJPhillips/cbmc/teams","hooks_url":"https://api.github.com/repos/NathanJPhillips/cbmc/hooks","issue_events_url":"https://api.github.com/repos/NathanJPhillips/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/NathanJPhillips/cbmc/events","assignees_url":"https://api.github.com/repos/NathanJPhillips/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/NathanJPhillips/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/NathanJPhillips/cbmc/tags","blobs_url":"https://api.github.com/repos/NathanJPhillips/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NathanJPhillips/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NathanJPhillips/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/NathanJPhillips/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NathanJPhillips/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/NathanJPhillips/cbmc/languages","stargazers_url":"https://api.github.com/repos/NathanJPhillips/cbmc/stargazers","contributors_url":"https://api.github.com/repos/NathanJPhillips/cbmc/contributors","subscribers_url":"https://api.github.com/repos/NathanJPhillips/cbmc/subscribers","subscription_url":"https://api.github.com/repos/NathanJPhillips/cbmc/subscription","commits_url":"https://api.github.com/repos/NathanJPhillips/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/NathanJPhillips/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/NathanJPhillips/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/NathanJPhillips/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/NathanJPhillips/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/NathanJPhillips/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NathanJPhillips/cbmc/merges","archive_url":"https://api.github.com/repos/NathanJPhillips/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NathanJPhillips/cbmc/downloads","issues_url":"https://api.github.com/repos/NathanJPhillips/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/NathanJPhillips/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/NathanJPhillips/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/NathanJPhillips/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NathanJPhillips/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/NathanJPhillips/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/NathanJPhillips/cbmc/deployments","created_at":"2017-01-11T10:27:50Z","updated_at":"2017-01-11T10:28:00Z","pushed_at":"2018-02-07T15:56:55Z","git_url":"git://github.com/NathanJPhillips/cbmc.git","ssh_url":"git@github.com:NathanJPhillips/cbmc.git","clone_url":"https://github.com/NathanJPhillips/cbmc.git","svn_url":"https://github.com/NathanJPhillips/cbmc","homepage":"http://www.cprover.org/cbmc","size":25781,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diffblue:develop","ref":"develop","sha":"fbcb4238c488145e517e5e51de54ffa9c0980c65","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2018-02-06T19:52:55Z","pushed_at":"2018-02-07T16:58:01Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":27762,"stargazers_count":96,"watchers_count":96,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":310,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":86,"open_issues":310,"watchers":96,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1809"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1809"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1809"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1809/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1809/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1809/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/01b334bd80ec372c1a9bc7964dd9eb0d1e86c898"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tautschnig"}}