{"action":"created","issue":{"url":"https://api.github.com/repos/jgyates/genmon/issues/64","repository_url":"https://api.github.com/repos/jgyates/genmon","labels_url":"https://api.github.com/repos/jgyates/genmon/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/jgyates/genmon/issues/64/comments","events_url":"https://api.github.com/repos/jgyates/genmon/issues/64/events","html_url":"https://github.com/jgyates/genmon/issues/64","id":286589788,"number":64,"title":"Add JSON support?","user":{"login":"madisdev","id":17501399,"avatar_url":"https://avatars2.githubusercontent.com/u/17501399?v=4","gravatar_id":"","url":"https://api.github.com/users/madisdev","html_url":"https://github.com/madisdev","followers_url":"https://api.github.com/users/madisdev/followers","following_url":"https://api.github.com/users/madisdev/following{/other_user}","gists_url":"https://api.github.com/users/madisdev/gists{/gist_id}","starred_url":"https://api.github.com/users/madisdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madisdev/subscriptions","organizations_url":"https://api.github.com/users/madisdev/orgs","repos_url":"https://api.github.com/users/madisdev/repos","events_url":"https://api.github.com/users/madisdev/events{/privacy}","received_events_url":"https://api.github.com/users/madisdev/received_events","type":"User","site_admin":false},"labels":[{"id":563850594,"url":"https://api.github.com/repos/jgyates/genmon/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-01-07T18:45:38Z","updated_at":"2018-03-03T02:17:50Z","closed_at":null,"author_association":"COLLABORATOR","body":"Jason,\r\n\r\nDid you ever consider returning data from genmon in a more structured format, specifically JSON? I think it might open up the app a little more for consumption from other clients. I think it also might make modifications to the webpage a little easier.\r\n\r\nI looked at the code and it seems like its pretty baked in how you build the strings, but I don't think its impossible to add an option to return JSON.\r\n\r\nI'm not asking you todo the work, just want your opinion. Thanks.\r\n\r\nPS I think we could also add a PI CPU temp measurement to the webpage, to monitor how frozen our generators are getting."},"comment":{"url":"https://api.github.com/repos/jgyates/genmon/issues/comments/370108339","html_url":"https://github.com/jgyates/genmon/issues/64#issuecomment-370108339","issue_url":"https://api.github.com/repos/jgyates/genmon/issues/64","id":370108339,"user":{"login":"proppilot","id":33790842,"avatar_url":"https://avatars2.githubusercontent.com/u/33790842?v=4","gravatar_id":"","url":"https://api.github.com/users/proppilot","html_url":"https://github.com/proppilot","followers_url":"https://api.github.com/users/proppilot/followers","following_url":"https://api.github.com/users/proppilot/following{/other_user}","gists_url":"https://api.github.com/users/proppilot/gists{/gist_id}","starred_url":"https://api.github.com/users/proppilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proppilot/subscriptions","organizations_url":"https://api.github.com/users/proppilot/orgs","repos_url":"https://api.github.com/users/proppilot/repos","events_url":"https://api.github.com/users/proppilot/events{/privacy}","received_events_url":"https://api.github.com/users/proppilot/received_events","type":"User","site_admin":false},"created_at":"2018-03-03T02:17:49Z","updated_at":"2018-03-03T02:17:49Z","author_association":"NONE","body":"Hi Jason,  there have been some terrific upgrades and development done.\nWith a stable platform (including wifi link break detection and restart) I\nnow have 39 solid days of running so I am (quite) a bit gun shy to mess with\nsuccess.  I know you have posted some updates on how to do the update so my\nquestion is this.  Is there an easy way to clone the SD card that is in my\nPI and then pop in the clone and play with it with a backup (revert to the\noriginal SD card should I mess it up ?  Is it a simple copy of all files (I\nam on a MAC platform) or are there hidden files that need special handling ?\nSorry, a bit off topic but maybe an interesting topic for others Leary to\nmess with a stable operating GENMON !\n\nFrom:  jgyates <notifications@github.com>\nReply-To:  jgyates/genmon\n<reply+02039b7a53fe7a2f9beca3ba7dd39778d5932c7bf5442fe492cf0000000116b1c42d9\n2a169ce1115035c@reply.github.com>\nDate:  Friday, March 2, 2018 at 9:02 PM\nTo:  jgyates/genmon <genmon@noreply.github.com>\nCc:  Anthony Varga <tonyvarga@mail.com>, Comment\n<comment@noreply.github.com>\nSubject:  Re: [jgyates/genmon] Add JSON support? (#64)\n\n\nOK. I have completed the JSON support in genmon and genserv. It is checked\nin and I tagged a new release. I added a new page to the web UI that uses\nJSON. The link to the new page is at the bottom of the web UI page. The new\npage is mostly just for debugging / reverse engineering functionality so I\nmade it low profile. It displays the registers of the generator and\nhighlights changes in the registers as they occur. The new page is not the\nbest looking thing to look at, but it is useful for technical reasons. Once\nyou install the update you can reach the new page by the link at the bottom\nof the web UI labled \"Generator Registers\".\n\nImplementing this gave me a chance to clean up some of the code that deals\nwith string parsing and output. Now most data that was output was just a lot\nof string manipulation. Now the data is stored in python dictionaries and\neither converted to strings or JSON before outputting, which is easier to\nmaintain and better interoperability, so thanks for making this feature\nrequest.\n\nI am not 100% convinced we need to update the web interface to fully use\nJSON just yet, but I am open to ideas if anyone has any. In general the web\ninterface is fairly easy to maintain now. If JSON can make this easy to\nmaintain and not complicate the setup for people then I am all for it.\n\nLet me know if anyone has any issues with the new release or questions on\nthe JSON implementation.\n\n\nYou are receiving this because you commented.\nReply to this email directly, view it on GitHub\n<https://github.com/jgyates/genmon/issues/64#issuecomment-370107100> , or\nmute the thread \n<https://github.com/notifications/unsubscribe-auth/AgObejtWht9L5se--FKRFD1jx\nTcAuytpks5tafmtgaJpZM4RVvh0> .\n\n  \n{\"api_version\":\"1.0\",\"publisher\":{\"api_key\":\"05dde50f1d1a384dd78767c55493e4b\nb\",\"name\":\"GitHub\"},\"entity\":{\"external_key\":\"github/jgyates/genmon\",\"title\"\n:\"jgyates/genmon\",\"subtitle\":\"GitHub\nrepository\",\"main_image_url\":\"https://cloud.githubusercontent.com/assets/143\n418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png\",\"avatar_image_url\":\"h\nttps://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6\n-9aed-b52498112777.png\",\"action\":{\"name\":\"Open in\nGitHub\",\"url\":\"https://github.com/jgyates/genmon\"}},\"updates\":{\"snippets\":[{\n\"icon\":\"PERSON\",\"message\":\"@jgyates in #64: OK. I have completed the JSON\nsupport in genmon and genserv. It is checked in and I tagged a new release.\nI added a new page to the web UI that uses JSON. The link to the new page is\nat the bottom of the web UI page. The new page is mostly just for debugging\n/ reverse engineering functionality so I made it low profile. It displays\nthe registers of the generator and highlights changes in the registers as\nthey occur. The new page is not the best looking thing to look at, but it is\nuseful for technical reasons. Once you install the update you can reach the\nnew page by the link at the bottom of the web UI labled \\\"Generator\nRegisters\\\".\\r\\n\\r\\nImplementing this gave me a chance to clean up some of\nthe code that deals with string parsing and output. Now most data that was\noutput was just a lot of string manipulation. Now the data is stored in\npython dictionaries and either converted to strings or JSON before\noutputting, which is easier to maintain and better interoperability, so\nthanks for making this feature request.\\r\\n\\r\\nI am not 100% convinced we\nneed to update the web interface to fully use JSON just yet, but I am open\nto ideas if anyone has any. In general the web interface is fairly easy to\nmaintain now. If JSON can make this easy to maintain and not complicate the\nsetup for people then I am all for it. \\r\\n\\r\\nLet me know if anyone has any\nissues with the new release or questions on the JSON\nimplementation.\\r\\n\\r\\n\"}],\"action\":{\"name\":\"View\nIssue\",\"url\":\"https://github.com/jgyates/genmon/issues/64#issuecomment-37010\n7100\"}}}\n\n"}}
{"actor":{"display_login":"proppilot"}}