{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/24733","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/24733/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24733/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/24733/events","html_url":"https://github.com/nodejs/node/pull/24733","id":385954197,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODA4MTIy","number":24733,"title":"test/document TLS authentication, then add support for TRUSTED CERTIFICATE pem headers","user":{"login":"sam-github","id":17607,"node_id":"MDQ6VXNlcjE3NjA3","avatar_url":"https://avatars2.githubusercontent.com/u/17607?v=4","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"labels":[{"id":169485478,"node_id":"MDU6TGFiZWwxNjk0ODU0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0","default":false},{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false},{"id":155267349,"node_id":"MDU6TGFiZWwxNTUyNjczNDk=","url":"https://api.github.com/repos/nodejs/node/labels/tls","name":"tls","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-11-29T22:27:30Z","updated_at":"2018-12-11T20:31:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24733","html_url":"https://github.com/nodejs/node/pull/24733","diff_url":"https://github.com/nodejs/node/pull/24733.diff","patch_url":"https://github.com/nodejs/node/pull/24733.patch"},"body":"TLS client authentication should be tested, including failure scenarios.\r\n\r\nThere were tests for a couple success scenarios as side-effects of testing other things, but little coverage for the various ways intermediate and root CAs can be configured.\r\n\r\nSupport the same PEM certificate formats for the ca: option to\r\ntls.createSecureContext() that are supported by openssl when loading a\r\nCAfile.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/446351030","html_url":"https://github.com/nodejs/node/pull/24733#issuecomment-446351030","issue_url":"https://api.github.com/repos/nodejs/node/issues/24733","id":446351030,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjM1MTAzMA==","user":{"login":"sam-github","id":17607,"node_id":"MDQ6VXNlcjE3NjA3","avatar_url":"https://avatars2.githubusercontent.com/u/17607?v=4","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T20:31:09Z","updated_at":"2018-12-11T20:31:09Z","author_association":"MEMBER","body":"The only failures were test-cli-syntax.js, which is flaky. I'm re-running ci, but I think this is landable.\r\n\r\nre-ci: https://ci.nodejs.org/job/node-test-commit/24210/"}}
{"actor":{"display_login":"sam-github"}}