{"push_id":2822889963,"size":1,"distinct_size":1,"ref":"refs/heads/dont-emit-alter-owner-for-predefined-language","head":"d1f71ee687b052cdb640df9f8d2a4d5fec973b0c","before":"d5e010e0026dfceabd25078ab28ba4ded5797a98","commits":[{"sha":"d1f71ee687b052cdb640df9f8d2a4d5fec973b0c","author":{"name":"Heikki Linnakangas","email":"9304c20251d03f4d84fc732cc8196e9ef6638e64@pivotal.io"},"message":"Don't emit extra ALTER FUNCTION OWNER TO commands after CREATE LANGUAGE.\n\nIn pg_dump, we had a GPDB-specific hack to change the owners of the\nhandler and validator functions of the language, after dumping the CREATE\nLANGUAGE command. This was added back in 2008, with commit message:\n\n    MPP-3774: Change pg_dump to emit ALTER FUNCTION ... OWNER statements\n    for functions underlying created languages for languages defined\n    using pg_pltemplate-specified languages.\n\nI looked into MPP-3774, but I couldn't make much sense of it.\n\nTitle:\n    pg_dumpall doesn't dump Language function owners\nDescription:\n    pg_dumpall doesn't dump the permissions for the CREATE LANGUAGE. need to\n    modify the function owners. so ALTER FUNCTION ... OWNER TO ...\n\nPostgreSQL never had that code. I don't think it is relevant anymore,\nthere's been a lot of change in the way languages are handled. Firstly,\nthey are usually created as part of extensions, these days, so the\n\"language template\" mechanism is obsolete. Secondly, when this change was\nmade in GPDB, languages didn't have owners. That was added later.\n\nAll in all, I don't think this is needed anymore, so remove it, and dump\nlanguages and their functions just like in the upstream.\n\nPS. If this was still valid and needed, I think we'd also need to emit the\nALTER FUNCTION commands for the 'laninline' function.","distinct":true,"url":"https://api.github.com/repos/hlinnaka/gpdb/commits/d1f71ee687b052cdb640df9f8d2a4d5fec973b0c"}]}
{"actor":{"display_login":"hlinnaka"}}