{"action":"created","comment":{"url":"https://api.github.com/repos/xiph/rav1e/pulls/comments/228145181","pull_request_review_id":168345315,"id":228145181,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODE0NTE4MQ==","diff_hunk":"@@ -2080,20 +2125,31 @@ fn encode_tile(sequence: &mut Sequence, fi: &FrameInvariants, fs: &mut FrameStat\n             if fi.config.speed == 0 {\n                 let pmv = MotionVector { row: 0, col: 0 };\n                 encode_partition_bottomup(sequence, fi, fs, &mut cw,\n-                                          &mut w, &mut w_post_cdef,\n+                                          &mut w_pre_cdef, &mut w_post_cdef,\n                                           BlockSize::BLOCK_64X64, &bo, &pmv);\n             }\n             else {\n                 encode_partition_topdown(sequence, fi, fs, &mut cw,\n-                                         &mut w, &mut w_post_cdef,\n+                                         &mut w_pre_cdef, &mut w_post_cdef,\n                                          BlockSize::BLOCK_64X64, &bo, &None);\n             }\n \n+            // CDEF has to be decisded before loop restoration, but coded after","path":"src/encoder.rs","position":124,"original_position":124,"commit_id":"801c35b00479718e50fd9b8c34bfdd7fc3084026","original_commit_id":"801c35b00479718e50fd9b8c34bfdd7fc3084026","user":{"login":"xiphmont","id":11322256,"node_id":"MDQ6VXNlcjExMzIyMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/11322256?v=4","gravatar_id":"","url":"https://api.github.com/users/xiphmont","html_url":"https://github.com/xiphmont","followers_url":"https://api.github.com/users/xiphmont/followers","following_url":"https://api.github.com/users/xiphmont/following{/other_user}","gists_url":"https://api.github.com/users/xiphmont/gists{/gist_id}","starred_url":"https://api.github.com/users/xiphmont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiphmont/subscriptions","organizations_url":"https://api.github.com/users/xiphmont/orgs","repos_url":"https://api.github.com/users/xiphmont/repos","events_url":"https://api.github.com/users/xiphmont/events{/privacy}","received_events_url":"https://api.github.com/users/xiphmont/received_events","type":"User","site_admin":false},"body":"will catch it in next patch, thanks","created_at":"2018-10-25T12:05:02Z","updated_at":"2018-10-25T12:05:03Z","html_url":"https://github.com/xiph/rav1e/pull/678#discussion_r228145181","pull_request_url":"https://api.github.com/repos/xiph/rav1e/pulls/678","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/comments/228145181"},"html":{"href":"https://github.com/xiph/rav1e/pull/678#discussion_r228145181"},"pull_request":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/678"}},"in_reply_to_id":228135381},"pull_request":{"url":"https://api.github.com/repos/xiph/rav1e/pulls/678","id":225612491,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjEyNDkx","html_url":"https://github.com/xiph/rav1e/pull/678","diff_url":"https://github.com/xiph/rav1e/pull/678.diff","patch_url":"https://github.com/xiph/rav1e/pull/678.patch","issue_url":"https://api.github.com/repos/xiph/rav1e/issues/678","number":678,"state":"open","locked":false,"title":"Loop restoration filter beginnings","user":{"login":"xiphmont","id":11322256,"node_id":"MDQ6VXNlcjExMzIyMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/11322256?v=4","gravatar_id":"","url":"https://api.github.com/users/xiphmont","html_url":"https://github.com/xiphmont","followers_url":"https://api.github.com/users/xiphmont/followers","following_url":"https://api.github.com/users/xiphmont/following{/other_user}","gists_url":"https://api.github.com/users/xiphmont/gists{/gist_id}","starred_url":"https://api.github.com/users/xiphmont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiphmont/subscriptions","organizations_url":"https://api.github.com/users/xiphmont/orgs","repos_url":"https://api.github.com/users/xiphmont/repos","events_url":"https://api.github.com/users/xiphmont/events{/privacy}","received_events_url":"https://api.github.com/users/xiphmont/received_events","type":"User","site_admin":false},"body":"No functional change, but some added infrastructure and a Writer flow change in shared code menas I probably want to get this in sooner rather than later to avoid surprises.\r\n\r\nAside from adding RestorationUnits and a RestorationContext, coding the loop restoration parameters requires yet one more temporary Writer in the tile encode loop, as for each LRU the filter params have to be decided last, but written first.","created_at":"2018-10-25T03:25:40Z","updated_at":"2018-10-25T12:05:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3c6092d34aff93869bbe02e8d78e4216bddef03","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mbebenita","id":311082,"node_id":"MDQ6VXNlcjMxMTA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/311082?v=4","gravatar_id":"","url":"https://api.github.com/users/mbebenita","html_url":"https://github.com/mbebenita","followers_url":"https://api.github.com/users/mbebenita/followers","following_url":"https://api.github.com/users/mbebenita/following{/other_user}","gists_url":"https://api.github.com/users/mbebenita/gists{/gist_id}","starred_url":"https://api.github.com/users/mbebenita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbebenita/subscriptions","organizations_url":"https://api.github.com/users/mbebenita/orgs","repos_url":"https://api.github.com/users/mbebenita/repos","events_url":"https://api.github.com/users/mbebenita/events{/privacy}","received_events_url":"https://api.github.com/users/mbebenita/received_events","type":"User","site_admin":false},{"login":"tdaede","id":1308314,"node_id":"MDQ6VXNlcjEzMDgzMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1308314?v=4","gravatar_id":"","url":"https://api.github.com/users/tdaede","html_url":"https://github.com/tdaede","followers_url":"https://api.github.com/users/tdaede/followers","following_url":"https://api.github.com/users/tdaede/following{/other_user}","gists_url":"https://api.github.com/users/tdaede/gists{/gist_id}","starred_url":"https://api.github.com/users/tdaede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdaede/subscriptions","organizations_url":"https://api.github.com/users/tdaede/orgs","repos_url":"https://api.github.com/users/tdaede/repos","events_url":"https://api.github.com/users/tdaede/events{/privacy}","received_events_url":"https://api.github.com/users/tdaede/received_events","type":"User","site_admin":false},{"login":"ycho","id":10123259,"node_id":"MDQ6VXNlcjEwMTIzMjU5","avatar_url":"https://avatars3.githubusercontent.com/u/10123259?v=4","gravatar_id":"","url":"https://api.github.com/users/ycho","html_url":"https://github.com/ycho","followers_url":"https://api.github.com/users/ycho/followers","following_url":"https://api.github.com/users/ycho/following{/other_user}","gists_url":"https://api.github.com/users/ycho/gists{/gist_id}","starred_url":"https://api.github.com/users/ycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycho/subscriptions","organizations_url":"https://api.github.com/users/ycho/orgs","repos_url":"https://api.github.com/users/ycho/repos","events_url":"https://api.github.com/users/ycho/events{/privacy}","received_events_url":"https://api.github.com/users/ycho/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xiph/rav1e/pulls/678/commits","review_comments_url":"https://api.github.com/repos/xiph/rav1e/pulls/678/comments","review_comment_url":"https://api.github.com/repos/xiph/rav1e/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xiph/rav1e/issues/678/comments","statuses_url":"https://api.github.com/repos/xiph/rav1e/statuses/801c35b00479718e50fd9b8c34bfdd7fc3084026","head":{"label":"xiphmont:lrf","ref":"lrf","sha":"801c35b00479718e50fd9b8c34bfdd7fc3084026","user":{"login":"xiphmont","id":11322256,"node_id":"MDQ6VXNlcjExMzIyMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/11322256?v=4","gravatar_id":"","url":"https://api.github.com/users/xiphmont","html_url":"https://github.com/xiphmont","followers_url":"https://api.github.com/users/xiphmont/followers","following_url":"https://api.github.com/users/xiphmont/following{/other_user}","gists_url":"https://api.github.com/users/xiphmont/gists{/gist_id}","starred_url":"https://api.github.com/users/xiphmont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiphmont/subscriptions","organizations_url":"https://api.github.com/users/xiphmont/orgs","repos_url":"https://api.github.com/users/xiphmont/repos","events_url":"https://api.github.com/users/xiphmont/events{/privacy}","received_events_url":"https://api.github.com/users/xiphmont/received_events","type":"User","site_admin":false},"repo":{"id":122539054,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1MzkwNTQ=","name":"rav1e","full_name":"xiphmont/rav1e","private":false,"owner":{"login":"xiphmont","id":11322256,"node_id":"MDQ6VXNlcjExMzIyMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/11322256?v=4","gravatar_id":"","url":"https://api.github.com/users/xiphmont","html_url":"https://github.com/xiphmont","followers_url":"https://api.github.com/users/xiphmont/followers","following_url":"https://api.github.com/users/xiphmont/following{/other_user}","gists_url":"https://api.github.com/users/xiphmont/gists{/gist_id}","starred_url":"https://api.github.com/users/xiphmont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiphmont/subscriptions","organizations_url":"https://api.github.com/users/xiphmont/orgs","repos_url":"https://api.github.com/users/xiphmont/repos","events_url":"https://api.github.com/users/xiphmont/events{/privacy}","received_events_url":"https://api.github.com/users/xiphmont/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xiphmont/rav1e","description":"The fastest and safest AV1 encoder.","fork":true,"url":"https://api.github.com/repos/xiphmont/rav1e","forks_url":"https://api.github.com/repos/xiphmont/rav1e/forks","keys_url":"https://api.github.com/repos/xiphmont/rav1e/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiphmont/rav1e/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiphmont/rav1e/teams","hooks_url":"https://api.github.com/repos/xiphmont/rav1e/hooks","issue_events_url":"https://api.github.com/repos/xiphmont/rav1e/issues/events{/number}","events_url":"https://api.github.com/repos/xiphmont/rav1e/events","assignees_url":"https://api.github.com/repos/xiphmont/rav1e/assignees{/user}","branches_url":"https://api.github.com/repos/xiphmont/rav1e/branches{/branch}","tags_url":"https://api.github.com/repos/xiphmont/rav1e/tags","blobs_url":"https://api.github.com/repos/xiphmont/rav1e/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiphmont/rav1e/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiphmont/rav1e/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiphmont/rav1e/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiphmont/rav1e/statuses/{sha}","languages_url":"https://api.github.com/repos/xiphmont/rav1e/languages","stargazers_url":"https://api.github.com/repos/xiphmont/rav1e/stargazers","contributors_url":"https://api.github.com/repos/xiphmont/rav1e/contributors","subscribers_url":"https://api.github.com/repos/xiphmont/rav1e/subscribers","subscription_url":"https://api.github.com/repos/xiphmont/rav1e/subscription","commits_url":"https://api.github.com/repos/xiphmont/rav1e/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiphmont/rav1e/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiphmont/rav1e/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiphmont/rav1e/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiphmont/rav1e/contents/{+path}","compare_url":"https://api.github.com/repos/xiphmont/rav1e/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiphmont/rav1e/merges","archive_url":"https://api.github.com/repos/xiphmont/rav1e/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiphmont/rav1e/downloads","issues_url":"https://api.github.com/repos/xiphmont/rav1e/issues{/number}","pulls_url":"https://api.github.com/repos/xiphmont/rav1e/pulls{/number}","milestones_url":"https://api.github.com/repos/xiphmont/rav1e/milestones{/number}","notifications_url":"https://api.github.com/repos/xiphmont/rav1e/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiphmont/rav1e/labels{/name}","releases_url":"https://api.github.com/repos/xiphmont/rav1e/releases{/id}","deployments_url":"https://api.github.com/repos/xiphmont/rav1e/deployments","created_at":"2018-02-22T21:45:03Z","updated_at":"2018-10-24T03:13:42Z","pushed_at":"2018-10-25T04:11:37Z","git_url":"git://github.com/xiphmont/rav1e.git","ssh_url":"git@github.com:xiphmont/rav1e.git","clone_url":"https://github.com/xiphmont/rav1e.git","svn_url":"https://github.com/xiphmont/rav1e","homepage":"","size":2043,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xiph:master","ref":"master","sha":"9d5678c97b687fb9ead404cc46f5d0587606471a","user":{"login":"xiph","id":8365509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjU1MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/8365509?v=4","gravatar_id":"","url":"https://api.github.com/users/xiph","html_url":"https://github.com/xiph","followers_url":"https://api.github.com/users/xiph/followers","following_url":"https://api.github.com/users/xiph/following{/other_user}","gists_url":"https://api.github.com/users/xiph/gists{/gist_id}","starred_url":"https://api.github.com/users/xiph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiph/subscriptions","organizations_url":"https://api.github.com/users/xiph/orgs","repos_url":"https://api.github.com/users/xiph/repos","events_url":"https://api.github.com/users/xiph/events{/privacy}","received_events_url":"https://api.github.com/users/xiph/received_events","type":"Organization","site_admin":false},"repo":{"id":104629023,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ2MjkwMjM=","name":"rav1e","full_name":"xiph/rav1e","private":false,"owner":{"login":"xiph","id":8365509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjU1MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/8365509?v=4","gravatar_id":"","url":"https://api.github.com/users/xiph","html_url":"https://github.com/xiph","followers_url":"https://api.github.com/users/xiph/followers","following_url":"https://api.github.com/users/xiph/following{/other_user}","gists_url":"https://api.github.com/users/xiph/gists{/gist_id}","starred_url":"https://api.github.com/users/xiph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiph/subscriptions","organizations_url":"https://api.github.com/users/xiph/orgs","repos_url":"https://api.github.com/users/xiph/repos","events_url":"https://api.github.com/users/xiph/events{/privacy}","received_events_url":"https://api.github.com/users/xiph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xiph/rav1e","description":"The fastest and safest AV1 encoder.","fork":false,"url":"https://api.github.com/repos/xiph/rav1e","forks_url":"https://api.github.com/repos/xiph/rav1e/forks","keys_url":"https://api.github.com/repos/xiph/rav1e/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiph/rav1e/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiph/rav1e/teams","hooks_url":"https://api.github.com/repos/xiph/rav1e/hooks","issue_events_url":"https://api.github.com/repos/xiph/rav1e/issues/events{/number}","events_url":"https://api.github.com/repos/xiph/rav1e/events","assignees_url":"https://api.github.com/repos/xiph/rav1e/assignees{/user}","branches_url":"https://api.github.com/repos/xiph/rav1e/branches{/branch}","tags_url":"https://api.github.com/repos/xiph/rav1e/tags","blobs_url":"https://api.github.com/repos/xiph/rav1e/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiph/rav1e/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiph/rav1e/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiph/rav1e/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiph/rav1e/statuses/{sha}","languages_url":"https://api.github.com/repos/xiph/rav1e/languages","stargazers_url":"https://api.github.com/repos/xiph/rav1e/stargazers","contributors_url":"https://api.github.com/repos/xiph/rav1e/contributors","subscribers_url":"https://api.github.com/repos/xiph/rav1e/subscribers","subscription_url":"https://api.github.com/repos/xiph/rav1e/subscription","commits_url":"https://api.github.com/repos/xiph/rav1e/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiph/rav1e/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiph/rav1e/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiph/rav1e/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiph/rav1e/contents/{+path}","compare_url":"https://api.github.com/repos/xiph/rav1e/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiph/rav1e/merges","archive_url":"https://api.github.com/repos/xiph/rav1e/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiph/rav1e/downloads","issues_url":"https://api.github.com/repos/xiph/rav1e/issues{/number}","pulls_url":"https://api.github.com/repos/xiph/rav1e/pulls{/number}","milestones_url":"https://api.github.com/repos/xiph/rav1e/milestones{/number}","notifications_url":"https://api.github.com/repos/xiph/rav1e/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiph/rav1e/labels{/name}","releases_url":"https://api.github.com/repos/xiph/rav1e/releases{/id}","deployments_url":"https://api.github.com/repos/xiph/rav1e/deployments","created_at":"2017-09-24T08:12:55Z","updated_at":"2018-10-25T01:31:10Z","pushed_at":"2018-10-25T10:17:55Z","git_url":"git://github.com/xiph/rav1e.git","ssh_url":"git@github.com:xiph/rav1e.git","clone_url":"https://github.com/xiph/rav1e.git","svn_url":"https://github.com/xiph/rav1e","homepage":"","size":1995,"stargazers_count":816,"watchers_count":816,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":64,"open_issues":72,"watchers":816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/678"},"html":{"href":"https://github.com/xiph/rav1e/pull/678"},"issue":{"href":"https://api.github.com/repos/xiph/rav1e/issues/678"},"comments":{"href":"https://api.github.com/repos/xiph/rav1e/issues/678/comments"},"review_comments":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/678/comments"},"review_comment":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/678/commits"},"statuses":{"href":"https://api.github.com/repos/xiph/rav1e/statuses/801c35b00479718e50fd9b8c34bfdd7fc3084026"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xiphmont"}}