{"action":"created","comment":{"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/182336983","pull_request_review_id":113109434,"id":182336983,"diff_hunk":"@@ -1,8 +1,15 @@\n module Doorkeeper\n   class AuthorizationsController < Doorkeeper::ApplicationController\n-    before_action :authenticate_resource_owner!\n+    before_action do\n+      render_prompt_error(:login_required) unless begin\n+                                                    authenticate_resource_owner!\n+                                                  rescue StandardError => e","path":"app/controllers/doorkeeper/authorizations_controller.rb","position":7,"original_position":7,"commit_id":"a318ac504093257e2017e16519c0e44ed5e76511","original_commit_id":"a318ac504093257e2017e16519c0e44ed5e76511","user":{"login":"nbulaj","id":1443426,"avatar_url":"https://avatars2.githubusercontent.com/u/1443426?v=4","gravatar_id":"","url":"https://api.github.com/users/nbulaj","html_url":"https://github.com/nbulaj","followers_url":"https://api.github.com/users/nbulaj/followers","following_url":"https://api.github.com/users/nbulaj/following{/other_user}","gists_url":"https://api.github.com/users/nbulaj/gists{/gist_id}","starred_url":"https://api.github.com/users/nbulaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbulaj/subscriptions","organizations_url":"https://api.github.com/users/nbulaj/orgs","repos_url":"https://api.github.com/users/nbulaj/repos","events_url":"https://api.github.com/users/nbulaj/events{/privacy}","received_events_url":"https://api.github.com/users/nbulaj/received_events","type":"User","site_admin":false},"body":"Do we really need to handle `StandardError` ? :thinking: ","created_at":"2018-04-18T07:51:03Z","updated_at":"2018-04-18T07:51:13Z","html_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/1084#discussion_r182336983","pull_request_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1084","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments/182336983"},"html":{"href":"https://github.com/doorkeeper-gem/doorkeeper/pull/1084#discussion_r182336983"},"pull_request":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1084"}}},"pull_request":{"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1084","id":181720140,"html_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/1084","diff_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/1084.diff","patch_url":"https://github.com/doorkeeper-gem/doorkeeper/pull/1084.patch","issue_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/1084","number":1084,"state":"open","locked":false,"title":"Support OIDC 1.0's optional `prompt` parameter","user":{"login":"f3ndot","id":740289,"avatar_url":"https://avatars3.githubusercontent.com/u/740289?v=4","gravatar_id":"","url":"https://api.github.com/users/f3ndot","html_url":"https://github.com/f3ndot","followers_url":"https://api.github.com/users/f3ndot/followers","following_url":"https://api.github.com/users/f3ndot/following{/other_user}","gists_url":"https://api.github.com/users/f3ndot/gists{/gist_id}","starred_url":"https://api.github.com/users/f3ndot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f3ndot/subscriptions","organizations_url":"https://api.github.com/users/f3ndot/orgs","repos_url":"https://api.github.com/users/f3ndot/repos","events_url":"https://api.github.com/users/f3ndot/events{/privacy}","received_events_url":"https://api.github.com/users/f3ndot/received_events","type":"User","site_admin":false},"body":"Per http://openid.net/specs/openid-connect-core-1_0.html\r\n\r\nPrompt accepts a few different values:\r\n\r\n- `none`: Must not display consent or authorization pages. Either will redirect or error with `login_required` or `consent_required`. This param allows devs to use The Silent Authentication method as described by Auth0.\r\n- `login`: Should prompt user for reauthentication. Doorkeeper will just fail with `login_required`.\r\n- `consent`: Should prompt user for consent. Doorkeeper will not automatically redirect even if matching token.\r\n\r\nFixes #1073 ","created_at":"2018-04-15T20:50:59Z","updated_at":"2018-04-18T07:51:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26753c109ea930f2bd27a4ca0f22af1b211bf3fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1084/commits","review_comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1084/comments","review_comment_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/1084/comments","statuses_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/a318ac504093257e2017e16519c0e44ed5e76511","head":{"label":"f3ndot:issue-1073-support-silent-auth","ref":"issue-1073-support-silent-auth","sha":"a318ac504093257e2017e16519c0e44ed5e76511","user":{"login":"f3ndot","id":740289,"avatar_url":"https://avatars3.githubusercontent.com/u/740289?v=4","gravatar_id":"","url":"https://api.github.com/users/f3ndot","html_url":"https://github.com/f3ndot","followers_url":"https://api.github.com/users/f3ndot/followers","following_url":"https://api.github.com/users/f3ndot/following{/other_user}","gists_url":"https://api.github.com/users/f3ndot/gists{/gist_id}","starred_url":"https://api.github.com/users/f3ndot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f3ndot/subscriptions","organizations_url":"https://api.github.com/users/f3ndot/orgs","repos_url":"https://api.github.com/users/f3ndot/repos","events_url":"https://api.github.com/users/f3ndot/events{/privacy}","received_events_url":"https://api.github.com/users/f3ndot/received_events","type":"User","site_admin":false},"repo":{"id":64866836,"name":"doorkeeper","full_name":"f3ndot/doorkeeper","owner":{"login":"f3ndot","id":740289,"avatar_url":"https://avatars3.githubusercontent.com/u/740289?v=4","gravatar_id":"","url":"https://api.github.com/users/f3ndot","html_url":"https://github.com/f3ndot","followers_url":"https://api.github.com/users/f3ndot/followers","following_url":"https://api.github.com/users/f3ndot/following{/other_user}","gists_url":"https://api.github.com/users/f3ndot/gists{/gist_id}","starred_url":"https://api.github.com/users/f3ndot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f3ndot/subscriptions","organizations_url":"https://api.github.com/users/f3ndot/orgs","repos_url":"https://api.github.com/users/f3ndot/repos","events_url":"https://api.github.com/users/f3ndot/events{/privacy}","received_events_url":"https://api.github.com/users/f3ndot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/f3ndot/doorkeeper","description":"Doorkeeper is an OAuth 2 provider for Rails","fork":true,"url":"https://api.github.com/repos/f3ndot/doorkeeper","forks_url":"https://api.github.com/repos/f3ndot/doorkeeper/forks","keys_url":"https://api.github.com/repos/f3ndot/doorkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/f3ndot/doorkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/f3ndot/doorkeeper/teams","hooks_url":"https://api.github.com/repos/f3ndot/doorkeeper/hooks","issue_events_url":"https://api.github.com/repos/f3ndot/doorkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/f3ndot/doorkeeper/events","assignees_url":"https://api.github.com/repos/f3ndot/doorkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/f3ndot/doorkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/f3ndot/doorkeeper/tags","blobs_url":"https://api.github.com/repos/f3ndot/doorkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/f3ndot/doorkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/f3ndot/doorkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/f3ndot/doorkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/f3ndot/doorkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/f3ndot/doorkeeper/languages","stargazers_url":"https://api.github.com/repos/f3ndot/doorkeeper/stargazers","contributors_url":"https://api.github.com/repos/f3ndot/doorkeeper/contributors","subscribers_url":"https://api.github.com/repos/f3ndot/doorkeeper/subscribers","subscription_url":"https://api.github.com/repos/f3ndot/doorkeeper/subscription","commits_url":"https://api.github.com/repos/f3ndot/doorkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/f3ndot/doorkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/f3ndot/doorkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/f3ndot/doorkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/f3ndot/doorkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/f3ndot/doorkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/f3ndot/doorkeeper/merges","archive_url":"https://api.github.com/repos/f3ndot/doorkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/f3ndot/doorkeeper/downloads","issues_url":"https://api.github.com/repos/f3ndot/doorkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/f3ndot/doorkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/f3ndot/doorkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/f3ndot/doorkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/f3ndot/doorkeeper/labels{/name}","releases_url":"https://api.github.com/repos/f3ndot/doorkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/f3ndot/doorkeeper/deployments","created_at":"2016-08-03T17:49:42Z","updated_at":"2018-03-15T19:26:49Z","pushed_at":"2018-04-15T20:49:41Z","git_url":"git://github.com/f3ndot/doorkeeper.git","ssh_url":"git@github.com:f3ndot/doorkeeper.git","clone_url":"https://github.com/f3ndot/doorkeeper.git","svn_url":"https://github.com/f3ndot/doorkeeper","homepage":"","size":2415,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doorkeeper-gem:master","ref":"master","sha":"25028a8f2811dbc6b91bab731ed6e12ad07cbce2","user":{"login":"doorkeeper-gem","id":7275750,"avatar_url":"https://avatars1.githubusercontent.com/u/7275750?v=4","gravatar_id":"","url":"https://api.github.com/users/doorkeeper-gem","html_url":"https://github.com/doorkeeper-gem","followers_url":"https://api.github.com/users/doorkeeper-gem/followers","following_url":"https://api.github.com/users/doorkeeper-gem/following{/other_user}","gists_url":"https://api.github.com/users/doorkeeper-gem/gists{/gist_id}","starred_url":"https://api.github.com/users/doorkeeper-gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doorkeeper-gem/subscriptions","organizations_url":"https://api.github.com/users/doorkeeper-gem/orgs","repos_url":"https://api.github.com/users/doorkeeper-gem/repos","events_url":"https://api.github.com/users/doorkeeper-gem/events{/privacy}","received_events_url":"https://api.github.com/users/doorkeeper-gem/received_events","type":"Organization","site_admin":false},"repo":{"id":2802565,"name":"doorkeeper","full_name":"doorkeeper-gem/doorkeeper","owner":{"login":"doorkeeper-gem","id":7275750,"avatar_url":"https://avatars1.githubusercontent.com/u/7275750?v=4","gravatar_id":"","url":"https://api.github.com/users/doorkeeper-gem","html_url":"https://github.com/doorkeeper-gem","followers_url":"https://api.github.com/users/doorkeeper-gem/followers","following_url":"https://api.github.com/users/doorkeeper-gem/following{/other_user}","gists_url":"https://api.github.com/users/doorkeeper-gem/gists{/gist_id}","starred_url":"https://api.github.com/users/doorkeeper-gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doorkeeper-gem/subscriptions","organizations_url":"https://api.github.com/users/doorkeeper-gem/orgs","repos_url":"https://api.github.com/users/doorkeeper-gem/repos","events_url":"https://api.github.com/users/doorkeeper-gem/events{/privacy}","received_events_url":"https://api.github.com/users/doorkeeper-gem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doorkeeper-gem/doorkeeper","description":"Doorkeeper is an OAuth 2 provider for Rails.","fork":false,"url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper","forks_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/forks","keys_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/teams","hooks_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/hooks","issue_events_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/events","assignees_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/tags","blobs_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/languages","stargazers_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/stargazers","contributors_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/contributors","subscribers_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/subscribers","subscription_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/subscription","commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/merges","archive_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/downloads","issues_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/labels{/name}","releases_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/deployments","created_at":"2011-11-18T13:02:01Z","updated_at":"2018-04-18T01:36:39Z","pushed_at":"2018-04-16T12:34:09Z","git_url":"git://github.com/doorkeeper-gem/doorkeeper.git","ssh_url":"git@github.com:doorkeeper-gem/doorkeeper.git","clone_url":"https://github.com/doorkeeper-gem/doorkeeper.git","svn_url":"https://github.com/doorkeeper-gem/doorkeeper","homepage":"","size":2439,"stargazers_count":3874,"watchers_count":3874,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":779,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":779,"open_issues":22,"watchers":3874,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1084"},"html":{"href":"https://github.com/doorkeeper-gem/doorkeeper/pull/1084"},"issue":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/1084"},"comments":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/issues/1084/comments"},"review_comments":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1084/comments"},"review_comment":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/pulls/1084/commits"},"statuses":{"href":"https://api.github.com/repos/doorkeeper-gem/doorkeeper/statuses/a318ac504093257e2017e16519c0e44ed5e76511"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nbulaj"}}