{"action":"created","comment":{"url":"https://api.github.com/repos/olofk/edalize/pulls/comments/242358548","pull_request_review_id":185847368,"id":242358548,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjM1ODU0OA==","diff_hunk":"@@ -0,0 +1,86 @@\n+import os\n+import logging\n+\n+from edalize.edatool import Edatool\n+\n+logger = logging.getLogger(__name__)\n+\n+class Vcs(Edatool):\n+\n+    tool_options = {\n+        'lists' : {'vcs_options' : 'String'}\n+    }\n+\n+    argtypes = ['plusarg', 'vlogdefine', 'vlogparam']\n+\n+    MAKEFILE_TEMPLATE = \"\"\"\n+all: $(TARGET)\n+\n+$(TARGET):\n+\tvcs -full64 -t $(TOPLEVEL) -f $(TARGET).scr -o $@ $(VCS_OPTIONS)","path":"edalize/vcs.py","position":20,"original_position":20,"commit_id":"6c5256608114af16789c9a57ec262af70b7cd18e","original_commit_id":"6c5256608114af16789c9a57ec262af70b7cd18e","user":{"login":"imphil","id":1467123,"node_id":"MDQ6VXNlcjE0NjcxMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1467123?v=4","gravatar_id":"","url":"https://api.github.com/users/imphil","html_url":"https://github.com/imphil","followers_url":"https://api.github.com/users/imphil/followers","following_url":"https://api.github.com/users/imphil/following{/other_user}","gists_url":"https://api.github.com/users/imphil/gists{/gist_id}","starred_url":"https://api.github.com/users/imphil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imphil/subscriptions","organizations_url":"https://api.github.com/users/imphil/orgs","repos_url":"https://api.github.com/users/imphil/repos","events_url":"https://api.github.com/users/imphil/events{/privacy}","received_events_url":"https://api.github.com/users/imphil/received_events","type":"User","site_admin":false},"body":"```\r\n-full64\r\n   Compiles the design in 64 bit mode and creates a 64 bit executable\r\n   for simulating in 64 bit mode.\r\n```\r\n\r\nSo it's required on 64 bit platforms (otherwise VCS won't start). Given that I cannot imagine anybody running VCS on a 32 bit machine these days it's probably safe to unconditionally set it.\r\n\r\nDetecting 32 vs 64 bit would probably be sufficiently easy, however testing for that is probably annoying ...","created_at":"2018-12-17T23:38:40Z","updated_at":"2018-12-17T23:47:10Z","html_url":"https://github.com/olofk/edalize/pull/5#discussion_r242358548","pull_request_url":"https://api.github.com/repos/olofk/edalize/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/olofk/edalize/pulls/comments/242358548"},"html":{"href":"https://github.com/olofk/edalize/pull/5#discussion_r242358548"},"pull_request":{"href":"https://api.github.com/repos/olofk/edalize/pulls/5"}},"in_reply_to_id":242140366},"pull_request":{"url":"https://api.github.com/repos/olofk/edalize/pulls/5","id":238992871,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTkyODcx","html_url":"https://github.com/olofk/edalize/pull/5","diff_url":"https://github.com/olofk/edalize/pull/5.diff","patch_url":"https://github.com/olofk/edalize/pull/5.patch","issue_url":"https://api.github.com/repos/olofk/edalize/issues/5","number":5,"state":"open","locked":false,"title":"Minimal VCS backend","user":{"login":"Jbalkind","id":1590433,"node_id":"MDQ6VXNlcjE1OTA0MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1590433?v=4","gravatar_id":"","url":"https://api.github.com/users/Jbalkind","html_url":"https://github.com/Jbalkind","followers_url":"https://api.github.com/users/Jbalkind/followers","following_url":"https://api.github.com/users/Jbalkind/following{/other_user}","gists_url":"https://api.github.com/users/Jbalkind/gists{/gist_id}","starred_url":"https://api.github.com/users/Jbalkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jbalkind/subscriptions","organizations_url":"https://api.github.com/users/Jbalkind/orgs","repos_url":"https://api.github.com/users/Jbalkind/repos","events_url":"https://api.github.com/users/Jbalkind/events{/privacy}","received_events_url":"https://api.github.com/users/Jbalkind/received_events","type":"User","site_admin":false},"body":"Not sure that all the arguments work but this backend worked for my simple cases with openpiton.\r\n\r\nHappy to make edits versus what's here. Also it's basically a direct copy of one of the other backends (I forget which) so I may have left something in there accidentally.","created_at":"2018-12-16T21:55:25Z","updated_at":"2018-12-17T23:47:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc555be3b677d1d821fe1bd238acc355269c9bd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/olofk/edalize/pulls/5/commits","review_comments_url":"https://api.github.com/repos/olofk/edalize/pulls/5/comments","review_comment_url":"https://api.github.com/repos/olofk/edalize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/olofk/edalize/issues/5/comments","statuses_url":"https://api.github.com/repos/olofk/edalize/statuses/6c5256608114af16789c9a57ec262af70b7cd18e","head":{"label":"Jbalkind:vcs-backend","ref":"vcs-backend","sha":"6c5256608114af16789c9a57ec262af70b7cd18e","user":{"login":"Jbalkind","id":1590433,"node_id":"MDQ6VXNlcjE1OTA0MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1590433?v=4","gravatar_id":"","url":"https://api.github.com/users/Jbalkind","html_url":"https://github.com/Jbalkind","followers_url":"https://api.github.com/users/Jbalkind/followers","following_url":"https://api.github.com/users/Jbalkind/following{/other_user}","gists_url":"https://api.github.com/users/Jbalkind/gists{/gist_id}","starred_url":"https://api.github.com/users/Jbalkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jbalkind/subscriptions","organizations_url":"https://api.github.com/users/Jbalkind/orgs","repos_url":"https://api.github.com/users/Jbalkind/repos","events_url":"https://api.github.com/users/Jbalkind/events{/privacy}","received_events_url":"https://api.github.com/users/Jbalkind/received_events","type":"User","site_admin":false},"repo":{"id":162044205,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIwNDQyMDU=","name":"edalize","full_name":"Jbalkind/edalize","private":false,"owner":{"login":"Jbalkind","id":1590433,"node_id":"MDQ6VXNlcjE1OTA0MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1590433?v=4","gravatar_id":"","url":"https://api.github.com/users/Jbalkind","html_url":"https://github.com/Jbalkind","followers_url":"https://api.github.com/users/Jbalkind/followers","following_url":"https://api.github.com/users/Jbalkind/following{/other_user}","gists_url":"https://api.github.com/users/Jbalkind/gists{/gist_id}","starred_url":"https://api.github.com/users/Jbalkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jbalkind/subscriptions","organizations_url":"https://api.github.com/users/Jbalkind/orgs","repos_url":"https://api.github.com/users/Jbalkind/repos","events_url":"https://api.github.com/users/Jbalkind/events{/privacy}","received_events_url":"https://api.github.com/users/Jbalkind/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Jbalkind/edalize","description":"An abstraction library for interfacing EDA tools","fork":true,"url":"https://api.github.com/repos/Jbalkind/edalize","forks_url":"https://api.github.com/repos/Jbalkind/edalize/forks","keys_url":"https://api.github.com/repos/Jbalkind/edalize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jbalkind/edalize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jbalkind/edalize/teams","hooks_url":"https://api.github.com/repos/Jbalkind/edalize/hooks","issue_events_url":"https://api.github.com/repos/Jbalkind/edalize/issues/events{/number}","events_url":"https://api.github.com/repos/Jbalkind/edalize/events","assignees_url":"https://api.github.com/repos/Jbalkind/edalize/assignees{/user}","branches_url":"https://api.github.com/repos/Jbalkind/edalize/branches{/branch}","tags_url":"https://api.github.com/repos/Jbalkind/edalize/tags","blobs_url":"https://api.github.com/repos/Jbalkind/edalize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jbalkind/edalize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jbalkind/edalize/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jbalkind/edalize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jbalkind/edalize/statuses/{sha}","languages_url":"https://api.github.com/repos/Jbalkind/edalize/languages","stargazers_url":"https://api.github.com/repos/Jbalkind/edalize/stargazers","contributors_url":"https://api.github.com/repos/Jbalkind/edalize/contributors","subscribers_url":"https://api.github.com/repos/Jbalkind/edalize/subscribers","subscription_url":"https://api.github.com/repos/Jbalkind/edalize/subscription","commits_url":"https://api.github.com/repos/Jbalkind/edalize/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jbalkind/edalize/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jbalkind/edalize/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jbalkind/edalize/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jbalkind/edalize/contents/{+path}","compare_url":"https://api.github.com/repos/Jbalkind/edalize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jbalkind/edalize/merges","archive_url":"https://api.github.com/repos/Jbalkind/edalize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jbalkind/edalize/downloads","issues_url":"https://api.github.com/repos/Jbalkind/edalize/issues{/number}","pulls_url":"https://api.github.com/repos/Jbalkind/edalize/pulls{/number}","milestones_url":"https://api.github.com/repos/Jbalkind/edalize/milestones{/number}","notifications_url":"https://api.github.com/repos/Jbalkind/edalize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jbalkind/edalize/labels{/name}","releases_url":"https://api.github.com/repos/Jbalkind/edalize/releases{/id}","deployments_url":"https://api.github.com/repos/Jbalkind/edalize/deployments","created_at":"2018-12-16T21:51:04Z","updated_at":"2018-12-16T21:51:06Z","pushed_at":"2018-12-16T21:53:12Z","git_url":"git://github.com/Jbalkind/edalize.git","ssh_url":"git@github.com:Jbalkind/edalize.git","clone_url":"https://github.com/Jbalkind/edalize.git","svn_url":"https://github.com/Jbalkind/edalize","homepage":"","size":69,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"olofk:master","ref":"master","sha":"89e3c991a5dfff7c2a1b42a43b5f208eaac9d502","user":{"login":"olofk","id":2194902,"node_id":"MDQ6VXNlcjIxOTQ5MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2194902?v=4","gravatar_id":"","url":"https://api.github.com/users/olofk","html_url":"https://github.com/olofk","followers_url":"https://api.github.com/users/olofk/followers","following_url":"https://api.github.com/users/olofk/following{/other_user}","gists_url":"https://api.github.com/users/olofk/gists{/gist_id}","starred_url":"https://api.github.com/users/olofk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olofk/subscriptions","organizations_url":"https://api.github.com/users/olofk/orgs","repos_url":"https://api.github.com/users/olofk/repos","events_url":"https://api.github.com/users/olofk/events{/privacy}","received_events_url":"https://api.github.com/users/olofk/received_events","type":"User","site_admin":false},"repo":{"id":132811303,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI4MTEzMDM=","name":"edalize","full_name":"olofk/edalize","private":false,"owner":{"login":"olofk","id":2194902,"node_id":"MDQ6VXNlcjIxOTQ5MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2194902?v=4","gravatar_id":"","url":"https://api.github.com/users/olofk","html_url":"https://github.com/olofk","followers_url":"https://api.github.com/users/olofk/followers","following_url":"https://api.github.com/users/olofk/following{/other_user}","gists_url":"https://api.github.com/users/olofk/gists{/gist_id}","starred_url":"https://api.github.com/users/olofk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olofk/subscriptions","organizations_url":"https://api.github.com/users/olofk/orgs","repos_url":"https://api.github.com/users/olofk/repos","events_url":"https://api.github.com/users/olofk/events{/privacy}","received_events_url":"https://api.github.com/users/olofk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/olofk/edalize","description":"An abstraction library for interfacing EDA tools","fork":false,"url":"https://api.github.com/repos/olofk/edalize","forks_url":"https://api.github.com/repos/olofk/edalize/forks","keys_url":"https://api.github.com/repos/olofk/edalize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olofk/edalize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olofk/edalize/teams","hooks_url":"https://api.github.com/repos/olofk/edalize/hooks","issue_events_url":"https://api.github.com/repos/olofk/edalize/issues/events{/number}","events_url":"https://api.github.com/repos/olofk/edalize/events","assignees_url":"https://api.github.com/repos/olofk/edalize/assignees{/user}","branches_url":"https://api.github.com/repos/olofk/edalize/branches{/branch}","tags_url":"https://api.github.com/repos/olofk/edalize/tags","blobs_url":"https://api.github.com/repos/olofk/edalize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olofk/edalize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olofk/edalize/git/refs{/sha}","trees_url":"https://api.github.com/repos/olofk/edalize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olofk/edalize/statuses/{sha}","languages_url":"https://api.github.com/repos/olofk/edalize/languages","stargazers_url":"https://api.github.com/repos/olofk/edalize/stargazers","contributors_url":"https://api.github.com/repos/olofk/edalize/contributors","subscribers_url":"https://api.github.com/repos/olofk/edalize/subscribers","subscription_url":"https://api.github.com/repos/olofk/edalize/subscription","commits_url":"https://api.github.com/repos/olofk/edalize/commits{/sha}","git_commits_url":"https://api.github.com/repos/olofk/edalize/git/commits{/sha}","comments_url":"https://api.github.com/repos/olofk/edalize/comments{/number}","issue_comment_url":"https://api.github.com/repos/olofk/edalize/issues/comments{/number}","contents_url":"https://api.github.com/repos/olofk/edalize/contents/{+path}","compare_url":"https://api.github.com/repos/olofk/edalize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olofk/edalize/merges","archive_url":"https://api.github.com/repos/olofk/edalize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olofk/edalize/downloads","issues_url":"https://api.github.com/repos/olofk/edalize/issues{/number}","pulls_url":"https://api.github.com/repos/olofk/edalize/pulls{/number}","milestones_url":"https://api.github.com/repos/olofk/edalize/milestones{/number}","notifications_url":"https://api.github.com/repos/olofk/edalize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olofk/edalize/labels{/name}","releases_url":"https://api.github.com/repos/olofk/edalize/releases{/id}","deployments_url":"https://api.github.com/repos/olofk/edalize/deployments","created_at":"2018-05-09T20:48:49Z","updated_at":"2018-12-08T14:18:17Z","pushed_at":"2018-12-16T21:55:26Z","git_url":"git://github.com/olofk/edalize.git","ssh_url":"git@github.com:olofk/edalize.git","clone_url":"https://github.com/olofk/edalize.git","svn_url":"https://github.com/olofk/edalize","homepage":"","size":68,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":4,"open_issues":2,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/olofk/edalize/pulls/5"},"html":{"href":"https://github.com/olofk/edalize/pull/5"},"issue":{"href":"https://api.github.com/repos/olofk/edalize/issues/5"},"comments":{"href":"https://api.github.com/repos/olofk/edalize/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/olofk/edalize/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/olofk/edalize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/olofk/edalize/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/olofk/edalize/statuses/6c5256608114af16789c9a57ec262af70b7cd18e"}},"author_association":"NONE"}}
{"actor":{"display_login":"imphil"}}