{"action":"created","comment":{"url":"https://api.github.com/repos/DataBiosphere/azul/pulls/comments/230605729","pull_request_review_id":171379783,"id":230605729,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDYwNTcyOQ==","diff_hunk":"@@ -130,6 +130,9 @@ def create_aggregate(filters, facet_config, agg):\n             field=_field,\n             size=99999)\n         aggregate.bucket('untagged', 'missing', field=_field)\n+        if agg == \"fileFormat\":\n+            aggregate.aggs['myTerms'].metric('size_by_type', 'sum', field=\"contents.files.size\")\n+            aggregate.aggs['untagged'].metric('size_by_type', 'sum', field=\"contents.files.size\")","path":"src/azul/service/responseobjects/elastic_request_builder.py","position":6,"original_position":6,"commit_id":"b488850b888b804c44f9c58aa1d31560c3c44e31","original_commit_id":"b488850b888b804c44f9c58aa1d31560c3c44e31","user":{"login":"hannes-ucsc","id":5143256,"node_id":"MDQ6VXNlcjUxNDMyNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5143256?v=4","gravatar_id":"","url":"https://api.github.com/users/hannes-ucsc","html_url":"https://github.com/hannes-ucsc","followers_url":"https://api.github.com/users/hannes-ucsc/followers","following_url":"https://api.github.com/users/hannes-ucsc/following{/other_user}","gists_url":"https://api.github.com/users/hannes-ucsc/gists{/gist_id}","starred_url":"https://api.github.com/users/hannes-ucsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannes-ucsc/subscriptions","organizations_url":"https://api.github.com/users/hannes-ucsc/orgs","repos_url":"https://api.github.com/users/hannes-ucsc/repos","events_url":"https://api.github.com/users/hannes-ucsc/events{/privacy}","received_events_url":"https://api.github.com/users/hannes-ucsc/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n            aggregate.aggs['untagged'].metric('size_by_type', 'sum', field=fileSizeField)\r\n```","created_at":"2018-11-04T21:18:04Z","updated_at":"2018-11-04T21:32:26Z","html_url":"https://github.com/DataBiosphere/azul/pull/534#discussion_r230605729","pull_request_url":"https://api.github.com/repos/DataBiosphere/azul/pulls/534","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DataBiosphere/azul/pulls/comments/230605729"},"html":{"href":"https://github.com/DataBiosphere/azul/pull/534#discussion_r230605729"},"pull_request":{"href":"https://api.github.com/repos/DataBiosphere/azul/pulls/534"}}},"pull_request":{"url":"https://api.github.com/repos/DataBiosphere/azul/pulls/534","id":228084462,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDg0NDYy","html_url":"https://github.com/DataBiosphere/azul/pull/534","diff_url":"https://github.com/DataBiosphere/azul/pull/534.diff","patch_url":"https://github.com/DataBiosphere/azul/pull/534.patch","issue_url":"https://api.github.com/repos/DataBiosphere/azul/issues/534","number":534,"state":"open","locked":false,"title":"Comprehensive fileFormat agg (fixes HumanCellAtlas/data-browser#318)","user":{"login":"achave11","id":19215510,"node_id":"MDQ6VXNlcjE5MjE1NTEw","avatar_url":"https://avatars2.githubusercontent.com/u/19215510?v=4","gravatar_id":"","url":"https://api.github.com/users/achave11","html_url":"https://github.com/achave11","followers_url":"https://api.github.com/users/achave11/followers","following_url":"https://api.github.com/users/achave11/following{/other_user}","gists_url":"https://api.github.com/users/achave11/gists{/gist_id}","starred_url":"https://api.github.com/users/achave11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achave11/subscriptions","organizations_url":"https://api.github.com/users/achave11/orgs","repos_url":"https://api.github.com/users/achave11/repos","events_url":"https://api.github.com/users/achave11/events{/privacy}","received_events_url":"https://api.github.com/users/achave11/received_events","type":"User","site_admin":false},"body":"\r\n\r\nObtain fields for formation of fileFormat aggregate from one aggregate.\r\nAdded log for ES request of /summary endpoint.","created_at":"2018-11-02T23:51:37Z","updated_at":"2018-11-04T21:32:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c498f9a4316acb26991e52ed04e6ee898d2dee66","assignee":{"login":"hannes-ucsc","id":5143256,"node_id":"MDQ6VXNlcjUxNDMyNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5143256?v=4","gravatar_id":"","url":"https://api.github.com/users/hannes-ucsc","html_url":"https://github.com/hannes-ucsc","followers_url":"https://api.github.com/users/hannes-ucsc/followers","following_url":"https://api.github.com/users/hannes-ucsc/following{/other_user}","gists_url":"https://api.github.com/users/hannes-ucsc/gists{/gist_id}","starred_url":"https://api.github.com/users/hannes-ucsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannes-ucsc/subscriptions","organizations_url":"https://api.github.com/users/hannes-ucsc/orgs","repos_url":"https://api.github.com/users/hannes-ucsc/repos","events_url":"https://api.github.com/users/hannes-ucsc/events{/privacy}","received_events_url":"https://api.github.com/users/hannes-ucsc/received_events","type":"User","site_admin":false},"assignees":[{"login":"hannes-ucsc","id":5143256,"node_id":"MDQ6VXNlcjUxNDMyNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5143256?v=4","gravatar_id":"","url":"https://api.github.com/users/hannes-ucsc","html_url":"https://github.com/hannes-ucsc","followers_url":"https://api.github.com/users/hannes-ucsc/followers","following_url":"https://api.github.com/users/hannes-ucsc/following{/other_user}","gists_url":"https://api.github.com/users/hannes-ucsc/gists{/gist_id}","starred_url":"https://api.github.com/users/hannes-ucsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannes-ucsc/subscriptions","organizations_url":"https://api.github.com/users/hannes-ucsc/orgs","repos_url":"https://api.github.com/users/hannes-ucsc/repos","events_url":"https://api.github.com/users/hannes-ucsc/events{/privacy}","received_events_url":"https://api.github.com/users/hannes-ucsc/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataBiosphere/azul/pulls/534/commits","review_comments_url":"https://api.github.com/repos/DataBiosphere/azul/pulls/534/comments","review_comment_url":"https://api.github.com/repos/DataBiosphere/azul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataBiosphere/azul/issues/534/comments","statuses_url":"https://api.github.com/repos/DataBiosphere/azul/statuses/b488850b888b804c44f9c58aa1d31560c3c44e31","head":{"label":"DataBiosphere:feature/achave11/318-data-browser-fileFormat-aggregate","ref":"feature/achave11/318-data-browser-fileFormat-aggregate","sha":"b488850b888b804c44f9c58aa1d31560c3c44e31","user":{"login":"DataBiosphere","id":32805087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODA1MDg3","avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":139095537,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwOTU1Mzc=","name":"azul","full_name":"DataBiosphere/azul","private":false,"owner":{"login":"DataBiosphere","id":32805087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODA1MDg3","avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataBiosphere/azul","description":null,"fork":false,"url":"https://api.github.com/repos/DataBiosphere/azul","forks_url":"https://api.github.com/repos/DataBiosphere/azul/forks","keys_url":"https://api.github.com/repos/DataBiosphere/azul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataBiosphere/azul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataBiosphere/azul/teams","hooks_url":"https://api.github.com/repos/DataBiosphere/azul/hooks","issue_events_url":"https://api.github.com/repos/DataBiosphere/azul/issues/events{/number}","events_url":"https://api.github.com/repos/DataBiosphere/azul/events","assignees_url":"https://api.github.com/repos/DataBiosphere/azul/assignees{/user}","branches_url":"https://api.github.com/repos/DataBiosphere/azul/branches{/branch}","tags_url":"https://api.github.com/repos/DataBiosphere/azul/tags","blobs_url":"https://api.github.com/repos/DataBiosphere/azul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataBiosphere/azul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataBiosphere/azul/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataBiosphere/azul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataBiosphere/azul/statuses/{sha}","languages_url":"https://api.github.com/repos/DataBiosphere/azul/languages","stargazers_url":"https://api.github.com/repos/DataBiosphere/azul/stargazers","contributors_url":"https://api.github.com/repos/DataBiosphere/azul/contributors","subscribers_url":"https://api.github.com/repos/DataBiosphere/azul/subscribers","subscription_url":"https://api.github.com/repos/DataBiosphere/azul/subscription","commits_url":"https://api.github.com/repos/DataBiosphere/azul/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataBiosphere/azul/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataBiosphere/azul/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataBiosphere/azul/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataBiosphere/azul/contents/{+path}","compare_url":"https://api.github.com/repos/DataBiosphere/azul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataBiosphere/azul/merges","archive_url":"https://api.github.com/repos/DataBiosphere/azul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataBiosphere/azul/downloads","issues_url":"https://api.github.com/repos/DataBiosphere/azul/issues{/number}","pulls_url":"https://api.github.com/repos/DataBiosphere/azul/pulls{/number}","milestones_url":"https://api.github.com/repos/DataBiosphere/azul/milestones{/number}","notifications_url":"https://api.github.com/repos/DataBiosphere/azul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataBiosphere/azul/labels{/name}","releases_url":"https://api.github.com/repos/DataBiosphere/azul/releases{/id}","deployments_url":"https://api.github.com/repos/DataBiosphere/azul/deployments","created_at":"2018-06-29T03:18:14Z","updated_at":"2018-11-02T22:01:09Z","pushed_at":"2018-11-02T23:51:37Z","git_url":"git://github.com/DataBiosphere/azul.git","ssh_url":"git@github.com:DataBiosphere/azul.git","clone_url":"https://github.com/DataBiosphere/azul.git","svn_url":"https://github.com/DataBiosphere/azul","homepage":null,"size":11777,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":125,"watchers":4,"default_branch":"develop"}},"base":{"label":"DataBiosphere:develop","ref":"develop","sha":"908327616079addbd30b9474c12a89a6b04d2a6b","user":{"login":"DataBiosphere","id":32805087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODA1MDg3","avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":139095537,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwOTU1Mzc=","name":"azul","full_name":"DataBiosphere/azul","private":false,"owner":{"login":"DataBiosphere","id":32805087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODA1MDg3","avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataBiosphere/azul","description":null,"fork":false,"url":"https://api.github.com/repos/DataBiosphere/azul","forks_url":"https://api.github.com/repos/DataBiosphere/azul/forks","keys_url":"https://api.github.com/repos/DataBiosphere/azul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataBiosphere/azul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataBiosphere/azul/teams","hooks_url":"https://api.github.com/repos/DataBiosphere/azul/hooks","issue_events_url":"https://api.github.com/repos/DataBiosphere/azul/issues/events{/number}","events_url":"https://api.github.com/repos/DataBiosphere/azul/events","assignees_url":"https://api.github.com/repos/DataBiosphere/azul/assignees{/user}","branches_url":"https://api.github.com/repos/DataBiosphere/azul/branches{/branch}","tags_url":"https://api.github.com/repos/DataBiosphere/azul/tags","blobs_url":"https://api.github.com/repos/DataBiosphere/azul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataBiosphere/azul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataBiosphere/azul/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataBiosphere/azul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataBiosphere/azul/statuses/{sha}","languages_url":"https://api.github.com/repos/DataBiosphere/azul/languages","stargazers_url":"https://api.github.com/repos/DataBiosphere/azul/stargazers","contributors_url":"https://api.github.com/repos/DataBiosphere/azul/contributors","subscribers_url":"https://api.github.com/repos/DataBiosphere/azul/subscribers","subscription_url":"https://api.github.com/repos/DataBiosphere/azul/subscription","commits_url":"https://api.github.com/repos/DataBiosphere/azul/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataBiosphere/azul/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataBiosphere/azul/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataBiosphere/azul/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataBiosphere/azul/contents/{+path}","compare_url":"https://api.github.com/repos/DataBiosphere/azul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataBiosphere/azul/merges","archive_url":"https://api.github.com/repos/DataBiosphere/azul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataBiosphere/azul/downloads","issues_url":"https://api.github.com/repos/DataBiosphere/azul/issues{/number}","pulls_url":"https://api.github.com/repos/DataBiosphere/azul/pulls{/number}","milestones_url":"https://api.github.com/repos/DataBiosphere/azul/milestones{/number}","notifications_url":"https://api.github.com/repos/DataBiosphere/azul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataBiosphere/azul/labels{/name}","releases_url":"https://api.github.com/repos/DataBiosphere/azul/releases{/id}","deployments_url":"https://api.github.com/repos/DataBiosphere/azul/deployments","created_at":"2018-06-29T03:18:14Z","updated_at":"2018-11-02T22:01:09Z","pushed_at":"2018-11-02T23:51:37Z","git_url":"git://github.com/DataBiosphere/azul.git","ssh_url":"git@github.com:DataBiosphere/azul.git","clone_url":"https://github.com/DataBiosphere/azul.git","svn_url":"https://github.com/DataBiosphere/azul","homepage":null,"size":11777,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":125,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/DataBiosphere/azul/pulls/534"},"html":{"href":"https://github.com/DataBiosphere/azul/pull/534"},"issue":{"href":"https://api.github.com/repos/DataBiosphere/azul/issues/534"},"comments":{"href":"https://api.github.com/repos/DataBiosphere/azul/issues/534/comments"},"review_comments":{"href":"https://api.github.com/repos/DataBiosphere/azul/pulls/534/comments"},"review_comment":{"href":"https://api.github.com/repos/DataBiosphere/azul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataBiosphere/azul/pulls/534/commits"},"statuses":{"href":"https://api.github.com/repos/DataBiosphere/azul/statuses/b488850b888b804c44f9c58aa1d31560c3c44e31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hannes-ucsc"}}