{"action":"created","comment":{"url":"https://api.github.com/repos/onnx/onnx/pulls/comments/209714985","pull_request_review_id":145761961,"id":209714985,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTcxNDk4NQ==","diff_hunk":"@@ -0,0 +1,30 @@\n+// Adapter for Gemm in default domain from version 7 to 6\n+\n+#pragma once\n+\n+#include \"onnx/version_converter/adapters/adapter.h\"\n+\n+namespace ONNX_NAMESPACE { namespace version_conversion {\n+\n+class Gemm_7_6 final : public Adapter {\n+  public:\n+    explicit Gemm_7_6(): Adapter(\"Gemm\", OpSetID(7), OpSetID(6)) {}\n+\n+    void adapt_gemm_7_6(std::shared_ptr<Graph> graph, Node* node) const {\n+      const ArrayRef<Value*>& inputs = node->inputs();\n+      ONNX_ASSERTM(inputs.size() == 3, \"3 Inputs must be provided to Gemm\");\n+      // Determine if C is broadcastable\n+      ONNX_ASSERTM(inputs[2]->has_sizes(), \"C's shape must be statically determined\");","path":"onnx/version_converter/adapters/gemm_7_6.h","position":17,"original_position":17,"commit_id":"82f1f0aa5cdcf57eeaf17e934868f94d767ecf75","original_commit_id":"82f1f0aa5cdcf57eeaf17e934868f94d767ecf75","user":{"login":"houseroad","id":30275821,"node_id":"MDQ6VXNlcjMwMjc1ODIx","avatar_url":"https://avatars0.githubusercontent.com/u/30275821?v=4","gravatar_id":"","url":"https://api.github.com/users/houseroad","html_url":"https://github.com/houseroad","followers_url":"https://api.github.com/users/houseroad/followers","following_url":"https://api.github.com/users/houseroad/following{/other_user}","gists_url":"https://api.github.com/users/houseroad/gists{/gist_id}","starred_url":"https://api.github.com/users/houseroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houseroad/subscriptions","organizations_url":"https://api.github.com/users/houseroad/orgs","repos_url":"https://api.github.com/users/houseroad/repos","events_url":"https://api.github.com/users/houseroad/events{/privacy}","received_events_url":"https://api.github.com/users/houseroad/received_events","type":"User","site_admin":false},"body":"Not must be statically determined. Better to say, no enough shape information to convert the model. :-)","created_at":"2018-08-13T18:38:18Z","updated_at":"2018-08-13T18:54:00Z","html_url":"https://github.com/onnx/onnx/pull/1184#discussion_r209714985","pull_request_url":"https://api.github.com/repos/onnx/onnx/pulls/1184","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/onnx/onnx/pulls/comments/209714985"},"html":{"href":"https://github.com/onnx/onnx/pull/1184#discussion_r209714985"},"pull_request":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1184"}}},"pull_request":{"url":"https://api.github.com/repos/onnx/onnx/pulls/1184","id":200556033,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTU2MDMz","html_url":"https://github.com/onnx/onnx/pull/1184","diff_url":"https://github.com/onnx/onnx/pull/1184.diff","patch_url":"https://github.com/onnx/onnx/pull/1184.patch","issue_url":"https://api.github.com/repos/onnx/onnx/issues/1184","number":1184,"state":"open","locked":false,"title":"Model Version Converter Adapters","user":{"login":"Ac2zoom","id":3822214,"node_id":"MDQ6VXNlcjM4MjIyMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3822214?v=4","gravatar_id":"","url":"https://api.github.com/users/Ac2zoom","html_url":"https://github.com/Ac2zoom","followers_url":"https://api.github.com/users/Ac2zoom/followers","following_url":"https://api.github.com/users/Ac2zoom/following{/other_user}","gists_url":"https://api.github.com/users/Ac2zoom/gists{/gist_id}","starred_url":"https://api.github.com/users/Ac2zoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ac2zoom/subscriptions","organizations_url":"https://api.github.com/users/Ac2zoom/orgs","repos_url":"https://api.github.com/users/Ac2zoom/repos","events_url":"https://api.github.com/users/Ac2zoom/events{/privacy}","received_events_url":"https://api.github.com/users/Ac2zoom/received_events","type":"User","site_admin":false},"body":"Implementation of Version Converter adapters, particularly for Model Zoo, as outlined in internal spec\r\n\r\nWill be rebased onto version_converter until that is merged","created_at":"2018-07-11T00:12:40Z","updated_at":"2018-08-13T18:54:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"715fb347613c043a082d8655237a8b91d49634db","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anderspapitto","id":1388690,"node_id":"MDQ6VXNlcjEzODg2OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1388690?v=4","gravatar_id":"","url":"https://api.github.com/users/anderspapitto","html_url":"https://github.com/anderspapitto","followers_url":"https://api.github.com/users/anderspapitto/followers","following_url":"https://api.github.com/users/anderspapitto/following{/other_user}","gists_url":"https://api.github.com/users/anderspapitto/gists{/gist_id}","starred_url":"https://api.github.com/users/anderspapitto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anderspapitto/subscriptions","organizations_url":"https://api.github.com/users/anderspapitto/orgs","repos_url":"https://api.github.com/users/anderspapitto/repos","events_url":"https://api.github.com/users/anderspapitto/events{/privacy}","received_events_url":"https://api.github.com/users/anderspapitto/received_events","type":"User","site_admin":false},{"login":"smessmer","id":2373925,"node_id":"MDQ6VXNlcjIzNzM5MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2373925?v=4","gravatar_id":"","url":"https://api.github.com/users/smessmer","html_url":"https://github.com/smessmer","followers_url":"https://api.github.com/users/smessmer/followers","following_url":"https://api.github.com/users/smessmer/following{/other_user}","gists_url":"https://api.github.com/users/smessmer/gists{/gist_id}","starred_url":"https://api.github.com/users/smessmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smessmer/subscriptions","organizations_url":"https://api.github.com/users/smessmer/orgs","repos_url":"https://api.github.com/users/smessmer/repos","events_url":"https://api.github.com/users/smessmer/events{/privacy}","received_events_url":"https://api.github.com/users/smessmer/received_events","type":"User","site_admin":false},{"login":"bddppq","id":9300575,"node_id":"MDQ6VXNlcjkzMDA1NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9300575?v=4","gravatar_id":"","url":"https://api.github.com/users/bddppq","html_url":"https://github.com/bddppq","followers_url":"https://api.github.com/users/bddppq/followers","following_url":"https://api.github.com/users/bddppq/following{/other_user}","gists_url":"https://api.github.com/users/bddppq/gists{/gist_id}","starred_url":"https://api.github.com/users/bddppq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bddppq/subscriptions","organizations_url":"https://api.github.com/users/bddppq/orgs","repos_url":"https://api.github.com/users/bddppq/repos","events_url":"https://api.github.com/users/bddppq/events{/privacy}","received_events_url":"https://api.github.com/users/bddppq/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/onnx/onnx/pulls/1184/commits","review_comments_url":"https://api.github.com/repos/onnx/onnx/pulls/1184/comments","review_comment_url":"https://api.github.com/repos/onnx/onnx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onnx/onnx/issues/1184/comments","statuses_url":"https://api.github.com/repos/onnx/onnx/statuses/82f1f0aa5cdcf57eeaf17e934868f94d767ecf75","head":{"label":"Ac2zoom:adapters","ref":"adapters","sha":"82f1f0aa5cdcf57eeaf17e934868f94d767ecf75","user":{"login":"Ac2zoom","id":3822214,"node_id":"MDQ6VXNlcjM4MjIyMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3822214?v=4","gravatar_id":"","url":"https://api.github.com/users/Ac2zoom","html_url":"https://github.com/Ac2zoom","followers_url":"https://api.github.com/users/Ac2zoom/followers","following_url":"https://api.github.com/users/Ac2zoom/following{/other_user}","gists_url":"https://api.github.com/users/Ac2zoom/gists{/gist_id}","starred_url":"https://api.github.com/users/Ac2zoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ac2zoom/subscriptions","organizations_url":"https://api.github.com/users/Ac2zoom/orgs","repos_url":"https://api.github.com/users/Ac2zoom/repos","events_url":"https://api.github.com/users/Ac2zoom/events{/privacy}","received_events_url":"https://api.github.com/users/Ac2zoom/received_events","type":"User","site_admin":false},"repo":{"id":138069347,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgwNjkzNDc=","name":"onnx","full_name":"Ac2zoom/onnx","owner":{"login":"Ac2zoom","id":3822214,"node_id":"MDQ6VXNlcjM4MjIyMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3822214?v=4","gravatar_id":"","url":"https://api.github.com/users/Ac2zoom","html_url":"https://github.com/Ac2zoom","followers_url":"https://api.github.com/users/Ac2zoom/followers","following_url":"https://api.github.com/users/Ac2zoom/following{/other_user}","gists_url":"https://api.github.com/users/Ac2zoom/gists{/gist_id}","starred_url":"https://api.github.com/users/Ac2zoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ac2zoom/subscriptions","organizations_url":"https://api.github.com/users/Ac2zoom/orgs","repos_url":"https://api.github.com/users/Ac2zoom/repos","events_url":"https://api.github.com/users/Ac2zoom/events{/privacy}","received_events_url":"https://api.github.com/users/Ac2zoom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ac2zoom/onnx","description":"Open Neural Network Exchange","fork":true,"url":"https://api.github.com/repos/Ac2zoom/onnx","forks_url":"https://api.github.com/repos/Ac2zoom/onnx/forks","keys_url":"https://api.github.com/repos/Ac2zoom/onnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ac2zoom/onnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ac2zoom/onnx/teams","hooks_url":"https://api.github.com/repos/Ac2zoom/onnx/hooks","issue_events_url":"https://api.github.com/repos/Ac2zoom/onnx/issues/events{/number}","events_url":"https://api.github.com/repos/Ac2zoom/onnx/events","assignees_url":"https://api.github.com/repos/Ac2zoom/onnx/assignees{/user}","branches_url":"https://api.github.com/repos/Ac2zoom/onnx/branches{/branch}","tags_url":"https://api.github.com/repos/Ac2zoom/onnx/tags","blobs_url":"https://api.github.com/repos/Ac2zoom/onnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ac2zoom/onnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ac2zoom/onnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ac2zoom/onnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ac2zoom/onnx/statuses/{sha}","languages_url":"https://api.github.com/repos/Ac2zoom/onnx/languages","stargazers_url":"https://api.github.com/repos/Ac2zoom/onnx/stargazers","contributors_url":"https://api.github.com/repos/Ac2zoom/onnx/contributors","subscribers_url":"https://api.github.com/repos/Ac2zoom/onnx/subscribers","subscription_url":"https://api.github.com/repos/Ac2zoom/onnx/subscription","commits_url":"https://api.github.com/repos/Ac2zoom/onnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ac2zoom/onnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ac2zoom/onnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ac2zoom/onnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ac2zoom/onnx/contents/{+path}","compare_url":"https://api.github.com/repos/Ac2zoom/onnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ac2zoom/onnx/merges","archive_url":"https://api.github.com/repos/Ac2zoom/onnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ac2zoom/onnx/downloads","issues_url":"https://api.github.com/repos/Ac2zoom/onnx/issues{/number}","pulls_url":"https://api.github.com/repos/Ac2zoom/onnx/pulls{/number}","milestones_url":"https://api.github.com/repos/Ac2zoom/onnx/milestones{/number}","notifications_url":"https://api.github.com/repos/Ac2zoom/onnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ac2zoom/onnx/labels{/name}","releases_url":"https://api.github.com/repos/Ac2zoom/onnx/releases{/id}","deployments_url":"https://api.github.com/repos/Ac2zoom/onnx/deployments","created_at":"2018-06-20T18:11:58Z","updated_at":"2018-08-01T00:26:49Z","pushed_at":"2018-08-13T18:47:45Z","git_url":"git://github.com/Ac2zoom/onnx.git","ssh_url":"git@github.com:Ac2zoom/onnx.git","clone_url":"https://github.com/Ac2zoom/onnx.git","svn_url":"https://github.com/Ac2zoom/onnx","homepage":"https://onnx.ai/","size":6706,"stargazers_count":0,"watchers_count":0,"language":"PureBasic","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onnx:master","ref":"master","sha":"0d250dea7637effd124ba6c69cdfa22f5e964817","user":{"login":"onnx","id":31675368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjc1MzY4","avatar_url":"https://avatars3.githubusercontent.com/u/31675368?v=4","gravatar_id":"","url":"https://api.github.com/users/onnx","html_url":"https://github.com/onnx","followers_url":"https://api.github.com/users/onnx/followers","following_url":"https://api.github.com/users/onnx/following{/other_user}","gists_url":"https://api.github.com/users/onnx/gists{/gist_id}","starred_url":"https://api.github.com/users/onnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onnx/subscriptions","organizations_url":"https://api.github.com/users/onnx/orgs","repos_url":"https://api.github.com/users/onnx/repos","events_url":"https://api.github.com/users/onnx/events{/privacy}","received_events_url":"https://api.github.com/users/onnx/received_events","type":"Organization","site_admin":false},"repo":{"id":102692863,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2OTI4NjM=","name":"onnx","full_name":"onnx/onnx","owner":{"login":"onnx","id":31675368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjc1MzY4","avatar_url":"https://avatars3.githubusercontent.com/u/31675368?v=4","gravatar_id":"","url":"https://api.github.com/users/onnx","html_url":"https://github.com/onnx","followers_url":"https://api.github.com/users/onnx/followers","following_url":"https://api.github.com/users/onnx/following{/other_user}","gists_url":"https://api.github.com/users/onnx/gists{/gist_id}","starred_url":"https://api.github.com/users/onnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onnx/subscriptions","organizations_url":"https://api.github.com/users/onnx/orgs","repos_url":"https://api.github.com/users/onnx/repos","events_url":"https://api.github.com/users/onnx/events{/privacy}","received_events_url":"https://api.github.com/users/onnx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onnx/onnx","description":"Open Neural Network Exchange","fork":false,"url":"https://api.github.com/repos/onnx/onnx","forks_url":"https://api.github.com/repos/onnx/onnx/forks","keys_url":"https://api.github.com/repos/onnx/onnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onnx/onnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onnx/onnx/teams","hooks_url":"https://api.github.com/repos/onnx/onnx/hooks","issue_events_url":"https://api.github.com/repos/onnx/onnx/issues/events{/number}","events_url":"https://api.github.com/repos/onnx/onnx/events","assignees_url":"https://api.github.com/repos/onnx/onnx/assignees{/user}","branches_url":"https://api.github.com/repos/onnx/onnx/branches{/branch}","tags_url":"https://api.github.com/repos/onnx/onnx/tags","blobs_url":"https://api.github.com/repos/onnx/onnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onnx/onnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onnx/onnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/onnx/onnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onnx/onnx/statuses/{sha}","languages_url":"https://api.github.com/repos/onnx/onnx/languages","stargazers_url":"https://api.github.com/repos/onnx/onnx/stargazers","contributors_url":"https://api.github.com/repos/onnx/onnx/contributors","subscribers_url":"https://api.github.com/repos/onnx/onnx/subscribers","subscription_url":"https://api.github.com/repos/onnx/onnx/subscription","commits_url":"https://api.github.com/repos/onnx/onnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/onnx/onnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/onnx/onnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/onnx/onnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/onnx/onnx/contents/{+path}","compare_url":"https://api.github.com/repos/onnx/onnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onnx/onnx/merges","archive_url":"https://api.github.com/repos/onnx/onnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onnx/onnx/downloads","issues_url":"https://api.github.com/repos/onnx/onnx/issues{/number}","pulls_url":"https://api.github.com/repos/onnx/onnx/pulls{/number}","milestones_url":"https://api.github.com/repos/onnx/onnx/milestones{/number}","notifications_url":"https://api.github.com/repos/onnx/onnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onnx/onnx/labels{/name}","releases_url":"https://api.github.com/repos/onnx/onnx/releases{/id}","deployments_url":"https://api.github.com/repos/onnx/onnx/deployments","created_at":"2017-09-07T04:53:45Z","updated_at":"2018-08-13T18:51:53Z","pushed_at":"2018-08-13T18:47:46Z","git_url":"git://github.com/onnx/onnx.git","ssh_url":"git@github.com:onnx/onnx.git","clone_url":"https://github.com/onnx/onnx.git","svn_url":"https://github.com/onnx/onnx","homepage":"https://onnx.ai/","size":6412,"stargazers_count":4001,"watchers_count":4001,"language":"PureBasic","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":541,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":541,"open_issues":218,"watchers":4001,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1184"},"html":{"href":"https://github.com/onnx/onnx/pull/1184"},"issue":{"href":"https://api.github.com/repos/onnx/onnx/issues/1184"},"comments":{"href":"https://api.github.com/repos/onnx/onnx/issues/1184/comments"},"review_comments":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1184/comments"},"review_comment":{"href":"https://api.github.com/repos/onnx/onnx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1184/commits"},"statuses":{"href":"https://api.github.com/repos/onnx/onnx/statuses/82f1f0aa5cdcf57eeaf17e934868f94d767ecf75"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houseroad"}}