{"action":"created","comment":{"url":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/222383362","pull_request_review_id":161257187,"id":222383362,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjM4MzM2Mg==","diff_hunk":"@@ -241,11 +241,12 @@ public static void configureTransactionManager(ModelControllerClient mcc, HashMa\n         client.setDefaultTransactionTimeout(600);\n         LOG.info(\"Default transaction timeout set to 600 seconds.\");\n \n-        if(serverProperties.containsKey(ServerProperties.PROP_JBOSS_HA_NODE_ID)) {\n-            String nodeId = buildExpression(ServerProperties.PROP_JBOSS_HA_NODE_ID, serverProperties, true, false, false);\n-            client.setTransactionNodeId(nodeId);\n-            LOG.info(\"Set high availability nodeId to \" + nodeId);\n-        }\n+        // Set expression and its default regardless if a value was specified at install time\n+        final HashMap<String, String> transactionNodeIdDefault = new HashMap();\n+        transactionNodeIdDefault.put(ServerProperties.PROP_JBOSS_HA_NODE_ID, \"1\");\n+        String nodeId = buildExpression(ServerProperties.PROP_JBOSS_HA_NODE_ID, transactionNodeIdDefault, true, false, false);\n+        client.setTransactionNodeId(nodeId);\n+        LOG.info(\"Set high availability nodeId to \" + nodeId);","path":"modules/enterprise/server/installer/src/main/java/org/rhq/enterprise/server/installer/ServerInstallUtil.java","position":null,"original_position":14,"commit_id":"0a66f9787a7553e967cf374f955bab444d8012f2","original_commit_id":"d20bbcbe925a99fb6d8edce6cf8ffe143658f37b","user":{"login":"josejulio","id":3845764,"node_id":"MDQ6VXNlcjM4NDU3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3845764?v=4","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"body":"Removed.","created_at":"2018-10-03T16:42:45Z","updated_at":"2018-10-03T16:42:45Z","html_url":"https://github.com/rhq-project/rhq/pull/355#discussion_r222383362","pull_request_url":"https://api.github.com/repos/rhq-project/rhq/pulls/355","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/222383362"},"html":{"href":"https://github.com/rhq-project/rhq/pull/355#discussion_r222383362"},"pull_request":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/355"}},"in_reply_to_id":222278579},"pull_request":{"url":"https://api.github.com/repos/rhq-project/rhq/pulls/355","id":219837191,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODM3MTkx","html_url":"https://github.com/rhq-project/rhq/pull/355","diff_url":"https://github.com/rhq-project/rhq/pull/355.diff","patch_url":"https://github.com/rhq-project/rhq/pull/355.patch","issue_url":"https://api.github.com/repos/rhq-project/rhq/issues/355","number":355,"state":"open","locked":false,"title":"Bug 1630170 - Set the same properties as jboss-cli-commands.txt","user":{"login":"josejulio","id":3845764,"node_id":"MDQ6VXNlcjM4NDU3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3845764?v=4","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"body":" - Allows the installer to write jboss.tx.node.id even if not set at install time\r\n - Sets jackson.deserialization.whitelist.packages","created_at":"2018-10-02T20:37:31Z","updated_at":"2018-10-03T16:42:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"832352de734986476225ea833e61ac8f5ce4577c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rhq-project/rhq/pulls/355/commits","review_comments_url":"https://api.github.com/repos/rhq-project/rhq/pulls/355/comments","review_comment_url":"https://api.github.com/repos/rhq-project/rhq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhq-project/rhq/issues/355/comments","statuses_url":"https://api.github.com/repos/rhq-project/rhq/statuses/0a66f9787a7553e967cf374f955bab444d8012f2","head":{"label":"josejulio:bugs/1630170","ref":"bugs/1630170","sha":"0a66f9787a7553e967cf374f955bab444d8012f2","user":{"login":"josejulio","id":3845764,"node_id":"MDQ6VXNlcjM4NDU3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3845764?v=4","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"repo":{"id":44854560,"node_id":"MDEwOlJlcG9zaXRvcnk0NDg1NDU2MA==","name":"rhq","full_name":"josejulio/rhq","private":false,"owner":{"login":"josejulio","id":3845764,"node_id":"MDQ6VXNlcjM4NDU3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3845764?v=4","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"html_url":"https://github.com/josejulio/rhq","description":"RHQ system management and monitoring framework","fork":true,"url":"https://api.github.com/repos/josejulio/rhq","forks_url":"https://api.github.com/repos/josejulio/rhq/forks","keys_url":"https://api.github.com/repos/josejulio/rhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josejulio/rhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josejulio/rhq/teams","hooks_url":"https://api.github.com/repos/josejulio/rhq/hooks","issue_events_url":"https://api.github.com/repos/josejulio/rhq/issues/events{/number}","events_url":"https://api.github.com/repos/josejulio/rhq/events","assignees_url":"https://api.github.com/repos/josejulio/rhq/assignees{/user}","branches_url":"https://api.github.com/repos/josejulio/rhq/branches{/branch}","tags_url":"https://api.github.com/repos/josejulio/rhq/tags","blobs_url":"https://api.github.com/repos/josejulio/rhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josejulio/rhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josejulio/rhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/josejulio/rhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josejulio/rhq/statuses/{sha}","languages_url":"https://api.github.com/repos/josejulio/rhq/languages","stargazers_url":"https://api.github.com/repos/josejulio/rhq/stargazers","contributors_url":"https://api.github.com/repos/josejulio/rhq/contributors","subscribers_url":"https://api.github.com/repos/josejulio/rhq/subscribers","subscription_url":"https://api.github.com/repos/josejulio/rhq/subscription","commits_url":"https://api.github.com/repos/josejulio/rhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/josejulio/rhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/josejulio/rhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/josejulio/rhq/issues/comments{/number}","contents_url":"https://api.github.com/repos/josejulio/rhq/contents/{+path}","compare_url":"https://api.github.com/repos/josejulio/rhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josejulio/rhq/merges","archive_url":"https://api.github.com/repos/josejulio/rhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josejulio/rhq/downloads","issues_url":"https://api.github.com/repos/josejulio/rhq/issues{/number}","pulls_url":"https://api.github.com/repos/josejulio/rhq/pulls{/number}","milestones_url":"https://api.github.com/repos/josejulio/rhq/milestones{/number}","notifications_url":"https://api.github.com/repos/josejulio/rhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josejulio/rhq/labels{/name}","releases_url":"https://api.github.com/repos/josejulio/rhq/releases{/id}","deployments_url":"https://api.github.com/repos/josejulio/rhq/deployments","created_at":"2015-10-24T06:08:35Z","updated_at":"2018-09-24T14:56:18Z","pushed_at":"2018-10-03T16:40:05Z","git_url":"git://github.com/josejulio/rhq.git","ssh_url":"git@github.com:josejulio/rhq.git","clone_url":"https://github.com/josejulio/rhq.git","svn_url":"https://github.com/josejulio/rhq","homepage":"http://jboss.org/rhq","size":139451,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhq-project:master","ref":"master","sha":"abc9b18d43ae9ad7f389078ca280d008c6424a16","user":{"login":"rhq-project","id":1080166,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODAxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1080166?v=4","gravatar_id":"","url":"https://api.github.com/users/rhq-project","html_url":"https://github.com/rhq-project","followers_url":"https://api.github.com/users/rhq-project/followers","following_url":"https://api.github.com/users/rhq-project/following{/other_user}","gists_url":"https://api.github.com/users/rhq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rhq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhq-project/subscriptions","organizations_url":"https://api.github.com/users/rhq-project/orgs","repos_url":"https://api.github.com/users/rhq-project/repos","events_url":"https://api.github.com/users/rhq-project/events{/privacy}","received_events_url":"https://api.github.com/users/rhq-project/received_events","type":"Organization","site_admin":false},"repo":{"id":17278009,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI3ODAwOQ==","name":"rhq","full_name":"rhq-project/rhq","private":false,"owner":{"login":"rhq-project","id":1080166,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODAxNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1080166?v=4","gravatar_id":"","url":"https://api.github.com/users/rhq-project","html_url":"https://github.com/rhq-project","followers_url":"https://api.github.com/users/rhq-project/followers","following_url":"https://api.github.com/users/rhq-project/following{/other_user}","gists_url":"https://api.github.com/users/rhq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rhq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhq-project/subscriptions","organizations_url":"https://api.github.com/users/rhq-project/orgs","repos_url":"https://api.github.com/users/rhq-project/repos","events_url":"https://api.github.com/users/rhq-project/events{/privacy}","received_events_url":"https://api.github.com/users/rhq-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rhq-project/rhq","description":"RHQ system management and monitoring framework","fork":false,"url":"https://api.github.com/repos/rhq-project/rhq","forks_url":"https://api.github.com/repos/rhq-project/rhq/forks","keys_url":"https://api.github.com/repos/rhq-project/rhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhq-project/rhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhq-project/rhq/teams","hooks_url":"https://api.github.com/repos/rhq-project/rhq/hooks","issue_events_url":"https://api.github.com/repos/rhq-project/rhq/issues/events{/number}","events_url":"https://api.github.com/repos/rhq-project/rhq/events","assignees_url":"https://api.github.com/repos/rhq-project/rhq/assignees{/user}","branches_url":"https://api.github.com/repos/rhq-project/rhq/branches{/branch}","tags_url":"https://api.github.com/repos/rhq-project/rhq/tags","blobs_url":"https://api.github.com/repos/rhq-project/rhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhq-project/rhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhq-project/rhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhq-project/rhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhq-project/rhq/statuses/{sha}","languages_url":"https://api.github.com/repos/rhq-project/rhq/languages","stargazers_url":"https://api.github.com/repos/rhq-project/rhq/stargazers","contributors_url":"https://api.github.com/repos/rhq-project/rhq/contributors","subscribers_url":"https://api.github.com/repos/rhq-project/rhq/subscribers","subscription_url":"https://api.github.com/repos/rhq-project/rhq/subscription","commits_url":"https://api.github.com/repos/rhq-project/rhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhq-project/rhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhq-project/rhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhq-project/rhq/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhq-project/rhq/contents/{+path}","compare_url":"https://api.github.com/repos/rhq-project/rhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhq-project/rhq/merges","archive_url":"https://api.github.com/repos/rhq-project/rhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhq-project/rhq/downloads","issues_url":"https://api.github.com/repos/rhq-project/rhq/issues{/number}","pulls_url":"https://api.github.com/repos/rhq-project/rhq/pulls{/number}","milestones_url":"https://api.github.com/repos/rhq-project/rhq/milestones{/number}","notifications_url":"https://api.github.com/repos/rhq-project/rhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhq-project/rhq/labels{/name}","releases_url":"https://api.github.com/repos/rhq-project/rhq/releases{/id}","deployments_url":"https://api.github.com/repos/rhq-project/rhq/deployments","created_at":"2014-02-28T06:54:47Z","updated_at":"2018-10-03T10:50:54Z","pushed_at":"2018-10-03T16:40:06Z","git_url":"git://github.com/rhq-project/rhq.git","ssh_url":"git@github.com:rhq-project/rhq.git","clone_url":"https://github.com/rhq-project/rhq.git","svn_url":"https://github.com/rhq-project/rhq","homepage":"http://jboss.org/rhq","size":139517,"stargazers_count":142,"watchers_count":142,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":77,"open_issues":17,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/355"},"html":{"href":"https://github.com/rhq-project/rhq/pull/355"},"issue":{"href":"https://api.github.com/repos/rhq-project/rhq/issues/355"},"comments":{"href":"https://api.github.com/repos/rhq-project/rhq/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/rhq-project/rhq/statuses/0a66f9787a7553e967cf374f955bab444d8012f2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"josejulio"}}