{"action":"created","issue":{"url":"https://api.github.com/repos/interledgerjs/ilp-plugin-xrp-asym-server/issues/25","repository_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-xrp-asym-server","labels_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-xrp-asym-server/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-xrp-asym-server/issues/25/comments","events_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-xrp-asym-server/issues/25/events","html_url":"https://github.com/interledgerjs/ilp-plugin-xrp-asym-server/pull/25","id":300402601,"number":25,"title":"Feat: use channel watcher","user":{"login":"sharafian","id":3362563,"avatar_url":"https://avatars0.githubusercontent.com/u/3362563?v=4","gravatar_id":"","url":"https://api.github.com/users/sharafian","html_url":"https://github.com/sharafian","followers_url":"https://api.github.com/users/sharafian/followers","following_url":"https://api.github.com/users/sharafian/following{/other_user}","gists_url":"https://api.github.com/users/sharafian/gists{/gist_id}","starred_url":"https://api.github.com/users/sharafian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharafian/subscriptions","organizations_url":"https://api.github.com/users/sharafian/orgs","repos_url":"https://api.github.com/users/sharafian/repos","events_url":"https://api.github.com/users/sharafian/events{/privacy}","received_events_url":"https://api.github.com/users/sharafian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-26T21:28:17Z","updated_at":"2018-03-12T18:21:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/interledgerjs/ilp-plugin-xrp-asym-server/pulls/25","html_url":"https://github.com/interledgerjs/ilp-plugin-xrp-asym-server/pull/25","diff_url":"https://github.com/interledgerjs/ilp-plugin-xrp-asym-server/pull/25.diff","patch_url":"https://github.com/interledgerjs/ilp-plugin-xrp-asym-server/pull/25.patch"},"body":"The watcher was instantiated but wasn't used in previous versions. This isn't closing a critical vulnerability, but it makes sure that the server cleans up its outgoing payment channels when one of its clients closes their channel to the server."},"comment":{"url":"https://api.github.com/repos/interledgerjs/ilp-plugin-xrp-asym-server/issues/comments/372413303","html_url":"https://github.com/interledgerjs/ilp-plugin-xrp-asym-server/pull/25#issuecomment-372413303","issue_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-xrp-asym-server/issues/25","id":372413303,"user":{"login":"sharafian","id":3362563,"avatar_url":"https://avatars0.githubusercontent.com/u/3362563?v=4","gravatar_id":"","url":"https://api.github.com/users/sharafian","html_url":"https://github.com/sharafian","followers_url":"https://api.github.com/users/sharafian/followers","following_url":"https://api.github.com/users/sharafian/following{/other_user}","gists_url":"https://api.github.com/users/sharafian/gists{/gist_id}","starred_url":"https://api.github.com/users/sharafian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharafian/subscriptions","organizations_url":"https://api.github.com/users/sharafian/orgs","repos_url":"https://api.github.com/users/sharafian/repos","events_url":"https://api.github.com/users/sharafian/events{/privacy}","received_events_url":"https://api.github.com/users/sharafian/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T18:21:53Z","updated_at":"2018-03-12T18:21:53Z","author_association":"CONTRIBUTOR","body":"As of right now, I think this is a step forward for the channel closing behavior. I don't think it's safe for us to delete the channel until we get the reliable transaction submission stuff more robust. For now the client just shouldn't close their channel to the connector."}}
{"actor":{"display_login":"sharafian"}}