{"action":"created","comment":{"url":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/comments/238022881","pull_request_review_id":180475220,"id":238022881,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODAyMjg4MQ==","diff_hunk":"@@ -22,18 +22,42 @@ class PaymentAction {\n    * @return {undefined}\n    */\n   listenForUrl(ipc) {\n-    ipc.listen('open-url', async (event, url) => {\n-      log.info('open-url', url);\n-      if (!isLnUri(url)) {\n-        return;\n-      }\n-      while (!this._store.lndReady) {\n-        this._tOpenUri = await nap(100);\n-      }\n-      this.init();\n-      this.setAddress({ address: url.replace(PREFIX_URI, '') });\n-      this.checkType();\n-    });\n+    ipc.listen('open-url', (event, url) => this._openUrl(url));\n+  }\n+\n+  /**\n+   * Set the listener for the mobile app to handle incoming URIs\n+   * containing lightning invoices.\n+   * @param  {Object} Linking The expo api to handle incoming uris\n+   * @return {undefined}\n+   */\n+  async listenForUrlMobile(Linking) {\n+    Linking.addEventListener('url', ({ url }) => this._openUrl(url));\n+    const url = await Linking.getInitialURL();\n+    if (!url) {\n+      return;\n+    }\n+    while (!this._store.navReady) {\n+      this._tOpenUri = await nap(100);","path":"src/action/payment.js","position":32,"original_position":32,"commit_id":"fe52a3a922d72134508f4f2cd597746d3017d985","original_commit_id":"fe52a3a922d72134508f4f2cd597746d3017d985","user":{"login":"valentinewallace","id":10647624,"node_id":"MDQ6VXNlcjEwNjQ3NjI0","avatar_url":"https://avatars0.githubusercontent.com/u/10647624?v=4","gravatar_id":"","url":"https://api.github.com/users/valentinewallace","html_url":"https://github.com/valentinewallace","followers_url":"https://api.github.com/users/valentinewallace/followers","following_url":"https://api.github.com/users/valentinewallace/following{/other_user}","gists_url":"https://api.github.com/users/valentinewallace/gists{/gist_id}","starred_url":"https://api.github.com/users/valentinewallace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentinewallace/subscriptions","organizations_url":"https://api.github.com/users/valentinewallace/orgs","repos_url":"https://api.github.com/users/valentinewallace/repos","events_url":"https://api.github.com/users/valentinewallace/events{/privacy}","received_events_url":"https://api.github.com/users/valentinewallace/received_events","type":"User","site_admin":false},"body":"Can we replace this line with simply: `await nap(100)`? (and similarly on line `45` and `56`)","created_at":"2018-11-30T22:31:51Z","updated_at":"2018-11-30T22:49:22Z","html_url":"https://github.com/lightninglabs/lightning-app/pull/816#discussion_r238022881","pull_request_url":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/816","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/comments/238022881"},"html":{"href":"https://github.com/lightninglabs/lightning-app/pull/816#discussion_r238022881"},"pull_request":{"href":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/816"}}},"pull_request":{"url":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/816","id":234713424,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzEzNDI0","html_url":"https://github.com/lightninglabs/lightning-app/pull/816","diff_url":"https://github.com/lightninglabs/lightning-app/pull/816.diff","patch_url":"https://github.com/lightninglabs/lightning-app/pull/816.patch","issue_url":"https://api.github.com/repos/lightninglabs/lightning-app/issues/816","number":816,"state":"open","locked":false,"title":"Payment mobile","user":{"login":"tanx","id":1374174,"node_id":"MDQ6VXNlcjEzNzQxNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1374174?v=4","gravatar_id":"","url":"https://api.github.com/users/tanx","html_url":"https://github.com/tanx","followers_url":"https://api.github.com/users/tanx/followers","following_url":"https://api.github.com/users/tanx/following{/other_user}","gists_url":"https://api.github.com/users/tanx/gists{/gist_id}","starred_url":"https://api.github.com/users/tanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanx/subscriptions","organizations_url":"https://api.github.com/users/tanx/orgs","repos_url":"https://api.github.com/users/tanx/repos","events_url":"https://api.github.com/users/tanx/events{/privacy}","received_events_url":"https://api.github.com/users/tanx/received_events","type":"User","site_admin":false},"body":"Closes #815, closes #814 ","created_at":"2018-11-29T16:57:08Z","updated_at":"2018-11-30T22:49:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a2884487b861ea0024f46f90185506899c231b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/816/commits","review_comments_url":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/816/comments","review_comment_url":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightninglabs/lightning-app/issues/816/comments","statuses_url":"https://api.github.com/repos/lightninglabs/lightning-app/statuses/fe52a3a922d72134508f4f2cd597746d3017d985","head":{"label":"lightninglabs:payment-mobile","ref":"payment-mobile","sha":"fe52a3a922d72134508f4f2cd597746d3017d985","user":{"login":"lightninglabs","id":24724349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzI0MzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/24724349?v=4","gravatar_id":"","url":"https://api.github.com/users/lightninglabs","html_url":"https://github.com/lightninglabs","followers_url":"https://api.github.com/users/lightninglabs/followers","following_url":"https://api.github.com/users/lightninglabs/following{/other_user}","gists_url":"https://api.github.com/users/lightninglabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lightninglabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightninglabs/subscriptions","organizations_url":"https://api.github.com/users/lightninglabs/orgs","repos_url":"https://api.github.com/users/lightninglabs/repos","events_url":"https://api.github.com/users/lightninglabs/events{/privacy}","received_events_url":"https://api.github.com/users/lightninglabs/received_events","type":"Organization","site_admin":false},"repo":{"id":76898197,"node_id":"MDEwOlJlcG9zaXRvcnk3Njg5ODE5Nw==","name":"lightning-app","full_name":"lightninglabs/lightning-app","private":false,"owner":{"login":"lightninglabs","id":24724349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzI0MzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/24724349?v=4","gravatar_id":"","url":"https://api.github.com/users/lightninglabs","html_url":"https://github.com/lightninglabs","followers_url":"https://api.github.com/users/lightninglabs/followers","following_url":"https://api.github.com/users/lightninglabs/following{/other_user}","gists_url":"https://api.github.com/users/lightninglabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lightninglabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightninglabs/subscriptions","organizations_url":"https://api.github.com/users/lightninglabs/orgs","repos_url":"https://api.github.com/users/lightninglabs/repos","events_url":"https://api.github.com/users/lightninglabs/events{/privacy}","received_events_url":"https://api.github.com/users/lightninglabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightninglabs/lightning-app","description":"Cross-platform Lightning Application ","fork":false,"url":"https://api.github.com/repos/lightninglabs/lightning-app","forks_url":"https://api.github.com/repos/lightninglabs/lightning-app/forks","keys_url":"https://api.github.com/repos/lightninglabs/lightning-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightninglabs/lightning-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightninglabs/lightning-app/teams","hooks_url":"https://api.github.com/repos/lightninglabs/lightning-app/hooks","issue_events_url":"https://api.github.com/repos/lightninglabs/lightning-app/issues/events{/number}","events_url":"https://api.github.com/repos/lightninglabs/lightning-app/events","assignees_url":"https://api.github.com/repos/lightninglabs/lightning-app/assignees{/user}","branches_url":"https://api.github.com/repos/lightninglabs/lightning-app/branches{/branch}","tags_url":"https://api.github.com/repos/lightninglabs/lightning-app/tags","blobs_url":"https://api.github.com/repos/lightninglabs/lightning-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightninglabs/lightning-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightninglabs/lightning-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightninglabs/lightning-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightninglabs/lightning-app/statuses/{sha}","languages_url":"https://api.github.com/repos/lightninglabs/lightning-app/languages","stargazers_url":"https://api.github.com/repos/lightninglabs/lightning-app/stargazers","contributors_url":"https://api.github.com/repos/lightninglabs/lightning-app/contributors","subscribers_url":"https://api.github.com/repos/lightninglabs/lightning-app/subscribers","subscription_url":"https://api.github.com/repos/lightninglabs/lightning-app/subscription","commits_url":"https://api.github.com/repos/lightninglabs/lightning-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightninglabs/lightning-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightninglabs/lightning-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightninglabs/lightning-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightninglabs/lightning-app/contents/{+path}","compare_url":"https://api.github.com/repos/lightninglabs/lightning-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightninglabs/lightning-app/merges","archive_url":"https://api.github.com/repos/lightninglabs/lightning-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightninglabs/lightning-app/downloads","issues_url":"https://api.github.com/repos/lightninglabs/lightning-app/issues{/number}","pulls_url":"https://api.github.com/repos/lightninglabs/lightning-app/pulls{/number}","milestones_url":"https://api.github.com/repos/lightninglabs/lightning-app/milestones{/number}","notifications_url":"https://api.github.com/repos/lightninglabs/lightning-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightninglabs/lightning-app/labels{/name}","releases_url":"https://api.github.com/repos/lightninglabs/lightning-app/releases{/id}","deployments_url":"https://api.github.com/repos/lightninglabs/lightning-app/deployments","created_at":"2016-12-19T21:21:03Z","updated_at":"2018-11-29T13:43:51Z","pushed_at":"2018-11-30T14:32:48Z","git_url":"git://github.com/lightninglabs/lightning-app.git","ssh_url":"git@github.com:lightninglabs/lightning-app.git","clone_url":"https://github.com/lightninglabs/lightning-app.git","svn_url":"https://github.com/lightninglabs/lightning-app","homepage":"","size":22466,"stargazers_count":612,"watchers_count":612,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":118,"open_issues":111,"watchers":612,"default_branch":"master"}},"base":{"label":"lightninglabs:master","ref":"master","sha":"351b2455fbb480a98a48b4815444bc207d2500f8","user":{"login":"lightninglabs","id":24724349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzI0MzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/24724349?v=4","gravatar_id":"","url":"https://api.github.com/users/lightninglabs","html_url":"https://github.com/lightninglabs","followers_url":"https://api.github.com/users/lightninglabs/followers","following_url":"https://api.github.com/users/lightninglabs/following{/other_user}","gists_url":"https://api.github.com/users/lightninglabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lightninglabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightninglabs/subscriptions","organizations_url":"https://api.github.com/users/lightninglabs/orgs","repos_url":"https://api.github.com/users/lightninglabs/repos","events_url":"https://api.github.com/users/lightninglabs/events{/privacy}","received_events_url":"https://api.github.com/users/lightninglabs/received_events","type":"Organization","site_admin":false},"repo":{"id":76898197,"node_id":"MDEwOlJlcG9zaXRvcnk3Njg5ODE5Nw==","name":"lightning-app","full_name":"lightninglabs/lightning-app","private":false,"owner":{"login":"lightninglabs","id":24724349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzI0MzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/24724349?v=4","gravatar_id":"","url":"https://api.github.com/users/lightninglabs","html_url":"https://github.com/lightninglabs","followers_url":"https://api.github.com/users/lightninglabs/followers","following_url":"https://api.github.com/users/lightninglabs/following{/other_user}","gists_url":"https://api.github.com/users/lightninglabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lightninglabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightninglabs/subscriptions","organizations_url":"https://api.github.com/users/lightninglabs/orgs","repos_url":"https://api.github.com/users/lightninglabs/repos","events_url":"https://api.github.com/users/lightninglabs/events{/privacy}","received_events_url":"https://api.github.com/users/lightninglabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightninglabs/lightning-app","description":"Cross-platform Lightning Application ","fork":false,"url":"https://api.github.com/repos/lightninglabs/lightning-app","forks_url":"https://api.github.com/repos/lightninglabs/lightning-app/forks","keys_url":"https://api.github.com/repos/lightninglabs/lightning-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightninglabs/lightning-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightninglabs/lightning-app/teams","hooks_url":"https://api.github.com/repos/lightninglabs/lightning-app/hooks","issue_events_url":"https://api.github.com/repos/lightninglabs/lightning-app/issues/events{/number}","events_url":"https://api.github.com/repos/lightninglabs/lightning-app/events","assignees_url":"https://api.github.com/repos/lightninglabs/lightning-app/assignees{/user}","branches_url":"https://api.github.com/repos/lightninglabs/lightning-app/branches{/branch}","tags_url":"https://api.github.com/repos/lightninglabs/lightning-app/tags","blobs_url":"https://api.github.com/repos/lightninglabs/lightning-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightninglabs/lightning-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightninglabs/lightning-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightninglabs/lightning-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightninglabs/lightning-app/statuses/{sha}","languages_url":"https://api.github.com/repos/lightninglabs/lightning-app/languages","stargazers_url":"https://api.github.com/repos/lightninglabs/lightning-app/stargazers","contributors_url":"https://api.github.com/repos/lightninglabs/lightning-app/contributors","subscribers_url":"https://api.github.com/repos/lightninglabs/lightning-app/subscribers","subscription_url":"https://api.github.com/repos/lightninglabs/lightning-app/subscription","commits_url":"https://api.github.com/repos/lightninglabs/lightning-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightninglabs/lightning-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightninglabs/lightning-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightninglabs/lightning-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightninglabs/lightning-app/contents/{+path}","compare_url":"https://api.github.com/repos/lightninglabs/lightning-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightninglabs/lightning-app/merges","archive_url":"https://api.github.com/repos/lightninglabs/lightning-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightninglabs/lightning-app/downloads","issues_url":"https://api.github.com/repos/lightninglabs/lightning-app/issues{/number}","pulls_url":"https://api.github.com/repos/lightninglabs/lightning-app/pulls{/number}","milestones_url":"https://api.github.com/repos/lightninglabs/lightning-app/milestones{/number}","notifications_url":"https://api.github.com/repos/lightninglabs/lightning-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightninglabs/lightning-app/labels{/name}","releases_url":"https://api.github.com/repos/lightninglabs/lightning-app/releases{/id}","deployments_url":"https://api.github.com/repos/lightninglabs/lightning-app/deployments","created_at":"2016-12-19T21:21:03Z","updated_at":"2018-11-29T13:43:51Z","pushed_at":"2018-11-30T14:32:48Z","git_url":"git://github.com/lightninglabs/lightning-app.git","ssh_url":"git@github.com:lightninglabs/lightning-app.git","clone_url":"https://github.com/lightninglabs/lightning-app.git","svn_url":"https://github.com/lightninglabs/lightning-app","homepage":"","size":22466,"stargazers_count":612,"watchers_count":612,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":118,"open_issues":111,"watchers":612,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/816"},"html":{"href":"https://github.com/lightninglabs/lightning-app/pull/816"},"issue":{"href":"https://api.github.com/repos/lightninglabs/lightning-app/issues/816"},"comments":{"href":"https://api.github.com/repos/lightninglabs/lightning-app/issues/816/comments"},"review_comments":{"href":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/816/comments"},"review_comment":{"href":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightninglabs/lightning-app/pulls/816/commits"},"statuses":{"href":"https://api.github.com/repos/lightninglabs/lightning-app/statuses/fe52a3a922d72134508f4f2cd597746d3017d985"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"valentinewallace"}}