{"action":"opened","issue":{"url":"https://api.github.com/repos/wikimedia/eslint-config-wikimedia/issues/103","repository_url":"https://api.github.com/repos/wikimedia/eslint-config-wikimedia","labels_url":"https://api.github.com/repos/wikimedia/eslint-config-wikimedia/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/eslint-config-wikimedia/issues/103/comments","events_url":"https://api.github.com/repos/wikimedia/eslint-config-wikimedia/issues/103/events","html_url":"https://github.com/wikimedia/eslint-config-wikimedia/issues/103","id":361287508,"node_id":"MDU6SXNzdWUzNjEyODc1MDg=","number":103,"title":"Upgrade to eslint 5.6","user":{"login":"edg2s","id":180672,"node_id":"MDQ6VXNlcjE4MDY3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/180672?v=4","gravatar_id":"","url":"https://api.github.com/users/edg2s","html_url":"https://github.com/edg2s","followers_url":"https://api.github.com/users/edg2s/followers","following_url":"https://api.github.com/users/edg2s/following{/other_user}","gists_url":"https://api.github.com/users/edg2s/gists{/gist_id}","starred_url":"https://api.github.com/users/edg2s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edg2s/subscriptions","organizations_url":"https://api.github.com/users/edg2s/orgs","repos_url":"https://api.github.com/users/edg2s/repos","events_url":"https://api.github.com/users/edg2s/events{/privacy}","received_events_url":"https://api.github.com/users/edg2s/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-18T12:47:40Z","updated_at":"2018-09-18T12:47:40Z","closed_at":null,"author_association":"MEMBER","body":"Significant changes:\r\n\r\n5.1:\r\nThe `no-catch-shadow rule` has been deprecated in favor of `no-shadow`.\r\n - we don't use this\r\n\r\n5.3:\r\n- `no-misleading-character-class` reports multi-code-point characters in regular expression character classes. Using these characters in character classes often results in surprising behavior.\r\n- `require-atomic-updates` reports potential race conditions that result from updating values in async or generator functions.\r\n- `no-async-promise-executor` reports uses of the Promise constructor that have an async function as the argument. Using an async function in this scenario is not necessary and a potential source of bugs.\r\n- `require-unicode-regexp` requires all regular expressions to have the u flag. Regular expressions with the u flag have stricter parsing rules and handle unicode text more sensibly, which is useful to avoid unexpected behavior when writing regular expressions.\r\n\r\nWe should probably enable [no-misleading-character-class](https://eslint.org/docs/rules/no-misleading-character-class) (although unicodeJS will probably want to disable it :) ). The other unicode regex rule is too strict, and the other two rules are ES6 specific, so I have no opinion on them."}}
{"actor":{"display_login":"edg2s"}}