{"action":"created","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/3866","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/3866/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/3866/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/3866/events","html_url":"https://github.com/publiclab/plots2/pull/3866","id":375992817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzA5ODIw","number":3866,"title":"Fixed Show more of table","user":{"login":"shubhscoder","id":18489285,"node_id":"MDQ6VXNlcjE4NDg5Mjg1","avatar_url":"https://avatars3.githubusercontent.com/u/18489285?v=4","gravatar_id":"","url":"https://api.github.com/users/shubhscoder","html_url":"https://github.com/shubhscoder","followers_url":"https://api.github.com/users/shubhscoder/followers","following_url":"https://api.github.com/users/shubhscoder/following{/other_user}","gists_url":"https://api.github.com/users/shubhscoder/gists{/gist_id}","starred_url":"https://api.github.com/users/shubhscoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubhscoder/subscriptions","organizations_url":"https://api.github.com/users/shubhscoder/orgs","repos_url":"https://api.github.com/users/shubhscoder/repos","events_url":"https://api.github.com/users/shubhscoder/events{/privacy}","received_events_url":"https://api.github.com/users/shubhscoder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-10-31T14:34:23Z","updated_at":"2018-11-14T16:16:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/3866","html_url":"https://github.com/publiclab/plots2/pull/3866","diff_url":"https://github.com/publiclab/plots2/pull/3866.diff","patch_url":"https://github.com/publiclab/plots2/pull/3866.patch"},"body":"Fixes  #3654 \r\n\r\nProblem:\r\nThere were some problems in the show more button on the learn more page of infragram.\r\n\r\n1. Let's say that there were 10 more items to be viewed in the  table, the show more button said \"Show 10 more items\". Now,even after the user has clicked that once, it said the same text \"Show 10 more items\", which may confuse the user.\r\n\r\n2.If there were exact 10 items  in the table then the show more button said \"Show 0 more items\" which doesn't make much sense.\r\n\r\nChanges Proposed:\r\n1. Once the user clicks the button the text vanishes.\r\n2. Also the button is displayed only in case there are strictly more than 10 items in the table. This fixes the second problem.\r\n\r\nSince views were changed, the relevant screen shots are attached. \r\n\r\n\r\n![before_clicking](https://user-images.githubusercontent.com/18489285/47795276-4c29ed00-dd48-11e8-897a-42bbd4b1cfaa.png)\r\n![after_clicking](https://user-images.githubusercontent.com/18489285/47795304-55b35500-dd48-11e8-8488-a6e4056726e1.png)\r\n"},"comment":{"url":"https://api.github.com/repos/publiclab/plots2/issues/comments/438721019","html_url":"https://github.com/publiclab/plots2/pull/3866#issuecomment-438721019","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/3866","id":438721019,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODcyMTAxOQ==","user":{"login":"shubhscoder","id":18489285,"node_id":"MDQ6VXNlcjE4NDg5Mjg1","avatar_url":"https://avatars3.githubusercontent.com/u/18489285?v=4","gravatar_id":"","url":"https://api.github.com/users/shubhscoder","html_url":"https://github.com/shubhscoder","followers_url":"https://api.github.com/users/shubhscoder/followers","following_url":"https://api.github.com/users/shubhscoder/following{/other_user}","gists_url":"https://api.github.com/users/shubhscoder/gists{/gist_id}","starred_url":"https://api.github.com/users/shubhscoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubhscoder/subscriptions","organizations_url":"https://api.github.com/users/shubhscoder/orgs","repos_url":"https://api.github.com/users/shubhscoder/repos","events_url":"https://api.github.com/users/shubhscoder/events{/privacy}","received_events_url":"https://api.github.com/users/shubhscoder/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T16:16:12Z","updated_at":"2018-11-14T16:16:12Z","author_association":"CONTRIBUTOR","body":"If the gif seems fine to you then this can be reviewed. Thank you!"}}
{"actor":{"display_login":"shubhscoder"}}