{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11316","repository_url":"https://api.github.com/repos/apache/incubator-mxnet","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11316/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11316/comments","events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11316/events","html_url":"https://github.com/apache/incubator-mxnet/pull/11316","id":332929569,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Mjk1MDY2","number":11316,"title":"MXNET_FORCE_ADDTAKEGRAD to disable AddTakeGradLargeBatchCaller","user":{"login":"leezu","id":946903,"node_id":"MDQ6VXNlcjk0NjkwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/946903?v=4","gravatar_id":"","url":"https://api.github.com/users/leezu","html_url":"https://github.com/leezu","followers_url":"https://api.github.com/users/leezu/followers","following_url":"https://api.github.com/users/leezu/following{/other_user}","gists_url":"https://api.github.com/users/leezu/gists{/gist_id}","starred_url":"https://api.github.com/users/leezu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leezu/subscriptions","organizations_url":"https://api.github.com/users/leezu/orgs","repos_url":"https://api.github.com/users/leezu/repos","events_url":"https://api.github.com/users/leezu/events{/privacy}","received_events_url":"https://api.github.com/users/leezu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-15T22:20:39Z","updated_at":"2018-06-15T22:28:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11316","html_url":"https://github.com/apache/incubator-mxnet/pull/11316","diff_url":"https://github.com/apache/incubator-mxnet/pull/11316.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/11316.patch"},"body":"Adds an environment variable that allows working around #11314 until a proper fix is found."},"comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments/397758053","html_url":"https://github.com/apache/incubator-mxnet/pull/11316#issuecomment-397758053","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11316","id":397758053,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzc1ODA1Mw==","user":{"login":"eric-haibin-lin","id":5545640,"node_id":"MDQ6VXNlcjU1NDU2NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5545640?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-haibin-lin","html_url":"https://github.com/eric-haibin-lin","followers_url":"https://api.github.com/users/eric-haibin-lin/followers","following_url":"https://api.github.com/users/eric-haibin-lin/following{/other_user}","gists_url":"https://api.github.com/users/eric-haibin-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-haibin-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-haibin-lin/subscriptions","organizations_url":"https://api.github.com/users/eric-haibin-lin/orgs","repos_url":"https://api.github.com/users/eric-haibin-lin/repos","events_url":"https://api.github.com/users/eric-haibin-lin/events{/privacy}","received_events_url":"https://api.github.com/users/eric-haibin-lin/received_events","type":"User","site_admin":false},"created_at":"2018-06-15T22:28:39Z","updated_at":"2018-06-15T22:28:39Z","author_association":"CONTRIBUTOR","body":"Excellent finding! \r\nWorse case we can modify the sparse kernel a bit (just remove the lookup table) and use it for normal dense embedding, if its performance is close to the disabled one.\r\nhttps://github.com/apache/incubator-mxnet/blob/master/src/operator/tensor/indexing_op.cu#L76-L87 \r\nThe kernel you disabled is contributed by NVDIA, quite complicated and hard to debug if I were the person to investigate it.. https://github.com/apache/incubator-mxnet/blob/master/src/operator/tensor/indexing_op-inl.cuh#L42 \r\n"}}
{"actor":{"display_login":"eric-haibin-lin"}}