{"action":"created","issue":{"url":"https://api.github.com/repos/qzind/tray/issues/289","repository_url":"https://api.github.com/repos/qzind/tray","labels_url":"https://api.github.com/repos/qzind/tray/issues/289/labels{/name}","comments_url":"https://api.github.com/repos/qzind/tray/issues/289/comments","events_url":"https://api.github.com/repos/qzind/tray/issues/289/events","html_url":"https://github.com/qzind/tray/pull/289","id":308299979,"number":289,"title":"Various HID Improvements","user":{"login":"tresf","id":6345473,"avatar_url":"https://avatars0.githubusercontent.com/u/6345473?v=4","gravatar_id":"","url":"https://api.github.com/users/tresf","html_url":"https://github.com/tresf","followers_url":"https://api.github.com/users/tresf/followers","following_url":"https://api.github.com/users/tresf/following{/other_user}","gists_url":"https://api.github.com/users/tresf/gists{/gist_id}","starred_url":"https://api.github.com/users/tresf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tresf/subscriptions","organizations_url":"https://api.github.com/users/tresf/orgs","repos_url":"https://api.github.com/users/tresf/repos","events_url":"https://api.github.com/users/tresf/events{/privacy}","received_events_url":"https://api.github.com/users/tresf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-24T21:22:35Z","updated_at":"2018-03-27T01:02:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/qzind/tray/pulls/289","html_url":"https://github.com/qzind/tray/pull/289","diff_url":"https://github.com/qzind/tray/pull/289.diff","patch_url":"https://github.com/qzind/tray/pull/289.patch"},"body":"Some important improvements to HID:\r\n\r\n1. Provides two new parameters to the `qz.hid.claimDevice` and friends... \r\n   *  `usagePage`: Allows devices such as the Honewell Barcode scanners to be claimed per #288.\r\n   * `serial`: Allows multiple identical devices to be attached to the same computer by providing `serial` parameter.\r\n\r\n2. Provides a byte buffer for streaming HID data on Windows per #286.\r\n\r\nThis PR affects the API.  Backwards compatibility is maintained, but the `qz.hid.claimDevice` signature has been changed:\r\n\r\n**Before:**\r\n```js\r\nqz.hid.claimDevice('0x0000', '0x0000');\r\n```\r\n\r\n**After:**\r\n```js\r\nqz.hid.claimDevice({ vendorId: '0x0000', productId: '0x0000' });\r\n```\r\n\r\nThis has some added benefits, mainly, a \"device\" object can be passed directly from `qz.hid.listDevices` directly into `qz.hid.claimDevice`.  The wiki does not yet spell this out.  This feature is available in QZ Tray 2.0.6 and higher.\r\n\r\nCloses #286, #288"},"comment":{"url":"https://api.github.com/repos/qzind/tray/issues/comments/376360985","html_url":"https://github.com/qzind/tray/pull/289#issuecomment-376360985","issue_url":"https://api.github.com/repos/qzind/tray/issues/289","id":376360985,"user":{"login":"tresf","id":6345473,"avatar_url":"https://avatars0.githubusercontent.com/u/6345473?v=4","gravatar_id":"","url":"https://api.github.com/users/tresf","html_url":"https://github.com/tresf","followers_url":"https://api.github.com/users/tresf/followers","following_url":"https://api.github.com/users/tresf/following{/other_user}","gists_url":"https://api.github.com/users/tresf/gists{/gist_id}","starred_url":"https://api.github.com/users/tresf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tresf/subscriptions","organizations_url":"https://api.github.com/users/tresf/orgs","repos_url":"https://api.github.com/users/tresf/repos","events_url":"https://api.github.com/users/tresf/events{/privacy}","received_events_url":"https://api.github.com/users/tresf/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T01:02:18Z","updated_at":"2018-03-27T01:02:18Z","author_association":"CONTRIBUTOR","body":"@klabarge thanks for reporting.  This appears to be a regression caused by dde77988eb273a647d3ff47d54253e237aed2285.  Assigning @Vzor- to investigate.  I think we forgot to bring forward our custom code and we've run into #137 again."}}
{"actor":{"display_login":"tresf"}}