{"action":"created","comment":{"url":"https://api.github.com/repos/zcash/zcash/pulls/comments/212737282","pull_request_review_id":149438558,"id":212737282,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjczNzI4Mg==","diff_hunk":"@@ -186,13 +186,16 @@ TEST(WalletTests, FindUnspentSproutNotes) {\n     EXPECT_FALSE(wallet.IsSproutSpent(nullifier));\n \n     // We currently have an unspent and unconfirmed note in the wallet (depth of -1)\n-    std::vector<CSproutNotePlaintextEntry> entries;\n-    wallet.GetFilteredNotes(entries, \"\", 0);\n-    EXPECT_EQ(0, entries.size());\n-    entries.clear();\n-    wallet.GetFilteredNotes(entries, \"\", -1);\n-    EXPECT_EQ(1, entries.size());\n-    entries.clear();\n+    std::vector<CSproutNotePlaintextEntry> sproutEntries;\n+    std::vector<SaplingNoteEntry> saplingEntries;","path":"src/wallet/gtest/test_wallet.cpp","position":12,"original_position":12,"commit_id":"d316992f554d3233adff15f6d69d802fb72e0a23","original_commit_id":"d316992f554d3233adff15f6d69d802fb72e0a23","user":{"login":"arielgabizon","id":5689834,"node_id":"MDQ6VXNlcjU2ODk4MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5689834?v=4","gravatar_id":"","url":"https://api.github.com/users/arielgabizon","html_url":"https://github.com/arielgabizon","followers_url":"https://api.github.com/users/arielgabizon/followers","following_url":"https://api.github.com/users/arielgabizon/following{/other_user}","gists_url":"https://api.github.com/users/arielgabizon/gists{/gist_id}","starred_url":"https://api.github.com/users/arielgabizon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielgabizon/subscriptions","organizations_url":"https://api.github.com/users/arielgabizon/orgs","repos_url":"https://api.github.com/users/arielgabizon/repos","events_url":"https://api.github.com/users/arielgabizon/events{/privacy}","received_events_url":"https://api.github.com/users/arielgabizon/received_events","type":"User","site_admin":false},"body":"why is it note plaintexts for sprout and notes for sapling here?","created_at":"2018-08-24T19:49:53Z","updated_at":"2018-08-24T19:49:53Z","html_url":"https://github.com/zcash/zcash/pull/3436#discussion_r212737282","pull_request_url":"https://api.github.com/repos/zcash/zcash/pulls/3436","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments/212737282"},"html":{"href":"https://github.com/zcash/zcash/pull/3436#discussion_r212737282"},"pull_request":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3436"}}},"pull_request":{"url":"https://api.github.com/repos/zcash/zcash/pulls/3436","id":205279401,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Mjc5NDAx","html_url":"https://github.com/zcash/zcash/pull/3436","diff_url":"https://github.com/zcash/zcash/pull/3436.diff","patch_url":"https://github.com/zcash/zcash/pull/3436.patch","issue_url":"https://api.github.com/repos/zcash/zcash/issues/3436","number":3436,"state":"open","locked":false,"title":"Add Sapling support to z_getbalance and z_gettotalbalance","user":{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"body":"Also includes preparatory changes for various other RPCs that depend on `GetFilteredNotes` etc.\r\n\r\nCloses #3214.","created_at":"2018-08-01T00:40:24Z","updated_at":"2018-08-24T19:49:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c807516c3e66f609fc1124b7290c5963e8ac1822","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Eirik0","id":6133620,"node_id":"MDQ6VXNlcjYxMzM2MjA=","avatar_url":"https://avatars1.githubusercontent.com/u/6133620?v=4","gravatar_id":"","url":"https://api.github.com/users/Eirik0","html_url":"https://github.com/Eirik0","followers_url":"https://api.github.com/users/Eirik0/followers","following_url":"https://api.github.com/users/Eirik0/following{/other_user}","gists_url":"https://api.github.com/users/Eirik0/gists{/gist_id}","starred_url":"https://api.github.com/users/Eirik0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eirik0/subscriptions","organizations_url":"https://api.github.com/users/Eirik0/orgs","repos_url":"https://api.github.com/users/Eirik0/repos","events_url":"https://api.github.com/users/Eirik0/events{/privacy}","received_events_url":"https://api.github.com/users/Eirik0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":336611909,"node_id":"MDU6TGFiZWwzMzY2MTE5MDk=","url":"https://api.github.com/repos/zcash/zcash/labels/RPC%20interface","name":"RPC interface","color":"ffd0b7","default":false},{"id":546339364,"node_id":"MDU6TGFiZWw1NDYzMzkzNjQ=","url":"https://api.github.com/repos/zcash/zcash/labels/Sapling","name":"Sapling","color":"0e8a16","default":false},{"id":156615475,"node_id":"MDU6TGFiZWwxNTY2MTU0NzU=","url":"https://api.github.com/repos/zcash/zcash/labels/wallet","name":"wallet","color":"006b75","default":false}],"milestone":{"url":"https://api.github.com/repos/zcash/zcash/milestones/74","html_url":"https://github.com/zcash/zcash/milestone/74","labels_url":"https://api.github.com/repos/zcash/zcash/milestones/74/labels","id":3126625,"node_id":"MDk6TWlsZXN0b25lMzEyNjYyNQ==","number":74,"title":"v2.0.1","description":"","creator":{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":4,"state":"open","created_at":"2018-02-19T11:41:42Z","updated_at":"2018-08-24T19:41:20Z","due_on":"2018-09-24T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zcash/zcash/pulls/3436/commits","review_comments_url":"https://api.github.com/repos/zcash/zcash/pulls/3436/comments","review_comment_url":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zcash/zcash/issues/3436/comments","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/d316992f554d3233adff15f6d69d802fb72e0a23","head":{"label":"str4d:3214-z_getbalance","ref":"3214-z_getbalance","sha":"d316992f554d3233adff15f6d69d802fb72e0a23","user":{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"repo":{"id":52462432,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQ2MjQzMg==","name":"zcash","full_name":"str4d/zcash","owner":{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/str4d/zcash","description":"zcash","fork":true,"url":"https://api.github.com/repos/str4d/zcash","forks_url":"https://api.github.com/repos/str4d/zcash/forks","keys_url":"https://api.github.com/repos/str4d/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/str4d/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/str4d/zcash/teams","hooks_url":"https://api.github.com/repos/str4d/zcash/hooks","issue_events_url":"https://api.github.com/repos/str4d/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/str4d/zcash/events","assignees_url":"https://api.github.com/repos/str4d/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/str4d/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/str4d/zcash/tags","blobs_url":"https://api.github.com/repos/str4d/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/str4d/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/str4d/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/str4d/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/str4d/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/str4d/zcash/languages","stargazers_url":"https://api.github.com/repos/str4d/zcash/stargazers","contributors_url":"https://api.github.com/repos/str4d/zcash/contributors","subscribers_url":"https://api.github.com/repos/str4d/zcash/subscribers","subscription_url":"https://api.github.com/repos/str4d/zcash/subscription","commits_url":"https://api.github.com/repos/str4d/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/str4d/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/str4d/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/str4d/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/str4d/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/str4d/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/str4d/zcash/merges","archive_url":"https://api.github.com/repos/str4d/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/str4d/zcash/downloads","issues_url":"https://api.github.com/repos/str4d/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/str4d/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/str4d/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/str4d/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/str4d/zcash/labels{/name}","releases_url":"https://api.github.com/repos/str4d/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/str4d/zcash/deployments","created_at":"2016-02-24T17:50:40Z","updated_at":"2018-07-11T04:40:48Z","pushed_at":"2018-08-22T11:33:57Z","git_url":"git://github.com/str4d/zcash.git","ssh_url":"git@github.com:str4d/zcash.git","clone_url":"https://github.com/str4d/zcash.git","svn_url":"https://github.com/str4d/zcash","homepage":"https://z.cash/","size":74374,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":0,"watchers":29,"default_branch":"master"}},"base":{"label":"zcash:master","ref":"master","sha":"20f87bc226ea27ec5023ab4a182f566a84f48d3e","user":{"login":"zcash","id":16122764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTIyNzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"repo":{"id":26987049,"node_id":"MDEwOlJlcG9zaXRvcnkyNjk4NzA0OQ==","name":"zcash","full_name":"zcash/zcash","owner":{"login":"zcash","id":16122764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTIyNzY0","avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zcash/zcash","description":"Zcash - Internet Money","fork":false,"url":"https://api.github.com/repos/zcash/zcash","forks_url":"https://api.github.com/repos/zcash/zcash/forks","keys_url":"https://api.github.com/repos/zcash/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zcash/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zcash/zcash/teams","hooks_url":"https://api.github.com/repos/zcash/zcash/hooks","issue_events_url":"https://api.github.com/repos/zcash/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/zcash/zcash/events","assignees_url":"https://api.github.com/repos/zcash/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/zcash/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/zcash/zcash/tags","blobs_url":"https://api.github.com/repos/zcash/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zcash/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zcash/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/zcash/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/zcash/zcash/languages","stargazers_url":"https://api.github.com/repos/zcash/zcash/stargazers","contributors_url":"https://api.github.com/repos/zcash/zcash/contributors","subscribers_url":"https://api.github.com/repos/zcash/zcash/subscribers","subscription_url":"https://api.github.com/repos/zcash/zcash/subscription","commits_url":"https://api.github.com/repos/zcash/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/zcash/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/zcash/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/zcash/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/zcash/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/zcash/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zcash/zcash/merges","archive_url":"https://api.github.com/repos/zcash/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zcash/zcash/downloads","issues_url":"https://api.github.com/repos/zcash/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/zcash/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/zcash/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/zcash/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zcash/zcash/labels{/name}","releases_url":"https://api.github.com/repos/zcash/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/zcash/zcash/deployments","created_at":"2014-11-22T03:13:10Z","updated_at":"2018-08-24T19:41:12Z","pushed_at":"2018-08-24T18:25:09Z","git_url":"git://github.com/zcash/zcash.git","ssh_url":"git@github.com:zcash/zcash.git","clone_url":"https://github.com/zcash/zcash.git","svn_url":"https://github.com/zcash/zcash","homepage":"https://z.cash/","size":64606,"stargazers_count":3808,"watchers_count":3808,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1298,"mirror_url":null,"archived":false,"open_issues_count":810,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1298,"open_issues":810,"watchers":3808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3436"},"html":{"href":"https://github.com/zcash/zcash/pull/3436"},"issue":{"href":"https://api.github.com/repos/zcash/zcash/issues/3436"},"comments":{"href":"https://api.github.com/repos/zcash/zcash/issues/3436/comments"},"review_comments":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3436/comments"},"review_comment":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3436/commits"},"statuses":{"href":"https://api.github.com/repos/zcash/zcash/statuses/d316992f554d3233adff15f6d69d802fb72e0a23"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arielgabizon"}}