{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/189843013","pull_request_review_id":122097186,"id":189843013,"diff_hunk":"@@ -386,17 +380,24 @@ void L1TStage2CaloLayer2Offline::fillJets(edm::Event const& e, const unsigned in\n   double recoEta = leadingRecoJet.eta();\n   double recoPhi = leadingRecoJet.phi();\n \n-  double l1Et = closestL1Jet.et();\n-  double l1Eta = closestL1Jet.eta();\n-  double l1Phi = closestL1Jet.phi();\n+  double l1Et = foundMatch ? closestL1Jet.et() : 0;\n+  double l1Eta = foundMatch ? closestL1Jet.eta() : 9999;\n+  double l1Phi = foundMatch ? closestL1Jet.phi() : 9999;\n \n   // if no reco value, relative resolution does not make sense -> sort to overflow\n   double outOfBounds = 9999;\n   double resolutionEt = recoEt > 0 ? (l1Et - recoEt) / recoEt : outOfBounds;\n-  double resolutionEta = std::abs(recoEta) > 0 ? (l1Eta - recoEta) / recoEta : outOfBounds;\n-  double resolutionPhi = std::abs(recoPhi) > 0 ? (l1Phi - recoPhi) / recoPhi : outOfBounds;\n+  double resolutionEta = l1Eta - recoEta;\n+  double resolutionPhi = l1Phi - recoPhi;\n \n   using namespace dqmoffline::l1t;\n+  // fill efficiencies regardless of matched jet found\n+  fillJetEfficiencies(recoEt, l1Et, recoEta);\n+  // don't fill anything else if no matched L1 jet is found\n+  if (!foundMatch){\n+    return;\n+  }\n+\n   // eta\n   fill2DWithinLimits(h_L1JetEtavsCaloJetEta_, recoEta, l1Eta);\n   fillWithinLimits(h_resolutionJetEta_, resolutionEta);","path":"DQMOffline/L1Trigger/src/L1TStage2CaloLayer2Offline.cc","position":58,"original_position":58,"commit_id":"21a416bb7cc949ebc64562afb82eb57340cdc3d6","original_commit_id":"21a416bb7cc949ebc64562afb82eb57340cdc3d6","user":{"login":"kreczko","id":1213276,"avatar_url":"https://avatars3.githubusercontent.com/u/1213276?v=4","gravatar_id":"","url":"https://api.github.com/users/kreczko","html_url":"https://github.com/kreczko","followers_url":"https://api.github.com/users/kreczko/followers","following_url":"https://api.github.com/users/kreczko/following{/other_user}","gists_url":"https://api.github.com/users/kreczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kreczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreczko/subscriptions","organizations_url":"https://api.github.com/users/kreczko/orgs","repos_url":"https://api.github.com/users/kreczko/repos","events_url":"https://api.github.com/users/kreczko/events{/privacy}","received_events_url":"https://api.github.com/users/kreczko/received_events","type":"User","site_admin":false},"body":"Control plots as in `h_controlPlots_` or also `h_L1JetEtavsCaloJetEta_`, `h_resolutionJetEta_`, etc?","created_at":"2018-05-22T09:57:20Z","updated_at":"2018-05-22T09:57:20Z","html_url":"https://github.com/cms-sw/cmssw/pull/23269#discussion_r189843013","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23269","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/189843013"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23269#discussion_r189843013"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23269"}},"in_reply_to_id":189835265},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23269","id":189393933,"html_url":"https://github.com/cms-sw/cmssw/pull/23269","diff_url":"https://github.com/cms-sw/cmssw/pull/23269.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/23269.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23269","number":23269,"state":"open","locked":false,"title":"[L1T][DQMOffline] Fixes for L1T jet DQMOffline","user":{"login":"kreczko","id":1213276,"avatar_url":"https://avatars3.githubusercontent.com/u/1213276?v=4","gravatar_id":"","url":"https://api.github.com/users/kreczko","html_url":"https://github.com/kreczko","followers_url":"https://api.github.com/users/kreczko/followers","following_url":"https://api.github.com/users/kreczko/following{/other_user}","gists_url":"https://api.github.com/users/kreczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kreczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreczko/subscriptions","organizations_url":"https://api.github.com/users/kreczko/orgs","repos_url":"https://api.github.com/users/kreczko/repos","events_url":"https://api.github.com/users/kreczko/events{/privacy}","received_events_url":"https://api.github.com/users/kreczko/received_events","type":"User","site_admin":false},"body":"Partly fixes https://its.cern.ch/jira/projects/CMSLITDPG/issues/CMSLITDPG-588\r\n\r\n* Drop “events” y axis label for efficiency plots.\r\n* Phi resolution plots should not show (phi-phi_offline)/phi_offline but phi-phi_offline only.\r\n* Eta resolution plots should not show (eta-eta_offline)/eta_offline but eta-eta_offline only.\r\n* fill the efficiencies even if no a matched jet is found. \r\n* `currentDeltaR > minDeltaR`&rarr; `currentDeltaR >= minDeltaR`","created_at":"2018-05-21T14:24:21Z","updated_at":"2018-05-22T09:57:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0d0bea148a2632939992b96e15bab27755d3022","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":52820549,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04","default":false},{"id":52820587,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/l1-pending","name":"l1-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":52,"closed_issues":350,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-05-22T08:33:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23269/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23269/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23269/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/21a416bb7cc949ebc64562afb82eb57340cdc3d6","head":{"label":"kreczko:kreczko-issue-CMSLITDPG-588","ref":"kreczko-issue-CMSLITDPG-588","sha":"21a416bb7cc949ebc64562afb82eb57340cdc3d6","user":{"login":"kreczko","id":1213276,"avatar_url":"https://avatars3.githubusercontent.com/u/1213276?v=4","gravatar_id":"","url":"https://api.github.com/users/kreczko","html_url":"https://github.com/kreczko","followers_url":"https://api.github.com/users/kreczko/followers","following_url":"https://api.github.com/users/kreczko/following{/other_user}","gists_url":"https://api.github.com/users/kreczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kreczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreczko/subscriptions","organizations_url":"https://api.github.com/users/kreczko/orgs","repos_url":"https://api.github.com/users/kreczko/repos","events_url":"https://api.github.com/users/kreczko/events{/privacy}","received_events_url":"https://api.github.com/users/kreczko/received_events","type":"User","site_admin":false},"repo":{"id":25977827,"name":"cmssw","full_name":"kreczko/cmssw","owner":{"login":"kreczko","id":1213276,"avatar_url":"https://avatars3.githubusercontent.com/u/1213276?v=4","gravatar_id":"","url":"https://api.github.com/users/kreczko","html_url":"https://github.com/kreczko","followers_url":"https://api.github.com/users/kreczko/followers","following_url":"https://api.github.com/users/kreczko/following{/other_user}","gists_url":"https://api.github.com/users/kreczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kreczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreczko/subscriptions","organizations_url":"https://api.github.com/users/kreczko/orgs","repos_url":"https://api.github.com/users/kreczko/repos","events_url":"https://api.github.com/users/kreczko/events{/privacy}","received_events_url":"https://api.github.com/users/kreczko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kreczko/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/kreczko/cmssw","forks_url":"https://api.github.com/repos/kreczko/cmssw/forks","keys_url":"https://api.github.com/repos/kreczko/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kreczko/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kreczko/cmssw/teams","hooks_url":"https://api.github.com/repos/kreczko/cmssw/hooks","issue_events_url":"https://api.github.com/repos/kreczko/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/kreczko/cmssw/events","assignees_url":"https://api.github.com/repos/kreczko/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/kreczko/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/kreczko/cmssw/tags","blobs_url":"https://api.github.com/repos/kreczko/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kreczko/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kreczko/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/kreczko/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kreczko/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/kreczko/cmssw/languages","stargazers_url":"https://api.github.com/repos/kreczko/cmssw/stargazers","contributors_url":"https://api.github.com/repos/kreczko/cmssw/contributors","subscribers_url":"https://api.github.com/repos/kreczko/cmssw/subscribers","subscription_url":"https://api.github.com/repos/kreczko/cmssw/subscription","commits_url":"https://api.github.com/repos/kreczko/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/kreczko/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/kreczko/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/kreczko/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/kreczko/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/kreczko/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kreczko/cmssw/merges","archive_url":"https://api.github.com/repos/kreczko/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kreczko/cmssw/downloads","issues_url":"https://api.github.com/repos/kreczko/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/kreczko/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/kreczko/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/kreczko/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kreczko/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/kreczko/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/kreczko/cmssw/deployments","created_at":"2014-10-30T15:43:32Z","updated_at":"2014-11-25T17:04:53Z","pushed_at":"2018-05-21T14:20:20Z","git_url":"git://github.com/kreczko/cmssw.git","ssh_url":"git@github.com:kreczko/cmssw.git","clone_url":"https://github.com/kreczko/cmssw.git","svn_url":"https://github.com/kreczko/cmssw","homepage":"cms-sw.github.io/cmssw","size":865010,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_3_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"147c2034abf2ec43e97e7e55e5224a71b29ace84","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-05-22T08:33:48Z","pushed_at":"2018-05-22T09:49:38Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1002581,"stargazers_count":552,"watchers_count":552,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2572,"mirror_url":null,"archived":false,"open_issues_count":431,"license":null,"forks":2572,"open_issues":431,"watchers":552,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23269"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23269"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23269"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23269/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23269/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23269/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/21a416bb7cc949ebc64562afb82eb57340cdc3d6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kreczko"}}