{"action":"created","issue":{"url":"https://api.github.com/repos/emotion-js/emotion/issues/576","repository_url":"https://api.github.com/repos/emotion-js/emotion","labels_url":"https://api.github.com/repos/emotion-js/emotion/issues/576/labels{/name}","comments_url":"https://api.github.com/repos/emotion-js/emotion/issues/576/comments","events_url":"https://api.github.com/repos/emotion-js/emotion/issues/576/events","html_url":"https://github.com/emotion-js/emotion/pull/576","id":298103711,"number":576,"title":"Fix links on both github and website","user":{"login":"azizhk","id":5094296,"avatar_url":"https://avatars1.githubusercontent.com/u/5094296?v=4","gravatar_id":"","url":"https://api.github.com/users/azizhk","html_url":"https://github.com/azizhk","followers_url":"https://api.github.com/users/azizhk/followers","following_url":"https://api.github.com/users/azizhk/following{/other_user}","gists_url":"https://api.github.com/users/azizhk/gists{/gist_id}","starred_url":"https://api.github.com/users/azizhk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azizhk/subscriptions","organizations_url":"https://api.github.com/users/azizhk/orgs","repos_url":"https://api.github.com/users/azizhk/repos","events_url":"https://api.github.com/users/azizhk/events{/privacy}","received_events_url":"https://api.github.com/users/azizhk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-18T17:53:42Z","updated_at":"2018-02-19T07:29:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/emotion-js/emotion/pulls/576","html_url":"https://github.com/emotion-js/emotion/pull/576","diff_url":"https://github.com/emotion-js/emotion/pull/576.diff","patch_url":"https://github.com/emotion-js/emotion/pull/576.patch"},"body":"A lot of links were broken on the website when trying to open them in a new tab. This is because they were relative urls like `docs/css`, so if you were on a pages like `https://emotion.sh/docs/install` then the url would become `https://emotion.sh/docs/docs/css`. Double `/docs/`\r\nThe urls were working if opened in the same tab because the gatsby-plugin-catch-links was somehow catching them correctly.\r\n\r\nI ran http://www.brokenlinkcheck.com/ on https://emotion.sh and got the following 404s.\r\n<img width=\"657\" alt=\"screen shot 2018-02-18 at 5 27 02 pm\" src=\"https://user-images.githubusercontent.com/5094296/36354974-00bb2e06-1502-11e8-9b28-e497f0970cd9.png\">\r\n\r\nMy approach was that the links should work on github as well as on the website.\r\nLike if you go to https://github.com/azizhk/emotion/blob/1bf4eba72a8e11660cb4dc7b7a4ed717afae9b58/docs/babel.md and click on the last link then it should work and take you to the corresponding markdown file in the repository."},"comment":{"url":"https://api.github.com/repos/emotion-js/emotion/issues/comments/366608079","html_url":"https://github.com/emotion-js/emotion/pull/576#issuecomment-366608079","issue_url":"https://api.github.com/repos/emotion-js/emotion/issues/576","id":366608079,"user":{"login":"mitchellhamilton","id":11481355,"avatar_url":"https://avatars1.githubusercontent.com/u/11481355?v=4","gravatar_id":"","url":"https://api.github.com/users/mitchellhamilton","html_url":"https://github.com/mitchellhamilton","followers_url":"https://api.github.com/users/mitchellhamilton/followers","following_url":"https://api.github.com/users/mitchellhamilton/following{/other_user}","gists_url":"https://api.github.com/users/mitchellhamilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellhamilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellhamilton/subscriptions","organizations_url":"https://api.github.com/users/mitchellhamilton/orgs","repos_url":"https://api.github.com/users/mitchellhamilton/repos","events_url":"https://api.github.com/users/mitchellhamilton/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellhamilton/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T07:29:40Z","updated_at":"2018-02-19T07:29:40Z","author_association":"OWNER","body":"@azizhk Yep, make that change."}}
{"actor":{"display_login":"mitchellhamilton"}}