{"action":"created","issue":{"url":"https://api.github.com/repos/mlflow/mlflow/issues/276","repository_url":"https://api.github.com/repos/mlflow/mlflow","labels_url":"https://api.github.com/repos/mlflow/mlflow/issues/276/labels{/name}","comments_url":"https://api.github.com/repos/mlflow/mlflow/issues/276/comments","events_url":"https://api.github.com/repos/mlflow/mlflow/issues/276/events","html_url":"https://github.com/mlflow/mlflow/pull/276","id":349245515,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDA4Mjkx","number":276,"title":"project run should not add git version if the uri is local","user":{"login":"adrian555","id":10642337,"node_id":"MDQ6VXNlcjEwNjQyMzM3","avatar_url":"https://avatars2.githubusercontent.com/u/10642337?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian555","html_url":"https://github.com/adrian555","followers_url":"https://api.github.com/users/adrian555/followers","following_url":"https://api.github.com/users/adrian555/following{/other_user}","gists_url":"https://api.github.com/users/adrian555/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian555/subscriptions","organizations_url":"https://api.github.com/users/adrian555/orgs","repos_url":"https://api.github.com/users/adrian555/repos","events_url":"https://api.github.com/users/adrian555/events{/privacy}","received_events_url":"https://api.github.com/users/adrian555/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-09T18:45:40Z","updated_at":"2018-08-12T04:28:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mlflow/mlflow/pulls/276","html_url":"https://github.com/mlflow/mlflow/pull/276","diff_url":"https://github.com/mlflow/mlflow/pull/276.diff","patch_url":"https://github.com/mlflow/mlflow/pull/276.patch"},"body":"Toward https://github.com/mlflow/mlflow/issues/275\r\n\r\n`mlflow.projects._create_run` calls `tracking._get_git_commit` and tries to add a git version for a project. When it happens that the MLproject is inside the path from a git project, a version is attached to the project, even when the project is run as local uri.\r\n\r\nFix is to add the _is_local_uri() check so that it is according to what `mlflow.projects._fetch_project` expects."},"comment":{"url":"https://api.github.com/repos/mlflow/mlflow/issues/comments/412317906","html_url":"https://github.com/mlflow/mlflow/pull/276#issuecomment-412317906","issue_url":"https://api.github.com/repos/mlflow/mlflow/issues/276","id":412317906,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjMxNzkwNg==","user":{"login":"mateiz","id":228859,"node_id":"MDQ6VXNlcjIyODg1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/228859?v=4","gravatar_id":"","url":"https://api.github.com/users/mateiz","html_url":"https://github.com/mateiz","followers_url":"https://api.github.com/users/mateiz/followers","following_url":"https://api.github.com/users/mateiz/following{/other_user}","gists_url":"https://api.github.com/users/mateiz/gists{/gist_id}","starred_url":"https://api.github.com/users/mateiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateiz/subscriptions","organizations_url":"https://api.github.com/users/mateiz/orgs","repos_url":"https://api.github.com/users/mateiz/repos","events_url":"https://api.github.com/users/mateiz/events{/privacy}","received_events_url":"https://api.github.com/users/mateiz/received_events","type":"User","site_admin":false},"created_at":"2018-08-12T04:28:04Z","updated_at":"2018-08-12T04:28:04Z","author_association":"CONTRIBUTOR","body":"I think that in this case, it makes sense to fix how we display the `mlflow run` command for such runs in the UI, instead of not logging a version. I agree that the current command is wrong. It should actually be possible to have a command that specifies this is a subdirectory of a Git repo, because we now have a syntax for that (`mlflow run gitrepo#path/to/directory`). Or if that doesn't work for some reason, we can also just not show the command. But it's better to record the version and what we ran just to tell the user what happened."}}
{"actor":{"display_login":"mateiz"}}