{"action":"created","issue":{"url":"https://api.github.com/repos/karllark/dust_extinction/issues/72","repository_url":"https://api.github.com/repos/karllark/dust_extinction","labels_url":"https://api.github.com/repos/karllark/dust_extinction/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/karllark/dust_extinction/issues/72/comments","events_url":"https://api.github.com/repos/karllark/dust_extinction/issues/72/events","html_url":"https://github.com/karllark/dust_extinction/issues/72","id":326674338,"node_id":"MDU6SXNzdWUzMjY2NzQzMzg=","number":72,"title":"Astropy Affiliated Package Review","user":{"login":"eteq","id":346587,"node_id":"MDQ6VXNlcjM0NjU4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/346587?v=4","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-25T21:54:27Z","updated_at":"2018-06-04T11:36:58Z","closed_at":"2018-05-26T13:46:32Z","author_association":"NONE","body":"This package has been reviewed by the Astropy coordination committee for inclusion in the Astropy affiliated package ecosystem. \r\n\r\nWe have adopted a review process for affiliated package that includes assigning quantitative ‘scores’ (red/orange/green) for different categories of review. You can read up more about this process [here](https://docs.google.com/document/d/15PJf2PROXMa7xwTDvWnjXB_9KNuO2Ia4_kkxJ7MPazE/edit). (This document, currently in Google Docs, will be moved to the documentation in the near future.) For each of the categories below we have listed the score and have included some comments when the score is not green.\r\n\r\n<table>\r\n<tr><td><b>Functionality/Scope</b></td><td><a href=\"https://docs.google.com/document/d/e/2PACX-1vRXvsE3m8BBo6qE5pqUMfHAfHCDgRkOy4TumaHAaAt1jXMb_jHkNFFT1ddaTHnuzlP11dZxpQ_fe_BZ/pub#h.pch9wiwetm2l\"><img src=\"https://img.shields.io/badge/Functionality-Specialized%20package-brightgreen.svg\" alt=\"Specialized%20package\"></a></td></tr>\r\n\r\n<tr><td colspan=2><i>Strictly speaking this is generalized functionality because of course dust extinction is critical for pretty much all extragalactic astronomy.  But this particular *package* is primarily for the \"expert\" - even though some of its functionality is general I think it's best thought of as having a spcialist \"target audience\"?</i></td></tr>\r\n\r\n<tr><td><b>Integration with Astropy ecosystem</b></td><td><a href=\"https://docs.google.com/document/d/e/2PACX-1vRXvsE3m8BBo6qE5pqUMfHAfHCDgRkOy4TumaHAaAt1jXMb_jHkNFFT1ddaTHnuzlP11dZxpQ_fe_BZ/pub#h.lizp0k629jgg\"><img src=\"https://img.shields.io/badge/Astropy%20integration-Good-brightgreen.svg\" alt=\"Good\"></a></td></tr>\r\n\r\n<tr><td colspan=2><i>No further comments</i></td></tr>\r\n\r\n<tr><td><b>Documentation</b></td><td><a href=\"https://docs.google.com/document/d/e/2PACX-1vRXvsE3m8BBo6qE5pqUMfHAfHCDgRkOy4TumaHAaAt1jXMb_jHkNFFT1ddaTHnuzlP11dZxpQ_fe_BZ/pub#h.prawoqxdnwj5\"><img src=\"https://img.shields.io/badge/Docs-Partial-orange.svg\" alt=\"Partial\"></a></td></tr>\r\n\r\n<tr><td colspan=2><i>Sort of borderline between orange and green.  The examples/API are excellent, but the thing that is missing is a clear motivation/science background.  Obviously it's out-of-scope to write a ton on this, but because of the complexity of the topic, a bit more motivation of the *bounds* of this package and the intended user audience for various pieces might be helpful. </i></td></tr>\r\n\r\n<tr><td><b>Testing</b></td><td><a href=\"https://docs.google.com/document/d/e/2PACX-1vRXvsE3m8BBo6qE5pqUMfHAfHCDgRkOy4TumaHAaAt1jXMb_jHkNFFT1ddaTHnuzlP11dZxpQ_fe_BZ/pub#h.8dots8fmtpvp\"><img src=\"https://img.shields.io/badge/Tests-Good-brightgreen.svg\" alt=\"Good\"></a></td></tr>\r\n\r\n<tr><td colspan=2><i>No further comments</i></td></tr>\r\n\r\n<tr><td><b>Development status</b></td><td><a href=\"https://docs.google.com/document/d/e/2PACX-1vRXvsE3m8BBo6qE5pqUMfHAfHCDgRkOy4TumaHAaAt1jXMb_jHkNFFT1ddaTHnuzlP11dZxpQ_fe_BZ/pub#h.zh2jxv4intgn\"><img src=\"https://img.shields.io/badge/Development-Good-brightgreen.svg\" alt=\"Good\"></a></td></tr>\r\n\r\n<tr><td colspan=2><i>No further comments</i></td></tr>\r\n\r\n<tr><td><b>Python 3 compatibility</b></td><td><a href=\"https://docs.google.com/document/d/e/2PACX-1vRXvsE3m8BBo6qE5pqUMfHAfHCDgRkOy4TumaHAaAt1jXMb_jHkNFFT1ddaTHnuzlP11dZxpQ_fe_BZ/pub#h.9tur152fuipe\"><img src=\"https://img.shields.io/badge/Python%203-Good-brightgreen.svg\" alt=\"Good\"></a></td></tr>\r\n\r\n<tr><td colspan=2><i>No further comments</i></td></tr>\r\n\r\n</table>\r\n\r\n**Other comments**\r\n\r\nA great example of use of the package-template to speed development of a fundamentally science-based code.\r\n\r\n\r\n**Summary/Decision**: Things are looking good! There are a few areas where things could be improved as described above. However, these aren't critical and this package still meets the criteria to be an affiliated package. Keep up the good work!\r\n\r\nIf you agree with the above review, please feel free to close this issue. If you have any follow-up questions or disagree with any of the comments above, leave a comment and we can discuss it here. At any point in future you can request a re-review of the package if you believe any of the scores should be updated - contact the coordination committee, and we’ll do a new review. Note that we are in the process of redesigning the http://affiliated.astropy.org page to show these scores (but not the comments). Finally, please keep the title of this issue as-is (“Astropy Affiliated Package Review”) to make it easy to search for affiliated package reviews in future."},"comment":{"url":"https://api.github.com/repos/karllark/dust_extinction/issues/comments/394324221","html_url":"https://github.com/karllark/dust_extinction/issues/72#issuecomment-394324221","issue_url":"https://api.github.com/repos/karllark/dust_extinction/issues/72","id":394324221,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDMyNDIyMQ==","user":{"login":"karllark","id":1554536,"node_id":"MDQ6VXNlcjE1NTQ1MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1554536?v=4","gravatar_id":"","url":"https://api.github.com/users/karllark","html_url":"https://github.com/karllark","followers_url":"https://api.github.com/users/karllark/followers","following_url":"https://api.github.com/users/karllark/following{/other_user}","gists_url":"https://api.github.com/users/karllark/gists{/gist_id}","starred_url":"https://api.github.com/users/karllark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karllark/subscriptions","organizations_url":"https://api.github.com/users/karllark/orgs","repos_url":"https://api.github.com/users/karllark/repos","events_url":"https://api.github.com/users/karllark/events{/privacy}","received_events_url":"https://api.github.com/users/karllark/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T11:36:58Z","updated_at":"2018-06-04T11:36:58Z","author_association":"OWNER","body":"My goal is that the target audience is both the specialized user and the general user.  At least that is what I'd like.  I'm the specialized user, so need more feedback from general users on what is needed.   You've given a general user idea (spec1xd related code) and I have thought of others (e.g., the equivalent of the idl code ccm_unred.pro).  Need to document all such ideas and write the appropriate code.  \r\n\r\nI'm fine with either designation for the affiliated docs.  But this does raise the question, is it possible to choose both?  :-)"}}
{"actor":{"display_login":"karllark"}}